gdb/ChangeLog

   1 2019-12-11  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-win.c (tui_set_win_height_command): Call
   4         tui_adjust_window_height.
   5         (tui_adjust_win_heights, new_height_ok): Remove.
   6         * tui/tui-layout.h (tui_adjust_window_height): Declare.
   7         * tui/tui-layout.c (tui_adjust_window_height): New function.
   8
   9 2019-12-11  Tom Tromey  <tom@tromey.com>
  10
  11         * tui/tui-win.c (tui_resize_all): Remove code, call
  12         tui_apply_current_layout.
  13
  14 2019-12-11  Tom Tromey  <tom@tromey.com>
  15
  16         * tui/tui-layout.h (tui_apply_current_layout): Declare.
  17         * tui/tui-layout.c (standard_layouts, applied_layout): New
  18         globals.
  19         (tui_apply_current_layout): New function.
  20         (show_layout): Set applied_layout.  Call
  21         tui_apply_current_layout.
  22         (show_source_command, show_disasm_command)
  23         (show_source_disasm_command, show_data)
  24         (show_source_or_disasm_and_command): Remove.
  25         (initialize_layouts): New function.
  26         (_initialize_tui_layout): Call initialize_layouts.
  27
  28 2019-12-11  Tom Tromey  <tom@tromey.com>
  29
  30         * tui/tui-layout.h (class tui_layout_base)
  31         (class tui_layout_window, class tui_layout_split): New.
  32         * tui/tui-layout.c (tui_get_window_by_name)
  33         (tui_layout_window::clone, tui_layout_window::apply)
  34         (tui_layout_window::get_sizes, tui_layout_window::add_split)
  35         (tui_layout_split::add_window, tui_layout_split::clone)
  36         (tui_layout_split::get_sizes)
  37         (tui_layout_split::set_weights_from_heights)
  38         (tui_layout_split::adjust_size, tui_layout_split::apply): New
  39         functions.
  40         (tui_layout_split::add_split, tui_layout_split::add_split)
  41         (tui_layout_split::set_weights_from_heights)
  42         (tui_layout_split::set_weights_from_heights): New functions.
  43
  44 2019-12-11  Tom Tromey  <tom@tromey.com>
  45
  46         * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
  47         * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
  48         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
  49         * tui/tui-data.h (struct tui_point): Remove.
  50         (struct tui_gen_win_info) <origin>: Remove.
  51         <x, y>: New fields.
  52         * tui/tui-command.c (tui_cmd_window::resize): Update.
  53
  54 2019-12-11  Tom Tromey  <tom@tromey.com>
  55
  56         * tui/tui-stack.h (struct tui_locator_window) <min_height>:
  57         Implement.
  58         * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
  59         Implement.
  60         * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
  61         method.
  62         (struct tui_win_info) <min_height>: Implement.
  63
  64 2019-12-11  Tom Tromey  <tom@tromey.com>
  65
  66         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
  67         (struct tui_win_info) <can_box>: Update.
  68
  69 2019-12-11  Tom Tromey  <tom@tromey.com>
  70
  71         * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
  72         method.
  73         * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
  74         method.
  75         * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
  76         method.
  77         (struct tui_win_info) <max_height>: Now override.
  78
  79 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
  80
  81         * NEWS: Create a new section for the next release branch.
  82         Rename the section of the current branch, now that it has
  83         been cut.
  84
  85 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
  86
  87         GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
  88         * version.in: Bump version to 10.0.50.DATE-git.
  89
  90 2019-12-11  Tom Tromey  <tromey@adacore.com>
  91
  92         PR build/25268:
  93         * gdbsupport/thread-pool.c (set_thread_name): New function.
  94         (thread_pool::set_thread_count): Don't call pthread_setname_np.
  95         (thread_pool::thread_function): Call set_thread_name.
  96
  97 2019-12-11  Tom Tromey  <tromey@adacore.com>
  98
  99         * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
 100         bfd_get_signed_8.
 101
 102 2019-12-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 103
 104         * NEWS: Document -raw-values option and the related setting commands.
 105         * printcmd.c (print_command_parse_format): Do not set opts->raw off,
 106         only set it on when /r is given.
 107         * valprint.c (value_print_option_defs): New element raw-values.
 108         * Makefile.in: Add the new file.
 109
 110 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 111
 112         * gdbsupport/safe-strerror.c: Supress the unused function warning
 113         for select_strerror_r.
 114
 115 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 116
 117         * config.in: Regenerate.
 118         * configure: Regenerate.
 119         * gdbsupport/agent.c (gdb_connect_sync_socket): Call
 120         safe_strerror instead of strerror.
 121         * gdbsupport/common.m4: Don't check for strerror.
 122         * gdbsupport/safe-strerror.c: Support both the glibc version
 123         of strerror_r and the XSI version.
 124
 125 2019-12-10  Tom Tromey  <tromey@adacore.com>
 126
 127         * ada-typeprint.c (print_choices): Use a single "?".
 128         (print_variant_part): Print "?" if the discriminant name
 129         is not known.
 130
 131 2019-12-10  George Barrett  <bob@bob131.so>
 132
 133         Fix scripted probe breakpoints.
 134         * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
 135         declaration forward.
 136         (breakpoint_ops_for_event_location_type)
 137         (breakpoint_ops_for_event_location): Add function definitions.
 138         (break_command_1, trace_command): Use
 139         breakpoint_ops_for_event_location.
 140         * breakpoint.h (breakpoint_ops_for_event_location): Add function
 141         declarations.
 142         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
 143         breakpoint_ops_for_event_location.
 144         * python/py-breakpoint.c (bppy_init): Use
 145         breakpoint_ops_for_event_location.
 146
 147 2019-12-09  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 148
 149         * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
 150         when ranking an lvalue argument for an rvalue parameter.
 151
 152 2019-12-08  Wataru Ashihara  <wataash@wataash.com>
 153
 154         * darwin-nat.c (darwin_nat_target::create_inferior): Fix
 155         template argument for scoped_restore_tmpl from bool to int.
 156
 157 2019-12-07  Keith Seitz  <keiths@redhat.com>
 158
 159         * build-id.c (build_id_bfd_get): Permit bfd_core, too.
 160         (build_id_to_debug_bfd): Make static, rewriting to use
 161         build_id_to_bfd_suffix.
 162         (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
 163         adding `suffix' parameter. Append SUFFIX to file names
 164         when searching for matching files.
 165         (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
 166         (build_id_to_exec_bfd): Likewise.
 167         * build-id.h (build_id_to_debug_bfd): Clarify that function
 168         searches for BFD of debug info file.
 169         (build_id_to_exec_bfd): Declare.
 170         * corelow.c: Include build-id.h.
 171         (locate_exec_from_corefile_build_id): New function.
 172         (core_target_open): If no executable BFD is found,
 173         search for a core file BFD using build-id.
 174
 175 2019-12-06  Christian Biesinger  <cbiesinger@google.com>
 176
 177         * bcache.c: Put in namespace gdb.
 178         * bcache.h: Likewise.
 179         * gdbtypes.c (check_types_worklist): Update.
 180         (types_deeply_equal): Update.
 181         * macrotab.c (struct macro_table) <bcache>: Update.
 182         (new_macro_table): Update.
 183         * macrotab.h (struct bcache): Put this forward declaration
 184         inside namespace gdb.
 185         (new_macro_table): Update.
 186         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
 187         Update.
 188         <macro_cache>: Update.
 189         * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
 190
 191 2019-12-06  Tom de Vries  <tdevries@suse.de>
 192
 193         PR symtab/24971
 194         * block.c (best_symbol, better_symbol): New function.
 195         (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
 196         decl.
 197
 198 2019-12-06  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 199
 200         * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
 201         * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
 202         for ranking see-through reference cases.
 203
 204 2019-12-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 205         * stack.c (faas_command): Check a command is provided.
 206         * thread.c (taas_command, tfaas_command): Likewise.
 207
 208 2019-12-05  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 209         * inferior.c (prune_inferiors):  Only call delete_inferior,
 210         Do not modify the inferior list.
 211
 212 2019-12-05  Simon Marchi  <simon.marchi@polymtl.ca>
 213
 214         * c-exp.y: Update calls to lookup_typename,
 215         lookup_signed_typename and lookup_unsigned_typename.
 216         * c-lang.c (evaluate_subexp_c): Likewise.
 217         * cp-namespace.c (cp_lookup_symbol_imports_or_template):
 218         Likewise.
 219         * eval.c (binop_promote): Likewise.
 220         * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
 221         (lookup_unsigned_typename): Likewise.
 222         (lookup_signed_typename): Likewise.
 223         * gdbtypes.h (lookup_unsigned_typename): Likewise.
 224         (lookup_signed_typename): Likewise.
 225         (lookup_typename): Likewise.
 226         * guile/scm-type.c (tyscm_lookup_typename): Update calls to
 227         lookup_typename, lookup_signed_typename,
 228         lookup_unsigned_typename.
 229         * m2-exp.y: Likewise.
 230         * printcmd.c (printf_wide_c_string): Likewise.
 231         (ui_printf): Likewise.
 232         * python/py-type.c (typy_lookup_typename): Likewise.
 233         * python/py-xmethods.c (python_xmethod_worker::invoke):
 234         Likewise.
 235         * rust-exp.y: Likewise.
 236
 237 2019-12-04  Christian Biesinger  <cbiesinger@google.com>
 238
 239         * configure.nat (obsd64): Add missing files x86-nat.o and
 240         nat/x86-dregs.o.
 241
 242 2019-12-04  Tom Tromey  <tom@tromey.com>
 243
 244         * valprint.c (val_print_string): Use metadata_style.
 245         * go-valprint.c (print_go_string): Use metadata style.
 246         * p-valprint.c (pascal_object_print_static_field): Use metadata
 247         style.
 248         * cp-valprint.c (cp_print_static_field): Use metadata style.
 249
 250 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 251             Chris January  <chris.january@arm.com>
 252
 253         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
 254         tokens.
 255         (typebase): New patterns for complex, single/double precision, and
 256         single/double complex.
 257         (f77_keywords): Change token for complex keyword, and add single,
 258         double, and precision keywords.
 259
 260 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 261
 262         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
 263         "info io_registers".
 264
 265 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 266
 267         * regcache.c (cooked_read_test): Initialize thread list of
 268         mock_inferior.
 269
 270 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 271
 272         * aarch64-linux-tdep.c: Remove includes.
 273
 274 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 275
 276         * aarch64-tdep.c: Remove includes.
 277
 278 2019-12-04  Simon Marchi  <simon.marchi@efficios.com>
 279
 280         * filtered-iterator.h (filtered_iterator) <operator==,
 281         operator!=>: Compare wrapped iterators, not wrapped pointers.
 282         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 283         unittests/filtered_iterator-selftests.c.
 284         * unittests/filtered_iterator-selftests.c: New file.
 285
 286 2019-12-04  Tom Tromey  <tromey@adacore.com>
 287
 288         * gdbtypes.c (create_range_type): Inherit endianity
 289         from base type.
 290
 291 2019-12-04  Tom Tromey  <tromey@adacore.com>
 292
 293         * ada-lang.c (decode_constrained_packed_array)
 294         (ada_value_assign, value_assign_to_component): Update.
 295         * dwarf2loc.c (rw_pieced_value, access_memory)
 296         (dwarf2_compile_expr_to_ax): Update.
 297         * dwarf2read.c (dwarf2_add_field): Update.
 298         * eval.c (evaluate_subexp_standard): Update.
 299         * gdbarch.c, gdbarch.h: Rebuild.
 300         * gdbarch.sh (bits_big_endian): Remove.
 301         * gdbtypes.h (union field_location): Update comment.
 302         * target-descriptions.c (make_gdb_type): Update.
 303         * valarith.c (value_bit_index): Update.
 304         * value.c (struct value) <bitpos>: Update comment.
 305         (unpack_bits_as_long, modify_field): Update.
 306         * value.h (value_bitpos): Update comment.
 307
 308 2019-12-04  Tom Tromey  <tromey@adacore.com>
 309
 310         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
 311         endian-ness.
 312
 313 2019-12-04  Tom Tromey  <tromey@adacore.com>
 314
 315         * dwarf2read.c (dwarf2_init_float_type)
 316         (dwarf2_init_complex_target_type): Add byte_order parameter.
 317         (read_base_type): Compute byte order earlier.
 318         * gdbtypes.c (init_float_type): Add byte_order parameter.
 319         * gdbtypes.h (init_float_type): Add byte_order parameter.
 320
 321 2019-12-04  Tom Tromey  <tromey@adacore.com>
 322
 323         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
 324
 325 2019-12-04  Tom Tromey  <tromey@adacore.com>
 326
 327         * dwarf2read.c (process_structure_scope): Initialize
 328         "discr_offset".
 329
 330 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 331
 332         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
 333         add it into the search spec.
 334         (parse_max_results_option): New function.
 335         (mi_info_functions_or_variables): Parse -max-results flag and pass
 336         it to mi_symbol_info.
 337         (mi_cmd_symbol_info_modules): Likewise.
 338         (mi_cmd_symbol_info_types): Likewise.
 339         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
 340         return type to bool, change result container into a set, and don't
 341         add new results if we have enough already.
 342         (global_symbol_searcher::add_matching_msymbols): Change return
 343         type to bool, and don't add new results if we have enough already.
 344         (sort_search_symbols_remove_dups): Delete.
 345         (global_symbol_searcher::search): Early exit from search loop when
 346         we have enough results.  Use a std::set to collect the results
 347         from calling add_matching_symbols.
 348         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
 349         member function.
 350         (global_symbol_searcher) <m_max_search_results>: New member
 351         variable.
 352         (global_symbol_searcher) <add_matching_symbols>: Update header
 353         comment and change return type to bool.
 354         (global_symbol_searcher) <add_matching_msymbols>: Update header
 355         comment and change return type to bool.
 356
 357 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 358
 359         * symtab.c (symbol_search::compare_search_syms): Update header
 360         comment.
 361         (global_symbol_searcher::is_suitable_msymbol): New function.
 362         (global_symbol_searcher::expand_symtabs): New function.
 363         (global_symbol_searcher::add_matching_symbols): New function.
 364         (global_symbol_searcher::add_matching_msymbols): New function.
 365         (global_symbol_searcher::search): Move most of the content
 366         into the new functions above, and call them as needed.
 367         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
 368         function.
 369         (global_symbol_searcher) <add_matching_symbols>: New member
 370         function.
 371         (global_symbol_searcher) <add_matching_msymbols>: New member
 372         function.
 373         (global_symbol_searcher) <is_suitable_msymbol>: New member
 374         function.
 375
 376 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 377
 378         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
 379         -symbol-info-module-variables entries.
 380         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
 381         (mi_cmd_symbol_info_module_variables): Declare.
 382         * mi/mi-symbol-cmds.c
 383         (module_symbol_search_iterator): New typedef.
 384         (output_module_symbols_in_single_module_and_file): New function.
 385         (output_module_symbols_in_single_module): New function.
 386         (mi_info_module_functions_or_variables): New function.
 387         (mi_cmd_symbol_info_module_functions): New function.
 388         (mi_cmd_symbol_info_module_variables): New function.
 389         * NEWS: Mention new MI command.
 390
 391 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
 392
 393         * bcache.c (hash): Remove.
 394         (hash_continue): Remove.
 395         * bcache.h (hash): Remove.
 396         (hash_continue): Remove.
 397         (struct bcache) <ctor>: Update.
 398         * psymtab.c (psymbol_hash): Update.
 399         * stabsread.c (hashname): Update.
 400         * utils.h (fast_hash): Add an argument for a start value,
 401         defaulting to zero.
 402
 403 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 404         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
 405         (destroy_block_symbol_cache): New function.
 406         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
 407         (resize_symbol_cache): Likewise.
 408
 409 2019-12-02  Tom Tromey  <tom@tromey.com>
 410
 411         * unittests/tui-selftests.c (run_tests): Make conditional.
 412         (_initialize_tui_selftest): Make conditional.
 413
 414 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
 415
 416         * aix-thread.c (debug_aix_thread): Change type to bool.
 417
 418 2019-12-02  Luis Machado  <luis.machado@linaro.org>
 419
 420         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
 421
 422 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 423
 424         * dwarf2read.c (read_tag_string_type): Read the fields required to
 425         make a dynamic string, and possibly create a dynamic range for the
 426         string.
 427         (attr_to_dynamic_prop): Setup is_reference based on the type of
 428         attribute being processed.
 429         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
 430         (resolve_dynamic_array): Rename to...
 431         (resolve_dynamic_array_or_string): ...this, update header comment,
 432         and accept TYPE_CODE_STRING.
 433         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
 434
 435 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 436
 437         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
 438         of its implementation from...
 439         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
 440         the new function.
 441
 442 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 443
 444         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
 445         create a range with stride where appropriate.
 446         * f-valprint.c: Include 'gdbarch.h'.
 447         (f77_print_array_1): Take the stride into account when walking the
 448         array.  Also convert the stride into addressable units.
 449         * gdbtypes.c (create_range_type): Initialise the stride to
 450         constant zero.
 451         (create_range_type_with_stride): New function, initialise the
 452         range as normal, and then setup the stride.
 453         (has_static_range): Include the stride here.  Also change the
 454         return type to bool.
 455         (create_array_type_with_stride): Consider the range stride if the
 456         array isn't given its own stride.
 457         (resolve_dynamic_range): Resolve the stride if needed.
 458         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
 459         (struct range_bounds) <flag_is_byte_stride>: New member variable.
 460         (TYPE_BIT_STRIDE): Define.
 461         (TYPE_ARRAY_BIT_STRIDE): Define.
 462         (create_range_type_with_stride): Declare.
 463         * valarith.c (value_subscripted_rvalue): Take range stride into
 464         account when walking the array.
 465
 466 2019-12-01  Tom Tromey  <tom@tromey.com>
 467
 468         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
 469         specially.
 470
 471 2019-12-01  Tom Tromey  <tom@tromey.com>
 472
 473         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
 474         \0.
 475         * unittests/tui-selftests.c: New file.
 476         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
 477
 478 2019-12-01  Tom Tromey  <tom@tromey.com>
 479
 480         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
 481
 482 2019-12-01  Tom Tromey  <tom@tromey.com>
 483
 484         * NEWS: Document new settings.
 485         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
 486         * tui/tui-win.c (_initialize_tui_win): Add border style
 487         observers.
 488         * tui/tui-io.h (tui_apply_style): Declare.
 489         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
 490         longer static.
 491         (apply_ansi_escape, tui_set_reverse_mode): Update.
 492         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
 493         Add "skip_intensity" parameter.
 494         <changed>: New member.
 495         <do_set_value>: Declare.
 496         (tui_border_style, tui_active_border_style): Declare.
 497         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
 498         globals.
 499         (cli_style_option): Initialize "changed".
 500         (cli_style_option::do_set_value): New function.
 501         (cli_style_option::add_setshow_commands): Add "skip_intensity"
 502         parameter.  Update.
 503         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
 504         (_initialize_cli_style): Update.  Create TUI border style
 505         commands.
 506
 507 2019-12-01  Tom Tromey  <tom@tromey.com>
 508
 509         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
 510         parameter.
 511         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
 512         parameter.
 513         * tui/tui-win.h (compact_source): Declare.
 514         * tui/tui-win.c (compact_source): New global.
 515         (tui_set_compact_source, tui_show_compact_source): New functions.
 516         (_initialize_tui_win): Add "compact-source" setting.
 517         * tui/tui-source.c (tui_source_window::set_contents): Handle
 518         compact_source setting.
 519         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 520         * NEWS: Document new setting.
 521
 522 2019-11-30  Tom Tromey  <tom@tromey.com>
 523
 524         * dwarf2read.c (dwarf2_add_field): Include field offset when
 525         computing variant part length.
 526
 527 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 528         * NEWS:  Mention define-prefix.  Tell that command names can now
 529         contain a . character.
 530
 531 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 532
 533         * command.h (valid_cmd_char_p): Declare.
 534         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
 535         the check of valid command char.
 536         (find_command_name_length, valid_user_defined_cmd_name_p): Use
 537         valid_cmd_char_p.
 538         * cli/cli-script.c (validate_comname): Likewise.
 539         * completer.c (gdb_completer_command_word_break_characters):
 540         Do not remove . from the word break char, update comments.
 541         (complete_line_internal_1): Use valid_cmd_char_p.
 542         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
 543         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
 544
 545 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 546
 547         * cli/cli-script.c (do_define_command): Ensure a redefined
 548         prefix command is kept as a prefix command.
 549         (define_prefix_command): New function.
 550         (show_user_1): Report user defined prefixes.
 551         (_initialize_cli_script):  Create the new 'define-prefix' command.
 552         Add completers for 'define' and 'document'.
 553         * top.c (execute_command):  If command is a user-defined prefix only
 554         command, report the list of commands for this prefix command.
 555
 556 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 557
 558         * valops.c (find_oload_champ): Improve debug output.
 559
 560 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 561
 562         * valops.c (find_oload_champ): Print part of debug messages
 563         before the badness vector is std::move'd.
 564
 565 2019-11-28  Tom Tromey  <tom@tromey.com>
 566
 567         * value.c (creal_internal_fn): Fix comment.
 568
 569 2019-11-28  Tom Tromey  <tom@tromey.com>
 570
 571         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
 572         flag_bound_evaluated>: Now unsigned.
 573
 574 2019-11-28  Tom Tromey  <tom@tromey.com>
 575
 576         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
 577         declare.
 578
 579 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
 580
 581         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
 582         debug output.
 583         * jit.c (jit_unregister_code): Add debug print to match
 584         `jit_register_code`.
 585
 586 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 587
 588         * NEWS: Mention the new multithreaded symbol loading.
 589
 590 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 591
 592         * maint.c (n_worker_threads): Default to 0.
 593         (worker_threads_disabled): New function.
 594         * maint.h (worker_threads_disabled): New function.
 595         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
 596         here if worker_threads_disabled () is true.
 597         (minimal_symbol_reader::install): Skip all threading if
 598         worker_threads_disabled () is true.
 599
 600 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 601
 602         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
 603         hash code if possible.
 604         (add_minsym_to_demangled_hash_table): Likewise.
 605         (minimal_symbol_reader::install): Compute the hash codes for msymbol
 606         on the background thread.
 607         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
 608         Add these fields.
 609
 610 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 611
 612         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
 613         of the mangled name on the background thread.
 614         * symtab.c (symbol_set_names): Allow passing in the hash of the
 615         linkage_name.
 616         * symtab.h (symbol_set_names): Likewise.
 617
 618 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
 619
 620         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
 621         physnames are computed for inherited DIEs.
 622
 623 2019-11-27  Tom Tromey  <tromey@adacore.com>
 624
 625         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
 626         backslashes.
 627         * cp-support.c: Remove unnecessary backslashes.
 628
 629 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 630
 631         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
 632         with sym->set_linkage_name.
 633         * coffread.c (coff_read_enum_type): Likewise.
 634         * mdebugread.c (parse_symbol): Likewise.
 635         * stabsread.c (patch_block_stabs): Likewise.
 636         (define_symbol): Likewise.
 637         (read_enum_type): Likewise.
 638         (common_block_end): Likewise.
 639         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
 640         function.
 641         (SYMBOL_SET_LINKAGE_NAME): Remove.
 642         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
 643         with sym->set_linkage_name.
 644
 645 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 646
 647         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
 648         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
 649         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
 650         * NEWS: Mention new MI command.
 651
 652 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 653
 654         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
 655         '-symbol-info-types', and '-symbol-info-variables'.
 656         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
 657         (mi_cmd_symbol_info_types): Declare.
 658         (mi_cmd_symbol_info_variables): Declare.
 659         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
 660         (output_debug_symbol): New function.
 661         (output_nondebug_symbol): New function.
 662         (mi_symbol_info): New function.
 663         (mi_info_functions_or_variables): New function.
 664         (mi_cmd_symbol_info_functions): New function.
 665         (mi_cmd_symbol_info_types): New function.
 666         (mi_cmd_symbol_info_variables): New function.
 667         * NEWS: Mention new commands.
 668
 669 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 670
 671         * symtab.c (symbol_to_info_string): New function, most content
 672         moved from print_symbol_info, but updated to return a std::string.
 673         (print_symbol_info): Update to use symbol_to_info_string and print
 674         returned string.
 675         * symtab.h (symbol_to_info_string): Declare new function.
 676
 677 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 678
 679         * python/python.c (gdbpy_rbreak): Convert to using
 680         global_symbol_searcher.
 681         * symtab.c (file_matches): Convert return type to bool, change
 682         file list to std::vector, update header comment.
 683         (search_symbols): Rename to...
 684         (global_symbol_searcher::search): ...this and update now its
 685         a member function of global_symbol_searcher.  Take account of the
 686         changes to file_matches.
 687         (symtab_symbol_info): Convert to using global_symbol_searcher.
 688         (rbreak_command): Likewise.
 689         (search_module_symbols): Likewise.
 690         * symtab.h (enum symbol_search): Update comment.
 691         (search_symbols): Remove declaration.
 692         (class global_symbol_searcher): New class.
 693
 694 2019-11-26  Tom Tromey  <tromey@adacore.com>
 695
 696         * cp-support.c (_initialize_cp_support): Conditionally initialize
 697         gdb_demangle_attempt_core_dump.
 698
 699 2019-11-26  Tom Tromey  <tom@tromey.com>
 700
 701         * python/py-function.c (fnpy_init): Update.
 702         * value.h (add_internal_function): Adjust declaration.
 703         * value.c (function_destroyer): Remove.
 704         (do_add_internal_function): Don't set destroyer or copy name.
 705         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
 706         Set name_allocated.
 707         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
 708         (cmdpy_init): Set name_allocated.
 709         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
 710         member.
 711         (~cmd_list_element): Free "name" if needed.
 712
 713 2019-11-26  Tom Tromey  <tom@tromey.com>
 714
 715         * value.h (add_internal_function): Add new overload.  Move
 716         documentation from value.h.
 717         * value.c (do_add_internal_function): New function.
 718         (add_internal_function): Use it.  Add new overload.
 719         (function_destroyer): Don't free doc.
 720         * python/py-function.c (fnpy_init): Update.
 721
 722 2019-11-26  Tom Tromey  <tom@tromey.com>
 723
 724         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
 725         (cmdpy_init): Set "doc_allocated".
 726
 727 2019-11-26  Tom Tromey  <tom@tromey.com>
 728
 729         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
 730         name of worker thread.
 731         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 732         pthread_setname_np.
 733         * configure, config.in: Rebuild.
 734
 735 2019-11-26  Tom Tromey  <tom@tromey.com>
 736
 737         * python/python.c (class gdbpy_gil): New.
 738         (struct gdbpy_event): Add constructor, destructor, operator().
 739         (gdbpy_post_event): Use run_on_main_thread.
 740         (gdbpy_initialize_events): Remove.
 741         (do_start_initialization): Update.
 742
 743 2019-11-26  Tom Tromey  <tom@tromey.com>
 744
 745         * NEWS: Add entry.
 746         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
 747         commands.  Call update_thread_pool_size.
 748         (update_thread_pool_size, maintenance_set_worker_threads): New
 749         functions.
 750         (n_worker_threads): New global.
 751
 752 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 753             Tom Tromey  <tom@tromey.com>
 754
 755         * minsyms.c (minimal_symbol_reader::install): Use
 756         parallel_for_each.
 757         * gdbsupport/parallel-for.h: New file.
 758         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
 759
 760 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 761             Tom Tromey  <tom@tromey.com>
 762
 763         * gdbsupport/thread-pool.h: New file.
 764         * gdbsupport/thread-pool.c: New file.
 765         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
 766         (HFILES_NO_SRCDIR): Add thread-pool.h.
 767
 768 2019-11-26  Tom Tromey  <tom@tromey.com>
 769
 770         * event-top.h (thread_local_segv_handler): Declare.
 771         * event-top.c (thread_local_segv_handler): New global.
 772         (install_handle_sigsegv, handle_sigsegv): New functions.
 773         (async_init_signals): Install SIGSEGV handler.
 774         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
 775         thread-local.
 776         (report_failed_demangle): New function.
 777         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
 778         handler-setting code, instead use segv_handler.  Run warning code
 779         on main thread.
 780
 781 2019-11-26  Tom Tromey  <tom@tromey.com>
 782
 783         * run-on-main-thread.c: New file.
 784         * run-on-main-thread.h: New file.
 785         * unittests/main-thread-selftests.c: New file.
 786         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 787         main-thread-selftests.c.
 788         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
 789         (COMMON_SFILES): Add run-on-main-thread.c.
 790
 791 2019-11-26  Tom Tromey  <tom@tromey.com>
 792
 793         * main.c (setup_alternate_signal_stack): Remove.
 794         (captured_main_1): Use gdb::alternate_signal_stack.
 795         * gdbsupport/alt-stack.h: New file.
 796
 797 2019-11-26  Tom Tromey  <tom@tromey.com>
 798
 799         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
 800         Remove comment.
 801         (save_original_signals_state, restore_original_signals_state): Use
 802         gdb_sigmask.
 803         * linux-nat.c (block_child_signals, restore_child_signals_mask)
 804         (_initialize_linux_nat): Use gdb_sigmask.
 805         * guile/guile.c (_initialize_guile): Use block_signals.
 806         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
 807         * gdbsupport/gdb-sigmask.h: New file.
 808         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
 809         * cp-support.c (gdb_demangle): Use gdb_sigmask.
 810         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 811         pthread_sigmask.
 812         * configure, config.in: Rebuild.
 813         * gdbsupport/block-signals.h: New file.
 814
 815 2019-11-26  Tom Tromey  <tom@tromey.com>
 816
 817         * acinclude.m4: Include ax_pthread.m4.
 818         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
 819         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
 820         (CLIBS): Use PTHREAD_LIBS.
 821         (aclocal_m4_deps): Add ax_pthread.m4.
 822         * config.in, configure: Rebuild.
 823         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
 824
 825 2019-11-26  Tom Tromey  <tom@tromey.com>
 826
 827         * symtab.h (struct minimal_symbol) <name_set>: New member.
 828         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
 829         Don't call symbol_set_names.
 830         (minimal_symbol_reader::install): Call symbol_set_names.
 831
 832 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 833
 834         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
 835         restore_active_ext_lang, as GIL is needed for (indirectly)
 836         called PyOS_InterruptOccurred.
 837
 838 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 839
 840         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
 841         definition.
 842
 843 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 844
 845         * remote-sim.c (simulator_command): Make static, remove
 846         declaration.
 847
 848 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 849
 850         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
 851         static.
 852         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
 853         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
 854         (main): Likewise.
 855         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
 856         (main): Likewise.
 857         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
 858         (main): Likewise.
 859         * unittests/basic_string_view/element_access/char/1.cc (test01):
 860         Likewise.
 861         (main): Likewise.
 862         * unittests/basic_string_view/element_access/char/empty.cc (main):
 863         Likewise.
 864         * unittests/basic_string_view/element_access/char/front_back.cc
 865         (test01): Likewise.
 866         (main): Likewise.
 867         * unittests/basic_string_view/inserters/char/2.cc (test05):
 868         Likewise.
 869         (main): Likewise.
 870         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
 871         (test01): Likewise.
 872         (main): Likewise.
 873         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
 874         (test01): Likewise.
 875         (main): Likewise.
 876         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
 877         Likewise.
 878         * unittests/basic_string_view/operations/compare/char/1.cc
 879         (test01): Likewise.
 880         (main): Likewise.
 881         * unittests/basic_string_view/operations/compare/char/13650.cc
 882         (test01): Likewise.
 883         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
 884         Likewise.
 885         (main): Likewise.
 886         * unittests/basic_string_view/operations/data/char/1.cc (test01):
 887         Likewise.
 888         (main): Likewise.
 889         * unittests/basic_string_view/operations/find/char/1.cc (test01):
 890         Likewise.
 891         (main): Likewise.
 892         * unittests/basic_string_view/operations/find/char/2.cc (test02):
 893         Likewise.
 894         (main): Likewise.
 895         * unittests/basic_string_view/operations/find/char/3.cc (test03):
 896         Likewise.
 897         (main): Likewise.
 898         * unittests/basic_string_view/operations/find/char/4.cc (main):
 899         Likewise.
 900         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
 901         Likewise.
 902         (main): Likewise.
 903         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
 904         Likewise.
 905         (main): Likewise.
 906         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
 907         Likewise.
 908         (main): Likewise.
 909         * unittests/basic_string_view/operations/substr/char/1.cc
 910         (test01): Likewise.
 911         (main): Likewise.
 912         * unittests/basic_string_view/operators/char/2.cc (main):
 913         Likewise.
 914         * unittests/optional/assignment/1.cc (test): Likewise.
 915         * unittests/optional/assignment/2.cc (test): Likewise.
 916         * unittests/optional/assignment/3.cc (test): Likewise.
 917         * unittests/optional/assignment/4.cc (test): Likewise.
 918         * unittests/optional/assignment/5.cc (test): Likewise.
 919         * unittests/optional/assignment/6.cc (test): Likewise.
 920         * unittests/optional/assignment/7.cc (test): Likewise.
 921         * unittests/optional/cons/copy.cc (test): Likewise.
 922         * unittests/optional/cons/default.cc (test): Likewise.
 923         * unittests/optional/cons/move.cc (test): Likewise.
 924         * unittests/optional/cons/value.cc (test): Likewise.
 925         * unittests/optional/in_place.cc (test): Likewise.
 926         * unittests/optional/observers/1.cc (test): Likewise.
 927         * unittests/optional/observers/2.cc (test): Likewise.
 928
 929 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 930
 931         * tui-win.h (tui_set_var_cmd): Remove.
 932         * tui-win.c (tui_set_var_cmd): Make static.
 933
 934 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 935
 936         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
 937         rbreak_command_wrapper): Remove.
 938         * symtab.c (rbreak_command_wrapper): Remove.
 939
 940 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 941
 942         * inferior.h (info_terminal_command): Remove declaration.
 943         * inflow.c (info_terminal_command): Make static.
 944
 945 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 946
 947         * inferior.c (exit_inferior_silent): Remove.
 948
 949 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 950
 951         * dictionary.c (dict_empty, mdict_empty): Remove.
 952         * dictionary.c (mdict_empty): Remove.
 953
 954 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 955
 956          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
 957          (arc_insn_get_memory_offset): Likewise.
 958          (arc_insn_dump): Likewise.
 959          * cp-support.c (test_cp_symbol_name_matches): Likewise.
 960          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
 961          * dictionary.c (dict_iterator_next): Likewise.
 962          (dict_iter_match_first): Likewise.
 963          (dict_iter_match_next): Likewise.
 964          * f-lang.c (evaluate_subexp_f): Likewise.
 965          * hppa-tdep.c (hppa_read_pc): Likewise.
 966          * i386-tdep.c (i386_floatformat_for_type): Likewise.
 967          * parse.c (write_exp_elt_msym): Likewise.
 968          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
 969          * remote.c (remote_packet_size): Likewise.
 970          (remote_notif_stop_parse): Likewise.
 971          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
 972          * s12z-tdep.c (s12z_disassemble_info): Likewise.
 973          * source.c (prepare_path_for_appending): Likewise.
 974          * sparc64-linux-tdep.c
 975          (sparc64_linux_handle_segmentation_fault); Likewise.
 976          * stack.c (frame_selection_by_function_completer): Likewise.
 977
 978 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 979
 980         * completer.c (set_gdb_completion_word_break_characters):
 981         Remove.
 982
 983 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 984
 985         * dwarf-index-write.c: Include dwarf-index-write.h.
 986         * mi/mi-interp.c: Include mi/mi-interp.h.
 987
 988 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 989
 990         * aarch32-tdep.c: Include aarch32-tdep.h.
 991         * aarch32-tdep.h: Forward-declare struct target_desc.
 992
 993 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 994
 995         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
 996         strerror.
 997         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
 998         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
 999
1000 2019-11-25  Tom de Vries  <tdevries@suse.de>
1001
1002         * contrib/words.sh: Add -c option.
1003
1004 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
1005
1006         * solib.c (solib_find_1): Change int to bool.
1007         (exec_file_find): Change int to bool.
1008         (solib_find): Change int to bool.
1009         (solib_read_symbols): Change int to bool.
1010         (solib_used): Change int to bool.
1011         (solib_add): Change int to bool.
1012         (info_sharedlibrary_command): Change int to bool.
1013         (solib_contains_address_p): Change int to bool.
1014         (solib_keep_data_in_core): Change int to bool.
1015         (in_solib_dynsym_resolve_code): Change int to bool.
1016         (reload_shared_libraries_1): Change int to bool.
1017         (gdb_sysroot_changed): Change int to bool.
1018         * solib.h (solib_read_symbols): Change int to bool.
1019         (solib_contains_address_p): Change int to bool.
1020         (solib_keep_data_in_core): Change int to bool.
1021         (in_solib_dynsym_resolve_code): Change int to bool.
1022         (libpthread_name_p): Change int to bool.
1023
1024 2019-11-25  Luis Machado  <luis.machado@linaro.org>
1025
1026         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1027         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1028         (remote_packet_max_chars): New static global.
1029         (show_remote_packet_max_chars): New function.
1030         (remote_target::putpkt_binary): Adjust to use new
1031         remote_packet_max_chars option.
1032         (remote_target::getpkt_or_notif_sane_1): Likewise.
1033         (_initialize_remote): Register new remote-packet-max-chars option.
1034
1035 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
1036
1037         * m68k-linux-nat.c: Include gdbarch.h.
1038
1039 2019-11-24  Tom Tromey  <tom@tromey.com>
1040
1041         * symfile.c (read_symbols): Update.
1042         * psymtab.c (require_partial_symbols): Change type of "verbose" to
1043         bool.
1044         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1045         (psym_lookup_symbol, psym_find_last_source_symtab)
1046         (psym_forget_cached_source_info, psym_print_stats)
1047         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1048         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1049         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1050         (psym_find_compunit_symtab_by_address)
1051         (maintenance_print_psymbols, maintenance_info_psymtabs)
1052         (maintenance_check_psymtabs): Update.
1053         * psymtab.h (require_partial_symbols): Change type of "verbose" to
1054         bool.
1055
1056 2019-11-22  Tom Tromey  <tom@tromey.com>
1057
1058         * observable.h: Update comments.
1059
1060 2019-11-22  Tom Tromey  <tromey@adacore.com>
1061
1062         * ada-tasks.c (ada_task_is_alive): Make parameter const.
1063         (print_ada_task_info): Don't try to fetch thread id if task is not
1064         alive.
1065
1066 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1067
1068         * ada-exp.y: Update.
1069         * ada-lang.c (sort_choices): Update.
1070         (ada_print_symbol_signature): Update.
1071         (resolve_subexp): Update.
1072         (ada_parse_renaming): Update.
1073         (ada_read_renaming_var_value): Update.
1074         (lesseq_defined_than): Update.
1075         (remove_extra_symbols): Update.
1076         (remove_irrelevant_renamings): Update.
1077         (ada_add_block_symbols): Update.
1078         (ada_collect_symbol_completion_matches): Update.
1079         (ada_is_renaming_symbol): Update.
1080         (aggregate_assign_from_choices): Update.
1081         (ada_evaluate_subexp): Update.
1082         (ada_has_this_exception_support): Update.
1083         (ada_is_non_standard_exception_sym): Update.
1084         (ada_add_exceptions_from_frame): Update.
1085         (ada_add_global_exceptions): Update.
1086         (ada_print_subexp): Update.
1087         * ax-gdb.c (gen_var_ref): Update.
1088         (gen_maybe_namespace_elt): Update.
1089         (gen_expr_for_cast): Update.
1090         (gen_expr): Update.
1091         * block.h: Update.
1092         * blockframe.c (find_pc_partial_function): Update.
1093         * breakpoint.c (print_breakpoint_location): Update.
1094         (update_static_tracepoint): Update.
1095         * btrace.c (ftrace_print_function_name): Update.
1096         (ftrace_function_switched): Update.
1097         * buildsym.c (find_symbol_in_list): Update.
1098         * c-exp.y: Update.
1099         * c-typeprint.c (c_print_typedef): Update.
1100         (c_type_print_template_args): Update.
1101         * cli/cli-cmds.c (edit_command): Update.
1102         (list_command): Update.
1103         (print_sal_location): Update.
1104         * coffread.c (patch_opaque_types): Update.
1105         (process_coff_symbol): Update.
1106         (coff_read_enum_type): Update.
1107         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1108         (convert_one_symbol): Update.
1109         (hash_symname): Update.
1110         (eq_symname): Update.
1111         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1112         * compile/compile-cplus-types.c (debug_print_scope): Update.
1113         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1114         * compile/compile-object-load.c (get_out_value_type): Update.
1115         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1116         (search_symbol_list): Update.
1117         (cp_lookup_symbol_imports_or_template): Update.
1118         * cp-support.c (overload_list_add_symbol): Update.
1119         * ctfread.c (psymtab_to_symtab): Update.
1120         * dbxread.c (cp_set_block_scope): Update.
1121         * dictionary.c (iter_match_first_hashed): Update.
1122         (iter_match_next_hashed): Update.
1123         (insert_symbol_hashed): Update.
1124         (iter_match_next_linear): Update.
1125         * dictionary.h: Update.
1126         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1127         (locexpr_describe_location_piece): Update.
1128         (locexpr_describe_location_1): Update.
1129         (locexpr_generate_c_location): Update.
1130         (loclist_describe_location): Update.
1131         (loclist_generate_c_location): Update.
1132         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1133         (read_func_scope): Update.
1134         (process_enumeration_scope): Update.
1135         (new_symbol): Update.
1136         (dwarf2_const_value): Update.
1137         (dwarf2_symbol_mark_computed): Update.
1138         * eval.c (evaluate_funcall): Update.
1139         (evaluate_subexp_standard): Update.
1140         * expprint.c (print_subexp_standard): Update.
1141         (dump_subexp_body_standard): Update.
1142         * f-valprint.c (info_common_command_for_block): Update.
1143         * findvar.c (get_hosting_frame): Update.
1144         (default_read_var_value): Update.
1145         * go-lang.c (go_symbol_package_name): Update.
1146         * guile/scm-block.c (bkscm_print_block_smob): Update.
1147         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1148         (gdbscm_symbol_name): Update.
1149         (gdbscm_symbol_linkage_name): Update.
1150         (gdbscm_symbol_print_name): Update.
1151         * infcall.c (get_function_name): Update.
1152         * infcmd.c (jump_command): Update.
1153         (finish_command): Update.
1154         * infrun.c (insert_exception_resume_breakpoint): Update.
1155         * linespec.c (canonicalize_linespec): Update.
1156         (create_sals_line_offset): Update.
1157         (convert_linespec_to_sals): Update.
1158         (complete_label): Update.
1159         (find_label_symbols_in_block): Update.
1160         * m2-typeprint.c (m2_print_typedef): Update.
1161         * mdebugread.c (mdebug_reg_to_regnum): Update.
1162         (parse_symbol): Update.
1163         (mylookup_symbol): Update.
1164         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1165         (list_args_or_locals): Update.
1166         * objc-lang.c (compare_selectors): Update.
1167         (info_selectors_command): Update.
1168         (compare_classes): Update.
1169         (info_classes_command): Update.
1170         (find_imps): Update.
1171         * p-typeprint.c (pascal_print_typedef): Update.
1172         * printcmd.c (build_address_symbolic): Update.
1173         (info_address_command): Update.
1174         (print_variable_and_value): Update.
1175         * python/py-framefilter.c (extract_sym): Update.
1176         (py_print_single_arg): Update.
1177         * python/py-symbol.c (sympy_str): Update.
1178         (sympy_get_name): Update.
1179         (sympy_get_linkage_name): Update.
1180         * python/python.c (gdbpy_rbreak): Update.
1181         * record-btrace.c (btrace_get_bfun_name): Update.
1182         (btrace_call_history): Update.
1183         * rust-lang.c (rust_print_typedef): Update.
1184         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1185         * stabsread.c (stab_reg_to_regnum): Update.
1186         (define_symbol): Update.
1187         (read_enum_type): Update.
1188         (common_block_end): Update.
1189         (cleanup_undefined_types_1): Update.
1190         (scan_file_globals): Update.
1191         * stack.c (print_frame_arg): Update.
1192         (print_frame_args): Update.
1193         (find_frame_funname): Update.
1194         (info_frame_command_core): Update.
1195         (iterate_over_block_locals): Update.
1196         (print_block_frame_labels): Update.
1197         (do_print_variable_and_value): Update.
1198         (iterate_over_block_arg_vars): Update.
1199         (return_command): Update.
1200         * symmisc.c (dump_symtab_1): Update.
1201         (print_symbol): Update.
1202         * symtab.c (eq_symbol_entry): Update.
1203         (symbol_cache_dump): Update.
1204         (lookup_language_this): Update.
1205         (find_pc_sect_line): Update.
1206         (skip_prologue_sal): Update.
1207         (symbol_search::compare_search_syms): Update.
1208         (treg_matches_sym_type_name): Update.
1209         (search_symbols): Update.
1210         (print_symbol_info): Update.
1211         (rbreak_command): Update.
1212         (completion_list_add_symbol): Update.
1213         (find_gnu_ifunc): Update.
1214         (get_symbol_address): Update.
1215         (search_module_symbols): Update.
1216         (info_module_subcommand): Update.
1217         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1218         (SYMBOL_LINKAGE_NAME): Remove.
1219         (SYMBOL_DEMANGLED_NAME): Remove.
1220         (SYMBOL_PRINT_NAME): Remove.
1221         (SYMBOL_SEARCH_NAME): Remove.
1222         * tracepoint.c (set_traceframe_context): Update.
1223         (validate_actionline): Update.
1224         (collection_list::collect_symbol): Update.
1225         (encode_actions_1): Update.
1226         (info_scope_command): Update.
1227         (print_one_static_tracepoint_marker): Update.
1228         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1229         * valops.c (address_of_variable): Update.
1230         (find_overload_match): Update.
1231         (find_oload_champ): Update.
1232
1233 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1234
1235         * ada-lang.c (ada_lookup_simple_minsym): Update.
1236         (ada_collect_symbol_completion_matches): Update.
1237         * ada-tasks.c (read_atcb): Update.
1238         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1239         (amd64_windows_skip_trampoline_code): Update.
1240         * arm-tdep.c (skip_prologue_function): Update.
1241         (arm_skip_stack_protector): Update.
1242         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1243         (arm_wince_skip_main_prologue): Update.
1244         * ax-gdb.c (gen_expr): Update.
1245         * block.c (call_site_for_pc): Update.
1246         * blockframe.c (find_pc_partial_function): Update.
1247         * breakpoint.c (set_breakpoint_location_function): Update.
1248         * btrace.c (ftrace_print_function_name): Update.
1249         (ftrace_function_switched): Update.
1250         * c-valprint.c (print_unpacked_pointer): Update.
1251         * coffread.c (coff_symfile_read): Update.
1252         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1253         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1254         * dwarf-index-write.c (write_psymbols): Update.
1255         * dwarf2loc.c (call_site_to_target_addr): Update.
1256         (func_verify_no_selftailcall): Update.
1257         (tailcall_dump): Update.
1258         (call_site_find_chain_1): Update.
1259         (dwarf_expr_reg_to_entry_parameter): Update.
1260         * elfread.c (elf_gnu_ifunc_record_cache): Update.
1261         * eval.c (evaluate_funcall): Update.
1262         (evaluate_subexp_standard): Update.
1263         (evaluate_subexp_for_sizeof): Update.
1264         * expprint.c (print_subexp_standard): Update.
1265         (dump_subexp_body_standard): Update.
1266         * frame.c (get_prev_frame_always_1): Update.
1267         * frv-tdep.c (frv_skip_main_prologue): Update.
1268         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1269         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1270         (gnuv3_get_typename_from_type_info): Update.
1271         (gnuv3_skip_trampoline): Update.
1272         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1273         * i386-tdep.c (i386_skip_main_prologue): Update.
1274         (i386_pe_skip_trampoline_code): Update.
1275         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1276         * infcall.c (get_function_name): Update.
1277         * linespec.c (minsym_found): Update.
1278         * linux-fork.c (info_checkpoints_command): Update.
1279         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1280         (m32c_m16c_pointer_to_address): Update.
1281         * maint.c (maintenance_translate_address): Update.
1282         * minsyms.c (add_minsym_to_hash_table): Update.
1283         (add_minsym_to_demangled_hash_table): Update.
1284         (lookup_minimal_symbol_mangled): Update.
1285         (lookup_minimal_symbol_demangled): Update.
1286         (lookup_minimal_symbol_linkage): Update.
1287         (lookup_minimal_symbol_text): Update.
1288         (lookup_minimal_symbol_by_pc_name): Update.
1289         (minimal_symbol_is_less_than): Update.
1290         (compact_minimal_symbols): Update.
1291         (build_minimal_symbol_hash_tables): Update.
1292         (find_solib_trampoline_target): Update.
1293         * mips-tdep.c (mips_stub_frame_sniffer): Update.
1294         (mips_skip_pic_trampoline_code): Update.
1295         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1296         * objc-lang.c (info_selectors_command): Update.
1297         (info_classes_command): Update.
1298         (find_methods): Update.
1299         (find_imps): Update.
1300         * p-valprint.c (pascal_val_print): Update.
1301         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1302         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1303         * printcmd.c (build_address_symbolic): Update.
1304         (info_symbol_command): Update.
1305         * psymtab.c (psymbol_name_matches): Update.
1306         (match_partial_symbol): Update.
1307         (lookup_partial_symbol): Update.
1308         (print_partial_symbols): Update.
1309         (sort_pst_symbols): Update.
1310         (maintenance_check_psymtabs): Update.
1311         * python/py-framefilter.c (py_print_frame): Update.
1312         * python/python.c (gdbpy_rbreak): Update.
1313         * record-btrace.c (btrace_get_bfun_name): Update.
1314         (btrace_call_history): Update.
1315         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1316         (rs6000_skip_trampoline_code): Update.
1317         * sol-thread.c (info_cb): Update.
1318         * stabsread.c (scan_file_globals): Update.
1319         * stack.c (find_frame_funname): Update.
1320         (info_frame_command_core): Update.
1321         * symmisc.c (dump_msymbols): Update.
1322         * symtab.c (symbol_natural_name): Rename to..,
1323         (general_symbol_info::natural_name): ...this.
1324         (symbol_demangled_name): Rename to...
1325         (general_symbol_info::demangled_name): ...this.
1326         (symbol_search_name): Rename to...
1327         (general_symbol_info::search_name): ...this.
1328         (symbol_matches_search_name): Update.
1329         (find_pc_sect_line): Update.
1330         (skip_prologue_sal): Update.
1331         (search_symbols): Update.
1332         (print_msymbol_info): Update.
1333         (rbreak_command): Update.
1334         (completion_list_add_msymbol): Update.
1335         (completion_list_objc_symbol): Update.
1336         (get_msymbol_address): Update.
1337         * symtab.h (struct general_symbol_info): Add member functions
1338         natural_name (), linkage_name (), print_name (), demangled_name (),
1339         and search_name ().
1340         (SYMBOL_NATURAL_NAME): Update.
1341         (symbol_natural_name): Move to a member function on general_symbol_info.
1342         (SYMBOL_DEMANGLED_NAME): Update.
1343         (symbol_demangled_name): Move to a member function on
1344         general_symbol_info.
1345         (SYMBOL_SEARCH_NAME): Update.
1346         (symbol_search_name): Move to a member function on general_symbol_info.
1347         (MSYMBOL_NATURAL_NAME): Remove.
1348         (MSYMBOL_LINKAGE_NAME): Remove.
1349         (MSYMBOL_PRINT_NAME): Remove.
1350         (MSYMBOL_DEMANGLED_NAME): Remove.
1351         (MSYMBOL_SEARCH_NAME): Remove.
1352         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1353
1354 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1355
1356         * symtab.c (create_demangled_names_hash): Use per_bfd->
1357         minimal_symbol_count for computing the initial size, if greater
1358         than our default size.
1359
1360 2019-11-22  Tom de Vries  <tdevries@suse.de>
1361
1362         * contrib/words.sh: Improve words extraction.
1363
1364 2019-11-22  Tom de Vries  <tdevries@suse.de>
1365
1366         * contrib/words.sh: Combine sed invocations.
1367
1368 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
1369
1370         * Makefile.in: Update.
1371         * demangle.c: Rename to...
1372         * gdb-demangle.c: ..this.
1373         (is_cplus_marker): Change return type to bool.
1374         (_initialize_demangler): Rename to...
1375         (_initialize_gdb_demangle): ...this.
1376         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1377         * symtab.h (demangle): Remove declaration; instead include
1378         gdb-demangle.h.
1379
1380 2019-11-21  Tom Tromey  <tromey@adacore.com>
1381
1382         * gdbsupport/format.c (format_pieces): Parse %I64d.
1383         * unittests/format_pieces-selftests.c (test_windows_formats): New
1384         function.
1385         (run_tests): Call it.
1386
1387 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
1388
1389         Byte reverse display of variables with DW_END_big, DW_END_little
1390         (DW_AT_endianity) dwarf attributes if different than the native
1391         byte order.
1392         * ada-lang.c (ada_value_binop):
1393         Use type_byte_order instead of gdbarch_byte_order.
1394         * ada-valprint.c (printstr):
1395         (ada_val_print_string):
1396         * ada-lang.c (value_pointer):
1397         (ada_value_binop):
1398         Use type_byte_order instead of gdbarch_byte_order.
1399         * c-lang.c (c_get_string):
1400         Use type_byte_order instead of gdbarch_byte_order.
1401         * c-valprint.c (c_val_print_array):
1402         Use type_byte_order instead of gdbarch_byte_order.
1403         * cp-valprint.c (cp_print_class_member):
1404         Use type_byte_order instead of gdbarch_byte_order.
1405         * dwarf2loc.c (rw_pieced_value):
1406         Use type_byte_order instead of gdbarch_byte_order.
1407         * dwarf2read.c (read_base_type): Handle DW_END_big,
1408         DW_END_little
1409         * f-lang.c (f_get_encoding):
1410         Use type_byte_order instead of gdbarch_byte_order.
1411         * findvar.c (default_read_var_value):
1412         Use type_byte_order instead of gdbarch_byte_order.
1413         * gdbtypes.c (check_types_equal):
1414         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1415         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1416         and TYPE_ENDIANITY_LITTLE if set.
1417         (type_byte_order): new function.
1418         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1419         (struct main_type) <flag_endianity_not_default>:
1420         New field.
1421         (type_byte_order): New function.
1422         * infcmd.c (default_print_one_register_info):
1423         Use type_byte_order instead of gdbarch_byte_order.
1424         * p-lang.c (pascal_printstr):
1425         Use type_byte_order instead of gdbarch_byte_order.
1426         * p-valprint.c (pascal_val_print):
1427         Use type_byte_order instead of gdbarch_byte_order.
1428         * printcmd.c (print_scalar_formatted):
1429         Use type_byte_order instead of gdbarch_byte_order.
1430         * solib-darwin.c (darwin_current_sos):
1431         Use type_byte_order instead of gdbarch_byte_order.
1432         * solib-svr4.c (solib_svr4_r_ldsomap):
1433         Use type_byte_order instead of gdbarch_byte_order.
1434         * stap-probe.c (stap_modify_semaphore):
1435         Use type_byte_order instead of gdbarch_byte_order.
1436         * target-float.c (target_float_same_format_p):
1437         Use type_byte_order instead of gdbarch_byte_order.
1438         * valarith.c (scalar_binop):
1439         (value_bit_index):
1440         Use type_byte_order instead of gdbarch_byte_order.
1441         * valops.c (value_cast):
1442         Use type_byte_order instead of gdbarch_byte_order.
1443         * valprint.c (generic_emit_char):
1444         (generic_printstr):
1445         (val_print_string):
1446         Use type_byte_order instead of gdbarch_byte_order.
1447         * value.c (unpack_long):
1448         (unpack_bits_as_long):
1449         (unpack_value_bitfield):
1450         (modify_field):
1451         (pack_long):
1452         (pack_unsigned_long):
1453         Use type_byte_order instead of gdbarch_byte_order.
1454         * findvar.c (unsigned_pointer_to_address):
1455         (signed_pointer_to_address):
1456         (unsigned_address_to_pointer):
1457         (address_to_signed_pointer):
1458         (default_read_var_value):
1459         (default_value_from_register):
1460         Use type_byte_order instead of gdbarch_byte_order.
1461         * gnu-v3-abi.c (gnuv3_make_method_ptr):
1462         Use type_byte_order instead of gdbarch_byte_order.
1463         * riscv-tdep.c (riscv_print_one_register_info):
1464         Use type_byte_order instead of gdbarch_byte_order.
1465
1466 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
1467
1468         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1469         (current_ui_gdb_stdin_ptr): Likewise.
1470         (current_ui_gdb_stderr_ptr): Likewise.
1471         (current_ui_gdb_stdlog_ptr): Likewise.
1472         (current_ui_current_uiout_ptr): Likewise.
1473         (gen_ret_current_ui_field_ptr): Remove.
1474
1475 2019-11-21  Tom de Vries  <tdevries@suse.de>
1476
1477         PR gdb/24956
1478         * cli/cli-script.c (execute_control_command): Only switch to
1479         INTERP_CONSOLE's ui_out when INTERP_MI is active.
1480
1481 2019-11-19  Tom Tromey  <tom@tromey.com>
1482
1483         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1484         Now static.  Change type of "name".
1485         (tui_set_win_height_command): Don't copy "arg".
1486         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1487         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1488
1489 2019-11-19  Ali Tamur <tamur@google.com>
1490
1491         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1492         "if (attr != nullptr)".
1493         (dwarf2_find_base_address): Likewise.
1494         (dwarf2_build_include_psymtabs): Likewise.
1495         (read_cutu_die_from_dwo): Likewise.
1496         (read_func_scope): Likewise.
1497         (read_call_site_scope): Likewise.
1498         (dwarf2_get_pc_bounds): Likewise.
1499         (dwarf2_record_block_ranges): Likewise.
1500         (dwarf2_add_field): Likewise.
1501         (dwarf2_add_member_fn): Likewise.
1502         (read_structure_type): Likewise.
1503         (read_enumeration_type): Likewise.
1504         (read_array_type): Likewise.
1505         (read_array_order): Likewise.
1506         (read_set_type): Likewise.
1507         (read_common_block): Likewise.
1508         (read_tag_reference_type): Likewise.
1509         (read_tag_string_type): Likewise.
1510         (read_subroutine_type): Likewise.
1511         (read_base_type): Likewise.
1512         (read_subrange_type): Likewise.
1513         (new_symbol): Likewise.
1514         (prepare_one_comp_unit): Likewise.
1515
1516 2019-11-19  Tom Tromey  <tromey@adacore.com>
1517
1518         * windows-nat.c (windows_nat_target::attach): Include GetLastError
1519         result in error when DebugActiveProcess fails.
1520
1521 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
1522             Pedro Alves  <palves@redhat.com>
1523
1524         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1525         * target.c (target_stack::push): Call 'unpush' if there's a
1526         target on top of the stack.
1527
1528 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1529
1530         * python/py-block.c (blpy_dealloc): Call tp_free.
1531         (blpy_block_syms_dealloc): Likewise.
1532         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1533         * python/py-inferior.c (infpy_dealloc): Likewise.
1534         * python/py-lazy-string.c (stpy_dealloc): Likewise.
1535         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1536         * python/py-symbol.c (sympy_dealloc): Likewise.
1537         * python/py-symtab.c (stpy_dealloc): Likewise.
1538         * python/py-type.c (typy_iterator_dealloc): Likewise.
1539
1540 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
1541
1542         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1543         constructor instead of using a class initializer.
1544
1545 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1546
1547         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1548         * configure: Regenerate.
1549         * configure.ac: Don't source common.host.
1550         * gdbsupport/common.host: Remove.
1551         * gdbsupport/mingw-strerror.c: Remove.
1552         * gdbsupport/posix-strerror.c: Rename to...
1553         * gdbsupport/safe-strerror.c: ...this.
1554
1555 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1556
1557         * maint.c (scoped_command_stats::print_time): Use localtime_r
1558         instead of localtime (provided through gnulib if necessary).
1559         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1560         of ctime.
1561
1562 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1563
1564         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1565         avoid compile errors.
1566
1567 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1568
1569         * config.in: Regenerate.
1570         * configure: Regenerate.
1571         * gdbsupport/common.m4: No longer check for strerror_r.
1572         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1573         POSIX version of strerror_r, now that gnulib provides it if
1574         necessary.
1575
1576 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
1577
1578         * README (`configure' options): Update.
1579
1580 2019-11-14  Tom Tromey  <tromey@adacore.com>
1581
1582         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1583         expected type for the RHS if the LHS is a convenience variable.
1584
1585 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
1586
1587         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1588         Provide explicit default and copy constructor.
1589
1590 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1591
1592         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1593         only call Py_INCREF (newbp) in the bppy_pending_object case.
1594
1595 2019-11-13  Tom Tromey  <tromey@adacore.com>
1596
1597         PR build/25182:
1598         * psympriv.h (partial_symbol): Remove static assert.
1599         * symtab.h (general_symbol_info, symbol): Remove static assert.
1600
1601 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1602
1603         * gdbsupport/format.c (format_pieces::format_pieces): Support
1604         printf 'z' size modifier.
1605         * gdbsupport/format.h (enum argclass): Add size_t_arg.
1606         * printcmd.c (ui_printf):  Handle size_t_arg.
1607         * ui-out.c (ui_out::vmessage): Likewise.
1608         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1609         function.
1610         (run_tests): Call test_format_int_sizes.
1611
1612 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
1613
1614         * ada-exp.y (write_ambiguous_var): Update.
1615         * buildsym.c (add_symbol_to_list): Update.
1616         * dwarf2read.c (read_variable): Update.
1617         (new_symbol): Update.
1618         * jit.c (finalize_symtab): Update.
1619         * language.c (language_alloc_type_symbol): Update.
1620         * symtab.c (fixup_symbol_section): Update.
1621         (initialize_objfile_symbol_1): Move code to...
1622         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1623         (allocate_symbol): Update.
1624         (allocate_template_symbol): Update.
1625         (get_symbol_address): Update.
1626         * symtab.h (struct symbol): Inherit from general_symbol_info instead
1627         of having as a field, and add a constructor.
1628         (SYMBOL_VALUE): Update.
1629         (SYMBOL_VALUE_ADDRESS): Update.
1630         (SET_SYMBOL_VALUE_ADDRESS): Update.
1631         (SYMBOL_VALUE_BYTES): Update.
1632         (SYMBOL_VALUE_COMMON_BLOCK): Update.
1633         (SYMBOL_BLOCK_VALUE): Update.
1634         (SYMBOL_VALUE_CHAIN): Update.
1635         (SYMBOL_LANGUAGE): Update.
1636         (SYMBOL_SECTION): Update.
1637         (SYMBOL_OBJ_SECTION): Update.
1638         (SYMBOL_SET_LANGUAGE): Update.
1639         (SYMBOL_SET_LINKAGE_NAME): Update.
1640         (SYMBOL_SET_NAMES): Update.
1641         (SYMBOL_NATURAL_NAME): Update.
1642         (SYMBOL_LINKAGE_NAME): Update.
1643         (SYMBOL_DEMANGLED_NAME): Update.
1644         (SYMBOL_SEARCH_NAME): Update.
1645         (SYMBOL_MATCHES_SEARCH_NAME): Update.
1646         (struct symbol): Update.
1647         (struct template_symbol): Update.
1648         (struct rust_vtable_symbol): Update.
1649         * xcoffread.c (SYMBOL_DUP): Update.
1650
1651 2019-11-12  Tom Tromey  <tom@tromey.com>
1652
1653         * tui/tui-layout.c (show_layout): Set current_layout.
1654         (show_source_disasm_command, show_data)
1655         (show_source_or_disasm_and_command): Don't set current_layout.
1656
1657 2019-11-12  Tom Tromey  <tom@tromey.com>
1658
1659         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1660
1661 2019-11-12  Tom Tromey  <tom@tromey.com>
1662
1663         * tui/tui-win.c (resize_message): New global.
1664         (show_tui_resize_message): New function.
1665         (tui_async_resize_screen): Print message if requested.
1666         (_initialize_tui_win): Add tui-resize-message setting.
1667         * NEWS: Add entry for new commands.
1668
1669 2019-11-11  Tom Tromey  <tom@tromey.com>
1670
1671         * tui/tui.c (tui_initialize_readline): Add new bindable readline
1672         functions.
1673
1674 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
1675
1676         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1677
1678 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1679
1680         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1681         function.
1682         * python/python-internal.h (gdbpy_lookup_static_symbols):
1683         Declare new function.
1684         * python/python.c (python_GdbMethods): Add
1685         gdb.lookup_static_symbols method.
1686         * NEWS: Mention gdb.lookup_static_symbols.
1687
1688 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1689
1690         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1691         static block of current object file first.  Also fix typo in
1692         header comment.
1693
1694 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1695
1696         * stack.c (set_last_displayed_sal): Delete.
1697         (last_displayed_sal_valid): Delete.
1698         (last_displayed_pspace): Delete.
1699         (last_displayed_addr): Delete.
1700         (last_displayed_symtab): Delete.
1701         (last_displayed_line): Delete.
1702         (class last_displayed_symtab_info_type): New.
1703         (last_displayed_symtab_info): New static global variable.
1704         (print_frame_info): Call methods on last_displayed_symtab_info.
1705         (clear_last_displayed_sal): Update header comment, and make use of
1706         last_displayed_symtab_info.
1707         (last_displayed_sal_is_valid): Likewise.
1708         (get_last_displayed_pspace): Likewise.
1709         (get_last_displayed_addr): Likewise.
1710         (get_last_displayed_symtab): Likewise.
1711         (get_last_displayed_line): Likewise.
1712         (get_last_displayed_sal): Likewise.
1713         * stack.h (clear_last_displayed_sal): Update header comment.
1714         (last_displayed_sal_is_valid): Likewise.
1715         (get_last_displayed_pspace): Likewise.
1716         (get_last_displayed_addr): Likewise.
1717         (get_last_displayed_symtab): Likewise.
1718         (get_last_displayed_line): Likewise.
1719         (get_last_displayed_sal): Likewise.
1720
1721 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1722
1723         * stack.c (frame_show_address): Convert return type to bool.
1724         * stack.h (frame_show_address): Likewise, and update header
1725         comment.
1726
1727 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1728
1729         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1730         * unittests/vec-utils-selftests.c: New file.
1731         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1732
1733 2019-11-10  Tom Tromey  <tom@tromey.com>
1734
1735         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1736         (tui_highlight_win): Likewise.
1737         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1738         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1739         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1740         Don't set can_highlight.
1741
1742 2019-11-10  Tom Tromey  <tom@tromey.com>
1743
1744         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1745         Remove unused declaration.
1746
1747 2019-11-08  Tom Tromey  <tromey@adacore.com>
1748
1749         * top.c (read_command_file): Update.
1750         (command_line_input): Make return type const.
1751         * python/py-gdb-readline.c: Update.
1752         * linespec.c (decode_line_2): Update.
1753         * defs.h (command_line_input): Make return type const.
1754         * cli/cli-script.c (read_next_line): Make return type const.
1755         * ada-lang.c (get_selections): Update.
1756
1757 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
1758
1759         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1760         * mi/mi-main.c (output_cores): Likewise.
1761         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1762         (linux_xfer_osdata_modules): Likewise.
1763         * remote.c (register_remote_support_xml): Likewise.
1764         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1765         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1766
1767 2019-11-06  Tom Tromey  <tom@tromey.com>
1768
1769         * tui/tui-interp.c: Don't include readline.h.
1770         * tui/tui-hooks.c: Don't include readline.h.
1771         * symmisc.c: Include tilde.h, not readline.h.
1772         * symfile.c: Include tilde.h, not readline.h.
1773         * source.c: Include tilde.h, not readline.h.
1774         * solib.c: Include tilde.h, not readline.h.
1775         * psymtab.c: Include tilde.h, not readline.h.
1776         * exec.c: Include tilde.h, not readline.h.
1777         * corelow.c: Include tilde.h, not readline.h.
1778         * cli/cli-dump.c: Include tilde.h, not readline.h.
1779         * cli/cli-cmds.c: Don't include readline.h.
1780
1781 2019-11-05  Tom Tromey  <tom@tromey.com>
1782
1783         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1784         (tui_disassemble): Set addr_size.
1785         (tui_disasm_window::set_contents): Use addr_size.
1786
1787 2019-11-05  Tom Tromey  <tom@tromey.com>
1788
1789         * rust-lang.c (rust_language_defn): Update.
1790         * python/py-value.c (valpy_string): Call c_get_string.
1791         * p-lang.c (pascal_language_defn): Update.
1792         * opencl-lang.c (opencl_language_defn): Update.
1793         * objc-lang.c (objc_language_defn): Update.
1794         * m2-lang.c (m2_language_defn): Update.
1795         * language.c (unknown_language_defn, auto_language_defn): Update.
1796         (default_get_string): Remove.
1797         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1798         * go-lang.c (go_language_defn): Update.
1799         * f-lang.c (f_language_defn): Update.
1800         * d-lang.c (d_language_defn): Update.
1801         * c-lang.c (c_language_defn, cplus_language_defn)
1802         (asm_language_defn, minimal_language_defn): Update.
1803         * ada-lang.c (ada_language_defn): Update.
1804         * language.h (struct language_defn) <la_get_string>: Remove.
1805         (LA_GET_STRING): Remove.
1806         (default_get_string): Don't declare.
1807
1808 2019-11-05  Tom Tromey  <tom@tromey.com>
1809
1810         * tui/tui-source.h (struct tui_source_window): Inline
1811         constructor.  Remove destructor.
1812         <style_changed, m_observable>: Move to superclass.
1813         * tui/tui-winsource.h (tui_copy_source_line): Declare.
1814         (struct tui_source_window_base): Move private members to end.
1815         <style_changed, m_observable>: Move from tui_source_window.
1816         * tui/tui-winsource.c (tui_copy_source_line): Move from
1817         tui-source.c.  Rename from copy_source_line.  Add special handling
1818         for negative line number.
1819         (tui_source_window_base::style_changed): Move from
1820         tui_source_window.
1821         (tui_source_window_base): Register observer.
1822         (~tui_source_window_base): New.
1823         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1824         rename.
1825         (tui_source_window::set_contents): Use tui_copy_source_line.
1826         (tui_source_window::tui_source_window): Move to tui-source.h.
1827         (tui_source_window::~tui_source_window): Remove.
1828         (tui_source_window::style_changed): Move to superclass.
1829         * tui/tui-disasm.c (tui_disassemble): Create string file with
1830         styling, when possible.  Add "addr_size" parameter.
1831         (tui_disasm_window::set_contents): Use tui_copy_source_line.
1832         Don't compute maximum size.
1833         (len_without_escapes): New function
1834
1835 2019-11-05  Tom Tromey  <tom@tromey.com>
1836
1837         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1838         std::string.
1839         * tui/tui-winsource.c (tui_show_source_line): Update.
1840         * tui/tui-source.c (tui_source_window::set_contents): Update.
1841         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1842
1843 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
1844
1845         * symtab.h (gdb_static_assert): Put && operator at the beginning
1846         of the line instead of the end.
1847
1848 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
1849
1850         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1851         and sizeof (symbol).
1852         * symtab.h: Add a static_assert for sizeof (partial_symbol).
1853
1854 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1855
1856         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1857         * configure.host: Mark *-*-solaris2.10* obsolete.
1858         * configure.tgt: Mark Solaris < 11 obsolete.
1859         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1860         Update target triplet.
1861
1862 2019-11-01  Tom Tromey  <tromey@adacore.com>
1863
1864         * utils.c (print_sys_errmsg): Simplify.
1865
1866 2019-11-01  Tom Tromey  <tromey@adacore.com>
1867
1868         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1869
1870 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
1871
1872         * configure: Regenerate.
1873         * configure.ac: Remove check for strerror_r.
1874         * gdbsupport/common.m4: Check for strerror_r.
1875
1876 2019-11-01  Luis Machado  <luis.machado@linaro.org>
1877
1878         PR gdb/25124
1879
1880         * arm-tdep.c (arm_per_objfile): Rename to ...
1881         (arm_per_bfd): ... this.
1882         (arm_objfile_data_key): Rename to ...
1883         (arm_bfd_data_key): ... this.
1884         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1885         data.
1886         (arm_record_special_symbol): Likewise.
1887
1888 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1889
1890         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1891         end.
1892         * c-typeprint.c (c_print_typedef): Likewise.
1893         * f-typeprint.c (f_print_typedef): Likewise.
1894         * m2-typeprint.c (m2_print_typedef): Likewise.
1895         * p-typeprint.c (pascal_print_typedef): Likewise.
1896         * rust-lang.c (rust_print_typedef): Likewise.
1897         * symtab.c (print_symbol_info): Print a newline after calling
1898         typedef_print.
1899
1900 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1901
1902         * symtab.c (info_module_cmdlist): New variable.
1903         (info_module_command): New function.
1904         (search_module_symbols): New function.
1905         (info_module_subcommand): New function.
1906         (struct info_modules_var_func_options): New struct.
1907         (info_modules_var_func_options_defs): New variable.
1908         (make_info_modules_var_func_options_def_group): New function.
1909         (info_module_functions_command): New function.
1910         (info_module_variables_command): New function.
1911         (info_module_var_func_command_completer): New function.
1912         (_initialize_symtab): Register new 'info module functions' and
1913         'info module variables' commands.
1914         * symtab.h (typedef symbol_search_in_module): New typedef.
1915         (search_module_symbols): Declare new function.
1916         * NEWS: Mention new commands.
1917
1918 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1919
1920         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1921         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1922         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1923         MODULES_DOMAIN.
1924         (scan_partial_symbols): Only create partial module symbols for non
1925         declarations.
1926         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
1927         and MODULES_DOMAIN.
1928         * symtab.c (search_domain_name): Likewise.
1929         (search_symbols): Likewise.
1930         (print_symbol_info): Likewise.
1931         (symtab_symbol_info): Likewise.
1932         (info_modules_command): New function.
1933         (_initialize_symtab): Register 'info modules' command.
1934         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
1935         * NEWS: Mention new 'info modules' command.
1936
1937 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1938
1939         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
1940         and $_gdb_maint_setting_str.
1941
1942 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1943
1944         * cli/cli-cmds.c (setting_cmd, value_from_setting)
1945         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
1946         (str_value_from_setting, gdb_setting_str_internal_fn)
1947         (gdb_maint_setting_str_internal_fn): New functions.
1948         (_initialize_cli_cmds): Define the new convenience functions.
1949         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
1950         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
1951
1952 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1953
1954         * agent.c (set_can_use_agent): When the setting is turned on,
1955         look up agent symbols if we don't have them yet.
1956         (agent_new_objfile): Don't look up agent symbols when the agent
1957         setting is off.
1958
1959 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1960
1961         * config.in: Regenerate.
1962
1963 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1964
1965         * configure: Regenerate.
1966         * configure.ac: Check for strerror_r.
1967         * gdbsupport/common-utils.h (safe_strerror): Change return value
1968         to const char * and document that this function is now threadsafe.
1969         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
1970         thread_local and call strerror_r, if available.
1971         * utils.c (perror_string): Update.
1972         (print_sys_errmsg): Update.
1973
1974 2019-10-31  Luis Machado  <luis.machado@linaro.org>
1975
1976         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
1977         objfile_key.
1978         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
1979         objfile to fetch per-bfd data.
1980         (arm_find_exidx_entry): Likewise.
1981
1982 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1983
1984         * gdbsupport/agent.c (debug_agent): Change type to bool.
1985         (use_agent): Likewise.
1986         (all_agent_symbols_look_up): Likewise.
1987         (agent_loaded_p): Change return value to bool.
1988         (agent_look_up_symbols): Update.
1989         (agent_capability_check): Change return value to bool.
1990         * gdbsupport/agent.h (agent_loaded_p): Likewise.
1991         (debug_agent): Change type to bool.
1992         (use_agent): Likewise.
1993         (agent_capability_check): Change return value to bool.
1994
1995 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
1996
1997         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
1998         (build_minimal_symbol_hash_tables): Code to clear the table moved
1999         to clear_minimal_symbol_hash_tables.
2000         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2001         when needed.
2002
2003 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2004
2005         * infcmd.c: Remove includes.
2006         * infrun.c: Remove includes.
2007
2008 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2009
2010         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2011         (grow_vect): Remove declaration.
2012         (ada_type_of_array): Remove declaration.
2013         (ada_update_initial_language): Remove declaration.
2014         (ada_fold_name): Remove declaration.
2015         (ada_fill_in_ada_prototype): Remove declaration.
2016         (user_select_syms): Remove declaration.
2017         (get_selections): Remove declaration.
2018         (ada_tag_type): Remove declaration.
2019         (ada_value_tag): Remove declaration.
2020         (ada_is_others_clause): Remove declaration.
2021         (ada_in_variant): Remove declaration.
2022         (ada_value_struct_elt): Remove declaration.
2023         (ada_attribute_name): Remove declaration.
2024         (ada_system_address_type): Remove declaration.
2025         * ada-lang.c (ada_watch_location_expression): Make static.
2026         (GROW_VECT): Move here from ada-lang.h.
2027         (grow_vect): Make static.
2028         (ada_update_initial_language): Make static.
2029         (ada_fold_name): Make static.
2030         (ada_type_of_array): Make static.
2031         (encoded_ordered_before): Move up.
2032         (sort_choices): Move up.
2033         (print_signatures): Move up.
2034         (ada_print_symbol_signature): Move up.
2035         (get_selections): Move up and make static.
2036         (user_select_syms): Move up and make static.
2037         (ada_value_struct_elt): Move up and make static.
2038         (ada_tag_type): Make static.
2039         (ada_value_tag): Make static.
2040         (ada_is_others_clause): Make static.
2041         (ada_in_variant): Make static.
2042         (ada_attribute_name): Make static.
2043
2044 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2045
2046         * ada-lang.c: Remove includes.
2047         * ada-typeprint.c: Remove includes.
2048         * ada-valprint.c: Remove includes.
2049
2050 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
2051
2052         * addrmap.c: Add static assertions of type size, moved from
2053         _initialize_addrmap.
2054         (_initialize_addrmap): Remove.
2055
2056 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2057
2058         * coffread.c (record_minimal_symbol): Update.
2059         (process_coff_symbol): Update.
2060         * dbxread.c (read_dbx_symtab): Update.
2061         * dwarf2read.c (add_partial_symbol): Update.
2062         (fixup_go_packaging): Update.
2063         (load_partial_dies): Update.
2064         (new_symbol): Update.
2065         * elfread.c (record_minimal_symbol): Change signature to use
2066         gdb::string_view instead of name+len.
2067         (elf_symtab_read): Update.
2068         (elf_rel_plt_read): Update.
2069         * mdebugread.c (parse_partial_symbols): Update.
2070         (handle_psymbol_enumerators): Update.
2071         (new_symbol): Update.
2072         * minsyms.c (minimal_symbol_reader::record_full): Change signature
2073         to use gdb::string_view instead of name+len.
2074         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2075         * psympriv.h (add_psymbol_to_list): Likewise.
2076         * psymtab.c (add_psymbol_to_bcache): Likewise.
2077         (add_psymbol_to_list): Likewise.
2078         * stabsread.c (define_symbol): Update.
2079         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2080         * symtab.h (SYMBOL_SET_NAMES): Likewise.
2081         (symbol_set_names): Likewise.
2082         * xcoffread.c (scan_xcoff_symtab): Update.
2083
2084 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2085
2086         * symtab.h (symbol_set_names): Document that copy_name must be
2087         set to true for non-nullterminated strings.
2088         * symtab.c (symbol_set_names): Only make a nullterminated copy of
2089         linkage_name if the entry was not found and we need to demangle.
2090
2091 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2092
2093         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2094         * dwarf2-frame.c (bsearch_fde_cmp): Update.
2095         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2096         * gdbsupport/gdb_binary_search.h: New file.
2097
2098 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2099
2100         * NEWS: Mention new --with-system-gdbinit-dir option.
2101         * config.in: Regenerate.
2102         * configure: Regenerate.
2103         * configure.ac: Add new option --with-system-gdbinit-dir.
2104         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2105         for a ".gdb" suffix.
2106         * main.c (get_init_files): Change system_gdbinit argument to
2107         a vector and return the files in SYSTEM_GDBINIT_DIR in
2108         addition to SYSTEM_GDBINIT.
2109         (captured_main_1): Update.
2110         (print_gdb_help): Update.
2111         * top.c (print_gdb_configuration): Also print the value of
2112         SYSTEM_GDBINIT_DIR.
2113
2114 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
2115
2116         * gdbsupport/common-utils.h (startswith): Add an overloaded version
2117         that takes gdb::string_view arguments.
2118
2119 2019-10-26  Tom de Vries  <tdevries@suse.de>
2120
2121         * aarch64-linux-tdep.c: Fix typos in comments.
2122         * aarch64-tdep.c: Same.
2123         * ada-lang.c: Same.
2124         * amd64-nat.c: Same.
2125         * arc-tdep.c: Same.
2126         * arch/aarch64-insn.c: Same.
2127         * block.c: Same.
2128         * breakpoint.h: Same.
2129         * btrace.h: Same.
2130         * c-varobj.c: Same.
2131         * cli/cli-decode.c: Same.
2132         * cli/cli-script.c: Same.
2133         * cli/cli-utils.h: Same.
2134         * coff-pe-read.c: Same.
2135         * coffread.c: Same.
2136         * compile/compile-cplus-symbols.c: Same.
2137         * compile/compile-object-run.c: Same.
2138         * completer.c: Same.
2139         * corelow.c: Same.
2140         * cp-support.c: Same.
2141         * demangle.c: Same.
2142         * dwarf-index-write.c: Same.
2143         * dwarf2-frame.c: Same.
2144         * dwarf2-frame.h: Same.
2145         * eval.c: Same.
2146         * frame-base.h: Same.
2147         * frame.h: Same.
2148         * gdbcmd.h: Same.
2149         * gdbtypes.h: Same.
2150         * gnu-nat.c: Same.
2151         * guile/scm-objfile.c: Same.
2152         * i386-tdep.c: Same.
2153         * i386-tdep.h: Same.
2154         * infcall.c: Same.
2155         * infcall.h: Same.
2156         * linux-nat.c: Same.
2157         * m68k-tdep.c: Same.
2158         * macroexp.c: Same.
2159         * memattr.c: Same.
2160         * mi/mi-cmd-disas.c: Same.
2161         * mi/mi-getopt.h: Same.
2162         * mi/mi-main.c: Same.
2163         * minsyms.c: Same.
2164         * nat/aarch64-sve-linux-sigcontext.h: Same.
2165         * objfiles.h: Same.
2166         * ppc-linux-nat.c: Same.
2167         * ppc-linux-tdep.c: Same.
2168         * ppc-tdep.h: Same.
2169         * progspace.h: Same.
2170         * prologue-value.h: Same.
2171         * python/py-evtregistry.c: Same.
2172         * python/py-instruction.h: Same.
2173         * record-btrace.c: Same.
2174         * record-full.c: Same.
2175         * remote.c: Same.
2176         * rs6000-tdep.c: Same.
2177         * ser-tcp.c: Same.
2178         * sol-thread.c: Same.
2179         * sparc-sol2-tdep.c: Same.
2180         * sparc64-tdep.c: Same.
2181         * stabsread.c: Same.
2182         * symfile.c: Same.
2183         * symtab.h: Same.
2184         * target.c: Same.
2185         * tracepoint.c: Same.
2186         * tui/tui-data.h: Same.
2187         * tui/tui-io.c: Same.
2188         * tui/tui-win.c: Same.
2189         * tui/tui.c: Same.
2190         * unittests/rsp-low-selftests.c: Same.
2191         * user-regs.h: Same.
2192         * utils.c: Same.
2193         * utils.h: Same.
2194         * valarith.c: Same.
2195         * valops.c: Same.
2196         * valprint.c: Same.
2197         * valprint.h: Same.
2198         * value.c: Same.
2199         * value.h: Same.
2200         * varobj.c: Same.
2201         * x86-nat.h: Same.
2202         * xtensa-tdep.c: Same.
2203
2204 2019-10-25  Ali Tamur <tamur@google.com>
2205
2206         * charset.c (find_charset_names): Reflect API change.
2207
2208 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
2209
2210         * symtab.c (struct demangled_name_entry): Change demangled name
2211         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2212         part of the struct anymore.
2213         (symbol_set_names): No longer obstack allocate + copy the demangled
2214         name, just store the allocated name from bfd.
2215
2216 2019-10-25  Tom Tromey  <tromey@adacore.com>
2217
2218         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2219         (bsearch_cie_cmp, add_cie): Remove.
2220         (find_cie): Reimplement.
2221         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
2222         (dwarf2_build_frame_info): Update.
2223
2224 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
2225
2226         PR gdb/25126
2227         * symfile.c (reread_symbols): Call forget_cached_source_info to
2228         clear the stale source cache.
2229
2230 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2231
2232         * configure: Regenerate.
2233         * configure.ac: Remove code that sets python_has_threads.
2234
2235 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2236
2237         * config.in: Regenerate.
2238         * configure: Regenerate.
2239         * configure.ac: Remove the code that uses sed to get the python
2240         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2241
2242 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2243
2244         * python/py-progspace.c (pspy_block_for_pc): Return None for all
2245         error paths.
2246
2247 2019-10-23  Tom Tromey  <tom@tromey.com>
2248
2249         * arc-tdep.c: Remove ".." from include.
2250         * frv-tdep.c: Remove ".." from include.
2251         * lm32-tdep.c: Remove ".." from include.
2252         * microblaze-tdep.c: Remove ".." from include.
2253         * or1k-tdep.h: Remove ".." from include.
2254         * s12z-tdep.c: Remove ".." from include.
2255         * Makefile.in (OPCODES_CFLAGS): Add comment.
2256         (TOP_CFLAGS): New variable.
2257         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2258
2259 2019-10-23  Tom Tromey  <tom@tromey.com>
2260
2261         * Makefile.in (READLINE_DIR): Update.
2262
2263 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2264
2265         * infcall.c (call_function_by_hand_dummy): Fix the function
2266         comment.  And extract out a code section into...
2267         (reserve_stack_space): ...this new function.
2268
2269 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2270
2271         * infcall.c (value_arg_coerce): Remove an unused parameter.
2272         (call_function_by_hand_dummy): Update the call to
2273         'value_arg_coerce'.
2274
2275 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2276
2277         * infcall.c (call_function_by_hand_dummy): Refactor.
2278
2279 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2280
2281         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2282
2283 2019-10-23  Tom Tromey  <tom@tromey.com>
2284
2285         * configure: Rebuild.
2286         * configure.ac: Don't check for sigprocmask.
2287         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2288
2289 2019-10-23  Tom Tromey  <tom@tromey.com>
2290
2291         * configure: Rebuild.
2292         * acinclude.m4: Use m4_include, not sinclude.
2293
2294 2019-10-23  Tom de Vries  <tdevries@suse.de>
2295
2296         PR breakpoints/24687
2297         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2298
2299 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2300
2301         * symtab.c (struct demangled_name_entry) <language>: Change from
2302         bitfield to regular variable.
2303
2304 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2305
2306         * symtab.c (struct demangled_name_entry): Add a constructor.
2307         (free_demangled_name_entry): New function to call the destructor
2308         for demangled_name_entry.
2309         (create_demangled_names_hash): Pass free_demangled_name_entry to
2310         htab_create_alloc.
2311         (symbol_set_names): Call placement new for demangled_name_entry.
2312         * utils.c: No longer include xxhash.h here, now that fast_hash
2313         is inlined in the header.
2314         * utils.h: Instead, include it here.
2315
2316 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2317
2318         * Makefile.in: Link with libxxhash.
2319         * config.in: Regenerate.
2320         * configure: Regenerate.
2321         * configure.ac: Search for libxxhash.
2322         * utils.c (fast_hash): Use xxhash if present.
2323
2324 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2325
2326         * utils.h (fast_hash): New function.
2327         * symtab.c (hash_demangled_name_entry): Call new function
2328         fast_hash.
2329
2330 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2331
2332         * symtab.c (struct demangled_name_entry): Change type of mangled
2333         to gdb::string_view. Also adds a constructor that takes the
2334         mangled name.
2335         (hash_demangled_name_entry): Update.
2336         (eq_demangled_name_entry): Update.
2337         (free_demangled_name_entry): New function to call the destructor
2338         now that this is not a POD anymore.
2339         (create_demangled_names_hash): Pass free_demangled_name_entry to
2340         htab_create_alloc.
2341         (symbol_set_names): Update.
2342
2343 2019-10-21  Ali Tamur  <tamu@google.com>
2344
2345         * dwarf2read.c (dir_index): Change type.
2346         (file_name_index): Likewise.
2347         (line_header::include_dir_at): Change comment and implementation on
2348         whether it is DWARF 5.
2349         (line_header::is_valid_file_index): New function.
2350         (line_header::file_name_at): Change comment and implementation on
2351         whether it is DWARF 5.
2352         (line_header::file_names): Change to private field renamed as
2353         m_file_names and introduce a new accessor method.
2354         (line_header::file_names_size): New method.
2355         (line_header::include_dirs): Change to private field and rename as
2356         m_include_dirs.
2357         (dw2_get_file_names_reader): Define local var at a smaller scope and
2358         reflect API change.
2359         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2360         (process_structure_scope): Likewise.
2361         (line_header::add_include_dir): Change message and reflect renaming.
2362         (line_header::add_file_name): Likewise.
2363         (read_formatted_entries): Handle DW_FORM_data16.
2364         (dwarf_decode_line_header): Fix line header length calculation.
2365         (psymtab_include_file_name): Change comment and API.
2366         (lnp_state_machine::m_file): Update comment and reflect type change.
2367         (lnp_state_machine::record_line): Reflect type change.
2368         (dwarf_decode_lines): Reflect API change.
2369         (file_file_name): Likewise.
2370         (file_full_name): Likewise.
2371
2372 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2373
2374         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2375
2376 2019-10-21  Tom Tromey  <tom@tromey.com>
2377
2378         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2379
2380 2019-10-21  Tom Tromey  <tom@tromey.com>
2381
2382         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
2383         NM_H.   Use AC_CONFIG_LINKS.
2384         * configure: Rebuild.
2385         * Makefile.in (NM_H): New variable.
2386         (generated_files): Add NM_H.  Remove gcore.
2387         (nm.h, stamp-nmh): New targets.
2388
2389 2019-10-20  Tom Tromey  <tom@tromey.com>
2390
2391         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2392         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
2393         obsolete comment.
2394         (put_objfile_before): Now static.
2395
2396 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
2397
2398         * gdbsupport/common-utils.h (startswith): Change return type to
2399         bool.
2400
2401 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
2402
2403         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2404         * breakpoint.c (bp_locations_compare): Rename to...
2405         (bp_location_is_less_than): ...this, and change to std::sort semantics.
2406         (update_global_location_list): Use std::sort instead of qsort.
2407         * buildsym.c (compare_line_numbers): Rename to...
2408         (lte_is_less_than): ...this, and change to std::sort semantics.
2409         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2410         instead of qsort.
2411         * disasm.c (compare_lines): Rename to...
2412         (line_is_less_than): ...this, and change to std::sort semantics.
2413         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2414         of qsort.
2415         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2416         (fde_is_less_than): ...this, and change to std::sort semantics.
2417         (dwarf2_build_frame_info): Call std::sort instead of qsort.
2418         * mdebugread.c (compare_blocks):
2419         (block_is_less_than): ...this, and change to std::sort semantics.
2420         (sort_blocks): Call std::sort instead of qsort.
2421         * objfiles.c (qsort_cmp): Rename to...
2422         (sort_cmp): ...this, and change to std::sort semantics.
2423         (update_section_map): Call std::sort instead of qsort.
2424         * remote.c (compare_pnums): Remove.
2425         (map_regcache_remote_table): Call std::sort instead of qsort.
2426         * utils.c (compare_positive_ints): Remove.
2427         * utils.h (compare_positive_ints): Remove.
2428         * xcoffread.c (compare_lte): Remove.
2429         (arrange_linetable): Call std::sort instead of qsort.
2430
2431 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
2432
2433         * symfile.c (init_entry_point_info): Fix typo.
2434         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2435
2436 2019-10-18  Tom de Vries  <tdevries@suse.de>
2437
2438         * aarch64-tdep.c: Fix typos in comments.
2439         * ada-lang.c: Same.
2440         * ada-tasks.c: Same.
2441         * alpha-tdep.c: Same.
2442         * alpha-tdep.h: Same.
2443         * amd64-nat.c: Same.
2444         * amd64-windows-tdep.c: Same.
2445         * arc-tdep.c: Same.
2446         * arc-tdep.h: Same.
2447         * arch-utils.c: Same.
2448         * arm-nbsd-tdep.c: Same.
2449         * arm-tdep.c: Same.
2450         * ax-gdb.c: Same.
2451         * blockframe.c: Same.
2452         * btrace.c: Same.
2453         * c-varobj.c: Same.
2454         * coff-pe-read.c: Same.
2455         * coffread.c: Same.
2456         * cris-tdep.c: Same.
2457         * darwin-nat.c: Same.
2458         * dbxread.c: Same.
2459         * dcache.c: Same.
2460         * disasm.c: Same.
2461         * dtrace-probe.c: Same.
2462         * dwarf-index-write.c: Same.
2463         * dwarf2-frame-tailcall.c: Same.
2464         * dwarf2-frame.c: Same.
2465         * dwarf2read.c: Same.
2466         * eval.c: Same.
2467         * exceptions.c: Same.
2468         * fbsd-tdep.c: Same.
2469         * findvar.c: Same.
2470         * frame.c: Same.
2471         * frv-tdep.c: Same.
2472         * gnu-v3-abi.c: Same.
2473         * go32-nat.c: Same.
2474         * h8300-tdep.c: Same.
2475         * hppa-tdep.c: Same.
2476         * i386-linux-tdep.c: Same.
2477         * i386-tdep.c: Same.
2478         * ia64-libunwind-tdep.c: Same.
2479         * ia64-tdep.c: Same.
2480         * infcmd.c: Same.
2481         * infrun.c: Same.
2482         * linespec.c: Same.
2483         * linux-nat.c: Same.
2484         * linux-thread-db.c: Same.
2485         * machoread.c: Same.
2486         * mdebugread.c: Same.
2487         * mep-tdep.c: Same.
2488         * mn10300-tdep.c: Same.
2489         * namespace.c: Same.
2490         * objfiles.c: Same.
2491         * opencl-lang.c: Same.
2492         * or1k-tdep.c: Same.
2493         * osabi.c: Same.
2494         * ppc-linux-nat.c: Same.
2495         * ppc-linux-tdep.c: Same.
2496         * ppc-sysv-tdep.c: Same.
2497         * printcmd.c: Same.
2498         * procfs.c: Same.
2499         * record-btrace.c: Same.
2500         * record-full.c: Same.
2501         * remote-fileio.c: Same.
2502         * remote.c: Same.
2503         * rs6000-tdep.c: Same.
2504         * s12z-tdep.c: Same.
2505         * score-tdep.c: Same.
2506         * ser-base.c: Same.
2507         * ser-go32.c: Same.
2508         * skip.c: Same.
2509         * sol-thread.c: Same.
2510         * solib-svr4.c: Same.
2511         * solib.c: Same.
2512         * source.c: Same.
2513         * sparc-nat.c: Same.
2514         * sparc-sol2-tdep.c: Same.
2515         * sparc-tdep.c: Same.
2516         * sparc64-tdep.c: Same.
2517         * stabsread.c: Same.
2518         * stack.c: Same.
2519         * symfile.c: Same.
2520         * symtab.c: Same.
2521         * target-descriptions.c: Same.
2522         * target-float.c: Same.
2523         * thread.c: Same.
2524         * utils.c: Same.
2525         * valops.c: Same.
2526         * valprint.c: Same.
2527         * value.c: Same.
2528         * varobj.c: Same.
2529         * windows-nat.c: Same.
2530         * xcoffread.c: Same.
2531         * xstormy16-tdep.c: Same.
2532         * xtensa-tdep.c: Same.
2533
2534 2019-10-17  Tom Tromey  <tromey@adacore.com>
2535
2536         * configure: Rebuild.
2537         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
2538         in AC_CONFIG_FILES invocation.
2539         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2540         new-style config.status invocation.
2541
2542 2019-10-17  Tom de Vries  <tdevries@suse.de>
2543
2544         * arm-nbsd-nat.c: Fix typos in comments.
2545         * arm-tdep.c: Same.
2546         * darwin-nat-info.c: Same.
2547         * dwarf2read.c: Same.
2548         * elfread.c: Same.
2549         * event-top.c: Same.
2550         * findvar.c: Same.
2551         * gdbtypes.c: Same.
2552         * hppa-tdep.c: Same.
2553         * i386-tdep.c: Same.
2554         * jit.c: Same.
2555         * main.c: Same.
2556         * mdebugread.c: Same.
2557         * moxie-tdep.c: Same.
2558         * nto-procfs.c: Same.
2559         * osabi.c: Same.
2560         * ppc-linux-tdep.c: Same.
2561         * remote.c: Same.
2562         * riscv-tdep.c: Same.
2563         * s390-tdep.c: Same.
2564         * sh-tdep.c: Same.
2565         * sparc-linux-tdep.c: Same.
2566         * sparc-nat.c: Same.
2567         * stack.c: Same.
2568         * target-descriptions.c: Same.
2569         * top.c: Same.
2570         * varobj.c: Same.
2571
2572 2019-10-16  Tom Tromey  <tom@tromey.com>
2573
2574         * objfiles.h (struct objfile) <original_name>: Now const.
2575
2576 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2577
2578         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2579         pass on to sigsetjmp's second argument.
2580         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2581
2582 2019-10-16  Keith Seitz  <keiths@redhat.com>
2583
2584         PR gdb/23567
2585         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2586         sections whose size is greater than the file size.
2587
2588 2019-10-16  Jim Wilson  <jimw@sifive.com>
2589
2590         * riscv-tdep.c (riscv_gcc_target_options): New.
2591         (riscv_gnu_triplet_regexp): New.
2592         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2593         set_gdbarch_gnu_triplet_regexp.
2594
2595 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2596
2597         * Makefile.in: Add xml-builtin.h.
2598         * features/feature_to_c.sh: Add an include for xml-builtin.h
2599         to ensure that the compiler checks that the types match.
2600         * xml-builtin.h: New file.
2601         * xml-support.c (fetch_xml_builtin): Add missing const.
2602         * xml-support.h: Remove declaration of xml_builtins.
2603
2604 2019-10-16  Tom de Vries  <tdevries@suse.de>
2605
2606         PR tdep/25096
2607         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2608         (amd64_classify_aggregate): ... here.
2609         (amd64_classify_aggregate_field): Handled fiels of nested structs
2610         recursively.
2611
2612 2019-10-16  Tom de Vries  <tdevries@suse.de>
2613
2614         PR tdep/24104
2615         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2616         that handles 'theclass'.
2617
2618 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2619
2620         * linespec.c (decode_digits_ordinary): Update comment.
2621         * make-target-delegates: No longer need to handle VEC case.
2622         * memrange.c (normalize_mem_ranges): Update comment.
2623         * namespace.c (add_using_directive): Update comment.
2624         * objc-lang.c (uniquify_strings): Update comment.
2625         * ppc-linux-nat.c (struct thread_points): Update comment.
2626         * probe.h (find_probes_in_objfile): Update comment.
2627         * target.h (enum flash_preserve_mode): Update comment.
2628         * varobj.c (varobj_restrict_range): Update comment.
2629         * varobj.h (varobj_list_children): Update comment.
2630
2631 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2632
2633         * Makefile.in: Remove references to vec.h and vec.c.
2634         * aarch64-tdep.c: No longer include vec.h.
2635         * ada-lang.c: Likewise.
2636         * ada-lang.h: Likewise.
2637         * arm-tdep.c: Likewise.
2638         * ax.h: Likewise.
2639         * breakpoint.h: Likewise.
2640         * charset.c: Likewise.
2641         * cp-support.h: Likewise.
2642         * dtrace-probe.c: Likewise.
2643         * dwarf2read.c: Likewise.
2644         * extension.h: Likewise.
2645         * gdb_bfd.c: Likewise.
2646         * gdbsupport/gdb_vecs.h: Likewise.
2647         * gdbsupport/vec.c: Remove.
2648         * gdbsupport/vec.h: Remove.
2649         * gdbthread.h: Likewise.
2650         * guile/scm-type.c: Likewise.
2651         * inline-frame.c: Likewise.
2652         * machoread.c: Likewise.
2653         * memattr.c: Likewise.
2654         * memrange.h: Likewise.
2655         * namespace.h: Likewise.
2656         * nat/linux-btrace.h: Likewise.
2657         * osdata.c: Likewise.
2658         * parser-defs.h: Likewise.
2659         * progspace.h: Likewise.
2660         * python/py-type.c: Likewise.
2661         * record-btrace.c: Likewise.
2662         * rust-exp.y: Likewise.
2663         * solib-target.c: Likewise.
2664         * stap-probe.c: Likewise.
2665         * target-descriptions.c: Likewise.
2666         * target-memory.c: Likewise.
2667         * target.h: Likewise.
2668         * varobj.c: Likewise.
2669         * varobj.h: Likewise.
2670         * xml-support.h: Likewise.
2671
2672 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2673
2674         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2675         Update for new std::vector based implementation.
2676         (process_psymtab_comp_unit_reader): Likewise.
2677         (scan_partial_symbols): Likewise.
2678         (recursively_compute_inclusions): Likewise.
2679         (compute_compunit_symtab_includes): Likewise.
2680         (process_imported_unit_die): Likewise.
2681         (queue_and_load_dwo_tu): Likewise.
2682         (follow_die_sig_1): Likewise.
2683         * gdb/dwarf2read.h: Remove DEF_VEC_P.
2684         (typedef dwarf2_per_cu_ptr): Remove.
2685         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2686         function.
2687         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2688         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2689         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2690         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2691         std::vector.
2692
2693 2019-10-15  Tom Tromey  <tromey@adacore.com>
2694
2695         * windows-nat.c (windows_nat_target::resume): Use %x when logging
2696         TID.
2697
2698 2019-10-15  Tom Tromey  <tromey@adacore.com>
2699
2700         * windows-nat.c (windows_nat_target::fetch_registers)
2701         (windows_nat_target::store_registers): Rename "pid" to "tid".
2702
2703 2019-10-15  Tom Tromey  <tromey@adacore.com>
2704
2705         * gdbarch.h, gdbarch.c: Rebuild.
2706         * gdbarch.sh (gcc_target_options): Change return type to
2707         std::string.
2708         * compile/compile.c (get_args): Update.
2709         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2710         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2711         std::string.
2712         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2713         std::string.
2714         * arch-utils.c (default_gcc_target_options): Return std::string.
2715         * arch-utils.h (default_gcc_target_options): Return std::string.
2716         * s390-tdep.c (s390_gcc_target_options): Return std::string.
2717
2718 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2719
2720         * breakpoint.c (breakpoint_chain): Make static.
2721         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2722         of accessing breakpoint_chain.
2723
2724 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2725
2726         * breakpoint.c (iterate_over_breakpoints): Change function pointer
2727         to a gdb::function_view and return value to bool.
2728         * breakpoint.h (iterate_over_breakpoints): Likewise.
2729         * dummy-frame.c (pop_dummy_frame_bpt): Update.
2730         (pop_dummy_frame): Update.
2731         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2732         (gdbscm_breakpoints): Update.
2733         * python/py-breakpoint.c (build_bp_list): Update.
2734         (gdbpy_breakpoints): Update.
2735         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2736         Update.
2737         (bpfinishpy_handle_stop): Update.
2738         (bpfinishpy_handle_exit): Update.
2739         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2740         (svr4_update_solib_event_breakpoints): Update.
2741
2742 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
2743
2744         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2745         when unwrapping single-field structs.
2746
2747 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
2748
2749         * dwarf2read.c: Remove includes.
2750
2751 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
2752
2753         * ui-out.c (ui_out::call_do_message): Silence
2754         -Wformat-nonliteral warning.
2755
2756 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
2757
2758         * breakpoint.c: Remove some includes: continuations.h, skip.h,
2759         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
2760         include: readline/tilde.h.
2761
2762 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2763
2764         * remote.c (remote_target::get_trace_status): Remove declaration of
2765         trace_regblock_size.
2766
2767 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2768
2769         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2770         (show_user): Remove declaration of cmdlist.
2771         * cli/cli-cmds.h (max_user_call_depth): Declare.
2772         * cli/cli-script.c (execute_user_command): Remove declaration
2773         of max_user_call_depth.
2774
2775 2019-10-11  Jim Wilson  <jimw@sifive.com>
2776
2777         * gdbsupport/print-utils.h (pulongest): Fix comment.
2778         (plongest): Likewise.
2779         (phex): Add missing comment, mention leading zeros.
2780         (phex_nz): Add mention of no leading zeros to comment.
2781
2782         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2783         plongest instead of unsigned long long cast.
2784
2785 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2786
2787         * main.c (captured_main_1): Include gdbtk.h and remove declarations
2788         for external_editor_command and gdbtk_test.
2789
2790 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2791
2792         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2793         * varobj.c (varobjdebug): Move comment to...
2794         * varobj.h (varobjdebug): ...here, and declare.
2795
2796 2019-10-09  Tom Tromey  <tom@tromey.com>
2797
2798         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2799         erase_data_content.
2800
2801 2019-10-09  Tom Tromey  <tom@tromey.com>
2802
2803         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2804         * tui/tui-stack.c (tui_locator_window::rerender): Update.
2805         * tui/tui-command.c (tui_cmd_window::resize)
2806         (tui_refresh_cmd_win): Update.
2807         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2808         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2809         * tui/tui-data.c (~tui_gen_win_info): Remove.
2810         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2811         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2812         (tui_redisplay_readline, tui_mld_flush)
2813         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2814         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2815         (tui_data_window::erase_data_content)
2816         (tui_data_item_window::rerender)
2817         (tui_data_item_window::refresh_window): Update.
2818         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2819         (box_win, tui_gen_win_info::make_window)
2820         (tui_gen_win_info::make_visible): Update.
2821         (tui_delete_win): Remove.
2822         * tui/tui-winsource.c
2823         (tui_source_window_base::do_erase_source_content): Update.
2824         (tui_show_source_line, tui_source_window_base::update_tab_width)
2825         (tui_source_window_base::update_exec_info): Update.
2826         * tui/tui-data.h (struct curses_deleter): New.
2827         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2828         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2829
2830 2019-10-09  Tom Tromey  <tom@tromey.com>
2831
2832         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2833
2834 2019-10-09  Tom Tromey  <tom@tromey.com>
2835
2836         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2837         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2838
2839 2019-10-09  Tom Tromey  <tom@tromey.com>
2840
2841         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2842         window height directly.
2843         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2844         declare.
2845         * tui/tui-layout.c (tui_default_win_height): Remove.
2846         (tui_default_win_viewport_height): Remove.
2847
2848 2019-10-09  Tom Tromey  <tom@tromey.com>
2849
2850         * tui/tui.h: Remove comments.
2851
2852 2019-10-09  Tom de Vries  <tdevries@suse.de>
2853
2854         * python/lib/gdb/printer/bound_registers.py: Use
2855         '^builtin_type_bound128' as regexp argument for
2856         add_builtin_pretty_printer.
2857
2858 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
2859
2860         * guile/guile.c (guile_extension_script_ops): Remove forward
2861         declaration and mark as static.
2862         (guile_script_ops): Likewise.
2863         (extension_language_guile): Move further down in the file so
2864         it can reference the definitions for guile_{extension_,}script_ops.
2865
2866 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
2867
2868         * s390-tdep.c (390_process_record): Handle new arch13 instructions
2869         except SORTL, DFLTCC, and KDSA.
2870
2871 2019-10-08  Tom Tromey  <tromey@adacore.com>
2872
2873         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2874         (struct safe_symbol_file_add_args): Remove.
2875
2876 2019-10-08  Tom Tromey  <tromey@adacore.com>
2877
2878         * windows-nat.c: Don't include buildsym-legacy.h.
2879
2880 2019-10-08  Tom Tromey  <tromey@adacore.com>
2881
2882         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2883
2884 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2885
2886         * gdbtypes.c (overload_debug): Move comment to header.
2887         * gdbtypes.h (overload_debug): Declare.
2888         * valops.c: Remove declaration of overload_debug, instead
2889         include gdbtypes.h.
2890
2891 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2892
2893         * language.c (show_language_command): Pass lang_frame_mismatch_warn
2894         through _().
2895         (lang_frame_mismatch_warn): Make const, mark with N_(), and
2896         move comment...
2897         * language.h (lang_frame_mismatch_warn): ... here. Also add
2898         declaration.
2899         * top.c (lang_frame_mismatch_warn): Remove declaration.
2900         (check_frame_language_change): Pass lang_frame_mismatch_warn
2901         through _().
2902
2903 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2904
2905         * c-lang.h (vtbl_ptr_name): Declare.
2906         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2907         it from the header.
2908         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2909
2910 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2911
2912         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2913         gdb_static_assert.
2914
2915 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
2916
2917         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2918         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
2919         * ctfread.c: New file.
2920         * ctfread.h: New file.
2921         * elfread.c: Include ctfread.h.
2922         (struct elfinfo text_p): New member ctfsect.
2923         (elf_locate_sections): Mark CTF section.
2924         (elf_symfile_read): Call elfctf_build_psymtabs.
2925         * Makefile.in (LIBCTF): Add.
2926         (CLIBS): Use it.
2927         (CDEPS): Likewise.
2928         (DIST): Add ctfread.c.
2929
2930 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2931
2932         * ctfread.c (struct nextfield): Renamed to ...
2933         (struct ctf_nextfield): ... this.
2934         (struct field_info): Renamed to ...
2935         (strut ctf_field_info): ... this.
2936         (attach_fields_to_type): Update for renamed structures.
2937         (ctf_add_member_cb): Likewise.
2938         (ctf_add_enum_member_cb): Likewise.
2939         (process_struct_members): Likewise.
2940         (process_enum_type): Likewise.
2941
2942 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
2943
2944         * tracectf.h: Rename, was ctf.h.
2945         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
2946         * tracefile.c: Likewise.
2947         * tracepoint.c: Remove unused include ctf.h.
2948         * mi/mi-main.c: Likewise.
2949         * Makefile.in Replace ctf.c with tracectf.c.
2950
2951 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
2952
2953         * version.in: Change version number to "9.0.50.DATE-git".
2954
2955 2019-10-03  Tom Tromey  <tom@tromey.com>
2956
2957         PR rust/24976:
2958         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
2959
2960 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2961
2962         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
2963         cp_search_name_hash.
2964         * NEWS: Add entry about nested function support.
2965
2966 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
2967             Andrew Burgess  <andrew.burgess@embecosm.com>
2968
2969         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
2970         for nested static variables when searchin VAR_DOMAIN.
2971         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
2972         global scope, update comment.
2973         (add_partial_subprogram): Call add_partial_subprogram recursively
2974         for nested subroutines when processinng Fortran.
2975         (load_partial_dies): Process the child entities of a subprogram
2976         when processing Fortran.
2977         (partial_die_parent_scope): Handle building scope
2978         for Fortran nested functions.
2979         (process_die): Record that nested functions have a scope.
2980         (new_symbol): Always record Fortran subprograms on the global
2981         symbol list.
2982         (determine_prefix): How to build the prefix for Fortran
2983         subprograms.
2984
2985 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2986
2987         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
2988         have just sent the thread a SIGSTOP and are waiting for it to
2989         arrive.
2990
2991 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2992
2993         * btrace.c (btrace_add_pc): Remove whitespace before the template
2994         parameter in 'std::vector <...>'.
2995         (parse_xml_btrace_block): Likewise.
2996         (btrace_maint_decode_pt): Likewise.
2997         (btrace_maint_update_packets): Likewise.
2998         (btrace_maint_print_packets): Likewise.
2999         * btrace.h (struct btrace_maint_info): Likewise.
3000         * dwarf2read.c (struct type_unit_group): Likewise.
3001         (build_type_psymtabs_reader): Likewise.
3002         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3003         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3004         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3005
3006 2019-10-03  Tom de Vries  <tdevries@suse.de>
3007
3008         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3009         the first line of the help text for set/show style metadata.
3010
3011 2019-10-02  Tom Tromey  <tromey@adacore.com>
3012
3013         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3014         * gdbsupport/common-inferior.c: New file.
3015         * infcmd.c (startup_with_shell): Don't define.
3016         * nat/fork-inferior.h (startup_with_shell): Don't declare.
3017         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3018         * inferior.h (startup_with_shell): Don't declare.
3019
3020 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
3021
3022         * gdbsupport/gdb_assert.h: Include errors.h.
3023         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3024
3025 2019-10-02  Tom Tromey  <tromey@adacore.com>
3026
3027         * NEWS: Add $_ada_exception entry.
3028         * ada-lang.c (struct ada_catchpoint): Add constructor.
3029         <m_kind>: New member.
3030         (allocate_location_exception, re_set_exception): Remove
3031         "ex" parameter.
3032         (should_stop_exception): Compute $_ada_exception.
3033         (check_status_exception, print_it_exception)
3034         (print_one_exception, print_mention_exception): Remove
3035         "ex" parameter.
3036         (allocate_location_catch_exception, re_set_catch_exception)
3037         (check_status_exception, print_it_catch_exception)
3038         (print_one_catch_exception, print_mention_catch_exception)
3039         (print_recreate_catch_exception)
3040         (allocate_location_catch_exception_unhandled)
3041         (re_set_catch_exception_unhandled)
3042         (check_status_exception, print_it_catch_exception_unhandled)
3043         (print_one_catch_exception_unhandled)
3044         (print_mention_catch_exception_unhandled)
3045         (print_recreate_catch_exception_unhandled)
3046         (allocate_location_catch_assert, re_set_catch_assert)
3047         (check_status_assert, print_it_catch_assert)
3048         (print_one_catch_assert, print_mention_catch_assert)
3049         (print_recreate_catch_assert)
3050         (allocate_location_catch_handlers, re_set_catch_handlers)
3051         (check_status_handlers, print_it_catch_handlers)
3052         (print_one_catch_handlers, print_mention_catch_handlers)
3053         (print_recreate_catch_handlers): Remove.
3054         (create_ada_exception_catchpoint): Update.
3055         (initialize_ada_catchpoint_ops): Update.
3056
3057 2019-10-02  Tom Tromey  <tromey@adacore.com>
3058
3059         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3060         (create_excep_cond_exprs): Simplify exception string computation.
3061         (ada_exception_catchpoint_cond_string): Likewise.
3062
3063 2019-10-02  Tom Tromey  <tromey@adacore.com>
3064
3065         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3066         * ada-lang.c (lesseq_defined_than): Handle
3067         LOC_STATIC.
3068         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3069         parameter.
3070         (dwarf2_has_info): Likewise.
3071         (new_symbol): Set maybe_copied on symbol when
3072         appropriate.
3073         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3074         parameter.
3075         <can_copy>: New member.
3076         * elfread.c (record_minimal_symbol): Set maybe_copied
3077         on symbol when appropriate.
3078         (elf_symfile_read): Update call to dwarf2_has_info.
3079         * minsyms.c (lookup_minimal_symbol_linkage): New
3080         function.
3081         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3082         * symtab.c (get_symbol_address, get_msymbol_address):
3083         New functions.
3084         * symtab.h (get_symbol_address, get_msymbol_address):
3085         Declare.
3086         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3087         maybe_copied.
3088         (struct symbol, struct minimal_symbol) <maybe_copied>:
3089         New member.
3090
3091 2019-10-02  Tom Tromey  <tromey@adacore.com>
3092
3093         * source.c (struct current_source_location): New.
3094         (current_source_key): New global.
3095         (current_source_symtab, current_source_line)
3096         (current_source_pspace): Remove.
3097         (get_source_location): New function.
3098         (get_current_source_symtab_and_line)
3099         (set_default_source_symtab_and_line)
3100         (set_current_source_symtab_and_line)
3101         (clear_current_source_symtab_and_line, select_source_symtab)
3102         (info_source_command, print_source_lines_base)
3103         (info_line_command, search_command_helper, _initialize_source):
3104         Update.
3105
3106 2019-10-02  Tom Tromey  <tromey@adacore.com>
3107
3108         * source.c (select_source_symtab): Don't call
3109         decode_line_with_current_source.
3110
3111 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3112
3113         * symtab.c (lookup_global_symbol): Search global block.
3114
3115 2019-10-02  Tom Tromey  <tromey@adacore.com>
3116
3117         * coffread.c (process_coff_symbol): Update.
3118         * dwarf2read.c (var_decode_location, new_symbol): Update.
3119         * mdebugread.c (parse_symbol): Update.
3120         * objfiles.c (relocate_one_symbol): Update.
3121         * stabsread.c (define_symbol, fix_common_block)
3122         (scan_file_globals): Update.
3123         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3124         (SET_SYMBOL_VALUE_ADDRESS): New macro.
3125         * xcoffread.c (process_xcoff_symbol): Update.
3126
3127 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
3128
3129         * MAINTAINERS: Update my email address.
3130
3131 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3132
3133         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3134         std::vector.
3135         (build_type_psymtabs_reader): Update for std::vector.
3136         (build_type_psymtab_dependencies): Likewise.
3137         * dwarf2read.h: Remove use of DEF_VEC_P.
3138         (typedef sig_type_ptr): Delete.
3139
3140 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3141
3142         * btrace.c (btrace_maint_clear): Update to handle change from VEC
3143         to std::vector.
3144         (btrace_maint_decode_pt): Likewise, and move allocation of the
3145         vector outside of the loop.
3146         (btrace_maint_update_packets): Update to handle change from VEC to
3147         std::vector.
3148         (btrace_maint_print_packets): Likewise.
3149         (maint_info_btrace_cmd): Likewise.
3150         * btrace.h: Remove use of DEF_VEC_O.
3151         (typedef btrace_pt_packet_s): Delete.
3152         (struct btrace_maint_info) <packets>: Change fromm VEC to
3153         std::vector.
3154         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3155
3156 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3157
3158         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3159         make accesses into the vector constant references.
3160         (btrace_add_pc): Update for std::vector.
3161         (btrace_stitch_bts): Likewise.
3162         (parse_xml_btrace_block): Likewise.
3163         (btrace_maint_update_packets): Likewise.
3164         (btrace_maint_print_packets): Likewise.
3165         (maint_info_btrace_cmd): Likewise.
3166         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3167         std::vector.
3168         (btrace_data::empty): Likewise.
3169         (btrace_data_append): Likewise.
3170         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3171         (typedef btrace_block_s): Delete.
3172         (struct btrace_block): Add constructor.
3173         (struct btrace_data_bts) <blocks>: Change to std::vector.
3174         * nat/linux-btrace.c (perf_event_read_bts): Update for
3175         std::vector.
3176         (linux_read_bts): Likewise.
3177
3178 2019-10-01  Tom Tromey  <tom@tromey.com>
3179
3180         * cli/cli-logging.c (show_logging_filename): Use styled_string.
3181
3182 2019-10-01  Tom Tromey  <tom@tromey.com>
3183
3184         * stack.c (print_frame, info_frame_command_core): Use
3185         styled_string.
3186         * linux-thread-db.c (try_thread_db_load_1)
3187         (try_thread_db_load_from_pdir_1): Use styled_string.
3188         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3189         (auto_load_section_scripts, info_auto_load_local_gdbinit)
3190         (maybe_print_unsupported_script_warning)
3191         (maybe_print_script_not_found_warning): Use styled_string.
3192         * ada-lang.c (user_select_syms): Use styled_string.
3193
3194 2019-10-01  Tom Tromey  <tom@tromey.com>
3195
3196         * p-lang.c (pascal_printstr): Use metadata style.
3197         * value.c (show_convenience): Use metadata style.
3198         * valprint.c (valprint_check_validity, val_print_optimized_out)
3199         (val_print_not_saved, val_print_unavailable)
3200         (val_print_invalid_address, generic_val_print, val_print)
3201         (value_check_printable, val_print_array_elements): Use metadata
3202         style.
3203         * ui-out.h (class ui_out) <field_fmt>: New overload.
3204         <do_field_fmt>: Add style parameter.
3205         * ui-out.c (ui_out::field_fmt): New overload.
3206         * typeprint.c (type_print_unknown_return_type)
3207         (val_print_not_allocated, val_print_not_associated): Use metadata
3208         style.
3209         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3210         parameter.
3211         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3212         * tracepoint.c (tvariables_info_1): Use metadata style.
3213         * stack.c (print_frame_arg, print_frame_info, print_frame)
3214         (info_frame_command_core): Use metadata style.
3215         * skip.c (info_skip_command): Use metadata style.
3216         * rust-lang.c (rust_print_enum): Use metadata style.
3217         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3218         metadata style.
3219         * python/py-framefilter.c (py_print_single_arg): Use metadata
3220         style.
3221         * printcmd.c (do_one_display, print_variable_and_value): Use
3222         metadata style.
3223         * p-valprint.c (pascal_val_print)
3224         (pascal_object_print_value_fields): Use metadata style.
3225         * p-typeprint.c (pascal_type_print_base): Use metadata style.
3226         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3227         parameter.
3228         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3229         * m2-valprint.c (m2_print_long_set): Use metadata style.
3230         * m2-typeprint.c (m2_print_type): Use metadata style.
3231         * infcmd.c (print_return_value_1): Use metadata style.
3232         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3233         * f-valprint.c (info_common_command_for_block): Use metadata
3234         style.
3235         * f-typeprint.c (f_type_print_base): Use metadata style.
3236         * expprint.c (print_subexp_standard): Use metadata style.
3237         * cp-valprint.c (cp_print_value_fields): Use metadata style.
3238         * cli/cli-style.h (class cli_style_option): Add constructor.
3239         (metadata_style): Declare.
3240         * cli/cli-style.c (metadata_style): New global.
3241         (_initialize_cli_style): Register metadata style.
3242         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3243         parameter.
3244         * cli-out.c (cli_ui_out::do_field_fmt): Update.
3245         * c-typeprint.c (c_type_print_base_struct_union)
3246         (c_type_print_base_1): Use metadata style.
3247         * breakpoint.c (watchpoint_value_print)
3248         (print_one_breakpoint_location): Use metadata style.
3249         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3250         style.
3251         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3252         style.
3253         * ada-valprint.c (val_print_packed_array_elements, printstr)
3254         (print_field_values, ada_val_print_ref, ada_val_print): Use
3255         metadata style.
3256         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3257         style.
3258         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3259         style.
3260         * ada-lang.c (user_select_syms): Use metadata style.
3261
3262 2019-10-01  Tom Tromey  <tom@tromey.com>
3263
3264         * cli/cli-cmds.c (pwd_command): Style output.
3265
3266 2019-10-01  Pedro Alves  <palves@redhat.com>
3267             Tom Tromey  <tom@tromey.com>
3268
3269         * symtab.c (print_symbol_info): Use %ps.
3270         (print_msymbol_info): Use %ps.
3271         * symfile.c (symbol_file_add_with_addrs): Use %ps.
3272         * printcmd.c (print_variable_and_value): Use %ps.
3273         * macrocmd.c (show_pp_source_pos): Use %ps.
3274         * infrun.c (print_exited_reason): Use ui_out::message.
3275         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3276         (describe_other_breakpoints): Use ui_out::message and new
3277         formats.
3278         (say_where): Use new formats.
3279         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3280         and new formats.
3281
3282 2019-10-01  Pedro Alves  <palves@redhat.com>
3283             Tom Tromey  <tom@tromey.com>
3284
3285         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3286         (test_gdb_formats): New function.
3287         (run_tests): Call it.
3288         (test_format_specifier): Update.
3289         * utils.h (fputs_filtered): Update comment.
3290         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3291         (fputs_styled_unfiltered): Declare.
3292         * utils.c (fputs_styled_unfiltered): New function.
3293         (vfprintf_maybe_filtered): Add gdbfmt parameter.
3294         (vfprintf_filtered): Update.
3295         (vfprintf_unfiltered, vprintf_filtered): Update.
3296         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3297         * ui-out.h (enum ui_out_flag) <unfiltered_output,
3298         disallow_ui_out_field>: New constants.
3299         (enum class field_kind): New.
3300         (struct base_field_s, struct signed_field_s): New.
3301         (signed_field): New function.
3302         (struct string_field_s): New.
3303         (string_field): New function.
3304         (struct styled_string_s): New.
3305         (styled_string): New function.
3306         (class ui_out) <message>: Add comment.
3307         <vmessage, call_do_message>: New methods.
3308         <do_message>: Add style parameter.
3309         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3310         methods.
3311         (ui_out::message): Rewrite.
3312         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3313         parameter.
3314         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3315         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3316         gdb_extensions parameter.
3317         (class format_piece): Add parameter to constructor.
3318         (n_int_args): New field.
3319         * gdbsupport/format.c (format_pieces::format_pieces): Add
3320         gdb_extensions parameter.  Handle '*'.
3321         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3322         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
3323         vfprintf_styled_no_gdbfmt.
3324         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3325         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3326         unfiltered output.
3327         * ui-style.h (struct ui_file_style) <ptr>: New method.
3328
3329 2019-10-01  Tom Tromey  <tom@tromey.com>
3330
3331         * unittests/format_pieces-selftests.c: Update.  Add final format.
3332         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3333         empty literal pieces.
3334
3335 2019-10-01  Tom Tromey  <tom@tromey.com>
3336
3337         * ui-out.h (enum class ui_out_style_kind): Remove.
3338         (class ui_out) <field_string, field_stsream, do_field_string>:
3339         Change type of "style".
3340         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3341         (ui_out::field_string): Update.
3342         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3343         of "style".
3344         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3345         * tracepoint.c (print_one_static_tracepoint_marker): Update.
3346         * stack.c (print_frame_arg, print_frame_info, print_frame):
3347         Update.
3348         * source.c (print_source_lines_base): Update.
3349         * solib.c (info_sharedlibrary_command): Update.
3350         * skip.c (info_skip_command): Update.
3351         * record-btrace.c (btrace_call_history_src_line)
3352         (btrace_call_history): Update.
3353         * python/py-framefilter.c (py_print_frame): Update.
3354         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3355         "style".
3356         * mi/mi-out.c (mi_ui_out::do_table_header)
3357         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3358         (mi_ui_out::do_field_string): Update.
3359         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3360         Update.
3361         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3362         "style".
3363         * cli-out.c (cli_ui_out::do_table_header)
3364         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3365         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3366         (cli_ui_out::do_field_fmt): Update.
3367         * breakpoint.c (print_breakpoint_location): Update.
3368         (update_static_tracepoint): Update.
3369
3370 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3371
3372         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3373         conversion of gdb_datadir.
3374         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3375         remove not needed c_str ().
3376
3377 2019-09-30  Ali Tamur <tamur@google.com>
3378
3379         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3380         (dwarf2_string_attr): Likewise.
3381
3382 2019-09-30  Ali Tamur <tamur@google.com>
3383
3384         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3385         (process_full_type_unit): Likewise.
3386         (dump_die_shallow): Likewise.
3387         (cu_debug_loc_section): Likewise.
3388
3389 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
3390
3391         * minsyms.c (compare_minimal_symbols): Rename to...
3392         (minimal_symbol_is_less_than): ...this, and adjust to STL
3393         conventions (return bool, take arguments as references)
3394         (minimal_symbol_reader::install): Call std::sort instead
3395         of qsort.
3396
3397 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
3398
3399         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3400         hash and why.
3401         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3402         msymbol_hash, msymbol_demangled_hash>: Improve comments.
3403
3404 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
3405
3406         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3407         * psympriv.h (add_psymbol_to_list): Move comment here and update
3408         it.
3409
3410 2019-09-29  Tom de Vries  <tdevries@suse.de>
3411
3412         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3413         Use $tmpdir/$(basename "$output_file").dwz instead of
3414         "${output_file}.dwz".
3415
3416 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
3417
3418         PR gdb/25045
3419         * hppa-linux-nat.c: Include gdbarch.h.
3420
3421 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
3422
3423         * blockframe.c (find_pc_partial_function): Change return type to bool.
3424         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3425         * minsyms.c (in_gnu_ifunc_stub): Likewise.
3426         (stub_gnu_ifunc_resolve_name): Likewise.
3427         * symtab.c (compare_filenames_for_search): Likewise.
3428         (compare_glob_filenames_for_search): Likewise.
3429         (matching_obj_sections): Likewise.
3430         (symbol_matches_domain): Likewise.
3431         (find_line_symtab): Change out param EXACT_MATCH to bool *.
3432         (find_line_pc): Change return type to bool.
3433         (find_line_pc_range): Likewise.
3434         (producer_is_realview): Likewise.
3435         * symtab.h (symbol_matches_domain): Likewise.
3436         (find_pc_partial_function): Likewise.
3437         (find_pc_line_pc_range): Likewise.
3438         (in_gnu_ifunc_stub): Likewise.
3439         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3440         (find_line_pc): Likewise.
3441         (find_line_pc_range): Likewise.
3442         (matching_obj_sections): Likewise.
3443         (find_line_symtab): Change out parameter to bool.
3444         (producer_is_realview): Change return type to bool.
3445         (compare_filenames_for_search): Likewise.
3446         (compare_glob_filenames_for_search): Likewise.
3447
3448 2019-09-26  Tom Tromey  <tom@tromey.com>
3449
3450         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3451         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3452         * gdb_usleep.h: Remove.
3453         * gdb_usleep.c: Remove.
3454         * utils.c: Don't include gdb_usleep.h.
3455
3456 2019-09-26  Tom Tromey  <tromey@adacore.com>
3457
3458         * python/py-type.c (type_to_type_object): Call check_typedef
3459         for stub types.
3460
3461 2019-09-26  Tom Tromey  <tom@tromey.com>
3462
3463         * utils.h (initialize_utils): Don't declare.
3464         * top.c (gdb_init): Don't call initialize_utils.
3465         * utils.c (initialize_utils): Remove.  Move contents...
3466         (_initialize_utils): ... here.
3467
3468 2019-09-25  Tom Tromey  <tom@tromey.com>
3469
3470         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3471         * utils.h (make_hex_string): Don't declare.
3472         * utils.c (make_hex_string): Remove.
3473
3474 2019-09-24  Tom de Vries  <tdevries@suse.de>
3475
3476         PR gdb/23815
3477         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3478         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3479
3480 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
3481
3482         * NEWS: Mention new simulator port for PRU.
3483
3484 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
3485
3486         * ada-exp.y (write_object_remaining): Update.
3487         * ada-lang.c (ada_decode): Return a std::string instead of a char*
3488         and eliminate the static buffer.
3489         (ada_decode_symbol): Update.
3490         (ada_la_decode): Update.
3491         (ada_sniff_from_mangled_name): Update.
3492         (is_valid_name_for_wild_match): Update.
3493         (ada_lookup_name_info::matches): Update and simplify.
3494         (name_matches_regex): Update.
3495         (ada_add_global_exceptions): Update.
3496         * ada-lang.h (ada_decode): Update signature.
3497         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3498         * dwarf-index-write.c (debug_names::insert): Update.
3499
3500 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3501
3502         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3503         formatting.
3504
3505 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3506
3507         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3508         Change "nonzero" to "true" in documentation.
3509
3510 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
3511
3512         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3513         (_initialize_darwin_solib): Don't set
3514         darwin_so_ops.lookup_lib_global_symbol.
3515         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3516         set_gdbarch_iterate_over_objfiles_in_search_order.
3517         (elf_lookup_lib_symbol): Rename to...
3518         (svr4_iterate_over_objfiles_in_search_order): this, and update
3519         to iterate semantics.
3520         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3521         * solib.c (solib_global_lookup): Remove.
3522         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3523         (solib_global_lookup): Remove.
3524         * symtab.c (lookup_global_or_static_symbol): Remove call to
3525         solib_global_lookup.
3526
3527 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3528
3529         * NEWS: Move entries about default MI version now being
3530         version 3, and about the GDB/MI fix for multi-location
3531         breakpoints to the "since GDB 8.3" section.
3532
3533 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3534
3535         GDB 8.3.1 released.
3536
3537 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
3538
3539         * NEWS: Mention that Cell/B.E. debugging support was removed.
3540         * MAINTAINERS: Remove spu target.
3541
3542         * config/djgpp/fnchange.lst: Remove entries for removed files.
3543
3544         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3545         spu-multiarch.o, and spu-tdep.o.
3546         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3547         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3548         spu-multiarch.c, and spu-tdep.c.
3549         * spu-linux-nat.c: Remove file.
3550         * spu-multiarch.c: Remove file.
3551         * spu-tdep.c: Remove file.
3552         * spu-tdep.h: Remove file.
3553         * solib-spu.c: Remove file.
3554         * solib-spu.h: Remove file.
3555
3556         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3557         * configure.nat (spu-linux): Remove.
3558         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3559         solib-multiarch.o from gdb_target_obs.
3560         (spu*-*-*): Remove.
3561
3562         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3563         feature flag.
3564         (ppc_linux_no_features): Update.
3565         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3566         Cell/B.E. support.
3567         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3568         (tdesc_powerpc_cell64l): Likewise.
3569         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3570         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3571         Cell/B.E. support.
3572         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3573         Do not include "features/rs6000/powerpc-cell32l.c" or
3574         "features/rs6000/powerpc-cell64l.c".
3575         (ppc_linux_spu_section): Remove.
3576         (ppc_linux_core_read_description): Remove Cell/B.E. support.
3577         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3578         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3579         (ppc_linux_spe_context_lookup): Remove.
3580         (ppc_linux_spe_context_inferior_created): Remove.
3581         (ppc_linux_spe_context_solib_loaded): Remove.
3582         (ppc_linux_spe_context_solib_unloaded): Remove.
3583         (ppc_linux_spe_context): Remove.
3584         (struct ppu2spu_cache): Remove.
3585         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3586         (struct ppu2spu_data): Remove.
3587         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3588         ppu2spu_unwind): Remove.
3589         (ppc_linux_init_abi): Remove Cell/B.E. support.
3590         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3591
3592         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3593         (rs6000/powerpc-cell64l-expedite): Likewise
3594         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3595         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3596         rs6000/powerpc-cell64l.xml.
3597         * features/rs6000/powerpc-cell32l.xml: Remove.
3598         * features/rs6000/powerpc-cell64l.xml: Likewise.
3599         * features/rs6000/powerpc-cell32l.c: Remove generated file.
3600         * features/rs6000/powerpc-cell64l.c: Likewise.
3601         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3602         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3603         * regformats/reg-spu.dat: Remove.
3604
3605         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3606         * corelow.c (struct spuid_list): Remove.
3607         (add_to_spuid_list): Remove.
3608         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3609         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3610         (remote_protocol_features): Remove associated entries.
3611         (_initialize_remote): No longer initialize them.
3612         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3613         * linux-nat.c (SPUFS_MAGIC): Remove.
3614         (linux_proc_xfer_spu): Remove.
3615         (spu_enumerate_spu_ids): Remove.
3616         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3617         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3618         (linux_make_corefile_notes): No longer call it.
3619
3620         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3621         (cooked_write_test): Likewise.
3622
3623 2019-09-20  Tom Tromey  <tom@tromey.com>
3624
3625         * NEWS: Mention case-sensitivity of TUI commands.
3626         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3627         (tui_set_win_height_command, parse_scrolling_args): Likewise.
3628         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3629
3630 2019-09-20  Tom Tromey  <tom@tromey.com>
3631
3632         * tui/tui-source.c (tui_source_window::set_contents): Use
3633         make_unique_xstrdup.
3634         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3635         make_unique_xstrdup.
3636
3637 2019-09-20  Tom Tromey  <tom@tromey.com>
3638
3639         * tui/tui-data.c: Remove separator comments.
3640         * tui/tui-layout.c: Remove separator comments.
3641         * tui/tui-win.c: Remove separator comments.
3642         * tui/tui-wingeneral.c: Remove separator comments.
3643
3644 2019-09-20  Tom Tromey  <tom@tromey.com>
3645
3646         * tui/tui.h (strcat_to_buf): Don't declare.
3647         * tui/tui.c (strcat_to_buf): Remove.
3648
3649 2019-09-20  Tom Tromey  <tom@tromey.com>
3650
3651         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3652         from "fullname".
3653         * tui/tui-source.c (tui_source_window::set_contents)
3654         (tui_source_window::location_matches_p)
3655         (tui_source_window::maybe_update): Update.
3656
3657 2019-09-20  Tom Tromey  <tom@tromey.com>
3658
3659         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3660         Update.
3661         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3662         prefix.
3663         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3664         (tui_data_window::line_from_reg_element_no)
3665         (tui_data_window::first_reg_element_no_inline)
3666         (tui_data_window::show_registers)
3667         (tui_data_window::show_register_group)
3668         (tui_data_window::display_registers_from)
3669         (tui_data_window::display_registers_from_line)
3670         (tui_data_window::first_data_item_displayed)
3671         (tui_data_window::delete_data_content_windows)
3672         (tui_data_window::erase_data_content)
3673         (tui_data_window::do_scroll_vertical)
3674         (tui_data_window::refresh_window)
3675         (tui_data_window::check_register_values): Update.
3676
3677 2019-09-20  Tom Tromey  <tom@tromey.com>
3678
3679         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3680         (struct tui_locator_window) <full_name, proc_name>: Now
3681         std::string.
3682         * tui/tui-stack.c (tui_locator_window::make_status_line)
3683         (tui_locator_window::set_locator_fullname)
3684         (tui_locator_window::set_locator_info): Update.
3685         * tui/tui-source.c (tui_source_window::set_contents)
3686         (tui_source_window::showing_source_p): Update.
3687
3688 2019-09-20  Tom Tromey  <tom@tromey.com>
3689
3690         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3691         Don't call tui_locator_win_info_ptr.
3692
3693 2019-09-20  Tom Tromey  <tom@tromey.com>
3694
3695         * tui/tui-win.c (tui_resize_all): Don't call refresh.
3696
3697 2019-09-20  Tom Tromey  <tom@tromey.com>
3698
3699         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3700         height for locator.
3701         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3702         * tui/tui-layout.c (show_source_disasm_command, show_data)
3703         (show_source_or_disasm_and_command): Use 1 as height for locator.
3704
3705 2019-09-20  Tom Tromey  <tom@tromey.com>
3706
3707         * tui/tui.c (tui_enable): Update.
3708         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3709         Update.
3710         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3711         Update.
3712         * tui/tui-data.c (win_resized): Now bool.
3713         (tui_win_resized): Return bool.
3714         (tui_set_win_resized_to): Accept a bool.
3715
3716 2019-09-20  Tom Tromey  <tom@tromey.com>
3717
3718         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3719         Change type of "refresh_values_only".
3720         * tui/tui-regs.c (tui_data_window::show_register_group): Change
3721         type of "refresh_values_only".
3722
3723 2019-09-20  Tom Tromey  <tom@tromey.com>
3724
3725         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3726         std::string.
3727         (tui_disassemble): Add "pos" parameter.
3728         (tui_disasm_window::set_contents): Simplify.
3729
3730 2019-09-20  Tom Tromey  <tom@tromey.com>
3731
3732         * tui/tui-winsource.h (struct tui_source_window_base)
3733         <show_source_content>: Now private.
3734         * tui/tui-winsource.c
3735         (tui_source_window_base::show_source_content): Don't handle empty
3736         content case.
3737
3738 2019-09-20  Tom Tromey  <tom@tromey.com>
3739
3740         * tui/tui-layout.c (show_source_disasm_command)
3741         (show_source_or_disasm_and_command): Don't call
3742         show_source_content.
3743
3744 2019-09-20  Tom Tromey  <tom@tromey.com>
3745
3746         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3747         Declare.
3748         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3749         from tui_make_status_line.
3750         (tui_locator_window::rerender): Update.
3751
3752 2019-09-20  Tom Tromey  <tom@tromey.com>
3753
3754         * tui/tui-stack.c (tui_make_status_line): Return std::string.
3755         (tui_locator_window::rerender): Update.
3756
3757 2019-09-20  Tom Tromey  <tom@tromey.com>
3758
3759         * tui/tui-winsource.h (struct tui_source_window_base)
3760         <~tui_source_window_base>: Don't declare.
3761         <fullname>: Remove.
3762         * tui/tui-winsource.c (~tui_source_window_base): Remove.
3763         * tui/tui-source.h (struct tui_source_window) <fullname>: New
3764         member.
3765         * tui/tui-source.c (tui_source_window::set_contents): Update.
3766         (tui_source_window::location_matches_p)
3767         (tui_source_window::maybe_update): Update.
3768
3769 2019-09-20  Tom Tromey  <tom@tromey.com>
3770
3771         * tui/tui-winsource.h (~tui_source_element): Remove.
3772         (tui_source_element): Update.
3773         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3774         * tui/tui-winsource.c (tui_show_source_line): Update.
3775         * tui/tui-source.c (tui_source_window::set_contents): Update.
3776         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3777
3778 2019-09-20  Tom Tromey  <tom@tromey.com>
3779
3780         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3781         declare.
3782         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3783         tui_clear_source_windows_detail.
3784         * tui/tui-winsource.h (struct tui_source_window_base)
3785         <clear_detail>: Don't declare.
3786         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3787         Remove.
3788         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3789
3790 2019-09-20  Tom Tromey  <tromey@adacore.com>
3791
3792         PR ada/24919:
3793         * block.c (contained_in): Fix final return value.
3794
3795 2019-09-20  Alan Modra  <amodra@gmail.com>
3796
3797         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3798         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3799         (read_indirect_string_from_dwz): Use bfd accessor.
3800         * dwarf2read.h (struct dwz_file <filename>): Likewise.
3801         * machoread.c (macho_symfile_read_all_oso): Likewise.
3802         * solib.c (solib_bfd_open): Likewise.
3803
3804 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3805
3806         * eval.c: Move declaration of overload_resolution to...
3807         * value.h: ...here.
3808
3809 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3810
3811         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3812         * arm-linux-tdep.c: Likewise.
3813         * arm-nbsd-nat.c: Likewise.
3814         * arm-tdep.h: Declare arm_apcs_32.
3815         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3816
3817 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3818
3819         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3820         * dwarf2read.h: Declare dwarf_always_disassemble.
3821
3822 2019-09-19  Tom de Vries  <tdevries@suse.de>
3823
3824         PR gdb/25009
3825         * source-cache.c (source_cache::ensure): Catch exception thrown during
3826         construction of the highlighter.
3827
3828 2019-09-18  Alan Modra  <amodra@gmail.com>
3829
3830         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3831         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3832         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3833         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3834         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3835         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3836         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3837         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3838         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3839         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3840         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3841         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3842         * solib-spu.c, * solib-svr4.c, * solib-target.c,
3843         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3844         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3845         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3846         * mi/mi-interp.c: Update throughout for bfd section macro and
3847         function changes.
3848         * gcore (gcore_create_callback): Use bfd_set_section_lma.
3849         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3850
3851 2019-09-18  Tom Tromey  <tom@tromey.com>
3852
3853         * NEWS: Add entry.
3854         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
3855         call rl_initialize.
3856         (tui_enable): Do not call rl_initialize.
3857
3858 2019-09-18  Christian Groessler  <chris@groessler.org>
3859
3860         * alpha-linux-nat.c: Include gdbarch.h.
3861
3862 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
3863
3864         * ui-file.c: Include cli/cli-style.h.
3865         (term_cli_styling): Remove cli_styling declaration.
3866
3867 2019-09-18  Alan Modra  <amodra@gmail.com>
3868
3869         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3870         to bfd_asymbol_section.
3871
3872 2019-09-18  Alan Modra  <amodra@gmail.com>
3873
3874         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3875         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3876         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3877
3878 2019-09-18  Alan Modra  <amodra@gmail.com>
3879
3880         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3881         * spu-linux-nat.c (spu_bfd_open): Likewise.
3882
3883 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
3884
3885         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3886         to bool to match definition in dwarf2read.c.
3887
3888 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
3889
3890         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3891         (print_signatures): Likewise.
3892         (trust_pad_over_xvs): Likewise.
3893         * arch/aarch64-insn.c (aarch64_debug): Likewise.
3894         * arch/aarch64-insn.h (aarch64_debug): Likewise.
3895         * arm-linux-nat.c (arm_apcs_32): Likewise.
3896         * arm-linux-tdep.c (arm_apcs_32): Likewise.
3897         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3898         * arm-tdep.c (arm_debug): Likewise.
3899         (arm_apcs_32): Likewise.
3900         * auto-load.c (debug_auto_load): Likewise.
3901         (auto_load_gdb_scripts): Likewise.
3902         (global_auto_load): Likewise.
3903         (auto_load_local_gdbinit): Likewise.
3904         (auto_load_local_gdbinit_loaded): Likewise.
3905         * auto-load.h (global_auto_load): Likewise.
3906         (auto_load_local_gdbinit): Likewise.
3907         (auto_load_local_gdbinit_loaded): Likewise.
3908         * breakpoint.c (disconnected_dprintf): Likewise.
3909         (breakpoint_proceeded): Likewise.
3910         (automatic_hardware_breakpoints): Likewise.
3911         (always_inserted_mode): Likewise.
3912         (target_exact_watchpoints): Likewise.
3913         (_initialize_breakpoint): Update.
3914         * breakpoint.h (target_exact_watchpoints): Change to bool.
3915         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3916         * cli/cli-cmds.c (trace_commands): Likewise.
3917         * cli/cli-cmds.h (trace_commands): Likewise.
3918         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3919         to bool*.
3920         * cli/cli-logging.c (logging_overwrite): Change to bool.
3921         (logging_redirect): Likewise.
3922         (debug_redirect): Likewise.
3923         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3924         (struct boolean_option_def) <get_var_address_cb_>: Change return type
3925         to bool.
3926         <boolean_option_def>: Update.
3927         (struct flag_option_def): Change default type of Context to bool
3928         from int.
3929         <flag_option_def>: Change return type of var_address_cb_ to bool*.
3930         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
3931         (get_setshow_command_value_string): Likewise.
3932         * cli/cli-style.c (cli_styling): Change to bool.
3933         (source_styling): Likewise.
3934         * cli/cli-style.h (source_styling): Likewise.
3935         (cli_styling): Likewise.
3936         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
3937         to bool.
3938         * command.h (var_types): Update comment.
3939         (add_setshow_boolean_cmd): Change int* var argument to bool*.
3940         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
3941         bool.
3942         (debug_compile_cplus_scopes): Likewise.
3943         * compile/compile-internal.h (compile_debug): Likewise.
3944         * compile/compile.c (compile_debug): Likewise.
3945         (struct compile_options) <raw>: Likewise.
3946         * cp-support.c (catch_demangler_crashes): Likewise.
3947         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
3948         (usr_cmd_cris_dwarf2_cfi): Likewise.
3949         * csky-tdep.c (csky_debug): Likewise.
3950         * darwin-nat.c (enable_mach_exceptions): Likewise.
3951         * dcache.c (dcache_enabled_p): Likewise.
3952         * defs.h (info_verbose): Likewise.
3953         * demangle.c (demangle): Likewise.
3954         (asm_demangle): Likewise.
3955         * dwarf-index-cache.c (debug_index_cache): Likewise.
3956         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
3957         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
3958         * dwarf2read.c (check_physname): Likewise.
3959         (use_deprecated_index_sections): Likewise.
3960         (dwarf_always_disassemble): Likewise.
3961         * eval.c (overload_resolution): Likewise.
3962         * event-top.c (set_editing_cmd_var): Likewise.
3963         (exec_done_display_p): Likewise.
3964         * event-top.h (set_editing_cmd_var): Likewise.
3965         (exec_done_display_p): Likewise.
3966         * exec.c (write_files): Likewise.
3967         * fbsd-nat.c (debug_fbsd_lwp): Likewise
3968         (debug_fbsd_nat): Likewise.
3969         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
3970         Likewise.
3971         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
3972         <backtrace_past_entry> Likewise.
3973         * gdb-demangle.h (demangle): Likewise.
3974         (asm_demangle): Likewise.
3975         * gdb_bfd.c (bfd_sharing): Likewise.
3976         * gdbcore.h (write_files): Likewise.
3977         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
3978         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
3979         * gdbthread.h (print_thread_events): Likewise.
3980         * gdbtypes.c (opaque_type_resolution): Likewise.
3981         (strict_type_checking): Likewise.
3982         * gnu-nat.c (gnu_debug_flag): Likewise.
3983         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
3984         * guile/scm-param.c (pascm_variable): Add boolval.
3985         (add_setshow_generic): Update.
3986         (pascm_param_value): Update.
3987         (pascm_set_param_value_x): Update.
3988         * hppa-tdep.c (hppa_debug): Change to bool..
3989         * infcall.c (may_call_functions_p): Likewise.
3990         (coerce_float_to_double_p): Likewise.
3991         (unwind_on_signal_p): Likewise.
3992         (unwind_on_terminating_exception_p): Likewise.
3993         * infcmd.c (startup_with_shell): Likewise.
3994         * inferior.c (print_inferior_events): Likewise.
3995         * inferior.h (startup_with_shell): Likewise.
3996         (print_inferior_events): Likewise.
3997         * infrun.c (step_stop_if_no_debug): Likewise.
3998         (detach_fork): Likewise.
3999         (debug_displaced): Likewise.
4000         (disable_randomization): Likewise.
4001         (non_stop): Likewise.
4002         (non_stop_1): Likewise.
4003         (observer_mode): Likewise.
4004         (observer_mode_1): Likewise.
4005         (set_observer_mode): Update.
4006         (sched_multi): Change to bool.
4007         * infrun.h (debug_displaced): Likewise.
4008         (sched_multi): Likewise.
4009         (step_stop_if_no_debug): Likewise.
4010         (non_stop): Likewise.
4011         (disable_randomization): Likewise.
4012         * linux-tdep.c (use_coredump_filter): Likewise.
4013         (dump_excluded_mappings): Likewise.
4014         * linux-thread-db.c (auto_load_thread_db): Likewise.
4015         (check_thread_db_on_load): Likewise.
4016         * main.c (captured_main_1): Update.
4017         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4018         xx2_opt, boolean_opt>: Change to bool.
4019         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4020         * maint.c (maintenance_profile_p): Likewise.
4021         (per_command_time): Likewise.
4022         (per_command_space): Likewise.
4023         (per_command_symtab): Likewise.
4024         * memattr.c (inaccessible_by_default): Likewise.
4025         * mi/mi-main.c (mi_async): Likewise.
4026         (mi_async_1): Likewise.
4027         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4028         * nat/fork-inferior.h (startup_with_shell): Likewise.
4029         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4030         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4031         * nios2-tdep.c (nios2_debug): Likewise.
4032         * or1k-tdep.c (or1k_debug): Likewise.
4033         * parse.c (parser_debug): Likewise.
4034         * parser-defs.h (parser_debug): Likewise.
4035         * printcmd.c (print_symbol_filename): Likewise.
4036         * proc-api.c (procfs_trace): Likewise.
4037         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4038         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4039         (set_parameter_value): Update.
4040         (add_setshow_generic): Update.
4041         * python/py-value.c (copy_py_bool_obj): Change argument from int*
4042         to bool*.
4043         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4044         int*.
4045         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4046         * record-btrace.c (record_btrace_target::store_registers): Update.
4047         * record-full.c (record_full_memory_query): Change to bool.
4048         (record_full_stop_at_limit): Likewise.
4049         * record-full.h (record_full_memory_query): Likewise.
4050         * remote-notif.c (notif_debug): Likewise.
4051         * remote-notif.h (notif_debug): Likewise.
4052         * remote.c (use_range_stepping): Likewise.
4053         (interrupt_on_connect): Likewise.
4054         (remote_break): Likewise.
4055         * ser-tcp.c (tcp_auto_retry): Likewise.
4056         * ser-unix.c (serial_hwflow): Likewise.
4057         * skip.c (debug_skip): Likewise.
4058         * solib-aix.c (solib_aix_debug): Likewise.
4059         * spu-tdep.c (spu_stop_on_load_p): Likewise.
4060         (spu_auto_flush_cache_p): Likewise.
4061         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4062         Likewise.
4063         (struct info_print_options) <quiet>: Likewise.
4064         * symfile-debug.c (debug_symfile): Likewise.
4065         * symfile.c (auto_solib_add): Likewise.
4066         (separate_debug_file_debug): Likewise.
4067         * symfile.h (auto_solib_add): Likewise.
4068         (separate_debug_file_debug): Likewise.
4069         * symtab.c (basenames_may_differ): Likewise.
4070         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4071         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4072         (struct info_types_options) <quiet>: Likewise.
4073         * symtab.h (demangle): Likewise.
4074         (basenames_may_differ): Likewise.
4075         * target-dcache.c (stack_cache_enabled_1): Likewise.
4076         (code_cache_enabled_1): Likewise.
4077         * target.c (trust_readonly): Likewise.
4078         (may_write_registers): Likewise.
4079         (may_write_memory): Likewise.
4080         (may_insert_breakpoints): Likewise.
4081         (may_insert_tracepoints): Likewise.
4082         (may_insert_fast_tracepoints): Likewise.
4083         (may_stop): Likewise.
4084         (auto_connect_native_target): Likewise.
4085         (target_stop_and_wait): Update.
4086         (target_async_permitted): Change to bool.
4087         (target_async_permitted_1): Likewise.
4088         (may_write_registers_1): Likewise.
4089         (may_write_memory_1): Likewise.
4090         (may_insert_breakpoints_1): Likewise.
4091         (may_insert_tracepoints_1): Likewise.
4092         (may_insert_fast_tracepoints_1): Likewise.
4093         (may_stop_1): Likewise.
4094         * target.h (target_async_permitted): Likewise.
4095         (may_write_registers): Likewise.
4096         (may_write_memory): Likewise.
4097         (may_insert_breakpoints): Likewise.
4098         (may_insert_tracepoints): Likewise.
4099         (may_insert_fast_tracepoints): Likewise.
4100         (may_stop): Likewise.
4101         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4102         (make_thread_apply_all_options_def_group): Change argument from int*
4103         to bool*.
4104         (thread_apply_all_command): Update.
4105         (print_thread_events): Change to bool.
4106         * top.c (confirm): Likewise.
4107         (command_editing_p): Likewise.
4108         (history_expansion_p): Likewise.
4109         (write_history_p): Likewise.
4110         (info_verbose): Likewise.
4111         * top.h (confirm): Likewise.
4112         (history_expansion_p): Likewise.
4113         * tracepoint.c (disconnected_tracing): Likewise.
4114         (circular_trace_buffer): Likewise.
4115         * typeprint.c (print_methods): Likewise.
4116         (print_typedefs): Likewise.
4117         * utils.c (debug_timestamp): Likewise.
4118         (sevenbit_strings): Likewise.
4119         (pagination_enabled): Likewise.
4120         * utils.h (sevenbit_strings): Likewise.
4121         (pagination_enabled): Likewise.
4122         * valops.c (overload_resolution): Likewise.
4123         * valprint.h (struct value_print_options) <prettyformat_arrays,
4124         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4125         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4126         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4127         Likewise.
4128         * windows-nat.c (new_console): Likewise.
4129         (cygwin_exceptions): Likewise.
4130         (new_group): Likewise.
4131         (debug_exec): Likewise.
4132         (debug_events): Likewise.
4133         (debug_memory): Likewise.
4134         (debug_exceptions): Likewise.
4135         (useshell): Likewise.
4136         * windows-tdep.c (maint_display_all_tib): Likewise.
4137         * xml-support.c (debug_xml): Likewise.
4138
4139 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
4140
4141         * source.c (prepare_path_for_appending): New function.
4142         (openp): Make use of new function.
4143         (find_and_open_source): Search for the compilation directory and
4144         source file as a relative path beneath the directory search path.
4145
4146 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4147
4148         * source-cache.c (source_cache::get_line_charpos): Catch
4149         exceptions and return false, this matches the behaviour documented
4150         in the header file.
4151
4152 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
4153
4154         * ada-tasks.c (info_task): Remove quoting of the task's name.
4155
4156 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
4157
4158         * symfile.c (auto_solib_add): Replace comment with a reference
4159         to the header file.
4160
4161 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
4162
4163         * NEWS: Mention that gdb can now be compiled with Python 3
4164         on Windows.
4165
4166 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4167
4168         * maint.c (maint_print_section_data::maint_print_section_data):
4169         Force use of 'float log10 (float)' by casting the argument to
4170         float.
4171
4172 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4173
4174         * maint.c: Add 'cmath' include.
4175         (struct maint_print_section_data): New structure.
4176         (print_section_index): New function.
4177         (print_bfd_section_info): Add header comment, small whitespace
4178         cleanup, and update to call new print_section_index function.
4179         (print_objfile_section_info): Likewise.
4180         (maint_obj_section_from_bfd_section): New function.
4181         (print_bfd_section_info_maybe_relocated): New function.
4182         (maintenance_info_sections): Add header comment, always use
4183         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4184
4185 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4186
4187         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4188         inner scope, add check that the objfile has psymtabs before
4189         checking psymtabs_addrmap.
4190         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4191
4192 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4193
4194         * NEWS: Announce that Ada task names are now shown at more places,
4195         and between quotes (except in info task output).
4196         * gdb/ada-tasks.c (task_to_str): New function.
4197         (display_current_task_id): Call task_to_str.
4198         (task_command_1): Likewise.
4199         (print_ada_task_info): In non-mi mode, Properly align headers and data
4200         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4201
4202 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4203
4204         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4205         prstatus.pr_lwp.pr_info instead of making it up.
4206
4207 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4208
4209         * auto-load.c (auto_load_expand_dir_vars): Update.
4210         * defs.h (gdb_datadir): Change to std::string.
4211         (python_libdir): Likewise.
4212         (relocate_gdb_directory): Change return type to std::string.
4213         * guile/guile.c (gdbscm_data_directory): Update.
4214         (initialize_scheme_side): Update.
4215         * jit.c (jit_reader_dir): Change to std::string.
4216         (jit_reader_load_command): Update.
4217         * main.c (gdb_datadir): Change to std::string.
4218         (python_libdir): Likewise.
4219         (set_gdb_data_directory): Update.
4220         (relocate_path): Change to return std::string.
4221         (relocate_gdb_directory): Change to return std::string.
4222         (relocate_gdbinit_path_maybe_in_datadir): Update.
4223         (captured_main_1): Update.
4224         * python/python.c (do_start_initialization): Update.
4225         * top.c (show_gdb_datadir): Update.
4226         * xml-syscall.c (xml_init_syscalls_info): Update.
4227         (init_syscalls_info): Update.
4228
4229 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4230
4231         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4232         out of get_init_files.
4233         (get_init_files): Update.
4234
4235 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4236
4237         * main.c (get_init_files): Change to use std::string.
4238         (captured_main_1): Update.
4239         (print_gdb_help): Update.
4240
4241 2019-09-11  Ali Tamur  <tamur@google.com>
4242
4243         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4244         implementation.
4245
4246 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4247
4248         * dbxread.c (read_dbx_symtab): Update.
4249         * dwarf2read.c (load_partial_dies): Update.
4250         * mdebugread.c (parse_partial_symbols): Update.
4251         (handle_psymbol_enumerators): Update.
4252         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4253         * psymtab.c (add_psymbol_to_bcache): Likewise.
4254         (add_psymbol_to_list): Likewise.
4255         * symtab.c (symbol_set_names): Likewise.
4256         * symtab.h (symbol_set_names): Likewise.
4257         * xcoffread.c (scan_xcoff_symtab): Update.
4258
4259 2019-09-11  Tom Tromey  <tom@tromey.com>
4260
4261         * symfile-mem.c (symbol_file_add_from_memory): Use
4262         bfd_set_filename.
4263         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4264         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4265
4266 2019-09-10  Tom Tromey  <tromey@adacore.com>
4267
4268         * dwarf-index-write.c (write_psymbols): Extend error message.
4269         (debug_names::insert): Add Ada code.
4270         (debug_names::write_psymbols): Remove Ada check.
4271         (debug_names) <m_string_obstack>: New member.
4272         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4273         (gdb_index_symbol_name_matcher::matches): Remove.
4274         (mapped_index_base::find_name_components_bounds): Add "lang"
4275         parameter.
4276         (mapped_index_base::build_name_components): Also split names
4277         according to Ada syntax.
4278         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
4279         type of "match_callback".
4280         (check_match, check_find_bounds_finds)
4281         (dw2_expand_symtabs_matching): Update.
4282         (dw2_debug_names_iterator): Add new constructor.
4283         (dw2_debug_names_map_matching_symbols): New function.
4284         (dw2_debug_names_expand_symtabs_matching): Update.
4285         (dwarf2_debug_names_functions): Use
4286         dw2_debug_names_map_matching_symbols.
4287
4288 2019-09-10  Tom Tromey  <tromey@adacore.com>
4289
4290         * dwarf2read.c (dw2_get_file_names_reader): Add the
4291         CU's file name to the results.
4292
4293 2019-09-10  Tom Tromey  <tromey@adacore.com>
4294
4295         * ada-lang.c (add_nonlocal_symbols): Combine calls to
4296         map_matching_symbols.  Update.
4297         * dwarf2read.c (dw2_map_matching_symbols): Update.
4298         * psymtab.c (match_partial_symbol): Change type; update.
4299         (psym_map_matching_symbols): Likewise.
4300         * symfile-debug.c (debug_qf_map_matching_symbols): Change
4301         type; update.
4302         * symfile.h (struct quick_symbol_functions)
4303         <map_matching_symbols>: Change "name" to be a lookup_name_info.
4304         Remove "match".
4305
4306 2019-09-10  Tom Tromey  <tromey@adacore.com>
4307
4308         * psymtab.c (map_block): Remove.
4309         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4310         * symtab.c (iterate_over_symbols_terminated): New function.
4311         * symtab.c (iterate_over_symbols_terminated): Declare.
4312
4313 2019-09-10  Tom Tromey  <tromey@adacore.com>
4314
4315         * ada-lang.c (ada_iterate_over_symbols): Return bool.
4316         * language.h (struct language_defn) <la_iterate_over_symbols>:
4317         Return bool.
4318         * symtab.c (iterate_over_symbols): Return bool.
4319         * symtab.h (iterate_over_symbols): Return bool.
4320
4321 2019-09-10  Tom Tromey  <tromey@adacore.com>
4322
4323         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4324         (add_nonlocal_symbols): Update.
4325         * dwarf2read.c (dw2_map_matching_symbols): Change type.
4326         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4327         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4328         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4329         Change type of "callback".  Remove "data".
4330
4331
4332 2019-09-09  Ali Tamur  <tamur@google.com>
4333
4334         * dwarf2read.c (comp_unit_head): Update comment.
4335         (dwarf2_dwo_name): New function declaration.
4336         (dwarf_unit_type_name): New function declaration.
4337         (read_comp_unit_head): Add support for new compilation units,
4338         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4339         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4340         (currently named as "signature") in their header. Also clarify error
4341         messages.
4342         (lookup_dwo_id): New function. Returns the dwo id of the given
4343         compile unit.
4344         (lookup_dwo_unit): Use the new lookup_dwo_id function.
4345         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4346         functions.
4347         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4348         (dwarf2_dwo_name): Get the dwo name if present.
4349         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4350         purposes.
4351
4352 2019-09-09  Tom Tromey  <tom@tromey.com>
4353
4354         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4355
4356 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4357
4358         * python/python.c (do_start_initialization): Make progname_copy static,
4359         to avoid a leak report.
4360
4361 2019-09-08  Tom Tromey  <tom@tromey.com>
4362
4363         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4364
4365 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
4366
4367         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4368         Change type to gdb::optional<block_enum>.
4369         (dw2_symtab_iter_init): Change block_index parameter type
4370         to gdb::optional<block_enum>.
4371         (dw2_lookup_symbol): Change block_index parameter
4372         type to block_enum.c
4373         (dw2_debug_names_lookup_symbol): Likewise.
4374         * psymtab.c (psym_lookup_symbol): Likewise.
4375         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4376         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4377         Likewise.
4378
4379 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
4380
4381         * defs.h (relocate_gdb_directory): Change int to bool in
4382         signature and rename flag to relocatable.
4383         * main.c (relocate_path): Likewise.
4384         (relocate_gdb_directory): Likewise.
4385
4386 2019-09-06  Alan Modra  <amodra@gmail.com>
4387
4388         * coffread.c (coff_symfile_read): Constify filename variable.
4389         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4390         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4391         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4392         * solib.c (reload_shared_libraries_1): Likewise.
4393         * symfile.c (reread_symbols): Likewise.
4394         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4395         * solib-darwin.c (darwin_bfd_open): Likewise.
4396         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4397
4398 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4399
4400         * psymtab.c (print_partial_symbols): Handle missing domain_enum
4401         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4402
4403 2019-09-03  Tom Tromey  <tromey@adacore.com>
4404
4405         * ada-valprint.c (ada_val_print_num): Don't recurse for range
4406         types.
4407         (has_negatives): Unbias a range type bound.
4408         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4409         * gdbtypes.c (operator==): Handle new field.
4410         (create_range_type): Add "bias" parameter.
4411         (create_static_range_type, resolve_dynamic_range): Update.
4412         * gdbtypes.h (struct range_bounds) <bias>: New member.
4413         (create_range_type): Add bias parameter.
4414         * printcmd.c (print_scalar_formatted): Unbias range types.
4415         * value.c (unpack_long): Unbias range types.
4416         (pack_long): Bias range types.
4417
4418 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4419
4420         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4421         probe arguments.
4422
4423 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4424
4425         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4426         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4427         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4428         (compile_probe_arg): Likewise.
4429         * probe.h (get_argument_count): Likewise.
4430         * solib-svr4.c (solib_event_probe_action): Likewise.
4431         * stap-probe.c (stap_probe::get_argument_count): Likewise.
4432
4433 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4434
4435         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4436         code to here...
4437         (svr4_create_solib_event_breakpoints): ...from here.
4438
4439 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
4440
4441         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4442         suffix from warning message.
4443
4444 2019-08-30  Tom Tromey  <tom@tromey.com>
4445
4446         * tui/tui-winsource.h (struct tui_source_window_base)
4447         <refresh_all>: Don't declare.
4448         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4449         Remove.
4450         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4451         tui_show_locator_content.
4452         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4453         declare.
4454         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4455         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4456         declare.
4457
4458 2019-08-30  Tom Tromey  <tom@tromey.com>
4459
4460         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4461
4462 2019-08-30  Tom Tromey  <tom@tromey.com>
4463
4464         * tui/tui-stack.c (_initialize_tui_stack): Move later.
4465         Remove unnecessary forward declarations.
4466
4467 2019-08-30  Tom Tromey  <tom@tromey.com>
4468
4469         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4470         rerender.
4471         (tui_update_locator_fullname, tui_show_frame_info): Don't call
4472         tui_show_locator_content.
4473
4474 2019-08-30  Tom Tromey  <tom@tromey.com>
4475
4476         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
4477         (tui_locator_window::rerender): Rewrite using body of previous
4478         tui_show_locator_content.
4479
4480 2019-08-30  Tom Tromey  <tom@tromey.com>
4481
4482         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4483         set_locator_fullname>: New methods.
4484         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4485         Rename from tui_set_locator_fullname.
4486         (tui_locator_window::set_locator_info): Rename from
4487         tui_set_locator_info.  Return bool.
4488         (tui_update_locator_fullname, tui_show_frame_info): Update.
4489
4490 2019-08-30  Tom Tromey  <tom@tromey.com>
4491
4492         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4493
4494 2019-08-30  Tom Tromey  <tom@tromey.com>
4495
4496         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4497         call touchwin.
4498
4499 2019-08-30  Tom Tromey  <tom@tromey.com>
4500
4501         * tui/tui-wingeneral.c (box_win): Assume win_info and
4502         win_info->handle cannot be NULL.
4503
4504 2019-08-30  Tom Tromey  <tom@tromey.com>
4505
4506         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4507         refresh_window>: Declare.
4508         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4509         resize.
4510         (tui_data_item_window::rerender): Rename from
4511         tui_display_register.
4512         (tui_data_item_window::refresh_window): New method.
4513         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4514         no-op.
4515
4516 2019-08-30  Tom Tromey  <tom@tromey.com>
4517
4518         * tui/tui-regs.h (struct tui_data_window) <regs_content,
4519         regs_column_count, current_group>: Move later.  Now private.
4520         <get_current_group>: New method.
4521         * tui/tui-regs.c (tui_reg_command): Update.
4522         * tui/tui-layout.c (tui_set_layout): Update.
4523
4524 2019-08-30  Tom Tromey  <tom@tromey.com>
4525
4526         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4527         (tui_data_window::rerender): Don't call
4528         check_and_display_highlight_if_needed.
4529         (tui_data_window::refresh_all): Remove call to
4530         erase_data_content.
4531
4532 2019-08-30  Tom Tromey  <tom@tromey.com>
4533
4534         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4535         (tui_data_window::display_registers_from)
4536         (tui_data_window::display_reg_element_at_line)
4537         (tui_data_window::display_registers_from_line): Remove checks of
4538         "empty".
4539
4540 2019-08-30  Tom Tromey  <tom@tromey.com>
4541
4542         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4543         Don't declare.
4544         * tui/tui-regs.c (tui_data_window::show_registers): Call
4545         rerender.
4546         (tui_data_window::rerender): Rename from display_all_data.
4547         (tui_data_window::rerender): Remove old implementation.
4548
4549 2019-08-30  Tom Tromey  <tom@tromey.com>
4550
4551         * tui/tui-regs.c (tui_data_window::display_all_data): Change
4552         text.
4553         * tui/tui-data.h (NO_DATA_STRING): Remove define.
4554
4555 2019-08-29  Bernhard Wodok  <barto@gmx.net>
4556             Sergio Durigan Junior  <sergiodj@redhat.com>
4557
4558         PR win32/24284
4559         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4560
4561 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4562
4563         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4564         when searching for types.
4565
4566 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4567
4568         * f-lang.c (f_language_defn): Use f_print_typedef.
4569         * f-lang.h (f_print_typedef): Declare.
4570         * f-typeprint.c (f_print_typedef): Define.
4571
4572 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
4573
4574         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4575
4576 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4577
4578         * cli/cli-utils.c (info_print_options_defs): Delete.
4579         (make_info_print_options_def_group): Delete.
4580         (extract_info_print_options): Delete.
4581         (info_print_command_completer): Delete.
4582         (info_print_args_help): Add extra parameter, and optionally
4583         include text about -n flag.
4584         * cli/cli-utils.h (struct info_print_options): Delete.
4585         (extract_info_print_options): Delete declaration.
4586         (info_print_command_completer): Delete declaration.
4587         (info_print_args_help): Add extra parameter, extend header
4588         comment.
4589         * python/python.c (gdbpy_rbreak): Pass additional parameter to
4590         search_symbols.
4591         * stack.c (struct info_print_options): New type.
4592         (info_print_options_defs): New file scoped variable.
4593         (make_info_print_options_def_group): New static function.
4594         (info_print_command_completer): New static function.
4595         (info_locals_command): Update to use new local functions.
4596         (info_args_command): Likewise.
4597         (_initialize_stack): Add extra parameter to calls to
4598         info_print_args_help.
4599         * symtab.c (search_symbols): Add extra parameter, use this to
4600         possibly excluse non-debug symbols.
4601         (symtab_symbol_info): Add extra parameter, which is passed on to
4602         search_symbols.
4603         (struct info_print_options): New type.
4604         (info_print_options_defs): New file scoped variable.
4605         (make_info_print_options_def_group): New static function.
4606         (info_print_command_completer): New static function.
4607         (info_variables_command): Update to use local functions, and pass
4608         extra parameter through to symtab_symbol_info.
4609         (info_functions_command): Likewise.
4610         (info_types_command): Pass additional argument through to
4611         symtab_symbol_info.
4612         (rbreak_command): Pass extra argument to search_symbols.
4613         (_initialize_symtab): Add extra arguments for calls to
4614         info_print_args_help, and update help text for 'info variables',
4615         'whereis', and 'info functions' commands.
4616         * symtab.h (search_symbols): Add extra argument to declaration.
4617         * NEWS: Mention new flags.
4618
4619 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
4620
4621         * symtab.c (lookup_static_symbol): Call the new function (and move
4622         it down to be next to lookup_global_symbol).
4623         (struct global_sym_lookup_data): Add block_enum member and rename to...
4624         (struct global_or_static_sym_lookup_data): ...this.
4625         (lookup_symbol_global_iterator_cb): Pass block_index instead of
4626         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4627         (lookup_symbol_global_or_static_iterator_cb): ...this.
4628         (lookup_global_or_static_symbol): New function.
4629         (lookup_global_symbol): Call new function.
4630
4631 2019-08-26  Tom de Vries  <tdevries@suse.de>
4632
4633         PR c++/24852
4634         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4635         when pc_probe.prob == NULL.
4636
4637 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4638
4639         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4640         variable symbol_linkage to symbol_linkage_.
4641
4642 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4643
4644         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4645         represent whether the symbol is static, dynamic, or we don't
4646         know.
4647
4648 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
4649
4650         * gdb/rx-tdep.c (rx_register_names): New.
4651         (rx_register_name): Delete.
4652         (rx_psw_type): Delete.
4653         (rx_fpsw_type): Delete.
4654         (rx_register_type): Delete.
4655         (rx_gdbarch_init): Convert target-descriptions.
4656         (_initialize_rx_tdep): Add initialize_tdesc_rx.
4657         * gdb/features/Makefile: Add rx.xml.
4658         * gdb/features/rx.xml: New.
4659         * gdb/features/rx.c: Generated.
4660         * gdb/NEWS: Mention target description support.
4661
4662 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4663
4664         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4665         *slot_ptr.
4666
4667 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4668
4669         * configure.ac: Don't check for 'dlfcn.h' (moved to
4670         gdbsupport/common.m4).
4671         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4672         'gdbsupport/'.
4673         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4674         * compile/compile-c-support.c: Include
4675         'gdbsupport/gdb-dlfcn.h'.
4676         * gdbsupport/common.m4: Check for 'dlfcn.h'.
4677         * gdb-dlfcn.c: Move to...
4678         * gdbsupport/gdb-dlfcn.c: ... here.
4679         * gdb-dlfcn.h: Move to...
4680         * gdbsupport/gdb-dlfcn.h: ... here.
4681
4682 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
4683
4684         * nios2-tdep.c (struct reg_value): Improve comments.  Make
4685         the offset field signed.
4686
4687 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4688
4689         * python/lib/gdb/__init__.py (_execute_file): New function.
4690         * python/python.c (python_run_simple_file): Call gdb._execute_file
4691         on Windows.
4692
4693 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4694
4695         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4696         all uses as this was never set to anything but a zero value.
4697
4698 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
4699
4700         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4701
4702 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
4703
4704         * tui/tui-data.h (tui_gen_win_info): Add an =default
4705         move constructor, required by some GCC versions.
4706
4707 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
4708
4709         * go32-nat.c (go32_sysinfo): Add hygon_p.
4710
4711 2019-08-20  Tom Tromey  <tom@tromey.com>
4712
4713         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4714         line_from_reg_element_no, first_reg_element_no_inline,
4715         display_all_data, delete_data_content_windows,
4716         erase_data_content>: Now private.
4717
4718 2019-08-20  Tom Tromey  <tom@tromey.com>
4719
4720         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4721         (tui_unhighlight_win, tui_highlight_win)
4722         (tui_win_info::make_window): Update.
4723         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4724
4725 2019-08-20  Tom Tromey  <tom@tromey.com>
4726
4727         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4728         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4729         (MAX_PID_WIDTH): Move to tui-stack.c.
4730         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4731         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4732         (MAX_PID_WIDTH): Move from tui-data.h.
4733
4734 2019-08-20  Tom Tromey  <tom@tromey.com>
4735
4736         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4737         * tui/tui-wingeneral.c (box_win): Change type of win_info.
4738         (box_win): Update.
4739         (tui_gen_win_info::make_window): Rename from tui_make_window.
4740         (tui_win_info::make_window): New method.
4741         (tui_gen_win_info::make_visible): Update.
4742         * tui/tui-source.c (tui_source_window::set_contents): Update.
4743         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4744         (tui_data_window::display_registers_from): Update.
4745         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4746         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4747         Declare.
4748         <can_box>: Remove.
4749         <title>: Remove.
4750         (struct tui_win_info) <make_window>: Declare.
4751         <can_box>: Now virtual.
4752         <title>: New member.
4753         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4754         * tui/tui-command.c (tui_cmd_window::resize): Update.
4755
4756 2019-08-20  Tom Tromey  <tom@tromey.com>
4757
4758         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4759         * tui/tui-regs.c (tui_data_window::show_registers): Update.
4760         (tui_data_window::check_register_values): Update.
4761
4762 2019-08-20  Tom Tromey  <tom@tromey.com>
4763
4764         * tui/tui-regs.h (struct tui_data_window): Use
4765         DISABLE_COPY_AND_ASSIGN.
4766         <regs_content>: Change type, removing unique_ptr.
4767         <tui_data_window>: Add move constructor.
4768         * tui/tui-regs.c (tui_data_window::show_registers)
4769         (tui_data_window::show_register_group)
4770         (tui_data_window::display_registers_from)
4771         (tui_data_window::display_registers_from)
4772         (tui_data_window::first_data_item_displayed)
4773         (tui_data_window::delete_data_content_windows)
4774         (tui_data_window::rerender, tui_data_window::refresh_window)
4775         (tui_data_window::check_register_values): Update.
4776
4777 2019-08-20  Tom Tromey  <tom@tromey.com>
4778
4779         * tui/tui-regs.h (struct tui_data_window) <show_registers,
4780         show_register_group>: Declare.
4781         (tui_show_register_group): Don't declare.
4782         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4783         tui_show_registers.
4784         (tui_data_window::show_register_group): Rename from
4785         tui_show_register_group.
4786         (tui_data_window::check_register_values, tui_reg_command):
4787         Update.
4788         * tui/tui-layout.c (tui_set_layout): Update.
4789
4790 2019-08-20  Tom Tromey  <tom@tromey.com>
4791
4792         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4793         Declare.
4794         (tui_check_register_values): Don't declare.
4795         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4796         from tui_check_register_values.
4797         * tui/tui-hooks.c (tui_register_changed): Update.
4798
4799 2019-08-20  Tom Tromey  <tom@tromey.com>
4800
4801         * tui/tui-regs.c (tui_reg_layout): Move later.
4802         (tui_show_registers): Don't enable TUI mode or change layout.
4803
4804 2019-08-20  Tom Tromey  <tom@tromey.com>
4805
4806         * tui/tui-regs.h (struct tui_data_item_window)
4807         <~tui_data_item_window>: Remove.
4808         <content>: Now a unique_xmalloc_ptr.
4809         * tui/tui-regs.c (tui_register_format): Return a
4810         unique_xmalloc_ptr.
4811         (tui_get_register): Update.
4812         (~tui_data_item_window): Remove.
4813         (tui_data_window::display_registers_from, tui_display_register):
4814         Update.
4815         * tui/tui-io.h (tui_expand_tabs): Update.
4816         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4817         Remove "col" parameter.
4818
4819 2019-08-20  Tom Tromey  <tom@tromey.com>
4820
4821         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4822         field.
4823         * tui/tui-regs.c (~tui_data_item_window): Update.
4824
4825 2019-08-20  Tom Tromey  <tom@tromey.com>
4826
4827         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4828         earlier.
4829
4830 2019-08-20  Tom Tromey  <tom@tromey.com>
4831
4832         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4833
4834 2019-08-20  Tom Tromey  <tom@tromey.com>
4835
4836         * tui/tui-source.h (struct tui_source_window): Update.
4837         * tui/tui-regs.c (tui_show_registers): Update.
4838         * tui/tui-disasm.h (struct tui_disasm_window): Update.
4839         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4840         (NO_REGS_STRING): Remove defines.
4841
4842 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
4843
4844         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4845         unnecessary thread walk if remote doesn't support the packet.
4846
4847 2019-08-19  Tom Tromey  <tromey@adacore.com>
4848
4849         * python/py-value.c (value_has_field): Fix indentation.
4850
4851 2019-08-19  Tom Tromey  <tromey@adacore.com>
4852
4853         * printcmd.c (do_one_display, info_display_command): Update.
4854         * block.h (contained_in): Return bool.  Add allow_nested
4855         parameter.
4856         * block.c (contained_in): Return bool.  Add allow_nested
4857         parameter.
4858
4859 2019-08-19  Tom Tromey  <tom@tromey.com>
4860
4861         * configure: Rebuild.
4862         * configure.ac: Disallow the combination of -static-libstdc++ and
4863         source highlight.
4864         * source-cache.c (get_language_name): Handle rust.
4865         (source_cache::get_source_lines): Ignore highlighting exceptions.
4866
4867 2019-08-16  Tom Tromey  <tom@tromey.com>
4868
4869         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4870         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4871         (struct tui_source_window_base) <make_visible, refresh_window,
4872         resize>: Remove methods.
4873         <execution_info>: Remove field.
4874         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4875         (tui_show_source_line, tui_source_window_base)
4876         (~tui_source_window_base): Update.
4877         (tui_source_window_base::resize)
4878         (tui_source_window_base::make_visible)
4879         (tui_source_window_base::refresh_window): Remove.
4880         (tui_source_window_base::update_exec_info): Update.
4881         * tui/tui-source.c (tui_source_window::set_contents): Update.
4882         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4883
4884 2019-08-16  Tom Tromey  <tom@tromey.com>
4885
4886         * tui/tui-hooks.c (tui_remove_hooks): Don't set
4887         deprecated_query_hook.
4888
4889 2019-08-16  Tom Tromey  <tom@tromey.com>
4890
4891         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4892         (tui_update_source_windows_with_line): Update.
4893         * tui/tui-source.h (struct tui_source_window)
4894         <show_symtab_source>: Declare.
4895         (tui_show_symtab_source): Don't declare.
4896         * tui/tui-source.c (tui_show_symtab_source): Rename from
4897         tui_show_symtab_source.
4898
4899 2019-08-16  Tom Tromey  <tom@tromey.com>
4900
4901         * tui/tui-winsource.h (struct tui_source_window_base)
4902         <set_contents>: Declare.
4903         * tui/tui-winsource.c
4904         (tui_source_window_base::update_source_window_as_is): Update.
4905         * tui/tui-source.h (struct tui_source_window) <set_contents>:
4906         Declare.
4907         (tui_set_source_content): Don't declare.
4908         * tui/tui-source.c (tui_source_window::set_contents): Rename from
4909         tui_set_source_content.
4910         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4911         Declare.
4912         (tui_set_disassem_content): Don't declare.
4913         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4914         tui_set_disassem_content.
4915
4916 2019-08-16  Tom Tromey  <tom@tromey.com>
4917
4918         * tui/tui-winsource.h (struct tui_source_window_base)
4919         <update_breakpoint_info>: Declare.
4920         (tui_update_breakpoint_info): Don't declare.
4921         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4922         (tui_update_all_breakpoint_info): Update.
4923         (tui_source_window_base::update_breakpoint_info): Rename from
4924         tui_update_breakpoint_info.
4925         (tui_source_window_base::update_exec_info): Update.
4926
4927 2019-08-16  Tom Tromey  <tom@tromey.com>
4928
4929         * tui/tui-winsource.h (struct tui_source_window_base)
4930         <update_source_window>: Declare.
4931         (tui_update_source_window): Don't declare.
4932         * tui/tui-winsource.c
4933         (tui_source_window_base::update_source_window): Rename from
4934         tui_update_source_window.
4935         (tui_source_window_base::rerender): Update.
4936         * tui/tui-source.c (tui_source_window::maybe_update): Update.
4937         * tui/tui-disasm.c (tui_show_disassem)
4938         (tui_show_disassem_and_update_source)
4939         (tui_disasm_window::maybe_update): Update.
4940
4941 2019-08-16  Tom Tromey  <tom@tromey.com>
4942
4943         * tui/tui-winsource.h (struct tui_source_window_base)
4944         <update_source_window_as_is>: Declare.
4945         (tui_update_source_window_as_is): Don't declare.
4946         * tui/tui-winsource.c (tui_update_source_window): Update
4947         (tui_source_window_base::update_source_window_as_is): Rename from
4948         tui_update_source_window_as_is.
4949         (tui_source_window_base::refill): Update.
4950         * tui/tui-source.c (tui_show_symtab_source): Update.
4951         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
4952         Update.
4953
4954 2019-08-16  Tom Tromey  <tom@tromey.com>
4955
4956         * tui/tui-winsource.h (tui_update_source_window)
4957         (tui_update_source_window_as_is): Remove "noerror" parameter.
4958         * tui/tui-winsource.c (tui_update_source_window)
4959         (tui_update_source_window_as_is): Remove "noerror" parameter.
4960         (tui_update_source_windows_with_addr)
4961         (tui_update_source_windows_with_line)
4962         (tui_source_window_base::rerender)
4963         (tui_source_window_base::refill): Update.
4964         * tui/tui-source.h (tui_set_source_content)
4965         (tui_show_symtab_source): Remove "noerror" parameter.
4966         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
4967         parameter.
4968         (tui_show_symtab_source): Likewise.
4969         (tui_source_window::maybe_update): Update.
4970         * tui/tui-disasm.c (tui_show_disassem)
4971         (tui_show_disassem_and_update_source)
4972         (tui_disasm_window::do_scroll_vertical)
4973         (tui_disasm_window::maybe_update): Update.
4974
4975 2019-08-16  Tom Tromey  <tom@tromey.com>
4976
4977         * tui/tui.c (tui_is_window_visible): Update.
4978         * tui/tui-wingeneral.c (tui_make_window)
4979         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
4980         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
4981         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
4982         (tui_set_win_height_command, parse_scrolling_args): Update.
4983         * tui/tui-source.c (tui_source_window::style_changed): Update.
4984         * tui/tui-regs.c (tui_show_registers)
4985         (tui_data_window::first_data_item_displayed)
4986         (tui_data_window::delete_data_content_windows)
4987         (tui_check_register_values, tui_reg_command): Update.
4988         * tui/tui-disasm.c (tui_show_disassem): Update.
4989         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
4990         method.
4991         <is_visible>: Remove field.
4992         * tui/tui-data.c (tui_next_win, tui_prev_win)
4993         (tui_delete_invisible_windows): Update.
4994
4995 2019-08-16  Tom Tromey  <tom@tromey.com>
4996
4997         * tui/tui-winsource.h (struct tui_source_window_base)
4998         <m_has_locator>: Remove.
4999         * tui/tui-layout.c (show_source_disasm_command, show_data)
5000         (show_source_or_disasm_and_command): Update.
5001
5002 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
5003
5004         * NEWS (Other MI changes): New subsection.
5005         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5006         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5007         * arch-utils.c (default_get_pc_address_flags): New function.
5008         * arch-utils.h (default_get_pc_address_flags): New declaration.
5009         * gdbarch.sh: Add get_pc_address_flags.
5010         * gdbarch.c: Regenerate.
5011         * gdbarch.h: Likewise.
5012         * stack.c (print_pc): New function.
5013         (print_frame_info) (print_frame): Call print_pc.
5014
5015 2019-08-16  Tom de Vries  <tdevries@suse.de>
5016
5017         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5018         print_objfile_section_info.
5019
5020 2019-08-15  Tom Tromey  <tom@tromey.com>
5021
5022         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5023         calling update_cmdwin_start_line.
5024         * tui/tui-winsource.h (struct tui_source_window_base)
5025         <do_make_visible_with_new_height, set_new_height>: Don't declare.
5026         <rerender>: Declare.
5027         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5028         Call rerender.
5029         (tui_source_window_base::set_new_height): Remove.
5030         (tui_source_window_base::rerender): Rename from
5031         do_make_visible_with_new_height.
5032         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5033         resize method.
5034         (tui_win_info::make_invisible_and_set_new_height)
5035         (tui_win_info::make_visible_with_new_height): Remove.
5036         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5037         Declare.
5038         * tui/tui-stack.c (tui_locator_window::rerender): New method.
5039         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5040         do_make_visible_with_new_height>: Don't declare.
5041         <rerender>: Declare.
5042         * tui/tui-regs.c (tui_data_window::rerender): Rename from
5043         set_new_height.
5044         (tui_data_window::do_make_visible_with_new_height): Remove.
5045         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5046         call tui_show_locator_content.
5047         (tui_gen_win_info::resize): Call rerender.
5048         (show_source_or_disasm_and_command): Don't call
5049         tui_show_locator_content.
5050         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5051         method.
5052         (struct tui_win_info) <rerender>: Declare.
5053         <set_new_height, make_invisible_and_set_new_height,
5054         make_visible_with_new_height>: Don't declare.
5055         * tui/tui-data.c (tui_win_list::rerender): New method.
5056         * tui/tui-command.h (struct tui_cmd_window)
5057         <do_make_visible_with_new_height>: Don't declare.
5058         * tui/tui-command.c
5059         (tui_cmd_window::do_make_visible_with_new_height): Remove.
5060
5061 2019-08-15  Tom Tromey  <tromey@adacore.com>
5062
5063         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5064         * ada-lang.c (ada_enum_name): Likewise.
5065
5066 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
5067
5068         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5069         leading underscore.
5070         (GdbOutputErrorFile): Likewise.
5071         (global scope): Adjust constructor calls to GdbOutput{,Error}File
5072         accordingly.
5073         (execute_unwinders): Rename to have a leading underscore.
5074         (auto_load_packages): Likewise.
5075         (global scope): Adjust call to auto_load_packages accordingly.
5076         (GdbSetPythonDirectory): Likewise.
5077         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5078         instead of execute_unwinders.
5079
5080 2019-08-15  Tom Tromey  <tom@tromey.com>
5081
5082         * tui/tui-layout.c (show_layout, show_source_disasm_command)
5083         (show_data): Don't change window visibility.
5084         (tui_gen_win_info::resize): Remove special case for command
5085         window.  Use wresize, when available.
5086         (show_source_or_disasm_and_command): Don't change window
5087         visibility.
5088         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5089         <make_visible>: New method.
5090         * tui/tui-command.c (tui_cmd_window::resize): New method.
5091
5092 2019-08-15  Tom Tromey  <tom@tromey.com>
5093
5094         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5095         (struct tui_source_windows): New.
5096         * tui/tui-winsource.c (tui_display_main): Update.
5097         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5098         (new_height_ok, parse_scrolling_args): Update.
5099         * tui/tui-layout.c (show_layout, show_data): Update.
5100         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5101         (tui_add_to_source_windows): Don't declare.
5102         * tui/tui-data.c (source_windows, tui_source_windows)
5103         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5104
5105 2019-08-15  Tom Tromey  <tom@tromey.com>
5106
5107         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5108         Rename from reset.
5109         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5110         * tui/tui-layout.c (show_source_disasm_command, show_data):
5111         Update.
5112         (tui_gen_win_info::resize): Rename.
5113         (show_source_or_disasm_and_command): Update.
5114         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5115         reset.
5116
5117 2019-08-15  Tom Tromey  <tom@tromey.com>
5118
5119         * tui/tui-stack.c (tui_initialize_static_data): Remove.
5120         * tui/tui-interp.c (tui_interp::init): Don't call
5121         tui_initialize_static_data.
5122         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5123
5124 2019-08-15  Tom Tromey  <tom@tromey.com>
5125
5126         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5127         examine tui_win_list.
5128
5129 2019-08-15  Tom Tromey  <tom@tromey.com>
5130
5131         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5132         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5133         tui_clear_source_content.
5134         (tui_clear_source_content): Remove.
5135         (tui_source_window_base::do_erase_source_content): Hoist call to
5136         content.clear().
5137         * tui/tui-stack.c (tui_show_frame_info): Don't call
5138         tui_clear_source_content.
5139
5140 2019-08-15  Tom Tromey  <tom@tromey.com>
5141
5142         * tui/tui-winsource.h (struct tui_source_window_base)
5143         <do_erase_source_content>: New method.
5144         <erase_source_content>: New method.
5145         (tui_erase_source_content): Don't declare.
5146         * tui/tui-winsource.c (tui_clear_source_content): Update.
5147         (tui_source_window_base::do_erase_source_content): Rename from
5148         tui_erase_source_content.
5149         (tui_source_window_base::show_source_content): Update.
5150         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5151         * tui/tui-source.h (struct tui_source_window)
5152         <erase_source_content>: New method.
5153         * tui/tui-disasm.h (struct tui_disasm_window)
5154         <erase_source_content>: New method.
5155
5156 2019-08-15  Tom Tromey  <tom@tromey.com>
5157
5158         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5159         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5160         constructor.
5161         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5162         * tui/tui-source.c (tui_set_source_content): Update.
5163         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5164
5165 2019-08-15  Tom Tromey  <tom@tromey.com>
5166
5167         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5168         * tui/tui-winsource.c (tui_line_is_displayed): Move to
5169         tui-source.c.
5170         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5171         Declare.
5172         * tui/tui-source.c (tui_source_window::line_is_displayed): New
5173         method.
5174         (tui_source_window::maybe_update): Update.
5175
5176 2019-08-15  Tom Tromey  <tom@tromey.com>
5177
5178         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5179         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5180         tui-disasm.c.
5181         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5182         Declare.
5183         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5184         method.
5185         (tui_disasm_window::maybe_update): Update.
5186
5187 2019-08-15  Tom Tromey  <tom@tromey.com>
5188
5189         * tui/tui-winsource.h (struct tui_source_window_base)
5190         <maybe_update>: Declare.
5191         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5192         method.
5193         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5194         Declare.
5195         * tui/tui-source.c (tui_source_window::maybe_update): New method.
5196         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5197         Declare.
5198         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5199
5200 2019-08-15  Tom Tromey  <tom@tromey.com>
5201
5202         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5203
5204 2019-08-15  Tom Tromey  <tom@tromey.com>
5205
5206         * tui/tui-wingeneral.c: Include tui-stack.h.
5207         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5208         (struct tui_locator_window): Move from tui-data.h.
5209         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5210         (tui_initialize_static_data): Move from tui-data.c.
5211         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5212         (struct tui_locator_window): Move to tui-stack.c.
5213         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5214         (tui_initialize_static_data): Move to tui-stack.c.
5215
5216 2019-08-15  Tom Tromey  <tom@tromey.com>
5217
5218         * tui/tui-layout.c (show_source_disasm_command)
5219         (show_source_or_disasm_and_command): Use make_visible method, not
5220         tui_make_window.
5221         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5222         Remove.
5223
5224 2019-08-15  Tom Tromey  <tom@tromey.com>
5225
5226         * tui/tui-wingeneral.h (tui_make_window): Update.
5227         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5228         parameter.
5229         (tui_gen_win_info::make_visible): Update.
5230         * tui/tui-regs.c (tui_data_window::display_registers_from):
5231         Update.
5232         * tui/tui-layout.c (show_source_disasm_command)
5233         (show_source_or_disasm_and_command): Update.
5234         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5235         (enum tui_box): Remove.
5236         (struct tui_win_info) <can_box>: New method.
5237         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5238         method.
5239
5240 2019-08-15  Tom de Vries  <tdevries@suse.de>
5241
5242         * linux-nat-trad.c: Include gdbarch.h.
5243
5244 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
5245
5246         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5247         register sizes.
5248
5249 2019-08-14  Tom Tromey  <tromey@adacore.com>
5250
5251         * darwin-nat.c: Include gdbarch.h.
5252         * darwin-nat-info.c: Include gdbarch.h.
5253
5254 2019-08-13  Tom Tromey  <tom@tromey.com>
5255
5256         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5257         Remove.
5258         * tui/tui-data.c (tui_initialize_static_data): Update.
5259
5260 2019-08-13  Tom Tromey  <tom@tromey.com>
5261
5262         * tui/tui-winsource.h (struct tui_exec_info_window)
5263         <~tui_exec_info_window, maybe_allocate_content, get_content,
5264         m_content>: Remove.
5265         (struct tui_source_window_base) <set_exec_info_content,
5266         show_exec_info_content>: Don't declare.
5267         * tui/tui-winsource.c
5268         (tui_exec_info_window::maybe_allocate_content): Remove.
5269         (tui_source_window_base::update_exec_info): Rename from
5270         set_exec_info_content.
5271         (tui_source_window_base::show_exec_info_content)
5272         (tui_source_window_base::update_exec_info): Remove.
5273
5274 2019-08-13  Tom Tromey  <tom@tromey.com>
5275
5276         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5277         declare.
5278         * tui/tui-winsource.c (tui_update_source_window_as_is)
5279         (tui_update_source_windows_with_addr, tui_erase_source_content):
5280         Update.
5281         (tui_clear_exec_info_content): Remove.
5282
5283 2019-08-13  Tom Tromey  <tom@tromey.com>
5284
5285         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5286         declare.
5287         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5288         call tui_erase_exec_info_content.
5289         (tui_clear_exec_info_content): Rename from
5290         tui_erase_exec_info_content.
5291         (tui_clear_exec_info_content): Delete.
5292
5293 2019-08-13  Tom Tromey  <tom@tromey.com>
5294
5295         * tui/tui-winsource.h (struct tui_source_window_base)
5296         <show_exec_info_content>: Declare.
5297         (tui_show_exec_info_content): Don't declare.
5298         * tui/tui-winsource.c
5299         (tui_source_window_base::show_exec_info_content): Rename from
5300         tui_show_exec_info_content.
5301         (tui_source_window_base::update_exec_info): Update.
5302
5303 2019-08-13  Tom Tromey  <tom@tromey.com>
5304
5305         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5306         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5307         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5308         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5309         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5310         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5311         ... here.
5312
5313 2019-08-13  Tom Tromey  <tom@tromey.com>
5314
5315         * tui/tui-winsource.h (struct tui_source_window_base)
5316         <update_exec_info>: Declare.
5317         (tui_update_exec_info): Don't declare.
5318         * tui/tui-winsource.c (tui_update_source_window_as_is)
5319         (tui_source_window_base::refresh_all)
5320         (tui_update_all_breakpoint_info): Update.
5321         (tui_source_window_base::update_exec_info): Rename from
5322         tui_update_exec_info.
5323         * tui/tui-stack.c (tui_show_frame_info): Update.
5324
5325 2019-08-13  Tom Tromey  <tom@tromey.com>
5326
5327         * tui/tui-winsource.h (struct tui_source_window_base)
5328         <set_exec_info_content>: Declare.
5329         (tui_set_exec_info_content): Don't declare.
5330         * tui/tui-winsource.c
5331         (tui_source_window_base::set_exec_info_content): Rename from
5332         tui_set_exec_info_content.
5333         (tui_update_exec_info): Update.
5334
5335 2019-08-13  Tom Tromey  <tom@tromey.com>
5336
5337         * tui/tui-winsource.h (struct tui_source_window_base)
5338         <show_source_content>: Declare.
5339         (tui_show_source_content): Don't declare.
5340         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5341         (tui_source_window_base::show_source_content): Rename from
5342         tui_show_source_content.
5343         (tui_source_window_base::refresh_all): Update.
5344         * tui/tui-layout.c (show_source_disasm_command)
5345         (show_source_or_disasm_and_command): Update.
5346
5347 2019-08-13  Tom Tromey  <tom@tromey.com>
5348
5349         * tui/tui-winsource.c (tui_erase_source_content)
5350         (tui_show_source_content, tui_source_window_base::refresh_all):
5351         Update.
5352         * tui/tui-wingeneral.h
5353         (tui_check_and_display_highlight_if_needed): Don't declare.
5354         * tui/tui-wingeneral.c
5355         (tui_win_info::check_and_display_highlight_if_needed): Rename from
5356         check_and_display_highlight_if_needed.
5357         * tui/tui-win.c (tui_rehighlight_all)
5358         (tui_win_info::make_visible_with_new_height): Update.
5359         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5360         (tui_data_window::erase_data_content)
5361         (tui_data_window::display_all_data): Update.
5362         * tui/tui-data.h (struct tui_win_info)
5363         <check_and_display_highlight_if_needed>: Declare.
5364
5365 2019-08-13  Tom Tromey  <tom@tromey.com>
5366
5367         * tui/tui-win.c (tui_resize_all): Call
5368         tui_delete_invisible_windows.
5369         * tui/tui-layout.c (show_layout): Call
5370         tui_delete_invisible_windows.
5371         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5372         * tui/tui-data.c (tui_delete_invisible_windows): New function.
5373
5374 2019-08-13  Tom Tromey  <tom@tromey.com>
5375
5376         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
5377         tui_add_win_to_layout.
5378
5379 2019-08-13  Tom Tromey  <tom@tromey.com>
5380
5381         * tui/tui-layout.h (tui_default_win_height): Don't declare.
5382         * tui/tui-layout.c (tui_default_win_height): Now static.
5383
5384 2019-08-13  Tom Tromey  <tom@tromey.com>
5385
5386         * tui/tui-layout.c (show_layout): Unify all layout cases into a
5387         single switch.
5388         (show_source_disasm_command, show_source_or_disasm_and_command):
5389         Don't check current layout.
5390
5391 2019-08-13  Tom Tromey  <tom@tromey.com>
5392
5393         * tui/tui-wingeneral.c (make_all_visible): Remove.
5394         (tui_make_all_invisible): Simplify.
5395         * tui/tui-layout.c (tui_make_all_invisible): Move from
5396         tui-wingeneral.c; simplify.
5397         (show_layout): Hoist call to tui_make_all_invisible.
5398         (show_data): Don't call tui_make_all_invisible.
5399
5400 2019-08-13  Tom Tromey  <tom@tromey.com>
5401
5402         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5403         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5404
5405 2019-08-13  Tom Tromey  <tom@tromey.com>
5406
5407         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5408         tui-data.c.
5409         (show_source_disasm_command, show_data)
5410         (show_source_or_disasm_and_command): Don't use
5411         tui_set_current_layout_to.
5412         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5413         * tui/tui-data.c (current_layout, tui_current_layout): Move to
5414         tui-layout.c.
5415         (tui_set_current_layout_to): Remove.
5416
5417 2019-08-13  Tom Tromey  <tom@tromey.com>
5418
5419         * tui/tui-layout.c (tui_set_layout): Update.
5420         * tui/tui-data.h (struct tui_layout_def): Remove.
5421         (tui_layout_def): Don't declare.
5422         * tui/tui-data.c (layout_def): Remove.
5423         (tui_layout_def): Remove.
5424
5425 2019-08-13  Tom Tromey  <tom@tromey.com>
5426
5427         * tui/tui-winsource.h (struct tui_source_window_base)
5428         <clear_detail>: No longer "override".
5429         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5430         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5431         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5432         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5433         Remove.
5434         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5435
5436 2019-08-13  Tom Tromey  <tromey@adacore.com>
5437
5438         * tracepoint.c: Don't include readline.h or history.h.
5439
5440 2019-08-12  Tom Tromey  <tom@tromey.com>
5441
5442         * configure: Rebuild.
5443         * configure.ac: Check for readline 7.
5444         * NEWS: Mention readline 7 requirement.
5445         * README: Update.
5446
5447 2019-08-12  Tom Tromey  <tom@tromey.com>
5448
5449         * mingw-hdep.c (gdb_select): Remove readline hack.
5450
5451 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5452
5453         * blockframe.c (find_pc_partial_function): Set *block to nullptr
5454         when the function fails.
5455
5456 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
5457
5458         * s390-tdep.c (s390_type_align): New function.
5459         (s390_gdbarch_init): Set it as type_align gdbarch method.
5460
5461 2019-08-09  Tom de Vries  <tdevries@suse.de>
5462
5463         PR gdb/24591
5464         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5465         pc_low with relocation offset.
5466
5467 2019-08-07  Tom Tromey  <tromey@adacore.com>
5468
5469         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5470         (print_frame_args): Update.
5471         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5472         Update.
5473         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5474         * frame.h (struct frame_arg): Add initializers.
5475         <error>: Now a unique_xmalloc_ptr.
5476
5477 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
5478
5479         * NEWS: Expand the Pointer Authentication entry.
5480         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5481         (aarch64_frame_unmask_lr): ... to this.
5482         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5483         Call aarch64_frame_unmask_lr.
5484         * frame.c (struct frame_info): Add "masked" variable.
5485         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5486         (fprint_frame): Check for masked pc.
5487         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5488         declarations.
5489         * python/py-framefilter.c (py_print_frame): Check for masked pc.
5490         * stack.c (print_frame): Check for masked pc.
5491
5492 2019-08-06  Tom Tromey  <tom@tromey.com>
5493
5494         * stabsread.c (patch_block_stabs, read_one_struct_field)
5495         (read_enum_type): Use obstack_strndup.
5496         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5497         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5498         * dwarf2read.c (guess_full_die_structure_name)
5499         (anonymous_struct_prefix): Use obstack_strndup.
5500         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5501         * c-exp.y (yylex): Use obstack_strndup.
5502         * ada-exp.y (write_object_renaming, write_ambiguous_var)
5503         (write_var_or_type): Use obstack_strndup.
5504
5505 2019-08-06  Tom Tromey  <tom@tromey.com>
5506
5507         * symfile.c (reread_symbols): Use obstack_strdup.
5508         * stabsread.c (read_type): Use obstack_strdup.
5509         * gdb_obstack.h (obstack_strdup): New overload.
5510         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5511         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5512         (dwarf2_canonicalize_name): Use obstack_strdup.
5513         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5514         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5515         Use obstack_strdup.
5516
5517 2019-08-06  Tom Tromey  <tom@tromey.com>
5518
5519         * gdb_obstack.h (obstack_strdup): Define.
5520         * gdb_obstack.c (obstack_strdup): Don't define.
5521
5522 2019-08-06  Tom Tromey  <tom@tromey.com>
5523
5524         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5525         obstack_strdup.
5526         * typeprint.c (typedef_hash_table::find_global_typedef): Use
5527         obstack_strdup.
5528         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5529         * stabsread.c (common_block_start): Use obstack_strdup.
5530         * objfiles.c (set_objfile_main_name, objfile): Use
5531         obstack_strdup.
5532         * namespace.c (add_using_directive): Use obstack_strdup.
5533         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5534         * jit.c (finalize_symtab): Use obstack_strdup.
5535         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5536         (guess_partial_die_structure_name, partial_die_info::fixup)
5537         (dwarf2_name): Use obstack_strdup.
5538         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5539         obstack_strdup.
5540         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5541         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5542         obstack_strdup.
5543         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5544
5545 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5546
5547         * unittests/help-doc-selftests.c: New file.
5548         * Makefile.in: Add the new file.
5549
5550 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5551
5552         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5553         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
5554         the full first line, except when FOR_VALUE_PREFIX.  In this case,
5555         the trailing '.' is not output, and the first character is uppercased.
5556         (print_help_for_command): Update call to print_doc_line.
5557         (print_doc_of_command): Likewise.
5558         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5559         * cli/cli-option.c (append_indented_doc): Do not append newline.
5560         (build_help_option): Append newline after first appended_indented_doc
5561         only if a second call is done.
5562         (build_help): Append 2 new lines before each option, except the first
5563         one.
5564         * compile/compile.c (_initialize_compile): Add new lines after
5565         %OPTIONS%, when not at the end of the help.
5566         Change help doc or code
5567         producing the help doc to respect the invariants.
5568         * maint-test-options.c (_initialize_maint_test_options): Likewise.
5569         Also removed the new line after 'Options:', as all other commands
5570         do not put an empty line between 'Options:' and the first option.
5571         * printcmd.c (_initialize_printcmd): Likewise.
5572         * stack.c (_initialize_stack): Likewise.
5573         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5574         incorrectly telling COMMAND is optional.
5575         * ada-lang.c (_initialize_ada_language): Change help doc or code
5576         producing the help doc to respect the invariants.
5577         * ada-tasks.c (_initialize_ada_tasks): Likewise.
5578         * breakpoint.c (_initialize_breakpoint): Likewise.
5579         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5580         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5581         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5582         * cli/cli-style.c (cli_style_option::add_setshow_commands,
5583         _initialize_cli_style): Likewise.
5584         * corelow.c (core_target_info): Likewise.
5585         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5586         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5587         * filesystem.c (_initialize_filesystem): Likewise.
5588         * frame.c (_initialize_frame): Likewise.
5589         * gnu-nat.c (add_task_commands): Likewise.
5590         * infcall.c (_initialize_infcall): Likewise.
5591         * infcmd.c (_initialize_infcmd): Likewise.
5592         * interps.c (_initialize_interpreter): Likewise.
5593         * language.c (_initialize_language): Likewise.
5594         * linux-fork.c (_initialize_linux_fork): Likewise.
5595         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5596         * maint.c (_initialize_maint_cmds): Likewise.
5597         * memattr.c (_initialize_mem): Likewise.
5598         * printcmd.c (_initialize_printcmd): Likewise.
5599         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5600         _RegEx): Likewise.
5601         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5602         * record-btrace.c (_initialize_record_btrace): Likewise.
5603         * record-full.c (_initialize_record_full): Likewise.
5604         * record.c (_initialize_record): Likewise.
5605         * regcache-dump.c (_initialize_regcache_dump): Likewise.
5606         * regcache.c (_initialize_regcache): Likewise.
5607         * remote.c (add_packet_config_cmd, init_remote_threadtests,
5608         _initialize_remote): Likewise.
5609         * ser-tcp.c (_initialize_ser_tcp): Likewise.
5610         * serial.c (_initialize_serial): Likewise.
5611         * skip.c (_initialize_step_skip): Likewise.
5612         * source.c (_initialize_source): Likewise.
5613         * stack.c (_initialize_stack): Likewise.
5614         * symfile.c (_initialize_symfile): Likewise.
5615         * symtab.c (_initialize_symtab): Likewise.
5616         * target-descriptions.c (_initialize_target_descriptions): Likewise.
5617         * top.c (init_main): Likewise.
5618         * tracefile-tfile.c (tfile_target_info): Likewise.
5619         * tracepoint.c (_initialize_tracepoint): Likewise.
5620         * tui/tui-win.c (_initialize_tui_win): Likewise.
5621         * utils.c (add_internal_problem_command): Likewise.
5622         * valprint.c (value_print_option_defs): Likewise.
5623
5624 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
5625
5626         PR build/24886
5627         * configure.ac: Drop enable-libmcheck support.
5628         * configure, config.in: Rebuild.
5629         * libmcheck.m4: Remove.
5630         * acinclude.m4: Don't include it.
5631         * Makefile.in: Don't distribute it.
5632         * top.c (print_gdb_configuration): Don't mention it.
5633
5634 2019-08-06  Tom Tromey  <tom@tromey.com>
5635
5636         * utils.c (set_output_style): Sometimes pass stream to
5637         emit_style_escape.
5638         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5639         * record-btrace.c (btrace_insn_history): Update.
5640         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5641         method.
5642         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5643         Update initializers.
5644         <m_uiout>: New field.
5645         <m_di>: Move lower.
5646         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5647         Remove "uiout" parameter.
5648         (dump_insns): Update.
5649         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5650         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5651
5652 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
5653
5654         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5655         (error_in_psymtab_expansion): Likewise.
5656         (lookup_symbol_via_quick_fns): Likewise.
5657         (basic_lookup_transparent_type_quick): Likewise.
5658         (basic_lookup_transparent_type_1): Likewise.
5659
5660 2019-08-06  Tom Tromey  <tromey@adacore.com>
5661
5662         * source.c (last_source_error): Now bool.
5663         (print_source_lines_base): Make "noprint" bool.  Only open
5664         source file when last_source_visited changes.
5665
5666 2019-08-06  Tom Tromey  <tromey@adacore.com>
5667
5668         * annotate.c (annotate_source_line): Use g_source_cache.
5669         * source-cache.c (source_cache::get_plain_source_lines): Change
5670         parameters.  Populate m_offset_cache.
5671         (source_cache::ensure): New method.
5672         (source_cache::get_line_charpos): New method.
5673         (extract_lines): Move lower.  Change parameters.
5674         (source_cache::get_source_lines): Move lower.
5675         * source-cache.h (class source_cache): Update comment.
5676         <get_line_charpos>: New method.
5677         <get_source_lines>: Update comment.
5678         <clear>: Clear m_offset_cache.
5679         <get_plain_source_lines>: Change parameters.
5680         <ensure>: New method
5681         <m_offset_cache>: New member.
5682         * source.c (forget_cached_source_info_for_objfile): Update.
5683         (info_source_command): Use g_source_cache.
5684         (find_source_lines, open_source_file_with_line_charpos): Remove.
5685         (print_source_lines_base, search_command_helper): Use g_source_cache.
5686         * source.h (open_source_file_with_line_charpos): Don't declare.
5687         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5688         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5689         Use g_source_cache.
5690
5691 2019-08-06  Tom Tromey  <tromey@adacore.com>
5692
5693         * source-cache.c (source_cache::get_plain_source_lines):
5694         Remove "first_line" and "last_line" parameters.
5695         (source_cache::get_source_lines): Cache plain text.
5696         * source-cache.h (class source_cache)
5697         <get_plain_source_lines>: Update.
5698
5699 2019-08-06  Tom Tromey  <tromey@adacore.com>
5700
5701         * source-cache.c (extract_lines): No longer a method.
5702         Changed type of parameter.  Include final newline.
5703         (selftests::extract_lines_test): New function.
5704         (_initialize_source_cache): Likewise.
5705         * source-cache.h (class source_cache)
5706         <extract_lines>: Don't declare.
5707
5708 2019-08-06  Tom Tromey  <tromey@adacore.com>
5709
5710         * breakpoint.c (init_breakpoint_sal): Update.
5711         (breakpoint): Update.
5712         * breakpoint.h (struct breakpoint) <filter>: Now a
5713         unique_xmalloc_ptr.
5714
5715 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5716
5717         * NEWS: Mention dictionary access on blocks.
5718         * python/py-block.c (blpy_getitem): New function.
5719         (block_object_as_mapping): New struct.
5720         (block_object_type): Use new struct for tp_as_mapping field.
5721
5722 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5723
5724         * objfiles.h (objfile): Add a comment describing partial symbols.
5725
5726 2019-08-05  Tom Tromey  <tromey@adacore.com>
5727
5728         * compile/compile.c (_initialize_compile): Use _(), not N_().
5729         * thread.c (_initialize_thread): Use _(), not N_().
5730         * stack.c (_initialize_stack): Use _(), not N_().
5731         * printcmd.c (_initialize_printcmd): Use _(), not N_().
5732
5733 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
5734
5735         * dwarf2read.c (struct dw2_symtab_iterator):
5736         <want_specific_block>: Remove.
5737         <block_index>: Change type to gdb::optional.
5738         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5739         change type of BLOCK_INDEX parameter to gdb::optional.
5740         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5741         (dw2_lookup_symbol): Don't pass argument for
5742         WANT_SPECIFIC_BLOCK.
5743         (dw2_expand_symtabs_for_function): Don't pass argument for
5744         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5745         (class dw2_debug_names_iterator)
5746         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5747         parameter, change BLOCK_INDEX type to gdb::optional.
5748         <m_want_specific_block>: Remove.
5749         <m_block_index>: Change type to gdb::optional.
5750         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5751         gdb::optional.  Re-write in function of gdb::optional.
5752         (dw2_debug_names_lookup_symbol): Don't pass argument for
5753         WANT_SPECIFIC_BLOCK.
5754         (dw2_debug_names_expand_symtabs_for_function): Don't pass
5755         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5756         BLOCK_INDEX.
5757
5758 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5759
5760         * NEWS: Mention changes to "info sources" command.
5761
5762 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5763
5764         * symtab.c (filename_partial_match_opts): New struct type.
5765         (struct output_source_filename_data): New members
5766         regexp, c_regexp, partial_match.
5767         (output_source_filename): Use new members to decide to print file.
5768         (info_sources_option_defs): New variable.
5769         (make_info_sources_options_def_group, print_info_sources_header,
5770         info_sources_command_completer):
5771         New functions.
5772         (info_sources_command): Read new optional arguments.
5773         (_initialize_symtab): Update info sources help.
5774
5775 2019-08-02  Alexandre Oliva <oliva@adacore.com>
5776
5777         * ada-lang.c (exception_support_info_v0): Renamed from...
5778         (default_exception_support_info): ... this.  Create new
5779         definition for v1.
5780         (ada_has_this_exception_support): Look up catch_handlers_sym.
5781         (ada_exception_support_info_sniffer): Try v0 after default.
5782
5783 2019-08-01  Tom Tromey  <tromey@adacore.com>
5784
5785         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5786         gdbarch.h.
5787
5788 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
5789
5790         * s12z-tdep.c: Fix include path for s12z-opc.h.
5791
5792 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
5793
5794         * NEWS: Require GNU make 3.82.
5795
5796 2019-07-16  Tom Tromey  <tom@tromey.com>
5797
5798         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5799         declare.
5800
5801 2019-07-30  Tom Tromey  <tromey@adacore.com>
5802
5803         * block.c (contained_in): Remove BLOCK_FUNCTION check.
5804
5805 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
5806
5807         * printcmd.c (print_address_symbolic): Print negative offsets.
5808         (build_address_symbolic): Force signed arithmetic when computing
5809         offset.
5810
5811 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
5812
5813         PR/24474: Add a function to lookup static variables.
5814         * NEWS: Mention this new function.
5815         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5816         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5817         * python/python.c (python_GdbMethods): Add new function.
5818
5819 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
5820
5821         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5822         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5823         (objfpy_lookup_static_symbol): New function.
5824         (objfile_object_methods): Add new functions.
5825
5826 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5827
5828         * NEWS: Mention 'set|show print frame-info'.  Mention new
5829         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
5830         backtrace argument.  Mention that python frame filtering code
5831         is now consistent with what 'backtrace' command prints.
5832
5833 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5834
5835         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5836         comments.
5837         (print_frame_info_auto, print_frame_info_source_line,
5838         print_frame_info_location, print_frame_info_source_and_location,
5839         print_frame_info_location_and_address, print_frame_info_short_location):
5840         New declarations.
5841         (struct frame_print_options): New member print_frame_info.
5842         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5843         * stack.h (get_user_print_what_frame_info): New declaration.
5844         (frame_show_address): New declaration.
5845         * stack.c (print_frame_arguments_choices): New value 'presence'.
5846         (print_frame_info_auto, print_frame_info_source_line,
5847         print_frame_info_location, print_frame_info_source_and_location,
5848         print_frame_info_location_and_address, print_frame_info_short_location,
5849         print_frame_info_choices, print_frame_info_print_what): New definitions.
5850         (print_frame_args): Only print dots for args if print frame-arguments
5851         is 'presence'.
5852         (frame_print_option_defs): New element for "frame-info".
5853         (get_user_print_what_frame_info): New function.
5854         (frame_show_address): Make non static.  Move comment to stack.h.
5855         (print_frame_info_to_print_what): New function.
5856         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
5857         to decide what to print.
5858         (backtrace_command_1): Handle the new print_frame_arguments_presence
5859         value.
5860         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5861         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5862         (py_print_frame): In non-mi mode, use LOCATION as default for
5863         print_what, similarly to frame information printed directly by
5864         backtrace command. Handle frame-info user option in non MI mode.
5865
5866 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5867
5868         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5869         Add case for debugging 32-bit target on 64-bit host.  Revise
5870         comment.
5871
5872 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5873
5874         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5875         instead of find_function_entry_range_from_pc.
5876
5877 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5878
5879         * stack.c (find_frame_funname): Remove code which preferred
5880         minsym over symtab sym in "certain pathological cases".
5881
5882         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5883         parameter.  Change type of "do_demangle" to bool.
5884         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5885         Pass suitable "prefer_sym_over_minsym" flag to
5886         build_address_symbolic().  Don't output "+" for negative offsets.
5887         * printcmd.c (print_address_symbolic): Update invocation of
5888         build_address_symbolic to include a "prefer_sym_over_minsym"
5889         flag.
5890         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5891         Restrict cases in which use of minimal symbol is preferred to that
5892         of a found symbol.  Update comments.
5893
5894         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5895         for entry pc when entry pc is out of range for that FDE.
5896
5897 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
5898
5899         PR gdb/24839:
5900         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5901         type.
5902
5903 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
5904
5905         * python/py-objfile.c (add_separate_debug_file): Fix comment about
5906         this function's Python signature.
5907
5908
5909 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
5910
5911         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5912         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5913         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5914         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5915         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5916
5917
5918 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
5919
5920         * h8300-tdep.c (h8300_register_name_common): New.
5921         h8300_register_name): Use h8300_register_name_common.
5922         (h8300s_register_name): Likewise.
5923         (h8300sx_register_name): Likewise.
5924         (h8300h_register_nam): New.
5925         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
5926
5927
5928 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
5929
5930         * arm-tdep.c (arm_skip_cmse_entry): New function.
5931         (arm_is_sgstubs_section): New function.
5932         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
5933
5934 2019-07-22  Tom Tromey  <tom@tromey.com>
5935
5936         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
5937         Don't self-assign.
5938
5939 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5940
5941         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
5942         type_print.
5943
5944 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5945
5946         * symtab.c (search_symbols): Adjust msymbol matching type arrays
5947         so that GDB doesn't match any msymbols when searching in the
5948         TYPES_DOMAIN.
5949         (print_symbol_info): Print using typedef_print or type_print based
5950         on the type of the symbol.  Add updated FIXME comment moved from...
5951         (_initialize_symtab): ... move and update FIXME comment to above.
5952
5953 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5954
5955         * NEWS: Mention adding -q option to "info types".
5956         * symtab.c (struct info_types_options): New struct.
5957         (info_types_options_defs): New variable.
5958         (make_info_types_options_def_group): New function.
5959         (info_types_command): Use gdb::option framework to parse options.
5960         (info_types_command_completer): New function.
5961         (_initialize_symtab): Extend the help text on "info types" and
5962         register command completer.
5963
5964 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
5965
5966         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
5967         (lookup_symbol_in_objfile): Change int to block_enum and add a
5968         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
5969
5970 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
5971
5972         * MAINTAINERS (Write After Approval): Add self.
5973
5974 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5975
5976         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
5977         instruction to the dummy code region.
5978
5979 2019-07-19  Tom Tromey  <tromey@adacore.com>
5980
5981         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
5982         (ARGSUSED, PARAMS, __func__): Remove rules.
5983
5984 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5985
5986         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
5987         * features/arm/arm-with-iwmmxt.c: Remove.
5988         * features/arm/arm-with-iwmmxt.xml: Remove.
5989         * features/arm/arm-with-m-fpa-layout.c: Remove.
5990         * features/arm/arm-with-m-fpa-layout.xml: Remove.
5991         * features/arm/arm-with-m-vfp-d16.c: Remove.
5992         * features/arm/arm-with-m-vfp-d16.xml: Remove.
5993         * features/arm/arm-with-m.c: Remove.
5994         * features/arm/arm-with-m.xml: Remove.
5995         * features/arm/arm-with-neon.c: Remove.
5996         * features/arm/arm-with-neon.xml: Remove.
5997         * features/arm/arm-with-vfpv2.c: Remove.
5998         * features/arm/arm-with-vfpv2.xml: Remove.
5999         * features/arm/arm-with-vfpv3.c: Remove.
6000         * features/arm/arm-with-vfpv3.xml: Remove.
6001
6002 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6003
6004         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6005
6006 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6007
6008         * arch/aarch32.c (aarch32_create_target_description): Create
6009         target descriptions using features.
6010         * arch/arm.c (arm_create_target_description)
6011         (arm_create_mprofile_target_description): Likewise.
6012         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6013
6014 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6015
6016         * Makefile.in: Add new files.
6017         * aarch32-tdep.c: New file.
6018         * aarch32-tdep.h: New file.
6019         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6020         Call aarch32_read_description.
6021         * arch/aarch32.c: New file.
6022         * arch/aarch32.h: New file.
6023         * arch/arm.c (arm_create_target_description)
6024         (arm_create_mprofile_target_description): New function.
6025         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6026         (arm_create_target_description)
6027         (arm_create_mprofile_target_description): New declaration.
6028         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6029         read_description functions.
6030         * arm-linux-nat.c (arm_linux_nat_target::read_description):
6031         Likewise.
6032         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6033         * arm-tdep.c (tdesc_arm_list): New variable.
6034         (arm_register_g_packet_guesses): Call create description functions.
6035         (arm_read_description) (arm_read_mprofile_description): New
6036         function.
6037         * arm-tdep.h (arm_read_description)
6038         (arm_read_mprofile_description): Add declaration.
6039         * configure.tgt: Add new files.
6040
6041 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
6042
6043         * top.c (new_ui_command): Open specified terminal just once.
6044
6045 2019-07-18  Tom Tromey  <tromey@adacore.com>
6046
6047         * symtab.c (main_name): Constify return type.
6048         * symfile.c (set_initial_language): Update.
6049         * symtab.h (main_name): Constify return type.
6050
6051 2019-07-17  Tom Tromey  <tom@tromey.com>
6052
6053         * tui/tui-winsource.c (tui_update_source_window)
6054         (tui_update_source_window_as_is)
6055         (tui_update_source_windows_with_line): Remove return.
6056         * tui/tui-disasm.c (tui_show_disassem)
6057         (tui_show_disassem_and_update_source): Remove return.
6058         * tui/tui.c (tui_reset): Remove return.
6059         * tui/tui-wingeneral.c
6060         (tui_check_and_display_highlight_if_needed): Remove return.
6061
6062 2019-07-17  Tom Tromey  <tom@tromey.com>
6063
6064         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6065
6066 2019-07-17  Tom Tromey  <tom@tromey.com>
6067
6068         * tui/tui-winsource.h (struct tui_exec_info_window)
6069         (struct tui_source_window_base): Move from tui-data.h.
6070         * tui/tui-winsource.c: Move many method definitions from
6071         elsewhere.  Remove "structuring" comments.
6072         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6073         (tui_source_window_base::refresh_window): Move to
6074         tui-winsource.c.
6075         * tui/tui-win.c (tui_source_window_base::refresh_all)
6076         (tui_source_window_base::update_tab_width)
6077         (tui_source_window_base::set_new_height)
6078         (tui_source_window_base::do_make_visible_with_new_height): Move to
6079         tui-winsource.c.
6080         * tui/tui-source.h: Update.
6081         * tui/tui-source.c (tui_source_window_base::reset): Move to
6082         tui-winsource.c.
6083         * tui/tui-disasm.h: Update.
6084         * tui/tui-data.h (struct tui_exec_info_window): Move to
6085         tui-winsource.h.
6086         (struct tui_source_window_base): Likewise.
6087         * tui/tui-data.c (tui_source_window_base::clear_detail)
6088         (tui_source_window_base, ~tui_source_window_base): Move to
6089         tui-winsource.c.
6090
6091 2019-07-17  Tom Tromey  <tom@tromey.com>
6092
6093         * tui/tui-win.c (tui_resize_all)
6094         (tui_source_window_base::update_tab_width)
6095         (tui_adjust_win_heights): Update.
6096         (tui_win_info::make_invisible_and_set_new_height): Rename from
6097         make_invisible_and_set_new_height.
6098         * tui/tui-data.h (struct tui_win_info)
6099         <make_invisible_and_set_new_height>: New method.
6100
6101 2019-07-17  Tom Tromey  <tom@tromey.com>
6102
6103         * tui/tui.c: Update.
6104         * tui/tui-source.h (struct tui_source_window): Move from
6105         tui-data.h.
6106         * tui/tui-layout.c: Update.
6107         * tui/tui-disasm.c: Update.
6108         * tui/tui-data.h (struct tui_source_window): Move to
6109         tui-source.h.
6110
6111 2019-07-17  Tom Tromey  <tom@tromey.com>
6112
6113         * tui/tui-disasm.h (struct tui_disasm_window): Move from
6114         tui-data.h.
6115         * tui/tui-data.h (struct tui_disasm_window): Move to
6116         tui-disasm.h.
6117
6118 2019-07-17  Tom Tromey  <tom@tromey.com>
6119
6120         * tui/tui-regs.h (struct tui_data_item_window): Move from
6121         tui-data.h.
6122         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6123         * tui/tui-data.h (struct tui_data_item_window): Move to
6124         tui-regs.h.
6125         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6126
6127 2019-07-17  Tom Tromey  <tom@tromey.com>
6128
6129         * tui/tui.c: Update.
6130         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6131         (tui_cmd_window::max_height): Move to tui-command.c.
6132         * tui/tui-layout.c: Update.
6133         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6134         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6135         tui-command.c.
6136         * tui/tui-command.h (struct tui_cmd_window): Move from
6137         tui-data.h.
6138         * tui/tui-command.c: Remove "structuring" comments.
6139         (tui_cmd_window::clear_detail)
6140         (tui_cmd_window::do_make_visible_with_new_height)
6141         (tui_cmd_window::max_height): Move from elsewhere.
6142
6143 2019-07-17  Tom Tromey  <tom@tromey.com>
6144
6145         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6146         Now static.
6147         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6148         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6149
6150 2019-07-17  Tom Tromey  <tom@tromey.com>
6151
6152         * tui/tui.c: Update.
6153         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6154         tui-regs.c.
6155         * tui/tui-windata.h: Remove file.
6156         * tui/tui-windata.c: Remove file.
6157         * tui/tui-win.c (tui_data_window::set_new_height)
6158         (tui_data_window::do_make_visible_with_new_height): Move to
6159         tui-regs.c.
6160         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6161         * tui/tui-regs.c: Remove "structuring" comments.
6162         (tui_data_window::first_data_item_displayed)
6163         (tui_data_window::delete_data_content_windows)
6164         (tui_data_window::erase_data_content)
6165         (tui_data_window::display_all_data)
6166         (tui_data_window::refresh_all)
6167         (tui_data_window::do_scroll_vertical)
6168         (tui_data_window::clear_detail, tui_data_window::set_new_height)
6169         (tui_data_window::do_make_visible_with_new_height)
6170         (tui_data_window::refresh_window): Move from elsewhere.
6171         (_initialize_tui_regs): Move to end of file.
6172         * tui/tui-layout.c: Update.
6173         * tui/tui-hooks.c: Update.
6174         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6175         * tui/tui-data.c (tui_data_window::clear_detail): Move to
6176         tui-regs.c.
6177         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6178
6179 2019-07-17  Tom Tromey  <tom@tromey.com>
6180
6181         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6182         seen.
6183
6184 2019-07-17  Tom Tromey  <tom@tromey.com>
6185
6186         * tui/tui-win.c (tui_source_window_base::set_new_height)
6187         (tui_source_window_base::do_make_visible_with_new_height): Use
6188         m_has_locator field directly.
6189         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6190         method.
6191         (struct tui_source_window_base) <has_locator>: Likewise.
6192
6193 2019-07-17  Tom Tromey  <tom@tromey.com>
6194
6195         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6196         Don't declare.
6197         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6198         Remove.
6199         * tui/tui-win.c (tui_source_window_base::set_new_height)
6200         (tui_source_window_base::set_new_height)
6201         (make_invisible_and_set_new_height)
6202         (tui_source_window_base::do_make_visible_with_new_height)
6203         (tui_source_window_base::do_make_visible_with_new_height):
6204         Update.
6205         * tui/tui-layout.c (show_source_disasm_command, show_data)
6206         (show_source_or_disasm_and_command): Update.
6207         * tui/tui-layout.c (show_layout): Update.
6208
6209 2019-07-17  Tom Tromey  <tom@tromey.com>
6210
6211         * tui/tui-layout.c (make_data_window): Remove.
6212         (show_data): Unify creation and re-initialization cases.
6213
6214 2019-07-17  Tom Tromey  <tom@tromey.com>
6215
6216         * tui/tui-layout.c (make_source_window, make_disasm_window):
6217         Remove.
6218         (show_data): Unify creation and re-initialization cases.
6219
6220 2019-07-17  Tom Tromey  <tom@tromey.com>
6221
6222         * tui/tui-layout.c (make_command_window): Remove.
6223         (show_source_disasm_command, show_source_or_disasm_and_command):
6224         Unify creation and re-initialization cases.
6225
6226 2019-07-17  Tom Tromey  <tom@tromey.com>
6227
6228         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6229         creation and re-initialization cases.
6230
6231 2019-07-17  Tom Tromey  <tom@tromey.com>
6232
6233         * tui/tui-regs.c (tui_get_register): Return void.
6234
6235 2019-07-17  Tom Tromey  <tom@tromey.com>
6236
6237         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6238         Simplify.
6239
6240 2019-07-17  Tom Tromey  <tom@tromey.com>
6241
6242         * tui/tui-layout.c (show_source_disasm_command): Simplify window
6243         resetting.
6244
6245 2019-07-17  Tom Tromey  <tom@tromey.com>
6246
6247         * tui/tui.h (tui_set_layout_by_name): Don't declare.
6248         * tui/tui-regs.c (tui_reg_layout): New function.
6249         (tui_show_registers, tui_reg_command): Use it.
6250         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6251         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
6252         parameters.
6253         (tui_layout_command): Remove.
6254
6255 2019-07-17  Tom Tromey  <tom@tromey.com>
6256
6257         * tui/tui-layout.h (tui/tui-layout): Return void.
6258         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
6259
6260 2019-07-17  Tom Tromey  <tom@tromey.com>
6261
6262         * tui/tui-layout.c (show_source_disasm_command, show_data):
6263         Update.
6264         (reset_locator): Remove.
6265         (show_source_or_disasm_and_command): Update.
6266
6267 2019-07-17  Tom Tromey  <tom@tromey.com>
6268
6269         * tui/tui-source.c (tui_source_window_base::reset): Remove
6270         win_type parameter.
6271         * tui/tui-layout.c (make_command_window, make_source_window)
6272         (make_disasm_window, make_data_window)
6273         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6274         (reset_locator, show_source_or_disasm_and_command): Update.
6275         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6276         win_type parameter.
6277         (struct tui_source_window_base) <reset>: Likewise.
6278
6279 2019-07-17  Tom Tromey  <tom@tromey.com>
6280
6281         * tui/tui-layout.c (show_source_disasm_command): Use
6282         reset_locator.
6283         (reset_locator): New function.
6284         (init_and_make_win): Remove.
6285         (show_source_or_disasm_and_command): Use reset_locator.
6286
6287 2019-07-17  Tom Tromey  <tom@tromey.com>
6288
6289         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6290         condition.
6291         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6292         Remove condition.
6293         * tui/tui-source.c (tui_source_window_base::reset): New method.
6294         * tui/tui-layout.c (make_command_window): Don't call
6295         init_and_make_win.
6296         (make_source_window, make_disasm_window): Don't call
6297         make_source_or_disasm_window.
6298         (make_data_window): Don't call init_and_make_win.  Change calling
6299         convention.
6300         (show_source_disasm_command, show_data): Simplify.
6301         (make_source_or_disasm_window): Remove.
6302         (show_source_or_disasm_and_command): Simplify.
6303         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6304         (struct tui_source_window_base) <reset>: Likewise.
6305         <execution_info>: Remove initializer.
6306         * tui/tui-data.c (tui_source_window_base): Initialize
6307         execution_info.
6308
6309 2019-07-17  Tom Tromey  <tom@tromey.com>
6310
6311         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6312         variable.
6313
6314 2019-07-17  Tom Tromey  <tom@tromey.com>
6315
6316         * tui/tui.c (tui_rl_other_window): Update.
6317         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6318         superclass method first.  Always iterate over regs_content.
6319         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6320         method.
6321         * tui/tui-win.c (tui_set_focus_command): Update.
6322
6323 2019-07-17  Tom Tromey  <tom@tromey.com>
6324
6325         * tui/tui-win.c (tui_set_focus_command): Rename from
6326         tui_set_focus.  Call tui_enable.
6327         (tui_set_focus_command): Remove.
6328
6329 2019-07-17  Tom Tromey  <tom@tromey.com>
6330
6331         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6332         refresh_window.
6333         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6334         touchwin.
6335         (tui_data_window::refresh_window): Call refresh_window on data
6336         items.  Always call superclass refresh_window.
6337         (tui_win_info::refresh): Remove.
6338         (tui_source_window_base::refresh_window): Update.
6339         (tui_refresh_all): Update.
6340         * tui/tui-layout.c (show_source_disasm_command): Remove call to
6341         refresh_window.
6342         (show_source_or_disasm_and_command): Likewise.
6343         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6344         (struct tui_source_window_base) <refresh>: Likewise.
6345
6346 2019-07-17  Tom Tromey  <tom@tromey.com>
6347
6348         * tui/tui-winsource.c (tui_clear_source_content)
6349         (tui_show_source_content): Update.
6350         * tui/tui-source.c (tui_source_window::showing_source_p): Check
6351         whether content is empty.
6352         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6353         Remove.
6354
6355 2019-07-17  Tom Tromey  <tom@tromey.com>
6356
6357         * tui/tui-winsource.c (tui_erase_source_content): Clear the
6358         window's contents.
6359         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6360         * tui/tui-source.c (tui_set_source_content_nil): Remove.
6361
6362 2019-07-17  Tom Tromey  <tom@tromey.com>
6363
6364         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6365         (struct tui_data_item_window): Update.
6366
6367 2019-07-17  Tom Tromey  <tom@tromey.com>
6368
6369         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6370         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6371         defines.
6372
6373 2019-07-17  Tom Tromey  <tom@tromey.com>
6374
6375         * tui/tui-winsource.h (tui_erase_source_content)
6376         (tui_clear_source_content): Remove "display_prompt" parameter.
6377         * tui/tui-winsource.c (tui_update_source_window_as_is)
6378         (tui_update_source_windows_with_addr): Update.
6379         (tui_clear_source_content): Remove "display_prompt" parameter.
6380         (tui_erase_source_content): Likewise.  Simplify.
6381         (tui_show_source_content): Update.
6382         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6383         * tui/tui-stack.c (tui_show_frame_info): Update.
6384         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6385         Remove defines.
6386
6387 2019-07-17  Tom Tromey  <tom@tromey.com>
6388
6389         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6390         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6391         parameter.
6392         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6393         parameter.
6394
6395 2019-07-17  Tom Tromey  <tom@tromey.com>
6396
6397         * tui/tui-winsource.c (tui_clear_source_content)
6398         (tui_show_source_content, tui_show_exec_info_content)
6399         (tui_clear_exec_info_content): Update.
6400         * tui/tui-stack.c (tui_show_locator_content): Update.
6401         (tui_show_frame_info): Update.
6402         * tui/tui-source.h (tui_source_window): Don't declare.
6403         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6404         from tui_source_is_displayed.
6405         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6406         Remove field.
6407         (struct tui_source_window_base) <content_in_use>: New field.  Now
6408         bool.
6409         (struct tui_source_window) <showing_source_p>: New method.
6410         (TUI_SRC_WIN): Change cast.
6411         * tui/tui-data.c (tui_initialize_static_data): Update.
6412
6413 2019-07-17  Tom Tromey  <tom@tromey.com>
6414
6415         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6416         location_matches_p.
6417         * tui/tui-source.c (tui_source_window::location_matches_p): New
6418         method.
6419         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6420         method.
6421         * tui/tui-data.h (struct tui_source_window_base)
6422         <location_matches_p>: New method.
6423         (struct tui_source_window, struct tui_disasm_window)
6424         <location_matches_p>: Likewise.
6425
6426 2019-07-17  Tom Tromey  <tom@tromey.com>
6427
6428         * tui/tui-win.c (tui_set_win_height_command): Rename from
6429         tui_set_win_height.
6430         (tui_set_win_height_command): Remove.
6431
6432 2019-07-17  Tom Tromey  <tom@tromey.com>
6433
6434         * tui/tui-source.c (tui_source_window): New constructor.  Add
6435         observer.
6436         (~tui_source_window): New destructor.
6437         (tui_source_window::style_changed): New method.
6438         * tui/tui-hooks.c (tui_redisplay_source): Remove.
6439         (tui_attach_detach_observers): Update.
6440         * tui/tui-data.h (struct tui_source_window): Make constructor not
6441         inline.  Add destructor.
6442         (struct tui_source_window) <style_changed>: New method.
6443         <m_observable>: New member.
6444
6445 2019-07-17  Tom Tromey  <tom@tromey.com>
6446
6447         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6448         * tui/tui-win.c (tui_resize_all): Fix typo.
6449
6450 2019-07-17  Tom Tromey  <tom@tromey.com>
6451
6452         * tui/tui-wingeneral.h (tui_refresh_all): Update.
6453         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6454         (tui_refresh_all): Remove "list" parameter.  Use foreach.
6455         * tui/tui-win.c (window_name_completer): Use foreach.
6456         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6457         (update_tab_width): Likewise.
6458         * tui/tui-layout.c (show_layout): Update.
6459         * tui/tui-data.h (class tui_window_iterator): New.
6460         (struct all_tui_windows): New.
6461         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6462
6463 2019-07-17  Tom Tromey  <tom@tromey.com>
6464
6465         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6466         parameter.  Don't reference globals.
6467         (tui_reg_command): Update.
6468
6469 2019-07-17  Tom Tromey  <tom@tromey.com>
6470
6471         * tui/tui-regs.c (tui_show_registers): Simplify.
6472
6473 2019-07-17  Tom Tromey  <tom@tromey.com>
6474
6475         * tui/tui-regs.c (tui_show_registers): Update.
6476         (tui_show_register_group): Add win_info parameter.
6477
6478 2019-07-17  Tom Tromey  <tom@tromey.com>
6479
6480         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6481         Rename from tui_display_reg_element_at_line.
6482         (tui_data_window::display_registers_from_line): Update.
6483         * tui/tui-data.h (struct tui_data_window)
6484         <display_reg_element_at_line>: New method.
6485
6486 2019-07-17  Tom Tromey  <tom@tromey.com>
6487
6488         * tui/tui-regs.h (tui_display_registers_from)
6489         (tui_display_registers_from_line): Don't declare.
6490         * tui/tui-windata.c (tui_data_window::display_all_data)
6491         (tui_data_window::refresh_all)
6492         (tui_data_window::do_scroll_vertical): Update.
6493         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6494         from tui_display_registers_from.
6495         (tui_display_reg_element_at_line): Update.
6496         (tui_data_window::display_registers_from_line): Rename from
6497         tui_display_registers_from_line.
6498         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6499         display_registers_from_line>: New methods.
6500
6501 2019-07-17  Tom Tromey  <tom@tromey.com>
6502
6503         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6504         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6505         from tui_erase_data_content.
6506         (tui_data_window::display_all_data)
6507         (tui_data_window::refresh_all)
6508         (tui_data_window::do_scroll_vertical): Update.
6509         * tui/tui-regs.c (tui_show_registers): Update.
6510         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6511         New method.
6512
6513 2019-07-17  Tom Tromey  <tom@tromey.com>
6514
6515         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6516         declare.
6517         * tui/tui-windata.c
6518         (tui_data_window::delete_data_content_windows): Rename from
6519         tui_delete_data_content_windows.
6520         (tui_data_window::display_all_data)
6521         (tui_data_window::do_scroll_vertical): Update.
6522         * tui/tui-data.h (struct tui_data_window)
6523         <delete_data_content_windows>: New method.
6524
6525 2019-07-17  Tom Tromey  <tom@tromey.com>
6526
6527         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6528         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6529
6530 2019-07-17  Tom Tromey  <tom@tromey.com>
6531
6532         * tui/tui-windata.h (tui_display_all_data): Don't declare.
6533         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6534         from tui_display_all_data.
6535         * tui/tui-win.c
6536         (tui_data_window::do_make_visible_with_new_height): Update.
6537         * tui/tui-regs.c (tui_show_registers): Update.
6538         * tui/tui-layout.c (tui_set_layout): Update.
6539         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6540         method.
6541
6542 2019-07-17  Tom Tromey  <tom@tromey.com>
6543
6544         * tui/tui-windata.h (tui_display_data_from): Don't declare.
6545         * tui/tui-windata.c (tui_display_data_from): Remove.
6546         (tui_data_window::refresh_all): Update.
6547
6548 2019-07-17  Tom Tromey  <tom@tromey.com>
6549
6550         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6551         * tui/tui-windata.c (tui_display_data_from_line): Remove.
6552         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6553         tui_display_registers_from_line.
6554         * tui/tui-regs.h (tui_display_registers_from_line): Update.
6555         * tui/tui-regs.c (tui_display_registers_from_line): Remove
6556         "force_display" parameter.
6557
6558 2019-07-17  Tom Tromey  <tom@tromey.com>
6559
6560         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6561         declare.
6562         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6563         Rename from tui_first_reg_element_no_inline.
6564         (tui_display_reg_element_at_line)
6565         (tui_display_registers_from_line): Update.
6566         * tui/tui-data.h (struct tui_data_window)
6567         <first_reg_element_no_inline>: New method.
6568
6569 2019-07-17  Tom Tromey  <tom@tromey.com>
6570
6571         * tui/tui-windata.c (tui_display_data_from)
6572         (tui_data_window::do_scroll_vertical): Update.
6573         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6574         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6575         Rename from tui_line_from_reg_element_no.
6576         (tui_display_registers_from_line): Update.
6577         * tui/tui-data.h (struct tui_data_window)
6578         <line_from_reg_element_no>: New method.
6579
6580 2019-07-17  Tom Tromey  <tom@tromey.com>
6581
6582         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6583         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6584         tui_last_regs_line_no.
6585         (tui_display_reg_element_at_line)
6586         (tui_display_registers_from_line): Update.
6587         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6588         method.
6589
6590 2019-07-17  Tom Tromey  <tom@tromey.com>
6591
6592         PR tui/24722:
6593         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6594         (tui_update_breakpoint_info): Add "being_deleted" parameter.
6595         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6596         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6597         (tui_update_breakpoint_info): Likewise.
6598         * tui/tui-hooks.c (tui_event_create_breakpoint)
6599         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6600         Update.
6601
6602 2019-07-17  Tom Tromey  <tom@tromey.com>
6603
6604         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6605
6606 2019-07-17  Tom Tromey  <tom@tromey.com>
6607
6608         * tui/tui-winsource.c (tui_update_source_window_as_is)
6609         (tui_update_source_windows_with_addr): Update.
6610         * tui/tui-source.h (tui_set_source_content)
6611         (tui_show_symtab_source): Add "win_info" parameter.
6612         * tui/tui-source.c (tui_set_source_content): Add "win_info"
6613         parameter.
6614         (tui_show_symtab_source): Likewise.
6615
6616 2019-07-17  Tom Tromey  <tom@tromey.com>
6617
6618         * tui/tui-wingeneral.c
6619         (tui_check_and_display_highlight_if_needed): Check can_highlight.
6620
6621 2019-07-17  Tom Tromey  <tom@tromey.com>
6622
6623         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6624         (struct tui_cmd_window) <can_scroll>: New method.
6625         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6626         method.
6627
6628 2019-07-17  Tom Tromey  <tromey@adacore.com>
6629
6630         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6631         do_field_signed>: Rename.  Change type of "value".
6632         * ui-out.c (ui_out::field_signed): Rename from field_int.
6633         Change type of "value".
6634         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
6635         type of "value".
6636         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6637         do_field_int.  Change type of "value".
6638         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6639         do_field_int.  Change type of "value".
6640         * tracepoint.c (trace_status_mi, tfind_1)
6641         (print_one_static_tracepoint_marker): Update.
6642         * thread.c (print_thread_info_1, print_selected_thread_frame):
6643         Update.
6644         * stack.c (print_frame, print_frame_info): Update.
6645         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6646         Update.
6647         * source.c (print_source_lines_base): Update.
6648         * skip.c (info_skip_command): Update.
6649         * record-btrace.c (btrace_ui_out_decode_error)
6650         (btrace_call_history_src_line): Update.
6651         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6652         Update.
6653         * progspace.c (print_program_space): Update.
6654         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6655         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6656         do_field_int.  Change type of "value".
6657         * mi/mi-out.c (mi_ui_out::do_table_begin)
6658         (mi_ui_out::do_table_header): Update.
6659         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
6660         type of "value".
6661         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6662         (mi_cmd_data_list_changed_registers, output_register)
6663         (mi_cmd_data_read_memory, mi_load_progress)
6664         (mi_cmd_trace_frame_collected): Update.
6665         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6666         Update.
6667         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6668         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6669         (mi_cmd_var_list_children, varobj_update_one): Update.
6670         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6671         (mi_cmd_stack_list_args, list_arg_or_local): Update.
6672         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6673         * inferior.c (print_inferior): Update.
6674         * gdb_bfd.c (print_one_bfd): Update.
6675         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6676         Update.
6677         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6678         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6679         do_field_int.  Change type of "value".
6680         * cli-out.c (cli_ui_out::do_field_signed): Rename from
6681         do_field_int.  Change type of "value".
6682         * breakpoint.c (watchpoint_check, print_breakpoint_location)
6683         (print_one_breakpoint_location, print_it_catch_fork)
6684         (print_one_catch_fork, print_it_catch_vfork)
6685         (print_one_catch_vfork, print_it_catch_solib)
6686         (print_it_catch_exec, print_it_ranged_breakpoint)
6687         (print_mention_watchpoint, print_mention_masked_watchpoint)
6688         (bkpt_print_it, update_static_tracepoint): Update.
6689         * break-catch-throw.c (print_it_exception_catchpoint): Update.
6690         * break-catch-syscall.c (print_it_catch_syscall): Update.
6691         * ada-tasks.c (print_ada_task_info): Update.
6692         * ada-lang.c (print_it_exception, print_mention_exception):
6693         Update.
6694
6695 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
6696
6697         PR breakpoints/24541
6698         * gdbarch.c: Regenerate.
6699         * gdbarch.h: Regenerate.
6700         * gdbarch.sh: Adjust return type and parameter types for
6701         'stap_adjust_register'.
6702         (i386_stap_adjust_register): Adjust signature and return new
6703         register name.
6704         * stap-probe.c (stap_parse_register_operand): Adjust use of
6705         'gdbarch_stap_adjust_register'.
6706
6707 2019-07-17  Tom Tromey  <tromey@adacore.com>
6708
6709         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
6710         declare VEC.
6711         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6712         std::vector.
6713         (struct s390_process_info): Add initializers.
6714         (s390_add_process): Use new.
6715         (s390_linux_nat_target::low_forget_process): Use delete.
6716         (s390_linux_nat_target::low_new_fork)
6717         (s390_linux_nat_target::stopped_by_watchpoint)
6718         (s390_linux_nat_target::low_prepare_to_resume)
6719         (s390_linux_nat_target::insert_watchpoint)
6720         (s390_linux_nat_target::insert_hw_breakpoint)
6721         (s390_linux_nat_target::remove_watchpoint)
6722         (s390_linux_nat_target::remove_hw_breakpoint): Update.
6723
6724 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6725
6726         * aarch64-fbsd-nat.c: Include regcache.h.
6727         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6728         argument.
6729         (aarch64_fbsd_nat_target::fetch_registers)
6730         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6731         variable.
6732         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6733
6734 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6735
6736         * fbsd-nat.c: Include gdbarch.h.
6737
6738 2019-07-15  Tom Tromey  <tromey@adacore.com>
6739
6740         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6741
6742 2019-07-15  Tom Tromey  <tromey@adacore.com>
6743
6744         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6745         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6746         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6747         * cli-out.c (cli_ui_out::do_field_int): New method.
6748         * ui-out.c (ui_out::field_unsigned): New method.
6749         * symfile.c (generic_load): Use field_unsigned.
6750         (print_transfer_performance): Likewise.
6751         * record-btrace.c (ui_out_field_uint): Remove.
6752         (btrace_call_history_insn_range, btrace_call_history): Use
6753         field_unsigned.
6754         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6755         field_unsigned.
6756         * ui-out.h (class ui_out) <field_unsigned>: New method.
6757         <do_field_unsigned>: Likewise.
6758
6759 2019-07-15  Tom Tromey  <tromey@adacore.com>
6760
6761         * mi/mi-main.c (list_available_thread_groups): Use field_string.
6762         * mi/mi-interp.c (mi_memory_changed): Use field_string.
6763         * target.c (flash_erase_command): Use field_string.
6764         * infrun.c (print_signal_received_reason): Use field_string.
6765         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6766         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6767         field_string.
6768         * ada-tasks.c (print_ada_task_info): Use field_string.
6769
6770 2019-07-15  Tom Tromey  <tromey@adacore.com>
6771
6772         * target.c (flash_erase_command): Use field_core_addr.
6773         * symfile.c (generic_load): Use field_core_addr.
6774         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6775         Use field_core_addr.
6776         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6777         field_core_addr.
6778
6779 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6780
6781         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6782         value if its desired type is smaller than a CORE_ADDR and signed.
6783
6784 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6785
6786         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6787         of changes to field names, and use new is_reference field to
6788         decide if a property is a reference or not.
6789         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6790         field.
6791         (struct dwarf2_property_baton): Update header comment, rename
6792         'referenced_type' to 'property_type' and update comments.
6793         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6794         default property type, store in property baton, update to take
6795         accound of renamed field.
6796         (read_func_scope): Update call to attr_to_dynamic_prop.
6797         (read_array_type): Likewise.
6798         (dwarf2_per_cu_addr_sized_int_type): New function.
6799         (read_subrange_index_type): Move type finding code to
6800         dwarf2_per_cu_addr_sized_int_type.
6801         (read_subrange_type): Update calls to attr_to_dynamic_prop.
6802         (dwarf2_per_cu_addr_type): New function.
6803         (set_die_type): Update calls to attr_to_dynamic_prop.
6804
6805 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6806
6807         * dwarf2read.c (read_subrange_index_type): New function.
6808         (read_subrange_type): Move code into new function and call it.
6809         * gdbtypes.c (create_range_type): Add some asserts.
6810
6811 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6812
6813         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6814         update return statements.
6815         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6816         declaration, and update comment to match.
6817         * gdbtypes.c (resolve_dynamic_array): Update call to
6818         dwarf2_evaluate_property to match new return type.
6819
6820 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6821
6822         * valarith.c (value_subscripted_rvalue): Change lowerbound
6823         parameter type from int to LONGEST.
6824         * value.h (value_subscripted_rvalue): Likewise in declaration.
6825
6826 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6827
6828         * cli/cli-utils.c (info_print_command_completer): New function.
6829         * cli/cli-utils.h: Add 'completer.h' include, and forward
6830         declaration for 'struct cmd_list_element'.
6831         (info_print_command_completer): Declare.
6832         * stack.c (_initialize_stack): Add completer for 'info locals' and
6833         'info args'.
6834         * symtab.c (_initialize_symtab): Add completer for 'info
6835         variables' and 'info functions'.
6836         * NEWS: Mention completion for additional info commands.
6837
6838 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6839
6840         * cli/cli-utils.c (extract_info_print_args): Delete.
6841         (extract_arg_maybe_quoted): Delete.
6842         (info_print_options_defs): New variable.
6843         (make_info_print_options_def_group): New function.
6844         (extract_info_print_options): Define new function.
6845         * cli/cli-utils.h (extract_info_print_args): Delete.
6846         (struct info_print_options): New structure.
6847         (extract_info_print_options): Declare new function.
6848         * stack.c (info_locals_command): Update to use new
6849         extract_info_print_options, also add a header comment.
6850         (info_args_command): Likewise.
6851         * symtab.c (info_variables_command): Likewise.
6852         (info_functions_command): Likewise.
6853
6854 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6855
6856         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6857         to extract string arguments.
6858         * common/common-utils.c (extract_string_maybe_quoted): New function.
6859         * common/common-utils.h (extract_string_maybe_quoted): Declare.
6860
6861 2019-07-11  Tom Tromey  <tromey@adacore.com>
6862
6863         * main.c (get_init_files): Use GDBINIT, not gdbinit.
6864         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6865         * top.h (gdbinit): Don't declare.
6866         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6867         into...
6868         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
6869         * top.c (gdb_init): Don't call init_cli_cmds.
6870         (gdbinit): Remove.
6871         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6872
6873 2019-07-11  Tom Tromey  <tromey@adacore.com>
6874
6875         * python/py-inferior.c (add_thread_object): Don't use thread_obj
6876         after it has been moved.
6877
6878 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6879
6880         * valops.c (value_must_coerce_to_target): Change return type to
6881         bool.
6882         * value.h (value_must_coerce_to_target): Likewise.
6883
6884 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
6885
6886         * breakpoint.c (is_hardware_watchpoint): Remove
6887         forward-declaration.
6888         (is_masked_watchpoint): Change return type to bool.
6889         (is_tracepoint): Likewise.
6890         (is_breakpoint): Likewise.
6891         (is_hardware_watchpoint): Likewise.
6892         (is_watchpoint): Likewise.
6893         (is_no_memory_software_watchpoint): Likewise.
6894         (is_catchpoint): Likewise.
6895         (breakpoint_1): Make FILTER parameter's return type bool.
6896         is_masked_watchpoint): Change return type to bool.
6897         (save_breakpoints): Make FILTER parameter's return type bool.
6898         * breakpoint.h (is_breakpoint): Change return type to bool.
6899         (is_watchpoint): Likewise.
6900         (is_catchpoint): Likewise.
6901         (is_tracepoint): Likewise.
6902
6903 2019-07-10  Tom Tromey  <tom@tromey.com>
6904
6905         * defs.h: Don't include gdbarch.h.
6906         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6907         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6908         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6909         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6910         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6911         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6912         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6913         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6914         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6915         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6916         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6917         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6918         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6919         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6920         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6921         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6922         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6923         record-btrace.c, record.h, regcache-dump.c, regcache.h,
6924         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6925         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
6926         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
6927         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
6928         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
6929         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
6930         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
6931         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
6932         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
6933
6934 2019-07-10  Tom Tromey  <tromey@adacore.com>
6935
6936         * ada-lang.h (is_ada_exception_catchpoint): Declare.
6937         * breakpoint.c (init_ada_exception_breakpoint): Register as
6938         bp_catchpoint.
6939         (print_one_breakpoint_location, print_one_breakpoint): Use
6940         is_ada_exception_catchpoint.
6941         * ada-lang.c (class ada_catchpoint_location): Pass
6942         bp_loc_software_breakpoint to bp_location constructor.
6943         (is_ada_exception_catchpoint): New function.
6944
6945 2019-07-10  Tom Tromey  <tromey@adacore.com>
6946
6947         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
6948         VEC.
6949         (struct arm_exidx_entry): New method operator<.
6950         (struct arm_exidx_data) <section_maps>: Change type.
6951         (arm_exidx_data_free): Remove.
6952         (arm_exidx_data_key): Change type.  Move lower.
6953         (arm_exidx_new_objfile): Update.
6954         (arm_compare_exidx_entries): Remove.
6955         (arm_find_exidx_entry, _initialize_arm_tdep)
6956
6957 2019-07-10  Tom Tromey  <tromey@adacore.com>
6958
6959         * solib-spu.c (ocl_program_data_key): Change type.
6960         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
6961         Update.
6962
6963 2019-07-10  Tom Tromey  <tromey@adacore.com>
6964
6965         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
6966         (struct solib_aix_inferior_data) <library_list>: Change type.
6967         (solib_aix_inferior_data_handle): Change type.
6968         (get_solib_aix_inferior_data): Update.
6969         (solib_aix_free_library_list): Remove.
6970         (library_list_start_library): Update.
6971         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
6972         return type.
6973         (solib_aix_get_library_list)
6974         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
6975         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
6976
6977 2019-07-10  Tom Tromey  <tromey@adacore.com>
6978
6979         * solib-dsbt.c (struct dsbt_info): Add initializers.
6980         (solib_dsbt_pspace_data): Change type.
6981         (dsbt_pspace_data_cleanup): Remove.
6982         (get_dsbt_info, _initialize_dsbt_solib): Update.
6983
6984 2019-07-10  Tom Tromey  <tromey@adacore.com>
6985
6986         * spu-tdep.c (spu_overlay_data): Change type.
6987         (spu_get_overlay_table, spu_overlay_new_objfile)
6988         (_initialize_spu_tdep): Update.
6989
6990 2019-07-10  Tom Tromey  <tromey@adacore.com>
6991
6992         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
6993         destructor.
6994         (dbx_objfile_data_key): Change type and declare later.
6995         (DBX_SYMFILE_INFO): Rewrite.
6996         * dbxread.c (dbx_objfile_data_key): Change type.
6997         (dbx_symfile_init): Update.
6998         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
6999         (coffstab_build_psymtabs, elfstab_build_psymtabs)
7000         (stabsect_build_psymtabs, _initialize_dbxread): Update.
7001
7002 2019-07-10  Tom Tromey  <tromey@adacore.com>
7003
7004         * jit.c (jit_program_space_key): Change type.  Move lower.
7005         (get_jit_program_space_data): Update.
7006         (jit_program_space_data_cleanup): Remove.
7007         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7008         Update.
7009         (struct jit_program_space_data): Add initializers.
7010
7011 2019-07-10  Tom Tromey  <tromey@adacore.com>
7012
7013         * solib-darwin.c (struct darwin_info): Add initializers.
7014         (solib_darwin_pspace_data): Change type.
7015         (darwin_pspace_data_cleanup): Remove.
7016         (get_darwin_info, _initialize_darwin_solib): Update.
7017
7018 2019-07-10  Tom Tromey  <tromey@adacore.com>
7019
7020         * remote-sim.c (struct sim_inferior_data): Add initializers,
7021         constructor, and destructor.
7022         (sim_inferior_data_key): Change type.  Move lower.
7023         (check_for_duplicate_sim_descriptor): Update.
7024         (get_sim_inferior_data): Use new.  Update.
7025         (~sim_inferior_data_cleanup): Rename from
7026         sim_inferior_data_cleanup.  Simplify.
7027         (gdbsim_close_inferior, simulator_command)
7028         (sim_command_completer, _initialize_remote_sim): Update.
7029         (next_pid, INITIAL_PID): Move earlier.
7030
7031 2019-07-10  Tom Tromey  <tromey@adacore.com>
7032
7033         * python/python-internal.h (create_thread_object): Return
7034         gdbpy_ref.
7035         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7036         * python/py-inferior.c (struct threadlist_entry): Add
7037         constructor.
7038         <thread_obj>: Now a gdbpy_ref.
7039         (thread_to_thread_object): Update.
7040         (add_thread_object): Use new.
7041         (delete_thread_object): Use delete.
7042         (infpy_threads): Update.
7043         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
7044         GIL.
7045
7046 2019-07-10  Tom Tromey  <tromey@adacore.com>
7047
7048         * valops.c (value_cast): Specialize error message for Ada.
7049
7050 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7051
7052         * breakpoint.c (breakpoint_1): Update doc and parameter names.
7053
7054 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7055
7056         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7057         bpstat_should_step): Return bool, adjust comments.
7058         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7059         bpstat_should_step): Likewise.
7060
7061 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7062
7063         * features/Makefile: Use feature target descriptions for Arm.
7064         * features/arm/arm-core.c: Generate new file.
7065         * features/arm/arm-fpa.c: Likewise.
7066         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7067         * features/arm/arm-m-profile.c: Likewise.
7068         * features/arm/arm-vfpv2.c: Likewise.
7069         * features/arm/arm-vfpv3.c: Likewise.
7070         * features/arm/xscale-iwmmxt.c: Likewise.
7071         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7072
7073 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7074
7075         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7076         ptrace earlier.
7077
7078 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7079
7080         * features/aarch64-pauth.c: Regenerate.
7081
7082 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
7083
7084         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7085         bool.
7086         (bpstat_what): Use false instead of 0.
7087
7088 2019-07-09  Pedro Alves  <palves@redhat.com>
7089
7090         * break-catch-throw.c (is_exception_catchpoint): New.
7091         * breakpoint.c (print_one_breakpoint_location): New parameter
7092         'raw_loc'.  Handle it.  Use
7093         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7094         looking at the breakpoint's type.
7095         (print_one_breakpoint): If handling "maint info breakpoints", also
7096         print locations of exception catchpoints.
7097         * breakpoint.h (is_exception_catchpoint): Declare.
7098
7099 2019-07-09  Pedro Alves  <palves@redhat.com>
7100
7101         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7102         "addr" field.
7103         (allocate_location_exception_catchpoint): New.
7104         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7105         (initialize_throw_catchpoint_ops): Install
7106         allocate_location_exception_catchpoint as allocate_location
7107         method.
7108         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7109         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7110         bp_loc_other.
7111         (breakpoint_address_is_meaningful): Delete.
7112         (bl_address_is_meaningful): New.
7113         (breakpoint_locations_match): Adjust comment.
7114         (bp_location_from_bp_type): New, factored out of...
7115         (bp_location::bp_location(breakpoint *)): ... this.
7116         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7117         factored out of...
7118         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
7119         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7120         breakpoint_address_is_meaningful.
7121         (bp_locations_compare): Adjust comment.
7122         (update_global_location_list): Use bl_address_is_meaningful
7123         instead of breakpoint_address_is_meaningful.
7124         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7125         explicit.
7126         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7127         * python/py-breakpoint.c (bppy_get_location): No longer check
7128         whether location is null.
7129
7130 2019-07-09  Pedro Alves  <palves@redhat.com>
7131
7132         PR c++/15468
7133         * breakpoint.c (print_one_breakpoint_location): Remove
7134         single-location assert.
7135
7136 2019-07-09  Tom Tromey  <tom@tromey.com>
7137
7138         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7139         * configure: Rebuild.
7140         * configure.ac: Change common to gdbsupport.
7141         * gdbsupport: Rename from common.
7142         * acinclude.m4: Change common to gdbsupport.
7143         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7144         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7145         gdbsupport.
7146         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7147         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7148         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7149         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7150         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7151         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7152         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7153         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7154         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7155         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7156         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7157         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7158         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7159         coff-pe-read.c, command.h, compile/compile-c-support.c,
7160         compile/compile-c.h, compile/compile-cplus-symbols.c,
7161         compile/compile-cplus-types.c, compile/compile-cplus.h,
7162         compile/compile-loc2c.c, compile/compile.c, completer.c,
7163         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7164         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7165         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7166         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7167         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7168         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7169         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7170         features/aarch64-core.c, features/aarch64-fpu.c,
7171         features/aarch64-pauth.c, features/aarch64-sve.c,
7172         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7173         features/i386/32bit-core.c, features/i386/32bit-linux.c,
7174         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7175         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7176         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7177         features/i386/64bit-core.c, features/i386/64bit-linux.c,
7178         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7179         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7180         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7181         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7182         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7183         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7184         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7185         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7186         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7187         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7188         go32-nat.c, guile/guile.c, guile/scm-ports.c,
7189         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7190         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7191         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7192         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7193         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7194         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7195         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7196         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7197         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7198         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7199         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7200         minsyms.c, mips-linux-tdep.c, namespace.h,
7201         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7202         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7203         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7204         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7205         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7206         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7207         nat/linux-waitpid.c, nat/mips-linux-watch.c,
7208         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7209         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7210         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7211         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7212         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7213         procfs.c, producer.c, progspace.h, psymtab.h,
7214         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7215         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7216         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7217         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7218         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7219         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7220         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7221         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7222         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7223         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7224         target-memory.c, target.c, target.h, target/waitstatus.c,
7225         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7226         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7227         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7228         unittests/array-view-selftests.c,
7229         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7230         unittests/common-utils-selftests.c,
7231         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7232         unittests/format_pieces-selftests.c,
7233         unittests/function-view-selftests.c,
7234         unittests/lookup_name_info-selftests.c,
7235         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7236         unittests/mkdir-recursive-selftests.c,
7237         unittests/observable-selftests.c,
7238         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7239         unittests/parse-connection-spec-selftests.c,
7240         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7241         unittests/scoped_fd-selftests.c,
7242         unittests/scoped_mmap-selftests.c,
7243         unittests/scoped_restore-selftests.c,
7244         unittests/string_view-selftests.c, unittests/style-selftests.c,
7245         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7246         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7247         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7248         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7249         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7250         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7251
7252 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7253
7254         * linespec.c (decode_digits_list_mode): Set explicit_line to a
7255         bool value.
7256         (decode_digits_ordinary): Set explicit_line field in sal.
7257         * symtab.c (skip_prologue_sal): Don't skip prologue for a
7258         symtab_and_line that was set on an explicit line number in
7259         assembler code.  Do always update the recorded symtab and line if
7260         we do skip the prologue.
7261
7262 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7263
7264         * breakpoint.c (set_breakpoint_location_function): Remove
7265         explicit_loc parameter.
7266         (momentary_breakpoint_from_master): Update call to
7267         set_breakpoint_location_function.
7268         (add_location_to_breakpoint): Likewise.
7269
7270 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7271
7272         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7273         required features based on default bfd type when no specific bfd
7274         is present.
7275
7276 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7277
7278         * NEWS: Mention that GDB printf and eval commands can now print
7279         C-style and Ada-style convenience var strings without
7280         calling the inferior.
7281         * printcmd.c (printf_c_string): Locally print GDB internal var
7282         instead of transiting via the inferior.
7283         (printf_wide_c_string): Likewise.
7284
7285 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7286
7287         PR breakpoints/25011
7288         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7289
7290 2019-07-04  Tom Tromey  <tom@tromey.com>
7291
7292         PR tui/24724:
7293         * tui/tui-winsource.c (tui_clear_source_content): Update.
7294         (tui_source_window_base::set_is_exec_point_at): Fix comment.
7295         (tui_update_breakpoint_info): Update.
7296         (tui_set_exec_info_content): Update.
7297         * tui/tui-source.c (tui_set_source_content_nil): Update.
7298         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7299         has_break.
7300         * tui/tui-data.h (enum tui_bp_flag): New.
7301         (tui_bp_flags): New enum flags type.
7302         (struct tui_source_element) <break_mode>: Change type.  Rename
7303         from has_break.
7304         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7305         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
7306         constants.
7307         * tui/tui-winsource.h: Fix comment.
7308
7309 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7310
7311         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7312         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7313         (store_fpregs_to_thread)
7314         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7315         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7316         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7317         (IWMMXT_REGS_SIZE): Add define.
7318         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7319         (fetch_vfp_regs, store_vfp_regs)
7320         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7321         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7322
7323 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7324
7325         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7326         defines.
7327         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7328         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7329         (ARM_INT_REGISTER_SIZE): ...to this.
7330         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7331         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7332         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7333         (arm_linux_collect_gregset, supply_nwfpe_register)
7334         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7335         defines.
7336         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7337         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7338         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7339         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7340         (arm_return_in_memory, arm_store_return_value)
7341         (arm_get_longjmp_target, arm_register_g_packet_guesses)
7342         (arm_record_ld_st_multiple): Likewise.
7343         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7344         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7345
7346 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7347
7348         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7349         AARCH64_DISPLACED_MODIFIED_INSNS.
7350         * aarch64-tdep.c (struct aarch64_displaced_step_data)
7351         (aarch64_displaced_step_copy_insn): Likewise.
7352         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7353         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7354         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7355         ARM_DISPLACED_MODIFIED_INSNS.
7356         * arm-tdep.c (arm_gdbarch_init): Likewise.
7357         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7358         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7359         (struct arm_displaced_step_closure): Use
7360         ARM_DISPLACED_MODIFIED_INSNS.
7361
7362 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7363
7364         * features/Makefile: Remove unused xml files.
7365         * features/aarch64.xml: Remove.
7366         * features/i386/amd64-avx-avx512-linux.xml: Remove.
7367         * features/i386/amd64-avx-avx512.xml: Remove.
7368         * features/i386/amd64-avx-linux.xml: Remove.
7369         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7370         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7371         * features/i386/amd64-avx-mpx-linux.xml: Remove.
7372         * features/i386/amd64-avx-mpx.xml: Remove.
7373         * features/i386/amd64-avx.xml: Remove.
7374         * features/i386/amd64-linux.xml: Remove.
7375         * features/i386/amd64-mpx-linux.xml: Remove.
7376         * features/i386/amd64-mpx.xml: Remove.
7377         * features/i386/amd64.xml: Remove.
7378         * features/i386/i386-avx-avx512-linux.xml: Remove.
7379         * features/i386/i386-avx-avx512.xml: Remove.
7380         * features/i386/i386-avx-linux.xml: Remove.
7381         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7382         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7383         * features/i386/i386-avx-mpx-linux.xml: Remove.
7384         * features/i386/i386-avx-mpx.xml: Remove.
7385         * features/i386/i386-avx.xml: Remove.
7386         * features/i386/i386-linux.xml: Remove.
7387         * features/i386/i386-mmx-linux.xml: Remove.
7388         * features/i386/i386-mmx.xml: Remove.
7389         * features/i386/i386-mpx-linux.xml: Remove.
7390         * features/i386/i386-mpx.xml: Remove.
7391         * features/i386/i386.xml: Remove.
7392         * features/i386/x32-avx-avx512-linux.xml: Remove.
7393         * features/i386/x32-avx-linux.xml: Remove.
7394         * features/i386/x32-linux.xml: Remove.
7395
7396 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7397
7398         * regformats/aarch64.dat: Remove.
7399         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7400         * regformats/i386/amd64-avx-linux.dat: Remove.
7401         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7402         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7403         * regformats/i386/amd64-linux.dat: Remove.
7404         * regformats/i386/amd64-mpx-linux.dat: Remove.
7405         * regformats/i386/amd64.dat: Remove.
7406         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7407         * regformats/i386/i386-avx-linux.dat: Remove.
7408         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7409         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7410         * regformats/i386/i386-linux.dat: Remove.
7411         * regformats/i386/i386-mmx-linux.dat: Remove.
7412         * regformats/i386/i386-mpx-linux.dat: Remove.
7413         * regformats/i386/i386.dat: Remove.
7414         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7415         * regformats/i386/x32-avx-linux.dat: Remove.
7416         * regformats/i386/x32-linux.dat: Remove.
7417
7418 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7419
7420         * aarch64-tdep.c: Remove xml self tests.
7421         * amd64-linux-tdep.c: Likewise.
7422         * amd64-tdep.c: Likewise.
7423         * i386-linux-tdep.c: Likewise.
7424         * i386-tdep.c: Likewise.
7425
7426 2019-07-03  Pedro Alves  <palves@redhat.com>
7427
7428         PR cli/24732
7429         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7430         (pipe_cmd_option_defs): New.
7431         (make_pipe_cmd_options_def_group): New.
7432         (pipe_command): Use gdb::option::process_options.
7433         (pipe_command_completer): New function.
7434         (_initialize_cli_cmds): Install completer for "pipe" command.
7435
7436 2019-07-03  Pedro Alves  <palves@redhat.com>
7437
7438         * cli/cli-option.c (union option_value) <string>: New field.
7439         (struct option_def_and_value): Add ctor, move ctor, dtor and
7440         use DISABLE_COPY_AND_ASSIGN.
7441         (option_def_and_value::clear_value): New.
7442         (parse_option, save_option_value_in_ctx, get_val_type_str)
7443         (add_setshow_cmds_for_options): Handle var_string.
7444         * cli-option.h (union option_def::var_address) <string>: New
7445         field.
7446         (struct string_option_def): New.
7447         * maint-test-options.c (struct test_options_opts): Add default
7448         ctor and use DISABLE_COPY_AND_ASSIGN.
7449         <string_opt>: New field.
7450         (test_options_opts::~test_options_opts): New.
7451         (test_options_opts::dump): Also dump "-string".
7452         (test_options_option_defs): Install "string.
7453
7454 2019-07-03  Pedro Alves  <palves@redhat.com>
7455
7456         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7457         option_value with a null enumeration.
7458         (complete_options): Save the option values in the context.
7459         (save_option_value_in_ctx): New, factored out from ...
7460         (process_options): ... here.
7461         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7462         of the function.
7463         * maint-test-options.c (test_options_opts::dump): New, factored
7464         out from ...
7465         (maintenance_test_options_command_mode): ... here.
7466         (maintenance_test_options_command_completion_result): Delete.
7467         (maintenance_test_options_command_completion_text): Update
7468         comment.
7469         (maintenance_show_test_options_completion_result): Change
7470         prototype.  Just print
7471         maintenance_test_options_command_completion_text.
7472         (save_completion_result): New.
7473         (maintenance_test_options_completer_mode): Pass options context to
7474         complete_options, and then save a dump.
7475         (_initialize_maint_test_options): Use add_cmd to install "maint
7476         show test-options-completion-result".
7477
7478 2019-07-03  Pedro Alves  <palves@redhat.com>
7479
7480         * NEWS (New commands): Mention "with" and "maint with".
7481         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7482         (with_command, with_command_completer): New.
7483         (pipe_command): Adjust to new repeat_previous
7484         interface.
7485         (_initialize_cli_cmds): Install the "with" command and its "w"
7486         alias.
7487         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7488         declarations.
7489         * cli/cli-setshow.c (parse_cli_var_uinteger)
7490         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7491         argument strings for all var_types.
7492         (get_setshow_command_value_string): New, factored out from ...
7493         (do_show_command): ... this.
7494         * cli/cli-setshow.h: Include <string>.
7495         (get_setshow_command_value_string): Declare.
7496         * command.h (repeat_previous): Now returns const char *.  Adjust
7497         comment.
7498         * maint.c: Include "cli/cli-cmds.h".
7499         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7500         (_initialize_maint_cmds): Register the "maintenance with" command.
7501         * top.c (repeat_previous): Move bits from pipe_command here:
7502         Return the saved command line, if any; error out if there's no
7503         command to relaunch.
7504
7505 2019-07-03  Pedro Alves  <palves@redhat.com>
7506
7507         * NEWS (New commands): Mention "maint set/show test-settings"
7508         instead of "maint test-settings".
7509         * maint-test-settings.c (maintenance_test_settings_list): Delete.
7510         (maintenance_test_settings_set_list): Rename to ...
7511         (maintenance_set_test_settings_list): ... this.
7512         (maintenance_test_settings_show_list): Rename to  ...
7513         (maintenance_show_test_settings_list): ... this.
7514         (maintenance_test_settings_cmd): Delete.
7515         (maintenance_test_settings_set_cmd): ...
7516         (maintenance_set_test_settings_cmd): ... this.
7517         (maintenance_test_settings_show_cmd): ...
7518         (maintenance_show_test_settings_cmd): ... this.
7519         (maintenance_test_settings_show_value_cmd):
7520         (maintenance_show_test_settings_value_cmd): ... this.
7521         (_initialize_maint_test_settings): No longer install the "maint
7522         test-settings" prefix command.  Rename "maint test-settings set"
7523         to "maint set test-settings", and "maint test-settings show" to
7524         "maint show test-settings".  Adjust all subcommands.
7525
7526 2019-07-03  Pedro Alves  <palves@redhat.com>
7527
7528         * maint-test-settings.c: Fix file's intro comment.  Replace all
7529         references to "test-options" with references to "test-settings",
7530         in comments.
7531
7532 2019-07-03  Pedro Alves  <palves@redhat.com>
7533
7534         * maint-test-settings.c (maintenance_test_settings_xxx)
7535         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7536         New.
7537         (maintenance_test_settings_enums): Use them.
7538         (maintenance_test_settings_enum): Default to
7539         maintenance_test_settings_xxx.
7540         (_initialize_maint_test_settings): Initialize
7541         MAINTENANCE_TEST_SETTINGS_FILENAME.
7542
7543 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7544
7545         * breakpoint.h (remove_breakpoints_inf): Change return type to
7546         void, move function documentation here.
7547         * breakpoint.c (remove_breakpoints_inf): Change return type to
7548         void, move function documentation to header.
7549
7550 2019-07-02  Pedro Alves  <palves@redhat.com>
7551
7552         * NEWS (Completion improvements): Mention "info threads".
7553         * thread.c (struct info_threads_opts, info_threads_option_defs)
7554         (make_info_threads_options_def_group): New.
7555         (info_threads_command): Use gdb::option::process_options.
7556         (info_threads_command_completer): New.
7557         (_initialize_thread): Use gdb::option::build_help to build the
7558         help text for "info threads".
7559
7560 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7561
7562         * defs.h (generic_load): Move from here...
7563         * symfile.h (generic_load): ... to here.  Rename name parameter
7564         to args.
7565         * symfile.c (generic_load): Add comment.
7566
7567 2019-07-01  Tom Tromey  <tromey@adacore.com>
7568
7569         * dwarf2read.c
7570         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7571         declaration of without_params.  Fix formatting.
7572
7573 2019-07-01  Tom Tromey  <tromey@adacore.com>
7574
7575         * ada-exp.y (find_primitive_type): Update.
7576         * ada-lang.h (ada_lookup_symbol): Update.
7577         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7578         parameter.
7579         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7580
7581 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7582
7583         PR breakpoints/24541
7584         * gdbarch.c: Regenerate.
7585         * gdbarch.h: Regenerate.
7586         * gdbarch.sh: Add 'stap_adjust_register'.
7587         * i386-tdep.c: Include '<unordered_set>'.
7588         (i386_stap_adjust_register): New function.
7589         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7590         * stap-probe.c (stap_parse_register_operand): Call
7591         'gdbarch_stap_adjust_register'.
7592
7593 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7594
7595         PR python/24742
7596         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7597         * python/python.c (do_start_initialization): Use 'xmalloc'
7598         instead of 'PyMem_Malloc'.
7599
7600 2019-06-28  Tom Tromey  <tromey@adacore.com>
7601
7602         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7603         for Ada.
7604
7605 2019-06-27  Tom Tromey  <tromey@adacore.com>
7606
7607         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
7608         objfile_key.
7609         (arm_find_mapping_symbol, arm_record_special_symbol)
7610         (_initialize_arm_tdep): Update.
7611         (arm_objfile_data_free): Remove.
7612
7613 2019-06-27  Tom Tromey  <tromey@adacore.com>
7614
7615         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7616         to cp_print_static_field.
7617
7618 2019-06-26  Tom Tromey  <tromey@adacore.com>
7619
7620         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7621         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7622         declare.
7623
7624 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7625
7626         * features/aarch64-core.c (create_feature_aarch64_core):
7627         Regenerate.
7628         * features/aarch64-core.xml: Add cpsr flags.
7629
7630 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7631
7632         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7633         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7634
7635 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7636
7637         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7638         field.
7639         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7640         use.
7641         (arm_record_special_symbol): Don't insert new symbol in sorted
7642         position, push it at the end.
7643
7644 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7645
7646         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7647         (arm_mapping_symbol_s): Remove.
7648         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7649         (arm_mapping_symbol_vec): New typedef.
7650         (struct arm_per_objfile): Add constructor.
7651         <section_maps>: Change type to
7652         std::unique_ptr<arm_mapping_symbol_vec[]>.
7653         (arm_compare_mapping_symbols): Remove.
7654         (arm_find_mapping_symbol): Adjust to section_maps type change.
7655         (arm_objfile_data_free): Call delete on arm_per_objfile.
7656         (arm_record_special_symbol): Adjust to section_maps type change.
7657         Allocate arm_per_objfile with new.
7658
7659 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7660
7661         * cli/cli-cmds.c (alias_command): Compare the alias prefix
7662         with the command prefix.
7663
7664 2019-06-25  Tom Tromey  <tom@tromey.com>
7665
7666         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7667         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7668
7669 2019-06-25  Tom Tromey  <tom@tromey.com>
7670
7671         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7672         type.
7673         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7674         protected.
7675
7676 2019-06-25  Tom Tromey  <tom@tromey.com>
7677
7678         * tui/tui-winsource.c
7679         (tui_source_window_base::set_is_exec_point_at): Add check against
7680         LOA_ADDRESS.
7681
7682 2019-06-25  Tom Tromey  <tom@tromey.com>
7683
7684         * tui/tui-source.c (tui_set_source_content): Don't check before
7685         xfree.
7686         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7687
7688 2019-06-25  Tom Tromey  <tom@tromey.com>
7689
7690         * tui/tui-winsource.h (tui_update_source_window_as_is)
7691         (tui_alloc_source_buffer, tui_line_is_displayed)
7692         (tui_addr_is_displayed): Change type of win_info.
7693         * tui/tui-winsource.c (tui_update_source_window_as_is)
7694         (tui_clear_source_content, tui_show_source_line)
7695         (tui_show_source_content, tui_source_window_base::refill)
7696         (tui_source_window_base::set_is_exec_point_at)
7697         (tui_source_window_base::set_is_exec_point_at)
7698         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7699         (tui_alloc_source_buffer, tui_line_is_displayed)
7700         (tui_addr_is_displayed): Change type of win_info.  Update.
7701         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7702         (tui_source_window_base::do_make_visible_with_new_height):
7703         Update.
7704         * tui/tui-source.c (tui_set_source_content)
7705         (tui_set_source_content_nil)
7706         (tui_source_window::do_scroll_vertical): Update.
7707         * tui/tui-layout.c (show_layout): Update.
7708         * tui/tui-disasm.c (tui_set_disassem_content)
7709         (tui_disasm_window::do_scroll_vertical): Update.
7710         * tui/tui-data.h (tui_win_content): Remove.
7711         (struct tui_gen_win_info) <content, content_size>: Remove.
7712         (struct tui_source_element): Add initializers and destructor.
7713         (union tui_which_element, struct tui_win_element): Remove.
7714         (struct tui_source_window_base) <content>: New field.
7715         (struct tui_data_window): Remove destructor.
7716         (tui_alloc_content, tui_free_win_content)
7717         (tui_free_all_source_wins_content): Don't declare.
7718         * tui/tui-data.c (tui_initialize_static_data): Update.
7719         (init_content_element, tui_alloc_content): Remove.
7720         (~tui_gen_win_info): Update.
7721         (~tui_data_window, tui_free_all_source_wins_content)
7722         (tui_free_win_content, free_content, free_content_elements):
7723         Remove.
7724
7725 2019-06-25  Tom Tromey  <tom@tromey.com>
7726
7727         * tui/tui-winsource.h (tui_clear_source_content)
7728         (tui_erase_source_content, tui_show_source_content): Change type
7729         of win_info.
7730         * tui/tui-winsource.c (tui_clear_source_content)
7731         (tui_erase_source_content, tui_show_source_content): Change type
7732         of win_info.
7733         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7734         * tui/tui-source.h (tui_set_source_content_nil): Change type of
7735         win_info.
7736         * tui/tui-source.c (tui_set_source_content_nil): Change type of
7737         win_info.
7738         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7739
7740 2019-06-25  Tom Tromey  <tom@tromey.com>
7741
7742         * tui/tui-winsource.c (tui_clear_source_content)
7743         (tui_source_window_base::set_is_exec_point_at): Update.
7744         * tui/tui-source.c (tui_set_source_content_nil): Update.
7745         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7746         a bool.
7747         * tui/tui-data.c (init_content_element): Update.
7748
7749 2019-06-25  Tom Tromey  <tom@tromey.com>
7750
7751         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7752         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7753         * tui/tui-layout.c (init_and_make_win): Update.
7754         * tui/tui.h (enum tui_win_type): Update.
7755         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7756         tui_win_is_auxillary.
7757         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7758         tui_win_is_auxillary.
7759
7760 2019-06-25  Tom Tromey  <tom@tromey.com>
7761
7762         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7763         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7764         (tui_delete_data_content_windows, tui_display_all_data)
7765         (tui_data_window::do_scroll_vertical, tui_display_data_from):
7766         Update.
7767         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7768         * tui/tui-regs.c (tui_last_regs_line_no)
7769         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7770         (tui_show_registers): Update.
7771         (tui_show_register_group): Return void.  Update.
7772         (tui_display_registers_from, tui_display_reg_element_at_line)
7773         (tui_display_registers_from_line, tui_check_register_values):
7774         Update.
7775         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7776         member.
7777         (struct tui_data_window) <regs_content>: Now a std::vector.
7778         <regs_content_count>: Remove.
7779         (tui_add_content_elements, tui_free_data_content): Don't declare.
7780         * tui/tui-data.c (tui_data_window::clear_detail): Update.
7781         (init_content_element): Remove DATA_WIN case.  Add assert.
7782         (tui_add_content_elements): Remove.
7783         (tui_data_window): Update.
7784         (tui_free_data_content): Remove.
7785         (free_content_elements): Remove DATA_WIN case.
7786
7787 2019-06-25  Tom Tromey  <tom@tromey.com>
7788
7789         * tui/tui-data.c (tui_data_item_window): Update.
7790         * tui/tui-windata.h (tui_check_data_values): Don't declare.
7791         * tui/tui-windata.c (tui_display_all_data)
7792         (tui_display_data_from_line): Update.
7793         (tui_check_data_values): Remove.
7794         * tui/tui-regs.c (tui_show_register_group)
7795         (tui_display_reg_element_at_line): Update.
7796         * tui/tui-hooks.c (tui_register_changed)
7797         (tui_refresh_frame_and_register_information): Call
7798         tui_check_register_values.
7799         * tui/tui-data.h (struct tui_data_window) <data_content,
7800         data_content_count, data_type>: Remove.
7801         (enum tui_data_type): Remove.
7802
7803         * tui/tui-data.c (tui_data_window::clear_detail)
7804         (~tui_data_window): Update.
7805
7806 2019-06-25  Tom Tromey  <tom@tromey.com>
7807
7808         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7809         declare.
7810         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7811         Rename from tui_first_data_item_displayed.  Update.
7812         (tui_data_window::refresh_all)
7813         (tui_data_window::do_scroll_vertical): Update.
7814         * tui/tui-data.h (struct tui_data_window)
7815         <first_data_item_displayed>: Declare new method.
7816
7817 2019-06-25  Tom Tromey  <tom@tromey.com>
7818
7819         * tui/tui-data.h (tui_init_generic_part): Don't declare.
7820         * tui/tui-data.c (tui_init_generic_part): Remove, moving
7821         contents...
7822         (tui_initialize_static_data): ...here.
7823
7824 2019-06-25  Tom Tromey  <tom@tromey.com>
7825
7826         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7827         (tui_display_registers_from, tui_check_register_values): Update.
7828         (tui_display_register): Remove win_info parameter; update.
7829         (tui_get_register): Change type of parameters.
7830         * tui/tui-data.h (struct tui_data_element): Remove.
7831         (union tui_which_element) <data>: Remove.
7832         <data_window>: Change type.
7833         (struct tui_data_item_window): New.
7834         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7835         case.  Add assert.
7836         (~tui_data_item_window): New destructor.
7837         (free_content_elements): Remove DATA_ITEM_WIN case.
7838
7839 2019-06-25  Tom Tromey  <tom@tromey.com>
7840
7841         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7842         Remove.
7843
7844 2019-06-25  Tom Tromey  <tom@tromey.com>
7845
7846         * tui/tui-data.h (struct tui_command_element): Remove.
7847         (union tui_which_element) <command>: Remove.
7848         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
7849         assert.
7850         (free_content_elements): Remove CMD_WIN case.
7851
7852 2019-06-25  Tom Tromey  <tom@tromey.com>
7853
7854         * tui/tui-layout.c (tui_set_layout): Update.
7855         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7856         * tui/tui-data.c (layout_def): Update.
7857
7858 2019-06-25  Tom Tromey  <tom@tromey.com>
7859
7860         * tui/tui-wingeneral.c (tui_refresh_all): Update.
7861         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7862         (tui_source_window_base::set_new_height): Update.
7863         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7864         Update.
7865         (tui_set_locator_fullname, tui_set_locator_info)
7866         (tui_show_frame_info): Update.
7867         * tui/tui-source.c (tui_set_source_content)
7868         (tui_source_is_displayed): Update.
7869         * tui/tui-layout.c (show_source_disasm_command, show_data)
7870         (show_source_or_disasm_and_command): Update.
7871         * tui/tui-disasm.c (tui_set_disassem_content)
7872         (tui_get_begin_asm_address): Update.
7873         * tui/tui-data.h (struct tui_locator_element): Remove.
7874         (union tui_which_element) <locator>: Remove.
7875         (struct tui_locator_window): New.
7876         (tui_locator_win_info_ptr): Change return type.
7877         * tui/tui-data.c (_locator): Change type.
7878         (tui_locator_win_info_ptr): Change return type.
7879         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
7880         (tui_alloc_content): Add assert.
7881
7882 2019-06-25  Tom Tromey  <tom@tromey.com>
7883
7884         * tui/tui-winsource.c
7885         (tui_exec_info_window::maybe_allocate_content): New method.
7886         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7887         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7888         (make_source_or_disasm_window): Add cast.
7889         * tui/tui-data.h (union tui_which_element) <simple_string>:
7890         Remove.
7891         (struct tui_source_info): New.
7892         (struct tui_source_window_base) <execution_info>: Change type.
7893         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7894         case, and add assert.
7895         (tui_alloc_content): Add assert.
7896
7897 2019-06-25  Tom Tromey  <tom@tromey.com>
7898
7899         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7900         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7901         * tui/tui-data.c (tui_alloc_win_info): Remove.
7902
7903 2019-06-25  Tom Tromey  <tom@tromey.com>
7904
7905         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7906         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7907         can_highlight.
7908
7909 2019-06-25  Tom Tromey  <tom@tromey.com>
7910
7911         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7912         make_visible_with_new_height method.
7913         (tui_win_info::make_visible_with_new_height): New method.
7914         (tui_source_window_base::do_make_visible_with_new_height)
7915         (tui_data_window::do_make_visible_with_new_height)
7916         (tui_cmd_window::do_make_visible_with_new_height): New methods.
7917         (make_visible_with_new_height): Remove.
7918         (tui_resize_all, tui_adjust_win_heights): Use
7919         make_visible_with_new_height method.
7920         * tui/tui-data.h (struct tui_win_info)
7921         <do_make_visible_with_new_height, make_visible_with_new_height>:
7922         New methods.
7923         (struct tui_source_window_base, struct tui_data_window)
7924         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7925         methods.
7926
7927 2019-06-25  Tom Tromey  <tom@tromey.com>
7928
7929         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
7930         method.
7931         (update_tab_width): Call update_tab_width method.
7932         * tui/tui-data.h (struct tui_win_info)
7933         (struct tui_source_window_base) <update_tab_width>: New methods.
7934
7935 2019-06-25  Tom Tromey  <tom@tromey.com>
7936
7937         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
7938         parameter.
7939         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
7940         parameter.
7941         (tui_gen_win_info::make_visible): Update.
7942         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
7943         parameter.
7944         * tui/tui-data.h (enum tui_box): New enum.
7945         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
7946
7947 2019-06-25  Tom Tromey  <tom@tromey.com>
7948
7949         * tui/tui-layout.c (make_source_or_disasm_window): Always use
7950         init_and_make_win for EXEC_INFO_WIN.
7951         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
7952         longer inline.
7953         (struct tui_win_info) <~tui_win_info>: Inline.
7954         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7955         Don't declare.
7956         * tui/tui-data.c (source_win, disasm_win): Remove globals.
7957         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7958         Remove.
7959         (tui_initialize_static_data): Update.
7960         (~tui_gen_win_info): Handle more cleanup here.
7961         (~tui_source_window_base): Delete "execution_info".
7962         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
7963
7964 2019-06-25  Tom Tromey  <tom@tromey.com>
7965
7966         * tui/tui-layout.c (make_command_window): Don't set
7967         can_highlight.
7968         (show_source_disasm_command): Call the reset method.
7969         (show_data): Don't set can_highlight.  Call the reset method.
7970         (tui_gen_win_info::reset): Rename from init_gen_win_info
7971         (init_and_make_win): Simplify.  Return tui_gen_win_info.
7972         (show_source_or_disasm_and_command): Call the reset method.
7973         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
7974         (struct tui_cmd_window): Set can_highlight.
7975
7976 2019-06-25  Tom Tromey  <tom@tromey.com>
7977
7978         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
7979         from make_visible.
7980         (tui_make_visible, tui_make_invisible): Rewrite.
7981         (tui_win_info::make_visible): Remove.
7982         (tui_source_window_base::make_visible): Update.
7983         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
7984         method.  Moved from...
7985         (struct tui_win_info) <make_visible>: ...here.
7986
7987 2019-06-25  Tom Tromey  <tom@tromey.com>
7988
7989         * tui/tui-winsource.c
7990         (tui_source_window_base::do_scroll_horizontal): Remove direction
7991         parameter.
7992         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
7993         direction parameter.
7994         * tui/tui-win.c (tui_win_info::forward_scroll)
7995         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7996         (tui_win_info::right_scroll): Update.
7997         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
7998         direction parameter.
7999         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8000         direction parameter.
8001         * tui/tui-data.h (enum tui_scroll_direction): Remove.
8002         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8003         Remove direction parameter.
8004         (struct tui_source_window_base, struct tui_source_window)
8005         (struct tui_disasm_window, struct tui_data_window)
8006         (struct tui_cmd_window): Update.
8007
8008 2019-06-25  Tom Tromey  <tom@tromey.com>
8009
8010         * tui/tui-winsource.h (tui_set_exec_info_content)
8011         (tui_show_exec_info_content, tui_erase_exec_info_content)
8012         (tui_clear_exec_info_content, tui_update_exec_info): Change
8013         argument to tui_source_window_base.
8014         * tui/tui-winsource.c (tui_set_exec_info_content)
8015         (tui_show_exec_info_content, tui_erase_exec_info_content)
8016         (tui_clear_exec_info_content, tui_update_exec_info): Change
8017         argument to tui_source_window_base.
8018
8019 2019-06-25  Tom Tromey  <tom@tromey.com>
8020
8021         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8022         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8023
8024 2019-06-25  Tom Tromey  <tom@tromey.com>
8025
8026         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8027         check.
8028
8029 2019-06-25  Tom Tromey  <tom@tromey.com>
8030
8031         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8032         type to void.
8033         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8034         type to void.
8035         * tui/tui-source.c (tui_set_source_content): Update.
8036         * tui/tui-disasm.c (tui_set_disassem_content): Update.
8037
8038 2019-06-25  Tom Tromey  <tom@tromey.com>
8039
8040         * tui/tui-win.c (window_name_completer, tui_set_focus)
8041         (tui_all_windows_info): Use name method.
8042         * tui/tui-data.h (struct tui_gen_win_info)
8043         (struct tui_source_window, struct tui_disasm_window)
8044         (struct tui_data_window, struct tui_cmd_window) <name>: New
8045         method.
8046         (tui_win_name): Don't declare.
8047         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8048         (tui_win_name): Remove.
8049
8050 2019-06-25  Tom Tromey  <tom@tromey.com>
8051
8052         * tui/tui-winsource.h (tui_update_source_window)
8053         (tui_update_source_window_as_is): Change parameter type.
8054         * tui/tui-winsource.c (tui_update_source_window): Change win_info
8055         to be a tui_source_window_base.
8056         (tui_update_source_window_as_is): Likewise.
8057         * tui/tui-win.c (make_visible_with_new_height): Update.
8058
8059 2019-06-25  Tom Tromey  <tom@tromey.com>
8060
8061         * tui/tui-winsource.c (tui_erase_source_content)
8062         (tui_show_source_content, tui_show_exec_info_content)
8063         (tui_erase_exec_info_content): Use refresh_window method.
8064         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8065         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8066         from tui_refresh_win.
8067         (tui_data_window::refresh_window): New method.
8068         (tui_win_info::refresh, tui_source_window_base::refresh)
8069         (tui_refresh_all): Use refresh_window method.
8070         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8071         method.
8072         * tui/tui-regs.c (tui_display_register): Call refresh_window
8073         method.
8074         * tui/tui-layout.c (show_source_disasm_command)
8075         (show_source_or_disasm_and_command): Call refresh_window method.
8076         * tui/tui-data.h (struct tui_gen_win_info)
8077         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8078         New method.
8079
8080 2019-06-25  Tom Tromey  <tom@tromey.com>
8081
8082         * tui/tui.c (tui_rl_other_window, tui_enable)
8083         (tui_is_window_visible, tui_get_command_dimension): Update.
8084         * tui/tui-winsource.c (tui_update_source_window_as_is)
8085         (tui_clear_source_content, tui_erase_source_content)
8086         (tui_show_source_line, tui_source_window_base::refill)
8087         (tui_source_window_base::do_scroll_horizontal)
8088         (tui_source_window_base::set_is_exec_point_at)
8089         (tui_update_breakpoint_info, tui_set_exec_info_content)
8090         (tui_alloc_source_buffer, tui_line_is_displayed)
8091         (tui_addr_is_displayed): Update.
8092         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8093         (tui_check_and_display_highlight_if_needed)
8094         (tui_win_info::make_visible, tui_win_info::refresh)
8095         (tui_refresh_all): Update.
8096         * tui/tui-windata.c (tui_first_data_item_displayed)
8097         (tui_delete_data_content_windows, tui_erase_data_content)
8098         (tui_display_all_data, tui_data_window::refresh_all)
8099         (tui_check_data_values): Update.
8100         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8101         (tui_set_win_focus_to, tui_win_info::forward_scroll)
8102         (tui_win_info::backward_scroll, tui_refresh_all_win)
8103         (tui_resize_all, tui_set_focus, tui_all_windows_info)
8104         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8105         (tui_source_window_base::set_new_height)
8106         (tui_data_window::set_new_height)
8107         (make_invisible_and_set_new_height)
8108         (make_visible_with_new_height, new_height_ok)
8109         (parse_scrolling_args): Update.
8110         * tui/tui-stack.c (tui_show_frame_info): Update.
8111         * tui/tui-source.c (tui_set_source_content)
8112         (tui_set_source_content_nil, tui_source_is_displayed)
8113         (tui_source_window::do_scroll_vertical): Update.
8114         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8115         (tui_display_registers_from, tui_display_reg_element_at_line)
8116         (tui_check_register_values, tui_reg_command): Update.
8117         * tui/tui-layout.c (tui_default_win_height)
8118         (show_source_disasm_command, show_data, init_and_make_win)
8119         (show_source_or_disasm_and_command): Update.
8120         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8121         (tui_redisplay_readline, tui_mld_flush)
8122         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8123         (tui_getc): Update.
8124         * tui/tui-disasm.c (tui_set_disassem_content)
8125         (tui_disasm_window::do_scroll_vertical): Update.
8126         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8127         Now virtual.
8128         (struct tui_win_info): Derive from tui_gen_win_info.
8129         <~tui_win_info>: Mark as override.
8130         <generic>: Remove member.
8131         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8132         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8133         (~tui_data_window, ~tui_win_info)
8134         (tui_free_all_source_wins_content): Update.
8135         * tui/tui-command.c (tui_refresh_cmd_win): Update.
8136
8137 2019-06-25  Tom Tromey  <tom@tromey.com>
8138
8139         * tui/tui-layout.c (init_and_make_win): Use new.
8140         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8141         destructor, initializers.
8142         (tui_alloc_generic_win_info): Don't declare.
8143         * tui/tui-data.c (_locator): Add argument to constructor.
8144         (source_win, disasm_win): New globals.
8145         (exec_info): Remove.
8146         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8147         Update.
8148         (tui_alloc_generic_win_info): Remove.
8149         (init_content_element): Use new.
8150         (tui_win_info::tui_win_info): Update.
8151         (free_content_elements) <case DATA_WIN>: Use delete.
8152
8153 2019-06-25  Tom Tromey  <tom@tromey.com>
8154
8155         * tui/tui-wingeneral.c (tui_refresh_win): Update.
8156         * tui/tui-windata.c (tui_first_data_item_displayed)
8157         (tui_delete_data_content_windows): Update.
8158         * tui/tui-win.c (tui_data_window::set_new_height): Update.
8159         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8160         (tui_display_registers_from, tui_check_register_values): Update.
8161         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8162         pointer.
8163         * tui/tui-data.c (init_content_element): Update.  Allocate the new
8164         window.
8165         (tui_free_data_content): Update.
8166         (free_content_elements) <case DATA_WIN>: Free the window.
8167
8168 2019-06-25  Tom Tromey  <tom@tromey.com>
8169
8170         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8171         Update.
8172         * tui/tui-layout.c (make_command_window)
8173         (show_source_disasm_command, show_data, init_and_make_win)
8174         (show_source_or_disasm_and_command): Update.
8175         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8176         method.
8177         <can_highight, is_highlighted>: Now bool.
8178         (tui_set_win_highlight): Don't declare.
8179         * tui/tui-data.c (tui_set_win_highlight): Remove.
8180
8181 2019-06-25  Tom Tromey  <tom@tromey.com>
8182
8183         * tui/tui-wingeneral.c (make_visible): Remove check of window
8184         type.
8185
8186 2019-06-25  Tom Tromey  <tom@tromey.com>
8187
8188         * tui/tui-win.c (tui_win_info::max_height)
8189         (tui_cmd_window::max_height): New methods.
8190         (new_height_ok): Call max_height.
8191         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8192         <max_height>: New method.
8193
8194 2019-06-25  Tom Tromey  <tom@tromey.com>
8195
8196         * tui/tui-win.c (tui_source_window_base::set_new_height)
8197         (tui_data_window::set_new_height): New methods.
8198         (make_invisible_and_set_new_height): Call set_new_height method.
8199         * tui/tui-data.h (struct tui_win_info)
8200         (struct tui_source_window_base, struct tui_data_window)
8201         <set_new_height>: New method.
8202
8203 2019-06-25  Tom Tromey  <tom@tromey.com>
8204
8205         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8206         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8207         tui_refresh_data_win.
8208         * tui/tui-win.c (tui_source_window_base::refresh_all): New
8209         method.
8210         (tui_refresh_all_win): Call the refresh_all method.
8211         (tui_set_focus): Likewise.
8212         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8213         (struct tui_source_window_base, struct tui_data_window) <refresh>:
8214         Likewise.
8215
8216 2019-06-25  Tom Tromey  <tom@tromey.com>
8217
8218         * tui/tui-winsource.h (tui_refill_source_window)
8219         (tui_set_is_exec_point_at): Don't declare.
8220         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8221         (tui_source_window_base::refill): Rename from
8222         tui_refill_source_window.
8223         (tui_source_window_base::do_scroll_horizontal): Update.
8224         (tui_source_window_base::set_is_exec_point_at): Rename from
8225         tui_set_is_exec_point_at.
8226         (tui_update_all_breakpoint_info): Update.
8227         * tui/tui-stack.c (tui_show_frame_info): Update.
8228         * tui/tui-layout.c (show_data): Add cast.
8229         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8230         * tui/tui-data.h (struct tui_source_window_base) <refill,
8231         set_is_exec_point_at>: New methods.
8232         (tui_source_windows, tui_add_to_source_windows): Update types.
8233         (tui_add_to_source_windows): Remove redundant declaration.
8234         * tui/tui-data.c (source_windows): Store tui_source_window_base.
8235         (tui_source_windows): Change return type.
8236         (tui_clear_source_windows_detail): Update.
8237         (tui_add_to_source_windows): Change type of parameter.
8238         (tui_free_all_source_wins_content): Update.
8239
8240 2019-06-25  Tom Tromey  <tom@tromey.com>
8241
8242         * tui/tui-wingeneral.c (tui_win_info::refresh)
8243         (tui_source_window_base::refresh): New methods.
8244         (tui_refresh_all): Call the refresh method.
8245         * tui/tui-data.h (struct tui_win_info)
8246         (struct tui_source_window_base) <refresh>: New method.
8247
8248 2019-06-25  Tom Tromey  <tom@tromey.com>
8249
8250         * tui/tui.h (tui_is_window_visible): Return bool.
8251         * tui/tui.c (tui_is_window_visible): Return bool.
8252         * tui/tui-wingeneral.c (tui_make_window, make_visible)
8253         (tui_make_visible, tui_make_invisible)
8254         (tui_win_info::make_visible)
8255         (tui_source_window_base::make_visible, make_all_visible)
8256         (tui_make_all_visible, tui_make_all_invisible): Update.
8257         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8258         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8259         bool.
8260         (struct tui_win_info, struct tui_source_window_base)
8261         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8262         * tui/tui-data.c (tui_init_generic_part): Update.
8263
8264 2019-06-25  Tom Tromey  <tom@tromey.com>
8265
8266         * tui/tui-wingeneral.c (tui_win_info::make_visible)
8267         (tui_source_window_base::make_visible): New methods.
8268         (make_all_visible): Make method call.
8269         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8270         (struct tui_source_window_base, struct tui_cmd_window): Override
8271         make_visible.
8272         (tui_win_is_source_type): Don't declare.
8273         * tui/tui-data.c (tui_win_is_source_type): Remove.
8274
8275 2019-06-25  Tom Tromey  <tom@tromey.com>
8276
8277         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8278         NULL check.
8279
8280 2019-06-25  Tom Tromey  <tom@tromey.com>
8281
8282         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8283         Inline constructor.  Add initializers for members.
8284         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8285         constructors; now inline in class.
8286
8287 2019-06-25  Tom Tromey  <tom@tromey.com>
8288
8289         * tui/tui-regs.c (tui_show_registers): Update.
8290         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8291         bool.
8292         * tui/tui-data.c (tui_data_window::clear_detail)
8293         (tui_data_window): Update.
8294
8295 2019-06-25  Tom Tromey  <tom@tromey.com>
8296
8297         * tui/tui-windata.c (tui_display_all_data)
8298         (tui_display_data_from_line, tui_display_data_from)
8299         (tui_check_data_values, tui_data_window::do_scroll_vertical):
8300         Update.
8301         * tui/tui-regs.c (tui_last_regs_line_no)
8302         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8303         (tui_show_registers, tui_show_register_group)
8304         (tui_display_registers_from, tui_display_reg_element_at_line)
8305         (tui_display_registers_from_line, tui_check_register_values)
8306         (tui_reg_next, tui_reg_prev): Update.
8307         * tui/tui-layout.c (tui_set_layout, show_data): Update.
8308         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
8309         tui_data_window.
8310         (struct tui_win_info) <detail>: Remove.  Add new fields from
8311         tui_data_info.
8312         (TUI_DATA_WIN): Add cast.
8313         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8314         (~tui_data_window): Simplify.
8315
8316 2019-06-25  Tom Tromey  <tom@tromey.com>
8317
8318         * tui/tui-layout.c (show_source_disasm_command)
8319         (show_source_or_disasm_and_command): Update.
8320         * tui/tui-io.c (update_cmdwin_start_line)
8321         (tui_redisplay_readline): Update.
8322         * tui/tui-data.h (struct tui_command_info): Remove.
8323         (struct tui_win_info) <detail>: Remove command_info member.
8324         (struct tui_data_window) <start_line>: New member, from
8325         tui_command_info.
8326         (TUI_CMD_WIN): Add casts.
8327
8328 2019-06-25  Tom Tromey  <tom@tromey.com>
8329
8330         * tui/tui-winsource.c (tui_update_source_window)
8331         (tui_refill_source_window)
8332         (tui_source_window_base::do_scroll_horizontal)
8333         (tui_update_breakpoint_info, tui_set_exec_info_content)
8334         (tui_show_exec_info_content, tui_erase_exec_info_content)
8335         (tui_clear_exec_info_content): Update.
8336         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8337         Update.
8338         * tui/tui-win.c (make_invisible_and_set_new_height)
8339         (make_visible_with_new_height): Update.
8340         * tui/tui-source.c (tui_set_source_content)
8341         (tui_show_symtab_source): Update.
8342         * tui/tui-layout.c (extract_display_start_addr)
8343         (show_source_disasm_command, show_data)
8344         (make_source_or_disasm_window)
8345         (show_source_or_disasm_and_command): Update.
8346         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8347         (tui_disasm_window::do_scroll_vertical): Remove shadowing
8348         "gdbarch".
8349         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
8350         to tui_source_window_base.
8351         (struct tui_win_info) <detail>: Remove source_info member.
8352         (struct tui_source_window_base) <has_locator>: Inline.
8353         Move contents from tui_source_info; rename has_locator member to
8354         m_has_locator.
8355         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8356         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8357         header file.
8358         (tui_source_window_base::clear_detail, ~tui_source_window_base):
8359         Simplify.
8360         (tui_free_all_source_wins_content): Cast to
8361         tui_source_window_base.
8362
8363 2019-06-25  Tom Tromey  <tom@tromey.com>
8364
8365         * tui/tui-win.c (make_invisible_and_set_new_height)
8366         (make_visible_with_new_height): Call has_locator method.
8367         * tui/tui-layout.c (show_source_disasm_command, show_data)
8368         (show_source_or_disasm_and_command): Update for bool change.
8369         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8370         (tui_win_info) <has_locator>: New method.
8371         (struct tui_source_window_base) <has_locator>: New method.
8372         (tui_win_has_locator): Don't declare.
8373         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8374         from tui_win_has_locator.
8375         (tui_source_window_base): Use false, not FALSE.
8376
8377 2019-06-25  Tom Tromey  <tom@tromey.com>
8378
8379         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8380         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8381         clear_detail method directly.
8382         (tui_clear_win_detail): Remove.
8383
8384 2019-06-25  Tom Tromey  <tom@tromey.com>
8385
8386         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8387         "this", not TUI_DISASM_WIN.
8388
8389 2019-06-25  Tom Tromey  <tom@tromey.com>
8390
8391         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
8392         declare.
8393         * tui/tui-winsource.c
8394         (tui_source_window_base::do_scroll_horizontal): Rename from
8395         tui_horizontal_source_scroll.
8396         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8397         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8398         from tui_vertical_data_scroll.
8399         * tui/tui-win.h (tui_scroll): Don't declare.
8400         * tui/tui-win.c (tui_win_info::forward_scroll)
8401         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8402         (tui_win_info::right_scroll): Rename and update.
8403         (tui_scroll_forward_command, tui_scroll_backward_command)
8404         (tui_scroll_left_command, tui_scroll_right_command): Update.
8405         (tui_scroll): Remove.
8406         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8407         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8408         from tui_vertical_source_scroll.
8409         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8410         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8411         from tui_vertical_disassem_scroll.
8412         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8413         do_scroll_horizontal>: New methods.
8414         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8415         Likewise.
8416         (struct tui_source_window_base): Add do_scroll_horizontal.
8417         (struct tui_source_window, struct tui_disasm_window): Add
8418         do_scroll_vertical.
8419         (struct tui_data_window, struct tui_cmd_window): Add
8420         do_scroll_horizontal and do_scroll_vertical.
8421         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8422
8423 2019-06-25  Tom Tromey  <tom@tromey.com>
8424
8425         * tui/tui-data.h (struct tui_source_window_base): New struct.
8426         (struct tui_source_window): Derive from tui_source_window_base.
8427         (struct tui_disasm_window): New struct.
8428         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8429         from tui_source_window::clear_detail.
8430         (tui_source_window_base): Rename from tui_source_window.
8431         (~tui_source_window_base): Rename from ~tui_source_window.
8432         (tui_alloc_win_info): Create a tui_disasm_window.
8433
8434 2019-06-25  Tom Tromey  <tom@tromey.com>
8435
8436         * tui/tui-data.h (struct tui_source_window)
8437         (struct tui_data_window): Declare destructors.
8438         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8439         destructors.
8440         (tui_win_info): Simplify.
8441
8442 2019-06-25  Tom Tromey  <tom@tromey.com>
8443
8444         * tui/tui-winsource.c (tui_display_main)
8445         (tui_update_source_windows_with_addr)
8446         (tui_update_all_breakpoint_info): Update.
8447         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8448         (new_height_ok, parse_scrolling_args): Update.
8449         * tui/tui-stack.c (tui_show_frame_info): Update.
8450         * tui/tui-data.h (struct tui_list): Remove.
8451         (tui_source_windows): Return a reference to a std::vector.
8452         * tui/tui-data.c (source_windows): Now a std::vector.
8453         (tui_source_windows): Change return type.
8454         (tui_clear_source_windows): Rewrite.
8455         (tui_clear_source_windows_detail, tui_add_to_source_windows)
8456         (tui_free_all_source_wins_content): Rewrite.
8457
8458 2019-06-25  Tom Tromey  <tom@tromey.com>
8459
8460         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8461         (struct tui_data_window, struct tui_cmd_window): Declare
8462         clear_detail method.
8463         * tui/tui-data.c (tui_source_window::clear_detail)
8464         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8465         methods.
8466         (tui_clear_win_detail): Simplify.
8467
8468 2019-06-25  Tom Tromey  <tom@tromey.com>
8469
8470         * tui/tui-layout.c (make_source_window, make_disasm_window)
8471         (make_source_or_disasm_window): Remove win_info_ptr parameter.
8472         Return the new window.
8473         (show_source_disasm_command, show_data)
8474         (show_source_or_disasm_and_command): Update.
8475
8476 2019-06-25  Tom Tromey  <tom@tromey.com>
8477
8478         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8479         parameter.  Return the new window.
8480         (show_source_disasm_command): Update and remove NULL check.
8481         (show_source_or_disasm_and_command): Update.
8482
8483 2019-06-25  Tom Tromey  <tom@tromey.com>
8484
8485         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8486
8487 2019-06-25  Tom Tromey  <tom@tromey.com>
8488
8489         * tui/tui-data.h (struct tui_win_info): Make constructor
8490         protected.  Make destructor virtual.  Add initializers.
8491         (tui_source_window, tui_data_window, tui_cmd_window): New
8492         classes.
8493         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
8494         constructor.  Add "type" parameter.
8495         (tui_source_window, tui_data_window, tui_cmd_window): New
8496         constructors.
8497         (tui_alloc_win_info): Instantiate the appropriate subclass.
8498
8499 2019-06-25  Tom Tromey  <tom@tromey.com>
8500
8501         * tui/tui-win.c (tui_resize_all): Use delete.
8502         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8503         destructor.
8504         (tui_free_window): Don't declare.
8505         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8506         Update.
8507
8508 2019-06-25  Tom Tromey  <tom@tromey.com>
8509
8510         * tui/tui-data.h (struct tui_win_info): Add constructor.
8511         * tui/tui-data.c (tui_alloc_win_info): Use new.
8512         (tui_free_window): Use delete.
8513
8514 2019-06-22  Tom Tromey  <tom@tromey.com>
8515
8516         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8517         declare.
8518         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8519
8520 2019-06-22  Tom Tromey  <tom@tromey.com>
8521
8522         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8523         declare.
8524         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8525
8526 2019-06-22  Tom de Vries  <tdevries@suse.de>
8527
8528         * dwarf2read.c (create_addrmap_from_aranges)
8529         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8530         instead of '%zu'.
8531
8532 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
8533
8534         * dwarf2read.h (dwarf2_section_info_def): Remove.
8535         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8536         * dwarf2read.c (struct dwo_sections) <types>: Change type to
8537         std::vector<dwarf2_section_info>.
8538         (struct dwo_file) <~dwo_file>: Remove.
8539         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8540         types field.
8541         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8542         (dwarf2_read_debug_names): Likewise.
8543         (create_debug_types_hash_table): Change parameter type to
8544         array_view, adjust code accordingly.
8545         (dwarf2_locate_dwo_sections): Adjust to std::vector.
8546         (partial_die_info::fixup): Likewise.
8547         (determine_prefix): Likewise.
8548         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8549
8550 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8551
8552         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8553         gdb_bfd_ref_ptr.
8554         <~dwo_file>: Remove call to gdb_bfd_unref.
8555         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8556         gdb_bfd_ref_ptr::get.
8557
8558 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8559
8560         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8561         type to htab_up.
8562         * dwarf2read.c (struct dwo_file): Initialize fields.
8563         <~dwo_file>: New.
8564         (free_dwo_file): Remove, move content to ~dwo_file.
8565         (struct dwo_file_deleter): Remove.
8566         (dwo_file_up>: Remove custom deleter.
8567         (free_dwo_files): Remove.
8568         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8569         dwo_files.
8570         (process_skeletonless_type_units): Call unique_ptr::get.
8571         (allocate_dwo_file_hash_table): Add deleter to created hash
8572         table.  Change return type to htab_up.
8573         (lookup_dwo_file_slot): Don't memset dwo_file, call
8574         unique_ptr::get.
8575         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8576         (create_dwo_unit_in_dwp_v2): Likewise.
8577         (open_and_init_dwo_file): Likewise.
8578         (free_dwo_file_from_slot): Remove.
8579
8580 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8581
8582         * dwarf2read.h (struct dwarf2_section_info) <readin,
8583         is_virtual>: Change type to bool.
8584         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8585         true instead of 1.
8586
8587 2019-06-19  Tom Tromey  <tom@tromey.com>
8588
8589         * tui/tui-data.h (tui_init_content_element): Don't declare.
8590
8591 2019-06-19  Tom Tromey  <tom@tromey.com>
8592
8593         * tui/tui-data.h (tui_init_win_info): Don't declare.
8594
8595 2019-06-19  Tom de Vries  <tdevries@suse.de>
8596
8597         * dwarf2read.h (abstract_to_concrete): Change type to
8598         std::unordered_map<sect_offset, std::vector<sect_offset>,
8599         gdb::hash_enum<sect_offset>>.
8600
8601 2019-06-19  Tom Tromey  <tromey@adacore.com>
8602
8603         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8604         EVAL_AVOID_SIDE_EFFECTS specially.
8605
8606 2019-06-19  Tom Tromey  <tromey@adacore.com>
8607
8608         * source-cache.c (highlighter): New global.
8609         (source_cache::get_source_lines): Create a highlighter on demand.
8610
8611 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8612
8613         * defs.h (deprecated_interactive_hook): Delete declaration.
8614         * interps.c (clear_interpreter_hooks): Remove use of
8615         deprecated_interactive_hook.
8616         * top.c (deprecated_interactive_hook): Delete definition.
8617         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8618
8619 2019-06-18  Tom de Vries  <tdevries@suse.de>
8620
8621         PR gdb/24515
8622         * dwarf2read.h (abstract_to_concrete): Change type from
8623         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8624         std::unordered_map<sect_offset, std::vector<sect_offset>>.
8625         * dwarf2read.c (read_variable): Update.
8626         (dwarf2_fetch_die_loc_sect_off): Update.
8627
8628 2019-06-17  Tom de Vries  <tdevries@suse.de>
8629
8630         PR gdb/24617
8631         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8632         accessing parent[parent_len - 1].
8633
8634 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
8635
8636         PR gdb/24364
8637         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8638         call dtrace_process_dof with NULL dof.
8639
8640 2019-06-16  Tom de Vries  <tdevries@suse.de>
8641
8642         PR gdb/24445
8643         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8644
8645 2019-06-16  Tom Tromey  <tom@tromey.com>
8646
8647         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8648         (make_all_visible): Use address of member.
8649
8650 2019-06-16  Tom Tromey  <tom@tromey.com>
8651
8652         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8653         (tui_free_window, free_content, free_content_elements): Remove
8654         unnecessary cast.
8655         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8656         cast.
8657         * tui/tui-regs.c (tui_show_register_group)
8658         (tui_display_registers_from, tui_display_reg_element_at_line):
8659         Remove unnecessary cast.
8660
8661 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
8662
8663         * linux-nat.c (normal_mask): Delete.
8664         (_initialize_linux_nat): Don't initialise normal_mask.
8665
8666 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
8667
8668         PR gdb/24445
8669         * dwarf-index-write.h (write_psymtabs_to_index): Add
8670         dwz_basename parameter.
8671         * dwarf-index-write.c (write_gdbindex): Move file writing to
8672         write_gdbindex_1.  Change return type void.
8673         (assert_file_size): Move up, remove filename parameter.
8674         (write_gdbindex_1): New function.
8675         (write_debug_names): Change return type to void, call
8676         assert_file_size.
8677         (struct index_wip_file): New struct.
8678         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
8679         file logic to index_wip_file.  Write index for dwz file if
8680         needed.
8681         (save_gdb_index_command): Pass basename of dwz file, if present.
8682         * dwarf-index-cache.c (index_cache::store): Obtain and pass
8683         build-id of dwz file, if present.
8684         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8685         (dwarf2_get_dwz_file): Likewise.
8686         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8687         (dwarf2_get_dwz_file): Likewise.
8688
8689 2019-06-16  Tom Tromey  <tom@tromey.com>
8690
8691         * coffread.c (process_coff_symbol): Use xstrdup.
8692         * value.c (create_internalvar): Use xstrdup.
8693
8694 2019-06-16  Tom Tromey  <tom@tromey.com>
8695
8696         * valops.c (value_cast, value_slice): Remove unnecessary cast.
8697         * breakpoint.c (stopin_command, stopat_command)
8698         (until_break_command, decode_location_default): Remove unnecessary
8699         cast.
8700         * utils.c (subset_compare): Remove unnecessary cast.
8701         * ada-lang.c (ada_update_initial_language): Remove unnecessary
8702         cast.
8703         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8704         cast.
8705         * infcmd.c (path_command): Remove unnecessary cast.
8706         * coffread.c (decode_type): Remove unnecessary cast.
8707         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8708         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8709         * tui/tui-stack.c (tui_show_locator_content)
8710         (tui_show_frame_info): Remove unnecessary cast.
8711         * tui/tui-win.c (tui_scroll_forward_command)
8712         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8713         (parse_scrolling_args): Remove unnecessary cast.
8714         * tui/tui-data.c (init_win_info, tui_del_window)
8715         (tui_free_window, tui_del_data_windows, tui_free_data_content)
8716         (free_content_elements): Remove unnecessary cast.
8717         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8718         unnecessary cast.
8719         * tui/tui-source.c (tui_set_source_content)
8720         (tui_vertical_source_scroll): Remove unnecessary cast.
8721         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8722         cast.
8723         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8724         * tui/tui-regs.c (tui_display_registers_from)
8725         (tui_display_register): Remove unnecessary cast.
8726         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8727         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8728         (make_visible): Remove unnecessary cast.
8729         * tui/tui-winsource.c (tui_erase_source_content)
8730         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8731         unnecessary cast.
8732         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8733         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8734         * stabsread.c (read_type, read_array_type, read_range_type):
8735         Remove unnecessary cast.
8736         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8737         (parse_symbol, parse_type, upgrade_type, parse_external)
8738         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8739         unnecessary cast.
8740         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8741
8742 2019-06-16  Tom Tromey  <tom@tromey.com>
8743
8744         * tui/tui-data.c (tui_alloc_generic_win_info)
8745         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8746         checks.
8747
8748 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
8749             Andrew Burgess  <andrew.burgess@embecosm.com>
8750
8751         * f-typeprint.c (f_print_type): Don't return early for not
8752         associated or not allocated types.
8753         (f_type_print_varspec_suffix): Add print_rank parameter and print
8754         ranks of array types in case they dangling.
8755         (f_type_print_base): Add print_rank parameter.
8756
8757 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8758
8759         * NEWS: Mention new MI commands.
8760         * break-catch-throw.c (enum exception_event_kind): Move to
8761         breakpoint.h.
8762         (print_mention_exception_catchpoint): Output text as a single
8763         message.
8764         (catch_exception_command_1): Rename to...
8765         (catch_exception_event): ...this, make non-static, update header
8766         command, and change some parameter types.
8767         (catch_catch_command): Update for changes to
8768         catch_exception_command_1.
8769         (catch_throw_command): Likewise.
8770         (catch_rethrow_command): Likewise.
8771         * breakpoint.c (enum exception_event_kind): Delete.
8772         * breakpoint.h (enum exception_event_kind): Moved here from
8773         break-catch-throw.c.
8774         (catch_exception_event): Declare.
8775         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8776         (mi_cmd_catch_throw): New function.
8777         (mi_cmd_catch_rethrow): New function.
8778         (mi_cmd_catch_catch): New function.
8779         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8780         'catch-catch' entries.
8781         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8782         (mi_cmd_catch_rethrow): Declare.
8783         (mi_cmd_catch_catch): Declare.
8784
8785 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8786
8787         * annotate.c (annotate_source_line): Change return type to void,
8788         update implementation to match.
8789         * annotate.h (annotate_source_line): Change return type to void,
8790         update header comment.
8791         * stack.c (print_frame_info): Don't change what frame information
8792         is printed based on whether annotations are on or not.
8793
8794 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8795
8796         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8797         (annotate_source): Make static.
8798         (annotate_source_line): Moved from source.c and renamed from
8799         identify_source_line.  Update the return type.
8800         * annotate.h (annotate_source): Delete declaration.
8801         (annotate_source_line): Declaration moved from source.h, and
8802         renamed from identify_source_line.  Return type updated.
8803         * source.c (identify_source_line): Moved to annotate.c and renamed
8804         to annotate_source_line.
8805         (info_line_command): Remove check of annotation_level.
8806         * source.h (identify_source_line): Move declaration to annotate.h
8807         and rename to annotate_source_line.
8808         * stack.c: Add 'annotate.h' include.
8809         (print_frame_info): Remove check of annotation_level before
8810         calling annotate_source_line.
8811
8812 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8813
8814         * source-cache.c (source_cache::get_plain_source_lines): Use
8815         open_source_file_with_line_charpos instead of just
8816         open_source_file, remove call to find_source_lines.
8817         (source_cache::get_source_lines): Likewise.
8818         * source.c (find_source_lines): Make static.
8819         (get_filename_and_charpos): Renamed into...
8820         (open_source_file_with_line_charpos): ..this along with changes to
8821         return a scoped_fd, and some other minor clean ups.
8822         (identify_source_line): Use open_source_file_with_line_charpos.
8823         (search_command_helper): Use open_source_file_with_line_charpos
8824         instead of just open_source_file, remove call to
8825         find_source_lines.
8826         * source.h (open_source_file_with_line_charpos): Declare new
8827         function.
8828         (find_source_lines): Delete declaration.
8829
8830 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8831
8832         * source.c (get_filename_and_charpos): Remove fullname
8833         parameter.
8834         (identify_source_line): Update call to get_filename_and_charpos.
8835
8836 2019-06-14  Tom Tromey  <tromey@adacore.com>
8837
8838         PR gdb/24502:
8839         * ui-style.h (skip_ansi_escape): Update comment.
8840         * ui-file.h (class no_terminal_escape_file): New class.
8841         * ui-file.c (no_terminal_escape_file::write)
8842         (no_terminal_escape_file::puts): New methods.
8843         * cli/cli-logging.c (handle_redirections): Use
8844         no_terminal_escape_file.
8845
8846 2019-06-14  Tom Tromey  <tromey@adacore.com>
8847
8848         * NEWS: Move convenience variable news above Python news.
8849
8850 2019-06-14  Tom Tromey  <tom@tromey.com>
8851
8852         * gnulib: Move directory to top-level.
8853         * configure.ac: Don't configure gnulib.
8854         * configure: Rebuild.
8855         * common/common-defs.h: Use new path to gnulib.
8856         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8857         (GNULIB_H): Remove.
8858         (INCGNU): Look in new gnulib location.
8859         (HFILES_NO_SRCDIR): Remove gnulib files.
8860         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8861         (generated_files): Remove GNULIB_H.
8862         ($(LIBGNU), all-lib): Remove targets.
8863         (distclean): Don't mention GNULIB_BUILDDIR.
8864         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8865
8866 2019-06-14  Tom Tromey  <tromey@adacore.com>
8867
8868         * symfile.c (add_symbol_file_command): Remove obsolete comment.
8869         Warn if symbol file does not provide any symbols.
8870
8871 2019-06-14  Tom Tromey  <tromey@adacore.com>
8872
8873         * source.c (find_and_open_source): Respect basenames_may_differ.
8874
8875 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
8876
8877         * annotate.c (annotate_breakpoints_invalid): Make use of
8878         scoped_restore_terminal_state.
8879         (annotate_frames_invalid): Likewise.
8880
8881 2019-06-14  Tom Tromey  <tromey@adacore.com>
8882
8883         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8884         allow assignment to an internalvar.
8885
8886 2019-06-14  Tom Tromey  <tromey@adacore.com>
8887
8888         * ada-lex.l: Allow "_" in attribute names.
8889
8890 2019-06-14  Tom Tromey  <tromey@adacore.com>
8891
8892         PR gdb/24653:
8893         * regcache.c (registers_changed): Don't call alloca.
8894         * top.c (execute_command): Don't call alloca.
8895
8896 2019-06-13  Pedro Alves  <palves@redhat.com>
8897
8898         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8899         'expression'.  When parsing an expression, error out if there's
8900         junk after "unlimited".
8901         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8902         (do_set_command): Adjust calls to is_unlimited_literal.
8903
8904 2019-06-13  Pedro Alves  <palves@redhat.com>
8905
8906         * compile/compile.c (make_compile_options_def_group): Add braces
8907         around array_view initializer.
8908         * thread.c (make_thread_apply_all_options_def_group)
8909         (make_thread_apply_all_options_def_group): Likewise.
8910
8911 2019-06-13  Pedro Alves  <palves@redhat.com>
8912
8913         * NEWS (New commands): Mention "maint test-options
8914         require-delimiter", "maint test-options unknown-is-error", "maint
8915         test-options unknown-is-operand" and "maint show
8916         test-options-completion-result".
8917         (New command options, command completion): New section.
8918         (Completion improvements): New section.
8919         Mention that you can abbreviate "unlimited".
8920
8921 2019-06-13  Pedro Alves  <palves@redhat.com>
8922
8923         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8924         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8925         * unittests/cli-utils-selftests.c (test_parse_flags)
8926         (test_parse_flags_qcs): Delete.
8927         (test_cli_utils): Don't call deleted functions.
8928
8929 2019-06-13  Pedro Alves  <palves@redhat.com>
8930
8931         * thread.c: Include "cli/cli-option.h".
8932         (tp_array_compar_ascending): Global.
8933         (tp_array_compar): Delete function.
8934         (tp_array_compar_ascending, tp_array_compar_descending): New
8935         functions.
8936         (ascending_option_def, qcs_flag_option_def)
8937         (thr_qcs_flags_option_defs)
8938         (make_thread_apply_all_options_def_group)
8939         (make_thread_apply_options_def_group): New.
8940         (thread_apply_all_command): Use gdb::option::process_options.
8941         (thread_apply_command_completer)
8942         (thread_apply_all_command_completer): New.
8943         (thread_apply_command): Use gdb::option::process_options.
8944         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
8945         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
8946         to generate help text of "thread apply".  Adjust "taas"'s help.
8947         * tid-parse.c (tid_range_parser::in_thread_range): New method.
8948         * tid-parse.h (tid_range_parser::in_thread_range): New method.
8949
8950 2019-06-13  Pedro Alves  <palves@redhat.com>
8951
8952         * thread.c (thread_apply_command): Check for invalid TID with
8953         isdigit instead of !isalpha.
8954
8955 2019-06-13  Pedro Alves  <palves@redhat.com>
8956
8957         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
8958         (validate_flags_qcs): New.
8959         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
8960         (validate_flags_qcs): Declare.
8961         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
8962         (make_frame_apply_options_def_group): New.
8963         (frame_apply_command_count): Process options with
8964         gdb::option::process_options.
8965         (frame_apply_completer): New.
8966         (frame_apply_level_completer, frame_apply_all_completer)
8967         (frame_apply_completer): New.
8968         (_initialize_stack): Update help of "frame apply", "frame apply
8969         level", "frame apply all" and "faas" to mention supported options
8970         and install command completers.
8971         * stack.h (frame_apply_all_completer): Declare.
8972         * thread.c: Include "stack.h".
8973         (tfaas_command): Add "--".
8974         (_initialize_thread): Update help "tfaas" to mention supported
8975         options and install command completer.
8976
8977 2019-06-13  Pedro Alves  <palves@redhat.com>
8978
8979         * completer.c (complete_nested_command_line): New.
8980         (gdb_completion_word_break_characters_throw): Add assertion.
8981         * completer.h (complete_nested_command_line): Declare.
8982
8983 2019-06-13  Pedro Alves  <palves@redhat.com>
8984
8985         * stack.c (parse_backtrace_qualifiers): New.
8986         (backtrace_command): Use it.
8987         (backtrace_command_completer): Complete on qualifiers.
8988
8989 2019-06-13  Pedro Alves  <palves@redhat.com>
8990
8991         * frame.c: Include "cli/cli-option.h.
8992         (user_set_backtrace_options): New.
8993         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
8994         Delete.
8995         (get_prev_frame): Adjust.
8996         (boolean_option_def, uinteger_option_def)
8997         (set_backtrace_option_defs): New.
8998         (_initialize_frame): Adjust and use
8999         gdb::option::add_setshow_cmds_for_options to install "set
9000         backtrace past-main" and "set backtrace past-entry".
9001         * frame.h: Include "cli/cli-option.h".
9002         (struct frame_print_options): Forward declare.
9003         (print_frame_arguments_all, print_frame_arguments_scalars)
9004         (print_frame_arguments_none): Declare.
9005         (print_entry_values): Delete declaration.
9006         (struct frame_print_options, user_frame_print_options): New.
9007         (struct set_backtrace_options): New.
9008         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9009         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9010         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9011         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9012         (list_args_or_locals): Add frame_print_options parameter.
9013         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9014         * python/py-framefilter.c (enumerate_args): Pass down
9015         USER_FRAME_PRINT_OPTIONS.
9016         * stack.c: Include "cli/cli-option.h".
9017         (print_frame_arguments_all, print_frame_arguments_scalars)
9018         (print_frame_arguments_none): Declare.
9019         (print_raw_frame_arguments, print_entry_values): Delete.
9020         (user_frame_print_options): New.
9021         (boolean_option_def, enum_option_def, frame_print_option_defs):
9022         New.
9023         (struct backtrace_cmd_options): New.
9024         (bt_flag_option_def): New.
9025         (backtrace_command_option_defs): New.
9026         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9027         (print_frame_arg, read_frame_arg, print_frame_args)
9028         (print_frame_info, print_frame): Add frame_print_options parameter
9029         and use it.
9030         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9031         (backtrace_command_1): Add frame_print_options and
9032         backtrace_cmd_options parameters and use them.
9033         (make_backtrace_options_def_group): New.
9034         (backtrace_command): Process command options with
9035         gdb::option::process_options.
9036         (backtrace_command_completer): New.
9037         (_initialize_stack): Extend "backtrace"'s help to mention
9038         supported options.  Install completer for "backtrace".
9039         Install some settings commands with add_setshow_cmds_for_options.
9040
9041 2019-06-13  Pedro Alves  <palves@redhat.com>
9042
9043         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9044         and that "set/show print raw frame-arguments" are now deprecated.
9045
9046         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9047         command.
9048         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9049         * stack.c (_initialize_stack): Install "set/show print
9050         raw-frame-arguments", and deprecate "set/show print raw
9051         frame-arguments".
9052         * valprint.c (_initialize_valprint): Deprecate "set/show print
9053         raw".
9054
9055 2019-06-13  Pedro Alves  <palves@redhat.com>
9056
9057         * compile/compile.c (struct compile_options): New.
9058         (compile_flag_option_def, compile_command_option_defs)
9059         (make_compile_options_def_group): New.
9060         (compile_file_command): Handle options with
9061         gdb::option::process_options.
9062         (compile_file_command_completer): New function.
9063         (compile_code_command): Handle options with
9064         gdb::option::process_options.
9065         (compile_code_command_completer): New function.
9066         (_initialize_compiler): Install completers for "compile code" and
9067         "compile file".  Mention available options in "compile code" and
9068         "compile code"'s help.
9069         * completer.c (advance_to_completion_word): New, factored out from
9070         ...
9071         (advance_to_expression_complete_word_point): ... this.
9072         (advance_to_filename_complete_word_point): New.
9073         * completer.h (advance_to_filename_complete_word_point): New
9074         declaration.
9075
9076 2019-06-13  Pedro Alves  <palves@redhat.com>
9077
9078         * compile/compile.c: Include "cli/cli-option.h".
9079         (compile_print_value): Scope data pointer is now a
9080         value_print_options pointer; adjust.
9081         (compile_print_command): Process options.  Scope data pointer is
9082         now a value_print_options pointer; adjust.
9083         (_initialize_compile): Update "compile print"'s help to include
9084         supported options.  Install a completer for "compile print".
9085         * cp-valprint.c (show_vtblprint, show_objectprint)
9086         (show_static_field_print): Delete.
9087         (_initialize_cp_valprint): Don't install "set print
9088         static-members", "set print vtbl", "set print object" here.
9089         * printcmd.c: Include "cli/cli-option.h" and
9090         "common/gdb_optional.h".
9091         (print_command_parse_format): Rework to fill in a
9092         value_print_options instead of a format_data.
9093         (print_value): Change parameter type from format_data pointer to
9094         value_print_options reference.  Adjust.
9095         (print_command_1): Process options.  Adjust to pass down a
9096         value_print_options.
9097         (print_command_completer): New.
9098         (_initialize_printcmd): Install print_command_completer as
9099         handle_brkchars completer for the "print" command.  Update
9100         "print"'s help to include supported options.
9101         * valprint.c: Include "cli/cli-option.h".
9102         (show_vtblprint, show_objectprint, show_static_field_print): Moved
9103         here from cp-valprint.c.
9104         (boolean_option_def, uinteger_option_def)
9105         (value_print_option_defs, make_value_print_options_def_group):
9106         New.  Use gdb::option::add_setshow_cmds_for_options to install
9107         "set print elements", "set print null-stop", "set print repeats",
9108         "set print pretty", "set print union", "set print array", "set
9109         print address", "set print symbol", "set print array-indexes".
9110         * valprint.h: Include <string> and "cli/cli-option.h".
9111         (make_value_print_options_def_group): Declare.
9112         (print_value): Change parameter type from format_data pointer to
9113         value_print_options reference.
9114         (print_command_completer): Declare.
9115
9116 2019-06-13  Pedro Alves  <palves@redhat.com>
9117
9118         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9119         (COMMON_SFILES): Add maint-test-settings.c.
9120         * cli/cli-decode.c (boolean_enums): New global, factored out from
9121         ...
9122         (add_setshow_boolean_cmd): ... here.
9123         * cli/cli-decode.h (boolean_enums): Declare.
9124         * cli/cli-option.c: New file.
9125         * cli/cli-option.h: New file.
9126         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9127         factored out from ...
9128         (parse_cli_boolean_value(const char *)): ... this.
9129         (is_unlimited_literal): Change parameter type to pointer to
9130         pointer.  Adjust and advance ARG pointer.
9131         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9132         (parse_cli_var_enum): New, factored out from ...
9133         (do_set_command): ... this.  Adjust.
9134         * cli/cli-setshow.h (parse_cli_boolean_value)
9135         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9136         (parse_cli_var_enum): Declare.
9137         * cli/cli-utils.c: Include "cli/cli-option.h".
9138         (get_ulongest): New.
9139         * cli/cli-utils.h (get_ulongest): Declare.
9140         (check_for_argument): New overloads.
9141         * maint-test-options.c: New file.
9142
9143 2019-06-13  Pedro Alves  <palves@redhat.com>
9144
9145         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9146         parse a range if "-" is at the end of the string.
9147
9148 2019-06-13  Pedro Alves  <palves@redhat.com>
9149
9150         * cli/cli-setshow.c (parse_auto_binary_operation)
9151         (parse_cli_boolean_value): Don't allow "o".
9152
9153 2019-06-13  Pedro Alves  <palves@redhat.com>
9154
9155         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9156         * NEWS: Mention maint test-settings KIND.
9157         * maint-test-settings.c: New file.
9158
9159 2019-06-13  Pedro Alves  <palves@redhat.com>
9160
9161         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9162         completer.
9163         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9164         "set" completers.
9165
9166 2019-06-13  Pedro Alves  <palves@redhat.com>
9167
9168         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9169         after item.
9170
9171 2019-06-13  Pedro Alves  <palves@redhat.com>
9172
9173         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9174
9175 2019-06-13  Pedro Alves <palves@redhat.com>
9176
9177         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9178         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9179         call.
9180         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9181         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9182         calls.
9183         (check_for_argument): Skip spaces after argument.
9184
9185 2019-06-13  Pedro Alves  <palves@redhat.com>
9186
9187         * thread.c (thread_apply_command): Adjust TID parsing.
9188         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9189         detected before end of string.
9190         (tid_is_in_list): Error out if LIST is invalid.
9191
9192 2019-06-13  Pedro Alves  <palves@redhat.com>
9193
9194         * completer.c (complete_line_internal_1): Rewind completion word
9195         point.
9196         (completion_tracker::advance_custom_word_point_by): Change
9197         parameter type to int.
9198         * completer.h (completion_tracker::advance_custom_word_point_by):
9199         Likewise.
9200
9201 2019-06-13  Pedro Alves  <palves@redhat.com>
9202
9203         * completer.c (advance_to_completion_word): Handle delimiters.
9204
9205 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
9206
9207         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9208
9209 2019-06-11  Tom Tromey  <tom@tromey.com>
9210
9211         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9212         (xmalloc_failed): Move to alloc.c.
9213         * alloc.c: New file.
9214         * Makefile.in (COMMON_SFILES): Add alloc.c.
9215
9216 2019-06-11  Tom Tromey  <tom@tromey.com>
9217
9218         * nat/linux-waitpid.c: Don't include server.h.
9219         (linux_debug): Remove.
9220         (my_waitpid): Update.
9221
9222 2019-06-11  Tom Tromey  <tromey@adacore.com>
9223
9224         * infcall.c (_initialize_infcall): Remove trailing newline from
9225         help.
9226         * user-regs.c (_initialize_user_regs): Remove trailing newline
9227         from help.
9228         * typeprint.c (_initialize_typeprint): Remove trailing newline
9229         from help.
9230         * reverse.c (_initialize_reverse): Remove trailing newlines from
9231         help.
9232         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9233         from help.
9234         * language.c (add_set_language_command): Remove trailing newline
9235         from help.
9236         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9237         help.
9238         * disasm.c (_initialize_disasm): Remove trailing newline from
9239         help.
9240         * top.c (init_main): Remove trailing newline from help.
9241         * interps.c (_initialize_interpreter): Remove trailing newline
9242         from help.
9243         * btrace.c (_initialize_btrace): Remove trailing newlines from
9244         help.
9245         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9246         from help.
9247         * python/python.c (_initialize_python): Remove trailing newline
9248         from help.
9249         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9250         help.
9251         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9252         from help.  Reformat some text.
9253         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9254         from help.
9255         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9256         newline from help.
9257
9258 2019-06-11  Tom Tromey  <tromey@adacore.com>
9259
9260         * darwin-nat.c (darwin_decode_exception_message)
9261         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9262
9263 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9264
9265         * valops.c (value_slice): Check for not allocated or not
9266         associated values.
9267
9268 2019-06-10  Tom de Vries  <tdevries@suse.de>
9269
9270         PR gdb/24618
9271         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9272         sure an empty slot (defined by a 32-bit zero pair) is recognized as
9273         invalid.
9274
9275 2019-06-10  Tom de Vries  <tdevries@suse.de>
9276
9277         PR gdb/24611
9278         * linespec.c (linespec_lexer_lex_string): Remove incorrect
9279         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
9280
9281 2019-06-10  Tom de Vries  <tdevries@suse.de>
9282
9283         PR symtab/24545
9284         * symtab.c (struct demangled_name_entry): Add language field.
9285         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
9286         static minimal symbol".  Set and use language field.
9287
9288 2019-06-10  Tom Tromey  <tromey@adacore.com>
9289
9290         * ada-lang.c (_initialize_ada_language): Update help text.
9291
9292 2019-06-10  Tom Tromey  <tromey@adacore.com>
9293
9294         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9295         with a newline.
9296         * guile/guile.c (handle_boot_error): Don't end warning with a
9297         newline.
9298         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9299         warning with a newline.
9300         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9301         newline.
9302         (s12z_frame_cache): Likewise.
9303         * dwarf-index-cache.c (index_cache::store): Don't end warning with
9304         a newline.
9305         * solib-svr4.c (disable_probes_interface): Don't end warning with
9306         a newline.
9307         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9308         newline.
9309         * python/python.c (do_finish_initialization): Don't end warning
9310         with a newline.
9311
9312 2019-06-10  Tom Tromey  <tom@tromey.com>
9313
9314         * python/py-breakpoint.c (gdbpy_breakpoint_created)
9315         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9316         gdbpy_enter.
9317
9318 2019-06-10  Tom Tromey  <tromey@adacore.com>
9319
9320         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9321         data.
9322         (elf_new_init): Don't call stabsread_new_init.
9323         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9324         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
9325         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9326
9327 2019-06-10  Tom de Vries  <tdevries@suse.de>
9328
9329         PR symtab/16264
9330         PR symtab/24517
9331         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9332
9333 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
9334
9335         * source.c (find_and_open_source): Also rewrite relative file
9336         names.
9337
9338 2019-04-26  Amos Bird  <amosbird@gmail.com>
9339
9340         * annotate.c (annotate_thread_exited): Add "thread-exited"
9341         annotation.
9342
9343 2019-06-06  Tom Tromey  <tromey@adacore.com>
9344
9345         * maint.h (class scoped_command_stats): Use
9346         DISABLE_COPY_AND_ASSIGN.
9347         <print_time>: New method.
9348         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9349         print_time.
9350         (scoped_command_stats::print_time): New method.
9351
9352 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
9353
9354         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9355         instructions of lengths 6 or 8 bytes.
9356
9357 2019-06-04  Pedro Alves  <palves@redhat.com>
9358
9359         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9360
9361         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9362         * breakpoint.c (condition_completer): Likewise.
9363         * cli/cli-dump.c (scan_expression): Likewise.
9364         * common/filestuff.c (mkdir_recursive): Likewise.
9365         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9366         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9367         (gdb_abspath): Likewise.
9368         * compile/compile-cplus-types.c
9369         (compile_cplus_instance::decl_name): Likewise.
9370         * completer.c (complete_explicit_location):
9371         (signal_completer, reg_or_group_completer_1): Likewise.
9372         * cp-support.c (cp_remove_params_if_any): Likewise.
9373         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9374         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9375         * infcmd.c (strip_bg_char): Likewise.
9376         * linespec.c (copy_token_string): Likewise.
9377         * mi/mi-main.c (output_cores): Likewise.
9378         * psymtab.c (psymtab_search_name):
9379         * symfile.c (test_set_ext_lang_command): Likewise.
9380         * target.c (target_fileio_read_stralloc): Likewise.
9381         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9382         * value.c (complete_internalvar): Likewise.
9383
9384 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
9385
9386         Add objfile property to gdb.Type.
9387         * NEWS: Mention Python API addition.
9388         * python/py-type.c (typy_get_objfile): New method.
9389
9390 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9391
9392         * NEWS: Mention the new set|show style [title|highlight].
9393         Mention changes to "show style", "help" and "apropos".
9394
9395 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9396
9397         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9398         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
9399         instead of print_help_for_command.
9400         (print_doc_of_command): New function.
9401         (help_list): Add 'apropos -v word' suggestion.
9402         (print_help_for_command): Style the command name using title style.
9403         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9404         (_initialize_cli_cmds): Describe -v in apropos_command help.
9405
9406 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9407
9408         * cli/cli-style.h (cli_style_option): Add name in constructor,
9409         add m_name class member, add constructor with intensity,
9410         add name class function.
9411         (cli_style_option::add_setshow_commands): Remove name argument.
9412         (highlight_style, title_style): New styles.
9413         * cli/cli-style.c (do_show): New function that shows a style
9414         characteristic styling the style name with itself.
9415         (set_style_name): New function.
9416         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9417         Update all callers according to the changes in cli/cli-style.h.
9418         * utils.h (fputs_highlighted): New function.
9419         * utils.c (fputs_highlighted): Likewise.
9420
9421 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9422
9423         * NEWS: Mention new pipe command and new convenience variables.
9424
9425 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9426
9427         * cli/cli-cmds.c (pipe_command): New function.
9428         (_initialize_cli_cmds): Call add_com for pipe_command.
9429         Define | as an alias for pipe.
9430         (exit_status_set_internal_vars): New function.
9431         (shell_escape): Call exit_status_set_internal_vars.
9432         cli/cli-decode.c (find_command_name_length): Recognize | as
9433         a single character command.
9434
9435 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9436
9437         * gdbcmd.h (execute_command_to_ui_file): New declaration.
9438         top.c (execute_command_to_ui_file): New function, mostly a copy
9439         of execute_command_to_string.
9440         (execute_command_to_string): Implement by calling
9441         execute_command_to_ui_file.
9442
9443 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9444
9445         * top.h (saved_command_line): Remove declaration.
9446         * top.c (previous_saved_command_line, previous_repeat_arguments):
9447         New variables.
9448         (saved_command_line): Make static, define together with other
9449         'repeat variables'.
9450         (dont_repeat): Clear repeat_arguments.
9451         (repeat_previous, get_saved_command_line, save_command_line):
9452         New functions.
9453         (gdb_init): Initialize saved_command_line
9454         and previous_saved_command_line.
9455         * main.c (captured_main_1): Remove saved_command_line initialization.
9456         * event-top.c (handle_line_of_input): Update to use
9457         the new 'repeat' related functions instead of direct access to
9458         saved_command_line.
9459         * command.h (repeat_previous, get_saved_command_line,
9460         save_command_line): New declarations.
9461         (dont_repeat): Add comment.
9462
9463 2019-05-30  Tom Tromey  <tromey@adacore.com>
9464
9465         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9466         Fix comment.
9467         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9468
9469 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
9470
9471         PR cli/24587
9472         * completer.c (complete): Initialize variable word.
9473
9474 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
9475
9476         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9477         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9478         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9479         'body' is NULL to the outter 'if', protecting the '!is_define'
9480         situation as well.
9481
9482 2019-05-29  Tom Tromey  <tromey@adacore.com>
9483
9484         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9485         (dwarf_unknown): New function.
9486         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9487         (dwarf_type_encoding_name): Use dwarf_unknown.
9488
9489 2019-05-29  Tom Tromey  <tromey@adacore.com>
9490
9491         PR c++/20020:
9492         * cp-valprint.c (cp_print_value_fields): Call
9493         cp_print_static_field inside "try".
9494
9495 2019-05-29  Tom Tromey  <tromey@adacore.com>
9496
9497         * inflow.c (struct terminal_info): Add default operator=.
9498         * configure: Rebuild.
9499         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9500         -Wdeprecated-copy-dtor, -Wredundant-move.
9501
9502 2019-05-29  Tom Tromey  <tromey@adacore.com>
9503
9504         * NEWS: Add entry.
9505         * infcmd.c (print_return_value_1): Handle finish_print
9506         option.
9507         (show_print_finish): New function.
9508         (_initialize_infcmd): Add "set/show print finish" commands.
9509         * valprint.c (user_print_options): Initialize new member.
9510         * valprint.h (struct value_print_options) <finish_print>: New
9511         member.
9512
9513 2019-05-28  Tom Tromey  <tromey@adacore.com>
9514
9515         * ada-lang.c (ada_remove_Xbn_suffix)
9516         (find_old_style_renaming_symbol)
9517         (parse_old_style_renaming): Remove.
9518         (ada_find_renaming_symbol): Don't call
9519         find_old_style_renaming_symbol.
9520         (ada_is_renaming_symbol): Rename from
9521         ada_find_renaming_symbol.  Remove "block" parameter.  Return
9522         bool.  Now static.
9523         (ada_read_var_value): Update and simplify.
9524         * ada-exp.y (write_var_or_type): Remove old code.
9525
9526 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
9527
9528         PR gdb/25010
9529         * event-top.c: Remove include comment.
9530         * inflow.c (class scoped_ignore_sigttou): Move from here...
9531         * inflow.h (class scoped_ignore_sigttou): ...to here.
9532         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9533         * top.c:  Remove include comment.
9534
9535 2019-05-27  Tom Tromey  <tom@tromey.com>
9536
9537         * NEWS: Fix typo.
9538
9539 2019-05-22  Tom Tromey  <tromey@adacore.com>
9540
9541         * target.c (target_follow_exec): Constify parameter.
9542         * target-delegates.c: Rebuild.
9543         * remote.c (remote_target::follow_exec): Constify parameter.
9544         * infrun.c (follow_exec): Constify parameter.
9545         * target.h (struct target_ops) <follow_exec>: Constify parameter.
9546         (target_follow_exec): Likewise.
9547
9548 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9549
9550         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9551         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9552
9553 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9554
9555         * NEWS: Add debugredirect and testsuite sections.
9556
9557 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
9558
9559         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9560         target descriptions using exclusively floating point register name
9561         aliases.
9562
9563 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
9564
9565         PR gdb/18644:
9566         * f-lang.c (build_fortran_types): Handle the case where
9567         gdbarch_floatformat_for_type returns a nullptr.
9568
9569 2019-05-21  Tom de Vries  <tdevries@suse.de>
9570
9571         PR cli/24587
9572         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9573
9574 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9575
9576         PR gdb/18644:
9577         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9578         16-byte floats.
9579         * i386-tdep.c (i386_floatformat_for_type): Use
9580         floatformats_ia64_quad for the 16-byte floating point component
9581         within a fortran 32-byte complex number.
9582
9583 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9584
9585         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9586         delete default constructor.
9587         (find_partial_die): Update to return const struct.
9588         (partial_die_parent_scope): Move variable declaration into scope
9589         of its use and change its type to auto.
9590         (guess_partial_die_structure_name): Likewise.
9591         (partial_die_info::fixup): Likewise.
9592
9593 2019-05-17  Tom Tromey  <tromey@adacore.com>
9594
9595         * source.c (find_and_open_source): Remove cast.
9596
9597 2019-05-17  Tom Tromey  <tromey@adacore.com>
9598
9599         * annotate.c (annotate_source): Make "filename" const.
9600         * annotate.h (annotate_source): Use const.
9601
9602 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9603
9604         * disasm.c (set_disassembler_options): Send errors to stderr.
9605
9606 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9607
9608         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9609         (cli_interp_base::set_logging): Check debug_redirect.
9610         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9611         * cli/cli-logging.c (debug_redirect): Add static variable.
9612         (pop_output_files): Add default param.
9613         (handle_redirections): Print debug setting.
9614         (show_logging_command): Likewise.
9615         (_initialize_cli_logging): Add debugredirect command.
9616         * interps.c (current_interp_set_logging): Add debug_redirect
9617         parameter.
9618         * interps.h (set_logging): Add debug_redirect parameter.
9619         (current_interp_set_logging): Likewise.
9620         * mi/mi-common.h: Likewise.
9621         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9622
9623 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9624             Tom Tromey  <tromey@adacore.com>
9625
9626         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9627         directly.
9628         * cli/cli-interp.h (make_logging_output): Remove declaration.
9629         * cli/cli-logging.c (make_logging_output): Remove function.
9630         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9631         directly.
9632         * ui-file.c (tee_file::tee_file): Remove bools.
9633         (tee_file::~tee_file): Remove deletes.
9634         * ui-file.h (tee_file): Remove bools.
9635
9636 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
9637
9638         * mi/mi-cmds.h (mi_cmd_complete): New function.
9639         * mi/mi-main.c (mi_cmd_complete): Likewise.
9640         * mi/mi-cmds.c: Define new MI command -complete.
9641         * NEWS: Mention new -complete command.
9642
9643 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
9644
9645         * completer.h (complete): New function.
9646         * completer.c (complete): Likewise.
9647         * cli/cli-cmds.c: (complete_command): Update to use new complete()
9648         function defined in completer.h.
9649
9650 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
9651
9652         * MAINTAINERS (Write After Approval): Add myself.
9653
9654 2019-05-17  Tom de Vries  <tdevries@suse.de>
9655
9656         PR gdb/24094
9657         * dwarf2read.c (struct cu_partial_die_info): New struct.
9658         (find_partial_die): Return cu_partial_die_info.
9659         (partial_die_parent_scope, guess_partial_die_structure_name)
9660         (partial_die_info::fixup): Handle new return type of find_partial_die.
9661
9662 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9663
9664         PR breakpoints/24541
9665         * stap-probe.c (stap_parse_register_operand): Make "regname" an
9666         "std::string", simplifying the algorithm.
9667
9668 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9669
9670         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9671         (stap_static_probe_ops::get_probes): Likewise.
9672
9673 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9674
9675         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9676         '-')" and "else if".
9677         (stap_parse_single_operand): Join checks for
9678         "gdbarch_stap_parse_special_token_p" and
9679         "gdbarch_stap_parse_special_token" in the same "if" statement.
9680         Invert check when verifying for operation on register
9681         displacement.
9682
9683 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9684
9685         * stap-probe.c (stap_get_opcode): Update comment.
9686         (stap_get_expected_argument_type): Likewise.
9687         (handle_stap_probe): Likewise.
9688
9689 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9690
9691         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9692         return type to 'bool'.  Adjust comment.  Use 'bool' when
9693         appropriate.
9694         (i386_stap_parse_special_token_three_arg_disp): Likewise.
9695         * stap-probe.c (stap_parse_argument_1): Likewise.
9696         (stap_is_operator): Likewise.
9697         (stap_is_generic_prefix): Likewise.
9698         (stap_is_register_prefix): Likewise.
9699         (stap_is_register_indirection_prefix): Likewise.
9700         (stap_is_integer_prefix): Likewise.
9701         (stap_generic_check_suffix): Likewise.
9702         (stap_check_integer_suffix): Likewise.
9703         (stap_check_register_suffix): Likewise.
9704         (stap_check_register_indirection_suffix): Likewise.
9705         (stap_parse_register_operand): Likewise.
9706         (stap_parse_single_operand): Likewise.
9707         (stap_parse_argument_1): Likewise.
9708         (stap_probe::get_argument_count): Likewise.
9709         (stap_is_operator): Likewise.
9710
9711 2019-05-16  Tom Tromey  <tromey@adacore.com>
9712
9713         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9714         keyword to foreach.
9715
9716 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
9717
9718         * linux-thread-db.c (try_thread_db_load_1): Change return type
9719         to bool.
9720         (try_thread_db_load): Likewise.
9721         (try_thread_db_load_from_pdir_1): Likewise.
9722         (try_thread_db_load_from_pdir): Likewise.
9723         (try_thread_db_load_from_sdir): Likewise.
9724         (try_thread_db_load_from_dir): Likewise.
9725         (thread_db_load_search): Likewise.
9726         (has_libpthread): Likewise.
9727         (thread_db_load): Likewise.
9728
9729 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
9730
9731         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9732         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9733         NULL, and complain/return if that's the case.
9734
9735 2019-05-15  John Darrington <john@darrington.wattle.id.au>
9736
9737         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9738         (advance, posn, abstract_read_memory): New functions.
9739         [struct mem_read_abstraction]: New struct.
9740         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9741
9742 2019-05-14  Tom Tromey  <tromey@adacore.com>
9743
9744         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9745         value is not lval_memory.
9746
9747 2019-05-14  Tom Tromey  <tromey@adacore.com>
9748
9749         * solib.c (info_sharedlibrary_command): Style the file name.
9750
9751 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
9752
9753         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9754         (aarch64_vnv_type): Likewise.
9755         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9756         * common/tdesc.c: Likewise.
9757         * common/tdesc.h (enum tdesc_type_kind): Likewise.
9758         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9759         * features/aarch64-fpu.xml: Add ieee half view.
9760         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9761         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9762         * gdbtypes.h (struct builtin_type): Likewise.
9763         (struct objfile_type): Likewise.
9764
9765 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
9766
9767         * language.c (language_sniff_from_mangled_name): Fix "langauge"
9768         typo.
9769         * location.h (string_to_event_location): Likewise.
9770
9771 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
9772
9773         GDB 8.3 released.
9774
9775 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9776
9777         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9778         New variable declaration.
9779         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9780         New variable.
9781         (print_one_breakpoint): Use ui_out::test_flags and new global
9782         variable to compute use_fixed_output.
9783         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9784         Remove.
9785         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9786         (mi_multi_location_breakpoint_output_fixed): Remove.
9787         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9788         new variable.
9789         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9790         fix_multi_location_breakpoint_output flag if version >= 3.
9791         * ui-out.h (enum ui_out_flag)
9792         <fix_multi_location_breakpoint_output>: New enumerator.
9793
9794 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9795
9796         * contrib/cc-with-tweaks.sh: Validate dwz's work.
9797
9798 2019-05-10  Tom Tromey  <tromey@adacore.com>
9799
9800         * ada-lang.c (catch_ada_completer): New function.
9801         (_initialize_ada_language): Use it.
9802
9803 2019-05-10  Tom Tromey  <tromey@adacore.com>
9804
9805         * thread.c (print_thread_info): Make "requested_threads" const.
9806         * gdbthread.h (print_thread_info): Make "requested_threads"
9807         const.
9808         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9809         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9810
9811 2019-05-08  Tom Tromey  <tom@tromey.com>
9812
9813         * gdbtypes.c (objfile_type_data): Change type.
9814         (objfile_type, _initialize_gdbtypes): Update.
9815
9816 2019-05-08  Tom Tromey  <tom@tromey.com>
9817
9818         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9819         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9820         (_initialize_dwarf2_frame): Update.
9821
9822 2019-05-08  Tom Tromey  <tom@tromey.com>
9823
9824         * objc-lang.c (objc_objfile_data): Change type.
9825         (find_methods): Update.
9826         (_initialize_objc_lang): Remove.
9827
9828 2019-05-08  Tom Tromey  <tom@tromey.com>
9829
9830         * stabsread.c (rs6000_builtin_type_data): Change type.
9831         (rs6000_builtin_type, _initialize_stabsread): Update.
9832
9833 2019-05-08  Tom Tromey  <tom@tromey.com>
9834
9835         * mips-tdep.c (mips_pdr_data): Remove.
9836         (_initialize_mips_tdep): Update.
9837
9838 2019-05-08  Tom Tromey  <tom@tromey.com>
9839
9840         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9841         (hppa_init_objfile_priv_data, read_unwind_info)
9842         (find_unwind_entry, _initialize_hppa_tdep): Update.
9843
9844 2019-05-08  Tom Tromey  <tom@tromey.com>
9845
9846         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9847         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
9848         on obstack.
9849         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9850
9851 2019-05-08  Tom Tromey  <tom@tromey.com>
9852
9853         * mdebugread.c (basic_type_data): Change type.
9854         (basic_type, _initialize_mdebugread): Update.
9855
9856 2019-05-08  Tom Tromey  <tom@tromey.com>
9857
9858         * common/gdb_unique_ptr.h (struct noop_deleter): New.
9859
9860 2019-05-08  Tom Tromey  <tom@tromey.com>
9861
9862         * nto-tdep.c (nto_inferior_data_reg): Change type.
9863         (nto_inferior_data): Update.
9864         (nto_inferior_data_cleanup, nto_new_inferior_data)
9865         (_initialize_nto_tdep): Remove.
9866         * nto-tdep.h (struct nto_inferior_data): Add initializers.
9867
9868 2019-05-08  Tom Tromey  <tom@tromey.com>
9869
9870         * ada-lang.c (struct ada_inferior_data): Add initializers.
9871         (ada_inferior_data): Change type.
9872         (ada_inferior_data_cleanup): Remove.
9873         (get_ada_inferior_data, ada_inferior_exit)
9874         (struct ada_pspace_data): Add initializers, destructor.
9875         (ada_pspace_data_handle): Change type.
9876         (get_ada_pspace_data): Update.
9877         (ada_pspace_data_cleanup): Remove.
9878
9879 2019-05-08  Tom Tromey  <tom@tromey.com>
9880
9881         * coffread.c (struct coff_symfile_info): Add initializers.
9882         (coff_objfile_data_key): Move lower.  Change type.
9883         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9884         Update.
9885         (coff_free_info): Remove.
9886
9887 2019-05-08  Tom Tromey  <tom@tromey.com>
9888
9889         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9890         (fbsd_pspace_data_handle): Move lower.  Change type.
9891         (get_fbsd_pspace_data): Update.
9892         (fbsd_pspace_data_cleanup): Remove.
9893         (_initialize_fbsd_tdep): Update.
9894
9895 2019-05-08  Tom Tromey  <tom@tromey.com>
9896
9897         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9898         (get_ada_tasks_pspace_data): Update.
9899         (ada_tasks_pspace_data_cleanup): Remove.
9900         (_initialize_tasks): Update.
9901         (ada_tasks_inferior_data_handle): Change type.
9902         (get_ada_tasks_inferior_data): Update.
9903         (ada_tasks_inferior_data_cleanup): Remove.
9904         (struct ada_tasks_pspace_data): Add initializers.
9905
9906 2019-05-08  Tom Tromey  <tom@tromey.com>
9907
9908         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9909         * symfile-debug.c (debug_sym_get_probes): Change type.
9910         * stap-probe.c (handle_stap_probe):
9911         (stap_static_probe_ops::get_probes): Change type.
9912         * probe.h (class static_probe_ops) <get_probes>: Change type.
9913         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9914         (parse_probes_in_pspace): Update.
9915         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9916         Update.
9917         (any_static_probe_ops::get_probes): Change type.
9918         * elfread.c (elfread_data): New typedef.
9919         (probe_key): Change type.
9920         (elf_get_probes): Likewise.  Update.
9921         (probe_key_free): Remove.
9922         (_initialize_elfread): Update.
9923         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9924         Change type.
9925         (dtrace_process_dof_probe, dtrace_process_dof)
9926         (dtrace_static_probe_ops::get_probe): Change type.
9927
9928 2019-05-08  Tom Tromey  <tom@tromey.com>
9929
9930         * xcoffread.c (struct xcoff_symfile_info): Rename from
9931         coff_symfile_info.  Add initializers.
9932         (xcoff_objfile_data_key): Move lower.  Change type.
9933         (XCOFF_DATA): Rewrite.
9934         (xcoff_free_info): Remove.
9935         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
9936         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
9937         (xcoff_initial_scan): Update.
9938
9939 2019-05-08  Tom Tromey  <tom@tromey.com>
9940
9941         * solib-svr4.c (struct svr4_info): Add initializers and
9942         destructor.
9943         <probes_table>: Now an htab_up.
9944         (solib_svr4_pspace_data): Change type.
9945         (free_probes_table): Simplify.
9946         (~svr4_info): Rename from svr4_pspace_data_cleanup.
9947         (get_svr4_info, probes_table_htab_remove_objfile_probes)
9948         (probes_table_remove_objfile_probes, register_solib_event_probe)
9949         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
9950         (_initialize_svr4_solib): Update.
9951
9952 2019-05-08  Tom Tromey  <tom@tromey.com>
9953
9954         * remote.c (remote_pspace_data): Change type.
9955         (remote_pspace_data_cleanup): Remove.
9956         (get_remote_exec_file, set_pspace_remote_exec_file)
9957         (_initialize_remote): Update.
9958
9959 2019-05-08  Tom Tromey  <tom@tromey.com>
9960
9961         * breakpoint.c (breakpoint_objfile_key): Change type.
9962         (get_breakpoint_objfile_data): Update.
9963         (free_breakpoint_objfile_data): Remove.
9964         (_initialize_breakpoint): Update.
9965
9966 2019-05-08  Tom Tromey  <tom@tromey.com>
9967
9968         * linux-tdep.c (struct linux_info): Add initializers.
9969         (linux_inferior_data): Move.  Change type.
9970         (invalidate_linux_cache_inf): Update.
9971         (linux_inferior_data_cleanup): Remove.
9972         (get_linux_inferior_data, _initialize_linux_tdep): Update.
9973
9974 2019-05-08  Tom Tromey  <tom@tromey.com>
9975
9976         * auxv.c (auxv_inferior_data): Move.  Change type.
9977         (auxv_inferior_data_cleanup): Remove.
9978         (invalidate_auxv_cache_inf): Rewrite.
9979         (get_auxv_inferior_data, _initialize_auxv): Update.
9980
9981 2019-05-08  Tom Tromey  <tom@tromey.com>
9982
9983         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
9984         (symfile_debug_objfile_data_key): Change type.
9985         (symfile_debug_installed, debug_qf_has_symbols)
9986         (debug_qf_find_last_source_symtab)
9987         (debug_qf_forget_cached_source_info)
9988         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
9989         (debug_qf_print_stats, debug_qf_dump)
9990         (debug_qf_expand_symtabs_for_function)
9991         (debug_qf_expand_all_symtabs)
9992         (debug_qf_expand_symtabs_with_fullname)
9993         (debug_qf_map_matching_symbols)
9994         (debug_qf_expand_symtabs_matching)
9995         (debug_qf_find_pc_sect_compunit_symtab)
9996         (debug_qf_map_symbol_filenames)
9997         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
9998         (debug_sym_new_init, debug_sym_init, debug_sym_read)
9999         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10000         (debug_sym_read_linetable, debug_sym_relocate): Update.
10001         (symfile_debug_free_objfile): Remove.
10002         (install_symfile_debug_logging, _initialize_symfile_debug):
10003         Update.
10004
10005 2019-05-08  Tom Tromey  <tom@tromey.com>
10006
10007         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10008         allocate_on_obstack.
10009         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10010         (get_dwarf2_per_objfile): Update.
10011         (set_dwarf2_per_objfile): Remove.
10012         (dwarf2_has_info, dwarf2_get_section_info): Update.
10013         (dwarf2_free_objfile): Remove.
10014         (_initialize_dwarf2_read): Update.
10015
10016 2019-05-08  Tom Tromey  <tom@tromey.com>
10017
10018         * auto-load.c (struct auto_load_pspace_info): Add destructor and
10019         initializers.
10020         <unsupported_script_warning_printed,
10021         script_not_found_warning_printed>: Now bool.
10022         (auto_load_pspace_data): Change type.
10023         (~auto_load_pspace_info): Rename from
10024         auto_load_pspace_data_cleanup.
10025         (get_auto_load_pspace_data, init_loaded_scripts_info)
10026         (clear_section_scripts, maybe_print_unsupported_script_warning)
10027         (maybe_print_script_not_found_warning, _initialize_auto_load):
10028         Update.
10029
10030 2019-05-08  Tom Tromey  <tom@tromey.com>
10031
10032         * objfiles.c (objfile_pspace_info): Add destructor and
10033         initializers.
10034         (objfiles_pspace_data): Change type.
10035         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10036         (get_objfile_pspace_data): Update.
10037         (objfiles_bfd_data): Change type.
10038         (get_objfile_bfd_data): Update.
10039         (objfile_bfd_data_free, _initialize_objfiles): Remove.
10040
10041 2019-05-08  Tom Tromey  <tom@tromey.com>
10042
10043         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10044         Change type.
10045         (get_catch_syscall_inferior_data): Update.
10046         (catch_syscall_inferior_data_cleanup): Remove.
10047         (_initialize_break_catch_syscall): Update.
10048
10049 2019-05-08  Tom Tromey  <tom@tromey.com>
10050
10051         * inflow.c (struct terminal_info): Add destructor and
10052         initializers.
10053         (inflow_inferior_data): Change type.
10054         (~terminal_info): Rename from inflow_inferior_data_cleanup.
10055         (get_inflow_inferior_data, inflow_inferior_exit)
10056         (swap_terminal_info, _initialize_inflow): Update.
10057
10058 2019-05-08  Tom Tromey  <tom@tromey.com>
10059
10060         * target-dcache.c (target_dcache_cleanup): Remove.
10061         (target_dcache_aspace_key): Change type.
10062         (target_dcache_init_p, target_dcache_invalidate)
10063         (target_dcache_get, target_dcache_get_or_init)
10064         (_initialize_target_dcache): Update.
10065         * dcache.h (struct dcache_deleter): New.
10066
10067 2019-05-08  Tom Tromey  <tom@tromey.com>
10068
10069         * symtab.c (struct symbol_cache): Add destructor and
10070         initializers.
10071         (symbol_cache_key): Move.  Change type.
10072         (make_symbol_cache, free_symbol_cache): Remove.
10073         (get_symbol_cache): Update.
10074         (symbol_cache_cleanup): Remove.
10075         (ALL_PSPACES, symbol_cache_flush)
10076         (maintenance_print_symbol_cache)
10077         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10078         Update.
10079
10080 2019-05-08  Tom Tromey  <tom@tromey.com>
10081
10082         * symtab.c (struct main_info): Add destructor and initializers.
10083         (main_progspace_key): Move.  Change type.
10084         (get_main_info): Update.
10085         (main_info_cleanup): Remove.
10086         (_initialize_symtab): Update.
10087
10088 2019-05-08  Tom Tromey  <tom@tromey.com>
10089
10090         * registry.h (DECLARE_REGISTRY): Define the _key class.
10091
10092 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10093
10094         * NEWS: Merge two 'New commands' sections.
10095
10096 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
10097
10098         * ada-valprint.c (ada_val_print_gnat_array): Remove language
10099         parameter and use Ada language definition instead.
10100         (ada_val_print_ptr): Remove unused language parameter.
10101         (ada_val_print_num): Remove language parameter and use Ada language
10102         definition instead.
10103         (ada_val_print_enum, ada_val_print_flt): Remove unused language
10104         parameter.
10105         (ada_val_print_struct_union, ada_val_print_ref): Remove language
10106         parameter and use Ada language definition instead.
10107         (ada_val_print_1): Update all ada_val_print_xxx calls.
10108         Remove language parameter.
10109         (ada_val_print): Update ada_val_print_1 call.
10110
10111 2019-05-08  Tom Tromey  <tromey@adacore.com>
10112
10113         * remote.c (remote_hw_watchpoint_limit)
10114         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10115         Now static.
10116
10117 2019-05-08  Tom Tromey  <tromey@adacore.com>
10118
10119         * maint.c (_initialize_maint_cmds): Move initialization code to
10120         remote.c.
10121         (watchdog, show_watchdog): Move to remote.c.
10122         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
10123         "watchdog" static.
10124         (_initialize_remote): Move initialization code from maint.c.
10125         * defs.h (watchdog): Don't declare.
10126
10127 2019-05-08  Tom Tromey  <tromey@adacore.com>
10128
10129         * tui/tui-interp.c: Include main.h.
10130         * interps.c: Include main.h.
10131         * main.h (interpreter_p): Declare.
10132         * defs.h (interpreter_p): Don't declare.
10133
10134 2019-05-08  Tom Tromey  <tromey@adacore.com>
10135
10136         * dwarf2loc.c: Include dwarf2read.h.
10137         * defs.h (read_unsigned_leb128): Don't declare.
10138         * dwarf2read.h (read_unsigned_leb128): Declare.
10139
10140 2019-05-08  Tom Tromey  <tromey@adacore.com>
10141
10142         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10143         method.
10144
10145 2019-05-08  Tom Tromey  <tromey@adacore.com>
10146
10147         * utils.c (fputs_maybe_filtered): Reset style after paging, even
10148         when no wrap column is set.
10149
10150 2019-05-08  Tom Tromey  <tromey@adacore.com>
10151
10152         * c-lang.c (c_get_string): Handle non-C-style arrays.
10153
10154 2019-05-08  Tom Tromey  <tromey@adacore.com>
10155
10156         * typeprint.c (print_offset_data::update): Print the bit offset,
10157         not the number of bits remaining.
10158
10159 2019-05-08  Tom Tromey  <tromey@adacore.com>
10160
10161         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10162         padding at end of comment.
10163
10164 2019-05-08  Tom Tromey  <tromey@adacore.com>
10165
10166         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10167         Compare main types.
10168
10169 2019-05-06  Tom Tromey  <tom@tromey.com>
10170
10171         * common/scoped_mmap.c: Include common-defs.h.
10172         * common/scoped_mmap.h: Don't include config.h.
10173
10174 2019-05-04  Tom Tromey  <tom@tromey.com>
10175
10176         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10177         (struct aarch64_call_info): Add initializers.
10178         <si>: Now a std::vector.
10179         (pass_on_stack, aarch64_push_dummy_call): Update.
10180
10181 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
10182             Tom Tromey  <tom@tromey.com>
10183
10184         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10185         (ppc_threads): Now a std::vector.  Now static.
10186         (hwdebug_find_thread_points_by_tid)
10187         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10188         Update.
10189
10190 2019-05-04  Tom Tromey  <tom@tromey.com>
10191
10192         * arc-tdep.c (arc_tdesc_init): Return bool.
10193
10194 2019-05-04  Tom Tromey  <tom@tromey.com>
10195
10196         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10197         Use gdb_assert_not_reached.
10198
10199 2019-05-04  Tom Tromey  <tom@tromey.com>
10200
10201         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10202         "false".
10203
10204 2019-05-04  Tom Tromey  <tom@tromey.com>
10205
10206         * arc-tdep.c (arc_tdesc_init): Use bool.
10207
10208 2019-05-04  Tom Tromey  <tom@tromey.com>
10209
10210         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10211
10212 2019-05-04  Tom Tromey  <tom@tromey.com>
10213
10214         * cli/cli-cmds.c (valid_command_p): Return bool.
10215
10216 2019-05-04  Tom Tromey  <tom@tromey.com>
10217
10218         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10219         * command.h (valid_user_defined_cmd_name_p): Channge return type.
10220
10221 2019-05-04  Raul Tambre  <raul@tambre.ee>
10222
10223         * python/lib/gdb/prompt.py (_ExtendedPrompt)
10224         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10225         operator for comparison.
10226
10227 2019-05-04  Tom Tromey  <tom@tromey.com>
10228
10229         * psymtab.c (psymbol_name_matches, match_partial_symbol)
10230         (lookup_partial_symbol, print_partial_symbols)
10231         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10232         (psymbol_compare): Update.
10233         (add_psymbol_to_bcache): Clear the entire psymbol.
10234         (maintenance_check_psymtabs): Update.
10235         * psympriv.h (struct partial_symbol): Don't derive from
10236         general_symbol_info.
10237         <obj_section, unrelocated_address, address,
10238         set_unrelocated_address>: Update.
10239         <ginfo>: New member.
10240         * dwarf-index-write.c (write_psymbols, debug_names::insert)
10241         (debug_names::write_psymbols): Update.
10242
10243 2019-05-04  Tom de Vries  <tdevries@suse.de>
10244
10245         * contrib/cc-with-tweaks.sh: Support -n arg.
10246
10247 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10248
10249         * corelow.c (core_target::detach): Ensure frame cache and
10250         register caches are cleared.
10251         inferior.c (exit_inferior_1): Likewise.
10252
10253 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
10254             Tom Tromey  <tom@tromey.com>
10255
10256         * dictionary.c (collate_pending_symbols_by_language): Remove
10257         "struct" from foreach.
10258         * symtab.c (lookup_global_symbol_from_objfile)
10259         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10260         foreach.
10261         * ser-tcp.c (net_open): Remove "struct" from foreach.
10262         * objfiles.c (objfile_relocate, objfile_rebase)
10263         (objfile_has_symbols): Remove "struct" from foreach.
10264         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10265         from foreach.
10266         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10267         foreach.
10268         * darwin-nat.c (thread_info_from_private_thread_info): Remove
10269         "struct" from foreach.
10270         * ada-lang.c (create_excep_cond_exprs)
10271         (ada_exception_catchpoint_cond_string): Remove "struct" from
10272         foreach.
10273
10274 2019-05-03  Tom Tromey  <tromey@adacore.com>
10275
10276         * ada-exp.y (convert_char_literal): Check suffix of each
10277         enumerator.
10278
10279 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
10280
10281         PR ada/21406:
10282         * ada-exp.y (yywrap): Don't define.
10283         * ada-lex.l (%option): Add noyywrap
10284         (yywrap): Remove.
10285
10286 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
10287
10288         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10289         _WIN32_WINNT to the XP level, unless already defined to a higher
10290         level.
10291
10292         * unittests/parse-connection-spec-selftests.c:
10293         * ser-tcp.c:
10294         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
10295         override.
10296
10297         * symfile.c (find_separate_debug_file): Remove colon from the
10298         drive spec of DOS/Windows file names of the target, so that the
10299         file name produced from DEBUGDIR and the target's directory will
10300         be valid on DOS/Windows systems.
10301
10302 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
10303
10304         * rust-lang.c (val_print_struct): Handle printing structures
10305         containing strings.
10306
10307 2019-05-02  Tom Tromey  <tromey@adacore.com>
10308
10309         * valarith.c (_initialize_valarith): Remove.
10310
10311 2019-05-01  Tom Tromey  <tromey@adacore.com>
10312
10313         * ada-lang.c (ada_value_primitive_field): Treat more fields as
10314         bitfields.
10315
10316 2019-05-01  Tom Tromey  <tromey@adacore.com>
10317
10318         * ada-lang.c (ada_value_assign): Correctly compute starting offset
10319         for big-endian copies.
10320
10321 2019-04-30  Ali Tamur  <tamur@google.com>
10322         * gdb/dwarf2read.c (read_3_bytes): New declaration.
10323         (read_attribute_value): Added DW_FORM_strx1-4 cases.
10324         (read_3_bytes): New function.
10325
10326 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10327
10328         * windows-nat.c (main_thread_id): Delete.
10329         (handle_output_debug_string): Replace main_thread_id by
10330         current_event.dwThreadId.
10331         (fake_create_process): Likewise.
10332         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10333         Do not set main_thread_id.
10334         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10335         current_event.dwThreadId.
10336         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10337
10338 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10339
10340         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10341         Use current_event.dwThreadId instead of main_thread_id.
10342
10343 2019-04-30  Tom Tromey  <tromey@adacore.com>
10344
10345         * ada-lang.c (ada_lookup_simple_minsyms): New function.
10346         (create_excep_cond_exprs): Iterate over program spaces.
10347         (ada_exception_catchpoint_cond_string): Examine all minimal
10348         symbols for exception types.
10349
10350 2019-04-30  Tom Tromey  <tromey@adacore.com>
10351
10352         PR c++/24470:
10353         * dwarf2read.c (process_structure_scope): Handle case where type
10354         has template parameters but no symbol was created.
10355
10356 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10357             Chris January  <chris.january@arm.com>
10358
10359         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10360         qualifier.
10361         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10362
10363 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10364
10365         * f-typeprint.c (f_print_type): Update rules for printing
10366         whitespace.
10367         (f_type_print_varspec_suffix): Likewise.
10368
10369 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10370             Chris January  <chris.january@arm.com>
10371
10372         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10373         function arguments.
10374
10375 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10376
10377         * f-lang.c (build_fortran_types): Change name of void type to
10378         lower case.
10379         * f-typeprint.c (f_type_print_base): Print the name of the void
10380         type, rather than a fixed string.
10381         * f-valprint.c (f_decorations): Use lower case void string.
10382
10383 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10384             Chris January  <chris.january@arm.com>
10385
10386         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10387         types for Fortran.
10388
10389 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10390             Chris January  <chris.january@arm.com>
10391             David Lecomber  <david.lecomber@arm.com>
10392
10393         * f-exp.y (BINOP_INTRINSIC): New token.
10394         (exp): New parser rule handling BINOP_INTRINSIC.
10395         (f77_keywords): Add new builtin procedures.
10396         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10397         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10398         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10399         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10400         (print_unop_subexp_f): New function.
10401         (print_binop_subexp_f): New function.
10402         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10403         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10404         (dump_subexp_body_f): Likewise.
10405         (operator_check_f): Likewise.
10406         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10407         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10408
10409 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10410
10411         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10412         UNOP_KIND.
10413         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10414         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10415         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10416         (operator_length_f): New fuction.
10417         (print_subexp_f): New function.
10418         (op_name_f): New function.
10419         (dump_subexp_body_f): New function.
10420         (operator_check_f): New function.
10421         (exp_descriptor_f): Replace standard expression handling functions
10422         with new functions.
10423         * gdb/fortran-operator.def: New file.
10424         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10425         * gdb/std-operator.def: Remove UNOP_KIND.
10426
10427 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10428
10429         * std-operator.def: Remove unbalanced, stray double quote
10430         character.
10431
10432 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10433             Chris January  <chris.january@arm.com>
10434             Daniel Everett  <daniel.everett@arm.com>
10435             Nick Forrington  <nick.forrington@arm.com>
10436             Richard Bunt  <richard.bunt@arm.com>
10437
10438         * cp-valprint.c (cp_print_value_fields): Allow an additional level
10439         of depth when printing anonymous structs or unions.
10440         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10441         Don't print either the top-level value, or the children if the
10442         max-depth is exceeded.
10443         (ppscm_print_children): When printing the key of a map, allow one
10444         extra level of depth.
10445         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10446         print either the top-level value, or the children if the max-depth
10447         is exceeded.
10448         (print_children): When printing the key of a map, allow one extra
10449         level of depth.
10450         * python/py-value.c (valpy_format_string): Add max_depth keyword.
10451         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10452         (user_print_options): Initialise max_depth field.
10453         (val_print_scalar_or_string_type_p): New function.
10454         (val_print): Check to see if the max depth has been reached.
10455         (val_print_check_max_depth): Define new function.
10456         (show_print_max_depth): New function.
10457         (_initialize_valprint): Add 'print max-depth' option.
10458         * valprint.h (struct value_print_options) <max_depth>: New field.
10459         (val_print_check_max_depth): Declare new function.
10460         * NEWS: Document new feature.
10461
10462 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10463
10464         * ada-lang.c (ada_language_defn): Initialise new field.
10465         * c-lang.c (c_is_string_type_p): New function.
10466         (c_language_defn): Initialise new field.
10467         (cplus_language_defn): Initialise new field.
10468         (asm_language_defn): Initialise new field.
10469         (minimal_language_defn): Initialise new field.
10470         * c-lang.h (c_is_string_type_p): Declare new function.
10471         * d-lang.c (d_language_defn): Initialise new field.
10472         * f-lang.c (f_is_string_type_p): New function.
10473         (f_language_defn): Initialise new field.
10474         * go-lang.c (go_is_string_type_p): New function.
10475         (go_language_defn): Initialise new field.
10476         * language.c (default_is_string_type_p): New function.
10477         (unknown_language_defn): Initialise new field.
10478         (auto_language_defn): Initialise new field.
10479         * language.h (struct language_defn) <la_is_string_type_p>: New
10480         member variable.
10481         (default_is_string_type_p): Declare new function.
10482         * m2-lang.c (m2_language_defn): Initialise new field.
10483         * objc-lang.c (objc_language_defn): Initialise new field.
10484         * opencl-lang.c (opencl_language_defn): Initialise new field.
10485         * p-lang.c (pascal_is_string_type_p): New function.
10486         (pascal_language_defn): Initialise new field.
10487         * rust-lang.c (rust_is_string_type_p): New function.
10488         (rust_language_defn): Initialise new field.
10489
10490 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10491
10492         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10493         New field.
10494         * ada-lang.c (ada_language_defn): Initialise new field.
10495         * c-lang.c (c_language_defn): Likewise.
10496         (cplus_language_defn): Likewise.
10497         (asm_language_defn): Likewise.
10498         (minimal_language_defn): Likewise.
10499         * d-lang.c (d_language_defn): Likewise.
10500         * f-lang.c (f_language_defn): Likewise.
10501         * go-lang.c (go_language_defn): Likewise.
10502         * language.c (unknown_language_defn): Likewise.
10503         (auto_language_defn): Likewise.
10504         * m2-lang.c (m2_language_defn): Likewise.
10505         * objc-lang.c (objc_language_defn): Likewise.
10506         * opencl-lang.c (opencl_language_defn): Likewise.
10507         * p-lang.c (pascal_language_defn): Likewise.
10508         * rust-lang.c (rust_language_defn): Likewise.
10509
10510 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10511
10512         * ada-lang.c (ada_is_character_type): Change return type to bool.
10513         (ada_is_string_type): Likewise.
10514         * ada-lang.h (ada_is_character_type): Update declaration
10515         (ada_is_string_type): Likewise.
10516
10517 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10518
10519         Support style in 'frame|thread apply'
10520
10521         * gdbcmd.h (execute_command_to_string): New term_out parameter.
10522         * record.c (record_start, record_stop): Update callers of
10523         execute_command_to_string with false.
10524         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10525         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10526         methods.
10527         (class string_file): New constructor with term_out parameter.
10528         Override methods term_out and can_emit_style_escape.  New member
10529         term_out.
10530         (class stdio_file): Override can_emit_style_escape.
10531         (class tee_file): Override term_out and can_emit_style_escape.
10532         * utils.h (can_emit_style_escape): Remove.
10533         * utils.c (can_emit_style_escape): Likewise.
10534         Update all callers of can_emit_style_escape (SOMESTREAM) to
10535         SOMESTREAM->can_emit_style_escape.
10536         * source-cache.c (source_cache::get_source_lines): Likewise.
10537         * stack.c (frame_apply_command_count): Call execute_command_to_string
10538         passing the term_out characteristic of the current gdb_stdout.
10539         * thread.c (thr_try_catch_cmd): Likewise.
10540         * top.c (execute_command_to_string): pass term_out parameter
10541         to construct the string_file for the command output.
10542         * ui-file.c (term_cli_styling): New function (most code moved
10543         from utils.c can_emit_style_escape).
10544         (string_file::string_file, string_file::can_emit_style_escape,
10545         stdio_file::can_emit_style_escape, tee_file::term_out,
10546         tee_file::can_emit_style_escape): New functions.
10547
10548 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10549
10550         * NEWS: Mention the new set|show may-call-functions.
10551         * infcall.c (may_call_functions_p): New variable.
10552         (show_may_call_functions_p): New function.
10553         (call_function_by_hand_dummy): Throws an error if not
10554         may-call-functions.
10555         (_initialize_infcall): Call add_setshow_boolean_cmd for
10556         may-call-functions.
10557
10558 2019-04-25  Keith Seitz  <keiths@redhat.com>
10559
10560         PR c++/24367
10561         * cp-support.c (inspect_type): Don't attempt substitutions
10562         of symbol with the same name.
10563
10564 2019-04-25  Tom Tromey  <tromey@adacore.com>
10565
10566         PR gdb/24475:
10567         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10568         static.
10569
10570 2019-04-25  Tom Tromey  <tromey@adacore.com>
10571
10572         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10573         rvalue reference.
10574         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10575         (gdb_xml_parser::parse): Use std::move.
10576         * python/python-internal.h (gdbpy_convert_exception): Take a const
10577         reference.
10578         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10579         std::move.
10580         * python/py-utils.c (gdbpy_convert_exception): Take a const
10581         reference.
10582         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10583         Use std::move.
10584         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10585         Use std::move.
10586         * mi/mi-main.c (mi_print_exception): Take a const reference.
10587         * main.c (handle_command_errors): Take a const reference.
10588         * linespec.c (parse_linespec): Use std::move.
10589         * infcall.c (run_inferior_call): Use std::move.
10590         (call_function_by_hand_dummy): Use std::move.
10591         * exec.c (try_open_exec_file): Use std::move.
10592         * exceptions.h (exception_print, exception_fprintf)
10593         (exception_print_same): Update.
10594         * exceptions.c (print_exception, exception_print)
10595         (exception_fprintf, exception_print_same): Change parameters to
10596         const reference.
10597         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10598         * common/new-op.c: Use std::move.
10599         * common/common-exceptions.h (struct gdb_exception): Add move
10600         constructor.
10601         (struct gdb_exception_error, struct gdb_exception_quit, struct
10602         gdb_quit_bad_alloc): Change constructor to move constructor.
10603         (throw_exception): Change parameter to rvalue reference.
10604         * common/common-exceptions.c (throw_exception): Take rvalue
10605         reference.
10606         * cli/cli-interp.c (safe_execute_command): Use std::move.
10607         * breakpoint.c (insert_bp_location, location_to_sals): Use
10608         std::move.
10609
10610 2019-04-25  Tom Tromey  <tromey@adacore.com>
10611
10612         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10613         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10614         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10615         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10616         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10617         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10618         guile/scm-value.c: Use unpack.
10619         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10620         gdbscm_gdb_exception.
10621         (gdbscm_throw_gdb_exception): Likewise.
10622         (struct gdbscm_gdb_exception): New.
10623         (unpack): New function.
10624         (gdbscm_wrap): Use unpack.
10625
10626 2019-04-25  Tom Tromey  <tromey@adacore.com>
10627
10628         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10629         (gdb_rl_callback_handler): Use std::move.
10630         * common/common-exceptions.h (struct gdb_exception): Add move
10631         assignment operator.
10632         (throw_exception_sjlj): Change "exception" to const reference.
10633         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10634         (throw_exception_sjlj): Change "exception" to const reference.
10635
10636 2019-04-25  Tom Tromey  <tromey@adacore.com>
10637
10638         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10639         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10640         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10641         Update.
10642         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10643         Update.
10644         * mi/mi-interp.c (mi_interp::exec): Update.
10645         * linespec.c (parse_linespec): Update.
10646         * infcall.c (run_inferior_call): Update.
10647         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10648         * guile/scm-symbol.c (gdbscm_lookup_symbol)
10649         (gdbscm_lookup_global_symbol): Update.
10650         * guile/scm-param.c (gdbscm_parameter_value): Update.
10651         * guile/scm-frame.c (gdbscm_frame_read_register)
10652         (gdbscm_frame_read_var): Update.
10653         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10654         * exec.c (try_open_exec_file): Update.
10655         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10656         (gdb_rl_callback_handler): Update.
10657         * common/common-exceptions.h (exception_none): Don't declare.
10658         * common/common-exceptions.c (exception_none): Don't define.
10659         (struct catcher) <exception>: Update.
10660         * cli/cli-interp.c (safe_execute_command): Update.
10661         * breakpoint.c (insert_bp_location, location_to_sals): Update.
10662
10663 2019-04-25  Ali Tamur  <tamur@google.com>
10664
10665         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10666         (read_attribute_value): Likewise.
10667         (dwarf2_read_addr_index): Update comment.
10668         (read_str_index): Add DW_FORM_strx.
10669         (dwarf2_string_attr): Likewise.
10670         (dwarf2_const_value_attr): Likewise.
10671         (dump_die_shallow): Likewise.
10672         (dwarf2_fetch_constant_bytes): Likewise.
10673         (skip_form_bytes): Likewise.
10674         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10675
10676 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
10677
10678         PR corefiles/11608
10679         PR corefiles/18187
10680         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10681         OFFSET.  Verify if current mapping contains an ELF header.
10682         (linux_find_memory_regions_full): Adjust call to
10683         dump_mapping_p.
10684
10685 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
10686             Kang Li <kanglictf@gmail.com>
10687
10688         PR gdb/21600
10689
10690         * dwarf2-frame.c (read_initial_length): Be consistent about using
10691         unsigned representation of length.
10692         (decode_frame_entry_1): Likewise.  Check for wraparound of
10693         end pointer as well as buffer overflow.
10694
10695 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
10696
10697         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10698         "vq".
10699
10700 2019-04-24  Tom Tromey  <tromey@adacore.com>
10701
10702         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10703
10704 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10705
10706         * s12z-tdep.c (s12z_unwind_pc): Delete.
10707         (s12z_unwind_sp): Delete.
10708         (s12z_gdbarch_init): Don't register deleted functions with
10709         gdbarch.
10710
10711 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10712
10713         * rl78-tdep.c (rl78_unwind_sp): Delete.
10714         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10715
10716 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10717
10718         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10719         (xstormy16_unwind_pc): Delete.
10720         (xstormy16_dummy_id): Delete.
10721         (xstormy16_gdbarch_init): Don't register deleted functions with
10722         gdbarch.
10723
10724 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10725
10726         * vax-tdep.c (vax_unwind_pc): Delete.
10727         (vax_gdbarch_init): Don't register deleted function with gdbarch.
10728
10729 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10730
10731         * v850-tdep.c (v850_unwind_sp): Delete.
10732         (v850_unwind_pc): Delete.
10733         (v850_dummy_id): Delete.
10734         (v850_gdbarch_init): Don't register deleted functions with
10735         gdbarch.
10736
10737 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10738
10739         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10740         (tilegx_unwind_pc): Delete.
10741         (tilegx_unwind_dummy_id): Delete.
10742         (tilegx_gdbarch_init): Don't register deleted functions with
10743         gdbarch.
10744
10745 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10746
10747         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10748         (tic6x_dummy_id): Delete.
10749         (tic6x_gdbarch_init): Don't register deleted functions with
10750         gdbarch.
10751
10752 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10753
10754         * sparc-tdep.c (sparc_unwind_pc): Delete.
10755         (sparc32_gdbarch_init): Don't register deleted function with
10756         gdbarch.
10757
10758 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10759
10760         * sh-tdep.c (sh_unwind_sp): Delete.
10761         (sh_unwind_pc): Delete.
10762         (sh_dummy_id): Delete.
10763         (sh_gdbarch_init): Don't register deleted functions with
10764         gdbarch.
10765
10766 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10767
10768         * score-tdep.c (score_unwind_sp): Delete.
10769         (score_unwind_pc): Delete.
10770         (score_dummy_id): Delete.
10771         (score_gdbarch_init): Don't register deleted functions with
10772         gdbarch.
10773
10774 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10775
10776         * rx-tdep.c (rx_unwind_pc): Delete.
10777         (rx_unwind_sp): Delete.
10778         (rx_dummy_id): Delete.
10779         (rx_gdbarch_init): Don't register deleted functions with
10780         gdbarch.  Update comment.
10781
10782 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10783
10784         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10785         (rs6000_dummy_id): Delete.
10786         (rs6000_gdbarch_init): Don't register deleted functions with
10787         gdbarch.
10788
10789 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10790
10791         * or1k-tdep.c (or1k_dummy_id): Delete.
10792         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10793
10794 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10795
10796         * nios2-tdep.c (nios2_dummy_id): Delete.
10797         (nios2_unwind_sp): Delete.
10798         (nios2_gdbarch_init): Don't register deleted functions with
10799         gdbarch.
10800
10801 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10802
10803         * nds32-tdep.c (nds32_dummy_id): Delete.
10804         (nds32_unwind_pc): Delete.
10805         (nds32_unwind_sp): Delete.
10806         (nds32_gdbarch_init): Don't register deleted functions with
10807         gdbarch.
10808
10809 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10810
10811         * msp430-tdep.c (msp430_unwind_pc): Delete.
10812         (msp430_unwind_sp): Delete.
10813         (msp430_dummy_id): Delete.
10814         (msp430_gdbarch_init): Don't register deleted functions with
10815         gdbarch.
10816
10817 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10818
10819         * moxie-tdep.c (moxie_unwind_sp): Delete.
10820         (moxie_unwind_pc): Delete.
10821         (moxie_dummy_id): Delete.
10822         (moxie_gdbarch_init): Don't register deleted functions with
10823         gdbarch.
10824
10825 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10826
10827         * mn10300-tdep.c (mn10300_dummy_id): Delete.
10828         (mn10300_unwind_pc): Delete.
10829         (mn10300_unwind_sp): Delete.
10830         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10831         mn10300_unwind_sp.
10832         (mn10300_frame_unwind_init): Don't register deleted functions with
10833         gdbarch.
10834
10835 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10836
10837         * mep-tdep.c (mep_unwind_pc): Delete.
10838         (mep_unwind_sp): Delete.
10839         (mep_dummy_id): Delete.
10840         (mep_gdbarch_init): Don't register deleted functions with
10841         gdbarch.
10842
10843 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10844
10845         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10846         (m68hc11_unwind_sp): Delete.
10847         (m68hc11_gdbarch_init): Don't register deleted functions with
10848         gdbarch.
10849
10850 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10851
10852         * m32r-tdep.c (m32r_unwind_sp): Delete.
10853         (m32r_unwind_pc): Delete.
10854         (m32r_dummy_id): Delete.
10855         (m32r_gdbarch_init): Don't register deleted functions with
10856         gdbarch.
10857
10858 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10859
10860         * m32c-tdep.c (m32c_unwind_pc): Delete.
10861         (m32c_unwind_sp): Delete.
10862         (m32c_dummy_id): Delete.
10863         (m32c_gdbarch_init): Don't register deleted functions with
10864         gdbarch.
10865
10866 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10867
10868         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10869         (lm32_unwind_pc): Delete.
10870         (lm32_dummy_id): Delete.
10871         (lm32_gdbarch_init): Don't register deleted functions with
10872         gdbarch.
10873
10874 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10875
10876         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10877         (iq2000_unwind_pc): Delete.
10878         (iq2000_dummy_id): Delete.
10879         (iq2000_gdbarch_init): Don't register deleted functions with
10880         gdbarch.
10881
10882 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10883
10884         * nds32-tdep.c (nds32_type_align): Delete.
10885         (nds32_push_dummy_call): Use type_align instead.
10886
10887 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10888
10889         * arm-tdep.c (arm_type_align): Only handle vector override case.
10890         (arm_push_dummy_call): Use type_align.
10891         (arm_gdbarch_init): Register arm_type_align gdbarch function.
10892
10893 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10894
10895         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10896         case.
10897         (pass_on_stack): Use type_align.
10898         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10899         function.
10900
10901 2019-04-23  Tom Tromey  <tromey@adacore.com>
10902
10903         * dwarf2read.c (line_header::file_name_at): Remove unused
10904         overload.
10905
10906 2019-04-23  Tom de Vries  <tdevries@suse.de>
10907
10908         PR gdb/24438
10909         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10910         invocation.
10911
10912
10913 2019-03-27  Ali Tamur  <tamur@google.com>
10914
10915         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10916         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10917         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10918         (dwarf_expr_context::get_addr_index): Likewise
10919         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10920         (symbol_needs_eval_context::get_addr_index): Likewise
10921         (disassemble_dwarf_expression): Add DW_OP_addrx
10922         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10923         (read_cutu_die_from_dwo): Update comment
10924         (skip_one_die): Add DW_FORM_addrx
10925         (read_attribute_value): Likewise
10926         (var_decode_location): Add DW_OP_addrx
10927         (dwarf2_const_value_attr): Add DW_FORM_addrx
10928         (dump_die_shallow): Likewise
10929         (dwarf2_fetch_constant_bytes): Likewise
10930         (decode_locdesc): Add DW_OP_addrx
10931         (skip_form_bytes): Add DW_FORM_addrx
10932
10933 2019-04-22  Ali Tamur  <tamur@google.com>
10934
10935         * MAINTAINERS (Write After Approval): Add self.
10936
10937 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
10938
10939         * solib-svr4.c (get_svr4_info): Add pspace parameter.
10940         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
10941         (open_symbol_file_object): Likewise.
10942         (svr4_default_sos): Add info parameter.
10943         (svr4_read_so_list): Likewise.
10944         (svr4_current_sos_direct): Adjust functions calls to pass down
10945         info.
10946         (svr4_current_sos_1): Add info parameter.
10947         (svr4_current_sos): Call get_svr4_info, pass info down to
10948         svr4_current_sos_1.
10949         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
10950         get_svr4_info.
10951         (svr4_in_dynsym_resolve_code): Pass current_program_space to
10952         get_svr4_info.
10953         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
10954         to get_svr4_info.
10955         (probes_table_remove_objfile_probes): Likewise.
10956         (register_solib_event_probe): Add info parameter.
10957         (solist_update_incremental): Pass info parameter down to
10958         svr4_read_so_list.
10959         (disable_probes_interface): Add info parameter.
10960         (svr4_handle_solib_event): Pass current_program_space to
10961         get_svr4_info.  Adjust disable_probes_interface cleanup.
10962         (svr4_create_probe_breakpoints): Add info parameter, pass it
10963         down to register_solib_event_probe.
10964         (svr4_create_solib_event_breakpoints): Add info parameter,
10965         pass it down to svr4_create_probe_breakpoints.
10966         (enable_break): Pass info down to
10967         svr4_create_solib_event_breakpoints.
10968         (svr4_solib_create_inferior_hook): Pass current_program_space to
10969         get_svr4_info.
10970         (svr4_clear_solib): Likewise.
10971
10972 2019-04-22  Pedro Alves  <palves@redhat.com>
10973
10974         * solib-svr4.c (svr4_free_objfile_observer): New.
10975         (probe_and_action::objfile): New field.
10976         (probes_table_htab_remove_objfile_probes)
10977         (probes_table_remove_objfile_probes): New functions.
10978         (register_solib_event_probe): Add 'objfile' parameter.  Store it
10979         in the new probe_and_action.  Don't store the probe in 'lookup'.
10980         (svr4_create_probe_breakpoints): Pass objfile to
10981         register_solib_event_probe.
10982         (_initialize_svr4_solib): Register a free_objfile observer.
10983
10984 2019-04-19  Tom Tromey  <tom@tromey.com>
10985
10986         * common/queue.h: Remove.
10987
10988 2019-04-19  Tom Tromey  <tom@tromey.com>
10989
10990         * event-loop.c: Don't include "common/queue.h".
10991
10992 2019-04-19  Tom Tromey  <tom@tromey.com>
10993
10994         * remote.c (remote_target): Use delete.
10995         * remote-notif.h: Include <list>, not "common/queue.h".
10996         (notif_client_p): Remove typedef.
10997         (remote_notif_state): Add constructor, destructor, initializer.
10998         <notif_queue>: Now a std::list.
10999         (remote_notif_state_xfree): Don't declare.
11000         * remote-notif.c (remote_notif_process, handle_notification)
11001         (remote_notif_state_allocate): Update.
11002         (~remote_notif_state): Rename from remote_notif_state_xfree.
11003
11004 2019-04-19  Tom Tromey  <tom@tromey.com>
11005
11006         * symfile.c (reread_symbols): Update.
11007         * objfiles.c (objfile_register_static_link)
11008         (objfile_lookup_static_link): Update
11009         (~objfile) Don't delete static_links.
11010         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11011
11012 2019-04-19  Tom Tromey  <tom@tromey.com>
11013
11014         * type-stack.h (struct type_stack) <insert>: Constify string.
11015         * type-stack.c (type_stack::insert): Constify string.
11016         * gdbtypes.h (lookup_template_type): Update.
11017         (address_space_name_to_int): Update.
11018         * gdbtypes.c (address_space_name_to_int): Make space_identifier
11019         const.
11020         (lookup_template_type): Make name const.
11021         * c-exp.y: Update rules.
11022         (lex_one_token, classify_name, classify_inner_name)
11023         (c_print_token): Update.
11024         * p-exp.y: Update rules.
11025         (yylex): Update.
11026         * f-exp.y: Update rules.
11027         (yylex): Update.
11028         * d-exp.y: Update rules.
11029         (lex_one_token, classify_name, classify_inner_name): Update.
11030         * parse.c (write_dollar_variable, copy_name): Return std::string.
11031         * parser-defs.h (copy_name): Change return type.
11032         * m2-exp.y: Update rules.
11033         (yylex): Update.
11034         * go-exp.y (lex_one_token): Update.
11035         Update rules.
11036         (classify_unsafe_function, classify_packaged_name)
11037         (classify_name, yylex): Update.
11038
11039 2019-04-19  Sergei Trofimovich <siarheit@google.com>
11040
11041         * configure.ac: add --enable-source-highlight switch.
11042         * configure: Regenerate.
11043         * top.c (print_gdb_version): plumb --enable-source-highlight
11044         status to "show configuration".
11045
11046 2019-04-19  Tom Tromey  <tromey@adacore.com>
11047
11048         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11049         Check ADA_TYPE_P.
11050         (empty_record, ada_template_to_fixed_record_type_1)
11051         (template_to_static_fixed_type)
11052         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11053         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11054         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11055         macros.
11056
11057 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
11058
11059         PR symtab/24423:
11060         * source.c (print_source_lines_base): Advance "iter" when a
11061         control character is seen.
11062
11063 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11064
11065         * inferior.h (struct infcall_suspend_state_deleter):
11066         Catch exception in destructor to avoid crash.
11067
11068 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11069
11070         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11071         close to the add_com "shell".
11072
11073 2019-04-18  Tom Tromey  <tromey@adacore.com>
11074
11075         * process-stratum-target.h (class process_stratum_target)
11076         <stratum>: Add "final".
11077
11078 2019-04-17  Tom Tromey  <tromey@adacore.com>
11079
11080         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11081         against nullptr before use.
11082
11083 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
11084
11085         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11086
11087 2019-04-17  Jim Wilson  <jimw@sifive.com>
11088             Andrew Burgess  <andrew.burgess@embecosm.com>
11089
11090         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11091         code read might fail, assume 4-byte breakpoint in that case.
11092
11093 2019-04-15  Leszek Swirski  <leszeks@google.com>
11094
11095         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11096         rather than a hand-rolled POD check when checking for forced MEMORY
11097         classification.
11098
11099 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11100
11101         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11102         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11103         function.
11104         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11105         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11106         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11107         declaration.
11108
11109 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11110
11111         * aarch64-linux-nat.c
11112         (aarch64_linux_nat_target::thread_architecture): Add override.
11113         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11114         each VQ.
11115
11116 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11117
11118         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11119
11120 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11121
11122         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11123         target types of size 96-bits, add some additional comments, and
11124         check that the builtin type we found was the correct size.
11125
11126 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
11127
11128         * utils.c (prompt_for_continue): Don't restore the styling at the
11129         end, as applied_style has the wrong value.  This fixes styling in
11130         long lists of file names that are interrupted by the "Continue?"
11131         prompt.
11132
11133 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11134
11135         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11136         * c-lang.c (c_language_defn): Likewise.
11137         (cplus_language_defn): Likewise.
11138         (asm_language_defn): Likewise.
11139         (minimal_language_defn): Likewise.
11140         * d-lang.c (d_language_defn): Likewise.
11141         * f-lang.c (f_language_defn): Likewise.
11142         * go-lang.c (go_language_defn): Likewise.
11143         * language.c (unknown_language_defn): Likewise.
11144         (auto_language_defn): Likewise.
11145         * language.h (struct language_defn): Remove la_magic field.
11146         (LANG_MAGIC): Delete.
11147         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11148         * objc-lang.c (objc_language_defn): Likewise.
11149         * opencl-lang.c (opencl_language_defn): Likewise.
11150         * p-lang.c (pascal_language_defn): Likewise.
11151         * rust-lang.c (rust_language_defn): Likewise.
11152
11153 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11154
11155         * riscv-tdep.c (riscv_type_align): New function.
11156         (riscv_type_alignment): Delete.
11157         (riscv_arg_location): Use 'type_align'.
11158         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11159
11160 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11161
11162         * gdbtypes.c (type_align): A struct with no non-static fields also
11163         has alignment of 1.
11164
11165 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11166
11167         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11168         component to 0.
11169         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11170         member.
11171         (riscv_struct_info::analyse): New implementation using new
11172         analyse_inner member function.
11173         (riscv_struct_info::field_offset): New member function.
11174         (riscv_struct_info::m_offsets): New member variable.
11175         (riscv_struct_info::analyse_inner): New private member function,
11176         takes the old implementation of riscv_struct_info::analyse but
11177         extended to track field offsets.
11178         (riscv_call_arg_struct): Update the struct folding special cases
11179         to handle cases where empty C++ structs, which are non-zero
11180         length, are found.
11181         (riscv_arg_location): Initialise the length of each location, a
11182         non-zero length now indicates the location is in use.
11183         (riscv_push_dummy_call): Allow for the first location having a
11184         non-zero offset when setting up arguments.
11185         (riscv_return_value): Likewise, but for return values.
11186
11187 2019-04-11  Tom Tromey  <tromey@adacore.com>
11188
11189         * utils.c (internal_vproblem): Make "msg" const.
11190
11191 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
11192
11193         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11194         * trad-frame.c (trad_frame_reset_saved_regs): New function.
11195         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11196         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11197
11198 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
11199
11200         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11201         function.
11202         (fill_gregset): Call amd64_linux_collect_native_gregset instead
11203         of amd64_collect_native_gregset.
11204         (amd64_linux_nat_target::store_registers): Likewise.
11205
11206 2019-04-10  Tom Tromey  <tom@tromey.com>
11207
11208         * symtab.c (lookup_global_symbol_from_objfile)
11209         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11210         * objfiles.h (class separate_debug_iterator): New.
11211         (class separate_debug_range): New.
11212         (struct objfile) <separate_debug_objfiles>: New method.
11213         (objfile_separate_debug_iterate): Don't declare.
11214         * objfiles.c (separate_debug_iterator::operator++): Rename from
11215         objfile_separate_debug_iterate.
11216         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11217         iterator.
11218         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11219         iterator.
11220
11221 2019-04-10  Tom Tromey  <tom@tromey.com>
11222
11223         * symfile.c (reread_symbols): Remove old comment.
11224         * objfiles.c (free_all_objfiles): Fix a typo.
11225
11226 2019-04-10  Tom Tromey  <tom@tromey.com>
11227
11228         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11229         * minsyms.c (lookup_minimal_symbol): Use foreach.
11230         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11231         (lookup_minimal_symbol_solib_trampoline): Likewise.
11232         * symfile.c (reread_symbols): Use foreach.
11233
11234 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
11235             Tom Tromey  <tromey@adacore.com>
11236
11237         PR rust/24414:
11238         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11239         (rust_lex_int_test): Change "value" to be LONGEST.
11240         (rust_lex_tests): Add test for long integer literal.
11241
11242 2019-04-09  Tom Tromey  <tromey@adacore.com>
11243
11244         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11245         to bool.
11246         (extended_remote_target::attach): Update.
11247         (remote_target::remote_notice_new_inferior): Update.
11248         (remote_target::add_current_inferior_and_thread): Update.
11249         * inferior.c (exit_inferior_1): Use "false".
11250         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11251
11252 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
11253
11254         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11255         the "start" command.
11256
11257 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11258
11259         * python/py-inferior.c (infpy_thread_from_thread_handle):
11260         Adjust comments to reflect renaming of thread_from_thread_handle
11261         to thread_from_handle.  Adjust keywords.  Fix type error message.
11262         (inferior_object_methods): Add thread_from_handle.  Retain
11263         thread_from_thread_handle, but mark it as deprecated.
11264
11265 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11266
11267         * gdbthread.h (find_thread_by_handle): Revise declaration.
11268         * thread.c (find_thread_by_handle): Likewise.  Adjust
11269         implementation too.
11270         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11271         support for buffer objects as handles.
11272
11273 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11274
11275         * python/py-infthread.c (thpy_thread_handle): New function.
11276         (thread_object_methods): Register thpy_thread_handle.
11277
11278 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11279
11280         * gdbthread.h (thread_to_thread_handle): Declare.
11281         * thread.c (gdbtypes.h): Include.
11282         (thread_to_thread_handle): New function.
11283
11284         * target.h (struct target_ops): Add thread_info_to_thread_handle.
11285         (target_thread_info_to_thread_handle): Declare.
11286         * target.c (target_thread_info_to_thread_handle): New function.
11287         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11288         * target-delegates.c: Regenerate.
11289
11290         * linux-thread-db.c (class thread_db_target): Add method
11291         thread_info_to_thread_handle.
11292         (thread_db_target::thread_info_to_thread_handle): Define.
11293         * remote.c (class remote_target): Add new method
11294         thread_info_to_thread_handle.
11295         (remote_target::thread_info_to_thread_handle): Define.
11296
11297 2019-04-08  Pedro Alves  <palves@redhat.com>
11298
11299         * common/common-exceptions.c (throw_exception): Don't create
11300         named object to throw; throw directly.
11301         (throw_it): Likewise.  Don't initialize gdb_exception::message
11302         here, with new; pass FMT and AP to the ctor instead.
11303         * common/common-exceptions.h: Include <string>.
11304         (gdb_exception::gdb_exception(enum return_reason, enum errors,
11305         const char *, va_list)): New ctor.  Use std::make_shared.
11306         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11307         errors)): Delete.
11308         (gdb_exception_error::gdb_exception_error(enum errors, const char
11309         *, va_list)): New.
11310         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11311         Add assertion.
11312         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11313         errors)): Delete.
11314         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11315         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11316         Add assertion.
11317
11318 2019-04-08  Tom Tromey  <tom@tromey.com>
11319
11320         * valops.c (value_rtti_indirect_type): Replace throw_exception
11321         with throw.
11322         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11323         with throw.
11324         * thread.c (thr_try_catch_cmd): Replace throw_exception with
11325         throw.
11326         * target.c (target_translate_tls_address): Replace throw_exception
11327         with throw.
11328         * stack.c (frame_apply_command_count): Replace throw_exception
11329         with throw.
11330         * solib-spu.c (append_ocl_sos): Replace throw_exception with
11331         throw.
11332         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11333         with throw.
11334         * rs6000-tdep.c (rs6000_frame_cache)
11335         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11336         * remote.c: Replace throw_exception with throw.
11337         * record-full.c (record_full_message, record_full_wait_1)
11338         (record_full_restore): Replace throw_exception with throw.
11339         * record-btrace.c:
11340         (get_thread_current_frame_id, record_btrace_start_replaying)
11341         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11342         (cmd_record_btrace_start): Replace throw_exception with throw.
11343         * parse.c (parse_exp_in_context_1): Replace throw_exception with
11344         throw.
11345         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11346         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11347         * linespec.c:
11348         (find_linespec_symbols): Replace throw_exception with throw.
11349         * infrun.c (displaced_step_prepare, resume): Replace
11350         throw_exception with throw.
11351         * infcmd.c (post_create_inferior): Replace throw_exception with
11352         throw.
11353         * inf-loop.c (inferior_event_handler): Replace throw_exception
11354         with throw.
11355         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11356         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11357         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11358         (get_prev_frame_always, get_frame_pc_if_available)
11359         (get_frame_address_in_block_if_available, get_frame_language):
11360         Replace throw_exception with throw.
11361         * frame-unwind.c (frame_unwind_try_unwinder): Replace
11362         throw_exception with throw.
11363         * eval.c (fetch_subexp_value, evaluate_var_value)
11364         (evaluate_funcall, evaluate_subexp_standard): Replace
11365         throw_exception with throw.
11366         * dwarf2loc.c (call_site_find_chain)
11367         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11368         Replace throw_exception with throw.
11369         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11370         with throw.
11371         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11372         throw.
11373         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11374         * completer.c (complete_line_internal): Replace throw_exception
11375         with throw.
11376         * compile/compile-object-run.c (compile_object_run): Replace
11377         throw_exception with throw.
11378         * cli/cli-script.c (process_next_line): Replace throw_exception
11379         with throw.
11380         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11381         (btrace_enable, btrace_maint_update_pt_packets): Replace
11382         throw_exception with throw.
11383         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11384         throw_exception with throw.
11385         * break-catch-throw.c (re_set_exception_catchpoint): Replace
11386         throw_exception with throw.
11387         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11388         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11389         * aarch64-tdep.c (aarch64_make_prologue_cache)
11390         (aarch64_make_stub_cache): Replace throw_exception with throw.
11391
11392 2019-04-08  Tom Tromey  <tom@tromey.com>
11393
11394         * common/common-exceptions.c (throw_exception): Rename from
11395         throw_exception_cxx.  Remove old copy.  Make argument const.
11396         (throw_it): Create and throw exception objects directly.
11397         * common/common-exceptions.h (throw_exception): Make argument
11398         const.
11399         (struct gdb_exception_error): Add constructor.
11400         (struct gdb_exception_quit): Add constructor.
11401
11402 2019-04-08  Tom Tromey  <tom@tromey.com>
11403
11404         * common/common-exceptions.h (exception_rethrow): Don't declare.
11405         (TRY_SJLJ): Update comment.
11406         (TRY, CATCH, END_CATCH): Remove.
11407         * common/common-exceptions.c (exception_rethrow): Remove.
11408
11409 2019-04-08  Tom Tromey  <tom@tromey.com>
11410
11411         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11412         Remove.
11413         (gdb_exception_error): Rename from
11414         gdb_exception_RETURN_MASK_ERROR.
11415         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11416         (gdb_quit_bad_alloc): Update.
11417         * aarch64-tdep.c: Update.
11418         * ada-lang.c: Update.
11419         * ada-typeprint.c: Update.
11420         * ada-valprint.c: Update.
11421         * amd64-tdep.c: Update.
11422         * arch-utils.c: Update.
11423         * break-catch-throw.c: Update.
11424         * breakpoint.c: Update.
11425         * btrace.c: Update.
11426         * c-varobj.c: Update.
11427         * cli/cli-cmds.c: Update.
11428         * cli/cli-interp.c: Update.
11429         * cli/cli-script.c: Update.
11430         * common/common-exceptions.c: Update.
11431         * common/new-op.c: Update.
11432         * common/selftest.c: Update.
11433         * compile/compile-c-symbols.c: Update.
11434         * compile/compile-cplus-symbols.c: Update.
11435         * compile/compile-object-load.c: Update.
11436         * compile/compile-object-run.c: Update.
11437         * completer.c: Update.
11438         * corelow.c: Update.
11439         * cp-abi.c: Update.
11440         * cp-support.c: Update.
11441         * cp-valprint.c: Update.
11442         * darwin-nat.c: Update.
11443         * disasm-selftests.c: Update.
11444         * dtrace-probe.c: Update.
11445         * dwarf-index-cache.c: Update.
11446         * dwarf-index-write.c: Update.
11447         * dwarf2-frame-tailcall.c: Update.
11448         * dwarf2-frame.c: Update.
11449         * dwarf2loc.c: Update.
11450         * dwarf2read.c: Update.
11451         * eval.c: Update.
11452         * event-loop.c: Update.
11453         * event-top.c: Update.
11454         * exec.c: Update.
11455         * f-valprint.c: Update.
11456         * fbsd-tdep.c: Update.
11457         * frame-unwind.c: Update.
11458         * frame.c: Update.
11459         * gdbtypes.c: Update.
11460         * gnu-v3-abi.c: Update.
11461         * guile/guile-internal.h: Update.
11462         * guile/scm-block.c: Update.
11463         * guile/scm-breakpoint.c: Update.
11464         * guile/scm-cmd.c: Update.
11465         * guile/scm-disasm.c: Update.
11466         * guile/scm-frame.c: Update.
11467         * guile/scm-lazy-string.c: Update.
11468         * guile/scm-math.c: Update.
11469         * guile/scm-param.c: Update.
11470         * guile/scm-ports.c: Update.
11471         * guile/scm-pretty-print.c: Update.
11472         * guile/scm-symbol.c: Update.
11473         * guile/scm-symtab.c: Update.
11474         * guile/scm-type.c: Update.
11475         * guile/scm-value.c: Update.
11476         * i386-linux-tdep.c: Update.
11477         * i386-tdep.c: Update.
11478         * inf-loop.c: Update.
11479         * infcall.c: Update.
11480         * infcmd.c: Update.
11481         * infrun.c: Update.
11482         * jit.c: Update.
11483         * language.c: Update.
11484         * linespec.c: Update.
11485         * linux-fork.c: Update.
11486         * linux-nat.c: Update.
11487         * linux-tdep.c: Update.
11488         * linux-thread-db.c: Update.
11489         * main.c: Update.
11490         * mi/mi-cmd-break.c: Update.
11491         * mi/mi-cmd-stack.c: Update.
11492         * mi/mi-interp.c: Update.
11493         * mi/mi-main.c: Update.
11494         * objc-lang.c: Update.
11495         * p-valprint.c: Update.
11496         * parse.c: Update.
11497         * ppc-linux-tdep.c: Update.
11498         * printcmd.c: Update.
11499         * python/py-arch.c: Update.
11500         * python/py-breakpoint.c: Update.
11501         * python/py-cmd.c: Update.
11502         * python/py-finishbreakpoint.c: Update.
11503         * python/py-frame.c: Update.
11504         * python/py-framefilter.c: Update.
11505         * python/py-gdb-readline.c: Update.
11506         * python/py-inferior.c: Update.
11507         * python/py-infthread.c: Update.
11508         * python/py-lazy-string.c: Update.
11509         * python/py-linetable.c: Update.
11510         * python/py-objfile.c: Update.
11511         * python/py-param.c: Update.
11512         * python/py-prettyprint.c: Update.
11513         * python/py-progspace.c: Update.
11514         * python/py-record-btrace.c: Update.
11515         * python/py-record.c: Update.
11516         * python/py-symbol.c: Update.
11517         * python/py-type.c: Update.
11518         * python/py-unwind.c: Update.
11519         * python/py-utils.c: Update.
11520         * python/py-value.c: Update.
11521         * python/python.c: Update.
11522         * record-btrace.c: Update.
11523         * record-full.c: Update.
11524         * remote-fileio.c: Update.
11525         * remote.c: Update.
11526         * riscv-tdep.c: Update.
11527         * rs6000-aix-tdep.c: Update.
11528         * rs6000-tdep.c: Update.
11529         * rust-exp.y: Update.
11530         * rust-lang.c: Update.
11531         * s390-tdep.c: Update.
11532         * selftest-arch.c: Update.
11533         * solib-dsbt.c: Update.
11534         * solib-frv.c: Update.
11535         * solib-spu.c: Update.
11536         * solib-svr4.c: Update.
11537         * solib.c: Update.
11538         * sparc64-linux-tdep.c: Update.
11539         * stack.c: Update.
11540         * symfile-mem.c: Update.
11541         * symmisc.c: Update.
11542         * target.c: Update.
11543         * thread.c: Update.
11544         * top.c: Update.
11545         * tracefile-tfile.c: Update.
11546         * tui/tui.c: Update.
11547         * typeprint.c: Update.
11548         * unittests/cli-utils-selftests.c: Update.
11549         * unittests/parse-connection-spec-selftests.c: Update.
11550         * valops.c: Update.
11551         * valprint.c: Update.
11552         * value.c: Update.
11553         * varobj.c: Update.
11554         * windows-nat.c: Update.
11555         * x86-linux-nat.c: Update.
11556         * xml-support.c: Update.
11557
11558 2019-04-08  Tom Tromey  <tom@tromey.com>
11559
11560         * xml-support.c: Use C++ exception handling.
11561         * x86-linux-nat.c: Use C++ exception handling.
11562         * windows-nat.c: Use C++ exception handling.
11563         * varobj.c: Use C++ exception handling.
11564         * value.c: Use C++ exception handling.
11565         * valprint.c: Use C++ exception handling.
11566         * valops.c: Use C++ exception handling.
11567         * unittests/parse-connection-spec-selftests.c: Use C++ exception
11568         handling.
11569         * unittests/cli-utils-selftests.c: Use C++ exception handling.
11570         * typeprint.c: Use C++ exception handling.
11571         * tui/tui.c: Use C++ exception handling.
11572         * tracefile-tfile.c: Use C++ exception handling.
11573         * top.c: Use C++ exception handling.
11574         * thread.c: Use C++ exception handling.
11575         * target.c: Use C++ exception handling.
11576         * symmisc.c: Use C++ exception handling.
11577         * symfile-mem.c: Use C++ exception handling.
11578         * stack.c: Use C++ exception handling.
11579         * sparc64-linux-tdep.c: Use C++ exception handling.
11580         * solib.c: Use C++ exception handling.
11581         * solib-svr4.c: Use C++ exception handling.
11582         * solib-spu.c: Use C++ exception handling.
11583         * solib-frv.c: Use C++ exception handling.
11584         * solib-dsbt.c: Use C++ exception handling.
11585         * selftest-arch.c: Use C++ exception handling.
11586         * s390-tdep.c: Use C++ exception handling.
11587         * rust-lang.c: Use C++ exception handling.
11588         * rust-exp.y: Use C++ exception handling.
11589         * rs6000-tdep.c: Use C++ exception handling.
11590         * rs6000-aix-tdep.c: Use C++ exception handling.
11591         * riscv-tdep.c: Use C++ exception handling.
11592         * remote.c: Use C++ exception handling.
11593         * remote-fileio.c: Use C++ exception handling.
11594         * record-full.c: Use C++ exception handling.
11595         * record-btrace.c: Use C++ exception handling.
11596         * python/python.c: Use C++ exception handling.
11597         * python/py-value.c: Use C++ exception handling.
11598         * python/py-utils.c: Use C++ exception handling.
11599         * python/py-unwind.c: Use C++ exception handling.
11600         * python/py-type.c: Use C++ exception handling.
11601         * python/py-symbol.c: Use C++ exception handling.
11602         * python/py-record.c: Use C++ exception handling.
11603         * python/py-record-btrace.c: Use C++ exception handling.
11604         * python/py-progspace.c: Use C++ exception handling.
11605         * python/py-prettyprint.c: Use C++ exception handling.
11606         * python/py-param.c: Use C++ exception handling.
11607         * python/py-objfile.c: Use C++ exception handling.
11608         * python/py-linetable.c: Use C++ exception handling.
11609         * python/py-lazy-string.c: Use C++ exception handling.
11610         * python/py-infthread.c: Use C++ exception handling.
11611         * python/py-inferior.c: Use C++ exception handling.
11612         * python/py-gdb-readline.c: Use C++ exception handling.
11613         * python/py-framefilter.c: Use C++ exception handling.
11614         * python/py-frame.c: Use C++ exception handling.
11615         * python/py-finishbreakpoint.c: Use C++ exception handling.
11616         * python/py-cmd.c: Use C++ exception handling.
11617         * python/py-breakpoint.c: Use C++ exception handling.
11618         * python/py-arch.c: Use C++ exception handling.
11619         * printcmd.c: Use C++ exception handling.
11620         * ppc-linux-tdep.c: Use C++ exception handling.
11621         * parse.c: Use C++ exception handling.
11622         * p-valprint.c: Use C++ exception handling.
11623         * objc-lang.c: Use C++ exception handling.
11624         * mi/mi-main.c: Use C++ exception handling.
11625         * mi/mi-interp.c: Use C++ exception handling.
11626         * mi/mi-cmd-stack.c: Use C++ exception handling.
11627         * mi/mi-cmd-break.c: Use C++ exception handling.
11628         * main.c: Use C++ exception handling.
11629         * linux-thread-db.c: Use C++ exception handling.
11630         * linux-tdep.c: Use C++ exception handling.
11631         * linux-nat.c: Use C++ exception handling.
11632         * linux-fork.c: Use C++ exception handling.
11633         * linespec.c: Use C++ exception handling.
11634         * language.c: Use C++ exception handling.
11635         * jit.c: Use C++ exception handling.
11636         * infrun.c: Use C++ exception handling.
11637         * infcmd.c: Use C++ exception handling.
11638         * infcall.c: Use C++ exception handling.
11639         * inf-loop.c: Use C++ exception handling.
11640         * i386-tdep.c: Use C++ exception handling.
11641         * i386-linux-tdep.c: Use C++ exception handling.
11642         * guile/scm-value.c: Use C++ exception handling.
11643         * guile/scm-type.c: Use C++ exception handling.
11644         * guile/scm-symtab.c: Use C++ exception handling.
11645         * guile/scm-symbol.c: Use C++ exception handling.
11646         * guile/scm-pretty-print.c: Use C++ exception handling.
11647         * guile/scm-ports.c: Use C++ exception handling.
11648         * guile/scm-param.c: Use C++ exception handling.
11649         * guile/scm-math.c: Use C++ exception handling.
11650         * guile/scm-lazy-string.c: Use C++ exception handling.
11651         * guile/scm-frame.c: Use C++ exception handling.
11652         * guile/scm-disasm.c: Use C++ exception handling.
11653         * guile/scm-cmd.c: Use C++ exception handling.
11654         * guile/scm-breakpoint.c: Use C++ exception handling.
11655         * guile/scm-block.c: Use C++ exception handling.
11656         * guile/guile-internal.h: Use C++ exception handling.
11657         * gnu-v3-abi.c: Use C++ exception handling.
11658         * gdbtypes.c: Use C++ exception handling.
11659         * frame.c: Use C++ exception handling.
11660         * frame-unwind.c: Use C++ exception handling.
11661         * fbsd-tdep.c: Use C++ exception handling.
11662         * f-valprint.c: Use C++ exception handling.
11663         * exec.c: Use C++ exception handling.
11664         * event-top.c: Use C++ exception handling.
11665         * event-loop.c: Use C++ exception handling.
11666         * eval.c: Use C++ exception handling.
11667         * dwarf2read.c: Use C++ exception handling.
11668         * dwarf2loc.c: Use C++ exception handling.
11669         * dwarf2-frame.c: Use C++ exception handling.
11670         * dwarf2-frame-tailcall.c: Use C++ exception handling.
11671         * dwarf-index-write.c: Use C++ exception handling.
11672         * dwarf-index-cache.c: Use C++ exception handling.
11673         * dtrace-probe.c: Use C++ exception handling.
11674         * disasm-selftests.c: Use C++ exception handling.
11675         * darwin-nat.c: Use C++ exception handling.
11676         * cp-valprint.c: Use C++ exception handling.
11677         * cp-support.c: Use C++ exception handling.
11678         * cp-abi.c: Use C++ exception handling.
11679         * corelow.c: Use C++ exception handling.
11680         * completer.c: Use C++ exception handling.
11681         * compile/compile-object-run.c: Use C++ exception handling.
11682         * compile/compile-object-load.c: Use C++ exception handling.
11683         * compile/compile-cplus-symbols.c: Use C++ exception handling.
11684         * compile/compile-c-symbols.c: Use C++ exception handling.
11685         * common/selftest.c: Use C++ exception handling.
11686         * common/new-op.c: Use C++ exception handling.
11687         * cli/cli-script.c: Use C++ exception handling.
11688         * cli/cli-interp.c: Use C++ exception handling.
11689         * cli/cli-cmds.c: Use C++ exception handling.
11690         * c-varobj.c: Use C++ exception handling.
11691         * btrace.c: Use C++ exception handling.
11692         * breakpoint.c: Use C++ exception handling.
11693         * break-catch-throw.c: Use C++ exception handling.
11694         * arch-utils.c: Use C++ exception handling.
11695         * amd64-tdep.c: Use C++ exception handling.
11696         * ada-valprint.c: Use C++ exception handling.
11697         * ada-typeprint.c: Use C++ exception handling.
11698         * ada-lang.c: Use C++ exception handling.
11699         * aarch64-tdep.c: Use C++ exception handling.
11700
11701 2019-04-08  Tom Tromey  <tom@tromey.com>
11702
11703         * xml-support.c (gdb_xml_parser::parse): Update.
11704         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11705         * value.c (show_convenience): Update.
11706         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11707         (test_parse_flags_qcs): Update.
11708         * thread.c (thr_try_catch_cmd): Update.
11709         * target.c (target_translate_tls_address): Update.
11710         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11711         (info_frame_command_core, frame_apply_command_count): Update.
11712         * rust-exp.y (rust_lex_exception_test): Update.
11713         * riscv-tdep.c (riscv_print_one_register_info): Update.
11714         * remote.c (remote_target::enable_btrace): Update.
11715         * record-btrace.c (record_btrace_enable_warn): Update.
11716         * python/py-utils.c (gdbpy_convert_exception): Update.
11717         * printcmd.c (do_one_display, print_variable_and_value): Update.
11718         * mi/mi-main.c (mi_print_exception): Update.
11719         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11720         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11721         * linux-nat.c (linux_nat_target::attach): Update.
11722         * linux-fork.c (class scoped_switch_fork_info): Update.
11723         * infrun.c (displaced_step_prepare): Update.
11724         * infcall.c (call_function_by_hand_dummy): Update.
11725         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11726         * gnu-v3-abi.c (print_one_vtable): Update.
11727         * frame.c (get_prev_frame_always): Update.
11728         * f-valprint.c (info_common_command_for_block): Update.
11729         * exec.c (try_open_exec_file): Update.
11730         * exceptions.c (print_exception, exception_print)
11731         (exception_fprintf, exception_print_same): Update.
11732         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11733         * dwarf-index-cache.c (index_cache::store)
11734         (index_cache::lookup_gdb_index): Update.
11735         * darwin-nat.c (maybe_cache_shell): Update.
11736         * cp-valprint.c (cp_print_value_fields): Update.
11737         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11738         (gcc_cplus_symbol_address): Update.
11739         * compile/compile-c-symbols.c (gcc_convert_symbol)
11740         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11741         * common/selftest.c: Update.
11742         * common/common-exceptions.h (struct gdb_exception) <message>: Now
11743         a std::string.
11744         (exception_try_scope_entry, exception_try_scope_exit): Don't
11745         declare.
11746         (struct exception_try_scope): Remove.
11747         (TRY): Don't use exception_try_scope.
11748         (struct gdb_exception): Add constructor, operator=.
11749         <what>: New method.
11750         (struct gdb_exception_RETURN_MASK_ALL)
11751         (struct gdb_exception_RETURN_MASK_ERROR)
11752         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11753         (struct gdb_quit_bad_alloc): Update.
11754         * common/common-exceptions.c (exception_none): Change
11755         initializer.
11756         (struct catcher) <state, exception>: Initialize inline.
11757         <prev>: Remove member.
11758         (current_catcher): Remove.
11759         (catchers): New global.
11760         (exceptions_state_mc_init): Simplify.
11761         (catcher_pop): Remove.
11762         (exceptions_state_mc, exceptions_state_mc_catch): Update.
11763         (try_scope_depth, exception_try_scope_entry)
11764         (exception_try_scope_exit): Remove.
11765         (throw_exception_sjlj): Update.
11766         (exception_messages, exception_messages_size): Remove.
11767         (throw_it): Simplify.
11768         (gdb_exception_sliced_copy): Remove.
11769         (throw_exception_cxx): Update.
11770         * cli/cli-script.c (script_from_file): Update.
11771         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11772         Update.
11773         * ada-valprint.c (ada_val_print): Update.
11774         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11775         (create_excep_cond_exprs): Update.
11776
11777 2019-04-08  Tom Tromey  <tom@tromey.com>
11778
11779         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11780         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11781         (TRY, CATCH, END_CATCH): Remove some definitions.
11782         * common/common-exceptions.c: Don't use GDB_XCPT.
11783         (catcher_list_size): Remove.
11784         (throw_exception, throw_it): Simplify.
11785
11786 2019-04-05  Tom Tromey  <tom@tromey.com>
11787
11788         Revert the header-sorting patch.
11789         * ft32-tdep.c: Revert.
11790         * frv-tdep.c: Revert.
11791         * frv-linux-tdep.c: Revert.
11792         * frame.c: Revert.
11793         * frame-unwind.c: Revert.
11794         * frame-base.c: Revert.
11795         * fork-child.c: Revert.
11796         * findvar.c: Revert.
11797         * findcmd.c: Revert.
11798         * filesystem.c: Revert.
11799         * filename-seen-cache.h: Revert.
11800         * filename-seen-cache.c: Revert.
11801         * fbsd-tdep.c: Revert.
11802         * fbsd-nat.h: Revert.
11803         * fbsd-nat.c: Revert.
11804         * f-valprint.c: Revert.
11805         * f-typeprint.c: Revert.
11806         * f-lang.c: Revert.
11807         * extension.h: Revert.
11808         * extension.c: Revert.
11809         * extension-priv.h: Revert.
11810         * expprint.c: Revert.
11811         * exec.h: Revert.
11812         * exec.c: Revert.
11813         * exceptions.c: Revert.
11814         * event-top.c: Revert.
11815         * event-loop.c: Revert.
11816         * eval.c: Revert.
11817         * elfread.c: Revert.
11818         * dwarf2read.h: Revert.
11819         * dwarf2read.c: Revert.
11820         * dwarf2loc.c: Revert.
11821         * dwarf2expr.h: Revert.
11822         * dwarf2expr.c: Revert.
11823         * dwarf2-frame.c: Revert.
11824         * dwarf2-frame-tailcall.c: Revert.
11825         * dwarf-index-write.h: Revert.
11826         * dwarf-index-write.c: Revert.
11827         * dwarf-index-common.c: Revert.
11828         * dwarf-index-cache.h: Revert.
11829         * dwarf-index-cache.c: Revert.
11830         * dummy-frame.c: Revert.
11831         * dtrace-probe.c: Revert.
11832         * disasm.h: Revert.
11833         * disasm.c: Revert.
11834         * disasm-selftests.c: Revert.
11835         * dictionary.c: Revert.
11836         * dicos-tdep.c: Revert.
11837         * demangle.c: Revert.
11838         * dcache.h: Revert.
11839         * dcache.c: Revert.
11840         * darwin-nat.h: Revert.
11841         * darwin-nat.c: Revert.
11842         * darwin-nat-info.c: Revert.
11843         * d-valprint.c: Revert.
11844         * d-namespace.c: Revert.
11845         * d-lang.c: Revert.
11846         * ctf.c: Revert.
11847         * csky-tdep.c: Revert.
11848         * csky-linux-tdep.c: Revert.
11849         * cris-tdep.c: Revert.
11850         * cris-linux-tdep.c: Revert.
11851         * cp-valprint.c: Revert.
11852         * cp-support.c: Revert.
11853         * cp-namespace.c: Revert.
11854         * cp-abi.c: Revert.
11855         * corelow.c: Revert.
11856         * corefile.c: Revert.
11857         * continuations.c: Revert.
11858         * completer.h: Revert.
11859         * completer.c: Revert.
11860         * complaints.c: Revert.
11861         * coffread.c: Revert.
11862         * coff-pe-read.c: Revert.
11863         * cli-out.h: Revert.
11864         * cli-out.c: Revert.
11865         * charset.c: Revert.
11866         * c-varobj.c: Revert.
11867         * c-valprint.c: Revert.
11868         * c-typeprint.c: Revert.
11869         * c-lang.c: Revert.
11870         * buildsym.c: Revert.
11871         * buildsym-legacy.c: Revert.
11872         * build-id.h: Revert.
11873         * build-id.c: Revert.
11874         * btrace.c: Revert.
11875         * bsd-uthread.c: Revert.
11876         * breakpoint.h: Revert.
11877         * breakpoint.c: Revert.
11878         * break-catch-throw.c: Revert.
11879         * break-catch-syscall.c: Revert.
11880         * break-catch-sig.c: Revert.
11881         * blockframe.c: Revert.
11882         * block.c: Revert.
11883         * bfin-tdep.c: Revert.
11884         * bfin-linux-tdep.c: Revert.
11885         * bfd-target.c: Revert.
11886         * bcache.c: Revert.
11887         * ax-general.c: Revert.
11888         * ax-gdb.h: Revert.
11889         * ax-gdb.c: Revert.
11890         * avr-tdep.c: Revert.
11891         * auxv.c: Revert.
11892         * auto-load.c: Revert.
11893         * arm-wince-tdep.c: Revert.
11894         * arm-tdep.c: Revert.
11895         * arm-symbian-tdep.c: Revert.
11896         * arm-pikeos-tdep.c: Revert.
11897         * arm-obsd-tdep.c: Revert.
11898         * arm-nbsd-tdep.c: Revert.
11899         * arm-nbsd-nat.c: Revert.
11900         * arm-linux-tdep.c: Revert.
11901         * arm-linux-nat.c: Revert.
11902         * arm-fbsd-tdep.c: Revert.
11903         * arm-fbsd-nat.c: Revert.
11904         * arm-bsd-tdep.c: Revert.
11905         * arch-utils.c: Revert.
11906         * arc-tdep.c: Revert.
11907         * arc-newlib-tdep.c: Revert.
11908         * annotate.h: Revert.
11909         * annotate.c: Revert.
11910         * amd64-windows-tdep.c: Revert.
11911         * amd64-windows-nat.c: Revert.
11912         * amd64-tdep.c: Revert.
11913         * amd64-sol2-tdep.c: Revert.
11914         * amd64-obsd-tdep.c: Revert.
11915         * amd64-obsd-nat.c: Revert.
11916         * amd64-nbsd-tdep.c: Revert.
11917         * amd64-nbsd-nat.c: Revert.
11918         * amd64-nat.c: Revert.
11919         * amd64-linux-tdep.c: Revert.
11920         * amd64-linux-nat.c: Revert.
11921         * amd64-fbsd-tdep.c: Revert.
11922         * amd64-fbsd-nat.c: Revert.
11923         * amd64-dicos-tdep.c: Revert.
11924         * amd64-darwin-tdep.c: Revert.
11925         * amd64-bsd-nat.c: Revert.
11926         * alpha-tdep.c: Revert.
11927         * alpha-obsd-tdep.c: Revert.
11928         * alpha-nbsd-tdep.c: Revert.
11929         * alpha-mdebug-tdep.c: Revert.
11930         * alpha-linux-tdep.c: Revert.
11931         * alpha-linux-nat.c: Revert.
11932         * alpha-bsd-tdep.c: Revert.
11933         * alpha-bsd-nat.c: Revert.
11934         * aix-thread.c: Revert.
11935         * agent.c: Revert.
11936         * addrmap.c: Revert.
11937         * ada-varobj.c: Revert.
11938         * ada-valprint.c: Revert.
11939         * ada-typeprint.c: Revert.
11940         * ada-tasks.c: Revert.
11941         * ada-lang.c: Revert.
11942         * aarch64-tdep.c: Revert.
11943         * aarch64-ravenscar-thread.c: Revert.
11944         * aarch64-newlib-tdep.c: Revert.
11945         * aarch64-linux-tdep.c: Revert.
11946         * aarch64-linux-nat.c: Revert.
11947         * aarch64-fbsd-tdep.c: Revert.
11948         * aarch64-fbsd-nat.c: Revert.
11949         * aarch32-linux-nat.c: Revert.
11950
11951 2019-04-05  Tom Tromey  <tom@tromey.com>
11952
11953         * ft32-tdep.c: Sort headers.
11954         * frv-tdep.c: Sort headers.
11955         * frv-linux-tdep.c: Sort headers.
11956         * frame.c: Sort headers.
11957         * frame-unwind.c: Sort headers.
11958         * frame-base.c: Sort headers.
11959         * fork-child.c: Sort headers.
11960         * findvar.c: Sort headers.
11961         * findcmd.c: Sort headers.
11962         * filesystem.c: Sort headers.
11963         * filename-seen-cache.h: Sort headers.
11964         * filename-seen-cache.c: Sort headers.
11965         * fbsd-tdep.c: Sort headers.
11966         * fbsd-nat.h: Sort headers.
11967         * fbsd-nat.c: Sort headers.
11968         * f-valprint.c: Sort headers.
11969         * f-typeprint.c: Sort headers.
11970         * f-lang.c: Sort headers.
11971         * extension.h: Sort headers.
11972         * extension.c: Sort headers.
11973         * extension-priv.h: Sort headers.
11974         * expprint.c: Sort headers.
11975         * exec.h: Sort headers.
11976         * exec.c: Sort headers.
11977         * exceptions.c: Sort headers.
11978         * event-top.c: Sort headers.
11979         * event-loop.c: Sort headers.
11980         * eval.c: Sort headers.
11981         * elfread.c: Sort headers.
11982         * dwarf2read.h: Sort headers.
11983         * dwarf2read.c: Sort headers.
11984         * dwarf2loc.c: Sort headers.
11985         * dwarf2expr.h: Sort headers.
11986         * dwarf2expr.c: Sort headers.
11987         * dwarf2-frame.c: Sort headers.
11988         * dwarf2-frame-tailcall.c: Sort headers.
11989         * dwarf-index-write.h: Sort headers.
11990         * dwarf-index-write.c: Sort headers.
11991         * dwarf-index-common.c: Sort headers.
11992         * dwarf-index-cache.h: Sort headers.
11993         * dwarf-index-cache.c: Sort headers.
11994         * dummy-frame.c: Sort headers.
11995         * dtrace-probe.c: Sort headers.
11996         * disasm.h: Sort headers.
11997         * disasm.c: Sort headers.
11998         * disasm-selftests.c: Sort headers.
11999         * dictionary.c: Sort headers.
12000         * dicos-tdep.c: Sort headers.
12001         * demangle.c: Sort headers.
12002         * dcache.h: Sort headers.
12003         * dcache.c: Sort headers.
12004         * darwin-nat.h: Sort headers.
12005         * darwin-nat.c: Sort headers.
12006         * darwin-nat-info.c: Sort headers.
12007         * d-valprint.c: Sort headers.
12008         * d-namespace.c: Sort headers.
12009         * d-lang.c: Sort headers.
12010         * ctf.c: Sort headers.
12011         * csky-tdep.c: Sort headers.
12012         * csky-linux-tdep.c: Sort headers.
12013         * cris-tdep.c: Sort headers.
12014         * cris-linux-tdep.c: Sort headers.
12015         * cp-valprint.c: Sort headers.
12016         * cp-support.c: Sort headers.
12017         * cp-namespace.c: Sort headers.
12018         * cp-abi.c: Sort headers.
12019         * corelow.c: Sort headers.
12020         * corefile.c: Sort headers.
12021         * continuations.c: Sort headers.
12022         * completer.h: Sort headers.
12023         * completer.c: Sort headers.
12024         * complaints.c: Sort headers.
12025         * coffread.c: Sort headers.
12026         * coff-pe-read.c: Sort headers.
12027         * cli-out.h: Sort headers.
12028         * cli-out.c: Sort headers.
12029         * charset.c: Sort headers.
12030         * c-varobj.c: Sort headers.
12031         * c-valprint.c: Sort headers.
12032         * c-typeprint.c: Sort headers.
12033         * c-lang.c: Sort headers.
12034         * buildsym.c: Sort headers.
12035         * buildsym-legacy.c: Sort headers.
12036         * build-id.h: Sort headers.
12037         * build-id.c: Sort headers.
12038         * btrace.c: Sort headers.
12039         * bsd-uthread.c: Sort headers.
12040         * breakpoint.h: Sort headers.
12041         * breakpoint.c: Sort headers.
12042         * break-catch-throw.c: Sort headers.
12043         * break-catch-syscall.c: Sort headers.
12044         * break-catch-sig.c: Sort headers.
12045         * blockframe.c: Sort headers.
12046         * block.c: Sort headers.
12047         * bfin-tdep.c: Sort headers.
12048         * bfin-linux-tdep.c: Sort headers.
12049         * bfd-target.c: Sort headers.
12050         * bcache.c: Sort headers.
12051         * ax-general.c: Sort headers.
12052         * ax-gdb.h: Sort headers.
12053         * ax-gdb.c: Sort headers.
12054         * avr-tdep.c: Sort headers.
12055         * auxv.c: Sort headers.
12056         * auto-load.c: Sort headers.
12057         * arm-wince-tdep.c: Sort headers.
12058         * arm-tdep.c: Sort headers.
12059         * arm-symbian-tdep.c: Sort headers.
12060         * arm-pikeos-tdep.c: Sort headers.
12061         * arm-obsd-tdep.c: Sort headers.
12062         * arm-nbsd-tdep.c: Sort headers.
12063         * arm-nbsd-nat.c: Sort headers.
12064         * arm-linux-tdep.c: Sort headers.
12065         * arm-linux-nat.c: Sort headers.
12066         * arm-fbsd-tdep.c: Sort headers.
12067         * arm-fbsd-nat.c: Sort headers.
12068         * arm-bsd-tdep.c: Sort headers.
12069         * arch-utils.c: Sort headers.
12070         * arc-tdep.c: Sort headers.
12071         * arc-newlib-tdep.c: Sort headers.
12072         * annotate.h: Sort headers.
12073         * annotate.c: Sort headers.
12074         * amd64-windows-tdep.c: Sort headers.
12075         * amd64-windows-nat.c: Sort headers.
12076         * amd64-tdep.c: Sort headers.
12077         * amd64-sol2-tdep.c: Sort headers.
12078         * amd64-obsd-tdep.c: Sort headers.
12079         * amd64-obsd-nat.c: Sort headers.
12080         * amd64-nbsd-tdep.c: Sort headers.
12081         * amd64-nbsd-nat.c: Sort headers.
12082         * amd64-nat.c: Sort headers.
12083         * amd64-linux-tdep.c: Sort headers.
12084         * amd64-linux-nat.c: Sort headers.
12085         * amd64-fbsd-tdep.c: Sort headers.
12086         * amd64-fbsd-nat.c: Sort headers.
12087         * amd64-dicos-tdep.c: Sort headers.
12088         * amd64-darwin-tdep.c: Sort headers.
12089         * amd64-bsd-nat.c: Sort headers.
12090         * alpha-tdep.c: Sort headers.
12091         * alpha-obsd-tdep.c: Sort headers.
12092         * alpha-nbsd-tdep.c: Sort headers.
12093         * alpha-mdebug-tdep.c: Sort headers.
12094         * alpha-linux-tdep.c: Sort headers.
12095         * alpha-linux-nat.c: Sort headers.
12096         * alpha-bsd-tdep.c: Sort headers.
12097         * alpha-bsd-nat.c: Sort headers.
12098         * aix-thread.c: Sort headers.
12099         * agent.c: Sort headers.
12100         * addrmap.c: Sort headers.
12101         * ada-varobj.c: Sort headers.
12102         * ada-valprint.c: Sort headers.
12103         * ada-typeprint.c: Sort headers.
12104         * ada-tasks.c: Sort headers.
12105         * ada-lang.c: Sort headers.
12106         * aarch64-tdep.c: Sort headers.
12107         * aarch64-ravenscar-thread.c: Sort headers.
12108         * aarch64-newlib-tdep.c: Sort headers.
12109         * aarch64-linux-tdep.c: Sort headers.
12110         * aarch64-linux-nat.c: Sort headers.
12111         * aarch64-fbsd-tdep.c: Sort headers.
12112         * aarch64-fbsd-nat.c: Sort headers.
12113         * aarch32-linux-nat.c: Sort headers.
12114
12115 2019-04-04  Tom Tromey  <tom@tromey.com>
12116
12117         * varobj.c (varobj_create): Update.
12118         * rust-exp.y (struct rust_parser) <update_innermost_block,
12119         lookup_symbol>: New methods.
12120         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12121         Rename.
12122         (rust_parser::rust_lookup_type)
12123         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12124         * printcmd.c (display_command, do_one_display): Update.
12125         * parser-defs.h (struct parser_state) <parser_state>: Add
12126         "tracker" parameter.
12127         (block_tracker): New member.
12128         (class innermost_block_tracker) <innermost_block_tracker>: Add
12129         "types" parameter.
12130         <reset>: Remove method.
12131         (innermost_block): Don't declare.
12132         (null_post_parser): Update.
12133         * parse.c (innermost_block): Remove global.
12134         (write_dollar_variable): Update.
12135         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12136         Remove "tracker_types" parameter.
12137         (parse_expression): Add "tracker" parameter.
12138         (parse_expression_for_completion): Update.
12139         (null_post_parser): Add "tracker" parameter.
12140         * p-exp.y: Update rules.
12141         * m2-exp.y: Update rules.
12142         * language.h (struct language_defn) <la_post_parser>: Add
12143         "tracker" parameter.
12144         * go-exp.y: Update rules.
12145         * f-exp.y: Update rules.
12146         * expression.h (parse_expression, parse_exp_1): Add "tracker"
12147         parameter.
12148         * d-exp.y: Update rules.
12149         * c-exp.y: Update rules.
12150         * breakpoint.c (set_breakpoint_condition): Create an
12151         innermost_block_tracker.
12152         (watch_command_1): Likewise.
12153         * ada-lang.c (resolve): Add "tracker" parameter.
12154         (resolve_subexp): Likewise.
12155         * ada-exp.y (write_var_from_sym): Update.
12156
12157 2019-04-04  Tom Tromey  <tom@tromey.com>
12158
12159         * type-stack.h: New file.
12160         * type-stack.c: New file.
12161         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12162         type-stack.h.
12163         (insert_into_type_stack, insert_type, push_type, push_type_int)
12164         (insert_type_address_space, pop_type, pop_type_int)
12165         (pop_typelist, pop_type_stack, append_type_stack)
12166         (push_type_stack, get_type_stack, push_typelist)
12167         (follow_type_instance_flags, follow_types): Don't declare.
12168         * parse.c (type_stack): Remove global.
12169         (parse_exp_in_context): Update.
12170         (insert_into_type_stack, insert_type, push_type, push_type_int)
12171         (insert_type_address_space, pop_type, pop_type_int)
12172         (pop_typelist, pop_type_stack, append_type_stack)
12173         (push_type_stack, get_type_stack, push_typelist)
12174         (follow_type_instance_flags, follow_types): Remove (moved to
12175         type-stack.c).
12176         * f-exp.y (type_stack): New global.
12177         Update rules.
12178         (push_kind_type, f_parse): Update.
12179         * d-exp.y (type_stack): New global.
12180         Update rules.
12181         (d_parse): Update.
12182         * c-exp.y (struct c_parse_state) <type_stack>: New member.
12183         Update rules.
12184         * Makefile.in (COMMON_SFILES): Add type-stack.c.
12185         (HFILES_NO_SRCDIR): Add type-stack.h.
12186
12187 2019-04-04  Tom Tromey  <tom@tromey.com>
12188
12189         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12190         (rust_parser::convert_ast_to_expression, rust_parse)
12191         (rust_lex_test_completion, rust_lex_tests): Update.
12192         * parser-defs.h (struct expr_completion_state): New.
12193         (struct parser_state) <parser_state>: Add completion parameter.
12194         <mark_struct_expression, mark_completion_tag>: New methods.
12195         <parse_completion, m_completion_state>: New members.
12196         (prefixify_expression, null_post_parser): Update.
12197         (mark_struct_expression, mark_completion_tag): Don't declare.
12198         * parse.c (parse_completion, expout_last_struct)
12199         (expout_tag_completion_type, expout_completion_name): Remove
12200         globals.
12201         (parser_state::mark_struct_expression)
12202         (parser_state::mark_completion_tag): Now methods.
12203         (prefixify_expression): Add last_struct parameter.
12204         (prefixify_subexp): Likewise.
12205         (parse_exp_1): Update.
12206         (parse_exp_in_context): Add cstate parameter.  Update.
12207         (parse_expression_for_completion): Create an
12208         expr_completion_state.
12209         (null_post_parser): Add "completion" parameter.
12210         * p-exp.y: Update rules.
12211         (yylex): Update.
12212         * language.h (struct language_defn) <la_post_parser>: Add
12213         "completing" parameter.
12214         * go-exp.y: Update rules.
12215         (lex_one_token): Update.
12216         * expression.h (parse_completion): Don't declare.
12217         * d-exp.y: Update rules.
12218         (lex_one_token): Update rules.
12219         * c-exp.y: Update rules.
12220         (lex_one_token): Update.
12221         * ada-lang.c (resolve): Add "parse_completion" parameter.
12222         (resolve_subexp): Likewise.
12223         (ada_resolve_function): Likewise.
12224
12225 2019-04-04  Tom Tromey  <tom@tromey.com>
12226
12227         * parser-defs.h (struct parser_state) <start_arglist,
12228         end_arglist>: New methods.
12229         <arglist_len, m_funcall_chain>: New members.
12230         (arglist_len, start_arglist, end_arglist): Don't declare.
12231         * parse.c (arglist_len, funcall_chain): Remove global.
12232         (start_arglist, end_arglist): Remove functions.
12233         (parse_exp_in_context): Update.
12234         * p-exp.y: Update rules.
12235         * m2-exp.y: Update rules.
12236         * go-exp.y: Update rules.
12237         * f-exp.y: Update rules.
12238         * d-exp.y: Update rules.
12239         * c-exp.y: Update rules.
12240
12241 2019-04-04  Tom Tromey  <tom@tromey.com>
12242
12243         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12244         lex_operator, push_back>: New methods.
12245         Update all rules.
12246         (rust_parser::lex_hex, lex_escape): Rename and update.
12247         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12248         (rust_parser::lex_operator): Rename and update.
12249         (rust_parser::lex_number, rustyylex, rustyyerror)
12250         (rust_lex_test_init, rust_lex_test_sequence)
12251         (rust_lex_test_push_back, rust_lex_tests): Update.
12252         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12253         parameter.
12254         <lexptr, prev_lexptr>: New members.
12255         (lexptr, prev_lexptr): Don't declare.
12256         * parse.c (lexptr, prev_lexptr): Remove globals.
12257         (parse_exp_in_context): Update.
12258         * p-exp.y (yylex, yyerror): Update.
12259         * m2-exp.y (parse_number, yylex, yyerror): Update.
12260         * go-exp.y (lex_one_token, yyerror): Update.
12261         * f-exp.y (match_string_literal, yylex, yyerror): Update.
12262         * d-exp.y (lex_one_token, yyerror): Update.
12263         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12264         (lex_one_token, yyerror): Update.
12265         * ada-lex.l (YY_INPUT): Update.
12266         (rewind_to_char): Update.
12267         * ada-exp.y (yyerror): Update.
12268
12269 2019-04-04  Tom Tromey  <tom@tromey.com>
12270
12271         * rust-exp.y (rustyylex, rust_lex_tests): Update.
12272         * parser-defs.h (struct parser_state) <parser_state>: Add new
12273         parameter.
12274         <comma_terminates>: New member.
12275         (comma_terminates): Don't declare global.
12276         * parse.c (comma_terminates): Remove global.
12277         (parse_exp_in_context): Update.
12278         * p-exp.y (yylex): Update.
12279         * m2-exp.y (yylex): Update.
12280         * go-exp.y (lex_one_token): Update.
12281         * f-exp.y (yylex): Update.
12282         * d-exp.y (lex_one_token): Update.
12283         * c-exp.y (lex_one_token): Update.
12284         * ada-lex.l: Update.
12285
12286 2019-04-04  Tom Tromey  <tom@tromey.com>
12287
12288         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12289         (rustyylex, rust_lex_test_init, rust_lex_test_one)
12290         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12291         * parser-defs.h (paren_depth): Don't declare.
12292         * parse.c (paren_depth): Remove global.
12293         (parse_exp_in_context): Update.
12294         * p-exp.y (paren_depth): New global.
12295         (pascal_parse): Initialize it.
12296         * m2-exp.y (paren_depth): New global.
12297         (m2_parse): Initialize it.
12298         * go-exp.y (paren_depth): New global.
12299         (go_parse): Initialize it.
12300         * f-exp.y (paren_depth): New global.
12301         (f_parse): Initialize it.
12302         * d-exp.y (paren_depth): New global.
12303         (d_parse): Initialize it.
12304         * c-exp.y (paren_depth): New global.
12305         (c_parse): Initialize it.
12306         * ada-lex.l (paren_depth): New global.
12307         (lexer_init): Initialize it.
12308
12309 2019-04-04  Tom Tromey  <tom@tromey.com>
12310
12311         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12312         (rust_parser::convert_ast_to_type)
12313         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12314         * parser-defs.h (struct parser_state) <parser_state>: Add
12315         parameters.  Initialize new members.
12316         <expression_context_block, expression_context_pc>: New members.
12317         * parse.c (expression_context_block, expression_context_pc):
12318         Remove globals.
12319         (parse_exp_in_context): Update.
12320         * p-exp.y: Update all rules.
12321         (yylex): Update.
12322         * m2-exp.y: Update all rules.
12323         (yylex): Update.
12324         * go-exp.y (yylex): Update.
12325         * f-exp.y (yylex): Update.
12326         * d-exp.y: Update all rules.
12327         (yylex): Update.
12328         * c-exp.y: Update all rules.
12329         (lex_one_token, classify_name, yylex, c_parse): Update.
12330         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12331
12332 2019-04-04  Tom Tromey  <tom@tromey.com>
12333
12334         * gdbarch.h, gdbarch.c: Rebuild.
12335         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12336         * stap-probe.h:
12337         (struct stap_parse_info): Replace "parser_state" with
12338         "expr_builder".
12339         * parser-defs.h (struct expr_builder): Rename from "parser_state".
12340         (parser_state): New class.
12341         * parse.c (expr_builder): Rename.
12342         (expr_builder::release): Rename.
12343         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12344         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12345         (write_exp_elt_longcst, write_exp_elt_floatcst)
12346         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12347         (write_exp_string_vector, write_exp_bitstring)
12348         (write_exp_msymbol, mark_struct_expression)
12349         (write_dollar_variable)
12350         (insert_type_address_space, increase_expout_size): Replace
12351         "parser_state" with "expr_builder".
12352         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12353         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12354         "parser_state" with "expr_builder".
12355
12356 2019-04-04  Tom Tromey  <tom@tromey.com>
12357
12358         * rust-exp.y: Replace "parse_language" with method call.
12359         * p-exp.y:
12360         (yylex): Replace "parse_language" with method call.
12361         * m2-exp.y:
12362         (yylex): Replace "parse_language" with method call.
12363         * go-exp.y (classify_name): Replace "parse_language" with method
12364         call.
12365         * f-exp.y (yylex): Replace "parse_language" with method call.
12366         * d-exp.y (lex_one_token): Replace "parse_language" with method
12367         call.
12368         * c-exp.y:
12369         (lex_one_token, classify_name, yylex): Replace "parse_language"
12370         with method call.
12371         * ada-exp.y (find_primitive_type, type_char)
12372         (type_system_address): Replace "parse_language" with method call.
12373
12374 2019-04-04  Tom Tromey  <tom@tromey.com>
12375
12376         * rust-exp.y: Replace "parse_gdbarch" with method call.
12377         * parse.c (write_dollar_variable, insert_type_address_space):
12378         Replace "parse_gdbarch" with method call.
12379         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12380         call.
12381         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12382         call.
12383         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12384         "parse_gdbarch" with method call.
12385         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12386         with method call.
12387         * f-exp.y (parse_type, parse_f_type, yylex): Replace
12388         "parse_gdbarch" with method call.
12389         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12390         "parse_gdbarch" with method call.
12391         * c-exp.y (parse_type, parse_number, classify_name): Replace
12392         "parse_gdbarch" with method call.
12393         * ada-lex.l: Replace "parse_gdbarch" with method call.
12394         * ada-exp.y (parse_type, find_primitive_type, type_char)
12395         (type_system_address): Replace "parse_gdbarch" with method call.
12396
12397 2019-04-04  Tom Tromey  <tom@tromey.com>
12398
12399         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12400         * stap-probe.c (stap_parse_argument): Update.
12401         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12402         initial_size parameter.
12403         * rust-exp.y (rust_lex_tests): Update.
12404         * parse.c (parser_state): Update.
12405         (parse_exp_in_context): Update.
12406         * parser-defs.h (struct parser_state) <parser_state>: Remove
12407         "initial_size" parameter.
12408
12409 2019-04-04  Tom Tromey  <tom@tromey.com>
12410
12411         * parser-defs.h (increase_expout_size): Don't declare.
12412         * parse.c (increase_expout_size): Now static.
12413
12414 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
12415
12416         * gnu-nat.c (gnu_nat_target::wait): Fix
12417         target_waitstatus_to_string call.
12418
12419 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12420
12421         * eval.c (evaluate_subexp_standard): Handle internal functions
12422         during Fortran function call handling.
12423
12424 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12425
12426         * NEWS: Mention new internal functions.
12427         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12428         (read_base_type): Use dwarf2_init_complex_target_type.
12429         * value.c (creal_internal_fn): New function.
12430         (cimag_internal_fn): New function.
12431         (_initialize_values): Register new internal functions.
12432
12433 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12434
12435         * infrun.c (stop_all_threads): If debug_infrun, always
12436         trace the wait status after wait_one, using
12437         target_waitstatus_to_string and target_pid_to_str.
12438         (handle_inferior_event): Replace various trace of
12439         wait status kind by a single trace.
12440         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12441         wait status kind image by target_waitstatus_to_string.
12442         * target/waitstatus.c (target_waitstatus_to_string): Fix
12443         obsolete comment.
12444
12445 2019-04-01  Tom Tromey  <tromey@adacore.com>
12446
12447         PR symtab/23331:
12448         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12449
12450 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
12451             Pedro Alves  <palves@redhat.com>
12452
12453         * top.c (quit_force): Call 'finalize_values'.
12454         * value.c (finalize_values): New function.
12455         * value.h (finalize_values): Declare.
12456
12457 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
12458
12459         * NEWS: Announce $_gdb_major and $_gdb_minor.
12460
12461         * top.c (init_gdb_version_vars): New function.
12462         (gdb_init): Call init_gdb_version_vars.
12463
12464 2019-03-29  Tom Tromey  <tromey@adacore.com>
12465
12466         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
12467         help text.  Remove dead code.
12468
12469 2019-03-29  Keith Seitz  <keiths@redhat.com>
12470
12471         From Siddhesh Poyarekar:
12472         * f-lang.h (f77_get_upperbound): Return LONGEST.
12473         (f77_get_lowerbound): Likewise.
12474         * f-typeprint.c (f_type_print_varspec_suffix): Expand
12475         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
12476         print them.
12477         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
12478         plongest to format print it.
12479         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12480         (f77_get_upperbound): Likewise.
12481         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12482         LOWER_BOUND to LONGEST.
12483         (f77_create_arrayprint_offset_tbl): Likewise.
12484
12485 2019-03-29  Keith Seitz  <keiths@redhat.com>
12486
12487         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12488         %s/pulongest for TYPE_LENGTH instead of %d in format
12489         strings.
12490         * ada-typerint.c (ada_print_type): Likewise.
12491         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12492         * compile/compile-c-support.c (generate_register_struct): Likewise.
12493         * gdbtypes.c (recursive_dump_type): Likewise.
12494         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12495         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
12496         instead of %d in format strings.
12497         * riscv-tdep.c (riscv_type_alignment): Cast second argument
12498         to std::min to ULONGEST.
12499         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12500         instead of %d in format strings.
12501         * tracepoint.c (info_scope_command): Likewise.
12502         * typeprint.c (print_offset_data::update)
12503         (print_offset_data::finish): Likewise.
12504         * xtensa-tdep.c (xtensa_store_return_value)
12505         (xtensa_push_dummy_call): Likewise.
12506
12507 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
12508
12509         * windows-nat.c (display_selector): Fixed format specifications
12510         for 64-bit Cygwin.
12511
12512 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12513
12514         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12515
12516 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
12517
12518         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12519         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12520         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12521         (nios2_linux_init_abi): Install it.
12522
12523 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12524
12525         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12526
12527 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12528
12529         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12530
12531 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12532             Tom Tromey  <tromey@adacore.com>
12533
12534         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12535
12536 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
12537
12538         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12539         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12540         method to compute the bounds of range types. Also print "[evaluated]"
12541         if the bounds' values come from a dynamic evaluation.
12542
12543 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12544
12545         * cp-valprint.c (cp_print_value_fields): Don't print trailing
12546         whitespace when pretty printing is on.
12547
12548 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12549
12550         * ppc-linux-nat.c: Add include.
12551
12552 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12553
12554         * NEWS: Mention AArch64 Pointer Authentication.
12555
12556 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12557
12558         * arm-linux-nat.c: Add include.
12559
12560 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
12561
12562         * source-cache.c (source_cache::get_source_lines): Re-read
12563         fullname after calling open_source_file.
12564
12565 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
12566
12567         * NEWS: Mention TLS support for FreeBSD.
12568
12569 2019-03-25  Tom Tromey  <tromey@adacore.com>
12570
12571         * minsyms.c (BUNCH_SIZE): Update comment.
12572         (~minimal_symbol_reader): Remove old comment.
12573         (compact_minimal_symbols): Update comment.
12574         (minimal_symbol_reader::install): Remove old comment.  Update
12575         other comments.
12576
12577 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12578
12579         * s390-linux-nat.c: Add include.
12580
12581 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12582
12583         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12584         Call linux_get_hwcap.
12585         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12586         Likewise.
12587         (aarch64_linux_get_hwcap): Remove function.
12588         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12589         declaration.
12590         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12591         linux_get_hwcap.
12592         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12593         * linux-tdep.c (linux_get_hwcap): Add function.
12594         (linux_get_hwcap2): Likewise.
12595         * linux-tdep.h (linux_get_hwcap): Add declaration.
12596         (linux_get_hwcap2): Likewise.
12597         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12598         (ppc_linux_get_hwcap2): Likewise.
12599         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12600         linux_get_hwcap.
12601         (ppc_linux_nat_target::insert_watchpoint): Likewise.
12602         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12603         (ppc_linux_nat_target::read_description): Likewise.
12604         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12605         * s390-linux-nat.c: Likewise.
12606         * s390-linux-tdep.c (s390_core_read_description): Likewise.
12607
12608 2019-03-24  Tom Tromey  <tom@tromey.com>
12609
12610         * ada-lang.c (standard_lookup): Simplify initialization.
12611         (ada_lookup_symbol_nonlocal): Simplify return.
12612         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12613         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12614         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12615         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12616         initialization.
12617         * solib.c (solib_global_lookup): Simplify.
12618         * symtab.c (null_block_symbol): Remove.
12619         (symbol_cache_lookup): Simplify returns.
12620         (lookup_language_this): Simplify returns.
12621         (lookup_symbol_aux): Simplify return.
12622         (lookup_local_symbol): Simplify returns.
12623         (lookup_global_symbol_from_objfile): Simplify return.
12624         (lookup_symbol_in_objfile_symtabs)
12625         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12626         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12627         (lookup_static_symbol, lookup_global_symbol): Simplify return.
12628         * cp-namespace.c (cp_lookup_bare_symbol)
12629         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12630         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12631         (cp_lookup_nested_symbol): Don't use null_block_symbol.
12632         (cp_lookup_symbol_via_imports): Simplify initialization.
12633         (find_symbol_in_baseclass): Likewise.
12634         * symtab.h (null_block_symbol): Remove.
12635         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12636         (d_lookup_nested_symbol, d_lookup_symbol_imports)
12637         (d_lookup_symbol_module): Likewise.
12638         (find_symbol_in_baseclass): Simplify initialization.
12639
12640 2019-03-24  Tom Tromey  <tom@tromey.com>
12641
12642         * expression.h: Don't include symtab.h.
12643         (struct block): Forward declare.
12644
12645 2019-03-24  Tom Tromey  <tom@tromey.com>
12646
12647         * c-exp.y (typebase): Remove casts.
12648         * gdbtypes.c (lookup_unsigned_typename, )
12649         (lookup_signed_typename): Remove cast.
12650         * eval.c (parse_to_comma_and_eval): Remove cast.
12651         * parse.c (write_dollar_variable): Remove cast.
12652         * block.h (struct block) <superblock>: Now const.
12653         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12654         * psymtab.c (psym_map_matching_symbols): Make "block" const.
12655         (map_block): Make "block" const.
12656         * symfile.h (struct quick_symbol_functions)
12657         <map_matching_symbols>: Constify block argument to "callback".
12658         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12659         const.
12660         (find_pc_sect_compunit_symtab): Make "b" const.
12661         (find_symbol_at_address): Likewise.
12662         (search_symbols): Likewise.
12663         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12664         (dw2_debug_names_lookup_symbol): Likewise.
12665         (dw2_map_matching_symbols): Update.
12666         * p-valprint.c (pascal_val_print): Remove "block".
12667         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12668         (aux_add_nonlocal_symbols): Make "block" const.
12669         (resolve_subexp): Remove cast.
12670         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12671         const.
12672         (iterate_over_file_blocks): Likewise.
12673         * f-exp.y (%union) <bval>: Remove.
12674         * coffread.c (patch_opaque_types): Make "b" const.
12675         * spu-tdep.c (spu_catch_start): Make "block" const.
12676         * c-valprint.c (print_unpacked_pointer): Remove "block".
12677         * symmisc.c (dump_symtab_1): Make "b" const.
12678         (block_depth): Make "block" const.
12679         * d-exp.y (%union) <bval>: Remove.
12680         * cp-support.h (cp_lookup_rtti_type): Update.
12681         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12682         * psymtab.c (psym_lookup_symbol): Make "block" const.
12683         (maintenance_check_psymtabs): Make "b" const.
12684         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12685         (enumerate_locals, enumerate_args): Update.
12686         * python/py-symtab.c (stpy_global_block): Make "block" const.
12687         (stpy_static_block): Likewise.
12688         * inline-frame.c (block_starting_point_at): Make "new_block"
12689         const.
12690         * block.c (find_block_in_blockvector): Make return type const.
12691         (blockvector_for_pc_sect): Make "b" const.
12692         (find_block_in_blockvector): Make "b" const.
12693
12694 2019-03-23  Tom Tromey  <tom@tromey.com>
12695
12696         * varobj.c (varobj_create): Update.
12697         * symfile.c (clear_symtab_users): Don't reset innermost_block.
12698         * printcmd.c (display_command, do_one_display): Don't reset
12699         innermost_block.
12700         * parser-defs.h (enum innermost_block_tracker_type): Move to
12701         expression.h.
12702         (innermost_block): Update comment.
12703         * parse.c (parse_exp_1): Add tracker_types parameter.
12704         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
12705         tracker_types parameter.  Reset innermost_block.
12706         (parse_exp_in_context): Remove.
12707         (parse_expression_for_completion): Update.
12708         * objfiles.c (~objfile): Don't reset expression_context_block or
12709         innermost_block.
12710         * expression.h (enum innermost_block_tracker_type): Move from
12711         parser-defs.h.
12712         (parse_exp_1): Add tracker_types parameter.
12713         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12714         reset innermost_block.
12715
12716 2019-03-23  Tom Tromey  <tom@tromey.com>
12717
12718         * objfiles.h: Include bcache.h.
12719
12720 2019-03-23  Tom Tromey  <tom@tromey.com>
12721
12722         * linespec.c (get_current_search_block): Use
12723         scoped_restore_current_language.
12724         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12725
12726 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12727             Jiong Wang  <jiong.wang@arm.com>
12728
12729         * aarch64-linux-tdep.c
12730         (aarch64_linux_iterate_over_regset_sections): Check for pauth
12731         section.
12732         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12733
12734 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12735             Jiong Wang  <jiong.wang@arm.com>
12736
12737         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12738         instructions.
12739         (aarch64_analyze_prologue_test): Add PACIASP test.
12740         (aarch64_prologue_prev_register): Unmask PC value.
12741
12742 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12743             Jiong Wang  <jiong.wang@arm.com>
12744
12745         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12746         (aarch64_dwarf2_prev_register): Unmask PC value.
12747         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12748         (aarch64_execute_dwarf_cfa_vendor_op): Check for
12749         DW_CFA_AARCH64_negate_ra_state.
12750         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12751
12752 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12753             Jiong Wang  <jiong.wang@arm.com>
12754
12755         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12756         registers.
12757         (aarch64_pseudo_register_name): Likewise.
12758         (aarch64_pseudo_register_type): Likewise.
12759         (aarch64_pseudo_register_reggroup_p): Likewise.
12760         (aarch64_gdbarch_init): Add pauth registers.
12761         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12762         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12763         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12764         (struct gdbarch_tdep): Add regnum for ra_state.
12765
12766 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12767             Jiong Wang  <jiong.wang@arm.com>
12768
12769         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12770
12771 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12772             Jiong Wang  <jiong.wang@arm.com>
12773
12774         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12775         function.
12776         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12777         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12778         (aarch64_gdbarch_init): Add puth registers.
12779         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12780         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12781         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12782
12783 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12784             Jiong Wang  <jiong.wang@arm.com>
12785
12786         * aarch64-linux-nat.c
12787         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12788         * aarch64-linux-tdep.c
12789         (aarch64_linux_core_read_description): Likewise.
12790         (aarch64_linux_get_hwcap): New function.
12791         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12792         (aarch64_linux_get_hwcap): New declaration.
12793
12794 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12795             Jiong Wang  <jiong.wang@arm.com>
12796
12797         * aarch64-linux-nat.c
12798         (aarch64_linux_nat_target::read_description): Add pauth param.
12799         * aarch64-linux-tdep.c
12800         (aarch64_linux_core_read_description): Likewise.
12801         * aarch64-tdep.c (struct target_desc): Add in pauth.
12802         (aarch64_read_description): Add pauth param.
12803         (aarch64_gdbarch_init): Likewise.
12804         * aarch64-tdep.h (aarch64_read_description): Likewise.
12805         * arch/aarch64.c (aarch64_create_target_description): Likewise.
12806         * arch/aarch64.h (aarch64_create_target_description): Likewise.
12807         * features/Makefile: Add new files.
12808         * features/aarch64-pauth.c: New file.
12809         * features/aarch64-pauth.xml: New file.
12810
12811 2019-03-20  Tom Tromey  <tromey@adacore.com>
12812
12813         * infrun.c (handle_inferior_event): Rename from
12814         handle_inferior_event_1.  Create a scoped_value_mark.
12815         (handle_inferior_event): Remove.
12816
12817 2019-03-19  Tom Tromey  <tromey@adacore.com>
12818
12819         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12820         * infrun.h (print_stop_event): Add "displays" parameter.
12821         * infrun.c (print_stop_event): Add "displays" parameter.
12822
12823 2019-03-19  Pedro Alves  <palves@redhat.com>
12824
12825         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12826         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
12827         to -1.  Fix TABs vs spaces.
12828         (tui_ui_out::tui_ui_out): Don't initialize fields here.
12829         * tui/tui-out.h (tui_ui_out) Add intro comments.
12830         <m_line, m_start_of_line>: In-class initialize, and add describing
12831         comment.
12832
12833 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
12834
12835         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12836         variable names.
12837         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12838
12839 2019-03-18  Pedro Alves  <palves@redhat.com>
12840             Eli Zaretskii <eliz@gnu.org>
12841
12842         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12843         m_line and m_start_of_line.
12844
12845 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
12846
12847         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12848         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12849         it returns a newline.  This fixes a regression in TU mode, whereby
12850         the next line is output on the same screen line as the user input.
12851
12852 2019-03-18  Tom Tromey  <tromey@adacore.com>
12853
12854         * minsyms.c (minimal_symbol_reader::install): Remove call to
12855         obstack_blank.
12856
12857 2019-03-18  Pedro Alves  <palves@redhat.com>
12858
12859         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12860         New globals.
12861         (apply_style): New, factored out from ...
12862         (apply_ansi_escape): ... this.  Handle reverse video mode.
12863         (tui_set_reverse_mode): New function.
12864         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12865         * tui/tui-winsource.c (tui_show_source_line): Use
12866         tui_set_reverse_mode instead of setting A_STANDOUT.
12867         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12868         New setter methods.
12869
12870 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
12871
12872         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12873         Handle tabs.
12874
12875 2019-03-18  Tom Tromey  <tromey@adacore.com>
12876
12877         * ada-lang.c (empty_array): Add "high" parameter.
12878         (ada_evaluate_subexp): Update.
12879
12880 2019-03-17  Sergei Trofimovich <siarheit@google.com>
12881
12882         * unittests/string_view-selftests.c: Define
12883         _initialize_string_view_selftests unconditionally.
12884
12885 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12886
12887         PR gdb/24350
12888         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12889
12890 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12891
12892         PR gdb/24351
12893         * windows-nat.c (display_selector): Fix format specifiers.
12894
12895 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
12896
12897         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12898         tui_refill_source_window instead of tui_refresh_win, to update the
12899         current execution line.  This fixes redisplay of the current line
12900         when stepping through the code with "next" or "step".
12901
12902 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12903
12904         * source-cache.c (source_cache::get_source_lines): Call
12905         find_source_lines to initialize s->nlines.  This fixes vertical
12906         scrolling of TUI source window when the DOWN arrow is pressed.
12907
12908 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12909
12910         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12911         linux-thread-db.c (_initialize_thread_db): Likewise.
12912
12913 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12914
12915         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12916         wclrtoeol in tui_show_source_line".  This reverts changes made in
12917         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12918
12919 2019-03-15  Tom Tromey  <tom@tromey.com>
12920
12921         * symtab.h (struct minimal_symbol): Derive from
12922         general_symbol_info.
12923         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12924         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12925         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
12926         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
12927         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
12928         (MSYMBOL_SEARCH_NAME): Update.
12929         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
12930         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
12931         * minsyms.c (minimal_symbol_reader::record_full): Update.
12932
12933 2019-03-15  Tom Tromey  <tom@tromey.com>
12934
12935         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
12936
12937 2019-03-15  Tom Tromey  <tom@tromey.com>
12938
12939         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
12940         unique_xmalloc_ptr.
12941         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
12942         Update.
12943         * minsyms.c (lookup_minimal_symbol_by_pc_section)
12944         (build_minimal_symbol_hash_tables)
12945         (minimal_symbol_reader::install): Update.
12946
12947 2019-03-15  Tom Tromey  <tom@tromey.com>
12948
12949         * symtab.c (create_demangled_names_hash): Update.
12950         (symbol_set_names): Update.
12951         * objfiles.h (struct objfile_per_bfd_storage)
12952         <demangled_names_hash>: Now an htab_up.
12953         * objfiles.c (objfile_per_bfd_storage): Simplify.
12954
12955 2019-03-15  Tom Tromey  <tom@tromey.com>
12956
12957         * objfiles.h (struct objfile_per_bfd_storage): Declare
12958         destructor.
12959         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
12960         New.
12961         (get_objfile_bfd_data): Use new.  Don't initialize
12962         language_of_main.
12963         (free_objfile_per_bfd_storage): Remove.
12964         (objfile_bfd_data_free, objfile::~objfile): Use delete.
12965
12966 2019-03-15  Tom Tromey  <tom@tromey.com>
12967
12968         * symfile.c (reread_symbols): Update.
12969         * objfiles.c (objfile::objfile): Update.
12970         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
12971         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
12972         comment.
12973         (minimal_symbol_reader::install): Update.
12974         (terminate_minimal_symbol_table): Remove.
12975         * jit.c (jit_object_close_impl): Update.
12976
12977 2019-03-15  Tom Tromey  <tom@tromey.com>
12978
12979         * minsyms.c (minimal_symbol_reader::record_full): Remove some
12980         initializations.
12981
12982 2019-03-15  Tom Tromey  <tom@tromey.com>
12983
12984         * objfiles.h (struct objfile_per_bfd_storage)
12985         <demangled_hash_languages>: Now a bitset.
12986         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
12987         (lookup_minimal_symbol): Update.
12988
12989 2019-03-15  Tom Tromey  <tom@tromey.com>
12990
12991         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
12992         Don't return the symbol.
12993         * coffread.c (record_minimal_symbol): Use record_full.
12994
12995 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
12996
12997         The MS-Windows port of ncurses fails to switch to a color pair if
12998         one or both of the colors are the implicit default colors.  This
12999         change records the default colors when TUI is initialized, and
13000         then specifies them explicitly when a color pair uses the default
13001         colors.  This allows color styling in TUI mode on MS-Windows.
13002
13003         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
13004         ncurses_norm_attr.
13005         (tui_initialize_io) [__MINGW32__]: Record the default terminal
13006         colors in ncurses_norm_attr.
13007         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13008         "none", replace it with the default color recorded in
13009         ncurses_norm_attr.
13010
13011 2019-03-14  Tom Tromey  <tromey@adacore.com>
13012
13013         * source-cache.h (class source_cache) <get_source_lines>: Return
13014         std::string.
13015         * source-cache.c (source_cache::extract_lines): Handle case where
13016         first_pos==npos.  Return std::string.
13017         (source_cache::get_source_lines): Update.
13018
13019 2019-03-14  Tom Tromey  <tromey@adacore.com>
13020
13021         * NEWS: Add item for "style sources" commands.
13022         * source-cache.c (source_cache::get_source_lines): Check
13023         source_styling.
13024         * cli/cli-style.c (source_styling): New global.
13025         (_initialize_cli_style): Add "style sources" commands.
13026         (show_style_sources): New function.
13027         * cli/cli-style.h (source_styling): Declare.
13028
13029 2019-03-14  Pedro Alves  <palves@redhat.com>
13030             Tom Tromey  <tromey@adacore.com>
13031
13032         * tui/tui-winsource.h (tui_refill_source_window): Declare.
13033         * tui/tui-winsource.c (tui_refill_source_window): New function,
13034         from...
13035         (tui_horizontal_source_scroll): ... here.  Move some logic.
13036         * cli/cli-style.c (set_style_enabled): Notify new observable.
13037         * tui/tui-hooks.c (tui_redisplay_source): New function.
13038         (tui_attach_detach_observers): Attach or detach
13039         tui_redisplay_source.
13040         * observable.h (source_styling_changed): New observable.
13041         * observable.c: Define source_styling_changed observable.
13042
13043 2019-03-13  Tom Tromey  <tromey@adacore.com>
13044
13045         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13046         (i386_gnu_nat_target::store_registers): Update.
13047         * target-debug.h (target_debug_print_std_string): New macro.
13048         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13049         * windows-tdep.c (display_one_tib): Update.
13050         * tui/tui-stack.c (tui_make_status_line): Update.
13051         * top.c (print_inferior_quit_action): Update.
13052         * thread.c (thr_try_catch_cmd): Update.
13053         (add_thread_with_info): Update.
13054         (thread_target_id_str): Update.
13055         (thr_try_catch_cmd): Update.
13056         (thread_command): Update.
13057         (thread_find_command): Update.
13058         * record-btrace.c (record_btrace_target::info_record)
13059         (record_btrace_resume_thread, record_btrace_target::resume)
13060         (record_btrace_cancel_resume, record_btrace_step_thread)
13061         (record_btrace_target::wait, record_btrace_target::wait)
13062         (record_btrace_target::wait, record_btrace_target::stop): Update.
13063         * progspace.c (print_program_space): Update.
13064         * process-stratum-target.c
13065         (process_stratum_target::thread_address_space): Update.
13066         * linux-fork.c (linux_fork_mourn_inferior)
13067         (detach_checkpoint_command, info_checkpoints_command)
13068         (linux_fork_context): Update.
13069         (linux_fork_detach): Update.
13070         (class scoped_switch_fork_info): Update.
13071         (delete_checkpoint_command): Update.
13072         * infrun.c (follow_fork_inferior): Update.
13073         (follow_fork_inferior): Update.
13074         (proceed_after_vfork_done): Update.
13075         (handle_vfork_child_exec_or_exit): Update.
13076         (follow_exec): Update.
13077         (displaced_step_prepare_throw): Update.
13078         (displaced_step_restore): Update.
13079         (start_step_over): Update.
13080         (resume_1): Update.
13081         (clear_proceed_status_thread): Update.
13082         (proceed): Update.
13083         (print_target_wait_results): Update.
13084         (do_target_wait): Update.
13085         (context_switch): Update.
13086         (stop_all_threads): Update.
13087         (restart_threads): Update.
13088         (finish_step_over): Update.
13089         (handle_signal_stop): Update.
13090         (switch_back_to_stepped_thread): Update.
13091         (keep_going_pass_signal): Update.
13092         (print_exited_reason): Update.
13093         (normal_stop): Update.
13094         * inferior.c (inferior_pid_to_str): Change return type.
13095         (print_selected_inferior): Update.
13096         (add_inferior): Update.
13097         (detach_inferior): Update.
13098         * dummy-frame.c (fprint_dummy_frames): Update.
13099         * dcache.c (dcache_info_1): Update.
13100         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13101         (btrace_fetch, btrace_clear): Update.
13102         * linux-tdep.c (linux_core_pid_to_str): Change return type.
13103         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13104         type.
13105         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13106         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13107         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13108         * gdbarch.c, gdbarch.h: Rebuild.
13109         * gdbarch.sh (core_pid_to_str): Change return type.
13110         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13111         return type.
13112         (windows_nat_target::pid_to_str): Change return type.
13113         (windows_delete_thread): Update.
13114         (windows_nat_target::attach): Update.
13115         (windows_nat_target::files_info): Update.
13116         * target-delegates.c: Rebuild.
13117         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13118         return type.
13119         (sol_thread_target::pid_to_str): Change return type.
13120         * remote.c (class remote_target) <pid_to_str>: Change return
13121         type.
13122         (remote_target::pid_to_str): Change return type.
13123         (extended_remote_target::attach, remote_target::remote_stop_ns)
13124         (remote_target::remote_notif_remove_queued_reply)
13125         (remote_target::push_stop_reply, remote_target::disable_btrace):
13126         Update.
13127         (extended_remote_target::attach): Update.
13128         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13129         type.
13130         (gdbsim_target::pid_to_str): Change return type.
13131         * ravenscar-thread.c (struct ravenscar_thread_target)
13132         <pid_to_str>: Change return type.
13133         (ravenscar_thread_target::pid_to_str): Change return type.
13134         * procfs.c (class procfs_target) <pid_to_str>: Change return
13135         type.
13136         (procfs_target::pid_to_str): Change return type.
13137         (procfs_target::attach): Update.
13138         (procfs_target::detach): Update.
13139         (procfs_target::fetch_registers): Update.
13140         (procfs_target::store_registers): Update.
13141         (procfs_target::wait): Update.
13142         (procfs_target::files_info): Update.
13143         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13144         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13145         return type.
13146         (nto_procfs_target::pid_to_str): Change return type.
13147         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13148         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13149         return type.
13150         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13151         (exit_lwp): Update.
13152         (attach_proc_task_lwp_callback, get_detach_signal)
13153         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13154         (linux_nat_target::resume, wait_lwp, stop_callback)
13155         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13156         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13157         (linux_nat_wait_1, resume_stopped_resumed_lwps)
13158         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13159         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13160         type.
13161         (inf_ptrace_target::attach): Update.
13162         (inf_ptrace_target::files_info): Update.
13163         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13164         type.
13165         (go32_nat_target::pid_to_str): Change return type.
13166         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13167         (gnu_nat_target::wait): Update.
13168         (gnu_nat_target::wait): Update.
13169         (gnu_nat_target::resume): Update.
13170         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13171         (fbsd_nat_target::wait): Update.
13172         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13173         type.
13174         (darwin_nat_target::attach): Update.
13175         * corelow.c (class core_target) <pid_to_str>: Change return type.
13176         (core_target::pid_to_str): Change return type.
13177         * target.c (normal_pid_to_str): Change return type.
13178         (default_pid_to_str): Likewise.
13179         (target_pid_to_str): Change return type.
13180         (target_translate_tls_address): Update.
13181         (target_announce_detach): Update.
13182         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13183         return type.
13184         (bsd_uthread_target::pid_to_str): Change return type.
13185         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13186         type.
13187         (bsd_kvm_target::pid_to_str): Change return type.
13188         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13189         return type.
13190         (aix_thread_target::pid_to_str): Change return type.
13191         * target.h (struct target_ops) <pid_to_str>: Change return type.
13192         (target_pid_to_str, normal_pid_to_str): Likewise.
13193         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13194         type.
13195         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13196         type.
13197         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13198         return type.
13199         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13200         type.
13201         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13202         type.
13203         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13204         return type.
13205
13206 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
13207
13208         * NEWS: Mention that the new default MI version is 3.  Mention
13209         changes to the output of commands and events that deal with
13210         multi-location breakpoints.
13211         * breakpoint.c: Include "mi/mi-out.h".
13212         (print_one_breakpoint): Change output syntax if using MI version
13213         >= 3.
13214         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13215         New.
13216         (mi_multi_location_breakpoint_output_fixed): New.
13217         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13218         (mi_cmd_fix_multi_location_breakpoint_output): New.
13219         (mi_multi_location_breakpoint_output_fixed): New.
13220         * mi/mi-cmds.c (mi_cmds): Register command
13221         -fix-multi-location-breakpoint-output.
13222         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13223         interpreter "mi".
13224
13225 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
13226
13227         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13228         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13229         instantiate mi_ui_out based on interpreter name.
13230         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13231         * mi/mi-main.c (mi_load_progress): Likewise.
13232
13233 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13234
13235         * NEWS: Combine separate "New targets" sections for 8.3.
13236
13237 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13238
13239         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13240         (ppcfbsd_init_abi): Install gdbarch
13241         "fetch_tls_load_module_address" and "get_thread_local_address"
13242         methods.
13243
13244 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13245
13246         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13247         (riscv_fbsd_init_abi): Install gdbarch
13248         "fetch_tls_load_module_address" and "get_thread_local_address"
13249         methods.
13250
13251 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13252
13253         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13254         (i386fbsd_init_abi): Install gdbarch
13255         "fetch_tls_load_module_address" and "get_thread_local_address"
13256         methods.
13257
13258 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13259
13260         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13261         (amd64fbsd_init_abi): Install gdbarch
13262         "fetch_tls_load_module_address" and "get_thread_local_address"
13263         methods.
13264
13265 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13266
13267         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13268         (struct fbsd_pspace_data): New type.
13269         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13270         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13271         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13272         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13273         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13274
13275 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13276
13277         * gdbtypes.c (lookup_struct_elt): New function.
13278         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13279         * gdbtypes.h (struct struct_elt): New type.
13280         (lookup_struct_elt): New prototype.
13281
13282 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13283
13284         * gdbtypes.c (lookup_struct_elt_type): Update comment and
13285         remove disabled code block.
13286
13287 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13288
13289         * gdbarch.sh (get_thread_local_address): New method.
13290         * gdbarch.h, gdbarch.c: Regenerate.
13291         * target.c (target_translate_tls_address): Use
13292         gdbarch_get_thread_local_address if present instead of
13293         target::get_thread_local_address.
13294
13295 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13296
13297         * target.h (target::get_thread_local_address): Update comment.
13298
13299 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13300
13301         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13302         objfile->separate_debug_objfile_backlink if not NULL.
13303
13304 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13305
13306         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13307         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13308         (amd64bsd_store_inferior_registers): Likewise.
13309         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13310         Enable segment base registers.
13311         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13312         PT_GETFSBASE and PT_GETGSBASE.
13313         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13314         PT_SETGSBASE.
13315         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13316         segment base registers.
13317         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13318
13319 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13320
13321         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13322         Update calls to i386_target_description to add 'segments'
13323         parameter.
13324         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
13325         add segment base registers.
13326         * arch/i386.c (i386_create_target_description): Add 'segments'
13327         parameter to enable segment base registers.
13328         * arch/i386.h (i386_create_target_description): Likewise.
13329         * features/i386/32bit-segments.xml: New file.
13330         * features/i386/32bit-segments.c: Generate.
13331         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13332         call to i386_target_description to add 'segments' parameter.
13333         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13334         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13335         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13336         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13337         if feature is present.
13338         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13339         Add 'segments' parameter to call to i386_target_description.
13340         (i386_target_description): Add 'segments' parameter to enable
13341         segment base registers.
13342         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13343         to call to i386_target_description.
13344         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13345         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13346         Define I386_NUM_REGS.
13347         (i386_target_description): Add 'segments' parameter to enable
13348         segment base registers.
13349
13350 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
13351
13352         PR/24325
13353         * source-cache.c: #undef open and close, to avoid unresolved
13354         externals during linking.
13355
13356 2019-03-12  Tom Tromey  <tromey@adacore.com>
13357
13358         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13359         const.  Add initializers.
13360         (_initialize_remote): Don't initialize ptid globals.
13361
13362 2019-03-12  Pedro Alves  <palves@redhat.com>
13363
13364         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13365
13366 2019-03-12  Pedro Alves  <palves@redhat.com>
13367
13368         * cp-name-parser.y (main): Remove unused 'len' variable.
13369
13370 2019-03-12  Tom Tromey  <tromey@adacore.com>
13371
13372         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13373         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13374
13375 2019-03-12  Tom Tromey  <tromey@adacore.com>
13376
13377         * linux-nat.c (iterate_over_lwps): Update.
13378         (stop_callback): Remove parameter.
13379         (stop_wait_callback, detach_callback, resume_set_callback)
13380         (select_singlestep_lwp_callback, set_ignore_sigint)
13381         (status_callback, resumed_callback, resume_clear_callback)
13382         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13383         data parameter.
13384         (linux_nat_target::detach, linux_nat_target::resume)
13385         (linux_stop_and_wait_all_lwps, select_event_lwp)
13386         (linux_nat_filter_event, linux_nat_wait_1)
13387         (linux_nat_target::kill, linux_nat_target::stop)
13388         (linux_nat_target::stop): Update.
13389         (linux_nat_resume_callback): Change type.
13390         (resume_stopped_resumed_lwps, count_events_callback)
13391         (select_event_lwp_callback): Likewise.
13392         (linux_stop_lwp, linux_nat_stop_lwp): Update.
13393         * arm-linux-nat.c (struct update_registers_data): Remove.
13394         (update_registers_callback): Change type.
13395         (arm_linux_insert_hw_breakpoint1): Update.
13396         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13397         parameter.
13398         (x86_linux_dr_set_addr): Update.
13399         (x86_linux_dr_set_control): Update.
13400         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13401         (iterate_over_lwps): Use gdb::function_view.
13402         * nat/aarch64-linux-hw-point.c (struct
13403         aarch64_dr_update_callback_param): Remove.
13404         (debug_reg_change_callback): Change type.
13405         (aarch64_notify_debug_reg_change): Update.
13406         * s390-linux-nat.c (s390_refresh_per_info): Update.
13407
13408 2019-03-11  Tom Tromey  <tromey@adacore.com>
13409
13410         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13411         redundant assignment to "this_cu".
13412
13413 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13414
13415         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13416
13417 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13418
13419         * gdbtypes.c (rank_one_type_parm_set): New function extracted
13420         from...
13421         (rank_one_type): ... this.
13422
13423 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13424
13425         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13426         from...
13427         (rank_one_type): ... this.
13428
13429 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13430
13431         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13432         from...
13433         (rank_one_type): ... this.
13434
13435 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13436
13437         * gdbtypes.c (rank_one_type_parm_float): New function extracted
13438         from...
13439         (rank_one_type): ... this.
13440
13441 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13442
13443         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13444         from...
13445         (rank_one_type): ... this.
13446
13447 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13448
13449         * gdbtypes.c (rank_one_type_parm_range): New function extracted
13450         from...
13451         (rank_one_type): ... this.
13452
13453 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13454
13455         * gdbtypes.c (rank_one_type_parm_char): New function extracted
13456         from...
13457         (rank_one_type): ... this.
13458
13459 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13460
13461         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13462         from...
13463         (rank_one_type): ... this.
13464
13465 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13466
13467         * gdbtypes.c (rank_one_type_parm_int): New function extracted
13468         from...
13469         (rank_one_type): ... this.
13470
13471 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13472
13473         * gdbtypes.c (rank_one_type_parm_func): New function extracted
13474         from...
13475         (rank_one_type): ... this.
13476
13477 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13478
13479         * gdbtypes.c (rank_one_type_parm_array): New function extracted
13480         from...
13481         (rank_one_type): ... this.
13482
13483 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13484
13485         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13486         from...
13487         (rank_one_type): ... this.
13488
13489 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13490
13491         * inferior.c (initialize_inferiors): Ensure 'help set/show print
13492         inferior-events' shows the example events.
13493
13494 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
13495
13496         Support styling on native MS-Windows console
13497
13498         PR/24315
13499         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13500         on MS-Windows if $TERM is not defined.
13501
13502         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13503
13504         * posix-hdep.c (gdb_console_fputs):
13505         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13506         functions.
13507         * ui-file.h (gdb_console_fputs): Add prototype.
13508
13509         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13510         back to fputs only if the former returns zero.
13511
13512 2019-03-07  Tom Tromey  <tom@tromey.com>
13513
13514         * symmisc.c (print_symbol_bcache_statistics): Update.
13515         (print_objfile_statistics): Update.
13516         * symfile.c (allocate_symtab): Update.
13517         * stabsread.c: Don't include bcache.h.
13518         * psymtab.h (struct psymbol_bcache): Don't declare.
13519         (class psymtab_storage) <psymbol_cache>: Now a bcache.
13520         (psymbol_bcache_init, psymbol_bcache_free)
13521         (psymbol_bcache_get_bcache): Don't declare.
13522         * psymtab.c (struct psymbol_bcache): Remove.
13523         (psymtab_storage::psymtab_storage): Update.
13524         (psymtab_storage::~psymtab_storage): Update.
13525         (psymbol_bcache_init, psymbol_bcache_free)
13526         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13527         (add_psymbol_to_bcache): Update.
13528         (allocate_psymtab): Update.
13529         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13530         macro_cache>: No longer pointers.
13531         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13532         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13533         * macrotab.c (macro_bcache): Update.
13534         * macroexp.c: Don't include bcache.h.
13535         * gdbtypes.c (check_types_worklist): Update.
13536         (types_deeply_equal): Remove TRY/CATCH.  Update.
13537         * elfread.c (elf_symtab_read): Update.
13538         * dwarf2read.c: Don't include bcache.h.
13539         * buildsym.c (buildsym_compunit::get_macro_table): Update.
13540         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13541         (print_bcache_statistics, bcache_memory_used): Don't declare.
13542         (struct bcache): Move from bcache.c.  Add constructor, destructor,
13543         methods.  Rename all data members.
13544         * bcache.c (struct bcache): Move to bcache.h.
13545         (bcache::expand_hash_table): Rename from expand_hash_table.
13546         (bcache): Remove.
13547         (bcache::insert): Rename from bcache_full.
13548         (bcache::compare): Rename from bcache_compare.
13549         (bcache_xmalloc): Remove.
13550         (bcache::~bcache): Rename from bcache_xfree.
13551         (bcache::print_statistics): Rename from print_bcache_statistics.
13552         (bcache::memory_used): Rename from bcache_memory_used.
13553
13554 2019-03-07  Pedro Alves  <palves@redhat.com>
13555
13556         * infrun.c (normal_stop): Also check for
13557         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13558
13559 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
13560
13561         * f-lang.c (value_from_host_double): Moved to...
13562         * value.c (value_from_host_double): ...here.
13563         * value.h (value_from_host_double): Declare.
13564         * guile/scm-math.c (vlscm_convert_typed_number): Use
13565         value_from_host_double.
13566         (vlscm_convert_number): Likewise.
13567         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13568         * python/py-value.c (convert_value_from_python): Likewise.
13569
13570 2019-03-06  Tom Tromey  <tom@tromey.com>
13571
13572         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13573
13574 2019-03-06  Tom Tromey  <tom@tromey.com>
13575
13576         * utils.h (free_current_contents): Don't declare.
13577         * utils.c (free_current_contents): Remove.
13578
13579 2019-03-06  Tom Tromey  <tom@tromey.com>
13580
13581         * top.c (quit_force): Update.
13582         * main.c (captured_command_loop): Update.
13583         * common/new-op.c (operator new): Update.
13584         * common/common-exceptions.c (struct catcher)
13585         <save_cleanup_chain>: Remove member.
13586         (exceptions_state_mc_init): Update.
13587         (exception_try_scope_entry): Return nullptr.
13588         (exception_try_scope_exit, exception_rethrow)
13589         (throw_exception_sjlj, throw_exception_cxx): Update.
13590         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13591         (all_cleanups, do_cleanups, discard_cleanups)
13592         (discard_final_cleanups, save_cleanups, save_final_cleanups)
13593         (restore_cleanups, restore_final_cleanups): Don't declare.
13594         (do_final_cleanups): Remove parameter.
13595         * common/cleanups.c (cleanup_chain, make_cleanup)
13596         (make_cleanup_dtor, all_cleanups, do_cleanups)
13597         (discard_my_cleanups, discard_cleanups)
13598         (discard_final_cleanups, save_my_cleanups, save_cleanups)
13599         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13600         (null_cleanup): Remove.
13601         (do_final_cleanups): Remove parameter.
13602
13603 2019-03-06  Tom Tromey  <tom@tromey.com>
13604
13605         * remote.c (remote_target::remote_parse_stop_reply): Use
13606         unique_xmalloc_ptr.
13607
13608 2019-03-06  Tom Tromey  <tom@tromey.com>
13609
13610         * stabsread.c (struct stabs_field_info): Rename from field_info.
13611         <list, fnlist>: Add initializers.
13612         <obstack>: New member.
13613         (read_member_functions, read_struct_fields, read_baseclasses):
13614         Allocate on obstack.  Don't use cleanups.
13615         (read_one_struct_field, read_member_functions, read_struct_fields)
13616         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13617         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13618         (read_struct_type): Update.
13619
13620 2019-03-06  Tom Tromey  <tom@tromey.com>
13621
13622         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13623         * common/filestuff.h (make_cleanup_close): Don't declare.
13624         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13625         Remove.
13626
13627 2019-03-06  Tom Tromey  <tom@tromey.com>
13628
13629         * solib-aix.c: Use make_scope_exit.
13630
13631 2019-03-06  Tom Tromey  <tom@tromey.com>
13632
13633         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13634         Use make_scope_exit.
13635
13636 2019-03-06  Tom Tromey  <tom@tromey.com>
13637
13638         * solib-svr4.c (disable_probes_interface): Remove parameter.
13639         (svr4_handle_solib_event): Use make_scope_exit.
13640
13641 2019-03-06  Tom Tromey  <tom@tromey.com>
13642
13643         * remote.c (struct stop_reply_deleter): Remove.
13644         (stop_reply_up): Update.
13645         (struct stop_reply): Derive from notif_event.  Don't typedef.
13646         <regcache>: Now a std::vector.
13647         (stop_reply_xfree): Remove.
13648         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13649         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
13650         (remote_target::discard_pending_stop_replies): Use delete.
13651         (remote_target::remote_parse_stop_reply): Update.
13652         (remote_target::process_stop_reply): Update.
13653         * remote-notif.h (struct notif_event): Add virtual destructor.
13654         Remove "dtr" member.
13655         (struct notif_client) <alloc_event>: Return a unique_ptr.
13656         (notif_event_xfree): Don't declare.
13657         (notif_event_up): New typedef.
13658         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13659         (notif_event_xfree, do_notif_event_xfree): Remove.
13660         (remote_notif_state_xfree): Update.
13661
13662 2019-03-06  Tom Tromey  <tom@tromey.com>
13663
13664         * infrun.c (displaced_step_clear_cleanup): Now a
13665         forward_scope_exit type.
13666         (displaced_step_prepare_throw): Update.
13667         (displaced_step_fixup): Update.
13668
13669 2019-03-06  Tom Tromey  <tom@tromey.com>
13670
13671         * inferior.h (class inferior): Update comment.
13672         * gdbthread.h (class thread_info): Update comment.
13673
13674 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
13675             Tom Tromey  <tom@tromey.com>
13676
13677         * stabsread.h (struct stab_section_list): Remove.
13678         (coffstab_build_psymtabs): Update.
13679         * dbxread.c (symbuf_sections): Now a std::vector.
13680         (sect_idx): New global.
13681         (fill_symbuf): Update.
13682         (coffstab_build_psymtabs): Change type of stabsects parameter.
13683         Update.
13684         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13685         std::vector.
13686         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13687         (coff_locate_sections): Update.
13688         (coff_symfile_read): Remove cleanups.  Update.
13689         (init_stringtab): Add storage parameter.
13690         (free_stringtab, free_stringtab_cleanup): Remove.
13691         (init_lineno): Add storage parameter.
13692         (free_linetab, free_linetab_cleanup): Remove.
13693
13694 2019-03-06  Pedro Alves  <palves@redhat.com>
13695
13696         * linux-fork.c (fork_info::clobber_regs): Delete.
13697         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13698         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
13699         comment.  Adjust.
13700         (scoped_switch_fork_info::scoped_switch_fork_info)
13701         (checkpoint_command, linux_fork_context): Adjust
13702         fork_save_infrun_state calls.
13703
13704 2019-03-06  Pedro Alves  <palves@redhat.com>
13705
13706         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13707         (inf_has_multiple_threads): Return 'bool' and rewrite using
13708         inferior_info::threads().
13709
13710 2019-03-06  Pedro Alves  <palves@redhat.com>
13711
13712         * linux-fork.c: Include <list>.
13713         (fork_list): Now a std::list instance.
13714         (fork_info): Add ctor, dtor, and in-class initialize all fields.
13715         (forks_exist_p, find_last_fork): Adjust.
13716         (new_fork): Delete.
13717         (one_fork_p): New.
13718         (add_fork): Adjust.
13719         (free_fork): Delete, folded into fork_info::~fork_info().
13720         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13721         Adjust.
13722         (init_fork_list): Delete.
13723         (linux_fork_killall, linux_fork_mourn_inferior)
13724         (linux_fork_detach, info_checkpoints_command): Adjust.
13725         (_initialize_linux_fork): No longer call init_fork_list.
13726
13727 2019-03-06  Pedro Alves  <palves@redhat.com>
13728
13729         * linux-fork.c (new_fork): New, split out of ...
13730         (add_fork): ... this.  Return void.  Move "first fork" special
13731         case from here, to ...
13732         (checkpoint_command): ... here.
13733         * linux-linux.h (add_fork): Return void.
13734
13735 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13736
13737         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13738
13739 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13740             Chris January  <chris.january@arm.com>
13741             David Lecomber  <david.lecomber@arm.com>
13742
13743         * f-exp.y: New token, UNOP_INTRINSIC.
13744         (exp): New pattern using UNOP_INTRINSIC token.
13745         (f77_keywords): Add 'abs' keyword.
13746         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13747         (value_from_host_double): New function.
13748         (evaluate_subexp_f): Support UNOP_ABS.
13749
13750 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13751
13752         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13753         types.
13754
13755 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13756
13757         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13758         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13759         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13760
13761 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13762
13763         * f-exp.y (convert_to_kind_type): Handle more type kinds.
13764
13765 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13766             Chris January  <chris.january@arm.com>
13767
13768         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13769         * f-exp.y: Define 'KIND' token.
13770         (exp): New pattern for KIND expressions.
13771         (ptype): Handle types with a kind extension.
13772         (direct_abs_decl): Extend to spot kind extensions.
13773         (f77_keywords): Add 'kind' to the list.
13774         (push_kind_type): New function.
13775         (convert_to_kind_type): New function.
13776         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13777         * parse.c (operator_length_standard): Likewise.
13778         * parser-defs.h (enum type_pieces): Add tp_kind.
13779         * std-operator.def: Add UNOP_KIND.
13780
13781 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13782
13783         * f-exp.y (f_parse): Set yydebug.
13784
13785 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13786
13787         * f-lang.c (evaluate_subexp_f): New function.
13788         (exp_descriptor_f): New global.
13789         (f_language_defn): Use exp_descriptor_f instead of
13790         exp_descriptor_standard.
13791
13792 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13793
13794         * f-exp.y (struct token): Add comments.
13795         (dot_ops): Remove uppercase versions and the end marker.
13796         (f77_keywords): Likewise.
13797         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13798         entries in the dot_ops array are case insensitive, and use
13799         strncasecmp to compare strings.  Also some whitespace cleanup in
13800         this area.  Similar for the f77_keywords array, except entries in
13801         this list might be case sensitive.
13802
13803 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13804
13805         * f-exp.y (struct f77_boolean_val): Add comments.
13806         (boolean_values): Remove uppercase versions, and end marker.
13807         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13808         and use strncasecmp to achieve case insensitivity.  Additionally,
13809         perform whitespace cleanup around this code.
13810
13811 2019-03-06  Tom Tromey  <tromey@adacore.com>
13812
13813         * remote-sim.c (gdbsim_target_open): Use result of
13814         gdb_argv::release.
13815
13816 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
13817         Dirk Schubert  <dirk.schubert@arm.com>
13818         Chris January  <chris.january@arm.com>
13819
13820         * eval.c (evaluate_subexp_standard): Call Fortran argument
13821         wrapping logic.
13822         * f-lang.c (struct value): A value which can be passed into a
13823         Fortran function call.
13824         (fortran_argument_convert): Wrap Fortran arguments in a pointer
13825         where appropriate.
13826         (struct type): Value ready for a Fortran function call.
13827         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13828         is needed.
13829         * f-lang.h (fortran_argument_convert): Declaration.
13830         (fortran_preserve_arg_pointer): Declaration.
13831         * infcall.c (value_arg_coerce): Call Fortran argument logic.
13832
13833 2019-03-05  Tom Tromey  <tromey@adacore.com>
13834
13835         * python/py-prettyprint.c (print_string_repr): Remove #if.
13836         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13837
13838 2019-03-05  Tom Tromey  <tromey@adacore.com>
13839
13840         * target.c (the_dummy_target): Move later.  Change type to
13841         "dummy_target".
13842         (initialize_targets): Don't initialize the_dummy_target.
13843
13844 2019-03-05  Tom Tromey  <tromey@adacore.com>
13845
13846         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13847         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13848
13849 2019-03-05  Tom Tromey  <tromey@adacore.com>
13850
13851         * windows-nat.c (windows_nat_target::attach)
13852         (windows_nat_target::detach): Don't call gdb_flush.
13853         * valprint.c (generic_val_print, val_print, val_print_string):
13854         Don't call gdb_flush.
13855         * utils.c (defaulted_query): Don't call gdb_flush.
13856         * typeprint.c (print_type_scalar): Don't call gdb_flush.
13857         * target.c (target_announce_detach): Don't call gdb_flush.
13858         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13859         * remote.c (extended_remote_target::attach): Don't call
13860         gdb_flush.
13861         * procfs.c (procfs_target::detach): Don't call gdb_flush.
13862         * printcmd.c (do_examine): Don't call gdb_flush.
13863         (info_display_command): Don't call gdb_flush.
13864         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13865         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13866         * memattr.c (info_mem_command): Don't call gdb_flush.
13867         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13868         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13869         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13870         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13871         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13872         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13873         (gnu_nat_target::detach): Don't call gdb_flush.
13874         * f-valprint.c (f_val_print): Don't call gdb_flush.
13875         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13876         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13877         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13878         gdb_flush.
13879         * c-valprint.c (c_val_print): Don't call gdb_flush.
13880         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13881
13882 2019-03-05  Tom Tromey  <tromey@adacore.com>
13883
13884         * varobj.c (update_dynamic_varobj_children): Update.
13885         (install_default_visualizer): Use reset, not release.
13886         * value.c (set_internalvar): Update.
13887         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13888         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13889         ATTRIBUTE_UNUSED_RESULT.
13890
13891 2019-03-05  Tom Tromey  <tromey@adacore.com>
13892
13893         * remote.c (class scoped_remote_fd) <release>: Add
13894         ATTRIBUTE_UNUSED_RESULT.
13895
13896 2019-03-05  Tom Tromey  <tromey@adacore.com>
13897
13898         * macroexp.c (struct macro_buffer) <release>: Add
13899         ATTRIBUTE_UNUSED_RESULT.
13900
13901 2019-03-05  Tom Tromey  <tromey@adacore.com>
13902
13903         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13904         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13905         ATTRIBUTE_UNUSED_RESULT.
13906
13907 2019-03-05  Tom Tromey  <tromey@adacore.com>
13908
13909         * common/scoped_fd.h (class scoped_fd) <release>: Add
13910         ATTRIBUTE_UNUSED_RESULT.
13911
13912 2019-03-05  Tom Tromey  <tromey@adacore.com>
13913
13914         * parser-defs.h (struct parser_state) <release>: Add
13915         ATTRIBUTE_UNUSED_RESULT.
13916
13917 2019-03-05  Tom Tromey  <tromey@adacore.com>
13918
13919         * utils.h (class gdb_argv) <release>: Add
13920         ATTRIBUTE_UNUSED_RESULT.
13921         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13922
13923 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
13924
13925         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
13926         for-loop range, to avoid compiler warnings.
13927
13928         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13929         avoid compiler warnings about unused variables.
13930
13931         * NEWS: Mention end of support for native debugging on MS-Windows
13932         before XP.
13933
13934         PR gdb/24292
13935         * common/netstuff.c:
13936         * gdbserver/gdbreplay.c
13937         * gdbserver/remote-utils.c:
13938         * ser-tcp.c:
13939         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
13940         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
13941         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
13942         'getaddrinfo' and 'freeaddrinfo' were not available before
13943         Windows XP, and mingw.org's MinGW headers by default define
13944         _WIN32_WINNT to 0x500.
13945
13946 2019-03-01  Gary Benson <gbenson@redhat.com>
13947
13948         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
13949
13950 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
13951             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
13952
13953         PR gdb/8527
13954         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
13955         set_sigint_trap, clear_sigint_trap.
13956
13957 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13958
13959         * target.c (target_detach): Clear the regcache and the
13960         frame cache.
13961
13962 2019-02-27  Pedro Alves  <palves@redhat.com>
13963
13964         * utils.c (set_screen_size): When we cap the height/width sizes,
13965         tweak the corresponding command variable to show "unlimited":
13966
13967 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
13968             Pedro Alves  <palves@redhat.com>
13969
13970         * utils.c (set_screen_size): Reduce "infinite" rows and columns
13971         before calling rl_set_screen_size.
13972
13973 2019-02-27  Tom Tromey  <tromey@adacore.com>
13974
13975         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
13976         define.
13977         * python/py-value.c: Remove Python 2.4 workaround.
13978         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
13979         workaround.
13980         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
13981         Python 2.4 workaround.
13982         * python/python-internal.h: Remove Python 2.4 comment.
13983         (Py_ssize_t): Don't define.
13984         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
13985         (gdb_Py_DECREF): Remove Python 2.4 workaround.
13986         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
13987         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
13988         * python/python.c (do_start_initialization): Remove Python 2.4
13989         workaround.
13990         * python/py-prettyprint.c (class dummy_python_frame): Remove.
13991         (print_children): Remove Python 2.4 workaround.
13992         * python/py-inferior.c (buffer_procs): Remove Python 2.4
13993         workaround.
13994         (CHARBUFFERPROC_NAME): Remove.
13995         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
13996         Python 2.4 workaround.
13997
13998 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
13999
14000         * NEWS: Note minimum Python version.
14001
14002 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14003
14004         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14005         code from these functions.  Remove corresponding ifdefs.  Use
14006         Py_buffer_up instead of explicit calls to PyBuffer_Release.
14007         Remove gotos and target of gotos.
14008         (infpy_search_memory): Likewise.
14009
14010 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14011
14012         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14013         (hppa_gdbarch_init): Don't register deleted functions with
14014         gdbarch.
14015
14016 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14017
14018         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14019         (h8300_unwind_sp): Delete.
14020         (h8300_dummy_id): Delete.
14021         (h8300_gdbarch_init): Don't register deleted functions with
14022         gdbarch.
14023
14024 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14025
14026         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14027         (ft32_unwind_pc): Delete.
14028         (ft32_unwind_sp): Delete.
14029         (ft32_gdbarch_init): Don't register deleted functions with
14030         gdbarch.
14031
14032 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14033
14034         * gdb/frv-tdep.c (frv_dummy_id): Delete.
14035         (frv_unwind_pc): Delete.
14036         (frv_unwind_sp): Delete.
14037         (frv_gdbarch_init): Don't register deleted functions with
14038         gdbarch.
14039
14040 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14041
14042         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14043         (riscv_unwind_pc): Delete.
14044         (riscv_unwind_sp): Delete.
14045         (riscv_gdbarch_init): Don't register deleted functions with
14046         gdbarch.
14047
14048 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14049
14050         * gdb/csky-tdep.c (csky_dummy_id): Delete.
14051         (csky_unwind_pc): Delete.
14052         (csky_unwind_sp): Delete.
14053         (csky_gdbarch_init): Don't register deleted functions with
14054         gdbarch.
14055
14056 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14057
14058         * gdb/cris-tdep.c (cris_dummy_id): Delete.
14059         (cris_unwind_pc): Delete.
14060         (cris_unwind_sp): Delete.
14061         (cris_gdbarch_init): Don't register deleted functions with
14062         gdbarch.
14063
14064 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14065
14066         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14067         (bfin_unwind_pc): Delete.
14068         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14069
14070 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14071
14072         * gdb/arm-tdep.c (arm_dummy_id): Delete.
14073         (arm_unwind_pc): Delete.
14074         (arm_unwind_sp): Delete.
14075         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14076
14077 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14078
14079         * gdb/arc-tdep.c (arc_dummy_id): Delete.
14080         (arc_unwind_pc): Delete.
14081         (arc_unwind_sp): Delete.
14082         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14083
14084 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14085
14086         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14087         (alpha_unwind_pc): Delete.
14088         (alpha_gdbarch_init): Don't register deleted functions with
14089         gdbarch.
14090
14091 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14092
14093         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14094         (aarch64_unwind_pc): Delete.
14095         (aarch64_unwind_sp): Delete.
14096         (aarch64_gdbarch_init): Don't register deleted functions with
14097         gdbarch.
14098
14099 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14100
14101         * gdbtypes.c (type_align): Don't consider static members when
14102         computing structure alignment.
14103
14104 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14105
14106         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14107         return 0 for other types.
14108         * arch-utils.c (default_type_align): Always return 0.
14109         * gdbarch.h: Regenerate.
14110         * gdbarch.sh (type_align): Extend comment.
14111         * gdbtypes.c (type_align): Add additional comments, always call
14112         gdbarch_type_align before applying the default rules.
14113         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14114         generic code will then apply a suitable default.
14115         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14116         types, return 0 for other types.
14117
14118 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14119
14120         * NEWS: Create a new section for the next release branch.
14121         Rename the section of the current branch, now that it has
14122         been cut.
14123
14124 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14125
14126         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14127         * version.in: Bump version to 8.3.50.DATE-git.
14128
14129 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
14130
14131         * aix-thread.c (ptid_cmp): Remove unused variable.
14132         (get_signaled_thread): Likewise.
14133         (store_regs_user_thread): Likewise.
14134         (store_regs_kernel_thread): Likewise.
14135         (fetch_regs_kernel_thread): Remove shadowed variable.
14136
14137 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
14138
14139         * features/riscv/32bit-cpu.xml: Add register numbers.
14140         * features/riscv/32bit-fpu.c: Regenerate.
14141         * features/riscv/32bit-fpu.xml: Add register numbers.
14142         * features/riscv/64bit-cpu.xml: Add register numbers.
14143         * features/riscv/64bit-fpu.c: Regenerate.
14144         * features/riscv/64bit-fpu.xml: Add register numbers.
14145
14146 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
14147
14148         * NEWS: Mention two argument form of gdb.Value constructor.
14149         * python/py-value.c (convert_buffer_and_type_to_value): New
14150         function.
14151         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14152         Add support for handling an optional second argument.  Call
14153         convert_buffer_and_type_to_value as appropriate.
14154         * python/python-internal.h (Py_buffer_deleter): New struct.
14155         (Py_buffer_up): New typedef.
14156
14157 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
14158
14159         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14160         instead of releasing ownership.
14161
14162 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
14163
14164         * dwarf2read.c (open_and_init_dwp_file): Call
14165         elf_numsections instead of bfd_count_sections to initialize
14166         dwp_file->num_sections.
14167
14168 2019-02-25  Tom Tromey  <tromey@adacore.com>
14169
14170         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14171
14172 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
14173
14174         * gcore.in: Add '--readnever' option when invoking GDB.
14175
14176 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14177
14178         * MAINTAINERS: Update my email address.
14179
14180 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14181
14182         * build-id.c (build_id_to_debug_bfd_1): New function.
14183         (build_id_to_debug_bfd): Look for separate debug file in
14184         sysroot.
14185
14186 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
14187
14188         * gdbarch.sh: Update the copyright year range that is placed into
14189         generated files.
14190
14191 2019-02-22  Keith Seitz  <keiths@redhat.com>
14192
14193         PR symtab/23853
14194         * linespec.c (create_sals_line_offset): Search for the default
14195         symtab's filename instead of its fullname.
14196
14197 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14198
14199         * NEWS: Update style defaults.
14200
14201 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14202
14203         * main.c (captured_main_1): Disable styling in batch mode.
14204
14205 2019-02-20  Tom Tromey  <tom@tromey.com>
14206
14207         * symtab.c (symtab_symbol_info): Fix typos.
14208
14209 2019-02-20  Tom Tromey  <tromey@adacore.com>
14210
14211         * findcmd.c (_initialize_mem_search): Use upper case for
14212         metasyntactic variables.
14213
14214 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
14215
14216         * aarch64-tdep.c (aarch64_add_reggroups): New function.
14217         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14218
14219 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
14220
14221         * top.h (source_file_name): Change to std::string.
14222         * top.c (source_file_name): Likewise.
14223         (command_line_input): Adjust.
14224         * cli/cli-script.c (script_from_file): Adjust.
14225
14226 2019-02-19  Tom Tromey  <tromey@adacore.com>
14227
14228         * ravenscar-thread.c
14229         (ravenscar_thread_target::update_thread_list): Don't call
14230         ada_build_task_list.
14231         * ada-lang.h (ada_build_task_list): Don't declare.
14232         * ada-tasks.c (struct ada_tasks_inferior_data)
14233         <task_list_valid_p>: Now bool.
14234         (read_known_tasks, ada_task_list_changed)
14235         (ada_tasks_invalidate_inferior_data): Update.
14236         (read_known_tasks_array): Return bool.
14237         (read_known_tasks_list): Likewise.
14238         (read_known_tasks): Return void.
14239         (ada_build_task_list): Now static.
14240
14241 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
14242
14243         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14244         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14245
14246 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14247
14248         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14249         variant for ada_tasks_pspace_data_handle and
14250         ada_tasks_inferior_data_handle.
14251         (ada_tasks_pspace_data_cleanup): New function.
14252         (ada_tasks_inferior_data_cleanup): New function.
14253
14254 2019-02-17  Tom Tromey  <tom@tromey.com>
14255
14256         * macrotab.h (macro_source_fullname): Return a std::string.
14257         * macrotab.c (macro_include, check_for_redefinition)
14258         (macro_undef, macro_lookup_definition, foreach_macro)
14259         (foreach_macro_in_scope): Update.
14260         (macro_source_fullname): Return a std::string.
14261         * macrocmd.c (show_pp_source_pos): Update.
14262
14263 2019-02-17  Tom Tromey  <tom@tromey.com>
14264
14265         * macrocmd.c (show_pp_source_pos): Style the file names.
14266
14267 2019-02-17  Tom Tromey  <tom@tromey.com>
14268
14269         PR tui/24197:
14270         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14271
14272 2019-02-17  Tom Tromey  <tom@tromey.com>
14273
14274         * ada-lang.c (user_select_syms): Use filtered printing.
14275         * utils.c (wrap_style): New global.
14276         (desired_style): Remove.
14277         (emit_style_escape): Add stream parameter.
14278         (set_output_style, reset_terminal_style, prompt_for_continue):
14279         Update.
14280         (flush_wrap_buffer): Only flush gdb_stdout.
14281         (wrap_here): Set wrap_style.
14282         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
14283         treat escape sequences as a character.  Change when wrap buffer is
14284         flushed.
14285         (fputs_styled): Do not set the output style when the default is
14286         requested.
14287         * ui-style.h (struct ui_file_style) <is_default>: New method.
14288         * source.c (print_source_lines_base): Emit escape sequences in one
14289         piece.
14290
14291 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14292
14293         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14294         integers and enumeration types.
14295
14296 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14297
14298         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14299         instead of lookup_symbol_in_language
14300         (do_exact_match): New function.
14301         (ada_get_symbol_name_matcher): Return do_exact_match when
14302         doing a verbatim match.
14303
14304 2019-02-15  Tom Tromey  <tromey@adacore.com>
14305
14306         * ravenscar-thread.c (ravenscar_thread_target::resume)
14307         (ravenscar_thread_target::wait): Special case wildcard requests.
14308
14309 2019-02-15  Tom Tromey  <tromey@adacore.com>
14310
14311         * ravenscar-thread.c (base_ptid): Remove.
14312         (struct ravenscar_thread_target) <close>: New method.
14313         <m_base_ptid>: New member.
14314         <update_inferior_ptid, active_task, task_is_currently_active,
14315         runtime_initialized>: Declare methods.
14316         <ravenscar_thread_target>: Add constructor.
14317         (ravenscar_thread_target::task_is_currently_active)
14318         (ravenscar_thread_target::update_inferior_ptid)
14319         (ravenscar_runtime_initialized): Rename.  Now methods.
14320         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14321         (ravenscar_thread_target::update_thread_list): Update.
14322         (ravenscar_thread_target::active_task): Now method.
14323         (ravenscar_thread_target::store_registers)
14324         (ravenscar_thread_target::prepare_to_store)
14325         (ravenscar_thread_target::prepare_to_store)
14326         (ravenscar_thread_target::mourn_inferior): Update.
14327         (ravenscar_inferior_created): Use "new" to create target.
14328         (ravenscar_thread_target::get_ada_task_ptid): Update.
14329         (_initialize_ravenscar): Don't initialize base_ptid.
14330         (ravenscar_ops): Remove global.
14331
14332 2019-02-15  Tom Tromey  <tromey@adacore.com>
14333
14334         * target.h (push_target): Declare new overload.
14335         * target.c (push_target): New overload, taking an rvalue reference.
14336         * remote.c (remote_target::open_1): Use push_target overload.
14337         * corelow.c (core_target_open): Use push_target overload.
14338
14339 2019-02-15  Tom Tromey  <tromey@adacore.com>
14340
14341         * ravenscar-thread.c (is_ravenscar_task)
14342         (ravenscar_task_is_currently_active): Return bool.
14343         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14344         (_initialize_ravenscar): Remove "(void)".
14345         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14346         Return bool.
14347
14348 2019-02-15  Tom Tromey  <tromey@adacore.com>
14349
14350         * ravenscar-thread.c (ravenscar_runtime_initializer)
14351         (has_ravenscar_runtime, get_running_thread_id)
14352         (ravenscar_thread_target::resume): Fix indentation.
14353
14354 2019-02-15  Tom Tromey  <tromey@adacore.com>
14355
14356         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14357         from ravenscar_arch_ops.
14358         (sparc_ravenscar_ops::fetch_registers)
14359         (sparc_ravenscar_ops::store_registers): Now methods.
14360         (sparc_ravenscar_prepare_to_store): Remove.
14361         (sparc_ravenscar_ops): Redefine.
14362         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14363         methods and destructor.  Remove members.
14364         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14365         (ravenscar_thread_target::store_registers)
14366         (ravenscar_thread_target::prepare_to_store): Update.
14367         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14368         Remove.
14369         (struct ppc_ravenscar_powerpc_ops): Derive from
14370         ravenscar_arch_ops.
14371         (ppc_ravenscar_powerpc_ops::fetch_registers)
14372         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14373         (ppc_ravenscar_powerpc_ops): Redefine.
14374         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14375         (ppc_ravenscar_e500_ops::fetch_registers)
14376         (ppc_ravenscar_e500_ops::store_registers): Now methods.
14377         (ppc_ravenscar_e500_ops): Redefine.
14378         * aarch64-ravenscar-thread.c
14379         (aarch64_ravenscar_generic_prepare_to_store): Remove.
14380         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14381         (aarch64_ravenscar_fetch_registers)
14382         (aarch64_ravenscar_store_registers): Now methods.
14383         (aarch64_ravenscar_ops): Redefine.
14384
14385 2019-02-15  Tom Tromey  <tromey@adacore.com>
14386
14387         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14388         (ravenscar_thread_target::stopped_by_hw_breakpoint)
14389         (ravenscar_thread_target::stopped_by_watchpoint)
14390         (ravenscar_thread_target::stopped_data_address)
14391         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14392
14393 2019-02-15  Tom Tromey  <tromey@adacore.com>
14394
14395         * ravenscar-thread.c: Fix some typos.
14396
14397 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14398             Tom Tromey  <tromey@adacore.com>
14399
14400         * ada-lang.c (ada_exception_sal): Change addr_string to a
14401         std::string.
14402         (create_ada_exception_catchpoint): Update.
14403
14404 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14405             Tom Tromey  <tromey@adacore.com>
14406
14407         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14408         (bp_location_ops): Remove.
14409         (base_breakpoint_allocate_location): Update.
14410         (free_bp_location): Update.
14411         * ada-lang.c (class ada_catchpoint_location)
14412         <ada_catchpoint_location>: Remove ops parameter.
14413         (ada_catchpoint_location_dtor): Remove.
14414         (ada_catchpoint_location_ops): Remove.
14415         (allocate_location_exception): Update.
14416         * breakpoint.h (struct bp_location_ops): Remove.
14417         (class bp_location) <bp_location>: Remove bp_location_ops
14418         parameter.
14419         <~bp_location>: Add destructor.
14420         <ops>: Remove.
14421
14422 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14423             Pedro Alves  <palves@redhat.com>
14424
14425         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14426         'PATH_MAX'.
14427
14428 2019-02-14  David Michael  <fedora.dm0@gmail.com>
14429             Samuel Thibault  <samuel.thibault@gnu.org>
14430             Thomas Schwinge  <thomas@codesourcery.com>
14431
14432         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14433         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14434
14435 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14436
14437         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14438         (check_empty): Use "const char *".
14439
14440         * gnu-nat.c (gnu_nat_target::detach): Instead of
14441         'detach_inferior (pid)' call
14442         'detach_inferior (find_inferior_pid (pid))'.
14443
14444         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14445         'nat/fork-inferior.o'.
14446         * gnu-nat.c: #include "nat/fork-inferior.h".
14447
14448         * gnu-nat.c (gnu_nat_target::detach): Instead of
14449         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14450         * gnu-nat.h: #include "inf-child.h".
14451         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14452         'i386_gnu_nat_target::fetch_registers'.
14453         (gnu_store_registers): Rename/move to
14454         'i386_gnu_nat_target::store_registers'.
14455
14456         * config/i386/nm-i386gnu.h: Don't "#include" any files.
14457         * gnu-nat.h (mach_thread_info): New function.
14458         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14459
14460         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14461
14462 2019-02-14  Frederic Konrad  <konrad@adacore.com>
14463
14464         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14465
14466 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
14467
14468         * windows-nat.c (windows_add_thread): Add new parameter
14469         "main_thread_p" with default value set to false.  Update
14470         function documentation as well as all callers.
14471         (windows_delete_thread): Likewise.
14472         (fake_create_process): Update call to windows_add_thread.
14473         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14474         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14475         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14476         call to windows_delete_thread.
14477
14478 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
14479
14480         * MAINTAINERS: Add Andrew Burgess as global maintainer.
14481
14482 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14483
14484         * symfile.c (find_separate_debug_file): Use canonical path of
14485         sysroot with child_path instead of gdb_sysroot if it is valid.
14486
14487 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14488
14489         * symfile.c (find_separate_debug_file): Use child_path to
14490         determine if an object file is under a sysroot.
14491
14492 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14493
14494         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14495         unittests/child-path-selftests.c.
14496         * common/pathstuff.c (child_path): New function.
14497         * common/pathstuff.h (child_path): New prototype.
14498         * unittests/child-path-selftests.c: New file.
14499
14500 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14501
14502         * symfile.c (find_separate_debug_file): Look for separate debug
14503         files in debug directories under the sysroot.
14504
14505 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14506
14507         * symtab.h (struct minimal_symbol data_p): New const method.
14508         (struct minimal_symbol text_p): Likewise.
14509         * symtab.c (output_source_filename): Use file name style
14510         to print file name.
14511         (print_symbol_info): Likewise.
14512         (print_msymbol_info): Use address style to print addresses.
14513         Use function name style to print executable text symbols.
14514         (expand_symtab_containing_pc): Use data_p.
14515         (find_pc_sect_compunit_symtab): Likewise.
14516
14517 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14518
14519         * breakpoint.c (describe_other_breakpoints): Use address style
14520         to print addresses.
14521         (say_where): Likewise.
14522
14523 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14524
14525         * ada-typeprint.c (print_func_type): Print function name
14526         style to print function name.
14527         * c-typeprint.c (c_print_type_1): Likewise.
14528
14529 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
14530
14531         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14532         for execve.
14533
14534 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14535
14536         * c-exp.y (direct_abs_decl): Use emplace_back to record the
14537         type_stack.
14538
14539 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
14540
14541         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14542         TYPE_CODE_REF types.
14543
14544 2019-02-08  Jim Wilson  <jimw@sifive.com>
14545
14546         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14547         (riscv_linux_fregset): New.
14548         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14549
14550 2019-02-07  Tom Tromey  <tom@tromey.com>
14551
14552         * thread.c (thread_cancel_execution_command): Update.
14553         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14554         methods.
14555         (struct thread_fsm_ops): Remove.
14556         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14557         (thread_fsm_should_stop, thread_fsm_return_value)
14558         (thread_fsm_set_finished, thread_fsm_finished_p)
14559         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14560         Don't declare.
14561         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14562         * infrun.c (clear_proceed_status_thread)
14563         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14564         (print_stop_event): Update.
14565         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14566         Add constructor.
14567         (step_command_fsm_ops): Remove.
14568         (new_step_command_fsm): Remove.
14569         (step_1): Update.
14570         (step_command_fsm::should_stop): Rename from
14571         step_command_fsm_should_stop.
14572         (step_command_fsm::clean_up): Rename from
14573         step_command_fsm_clean_up.
14574         (step_command_fsm::do_async_reply_reason): Rename from
14575         step_command_fsm_async_reply_reason.
14576         (struct until_next_fsm): Inherit from thread_fsm.  Add
14577         constructor.
14578         (until_next_fsm_ops): Remove.
14579         (new_until_next_fsm): Remove.
14580         (until_next_fsm::should_stop): Rename from
14581         until_next_fsm_should_stop.
14582         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14583         (until_next_fsm::do_async_reply_reason): Rename from
14584         until_next_fsm_async_reply_reason.
14585         (struct finish_command_fsm): Inherit from thread_fsm.  Add
14586         constructor.  Change type of breakpoint.
14587         (finish_command_fsm_ops): Remove.
14588         (new_finish_command_fsm): Remove.
14589         (finish_command_fsm::should_stop): Rename from
14590         finish_command_fsm_should_stop.
14591         (finish_command_fsm::clean_up): Rename from
14592         finish_command_fsm_clean_up.
14593         (finish_command_fsm::return_value): Rename from
14594         finish_command_fsm_return_value.
14595         (finish_command_fsm::do_async_reply_reason): Rename from
14596         finish_command_fsm_async_reply_reason.
14597         (finish_command): Update.
14598         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14599         Add constructor.
14600         (call_thread_fsm_ops): Remove.
14601         (call_thread_fsm::call_thread_fsm): Rename from
14602         new_call_thread_fsm.
14603         (call_thread_fsm::should_stop): Rename from
14604         call_thread_fsm_should_stop.
14605         (call_thread_fsm::should_notify_stop): Rename from
14606         call_thread_fsm_should_notify_stop.
14607         (run_inferior_call, call_function_by_hand_dummy): Update.
14608         * cli/cli-interp.c (should_print_stop_to_console): Update.
14609         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14610         Add constructor.  Change type of location_breakpoint,
14611         caller_breakpoint.
14612         (until_break_fsm_ops): Remove.
14613         (new_until_break_fsm): Remove.
14614         (until_break_fsm::should_stop): Rename from
14615         until_break_fsm_should_stop.
14616         (until_break_fsm::clean_up): Rename from
14617         until_break_fsm_clean_up.
14618         (until_break_fsm::do_async_reply_reason): Rename from
14619         until_break_fsm_async_reply_reason.
14620         (until_break_command): Update.
14621         * thread-fsm.c: Remove.
14622         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14623
14624 2019-02-07  Tom Tromey  <tom@tromey.com>
14625
14626         * yy-remap.h: Add include guard.
14627         * xtensa-tdep.h: Add include guard.
14628         * xcoffread.h: Rename include guard.
14629         * varobj-iter.h: Add include guard.
14630         * tui/tui.h: Rename include guard.
14631         * tui/tui-winsource.h: Rename include guard.
14632         * tui/tui-wingeneral.h: Rename include guard.
14633         * tui/tui-windata.h: Rename include guard.
14634         * tui/tui-win.h: Rename include guard.
14635         * tui/tui-stack.h: Rename include guard.
14636         * tui/tui-source.h: Rename include guard.
14637         * tui/tui-regs.h: Rename include guard.
14638         * tui/tui-out.h: Rename include guard.
14639         * tui/tui-layout.h: Rename include guard.
14640         * tui/tui-io.h: Rename include guard.
14641         * tui/tui-hooks.h: Rename include guard.
14642         * tui/tui-file.h: Rename include guard.
14643         * tui/tui-disasm.h: Rename include guard.
14644         * tui/tui-data.h: Rename include guard.
14645         * tui/tui-command.h: Rename include guard.
14646         * tic6x-tdep.h: Add include guard.
14647         * target/waitstatus.h: Rename include guard.
14648         * target/wait.h: Rename include guard.
14649         * target/target.h: Rename include guard.
14650         * target/resume.h: Rename include guard.
14651         * target-float.h: Rename include guard.
14652         * stabsread.h: Add include guard.
14653         * rs6000-tdep.h: Add include guard.
14654         * riscv-fbsd-tdep.h: Add include guard.
14655         * regformats/regdef.h: Rename include guard.
14656         * record.h: Rename include guard.
14657         * python/python.h: Rename include guard.
14658         * python/python-internal.h: Rename include guard.
14659         * python/py-stopevent.h: Rename include guard.
14660         * python/py-ref.h: Rename include guard.
14661         * python/py-record.h: Rename include guard.
14662         * python/py-record-full.h: Rename include guard.
14663         * python/py-record-btrace.h: Rename include guard.
14664         * python/py-instruction.h: Rename include guard.
14665         * python/py-events.h: Rename include guard.
14666         * python/py-event.h: Rename include guard.
14667         * procfs.h: Add include guard.
14668         * proc-utils.h: Add include guard.
14669         * p-lang.h: Add include guard.
14670         * or1k-tdep.h: Rename include guard.
14671         * observable.h: Rename include guard.
14672         * nto-tdep.h: Rename include guard.
14673         * nat/x86-linux.h: Rename include guard.
14674         * nat/x86-linux-dregs.h: Rename include guard.
14675         * nat/x86-gcc-cpuid.h: Add include guard.
14676         * nat/x86-dregs.h: Rename include guard.
14677         * nat/x86-cpuid.h: Rename include guard.
14678         * nat/ppc-linux.h: Rename include guard.
14679         * nat/mips-linux-watch.h: Rename include guard.
14680         * nat/linux-waitpid.h: Rename include guard.
14681         * nat/linux-ptrace.h: Rename include guard.
14682         * nat/linux-procfs.h: Rename include guard.
14683         * nat/linux-osdata.h: Rename include guard.
14684         * nat/linux-nat.h: Rename include guard.
14685         * nat/linux-namespaces.h: Rename include guard.
14686         * nat/linux-btrace.h: Rename include guard.
14687         * nat/glibc_thread_db.h: Rename include guard.
14688         * nat/gdb_thread_db.h: Rename include guard.
14689         * nat/gdb_ptrace.h: Rename include guard.
14690         * nat/fork-inferior.h: Rename include guard.
14691         * nat/amd64-linux-siginfo.h: Rename include guard.
14692         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14693         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14694         * nat/aarch64-linux.h: Rename include guard.
14695         * nat/aarch64-linux-hw-point.h: Rename include guard.
14696         * mn10300-tdep.h: Add include guard.
14697         * mips-linux-tdep.h: Add include guard.
14698         * mi/mi-parse.h: Rename include guard.
14699         * mi/mi-out.h: Rename include guard.
14700         * mi/mi-main.h: Rename include guard.
14701         * mi/mi-interp.h: Rename include guard.
14702         * mi/mi-getopt.h: Rename include guard.
14703         * mi/mi-console.h: Rename include guard.
14704         * mi/mi-common.h: Rename include guard.
14705         * mi/mi-cmds.h: Rename include guard.
14706         * mi/mi-cmd-break.h: Rename include guard.
14707         * m2-lang.h: Add include guard.
14708         * location.h: Rename include guard.
14709         * linux-record.h: Rename include guard.
14710         * linux-nat.h: Add include guard.
14711         * linux-fork.h: Add include guard.
14712         * i386-darwin-tdep.h: Rename include guard.
14713         * hppa-linux-offsets.h: Add include guard.
14714         * guile/guile.h: Rename include guard.
14715         * guile/guile-internal.h: Rename include guard.
14716         * gnu-nat.h: Rename include guard.
14717         * gdb-stabs.h: Rename include guard.
14718         * frv-tdep.h: Add include guard.
14719         * f-lang.h: Add include guard.
14720         * event-loop.h: Add include guard.
14721         * darwin-nat.h: Rename include guard.
14722         * cp-abi.h: Rename include guard.
14723         * config/sparc/nm-sol2.h: Rename include guard.
14724         * config/nm-nto.h: Rename include guard.
14725         * config/nm-linux.h: Add include guard.
14726         * config/i386/nm-i386gnu.h: Rename include guard.
14727         * config/djgpp/nl_types.h: Rename include guard.
14728         * config/djgpp/langinfo.h: Rename include guard.
14729         * compile/gcc-cp-plugin.h: Add include guard.
14730         * compile/gcc-c-plugin.h: Add include guard.
14731         * compile/compile.h: Rename include guard.
14732         * compile/compile-object-run.h: Rename include guard.
14733         * compile/compile-object-load.h: Rename include guard.
14734         * compile/compile-internal.h: Rename include guard.
14735         * compile/compile-cplus.h: Rename include guard.
14736         * compile/compile-c.h: Rename include guard.
14737         * common/xml-utils.h: Rename include guard.
14738         * common/x86-xstate.h: Rename include guard.
14739         * common/version.h: Rename include guard.
14740         * common/vec.h: Rename include guard.
14741         * common/tdesc.h: Rename include guard.
14742         * common/selftest.h: Rename include guard.
14743         * common/scoped_restore.h: Rename include guard.
14744         * common/scoped_mmap.h: Rename include guard.
14745         * common/scoped_fd.h: Rename include guard.
14746         * common/safe-iterator.h: Rename include guard.
14747         * common/run-time-clock.h: Rename include guard.
14748         * common/refcounted-object.h: Rename include guard.
14749         * common/queue.h: Rename include guard.
14750         * common/ptid.h: Rename include guard.
14751         * common/print-utils.h: Rename include guard.
14752         * common/preprocessor.h: Rename include guard.
14753         * common/pathstuff.h: Rename include guard.
14754         * common/observable.h: Rename include guard.
14755         * common/netstuff.h: Rename include guard.
14756         * common/job-control.h: Rename include guard.
14757         * common/host-defs.h: Rename include guard.
14758         * common/gdb_wait.h: Rename include guard.
14759         * common/gdb_vecs.h: Rename include guard.
14760         * common/gdb_unlinker.h: Rename include guard.
14761         * common/gdb_unique_ptr.h: Rename include guard.
14762         * common/gdb_tilde_expand.h: Rename include guard.
14763         * common/gdb_sys_time.h: Rename include guard.
14764         * common/gdb_string_view.h: Rename include guard.
14765         * common/gdb_splay_tree.h: Rename include guard.
14766         * common/gdb_setjmp.h: Rename include guard.
14767         * common/gdb_ref_ptr.h: Rename include guard.
14768         * common/gdb_optional.h: Rename include guard.
14769         * common/gdb_locale.h: Rename include guard.
14770         * common/gdb_assert.h: Rename include guard.
14771         * common/filtered-iterator.h: Rename include guard.
14772         * common/filestuff.h: Rename include guard.
14773         * common/fileio.h: Rename include guard.
14774         * common/environ.h: Rename include guard.
14775         * common/common-utils.h: Rename include guard.
14776         * common/common-types.h: Rename include guard.
14777         * common/common-regcache.h: Rename include guard.
14778         * common/common-inferior.h: Rename include guard.
14779         * common/common-gdbthread.h: Rename include guard.
14780         * common/common-exceptions.h: Rename include guard.
14781         * common/common-defs.h: Rename include guard.
14782         * common/common-debug.h: Rename include guard.
14783         * common/cleanups.h: Rename include guard.
14784         * common/buffer.h: Rename include guard.
14785         * common/btrace-common.h: Rename include guard.
14786         * common/break-common.h: Rename include guard.
14787         * cli/cli-utils.h: Rename include guard.
14788         * cli/cli-style.h: Rename include guard.
14789         * cli/cli-setshow.h: Rename include guard.
14790         * cli/cli-script.h: Rename include guard.
14791         * cli/cli-interp.h: Rename include guard.
14792         * cli/cli-decode.h: Rename include guard.
14793         * cli/cli-cmds.h: Rename include guard.
14794         * charset-list.h: Add include guard.
14795         * buildsym-legacy.h: Rename include guard.
14796         * bfin-tdep.h: Add include guard.
14797         * ax.h: Rename include guard.
14798         * arm-linux-tdep.h: Add include guard.
14799         * arm-fbsd-tdep.h: Add include guard.
14800         * arch/xtensa.h: Rename include guard.
14801         * arch/tic6x.h: Add include guard.
14802         * arch/i386.h: Add include guard.
14803         * arch/arm.h: Rename include guard.
14804         * arch/arm-linux.h: Rename include guard.
14805         * arch/arm-get-next-pcs.h: Rename include guard.
14806         * arch/amd64.h: Add include guard.
14807         * arch/aarch64-insn.h: Rename include guard.
14808         * arch-utils.h: Rename include guard.
14809         * annotate.h: Add include guard.
14810         * amd64-darwin-tdep.h: Rename include guard.
14811         * aarch64-linux-tdep.h: Add include guard.
14812         * aarch64-fbsd-tdep.h: Add include guard.
14813         * aarch32-linux-nat.h: Add include guard.
14814
14815 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14816
14817         * macrotab.c (macro_define_internal): New function that
14818         factorizes macro_define_object_internal and macro_define_function
14819         code.
14820         (macro_define_object_internal): Use macro_define_internal.
14821         (macro_define_function): Likewise.
14822
14823 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14824
14825         * macrocmd.c (extract_identifier): Return
14826         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14827         callers.
14828
14829 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
14830
14831         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14832
14833 2019-02-05  Tom Tromey  <tom@tromey.com>
14834
14835         * target.c (target_stack::unpush): Move assertion earlier.
14836
14837 2019-01-30  Tom Tromey  <tom@tromey.com>
14838
14839         PR python/23615:
14840         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14841         (gdbpy_parse_and_eval): Likewise.
14842         * python/python-internal.h (gdbpy_allow_threads): New class.
14843
14844 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
14845
14846         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14847         (aarch64_fbsd_fpregmap): Move earlier.
14848         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14849         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14850         instead of individual calls to trad_frame_set_reg_addr.
14851         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14852         earlier.
14853         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14854         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14855         instead of individual calls to trad_frame_set_reg_addr.
14856
14857 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
14858
14859         * CONTRIBUTE: Replace contribution list with wiki link.
14860
14861 2019-01-25  Tom Tromey  <tom@tromey.com>
14862
14863         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14864
14865 2019-01-25  Tom Tromey  <tom@tromey.com>
14866
14867         * xtensa-linux-nat.c: Fix common/ includes.
14868         * xml-support.h: Fix common/ includes.
14869         * xml-support.c: Fix common/ includes.
14870         * x86-linux-nat.c: Fix common/ includes.
14871         * windows-nat.c: Fix common/ includes.
14872         * varobj.h: Fix common/ includes.
14873         * varobj.c: Fix common/ includes.
14874         * value.c: Fix common/ includes.
14875         * valops.c: Fix common/ includes.
14876         * utils.c: Fix common/ includes.
14877         * unittests/xml-utils-selftests.c: Fix common/ includes.
14878         * unittests/utils-selftests.c: Fix common/ includes.
14879         * unittests/unpack-selftests.c: Fix common/ includes.
14880         * unittests/tracepoint-selftests.c: Fix common/ includes.
14881         * unittests/style-selftests.c: Fix common/ includes.
14882         * unittests/string_view-selftests.c: Fix common/ includes.
14883         * unittests/scoped_restore-selftests.c: Fix common/ includes.
14884         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14885         * unittests/scoped_fd-selftests.c: Fix common/ includes.
14886         * unittests/rsp-low-selftests.c: Fix common/ includes.
14887         * unittests/parse-connection-spec-selftests.c: Fix common/
14888         includes.
14889         * unittests/optional-selftests.c: Fix common/ includes.
14890         * unittests/offset-type-selftests.c: Fix common/ includes.
14891         * unittests/observable-selftests.c: Fix common/ includes.
14892         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14893         * unittests/memrange-selftests.c: Fix common/ includes.
14894         * unittests/memory-map-selftests.c: Fix common/ includes.
14895         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14896         * unittests/function-view-selftests.c: Fix common/ includes.
14897         * unittests/environ-selftests.c: Fix common/ includes.
14898         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14899         * unittests/common-utils-selftests.c: Fix common/ includes.
14900         * unittests/cli-utils-selftests.c: Fix common/ includes.
14901         * unittests/array-view-selftests.c: Fix common/ includes.
14902         * ui-file.c: Fix common/ includes.
14903         * tui/tui-io.c: Fix common/ includes.
14904         * tracepoint.h: Fix common/ includes.
14905         * tracepoint.c: Fix common/ includes.
14906         * tracefile-tfile.c: Fix common/ includes.
14907         * top.h: Fix common/ includes.
14908         * top.c: Fix common/ includes.
14909         * thread.c: Fix common/ includes.
14910         * target/waitstatus.h: Fix common/ includes.
14911         * target/waitstatus.c: Fix common/ includes.
14912         * target.h: Fix common/ includes.
14913         * target.c: Fix common/ includes.
14914         * target-memory.c: Fix common/ includes.
14915         * target-descriptions.c: Fix common/ includes.
14916         * symtab.h: Fix common/ includes.
14917         * symfile.c: Fix common/ includes.
14918         * stap-probe.c: Fix common/ includes.
14919         * spu-linux-nat.c: Fix common/ includes.
14920         * sparc-nat.c: Fix common/ includes.
14921         * source.c: Fix common/ includes.
14922         * solib.c: Fix common/ includes.
14923         * solib-target.c: Fix common/ includes.
14924         * ser-unix.c: Fix common/ includes.
14925         * ser-tcp.c: Fix common/ includes.
14926         * ser-pipe.c: Fix common/ includes.
14927         * ser-base.c: Fix common/ includes.
14928         * selftest-arch.c: Fix common/ includes.
14929         * s12z-tdep.c: Fix common/ includes.
14930         * rust-exp.y: Fix common/ includes.
14931         * rs6000-aix-tdep.c: Fix common/ includes.
14932         * riscv-tdep.c: Fix common/ includes.
14933         * remote.c: Fix common/ includes.
14934         * remote-notif.h: Fix common/ includes.
14935         * remote-fileio.h: Fix common/ includes.
14936         * remote-fileio.c: Fix common/ includes.
14937         * regcache.h: Fix common/ includes.
14938         * regcache.c: Fix common/ includes.
14939         * record-btrace.c: Fix common/ includes.
14940         * python/python.c: Fix common/ includes.
14941         * python/py-type.c: Fix common/ includes.
14942         * python/py-inferior.c: Fix common/ includes.
14943         * progspace.h: Fix common/ includes.
14944         * producer.c: Fix common/ includes.
14945         * procfs.c: Fix common/ includes.
14946         * proc-api.c: Fix common/ includes.
14947         * printcmd.c: Fix common/ includes.
14948         * ppc-linux-nat.c: Fix common/ includes.
14949         * parser-defs.h: Fix common/ includes.
14950         * osdata.c: Fix common/ includes.
14951         * obsd-nat.c: Fix common/ includes.
14952         * nat/x86-linux.c: Fix common/ includes.
14953         * nat/x86-linux-dregs.c: Fix common/ includes.
14954         * nat/x86-dregs.h: Fix common/ includes.
14955         * nat/x86-dregs.c: Fix common/ includes.
14956         * nat/ppc-linux.c: Fix common/ includes.
14957         * nat/mips-linux-watch.h: Fix common/ includes.
14958         * nat/mips-linux-watch.c: Fix common/ includes.
14959         * nat/linux-waitpid.c: Fix common/ includes.
14960         * nat/linux-ptrace.h: Fix common/ includes.
14961         * nat/linux-ptrace.c: Fix common/ includes.
14962         * nat/linux-procfs.c: Fix common/ includes.
14963         * nat/linux-personality.c: Fix common/ includes.
14964         * nat/linux-osdata.c: Fix common/ includes.
14965         * nat/linux-namespaces.c: Fix common/ includes.
14966         * nat/linux-btrace.h: Fix common/ includes.
14967         * nat/linux-btrace.c: Fix common/ includes.
14968         * nat/fork-inferior.c: Fix common/ includes.
14969         * nat/amd64-linux-siginfo.c: Fix common/ includes.
14970         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
14971         * nat/aarch64-linux.c: Fix common/ includes.
14972         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
14973         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
14974         * namespace.h: Fix common/ includes.
14975         * mips-linux-tdep.c: Fix common/ includes.
14976         * minsyms.c: Fix common/ includes.
14977         * mi/mi-parse.h: Fix common/ includes.
14978         * mi/mi-main.c: Fix common/ includes.
14979         * mi/mi-cmd-env.c: Fix common/ includes.
14980         * memrange.h: Fix common/ includes.
14981         * memattr.c: Fix common/ includes.
14982         * maint.h: Fix common/ includes.
14983         * maint.c: Fix common/ includes.
14984         * main.c: Fix common/ includes.
14985         * machoread.c: Fix common/ includes.
14986         * location.c: Fix common/ includes.
14987         * linux-thread-db.c: Fix common/ includes.
14988         * linux-nat.c: Fix common/ includes.
14989         * linux-fork.c: Fix common/ includes.
14990         * inline-frame.c: Fix common/ includes.
14991         * infrun.c: Fix common/ includes.
14992         * inflow.c: Fix common/ includes.
14993         * inferior.h: Fix common/ includes.
14994         * inferior.c: Fix common/ includes.
14995         * infcmd.c: Fix common/ includes.
14996         * inf-ptrace.c: Fix common/ includes.
14997         * inf-child.c: Fix common/ includes.
14998         * ia64-linux-nat.c: Fix common/ includes.
14999         * i387-tdep.c: Fix common/ includes.
15000         * i386-tdep.c: Fix common/ includes.
15001         * i386-linux-tdep.c: Fix common/ includes.
15002         * i386-linux-nat.c: Fix common/ includes.
15003         * i386-go32-tdep.c: Fix common/ includes.
15004         * i386-fbsd-tdep.c: Fix common/ includes.
15005         * i386-fbsd-nat.c: Fix common/ includes.
15006         * guile/scm-type.c: Fix common/ includes.
15007         * guile/guile.c: Fix common/ includes.
15008         * go32-nat.c: Fix common/ includes.
15009         * gnu-nat.c: Fix common/ includes.
15010         * gdbthread.h: Fix common/ includes.
15011         * gdbarch-selftests.c: Fix common/ includes.
15012         * gdb_usleep.c: Fix common/ includes.
15013         * gdb_select.h: Fix common/ includes.
15014         * gdb_bfd.c: Fix common/ includes.
15015         * gcore.c: Fix common/ includes.
15016         * fork-child.c: Fix common/ includes.
15017         * findvar.c: Fix common/ includes.
15018         * fbsd-nat.c: Fix common/ includes.
15019         * event-top.c: Fix common/ includes.
15020         * event-loop.c: Fix common/ includes.
15021         * dwarf2read.c: Fix common/ includes.
15022         * dwarf2loc.c: Fix common/ includes.
15023         * dwarf2-frame.c: Fix common/ includes.
15024         * dwarf-index-cache.c: Fix common/ includes.
15025         * dtrace-probe.c: Fix common/ includes.
15026         * disasm-selftests.c: Fix common/ includes.
15027         * defs.h: Fix common/ includes.
15028         * csky-tdep.c: Fix common/ includes.
15029         * cp-valprint.c: Fix common/ includes.
15030         * cp-support.h: Fix common/ includes.
15031         * cp-support.c: Fix common/ includes.
15032         * corelow.c: Fix common/ includes.
15033         * completer.h: Fix common/ includes.
15034         * completer.c: Fix common/ includes.
15035         * compile/compile.c: Fix common/ includes.
15036         * compile/compile-loc2c.c: Fix common/ includes.
15037         * compile/compile-cplus-types.c: Fix common/ includes.
15038         * compile/compile-cplus-symbols.c: Fix common/ includes.
15039         * command.h: Fix common/ includes.
15040         * cli/cli-dump.c: Fix common/ includes.
15041         * cli/cli-cmds.c: Fix common/ includes.
15042         * charset.c: Fix common/ includes.
15043         * build-id.c: Fix common/ includes.
15044         * btrace.h: Fix common/ includes.
15045         * btrace.c: Fix common/ includes.
15046         * breakpoint.h: Fix common/ includes.
15047         * breakpoint.c: Fix common/ includes.
15048         * ax.h:
15049         (enum agent_op): Fix common/ includes.
15050         * ax-general.c (struct aop_map): Fix common/ includes.
15051         * ax-gdb.c: Fix common/ includes.
15052         * auxv.c: Fix common/ includes.
15053         * auto-load.c: Fix common/ includes.
15054         * arm-tdep.c: Fix common/ includes.
15055         * arch/riscv.c: Fix common/ includes.
15056         * arch/ppc-linux-common.c: Fix common/ includes.
15057         * arch/i386.c: Fix common/ includes.
15058         * arch/arm.c: Fix common/ includes.
15059         * arch/arm-linux.c: Fix common/ includes.
15060         * arch/arm-get-next-pcs.c: Fix common/ includes.
15061         * arch/amd64.c: Fix common/ includes.
15062         * arch/aarch64.c: Fix common/ includes.
15063         * arch/aarch64-insn.c: Fix common/ includes.
15064         * arch-utils.c: Fix common/ includes.
15065         * amd64-windows-tdep.c: Fix common/ includes.
15066         * amd64-tdep.c: Fix common/ includes.
15067         * amd64-sol2-tdep.c: Fix common/ includes.
15068         * amd64-obsd-tdep.c: Fix common/ includes.
15069         * amd64-nbsd-tdep.c: Fix common/ includes.
15070         * amd64-linux-tdep.c: Fix common/ includes.
15071         * amd64-linux-nat.c: Fix common/ includes.
15072         * amd64-fbsd-tdep.c: Fix common/ includes.
15073         * amd64-fbsd-nat.c: Fix common/ includes.
15074         * amd64-dicos-tdep.c: Fix common/ includes.
15075         * amd64-darwin-tdep.c: Fix common/ includes.
15076         * agent.c: Fix common/ includes.
15077         * ada-lang.h: Fix common/ includes.
15078         * ada-lang.c: Fix common/ includes.
15079         * aarch64-tdep.c: Fix common/ includes.
15080
15081 2019-01-25  Tom Tromey  <tom@tromey.com>
15082
15083         * common/create-version.sh: Use common/version.h.
15084
15085 2019-01-24  Pedro Alves  <palves@redhat.com>
15086
15087         * infrun.c (signal_stop, signal_print, signal_program)
15088         (signal_catch, signal_pass): Now arrays instead of pointers.
15089         (update_signals_program_target, do_target_resume)
15090         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15091         * linux-nat.c (linux_nat_target::pass_signals)
15092         (linux_nat_target::create_inferior, linux_nat_target::attach):
15093         Adjust.
15094         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15095         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15096         * procfs.c (procfs_target::pass_signals): Adjust.
15097         * record-full.c (record_full_target::resume): Adjust.
15098         * remote.c (remote_target::pass_signals)
15099         (remote_target::program_signals): Adjust.
15100         * target-debug.h (target_debug_print_signals): Now takes a
15101         gdb::array_view as parameter.  Adjust.
15102         * target.h (target_ops) <pass_signals, program_signals>: Replace
15103         pointer and length parameters with gdb::array_view.
15104         (target_pass_signals, target_program_signals): Likewise.
15105         * target-delegates.c: Regenerate.
15106
15107 2019-01-24  Pedro Alves  <palves@redhat.com>
15108
15109         * common/forward-scope-exit.h
15110         (forward_scope_exit::forward_scope_exit): Pass arguments to
15111         m_bind_function directly, instead of creating a std::bind and
15112         copying that.
15113
15114 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
15115
15116         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15117         for static members.
15118         (pass_in_v_vfp_candidate): Likewise.
15119
15120 2019-01-23  Tom Tromey  <tom@tromey.com>
15121             Pedro Alves  <palves@redhat.com>
15122
15123         * regcache.c (class regcache_invalidator): Remove.
15124         (regcache::raw_write): Use make_scope_exit.
15125
15126 2019-01-23  Tom Tromey  <tom@tromey.com>
15127
15128         * ui-out.h (class ui_out_emit_type): Update comment.
15129
15130 2019-01-23  Tom Tromey  <tom@tromey.com>
15131
15132         * infrun.c (fetch_inferior_event): Update comment.
15133
15134 2019-01-23  Tom Tromey  <tom@tromey.com>
15135             Pedro Alves  <palves@redhat.com>
15136
15137         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15138         parameter.
15139         (fetch_inferior_event): Use SCOPE_EXIT.
15140
15141
15142 2019-01-23  Tom Tromey  <tom@tromey.com>
15143             Pedro Alves  <palves@redhat.com>
15144
15145         * infrun.c (disable_thread_events): Delete.
15146         (stop_all_threads): Use SCOPE_EXIT.
15147
15148 2019-01-23  Tom Tromey  <tom@tromey.com>
15149             Pedro Alves  <palves@redhat.com>
15150
15151         * symfile.c: Include forward-scope-exit.h.
15152         (clear_symtab_users_cleanup): Replace forward declaration with
15153         a FORWARD_SCOPE_EXIT.
15154         (syms_from_objfile_1): Use the forward_scope_exit and
15155         gdb::optional instead of cleanup_function.
15156         (reread_symbols): Use the forward_scope_exit instead of
15157         cleanup_function.
15158         (clear_symtab_users_cleanup): Remove function.
15159
15160 2019-01-23  Tom Tromey  <tom@tromey.com>
15161             Pedro Alves  <palves@redhat.com>
15162
15163         * linux-nat.c: Include scope-exit.h.
15164         (cleanup_target_stop): Remove.
15165         (linux_nat_target::static_tracepoint_markers_by_strid): Use
15166         SCOPE_EXIT.
15167
15168 2019-01-23  Tom Tromey  <tom@tromey.com>
15169             Pedro Alves  <palves@redhat.com>
15170
15171         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15172         (call_function_by_hand_dummy): Use SCOPE_EXIT.
15173
15174 2019-01-23  Tom Tromey  <tom@tromey.com>
15175             Andrew Burgess  <andrew.burgess@embecosm.com>
15176             Pedro Alves  <palves@redhat.com>
15177
15178         * infrun.c (fetch_inferior_event): Use scope_exit.
15179         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15180         * top.c (execute_command): Use scope_exit.
15181         * breakpoint.c (bpstat_do_actions): Use scope_exit.
15182         * utils.c (do_bpstat_clear_actions_cleanup)
15183         (make_bpstat_clear_actions_cleanup): Remove.
15184
15185 2019-01-23  Tom Tromey  <tom@tromey.com>
15186             Pedro Alves  <palves@redhat.com>
15187
15188         * infrun.c: Include "common/scope-exit.h"
15189         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15190         (wait_for_inferior): Use SCOPE_EXIT.
15191         (fetch_inferior_event): Use scope_exit.
15192
15193 2019-01-23  Tom Tromey  <tom@tromey.com>
15194             Pedro Alves  <palves@redhat.com>
15195
15196         * breakpoint.c (create_breakpoint): Remove cleanup.
15197
15198 2019-01-23  Tom Tromey  <tom@tromey.com>
15199             Andrew Burgess  <andrew.burgess@embecosm.com>
15200             Pedro Alves  <palves@redhat.com>
15201
15202 2019-01-23  Pedro Alves  <palves@redhat.com>
15203
15204         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15205
15206 2019-01-23  Pedro Alves  <palves@redhat.com>
15207             Andrew Burgess  <andrew.burgess@embecosm.com>
15208
15209         * gdbthread.h: Include "common/forward-scope-exit.h".
15210         (scoped_finish_thread_state): Redefine custom class in terms of
15211         forward_scope_exit.
15212
15213 2019-01-23  Pedro Alves  <palves@redhat.com>
15214             Andrew Burgess  <andrew.burgess@embecosm.com>
15215
15216         * common/forward-scope-exit.h: New file.
15217
15218 2019-01-23  Pedro Alves  <palves@redhat.com>
15219             Andrew Burgess  <andrew.burgess@embecosm.com>
15220             Tom Tromey  <tom@tromey.com>
15221
15222         * common/scope-exit.h: New file.
15223
15224 2019-01-23  Pedro Alves  <palves@redhat.com>
15225
15226         * common/preprocessor.h (ESC): Rename to ...
15227         (ESC_PARENS): ... this.
15228         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15229         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15230
15231 2019-01-23  Tom Tromey  <tom@tromey.com>
15232
15233         * language.h (class scoped_switch_to_sym_language_if_auto):
15234         Initialize m_lang in both cases.
15235
15236 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
15237
15238         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15239         with XCNEW.
15240
15241 2019-01-22  Tom Tromey  <tom@tromey.com>
15242
15243         * corelow.c: Do not include sys/file.h.
15244
15245 2019-01-22  Tom Tromey  <tom@tromey.com>
15246
15247         * tui/tui-wingeneral.h: Include gdb_curses.h.
15248
15249 2019-01-22  Tom Tromey  <tom@tromey.com>
15250
15251         * source-cache.h (class source_cache) <get_source_lines,
15252         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15253
15254 2019-01-22  Tom Tromey  <tom@tromey.com>
15255
15256         * remote-fileio.h (struct remote_target): Declare.
15257
15258 2019-01-22  Tom Tromey  <tom@tromey.com>
15259
15260         * python/py-arch.c: Do not include py-ref.h.
15261         * python/py-bpevent.c: Do not include py-ref.h.
15262         * python/py-cmd.c: Do not include py-ref.h.
15263         * python/py-continueevent.c: Do not include py-ref.h.
15264         * python/py-event.h: Do not include py-ref.h.
15265         * python/py-evtregistry.c: Do not include py-ref.h.
15266         * python/py-finishbreakpoint.c: Do not include py-ref.h.
15267         * python/py-frame.c: Do not include py-ref.h.
15268         * python/py-framefilter.c: Do not include py-ref.h.
15269         * python/py-function.c: Do not include py-ref.h.
15270         * python/py-infevents.c: Do not include py-ref.h.
15271         * python/py-linetable.c: Do not include py-ref.h.
15272         * python/py-objfile.c: Do not include py-ref.h.
15273         * python/py-param.c: Do not include py-ref.h.
15274         * python/py-prettyprint.c: Do not include py-ref.h.
15275         * python/py-progspace.c: Do not include py-ref.h.
15276         * python/py-symbol.c: Do not include py-ref.h.
15277         * python/py-symtab.c: Do not include py-ref.h.
15278         * python/py-type.c: Do not include py-ref.h.
15279         * python/py-unwind.c: Do not include py-ref.h.
15280         * python/py-utils.c: Do not include py-ref.h.
15281         * python/py-value.c: Do not include py-ref.h.
15282         * python/py-varobj.c: Do not include py-ref.h.
15283         * python/py-xmethods.c: Do not include py-ref.h.
15284         * python/python.c: Do not include py-ref.h.
15285         * varobj.c: Do not include py-ref.h.
15286
15287 2019-01-22  Tom Tromey  <tom@tromey.com>
15288
15289         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15290         keyword for bcache.
15291
15292 2019-01-22  Tom Tromey  <tom@tromey.com>
15293
15294         * compile/compile-cplus-types.c: Remove a comment by #include.
15295
15296 2019-01-22  Tom Tromey  <tom@tromey.com>
15297
15298         * compile/gcc-c-plugin.h: Include compile-internal.h.
15299
15300 2019-01-22  Tom Tromey  <tom@tromey.com>
15301
15302         * stabsread.c (EXTERN): Do not define.
15303         (symnum, next_symbol_text_func, processing_gcc_compilation)
15304         (within_function, global_sym_chain, global_stabs)
15305         (previous_stab_code, this_object_header_files)
15306         (n_this_object_header_files)
15307         (n_allocated_this_object_header_files): Define.
15308         * stabsread.h (EXTERN): Never define.  Use "extern".
15309
15310 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15311
15312         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15313         history_value.
15314
15315 2019-01-21  Tom Tromey  <tom@tromey.com>
15316
15317         * ui-out.c: Fix includes.
15318         * tui/tui-source.c: Fix includes.
15319         * target.c: Fix includes.
15320         * remote.c: Fix includes.
15321         * regcache.c: Fix includes.
15322         * python/py-block.c: Fix includes.
15323         * printcmd.c: Fix includes.
15324         * or1k-tdep.c: Fix includes.
15325         * mi/mi-main.c: Fix includes.
15326         * m32r-tdep.c: Fix includes.
15327         * csky-tdep.c: Fix includes.
15328         * compile/compile-cplus-types.c: Fix includes.
15329         * cli/cli-interp.c: Fix includes.
15330
15331 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
15332
15333         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15334         for padding.
15335
15336 2019-01-16  Tom Tromey  <tom@tromey.com>
15337
15338         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
15339         earlier.
15340         (struct objfile) <msymbols_range>: Move from top level.
15341         <msymbols>: New method.
15342         (class objfile_msymbols): Remove.
15343         * symtab.c (default_collect_symbol_completion_matches_break_on):
15344         Update.
15345         * symmisc.c (dump_msymbols): Update.
15346         * stabsread.c (scan_file_globals): Update.
15347         * objc-lang.c (info_selectors_command, info_classes_command)
15348         (find_methods): Update.
15349         * minsyms.c (find_solib_trampoline_target): Update.
15350         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15351         * coffread.c (coff_symfile_read): Update.
15352         * ada-lang.c (ada_lookup_simple_minsym)
15353         (ada_collect_symbol_completion_matches): Update.
15354
15355 2019-01-16  Tom Tromey  <tom@tromey.com>
15356
15357         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15358         type.  Remove no-argument constructor.
15359         <iterator::operator++>: Simplify.
15360         <begin>: Update.
15361         <end>: Use minimal_symbol_count.
15362
15363 2019-01-16  Tom Tromey  <tom@tromey.com>
15364
15365         * objfiles.h (struct objfile) <psymtabs>: New method.
15366         (class objfile_psymtabs): Remove.
15367         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15368         typedef.
15369         <range>: New method.
15370         (require_partial_symbols): Change return type.
15371         * psymtab.c (require_partial_symbols)
15372         (psym_expand_symtabs_matching): Update.
15373         * mdebugread.c (parse_partial_symbols): Update.
15374         * dbxread.c (dbx_end_psymtab): Update.
15375
15376 2019-01-15  Tom Tromey  <tom@tromey.com>
15377
15378         * symtab.c (lookup_objfile_from_block)
15379         (lookup_symbol_in_objfile_symtabs)
15380         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15381         (find_line_symtab, info_sources_command)
15382         (default_collect_symbol_completion_matches_break_on)
15383         (make_source_files_completion_list): Update.
15384         * symmisc.c (print_objfile_statistics, dump_objfile)
15385         (maintenance_print_symbols, maintenance_info_symtabs)
15386         (maintenance_check_symtabs, maintenance_info_line_tables):
15387         Update.
15388         * source.c (select_source_symtab)
15389         (forget_cached_source_info_for_objfile): Update.
15390         * objfiles.h (class objfile_compunits): Remove.
15391         (struct objfile) <compunits_range>: New typedef.
15392         (compunits): New method.
15393         * objfiles.c (objfile_relocate1): Update.
15394         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15395         * maint.c (count_symtabs_and_blocks): Update.
15396         * linespec.c (iterate_over_all_matching_symtabs): Update.
15397         * cp-support.c (add_symbol_overload_list_qualified): Update.
15398         * coffread.c (coff_symtab_read): Update.
15399         * ada-lang.c (add_nonlocal_symbols)
15400         (ada_collect_symbol_completion_matches)
15401         (ada_add_global_exceptions): Update.
15402
15403 2019-01-15  Tom Tromey  <tom@tromey.com>
15404
15405         * progspace.h (program_space) <objfiles_safe_range>: New
15406         typedef.
15407         <objfiles_safe>: New method.
15408         * objfiles.h (class all_objfiles_safe): Remove.
15409         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15410         * jit.c (jit_inferior_exit_hook): Update.
15411
15412 2019-01-17  Tom Tromey  <tom@tromey.com>
15413
15414         * progspace.h (program_space) <objfiles_range>: New typedef.
15415         <objfiles>: New method.
15416         <objfiles_head>: Rename from objfiles.
15417         (object_files): Update.
15418         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15419         * guile/scm-pretty-print.c
15420         (ppscm_find_pretty_printer_from_objfiles): Update.
15421         * guile/scm-objfile.c (gdbscm_objfiles): Update.
15422         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15423         Update.
15424         * python/py-progspace.c (pspy_get_objfiles): Update.
15425         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15426         Update.
15427         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15428         (objfpy_lookup_objfile_by_build_id): Update.
15429         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15430         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15431         Update.
15432         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15433         (expand_symtab_containing_pc, lookup_objfile_from_block)
15434         (lookup_static_symbol, basic_lookup_transparent_type)
15435         (find_pc_sect_compunit_symtab, find_symbol_at_address)
15436         (find_line_symtab, info_sources_command)
15437         (default_collect_symbol_completion_matches_break_on)
15438         (make_source_files_completion_list, find_main_name): Update.
15439         * symmisc.c (print_symbol_bcache_statistics)
15440         (print_objfile_statistics, maintenance_print_symbols)
15441         (maintenance_print_msymbols, maintenance_print_objfiles)
15442         (maintenance_info_symtabs, maintenance_check_symtabs)
15443         (maintenance_expand_symtabs, maintenance_info_line_tables):
15444         Update.
15445         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15446         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15447         (map_overlay_command, unmap_overlay_command)
15448         (simple_overlay_update, expand_symtabs_matching)
15449         (map_symbol_filenames): Update.
15450         * symfile-debug.c (set_debug_symfile): Update.
15451         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15452         Update.
15453         * source.c (select_source_symtab, forget_cached_source_info):
15454         Update.
15455         * solib.c (solib_read_symbols): Update.
15456         * solib-spu.c (append_ocl_sos): Update.
15457         * psymtab.c (maintenance_print_psymbols)
15458         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15459         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15460         * printcmd.c (info_symbol_command): Update.
15461         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15462         Update.
15463         * objfiles.h (class all_objfiles): Remove.
15464         * objfiles.c (have_partial_symbols, have_full_symbols)
15465         (have_minimal_symbols, qsort_cmp, update_section_map)
15466         (shared_objfile_contains_address_p)
15467         (default_iterate_over_objfiles_in_search_order): Update.
15468         * objc-lang.c (info_selectors_command, info_classes_command)
15469         (find_methods): Update.
15470         * minsyms.c (find_solib_trampoline_target): Update.
15471         * maint.c (maintenance_info_sections)
15472         (maintenance_translate_address, count_symtabs_and_blocks):
15473         Update.
15474         * main.c (captured_main_1): Update.
15475         * linux-thread-db.c (try_thread_db_load_from_pdir)
15476         (has_libpthread): Update.
15477         * linespec.c (iterate_over_all_matching_symtabs)
15478         (search_minsyms_for_name): Update.
15479         * jit.c (jit_find_objf_with_entry_addr): Update.
15480         * hppa-tdep.c (find_unwind_entry)
15481         (hppa_lookup_stub_minimal_symbol): Update.
15482         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15483         Update.
15484         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15485         (elf_gnu_ifunc_resolve_by_got): Update.
15486         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15487         * dwarf-index-write.c (save_gdb_index_command): Update.
15488         * cp-support.c (add_symbol_overload_list_qualified): Update.
15489         * breakpoint.c (create_overlay_event_breakpoint)
15490         (create_longjmp_master_breakpoint)
15491         (create_std_terminate_master_breakpoint)
15492         (create_exception_master_breakpoint): Update.
15493         * blockframe.c (find_pc_partial_function): Update.
15494         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15495         (ada_collect_symbol_completion_matches)
15496         (ada_add_global_exceptions): Update.
15497
15498 2019-01-17  Tom Tromey  <tom@tromey.com>
15499
15500         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
15501         declare VEC.
15502         (solib_target_parse_libraries): Change return type.
15503         (library_list_start_segment, library_list_start_section)
15504         (library_list_end_library, library_list_start_library); Update.
15505         (solib_target_free_library_list): Remove.
15506         (solib_target_parse_libraries): Remove cleanup.  Change return
15507         type.
15508         (solib_target_current_sos): Update.
15509
15510 2019-01-17  Tom Tromey  <tromey@bapiya>
15511
15512         * valprint.c: Replace "the the" with "the".
15513         * symtab.c: Replace "the the" with "the".
15514         * solib.c: Replace "the the" with "the".
15515         * solib-dsbt.c: Replace "the the" with "the".
15516         * linespec.c: Replace "the the" with "the".
15517         * dwarf2loc.h: Replace "the the" with "the".
15518         * amd64-windows-tdep.c: Replace "the the" with "the".
15519         * aarch64-tdep.c: Replace "the the" with "the".
15520
15521 2019-01-16  Keith Seitz  <keiths@redhat.com>
15522
15523         PR gdb/23773
15524         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15525         <builder>: Rename to ..
15526         <m_builder>: ... this and make private.
15527         (dwarf2_cu::get_builder): New method.  Change all users of
15528         `builder' to use this method.
15529         (dwarf2_start_symtab): Move to ...
15530         (dwarf2_cu::start_symtab): ... here.  Update all callers
15531         (setup_type_unit_groups): Move to ...
15532         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
15533         callers.
15534         (dwarf2_cu::reset_builder): New method.
15535         (process_full_compunit, process_full_type_unit): Use
15536         dwarf2_cu::reset_builder.
15537         (follow_die_offset): Record the ancestor CU if it is different
15538         from the followed DIE's CU.
15539         (follow_die_sig_1): Likewise.
15540
15541 2019-01-15  Tom Tromey  <tom@tromey.com>
15542
15543         * remote.c (class remote_state) <buf>: Now a char_vector.
15544         <buf_size>: Remove.
15545         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
15546         parameter.
15547         (remote_target::getpkt_or_notif_sane_1)
15548         (remote_target::getpkt_sane)
15549         (remote_target::getpkt_or_notif_sane): Likewise.
15550         (class remote_target) <putpkt>: New overload.
15551         (remote_target::read_frame): Change type of "buf_p".  Remove
15552         sizeof_p parameter.
15553         (packet_ok): New overload.
15554         (packet_check_result): New overload.
15555         Update all uses.
15556
15557 2019-01-14  Tom Tromey  <tom@tromey.com>
15558
15559         * remote-notif.c (handle_notification, remote_notif_ack)
15560         (remote_notif_parse): Make "buf" const.
15561         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15562         const.
15563         (remote_notif_parse, remote_notif_ack, handle_notification):
15564         Likewise.
15565         * remote.c (remote_notif_stop_parse): Make "buf" const.
15566         (remote_target::remote_parse_stop_reply): Make "buf" const.
15567         (remote_notif_stop_ack): Make "buf" const.
15568
15569 2019-01-14  Tom Tromey  <tom@tromey.com>
15570
15571         * remote.c (remote_console_output): Make parameter const.
15572
15573 2019-01-14  Tom Tromey  <tom@tromey.com>
15574
15575         * target-debug.h (target_debug_print_signals): Constify.
15576         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15577         * procfs.c (procfs_target::pass_signals): Update.
15578         * linux-nat.c (linux_nat_target::pass_signals): Update.
15579         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15580         * target-delegates.c: Rebuild.
15581         * remote.c (remote_target::program_signals): Update.
15582         (remote_target::pass_signals): Update.
15583         * target.c (target_pass_signals): Constify argument.
15584         (target_program_signals): Likewise.
15585         * target.h (struct target_ops) <pass_signals, program_signals>:
15586         Constify argument.
15587         (target_pass_signals, target_program_signals): Constify argument.
15588
15589 2019-01-14  Tom Tromey  <tom@tromey.com>
15590
15591         PR tui/28819:
15592         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15593
15594 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
15595
15596         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15597         field.
15598         * rs6000-tdep.c: Include reggroups.h.
15599         (IS_V_ALIAS_PSEUDOREG): Define.
15600         (rs6000_register_name): Return names for the "vX" aliases.
15601         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15602         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
15603         aliases.  Call default_register_reggroup_p for all other
15604         pseudo-registers.
15605         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15606         New functions.
15607         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15608         Handle "vX" aliases.
15609         (v_alias_pseudo_register_collect): New function.
15610         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15611         (rs6000_gdbarch_init): Initialize "vX" aliases as
15612         pseudo-registers.  Restore registration of
15613         rs6000_pseudo_register_reggroup_p with
15614         set_tdesc_pseudo_register_reggroup_p.
15615
15616 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
15617
15618         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15619         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15620         set_gdbarch_num_pseudo_regs.
15621
15622 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15623
15624         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15625         Remove arg prefixname, add do_set and do_show.
15626         Add member functions set_list and show_list.
15627         * cli/cli-style.c (class cli_style_option): Update accordingly.
15628         (style_set_list): Move to file scope.
15629         (style_show_list): Likewise.
15630         (set_style): Call help_list.
15631         (show_style): Call cmd_show_list.
15632         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15633         Update to use the new macro.
15634
15635 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
15636
15637         * ada-lang.c (_initialize_ada_language): Expand the help text
15638         for the "catch exception" command.
15639
15640 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15641
15642         * symtab.c (matching_obj_sections): Initialize obj,
15643         declare it closer to its usage.
15644
15645 2019-01-10  Tom Tromey  <tom@tromey.com>
15646
15647         * thread-iter.h (inf_threads_iterator): Use next_iterator.
15648         (basic_inf_threads_range): Remove.
15649         (inf_threads_range, inf_non_exited_threads_range)
15650         (safe_inf_threads_range): Use next_adapter.
15651
15652 2019-01-10  Keith Seitz  <keiths@redhat.com>
15653
15654         PR gdb/23712
15655         PR symtab/23010
15656         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15657         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15658
15659 2019-01-10  Keith Seitz  <keiths@redhat.com>
15660
15661         PR gdb/23712
15662         PR symtab/23010
15663         * dictionary.c (pending_to_vector): Remove.
15664         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15665         Remove _1 suffix, replacing functions of the same name.  Update
15666         all callers.
15667         (dict_create_hashed, dict_create_hashed_expandable)
15668         (dict_create_linear, dict_create_linear_expandable, dict_free)
15669         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15670         Make functions static.
15671
15672 2019-01-10  Keith Seitz  <keiths@redhat.com>
15673
15674         PR gdb/23712
15675         PR symtab/23010
15676         * dictionary.h (struct dictionary): Replace declaration with
15677         multidictionary.
15678         (dict_create_hashed, dict_create_hashed_expandable)
15679         (dict_create_linear, dict_create_linear_expandable)
15680         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15681         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15682         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15683         taking multidictionary argument.
15684         [ALL_DICT_SYMBOLS]: Update for multidictionary.
15685         * block.h (struct block) <dict>: Change to multidictionary
15686         and rename `multidict'.
15687         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15688         symmisc.c: Update all dictionary references to multidictionary.
15689
15690 2019-01-10  Keith Seitz  <keiths@redhat.com>
15691
15692         PR gdb/23712
15693         PR symtab/23010
15694         * dictionary.c: Include unordered_map.
15695         (pending_to_vector): New function.
15696         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15697         Rewrite the non-"_1" functions to take vector instead
15698         of linked list.
15699         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15700         "new" _1 versions of the same name.
15701         (multidictionary): Define.
15702         (std::hash<enum language): New definition.
15703         (collate_pending_symbols_by_language, mdict_create_hashed)
15704         (mdict_create_hashed_expandable, mdict_create_linear)
15705         (mdict_create_linear_expandable, mdict_free)
15706         (find_language_dictionary, create_new_language_dictionary)
15707         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15708         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15709         (mdict_size, mdict_empty): New functions.
15710         * dictionary.h (mdict_iterator): Define.
15711
15712 2019-01-10  Pedro Alves  <palves@redhat.com>
15713
15714         * breakpoint.c (read_uploaded_action)
15715         (create_tracepoint_from_upload): Adjust to use
15716         gdb::unique_xmalloc_ptr.
15717         * ctf.c (ctf_write_uploaded_tp):
15718         (SET_ARRAY_FIELD): Use emplace_back.
15719         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15720         * tracefile-tfile.c (tfile_write_uploaded_tp):
15721         * tracepoint.c (parse_tracepoint_definition): Adjust to use
15722         gdb::unique_xmalloc_ptr.
15723         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15724         at_string, cond_string, cmd_strings>: Replace char pointers
15725         with gdb::unique_xmalloc_ptr.
15726
15727 2019-01-10  Pedro Alves  <palves@redhat.com>
15728
15729         * solib-target.c (library_list_start_library): Don't xstrdup name.
15730
15731 2019-01-10  Pedro Alves  <palves@redhat.com>
15732
15733         * mdebugread.c (parse_partial_symbols): Use
15734         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15735
15736 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15737
15738         * linux-fork.c (scoped_switch_fork_info)
15739         <~scoped_switch_fork_info>: Fix incorrect variable name.
15740
15741 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15742
15743         * linux-fork.c (scoped_switch_fork_info)
15744         <scoped_switch_fork_info>: Make explicit.
15745         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15746
15747 2019-01-10  Tom Tromey  <tom@tromey.com>
15748
15749         * objfiles.h (objfile::reset_psymtabs): Update.
15750         * objfiles.c (objfile::objfile): Update.
15751         * psymtab.h (psymtab_storage::obstack): Update.
15752         (psymtab_storage::m_obstack): Use gdb::optional.
15753         (class psymtab_storage): Update comment.  Remove objfile
15754         parameter.
15755         * psymtab.c (psymtab_storage::psymtab_storage): Update.
15756
15757 2019-01-10  Tom Tromey  <tom@tromey.com>
15758
15759         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15760         <free_psymtabs>: Now private.
15761         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15762         (allocate_psymtab): Use new method.
15763
15764 2019-01-10  Tom Tromey  <tom@tromey.com>
15765
15766         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15767         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15768         * mdebugread.c (parse_partial_symbols): Use
15769         allocate_dependencies.
15770         * dwarf2read.c (dwarf2_create_include_psymtab): Use
15771         allocate_dependencies.
15772         (process_psymtab_comp_unit_reader)
15773         (build_type_psymtab_dependencies): Likewise.
15774         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15775
15776 2019-01-10  Tom Tromey  <tom@tromey.com>
15777
15778         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15779         PSYMBOL_SET_LANGUAGE.
15780         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15781
15782 2019-01-10  Tom Tromey  <tom@tromey.com>
15783
15784         * psymtab.h (psymtab_storage::obstack): New method.
15785         <m_obstack>: Rename from obstack; now private.
15786         * psymtab.c (psymtab_storage): Update.
15787         * dwarf2read.c (create_addrmap_from_index)
15788         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15789         Update.
15790
15791 2019-01-10  Tom Tromey  <tom@tromey.com>
15792
15793         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15794         * objfiles.h (objfile::reset_psymtabs): New method.
15795
15796 2019-01-10  Tom Tromey  <tom@tromey.com>
15797
15798         * symmisc.c (print_symbol_bcache_statistics): Update.
15799         (print_objfile_statistics): Update.
15800         * symfile.c (reread_symbols): Update.
15801         * psymtab.h (class psymtab_storage): New.
15802         * psymtab.c (psymtab_storage): New constructor.
15803         (~psymtab_storage): New destructor.
15804         (require_partial_symbols): Update.
15805         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15806         (find_pc_sect_psymtab, find_pc_sect_psymbol)
15807         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15808         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15809         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15810         (start_psymtab_common, end_psymtab_common)
15811         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15812         (allocate_psymtab): Update.
15813         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15814         Update.
15815         (dump_psymtab_addrmap, maintenance_print_psymbols)
15816         (maintenance_check_psymtabs): Update.
15817         (class objfile_psymtabs): Move to objfiles.h.
15818         * psympriv.h (discard_psymtab): Now inline.
15819         (psymtab_discarder::psymtab_discarder): Update.
15820         (psymtab_discarder::~psymtab_discarder): Update.
15821         (ALL_OBJFILE_PSYMTABS): Rewrite.
15822         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15823         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15824         Remove fields.
15825         <partial_symtabs>: New field.
15826         (class objfile_psymtabs): Move from psymtab.h.  Update.
15827         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15828         psymbol_cache.
15829         (objfile::~objfile): Don't destroy psymbol_cache.
15830         * mdebugread.c (parse_partial_symbols): Update.
15831         * dwarf2read.c (create_addrmap_from_index)
15832         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15833         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15834         (add_partial_subprogram, dwarf2_ranges_read): Update.
15835         * dwarf-index-write.c (write_address_map)
15836         (write_one_signatured_type, recursively_write_psymbols)
15837         (class debug_names, class debug_names, write_psymtabs_to_index):
15838         Update.
15839
15840 2019-01-10  Tom Tromey  <tom@tromey.com>
15841
15842         * symtab.h (SYMBOL_SET_NAMES): Update.
15843         (symbol_set_names): Update.
15844         (MSYMBOL_SET_NAMES): Update.
15845         * symtab.c (symbol_set_names): Change argument to be an
15846         objfile_per_bfd_storage.
15847         * psymtab.c (add_psymbol_to_bcache): Update.
15848         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15849
15850 2019-01-10  Tom Tromey  <tom@tromey.com>
15851
15852         * symtab.c (create_demangled_names_hash): Change argument to be an
15853         objfile_per_bfd_storage.
15854         (symbol_set_names): Update.
15855
15856 2019-01-10  Tom Tromey  <tom@tromey.com>
15857
15858         * xcoffread.c (xcoff_initial_scan): Unconditionally call
15859         init_psymbol_list.
15860         * psymtab.c (init_psymbol_list): Do nothing if already called.
15861         * psympriv.h (init_psymbol_list): Add comment.
15862         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15863         init_psymbol_list.
15864         * dbxread.c (dbx_symfile_read): Unconditionally call
15865         init_psymbol_list.
15866
15867 2019-01-10  Tom Tromey  <tom@tromey.com>
15868
15869         * xcoffread.c (scan_xcoff_symtab): Update.
15870         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15871         "where".
15872         * mdebugread.c (parse_partial_symbols)
15873         (handle_psymbol_enumerators): Update.
15874         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15875         * dbxread.c (read_dbx_symtab): Update.
15876         * psympriv.h (psymbol_placement): New enum.
15877         (add_psymbol_to_list): Update.
15878
15879 2019-01-10  Tom Tromey  <tom@tromey.com>
15880
15881         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15882         static_psymbols parameters.
15883         (scan_xcoff_symtab): Update.
15884         * psymtab.c (start_psymtab_common): Remove global_psymbols and
15885         static_psymbols parameters.
15886         * psympriv.h (start_psymtab_common): Update.
15887         * mdebugread.c (parse_partial_symbols): Update.
15888         * dwarf2read.c (create_partial_symtab): Update.
15889         * dbxread.c (read_dbx_symtab): Update.
15890         (start_psymtab): Remove global_psymbols and static_psymbols
15891         parameters.
15892
15893 2019-01-10  Tom Tromey  <tom@tromey.com>
15894
15895         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15896         * psymtab.c (allocate_psymtab): Add comment.
15897         * psympriv.h (allocate_psymtab): Add comment.
15898         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15899         initializations.
15900         * dbxread.c (dbx_end_psymtab): Remove some initializations.
15901
15902 2019-01-10  Tom Tromey  <tom@tromey.com>
15903
15904         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15905         Don't declare.
15906         * mipsread.c: Include mdebugread.h.
15907         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15908         Declare.
15909         * elfread.c: Include mdebugread.h.
15910
15911 2019-01-09  Tom Tromey  <tom@tromey.com>
15912
15913         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15914         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15915         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15916         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15917         (psym_lookup_symbol, psym_find_last_source_symtab)
15918         (psym_forget_cached_source_info, psym_print_stats)
15919         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15920         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15921         (psym_map_matching_symbols, psym_expand_symtabs_matching)
15922         (psym_find_compunit_symtab_by_address)
15923         (maintenance_print_psymbols, maintenance_info_psymtabs)
15924         (maintenance_check_psymtabs): Use ranged for.
15925         * psymtab.h (class objfile_psymtabs): New.
15926         (require_partial_symbols): Return objfile_psymtabs.
15927         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
15928
15929 2019-01-09  Tom Tromey  <tom@tromey.com>
15930
15931         * symfile.c (overlay_invalidate_all, find_pc_overlay)
15932         (find_pc_mapped_section, list_overlays_command)
15933         (map_overlay_command, unmap_overlay_command)
15934         (simple_overlay_update): Use all_objfiles.
15935         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
15936         * printcmd.c (info_symbol_command): Use all_objfiles.
15937         * objfiles.h (ALL_OBJSECTIONS): Remove.
15938         * maint.c (maintenance_translate_address): Use all_objfiles.
15939         * gcore.c (gcore_create_callback): Use all_objfiles.
15940         (objfile_find_memory_regions): Likewise.
15941
15942 2019-01-09  Tom Tromey  <tom@tromey.com>
15943
15944         * symtab.c (find_line_symtab, info_sources_command)
15945         (make_source_files_completion_list): Use objfile_compunits.
15946         * source.c (select_source_symtab): Use objfile_compunits.
15947         * objfiles.h (struct objfile): Update comment.
15948         (ALL_OBJFILES): Remove.
15949         (ALL_FILETABS): Remove.
15950         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
15951         objfile_compunits.
15952
15953 2019-01-09  Tom Tromey  <tom@tromey.com>
15954
15955         * symmisc.c (print_objfile_statistics, dump_objfile)
15956         (maintenance_print_symbols): Use compunit_filetabs.
15957         * source.c (forget_cached_source_info_for_objfile): Use
15958         compunit_filetabs.
15959         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
15960         (ALL_FILETABS): Use compunit_filetabs.
15961         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
15962         * coffread.c (coff_symtab_read): Use compunit_filetabs.
15963
15964 2019-01-09  Tom Tromey  <tom@tromey.com>
15965
15966         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
15967         (compunit_filetabs): New.
15968         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
15969         compunit_filetabs.
15970         (info_sources_command, make_source_files_completion_list): Remove
15971         declaration.
15972         * symmisc.c (print_objfile_statistics, dump_objfile)
15973         (maintenance_print_symbols): Remove declaration.
15974         (maintenance_info_symtabs): Use compunit_filetabs.
15975         (maintenance_info_line_tables): Likewise.
15976         * source.c (select_source_symtab): Change local variable name.
15977         (forget_cached_source_info_for_objfile): Remove declaration.
15978         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
15979         * objfiles.c (objfile_relocate1): Remove declaration.
15980         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15981         declaration.
15982         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
15983         * coffread.c (coff_symtab_read): Remove declaration.
15984         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
15985         compunit_filetabs.
15986
15987 2019-01-09  Tom Tromey  <tom@tromey.com>
15988
15989         * symtab.c (lookup_objfile_from_block)
15990         (find_pc_sect_compunit_symtab, search_symbols)
15991         (default_collect_symbol_completion_matches_break_on): Use
15992         objfile_compunits.
15993         * objfiles.h (ALL_COMPUNITS): Remove.
15994         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
15995         * cp-support.c (add_symbol_overload_list_qualified): Use
15996         objfile_compunits.
15997         * ada-lang.c (ada_collect_symbol_completion_matches)
15998         (ada_add_global_exceptions): Use objfile_compunits.
15999
16000 2019-01-09  Tom Tromey  <tom@tromey.com>
16001
16002         * source.c (select_source_symtab)
16003         (forget_cached_source_info_for_objfile): Remove declaration.
16004         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16005         declaration.
16006         * maint.c (count_symtabs_and_blocks): Remove declaration.
16007         * cp-support.c (add_symbol_overload_list_qualified): Remove
16008         declaration.
16009         * coffread.c (coff_symtab_read): Remove declaration.
16010         * symtab.c (lookup_symbol_in_objfile_symtabs)
16011         (basic_lookup_transparent_type_1): Use objfile_compunits.
16012         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16013         (info_sources_command, search_symbols)
16014         (default_collect_symbol_completion_matches_break_on)
16015         (make_source_files_completion_list): Remove declaration.
16016         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16017         (ada_collect_symbol_completion_matches)
16018         (ada_add_global_exceptions): Remove declaration.
16019         * linespec.c (iterate_over_all_matching_symtabs): Use
16020         objfile_compunits.
16021         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16022         (class objfile_compunits): New.
16023         (ALL_COMPUNITS): Use objfile_compunits.
16024         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16025         (maintenance_check_symtabs, maintenance_info_line_tables): Use
16026         objfile_compunits.
16027         * objfiles.c (objfile_relocate1): Use objfile_compunits.
16028
16029 2019-01-09  Tom Tromey  <tom@tromey.com>
16030
16031         * symtab.c (search_symbols)
16032         (default_collect_symbol_completion_matches_break_on): Use
16033         objfile_msymbols.
16034         * ada-lang.c (ada_lookup_simple_minsym)
16035         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16036         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16037         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16038         objfile_msymbols.
16039         * coffread.c (coff_symfile_read): Use objfile_msymbols.
16040         * symmisc.c (dump_msymbols): Use objfile_msymbols.
16041         * objc-lang.c (find_methods): Use objfile_msymbols.
16042         (info_selectors_command, info_classes_command): Likewise.
16043         * stabsread.c (scan_file_globals): Use objfile_msymbols.
16044         * objfiles.h (class objfile_msymbols): New.
16045         (ALL_OBJFILE_MSYMBOLS): Remove.
16046         (ALL_MSYMBOLS): Remove.
16047
16048 2019-01-09  Tom Tromey  <tom@tromey.com>
16049
16050         * common/next-iterator.h (next_adapter): Add Iterator template
16051         parameter.
16052         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16053         (class all_objfiles_safe): New.
16054         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16055         * objfiles.c (put_objfile_before): Update comment.
16056         (add_separate_debug_objfile): Likewise.
16057         (free_all_objfiles): Use all_objfiles_safe.
16058         (objfile_purge_solibs): Likewise.
16059
16060 2019-01-09  Tom Tromey  <tom@tromey.com>
16061
16062         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16063         (expand_symtab_containing_pc, lookup_static_symbol)
16064         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16065         (find_symbol_at_address, find_line_symtab, find_main_name): Use
16066         all_objfiles.
16067         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16068         * breakpoint.c (create_overlay_event_breakpoint)
16069         (create_longjmp_master_breakpoint)
16070         (create_std_terminate_master_breakpoint)
16071         (create_exception_master_breakpoint): Use all_objfiles.
16072         * linux-thread-db.c (try_thread_db_load_from_pdir)
16073         (has_libpthread): Use all_objfiles.
16074         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16075         * linespec.c (iterate_over_all_matching_symtabs)
16076         (search_minsyms_for_name): Use all_objfiles.
16077         * maint.c (maintenance_info_sections): Use all_objfiles.
16078         * main.c (captured_main_1): Use all_objfiles.
16079         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16080         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16081         * guile/scm-pretty-print.c
16082         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16083         * solib-spu.c (append_ocl_sos): Use all_objfiles.
16084         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16085         (maintenance_print_msymbols): Use all_objfiles.
16086         * source.c (select_source_symtab): Use all_objfiles.
16087         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16088         * symfile.c (remove_symbol_file_command)
16089         (expand_symtabs_matching, map_symbol_filenames): Use
16090         all_objfiles.
16091         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16092         all_objfiles.
16093         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16094         * objc-lang.c (find_methods): Use all_objfiles.
16095         * objfiles.c (have_partial_symbols, have_full_symbols)
16096         (have_minimal_symbols, qsort_cmp)
16097         (default_iterate_over_objfiles_in_search_order): Use
16098         all_objfiles.
16099         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16100         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16101         (maintenance_check_psymtabs): Use all_objfiles.
16102         (ALL_PSYMTABS): Remove.
16103         * compile/compile-object-run.c (do_module_cleanup): Use
16104         all_objfiles.
16105         * blockframe.c (find_pc_partial_function): Use all_objfiles.
16106         * cp-support.c (add_symbol_overload_list_qualified): Use
16107         all_objfiles.
16108         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16109         Use all_objfiles.
16110         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16111         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16112         all_objfiles.
16113         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16114         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16115         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16116         Uses all_objfiles.
16117         * solib.c (solib_read_symbols): Use all_objfiles
16118
16119 2019-01-09  Tom Tromey  <tom@tromey.com>
16120
16121         * probe.c (parse_probes_in_pspace): Use all_objfiles.
16122         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16123         all_objfiles.
16124         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16125         * symmisc.c (print_symbol_bcache_statistics)
16126         (print_objfile_statistics, maintenance_print_objfiles)
16127         (maintenance_info_symtabs, maintenance_check_symtabs)
16128         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16129         all_objfiles.
16130         * source.c (forget_cached_source_info): Use all_objfiles.
16131         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16132         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16133         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16134         * objfiles.c (update_section_map): Use all_objfiles.
16135         (shared_objfile_contains_address_p): Likewise.
16136         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16137         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16138
16139 2019-01-09  Tom Tromey  <tom@tromey.com>
16140
16141         * common/next-iterator.h: New file.
16142         * objfiles.h (class all_objfiles): New.
16143         (struct objfile_iterator): New.
16144
16145 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16146
16147         * NEWS: Move the description of the changed "frame", "select-frame",
16148          and "info frame" commands to the Changed commands section.
16149
16150 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
16151
16152         * gdbtypes.c (check_stub_method_group): Remove handling of old
16153         mangling schemes.
16154         * linespec.c (find_methods): Likewise.
16155         * stabsread.c (read_member_functions): Likewise.
16156         * valops.c (search_struct_method): Likewise.
16157         (value_struct_elt_for_reference): Likewise.
16158         * NEWS: Mention this change.
16159
16160 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
16161
16162         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16163         print_source_lines.
16164         * source.c (print_source_lines_base): Update line number check.
16165         (print_source_lines): New function.
16166         (source_lines_range::source_lines_range): New function.
16167         * source.h (class source_lines_range): New class.
16168         (print_source_lines): New declaration.
16169
16170 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16171
16172         * linespec.c (linespec_state_destructor): Free self->canonical_names.
16173
16174 2019-01-08  Tom Tromey  <tom@tromey.com>
16175             Simon Marchi  <simon.marchi@ericsson.com>
16176
16177         PR gdb/24060
16178         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16179         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16180         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16181         * f-exp.y (DOLLAR_VARIABLE): Likewise.
16182         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16183         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16184
16185 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16186
16187         * source.c (select_source_symtab): Move header comment to
16188         declaration in source.h.
16189         (forget_cached_source_info_for_objfile): Likewise.
16190         (forget_cached_source_info): Likewise.
16191         (identify_source_line): Likewise.
16192         * source.h (identify_source_line): Move declaration from symtab.h
16193         and add comment from source.c
16194         (print_source_lines): Likewise.
16195         (forget_cached_source_info_for_objfile): Likewise.
16196         (forget_cached_source_info): Likewise.
16197         (select_source_symtab): Likewise.
16198         (enum print_source_lines_flag): Move definition from symtab.h.
16199         * symtab.h (identify_source_line): Move declaration to source.h.
16200         (print_source_lines): Likewise.
16201         (forget_cached_source_info_for_objfile): Likewise.
16202         (forget_cached_source_info): Likewise.
16203         (select_source_symtab): Likewise.
16204         (enum print_source_lines_flag): Move definition to source.h.
16205         * tui/tui-hooks.c: Add 'source.h' include.
16206
16207 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16208
16209         * source.c (print_source_lines_base): Handle requests to print
16210         reverse line number sequences, and guard against empty lines
16211         string.
16212
16213 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16214
16215         * source.c (print_source_lines_base): Fix skip of '\r' if next
16216         character is '\n'.
16217
16218 2019-01-06  Tom Tromey  <tom@tromey.com>
16219
16220         * c-exp.y (struct c_parse_state) <macro_original_text,
16221         expansion_obstack>: New member.
16222         (macro_original_text, expansion_obstack): Remove globals.
16223         (scan_macro_expansion, scanning_macro_expansion)
16224         (finished_macro_expansion): Update.
16225         (scan_macro_cleanup): Remove.
16226         (yylex, c_parse): Update.
16227
16228 2019-01-06  Tom Tromey  <tom@tromey.com>
16229
16230         * c-exp.y (struct c_parse_state) <strings>: New member.
16231         (operator_stoken): Update.
16232
16233 2019-01-06  Tom Tromey  <tom@tromey.com>
16234
16235         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
16236         (union type_stack_elt) <typelist_val>: Now a pointer to
16237         std::vector.
16238         (type_stack_cleanup): Don't declare.
16239         (push_typelist): Update.
16240         * parse.c (pop_typelist): Return a std::vector.
16241         (push_typelist): Take a std::vector.
16242         (follow_types): Update.  Do not free args.
16243         (type_stack_cleanup): Remove.
16244         * c-exp.y (struct c_parse_state): New.
16245         (cpstate): New global.
16246         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16247         (nonempty_typelist): Update.
16248         (func_mod): Create a new vector.
16249         (c_parse): Create a c_parse_state.
16250         (check_parameter_typelist): Do not delete params.
16251         (function_method): Update.  Do not delete type_list.
16252
16253 2019-01-06  Tom Tromey  <tom@tromey.com>
16254
16255         PR gdb/28155:
16256         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16257         check_typedef.
16258         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16259         (print_return_value): Likewise.
16260
16261 2019-01-05  Tom Tromey  <tom@tromey.com>
16262
16263         * contrib/cleanup_check.py: Remove.
16264         * contrib/gcc-with-excheck: Remove.
16265         * contrib/exsummary.py: Remove.
16266         * contrib/excheck.py: Remove.
16267
16268 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
16269
16270         * thread.c (delete_thread_1): Add gdb_assert that THR is not
16271         NULL. Initialize tpprev to NULL instead of assigning it
16272         to NULL on the next statement.
16273         * windows-nat.c (windows_delete_thread): Remove check for
16274         main_thread_id before printing thread exit notifications.
16275         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16276         Remove thread ID check against main_thread_id.
16277         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16278         windows_delete_thread.
16279         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16280
16281 2019-01-04  Tom Tromey  <tom@tromey.com>
16282
16283         * compile/compile.c (_initialize_compile): Use upper case for
16284         metasyntactic variables.
16285         * symmisc.c (_initialize_symmisc): Use upper case for
16286         metasyntactic variables.
16287         * psymtab.c (_initialize_psymtab): Use upper case for
16288         metasyntactic variables.
16289         * demangle.c (demangle_command): Use upper case for metasyntactic
16290         variables.
16291         (_initialize_demangler): Likewise.
16292         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16293         variables.
16294
16295 2019-01-03  Tom Tromey  <tom@tromey.com>
16296
16297         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16298
16299 2019-01-03  Tom Tromey  <tom@tromey.com>
16300
16301         * python/py-symtab.c (salpy_str): Update.
16302         (struct salpy_sal_object) <symtab>: Now a PyObject.
16303         (salpy_dealloc): Update.
16304         (del_objfile_sal): Use gdbpy_ref.
16305
16306 2019-01-03  Tom Tromey  <tom@tromey.com>
16307
16308         * python/py-type.c (convert_field): Use new_reference.  Return
16309         gdbpy_ref.
16310         (make_fielditem): Return gdbpy_ref.
16311         (typy_fields): Update.
16312         (typy_getitem): Update.
16313         (field_name): Return gdbpy_ref.  Use new_reference.
16314         (typy_iterator_iternext): Update.
16315
16316 2019-01-03  Tom Tromey  <tom@tromey.com>
16317
16318         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16319
16320 2019-01-03  Tom Tromey  <tom@tromey.com>
16321
16322         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16323         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16324         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16325         (pspy_set_frame_filters, pspy_set_frame_unwinders)
16326         (pspy_set_type_printers): Likewise.
16327         * python/py-function.c (fnpy_init): Use gdbpy_ref.
16328         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16329         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16330         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16331         (objfpy_set_type_printers): Likewise.
16332
16333 2019-01-03  Tom Tromey  <tom@tromey.com>
16334
16335         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16336         (gdbpy_print_stack): Use gdbpy_err_fetch.
16337         * python/python-internal.h (class gdbpy_err_fetch): New class.
16338         (class gdbpy_enter) <m_error_type, m_error_value,
16339         m_error_traceback>: Remove.
16340         <m_error>: New member.
16341         (gdbpy_exception_to_string): Don't declare.
16342         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16343         * python/py-value.c (convert_value_from_python): Use
16344         gdbpy_err_fetch.
16345         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16346         gdbpy_exception_to_string.
16347         (gdbpy_handle_exception): Use gdbpy_err_fetch.
16348         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16349         gdbpy_err_fetch.
16350
16351 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16352
16353         * linux-nat.c (delete_lwp_cleanup): Delete.
16354         (struct lwp_deleter): New struct.
16355         (lwp_info_up): New typedef.
16356         (linux_nat_target::follow_fork): Delete cleanup, and make use of
16357         lwp_info_up.
16358
16359 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16360
16361         * linux-fork.c (class scoped_switch_fork_info): New class.
16362         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16363
16364 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16365
16366         * valops.c (find_overload_match): Remove use of null_cleanup, and
16367         calls to do_cleanups.
16368
16369 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16370
16371         * compile/compile-cplus-types.c
16372         (compile_cplus_instance::decl_name): Handle changes to
16373         cp_func_name.
16374         * cp-support.c (cp_func_name): Update header comment, update
16375         return type.
16376         * cp-support.h (cp_func_name): Update return type in declaration.
16377         * valops.c (find_overload_match): Move temp_func local to top
16378         level of function and change its type.  Use temp_func to hold and
16379         delete temporary string obtained from cp_func_name.
16380
16381 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16382
16383         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16384         gdb::char_vector, remove cleanup, and update uses of `msg`.
16385
16386 2019-01-03  Jim Wilson  <jimw@sifive.com>
16387
16388         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16389
16390 2019-01-02  Tom Tromey  <tom@tromey.com>
16391
16392         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16393         (tdesc_parse_xml): Remove cleanups.
16394         * target-descriptions.h (make_cleanup_free_target_description):
16395         Don't declare.
16396         (target_desc_deleter): New struct.
16397         (target_desc_up): New typedef.
16398         * target-descriptions.c (target_desc_deleter::operator()): Rename
16399         from free_target_description.
16400         (make_cleanup_free_target_description): Remove.
16401
16402 2019-01-02  Tom Tromey  <tom@tromey.com>
16403
16404         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
16405         constructor, destructor.
16406         (linespec_parser): Remove typedef.
16407         (~linespec_parser): Rename from linespec_parser_delete.
16408         (linespec_lex_to_end, linespec_complete_label)
16409         (linespec_complete): Update.
16410         (decode_line_full): Remove cleanups.
16411         (decode_line_1): Update.
16412
16413 2019-01-02  Tom Tromey  <tom@tromey.com>
16414
16415         * python/python-internal.h (inferior_to_inferior_object): Change
16416         return type.
16417         * python/py-exitedevent.c (create_exited_event_object): Update.
16418         * python/py-inferior.c (inferior_to_inferior_object): Return
16419         gdbpy_ref.
16420         (python_new_inferior, python_inferior_deleted)
16421         (thread_to_thread_object, delete_thread_object)
16422         (build_inferior_list, gdbpy_selected_inferior): Update.
16423         * python/py-infthread.c (create_thread_object): Update.  Also fail
16424         if inferior_to_inferior_object fails.
16425
16426 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
16427
16428         * inferior.h (class inferior) <displaced_step_state>: New field.
16429         * infrun.h (struct displaced_step_state): Move here from
16430         infrun.c.  Initialize fields, add constructor.
16431         <inf>: Remove field.
16432         <reset>: New method.
16433         * infrun.c (struct displaced_step_inferior_state): Move to
16434         infrun.h.
16435         (displaced_step_inferior_states): Remove.
16436         (get_displaced_stepping_state): Adust.
16437         (displaced_step_in_progress_any_inferior): Adjust.
16438         (displaced_step_in_progress_thread): Adjust.
16439         (displaced_step_in_progress): Adjust.
16440         (add_displaced_stepping_state): Remove.
16441         (get_displaced_step_closure_by_addr): Adjust.
16442         (remove_displaced_stepping_state): Remove.
16443         (infrun_inferior_exit): Call displaced_step_state.reset.
16444         (use_displaced_stepping): Don't check for NULL.
16445         (displaced_step_prepare_throw): Call
16446         get_displaced_stepping_state.
16447         (displaced_step_fixup): Don't check for NULL.
16448         (prepare_for_detach): Don't check for NULL.
16449
16450 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16451
16452         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16453          in case of call that did not complete.
16454
16455 2019-01-02  Andrey Utkin  <autkin@undo.io>
16456
16457         * symfile.c (find_separate_debug_file): Fix search of debug files for
16458         remote debuggee.
16459
16460 2019-01-02  Tom Tromey  <tom@tromey.com>
16461
16462         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16463         indentation.
16464         * python/py-frame.c (frapy_older): Remove cast.
16465         (frapy_newer): Likewise.
16466         * python/py-breakpoint.c (local_setattro): Remove cast.
16467         * python/py-arch.c (archpy_name): Remove local variable.
16468         * python/py-type.c (gdbpy_lookup_type): Remove cast.
16469
16470 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
16471
16472         * unittests/basic_string_view/element_access/char/empty.cc:
16473         Fix year range in copyright header.
16474
16475 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
16476
16477         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16478         Delete.
16479         <operator==>: Update with for removed field.
16480         <hash>: Likewise.
16481         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16482         <isa_features>: ...this.
16483         <abi_features>: New field.
16484         (riscv_isa_flen): Update comment.
16485         (riscv_abi_xlen): New declaration.
16486         (riscv_abi_flen): New declaration.
16487         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16488         isa_features.
16489         (riscv_abi_xlen): New function.
16490         (riscv_isa_flen): Update to get answer from isa_features.
16491         (riscv_abi_flen): New function.
16492         (riscv_has_fp_abi): Update to get answer from abi_features.
16493         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16494         xlen and flen.
16495         (riscv_call_info) <xlen, flen>: Update comment.
16496         (riscv_call_arg_struct): Remove invalid assertions
16497         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16498         is removed.
16499         (riscv_gdbarch_init): Gather isa features and abi features
16500         separately, ensure both match on the gdbarch when reusing an old
16501         gdbarch.  Relax an error check to allow 32-bit abi float to run on
16502         a target with 64-bit float hardware.
16503
16504 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16505
16506         * source.c (search_command_helper): Stop reverse search
16507         when line 1 has been searched.
16508
16509 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16510
16511         * record-full.c (record_full_base_target::close): Rewrite
16512         record_full_core_buf_list free logic.
16513
16514 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16515
16516         * break-catch-syscall.c (print_one_catch_syscall): xfree
16517         the last text.
16518
16519 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16520
16521         * top.c (print_gdb_version): Update Copyright year in version
16522         message.
16523
16524 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16525
16526         Update copyright year range in all GDB files.
16527
16528 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
16529
16530         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16531
16532 For older changes see ChangeLog-2018.
16533 \f
16534 Local Variables:
16535 mode: change-log
16536 left-margin: 8
16537 fill-column: 74
16538 version-control: never
16539 coding: utf-8
16540 End:
16541