gdb/ChangeLog

   1 2019-12-16  Tom Tromey  <tromey@adacore.com>
   2
   3         * windows-nat.c (windows_nat_target::attach): Update.
   4         * remote.c (extended_remote_target::attach): Update.
   5         * procfs.c (procfs_target::attach): Update.
   6         * nto-procfs.c (nto_procfs_target::attach): Update.
   7         (nto_procfs_target::create_inferior): Update.
   8         * inf-ptrace.c (inf_ptrace_target::attach): Update.
   9         * gnu-nat.c (gnu_nat_target::attach): Update.
  10         (gnu_nat_target::detach): Update.
  11         * darwin-nat.c (darwin_nat_target::attach): Update.
  12         * corefile.c (get_exec_file): Constify result.  Remove extraneous
  13         return.
  14         * bsd-kvm.c (bsd_kvm_target_open): Update.
  15         * gdbsupport/common-inferior.h (get_exec_file): Constify result.
  16
  17 2019-12-16  Christian Biesinger  <cbiesinger@google.com>
  18
  19         * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
  20         (we no longer need to include time.h before pathmax.h)
  21
  22 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
  23
  24         * ada-exp.y (write_ambiguous_var): Update.
  25         * coffread.c (process_coff_symbol): Update.
  26         * ctfread.c (ctf_add_enum_member_cb): Update.
  27         (new_symbol): Update.
  28         * dwarf2read.c (fixup_go_packaging): Update.
  29         (new_symbol): Update.
  30         * language.c (language_alloc_type_symbol): Update.
  31         * mdebugread.c (new_symbol): Update.
  32         * minsyms.c (minimal_symbol_reader::record_full): Update.
  33         * psymtab.c (add_psymbol_to_bcache): Update.
  34         * stabsread.c (define_symbol): Update.
  35         (read_enum_type): Update.
  36         * symtab.c (symbol_set_language): Make this a member function...
  37         (general_symbol_info::set_language): ... here.
  38         * symtab.h (struct general_symbol_info) <set_language>: New function.
  39         (SYMBOL_SET_LANGUAGE): Remove.
  40         (symbol_set_language): Remove.
  41
  42 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
  43
  44         * ada-lang.c (ada_add_block_symbols): Update.
  45         (ada_collect_symbol_completion_matches): Update.
  46         * ax-gdb.c (gen_expr): Update.
  47         * block.c (block_lookup_symbol): Update.
  48         (block_lookup_symbol_primary): Update.
  49         (block_find_symbol): Update.
  50         * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
  51         * dbxread.c (process_one_symbol): Update.
  52         * dictionary.c (insert_symbol_hashed): Update.
  53         (collate_pending_symbols_by_language): Update.
  54         (mdict_add_symbol): Update.
  55         * dwarf-index-write.c (write_psymbols): Update.
  56         * dwarf2read.c (fixup_go_packaging): Update.
  57         * findvar.c (read_var_value): Update.
  58         * ft32-tdep.c (ft32_skip_prologue): Update.
  59         * go-lang.c (go_symbol_package_name): Update.
  60         * language.h (scoped_switch_to_sym_language_if_auto::
  61         scoped_switch_to_sym_language_if_auto): Update.
  62         * linespec.c (find_method): Update.
  63         (find_label_symbols_in_block): Update.
  64         * mdebugread.c (parse_symbol): Update.
  65         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
  66         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
  67         (minimal_symbol_reader::install): Update.
  68         * moxie-tdep.c (moxie_skip_prologue): Update.
  69         * parse.c (parse_exp_in_context): Update.
  70         * psymtab.c (psymbol_name_matches): Update.
  71         (match_partial_symbol): Update.
  72         (lookup_partial_symbol): Update.
  73         (psymbol_hash): Update.
  74         (psymbol_compare): Update.
  75         * python/py-framefilter.c (extract_sym): Update.
  76         (py_print_single_arg): Update.
  77         * stabsread.c (define_symbol): Update.
  78         * stack.c (print_frame_arg): Update.
  79         (find_frame_funname): Update.
  80         (info_frame_command_core): Update.
  81         * symfile.c (set_initial_language): Update.
  82         * symtab.c (symbol_set_demangled_name): Update.
  83         (symbol_get_demangled_name): Update.
  84         (symbol_set_language): Update.
  85         (symbol_find_demangled_name): Update.
  86         (symbol_set_names): Update.
  87         (general_symbol_info::natural_name): Update.
  88         (general_symbol_info::demangled_name): Update.
  89         (general_symbol_info::search_name): Update.
  90         (symbol_matches_search_name): Update.
  91         (eq_symbol_entry): Update.
  92         (iterate_over_symbols): Update.
  93         (completion_list_add_symbol): Update.
  94         (completion_list_add_msymbol): Update.
  95         (completion_list_add_fields): Update.
  96         * symtab.h (struct general_symbol_info) <language>: New function.
  97         <language>: Rename to...
  98         <m_language>: ...this.
  99         (SYMBOL_LANGUAGE): Remove.
 100         (MSYMBOL_LANGUAGE): Remove.
 101         (struct symbol) <ctor>: Update.
 102         * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
 103
 104 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 105
 106         * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
 107         set the language of sym.
 108         * language.c (language_alloc_type_symbol): Likewise.
 109
 110 2019-12-14  Sergio Durigan Junior  <sergiodj@redhat.com>
 111
 112         https://bugzilla.redhat.com/show_bug.cgi?id=1728147
 113         PR gdb/23613
 114         * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
 115         * corelow.c: Include 'gdbsupport/pathstuff.h'.
 116         (core_target_open): Use 'gdb_abspath'.
 117         * gdbsupport/pathstuff.c (gdb_abspath): Guard against
 118         'current_directory == NULL' case.
 119         * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
 120         explain what happens when 'current_directory' is NULL.
 121         * go32-nat.c (go32_nat_target::wait): Check if
 122         'current_directory' is NULL before call to 'chdir'.
 123         * source.c (add_path): Use 'gdb_abspath'.
 124         * top.c: Include 'gdbsupport/pathstuff.h'.
 125         (init_history): Use 'gdb_abspath'.
 126         (set_history_filename): Likewise.
 127         * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
 128         (tfile_target_open): Use 'gdb_abspath'.
 129
 130 2019-12-13  Tom Tromey  <tromey@adacore.com>
 131
 132         * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
 133         warning or error.
 134
 135 2019-12-13  Tom Tromey  <tromey@adacore.com>
 136
 137         * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
 138
 139 2019-12-13  Tom Tromey  <tromey@adacore.com>
 140
 141         * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
 142
 143 2019-12-13  Tom Tromey  <tromey@adacore.com>
 144
 145         * contrib/ari/gdb_ari.sh (usage): Use GNU style.
 146
 147 2019-12-13  Tom Tromey  <tromey@adacore.com>
 148
 149         * gdbsupport/common-utils.c (string_printf, string_vprintf)
 150         (string_vappendf): Add ARI comment.
 151
 152 2019-12-13  Tom Tromey  <tromey@adacore.com>
 153
 154         * contrib/ari/gdb_ari.sh: Remove "fix" call for
 155         floatformat_to_double.
 156         * target-float.c (host_float_ops<T>::from_target): Add ARI
 157         comment.
 158
 159 2019-12-13  Tom Tromey  <tromey@adacore.com>
 160
 161         * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
 162         * utils.c (abort_with_message, dump_core, internal_vproblem): Add
 163         ARI marker to abort.
 164         * event-top.c (handle_sigsegv): Add ARI marker to abort.
 165
 166 2019-12-13  Tom Tromey  <tromey@adacore.com>
 167
 168         * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
 169
 170 2019-12-13  Tom Tromey  <tromey@adacore.com>
 171
 172         * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
 173
 174 2019-12-13  Tom Tromey  <tromey@adacore.com>
 175
 176         * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
 177         checks.
 178
 179 2019-12-13  Tom Tromey  <tromey@adacore.com>
 180
 181         * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
 182         end>: No longer "const".
 183
 184 2019-12-13  Simon Marchi  <simon.marchi@polymtl.ca>
 185
 186         * jit.c: Fix indentation, replace spaces with tabs where
 187         applicable.
 188
 189 2019-12-13  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
 190
 191         * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
 192
 193 2019-12-12  Tom Tromey  <tom@tromey.com>
 194
 195         * objfiles.h (struct objfile) <partial_symtabs>: Now a
 196         unique_ptr.
 197
 198 2019-12-12  Tom Tromey  <tom@tromey.com>
 199
 200         * progspace.h (objfile_list): New typedef.
 201         (class unwrapping_objfile_iterator)
 202         (struct unwrapping_objfile_range): Newl
 203         (struct program_space) <objfiles_range>: Change type.
 204         <objfiles>: Change return type.
 205         <add_objfile>: Change type of "objfile" parameter.
 206         <objfiles_list>: Now a list of shared_ptr.
 207         * progspace.c (program_space::add_objfile): Change type of
 208         "objfile".  Update.
 209         (program_space::remove_objfile): Update.
 210         * objfiles.h (struct objfile) <~objfile>: Make public.
 211         * objfiles.c (objfile::make): Update.
 212         (objfile::unlink): Don't call delete.
 213
 214 2019-12-12  Tom Tromey  <tom@tromey.com>
 215
 216         * symfile.c (symbol_file_clear): Update.
 217         * progspace.h (struct program_space) <free_all_objfiles>: Declare
 218         method.
 219         * progspace.c (program_space::free_all_objfiles): New method.
 220         * objfiles.h (free_all_objfiles): Don't declare.
 221         * objfiles.c (free_all_objfiles): Move to program_space.
 222
 223 2019-12-12  Tom Tromey  <tom@tromey.com>
 224
 225         * progspace.c (program_space::add_objfile)
 226         (program_space::remove_objfile): Update.
 227         (program_space::multi_objfile_p): Remove.
 228         * objfiles.h (struct objfile) <next>: Remove.
 229         * objfiles.c (objfile::objfile): Update.
 230         (put_objfile_before): Update.
 231         (unlink_objfile): Update.
 232         * progspace.h (object_files): Remove.
 233         (struct program_space) <objfiles_head>: Remove.
 234         <objfiles_list>: New member.
 235         <objfiles_range, objfiles_safe_range>: Change type.
 236         (objfiles): Change return type.
 237         (objfiles_safe): Update.
 238         (multi_objfile_p): Rewrite and inline.
 239         (object_files): Remove macro.
 240
 241 2019-12-12  Tom Tromey  <tom@tromey.com>
 242
 243         * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify.  Add
 244         second constructor.
 245         (basic_safe_range): New class.
 246
 247 2019-12-12  Tom Tromey  <tom@tromey.com>
 248
 249         * progspace.c (program_space::multi_objfile_p): New method.
 250         * printcmd.c (info_symbol_command): Update.
 251         * maint.c (maintenance_translate_address): Update.
 252         * objfiles.h (MULTI_OBJFILE_P): Remove.
 253         * progspace.h (struct program_space) <multi_objfile_p>: New
 254         method.
 255
 256 2019-12-12  Tom Tromey  <tom@tromey.com>
 257
 258         * progspace.h (struct program_space) <remove_objfile>: Declare.
 259         * progspace.c (program_space::remove_objfile): New method.
 260         * objfiles.c (unlink_objfile): Remove.
 261         (objfile::unlink): Call remove_objfile.
 262         (objfile): Don't call unlink_objfile.
 263
 264 2019-12-12  Tom Tromey  <tom@tromey.com>
 265
 266         * progspace.h (struct program_space) <add_objfile>: Declare
 267         method.
 268         * progspace.c (program_space::add_objfile): New method.
 269         * objfiles.c (~objfile): Don't unlink objfile.
 270         (put_objfile_before): Remove.
 271         (add_separate_debug_objfile): Don't call put_objfile_before.
 272         (objfile::make): Call add_objfile.  Set new_objfiles_available on
 273         the per-program-space data.
 274
 275 2019-12-12  Tom Tromey  <tom@tromey.com>
 276
 277         * symfile.c (syms_from_objfile_1): Use objfile_up.
 278         (syms_from_objfile_1, remove_symbol_file_command): Call unlink
 279         method.
 280         (reread_symbols): Use objfile_up.
 281         * solib.c (update_solib_list, reload_shared_libraries_1): Call
 282         unlink method.
 283         * objfiles.h (struct objfile) <~objfile>: Now private.
 284         <unlink>: New method.
 285         (struct objfile_deleter): New.
 286         (objfile_up): New typedef.
 287         * objfiles.c (objfile::unlink): New method.
 288         (free_objfile_separate_debug, free_all_objfiles)
 289         (objfile_purge_solibs): Use it.
 290         * jit.c (jit_unregister_code): Remove.
 291         (jit_inferior_exit_hook, jit_event_handler): Call unlink on
 292         objfile.
 293         * compile/compile-object-run.c (do_module_cleanup): Call unlink on
 294         objfile.
 295         * compile/compile-object-load.c (compile_object_load): Use
 296         objfile_up.
 297
 298 2019-12-12  Tom Tromey  <tom@tromey.com>
 299
 300         * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
 301         objfile::make.
 302         * objfiles.h (struct objjfile) <make>: No longer inline.
 303         (add_separate_debug_objfile): Don't declare.
 304         * objfiles.c (add_separate_debug_objfile): Now static.
 305         (objfile::make): Move from objfiles.h.  Call
 306         add_separate_debug_objfile.  Add "parent" parameter.
 307
 308 2019-12-12  Tom Tromey  <tom@tromey.com>
 309
 310         * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
 311         * objfiles.h (struct objfile): Make constructor private.
 312         <make>: New static method.
 313         * jit.c (jit_object_close_impl): Update.
 314
 315 2019-12-12  Simon Marchi  <simon.marchi@polymtl.ca>
 316
 317         * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
 318         gdb::byte_vector.
 319
 320 2019-12-12  Tom Tromey  <tromey@adacore.com>
 321
 322         * xml-support.c (xml_fetch_content_from_file): Don't call
 323         malloc_failure.
 324         * utils.h (class gdb_argv): Remove malloc_failure comment.
 325         * utils.c (gdb_argv::reset): Don't call malloc_failure.
 326
 327 2019-12-12  Tom Tromey  <tromey@adacore.com>
 328
 329         * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
 330         (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
 331         (ALLDEPFILES): Add riscv-ravenscar-thread.c.
 332         * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
 333         * riscv-ravenscar-thread.c: New file.
 334         * riscv-ravenscar-thread.h: New file.
 335         * riscv-tdep.c (riscv_gdbarch_init): Call
 336         register_riscv_ravenscar_ops.
 337
 338 2019-12-12  Tom Tromey  <tromey@adacore.com>
 339
 340         * gdbsupport/thread-pool.c (set_thread_name): Use
 341         ATTRIBUTE_UNUSED.
 342
 343 2019-12-12  Luis Machado  <luis.machado@linaro.org>
 344
 345         * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
 346         (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
 347         macros.
 348
 349 2019-12-11  Tom Tromey  <tom@tromey.com>
 350
 351         * tui/tui-win.c (tui_set_win_height_command): Call
 352         tui_adjust_window_height.
 353         (tui_adjust_win_heights, new_height_ok): Remove.
 354         * tui/tui-layout.h (tui_adjust_window_height): Declare.
 355         * tui/tui-layout.c (tui_adjust_window_height): New function.
 356
 357 2019-12-11  Tom Tromey  <tom@tromey.com>
 358
 359         * tui/tui-win.c (tui_resize_all): Remove code, call
 360         tui_apply_current_layout.
 361
 362 2019-12-11  Tom Tromey  <tom@tromey.com>
 363
 364         * tui/tui-layout.h (tui_apply_current_layout): Declare.
 365         * tui/tui-layout.c (standard_layouts, applied_layout): New
 366         globals.
 367         (tui_apply_current_layout): New function.
 368         (show_layout): Set applied_layout.  Call
 369         tui_apply_current_layout.
 370         (show_source_command, show_disasm_command)
 371         (show_source_disasm_command, show_data)
 372         (show_source_or_disasm_and_command): Remove.
 373         (initialize_layouts): New function.
 374         (_initialize_tui_layout): Call initialize_layouts.
 375
 376 2019-12-11  Tom Tromey  <tom@tromey.com>
 377
 378         * tui/tui-layout.h (class tui_layout_base)
 379         (class tui_layout_window, class tui_layout_split): New.
 380         * tui/tui-layout.c (tui_get_window_by_name)
 381         (tui_layout_window::clone, tui_layout_window::apply)
 382         (tui_layout_window::get_sizes, tui_layout_window::add_split)
 383         (tui_layout_split::add_window, tui_layout_split::clone)
 384         (tui_layout_split::get_sizes)
 385         (tui_layout_split::set_weights_from_heights)
 386         (tui_layout_split::adjust_size, tui_layout_split::apply): New
 387         functions.
 388         (tui_layout_split::add_split, tui_layout_split::add_split)
 389         (tui_layout_split::set_weights_from_heights)
 390         (tui_layout_split::set_weights_from_heights): New functions.
 391
 392 2019-12-11  Tom Tromey  <tom@tromey.com>
 393
 394         * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
 395         * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
 396         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 397         * tui/tui-data.h (struct tui_point): Remove.
 398         (struct tui_gen_win_info) <origin>: Remove.
 399         <x, y>: New fields.
 400         * tui/tui-command.c (tui_cmd_window::resize): Update.
 401
 402 2019-12-11  Tom Tromey  <tom@tromey.com>
 403
 404         * tui/tui-stack.h (struct tui_locator_window) <min_height>:
 405         Implement.
 406         * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
 407         Implement.
 408         * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
 409         method.
 410         (struct tui_win_info) <min_height>: Implement.
 411
 412 2019-12-11  Tom Tromey  <tom@tromey.com>
 413
 414         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 415         (struct tui_win_info) <can_box>: Update.
 416
 417 2019-12-11  Tom Tromey  <tom@tromey.com>
 418
 419         * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
 420         method.
 421         * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
 422         method.
 423         * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
 424         method.
 425         (struct tui_win_info) <max_height>: Now override.
 426
 427 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 428
 429         * NEWS: Create a new section for the next release branch.
 430         Rename the section of the current branch, now that it has
 431         been cut.
 432
 433 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 434
 435         GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
 436         * version.in: Bump version to 10.0.50.DATE-git.
 437
 438 2019-12-11  Tom Tromey  <tromey@adacore.com>
 439
 440         PR build/25268:
 441         * gdbsupport/thread-pool.c (set_thread_name): New function.
 442         (thread_pool::set_thread_count): Don't call pthread_setname_np.
 443         (thread_pool::thread_function): Call set_thread_name.
 444
 445 2019-12-11  Tom Tromey  <tromey@adacore.com>
 446
 447         * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
 448         bfd_get_signed_8.
 449
 450 2019-12-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 451
 452         * NEWS: Document -raw-values option and the related setting commands.
 453         * printcmd.c (print_command_parse_format): Do not set opts->raw off,
 454         only set it on when /r is given.
 455         * valprint.c (value_print_option_defs): New element raw-values.
 456         * Makefile.in: Add the new file.
 457
 458 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 459
 460         * gdbsupport/safe-strerror.c: Supress the unused function warning
 461         for select_strerror_r.
 462
 463 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 464
 465         * config.in: Regenerate.
 466         * configure: Regenerate.
 467         * gdbsupport/agent.c (gdb_connect_sync_socket): Call
 468         safe_strerror instead of strerror.
 469         * gdbsupport/common.m4: Don't check for strerror.
 470         * gdbsupport/safe-strerror.c: Support both the glibc version
 471         of strerror_r and the XSI version.
 472
 473 2019-12-10  Tom Tromey  <tromey@adacore.com>
 474
 475         * ada-typeprint.c (print_choices): Use a single "?".
 476         (print_variant_part): Print "?" if the discriminant name
 477         is not known.
 478
 479 2019-12-10  George Barrett  <bob@bob131.so>
 480
 481         Fix scripted probe breakpoints.
 482         * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
 483         declaration forward.
 484         (breakpoint_ops_for_event_location_type)
 485         (breakpoint_ops_for_event_location): Add function definitions.
 486         (break_command_1, trace_command): Use
 487         breakpoint_ops_for_event_location.
 488         * breakpoint.h (breakpoint_ops_for_event_location): Add function
 489         declarations.
 490         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
 491         breakpoint_ops_for_event_location.
 492         * python/py-breakpoint.c (bppy_init): Use
 493         breakpoint_ops_for_event_location.
 494
 495 2019-12-09  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 496
 497         * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
 498         when ranking an lvalue argument for an rvalue parameter.
 499
 500 2019-12-08  Wataru Ashihara  <wataash@wataash.com>
 501
 502         * darwin-nat.c (darwin_nat_target::create_inferior): Fix
 503         template argument for scoped_restore_tmpl from bool to int.
 504
 505 2019-12-07  Keith Seitz  <keiths@redhat.com>
 506
 507         * build-id.c (build_id_bfd_get): Permit bfd_core, too.
 508         (build_id_to_debug_bfd): Make static, rewriting to use
 509         build_id_to_bfd_suffix.
 510         (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
 511         adding `suffix' parameter. Append SUFFIX to file names
 512         when searching for matching files.
 513         (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
 514         (build_id_to_exec_bfd): Likewise.
 515         * build-id.h (build_id_to_debug_bfd): Clarify that function
 516         searches for BFD of debug info file.
 517         (build_id_to_exec_bfd): Declare.
 518         * corelow.c: Include build-id.h.
 519         (locate_exec_from_corefile_build_id): New function.
 520         (core_target_open): If no executable BFD is found,
 521         search for a core file BFD using build-id.
 522
 523 2019-12-06  Christian Biesinger  <cbiesinger@google.com>
 524
 525         * bcache.c: Put in namespace gdb.
 526         * bcache.h: Likewise.
 527         * gdbtypes.c (check_types_worklist): Update.
 528         (types_deeply_equal): Update.
 529         * macrotab.c (struct macro_table) <bcache>: Update.
 530         (new_macro_table): Update.
 531         * macrotab.h (struct bcache): Put this forward declaration
 532         inside namespace gdb.
 533         (new_macro_table): Update.
 534         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
 535         Update.
 536         <macro_cache>: Update.
 537         * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
 538
 539 2019-12-06  Tom de Vries  <tdevries@suse.de>
 540
 541         PR symtab/24971
 542         * block.c (best_symbol, better_symbol): New function.
 543         (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
 544         decl.
 545
 546 2019-12-06  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 547
 548         * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
 549         * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
 550         for ranking see-through reference cases.
 551
 552 2019-12-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 553         * stack.c (faas_command): Check a command is provided.
 554         * thread.c (taas_command, tfaas_command): Likewise.
 555
 556 2019-12-05  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 557         * inferior.c (prune_inferiors):  Only call delete_inferior,
 558         Do not modify the inferior list.
 559
 560 2019-12-05  Simon Marchi  <simon.marchi@polymtl.ca>
 561
 562         * c-exp.y: Update calls to lookup_typename,
 563         lookup_signed_typename and lookup_unsigned_typename.
 564         * c-lang.c (evaluate_subexp_c): Likewise.
 565         * cp-namespace.c (cp_lookup_symbol_imports_or_template):
 566         Likewise.
 567         * eval.c (binop_promote): Likewise.
 568         * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
 569         (lookup_unsigned_typename): Likewise.
 570         (lookup_signed_typename): Likewise.
 571         * gdbtypes.h (lookup_unsigned_typename): Likewise.
 572         (lookup_signed_typename): Likewise.
 573         (lookup_typename): Likewise.
 574         * guile/scm-type.c (tyscm_lookup_typename): Update calls to
 575         lookup_typename, lookup_signed_typename,
 576         lookup_unsigned_typename.
 577         * m2-exp.y: Likewise.
 578         * printcmd.c (printf_wide_c_string): Likewise.
 579         (ui_printf): Likewise.
 580         * python/py-type.c (typy_lookup_typename): Likewise.
 581         * python/py-xmethods.c (python_xmethod_worker::invoke):
 582         Likewise.
 583         * rust-exp.y: Likewise.
 584
 585 2019-12-04  Christian Biesinger  <cbiesinger@google.com>
 586
 587         * configure.nat (obsd64): Add missing files x86-nat.o and
 588         nat/x86-dregs.o.
 589
 590 2019-12-04  Tom Tromey  <tom@tromey.com>
 591
 592         * valprint.c (val_print_string): Use metadata_style.
 593         * go-valprint.c (print_go_string): Use metadata style.
 594         * p-valprint.c (pascal_object_print_static_field): Use metadata
 595         style.
 596         * cp-valprint.c (cp_print_static_field): Use metadata style.
 597
 598 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 599             Chris January  <chris.january@arm.com>
 600
 601         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
 602         tokens.
 603         (typebase): New patterns for complex, single/double precision, and
 604         single/double complex.
 605         (f77_keywords): Change token for complex keyword, and add single,
 606         double, and precision keywords.
 607
 608 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 609
 610         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
 611         "info io_registers".
 612
 613 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 614
 615         * regcache.c (cooked_read_test): Initialize thread list of
 616         mock_inferior.
 617
 618 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 619
 620         * aarch64-linux-tdep.c: Remove includes.
 621
 622 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 623
 624         * aarch64-tdep.c: Remove includes.
 625
 626 2019-12-04  Simon Marchi  <simon.marchi@efficios.com>
 627
 628         * filtered-iterator.h (filtered_iterator) <operator==,
 629         operator!=>: Compare wrapped iterators, not wrapped pointers.
 630         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 631         unittests/filtered_iterator-selftests.c.
 632         * unittests/filtered_iterator-selftests.c: New file.
 633
 634 2019-12-04  Tom Tromey  <tromey@adacore.com>
 635
 636         * gdbtypes.c (create_range_type): Inherit endianity
 637         from base type.
 638
 639 2019-12-04  Tom Tromey  <tromey@adacore.com>
 640
 641         * ada-lang.c (decode_constrained_packed_array)
 642         (ada_value_assign, value_assign_to_component): Update.
 643         * dwarf2loc.c (rw_pieced_value, access_memory)
 644         (dwarf2_compile_expr_to_ax): Update.
 645         * dwarf2read.c (dwarf2_add_field): Update.
 646         * eval.c (evaluate_subexp_standard): Update.
 647         * gdbarch.c, gdbarch.h: Rebuild.
 648         * gdbarch.sh (bits_big_endian): Remove.
 649         * gdbtypes.h (union field_location): Update comment.
 650         * target-descriptions.c (make_gdb_type): Update.
 651         * valarith.c (value_bit_index): Update.
 652         * value.c (struct value) <bitpos>: Update comment.
 653         (unpack_bits_as_long, modify_field): Update.
 654         * value.h (value_bitpos): Update comment.
 655
 656 2019-12-04  Tom Tromey  <tromey@adacore.com>
 657
 658         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
 659         endian-ness.
 660
 661 2019-12-04  Tom Tromey  <tromey@adacore.com>
 662
 663         * dwarf2read.c (dwarf2_init_float_type)
 664         (dwarf2_init_complex_target_type): Add byte_order parameter.
 665         (read_base_type): Compute byte order earlier.
 666         * gdbtypes.c (init_float_type): Add byte_order parameter.
 667         * gdbtypes.h (init_float_type): Add byte_order parameter.
 668
 669 2019-12-04  Tom Tromey  <tromey@adacore.com>
 670
 671         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
 672
 673 2019-12-04  Tom Tromey  <tromey@adacore.com>
 674
 675         * dwarf2read.c (process_structure_scope): Initialize
 676         "discr_offset".
 677
 678 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 679
 680         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
 681         add it into the search spec.
 682         (parse_max_results_option): New function.
 683         (mi_info_functions_or_variables): Parse -max-results flag and pass
 684         it to mi_symbol_info.
 685         (mi_cmd_symbol_info_modules): Likewise.
 686         (mi_cmd_symbol_info_types): Likewise.
 687         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
 688         return type to bool, change result container into a set, and don't
 689         add new results if we have enough already.
 690         (global_symbol_searcher::add_matching_msymbols): Change return
 691         type to bool, and don't add new results if we have enough already.
 692         (sort_search_symbols_remove_dups): Delete.
 693         (global_symbol_searcher::search): Early exit from search loop when
 694         we have enough results.  Use a std::set to collect the results
 695         from calling add_matching_symbols.
 696         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
 697         member function.
 698         (global_symbol_searcher) <m_max_search_results>: New member
 699         variable.
 700         (global_symbol_searcher) <add_matching_symbols>: Update header
 701         comment and change return type to bool.
 702         (global_symbol_searcher) <add_matching_msymbols>: Update header
 703         comment and change return type to bool.
 704
 705 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 706
 707         * symtab.c (symbol_search::compare_search_syms): Update header
 708         comment.
 709         (global_symbol_searcher::is_suitable_msymbol): New function.
 710         (global_symbol_searcher::expand_symtabs): New function.
 711         (global_symbol_searcher::add_matching_symbols): New function.
 712         (global_symbol_searcher::add_matching_msymbols): New function.
 713         (global_symbol_searcher::search): Move most of the content
 714         into the new functions above, and call them as needed.
 715         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
 716         function.
 717         (global_symbol_searcher) <add_matching_symbols>: New member
 718         function.
 719         (global_symbol_searcher) <add_matching_msymbols>: New member
 720         function.
 721         (global_symbol_searcher) <is_suitable_msymbol>: New member
 722         function.
 723
 724 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 725
 726         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
 727         -symbol-info-module-variables entries.
 728         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
 729         (mi_cmd_symbol_info_module_variables): Declare.
 730         * mi/mi-symbol-cmds.c
 731         (module_symbol_search_iterator): New typedef.
 732         (output_module_symbols_in_single_module_and_file): New function.
 733         (output_module_symbols_in_single_module): New function.
 734         (mi_info_module_functions_or_variables): New function.
 735         (mi_cmd_symbol_info_module_functions): New function.
 736         (mi_cmd_symbol_info_module_variables): New function.
 737         * NEWS: Mention new MI command.
 738
 739 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
 740
 741         * bcache.c (hash): Remove.
 742         (hash_continue): Remove.
 743         * bcache.h (hash): Remove.
 744         (hash_continue): Remove.
 745         (struct bcache) <ctor>: Update.
 746         * psymtab.c (psymbol_hash): Update.
 747         * stabsread.c (hashname): Update.
 748         * utils.h (fast_hash): Add an argument for a start value,
 749         defaulting to zero.
 750
 751 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 752         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
 753         (destroy_block_symbol_cache): New function.
 754         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
 755         (resize_symbol_cache): Likewise.
 756
 757 2019-12-02  Tom Tromey  <tom@tromey.com>
 758
 759         * unittests/tui-selftests.c (run_tests): Make conditional.
 760         (_initialize_tui_selftest): Make conditional.
 761
 762 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
 763
 764         * aix-thread.c (debug_aix_thread): Change type to bool.
 765
 766 2019-12-02  Luis Machado  <luis.machado@linaro.org>
 767
 768         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
 769
 770 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 771
 772         * dwarf2read.c (read_tag_string_type): Read the fields required to
 773         make a dynamic string, and possibly create a dynamic range for the
 774         string.
 775         (attr_to_dynamic_prop): Setup is_reference based on the type of
 776         attribute being processed.
 777         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
 778         (resolve_dynamic_array): Rename to...
 779         (resolve_dynamic_array_or_string): ...this, update header comment,
 780         and accept TYPE_CODE_STRING.
 781         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
 782
 783 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 784
 785         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
 786         of its implementation from...
 787         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
 788         the new function.
 789
 790 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 791
 792         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
 793         create a range with stride where appropriate.
 794         * f-valprint.c: Include 'gdbarch.h'.
 795         (f77_print_array_1): Take the stride into account when walking the
 796         array.  Also convert the stride into addressable units.
 797         * gdbtypes.c (create_range_type): Initialise the stride to
 798         constant zero.
 799         (create_range_type_with_stride): New function, initialise the
 800         range as normal, and then setup the stride.
 801         (has_static_range): Include the stride here.  Also change the
 802         return type to bool.
 803         (create_array_type_with_stride): Consider the range stride if the
 804         array isn't given its own stride.
 805         (resolve_dynamic_range): Resolve the stride if needed.
 806         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
 807         (struct range_bounds) <flag_is_byte_stride>: New member variable.
 808         (TYPE_BIT_STRIDE): Define.
 809         (TYPE_ARRAY_BIT_STRIDE): Define.
 810         (create_range_type_with_stride): Declare.
 811         * valarith.c (value_subscripted_rvalue): Take range stride into
 812         account when walking the array.
 813
 814 2019-12-01  Tom Tromey  <tom@tromey.com>
 815
 816         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
 817         specially.
 818
 819 2019-12-01  Tom Tromey  <tom@tromey.com>
 820
 821         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
 822         \0.
 823         * unittests/tui-selftests.c: New file.
 824         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
 825
 826 2019-12-01  Tom Tromey  <tom@tromey.com>
 827
 828         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
 829
 830 2019-12-01  Tom Tromey  <tom@tromey.com>
 831
 832         * NEWS: Document new settings.
 833         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
 834         * tui/tui-win.c (_initialize_tui_win): Add border style
 835         observers.
 836         * tui/tui-io.h (tui_apply_style): Declare.
 837         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
 838         longer static.
 839         (apply_ansi_escape, tui_set_reverse_mode): Update.
 840         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
 841         Add "skip_intensity" parameter.
 842         <changed>: New member.
 843         <do_set_value>: Declare.
 844         (tui_border_style, tui_active_border_style): Declare.
 845         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
 846         globals.
 847         (cli_style_option): Initialize "changed".
 848         (cli_style_option::do_set_value): New function.
 849         (cli_style_option::add_setshow_commands): Add "skip_intensity"
 850         parameter.  Update.
 851         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
 852         (_initialize_cli_style): Update.  Create TUI border style
 853         commands.
 854
 855 2019-12-01  Tom Tromey  <tom@tromey.com>
 856
 857         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
 858         parameter.
 859         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
 860         parameter.
 861         * tui/tui-win.h (compact_source): Declare.
 862         * tui/tui-win.c (compact_source): New global.
 863         (tui_set_compact_source, tui_show_compact_source): New functions.
 864         (_initialize_tui_win): Add "compact-source" setting.
 865         * tui/tui-source.c (tui_source_window::set_contents): Handle
 866         compact_source setting.
 867         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 868         * NEWS: Document new setting.
 869
 870 2019-11-30  Tom Tromey  <tom@tromey.com>
 871
 872         * dwarf2read.c (dwarf2_add_field): Include field offset when
 873         computing variant part length.
 874
 875 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 876         * NEWS:  Mention define-prefix.  Tell that command names can now
 877         contain a . character.
 878
 879 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 880
 881         * command.h (valid_cmd_char_p): Declare.
 882         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
 883         the check of valid command char.
 884         (find_command_name_length, valid_user_defined_cmd_name_p): Use
 885         valid_cmd_char_p.
 886         * cli/cli-script.c (validate_comname): Likewise.
 887         * completer.c (gdb_completer_command_word_break_characters):
 888         Do not remove . from the word break char, update comments.
 889         (complete_line_internal_1): Use valid_cmd_char_p.
 890         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
 891         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
 892
 893 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 894
 895         * cli/cli-script.c (do_define_command): Ensure a redefined
 896         prefix command is kept as a prefix command.
 897         (define_prefix_command): New function.
 898         (show_user_1): Report user defined prefixes.
 899         (_initialize_cli_script):  Create the new 'define-prefix' command.
 900         Add completers for 'define' and 'document'.
 901         * top.c (execute_command):  If command is a user-defined prefix only
 902         command, report the list of commands for this prefix command.
 903
 904 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 905
 906         * valops.c (find_oload_champ): Improve debug output.
 907
 908 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 909
 910         * valops.c (find_oload_champ): Print part of debug messages
 911         before the badness vector is std::move'd.
 912
 913 2019-11-28  Tom Tromey  <tom@tromey.com>
 914
 915         * value.c (creal_internal_fn): Fix comment.
 916
 917 2019-11-28  Tom Tromey  <tom@tromey.com>
 918
 919         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
 920         flag_bound_evaluated>: Now unsigned.
 921
 922 2019-11-28  Tom Tromey  <tom@tromey.com>
 923
 924         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
 925         declare.
 926
 927 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
 928
 929         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
 930         debug output.
 931         * jit.c (jit_unregister_code): Add debug print to match
 932         `jit_register_code`.
 933
 934 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 935
 936         * NEWS: Mention the new multithreaded symbol loading.
 937
 938 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 939
 940         * maint.c (n_worker_threads): Default to 0.
 941         (worker_threads_disabled): New function.
 942         * maint.h (worker_threads_disabled): New function.
 943         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
 944         here if worker_threads_disabled () is true.
 945         (minimal_symbol_reader::install): Skip all threading if
 946         worker_threads_disabled () is true.
 947
 948 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 949
 950         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
 951         hash code if possible.
 952         (add_minsym_to_demangled_hash_table): Likewise.
 953         (minimal_symbol_reader::install): Compute the hash codes for msymbol
 954         on the background thread.
 955         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
 956         Add these fields.
 957
 958 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 959
 960         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
 961         of the mangled name on the background thread.
 962         * symtab.c (symbol_set_names): Allow passing in the hash of the
 963         linkage_name.
 964         * symtab.h (symbol_set_names): Likewise.
 965
 966 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
 967
 968         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
 969         physnames are computed for inherited DIEs.
 970
 971 2019-11-27  Tom Tromey  <tromey@adacore.com>
 972
 973         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
 974         backslashes.
 975         * cp-support.c: Remove unnecessary backslashes.
 976
 977 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 978
 979         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
 980         with sym->set_linkage_name.
 981         * coffread.c (coff_read_enum_type): Likewise.
 982         * mdebugread.c (parse_symbol): Likewise.
 983         * stabsread.c (patch_block_stabs): Likewise.
 984         (define_symbol): Likewise.
 985         (read_enum_type): Likewise.
 986         (common_block_end): Likewise.
 987         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
 988         function.
 989         (SYMBOL_SET_LINKAGE_NAME): Remove.
 990         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
 991         with sym->set_linkage_name.
 992
 993 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 994
 995         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
 996         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
 997         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
 998         * NEWS: Mention new MI command.
 999
1000 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1001
1002         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1003         '-symbol-info-types', and '-symbol-info-variables'.
1004         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1005         (mi_cmd_symbol_info_types): Declare.
1006         (mi_cmd_symbol_info_variables): Declare.
1007         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1008         (output_debug_symbol): New function.
1009         (output_nondebug_symbol): New function.
1010         (mi_symbol_info): New function.
1011         (mi_info_functions_or_variables): New function.
1012         (mi_cmd_symbol_info_functions): New function.
1013         (mi_cmd_symbol_info_types): New function.
1014         (mi_cmd_symbol_info_variables): New function.
1015         * NEWS: Mention new commands.
1016
1017 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1018
1019         * symtab.c (symbol_to_info_string): New function, most content
1020         moved from print_symbol_info, but updated to return a std::string.
1021         (print_symbol_info): Update to use symbol_to_info_string and print
1022         returned string.
1023         * symtab.h (symbol_to_info_string): Declare new function.
1024
1025 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1026
1027         * python/python.c (gdbpy_rbreak): Convert to using
1028         global_symbol_searcher.
1029         * symtab.c (file_matches): Convert return type to bool, change
1030         file list to std::vector, update header comment.
1031         (search_symbols): Rename to...
1032         (global_symbol_searcher::search): ...this and update now its
1033         a member function of global_symbol_searcher.  Take account of the
1034         changes to file_matches.
1035         (symtab_symbol_info): Convert to using global_symbol_searcher.
1036         (rbreak_command): Likewise.
1037         (search_module_symbols): Likewise.
1038         * symtab.h (enum symbol_search): Update comment.
1039         (search_symbols): Remove declaration.
1040         (class global_symbol_searcher): New class.
1041
1042 2019-11-26  Tom Tromey  <tromey@adacore.com>
1043
1044         * cp-support.c (_initialize_cp_support): Conditionally initialize
1045         gdb_demangle_attempt_core_dump.
1046
1047 2019-11-26  Tom Tromey  <tom@tromey.com>
1048
1049         * python/py-function.c (fnpy_init): Update.
1050         * value.h (add_internal_function): Adjust declaration.
1051         * value.c (function_destroyer): Remove.
1052         (do_add_internal_function): Don't set destroyer or copy name.
1053         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1054         Set name_allocated.
1055         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1056         (cmdpy_init): Set name_allocated.
1057         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1058         member.
1059         (~cmd_list_element): Free "name" if needed.
1060
1061 2019-11-26  Tom Tromey  <tom@tromey.com>
1062
1063         * value.h (add_internal_function): Add new overload.  Move
1064         documentation from value.h.
1065         * value.c (do_add_internal_function): New function.
1066         (add_internal_function): Use it.  Add new overload.
1067         (function_destroyer): Don't free doc.
1068         * python/py-function.c (fnpy_init): Update.
1069
1070 2019-11-26  Tom Tromey  <tom@tromey.com>
1071
1072         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1073         (cmdpy_init): Set "doc_allocated".
1074
1075 2019-11-26  Tom Tromey  <tom@tromey.com>
1076
1077         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1078         name of worker thread.
1079         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1080         pthread_setname_np.
1081         * configure, config.in: Rebuild.
1082
1083 2019-11-26  Tom Tromey  <tom@tromey.com>
1084
1085         * python/python.c (class gdbpy_gil): New.
1086         (struct gdbpy_event): Add constructor, destructor, operator().
1087         (gdbpy_post_event): Use run_on_main_thread.
1088         (gdbpy_initialize_events): Remove.
1089         (do_start_initialization): Update.
1090
1091 2019-11-26  Tom Tromey  <tom@tromey.com>
1092
1093         * NEWS: Add entry.
1094         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1095         commands.  Call update_thread_pool_size.
1096         (update_thread_pool_size, maintenance_set_worker_threads): New
1097         functions.
1098         (n_worker_threads): New global.
1099
1100 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1101             Tom Tromey  <tom@tromey.com>
1102
1103         * minsyms.c (minimal_symbol_reader::install): Use
1104         parallel_for_each.
1105         * gdbsupport/parallel-for.h: New file.
1106         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1107
1108 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1109             Tom Tromey  <tom@tromey.com>
1110
1111         * gdbsupport/thread-pool.h: New file.
1112         * gdbsupport/thread-pool.c: New file.
1113         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1114         (HFILES_NO_SRCDIR): Add thread-pool.h.
1115
1116 2019-11-26  Tom Tromey  <tom@tromey.com>
1117
1118         * event-top.h (thread_local_segv_handler): Declare.
1119         * event-top.c (thread_local_segv_handler): New global.
1120         (install_handle_sigsegv, handle_sigsegv): New functions.
1121         (async_init_signals): Install SIGSEGV handler.
1122         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
1123         thread-local.
1124         (report_failed_demangle): New function.
1125         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
1126         handler-setting code, instead use segv_handler.  Run warning code
1127         on main thread.
1128
1129 2019-11-26  Tom Tromey  <tom@tromey.com>
1130
1131         * run-on-main-thread.c: New file.
1132         * run-on-main-thread.h: New file.
1133         * unittests/main-thread-selftests.c: New file.
1134         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1135         main-thread-selftests.c.
1136         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1137         (COMMON_SFILES): Add run-on-main-thread.c.
1138
1139 2019-11-26  Tom Tromey  <tom@tromey.com>
1140
1141         * main.c (setup_alternate_signal_stack): Remove.
1142         (captured_main_1): Use gdb::alternate_signal_stack.
1143         * gdbsupport/alt-stack.h: New file.
1144
1145 2019-11-26  Tom Tromey  <tom@tromey.com>
1146
1147         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1148         Remove comment.
1149         (save_original_signals_state, restore_original_signals_state): Use
1150         gdb_sigmask.
1151         * linux-nat.c (block_child_signals, restore_child_signals_mask)
1152         (_initialize_linux_nat): Use gdb_sigmask.
1153         * guile/guile.c (_initialize_guile): Use block_signals.
1154         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1155         * gdbsupport/gdb-sigmask.h: New file.
1156         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1157         * cp-support.c (gdb_demangle): Use gdb_sigmask.
1158         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1159         pthread_sigmask.
1160         * configure, config.in: Rebuild.
1161         * gdbsupport/block-signals.h: New file.
1162
1163 2019-11-26  Tom Tromey  <tom@tromey.com>
1164
1165         * acinclude.m4: Include ax_pthread.m4.
1166         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1167         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1168         (CLIBS): Use PTHREAD_LIBS.
1169         (aclocal_m4_deps): Add ax_pthread.m4.
1170         * config.in, configure: Rebuild.
1171         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1172
1173 2019-11-26  Tom Tromey  <tom@tromey.com>
1174
1175         * symtab.h (struct minimal_symbol) <name_set>: New member.
1176         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1177         Don't call symbol_set_names.
1178         (minimal_symbol_reader::install): Call symbol_set_names.
1179
1180 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1181
1182         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1183         restore_active_ext_lang, as GIL is needed for (indirectly)
1184         called PyOS_InterruptOccurred.
1185
1186 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1187
1188         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1189         definition.
1190
1191 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1192
1193         * remote-sim.c (simulator_command): Make static, remove
1194         declaration.
1195
1196 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1197
1198         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1199         static.
1200         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1201         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1202         (main): Likewise.
1203         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1204         (main): Likewise.
1205         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1206         (main): Likewise.
1207         * unittests/basic_string_view/element_access/char/1.cc (test01):
1208         Likewise.
1209         (main): Likewise.
1210         * unittests/basic_string_view/element_access/char/empty.cc (main):
1211         Likewise.
1212         * unittests/basic_string_view/element_access/char/front_back.cc
1213         (test01): Likewise.
1214         (main): Likewise.
1215         * unittests/basic_string_view/inserters/char/2.cc (test05):
1216         Likewise.
1217         (main): Likewise.
1218         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1219         (test01): Likewise.
1220         (main): Likewise.
1221         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1222         (test01): Likewise.
1223         (main): Likewise.
1224         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1225         Likewise.
1226         * unittests/basic_string_view/operations/compare/char/1.cc
1227         (test01): Likewise.
1228         (main): Likewise.
1229         * unittests/basic_string_view/operations/compare/char/13650.cc
1230         (test01): Likewise.
1231         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1232         Likewise.
1233         (main): Likewise.
1234         * unittests/basic_string_view/operations/data/char/1.cc (test01):
1235         Likewise.
1236         (main): Likewise.
1237         * unittests/basic_string_view/operations/find/char/1.cc (test01):
1238         Likewise.
1239         (main): Likewise.
1240         * unittests/basic_string_view/operations/find/char/2.cc (test02):
1241         Likewise.
1242         (main): Likewise.
1243         * unittests/basic_string_view/operations/find/char/3.cc (test03):
1244         Likewise.
1245         (main): Likewise.
1246         * unittests/basic_string_view/operations/find/char/4.cc (main):
1247         Likewise.
1248         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1249         Likewise.
1250         (main): Likewise.
1251         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1252         Likewise.
1253         (main): Likewise.
1254         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1255         Likewise.
1256         (main): Likewise.
1257         * unittests/basic_string_view/operations/substr/char/1.cc
1258         (test01): Likewise.
1259         (main): Likewise.
1260         * unittests/basic_string_view/operators/char/2.cc (main):
1261         Likewise.
1262         * unittests/optional/assignment/1.cc (test): Likewise.
1263         * unittests/optional/assignment/2.cc (test): Likewise.
1264         * unittests/optional/assignment/3.cc (test): Likewise.
1265         * unittests/optional/assignment/4.cc (test): Likewise.
1266         * unittests/optional/assignment/5.cc (test): Likewise.
1267         * unittests/optional/assignment/6.cc (test): Likewise.
1268         * unittests/optional/assignment/7.cc (test): Likewise.
1269         * unittests/optional/cons/copy.cc (test): Likewise.
1270         * unittests/optional/cons/default.cc (test): Likewise.
1271         * unittests/optional/cons/move.cc (test): Likewise.
1272         * unittests/optional/cons/value.cc (test): Likewise.
1273         * unittests/optional/in_place.cc (test): Likewise.
1274         * unittests/optional/observers/1.cc (test): Likewise.
1275         * unittests/optional/observers/2.cc (test): Likewise.
1276
1277 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1278
1279         * tui-win.h (tui_set_var_cmd): Remove.
1280         * tui-win.c (tui_set_var_cmd): Make static.
1281
1282 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1283
1284         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1285         rbreak_command_wrapper): Remove.
1286         * symtab.c (rbreak_command_wrapper): Remove.
1287
1288 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1289
1290         * inferior.h (info_terminal_command): Remove declaration.
1291         * inflow.c (info_terminal_command): Make static.
1292
1293 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1294
1295         * inferior.c (exit_inferior_silent): Remove.
1296
1297 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1298
1299         * dictionary.c (dict_empty, mdict_empty): Remove.
1300         * dictionary.c (mdict_empty): Remove.
1301
1302 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1303
1304          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1305          (arc_insn_get_memory_offset): Likewise.
1306          (arc_insn_dump): Likewise.
1307          * cp-support.c (test_cp_symbol_name_matches): Likewise.
1308          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1309          * dictionary.c (dict_iterator_next): Likewise.
1310          (dict_iter_match_first): Likewise.
1311          (dict_iter_match_next): Likewise.
1312          * f-lang.c (evaluate_subexp_f): Likewise.
1313          * hppa-tdep.c (hppa_read_pc): Likewise.
1314          * i386-tdep.c (i386_floatformat_for_type): Likewise.
1315          * parse.c (write_exp_elt_msym): Likewise.
1316          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1317          * remote.c (remote_packet_size): Likewise.
1318          (remote_notif_stop_parse): Likewise.
1319          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1320          * s12z-tdep.c (s12z_disassemble_info): Likewise.
1321          * source.c (prepare_path_for_appending): Likewise.
1322          * sparc64-linux-tdep.c
1323          (sparc64_linux_handle_segmentation_fault); Likewise.
1324          * stack.c (frame_selection_by_function_completer): Likewise.
1325
1326 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1327
1328         * completer.c (set_gdb_completion_word_break_characters):
1329         Remove.
1330
1331 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1332
1333         * dwarf-index-write.c: Include dwarf-index-write.h.
1334         * mi/mi-interp.c: Include mi/mi-interp.h.
1335
1336 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1337
1338         * aarch32-tdep.c: Include aarch32-tdep.h.
1339         * aarch32-tdep.h: Forward-declare struct target_desc.
1340
1341 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1342
1343         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1344         strerror.
1345         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1346         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1347
1348 2019-11-25  Tom de Vries  <tdevries@suse.de>
1349
1350         * contrib/words.sh: Add -c option.
1351
1352 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
1353
1354         * solib.c (solib_find_1): Change int to bool.
1355         (exec_file_find): Change int to bool.
1356         (solib_find): Change int to bool.
1357         (solib_read_symbols): Change int to bool.
1358         (solib_used): Change int to bool.
1359         (solib_add): Change int to bool.
1360         (info_sharedlibrary_command): Change int to bool.
1361         (solib_contains_address_p): Change int to bool.
1362         (solib_keep_data_in_core): Change int to bool.
1363         (in_solib_dynsym_resolve_code): Change int to bool.
1364         (reload_shared_libraries_1): Change int to bool.
1365         (gdb_sysroot_changed): Change int to bool.
1366         * solib.h (solib_read_symbols): Change int to bool.
1367         (solib_contains_address_p): Change int to bool.
1368         (solib_keep_data_in_core): Change int to bool.
1369         (in_solib_dynsym_resolve_code): Change int to bool.
1370         (libpthread_name_p): Change int to bool.
1371
1372 2019-11-25  Luis Machado  <luis.machado@linaro.org>
1373
1374         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1375         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1376         (remote_packet_max_chars): New static global.
1377         (show_remote_packet_max_chars): New function.
1378         (remote_target::putpkt_binary): Adjust to use new
1379         remote_packet_max_chars option.
1380         (remote_target::getpkt_or_notif_sane_1): Likewise.
1381         (_initialize_remote): Register new remote-packet-max-chars option.
1382
1383 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
1384
1385         * m68k-linux-nat.c: Include gdbarch.h.
1386
1387 2019-11-24  Tom Tromey  <tom@tromey.com>
1388
1389         * symfile.c (read_symbols): Update.
1390         * psymtab.c (require_partial_symbols): Change type of "verbose" to
1391         bool.
1392         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1393         (psym_lookup_symbol, psym_find_last_source_symtab)
1394         (psym_forget_cached_source_info, psym_print_stats)
1395         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1396         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1397         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1398         (psym_find_compunit_symtab_by_address)
1399         (maintenance_print_psymbols, maintenance_info_psymtabs)
1400         (maintenance_check_psymtabs): Update.
1401         * psymtab.h (require_partial_symbols): Change type of "verbose" to
1402         bool.
1403
1404 2019-11-22  Tom Tromey  <tom@tromey.com>
1405
1406         * observable.h: Update comments.
1407
1408 2019-11-22  Tom Tromey  <tromey@adacore.com>
1409
1410         * ada-tasks.c (ada_task_is_alive): Make parameter const.
1411         (print_ada_task_info): Don't try to fetch thread id if task is not
1412         alive.
1413
1414 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1415
1416         * ada-exp.y: Update.
1417         * ada-lang.c (sort_choices): Update.
1418         (ada_print_symbol_signature): Update.
1419         (resolve_subexp): Update.
1420         (ada_parse_renaming): Update.
1421         (ada_read_renaming_var_value): Update.
1422         (lesseq_defined_than): Update.
1423         (remove_extra_symbols): Update.
1424         (remove_irrelevant_renamings): Update.
1425         (ada_add_block_symbols): Update.
1426         (ada_collect_symbol_completion_matches): Update.
1427         (ada_is_renaming_symbol): Update.
1428         (aggregate_assign_from_choices): Update.
1429         (ada_evaluate_subexp): Update.
1430         (ada_has_this_exception_support): Update.
1431         (ada_is_non_standard_exception_sym): Update.
1432         (ada_add_exceptions_from_frame): Update.
1433         (ada_add_global_exceptions): Update.
1434         (ada_print_subexp): Update.
1435         * ax-gdb.c (gen_var_ref): Update.
1436         (gen_maybe_namespace_elt): Update.
1437         (gen_expr_for_cast): Update.
1438         (gen_expr): Update.
1439         * block.h: Update.
1440         * blockframe.c (find_pc_partial_function): Update.
1441         * breakpoint.c (print_breakpoint_location): Update.
1442         (update_static_tracepoint): Update.
1443         * btrace.c (ftrace_print_function_name): Update.
1444         (ftrace_function_switched): Update.
1445         * buildsym.c (find_symbol_in_list): Update.
1446         * c-exp.y: Update.
1447         * c-typeprint.c (c_print_typedef): Update.
1448         (c_type_print_template_args): Update.
1449         * cli/cli-cmds.c (edit_command): Update.
1450         (list_command): Update.
1451         (print_sal_location): Update.
1452         * coffread.c (patch_opaque_types): Update.
1453         (process_coff_symbol): Update.
1454         (coff_read_enum_type): Update.
1455         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1456         (convert_one_symbol): Update.
1457         (hash_symname): Update.
1458         (eq_symname): Update.
1459         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1460         * compile/compile-cplus-types.c (debug_print_scope): Update.
1461         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1462         * compile/compile-object-load.c (get_out_value_type): Update.
1463         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1464         (search_symbol_list): Update.
1465         (cp_lookup_symbol_imports_or_template): Update.
1466         * cp-support.c (overload_list_add_symbol): Update.
1467         * ctfread.c (psymtab_to_symtab): Update.
1468         * dbxread.c (cp_set_block_scope): Update.
1469         * dictionary.c (iter_match_first_hashed): Update.
1470         (iter_match_next_hashed): Update.
1471         (insert_symbol_hashed): Update.
1472         (iter_match_next_linear): Update.
1473         * dictionary.h: Update.
1474         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1475         (locexpr_describe_location_piece): Update.
1476         (locexpr_describe_location_1): Update.
1477         (locexpr_generate_c_location): Update.
1478         (loclist_describe_location): Update.
1479         (loclist_generate_c_location): Update.
1480         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1481         (read_func_scope): Update.
1482         (process_enumeration_scope): Update.
1483         (new_symbol): Update.
1484         (dwarf2_const_value): Update.
1485         (dwarf2_symbol_mark_computed): Update.
1486         * eval.c (evaluate_funcall): Update.
1487         (evaluate_subexp_standard): Update.
1488         * expprint.c (print_subexp_standard): Update.
1489         (dump_subexp_body_standard): Update.
1490         * f-valprint.c (info_common_command_for_block): Update.
1491         * findvar.c (get_hosting_frame): Update.
1492         (default_read_var_value): Update.
1493         * go-lang.c (go_symbol_package_name): Update.
1494         * guile/scm-block.c (bkscm_print_block_smob): Update.
1495         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1496         (gdbscm_symbol_name): Update.
1497         (gdbscm_symbol_linkage_name): Update.
1498         (gdbscm_symbol_print_name): Update.
1499         * infcall.c (get_function_name): Update.
1500         * infcmd.c (jump_command): Update.
1501         (finish_command): Update.
1502         * infrun.c (insert_exception_resume_breakpoint): Update.
1503         * linespec.c (canonicalize_linespec): Update.
1504         (create_sals_line_offset): Update.
1505         (convert_linespec_to_sals): Update.
1506         (complete_label): Update.
1507         (find_label_symbols_in_block): Update.
1508         * m2-typeprint.c (m2_print_typedef): Update.
1509         * mdebugread.c (mdebug_reg_to_regnum): Update.
1510         (parse_symbol): Update.
1511         (mylookup_symbol): Update.
1512         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1513         (list_args_or_locals): Update.
1514         * objc-lang.c (compare_selectors): Update.
1515         (info_selectors_command): Update.
1516         (compare_classes): Update.
1517         (info_classes_command): Update.
1518         (find_imps): Update.
1519         * p-typeprint.c (pascal_print_typedef): Update.
1520         * printcmd.c (build_address_symbolic): Update.
1521         (info_address_command): Update.
1522         (print_variable_and_value): Update.
1523         * python/py-framefilter.c (extract_sym): Update.
1524         (py_print_single_arg): Update.
1525         * python/py-symbol.c (sympy_str): Update.
1526         (sympy_get_name): Update.
1527         (sympy_get_linkage_name): Update.
1528         * python/python.c (gdbpy_rbreak): Update.
1529         * record-btrace.c (btrace_get_bfun_name): Update.
1530         (btrace_call_history): Update.
1531         * rust-lang.c (rust_print_typedef): Update.
1532         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1533         * stabsread.c (stab_reg_to_regnum): Update.
1534         (define_symbol): Update.
1535         (read_enum_type): Update.
1536         (common_block_end): Update.
1537         (cleanup_undefined_types_1): Update.
1538         (scan_file_globals): Update.
1539         * stack.c (print_frame_arg): Update.
1540         (print_frame_args): Update.
1541         (find_frame_funname): Update.
1542         (info_frame_command_core): Update.
1543         (iterate_over_block_locals): Update.
1544         (print_block_frame_labels): Update.
1545         (do_print_variable_and_value): Update.
1546         (iterate_over_block_arg_vars): Update.
1547         (return_command): Update.
1548         * symmisc.c (dump_symtab_1): Update.
1549         (print_symbol): Update.
1550         * symtab.c (eq_symbol_entry): Update.
1551         (symbol_cache_dump): Update.
1552         (lookup_language_this): Update.
1553         (find_pc_sect_line): Update.
1554         (skip_prologue_sal): Update.
1555         (symbol_search::compare_search_syms): Update.
1556         (treg_matches_sym_type_name): Update.
1557         (search_symbols): Update.
1558         (print_symbol_info): Update.
1559         (rbreak_command): Update.
1560         (completion_list_add_symbol): Update.
1561         (find_gnu_ifunc): Update.
1562         (get_symbol_address): Update.
1563         (search_module_symbols): Update.
1564         (info_module_subcommand): Update.
1565         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1566         (SYMBOL_LINKAGE_NAME): Remove.
1567         (SYMBOL_DEMANGLED_NAME): Remove.
1568         (SYMBOL_PRINT_NAME): Remove.
1569         (SYMBOL_SEARCH_NAME): Remove.
1570         * tracepoint.c (set_traceframe_context): Update.
1571         (validate_actionline): Update.
1572         (collection_list::collect_symbol): Update.
1573         (encode_actions_1): Update.
1574         (info_scope_command): Update.
1575         (print_one_static_tracepoint_marker): Update.
1576         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1577         * valops.c (address_of_variable): Update.
1578         (find_overload_match): Update.
1579         (find_oload_champ): Update.
1580
1581 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1582
1583         * ada-lang.c (ada_lookup_simple_minsym): Update.
1584         (ada_collect_symbol_completion_matches): Update.
1585         * ada-tasks.c (read_atcb): Update.
1586         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1587         (amd64_windows_skip_trampoline_code): Update.
1588         * arm-tdep.c (skip_prologue_function): Update.
1589         (arm_skip_stack_protector): Update.
1590         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1591         (arm_wince_skip_main_prologue): Update.
1592         * ax-gdb.c (gen_expr): Update.
1593         * block.c (call_site_for_pc): Update.
1594         * blockframe.c (find_pc_partial_function): Update.
1595         * breakpoint.c (set_breakpoint_location_function): Update.
1596         * btrace.c (ftrace_print_function_name): Update.
1597         (ftrace_function_switched): Update.
1598         * c-valprint.c (print_unpacked_pointer): Update.
1599         * coffread.c (coff_symfile_read): Update.
1600         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1601         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1602         * dwarf-index-write.c (write_psymbols): Update.
1603         * dwarf2loc.c (call_site_to_target_addr): Update.
1604         (func_verify_no_selftailcall): Update.
1605         (tailcall_dump): Update.
1606         (call_site_find_chain_1): Update.
1607         (dwarf_expr_reg_to_entry_parameter): Update.
1608         * elfread.c (elf_gnu_ifunc_record_cache): Update.
1609         * eval.c (evaluate_funcall): Update.
1610         (evaluate_subexp_standard): Update.
1611         (evaluate_subexp_for_sizeof): Update.
1612         * expprint.c (print_subexp_standard): Update.
1613         (dump_subexp_body_standard): Update.
1614         * frame.c (get_prev_frame_always_1): Update.
1615         * frv-tdep.c (frv_skip_main_prologue): Update.
1616         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1617         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1618         (gnuv3_get_typename_from_type_info): Update.
1619         (gnuv3_skip_trampoline): Update.
1620         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1621         * i386-tdep.c (i386_skip_main_prologue): Update.
1622         (i386_pe_skip_trampoline_code): Update.
1623         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1624         * infcall.c (get_function_name): Update.
1625         * linespec.c (minsym_found): Update.
1626         * linux-fork.c (info_checkpoints_command): Update.
1627         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1628         (m32c_m16c_pointer_to_address): Update.
1629         * maint.c (maintenance_translate_address): Update.
1630         * minsyms.c (add_minsym_to_hash_table): Update.
1631         (add_minsym_to_demangled_hash_table): Update.
1632         (lookup_minimal_symbol_mangled): Update.
1633         (lookup_minimal_symbol_demangled): Update.
1634         (lookup_minimal_symbol_linkage): Update.
1635         (lookup_minimal_symbol_text): Update.
1636         (lookup_minimal_symbol_by_pc_name): Update.
1637         (minimal_symbol_is_less_than): Update.
1638         (compact_minimal_symbols): Update.
1639         (build_minimal_symbol_hash_tables): Update.
1640         (find_solib_trampoline_target): Update.
1641         * mips-tdep.c (mips_stub_frame_sniffer): Update.
1642         (mips_skip_pic_trampoline_code): Update.
1643         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1644         * objc-lang.c (info_selectors_command): Update.
1645         (info_classes_command): Update.
1646         (find_methods): Update.
1647         (find_imps): Update.
1648         * p-valprint.c (pascal_val_print): Update.
1649         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1650         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1651         * printcmd.c (build_address_symbolic): Update.
1652         (info_symbol_command): Update.
1653         * psymtab.c (psymbol_name_matches): Update.
1654         (match_partial_symbol): Update.
1655         (lookup_partial_symbol): Update.
1656         (print_partial_symbols): Update.
1657         (sort_pst_symbols): Update.
1658         (maintenance_check_psymtabs): Update.
1659         * python/py-framefilter.c (py_print_frame): Update.
1660         * python/python.c (gdbpy_rbreak): Update.
1661         * record-btrace.c (btrace_get_bfun_name): Update.
1662         (btrace_call_history): Update.
1663         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1664         (rs6000_skip_trampoline_code): Update.
1665         * sol-thread.c (info_cb): Update.
1666         * stabsread.c (scan_file_globals): Update.
1667         * stack.c (find_frame_funname): Update.
1668         (info_frame_command_core): Update.
1669         * symmisc.c (dump_msymbols): Update.
1670         * symtab.c (symbol_natural_name): Rename to..,
1671         (general_symbol_info::natural_name): ...this.
1672         (symbol_demangled_name): Rename to...
1673         (general_symbol_info::demangled_name): ...this.
1674         (symbol_search_name): Rename to...
1675         (general_symbol_info::search_name): ...this.
1676         (symbol_matches_search_name): Update.
1677         (find_pc_sect_line): Update.
1678         (skip_prologue_sal): Update.
1679         (search_symbols): Update.
1680         (print_msymbol_info): Update.
1681         (rbreak_command): Update.
1682         (completion_list_add_msymbol): Update.
1683         (completion_list_objc_symbol): Update.
1684         (get_msymbol_address): Update.
1685         * symtab.h (struct general_symbol_info): Add member functions
1686         natural_name (), linkage_name (), print_name (), demangled_name (),
1687         and search_name ().
1688         (SYMBOL_NATURAL_NAME): Update.
1689         (symbol_natural_name): Move to a member function on general_symbol_info.
1690         (SYMBOL_DEMANGLED_NAME): Update.
1691         (symbol_demangled_name): Move to a member function on
1692         general_symbol_info.
1693         (SYMBOL_SEARCH_NAME): Update.
1694         (symbol_search_name): Move to a member function on general_symbol_info.
1695         (MSYMBOL_NATURAL_NAME): Remove.
1696         (MSYMBOL_LINKAGE_NAME): Remove.
1697         (MSYMBOL_PRINT_NAME): Remove.
1698         (MSYMBOL_DEMANGLED_NAME): Remove.
1699         (MSYMBOL_SEARCH_NAME): Remove.
1700         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1701
1702 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1703
1704         * symtab.c (create_demangled_names_hash): Use per_bfd->
1705         minimal_symbol_count for computing the initial size, if greater
1706         than our default size.
1707
1708 2019-11-22  Tom de Vries  <tdevries@suse.de>
1709
1710         * contrib/words.sh: Improve words extraction.
1711
1712 2019-11-22  Tom de Vries  <tdevries@suse.de>
1713
1714         * contrib/words.sh: Combine sed invocations.
1715
1716 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
1717
1718         * Makefile.in: Update.
1719         * demangle.c: Rename to...
1720         * gdb-demangle.c: ..this.
1721         (is_cplus_marker): Change return type to bool.
1722         (_initialize_demangler): Rename to...
1723         (_initialize_gdb_demangle): ...this.
1724         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1725         * symtab.h (demangle): Remove declaration; instead include
1726         gdb-demangle.h.
1727
1728 2019-11-21  Tom Tromey  <tromey@adacore.com>
1729
1730         * gdbsupport/format.c (format_pieces): Parse %I64d.
1731         * unittests/format_pieces-selftests.c (test_windows_formats): New
1732         function.
1733         (run_tests): Call it.
1734
1735 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
1736
1737         Byte reverse display of variables with DW_END_big, DW_END_little
1738         (DW_AT_endianity) dwarf attributes if different than the native
1739         byte order.
1740         * ada-lang.c (ada_value_binop):
1741         Use type_byte_order instead of gdbarch_byte_order.
1742         * ada-valprint.c (printstr):
1743         (ada_val_print_string):
1744         * ada-lang.c (value_pointer):
1745         (ada_value_binop):
1746         Use type_byte_order instead of gdbarch_byte_order.
1747         * c-lang.c (c_get_string):
1748         Use type_byte_order instead of gdbarch_byte_order.
1749         * c-valprint.c (c_val_print_array):
1750         Use type_byte_order instead of gdbarch_byte_order.
1751         * cp-valprint.c (cp_print_class_member):
1752         Use type_byte_order instead of gdbarch_byte_order.
1753         * dwarf2loc.c (rw_pieced_value):
1754         Use type_byte_order instead of gdbarch_byte_order.
1755         * dwarf2read.c (read_base_type): Handle DW_END_big,
1756         DW_END_little
1757         * f-lang.c (f_get_encoding):
1758         Use type_byte_order instead of gdbarch_byte_order.
1759         * findvar.c (default_read_var_value):
1760         Use type_byte_order instead of gdbarch_byte_order.
1761         * gdbtypes.c (check_types_equal):
1762         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1763         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1764         and TYPE_ENDIANITY_LITTLE if set.
1765         (type_byte_order): new function.
1766         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1767         (struct main_type) <flag_endianity_not_default>:
1768         New field.
1769         (type_byte_order): New function.
1770         * infcmd.c (default_print_one_register_info):
1771         Use type_byte_order instead of gdbarch_byte_order.
1772         * p-lang.c (pascal_printstr):
1773         Use type_byte_order instead of gdbarch_byte_order.
1774         * p-valprint.c (pascal_val_print):
1775         Use type_byte_order instead of gdbarch_byte_order.
1776         * printcmd.c (print_scalar_formatted):
1777         Use type_byte_order instead of gdbarch_byte_order.
1778         * solib-darwin.c (darwin_current_sos):
1779         Use type_byte_order instead of gdbarch_byte_order.
1780         * solib-svr4.c (solib_svr4_r_ldsomap):
1781         Use type_byte_order instead of gdbarch_byte_order.
1782         * stap-probe.c (stap_modify_semaphore):
1783         Use type_byte_order instead of gdbarch_byte_order.
1784         * target-float.c (target_float_same_format_p):
1785         Use type_byte_order instead of gdbarch_byte_order.
1786         * valarith.c (scalar_binop):
1787         (value_bit_index):
1788         Use type_byte_order instead of gdbarch_byte_order.
1789         * valops.c (value_cast):
1790         Use type_byte_order instead of gdbarch_byte_order.
1791         * valprint.c (generic_emit_char):
1792         (generic_printstr):
1793         (val_print_string):
1794         Use type_byte_order instead of gdbarch_byte_order.
1795         * value.c (unpack_long):
1796         (unpack_bits_as_long):
1797         (unpack_value_bitfield):
1798         (modify_field):
1799         (pack_long):
1800         (pack_unsigned_long):
1801         Use type_byte_order instead of gdbarch_byte_order.
1802         * findvar.c (unsigned_pointer_to_address):
1803         (signed_pointer_to_address):
1804         (unsigned_address_to_pointer):
1805         (address_to_signed_pointer):
1806         (default_read_var_value):
1807         (default_value_from_register):
1808         Use type_byte_order instead of gdbarch_byte_order.
1809         * gnu-v3-abi.c (gnuv3_make_method_ptr):
1810         Use type_byte_order instead of gdbarch_byte_order.
1811         * riscv-tdep.c (riscv_print_one_register_info):
1812         Use type_byte_order instead of gdbarch_byte_order.
1813
1814 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
1815
1816         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1817         (current_ui_gdb_stdin_ptr): Likewise.
1818         (current_ui_gdb_stderr_ptr): Likewise.
1819         (current_ui_gdb_stdlog_ptr): Likewise.
1820         (current_ui_current_uiout_ptr): Likewise.
1821         (gen_ret_current_ui_field_ptr): Remove.
1822
1823 2019-11-21  Tom de Vries  <tdevries@suse.de>
1824
1825         PR gdb/24956
1826         * cli/cli-script.c (execute_control_command): Only switch to
1827         INTERP_CONSOLE's ui_out when INTERP_MI is active.
1828
1829 2019-11-19  Tom Tromey  <tom@tromey.com>
1830
1831         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1832         Now static.  Change type of "name".
1833         (tui_set_win_height_command): Don't copy "arg".
1834         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1835         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1836
1837 2019-11-19  Ali Tamur <tamur@google.com>
1838
1839         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1840         "if (attr != nullptr)".
1841         (dwarf2_find_base_address): Likewise.
1842         (dwarf2_build_include_psymtabs): Likewise.
1843         (read_cutu_die_from_dwo): Likewise.
1844         (read_func_scope): Likewise.
1845         (read_call_site_scope): Likewise.
1846         (dwarf2_get_pc_bounds): Likewise.
1847         (dwarf2_record_block_ranges): Likewise.
1848         (dwarf2_add_field): Likewise.
1849         (dwarf2_add_member_fn): Likewise.
1850         (read_structure_type): Likewise.
1851         (read_enumeration_type): Likewise.
1852         (read_array_type): Likewise.
1853         (read_array_order): Likewise.
1854         (read_set_type): Likewise.
1855         (read_common_block): Likewise.
1856         (read_tag_reference_type): Likewise.
1857         (read_tag_string_type): Likewise.
1858         (read_subroutine_type): Likewise.
1859         (read_base_type): Likewise.
1860         (read_subrange_type): Likewise.
1861         (new_symbol): Likewise.
1862         (prepare_one_comp_unit): Likewise.
1863
1864 2019-11-19  Tom Tromey  <tromey@adacore.com>
1865
1866         * windows-nat.c (windows_nat_target::attach): Include GetLastError
1867         result in error when DebugActiveProcess fails.
1868
1869 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
1870             Pedro Alves  <palves@redhat.com>
1871
1872         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1873         * target.c (target_stack::push): Call 'unpush' if there's a
1874         target on top of the stack.
1875
1876 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1877
1878         * python/py-block.c (blpy_dealloc): Call tp_free.
1879         (blpy_block_syms_dealloc): Likewise.
1880         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1881         * python/py-inferior.c (infpy_dealloc): Likewise.
1882         * python/py-lazy-string.c (stpy_dealloc): Likewise.
1883         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1884         * python/py-symbol.c (sympy_dealloc): Likewise.
1885         * python/py-symtab.c (stpy_dealloc): Likewise.
1886         * python/py-type.c (typy_iterator_dealloc): Likewise.
1887
1888 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
1889
1890         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1891         constructor instead of using a class initializer.
1892
1893 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1894
1895         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1896         * configure: Regenerate.
1897         * configure.ac: Don't source common.host.
1898         * gdbsupport/common.host: Remove.
1899         * gdbsupport/mingw-strerror.c: Remove.
1900         * gdbsupport/posix-strerror.c: Rename to...
1901         * gdbsupport/safe-strerror.c: ...this.
1902
1903 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1904
1905         * maint.c (scoped_command_stats::print_time): Use localtime_r
1906         instead of localtime (provided through gnulib if necessary).
1907         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1908         of ctime.
1909
1910 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1911
1912         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1913         avoid compile errors.
1914
1915 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1916
1917         * config.in: Regenerate.
1918         * configure: Regenerate.
1919         * gdbsupport/common.m4: No longer check for strerror_r.
1920         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1921         POSIX version of strerror_r, now that gnulib provides it if
1922         necessary.
1923
1924 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
1925
1926         * README (`configure' options): Update.
1927
1928 2019-11-14  Tom Tromey  <tromey@adacore.com>
1929
1930         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1931         expected type for the RHS if the LHS is a convenience variable.
1932
1933 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
1934
1935         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1936         Provide explicit default and copy constructor.
1937
1938 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1939
1940         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1941         only call Py_INCREF (newbp) in the bppy_pending_object case.
1942
1943 2019-11-13  Tom Tromey  <tromey@adacore.com>
1944
1945         PR build/25182:
1946         * psympriv.h (partial_symbol): Remove static assert.
1947         * symtab.h (general_symbol_info, symbol): Remove static assert.
1948
1949 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1950
1951         * gdbsupport/format.c (format_pieces::format_pieces): Support
1952         printf 'z' size modifier.
1953         * gdbsupport/format.h (enum argclass): Add size_t_arg.
1954         * printcmd.c (ui_printf):  Handle size_t_arg.
1955         * ui-out.c (ui_out::vmessage): Likewise.
1956         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1957         function.
1958         (run_tests): Call test_format_int_sizes.
1959
1960 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
1961
1962         * ada-exp.y (write_ambiguous_var): Update.
1963         * buildsym.c (add_symbol_to_list): Update.
1964         * dwarf2read.c (read_variable): Update.
1965         (new_symbol): Update.
1966         * jit.c (finalize_symtab): Update.
1967         * language.c (language_alloc_type_symbol): Update.
1968         * symtab.c (fixup_symbol_section): Update.
1969         (initialize_objfile_symbol_1): Move code to...
1970         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1971         (allocate_symbol): Update.
1972         (allocate_template_symbol): Update.
1973         (get_symbol_address): Update.
1974         * symtab.h (struct symbol): Inherit from general_symbol_info instead
1975         of having as a field, and add a constructor.
1976         (SYMBOL_VALUE): Update.
1977         (SYMBOL_VALUE_ADDRESS): Update.
1978         (SET_SYMBOL_VALUE_ADDRESS): Update.
1979         (SYMBOL_VALUE_BYTES): Update.
1980         (SYMBOL_VALUE_COMMON_BLOCK): Update.
1981         (SYMBOL_BLOCK_VALUE): Update.
1982         (SYMBOL_VALUE_CHAIN): Update.
1983         (SYMBOL_LANGUAGE): Update.
1984         (SYMBOL_SECTION): Update.
1985         (SYMBOL_OBJ_SECTION): Update.
1986         (SYMBOL_SET_LANGUAGE): Update.
1987         (SYMBOL_SET_LINKAGE_NAME): Update.
1988         (SYMBOL_SET_NAMES): Update.
1989         (SYMBOL_NATURAL_NAME): Update.
1990         (SYMBOL_LINKAGE_NAME): Update.
1991         (SYMBOL_DEMANGLED_NAME): Update.
1992         (SYMBOL_SEARCH_NAME): Update.
1993         (SYMBOL_MATCHES_SEARCH_NAME): Update.
1994         (struct symbol): Update.
1995         (struct template_symbol): Update.
1996         (struct rust_vtable_symbol): Update.
1997         * xcoffread.c (SYMBOL_DUP): Update.
1998
1999 2019-11-12  Tom Tromey  <tom@tromey.com>
2000
2001         * tui/tui-layout.c (show_layout): Set current_layout.
2002         (show_source_disasm_command, show_data)
2003         (show_source_or_disasm_and_command): Don't set current_layout.
2004
2005 2019-11-12  Tom Tromey  <tom@tromey.com>
2006
2007         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2008
2009 2019-11-12  Tom Tromey  <tom@tromey.com>
2010
2011         * tui/tui-win.c (resize_message): New global.
2012         (show_tui_resize_message): New function.
2013         (tui_async_resize_screen): Print message if requested.
2014         (_initialize_tui_win): Add tui-resize-message setting.
2015         * NEWS: Add entry for new commands.
2016
2017 2019-11-11  Tom Tromey  <tom@tromey.com>
2018
2019         * tui/tui.c (tui_initialize_readline): Add new bindable readline
2020         functions.
2021
2022 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
2023
2024         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2025
2026 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2027
2028         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2029         function.
2030         * python/python-internal.h (gdbpy_lookup_static_symbols):
2031         Declare new function.
2032         * python/python.c (python_GdbMethods): Add
2033         gdb.lookup_static_symbols method.
2034         * NEWS: Mention gdb.lookup_static_symbols.
2035
2036 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2037
2038         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2039         static block of current object file first.  Also fix typo in
2040         header comment.
2041
2042 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2043
2044         * stack.c (set_last_displayed_sal): Delete.
2045         (last_displayed_sal_valid): Delete.
2046         (last_displayed_pspace): Delete.
2047         (last_displayed_addr): Delete.
2048         (last_displayed_symtab): Delete.
2049         (last_displayed_line): Delete.
2050         (class last_displayed_symtab_info_type): New.
2051         (last_displayed_symtab_info): New static global variable.
2052         (print_frame_info): Call methods on last_displayed_symtab_info.
2053         (clear_last_displayed_sal): Update header comment, and make use of
2054         last_displayed_symtab_info.
2055         (last_displayed_sal_is_valid): Likewise.
2056         (get_last_displayed_pspace): Likewise.
2057         (get_last_displayed_addr): Likewise.
2058         (get_last_displayed_symtab): Likewise.
2059         (get_last_displayed_line): Likewise.
2060         (get_last_displayed_sal): Likewise.
2061         * stack.h (clear_last_displayed_sal): Update header comment.
2062         (last_displayed_sal_is_valid): Likewise.
2063         (get_last_displayed_pspace): Likewise.
2064         (get_last_displayed_addr): Likewise.
2065         (get_last_displayed_symtab): Likewise.
2066         (get_last_displayed_line): Likewise.
2067         (get_last_displayed_sal): Likewise.
2068
2069 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2070
2071         * stack.c (frame_show_address): Convert return type to bool.
2072         * stack.h (frame_show_address): Likewise, and update header
2073         comment.
2074
2075 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2076
2077         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2078         * unittests/vec-utils-selftests.c: New file.
2079         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2080
2081 2019-11-10  Tom Tromey  <tom@tromey.com>
2082
2083         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2084         (tui_highlight_win): Likewise.
2085         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2086         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2087         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2088         Don't set can_highlight.
2089
2090 2019-11-10  Tom Tromey  <tom@tromey.com>
2091
2092         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2093         Remove unused declaration.
2094
2095 2019-11-08  Tom Tromey  <tromey@adacore.com>
2096
2097         * top.c (read_command_file): Update.
2098         (command_line_input): Make return type const.
2099         * python/py-gdb-readline.c: Update.
2100         * linespec.c (decode_line_2): Update.
2101         * defs.h (command_line_input): Make return type const.
2102         * cli/cli-script.c (read_next_line): Make return type const.
2103         * ada-lang.c (get_selections): Update.
2104
2105 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
2106
2107         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2108         * mi/mi-main.c (output_cores): Likewise.
2109         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2110         (linux_xfer_osdata_modules): Likewise.
2111         * remote.c (register_remote_support_xml): Likewise.
2112         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2113         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2114
2115 2019-11-06  Tom Tromey  <tom@tromey.com>
2116
2117         * tui/tui-interp.c: Don't include readline.h.
2118         * tui/tui-hooks.c: Don't include readline.h.
2119         * symmisc.c: Include tilde.h, not readline.h.
2120         * symfile.c: Include tilde.h, not readline.h.
2121         * source.c: Include tilde.h, not readline.h.
2122         * solib.c: Include tilde.h, not readline.h.
2123         * psymtab.c: Include tilde.h, not readline.h.
2124         * exec.c: Include tilde.h, not readline.h.
2125         * corelow.c: Include tilde.h, not readline.h.
2126         * cli/cli-dump.c: Include tilde.h, not readline.h.
2127         * cli/cli-cmds.c: Don't include readline.h.
2128
2129 2019-11-05  Tom Tromey  <tom@tromey.com>
2130
2131         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2132         (tui_disassemble): Set addr_size.
2133         (tui_disasm_window::set_contents): Use addr_size.
2134
2135 2019-11-05  Tom Tromey  <tom@tromey.com>
2136
2137         * rust-lang.c (rust_language_defn): Update.
2138         * python/py-value.c (valpy_string): Call c_get_string.
2139         * p-lang.c (pascal_language_defn): Update.
2140         * opencl-lang.c (opencl_language_defn): Update.
2141         * objc-lang.c (objc_language_defn): Update.
2142         * m2-lang.c (m2_language_defn): Update.
2143         * language.c (unknown_language_defn, auto_language_defn): Update.
2144         (default_get_string): Remove.
2145         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2146         * go-lang.c (go_language_defn): Update.
2147         * f-lang.c (f_language_defn): Update.
2148         * d-lang.c (d_language_defn): Update.
2149         * c-lang.c (c_language_defn, cplus_language_defn)
2150         (asm_language_defn, minimal_language_defn): Update.
2151         * ada-lang.c (ada_language_defn): Update.
2152         * language.h (struct language_defn) <la_get_string>: Remove.
2153         (LA_GET_STRING): Remove.
2154         (default_get_string): Don't declare.
2155
2156 2019-11-05  Tom Tromey  <tom@tromey.com>
2157
2158         * tui/tui-source.h (struct tui_source_window): Inline
2159         constructor.  Remove destructor.
2160         <style_changed, m_observable>: Move to superclass.
2161         * tui/tui-winsource.h (tui_copy_source_line): Declare.
2162         (struct tui_source_window_base): Move private members to end.
2163         <style_changed, m_observable>: Move from tui_source_window.
2164         * tui/tui-winsource.c (tui_copy_source_line): Move from
2165         tui-source.c.  Rename from copy_source_line.  Add special handling
2166         for negative line number.
2167         (tui_source_window_base::style_changed): Move from
2168         tui_source_window.
2169         (tui_source_window_base): Register observer.
2170         (~tui_source_window_base): New.
2171         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2172         rename.
2173         (tui_source_window::set_contents): Use tui_copy_source_line.
2174         (tui_source_window::tui_source_window): Move to tui-source.h.
2175         (tui_source_window::~tui_source_window): Remove.
2176         (tui_source_window::style_changed): Move to superclass.
2177         * tui/tui-disasm.c (tui_disassemble): Create string file with
2178         styling, when possible.  Add "addr_size" parameter.
2179         (tui_disasm_window::set_contents): Use tui_copy_source_line.
2180         Don't compute maximum size.
2181         (len_without_escapes): New function
2182
2183 2019-11-05  Tom Tromey  <tom@tromey.com>
2184
2185         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2186         std::string.
2187         * tui/tui-winsource.c (tui_show_source_line): Update.
2188         * tui/tui-source.c (tui_source_window::set_contents): Update.
2189         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2190
2191 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
2192
2193         * symtab.h (gdb_static_assert): Put && operator at the beginning
2194         of the line instead of the end.
2195
2196 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
2197
2198         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2199         and sizeof (symbol).
2200         * symtab.h: Add a static_assert for sizeof (partial_symbol).
2201
2202 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2203
2204         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2205         * configure.host: Mark *-*-solaris2.10* obsolete.
2206         * configure.tgt: Mark Solaris < 11 obsolete.
2207         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2208         Update target triplet.
2209
2210 2019-11-01  Tom Tromey  <tromey@adacore.com>
2211
2212         * utils.c (print_sys_errmsg): Simplify.
2213
2214 2019-11-01  Tom Tromey  <tromey@adacore.com>
2215
2216         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2217
2218 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
2219
2220         * configure: Regenerate.
2221         * configure.ac: Remove check for strerror_r.
2222         * gdbsupport/common.m4: Check for strerror_r.
2223
2224 2019-11-01  Luis Machado  <luis.machado@linaro.org>
2225
2226         PR gdb/25124
2227
2228         * arm-tdep.c (arm_per_objfile): Rename to ...
2229         (arm_per_bfd): ... this.
2230         (arm_objfile_data_key): Rename to ...
2231         (arm_bfd_data_key): ... this.
2232         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2233         data.
2234         (arm_record_special_symbol): Likewise.
2235
2236 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2237
2238         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2239         end.
2240         * c-typeprint.c (c_print_typedef): Likewise.
2241         * f-typeprint.c (f_print_typedef): Likewise.
2242         * m2-typeprint.c (m2_print_typedef): Likewise.
2243         * p-typeprint.c (pascal_print_typedef): Likewise.
2244         * rust-lang.c (rust_print_typedef): Likewise.
2245         * symtab.c (print_symbol_info): Print a newline after calling
2246         typedef_print.
2247
2248 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2249
2250         * symtab.c (info_module_cmdlist): New variable.
2251         (info_module_command): New function.
2252         (search_module_symbols): New function.
2253         (info_module_subcommand): New function.
2254         (struct info_modules_var_func_options): New struct.
2255         (info_modules_var_func_options_defs): New variable.
2256         (make_info_modules_var_func_options_def_group): New function.
2257         (info_module_functions_command): New function.
2258         (info_module_variables_command): New function.
2259         (info_module_var_func_command_completer): New function.
2260         (_initialize_symtab): Register new 'info module functions' and
2261         'info module variables' commands.
2262         * symtab.h (typedef symbol_search_in_module): New typedef.
2263         (search_module_symbols): Declare new function.
2264         * NEWS: Mention new commands.
2265
2266 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2267
2268         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2269         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2270         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2271         MODULES_DOMAIN.
2272         (scan_partial_symbols): Only create partial module symbols for non
2273         declarations.
2274         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2275         and MODULES_DOMAIN.
2276         * symtab.c (search_domain_name): Likewise.
2277         (search_symbols): Likewise.
2278         (print_symbol_info): Likewise.
2279         (symtab_symbol_info): Likewise.
2280         (info_modules_command): New function.
2281         (_initialize_symtab): Register 'info modules' command.
2282         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2283         * NEWS: Mention new 'info modules' command.
2284
2285 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2286
2287         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2288         and $_gdb_maint_setting_str.
2289
2290 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2291
2292         * cli/cli-cmds.c (setting_cmd, value_from_setting)
2293         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2294         (str_value_from_setting, gdb_setting_str_internal_fn)
2295         (gdb_maint_setting_str_internal_fn): New functions.
2296         (_initialize_cli_cmds): Define the new convenience functions.
2297         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2298         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2299
2300 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2301
2302         * agent.c (set_can_use_agent): When the setting is turned on,
2303         look up agent symbols if we don't have them yet.
2304         (agent_new_objfile): Don't look up agent symbols when the agent
2305         setting is off.
2306
2307 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2308
2309         * config.in: Regenerate.
2310
2311 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2312
2313         * configure: Regenerate.
2314         * configure.ac: Check for strerror_r.
2315         * gdbsupport/common-utils.h (safe_strerror): Change return value
2316         to const char * and document that this function is now threadsafe.
2317         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2318         thread_local and call strerror_r, if available.
2319         * utils.c (perror_string): Update.
2320         (print_sys_errmsg): Update.
2321
2322 2019-10-31  Luis Machado  <luis.machado@linaro.org>
2323
2324         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2325         objfile_key.
2326         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2327         objfile to fetch per-bfd data.
2328         (arm_find_exidx_entry): Likewise.
2329
2330 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2331
2332         * gdbsupport/agent.c (debug_agent): Change type to bool.
2333         (use_agent): Likewise.
2334         (all_agent_symbols_look_up): Likewise.
2335         (agent_loaded_p): Change return value to bool.
2336         (agent_look_up_symbols): Update.
2337         (agent_capability_check): Change return value to bool.
2338         * gdbsupport/agent.h (agent_loaded_p): Likewise.
2339         (debug_agent): Change type to bool.
2340         (use_agent): Likewise.
2341         (agent_capability_check): Change return value to bool.
2342
2343 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
2344
2345         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2346         (build_minimal_symbol_hash_tables): Code to clear the table moved
2347         to clear_minimal_symbol_hash_tables.
2348         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2349         when needed.
2350
2351 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2352
2353         * infcmd.c: Remove includes.
2354         * infrun.c: Remove includes.
2355
2356 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2357
2358         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2359         (grow_vect): Remove declaration.
2360         (ada_type_of_array): Remove declaration.
2361         (ada_update_initial_language): Remove declaration.
2362         (ada_fold_name): Remove declaration.
2363         (ada_fill_in_ada_prototype): Remove declaration.
2364         (user_select_syms): Remove declaration.
2365         (get_selections): Remove declaration.
2366         (ada_tag_type): Remove declaration.
2367         (ada_value_tag): Remove declaration.
2368         (ada_is_others_clause): Remove declaration.
2369         (ada_in_variant): Remove declaration.
2370         (ada_value_struct_elt): Remove declaration.
2371         (ada_attribute_name): Remove declaration.
2372         (ada_system_address_type): Remove declaration.
2373         * ada-lang.c (ada_watch_location_expression): Make static.
2374         (GROW_VECT): Move here from ada-lang.h.
2375         (grow_vect): Make static.
2376         (ada_update_initial_language): Make static.
2377         (ada_fold_name): Make static.
2378         (ada_type_of_array): Make static.
2379         (encoded_ordered_before): Move up.
2380         (sort_choices): Move up.
2381         (print_signatures): Move up.
2382         (ada_print_symbol_signature): Move up.
2383         (get_selections): Move up and make static.
2384         (user_select_syms): Move up and make static.
2385         (ada_value_struct_elt): Move up and make static.
2386         (ada_tag_type): Make static.
2387         (ada_value_tag): Make static.
2388         (ada_is_others_clause): Make static.
2389         (ada_in_variant): Make static.
2390         (ada_attribute_name): Make static.
2391
2392 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2393
2394         * ada-lang.c: Remove includes.
2395         * ada-typeprint.c: Remove includes.
2396         * ada-valprint.c: Remove includes.
2397
2398 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
2399
2400         * addrmap.c: Add static assertions of type size, moved from
2401         _initialize_addrmap.
2402         (_initialize_addrmap): Remove.
2403
2404 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2405
2406         * coffread.c (record_minimal_symbol): Update.
2407         (process_coff_symbol): Update.
2408         * dbxread.c (read_dbx_symtab): Update.
2409         * dwarf2read.c (add_partial_symbol): Update.
2410         (fixup_go_packaging): Update.
2411         (load_partial_dies): Update.
2412         (new_symbol): Update.
2413         * elfread.c (record_minimal_symbol): Change signature to use
2414         gdb::string_view instead of name+len.
2415         (elf_symtab_read): Update.
2416         (elf_rel_plt_read): Update.
2417         * mdebugread.c (parse_partial_symbols): Update.
2418         (handle_psymbol_enumerators): Update.
2419         (new_symbol): Update.
2420         * minsyms.c (minimal_symbol_reader::record_full): Change signature
2421         to use gdb::string_view instead of name+len.
2422         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2423         * psympriv.h (add_psymbol_to_list): Likewise.
2424         * psymtab.c (add_psymbol_to_bcache): Likewise.
2425         (add_psymbol_to_list): Likewise.
2426         * stabsread.c (define_symbol): Update.
2427         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2428         * symtab.h (SYMBOL_SET_NAMES): Likewise.
2429         (symbol_set_names): Likewise.
2430         * xcoffread.c (scan_xcoff_symtab): Update.
2431
2432 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2433
2434         * symtab.h (symbol_set_names): Document that copy_name must be
2435         set to true for non-nullterminated strings.
2436         * symtab.c (symbol_set_names): Only make a nullterminated copy of
2437         linkage_name if the entry was not found and we need to demangle.
2438
2439 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2440
2441         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2442         * dwarf2-frame.c (bsearch_fde_cmp): Update.
2443         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2444         * gdbsupport/gdb_binary_search.h: New file.
2445
2446 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2447
2448         * NEWS: Mention new --with-system-gdbinit-dir option.
2449         * config.in: Regenerate.
2450         * configure: Regenerate.
2451         * configure.ac: Add new option --with-system-gdbinit-dir.
2452         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2453         for a ".gdb" suffix.
2454         * main.c (get_init_files): Change system_gdbinit argument to
2455         a vector and return the files in SYSTEM_GDBINIT_DIR in
2456         addition to SYSTEM_GDBINIT.
2457         (captured_main_1): Update.
2458         (print_gdb_help): Update.
2459         * top.c (print_gdb_configuration): Also print the value of
2460         SYSTEM_GDBINIT_DIR.
2461
2462 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
2463
2464         * gdbsupport/common-utils.h (startswith): Add an overloaded version
2465         that takes gdb::string_view arguments.
2466
2467 2019-10-26  Tom de Vries  <tdevries@suse.de>
2468
2469         * aarch64-linux-tdep.c: Fix typos in comments.
2470         * aarch64-tdep.c: Same.
2471         * ada-lang.c: Same.
2472         * amd64-nat.c: Same.
2473         * arc-tdep.c: Same.
2474         * arch/aarch64-insn.c: Same.
2475         * block.c: Same.
2476         * breakpoint.h: Same.
2477         * btrace.h: Same.
2478         * c-varobj.c: Same.
2479         * cli/cli-decode.c: Same.
2480         * cli/cli-script.c: Same.
2481         * cli/cli-utils.h: Same.
2482         * coff-pe-read.c: Same.
2483         * coffread.c: Same.
2484         * compile/compile-cplus-symbols.c: Same.
2485         * compile/compile-object-run.c: Same.
2486         * completer.c: Same.
2487         * corelow.c: Same.
2488         * cp-support.c: Same.
2489         * demangle.c: Same.
2490         * dwarf-index-write.c: Same.
2491         * dwarf2-frame.c: Same.
2492         * dwarf2-frame.h: Same.
2493         * eval.c: Same.
2494         * frame-base.h: Same.
2495         * frame.h: Same.
2496         * gdbcmd.h: Same.
2497         * gdbtypes.h: Same.
2498         * gnu-nat.c: Same.
2499         * guile/scm-objfile.c: Same.
2500         * i386-tdep.c: Same.
2501         * i386-tdep.h: Same.
2502         * infcall.c: Same.
2503         * infcall.h: Same.
2504         * linux-nat.c: Same.
2505         * m68k-tdep.c: Same.
2506         * macroexp.c: Same.
2507         * memattr.c: Same.
2508         * mi/mi-cmd-disas.c: Same.
2509         * mi/mi-getopt.h: Same.
2510         * mi/mi-main.c: Same.
2511         * minsyms.c: Same.
2512         * nat/aarch64-sve-linux-sigcontext.h: Same.
2513         * objfiles.h: Same.
2514         * ppc-linux-nat.c: Same.
2515         * ppc-linux-tdep.c: Same.
2516         * ppc-tdep.h: Same.
2517         * progspace.h: Same.
2518         * prologue-value.h: Same.
2519         * python/py-evtregistry.c: Same.
2520         * python/py-instruction.h: Same.
2521         * record-btrace.c: Same.
2522         * record-full.c: Same.
2523         * remote.c: Same.
2524         * rs6000-tdep.c: Same.
2525         * ser-tcp.c: Same.
2526         * sol-thread.c: Same.
2527         * sparc-sol2-tdep.c: Same.
2528         * sparc64-tdep.c: Same.
2529         * stabsread.c: Same.
2530         * symfile.c: Same.
2531         * symtab.h: Same.
2532         * target.c: Same.
2533         * tracepoint.c: Same.
2534         * tui/tui-data.h: Same.
2535         * tui/tui-io.c: Same.
2536         * tui/tui-win.c: Same.
2537         * tui/tui.c: Same.
2538         * unittests/rsp-low-selftests.c: Same.
2539         * user-regs.h: Same.
2540         * utils.c: Same.
2541         * utils.h: Same.
2542         * valarith.c: Same.
2543         * valops.c: Same.
2544         * valprint.c: Same.
2545         * valprint.h: Same.
2546         * value.c: Same.
2547         * value.h: Same.
2548         * varobj.c: Same.
2549         * x86-nat.h: Same.
2550         * xtensa-tdep.c: Same.
2551
2552 2019-10-25  Ali Tamur <tamur@google.com>
2553
2554         * charset.c (find_charset_names): Reflect API change.
2555
2556 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
2557
2558         * symtab.c (struct demangled_name_entry): Change demangled name
2559         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2560         part of the struct anymore.
2561         (symbol_set_names): No longer obstack allocate + copy the demangled
2562         name, just store the allocated name from bfd.
2563
2564 2019-10-25  Tom Tromey  <tromey@adacore.com>
2565
2566         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2567         (bsearch_cie_cmp, add_cie): Remove.
2568         (find_cie): Reimplement.
2569         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
2570         (dwarf2_build_frame_info): Update.
2571
2572 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
2573
2574         PR gdb/25126
2575         * symfile.c (reread_symbols): Call forget_cached_source_info to
2576         clear the stale source cache.
2577
2578 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2579
2580         * configure: Regenerate.
2581         * configure.ac: Remove code that sets python_has_threads.
2582
2583 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2584
2585         * config.in: Regenerate.
2586         * configure: Regenerate.
2587         * configure.ac: Remove the code that uses sed to get the python
2588         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2589
2590 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2591
2592         * python/py-progspace.c (pspy_block_for_pc): Return None for all
2593         error paths.
2594
2595 2019-10-23  Tom Tromey  <tom@tromey.com>
2596
2597         * arc-tdep.c: Remove ".." from include.
2598         * frv-tdep.c: Remove ".." from include.
2599         * lm32-tdep.c: Remove ".." from include.
2600         * microblaze-tdep.c: Remove ".." from include.
2601         * or1k-tdep.h: Remove ".." from include.
2602         * s12z-tdep.c: Remove ".." from include.
2603         * Makefile.in (OPCODES_CFLAGS): Add comment.
2604         (TOP_CFLAGS): New variable.
2605         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2606
2607 2019-10-23  Tom Tromey  <tom@tromey.com>
2608
2609         * Makefile.in (READLINE_DIR): Update.
2610
2611 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2612
2613         * infcall.c (call_function_by_hand_dummy): Fix the function
2614         comment.  And extract out a code section into...
2615         (reserve_stack_space): ...this new function.
2616
2617 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2618
2619         * infcall.c (value_arg_coerce): Remove an unused parameter.
2620         (call_function_by_hand_dummy): Update the call to
2621         'value_arg_coerce'.
2622
2623 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2624
2625         * infcall.c (call_function_by_hand_dummy): Refactor.
2626
2627 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2628
2629         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2630
2631 2019-10-23  Tom Tromey  <tom@tromey.com>
2632
2633         * configure: Rebuild.
2634         * configure.ac: Don't check for sigprocmask.
2635         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2636
2637 2019-10-23  Tom Tromey  <tom@tromey.com>
2638
2639         * configure: Rebuild.
2640         * acinclude.m4: Use m4_include, not sinclude.
2641
2642 2019-10-23  Tom de Vries  <tdevries@suse.de>
2643
2644         PR breakpoints/24687
2645         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2646
2647 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2648
2649         * symtab.c (struct demangled_name_entry) <language>: Change from
2650         bitfield to regular variable.
2651
2652 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2653
2654         * symtab.c (struct demangled_name_entry): Add a constructor.
2655         (free_demangled_name_entry): New function to call the destructor
2656         for demangled_name_entry.
2657         (create_demangled_names_hash): Pass free_demangled_name_entry to
2658         htab_create_alloc.
2659         (symbol_set_names): Call placement new for demangled_name_entry.
2660         * utils.c: No longer include xxhash.h here, now that fast_hash
2661         is inlined in the header.
2662         * utils.h: Instead, include it here.
2663
2664 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2665
2666         * Makefile.in: Link with libxxhash.
2667         * config.in: Regenerate.
2668         * configure: Regenerate.
2669         * configure.ac: Search for libxxhash.
2670         * utils.c (fast_hash): Use xxhash if present.
2671
2672 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2673
2674         * utils.h (fast_hash): New function.
2675         * symtab.c (hash_demangled_name_entry): Call new function
2676         fast_hash.
2677
2678 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2679
2680         * symtab.c (struct demangled_name_entry): Change type of mangled
2681         to gdb::string_view. Also adds a constructor that takes the
2682         mangled name.
2683         (hash_demangled_name_entry): Update.
2684         (eq_demangled_name_entry): Update.
2685         (free_demangled_name_entry): New function to call the destructor
2686         now that this is not a POD anymore.
2687         (create_demangled_names_hash): Pass free_demangled_name_entry to
2688         htab_create_alloc.
2689         (symbol_set_names): Update.
2690
2691 2019-10-21  Ali Tamur  <tamu@google.com>
2692
2693         * dwarf2read.c (dir_index): Change type.
2694         (file_name_index): Likewise.
2695         (line_header::include_dir_at): Change comment and implementation on
2696         whether it is DWARF 5.
2697         (line_header::is_valid_file_index): New function.
2698         (line_header::file_name_at): Change comment and implementation on
2699         whether it is DWARF 5.
2700         (line_header::file_names): Change to private field renamed as
2701         m_file_names and introduce a new accessor method.
2702         (line_header::file_names_size): New method.
2703         (line_header::include_dirs): Change to private field and rename as
2704         m_include_dirs.
2705         (dw2_get_file_names_reader): Define local var at a smaller scope and
2706         reflect API change.
2707         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2708         (process_structure_scope): Likewise.
2709         (line_header::add_include_dir): Change message and reflect renaming.
2710         (line_header::add_file_name): Likewise.
2711         (read_formatted_entries): Handle DW_FORM_data16.
2712         (dwarf_decode_line_header): Fix line header length calculation.
2713         (psymtab_include_file_name): Change comment and API.
2714         (lnp_state_machine::m_file): Update comment and reflect type change.
2715         (lnp_state_machine::record_line): Reflect type change.
2716         (dwarf_decode_lines): Reflect API change.
2717         (file_file_name): Likewise.
2718         (file_full_name): Likewise.
2719
2720 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2721
2722         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2723
2724 2019-10-21  Tom Tromey  <tom@tromey.com>
2725
2726         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2727
2728 2019-10-21  Tom Tromey  <tom@tromey.com>
2729
2730         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
2731         NM_H.   Use AC_CONFIG_LINKS.
2732         * configure: Rebuild.
2733         * Makefile.in (NM_H): New variable.
2734         (generated_files): Add NM_H.  Remove gcore.
2735         (nm.h, stamp-nmh): New targets.
2736
2737 2019-10-20  Tom Tromey  <tom@tromey.com>
2738
2739         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2740         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
2741         obsolete comment.
2742         (put_objfile_before): Now static.
2743
2744 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
2745
2746         * gdbsupport/common-utils.h (startswith): Change return type to
2747         bool.
2748
2749 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
2750
2751         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2752         * breakpoint.c (bp_locations_compare): Rename to...
2753         (bp_location_is_less_than): ...this, and change to std::sort semantics.
2754         (update_global_location_list): Use std::sort instead of qsort.
2755         * buildsym.c (compare_line_numbers): Rename to...
2756         (lte_is_less_than): ...this, and change to std::sort semantics.
2757         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2758         instead of qsort.
2759         * disasm.c (compare_lines): Rename to...
2760         (line_is_less_than): ...this, and change to std::sort semantics.
2761         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2762         of qsort.
2763         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2764         (fde_is_less_than): ...this, and change to std::sort semantics.
2765         (dwarf2_build_frame_info): Call std::sort instead of qsort.
2766         * mdebugread.c (compare_blocks):
2767         (block_is_less_than): ...this, and change to std::sort semantics.
2768         (sort_blocks): Call std::sort instead of qsort.
2769         * objfiles.c (qsort_cmp): Rename to...
2770         (sort_cmp): ...this, and change to std::sort semantics.
2771         (update_section_map): Call std::sort instead of qsort.
2772         * remote.c (compare_pnums): Remove.
2773         (map_regcache_remote_table): Call std::sort instead of qsort.
2774         * utils.c (compare_positive_ints): Remove.
2775         * utils.h (compare_positive_ints): Remove.
2776         * xcoffread.c (compare_lte): Remove.
2777         (arrange_linetable): Call std::sort instead of qsort.
2778
2779 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
2780
2781         * symfile.c (init_entry_point_info): Fix typo.
2782         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2783
2784 2019-10-18  Tom de Vries  <tdevries@suse.de>
2785
2786         * aarch64-tdep.c: Fix typos in comments.
2787         * ada-lang.c: Same.
2788         * ada-tasks.c: Same.
2789         * alpha-tdep.c: Same.
2790         * alpha-tdep.h: Same.
2791         * amd64-nat.c: Same.
2792         * amd64-windows-tdep.c: Same.
2793         * arc-tdep.c: Same.
2794         * arc-tdep.h: Same.
2795         * arch-utils.c: Same.
2796         * arm-nbsd-tdep.c: Same.
2797         * arm-tdep.c: Same.
2798         * ax-gdb.c: Same.
2799         * blockframe.c: Same.
2800         * btrace.c: Same.
2801         * c-varobj.c: Same.
2802         * coff-pe-read.c: Same.
2803         * coffread.c: Same.
2804         * cris-tdep.c: Same.
2805         * darwin-nat.c: Same.
2806         * dbxread.c: Same.
2807         * dcache.c: Same.
2808         * disasm.c: Same.
2809         * dtrace-probe.c: Same.
2810         * dwarf-index-write.c: Same.
2811         * dwarf2-frame-tailcall.c: Same.
2812         * dwarf2-frame.c: Same.
2813         * dwarf2read.c: Same.
2814         * eval.c: Same.
2815         * exceptions.c: Same.
2816         * fbsd-tdep.c: Same.
2817         * findvar.c: Same.
2818         * frame.c: Same.
2819         * frv-tdep.c: Same.
2820         * gnu-v3-abi.c: Same.
2821         * go32-nat.c: Same.
2822         * h8300-tdep.c: Same.
2823         * hppa-tdep.c: Same.
2824         * i386-linux-tdep.c: Same.
2825         * i386-tdep.c: Same.
2826         * ia64-libunwind-tdep.c: Same.
2827         * ia64-tdep.c: Same.
2828         * infcmd.c: Same.
2829         * infrun.c: Same.
2830         * linespec.c: Same.
2831         * linux-nat.c: Same.
2832         * linux-thread-db.c: Same.
2833         * machoread.c: Same.
2834         * mdebugread.c: Same.
2835         * mep-tdep.c: Same.
2836         * mn10300-tdep.c: Same.
2837         * namespace.c: Same.
2838         * objfiles.c: Same.
2839         * opencl-lang.c: Same.
2840         * or1k-tdep.c: Same.
2841         * osabi.c: Same.
2842         * ppc-linux-nat.c: Same.
2843         * ppc-linux-tdep.c: Same.
2844         * ppc-sysv-tdep.c: Same.
2845         * printcmd.c: Same.
2846         * procfs.c: Same.
2847         * record-btrace.c: Same.
2848         * record-full.c: Same.
2849         * remote-fileio.c: Same.
2850         * remote.c: Same.
2851         * rs6000-tdep.c: Same.
2852         * s12z-tdep.c: Same.
2853         * score-tdep.c: Same.
2854         * ser-base.c: Same.
2855         * ser-go32.c: Same.
2856         * skip.c: Same.
2857         * sol-thread.c: Same.
2858         * solib-svr4.c: Same.
2859         * solib.c: Same.
2860         * source.c: Same.
2861         * sparc-nat.c: Same.
2862         * sparc-sol2-tdep.c: Same.
2863         * sparc-tdep.c: Same.
2864         * sparc64-tdep.c: Same.
2865         * stabsread.c: Same.
2866         * stack.c: Same.
2867         * symfile.c: Same.
2868         * symtab.c: Same.
2869         * target-descriptions.c: Same.
2870         * target-float.c: Same.
2871         * thread.c: Same.
2872         * utils.c: Same.
2873         * valops.c: Same.
2874         * valprint.c: Same.
2875         * value.c: Same.
2876         * varobj.c: Same.
2877         * windows-nat.c: Same.
2878         * xcoffread.c: Same.
2879         * xstormy16-tdep.c: Same.
2880         * xtensa-tdep.c: Same.
2881
2882 2019-10-17  Tom Tromey  <tromey@adacore.com>
2883
2884         * configure: Rebuild.
2885         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
2886         in AC_CONFIG_FILES invocation.
2887         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2888         new-style config.status invocation.
2889
2890 2019-10-17  Tom de Vries  <tdevries@suse.de>
2891
2892         * arm-nbsd-nat.c: Fix typos in comments.
2893         * arm-tdep.c: Same.
2894         * darwin-nat-info.c: Same.
2895         * dwarf2read.c: Same.
2896         * elfread.c: Same.
2897         * event-top.c: Same.
2898         * findvar.c: Same.
2899         * gdbtypes.c: Same.
2900         * hppa-tdep.c: Same.
2901         * i386-tdep.c: Same.
2902         * jit.c: Same.
2903         * main.c: Same.
2904         * mdebugread.c: Same.
2905         * moxie-tdep.c: Same.
2906         * nto-procfs.c: Same.
2907         * osabi.c: Same.
2908         * ppc-linux-tdep.c: Same.
2909         * remote.c: Same.
2910         * riscv-tdep.c: Same.
2911         * s390-tdep.c: Same.
2912         * sh-tdep.c: Same.
2913         * sparc-linux-tdep.c: Same.
2914         * sparc-nat.c: Same.
2915         * stack.c: Same.
2916         * target-descriptions.c: Same.
2917         * top.c: Same.
2918         * varobj.c: Same.
2919
2920 2019-10-16  Tom Tromey  <tom@tromey.com>
2921
2922         * objfiles.h (struct objfile) <original_name>: Now const.
2923
2924 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2925
2926         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2927         pass on to sigsetjmp's second argument.
2928         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2929
2930 2019-10-16  Keith Seitz  <keiths@redhat.com>
2931
2932         PR gdb/23567
2933         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2934         sections whose size is greater than the file size.
2935
2936 2019-10-16  Jim Wilson  <jimw@sifive.com>
2937
2938         * riscv-tdep.c (riscv_gcc_target_options): New.
2939         (riscv_gnu_triplet_regexp): New.
2940         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2941         set_gdbarch_gnu_triplet_regexp.
2942
2943 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2944
2945         * Makefile.in: Add xml-builtin.h.
2946         * features/feature_to_c.sh: Add an include for xml-builtin.h
2947         to ensure that the compiler checks that the types match.
2948         * xml-builtin.h: New file.
2949         * xml-support.c (fetch_xml_builtin): Add missing const.
2950         * xml-support.h: Remove declaration of xml_builtins.
2951
2952 2019-10-16  Tom de Vries  <tdevries@suse.de>
2953
2954         PR tdep/25096
2955         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2956         (amd64_classify_aggregate): ... here.
2957         (amd64_classify_aggregate_field): Handled fiels of nested structs
2958         recursively.
2959
2960 2019-10-16  Tom de Vries  <tdevries@suse.de>
2961
2962         PR tdep/24104
2963         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2964         that handles 'theclass'.
2965
2966 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2967
2968         * linespec.c (decode_digits_ordinary): Update comment.
2969         * make-target-delegates: No longer need to handle VEC case.
2970         * memrange.c (normalize_mem_ranges): Update comment.
2971         * namespace.c (add_using_directive): Update comment.
2972         * objc-lang.c (uniquify_strings): Update comment.
2973         * ppc-linux-nat.c (struct thread_points): Update comment.
2974         * probe.h (find_probes_in_objfile): Update comment.
2975         * target.h (enum flash_preserve_mode): Update comment.
2976         * varobj.c (varobj_restrict_range): Update comment.
2977         * varobj.h (varobj_list_children): Update comment.
2978
2979 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2980
2981         * Makefile.in: Remove references to vec.h and vec.c.
2982         * aarch64-tdep.c: No longer include vec.h.
2983         * ada-lang.c: Likewise.
2984         * ada-lang.h: Likewise.
2985         * arm-tdep.c: Likewise.
2986         * ax.h: Likewise.
2987         * breakpoint.h: Likewise.
2988         * charset.c: Likewise.
2989         * cp-support.h: Likewise.
2990         * dtrace-probe.c: Likewise.
2991         * dwarf2read.c: Likewise.
2992         * extension.h: Likewise.
2993         * gdb_bfd.c: Likewise.
2994         * gdbsupport/gdb_vecs.h: Likewise.
2995         * gdbsupport/vec.c: Remove.
2996         * gdbsupport/vec.h: Remove.
2997         * gdbthread.h: Likewise.
2998         * guile/scm-type.c: Likewise.
2999         * inline-frame.c: Likewise.
3000         * machoread.c: Likewise.
3001         * memattr.c: Likewise.
3002         * memrange.h: Likewise.
3003         * namespace.h: Likewise.
3004         * nat/linux-btrace.h: Likewise.
3005         * osdata.c: Likewise.
3006         * parser-defs.h: Likewise.
3007         * progspace.h: Likewise.
3008         * python/py-type.c: Likewise.
3009         * record-btrace.c: Likewise.
3010         * rust-exp.y: Likewise.
3011         * solib-target.c: Likewise.
3012         * stap-probe.c: Likewise.
3013         * target-descriptions.c: Likewise.
3014         * target-memory.c: Likewise.
3015         * target.h: Likewise.
3016         * varobj.c: Likewise.
3017         * varobj.h: Likewise.
3018         * xml-support.h: Likewise.
3019
3020 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3021
3022         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3023         Update for new std::vector based implementation.
3024         (process_psymtab_comp_unit_reader): Likewise.
3025         (scan_partial_symbols): Likewise.
3026         (recursively_compute_inclusions): Likewise.
3027         (compute_compunit_symtab_includes): Likewise.
3028         (process_imported_unit_die): Likewise.
3029         (queue_and_load_dwo_tu): Likewise.
3030         (follow_die_sig_1): Likewise.
3031         * gdb/dwarf2read.h: Remove DEF_VEC_P.
3032         (typedef dwarf2_per_cu_ptr): Remove.
3033         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3034         function.
3035         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3036         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3037         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3038         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3039         std::vector.
3040
3041 2019-10-15  Tom Tromey  <tromey@adacore.com>
3042
3043         * windows-nat.c (windows_nat_target::resume): Use %x when logging
3044         TID.
3045
3046 2019-10-15  Tom Tromey  <tromey@adacore.com>
3047
3048         * windows-nat.c (windows_nat_target::fetch_registers)
3049         (windows_nat_target::store_registers): Rename "pid" to "tid".
3050
3051 2019-10-15  Tom Tromey  <tromey@adacore.com>
3052
3053         * gdbarch.h, gdbarch.c: Rebuild.
3054         * gdbarch.sh (gcc_target_options): Change return type to
3055         std::string.
3056         * compile/compile.c (get_args): Update.
3057         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3058         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3059         std::string.
3060         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3061         std::string.
3062         * arch-utils.c (default_gcc_target_options): Return std::string.
3063         * arch-utils.h (default_gcc_target_options): Return std::string.
3064         * s390-tdep.c (s390_gcc_target_options): Return std::string.
3065
3066 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3067
3068         * breakpoint.c (breakpoint_chain): Make static.
3069         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3070         of accessing breakpoint_chain.
3071
3072 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3073
3074         * breakpoint.c (iterate_over_breakpoints): Change function pointer
3075         to a gdb::function_view and return value to bool.
3076         * breakpoint.h (iterate_over_breakpoints): Likewise.
3077         * dummy-frame.c (pop_dummy_frame_bpt): Update.
3078         (pop_dummy_frame): Update.
3079         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3080         (gdbscm_breakpoints): Update.
3081         * python/py-breakpoint.c (build_bp_list): Update.
3082         (gdbpy_breakpoints): Update.
3083         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3084         Update.
3085         (bpfinishpy_handle_stop): Update.
3086         (bpfinishpy_handle_exit): Update.
3087         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3088         (svr4_update_solib_event_breakpoints): Update.
3089
3090 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
3091
3092         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3093         when unwrapping single-field structs.
3094
3095 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
3096
3097         * dwarf2read.c: Remove includes.
3098
3099 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
3100
3101         * ui-out.c (ui_out::call_do_message): Silence
3102         -Wformat-nonliteral warning.
3103
3104 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
3105
3106         * breakpoint.c: Remove some includes: continuations.h, skip.h,
3107         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
3108         include: readline/tilde.h.
3109
3110 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3111
3112         * remote.c (remote_target::get_trace_status): Remove declaration of
3113         trace_regblock_size.
3114
3115 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3116
3117         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3118         (show_user): Remove declaration of cmdlist.
3119         * cli/cli-cmds.h (max_user_call_depth): Declare.
3120         * cli/cli-script.c (execute_user_command): Remove declaration
3121         of max_user_call_depth.
3122
3123 2019-10-11  Jim Wilson  <jimw@sifive.com>
3124
3125         * gdbsupport/print-utils.h (pulongest): Fix comment.
3126         (plongest): Likewise.
3127         (phex): Add missing comment, mention leading zeros.
3128         (phex_nz): Add mention of no leading zeros to comment.
3129
3130         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3131         plongest instead of unsigned long long cast.
3132
3133 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3134
3135         * main.c (captured_main_1): Include gdbtk.h and remove declarations
3136         for external_editor_command and gdbtk_test.
3137
3138 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3139
3140         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3141         * varobj.c (varobjdebug): Move comment to...
3142         * varobj.h (varobjdebug): ...here, and declare.
3143
3144 2019-10-09  Tom Tromey  <tom@tromey.com>
3145
3146         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3147         erase_data_content.
3148
3149 2019-10-09  Tom Tromey  <tom@tromey.com>
3150
3151         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3152         * tui/tui-stack.c (tui_locator_window::rerender): Update.
3153         * tui/tui-command.c (tui_cmd_window::resize)
3154         (tui_refresh_cmd_win): Update.
3155         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3156         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3157         * tui/tui-data.c (~tui_gen_win_info): Remove.
3158         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3159         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3160         (tui_redisplay_readline, tui_mld_flush)
3161         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3162         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3163         (tui_data_window::erase_data_content)
3164         (tui_data_item_window::rerender)
3165         (tui_data_item_window::refresh_window): Update.
3166         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3167         (box_win, tui_gen_win_info::make_window)
3168         (tui_gen_win_info::make_visible): Update.
3169         (tui_delete_win): Remove.
3170         * tui/tui-winsource.c
3171         (tui_source_window_base::do_erase_source_content): Update.
3172         (tui_show_source_line, tui_source_window_base::update_tab_width)
3173         (tui_source_window_base::update_exec_info): Update.
3174         * tui/tui-data.h (struct curses_deleter): New.
3175         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3176         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3177
3178 2019-10-09  Tom Tromey  <tom@tromey.com>
3179
3180         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3181
3182 2019-10-09  Tom Tromey  <tom@tromey.com>
3183
3184         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3185         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3186
3187 2019-10-09  Tom Tromey  <tom@tromey.com>
3188
3189         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3190         window height directly.
3191         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3192         declare.
3193         * tui/tui-layout.c (tui_default_win_height): Remove.
3194         (tui_default_win_viewport_height): Remove.
3195
3196 2019-10-09  Tom Tromey  <tom@tromey.com>
3197
3198         * tui/tui.h: Remove comments.
3199
3200 2019-10-09  Tom de Vries  <tdevries@suse.de>
3201
3202         * python/lib/gdb/printer/bound_registers.py: Use
3203         '^builtin_type_bound128' as regexp argument for
3204         add_builtin_pretty_printer.
3205
3206 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
3207
3208         * guile/guile.c (guile_extension_script_ops): Remove forward
3209         declaration and mark as static.
3210         (guile_script_ops): Likewise.
3211         (extension_language_guile): Move further down in the file so
3212         it can reference the definitions for guile_{extension_,}script_ops.
3213
3214 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
3215
3216         * s390-tdep.c (390_process_record): Handle new arch13 instructions
3217         except SORTL, DFLTCC, and KDSA.
3218
3219 2019-10-08  Tom Tromey  <tromey@adacore.com>
3220
3221         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3222         (struct safe_symbol_file_add_args): Remove.
3223
3224 2019-10-08  Tom Tromey  <tromey@adacore.com>
3225
3226         * windows-nat.c: Don't include buildsym-legacy.h.
3227
3228 2019-10-08  Tom Tromey  <tromey@adacore.com>
3229
3230         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3231
3232 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3233
3234         * gdbtypes.c (overload_debug): Move comment to header.
3235         * gdbtypes.h (overload_debug): Declare.
3236         * valops.c: Remove declaration of overload_debug, instead
3237         include gdbtypes.h.
3238
3239 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3240
3241         * language.c (show_language_command): Pass lang_frame_mismatch_warn
3242         through _().
3243         (lang_frame_mismatch_warn): Make const, mark with N_(), and
3244         move comment...
3245         * language.h (lang_frame_mismatch_warn): ... here. Also add
3246         declaration.
3247         * top.c (lang_frame_mismatch_warn): Remove declaration.
3248         (check_frame_language_change): Pass lang_frame_mismatch_warn
3249         through _().
3250
3251 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3252
3253         * c-lang.h (vtbl_ptr_name): Declare.
3254         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3255         it from the header.
3256         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3257
3258 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3259
3260         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3261         gdb_static_assert.
3262
3263 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3264
3265         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3266         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3267         * ctfread.c: New file.
3268         * ctfread.h: New file.
3269         * elfread.c: Include ctfread.h.
3270         (struct elfinfo text_p): New member ctfsect.
3271         (elf_locate_sections): Mark CTF section.
3272         (elf_symfile_read): Call elfctf_build_psymtabs.
3273         * Makefile.in (LIBCTF): Add.
3274         (CLIBS): Use it.
3275         (CDEPS): Likewise.
3276         (DIST): Add ctfread.c.
3277
3278 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3279
3280         * ctfread.c (struct nextfield): Renamed to ...
3281         (struct ctf_nextfield): ... this.
3282         (struct field_info): Renamed to ...
3283         (strut ctf_field_info): ... this.
3284         (attach_fields_to_type): Update for renamed structures.
3285         (ctf_add_member_cb): Likewise.
3286         (ctf_add_enum_member_cb): Likewise.
3287         (process_struct_members): Likewise.
3288         (process_enum_type): Likewise.
3289
3290 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3291
3292         * tracectf.h: Rename, was ctf.h.
3293         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3294         * tracefile.c: Likewise.
3295         * tracepoint.c: Remove unused include ctf.h.
3296         * mi/mi-main.c: Likewise.
3297         * Makefile.in Replace ctf.c with tracectf.c.
3298
3299 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
3300
3301         * version.in: Change version number to "9.0.50.DATE-git".
3302
3303 2019-10-03  Tom Tromey  <tom@tromey.com>
3304
3305         PR rust/24976:
3306         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3307
3308 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3309
3310         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3311         cp_search_name_hash.
3312         * NEWS: Add entry about nested function support.
3313
3314 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
3315             Andrew Burgess  <andrew.burgess@embecosm.com>
3316
3317         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3318         for nested static variables when searchin VAR_DOMAIN.
3319         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3320         global scope, update comment.
3321         (add_partial_subprogram): Call add_partial_subprogram recursively
3322         for nested subroutines when processinng Fortran.
3323         (load_partial_dies): Process the child entities of a subprogram
3324         when processing Fortran.
3325         (partial_die_parent_scope): Handle building scope
3326         for Fortran nested functions.
3327         (process_die): Record that nested functions have a scope.
3328         (new_symbol): Always record Fortran subprograms on the global
3329         symbol list.
3330         (determine_prefix): How to build the prefix for Fortran
3331         subprograms.
3332
3333 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3334
3335         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3336         have just sent the thread a SIGSTOP and are waiting for it to
3337         arrive.
3338
3339 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3340
3341         * btrace.c (btrace_add_pc): Remove whitespace before the template
3342         parameter in 'std::vector <...>'.
3343         (parse_xml_btrace_block): Likewise.
3344         (btrace_maint_decode_pt): Likewise.
3345         (btrace_maint_update_packets): Likewise.
3346         (btrace_maint_print_packets): Likewise.
3347         * btrace.h (struct btrace_maint_info): Likewise.
3348         * dwarf2read.c (struct type_unit_group): Likewise.
3349         (build_type_psymtabs_reader): Likewise.
3350         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3351         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3352         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3353
3354 2019-10-03  Tom de Vries  <tdevries@suse.de>
3355
3356         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3357         the first line of the help text for set/show style metadata.
3358
3359 2019-10-02  Tom Tromey  <tromey@adacore.com>
3360
3361         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3362         * gdbsupport/common-inferior.c: New file.
3363         * infcmd.c (startup_with_shell): Don't define.
3364         * nat/fork-inferior.h (startup_with_shell): Don't declare.
3365         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3366         * inferior.h (startup_with_shell): Don't declare.
3367
3368 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
3369
3370         * gdbsupport/gdb_assert.h: Include errors.h.
3371         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3372
3373 2019-10-02  Tom Tromey  <tromey@adacore.com>
3374
3375         * NEWS: Add $_ada_exception entry.
3376         * ada-lang.c (struct ada_catchpoint): Add constructor.
3377         <m_kind>: New member.
3378         (allocate_location_exception, re_set_exception): Remove
3379         "ex" parameter.
3380         (should_stop_exception): Compute $_ada_exception.
3381         (check_status_exception, print_it_exception)
3382         (print_one_exception, print_mention_exception): Remove
3383         "ex" parameter.
3384         (allocate_location_catch_exception, re_set_catch_exception)
3385         (check_status_exception, print_it_catch_exception)
3386         (print_one_catch_exception, print_mention_catch_exception)
3387         (print_recreate_catch_exception)
3388         (allocate_location_catch_exception_unhandled)
3389         (re_set_catch_exception_unhandled)
3390         (check_status_exception, print_it_catch_exception_unhandled)
3391         (print_one_catch_exception_unhandled)
3392         (print_mention_catch_exception_unhandled)
3393         (print_recreate_catch_exception_unhandled)
3394         (allocate_location_catch_assert, re_set_catch_assert)
3395         (check_status_assert, print_it_catch_assert)
3396         (print_one_catch_assert, print_mention_catch_assert)
3397         (print_recreate_catch_assert)
3398         (allocate_location_catch_handlers, re_set_catch_handlers)
3399         (check_status_handlers, print_it_catch_handlers)
3400         (print_one_catch_handlers, print_mention_catch_handlers)
3401         (print_recreate_catch_handlers): Remove.
3402         (create_ada_exception_catchpoint): Update.
3403         (initialize_ada_catchpoint_ops): Update.
3404
3405 2019-10-02  Tom Tromey  <tromey@adacore.com>
3406
3407         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3408         (create_excep_cond_exprs): Simplify exception string computation.
3409         (ada_exception_catchpoint_cond_string): Likewise.
3410
3411 2019-10-02  Tom Tromey  <tromey@adacore.com>
3412
3413         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3414         * ada-lang.c (lesseq_defined_than): Handle
3415         LOC_STATIC.
3416         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3417         parameter.
3418         (dwarf2_has_info): Likewise.
3419         (new_symbol): Set maybe_copied on symbol when
3420         appropriate.
3421         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3422         parameter.
3423         <can_copy>: New member.
3424         * elfread.c (record_minimal_symbol): Set maybe_copied
3425         on symbol when appropriate.
3426         (elf_symfile_read): Update call to dwarf2_has_info.
3427         * minsyms.c (lookup_minimal_symbol_linkage): New
3428         function.
3429         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3430         * symtab.c (get_symbol_address, get_msymbol_address):
3431         New functions.
3432         * symtab.h (get_symbol_address, get_msymbol_address):
3433         Declare.
3434         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3435         maybe_copied.
3436         (struct symbol, struct minimal_symbol) <maybe_copied>:
3437         New member.
3438
3439 2019-10-02  Tom Tromey  <tromey@adacore.com>
3440
3441         * source.c (struct current_source_location): New.
3442         (current_source_key): New global.
3443         (current_source_symtab, current_source_line)
3444         (current_source_pspace): Remove.
3445         (get_source_location): New function.
3446         (get_current_source_symtab_and_line)
3447         (set_default_source_symtab_and_line)
3448         (set_current_source_symtab_and_line)
3449         (clear_current_source_symtab_and_line, select_source_symtab)
3450         (info_source_command, print_source_lines_base)
3451         (info_line_command, search_command_helper, _initialize_source):
3452         Update.
3453
3454 2019-10-02  Tom Tromey  <tromey@adacore.com>
3455
3456         * source.c (select_source_symtab): Don't call
3457         decode_line_with_current_source.
3458
3459 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3460
3461         * symtab.c (lookup_global_symbol): Search global block.
3462
3463 2019-10-02  Tom Tromey  <tromey@adacore.com>
3464
3465         * coffread.c (process_coff_symbol): Update.
3466         * dwarf2read.c (var_decode_location, new_symbol): Update.
3467         * mdebugread.c (parse_symbol): Update.
3468         * objfiles.c (relocate_one_symbol): Update.
3469         * stabsread.c (define_symbol, fix_common_block)
3470         (scan_file_globals): Update.
3471         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3472         (SET_SYMBOL_VALUE_ADDRESS): New macro.
3473         * xcoffread.c (process_xcoff_symbol): Update.
3474
3475 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
3476
3477         * MAINTAINERS: Update my email address.
3478
3479 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3480
3481         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3482         std::vector.
3483         (build_type_psymtabs_reader): Update for std::vector.
3484         (build_type_psymtab_dependencies): Likewise.
3485         * dwarf2read.h: Remove use of DEF_VEC_P.
3486         (typedef sig_type_ptr): Delete.
3487
3488 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3489
3490         * btrace.c (btrace_maint_clear): Update to handle change from VEC
3491         to std::vector.
3492         (btrace_maint_decode_pt): Likewise, and move allocation of the
3493         vector outside of the loop.
3494         (btrace_maint_update_packets): Update to handle change from VEC to
3495         std::vector.
3496         (btrace_maint_print_packets): Likewise.
3497         (maint_info_btrace_cmd): Likewise.
3498         * btrace.h: Remove use of DEF_VEC_O.
3499         (typedef btrace_pt_packet_s): Delete.
3500         (struct btrace_maint_info) <packets>: Change fromm VEC to
3501         std::vector.
3502         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3503
3504 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3505
3506         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3507         make accesses into the vector constant references.
3508         (btrace_add_pc): Update for std::vector.
3509         (btrace_stitch_bts): Likewise.
3510         (parse_xml_btrace_block): Likewise.
3511         (btrace_maint_update_packets): Likewise.
3512         (btrace_maint_print_packets): Likewise.
3513         (maint_info_btrace_cmd): Likewise.
3514         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3515         std::vector.
3516         (btrace_data::empty): Likewise.
3517         (btrace_data_append): Likewise.
3518         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3519         (typedef btrace_block_s): Delete.
3520         (struct btrace_block): Add constructor.
3521         (struct btrace_data_bts) <blocks>: Change to std::vector.
3522         * nat/linux-btrace.c (perf_event_read_bts): Update for
3523         std::vector.
3524         (linux_read_bts): Likewise.
3525
3526 2019-10-01  Tom Tromey  <tom@tromey.com>
3527
3528         * cli/cli-logging.c (show_logging_filename): Use styled_string.
3529
3530 2019-10-01  Tom Tromey  <tom@tromey.com>
3531
3532         * stack.c (print_frame, info_frame_command_core): Use
3533         styled_string.
3534         * linux-thread-db.c (try_thread_db_load_1)
3535         (try_thread_db_load_from_pdir_1): Use styled_string.
3536         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3537         (auto_load_section_scripts, info_auto_load_local_gdbinit)
3538         (maybe_print_unsupported_script_warning)
3539         (maybe_print_script_not_found_warning): Use styled_string.
3540         * ada-lang.c (user_select_syms): Use styled_string.
3541
3542 2019-10-01  Tom Tromey  <tom@tromey.com>
3543
3544         * p-lang.c (pascal_printstr): Use metadata style.
3545         * value.c (show_convenience): Use metadata style.
3546         * valprint.c (valprint_check_validity, val_print_optimized_out)
3547         (val_print_not_saved, val_print_unavailable)
3548         (val_print_invalid_address, generic_val_print, val_print)
3549         (value_check_printable, val_print_array_elements): Use metadata
3550         style.
3551         * ui-out.h (class ui_out) <field_fmt>: New overload.
3552         <do_field_fmt>: Add style parameter.
3553         * ui-out.c (ui_out::field_fmt): New overload.
3554         * typeprint.c (type_print_unknown_return_type)
3555         (val_print_not_allocated, val_print_not_associated): Use metadata
3556         style.
3557         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3558         parameter.
3559         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3560         * tracepoint.c (tvariables_info_1): Use metadata style.
3561         * stack.c (print_frame_arg, print_frame_info, print_frame)
3562         (info_frame_command_core): Use metadata style.
3563         * skip.c (info_skip_command): Use metadata style.
3564         * rust-lang.c (rust_print_enum): Use metadata style.
3565         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3566         metadata style.
3567         * python/py-framefilter.c (py_print_single_arg): Use metadata
3568         style.
3569         * printcmd.c (do_one_display, print_variable_and_value): Use
3570         metadata style.
3571         * p-valprint.c (pascal_val_print)
3572         (pascal_object_print_value_fields): Use metadata style.
3573         * p-typeprint.c (pascal_type_print_base): Use metadata style.
3574         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3575         parameter.
3576         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3577         * m2-valprint.c (m2_print_long_set): Use metadata style.
3578         * m2-typeprint.c (m2_print_type): Use metadata style.
3579         * infcmd.c (print_return_value_1): Use metadata style.
3580         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3581         * f-valprint.c (info_common_command_for_block): Use metadata
3582         style.
3583         * f-typeprint.c (f_type_print_base): Use metadata style.
3584         * expprint.c (print_subexp_standard): Use metadata style.
3585         * cp-valprint.c (cp_print_value_fields): Use metadata style.
3586         * cli/cli-style.h (class cli_style_option): Add constructor.
3587         (metadata_style): Declare.
3588         * cli/cli-style.c (metadata_style): New global.
3589         (_initialize_cli_style): Register metadata style.
3590         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3591         parameter.
3592         * cli-out.c (cli_ui_out::do_field_fmt): Update.
3593         * c-typeprint.c (c_type_print_base_struct_union)
3594         (c_type_print_base_1): Use metadata style.
3595         * breakpoint.c (watchpoint_value_print)
3596         (print_one_breakpoint_location): Use metadata style.
3597         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3598         style.
3599         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3600         style.
3601         * ada-valprint.c (val_print_packed_array_elements, printstr)
3602         (print_field_values, ada_val_print_ref, ada_val_print): Use
3603         metadata style.
3604         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3605         style.
3606         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3607         style.
3608         * ada-lang.c (user_select_syms): Use metadata style.
3609
3610 2019-10-01  Tom Tromey  <tom@tromey.com>
3611
3612         * cli/cli-cmds.c (pwd_command): Style output.
3613
3614 2019-10-01  Pedro Alves  <palves@redhat.com>
3615             Tom Tromey  <tom@tromey.com>
3616
3617         * symtab.c (print_symbol_info): Use %ps.
3618         (print_msymbol_info): Use %ps.
3619         * symfile.c (symbol_file_add_with_addrs): Use %ps.
3620         * printcmd.c (print_variable_and_value): Use %ps.
3621         * macrocmd.c (show_pp_source_pos): Use %ps.
3622         * infrun.c (print_exited_reason): Use ui_out::message.
3623         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3624         (describe_other_breakpoints): Use ui_out::message and new
3625         formats.
3626         (say_where): Use new formats.
3627         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3628         and new formats.
3629
3630 2019-10-01  Pedro Alves  <palves@redhat.com>
3631             Tom Tromey  <tom@tromey.com>
3632
3633         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3634         (test_gdb_formats): New function.
3635         (run_tests): Call it.
3636         (test_format_specifier): Update.
3637         * utils.h (fputs_filtered): Update comment.
3638         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3639         (fputs_styled_unfiltered): Declare.
3640         * utils.c (fputs_styled_unfiltered): New function.
3641         (vfprintf_maybe_filtered): Add gdbfmt parameter.
3642         (vfprintf_filtered): Update.
3643         (vfprintf_unfiltered, vprintf_filtered): Update.
3644         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3645         * ui-out.h (enum ui_out_flag) <unfiltered_output,
3646         disallow_ui_out_field>: New constants.
3647         (enum class field_kind): New.
3648         (struct base_field_s, struct signed_field_s): New.
3649         (signed_field): New function.
3650         (struct string_field_s): New.
3651         (string_field): New function.
3652         (struct styled_string_s): New.
3653         (styled_string): New function.
3654         (class ui_out) <message>: Add comment.
3655         <vmessage, call_do_message>: New methods.
3656         <do_message>: Add style parameter.
3657         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3658         methods.
3659         (ui_out::message): Rewrite.
3660         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3661         parameter.
3662         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3663         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3664         gdb_extensions parameter.
3665         (class format_piece): Add parameter to constructor.
3666         (n_int_args): New field.
3667         * gdbsupport/format.c (format_pieces::format_pieces): Add
3668         gdb_extensions parameter.  Handle '*'.
3669         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3670         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
3671         vfprintf_styled_no_gdbfmt.
3672         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3673         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3674         unfiltered output.
3675         * ui-style.h (struct ui_file_style) <ptr>: New method.
3676
3677 2019-10-01  Tom Tromey  <tom@tromey.com>
3678
3679         * unittests/format_pieces-selftests.c: Update.  Add final format.
3680         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3681         empty literal pieces.
3682
3683 2019-10-01  Tom Tromey  <tom@tromey.com>
3684
3685         * ui-out.h (enum class ui_out_style_kind): Remove.
3686         (class ui_out) <field_string, field_stsream, do_field_string>:
3687         Change type of "style".
3688         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3689         (ui_out::field_string): Update.
3690         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3691         of "style".
3692         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3693         * tracepoint.c (print_one_static_tracepoint_marker): Update.
3694         * stack.c (print_frame_arg, print_frame_info, print_frame):
3695         Update.
3696         * source.c (print_source_lines_base): Update.
3697         * solib.c (info_sharedlibrary_command): Update.
3698         * skip.c (info_skip_command): Update.
3699         * record-btrace.c (btrace_call_history_src_line)
3700         (btrace_call_history): Update.
3701         * python/py-framefilter.c (py_print_frame): Update.
3702         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3703         "style".
3704         * mi/mi-out.c (mi_ui_out::do_table_header)
3705         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3706         (mi_ui_out::do_field_string): Update.
3707         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3708         Update.
3709         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3710         "style".
3711         * cli-out.c (cli_ui_out::do_table_header)
3712         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3713         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3714         (cli_ui_out::do_field_fmt): Update.
3715         * breakpoint.c (print_breakpoint_location): Update.
3716         (update_static_tracepoint): Update.
3717
3718 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3719
3720         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3721         conversion of gdb_datadir.
3722         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3723         remove not needed c_str ().
3724
3725 2019-09-30  Ali Tamur <tamur@google.com>
3726
3727         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3728         (dwarf2_string_attr): Likewise.
3729
3730 2019-09-30  Ali Tamur <tamur@google.com>
3731
3732         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3733         (process_full_type_unit): Likewise.
3734         (dump_die_shallow): Likewise.
3735         (cu_debug_loc_section): Likewise.
3736
3737 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
3738
3739         * minsyms.c (compare_minimal_symbols): Rename to...
3740         (minimal_symbol_is_less_than): ...this, and adjust to STL
3741         conventions (return bool, take arguments as references)
3742         (minimal_symbol_reader::install): Call std::sort instead
3743         of qsort.
3744
3745 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
3746
3747         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3748         hash and why.
3749         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3750         msymbol_hash, msymbol_demangled_hash>: Improve comments.
3751
3752 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
3753
3754         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3755         * psympriv.h (add_psymbol_to_list): Move comment here and update
3756         it.
3757
3758 2019-09-29  Tom de Vries  <tdevries@suse.de>
3759
3760         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3761         Use $tmpdir/$(basename "$output_file").dwz instead of
3762         "${output_file}.dwz".
3763
3764 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
3765
3766         PR gdb/25045
3767         * hppa-linux-nat.c: Include gdbarch.h.
3768
3769 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
3770
3771         * blockframe.c (find_pc_partial_function): Change return type to bool.
3772         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3773         * minsyms.c (in_gnu_ifunc_stub): Likewise.
3774         (stub_gnu_ifunc_resolve_name): Likewise.
3775         * symtab.c (compare_filenames_for_search): Likewise.
3776         (compare_glob_filenames_for_search): Likewise.
3777         (matching_obj_sections): Likewise.
3778         (symbol_matches_domain): Likewise.
3779         (find_line_symtab): Change out param EXACT_MATCH to bool *.
3780         (find_line_pc): Change return type to bool.
3781         (find_line_pc_range): Likewise.
3782         (producer_is_realview): Likewise.
3783         * symtab.h (symbol_matches_domain): Likewise.
3784         (find_pc_partial_function): Likewise.
3785         (find_pc_line_pc_range): Likewise.
3786         (in_gnu_ifunc_stub): Likewise.
3787         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3788         (find_line_pc): Likewise.
3789         (find_line_pc_range): Likewise.
3790         (matching_obj_sections): Likewise.
3791         (find_line_symtab): Change out parameter to bool.
3792         (producer_is_realview): Change return type to bool.
3793         (compare_filenames_for_search): Likewise.
3794         (compare_glob_filenames_for_search): Likewise.
3795
3796 2019-09-26  Tom Tromey  <tom@tromey.com>
3797
3798         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3799         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3800         * gdb_usleep.h: Remove.
3801         * gdb_usleep.c: Remove.
3802         * utils.c: Don't include gdb_usleep.h.
3803
3804 2019-09-26  Tom Tromey  <tromey@adacore.com>
3805
3806         * python/py-type.c (type_to_type_object): Call check_typedef
3807         for stub types.
3808
3809 2019-09-26  Tom Tromey  <tom@tromey.com>
3810
3811         * utils.h (initialize_utils): Don't declare.
3812         * top.c (gdb_init): Don't call initialize_utils.
3813         * utils.c (initialize_utils): Remove.  Move contents...
3814         (_initialize_utils): ... here.
3815
3816 2019-09-25  Tom Tromey  <tom@tromey.com>
3817
3818         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3819         * utils.h (make_hex_string): Don't declare.
3820         * utils.c (make_hex_string): Remove.
3821
3822 2019-09-24  Tom de Vries  <tdevries@suse.de>
3823
3824         PR gdb/23815
3825         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3826         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3827
3828 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
3829
3830         * NEWS: Mention new simulator port for PRU.
3831
3832 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
3833
3834         * ada-exp.y (write_object_remaining): Update.
3835         * ada-lang.c (ada_decode): Return a std::string instead of a char*
3836         and eliminate the static buffer.
3837         (ada_decode_symbol): Update.
3838         (ada_la_decode): Update.
3839         (ada_sniff_from_mangled_name): Update.
3840         (is_valid_name_for_wild_match): Update.
3841         (ada_lookup_name_info::matches): Update and simplify.
3842         (name_matches_regex): Update.
3843         (ada_add_global_exceptions): Update.
3844         * ada-lang.h (ada_decode): Update signature.
3845         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3846         * dwarf-index-write.c (debug_names::insert): Update.
3847
3848 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3849
3850         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3851         formatting.
3852
3853 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3854
3855         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3856         Change "nonzero" to "true" in documentation.
3857
3858 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
3859
3860         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3861         (_initialize_darwin_solib): Don't set
3862         darwin_so_ops.lookup_lib_global_symbol.
3863         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3864         set_gdbarch_iterate_over_objfiles_in_search_order.
3865         (elf_lookup_lib_symbol): Rename to...
3866         (svr4_iterate_over_objfiles_in_search_order): this, and update
3867         to iterate semantics.
3868         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3869         * solib.c (solib_global_lookup): Remove.
3870         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3871         (solib_global_lookup): Remove.
3872         * symtab.c (lookup_global_or_static_symbol): Remove call to
3873         solib_global_lookup.
3874
3875 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3876
3877         * NEWS: Move entries about default MI version now being
3878         version 3, and about the GDB/MI fix for multi-location
3879         breakpoints to the "since GDB 8.3" section.
3880
3881 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3882
3883         GDB 8.3.1 released.
3884
3885 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
3886
3887         * NEWS: Mention that Cell/B.E. debugging support was removed.
3888         * MAINTAINERS: Remove spu target.
3889
3890         * config/djgpp/fnchange.lst: Remove entries for removed files.
3891
3892         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3893         spu-multiarch.o, and spu-tdep.o.
3894         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3895         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3896         spu-multiarch.c, and spu-tdep.c.
3897         * spu-linux-nat.c: Remove file.
3898         * spu-multiarch.c: Remove file.
3899         * spu-tdep.c: Remove file.
3900         * spu-tdep.h: Remove file.
3901         * solib-spu.c: Remove file.
3902         * solib-spu.h: Remove file.
3903
3904         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3905         * configure.nat (spu-linux): Remove.
3906         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3907         solib-multiarch.o from gdb_target_obs.
3908         (spu*-*-*): Remove.
3909
3910         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3911         feature flag.
3912         (ppc_linux_no_features): Update.
3913         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3914         Cell/B.E. support.
3915         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3916         (tdesc_powerpc_cell64l): Likewise.
3917         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3918         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3919         Cell/B.E. support.
3920         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3921         Do not include "features/rs6000/powerpc-cell32l.c" or
3922         "features/rs6000/powerpc-cell64l.c".
3923         (ppc_linux_spu_section): Remove.
3924         (ppc_linux_core_read_description): Remove Cell/B.E. support.
3925         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3926         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3927         (ppc_linux_spe_context_lookup): Remove.
3928         (ppc_linux_spe_context_inferior_created): Remove.
3929         (ppc_linux_spe_context_solib_loaded): Remove.
3930         (ppc_linux_spe_context_solib_unloaded): Remove.
3931         (ppc_linux_spe_context): Remove.
3932         (struct ppu2spu_cache): Remove.
3933         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3934         (struct ppu2spu_data): Remove.
3935         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3936         ppu2spu_unwind): Remove.
3937         (ppc_linux_init_abi): Remove Cell/B.E. support.
3938         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3939
3940         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3941         (rs6000/powerpc-cell64l-expedite): Likewise
3942         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3943         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3944         rs6000/powerpc-cell64l.xml.
3945         * features/rs6000/powerpc-cell32l.xml: Remove.
3946         * features/rs6000/powerpc-cell64l.xml: Likewise.
3947         * features/rs6000/powerpc-cell32l.c: Remove generated file.
3948         * features/rs6000/powerpc-cell64l.c: Likewise.
3949         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3950         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3951         * regformats/reg-spu.dat: Remove.
3952
3953         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3954         * corelow.c (struct spuid_list): Remove.
3955         (add_to_spuid_list): Remove.
3956         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3957         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3958         (remote_protocol_features): Remove associated entries.
3959         (_initialize_remote): No longer initialize them.
3960         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3961         * linux-nat.c (SPUFS_MAGIC): Remove.
3962         (linux_proc_xfer_spu): Remove.
3963         (spu_enumerate_spu_ids): Remove.
3964         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3965         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3966         (linux_make_corefile_notes): No longer call it.
3967
3968         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3969         (cooked_write_test): Likewise.
3970
3971 2019-09-20  Tom Tromey  <tom@tromey.com>
3972
3973         * NEWS: Mention case-sensitivity of TUI commands.
3974         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3975         (tui_set_win_height_command, parse_scrolling_args): Likewise.
3976         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3977
3978 2019-09-20  Tom Tromey  <tom@tromey.com>
3979
3980         * tui/tui-source.c (tui_source_window::set_contents): Use
3981         make_unique_xstrdup.
3982         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3983         make_unique_xstrdup.
3984
3985 2019-09-20  Tom Tromey  <tom@tromey.com>
3986
3987         * tui/tui-data.c: Remove separator comments.
3988         * tui/tui-layout.c: Remove separator comments.
3989         * tui/tui-win.c: Remove separator comments.
3990         * tui/tui-wingeneral.c: Remove separator comments.
3991
3992 2019-09-20  Tom Tromey  <tom@tromey.com>
3993
3994         * tui/tui.h (strcat_to_buf): Don't declare.
3995         * tui/tui.c (strcat_to_buf): Remove.
3996
3997 2019-09-20  Tom Tromey  <tom@tromey.com>
3998
3999         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4000         from "fullname".
4001         * tui/tui-source.c (tui_source_window::set_contents)
4002         (tui_source_window::location_matches_p)
4003         (tui_source_window::maybe_update): Update.
4004
4005 2019-09-20  Tom Tromey  <tom@tromey.com>
4006
4007         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4008         Update.
4009         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4010         prefix.
4011         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4012         (tui_data_window::line_from_reg_element_no)
4013         (tui_data_window::first_reg_element_no_inline)
4014         (tui_data_window::show_registers)
4015         (tui_data_window::show_register_group)
4016         (tui_data_window::display_registers_from)
4017         (tui_data_window::display_registers_from_line)
4018         (tui_data_window::first_data_item_displayed)
4019         (tui_data_window::delete_data_content_windows)
4020         (tui_data_window::erase_data_content)
4021         (tui_data_window::do_scroll_vertical)
4022         (tui_data_window::refresh_window)
4023         (tui_data_window::check_register_values): Update.
4024
4025 2019-09-20  Tom Tromey  <tom@tromey.com>
4026
4027         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4028         (struct tui_locator_window) <full_name, proc_name>: Now
4029         std::string.
4030         * tui/tui-stack.c (tui_locator_window::make_status_line)
4031         (tui_locator_window::set_locator_fullname)
4032         (tui_locator_window::set_locator_info): Update.
4033         * tui/tui-source.c (tui_source_window::set_contents)
4034         (tui_source_window::showing_source_p): Update.
4035
4036 2019-09-20  Tom Tromey  <tom@tromey.com>
4037
4038         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4039         Don't call tui_locator_win_info_ptr.
4040
4041 2019-09-20  Tom Tromey  <tom@tromey.com>
4042
4043         * tui/tui-win.c (tui_resize_all): Don't call refresh.
4044
4045 2019-09-20  Tom Tromey  <tom@tromey.com>
4046
4047         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4048         height for locator.
4049         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4050         * tui/tui-layout.c (show_source_disasm_command, show_data)
4051         (show_source_or_disasm_and_command): Use 1 as height for locator.
4052
4053 2019-09-20  Tom Tromey  <tom@tromey.com>
4054
4055         * tui/tui.c (tui_enable): Update.
4056         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4057         Update.
4058         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4059         Update.
4060         * tui/tui-data.c (win_resized): Now bool.
4061         (tui_win_resized): Return bool.
4062         (tui_set_win_resized_to): Accept a bool.
4063
4064 2019-09-20  Tom Tromey  <tom@tromey.com>
4065
4066         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4067         Change type of "refresh_values_only".
4068         * tui/tui-regs.c (tui_data_window::show_register_group): Change
4069         type of "refresh_values_only".
4070
4071 2019-09-20  Tom Tromey  <tom@tromey.com>
4072
4073         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4074         std::string.
4075         (tui_disassemble): Add "pos" parameter.
4076         (tui_disasm_window::set_contents): Simplify.
4077
4078 2019-09-20  Tom Tromey  <tom@tromey.com>
4079
4080         * tui/tui-winsource.h (struct tui_source_window_base)
4081         <show_source_content>: Now private.
4082         * tui/tui-winsource.c
4083         (tui_source_window_base::show_source_content): Don't handle empty
4084         content case.
4085
4086 2019-09-20  Tom Tromey  <tom@tromey.com>
4087
4088         * tui/tui-layout.c (show_source_disasm_command)
4089         (show_source_or_disasm_and_command): Don't call
4090         show_source_content.
4091
4092 2019-09-20  Tom Tromey  <tom@tromey.com>
4093
4094         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4095         Declare.
4096         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4097         from tui_make_status_line.
4098         (tui_locator_window::rerender): Update.
4099
4100 2019-09-20  Tom Tromey  <tom@tromey.com>
4101
4102         * tui/tui-stack.c (tui_make_status_line): Return std::string.
4103         (tui_locator_window::rerender): Update.
4104
4105 2019-09-20  Tom Tromey  <tom@tromey.com>
4106
4107         * tui/tui-winsource.h (struct tui_source_window_base)
4108         <~tui_source_window_base>: Don't declare.
4109         <fullname>: Remove.
4110         * tui/tui-winsource.c (~tui_source_window_base): Remove.
4111         * tui/tui-source.h (struct tui_source_window) <fullname>: New
4112         member.
4113         * tui/tui-source.c (tui_source_window::set_contents): Update.
4114         (tui_source_window::location_matches_p)
4115         (tui_source_window::maybe_update): Update.
4116
4117 2019-09-20  Tom Tromey  <tom@tromey.com>
4118
4119         * tui/tui-winsource.h (~tui_source_element): Remove.
4120         (tui_source_element): Update.
4121         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4122         * tui/tui-winsource.c (tui_show_source_line): Update.
4123         * tui/tui-source.c (tui_source_window::set_contents): Update.
4124         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4125
4126 2019-09-20  Tom Tromey  <tom@tromey.com>
4127
4128         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4129         declare.
4130         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4131         tui_clear_source_windows_detail.
4132         * tui/tui-winsource.h (struct tui_source_window_base)
4133         <clear_detail>: Don't declare.
4134         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4135         Remove.
4136         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4137
4138 2019-09-20  Tom Tromey  <tromey@adacore.com>
4139
4140         PR ada/24919:
4141         * block.c (contained_in): Fix final return value.
4142
4143 2019-09-20  Alan Modra  <amodra@gmail.com>
4144
4145         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4146         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4147         (read_indirect_string_from_dwz): Use bfd accessor.
4148         * dwarf2read.h (struct dwz_file <filename>): Likewise.
4149         * machoread.c (macho_symfile_read_all_oso): Likewise.
4150         * solib.c (solib_bfd_open): Likewise.
4151
4152 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4153
4154         * eval.c: Move declaration of overload_resolution to...
4155         * value.h: ...here.
4156
4157 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4158
4159         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4160         * arm-linux-tdep.c: Likewise.
4161         * arm-nbsd-nat.c: Likewise.
4162         * arm-tdep.h: Declare arm_apcs_32.
4163         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4164
4165 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4166
4167         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4168         * dwarf2read.h: Declare dwarf_always_disassemble.
4169
4170 2019-09-19  Tom de Vries  <tdevries@suse.de>
4171
4172         PR gdb/25009
4173         * source-cache.c (source_cache::ensure): Catch exception thrown during
4174         construction of the highlighter.
4175
4176 2019-09-18  Alan Modra  <amodra@gmail.com>
4177
4178         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4179         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4180         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4181         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4182         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4183         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4184         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4185         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4186         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4187         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4188         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4189         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4190         * solib-spu.c, * solib-svr4.c, * solib-target.c,
4191         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4192         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4193         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4194         * mi/mi-interp.c: Update throughout for bfd section macro and
4195         function changes.
4196         * gcore (gcore_create_callback): Use bfd_set_section_lma.
4197         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4198
4199 2019-09-18  Tom Tromey  <tom@tromey.com>
4200
4201         * NEWS: Add entry.
4202         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
4203         call rl_initialize.
4204         (tui_enable): Do not call rl_initialize.
4205
4206 2019-09-18  Christian Groessler  <chris@groessler.org>
4207
4208         * alpha-linux-nat.c: Include gdbarch.h.
4209
4210 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
4211
4212         * ui-file.c: Include cli/cli-style.h.
4213         (term_cli_styling): Remove cli_styling declaration.
4214
4215 2019-09-18  Alan Modra  <amodra@gmail.com>
4216
4217         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4218         to bfd_asymbol_section.
4219
4220 2019-09-18  Alan Modra  <amodra@gmail.com>
4221
4222         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4223         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4224         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4225
4226 2019-09-18  Alan Modra  <amodra@gmail.com>
4227
4228         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4229         * spu-linux-nat.c (spu_bfd_open): Likewise.
4230
4231 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
4232
4233         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4234         to bool to match definition in dwarf2read.c.
4235
4236 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
4237
4238         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4239         (print_signatures): Likewise.
4240         (trust_pad_over_xvs): Likewise.
4241         * arch/aarch64-insn.c (aarch64_debug): Likewise.
4242         * arch/aarch64-insn.h (aarch64_debug): Likewise.
4243         * arm-linux-nat.c (arm_apcs_32): Likewise.
4244         * arm-linux-tdep.c (arm_apcs_32): Likewise.
4245         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4246         * arm-tdep.c (arm_debug): Likewise.
4247         (arm_apcs_32): Likewise.
4248         * auto-load.c (debug_auto_load): Likewise.
4249         (auto_load_gdb_scripts): Likewise.
4250         (global_auto_load): Likewise.
4251         (auto_load_local_gdbinit): Likewise.
4252         (auto_load_local_gdbinit_loaded): Likewise.
4253         * auto-load.h (global_auto_load): Likewise.
4254         (auto_load_local_gdbinit): Likewise.
4255         (auto_load_local_gdbinit_loaded): Likewise.
4256         * breakpoint.c (disconnected_dprintf): Likewise.
4257         (breakpoint_proceeded): Likewise.
4258         (automatic_hardware_breakpoints): Likewise.
4259         (always_inserted_mode): Likewise.
4260         (target_exact_watchpoints): Likewise.
4261         (_initialize_breakpoint): Update.
4262         * breakpoint.h (target_exact_watchpoints): Change to bool.
4263         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4264         * cli/cli-cmds.c (trace_commands): Likewise.
4265         * cli/cli-cmds.h (trace_commands): Likewise.
4266         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4267         to bool*.
4268         * cli/cli-logging.c (logging_overwrite): Change to bool.
4269         (logging_redirect): Likewise.
4270         (debug_redirect): Likewise.
4271         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4272         (struct boolean_option_def) <get_var_address_cb_>: Change return type
4273         to bool.
4274         <boolean_option_def>: Update.
4275         (struct flag_option_def): Change default type of Context to bool
4276         from int.
4277         <flag_option_def>: Change return type of var_address_cb_ to bool*.
4278         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4279         (get_setshow_command_value_string): Likewise.
4280         * cli/cli-style.c (cli_styling): Change to bool.
4281         (source_styling): Likewise.
4282         * cli/cli-style.h (source_styling): Likewise.
4283         (cli_styling): Likewise.
4284         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4285         to bool.
4286         * command.h (var_types): Update comment.
4287         (add_setshow_boolean_cmd): Change int* var argument to bool*.
4288         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4289         bool.
4290         (debug_compile_cplus_scopes): Likewise.
4291         * compile/compile-internal.h (compile_debug): Likewise.
4292         * compile/compile.c (compile_debug): Likewise.
4293         (struct compile_options) <raw>: Likewise.
4294         * cp-support.c (catch_demangler_crashes): Likewise.
4295         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4296         (usr_cmd_cris_dwarf2_cfi): Likewise.
4297         * csky-tdep.c (csky_debug): Likewise.
4298         * darwin-nat.c (enable_mach_exceptions): Likewise.
4299         * dcache.c (dcache_enabled_p): Likewise.
4300         * defs.h (info_verbose): Likewise.
4301         * demangle.c (demangle): Likewise.
4302         (asm_demangle): Likewise.
4303         * dwarf-index-cache.c (debug_index_cache): Likewise.
4304         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4305         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4306         * dwarf2read.c (check_physname): Likewise.
4307         (use_deprecated_index_sections): Likewise.
4308         (dwarf_always_disassemble): Likewise.
4309         * eval.c (overload_resolution): Likewise.
4310         * event-top.c (set_editing_cmd_var): Likewise.
4311         (exec_done_display_p): Likewise.
4312         * event-top.h (set_editing_cmd_var): Likewise.
4313         (exec_done_display_p): Likewise.
4314         * exec.c (write_files): Likewise.
4315         * fbsd-nat.c (debug_fbsd_lwp): Likewise
4316         (debug_fbsd_nat): Likewise.
4317         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4318         Likewise.
4319         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4320         <backtrace_past_entry> Likewise.
4321         * gdb-demangle.h (demangle): Likewise.
4322         (asm_demangle): Likewise.
4323         * gdb_bfd.c (bfd_sharing): Likewise.
4324         * gdbcore.h (write_files): Likewise.
4325         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4326         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4327         * gdbthread.h (print_thread_events): Likewise.
4328         * gdbtypes.c (opaque_type_resolution): Likewise.
4329         (strict_type_checking): Likewise.
4330         * gnu-nat.c (gnu_debug_flag): Likewise.
4331         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4332         * guile/scm-param.c (pascm_variable): Add boolval.
4333         (add_setshow_generic): Update.
4334         (pascm_param_value): Update.
4335         (pascm_set_param_value_x): Update.
4336         * hppa-tdep.c (hppa_debug): Change to bool..
4337         * infcall.c (may_call_functions_p): Likewise.
4338         (coerce_float_to_double_p): Likewise.
4339         (unwind_on_signal_p): Likewise.
4340         (unwind_on_terminating_exception_p): Likewise.
4341         * infcmd.c (startup_with_shell): Likewise.
4342         * inferior.c (print_inferior_events): Likewise.
4343         * inferior.h (startup_with_shell): Likewise.
4344         (print_inferior_events): Likewise.
4345         * infrun.c (step_stop_if_no_debug): Likewise.
4346         (detach_fork): Likewise.
4347         (debug_displaced): Likewise.
4348         (disable_randomization): Likewise.
4349         (non_stop): Likewise.
4350         (non_stop_1): Likewise.
4351         (observer_mode): Likewise.
4352         (observer_mode_1): Likewise.
4353         (set_observer_mode): Update.
4354         (sched_multi): Change to bool.
4355         * infrun.h (debug_displaced): Likewise.
4356         (sched_multi): Likewise.
4357         (step_stop_if_no_debug): Likewise.
4358         (non_stop): Likewise.
4359         (disable_randomization): Likewise.
4360         * linux-tdep.c (use_coredump_filter): Likewise.
4361         (dump_excluded_mappings): Likewise.
4362         * linux-thread-db.c (auto_load_thread_db): Likewise.
4363         (check_thread_db_on_load): Likewise.
4364         * main.c (captured_main_1): Update.
4365         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4366         xx2_opt, boolean_opt>: Change to bool.
4367         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4368         * maint.c (maintenance_profile_p): Likewise.
4369         (per_command_time): Likewise.
4370         (per_command_space): Likewise.
4371         (per_command_symtab): Likewise.
4372         * memattr.c (inaccessible_by_default): Likewise.
4373         * mi/mi-main.c (mi_async): Likewise.
4374         (mi_async_1): Likewise.
4375         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4376         * nat/fork-inferior.h (startup_with_shell): Likewise.
4377         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4378         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4379         * nios2-tdep.c (nios2_debug): Likewise.
4380         * or1k-tdep.c (or1k_debug): Likewise.
4381         * parse.c (parser_debug): Likewise.
4382         * parser-defs.h (parser_debug): Likewise.
4383         * printcmd.c (print_symbol_filename): Likewise.
4384         * proc-api.c (procfs_trace): Likewise.
4385         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4386         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4387         (set_parameter_value): Update.
4388         (add_setshow_generic): Update.
4389         * python/py-value.c (copy_py_bool_obj): Change argument from int*
4390         to bool*.
4391         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4392         int*.
4393         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4394         * record-btrace.c (record_btrace_target::store_registers): Update.
4395         * record-full.c (record_full_memory_query): Change to bool.
4396         (record_full_stop_at_limit): Likewise.
4397         * record-full.h (record_full_memory_query): Likewise.
4398         * remote-notif.c (notif_debug): Likewise.
4399         * remote-notif.h (notif_debug): Likewise.
4400         * remote.c (use_range_stepping): Likewise.
4401         (interrupt_on_connect): Likewise.
4402         (remote_break): Likewise.
4403         * ser-tcp.c (tcp_auto_retry): Likewise.
4404         * ser-unix.c (serial_hwflow): Likewise.
4405         * skip.c (debug_skip): Likewise.
4406         * solib-aix.c (solib_aix_debug): Likewise.
4407         * spu-tdep.c (spu_stop_on_load_p): Likewise.
4408         (spu_auto_flush_cache_p): Likewise.
4409         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4410         Likewise.
4411         (struct info_print_options) <quiet>: Likewise.
4412         * symfile-debug.c (debug_symfile): Likewise.
4413         * symfile.c (auto_solib_add): Likewise.
4414         (separate_debug_file_debug): Likewise.
4415         * symfile.h (auto_solib_add): Likewise.
4416         (separate_debug_file_debug): Likewise.
4417         * symtab.c (basenames_may_differ): Likewise.
4418         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4419         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4420         (struct info_types_options) <quiet>: Likewise.
4421         * symtab.h (demangle): Likewise.
4422         (basenames_may_differ): Likewise.
4423         * target-dcache.c (stack_cache_enabled_1): Likewise.
4424         (code_cache_enabled_1): Likewise.
4425         * target.c (trust_readonly): Likewise.
4426         (may_write_registers): Likewise.
4427         (may_write_memory): Likewise.
4428         (may_insert_breakpoints): Likewise.
4429         (may_insert_tracepoints): Likewise.
4430         (may_insert_fast_tracepoints): Likewise.
4431         (may_stop): Likewise.
4432         (auto_connect_native_target): Likewise.
4433         (target_stop_and_wait): Update.
4434         (target_async_permitted): Change to bool.
4435         (target_async_permitted_1): Likewise.
4436         (may_write_registers_1): Likewise.
4437         (may_write_memory_1): Likewise.
4438         (may_insert_breakpoints_1): Likewise.
4439         (may_insert_tracepoints_1): Likewise.
4440         (may_insert_fast_tracepoints_1): Likewise.
4441         (may_stop_1): Likewise.
4442         * target.h (target_async_permitted): Likewise.
4443         (may_write_registers): Likewise.
4444         (may_write_memory): Likewise.
4445         (may_insert_breakpoints): Likewise.
4446         (may_insert_tracepoints): Likewise.
4447         (may_insert_fast_tracepoints): Likewise.
4448         (may_stop): Likewise.
4449         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4450         (make_thread_apply_all_options_def_group): Change argument from int*
4451         to bool*.
4452         (thread_apply_all_command): Update.
4453         (print_thread_events): Change to bool.
4454         * top.c (confirm): Likewise.
4455         (command_editing_p): Likewise.
4456         (history_expansion_p): Likewise.
4457         (write_history_p): Likewise.
4458         (info_verbose): Likewise.
4459         * top.h (confirm): Likewise.
4460         (history_expansion_p): Likewise.
4461         * tracepoint.c (disconnected_tracing): Likewise.
4462         (circular_trace_buffer): Likewise.
4463         * typeprint.c (print_methods): Likewise.
4464         (print_typedefs): Likewise.
4465         * utils.c (debug_timestamp): Likewise.
4466         (sevenbit_strings): Likewise.
4467         (pagination_enabled): Likewise.
4468         * utils.h (sevenbit_strings): Likewise.
4469         (pagination_enabled): Likewise.
4470         * valops.c (overload_resolution): Likewise.
4471         * valprint.h (struct value_print_options) <prettyformat_arrays,
4472         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4473         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4474         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4475         Likewise.
4476         * windows-nat.c (new_console): Likewise.
4477         (cygwin_exceptions): Likewise.
4478         (new_group): Likewise.
4479         (debug_exec): Likewise.
4480         (debug_events): Likewise.
4481         (debug_memory): Likewise.
4482         (debug_exceptions): Likewise.
4483         (useshell): Likewise.
4484         * windows-tdep.c (maint_display_all_tib): Likewise.
4485         * xml-support.c (debug_xml): Likewise.
4486
4487 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
4488
4489         * source.c (prepare_path_for_appending): New function.
4490         (openp): Make use of new function.
4491         (find_and_open_source): Search for the compilation directory and
4492         source file as a relative path beneath the directory search path.
4493
4494 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4495
4496         * source-cache.c (source_cache::get_line_charpos): Catch
4497         exceptions and return false, this matches the behaviour documented
4498         in the header file.
4499
4500 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
4501
4502         * ada-tasks.c (info_task): Remove quoting of the task's name.
4503
4504 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
4505
4506         * symfile.c (auto_solib_add): Replace comment with a reference
4507         to the header file.
4508
4509 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
4510
4511         * NEWS: Mention that gdb can now be compiled with Python 3
4512         on Windows.
4513
4514 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4515
4516         * maint.c (maint_print_section_data::maint_print_section_data):
4517         Force use of 'float log10 (float)' by casting the argument to
4518         float.
4519
4520 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4521
4522         * maint.c: Add 'cmath' include.
4523         (struct maint_print_section_data): New structure.
4524         (print_section_index): New function.
4525         (print_bfd_section_info): Add header comment, small whitespace
4526         cleanup, and update to call new print_section_index function.
4527         (print_objfile_section_info): Likewise.
4528         (maint_obj_section_from_bfd_section): New function.
4529         (print_bfd_section_info_maybe_relocated): New function.
4530         (maintenance_info_sections): Add header comment, always use
4531         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4532
4533 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4534
4535         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4536         inner scope, add check that the objfile has psymtabs before
4537         checking psymtabs_addrmap.
4538         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4539
4540 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4541
4542         * NEWS: Announce that Ada task names are now shown at more places,
4543         and between quotes (except in info task output).
4544         * gdb/ada-tasks.c (task_to_str): New function.
4545         (display_current_task_id): Call task_to_str.
4546         (task_command_1): Likewise.
4547         (print_ada_task_info): In non-mi mode, Properly align headers and data
4548         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4549
4550 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4551
4552         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4553         prstatus.pr_lwp.pr_info instead of making it up.
4554
4555 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4556
4557         * auto-load.c (auto_load_expand_dir_vars): Update.
4558         * defs.h (gdb_datadir): Change to std::string.
4559         (python_libdir): Likewise.
4560         (relocate_gdb_directory): Change return type to std::string.
4561         * guile/guile.c (gdbscm_data_directory): Update.
4562         (initialize_scheme_side): Update.
4563         * jit.c (jit_reader_dir): Change to std::string.
4564         (jit_reader_load_command): Update.
4565         * main.c (gdb_datadir): Change to std::string.
4566         (python_libdir): Likewise.
4567         (set_gdb_data_directory): Update.
4568         (relocate_path): Change to return std::string.
4569         (relocate_gdb_directory): Change to return std::string.
4570         (relocate_gdbinit_path_maybe_in_datadir): Update.
4571         (captured_main_1): Update.
4572         * python/python.c (do_start_initialization): Update.
4573         * top.c (show_gdb_datadir): Update.
4574         * xml-syscall.c (xml_init_syscalls_info): Update.
4575         (init_syscalls_info): Update.
4576
4577 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4578
4579         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4580         out of get_init_files.
4581         (get_init_files): Update.
4582
4583 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4584
4585         * main.c (get_init_files): Change to use std::string.
4586         (captured_main_1): Update.
4587         (print_gdb_help): Update.
4588
4589 2019-09-11  Ali Tamur  <tamur@google.com>
4590
4591         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4592         implementation.
4593
4594 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4595
4596         * dbxread.c (read_dbx_symtab): Update.
4597         * dwarf2read.c (load_partial_dies): Update.
4598         * mdebugread.c (parse_partial_symbols): Update.
4599         (handle_psymbol_enumerators): Update.
4600         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4601         * psymtab.c (add_psymbol_to_bcache): Likewise.
4602         (add_psymbol_to_list): Likewise.
4603         * symtab.c (symbol_set_names): Likewise.
4604         * symtab.h (symbol_set_names): Likewise.
4605         * xcoffread.c (scan_xcoff_symtab): Update.
4606
4607 2019-09-11  Tom Tromey  <tom@tromey.com>
4608
4609         * symfile-mem.c (symbol_file_add_from_memory): Use
4610         bfd_set_filename.
4611         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4612         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4613
4614 2019-09-10  Tom Tromey  <tromey@adacore.com>
4615
4616         * dwarf-index-write.c (write_psymbols): Extend error message.
4617         (debug_names::insert): Add Ada code.
4618         (debug_names::write_psymbols): Remove Ada check.
4619         (debug_names) <m_string_obstack>: New member.
4620         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4621         (gdb_index_symbol_name_matcher::matches): Remove.
4622         (mapped_index_base::find_name_components_bounds): Add "lang"
4623         parameter.
4624         (mapped_index_base::build_name_components): Also split names
4625         according to Ada syntax.
4626         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
4627         type of "match_callback".
4628         (check_match, check_find_bounds_finds)
4629         (dw2_expand_symtabs_matching): Update.
4630         (dw2_debug_names_iterator): Add new constructor.
4631         (dw2_debug_names_map_matching_symbols): New function.
4632         (dw2_debug_names_expand_symtabs_matching): Update.
4633         (dwarf2_debug_names_functions): Use
4634         dw2_debug_names_map_matching_symbols.
4635
4636 2019-09-10  Tom Tromey  <tromey@adacore.com>
4637
4638         * dwarf2read.c (dw2_get_file_names_reader): Add the
4639         CU's file name to the results.
4640
4641 2019-09-10  Tom Tromey  <tromey@adacore.com>
4642
4643         * ada-lang.c (add_nonlocal_symbols): Combine calls to
4644         map_matching_symbols.  Update.
4645         * dwarf2read.c (dw2_map_matching_symbols): Update.
4646         * psymtab.c (match_partial_symbol): Change type; update.
4647         (psym_map_matching_symbols): Likewise.
4648         * symfile-debug.c (debug_qf_map_matching_symbols): Change
4649         type; update.
4650         * symfile.h (struct quick_symbol_functions)
4651         <map_matching_symbols>: Change "name" to be a lookup_name_info.
4652         Remove "match".
4653
4654 2019-09-10  Tom Tromey  <tromey@adacore.com>
4655
4656         * psymtab.c (map_block): Remove.
4657         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4658         * symtab.c (iterate_over_symbols_terminated): New function.
4659         * symtab.c (iterate_over_symbols_terminated): Declare.
4660
4661 2019-09-10  Tom Tromey  <tromey@adacore.com>
4662
4663         * ada-lang.c (ada_iterate_over_symbols): Return bool.
4664         * language.h (struct language_defn) <la_iterate_over_symbols>:
4665         Return bool.
4666         * symtab.c (iterate_over_symbols): Return bool.
4667         * symtab.h (iterate_over_symbols): Return bool.
4668
4669 2019-09-10  Tom Tromey  <tromey@adacore.com>
4670
4671         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4672         (add_nonlocal_symbols): Update.
4673         * dwarf2read.c (dw2_map_matching_symbols): Change type.
4674         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4675         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4676         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4677         Change type of "callback".  Remove "data".
4678
4679
4680 2019-09-09  Ali Tamur  <tamur@google.com>
4681
4682         * dwarf2read.c (comp_unit_head): Update comment.
4683         (dwarf2_dwo_name): New function declaration.
4684         (dwarf_unit_type_name): New function declaration.
4685         (read_comp_unit_head): Add support for new compilation units,
4686         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4687         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4688         (currently named as "signature") in their header. Also clarify error
4689         messages.
4690         (lookup_dwo_id): New function. Returns the dwo id of the given
4691         compile unit.
4692         (lookup_dwo_unit): Use the new lookup_dwo_id function.
4693         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4694         functions.
4695         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4696         (dwarf2_dwo_name): Get the dwo name if present.
4697         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4698         purposes.
4699
4700 2019-09-09  Tom Tromey  <tom@tromey.com>
4701
4702         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4703
4704 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4705
4706         * python/python.c (do_start_initialization): Make progname_copy static,
4707         to avoid a leak report.
4708
4709 2019-09-08  Tom Tromey  <tom@tromey.com>
4710
4711         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4712
4713 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
4714
4715         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4716         Change type to gdb::optional<block_enum>.
4717         (dw2_symtab_iter_init): Change block_index parameter type
4718         to gdb::optional<block_enum>.
4719         (dw2_lookup_symbol): Change block_index parameter
4720         type to block_enum.c
4721         (dw2_debug_names_lookup_symbol): Likewise.
4722         * psymtab.c (psym_lookup_symbol): Likewise.
4723         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4724         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4725         Likewise.
4726
4727 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
4728
4729         * defs.h (relocate_gdb_directory): Change int to bool in
4730         signature and rename flag to relocatable.
4731         * main.c (relocate_path): Likewise.
4732         (relocate_gdb_directory): Likewise.
4733
4734 2019-09-06  Alan Modra  <amodra@gmail.com>
4735
4736         * coffread.c (coff_symfile_read): Constify filename variable.
4737         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4738         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4739         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4740         * solib.c (reload_shared_libraries_1): Likewise.
4741         * symfile.c (reread_symbols): Likewise.
4742         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4743         * solib-darwin.c (darwin_bfd_open): Likewise.
4744         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4745
4746 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4747
4748         * psymtab.c (print_partial_symbols): Handle missing domain_enum
4749         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4750
4751 2019-09-03  Tom Tromey  <tromey@adacore.com>
4752
4753         * ada-valprint.c (ada_val_print_num): Don't recurse for range
4754         types.
4755         (has_negatives): Unbias a range type bound.
4756         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4757         * gdbtypes.c (operator==): Handle new field.
4758         (create_range_type): Add "bias" parameter.
4759         (create_static_range_type, resolve_dynamic_range): Update.
4760         * gdbtypes.h (struct range_bounds) <bias>: New member.
4761         (create_range_type): Add bias parameter.
4762         * printcmd.c (print_scalar_formatted): Unbias range types.
4763         * value.c (unpack_long): Unbias range types.
4764         (pack_long): Bias range types.
4765
4766 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4767
4768         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4769         probe arguments.
4770
4771 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4772
4773         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4774         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4775         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4776         (compile_probe_arg): Likewise.
4777         * probe.h (get_argument_count): Likewise.
4778         * solib-svr4.c (solib_event_probe_action): Likewise.
4779         * stap-probe.c (stap_probe::get_argument_count): Likewise.
4780
4781 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4782
4783         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4784         code to here...
4785         (svr4_create_solib_event_breakpoints): ...from here.
4786
4787 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
4788
4789         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4790         suffix from warning message.
4791
4792 2019-08-30  Tom Tromey  <tom@tromey.com>
4793
4794         * tui/tui-winsource.h (struct tui_source_window_base)
4795         <refresh_all>: Don't declare.
4796         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4797         Remove.
4798         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4799         tui_show_locator_content.
4800         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4801         declare.
4802         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4803         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4804         declare.
4805
4806 2019-08-30  Tom Tromey  <tom@tromey.com>
4807
4808         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4809
4810 2019-08-30  Tom Tromey  <tom@tromey.com>
4811
4812         * tui/tui-stack.c (_initialize_tui_stack): Move later.
4813         Remove unnecessary forward declarations.
4814
4815 2019-08-30  Tom Tromey  <tom@tromey.com>
4816
4817         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4818         rerender.
4819         (tui_update_locator_fullname, tui_show_frame_info): Don't call
4820         tui_show_locator_content.
4821
4822 2019-08-30  Tom Tromey  <tom@tromey.com>
4823
4824         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
4825         (tui_locator_window::rerender): Rewrite using body of previous
4826         tui_show_locator_content.
4827
4828 2019-08-30  Tom Tromey  <tom@tromey.com>
4829
4830         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4831         set_locator_fullname>: New methods.
4832         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4833         Rename from tui_set_locator_fullname.
4834         (tui_locator_window::set_locator_info): Rename from
4835         tui_set_locator_info.  Return bool.
4836         (tui_update_locator_fullname, tui_show_frame_info): Update.
4837
4838 2019-08-30  Tom Tromey  <tom@tromey.com>
4839
4840         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4841
4842 2019-08-30  Tom Tromey  <tom@tromey.com>
4843
4844         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4845         call touchwin.
4846
4847 2019-08-30  Tom Tromey  <tom@tromey.com>
4848
4849         * tui/tui-wingeneral.c (box_win): Assume win_info and
4850         win_info->handle cannot be NULL.
4851
4852 2019-08-30  Tom Tromey  <tom@tromey.com>
4853
4854         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4855         refresh_window>: Declare.
4856         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4857         resize.
4858         (tui_data_item_window::rerender): Rename from
4859         tui_display_register.
4860         (tui_data_item_window::refresh_window): New method.
4861         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4862         no-op.
4863
4864 2019-08-30  Tom Tromey  <tom@tromey.com>
4865
4866         * tui/tui-regs.h (struct tui_data_window) <regs_content,
4867         regs_column_count, current_group>: Move later.  Now private.
4868         <get_current_group>: New method.
4869         * tui/tui-regs.c (tui_reg_command): Update.
4870         * tui/tui-layout.c (tui_set_layout): Update.
4871
4872 2019-08-30  Tom Tromey  <tom@tromey.com>
4873
4874         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4875         (tui_data_window::rerender): Don't call
4876         check_and_display_highlight_if_needed.
4877         (tui_data_window::refresh_all): Remove call to
4878         erase_data_content.
4879
4880 2019-08-30  Tom Tromey  <tom@tromey.com>
4881
4882         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4883         (tui_data_window::display_registers_from)
4884         (tui_data_window::display_reg_element_at_line)
4885         (tui_data_window::display_registers_from_line): Remove checks of
4886         "empty".
4887
4888 2019-08-30  Tom Tromey  <tom@tromey.com>
4889
4890         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4891         Don't declare.
4892         * tui/tui-regs.c (tui_data_window::show_registers): Call
4893         rerender.
4894         (tui_data_window::rerender): Rename from display_all_data.
4895         (tui_data_window::rerender): Remove old implementation.
4896
4897 2019-08-30  Tom Tromey  <tom@tromey.com>
4898
4899         * tui/tui-regs.c (tui_data_window::display_all_data): Change
4900         text.
4901         * tui/tui-data.h (NO_DATA_STRING): Remove define.
4902
4903 2019-08-29  Bernhard Wodok  <barto@gmx.net>
4904             Sergio Durigan Junior  <sergiodj@redhat.com>
4905
4906         PR win32/24284
4907         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4908
4909 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4910
4911         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4912         when searching for types.
4913
4914 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4915
4916         * f-lang.c (f_language_defn): Use f_print_typedef.
4917         * f-lang.h (f_print_typedef): Declare.
4918         * f-typeprint.c (f_print_typedef): Define.
4919
4920 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
4921
4922         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4923
4924 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4925
4926         * cli/cli-utils.c (info_print_options_defs): Delete.
4927         (make_info_print_options_def_group): Delete.
4928         (extract_info_print_options): Delete.
4929         (info_print_command_completer): Delete.
4930         (info_print_args_help): Add extra parameter, and optionally
4931         include text about -n flag.
4932         * cli/cli-utils.h (struct info_print_options): Delete.
4933         (extract_info_print_options): Delete declaration.
4934         (info_print_command_completer): Delete declaration.
4935         (info_print_args_help): Add extra parameter, extend header
4936         comment.
4937         * python/python.c (gdbpy_rbreak): Pass additional parameter to
4938         search_symbols.
4939         * stack.c (struct info_print_options): New type.
4940         (info_print_options_defs): New file scoped variable.
4941         (make_info_print_options_def_group): New static function.
4942         (info_print_command_completer): New static function.
4943         (info_locals_command): Update to use new local functions.
4944         (info_args_command): Likewise.
4945         (_initialize_stack): Add extra parameter to calls to
4946         info_print_args_help.
4947         * symtab.c (search_symbols): Add extra parameter, use this to
4948         possibly excluse non-debug symbols.
4949         (symtab_symbol_info): Add extra parameter, which is passed on to
4950         search_symbols.
4951         (struct info_print_options): New type.
4952         (info_print_options_defs): New file scoped variable.
4953         (make_info_print_options_def_group): New static function.
4954         (info_print_command_completer): New static function.
4955         (info_variables_command): Update to use local functions, and pass
4956         extra parameter through to symtab_symbol_info.
4957         (info_functions_command): Likewise.
4958         (info_types_command): Pass additional argument through to
4959         symtab_symbol_info.
4960         (rbreak_command): Pass extra argument to search_symbols.
4961         (_initialize_symtab): Add extra arguments for calls to
4962         info_print_args_help, and update help text for 'info variables',
4963         'whereis', and 'info functions' commands.
4964         * symtab.h (search_symbols): Add extra argument to declaration.
4965         * NEWS: Mention new flags.
4966
4967 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
4968
4969         * symtab.c (lookup_static_symbol): Call the new function (and move
4970         it down to be next to lookup_global_symbol).
4971         (struct global_sym_lookup_data): Add block_enum member and rename to...
4972         (struct global_or_static_sym_lookup_data): ...this.
4973         (lookup_symbol_global_iterator_cb): Pass block_index instead of
4974         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4975         (lookup_symbol_global_or_static_iterator_cb): ...this.
4976         (lookup_global_or_static_symbol): New function.
4977         (lookup_global_symbol): Call new function.
4978
4979 2019-08-26  Tom de Vries  <tdevries@suse.de>
4980
4981         PR c++/24852
4982         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4983         when pc_probe.prob == NULL.
4984
4985 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4986
4987         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4988         variable symbol_linkage to symbol_linkage_.
4989
4990 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4991
4992         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4993         represent whether the symbol is static, dynamic, or we don't
4994         know.
4995
4996 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
4997
4998         * gdb/rx-tdep.c (rx_register_names): New.
4999         (rx_register_name): Delete.
5000         (rx_psw_type): Delete.
5001         (rx_fpsw_type): Delete.
5002         (rx_register_type): Delete.
5003         (rx_gdbarch_init): Convert target-descriptions.
5004         (_initialize_rx_tdep): Add initialize_tdesc_rx.
5005         * gdb/features/Makefile: Add rx.xml.
5006         * gdb/features/rx.xml: New.
5007         * gdb/features/rx.c: Generated.
5008         * gdb/NEWS: Mention target description support.
5009
5010 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5011
5012         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5013         *slot_ptr.
5014
5015 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5016
5017         * configure.ac: Don't check for 'dlfcn.h' (moved to
5018         gdbsupport/common.m4).
5019         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5020         'gdbsupport/'.
5021         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5022         * compile/compile-c-support.c: Include
5023         'gdbsupport/gdb-dlfcn.h'.
5024         * gdbsupport/common.m4: Check for 'dlfcn.h'.
5025         * gdb-dlfcn.c: Move to...
5026         * gdbsupport/gdb-dlfcn.c: ... here.
5027         * gdb-dlfcn.h: Move to...
5028         * gdbsupport/gdb-dlfcn.h: ... here.
5029
5030 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
5031
5032         * nios2-tdep.c (struct reg_value): Improve comments.  Make
5033         the offset field signed.
5034
5035 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5036
5037         * python/lib/gdb/__init__.py (_execute_file): New function.
5038         * python/python.c (python_run_simple_file): Call gdb._execute_file
5039         on Windows.
5040
5041 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5042
5043         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5044         all uses as this was never set to anything but a zero value.
5045
5046 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
5047
5048         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5049
5050 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
5051
5052         * tui/tui-data.h (tui_gen_win_info): Add an =default
5053         move constructor, required by some GCC versions.
5054
5055 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
5056
5057         * go32-nat.c (go32_sysinfo): Add hygon_p.
5058
5059 2019-08-20  Tom Tromey  <tom@tromey.com>
5060
5061         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5062         line_from_reg_element_no, first_reg_element_no_inline,
5063         display_all_data, delete_data_content_windows,
5064         erase_data_content>: Now private.
5065
5066 2019-08-20  Tom Tromey  <tom@tromey.com>
5067
5068         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5069         (tui_unhighlight_win, tui_highlight_win)
5070         (tui_win_info::make_window): Update.
5071         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5072
5073 2019-08-20  Tom Tromey  <tom@tromey.com>
5074
5075         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5076         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5077         (MAX_PID_WIDTH): Move to tui-stack.c.
5078         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5079         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5080         (MAX_PID_WIDTH): Move from tui-data.h.
5081
5082 2019-08-20  Tom Tromey  <tom@tromey.com>
5083
5084         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5085         * tui/tui-wingeneral.c (box_win): Change type of win_info.
5086         (box_win): Update.
5087         (tui_gen_win_info::make_window): Rename from tui_make_window.
5088         (tui_win_info::make_window): New method.
5089         (tui_gen_win_info::make_visible): Update.
5090         * tui/tui-source.c (tui_source_window::set_contents): Update.
5091         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5092         (tui_data_window::display_registers_from): Update.
5093         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5094         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5095         Declare.
5096         <can_box>: Remove.
5097         <title>: Remove.
5098         (struct tui_win_info) <make_window>: Declare.
5099         <can_box>: Now virtual.
5100         <title>: New member.
5101         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5102         * tui/tui-command.c (tui_cmd_window::resize): Update.
5103
5104 2019-08-20  Tom Tromey  <tom@tromey.com>
5105
5106         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5107         * tui/tui-regs.c (tui_data_window::show_registers): Update.
5108         (tui_data_window::check_register_values): Update.
5109
5110 2019-08-20  Tom Tromey  <tom@tromey.com>
5111
5112         * tui/tui-regs.h (struct tui_data_window): Use
5113         DISABLE_COPY_AND_ASSIGN.
5114         <regs_content>: Change type, removing unique_ptr.
5115         <tui_data_window>: Add move constructor.
5116         * tui/tui-regs.c (tui_data_window::show_registers)
5117         (tui_data_window::show_register_group)
5118         (tui_data_window::display_registers_from)
5119         (tui_data_window::display_registers_from)
5120         (tui_data_window::first_data_item_displayed)
5121         (tui_data_window::delete_data_content_windows)
5122         (tui_data_window::rerender, tui_data_window::refresh_window)
5123         (tui_data_window::check_register_values): Update.
5124
5125 2019-08-20  Tom Tromey  <tom@tromey.com>
5126
5127         * tui/tui-regs.h (struct tui_data_window) <show_registers,
5128         show_register_group>: Declare.
5129         (tui_show_register_group): Don't declare.
5130         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5131         tui_show_registers.
5132         (tui_data_window::show_register_group): Rename from
5133         tui_show_register_group.
5134         (tui_data_window::check_register_values, tui_reg_command):
5135         Update.
5136         * tui/tui-layout.c (tui_set_layout): Update.
5137
5138 2019-08-20  Tom Tromey  <tom@tromey.com>
5139
5140         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5141         Declare.
5142         (tui_check_register_values): Don't declare.
5143         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5144         from tui_check_register_values.
5145         * tui/tui-hooks.c (tui_register_changed): Update.
5146
5147 2019-08-20  Tom Tromey  <tom@tromey.com>
5148
5149         * tui/tui-regs.c (tui_reg_layout): Move later.
5150         (tui_show_registers): Don't enable TUI mode or change layout.
5151
5152 2019-08-20  Tom Tromey  <tom@tromey.com>
5153
5154         * tui/tui-regs.h (struct tui_data_item_window)
5155         <~tui_data_item_window>: Remove.
5156         <content>: Now a unique_xmalloc_ptr.
5157         * tui/tui-regs.c (tui_register_format): Return a
5158         unique_xmalloc_ptr.
5159         (tui_get_register): Update.
5160         (~tui_data_item_window): Remove.
5161         (tui_data_window::display_registers_from, tui_display_register):
5162         Update.
5163         * tui/tui-io.h (tui_expand_tabs): Update.
5164         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5165         Remove "col" parameter.
5166
5167 2019-08-20  Tom Tromey  <tom@tromey.com>
5168
5169         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5170         field.
5171         * tui/tui-regs.c (~tui_data_item_window): Update.
5172
5173 2019-08-20  Tom Tromey  <tom@tromey.com>
5174
5175         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5176         earlier.
5177
5178 2019-08-20  Tom Tromey  <tom@tromey.com>
5179
5180         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5181
5182 2019-08-20  Tom Tromey  <tom@tromey.com>
5183
5184         * tui/tui-source.h (struct tui_source_window): Update.
5185         * tui/tui-regs.c (tui_show_registers): Update.
5186         * tui/tui-disasm.h (struct tui_disasm_window): Update.
5187         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5188         (NO_REGS_STRING): Remove defines.
5189
5190 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
5191
5192         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5193         unnecessary thread walk if remote doesn't support the packet.
5194
5195 2019-08-19  Tom Tromey  <tromey@adacore.com>
5196
5197         * python/py-value.c (value_has_field): Fix indentation.
5198
5199 2019-08-19  Tom Tromey  <tromey@adacore.com>
5200
5201         * printcmd.c (do_one_display, info_display_command): Update.
5202         * block.h (contained_in): Return bool.  Add allow_nested
5203         parameter.
5204         * block.c (contained_in): Return bool.  Add allow_nested
5205         parameter.
5206
5207 2019-08-19  Tom Tromey  <tom@tromey.com>
5208
5209         * configure: Rebuild.
5210         * configure.ac: Disallow the combination of -static-libstdc++ and
5211         source highlight.
5212         * source-cache.c (get_language_name): Handle rust.
5213         (source_cache::get_source_lines): Ignore highlighting exceptions.
5214
5215 2019-08-16  Tom Tromey  <tom@tromey.com>
5216
5217         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5218         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5219         (struct tui_source_window_base) <make_visible, refresh_window,
5220         resize>: Remove methods.
5221         <execution_info>: Remove field.
5222         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5223         (tui_show_source_line, tui_source_window_base)
5224         (~tui_source_window_base): Update.
5225         (tui_source_window_base::resize)
5226         (tui_source_window_base::make_visible)
5227         (tui_source_window_base::refresh_window): Remove.
5228         (tui_source_window_base::update_exec_info): Update.
5229         * tui/tui-source.c (tui_source_window::set_contents): Update.
5230         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5231
5232 2019-08-16  Tom Tromey  <tom@tromey.com>
5233
5234         * tui/tui-hooks.c (tui_remove_hooks): Don't set
5235         deprecated_query_hook.
5236
5237 2019-08-16  Tom Tromey  <tom@tromey.com>
5238
5239         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5240         (tui_update_source_windows_with_line): Update.
5241         * tui/tui-source.h (struct tui_source_window)
5242         <show_symtab_source>: Declare.
5243         (tui_show_symtab_source): Don't declare.
5244         * tui/tui-source.c (tui_show_symtab_source): Rename from
5245         tui_show_symtab_source.
5246
5247 2019-08-16  Tom Tromey  <tom@tromey.com>
5248
5249         * tui/tui-winsource.h (struct tui_source_window_base)
5250         <set_contents>: Declare.
5251         * tui/tui-winsource.c
5252         (tui_source_window_base::update_source_window_as_is): Update.
5253         * tui/tui-source.h (struct tui_source_window) <set_contents>:
5254         Declare.
5255         (tui_set_source_content): Don't declare.
5256         * tui/tui-source.c (tui_source_window::set_contents): Rename from
5257         tui_set_source_content.
5258         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5259         Declare.
5260         (tui_set_disassem_content): Don't declare.
5261         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5262         tui_set_disassem_content.
5263
5264 2019-08-16  Tom Tromey  <tom@tromey.com>
5265
5266         * tui/tui-winsource.h (struct tui_source_window_base)
5267         <update_breakpoint_info>: Declare.
5268         (tui_update_breakpoint_info): Don't declare.
5269         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5270         (tui_update_all_breakpoint_info): Update.
5271         (tui_source_window_base::update_breakpoint_info): Rename from
5272         tui_update_breakpoint_info.
5273         (tui_source_window_base::update_exec_info): Update.
5274
5275 2019-08-16  Tom Tromey  <tom@tromey.com>
5276
5277         * tui/tui-winsource.h (struct tui_source_window_base)
5278         <update_source_window>: Declare.
5279         (tui_update_source_window): Don't declare.
5280         * tui/tui-winsource.c
5281         (tui_source_window_base::update_source_window): Rename from
5282         tui_update_source_window.
5283         (tui_source_window_base::rerender): Update.
5284         * tui/tui-source.c (tui_source_window::maybe_update): Update.
5285         * tui/tui-disasm.c (tui_show_disassem)
5286         (tui_show_disassem_and_update_source)
5287         (tui_disasm_window::maybe_update): Update.
5288
5289 2019-08-16  Tom Tromey  <tom@tromey.com>
5290
5291         * tui/tui-winsource.h (struct tui_source_window_base)
5292         <update_source_window_as_is>: Declare.
5293         (tui_update_source_window_as_is): Don't declare.
5294         * tui/tui-winsource.c (tui_update_source_window): Update
5295         (tui_source_window_base::update_source_window_as_is): Rename from
5296         tui_update_source_window_as_is.
5297         (tui_source_window_base::refill): Update.
5298         * tui/tui-source.c (tui_show_symtab_source): Update.
5299         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5300         Update.
5301
5302 2019-08-16  Tom Tromey  <tom@tromey.com>
5303
5304         * tui/tui-winsource.h (tui_update_source_window)
5305         (tui_update_source_window_as_is): Remove "noerror" parameter.
5306         * tui/tui-winsource.c (tui_update_source_window)
5307         (tui_update_source_window_as_is): Remove "noerror" parameter.
5308         (tui_update_source_windows_with_addr)
5309         (tui_update_source_windows_with_line)
5310         (tui_source_window_base::rerender)
5311         (tui_source_window_base::refill): Update.
5312         * tui/tui-source.h (tui_set_source_content)
5313         (tui_show_symtab_source): Remove "noerror" parameter.
5314         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5315         parameter.
5316         (tui_show_symtab_source): Likewise.
5317         (tui_source_window::maybe_update): Update.
5318         * tui/tui-disasm.c (tui_show_disassem)
5319         (tui_show_disassem_and_update_source)
5320         (tui_disasm_window::do_scroll_vertical)
5321         (tui_disasm_window::maybe_update): Update.
5322
5323 2019-08-16  Tom Tromey  <tom@tromey.com>
5324
5325         * tui/tui.c (tui_is_window_visible): Update.
5326         * tui/tui-wingeneral.c (tui_make_window)
5327         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5328         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5329         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5330         (tui_set_win_height_command, parse_scrolling_args): Update.
5331         * tui/tui-source.c (tui_source_window::style_changed): Update.
5332         * tui/tui-regs.c (tui_show_registers)
5333         (tui_data_window::first_data_item_displayed)
5334         (tui_data_window::delete_data_content_windows)
5335         (tui_check_register_values, tui_reg_command): Update.
5336         * tui/tui-disasm.c (tui_show_disassem): Update.
5337         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5338         method.
5339         <is_visible>: Remove field.
5340         * tui/tui-data.c (tui_next_win, tui_prev_win)
5341         (tui_delete_invisible_windows): Update.
5342
5343 2019-08-16  Tom Tromey  <tom@tromey.com>
5344
5345         * tui/tui-winsource.h (struct tui_source_window_base)
5346         <m_has_locator>: Remove.
5347         * tui/tui-layout.c (show_source_disasm_command, show_data)
5348         (show_source_or_disasm_and_command): Update.
5349
5350 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
5351
5352         * NEWS (Other MI changes): New subsection.
5353         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5354         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5355         * arch-utils.c (default_get_pc_address_flags): New function.
5356         * arch-utils.h (default_get_pc_address_flags): New declaration.
5357         * gdbarch.sh: Add get_pc_address_flags.
5358         * gdbarch.c: Regenerate.
5359         * gdbarch.h: Likewise.
5360         * stack.c (print_pc): New function.
5361         (print_frame_info) (print_frame): Call print_pc.
5362
5363 2019-08-16  Tom de Vries  <tdevries@suse.de>
5364
5365         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5366         print_objfile_section_info.
5367
5368 2019-08-15  Tom Tromey  <tom@tromey.com>
5369
5370         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5371         calling update_cmdwin_start_line.
5372         * tui/tui-winsource.h (struct tui_source_window_base)
5373         <do_make_visible_with_new_height, set_new_height>: Don't declare.
5374         <rerender>: Declare.
5375         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5376         Call rerender.
5377         (tui_source_window_base::set_new_height): Remove.
5378         (tui_source_window_base::rerender): Rename from
5379         do_make_visible_with_new_height.
5380         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5381         resize method.
5382         (tui_win_info::make_invisible_and_set_new_height)
5383         (tui_win_info::make_visible_with_new_height): Remove.
5384         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5385         Declare.
5386         * tui/tui-stack.c (tui_locator_window::rerender): New method.
5387         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5388         do_make_visible_with_new_height>: Don't declare.
5389         <rerender>: Declare.
5390         * tui/tui-regs.c (tui_data_window::rerender): Rename from
5391         set_new_height.
5392         (tui_data_window::do_make_visible_with_new_height): Remove.
5393         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5394         call tui_show_locator_content.
5395         (tui_gen_win_info::resize): Call rerender.
5396         (show_source_or_disasm_and_command): Don't call
5397         tui_show_locator_content.
5398         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5399         method.
5400         (struct tui_win_info) <rerender>: Declare.
5401         <set_new_height, make_invisible_and_set_new_height,
5402         make_visible_with_new_height>: Don't declare.
5403         * tui/tui-data.c (tui_win_list::rerender): New method.
5404         * tui/tui-command.h (struct tui_cmd_window)
5405         <do_make_visible_with_new_height>: Don't declare.
5406         * tui/tui-command.c
5407         (tui_cmd_window::do_make_visible_with_new_height): Remove.
5408
5409 2019-08-15  Tom Tromey  <tromey@adacore.com>
5410
5411         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5412         * ada-lang.c (ada_enum_name): Likewise.
5413
5414 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
5415
5416         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5417         leading underscore.
5418         (GdbOutputErrorFile): Likewise.
5419         (global scope): Adjust constructor calls to GdbOutput{,Error}File
5420         accordingly.
5421         (execute_unwinders): Rename to have a leading underscore.
5422         (auto_load_packages): Likewise.
5423         (global scope): Adjust call to auto_load_packages accordingly.
5424         (GdbSetPythonDirectory): Likewise.
5425         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5426         instead of execute_unwinders.
5427
5428 2019-08-15  Tom Tromey  <tom@tromey.com>
5429
5430         * tui/tui-layout.c (show_layout, show_source_disasm_command)
5431         (show_data): Don't change window visibility.
5432         (tui_gen_win_info::resize): Remove special case for command
5433         window.  Use wresize, when available.
5434         (show_source_or_disasm_and_command): Don't change window
5435         visibility.
5436         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5437         <make_visible>: New method.
5438         * tui/tui-command.c (tui_cmd_window::resize): New method.
5439
5440 2019-08-15  Tom Tromey  <tom@tromey.com>
5441
5442         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5443         (struct tui_source_windows): New.
5444         * tui/tui-winsource.c (tui_display_main): Update.
5445         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5446         (new_height_ok, parse_scrolling_args): Update.
5447         * tui/tui-layout.c (show_layout, show_data): Update.
5448         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5449         (tui_add_to_source_windows): Don't declare.
5450         * tui/tui-data.c (source_windows, tui_source_windows)
5451         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5452
5453 2019-08-15  Tom Tromey  <tom@tromey.com>
5454
5455         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5456         Rename from reset.
5457         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5458         * tui/tui-layout.c (show_source_disasm_command, show_data):
5459         Update.
5460         (tui_gen_win_info::resize): Rename.
5461         (show_source_or_disasm_and_command): Update.
5462         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5463         reset.
5464
5465 2019-08-15  Tom Tromey  <tom@tromey.com>
5466
5467         * tui/tui-stack.c (tui_initialize_static_data): Remove.
5468         * tui/tui-interp.c (tui_interp::init): Don't call
5469         tui_initialize_static_data.
5470         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5471
5472 2019-08-15  Tom Tromey  <tom@tromey.com>
5473
5474         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5475         examine tui_win_list.
5476
5477 2019-08-15  Tom Tromey  <tom@tromey.com>
5478
5479         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5480         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5481         tui_clear_source_content.
5482         (tui_clear_source_content): Remove.
5483         (tui_source_window_base::do_erase_source_content): Hoist call to
5484         content.clear().
5485         * tui/tui-stack.c (tui_show_frame_info): Don't call
5486         tui_clear_source_content.
5487
5488 2019-08-15  Tom Tromey  <tom@tromey.com>
5489
5490         * tui/tui-winsource.h (struct tui_source_window_base)
5491         <do_erase_source_content>: New method.
5492         <erase_source_content>: New method.
5493         (tui_erase_source_content): Don't declare.
5494         * tui/tui-winsource.c (tui_clear_source_content): Update.
5495         (tui_source_window_base::do_erase_source_content): Rename from
5496         tui_erase_source_content.
5497         (tui_source_window_base::show_source_content): Update.
5498         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5499         * tui/tui-source.h (struct tui_source_window)
5500         <erase_source_content>: New method.
5501         * tui/tui-disasm.h (struct tui_disasm_window)
5502         <erase_source_content>: New method.
5503
5504 2019-08-15  Tom Tromey  <tom@tromey.com>
5505
5506         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5507         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5508         constructor.
5509         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5510         * tui/tui-source.c (tui_set_source_content): Update.
5511         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5512
5513 2019-08-15  Tom Tromey  <tom@tromey.com>
5514
5515         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5516         * tui/tui-winsource.c (tui_line_is_displayed): Move to
5517         tui-source.c.
5518         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5519         Declare.
5520         * tui/tui-source.c (tui_source_window::line_is_displayed): New
5521         method.
5522         (tui_source_window::maybe_update): Update.
5523
5524 2019-08-15  Tom Tromey  <tom@tromey.com>
5525
5526         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5527         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5528         tui-disasm.c.
5529         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5530         Declare.
5531         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5532         method.
5533         (tui_disasm_window::maybe_update): Update.
5534
5535 2019-08-15  Tom Tromey  <tom@tromey.com>
5536
5537         * tui/tui-winsource.h (struct tui_source_window_base)
5538         <maybe_update>: Declare.
5539         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5540         method.
5541         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5542         Declare.
5543         * tui/tui-source.c (tui_source_window::maybe_update): New method.
5544         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5545         Declare.
5546         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5547
5548 2019-08-15  Tom Tromey  <tom@tromey.com>
5549
5550         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5551
5552 2019-08-15  Tom Tromey  <tom@tromey.com>
5553
5554         * tui/tui-wingeneral.c: Include tui-stack.h.
5555         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5556         (struct tui_locator_window): Move from tui-data.h.
5557         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5558         (tui_initialize_static_data): Move from tui-data.c.
5559         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5560         (struct tui_locator_window): Move to tui-stack.c.
5561         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5562         (tui_initialize_static_data): Move to tui-stack.c.
5563
5564 2019-08-15  Tom Tromey  <tom@tromey.com>
5565
5566         * tui/tui-layout.c (show_source_disasm_command)
5567         (show_source_or_disasm_and_command): Use make_visible method, not
5568         tui_make_window.
5569         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5570         Remove.
5571
5572 2019-08-15  Tom Tromey  <tom@tromey.com>
5573
5574         * tui/tui-wingeneral.h (tui_make_window): Update.
5575         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5576         parameter.
5577         (tui_gen_win_info::make_visible): Update.
5578         * tui/tui-regs.c (tui_data_window::display_registers_from):
5579         Update.
5580         * tui/tui-layout.c (show_source_disasm_command)
5581         (show_source_or_disasm_and_command): Update.
5582         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5583         (enum tui_box): Remove.
5584         (struct tui_win_info) <can_box>: New method.
5585         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5586         method.
5587
5588 2019-08-15  Tom de Vries  <tdevries@suse.de>
5589
5590         * linux-nat-trad.c: Include gdbarch.h.
5591
5592 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
5593
5594         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5595         register sizes.
5596
5597 2019-08-14  Tom Tromey  <tromey@adacore.com>
5598
5599         * darwin-nat.c: Include gdbarch.h.
5600         * darwin-nat-info.c: Include gdbarch.h.
5601
5602 2019-08-13  Tom Tromey  <tom@tromey.com>
5603
5604         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5605         Remove.
5606         * tui/tui-data.c (tui_initialize_static_data): Update.
5607
5608 2019-08-13  Tom Tromey  <tom@tromey.com>
5609
5610         * tui/tui-winsource.h (struct tui_exec_info_window)
5611         <~tui_exec_info_window, maybe_allocate_content, get_content,
5612         m_content>: Remove.
5613         (struct tui_source_window_base) <set_exec_info_content,
5614         show_exec_info_content>: Don't declare.
5615         * tui/tui-winsource.c
5616         (tui_exec_info_window::maybe_allocate_content): Remove.
5617         (tui_source_window_base::update_exec_info): Rename from
5618         set_exec_info_content.
5619         (tui_source_window_base::show_exec_info_content)
5620         (tui_source_window_base::update_exec_info): Remove.
5621
5622 2019-08-13  Tom Tromey  <tom@tromey.com>
5623
5624         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5625         declare.
5626         * tui/tui-winsource.c (tui_update_source_window_as_is)
5627         (tui_update_source_windows_with_addr, tui_erase_source_content):
5628         Update.
5629         (tui_clear_exec_info_content): Remove.
5630
5631 2019-08-13  Tom Tromey  <tom@tromey.com>
5632
5633         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5634         declare.
5635         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5636         call tui_erase_exec_info_content.
5637         (tui_clear_exec_info_content): Rename from
5638         tui_erase_exec_info_content.
5639         (tui_clear_exec_info_content): Delete.
5640
5641 2019-08-13  Tom Tromey  <tom@tromey.com>
5642
5643         * tui/tui-winsource.h (struct tui_source_window_base)
5644         <show_exec_info_content>: Declare.
5645         (tui_show_exec_info_content): Don't declare.
5646         * tui/tui-winsource.c
5647         (tui_source_window_base::show_exec_info_content): Rename from
5648         tui_show_exec_info_content.
5649         (tui_source_window_base::update_exec_info): Update.
5650
5651 2019-08-13  Tom Tromey  <tom@tromey.com>
5652
5653         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5654         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5655         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5656         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5657         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5658         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5659         ... here.
5660
5661 2019-08-13  Tom Tromey  <tom@tromey.com>
5662
5663         * tui/tui-winsource.h (struct tui_source_window_base)
5664         <update_exec_info>: Declare.
5665         (tui_update_exec_info): Don't declare.
5666         * tui/tui-winsource.c (tui_update_source_window_as_is)
5667         (tui_source_window_base::refresh_all)
5668         (tui_update_all_breakpoint_info): Update.
5669         (tui_source_window_base::update_exec_info): Rename from
5670         tui_update_exec_info.
5671         * tui/tui-stack.c (tui_show_frame_info): Update.
5672
5673 2019-08-13  Tom Tromey  <tom@tromey.com>
5674
5675         * tui/tui-winsource.h (struct tui_source_window_base)
5676         <set_exec_info_content>: Declare.
5677         (tui_set_exec_info_content): Don't declare.
5678         * tui/tui-winsource.c
5679         (tui_source_window_base::set_exec_info_content): Rename from
5680         tui_set_exec_info_content.
5681         (tui_update_exec_info): Update.
5682
5683 2019-08-13  Tom Tromey  <tom@tromey.com>
5684
5685         * tui/tui-winsource.h (struct tui_source_window_base)
5686         <show_source_content>: Declare.
5687         (tui_show_source_content): Don't declare.
5688         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5689         (tui_source_window_base::show_source_content): Rename from
5690         tui_show_source_content.
5691         (tui_source_window_base::refresh_all): Update.
5692         * tui/tui-layout.c (show_source_disasm_command)
5693         (show_source_or_disasm_and_command): Update.
5694
5695 2019-08-13  Tom Tromey  <tom@tromey.com>
5696
5697         * tui/tui-winsource.c (tui_erase_source_content)
5698         (tui_show_source_content, tui_source_window_base::refresh_all):
5699         Update.
5700         * tui/tui-wingeneral.h
5701         (tui_check_and_display_highlight_if_needed): Don't declare.
5702         * tui/tui-wingeneral.c
5703         (tui_win_info::check_and_display_highlight_if_needed): Rename from
5704         check_and_display_highlight_if_needed.
5705         * tui/tui-win.c (tui_rehighlight_all)
5706         (tui_win_info::make_visible_with_new_height): Update.
5707         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5708         (tui_data_window::erase_data_content)
5709         (tui_data_window::display_all_data): Update.
5710         * tui/tui-data.h (struct tui_win_info)
5711         <check_and_display_highlight_if_needed>: Declare.
5712
5713 2019-08-13  Tom Tromey  <tom@tromey.com>
5714
5715         * tui/tui-win.c (tui_resize_all): Call
5716         tui_delete_invisible_windows.
5717         * tui/tui-layout.c (show_layout): Call
5718         tui_delete_invisible_windows.
5719         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5720         * tui/tui-data.c (tui_delete_invisible_windows): New function.
5721
5722 2019-08-13  Tom Tromey  <tom@tromey.com>
5723
5724         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
5725         tui_add_win_to_layout.
5726
5727 2019-08-13  Tom Tromey  <tom@tromey.com>
5728
5729         * tui/tui-layout.h (tui_default_win_height): Don't declare.
5730         * tui/tui-layout.c (tui_default_win_height): Now static.
5731
5732 2019-08-13  Tom Tromey  <tom@tromey.com>
5733
5734         * tui/tui-layout.c (show_layout): Unify all layout cases into a
5735         single switch.
5736         (show_source_disasm_command, show_source_or_disasm_and_command):
5737         Don't check current layout.
5738
5739 2019-08-13  Tom Tromey  <tom@tromey.com>
5740
5741         * tui/tui-wingeneral.c (make_all_visible): Remove.
5742         (tui_make_all_invisible): Simplify.
5743         * tui/tui-layout.c (tui_make_all_invisible): Move from
5744         tui-wingeneral.c; simplify.
5745         (show_layout): Hoist call to tui_make_all_invisible.
5746         (show_data): Don't call tui_make_all_invisible.
5747
5748 2019-08-13  Tom Tromey  <tom@tromey.com>
5749
5750         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5751         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5752
5753 2019-08-13  Tom Tromey  <tom@tromey.com>
5754
5755         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5756         tui-data.c.
5757         (show_source_disasm_command, show_data)
5758         (show_source_or_disasm_and_command): Don't use
5759         tui_set_current_layout_to.
5760         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5761         * tui/tui-data.c (current_layout, tui_current_layout): Move to
5762         tui-layout.c.
5763         (tui_set_current_layout_to): Remove.
5764
5765 2019-08-13  Tom Tromey  <tom@tromey.com>
5766
5767         * tui/tui-layout.c (tui_set_layout): Update.
5768         * tui/tui-data.h (struct tui_layout_def): Remove.
5769         (tui_layout_def): Don't declare.
5770         * tui/tui-data.c (layout_def): Remove.
5771         (tui_layout_def): Remove.
5772
5773 2019-08-13  Tom Tromey  <tom@tromey.com>
5774
5775         * tui/tui-winsource.h (struct tui_source_window_base)
5776         <clear_detail>: No longer "override".
5777         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5778         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5779         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5780         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5781         Remove.
5782         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5783
5784 2019-08-13  Tom Tromey  <tromey@adacore.com>
5785
5786         * tracepoint.c: Don't include readline.h or history.h.
5787
5788 2019-08-12  Tom Tromey  <tom@tromey.com>
5789
5790         * configure: Rebuild.
5791         * configure.ac: Check for readline 7.
5792         * NEWS: Mention readline 7 requirement.
5793         * README: Update.
5794
5795 2019-08-12  Tom Tromey  <tom@tromey.com>
5796
5797         * mingw-hdep.c (gdb_select): Remove readline hack.
5798
5799 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5800
5801         * blockframe.c (find_pc_partial_function): Set *block to nullptr
5802         when the function fails.
5803
5804 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
5805
5806         * s390-tdep.c (s390_type_align): New function.
5807         (s390_gdbarch_init): Set it as type_align gdbarch method.
5808
5809 2019-08-09  Tom de Vries  <tdevries@suse.de>
5810
5811         PR gdb/24591
5812         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5813         pc_low with relocation offset.
5814
5815 2019-08-07  Tom Tromey  <tromey@adacore.com>
5816
5817         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5818         (print_frame_args): Update.
5819         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5820         Update.
5821         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5822         * frame.h (struct frame_arg): Add initializers.
5823         <error>: Now a unique_xmalloc_ptr.
5824
5825 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
5826
5827         * NEWS: Expand the Pointer Authentication entry.
5828         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5829         (aarch64_frame_unmask_lr): ... to this.
5830         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5831         Call aarch64_frame_unmask_lr.
5832         * frame.c (struct frame_info): Add "masked" variable.
5833         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5834         (fprint_frame): Check for masked pc.
5835         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5836         declarations.
5837         * python/py-framefilter.c (py_print_frame): Check for masked pc.
5838         * stack.c (print_frame): Check for masked pc.
5839
5840 2019-08-06  Tom Tromey  <tom@tromey.com>
5841
5842         * stabsread.c (patch_block_stabs, read_one_struct_field)
5843         (read_enum_type): Use obstack_strndup.
5844         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5845         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5846         * dwarf2read.c (guess_full_die_structure_name)
5847         (anonymous_struct_prefix): Use obstack_strndup.
5848         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5849         * c-exp.y (yylex): Use obstack_strndup.
5850         * ada-exp.y (write_object_renaming, write_ambiguous_var)
5851         (write_var_or_type): Use obstack_strndup.
5852
5853 2019-08-06  Tom Tromey  <tom@tromey.com>
5854
5855         * symfile.c (reread_symbols): Use obstack_strdup.
5856         * stabsread.c (read_type): Use obstack_strdup.
5857         * gdb_obstack.h (obstack_strdup): New overload.
5858         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5859         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5860         (dwarf2_canonicalize_name): Use obstack_strdup.
5861         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5862         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5863         Use obstack_strdup.
5864
5865 2019-08-06  Tom Tromey  <tom@tromey.com>
5866
5867         * gdb_obstack.h (obstack_strdup): Define.
5868         * gdb_obstack.c (obstack_strdup): Don't define.
5869
5870 2019-08-06  Tom Tromey  <tom@tromey.com>
5871
5872         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5873         obstack_strdup.
5874         * typeprint.c (typedef_hash_table::find_global_typedef): Use
5875         obstack_strdup.
5876         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5877         * stabsread.c (common_block_start): Use obstack_strdup.
5878         * objfiles.c (set_objfile_main_name, objfile): Use
5879         obstack_strdup.
5880         * namespace.c (add_using_directive): Use obstack_strdup.
5881         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5882         * jit.c (finalize_symtab): Use obstack_strdup.
5883         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5884         (guess_partial_die_structure_name, partial_die_info::fixup)
5885         (dwarf2_name): Use obstack_strdup.
5886         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5887         obstack_strdup.
5888         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5889         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5890         obstack_strdup.
5891         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5892
5893 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5894
5895         * unittests/help-doc-selftests.c: New file.
5896         * Makefile.in: Add the new file.
5897
5898 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5899
5900         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5901         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
5902         the full first line, except when FOR_VALUE_PREFIX.  In this case,
5903         the trailing '.' is not output, and the first character is uppercased.
5904         (print_help_for_command): Update call to print_doc_line.
5905         (print_doc_of_command): Likewise.
5906         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5907         * cli/cli-option.c (append_indented_doc): Do not append newline.
5908         (build_help_option): Append newline after first appended_indented_doc
5909         only if a second call is done.
5910         (build_help): Append 2 new lines before each option, except the first
5911         one.
5912         * compile/compile.c (_initialize_compile): Add new lines after
5913         %OPTIONS%, when not at the end of the help.
5914         Change help doc or code
5915         producing the help doc to respect the invariants.
5916         * maint-test-options.c (_initialize_maint_test_options): Likewise.
5917         Also removed the new line after 'Options:', as all other commands
5918         do not put an empty line between 'Options:' and the first option.
5919         * printcmd.c (_initialize_printcmd): Likewise.
5920         * stack.c (_initialize_stack): Likewise.
5921         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5922         incorrectly telling COMMAND is optional.
5923         * ada-lang.c (_initialize_ada_language): Change help doc or code
5924         producing the help doc to respect the invariants.
5925         * ada-tasks.c (_initialize_ada_tasks): Likewise.
5926         * breakpoint.c (_initialize_breakpoint): Likewise.
5927         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5928         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5929         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5930         * cli/cli-style.c (cli_style_option::add_setshow_commands,
5931         _initialize_cli_style): Likewise.
5932         * corelow.c (core_target_info): Likewise.
5933         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5934         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5935         * filesystem.c (_initialize_filesystem): Likewise.
5936         * frame.c (_initialize_frame): Likewise.
5937         * gnu-nat.c (add_task_commands): Likewise.
5938         * infcall.c (_initialize_infcall): Likewise.
5939         * infcmd.c (_initialize_infcmd): Likewise.
5940         * interps.c (_initialize_interpreter): Likewise.
5941         * language.c (_initialize_language): Likewise.
5942         * linux-fork.c (_initialize_linux_fork): Likewise.
5943         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5944         * maint.c (_initialize_maint_cmds): Likewise.
5945         * memattr.c (_initialize_mem): Likewise.
5946         * printcmd.c (_initialize_printcmd): Likewise.
5947         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5948         _RegEx): Likewise.
5949         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5950         * record-btrace.c (_initialize_record_btrace): Likewise.
5951         * record-full.c (_initialize_record_full): Likewise.
5952         * record.c (_initialize_record): Likewise.
5953         * regcache-dump.c (_initialize_regcache_dump): Likewise.
5954         * regcache.c (_initialize_regcache): Likewise.
5955         * remote.c (add_packet_config_cmd, init_remote_threadtests,
5956         _initialize_remote): Likewise.
5957         * ser-tcp.c (_initialize_ser_tcp): Likewise.
5958         * serial.c (_initialize_serial): Likewise.
5959         * skip.c (_initialize_step_skip): Likewise.
5960         * source.c (_initialize_source): Likewise.
5961         * stack.c (_initialize_stack): Likewise.
5962         * symfile.c (_initialize_symfile): Likewise.
5963         * symtab.c (_initialize_symtab): Likewise.
5964         * target-descriptions.c (_initialize_target_descriptions): Likewise.
5965         * top.c (init_main): Likewise.
5966         * tracefile-tfile.c (tfile_target_info): Likewise.
5967         * tracepoint.c (_initialize_tracepoint): Likewise.
5968         * tui/tui-win.c (_initialize_tui_win): Likewise.
5969         * utils.c (add_internal_problem_command): Likewise.
5970         * valprint.c (value_print_option_defs): Likewise.
5971
5972 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
5973
5974         PR build/24886
5975         * configure.ac: Drop enable-libmcheck support.
5976         * configure, config.in: Rebuild.
5977         * libmcheck.m4: Remove.
5978         * acinclude.m4: Don't include it.
5979         * Makefile.in: Don't distribute it.
5980         * top.c (print_gdb_configuration): Don't mention it.
5981
5982 2019-08-06  Tom Tromey  <tom@tromey.com>
5983
5984         * utils.c (set_output_style): Sometimes pass stream to
5985         emit_style_escape.
5986         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5987         * record-btrace.c (btrace_insn_history): Update.
5988         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5989         method.
5990         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5991         Update initializers.
5992         <m_uiout>: New field.
5993         <m_di>: Move lower.
5994         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5995         Remove "uiout" parameter.
5996         (dump_insns): Update.
5997         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5998         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5999
6000 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
6001
6002         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6003         (error_in_psymtab_expansion): Likewise.
6004         (lookup_symbol_via_quick_fns): Likewise.
6005         (basic_lookup_transparent_type_quick): Likewise.
6006         (basic_lookup_transparent_type_1): Likewise.
6007
6008 2019-08-06  Tom Tromey  <tromey@adacore.com>
6009
6010         * source.c (last_source_error): Now bool.
6011         (print_source_lines_base): Make "noprint" bool.  Only open
6012         source file when last_source_visited changes.
6013
6014 2019-08-06  Tom Tromey  <tromey@adacore.com>
6015
6016         * annotate.c (annotate_source_line): Use g_source_cache.
6017         * source-cache.c (source_cache::get_plain_source_lines): Change
6018         parameters.  Populate m_offset_cache.
6019         (source_cache::ensure): New method.
6020         (source_cache::get_line_charpos): New method.
6021         (extract_lines): Move lower.  Change parameters.
6022         (source_cache::get_source_lines): Move lower.
6023         * source-cache.h (class source_cache): Update comment.
6024         <get_line_charpos>: New method.
6025         <get_source_lines>: Update comment.
6026         <clear>: Clear m_offset_cache.
6027         <get_plain_source_lines>: Change parameters.
6028         <ensure>: New method
6029         <m_offset_cache>: New member.
6030         * source.c (forget_cached_source_info_for_objfile): Update.
6031         (info_source_command): Use g_source_cache.
6032         (find_source_lines, open_source_file_with_line_charpos): Remove.
6033         (print_source_lines_base, search_command_helper): Use g_source_cache.
6034         * source.h (open_source_file_with_line_charpos): Don't declare.
6035         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6036         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6037         Use g_source_cache.
6038
6039 2019-08-06  Tom Tromey  <tromey@adacore.com>
6040
6041         * source-cache.c (source_cache::get_plain_source_lines):
6042         Remove "first_line" and "last_line" parameters.
6043         (source_cache::get_source_lines): Cache plain text.
6044         * source-cache.h (class source_cache)
6045         <get_plain_source_lines>: Update.
6046
6047 2019-08-06  Tom Tromey  <tromey@adacore.com>
6048
6049         * source-cache.c (extract_lines): No longer a method.
6050         Changed type of parameter.  Include final newline.
6051         (selftests::extract_lines_test): New function.
6052         (_initialize_source_cache): Likewise.
6053         * source-cache.h (class source_cache)
6054         <extract_lines>: Don't declare.
6055
6056 2019-08-06  Tom Tromey  <tromey@adacore.com>
6057
6058         * breakpoint.c (init_breakpoint_sal): Update.
6059         (breakpoint): Update.
6060         * breakpoint.h (struct breakpoint) <filter>: Now a
6061         unique_xmalloc_ptr.
6062
6063 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6064
6065         * NEWS: Mention dictionary access on blocks.
6066         * python/py-block.c (blpy_getitem): New function.
6067         (block_object_as_mapping): New struct.
6068         (block_object_type): Use new struct for tp_as_mapping field.
6069
6070 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6071
6072         * objfiles.h (objfile): Add a comment describing partial symbols.
6073
6074 2019-08-05  Tom Tromey  <tromey@adacore.com>
6075
6076         * compile/compile.c (_initialize_compile): Use _(), not N_().
6077         * thread.c (_initialize_thread): Use _(), not N_().
6078         * stack.c (_initialize_stack): Use _(), not N_().
6079         * printcmd.c (_initialize_printcmd): Use _(), not N_().
6080
6081 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
6082
6083         * dwarf2read.c (struct dw2_symtab_iterator):
6084         <want_specific_block>: Remove.
6085         <block_index>: Change type to gdb::optional.
6086         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6087         change type of BLOCK_INDEX parameter to gdb::optional.
6088         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6089         (dw2_lookup_symbol): Don't pass argument for
6090         WANT_SPECIFIC_BLOCK.
6091         (dw2_expand_symtabs_for_function): Don't pass argument for
6092         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6093         (class dw2_debug_names_iterator)
6094         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6095         parameter, change BLOCK_INDEX type to gdb::optional.
6096         <m_want_specific_block>: Remove.
6097         <m_block_index>: Change type to gdb::optional.
6098         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6099         gdb::optional.  Re-write in function of gdb::optional.
6100         (dw2_debug_names_lookup_symbol): Don't pass argument for
6101         WANT_SPECIFIC_BLOCK.
6102         (dw2_debug_names_expand_symtabs_for_function): Don't pass
6103         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6104         BLOCK_INDEX.
6105
6106 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6107
6108         * NEWS: Mention changes to "info sources" command.
6109
6110 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6111
6112         * symtab.c (filename_partial_match_opts): New struct type.
6113         (struct output_source_filename_data): New members
6114         regexp, c_regexp, partial_match.
6115         (output_source_filename): Use new members to decide to print file.
6116         (info_sources_option_defs): New variable.
6117         (make_info_sources_options_def_group, print_info_sources_header,
6118         info_sources_command_completer):
6119         New functions.
6120         (info_sources_command): Read new optional arguments.
6121         (_initialize_symtab): Update info sources help.
6122
6123 2019-08-02  Alexandre Oliva <oliva@adacore.com>
6124
6125         * ada-lang.c (exception_support_info_v0): Renamed from...
6126         (default_exception_support_info): ... this.  Create new
6127         definition for v1.
6128         (ada_has_this_exception_support): Look up catch_handlers_sym.
6129         (ada_exception_support_info_sniffer): Try v0 after default.
6130
6131 2019-08-01  Tom Tromey  <tromey@adacore.com>
6132
6133         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6134         gdbarch.h.
6135
6136 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
6137
6138         * s12z-tdep.c: Fix include path for s12z-opc.h.
6139
6140 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
6141
6142         * NEWS: Require GNU make 3.82.
6143
6144 2019-07-16  Tom Tromey  <tom@tromey.com>
6145
6146         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6147         declare.
6148
6149 2019-07-30  Tom Tromey  <tromey@adacore.com>
6150
6151         * block.c (contained_in): Remove BLOCK_FUNCTION check.
6152
6153 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
6154
6155         * printcmd.c (print_address_symbolic): Print negative offsets.
6156         (build_address_symbolic): Force signed arithmetic when computing
6157         offset.
6158
6159 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
6160
6161         PR/24474: Add a function to lookup static variables.
6162         * NEWS: Mention this new function.
6163         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6164         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6165         * python/python.c (python_GdbMethods): Add new function.
6166
6167 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
6168
6169         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6170         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6171         (objfpy_lookup_static_symbol): New function.
6172         (objfile_object_methods): Add new functions.
6173
6174 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6175
6176         * NEWS: Mention 'set|show print frame-info'.  Mention new
6177         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
6178         backtrace argument.  Mention that python frame filtering code
6179         is now consistent with what 'backtrace' command prints.
6180
6181 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6182
6183         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6184         comments.
6185         (print_frame_info_auto, print_frame_info_source_line,
6186         print_frame_info_location, print_frame_info_source_and_location,
6187         print_frame_info_location_and_address, print_frame_info_short_location):
6188         New declarations.
6189         (struct frame_print_options): New member print_frame_info.
6190         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6191         * stack.h (get_user_print_what_frame_info): New declaration.
6192         (frame_show_address): New declaration.
6193         * stack.c (print_frame_arguments_choices): New value 'presence'.
6194         (print_frame_info_auto, print_frame_info_source_line,
6195         print_frame_info_location, print_frame_info_source_and_location,
6196         print_frame_info_location_and_address, print_frame_info_short_location,
6197         print_frame_info_choices, print_frame_info_print_what): New definitions.
6198         (print_frame_args): Only print dots for args if print frame-arguments
6199         is 'presence'.
6200         (frame_print_option_defs): New element for "frame-info".
6201         (get_user_print_what_frame_info): New function.
6202         (frame_show_address): Make non static.  Move comment to stack.h.
6203         (print_frame_info_to_print_what): New function.
6204         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
6205         to decide what to print.
6206         (backtrace_command_1): Handle the new print_frame_arguments_presence
6207         value.
6208         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6209         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6210         (py_print_frame): In non-mi mode, use LOCATION as default for
6211         print_what, similarly to frame information printed directly by
6212         backtrace command. Handle frame-info user option in non MI mode.
6213
6214 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6215
6216         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6217         Add case for debugging 32-bit target on 64-bit host.  Revise
6218         comment.
6219
6220 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6221
6222         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6223         instead of find_function_entry_range_from_pc.
6224
6225 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6226
6227         * stack.c (find_frame_funname): Remove code which preferred
6228         minsym over symtab sym in "certain pathological cases".
6229
6230         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6231         parameter.  Change type of "do_demangle" to bool.
6232         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6233         Pass suitable "prefer_sym_over_minsym" flag to
6234         build_address_symbolic().  Don't output "+" for negative offsets.
6235         * printcmd.c (print_address_symbolic): Update invocation of
6236         build_address_symbolic to include a "prefer_sym_over_minsym"
6237         flag.
6238         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6239         Restrict cases in which use of minimal symbol is preferred to that
6240         of a found symbol.  Update comments.
6241
6242         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6243         for entry pc when entry pc is out of range for that FDE.
6244
6245 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
6246
6247         PR gdb/24839:
6248         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6249         type.
6250
6251 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
6252
6253         * python/py-objfile.c (add_separate_debug_file): Fix comment about
6254         this function's Python signature.
6255
6256
6257 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
6258
6259         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6260         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6261         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6262         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6263         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6264
6265
6266 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
6267
6268         * h8300-tdep.c (h8300_register_name_common): New.
6269         h8300_register_name): Use h8300_register_name_common.
6270         (h8300s_register_name): Likewise.
6271         (h8300sx_register_name): Likewise.
6272         (h8300h_register_nam): New.
6273         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6274
6275
6276 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
6277
6278         * arm-tdep.c (arm_skip_cmse_entry): New function.
6279         (arm_is_sgstubs_section): New function.
6280         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6281
6282 2019-07-22  Tom Tromey  <tom@tromey.com>
6283
6284         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6285         Don't self-assign.
6286
6287 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6288
6289         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6290         type_print.
6291
6292 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6293
6294         * symtab.c (search_symbols): Adjust msymbol matching type arrays
6295         so that GDB doesn't match any msymbols when searching in the
6296         TYPES_DOMAIN.
6297         (print_symbol_info): Print using typedef_print or type_print based
6298         on the type of the symbol.  Add updated FIXME comment moved from...
6299         (_initialize_symtab): ... move and update FIXME comment to above.
6300
6301 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6302
6303         * NEWS: Mention adding -q option to "info types".
6304         * symtab.c (struct info_types_options): New struct.
6305         (info_types_options_defs): New variable.
6306         (make_info_types_options_def_group): New function.
6307         (info_types_command): Use gdb::option framework to parse options.
6308         (info_types_command_completer): New function.
6309         (_initialize_symtab): Extend the help text on "info types" and
6310         register command completer.
6311
6312 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
6313
6314         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6315         (lookup_symbol_in_objfile): Change int to block_enum and add a
6316         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6317
6318 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
6319
6320         * MAINTAINERS (Write After Approval): Add self.
6321
6322 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6323
6324         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6325         instruction to the dummy code region.
6326
6327 2019-07-19  Tom Tromey  <tromey@adacore.com>
6328
6329         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6330         (ARGSUSED, PARAMS, __func__): Remove rules.
6331
6332 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6333
6334         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6335         * features/arm/arm-with-iwmmxt.c: Remove.
6336         * features/arm/arm-with-iwmmxt.xml: Remove.
6337         * features/arm/arm-with-m-fpa-layout.c: Remove.
6338         * features/arm/arm-with-m-fpa-layout.xml: Remove.
6339         * features/arm/arm-with-m-vfp-d16.c: Remove.
6340         * features/arm/arm-with-m-vfp-d16.xml: Remove.
6341         * features/arm/arm-with-m.c: Remove.
6342         * features/arm/arm-with-m.xml: Remove.
6343         * features/arm/arm-with-neon.c: Remove.
6344         * features/arm/arm-with-neon.xml: Remove.
6345         * features/arm/arm-with-vfpv2.c: Remove.
6346         * features/arm/arm-with-vfpv2.xml: Remove.
6347         * features/arm/arm-with-vfpv3.c: Remove.
6348         * features/arm/arm-with-vfpv3.xml: Remove.
6349
6350 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6351
6352         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6353
6354 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6355
6356         * arch/aarch32.c (aarch32_create_target_description): Create
6357         target descriptions using features.
6358         * arch/arm.c (arm_create_target_description)
6359         (arm_create_mprofile_target_description): Likewise.
6360         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6361
6362 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6363
6364         * Makefile.in: Add new files.
6365         * aarch32-tdep.c: New file.
6366         * aarch32-tdep.h: New file.
6367         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6368         Call aarch32_read_description.
6369         * arch/aarch32.c: New file.
6370         * arch/aarch32.h: New file.
6371         * arch/arm.c (arm_create_target_description)
6372         (arm_create_mprofile_target_description): New function.
6373         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6374         (arm_create_target_description)
6375         (arm_create_mprofile_target_description): New declaration.
6376         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6377         read_description functions.
6378         * arm-linux-nat.c (arm_linux_nat_target::read_description):
6379         Likewise.
6380         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6381         * arm-tdep.c (tdesc_arm_list): New variable.
6382         (arm_register_g_packet_guesses): Call create description functions.
6383         (arm_read_description) (arm_read_mprofile_description): New
6384         function.
6385         * arm-tdep.h (arm_read_description)
6386         (arm_read_mprofile_description): Add declaration.
6387         * configure.tgt: Add new files.
6388
6389 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
6390
6391         * top.c (new_ui_command): Open specified terminal just once.
6392
6393 2019-07-18  Tom Tromey  <tromey@adacore.com>
6394
6395         * symtab.c (main_name): Constify return type.
6396         * symfile.c (set_initial_language): Update.
6397         * symtab.h (main_name): Constify return type.
6398
6399 2019-07-17  Tom Tromey  <tom@tromey.com>
6400
6401         * tui/tui-winsource.c (tui_update_source_window)
6402         (tui_update_source_window_as_is)
6403         (tui_update_source_windows_with_line): Remove return.
6404         * tui/tui-disasm.c (tui_show_disassem)
6405         (tui_show_disassem_and_update_source): Remove return.
6406         * tui/tui.c (tui_reset): Remove return.
6407         * tui/tui-wingeneral.c
6408         (tui_check_and_display_highlight_if_needed): Remove return.
6409
6410 2019-07-17  Tom Tromey  <tom@tromey.com>
6411
6412         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6413
6414 2019-07-17  Tom Tromey  <tom@tromey.com>
6415
6416         * tui/tui-winsource.h (struct tui_exec_info_window)
6417         (struct tui_source_window_base): Move from tui-data.h.
6418         * tui/tui-winsource.c: Move many method definitions from
6419         elsewhere.  Remove "structuring" comments.
6420         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6421         (tui_source_window_base::refresh_window): Move to
6422         tui-winsource.c.
6423         * tui/tui-win.c (tui_source_window_base::refresh_all)
6424         (tui_source_window_base::update_tab_width)
6425         (tui_source_window_base::set_new_height)
6426         (tui_source_window_base::do_make_visible_with_new_height): Move to
6427         tui-winsource.c.
6428         * tui/tui-source.h: Update.
6429         * tui/tui-source.c (tui_source_window_base::reset): Move to
6430         tui-winsource.c.
6431         * tui/tui-disasm.h: Update.
6432         * tui/tui-data.h (struct tui_exec_info_window): Move to
6433         tui-winsource.h.
6434         (struct tui_source_window_base): Likewise.
6435         * tui/tui-data.c (tui_source_window_base::clear_detail)
6436         (tui_source_window_base, ~tui_source_window_base): Move to
6437         tui-winsource.c.
6438
6439 2019-07-17  Tom Tromey  <tom@tromey.com>
6440
6441         * tui/tui-win.c (tui_resize_all)
6442         (tui_source_window_base::update_tab_width)
6443         (tui_adjust_win_heights): Update.
6444         (tui_win_info::make_invisible_and_set_new_height): Rename from
6445         make_invisible_and_set_new_height.
6446         * tui/tui-data.h (struct tui_win_info)
6447         <make_invisible_and_set_new_height>: New method.
6448
6449 2019-07-17  Tom Tromey  <tom@tromey.com>
6450
6451         * tui/tui.c: Update.
6452         * tui/tui-source.h (struct tui_source_window): Move from
6453         tui-data.h.
6454         * tui/tui-layout.c: Update.
6455         * tui/tui-disasm.c: Update.
6456         * tui/tui-data.h (struct tui_source_window): Move to
6457         tui-source.h.
6458
6459 2019-07-17  Tom Tromey  <tom@tromey.com>
6460
6461         * tui/tui-disasm.h (struct tui_disasm_window): Move from
6462         tui-data.h.
6463         * tui/tui-data.h (struct tui_disasm_window): Move to
6464         tui-disasm.h.
6465
6466 2019-07-17  Tom Tromey  <tom@tromey.com>
6467
6468         * tui/tui-regs.h (struct tui_data_item_window): Move from
6469         tui-data.h.
6470         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6471         * tui/tui-data.h (struct tui_data_item_window): Move to
6472         tui-regs.h.
6473         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6474
6475 2019-07-17  Tom Tromey  <tom@tromey.com>
6476
6477         * tui/tui.c: Update.
6478         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6479         (tui_cmd_window::max_height): Move to tui-command.c.
6480         * tui/tui-layout.c: Update.
6481         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6482         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6483         tui-command.c.
6484         * tui/tui-command.h (struct tui_cmd_window): Move from
6485         tui-data.h.
6486         * tui/tui-command.c: Remove "structuring" comments.
6487         (tui_cmd_window::clear_detail)
6488         (tui_cmd_window::do_make_visible_with_new_height)
6489         (tui_cmd_window::max_height): Move from elsewhere.
6490
6491 2019-07-17  Tom Tromey  <tom@tromey.com>
6492
6493         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6494         Now static.
6495         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6496         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6497
6498 2019-07-17  Tom Tromey  <tom@tromey.com>
6499
6500         * tui/tui.c: Update.
6501         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6502         tui-regs.c.
6503         * tui/tui-windata.h: Remove file.
6504         * tui/tui-windata.c: Remove file.
6505         * tui/tui-win.c (tui_data_window::set_new_height)
6506         (tui_data_window::do_make_visible_with_new_height): Move to
6507         tui-regs.c.
6508         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6509         * tui/tui-regs.c: Remove "structuring" comments.
6510         (tui_data_window::first_data_item_displayed)
6511         (tui_data_window::delete_data_content_windows)
6512         (tui_data_window::erase_data_content)
6513         (tui_data_window::display_all_data)
6514         (tui_data_window::refresh_all)
6515         (tui_data_window::do_scroll_vertical)
6516         (tui_data_window::clear_detail, tui_data_window::set_new_height)
6517         (tui_data_window::do_make_visible_with_new_height)
6518         (tui_data_window::refresh_window): Move from elsewhere.
6519         (_initialize_tui_regs): Move to end of file.
6520         * tui/tui-layout.c: Update.
6521         * tui/tui-hooks.c: Update.
6522         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6523         * tui/tui-data.c (tui_data_window::clear_detail): Move to
6524         tui-regs.c.
6525         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6526
6527 2019-07-17  Tom Tromey  <tom@tromey.com>
6528
6529         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6530         seen.
6531
6532 2019-07-17  Tom Tromey  <tom@tromey.com>
6533
6534         * tui/tui-win.c (tui_source_window_base::set_new_height)
6535         (tui_source_window_base::do_make_visible_with_new_height): Use
6536         m_has_locator field directly.
6537         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6538         method.
6539         (struct tui_source_window_base) <has_locator>: Likewise.
6540
6541 2019-07-17  Tom Tromey  <tom@tromey.com>
6542
6543         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6544         Don't declare.
6545         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6546         Remove.
6547         * tui/tui-win.c (tui_source_window_base::set_new_height)
6548         (tui_source_window_base::set_new_height)
6549         (make_invisible_and_set_new_height)
6550         (tui_source_window_base::do_make_visible_with_new_height)
6551         (tui_source_window_base::do_make_visible_with_new_height):
6552         Update.
6553         * tui/tui-layout.c (show_source_disasm_command, show_data)
6554         (show_source_or_disasm_and_command): Update.
6555         * tui/tui-layout.c (show_layout): Update.
6556
6557 2019-07-17  Tom Tromey  <tom@tromey.com>
6558
6559         * tui/tui-layout.c (make_data_window): Remove.
6560         (show_data): Unify creation and re-initialization cases.
6561
6562 2019-07-17  Tom Tromey  <tom@tromey.com>
6563
6564         * tui/tui-layout.c (make_source_window, make_disasm_window):
6565         Remove.
6566         (show_data): Unify creation and re-initialization cases.
6567
6568 2019-07-17  Tom Tromey  <tom@tromey.com>
6569
6570         * tui/tui-layout.c (make_command_window): Remove.
6571         (show_source_disasm_command, show_source_or_disasm_and_command):
6572         Unify creation and re-initialization cases.
6573
6574 2019-07-17  Tom Tromey  <tom@tromey.com>
6575
6576         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6577         creation and re-initialization cases.
6578
6579 2019-07-17  Tom Tromey  <tom@tromey.com>
6580
6581         * tui/tui-regs.c (tui_get_register): Return void.
6582
6583 2019-07-17  Tom Tromey  <tom@tromey.com>
6584
6585         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6586         Simplify.
6587
6588 2019-07-17  Tom Tromey  <tom@tromey.com>
6589
6590         * tui/tui-layout.c (show_source_disasm_command): Simplify window
6591         resetting.
6592
6593 2019-07-17  Tom Tromey  <tom@tromey.com>
6594
6595         * tui/tui.h (tui_set_layout_by_name): Don't declare.
6596         * tui/tui-regs.c (tui_reg_layout): New function.
6597         (tui_show_registers, tui_reg_command): Use it.
6598         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6599         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
6600         parameters.
6601         (tui_layout_command): Remove.
6602
6603 2019-07-17  Tom Tromey  <tom@tromey.com>
6604
6605         * tui/tui-layout.h (tui/tui-layout): Return void.
6606         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
6607
6608 2019-07-17  Tom Tromey  <tom@tromey.com>
6609
6610         * tui/tui-layout.c (show_source_disasm_command, show_data):
6611         Update.
6612         (reset_locator): Remove.
6613         (show_source_or_disasm_and_command): Update.
6614
6615 2019-07-17  Tom Tromey  <tom@tromey.com>
6616
6617         * tui/tui-source.c (tui_source_window_base::reset): Remove
6618         win_type parameter.
6619         * tui/tui-layout.c (make_command_window, make_source_window)
6620         (make_disasm_window, make_data_window)
6621         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6622         (reset_locator, show_source_or_disasm_and_command): Update.
6623         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6624         win_type parameter.
6625         (struct tui_source_window_base) <reset>: Likewise.
6626
6627 2019-07-17  Tom Tromey  <tom@tromey.com>
6628
6629         * tui/tui-layout.c (show_source_disasm_command): Use
6630         reset_locator.
6631         (reset_locator): New function.
6632         (init_and_make_win): Remove.
6633         (show_source_or_disasm_and_command): Use reset_locator.
6634
6635 2019-07-17  Tom Tromey  <tom@tromey.com>
6636
6637         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6638         condition.
6639         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6640         Remove condition.
6641         * tui/tui-source.c (tui_source_window_base::reset): New method.
6642         * tui/tui-layout.c (make_command_window): Don't call
6643         init_and_make_win.
6644         (make_source_window, make_disasm_window): Don't call
6645         make_source_or_disasm_window.
6646         (make_data_window): Don't call init_and_make_win.  Change calling
6647         convention.
6648         (show_source_disasm_command, show_data): Simplify.
6649         (make_source_or_disasm_window): Remove.
6650         (show_source_or_disasm_and_command): Simplify.
6651         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6652         (struct tui_source_window_base) <reset>: Likewise.
6653         <execution_info>: Remove initializer.
6654         * tui/tui-data.c (tui_source_window_base): Initialize
6655         execution_info.
6656
6657 2019-07-17  Tom Tromey  <tom@tromey.com>
6658
6659         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6660         variable.
6661
6662 2019-07-17  Tom Tromey  <tom@tromey.com>
6663
6664         * tui/tui.c (tui_rl_other_window): Update.
6665         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6666         superclass method first.  Always iterate over regs_content.
6667         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6668         method.
6669         * tui/tui-win.c (tui_set_focus_command): Update.
6670
6671 2019-07-17  Tom Tromey  <tom@tromey.com>
6672
6673         * tui/tui-win.c (tui_set_focus_command): Rename from
6674         tui_set_focus.  Call tui_enable.
6675         (tui_set_focus_command): Remove.
6676
6677 2019-07-17  Tom Tromey  <tom@tromey.com>
6678
6679         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6680         refresh_window.
6681         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6682         touchwin.
6683         (tui_data_window::refresh_window): Call refresh_window on data
6684         items.  Always call superclass refresh_window.
6685         (tui_win_info::refresh): Remove.
6686         (tui_source_window_base::refresh_window): Update.
6687         (tui_refresh_all): Update.
6688         * tui/tui-layout.c (show_source_disasm_command): Remove call to
6689         refresh_window.
6690         (show_source_or_disasm_and_command): Likewise.
6691         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6692         (struct tui_source_window_base) <refresh>: Likewise.
6693
6694 2019-07-17  Tom Tromey  <tom@tromey.com>
6695
6696         * tui/tui-winsource.c (tui_clear_source_content)
6697         (tui_show_source_content): Update.
6698         * tui/tui-source.c (tui_source_window::showing_source_p): Check
6699         whether content is empty.
6700         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6701         Remove.
6702
6703 2019-07-17  Tom Tromey  <tom@tromey.com>
6704
6705         * tui/tui-winsource.c (tui_erase_source_content): Clear the
6706         window's contents.
6707         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6708         * tui/tui-source.c (tui_set_source_content_nil): Remove.
6709
6710 2019-07-17  Tom Tromey  <tom@tromey.com>
6711
6712         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6713         (struct tui_data_item_window): Update.
6714
6715 2019-07-17  Tom Tromey  <tom@tromey.com>
6716
6717         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6718         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6719         defines.
6720
6721 2019-07-17  Tom Tromey  <tom@tromey.com>
6722
6723         * tui/tui-winsource.h (tui_erase_source_content)
6724         (tui_clear_source_content): Remove "display_prompt" parameter.
6725         * tui/tui-winsource.c (tui_update_source_window_as_is)
6726         (tui_update_source_windows_with_addr): Update.
6727         (tui_clear_source_content): Remove "display_prompt" parameter.
6728         (tui_erase_source_content): Likewise.  Simplify.
6729         (tui_show_source_content): Update.
6730         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6731         * tui/tui-stack.c (tui_show_frame_info): Update.
6732         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6733         Remove defines.
6734
6735 2019-07-17  Tom Tromey  <tom@tromey.com>
6736
6737         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6738         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6739         parameter.
6740         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6741         parameter.
6742
6743 2019-07-17  Tom Tromey  <tom@tromey.com>
6744
6745         * tui/tui-winsource.c (tui_clear_source_content)
6746         (tui_show_source_content, tui_show_exec_info_content)
6747         (tui_clear_exec_info_content): Update.
6748         * tui/tui-stack.c (tui_show_locator_content): Update.
6749         (tui_show_frame_info): Update.
6750         * tui/tui-source.h (tui_source_window): Don't declare.
6751         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6752         from tui_source_is_displayed.
6753         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6754         Remove field.
6755         (struct tui_source_window_base) <content_in_use>: New field.  Now
6756         bool.
6757         (struct tui_source_window) <showing_source_p>: New method.
6758         (TUI_SRC_WIN): Change cast.
6759         * tui/tui-data.c (tui_initialize_static_data): Update.
6760
6761 2019-07-17  Tom Tromey  <tom@tromey.com>
6762
6763         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6764         location_matches_p.
6765         * tui/tui-source.c (tui_source_window::location_matches_p): New
6766         method.
6767         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6768         method.
6769         * tui/tui-data.h (struct tui_source_window_base)
6770         <location_matches_p>: New method.
6771         (struct tui_source_window, struct tui_disasm_window)
6772         <location_matches_p>: Likewise.
6773
6774 2019-07-17  Tom Tromey  <tom@tromey.com>
6775
6776         * tui/tui-win.c (tui_set_win_height_command): Rename from
6777         tui_set_win_height.
6778         (tui_set_win_height_command): Remove.
6779
6780 2019-07-17  Tom Tromey  <tom@tromey.com>
6781
6782         * tui/tui-source.c (tui_source_window): New constructor.  Add
6783         observer.
6784         (~tui_source_window): New destructor.
6785         (tui_source_window::style_changed): New method.
6786         * tui/tui-hooks.c (tui_redisplay_source): Remove.
6787         (tui_attach_detach_observers): Update.
6788         * tui/tui-data.h (struct tui_source_window): Make constructor not
6789         inline.  Add destructor.
6790         (struct tui_source_window) <style_changed>: New method.
6791         <m_observable>: New member.
6792
6793 2019-07-17  Tom Tromey  <tom@tromey.com>
6794
6795         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6796         * tui/tui-win.c (tui_resize_all): Fix typo.
6797
6798 2019-07-17  Tom Tromey  <tom@tromey.com>
6799
6800         * tui/tui-wingeneral.h (tui_refresh_all): Update.
6801         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6802         (tui_refresh_all): Remove "list" parameter.  Use foreach.
6803         * tui/tui-win.c (window_name_completer): Use foreach.
6804         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6805         (update_tab_width): Likewise.
6806         * tui/tui-layout.c (show_layout): Update.
6807         * tui/tui-data.h (class tui_window_iterator): New.
6808         (struct all_tui_windows): New.
6809         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6810
6811 2019-07-17  Tom Tromey  <tom@tromey.com>
6812
6813         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6814         parameter.  Don't reference globals.
6815         (tui_reg_command): Update.
6816
6817 2019-07-17  Tom Tromey  <tom@tromey.com>
6818
6819         * tui/tui-regs.c (tui_show_registers): Simplify.
6820
6821 2019-07-17  Tom Tromey  <tom@tromey.com>
6822
6823         * tui/tui-regs.c (tui_show_registers): Update.
6824         (tui_show_register_group): Add win_info parameter.
6825
6826 2019-07-17  Tom Tromey  <tom@tromey.com>
6827
6828         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6829         Rename from tui_display_reg_element_at_line.
6830         (tui_data_window::display_registers_from_line): Update.
6831         * tui/tui-data.h (struct tui_data_window)
6832         <display_reg_element_at_line>: New method.
6833
6834 2019-07-17  Tom Tromey  <tom@tromey.com>
6835
6836         * tui/tui-regs.h (tui_display_registers_from)
6837         (tui_display_registers_from_line): Don't declare.
6838         * tui/tui-windata.c (tui_data_window::display_all_data)
6839         (tui_data_window::refresh_all)
6840         (tui_data_window::do_scroll_vertical): Update.
6841         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6842         from tui_display_registers_from.
6843         (tui_display_reg_element_at_line): Update.
6844         (tui_data_window::display_registers_from_line): Rename from
6845         tui_display_registers_from_line.
6846         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6847         display_registers_from_line>: New methods.
6848
6849 2019-07-17  Tom Tromey  <tom@tromey.com>
6850
6851         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6852         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6853         from tui_erase_data_content.
6854         (tui_data_window::display_all_data)
6855         (tui_data_window::refresh_all)
6856         (tui_data_window::do_scroll_vertical): Update.
6857         * tui/tui-regs.c (tui_show_registers): Update.
6858         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6859         New method.
6860
6861 2019-07-17  Tom Tromey  <tom@tromey.com>
6862
6863         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6864         declare.
6865         * tui/tui-windata.c
6866         (tui_data_window::delete_data_content_windows): Rename from
6867         tui_delete_data_content_windows.
6868         (tui_data_window::display_all_data)
6869         (tui_data_window::do_scroll_vertical): Update.
6870         * tui/tui-data.h (struct tui_data_window)
6871         <delete_data_content_windows>: New method.
6872
6873 2019-07-17  Tom Tromey  <tom@tromey.com>
6874
6875         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6876         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6877
6878 2019-07-17  Tom Tromey  <tom@tromey.com>
6879
6880         * tui/tui-windata.h (tui_display_all_data): Don't declare.
6881         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6882         from tui_display_all_data.
6883         * tui/tui-win.c
6884         (tui_data_window::do_make_visible_with_new_height): Update.
6885         * tui/tui-regs.c (tui_show_registers): Update.
6886         * tui/tui-layout.c (tui_set_layout): Update.
6887         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6888         method.
6889
6890 2019-07-17  Tom Tromey  <tom@tromey.com>
6891
6892         * tui/tui-windata.h (tui_display_data_from): Don't declare.
6893         * tui/tui-windata.c (tui_display_data_from): Remove.
6894         (tui_data_window::refresh_all): Update.
6895
6896 2019-07-17  Tom Tromey  <tom@tromey.com>
6897
6898         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6899         * tui/tui-windata.c (tui_display_data_from_line): Remove.
6900         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6901         tui_display_registers_from_line.
6902         * tui/tui-regs.h (tui_display_registers_from_line): Update.
6903         * tui/tui-regs.c (tui_display_registers_from_line): Remove
6904         "force_display" parameter.
6905
6906 2019-07-17  Tom Tromey  <tom@tromey.com>
6907
6908         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6909         declare.
6910         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6911         Rename from tui_first_reg_element_no_inline.
6912         (tui_display_reg_element_at_line)
6913         (tui_display_registers_from_line): Update.
6914         * tui/tui-data.h (struct tui_data_window)
6915         <first_reg_element_no_inline>: New method.
6916
6917 2019-07-17  Tom Tromey  <tom@tromey.com>
6918
6919         * tui/tui-windata.c (tui_display_data_from)
6920         (tui_data_window::do_scroll_vertical): Update.
6921         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6922         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6923         Rename from tui_line_from_reg_element_no.
6924         (tui_display_registers_from_line): Update.
6925         * tui/tui-data.h (struct tui_data_window)
6926         <line_from_reg_element_no>: New method.
6927
6928 2019-07-17  Tom Tromey  <tom@tromey.com>
6929
6930         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6931         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6932         tui_last_regs_line_no.
6933         (tui_display_reg_element_at_line)
6934         (tui_display_registers_from_line): Update.
6935         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6936         method.
6937
6938 2019-07-17  Tom Tromey  <tom@tromey.com>
6939
6940         PR tui/24722:
6941         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6942         (tui_update_breakpoint_info): Add "being_deleted" parameter.
6943         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6944         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6945         (tui_update_breakpoint_info): Likewise.
6946         * tui/tui-hooks.c (tui_event_create_breakpoint)
6947         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6948         Update.
6949
6950 2019-07-17  Tom Tromey  <tom@tromey.com>
6951
6952         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6953
6954 2019-07-17  Tom Tromey  <tom@tromey.com>
6955
6956         * tui/tui-winsource.c (tui_update_source_window_as_is)
6957         (tui_update_source_windows_with_addr): Update.
6958         * tui/tui-source.h (tui_set_source_content)
6959         (tui_show_symtab_source): Add "win_info" parameter.
6960         * tui/tui-source.c (tui_set_source_content): Add "win_info"
6961         parameter.
6962         (tui_show_symtab_source): Likewise.
6963
6964 2019-07-17  Tom Tromey  <tom@tromey.com>
6965
6966         * tui/tui-wingeneral.c
6967         (tui_check_and_display_highlight_if_needed): Check can_highlight.
6968
6969 2019-07-17  Tom Tromey  <tom@tromey.com>
6970
6971         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6972         (struct tui_cmd_window) <can_scroll>: New method.
6973         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6974         method.
6975
6976 2019-07-17  Tom Tromey  <tromey@adacore.com>
6977
6978         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6979         do_field_signed>: Rename.  Change type of "value".
6980         * ui-out.c (ui_out::field_signed): Rename from field_int.
6981         Change type of "value".
6982         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
6983         type of "value".
6984         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6985         do_field_int.  Change type of "value".
6986         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6987         do_field_int.  Change type of "value".
6988         * tracepoint.c (trace_status_mi, tfind_1)
6989         (print_one_static_tracepoint_marker): Update.
6990         * thread.c (print_thread_info_1, print_selected_thread_frame):
6991         Update.
6992         * stack.c (print_frame, print_frame_info): Update.
6993         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6994         Update.
6995         * source.c (print_source_lines_base): Update.
6996         * skip.c (info_skip_command): Update.
6997         * record-btrace.c (btrace_ui_out_decode_error)
6998         (btrace_call_history_src_line): Update.
6999         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7000         Update.
7001         * progspace.c (print_program_space): Update.
7002         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7003         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7004         do_field_int.  Change type of "value".
7005         * mi/mi-out.c (mi_ui_out::do_table_begin)
7006         (mi_ui_out::do_table_header): Update.
7007         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
7008         type of "value".
7009         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7010         (mi_cmd_data_list_changed_registers, output_register)
7011         (mi_cmd_data_read_memory, mi_load_progress)
7012         (mi_cmd_trace_frame_collected): Update.
7013         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7014         Update.
7015         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7016         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7017         (mi_cmd_var_list_children, varobj_update_one): Update.
7018         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7019         (mi_cmd_stack_list_args, list_arg_or_local): Update.
7020         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7021         * inferior.c (print_inferior): Update.
7022         * gdb_bfd.c (print_one_bfd): Update.
7023         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7024         Update.
7025         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7026         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7027         do_field_int.  Change type of "value".
7028         * cli-out.c (cli_ui_out::do_field_signed): Rename from
7029         do_field_int.  Change type of "value".
7030         * breakpoint.c (watchpoint_check, print_breakpoint_location)
7031         (print_one_breakpoint_location, print_it_catch_fork)
7032         (print_one_catch_fork, print_it_catch_vfork)
7033         (print_one_catch_vfork, print_it_catch_solib)
7034         (print_it_catch_exec, print_it_ranged_breakpoint)
7035         (print_mention_watchpoint, print_mention_masked_watchpoint)
7036         (bkpt_print_it, update_static_tracepoint): Update.
7037         * break-catch-throw.c (print_it_exception_catchpoint): Update.
7038         * break-catch-syscall.c (print_it_catch_syscall): Update.
7039         * ada-tasks.c (print_ada_task_info): Update.
7040         * ada-lang.c (print_it_exception, print_mention_exception):
7041         Update.
7042
7043 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
7044
7045         PR breakpoints/24541
7046         * gdbarch.c: Regenerate.
7047         * gdbarch.h: Regenerate.
7048         * gdbarch.sh: Adjust return type and parameter types for
7049         'stap_adjust_register'.
7050         (i386_stap_adjust_register): Adjust signature and return new
7051         register name.
7052         * stap-probe.c (stap_parse_register_operand): Adjust use of
7053         'gdbarch_stap_adjust_register'.
7054
7055 2019-07-17  Tom Tromey  <tromey@adacore.com>
7056
7057         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
7058         declare VEC.
7059         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7060         std::vector.
7061         (struct s390_process_info): Add initializers.
7062         (s390_add_process): Use new.
7063         (s390_linux_nat_target::low_forget_process): Use delete.
7064         (s390_linux_nat_target::low_new_fork)
7065         (s390_linux_nat_target::stopped_by_watchpoint)
7066         (s390_linux_nat_target::low_prepare_to_resume)
7067         (s390_linux_nat_target::insert_watchpoint)
7068         (s390_linux_nat_target::insert_hw_breakpoint)
7069         (s390_linux_nat_target::remove_watchpoint)
7070         (s390_linux_nat_target::remove_hw_breakpoint): Update.
7071
7072 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7073
7074         * aarch64-fbsd-nat.c: Include regcache.h.
7075         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7076         argument.
7077         (aarch64_fbsd_nat_target::fetch_registers)
7078         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7079         variable.
7080         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7081
7082 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7083
7084         * fbsd-nat.c: Include gdbarch.h.
7085
7086 2019-07-15  Tom Tromey  <tromey@adacore.com>
7087
7088         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7089
7090 2019-07-15  Tom Tromey  <tromey@adacore.com>
7091
7092         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7093         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7094         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7095         * cli-out.c (cli_ui_out::do_field_int): New method.
7096         * ui-out.c (ui_out::field_unsigned): New method.
7097         * symfile.c (generic_load): Use field_unsigned.
7098         (print_transfer_performance): Likewise.
7099         * record-btrace.c (ui_out_field_uint): Remove.
7100         (btrace_call_history_insn_range, btrace_call_history): Use
7101         field_unsigned.
7102         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7103         field_unsigned.
7104         * ui-out.h (class ui_out) <field_unsigned>: New method.
7105         <do_field_unsigned>: Likewise.
7106
7107 2019-07-15  Tom Tromey  <tromey@adacore.com>
7108
7109         * mi/mi-main.c (list_available_thread_groups): Use field_string.
7110         * mi/mi-interp.c (mi_memory_changed): Use field_string.
7111         * target.c (flash_erase_command): Use field_string.
7112         * infrun.c (print_signal_received_reason): Use field_string.
7113         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7114         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7115         field_string.
7116         * ada-tasks.c (print_ada_task_info): Use field_string.
7117
7118 2019-07-15  Tom Tromey  <tromey@adacore.com>
7119
7120         * target.c (flash_erase_command): Use field_core_addr.
7121         * symfile.c (generic_load): Use field_core_addr.
7122         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7123         Use field_core_addr.
7124         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7125         field_core_addr.
7126
7127 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7128
7129         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7130         value if its desired type is smaller than a CORE_ADDR and signed.
7131
7132 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7133
7134         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7135         of changes to field names, and use new is_reference field to
7136         decide if a property is a reference or not.
7137         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7138         field.
7139         (struct dwarf2_property_baton): Update header comment, rename
7140         'referenced_type' to 'property_type' and update comments.
7141         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7142         default property type, store in property baton, update to take
7143         accound of renamed field.
7144         (read_func_scope): Update call to attr_to_dynamic_prop.
7145         (read_array_type): Likewise.
7146         (dwarf2_per_cu_addr_sized_int_type): New function.
7147         (read_subrange_index_type): Move type finding code to
7148         dwarf2_per_cu_addr_sized_int_type.
7149         (read_subrange_type): Update calls to attr_to_dynamic_prop.
7150         (dwarf2_per_cu_addr_type): New function.
7151         (set_die_type): Update calls to attr_to_dynamic_prop.
7152
7153 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7154
7155         * dwarf2read.c (read_subrange_index_type): New function.
7156         (read_subrange_type): Move code into new function and call it.
7157         * gdbtypes.c (create_range_type): Add some asserts.
7158
7159 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7160
7161         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7162         update return statements.
7163         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7164         declaration, and update comment to match.
7165         * gdbtypes.c (resolve_dynamic_array): Update call to
7166         dwarf2_evaluate_property to match new return type.
7167
7168 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7169
7170         * valarith.c (value_subscripted_rvalue): Change lowerbound
7171         parameter type from int to LONGEST.
7172         * value.h (value_subscripted_rvalue): Likewise in declaration.
7173
7174 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7175
7176         * cli/cli-utils.c (info_print_command_completer): New function.
7177         * cli/cli-utils.h: Add 'completer.h' include, and forward
7178         declaration for 'struct cmd_list_element'.
7179         (info_print_command_completer): Declare.
7180         * stack.c (_initialize_stack): Add completer for 'info locals' and
7181         'info args'.
7182         * symtab.c (_initialize_symtab): Add completer for 'info
7183         variables' and 'info functions'.
7184         * NEWS: Mention completion for additional info commands.
7185
7186 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7187
7188         * cli/cli-utils.c (extract_info_print_args): Delete.
7189         (extract_arg_maybe_quoted): Delete.
7190         (info_print_options_defs): New variable.
7191         (make_info_print_options_def_group): New function.
7192         (extract_info_print_options): Define new function.
7193         * cli/cli-utils.h (extract_info_print_args): Delete.
7194         (struct info_print_options): New structure.
7195         (extract_info_print_options): Declare new function.
7196         * stack.c (info_locals_command): Update to use new
7197         extract_info_print_options, also add a header comment.
7198         (info_args_command): Likewise.
7199         * symtab.c (info_variables_command): Likewise.
7200         (info_functions_command): Likewise.
7201
7202 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7203
7204         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7205         to extract string arguments.
7206         * common/common-utils.c (extract_string_maybe_quoted): New function.
7207         * common/common-utils.h (extract_string_maybe_quoted): Declare.
7208
7209 2019-07-11  Tom Tromey  <tromey@adacore.com>
7210
7211         * main.c (get_init_files): Use GDBINIT, not gdbinit.
7212         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7213         * top.h (gdbinit): Don't declare.
7214         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7215         into...
7216         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
7217         * top.c (gdb_init): Don't call init_cli_cmds.
7218         (gdbinit): Remove.
7219         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7220
7221 2019-07-11  Tom Tromey  <tromey@adacore.com>
7222
7223         * python/py-inferior.c (add_thread_object): Don't use thread_obj
7224         after it has been moved.
7225
7226 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7227
7228         * valops.c (value_must_coerce_to_target): Change return type to
7229         bool.
7230         * value.h (value_must_coerce_to_target): Likewise.
7231
7232 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
7233
7234         * breakpoint.c (is_hardware_watchpoint): Remove
7235         forward-declaration.
7236         (is_masked_watchpoint): Change return type to bool.
7237         (is_tracepoint): Likewise.
7238         (is_breakpoint): Likewise.
7239         (is_hardware_watchpoint): Likewise.
7240         (is_watchpoint): Likewise.
7241         (is_no_memory_software_watchpoint): Likewise.
7242         (is_catchpoint): Likewise.
7243         (breakpoint_1): Make FILTER parameter's return type bool.
7244         is_masked_watchpoint): Change return type to bool.
7245         (save_breakpoints): Make FILTER parameter's return type bool.
7246         * breakpoint.h (is_breakpoint): Change return type to bool.
7247         (is_watchpoint): Likewise.
7248         (is_catchpoint): Likewise.
7249         (is_tracepoint): Likewise.
7250
7251 2019-07-10  Tom Tromey  <tom@tromey.com>
7252
7253         * defs.h: Don't include gdbarch.h.
7254         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7255         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7256         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7257         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7258         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7259         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7260         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7261         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7262         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7263         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7264         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7265         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7266         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7267         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7268         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7269         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7270         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7271         record-btrace.c, record.h, regcache-dump.c, regcache.h,
7272         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7273         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7274         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7275         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7276         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7277         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7278         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7279         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7280         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7281
7282 2019-07-10  Tom Tromey  <tromey@adacore.com>
7283
7284         * ada-lang.h (is_ada_exception_catchpoint): Declare.
7285         * breakpoint.c (init_ada_exception_breakpoint): Register as
7286         bp_catchpoint.
7287         (print_one_breakpoint_location, print_one_breakpoint): Use
7288         is_ada_exception_catchpoint.
7289         * ada-lang.c (class ada_catchpoint_location): Pass
7290         bp_loc_software_breakpoint to bp_location constructor.
7291         (is_ada_exception_catchpoint): New function.
7292
7293 2019-07-10  Tom Tromey  <tromey@adacore.com>
7294
7295         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
7296         VEC.
7297         (struct arm_exidx_entry): New method operator<.
7298         (struct arm_exidx_data) <section_maps>: Change type.
7299         (arm_exidx_data_free): Remove.
7300         (arm_exidx_data_key): Change type.  Move lower.
7301         (arm_exidx_new_objfile): Update.
7302         (arm_compare_exidx_entries): Remove.
7303         (arm_find_exidx_entry, _initialize_arm_tdep)
7304
7305 2019-07-10  Tom Tromey  <tromey@adacore.com>
7306
7307         * solib-spu.c (ocl_program_data_key): Change type.
7308         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7309         Update.
7310
7311 2019-07-10  Tom Tromey  <tromey@adacore.com>
7312
7313         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
7314         (struct solib_aix_inferior_data) <library_list>: Change type.
7315         (solib_aix_inferior_data_handle): Change type.
7316         (get_solib_aix_inferior_data): Update.
7317         (solib_aix_free_library_list): Remove.
7318         (library_list_start_library): Update.
7319         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7320         return type.
7321         (solib_aix_get_library_list)
7322         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7323         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7324
7325 2019-07-10  Tom Tromey  <tromey@adacore.com>
7326
7327         * solib-dsbt.c (struct dsbt_info): Add initializers.
7328         (solib_dsbt_pspace_data): Change type.
7329         (dsbt_pspace_data_cleanup): Remove.
7330         (get_dsbt_info, _initialize_dsbt_solib): Update.
7331
7332 2019-07-10  Tom Tromey  <tromey@adacore.com>
7333
7334         * spu-tdep.c (spu_overlay_data): Change type.
7335         (spu_get_overlay_table, spu_overlay_new_objfile)
7336         (_initialize_spu_tdep): Update.
7337
7338 2019-07-10  Tom Tromey  <tromey@adacore.com>
7339
7340         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7341         destructor.
7342         (dbx_objfile_data_key): Change type and declare later.
7343         (DBX_SYMFILE_INFO): Rewrite.
7344         * dbxread.c (dbx_objfile_data_key): Change type.
7345         (dbx_symfile_init): Update.
7346         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
7347         (coffstab_build_psymtabs, elfstab_build_psymtabs)
7348         (stabsect_build_psymtabs, _initialize_dbxread): Update.
7349
7350 2019-07-10  Tom Tromey  <tromey@adacore.com>
7351
7352         * jit.c (jit_program_space_key): Change type.  Move lower.
7353         (get_jit_program_space_data): Update.
7354         (jit_program_space_data_cleanup): Remove.
7355         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7356         Update.
7357         (struct jit_program_space_data): Add initializers.
7358
7359 2019-07-10  Tom Tromey  <tromey@adacore.com>
7360
7361         * solib-darwin.c (struct darwin_info): Add initializers.
7362         (solib_darwin_pspace_data): Change type.
7363         (darwin_pspace_data_cleanup): Remove.
7364         (get_darwin_info, _initialize_darwin_solib): Update.
7365
7366 2019-07-10  Tom Tromey  <tromey@adacore.com>
7367
7368         * remote-sim.c (struct sim_inferior_data): Add initializers,
7369         constructor, and destructor.
7370         (sim_inferior_data_key): Change type.  Move lower.
7371         (check_for_duplicate_sim_descriptor): Update.
7372         (get_sim_inferior_data): Use new.  Update.
7373         (~sim_inferior_data_cleanup): Rename from
7374         sim_inferior_data_cleanup.  Simplify.
7375         (gdbsim_close_inferior, simulator_command)
7376         (sim_command_completer, _initialize_remote_sim): Update.
7377         (next_pid, INITIAL_PID): Move earlier.
7378
7379 2019-07-10  Tom Tromey  <tromey@adacore.com>
7380
7381         * python/python-internal.h (create_thread_object): Return
7382         gdbpy_ref.
7383         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7384         * python/py-inferior.c (struct threadlist_entry): Add
7385         constructor.
7386         <thread_obj>: Now a gdbpy_ref.
7387         (thread_to_thread_object): Update.
7388         (add_thread_object): Use new.
7389         (delete_thread_object): Use delete.
7390         (infpy_threads): Update.
7391         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
7392         GIL.
7393
7394 2019-07-10  Tom Tromey  <tromey@adacore.com>
7395
7396         * valops.c (value_cast): Specialize error message for Ada.
7397
7398 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7399
7400         * breakpoint.c (breakpoint_1): Update doc and parameter names.
7401
7402 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7403
7404         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7405         bpstat_should_step): Return bool, adjust comments.
7406         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7407         bpstat_should_step): Likewise.
7408
7409 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7410
7411         * features/Makefile: Use feature target descriptions for Arm.
7412         * features/arm/arm-core.c: Generate new file.
7413         * features/arm/arm-fpa.c: Likewise.
7414         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7415         * features/arm/arm-m-profile.c: Likewise.
7416         * features/arm/arm-vfpv2.c: Likewise.
7417         * features/arm/arm-vfpv3.c: Likewise.
7418         * features/arm/xscale-iwmmxt.c: Likewise.
7419         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7420
7421 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7422
7423         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7424         ptrace earlier.
7425
7426 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7427
7428         * features/aarch64-pauth.c: Regenerate.
7429
7430 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
7431
7432         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7433         bool.
7434         (bpstat_what): Use false instead of 0.
7435
7436 2019-07-09  Pedro Alves  <palves@redhat.com>
7437
7438         * break-catch-throw.c (is_exception_catchpoint): New.
7439         * breakpoint.c (print_one_breakpoint_location): New parameter
7440         'raw_loc'.  Handle it.  Use
7441         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7442         looking at the breakpoint's type.
7443         (print_one_breakpoint): If handling "maint info breakpoints", also
7444         print locations of exception catchpoints.
7445         * breakpoint.h (is_exception_catchpoint): Declare.
7446
7447 2019-07-09  Pedro Alves  <palves@redhat.com>
7448
7449         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7450         "addr" field.
7451         (allocate_location_exception_catchpoint): New.
7452         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7453         (initialize_throw_catchpoint_ops): Install
7454         allocate_location_exception_catchpoint as allocate_location
7455         method.
7456         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7457         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7458         bp_loc_other.
7459         (breakpoint_address_is_meaningful): Delete.
7460         (bl_address_is_meaningful): New.
7461         (breakpoint_locations_match): Adjust comment.
7462         (bp_location_from_bp_type): New, factored out of...
7463         (bp_location::bp_location(breakpoint *)): ... this.
7464         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7465         factored out of...
7466         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
7467         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7468         breakpoint_address_is_meaningful.
7469         (bp_locations_compare): Adjust comment.
7470         (update_global_location_list): Use bl_address_is_meaningful
7471         instead of breakpoint_address_is_meaningful.
7472         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7473         explicit.
7474         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7475         * python/py-breakpoint.c (bppy_get_location): No longer check
7476         whether location is null.
7477
7478 2019-07-09  Pedro Alves  <palves@redhat.com>
7479
7480         PR c++/15468
7481         * breakpoint.c (print_one_breakpoint_location): Remove
7482         single-location assert.
7483
7484 2019-07-09  Tom Tromey  <tom@tromey.com>
7485
7486         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7487         * configure: Rebuild.
7488         * configure.ac: Change common to gdbsupport.
7489         * gdbsupport: Rename from common.
7490         * acinclude.m4: Change common to gdbsupport.
7491         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7492         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7493         gdbsupport.
7494         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7495         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7496         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7497         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7498         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7499         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7500         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7501         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7502         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7503         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7504         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7505         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7506         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7507         coff-pe-read.c, command.h, compile/compile-c-support.c,
7508         compile/compile-c.h, compile/compile-cplus-symbols.c,
7509         compile/compile-cplus-types.c, compile/compile-cplus.h,
7510         compile/compile-loc2c.c, compile/compile.c, completer.c,
7511         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7512         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7513         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7514         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7515         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7516         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7517         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7518         features/aarch64-core.c, features/aarch64-fpu.c,
7519         features/aarch64-pauth.c, features/aarch64-sve.c,
7520         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7521         features/i386/32bit-core.c, features/i386/32bit-linux.c,
7522         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7523         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7524         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7525         features/i386/64bit-core.c, features/i386/64bit-linux.c,
7526         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7527         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7528         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7529         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7530         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7531         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7532         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7533         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7534         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7535         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7536         go32-nat.c, guile/guile.c, guile/scm-ports.c,
7537         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7538         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7539         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7540         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7541         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7542         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7543         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7544         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7545         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7546         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7547         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7548         minsyms.c, mips-linux-tdep.c, namespace.h,
7549         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7550         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7551         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7552         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7553         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7554         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7555         nat/linux-waitpid.c, nat/mips-linux-watch.c,
7556         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7557         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7558         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7559         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7560         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7561         procfs.c, producer.c, progspace.h, psymtab.h,
7562         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7563         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7564         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7565         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7566         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7567         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7568         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7569         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7570         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7571         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7572         target-memory.c, target.c, target.h, target/waitstatus.c,
7573         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7574         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7575         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7576         unittests/array-view-selftests.c,
7577         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7578         unittests/common-utils-selftests.c,
7579         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7580         unittests/format_pieces-selftests.c,
7581         unittests/function-view-selftests.c,
7582         unittests/lookup_name_info-selftests.c,
7583         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7584         unittests/mkdir-recursive-selftests.c,
7585         unittests/observable-selftests.c,
7586         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7587         unittests/parse-connection-spec-selftests.c,
7588         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7589         unittests/scoped_fd-selftests.c,
7590         unittests/scoped_mmap-selftests.c,
7591         unittests/scoped_restore-selftests.c,
7592         unittests/string_view-selftests.c, unittests/style-selftests.c,
7593         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7594         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7595         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7596         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7597         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7598         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7599
7600 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7601
7602         * linespec.c (decode_digits_list_mode): Set explicit_line to a
7603         bool value.
7604         (decode_digits_ordinary): Set explicit_line field in sal.
7605         * symtab.c (skip_prologue_sal): Don't skip prologue for a
7606         symtab_and_line that was set on an explicit line number in
7607         assembler code.  Do always update the recorded symtab and line if
7608         we do skip the prologue.
7609
7610 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7611
7612         * breakpoint.c (set_breakpoint_location_function): Remove
7613         explicit_loc parameter.
7614         (momentary_breakpoint_from_master): Update call to
7615         set_breakpoint_location_function.
7616         (add_location_to_breakpoint): Likewise.
7617
7618 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7619
7620         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7621         required features based on default bfd type when no specific bfd
7622         is present.
7623
7624 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7625
7626         * NEWS: Mention that GDB printf and eval commands can now print
7627         C-style and Ada-style convenience var strings without
7628         calling the inferior.
7629         * printcmd.c (printf_c_string): Locally print GDB internal var
7630         instead of transiting via the inferior.
7631         (printf_wide_c_string): Likewise.
7632
7633 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7634
7635         PR breakpoints/25011
7636         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7637
7638 2019-07-04  Tom Tromey  <tom@tromey.com>
7639
7640         PR tui/24724:
7641         * tui/tui-winsource.c (tui_clear_source_content): Update.
7642         (tui_source_window_base::set_is_exec_point_at): Fix comment.
7643         (tui_update_breakpoint_info): Update.
7644         (tui_set_exec_info_content): Update.
7645         * tui/tui-source.c (tui_set_source_content_nil): Update.
7646         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7647         has_break.
7648         * tui/tui-data.h (enum tui_bp_flag): New.
7649         (tui_bp_flags): New enum flags type.
7650         (struct tui_source_element) <break_mode>: Change type.  Rename
7651         from has_break.
7652         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7653         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
7654         constants.
7655         * tui/tui-winsource.h: Fix comment.
7656
7657 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7658
7659         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7660         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7661         (store_fpregs_to_thread)
7662         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7663         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7664         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7665         (IWMMXT_REGS_SIZE): Add define.
7666         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7667         (fetch_vfp_regs, store_vfp_regs)
7668         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7669         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7670
7671 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7672
7673         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7674         defines.
7675         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7676         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7677         (ARM_INT_REGISTER_SIZE): ...to this.
7678         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7679         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7680         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7681         (arm_linux_collect_gregset, supply_nwfpe_register)
7682         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7683         defines.
7684         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7685         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7686         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7687         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7688         (arm_return_in_memory, arm_store_return_value)
7689         (arm_get_longjmp_target, arm_register_g_packet_guesses)
7690         (arm_record_ld_st_multiple): Likewise.
7691         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7692         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7693
7694 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7695
7696         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7697         AARCH64_DISPLACED_MODIFIED_INSNS.
7698         * aarch64-tdep.c (struct aarch64_displaced_step_data)
7699         (aarch64_displaced_step_copy_insn): Likewise.
7700         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7701         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7702         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7703         ARM_DISPLACED_MODIFIED_INSNS.
7704         * arm-tdep.c (arm_gdbarch_init): Likewise.
7705         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7706         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7707         (struct arm_displaced_step_closure): Use
7708         ARM_DISPLACED_MODIFIED_INSNS.
7709
7710 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7711
7712         * features/Makefile: Remove unused xml files.
7713         * features/aarch64.xml: Remove.
7714         * features/i386/amd64-avx-avx512-linux.xml: Remove.
7715         * features/i386/amd64-avx-avx512.xml: Remove.
7716         * features/i386/amd64-avx-linux.xml: Remove.
7717         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7718         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7719         * features/i386/amd64-avx-mpx-linux.xml: Remove.
7720         * features/i386/amd64-avx-mpx.xml: Remove.
7721         * features/i386/amd64-avx.xml: Remove.
7722         * features/i386/amd64-linux.xml: Remove.
7723         * features/i386/amd64-mpx-linux.xml: Remove.
7724         * features/i386/amd64-mpx.xml: Remove.
7725         * features/i386/amd64.xml: Remove.
7726         * features/i386/i386-avx-avx512-linux.xml: Remove.
7727         * features/i386/i386-avx-avx512.xml: Remove.
7728         * features/i386/i386-avx-linux.xml: Remove.
7729         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7730         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7731         * features/i386/i386-avx-mpx-linux.xml: Remove.
7732         * features/i386/i386-avx-mpx.xml: Remove.
7733         * features/i386/i386-avx.xml: Remove.
7734         * features/i386/i386-linux.xml: Remove.
7735         * features/i386/i386-mmx-linux.xml: Remove.
7736         * features/i386/i386-mmx.xml: Remove.
7737         * features/i386/i386-mpx-linux.xml: Remove.
7738         * features/i386/i386-mpx.xml: Remove.
7739         * features/i386/i386.xml: Remove.
7740         * features/i386/x32-avx-avx512-linux.xml: Remove.
7741         * features/i386/x32-avx-linux.xml: Remove.
7742         * features/i386/x32-linux.xml: Remove.
7743
7744 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7745
7746         * regformats/aarch64.dat: Remove.
7747         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7748         * regformats/i386/amd64-avx-linux.dat: Remove.
7749         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7750         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7751         * regformats/i386/amd64-linux.dat: Remove.
7752         * regformats/i386/amd64-mpx-linux.dat: Remove.
7753         * regformats/i386/amd64.dat: Remove.
7754         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7755         * regformats/i386/i386-avx-linux.dat: Remove.
7756         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7757         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7758         * regformats/i386/i386-linux.dat: Remove.
7759         * regformats/i386/i386-mmx-linux.dat: Remove.
7760         * regformats/i386/i386-mpx-linux.dat: Remove.
7761         * regformats/i386/i386.dat: Remove.
7762         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7763         * regformats/i386/x32-avx-linux.dat: Remove.
7764         * regformats/i386/x32-linux.dat: Remove.
7765
7766 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7767
7768         * aarch64-tdep.c: Remove xml self tests.
7769         * amd64-linux-tdep.c: Likewise.
7770         * amd64-tdep.c: Likewise.
7771         * i386-linux-tdep.c: Likewise.
7772         * i386-tdep.c: Likewise.
7773
7774 2019-07-03  Pedro Alves  <palves@redhat.com>
7775
7776         PR cli/24732
7777         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7778         (pipe_cmd_option_defs): New.
7779         (make_pipe_cmd_options_def_group): New.
7780         (pipe_command): Use gdb::option::process_options.
7781         (pipe_command_completer): New function.
7782         (_initialize_cli_cmds): Install completer for "pipe" command.
7783
7784 2019-07-03  Pedro Alves  <palves@redhat.com>
7785
7786         * cli/cli-option.c (union option_value) <string>: New field.
7787         (struct option_def_and_value): Add ctor, move ctor, dtor and
7788         use DISABLE_COPY_AND_ASSIGN.
7789         (option_def_and_value::clear_value): New.
7790         (parse_option, save_option_value_in_ctx, get_val_type_str)
7791         (add_setshow_cmds_for_options): Handle var_string.
7792         * cli-option.h (union option_def::var_address) <string>: New
7793         field.
7794         (struct string_option_def): New.
7795         * maint-test-options.c (struct test_options_opts): Add default
7796         ctor and use DISABLE_COPY_AND_ASSIGN.
7797         <string_opt>: New field.
7798         (test_options_opts::~test_options_opts): New.
7799         (test_options_opts::dump): Also dump "-string".
7800         (test_options_option_defs): Install "string.
7801
7802 2019-07-03  Pedro Alves  <palves@redhat.com>
7803
7804         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7805         option_value with a null enumeration.
7806         (complete_options): Save the option values in the context.
7807         (save_option_value_in_ctx): New, factored out from ...
7808         (process_options): ... here.
7809         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7810         of the function.
7811         * maint-test-options.c (test_options_opts::dump): New, factored
7812         out from ...
7813         (maintenance_test_options_command_mode): ... here.
7814         (maintenance_test_options_command_completion_result): Delete.
7815         (maintenance_test_options_command_completion_text): Update
7816         comment.
7817         (maintenance_show_test_options_completion_result): Change
7818         prototype.  Just print
7819         maintenance_test_options_command_completion_text.
7820         (save_completion_result): New.
7821         (maintenance_test_options_completer_mode): Pass options context to
7822         complete_options, and then save a dump.
7823         (_initialize_maint_test_options): Use add_cmd to install "maint
7824         show test-options-completion-result".
7825
7826 2019-07-03  Pedro Alves  <palves@redhat.com>
7827
7828         * NEWS (New commands): Mention "with" and "maint with".
7829         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7830         (with_command, with_command_completer): New.
7831         (pipe_command): Adjust to new repeat_previous
7832         interface.
7833         (_initialize_cli_cmds): Install the "with" command and its "w"
7834         alias.
7835         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7836         declarations.
7837         * cli/cli-setshow.c (parse_cli_var_uinteger)
7838         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7839         argument strings for all var_types.
7840         (get_setshow_command_value_string): New, factored out from ...
7841         (do_show_command): ... this.
7842         * cli/cli-setshow.h: Include <string>.
7843         (get_setshow_command_value_string): Declare.
7844         * command.h (repeat_previous): Now returns const char *.  Adjust
7845         comment.
7846         * maint.c: Include "cli/cli-cmds.h".
7847         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7848         (_initialize_maint_cmds): Register the "maintenance with" command.
7849         * top.c (repeat_previous): Move bits from pipe_command here:
7850         Return the saved command line, if any; error out if there's no
7851         command to relaunch.
7852
7853 2019-07-03  Pedro Alves  <palves@redhat.com>
7854
7855         * NEWS (New commands): Mention "maint set/show test-settings"
7856         instead of "maint test-settings".
7857         * maint-test-settings.c (maintenance_test_settings_list): Delete.
7858         (maintenance_test_settings_set_list): Rename to ...
7859         (maintenance_set_test_settings_list): ... this.
7860         (maintenance_test_settings_show_list): Rename to  ...
7861         (maintenance_show_test_settings_list): ... this.
7862         (maintenance_test_settings_cmd): Delete.
7863         (maintenance_test_settings_set_cmd): ...
7864         (maintenance_set_test_settings_cmd): ... this.
7865         (maintenance_test_settings_show_cmd): ...
7866         (maintenance_show_test_settings_cmd): ... this.
7867         (maintenance_test_settings_show_value_cmd):
7868         (maintenance_show_test_settings_value_cmd): ... this.
7869         (_initialize_maint_test_settings): No longer install the "maint
7870         test-settings" prefix command.  Rename "maint test-settings set"
7871         to "maint set test-settings", and "maint test-settings show" to
7872         "maint show test-settings".  Adjust all subcommands.
7873
7874 2019-07-03  Pedro Alves  <palves@redhat.com>
7875
7876         * maint-test-settings.c: Fix file's intro comment.  Replace all
7877         references to "test-options" with references to "test-settings",
7878         in comments.
7879
7880 2019-07-03  Pedro Alves  <palves@redhat.com>
7881
7882         * maint-test-settings.c (maintenance_test_settings_xxx)
7883         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7884         New.
7885         (maintenance_test_settings_enums): Use them.
7886         (maintenance_test_settings_enum): Default to
7887         maintenance_test_settings_xxx.
7888         (_initialize_maint_test_settings): Initialize
7889         MAINTENANCE_TEST_SETTINGS_FILENAME.
7890
7891 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7892
7893         * breakpoint.h (remove_breakpoints_inf): Change return type to
7894         void, move function documentation here.
7895         * breakpoint.c (remove_breakpoints_inf): Change return type to
7896         void, move function documentation to header.
7897
7898 2019-07-02  Pedro Alves  <palves@redhat.com>
7899
7900         * NEWS (Completion improvements): Mention "info threads".
7901         * thread.c (struct info_threads_opts, info_threads_option_defs)
7902         (make_info_threads_options_def_group): New.
7903         (info_threads_command): Use gdb::option::process_options.
7904         (info_threads_command_completer): New.
7905         (_initialize_thread): Use gdb::option::build_help to build the
7906         help text for "info threads".
7907
7908 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7909
7910         * defs.h (generic_load): Move from here...
7911         * symfile.h (generic_load): ... to here.  Rename name parameter
7912         to args.
7913         * symfile.c (generic_load): Add comment.
7914
7915 2019-07-01  Tom Tromey  <tromey@adacore.com>
7916
7917         * dwarf2read.c
7918         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7919         declaration of without_params.  Fix formatting.
7920
7921 2019-07-01  Tom Tromey  <tromey@adacore.com>
7922
7923         * ada-exp.y (find_primitive_type): Update.
7924         * ada-lang.h (ada_lookup_symbol): Update.
7925         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7926         parameter.
7927         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7928
7929 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7930
7931         PR breakpoints/24541
7932         * gdbarch.c: Regenerate.
7933         * gdbarch.h: Regenerate.
7934         * gdbarch.sh: Add 'stap_adjust_register'.
7935         * i386-tdep.c: Include '<unordered_set>'.
7936         (i386_stap_adjust_register): New function.
7937         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7938         * stap-probe.c (stap_parse_register_operand): Call
7939         'gdbarch_stap_adjust_register'.
7940
7941 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7942
7943         PR python/24742
7944         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7945         * python/python.c (do_start_initialization): Use 'xmalloc'
7946         instead of 'PyMem_Malloc'.
7947
7948 2019-06-28  Tom Tromey  <tromey@adacore.com>
7949
7950         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7951         for Ada.
7952
7953 2019-06-27  Tom Tromey  <tromey@adacore.com>
7954
7955         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
7956         objfile_key.
7957         (arm_find_mapping_symbol, arm_record_special_symbol)
7958         (_initialize_arm_tdep): Update.
7959         (arm_objfile_data_free): Remove.
7960
7961 2019-06-27  Tom Tromey  <tromey@adacore.com>
7962
7963         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7964         to cp_print_static_field.
7965
7966 2019-06-26  Tom Tromey  <tromey@adacore.com>
7967
7968         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7969         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7970         declare.
7971
7972 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7973
7974         * features/aarch64-core.c (create_feature_aarch64_core):
7975         Regenerate.
7976         * features/aarch64-core.xml: Add cpsr flags.
7977
7978 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7979
7980         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7981         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7982
7983 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7984
7985         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7986         field.
7987         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7988         use.
7989         (arm_record_special_symbol): Don't insert new symbol in sorted
7990         position, push it at the end.
7991
7992 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7993
7994         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7995         (arm_mapping_symbol_s): Remove.
7996         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7997         (arm_mapping_symbol_vec): New typedef.
7998         (struct arm_per_objfile): Add constructor.
7999         <section_maps>: Change type to
8000         std::unique_ptr<arm_mapping_symbol_vec[]>.
8001         (arm_compare_mapping_symbols): Remove.
8002         (arm_find_mapping_symbol): Adjust to section_maps type change.
8003         (arm_objfile_data_free): Call delete on arm_per_objfile.
8004         (arm_record_special_symbol): Adjust to section_maps type change.
8005         Allocate arm_per_objfile with new.
8006
8007 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8008
8009         * cli/cli-cmds.c (alias_command): Compare the alias prefix
8010         with the command prefix.
8011
8012 2019-06-25  Tom Tromey  <tom@tromey.com>
8013
8014         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8015         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8016
8017 2019-06-25  Tom Tromey  <tom@tromey.com>
8018
8019         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8020         type.
8021         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8022         protected.
8023
8024 2019-06-25  Tom Tromey  <tom@tromey.com>
8025
8026         * tui/tui-winsource.c
8027         (tui_source_window_base::set_is_exec_point_at): Add check against
8028         LOA_ADDRESS.
8029
8030 2019-06-25  Tom Tromey  <tom@tromey.com>
8031
8032         * tui/tui-source.c (tui_set_source_content): Don't check before
8033         xfree.
8034         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8035
8036 2019-06-25  Tom Tromey  <tom@tromey.com>
8037
8038         * tui/tui-winsource.h (tui_update_source_window_as_is)
8039         (tui_alloc_source_buffer, tui_line_is_displayed)
8040         (tui_addr_is_displayed): Change type of win_info.
8041         * tui/tui-winsource.c (tui_update_source_window_as_is)
8042         (tui_clear_source_content, tui_show_source_line)
8043         (tui_show_source_content, tui_source_window_base::refill)
8044         (tui_source_window_base::set_is_exec_point_at)
8045         (tui_source_window_base::set_is_exec_point_at)
8046         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8047         (tui_alloc_source_buffer, tui_line_is_displayed)
8048         (tui_addr_is_displayed): Change type of win_info.  Update.
8049         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8050         (tui_source_window_base::do_make_visible_with_new_height):
8051         Update.
8052         * tui/tui-source.c (tui_set_source_content)
8053         (tui_set_source_content_nil)
8054         (tui_source_window::do_scroll_vertical): Update.
8055         * tui/tui-layout.c (show_layout): Update.
8056         * tui/tui-disasm.c (tui_set_disassem_content)
8057         (tui_disasm_window::do_scroll_vertical): Update.
8058         * tui/tui-data.h (tui_win_content): Remove.
8059         (struct tui_gen_win_info) <content, content_size>: Remove.
8060         (struct tui_source_element): Add initializers and destructor.
8061         (union tui_which_element, struct tui_win_element): Remove.
8062         (struct tui_source_window_base) <content>: New field.
8063         (struct tui_data_window): Remove destructor.
8064         (tui_alloc_content, tui_free_win_content)
8065         (tui_free_all_source_wins_content): Don't declare.
8066         * tui/tui-data.c (tui_initialize_static_data): Update.
8067         (init_content_element, tui_alloc_content): Remove.
8068         (~tui_gen_win_info): Update.
8069         (~tui_data_window, tui_free_all_source_wins_content)
8070         (tui_free_win_content, free_content, free_content_elements):
8071         Remove.
8072
8073 2019-06-25  Tom Tromey  <tom@tromey.com>
8074
8075         * tui/tui-winsource.h (tui_clear_source_content)
8076         (tui_erase_source_content, tui_show_source_content): Change type
8077         of win_info.
8078         * tui/tui-winsource.c (tui_clear_source_content)
8079         (tui_erase_source_content, tui_show_source_content): Change type
8080         of win_info.
8081         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8082         * tui/tui-source.h (tui_set_source_content_nil): Change type of
8083         win_info.
8084         * tui/tui-source.c (tui_set_source_content_nil): Change type of
8085         win_info.
8086         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8087
8088 2019-06-25  Tom Tromey  <tom@tromey.com>
8089
8090         * tui/tui-winsource.c (tui_clear_source_content)
8091         (tui_source_window_base::set_is_exec_point_at): Update.
8092         * tui/tui-source.c (tui_set_source_content_nil): Update.
8093         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8094         a bool.
8095         * tui/tui-data.c (init_content_element): Update.
8096
8097 2019-06-25  Tom Tromey  <tom@tromey.com>
8098
8099         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8100         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8101         * tui/tui-layout.c (init_and_make_win): Update.
8102         * tui/tui.h (enum tui_win_type): Update.
8103         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8104         tui_win_is_auxillary.
8105         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8106         tui_win_is_auxillary.
8107
8108 2019-06-25  Tom Tromey  <tom@tromey.com>
8109
8110         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8111         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8112         (tui_delete_data_content_windows, tui_display_all_data)
8113         (tui_data_window::do_scroll_vertical, tui_display_data_from):
8114         Update.
8115         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8116         * tui/tui-regs.c (tui_last_regs_line_no)
8117         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8118         (tui_show_registers): Update.
8119         (tui_show_register_group): Return void.  Update.
8120         (tui_display_registers_from, tui_display_reg_element_at_line)
8121         (tui_display_registers_from_line, tui_check_register_values):
8122         Update.
8123         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8124         member.
8125         (struct tui_data_window) <regs_content>: Now a std::vector.
8126         <regs_content_count>: Remove.
8127         (tui_add_content_elements, tui_free_data_content): Don't declare.
8128         * tui/tui-data.c (tui_data_window::clear_detail): Update.
8129         (init_content_element): Remove DATA_WIN case.  Add assert.
8130         (tui_add_content_elements): Remove.
8131         (tui_data_window): Update.
8132         (tui_free_data_content): Remove.
8133         (free_content_elements): Remove DATA_WIN case.
8134
8135 2019-06-25  Tom Tromey  <tom@tromey.com>
8136
8137         * tui/tui-data.c (tui_data_item_window): Update.
8138         * tui/tui-windata.h (tui_check_data_values): Don't declare.
8139         * tui/tui-windata.c (tui_display_all_data)
8140         (tui_display_data_from_line): Update.
8141         (tui_check_data_values): Remove.
8142         * tui/tui-regs.c (tui_show_register_group)
8143         (tui_display_reg_element_at_line): Update.
8144         * tui/tui-hooks.c (tui_register_changed)
8145         (tui_refresh_frame_and_register_information): Call
8146         tui_check_register_values.
8147         * tui/tui-data.h (struct tui_data_window) <data_content,
8148         data_content_count, data_type>: Remove.
8149         (enum tui_data_type): Remove.
8150
8151         * tui/tui-data.c (tui_data_window::clear_detail)
8152         (~tui_data_window): Update.
8153
8154 2019-06-25  Tom Tromey  <tom@tromey.com>
8155
8156         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8157         declare.
8158         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8159         Rename from tui_first_data_item_displayed.  Update.
8160         (tui_data_window::refresh_all)
8161         (tui_data_window::do_scroll_vertical): Update.
8162         * tui/tui-data.h (struct tui_data_window)
8163         <first_data_item_displayed>: Declare new method.
8164
8165 2019-06-25  Tom Tromey  <tom@tromey.com>
8166
8167         * tui/tui-data.h (tui_init_generic_part): Don't declare.
8168         * tui/tui-data.c (tui_init_generic_part): Remove, moving
8169         contents...
8170         (tui_initialize_static_data): ...here.
8171
8172 2019-06-25  Tom Tromey  <tom@tromey.com>
8173
8174         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8175         (tui_display_registers_from, tui_check_register_values): Update.
8176         (tui_display_register): Remove win_info parameter; update.
8177         (tui_get_register): Change type of parameters.
8178         * tui/tui-data.h (struct tui_data_element): Remove.
8179         (union tui_which_element) <data>: Remove.
8180         <data_window>: Change type.
8181         (struct tui_data_item_window): New.
8182         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8183         case.  Add assert.
8184         (~tui_data_item_window): New destructor.
8185         (free_content_elements): Remove DATA_ITEM_WIN case.
8186
8187 2019-06-25  Tom Tromey  <tom@tromey.com>
8188
8189         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8190         Remove.
8191
8192 2019-06-25  Tom Tromey  <tom@tromey.com>
8193
8194         * tui/tui-data.h (struct tui_command_element): Remove.
8195         (union tui_which_element) <command>: Remove.
8196         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
8197         assert.
8198         (free_content_elements): Remove CMD_WIN case.
8199
8200 2019-06-25  Tom Tromey  <tom@tromey.com>
8201
8202         * tui/tui-layout.c (tui_set_layout): Update.
8203         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8204         * tui/tui-data.c (layout_def): Update.
8205
8206 2019-06-25  Tom Tromey  <tom@tromey.com>
8207
8208         * tui/tui-wingeneral.c (tui_refresh_all): Update.
8209         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8210         (tui_source_window_base::set_new_height): Update.
8211         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8212         Update.
8213         (tui_set_locator_fullname, tui_set_locator_info)
8214         (tui_show_frame_info): Update.
8215         * tui/tui-source.c (tui_set_source_content)
8216         (tui_source_is_displayed): Update.
8217         * tui/tui-layout.c (show_source_disasm_command, show_data)
8218         (show_source_or_disasm_and_command): Update.
8219         * tui/tui-disasm.c (tui_set_disassem_content)
8220         (tui_get_begin_asm_address): Update.
8221         * tui/tui-data.h (struct tui_locator_element): Remove.
8222         (union tui_which_element) <locator>: Remove.
8223         (struct tui_locator_window): New.
8224         (tui_locator_win_info_ptr): Change return type.
8225         * tui/tui-data.c (_locator): Change type.
8226         (tui_locator_win_info_ptr): Change return type.
8227         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
8228         (tui_alloc_content): Add assert.
8229
8230 2019-06-25  Tom Tromey  <tom@tromey.com>
8231
8232         * tui/tui-winsource.c
8233         (tui_exec_info_window::maybe_allocate_content): New method.
8234         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8235         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8236         (make_source_or_disasm_window): Add cast.
8237         * tui/tui-data.h (union tui_which_element) <simple_string>:
8238         Remove.
8239         (struct tui_source_info): New.
8240         (struct tui_source_window_base) <execution_info>: Change type.
8241         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8242         case, and add assert.
8243         (tui_alloc_content): Add assert.
8244
8245 2019-06-25  Tom Tromey  <tom@tromey.com>
8246
8247         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8248         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8249         * tui/tui-data.c (tui_alloc_win_info): Remove.
8250
8251 2019-06-25  Tom Tromey  <tom@tromey.com>
8252
8253         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8254         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8255         can_highlight.
8256
8257 2019-06-25  Tom Tromey  <tom@tromey.com>
8258
8259         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8260         make_visible_with_new_height method.
8261         (tui_win_info::make_visible_with_new_height): New method.
8262         (tui_source_window_base::do_make_visible_with_new_height)
8263         (tui_data_window::do_make_visible_with_new_height)
8264         (tui_cmd_window::do_make_visible_with_new_height): New methods.
8265         (make_visible_with_new_height): Remove.
8266         (tui_resize_all, tui_adjust_win_heights): Use
8267         make_visible_with_new_height method.
8268         * tui/tui-data.h (struct tui_win_info)
8269         <do_make_visible_with_new_height, make_visible_with_new_height>:
8270         New methods.
8271         (struct tui_source_window_base, struct tui_data_window)
8272         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8273         methods.
8274
8275 2019-06-25  Tom Tromey  <tom@tromey.com>
8276
8277         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8278         method.
8279         (update_tab_width): Call update_tab_width method.
8280         * tui/tui-data.h (struct tui_win_info)
8281         (struct tui_source_window_base) <update_tab_width>: New methods.
8282
8283 2019-06-25  Tom Tromey  <tom@tromey.com>
8284
8285         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8286         parameter.
8287         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8288         parameter.
8289         (tui_gen_win_info::make_visible): Update.
8290         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8291         parameter.
8292         * tui/tui-data.h (enum tui_box): New enum.
8293         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8294
8295 2019-06-25  Tom Tromey  <tom@tromey.com>
8296
8297         * tui/tui-layout.c (make_source_or_disasm_window): Always use
8298         init_and_make_win for EXEC_INFO_WIN.
8299         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8300         longer inline.
8301         (struct tui_win_info) <~tui_win_info>: Inline.
8302         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8303         Don't declare.
8304         * tui/tui-data.c (source_win, disasm_win): Remove globals.
8305         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8306         Remove.
8307         (tui_initialize_static_data): Update.
8308         (~tui_gen_win_info): Handle more cleanup here.
8309         (~tui_source_window_base): Delete "execution_info".
8310         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8311
8312 2019-06-25  Tom Tromey  <tom@tromey.com>
8313
8314         * tui/tui-layout.c (make_command_window): Don't set
8315         can_highlight.
8316         (show_source_disasm_command): Call the reset method.
8317         (show_data): Don't set can_highlight.  Call the reset method.
8318         (tui_gen_win_info::reset): Rename from init_gen_win_info
8319         (init_and_make_win): Simplify.  Return tui_gen_win_info.
8320         (show_source_or_disasm_and_command): Call the reset method.
8321         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8322         (struct tui_cmd_window): Set can_highlight.
8323
8324 2019-06-25  Tom Tromey  <tom@tromey.com>
8325
8326         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8327         from make_visible.
8328         (tui_make_visible, tui_make_invisible): Rewrite.
8329         (tui_win_info::make_visible): Remove.
8330         (tui_source_window_base::make_visible): Update.
8331         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8332         method.  Moved from...
8333         (struct tui_win_info) <make_visible>: ...here.
8334
8335 2019-06-25  Tom Tromey  <tom@tromey.com>
8336
8337         * tui/tui-winsource.c
8338         (tui_source_window_base::do_scroll_horizontal): Remove direction
8339         parameter.
8340         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8341         direction parameter.
8342         * tui/tui-win.c (tui_win_info::forward_scroll)
8343         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8344         (tui_win_info::right_scroll): Update.
8345         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8346         direction parameter.
8347         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8348         direction parameter.
8349         * tui/tui-data.h (enum tui_scroll_direction): Remove.
8350         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8351         Remove direction parameter.
8352         (struct tui_source_window_base, struct tui_source_window)
8353         (struct tui_disasm_window, struct tui_data_window)
8354         (struct tui_cmd_window): Update.
8355
8356 2019-06-25  Tom Tromey  <tom@tromey.com>
8357
8358         * tui/tui-winsource.h (tui_set_exec_info_content)
8359         (tui_show_exec_info_content, tui_erase_exec_info_content)
8360         (tui_clear_exec_info_content, tui_update_exec_info): Change
8361         argument to tui_source_window_base.
8362         * tui/tui-winsource.c (tui_set_exec_info_content)
8363         (tui_show_exec_info_content, tui_erase_exec_info_content)
8364         (tui_clear_exec_info_content, tui_update_exec_info): Change
8365         argument to tui_source_window_base.
8366
8367 2019-06-25  Tom Tromey  <tom@tromey.com>
8368
8369         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8370         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8371
8372 2019-06-25  Tom Tromey  <tom@tromey.com>
8373
8374         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8375         check.
8376
8377 2019-06-25  Tom Tromey  <tom@tromey.com>
8378
8379         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8380         type to void.
8381         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8382         type to void.
8383         * tui/tui-source.c (tui_set_source_content): Update.
8384         * tui/tui-disasm.c (tui_set_disassem_content): Update.
8385
8386 2019-06-25  Tom Tromey  <tom@tromey.com>
8387
8388         * tui/tui-win.c (window_name_completer, tui_set_focus)
8389         (tui_all_windows_info): Use name method.
8390         * tui/tui-data.h (struct tui_gen_win_info)
8391         (struct tui_source_window, struct tui_disasm_window)
8392         (struct tui_data_window, struct tui_cmd_window) <name>: New
8393         method.
8394         (tui_win_name): Don't declare.
8395         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8396         (tui_win_name): Remove.
8397
8398 2019-06-25  Tom Tromey  <tom@tromey.com>
8399
8400         * tui/tui-winsource.h (tui_update_source_window)
8401         (tui_update_source_window_as_is): Change parameter type.
8402         * tui/tui-winsource.c (tui_update_source_window): Change win_info
8403         to be a tui_source_window_base.
8404         (tui_update_source_window_as_is): Likewise.
8405         * tui/tui-win.c (make_visible_with_new_height): Update.
8406
8407 2019-06-25  Tom Tromey  <tom@tromey.com>
8408
8409         * tui/tui-winsource.c (tui_erase_source_content)
8410         (tui_show_source_content, tui_show_exec_info_content)
8411         (tui_erase_exec_info_content): Use refresh_window method.
8412         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8413         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8414         from tui_refresh_win.
8415         (tui_data_window::refresh_window): New method.
8416         (tui_win_info::refresh, tui_source_window_base::refresh)
8417         (tui_refresh_all): Use refresh_window method.
8418         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8419         method.
8420         * tui/tui-regs.c (tui_display_register): Call refresh_window
8421         method.
8422         * tui/tui-layout.c (show_source_disasm_command)
8423         (show_source_or_disasm_and_command): Call refresh_window method.
8424         * tui/tui-data.h (struct tui_gen_win_info)
8425         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8426         New method.
8427
8428 2019-06-25  Tom Tromey  <tom@tromey.com>
8429
8430         * tui/tui.c (tui_rl_other_window, tui_enable)
8431         (tui_is_window_visible, tui_get_command_dimension): Update.
8432         * tui/tui-winsource.c (tui_update_source_window_as_is)
8433         (tui_clear_source_content, tui_erase_source_content)
8434         (tui_show_source_line, tui_source_window_base::refill)
8435         (tui_source_window_base::do_scroll_horizontal)
8436         (tui_source_window_base::set_is_exec_point_at)
8437         (tui_update_breakpoint_info, tui_set_exec_info_content)
8438         (tui_alloc_source_buffer, tui_line_is_displayed)
8439         (tui_addr_is_displayed): Update.
8440         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8441         (tui_check_and_display_highlight_if_needed)
8442         (tui_win_info::make_visible, tui_win_info::refresh)
8443         (tui_refresh_all): Update.
8444         * tui/tui-windata.c (tui_first_data_item_displayed)
8445         (tui_delete_data_content_windows, tui_erase_data_content)
8446         (tui_display_all_data, tui_data_window::refresh_all)
8447         (tui_check_data_values): Update.
8448         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8449         (tui_set_win_focus_to, tui_win_info::forward_scroll)
8450         (tui_win_info::backward_scroll, tui_refresh_all_win)
8451         (tui_resize_all, tui_set_focus, tui_all_windows_info)
8452         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8453         (tui_source_window_base::set_new_height)
8454         (tui_data_window::set_new_height)
8455         (make_invisible_and_set_new_height)
8456         (make_visible_with_new_height, new_height_ok)
8457         (parse_scrolling_args): Update.
8458         * tui/tui-stack.c (tui_show_frame_info): Update.
8459         * tui/tui-source.c (tui_set_source_content)
8460         (tui_set_source_content_nil, tui_source_is_displayed)
8461         (tui_source_window::do_scroll_vertical): Update.
8462         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8463         (tui_display_registers_from, tui_display_reg_element_at_line)
8464         (tui_check_register_values, tui_reg_command): Update.
8465         * tui/tui-layout.c (tui_default_win_height)
8466         (show_source_disasm_command, show_data, init_and_make_win)
8467         (show_source_or_disasm_and_command): Update.
8468         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8469         (tui_redisplay_readline, tui_mld_flush)
8470         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8471         (tui_getc): Update.
8472         * tui/tui-disasm.c (tui_set_disassem_content)
8473         (tui_disasm_window::do_scroll_vertical): Update.
8474         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8475         Now virtual.
8476         (struct tui_win_info): Derive from tui_gen_win_info.
8477         <~tui_win_info>: Mark as override.
8478         <generic>: Remove member.
8479         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8480         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8481         (~tui_data_window, ~tui_win_info)
8482         (tui_free_all_source_wins_content): Update.
8483         * tui/tui-command.c (tui_refresh_cmd_win): Update.
8484
8485 2019-06-25  Tom Tromey  <tom@tromey.com>
8486
8487         * tui/tui-layout.c (init_and_make_win): Use new.
8488         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8489         destructor, initializers.
8490         (tui_alloc_generic_win_info): Don't declare.
8491         * tui/tui-data.c (_locator): Add argument to constructor.
8492         (source_win, disasm_win): New globals.
8493         (exec_info): Remove.
8494         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8495         Update.
8496         (tui_alloc_generic_win_info): Remove.
8497         (init_content_element): Use new.
8498         (tui_win_info::tui_win_info): Update.
8499         (free_content_elements) <case DATA_WIN>: Use delete.
8500
8501 2019-06-25  Tom Tromey  <tom@tromey.com>
8502
8503         * tui/tui-wingeneral.c (tui_refresh_win): Update.
8504         * tui/tui-windata.c (tui_first_data_item_displayed)
8505         (tui_delete_data_content_windows): Update.
8506         * tui/tui-win.c (tui_data_window::set_new_height): Update.
8507         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8508         (tui_display_registers_from, tui_check_register_values): Update.
8509         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8510         pointer.
8511         * tui/tui-data.c (init_content_element): Update.  Allocate the new
8512         window.
8513         (tui_free_data_content): Update.
8514         (free_content_elements) <case DATA_WIN>: Free the window.
8515
8516 2019-06-25  Tom Tromey  <tom@tromey.com>
8517
8518         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8519         Update.
8520         * tui/tui-layout.c (make_command_window)
8521         (show_source_disasm_command, show_data, init_and_make_win)
8522         (show_source_or_disasm_and_command): Update.
8523         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8524         method.
8525         <can_highight, is_highlighted>: Now bool.
8526         (tui_set_win_highlight): Don't declare.
8527         * tui/tui-data.c (tui_set_win_highlight): Remove.
8528
8529 2019-06-25  Tom Tromey  <tom@tromey.com>
8530
8531         * tui/tui-wingeneral.c (make_visible): Remove check of window
8532         type.
8533
8534 2019-06-25  Tom Tromey  <tom@tromey.com>
8535
8536         * tui/tui-win.c (tui_win_info::max_height)
8537         (tui_cmd_window::max_height): New methods.
8538         (new_height_ok): Call max_height.
8539         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8540         <max_height>: New method.
8541
8542 2019-06-25  Tom Tromey  <tom@tromey.com>
8543
8544         * tui/tui-win.c (tui_source_window_base::set_new_height)
8545         (tui_data_window::set_new_height): New methods.
8546         (make_invisible_and_set_new_height): Call set_new_height method.
8547         * tui/tui-data.h (struct tui_win_info)
8548         (struct tui_source_window_base, struct tui_data_window)
8549         <set_new_height>: New method.
8550
8551 2019-06-25  Tom Tromey  <tom@tromey.com>
8552
8553         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8554         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8555         tui_refresh_data_win.
8556         * tui/tui-win.c (tui_source_window_base::refresh_all): New
8557         method.
8558         (tui_refresh_all_win): Call the refresh_all method.
8559         (tui_set_focus): Likewise.
8560         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8561         (struct tui_source_window_base, struct tui_data_window) <refresh>:
8562         Likewise.
8563
8564 2019-06-25  Tom Tromey  <tom@tromey.com>
8565
8566         * tui/tui-winsource.h (tui_refill_source_window)
8567         (tui_set_is_exec_point_at): Don't declare.
8568         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8569         (tui_source_window_base::refill): Rename from
8570         tui_refill_source_window.
8571         (tui_source_window_base::do_scroll_horizontal): Update.
8572         (tui_source_window_base::set_is_exec_point_at): Rename from
8573         tui_set_is_exec_point_at.
8574         (tui_update_all_breakpoint_info): Update.
8575         * tui/tui-stack.c (tui_show_frame_info): Update.
8576         * tui/tui-layout.c (show_data): Add cast.
8577         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8578         * tui/tui-data.h (struct tui_source_window_base) <refill,
8579         set_is_exec_point_at>: New methods.
8580         (tui_source_windows, tui_add_to_source_windows): Update types.
8581         (tui_add_to_source_windows): Remove redundant declaration.
8582         * tui/tui-data.c (source_windows): Store tui_source_window_base.
8583         (tui_source_windows): Change return type.
8584         (tui_clear_source_windows_detail): Update.
8585         (tui_add_to_source_windows): Change type of parameter.
8586         (tui_free_all_source_wins_content): Update.
8587
8588 2019-06-25  Tom Tromey  <tom@tromey.com>
8589
8590         * tui/tui-wingeneral.c (tui_win_info::refresh)
8591         (tui_source_window_base::refresh): New methods.
8592         (tui_refresh_all): Call the refresh method.
8593         * tui/tui-data.h (struct tui_win_info)
8594         (struct tui_source_window_base) <refresh>: New method.
8595
8596 2019-06-25  Tom Tromey  <tom@tromey.com>
8597
8598         * tui/tui.h (tui_is_window_visible): Return bool.
8599         * tui/tui.c (tui_is_window_visible): Return bool.
8600         * tui/tui-wingeneral.c (tui_make_window, make_visible)
8601         (tui_make_visible, tui_make_invisible)
8602         (tui_win_info::make_visible)
8603         (tui_source_window_base::make_visible, make_all_visible)
8604         (tui_make_all_visible, tui_make_all_invisible): Update.
8605         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8606         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8607         bool.
8608         (struct tui_win_info, struct tui_source_window_base)
8609         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8610         * tui/tui-data.c (tui_init_generic_part): Update.
8611
8612 2019-06-25  Tom Tromey  <tom@tromey.com>
8613
8614         * tui/tui-wingeneral.c (tui_win_info::make_visible)
8615         (tui_source_window_base::make_visible): New methods.
8616         (make_all_visible): Make method call.
8617         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8618         (struct tui_source_window_base, struct tui_cmd_window): Override
8619         make_visible.
8620         (tui_win_is_source_type): Don't declare.
8621         * tui/tui-data.c (tui_win_is_source_type): Remove.
8622
8623 2019-06-25  Tom Tromey  <tom@tromey.com>
8624
8625         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8626         NULL check.
8627
8628 2019-06-25  Tom Tromey  <tom@tromey.com>
8629
8630         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8631         Inline constructor.  Add initializers for members.
8632         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8633         constructors; now inline in class.
8634
8635 2019-06-25  Tom Tromey  <tom@tromey.com>
8636
8637         * tui/tui-regs.c (tui_show_registers): Update.
8638         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8639         bool.
8640         * tui/tui-data.c (tui_data_window::clear_detail)
8641         (tui_data_window): Update.
8642
8643 2019-06-25  Tom Tromey  <tom@tromey.com>
8644
8645         * tui/tui-windata.c (tui_display_all_data)
8646         (tui_display_data_from_line, tui_display_data_from)
8647         (tui_check_data_values, tui_data_window::do_scroll_vertical):
8648         Update.
8649         * tui/tui-regs.c (tui_last_regs_line_no)
8650         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8651         (tui_show_registers, tui_show_register_group)
8652         (tui_display_registers_from, tui_display_reg_element_at_line)
8653         (tui_display_registers_from_line, tui_check_register_values)
8654         (tui_reg_next, tui_reg_prev): Update.
8655         * tui/tui-layout.c (tui_set_layout, show_data): Update.
8656         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
8657         tui_data_window.
8658         (struct tui_win_info) <detail>: Remove.  Add new fields from
8659         tui_data_info.
8660         (TUI_DATA_WIN): Add cast.
8661         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8662         (~tui_data_window): Simplify.
8663
8664 2019-06-25  Tom Tromey  <tom@tromey.com>
8665
8666         * tui/tui-layout.c (show_source_disasm_command)
8667         (show_source_or_disasm_and_command): Update.
8668         * tui/tui-io.c (update_cmdwin_start_line)
8669         (tui_redisplay_readline): Update.
8670         * tui/tui-data.h (struct tui_command_info): Remove.
8671         (struct tui_win_info) <detail>: Remove command_info member.
8672         (struct tui_data_window) <start_line>: New member, from
8673         tui_command_info.
8674         (TUI_CMD_WIN): Add casts.
8675
8676 2019-06-25  Tom Tromey  <tom@tromey.com>
8677
8678         * tui/tui-winsource.c (tui_update_source_window)
8679         (tui_refill_source_window)
8680         (tui_source_window_base::do_scroll_horizontal)
8681         (tui_update_breakpoint_info, tui_set_exec_info_content)
8682         (tui_show_exec_info_content, tui_erase_exec_info_content)
8683         (tui_clear_exec_info_content): Update.
8684         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8685         Update.
8686         * tui/tui-win.c (make_invisible_and_set_new_height)
8687         (make_visible_with_new_height): Update.
8688         * tui/tui-source.c (tui_set_source_content)
8689         (tui_show_symtab_source): Update.
8690         * tui/tui-layout.c (extract_display_start_addr)
8691         (show_source_disasm_command, show_data)
8692         (make_source_or_disasm_window)
8693         (show_source_or_disasm_and_command): Update.
8694         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8695         (tui_disasm_window::do_scroll_vertical): Remove shadowing
8696         "gdbarch".
8697         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
8698         to tui_source_window_base.
8699         (struct tui_win_info) <detail>: Remove source_info member.
8700         (struct tui_source_window_base) <has_locator>: Inline.
8701         Move contents from tui_source_info; rename has_locator member to
8702         m_has_locator.
8703         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8704         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8705         header file.
8706         (tui_source_window_base::clear_detail, ~tui_source_window_base):
8707         Simplify.
8708         (tui_free_all_source_wins_content): Cast to
8709         tui_source_window_base.
8710
8711 2019-06-25  Tom Tromey  <tom@tromey.com>
8712
8713         * tui/tui-win.c (make_invisible_and_set_new_height)
8714         (make_visible_with_new_height): Call has_locator method.
8715         * tui/tui-layout.c (show_source_disasm_command, show_data)
8716         (show_source_or_disasm_and_command): Update for bool change.
8717         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8718         (tui_win_info) <has_locator>: New method.
8719         (struct tui_source_window_base) <has_locator>: New method.
8720         (tui_win_has_locator): Don't declare.
8721         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8722         from tui_win_has_locator.
8723         (tui_source_window_base): Use false, not FALSE.
8724
8725 2019-06-25  Tom Tromey  <tom@tromey.com>
8726
8727         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8728         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8729         clear_detail method directly.
8730         (tui_clear_win_detail): Remove.
8731
8732 2019-06-25  Tom Tromey  <tom@tromey.com>
8733
8734         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8735         "this", not TUI_DISASM_WIN.
8736
8737 2019-06-25  Tom Tromey  <tom@tromey.com>
8738
8739         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
8740         declare.
8741         * tui/tui-winsource.c
8742         (tui_source_window_base::do_scroll_horizontal): Rename from
8743         tui_horizontal_source_scroll.
8744         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8745         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8746         from tui_vertical_data_scroll.
8747         * tui/tui-win.h (tui_scroll): Don't declare.
8748         * tui/tui-win.c (tui_win_info::forward_scroll)
8749         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8750         (tui_win_info::right_scroll): Rename and update.
8751         (tui_scroll_forward_command, tui_scroll_backward_command)
8752         (tui_scroll_left_command, tui_scroll_right_command): Update.
8753         (tui_scroll): Remove.
8754         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8755         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8756         from tui_vertical_source_scroll.
8757         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8758         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8759         from tui_vertical_disassem_scroll.
8760         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8761         do_scroll_horizontal>: New methods.
8762         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8763         Likewise.
8764         (struct tui_source_window_base): Add do_scroll_horizontal.
8765         (struct tui_source_window, struct tui_disasm_window): Add
8766         do_scroll_vertical.
8767         (struct tui_data_window, struct tui_cmd_window): Add
8768         do_scroll_horizontal and do_scroll_vertical.
8769         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8770
8771 2019-06-25  Tom Tromey  <tom@tromey.com>
8772
8773         * tui/tui-data.h (struct tui_source_window_base): New struct.
8774         (struct tui_source_window): Derive from tui_source_window_base.
8775         (struct tui_disasm_window): New struct.
8776         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8777         from tui_source_window::clear_detail.
8778         (tui_source_window_base): Rename from tui_source_window.
8779         (~tui_source_window_base): Rename from ~tui_source_window.
8780         (tui_alloc_win_info): Create a tui_disasm_window.
8781
8782 2019-06-25  Tom Tromey  <tom@tromey.com>
8783
8784         * tui/tui-data.h (struct tui_source_window)
8785         (struct tui_data_window): Declare destructors.
8786         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8787         destructors.
8788         (tui_win_info): Simplify.
8789
8790 2019-06-25  Tom Tromey  <tom@tromey.com>
8791
8792         * tui/tui-winsource.c (tui_display_main)
8793         (tui_update_source_windows_with_addr)
8794         (tui_update_all_breakpoint_info): Update.
8795         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8796         (new_height_ok, parse_scrolling_args): Update.
8797         * tui/tui-stack.c (tui_show_frame_info): Update.
8798         * tui/tui-data.h (struct tui_list): Remove.
8799         (tui_source_windows): Return a reference to a std::vector.
8800         * tui/tui-data.c (source_windows): Now a std::vector.
8801         (tui_source_windows): Change return type.
8802         (tui_clear_source_windows): Rewrite.
8803         (tui_clear_source_windows_detail, tui_add_to_source_windows)
8804         (tui_free_all_source_wins_content): Rewrite.
8805
8806 2019-06-25  Tom Tromey  <tom@tromey.com>
8807
8808         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8809         (struct tui_data_window, struct tui_cmd_window): Declare
8810         clear_detail method.
8811         * tui/tui-data.c (tui_source_window::clear_detail)
8812         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8813         methods.
8814         (tui_clear_win_detail): Simplify.
8815
8816 2019-06-25  Tom Tromey  <tom@tromey.com>
8817
8818         * tui/tui-layout.c (make_source_window, make_disasm_window)
8819         (make_source_or_disasm_window): Remove win_info_ptr parameter.
8820         Return the new window.
8821         (show_source_disasm_command, show_data)
8822         (show_source_or_disasm_and_command): Update.
8823
8824 2019-06-25  Tom Tromey  <tom@tromey.com>
8825
8826         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8827         parameter.  Return the new window.
8828         (show_source_disasm_command): Update and remove NULL check.
8829         (show_source_or_disasm_and_command): Update.
8830
8831 2019-06-25  Tom Tromey  <tom@tromey.com>
8832
8833         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8834
8835 2019-06-25  Tom Tromey  <tom@tromey.com>
8836
8837         * tui/tui-data.h (struct tui_win_info): Make constructor
8838         protected.  Make destructor virtual.  Add initializers.
8839         (tui_source_window, tui_data_window, tui_cmd_window): New
8840         classes.
8841         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
8842         constructor.  Add "type" parameter.
8843         (tui_source_window, tui_data_window, tui_cmd_window): New
8844         constructors.
8845         (tui_alloc_win_info): Instantiate the appropriate subclass.
8846
8847 2019-06-25  Tom Tromey  <tom@tromey.com>
8848
8849         * tui/tui-win.c (tui_resize_all): Use delete.
8850         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8851         destructor.
8852         (tui_free_window): Don't declare.
8853         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8854         Update.
8855
8856 2019-06-25  Tom Tromey  <tom@tromey.com>
8857
8858         * tui/tui-data.h (struct tui_win_info): Add constructor.
8859         * tui/tui-data.c (tui_alloc_win_info): Use new.
8860         (tui_free_window): Use delete.
8861
8862 2019-06-22  Tom Tromey  <tom@tromey.com>
8863
8864         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8865         declare.
8866         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8867
8868 2019-06-22  Tom Tromey  <tom@tromey.com>
8869
8870         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8871         declare.
8872         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8873
8874 2019-06-22  Tom de Vries  <tdevries@suse.de>
8875
8876         * dwarf2read.c (create_addrmap_from_aranges)
8877         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8878         instead of '%zu'.
8879
8880 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
8881
8882         * dwarf2read.h (dwarf2_section_info_def): Remove.
8883         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8884         * dwarf2read.c (struct dwo_sections) <types>: Change type to
8885         std::vector<dwarf2_section_info>.
8886         (struct dwo_file) <~dwo_file>: Remove.
8887         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8888         types field.
8889         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8890         (dwarf2_read_debug_names): Likewise.
8891         (create_debug_types_hash_table): Change parameter type to
8892         array_view, adjust code accordingly.
8893         (dwarf2_locate_dwo_sections): Adjust to std::vector.
8894         (partial_die_info::fixup): Likewise.
8895         (determine_prefix): Likewise.
8896         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8897
8898 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8899
8900         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8901         gdb_bfd_ref_ptr.
8902         <~dwo_file>: Remove call to gdb_bfd_unref.
8903         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8904         gdb_bfd_ref_ptr::get.
8905
8906 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8907
8908         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8909         type to htab_up.
8910         * dwarf2read.c (struct dwo_file): Initialize fields.
8911         <~dwo_file>: New.
8912         (free_dwo_file): Remove, move content to ~dwo_file.
8913         (struct dwo_file_deleter): Remove.
8914         (dwo_file_up>: Remove custom deleter.
8915         (free_dwo_files): Remove.
8916         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8917         dwo_files.
8918         (process_skeletonless_type_units): Call unique_ptr::get.
8919         (allocate_dwo_file_hash_table): Add deleter to created hash
8920         table.  Change return type to htab_up.
8921         (lookup_dwo_file_slot): Don't memset dwo_file, call
8922         unique_ptr::get.
8923         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8924         (create_dwo_unit_in_dwp_v2): Likewise.
8925         (open_and_init_dwo_file): Likewise.
8926         (free_dwo_file_from_slot): Remove.
8927
8928 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8929
8930         * dwarf2read.h (struct dwarf2_section_info) <readin,
8931         is_virtual>: Change type to bool.
8932         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8933         true instead of 1.
8934
8935 2019-06-19  Tom Tromey  <tom@tromey.com>
8936
8937         * tui/tui-data.h (tui_init_content_element): Don't declare.
8938
8939 2019-06-19  Tom Tromey  <tom@tromey.com>
8940
8941         * tui/tui-data.h (tui_init_win_info): Don't declare.
8942
8943 2019-06-19  Tom de Vries  <tdevries@suse.de>
8944
8945         * dwarf2read.h (abstract_to_concrete): Change type to
8946         std::unordered_map<sect_offset, std::vector<sect_offset>,
8947         gdb::hash_enum<sect_offset>>.
8948
8949 2019-06-19  Tom Tromey  <tromey@adacore.com>
8950
8951         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8952         EVAL_AVOID_SIDE_EFFECTS specially.
8953
8954 2019-06-19  Tom Tromey  <tromey@adacore.com>
8955
8956         * source-cache.c (highlighter): New global.
8957         (source_cache::get_source_lines): Create a highlighter on demand.
8958
8959 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8960
8961         * defs.h (deprecated_interactive_hook): Delete declaration.
8962         * interps.c (clear_interpreter_hooks): Remove use of
8963         deprecated_interactive_hook.
8964         * top.c (deprecated_interactive_hook): Delete definition.
8965         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8966
8967 2019-06-18  Tom de Vries  <tdevries@suse.de>
8968
8969         PR gdb/24515
8970         * dwarf2read.h (abstract_to_concrete): Change type from
8971         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8972         std::unordered_map<sect_offset, std::vector<sect_offset>>.
8973         * dwarf2read.c (read_variable): Update.
8974         (dwarf2_fetch_die_loc_sect_off): Update.
8975
8976 2019-06-17  Tom de Vries  <tdevries@suse.de>
8977
8978         PR gdb/24617
8979         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8980         accessing parent[parent_len - 1].
8981
8982 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
8983
8984         PR gdb/24364
8985         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8986         call dtrace_process_dof with NULL dof.
8987
8988 2019-06-16  Tom de Vries  <tdevries@suse.de>
8989
8990         PR gdb/24445
8991         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8992
8993 2019-06-16  Tom Tromey  <tom@tromey.com>
8994
8995         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8996         (make_all_visible): Use address of member.
8997
8998 2019-06-16  Tom Tromey  <tom@tromey.com>
8999
9000         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9001         (tui_free_window, free_content, free_content_elements): Remove
9002         unnecessary cast.
9003         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9004         cast.
9005         * tui/tui-regs.c (tui_show_register_group)
9006         (tui_display_registers_from, tui_display_reg_element_at_line):
9007         Remove unnecessary cast.
9008
9009 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
9010
9011         * linux-nat.c (normal_mask): Delete.
9012         (_initialize_linux_nat): Don't initialise normal_mask.
9013
9014 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
9015
9016         PR gdb/24445
9017         * dwarf-index-write.h (write_psymtabs_to_index): Add
9018         dwz_basename parameter.
9019         * dwarf-index-write.c (write_gdbindex): Move file writing to
9020         write_gdbindex_1.  Change return type void.
9021         (assert_file_size): Move up, remove filename parameter.
9022         (write_gdbindex_1): New function.
9023         (write_debug_names): Change return type to void, call
9024         assert_file_size.
9025         (struct index_wip_file): New struct.
9026         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
9027         file logic to index_wip_file.  Write index for dwz file if
9028         needed.
9029         (save_gdb_index_command): Pass basename of dwz file, if present.
9030         * dwarf-index-cache.c (index_cache::store): Obtain and pass
9031         build-id of dwz file, if present.
9032         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9033         (dwarf2_get_dwz_file): Likewise.
9034         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9035         (dwarf2_get_dwz_file): Likewise.
9036
9037 2019-06-16  Tom Tromey  <tom@tromey.com>
9038
9039         * coffread.c (process_coff_symbol): Use xstrdup.
9040         * value.c (create_internalvar): Use xstrdup.
9041
9042 2019-06-16  Tom Tromey  <tom@tromey.com>
9043
9044         * valops.c (value_cast, value_slice): Remove unnecessary cast.
9045         * breakpoint.c (stopin_command, stopat_command)
9046         (until_break_command, decode_location_default): Remove unnecessary
9047         cast.
9048         * utils.c (subset_compare): Remove unnecessary cast.
9049         * ada-lang.c (ada_update_initial_language): Remove unnecessary
9050         cast.
9051         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9052         cast.
9053         * infcmd.c (path_command): Remove unnecessary cast.
9054         * coffread.c (decode_type): Remove unnecessary cast.
9055         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9056         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9057         * tui/tui-stack.c (tui_show_locator_content)
9058         (tui_show_frame_info): Remove unnecessary cast.
9059         * tui/tui-win.c (tui_scroll_forward_command)
9060         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9061         (parse_scrolling_args): Remove unnecessary cast.
9062         * tui/tui-data.c (init_win_info, tui_del_window)
9063         (tui_free_window, tui_del_data_windows, tui_free_data_content)
9064         (free_content_elements): Remove unnecessary cast.
9065         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9066         unnecessary cast.
9067         * tui/tui-source.c (tui_set_source_content)
9068         (tui_vertical_source_scroll): Remove unnecessary cast.
9069         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9070         cast.
9071         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9072         * tui/tui-regs.c (tui_display_registers_from)
9073         (tui_display_register): Remove unnecessary cast.
9074         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9075         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9076         (make_visible): Remove unnecessary cast.
9077         * tui/tui-winsource.c (tui_erase_source_content)
9078         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9079         unnecessary cast.
9080         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9081         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9082         * stabsread.c (read_type, read_array_type, read_range_type):
9083         Remove unnecessary cast.
9084         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9085         (parse_symbol, parse_type, upgrade_type, parse_external)
9086         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9087         unnecessary cast.
9088         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9089
9090 2019-06-16  Tom Tromey  <tom@tromey.com>
9091
9092         * tui/tui-data.c (tui_alloc_generic_win_info)
9093         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9094         checks.
9095
9096 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
9097             Andrew Burgess  <andrew.burgess@embecosm.com>
9098
9099         * f-typeprint.c (f_print_type): Don't return early for not
9100         associated or not allocated types.
9101         (f_type_print_varspec_suffix): Add print_rank parameter and print
9102         ranks of array types in case they dangling.
9103         (f_type_print_base): Add print_rank parameter.
9104
9105 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9106
9107         * NEWS: Mention new MI commands.
9108         * break-catch-throw.c (enum exception_event_kind): Move to
9109         breakpoint.h.
9110         (print_mention_exception_catchpoint): Output text as a single
9111         message.
9112         (catch_exception_command_1): Rename to...
9113         (catch_exception_event): ...this, make non-static, update header
9114         command, and change some parameter types.
9115         (catch_catch_command): Update for changes to
9116         catch_exception_command_1.
9117         (catch_throw_command): Likewise.
9118         (catch_rethrow_command): Likewise.
9119         * breakpoint.c (enum exception_event_kind): Delete.
9120         * breakpoint.h (enum exception_event_kind): Moved here from
9121         break-catch-throw.c.
9122         (catch_exception_event): Declare.
9123         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9124         (mi_cmd_catch_throw): New function.
9125         (mi_cmd_catch_rethrow): New function.
9126         (mi_cmd_catch_catch): New function.
9127         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9128         'catch-catch' entries.
9129         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9130         (mi_cmd_catch_rethrow): Declare.
9131         (mi_cmd_catch_catch): Declare.
9132
9133 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9134
9135         * annotate.c (annotate_source_line): Change return type to void,
9136         update implementation to match.
9137         * annotate.h (annotate_source_line): Change return type to void,
9138         update header comment.
9139         * stack.c (print_frame_info): Don't change what frame information
9140         is printed based on whether annotations are on or not.
9141
9142 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9143
9144         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9145         (annotate_source): Make static.
9146         (annotate_source_line): Moved from source.c and renamed from
9147         identify_source_line.  Update the return type.
9148         * annotate.h (annotate_source): Delete declaration.
9149         (annotate_source_line): Declaration moved from source.h, and
9150         renamed from identify_source_line.  Return type updated.
9151         * source.c (identify_source_line): Moved to annotate.c and renamed
9152         to annotate_source_line.
9153         (info_line_command): Remove check of annotation_level.
9154         * source.h (identify_source_line): Move declaration to annotate.h
9155         and rename to annotate_source_line.
9156         * stack.c: Add 'annotate.h' include.
9157         (print_frame_info): Remove check of annotation_level before
9158         calling annotate_source_line.
9159
9160 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9161
9162         * source-cache.c (source_cache::get_plain_source_lines): Use
9163         open_source_file_with_line_charpos instead of just
9164         open_source_file, remove call to find_source_lines.
9165         (source_cache::get_source_lines): Likewise.
9166         * source.c (find_source_lines): Make static.
9167         (get_filename_and_charpos): Renamed into...
9168         (open_source_file_with_line_charpos): ..this along with changes to
9169         return a scoped_fd, and some other minor clean ups.
9170         (identify_source_line): Use open_source_file_with_line_charpos.
9171         (search_command_helper): Use open_source_file_with_line_charpos
9172         instead of just open_source_file, remove call to
9173         find_source_lines.
9174         * source.h (open_source_file_with_line_charpos): Declare new
9175         function.
9176         (find_source_lines): Delete declaration.
9177
9178 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9179
9180         * source.c (get_filename_and_charpos): Remove fullname
9181         parameter.
9182         (identify_source_line): Update call to get_filename_and_charpos.
9183
9184 2019-06-14  Tom Tromey  <tromey@adacore.com>
9185
9186         PR gdb/24502:
9187         * ui-style.h (skip_ansi_escape): Update comment.
9188         * ui-file.h (class no_terminal_escape_file): New class.
9189         * ui-file.c (no_terminal_escape_file::write)
9190         (no_terminal_escape_file::puts): New methods.
9191         * cli/cli-logging.c (handle_redirections): Use
9192         no_terminal_escape_file.
9193
9194 2019-06-14  Tom Tromey  <tromey@adacore.com>
9195
9196         * NEWS: Move convenience variable news above Python news.
9197
9198 2019-06-14  Tom Tromey  <tom@tromey.com>
9199
9200         * gnulib: Move directory to top-level.
9201         * configure.ac: Don't configure gnulib.
9202         * configure: Rebuild.
9203         * common/common-defs.h: Use new path to gnulib.
9204         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9205         (GNULIB_H): Remove.
9206         (INCGNU): Look in new gnulib location.
9207         (HFILES_NO_SRCDIR): Remove gnulib files.
9208         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9209         (generated_files): Remove GNULIB_H.
9210         ($(LIBGNU), all-lib): Remove targets.
9211         (distclean): Don't mention GNULIB_BUILDDIR.
9212         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9213
9214 2019-06-14  Tom Tromey  <tromey@adacore.com>
9215
9216         * symfile.c (add_symbol_file_command): Remove obsolete comment.
9217         Warn if symbol file does not provide any symbols.
9218
9219 2019-06-14  Tom Tromey  <tromey@adacore.com>
9220
9221         * source.c (find_and_open_source): Respect basenames_may_differ.
9222
9223 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
9224
9225         * annotate.c (annotate_breakpoints_invalid): Make use of
9226         scoped_restore_terminal_state.
9227         (annotate_frames_invalid): Likewise.
9228
9229 2019-06-14  Tom Tromey  <tromey@adacore.com>
9230
9231         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9232         allow assignment to an internalvar.
9233
9234 2019-06-14  Tom Tromey  <tromey@adacore.com>
9235
9236         * ada-lex.l: Allow "_" in attribute names.
9237
9238 2019-06-14  Tom Tromey  <tromey@adacore.com>
9239
9240         PR gdb/24653:
9241         * regcache.c (registers_changed): Don't call alloca.
9242         * top.c (execute_command): Don't call alloca.
9243
9244 2019-06-13  Pedro Alves  <palves@redhat.com>
9245
9246         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9247         'expression'.  When parsing an expression, error out if there's
9248         junk after "unlimited".
9249         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9250         (do_set_command): Adjust calls to is_unlimited_literal.
9251
9252 2019-06-13  Pedro Alves  <palves@redhat.com>
9253
9254         * compile/compile.c (make_compile_options_def_group): Add braces
9255         around array_view initializer.
9256         * thread.c (make_thread_apply_all_options_def_group)
9257         (make_thread_apply_all_options_def_group): Likewise.
9258
9259 2019-06-13  Pedro Alves  <palves@redhat.com>
9260
9261         * NEWS (New commands): Mention "maint test-options
9262         require-delimiter", "maint test-options unknown-is-error", "maint
9263         test-options unknown-is-operand" and "maint show
9264         test-options-completion-result".
9265         (New command options, command completion): New section.
9266         (Completion improvements): New section.
9267         Mention that you can abbreviate "unlimited".
9268
9269 2019-06-13  Pedro Alves  <palves@redhat.com>
9270
9271         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9272         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9273         * unittests/cli-utils-selftests.c (test_parse_flags)
9274         (test_parse_flags_qcs): Delete.
9275         (test_cli_utils): Don't call deleted functions.
9276
9277 2019-06-13  Pedro Alves  <palves@redhat.com>
9278
9279         * thread.c: Include "cli/cli-option.h".
9280         (tp_array_compar_ascending): Global.
9281         (tp_array_compar): Delete function.
9282         (tp_array_compar_ascending, tp_array_compar_descending): New
9283         functions.
9284         (ascending_option_def, qcs_flag_option_def)
9285         (thr_qcs_flags_option_defs)
9286         (make_thread_apply_all_options_def_group)
9287         (make_thread_apply_options_def_group): New.
9288         (thread_apply_all_command): Use gdb::option::process_options.
9289         (thread_apply_command_completer)
9290         (thread_apply_all_command_completer): New.
9291         (thread_apply_command): Use gdb::option::process_options.
9292         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9293         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
9294         to generate help text of "thread apply".  Adjust "taas"'s help.
9295         * tid-parse.c (tid_range_parser::in_thread_range): New method.
9296         * tid-parse.h (tid_range_parser::in_thread_range): New method.
9297
9298 2019-06-13  Pedro Alves  <palves@redhat.com>
9299
9300         * thread.c (thread_apply_command): Check for invalid TID with
9301         isdigit instead of !isalpha.
9302
9303 2019-06-13  Pedro Alves  <palves@redhat.com>
9304
9305         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9306         (validate_flags_qcs): New.
9307         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9308         (validate_flags_qcs): Declare.
9309         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9310         (make_frame_apply_options_def_group): New.
9311         (frame_apply_command_count): Process options with
9312         gdb::option::process_options.
9313         (frame_apply_completer): New.
9314         (frame_apply_level_completer, frame_apply_all_completer)
9315         (frame_apply_completer): New.
9316         (_initialize_stack): Update help of "frame apply", "frame apply
9317         level", "frame apply all" and "faas" to mention supported options
9318         and install command completers.
9319         * stack.h (frame_apply_all_completer): Declare.
9320         * thread.c: Include "stack.h".
9321         (tfaas_command): Add "--".
9322         (_initialize_thread): Update help "tfaas" to mention supported
9323         options and install command completer.
9324
9325 2019-06-13  Pedro Alves  <palves@redhat.com>
9326
9327         * completer.c (complete_nested_command_line): New.
9328         (gdb_completion_word_break_characters_throw): Add assertion.
9329         * completer.h (complete_nested_command_line): Declare.
9330
9331 2019-06-13  Pedro Alves  <palves@redhat.com>
9332
9333         * stack.c (parse_backtrace_qualifiers): New.
9334         (backtrace_command): Use it.
9335         (backtrace_command_completer): Complete on qualifiers.
9336
9337 2019-06-13  Pedro Alves  <palves@redhat.com>
9338
9339         * frame.c: Include "cli/cli-option.h.
9340         (user_set_backtrace_options): New.
9341         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9342         Delete.
9343         (get_prev_frame): Adjust.
9344         (boolean_option_def, uinteger_option_def)
9345         (set_backtrace_option_defs): New.
9346         (_initialize_frame): Adjust and use
9347         gdb::option::add_setshow_cmds_for_options to install "set
9348         backtrace past-main" and "set backtrace past-entry".
9349         * frame.h: Include "cli/cli-option.h".
9350         (struct frame_print_options): Forward declare.
9351         (print_frame_arguments_all, print_frame_arguments_scalars)
9352         (print_frame_arguments_none): Declare.
9353         (print_entry_values): Delete declaration.
9354         (struct frame_print_options, user_frame_print_options): New.
9355         (struct set_backtrace_options): New.
9356         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9357         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9358         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9359         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9360         (list_args_or_locals): Add frame_print_options parameter.
9361         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9362         * python/py-framefilter.c (enumerate_args): Pass down
9363         USER_FRAME_PRINT_OPTIONS.
9364         * stack.c: Include "cli/cli-option.h".
9365         (print_frame_arguments_all, print_frame_arguments_scalars)
9366         (print_frame_arguments_none): Declare.
9367         (print_raw_frame_arguments, print_entry_values): Delete.
9368         (user_frame_print_options): New.
9369         (boolean_option_def, enum_option_def, frame_print_option_defs):
9370         New.
9371         (struct backtrace_cmd_options): New.
9372         (bt_flag_option_def): New.
9373         (backtrace_command_option_defs): New.
9374         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9375         (print_frame_arg, read_frame_arg, print_frame_args)
9376         (print_frame_info, print_frame): Add frame_print_options parameter
9377         and use it.
9378         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9379         (backtrace_command_1): Add frame_print_options and
9380         backtrace_cmd_options parameters and use them.
9381         (make_backtrace_options_def_group): New.
9382         (backtrace_command): Process command options with
9383         gdb::option::process_options.
9384         (backtrace_command_completer): New.
9385         (_initialize_stack): Extend "backtrace"'s help to mention
9386         supported options.  Install completer for "backtrace".
9387         Install some settings commands with add_setshow_cmds_for_options.
9388
9389 2019-06-13  Pedro Alves  <palves@redhat.com>
9390
9391         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9392         and that "set/show print raw frame-arguments" are now deprecated.
9393
9394         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9395         command.
9396         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9397         * stack.c (_initialize_stack): Install "set/show print
9398         raw-frame-arguments", and deprecate "set/show print raw
9399         frame-arguments".
9400         * valprint.c (_initialize_valprint): Deprecate "set/show print
9401         raw".
9402
9403 2019-06-13  Pedro Alves  <palves@redhat.com>
9404
9405         * compile/compile.c (struct compile_options): New.
9406         (compile_flag_option_def, compile_command_option_defs)
9407         (make_compile_options_def_group): New.
9408         (compile_file_command): Handle options with
9409         gdb::option::process_options.
9410         (compile_file_command_completer): New function.
9411         (compile_code_command): Handle options with
9412         gdb::option::process_options.
9413         (compile_code_command_completer): New function.
9414         (_initialize_compiler): Install completers for "compile code" and
9415         "compile file".  Mention available options in "compile code" and
9416         "compile code"'s help.
9417         * completer.c (advance_to_completion_word): New, factored out from
9418         ...
9419         (advance_to_expression_complete_word_point): ... this.
9420         (advance_to_filename_complete_word_point): New.
9421         * completer.h (advance_to_filename_complete_word_point): New
9422         declaration.
9423
9424 2019-06-13  Pedro Alves  <palves@redhat.com>
9425
9426         * compile/compile.c: Include "cli/cli-option.h".
9427         (compile_print_value): Scope data pointer is now a
9428         value_print_options pointer; adjust.
9429         (compile_print_command): Process options.  Scope data pointer is
9430         now a value_print_options pointer; adjust.
9431         (_initialize_compile): Update "compile print"'s help to include
9432         supported options.  Install a completer for "compile print".
9433         * cp-valprint.c (show_vtblprint, show_objectprint)
9434         (show_static_field_print): Delete.
9435         (_initialize_cp_valprint): Don't install "set print
9436         static-members", "set print vtbl", "set print object" here.
9437         * printcmd.c: Include "cli/cli-option.h" and
9438         "common/gdb_optional.h".
9439         (print_command_parse_format): Rework to fill in a
9440         value_print_options instead of a format_data.
9441         (print_value): Change parameter type from format_data pointer to
9442         value_print_options reference.  Adjust.
9443         (print_command_1): Process options.  Adjust to pass down a
9444         value_print_options.
9445         (print_command_completer): New.
9446         (_initialize_printcmd): Install print_command_completer as
9447         handle_brkchars completer for the "print" command.  Update
9448         "print"'s help to include supported options.
9449         * valprint.c: Include "cli/cli-option.h".
9450         (show_vtblprint, show_objectprint, show_static_field_print): Moved
9451         here from cp-valprint.c.
9452         (boolean_option_def, uinteger_option_def)
9453         (value_print_option_defs, make_value_print_options_def_group):
9454         New.  Use gdb::option::add_setshow_cmds_for_options to install
9455         "set print elements", "set print null-stop", "set print repeats",
9456         "set print pretty", "set print union", "set print array", "set
9457         print address", "set print symbol", "set print array-indexes".
9458         * valprint.h: Include <string> and "cli/cli-option.h".
9459         (make_value_print_options_def_group): Declare.
9460         (print_value): Change parameter type from format_data pointer to
9461         value_print_options reference.
9462         (print_command_completer): Declare.
9463
9464 2019-06-13  Pedro Alves  <palves@redhat.com>
9465
9466         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9467         (COMMON_SFILES): Add maint-test-settings.c.
9468         * cli/cli-decode.c (boolean_enums): New global, factored out from
9469         ...
9470         (add_setshow_boolean_cmd): ... here.
9471         * cli/cli-decode.h (boolean_enums): Declare.
9472         * cli/cli-option.c: New file.
9473         * cli/cli-option.h: New file.
9474         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9475         factored out from ...
9476         (parse_cli_boolean_value(const char *)): ... this.
9477         (is_unlimited_literal): Change parameter type to pointer to
9478         pointer.  Adjust and advance ARG pointer.
9479         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9480         (parse_cli_var_enum): New, factored out from ...
9481         (do_set_command): ... this.  Adjust.
9482         * cli/cli-setshow.h (parse_cli_boolean_value)
9483         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9484         (parse_cli_var_enum): Declare.
9485         * cli/cli-utils.c: Include "cli/cli-option.h".
9486         (get_ulongest): New.
9487         * cli/cli-utils.h (get_ulongest): Declare.
9488         (check_for_argument): New overloads.
9489         * maint-test-options.c: New file.
9490
9491 2019-06-13  Pedro Alves  <palves@redhat.com>
9492
9493         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9494         parse a range if "-" is at the end of the string.
9495
9496 2019-06-13  Pedro Alves  <palves@redhat.com>
9497
9498         * cli/cli-setshow.c (parse_auto_binary_operation)
9499         (parse_cli_boolean_value): Don't allow "o".
9500
9501 2019-06-13  Pedro Alves  <palves@redhat.com>
9502
9503         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9504         * NEWS: Mention maint test-settings KIND.
9505         * maint-test-settings.c: New file.
9506
9507 2019-06-13  Pedro Alves  <palves@redhat.com>
9508
9509         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9510         completer.
9511         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9512         "set" completers.
9513
9514 2019-06-13  Pedro Alves  <palves@redhat.com>
9515
9516         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9517         after item.
9518
9519 2019-06-13  Pedro Alves  <palves@redhat.com>
9520
9521         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9522
9523 2019-06-13  Pedro Alves <palves@redhat.com>
9524
9525         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9526         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9527         call.
9528         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9529         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9530         calls.
9531         (check_for_argument): Skip spaces after argument.
9532
9533 2019-06-13  Pedro Alves  <palves@redhat.com>
9534
9535         * thread.c (thread_apply_command): Adjust TID parsing.
9536         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9537         detected before end of string.
9538         (tid_is_in_list): Error out if LIST is invalid.
9539
9540 2019-06-13  Pedro Alves  <palves@redhat.com>
9541
9542         * completer.c (complete_line_internal_1): Rewind completion word
9543         point.
9544         (completion_tracker::advance_custom_word_point_by): Change
9545         parameter type to int.
9546         * completer.h (completion_tracker::advance_custom_word_point_by):
9547         Likewise.
9548
9549 2019-06-13  Pedro Alves  <palves@redhat.com>
9550
9551         * completer.c (advance_to_completion_word): Handle delimiters.
9552
9553 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
9554
9555         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9556
9557 2019-06-11  Tom Tromey  <tom@tromey.com>
9558
9559         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9560         (xmalloc_failed): Move to alloc.c.
9561         * alloc.c: New file.
9562         * Makefile.in (COMMON_SFILES): Add alloc.c.
9563
9564 2019-06-11  Tom Tromey  <tom@tromey.com>
9565
9566         * nat/linux-waitpid.c: Don't include server.h.
9567         (linux_debug): Remove.
9568         (my_waitpid): Update.
9569
9570 2019-06-11  Tom Tromey  <tromey@adacore.com>
9571
9572         * infcall.c (_initialize_infcall): Remove trailing newline from
9573         help.
9574         * user-regs.c (_initialize_user_regs): Remove trailing newline
9575         from help.
9576         * typeprint.c (_initialize_typeprint): Remove trailing newline
9577         from help.
9578         * reverse.c (_initialize_reverse): Remove trailing newlines from
9579         help.
9580         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9581         from help.
9582         * language.c (add_set_language_command): Remove trailing newline
9583         from help.
9584         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9585         help.
9586         * disasm.c (_initialize_disasm): Remove trailing newline from
9587         help.
9588         * top.c (init_main): Remove trailing newline from help.
9589         * interps.c (_initialize_interpreter): Remove trailing newline
9590         from help.
9591         * btrace.c (_initialize_btrace): Remove trailing newlines from
9592         help.
9593         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9594         from help.
9595         * python/python.c (_initialize_python): Remove trailing newline
9596         from help.
9597         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9598         help.
9599         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9600         from help.  Reformat some text.
9601         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9602         from help.
9603         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9604         newline from help.
9605
9606 2019-06-11  Tom Tromey  <tromey@adacore.com>
9607
9608         * darwin-nat.c (darwin_decode_exception_message)
9609         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9610
9611 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9612
9613         * valops.c (value_slice): Check for not allocated or not
9614         associated values.
9615
9616 2019-06-10  Tom de Vries  <tdevries@suse.de>
9617
9618         PR gdb/24618
9619         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9620         sure an empty slot (defined by a 32-bit zero pair) is recognized as
9621         invalid.
9622
9623 2019-06-10  Tom de Vries  <tdevries@suse.de>
9624
9625         PR gdb/24611
9626         * linespec.c (linespec_lexer_lex_string): Remove incorrect
9627         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
9628
9629 2019-06-10  Tom de Vries  <tdevries@suse.de>
9630
9631         PR symtab/24545
9632         * symtab.c (struct demangled_name_entry): Add language field.
9633         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
9634         static minimal symbol".  Set and use language field.
9635
9636 2019-06-10  Tom Tromey  <tromey@adacore.com>
9637
9638         * ada-lang.c (_initialize_ada_language): Update help text.
9639
9640 2019-06-10  Tom Tromey  <tromey@adacore.com>
9641
9642         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9643         with a newline.
9644         * guile/guile.c (handle_boot_error): Don't end warning with a
9645         newline.
9646         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9647         warning with a newline.
9648         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9649         newline.
9650         (s12z_frame_cache): Likewise.
9651         * dwarf-index-cache.c (index_cache::store): Don't end warning with
9652         a newline.
9653         * solib-svr4.c (disable_probes_interface): Don't end warning with
9654         a newline.
9655         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9656         newline.
9657         * python/python.c (do_finish_initialization): Don't end warning
9658         with a newline.
9659
9660 2019-06-10  Tom Tromey  <tom@tromey.com>
9661
9662         * python/py-breakpoint.c (gdbpy_breakpoint_created)
9663         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9664         gdbpy_enter.
9665
9666 2019-06-10  Tom Tromey  <tromey@adacore.com>
9667
9668         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9669         data.
9670         (elf_new_init): Don't call stabsread_new_init.
9671         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9672         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
9673         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9674
9675 2019-06-10  Tom de Vries  <tdevries@suse.de>
9676
9677         PR symtab/16264
9678         PR symtab/24517
9679         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9680
9681 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
9682
9683         * source.c (find_and_open_source): Also rewrite relative file
9684         names.
9685
9686 2019-04-26  Amos Bird  <amosbird@gmail.com>
9687
9688         * annotate.c (annotate_thread_exited): Add "thread-exited"
9689         annotation.
9690
9691 2019-06-06  Tom Tromey  <tromey@adacore.com>
9692
9693         * maint.h (class scoped_command_stats): Use
9694         DISABLE_COPY_AND_ASSIGN.
9695         <print_time>: New method.
9696         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9697         print_time.
9698         (scoped_command_stats::print_time): New method.
9699
9700 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
9701
9702         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9703         instructions of lengths 6 or 8 bytes.
9704
9705 2019-06-04  Pedro Alves  <palves@redhat.com>
9706
9707         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9708
9709         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9710         * breakpoint.c (condition_completer): Likewise.
9711         * cli/cli-dump.c (scan_expression): Likewise.
9712         * common/filestuff.c (mkdir_recursive): Likewise.
9713         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9714         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9715         (gdb_abspath): Likewise.
9716         * compile/compile-cplus-types.c
9717         (compile_cplus_instance::decl_name): Likewise.
9718         * completer.c (complete_explicit_location):
9719         (signal_completer, reg_or_group_completer_1): Likewise.
9720         * cp-support.c (cp_remove_params_if_any): Likewise.
9721         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9722         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9723         * infcmd.c (strip_bg_char): Likewise.
9724         * linespec.c (copy_token_string): Likewise.
9725         * mi/mi-main.c (output_cores): Likewise.
9726         * psymtab.c (psymtab_search_name):
9727         * symfile.c (test_set_ext_lang_command): Likewise.
9728         * target.c (target_fileio_read_stralloc): Likewise.
9729         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9730         * value.c (complete_internalvar): Likewise.
9731
9732 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
9733
9734         Add objfile property to gdb.Type.
9735         * NEWS: Mention Python API addition.
9736         * python/py-type.c (typy_get_objfile): New method.
9737
9738 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9739
9740         * NEWS: Mention the new set|show style [title|highlight].
9741         Mention changes to "show style", "help" and "apropos".
9742
9743 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9744
9745         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9746         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
9747         instead of print_help_for_command.
9748         (print_doc_of_command): New function.
9749         (help_list): Add 'apropos -v word' suggestion.
9750         (print_help_for_command): Style the command name using title style.
9751         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9752         (_initialize_cli_cmds): Describe -v in apropos_command help.
9753
9754 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9755
9756         * cli/cli-style.h (cli_style_option): Add name in constructor,
9757         add m_name class member, add constructor with intensity,
9758         add name class function.
9759         (cli_style_option::add_setshow_commands): Remove name argument.
9760         (highlight_style, title_style): New styles.
9761         * cli/cli-style.c (do_show): New function that shows a style
9762         characteristic styling the style name with itself.
9763         (set_style_name): New function.
9764         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9765         Update all callers according to the changes in cli/cli-style.h.
9766         * utils.h (fputs_highlighted): New function.
9767         * utils.c (fputs_highlighted): Likewise.
9768
9769 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9770
9771         * NEWS: Mention new pipe command and new convenience variables.
9772
9773 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9774
9775         * cli/cli-cmds.c (pipe_command): New function.
9776         (_initialize_cli_cmds): Call add_com for pipe_command.
9777         Define | as an alias for pipe.
9778         (exit_status_set_internal_vars): New function.
9779         (shell_escape): Call exit_status_set_internal_vars.
9780         cli/cli-decode.c (find_command_name_length): Recognize | as
9781         a single character command.
9782
9783 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9784
9785         * gdbcmd.h (execute_command_to_ui_file): New declaration.
9786         top.c (execute_command_to_ui_file): New function, mostly a copy
9787         of execute_command_to_string.
9788         (execute_command_to_string): Implement by calling
9789         execute_command_to_ui_file.
9790
9791 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9792
9793         * top.h (saved_command_line): Remove declaration.
9794         * top.c (previous_saved_command_line, previous_repeat_arguments):
9795         New variables.
9796         (saved_command_line): Make static, define together with other
9797         'repeat variables'.
9798         (dont_repeat): Clear repeat_arguments.
9799         (repeat_previous, get_saved_command_line, save_command_line):
9800         New functions.
9801         (gdb_init): Initialize saved_command_line
9802         and previous_saved_command_line.
9803         * main.c (captured_main_1): Remove saved_command_line initialization.
9804         * event-top.c (handle_line_of_input): Update to use
9805         the new 'repeat' related functions instead of direct access to
9806         saved_command_line.
9807         * command.h (repeat_previous, get_saved_command_line,
9808         save_command_line): New declarations.
9809         (dont_repeat): Add comment.
9810
9811 2019-05-30  Tom Tromey  <tromey@adacore.com>
9812
9813         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9814         Fix comment.
9815         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9816
9817 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
9818
9819         PR cli/24587
9820         * completer.c (complete): Initialize variable word.
9821
9822 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
9823
9824         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9825         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9826         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9827         'body' is NULL to the outter 'if', protecting the '!is_define'
9828         situation as well.
9829
9830 2019-05-29  Tom Tromey  <tromey@adacore.com>
9831
9832         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9833         (dwarf_unknown): New function.
9834         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9835         (dwarf_type_encoding_name): Use dwarf_unknown.
9836
9837 2019-05-29  Tom Tromey  <tromey@adacore.com>
9838
9839         PR c++/20020:
9840         * cp-valprint.c (cp_print_value_fields): Call
9841         cp_print_static_field inside "try".
9842
9843 2019-05-29  Tom Tromey  <tromey@adacore.com>
9844
9845         * inflow.c (struct terminal_info): Add default operator=.
9846         * configure: Rebuild.
9847         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9848         -Wdeprecated-copy-dtor, -Wredundant-move.
9849
9850 2019-05-29  Tom Tromey  <tromey@adacore.com>
9851
9852         * NEWS: Add entry.
9853         * infcmd.c (print_return_value_1): Handle finish_print
9854         option.
9855         (show_print_finish): New function.
9856         (_initialize_infcmd): Add "set/show print finish" commands.
9857         * valprint.c (user_print_options): Initialize new member.
9858         * valprint.h (struct value_print_options) <finish_print>: New
9859         member.
9860
9861 2019-05-28  Tom Tromey  <tromey@adacore.com>
9862
9863         * ada-lang.c (ada_remove_Xbn_suffix)
9864         (find_old_style_renaming_symbol)
9865         (parse_old_style_renaming): Remove.
9866         (ada_find_renaming_symbol): Don't call
9867         find_old_style_renaming_symbol.
9868         (ada_is_renaming_symbol): Rename from
9869         ada_find_renaming_symbol.  Remove "block" parameter.  Return
9870         bool.  Now static.
9871         (ada_read_var_value): Update and simplify.
9872         * ada-exp.y (write_var_or_type): Remove old code.
9873
9874 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
9875
9876         PR gdb/25010
9877         * event-top.c: Remove include comment.
9878         * inflow.c (class scoped_ignore_sigttou): Move from here...
9879         * inflow.h (class scoped_ignore_sigttou): ...to here.
9880         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9881         * top.c:  Remove include comment.
9882
9883 2019-05-27  Tom Tromey  <tom@tromey.com>
9884
9885         * NEWS: Fix typo.
9886
9887 2019-05-22  Tom Tromey  <tromey@adacore.com>
9888
9889         * target.c (target_follow_exec): Constify parameter.
9890         * target-delegates.c: Rebuild.
9891         * remote.c (remote_target::follow_exec): Constify parameter.
9892         * infrun.c (follow_exec): Constify parameter.
9893         * target.h (struct target_ops) <follow_exec>: Constify parameter.
9894         (target_follow_exec): Likewise.
9895
9896 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9897
9898         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9899         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9900
9901 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9902
9903         * NEWS: Add debugredirect and testsuite sections.
9904
9905 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
9906
9907         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9908         target descriptions using exclusively floating point register name
9909         aliases.
9910
9911 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
9912
9913         PR gdb/18644:
9914         * f-lang.c (build_fortran_types): Handle the case where
9915         gdbarch_floatformat_for_type returns a nullptr.
9916
9917 2019-05-21  Tom de Vries  <tdevries@suse.de>
9918
9919         PR cli/24587
9920         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9921
9922 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9923
9924         PR gdb/18644:
9925         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9926         16-byte floats.
9927         * i386-tdep.c (i386_floatformat_for_type): Use
9928         floatformats_ia64_quad for the 16-byte floating point component
9929         within a fortran 32-byte complex number.
9930
9931 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9932
9933         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9934         delete default constructor.
9935         (find_partial_die): Update to return const struct.
9936         (partial_die_parent_scope): Move variable declaration into scope
9937         of its use and change its type to auto.
9938         (guess_partial_die_structure_name): Likewise.
9939         (partial_die_info::fixup): Likewise.
9940
9941 2019-05-17  Tom Tromey  <tromey@adacore.com>
9942
9943         * source.c (find_and_open_source): Remove cast.
9944
9945 2019-05-17  Tom Tromey  <tromey@adacore.com>
9946
9947         * annotate.c (annotate_source): Make "filename" const.
9948         * annotate.h (annotate_source): Use const.
9949
9950 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9951
9952         * disasm.c (set_disassembler_options): Send errors to stderr.
9953
9954 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9955
9956         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9957         (cli_interp_base::set_logging): Check debug_redirect.
9958         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9959         * cli/cli-logging.c (debug_redirect): Add static variable.
9960         (pop_output_files): Add default param.
9961         (handle_redirections): Print debug setting.
9962         (show_logging_command): Likewise.
9963         (_initialize_cli_logging): Add debugredirect command.
9964         * interps.c (current_interp_set_logging): Add debug_redirect
9965         parameter.
9966         * interps.h (set_logging): Add debug_redirect parameter.
9967         (current_interp_set_logging): Likewise.
9968         * mi/mi-common.h: Likewise.
9969         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9970
9971 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9972             Tom Tromey  <tromey@adacore.com>
9973
9974         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9975         directly.
9976         * cli/cli-interp.h (make_logging_output): Remove declaration.
9977         * cli/cli-logging.c (make_logging_output): Remove function.
9978         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9979         directly.
9980         * ui-file.c (tee_file::tee_file): Remove bools.
9981         (tee_file::~tee_file): Remove deletes.
9982         * ui-file.h (tee_file): Remove bools.
9983
9984 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
9985
9986         * mi/mi-cmds.h (mi_cmd_complete): New function.
9987         * mi/mi-main.c (mi_cmd_complete): Likewise.
9988         * mi/mi-cmds.c: Define new MI command -complete.
9989         * NEWS: Mention new -complete command.
9990
9991 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
9992
9993         * completer.h (complete): New function.
9994         * completer.c (complete): Likewise.
9995         * cli/cli-cmds.c: (complete_command): Update to use new complete()
9996         function defined in completer.h.
9997
9998 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
9999
10000         * MAINTAINERS (Write After Approval): Add myself.
10001
10002 2019-05-17  Tom de Vries  <tdevries@suse.de>
10003
10004         PR gdb/24094
10005         * dwarf2read.c (struct cu_partial_die_info): New struct.
10006         (find_partial_die): Return cu_partial_die_info.
10007         (partial_die_parent_scope, guess_partial_die_structure_name)
10008         (partial_die_info::fixup): Handle new return type of find_partial_die.
10009
10010 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10011
10012         PR breakpoints/24541
10013         * stap-probe.c (stap_parse_register_operand): Make "regname" an
10014         "std::string", simplifying the algorithm.
10015
10016 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10017
10018         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10019         (stap_static_probe_ops::get_probes): Likewise.
10020
10021 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10022
10023         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10024         '-')" and "else if".
10025         (stap_parse_single_operand): Join checks for
10026         "gdbarch_stap_parse_special_token_p" and
10027         "gdbarch_stap_parse_special_token" in the same "if" statement.
10028         Invert check when verifying for operation on register
10029         displacement.
10030
10031 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10032
10033         * stap-probe.c (stap_get_opcode): Update comment.
10034         (stap_get_expected_argument_type): Likewise.
10035         (handle_stap_probe): Likewise.
10036
10037 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10038
10039         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10040         return type to 'bool'.  Adjust comment.  Use 'bool' when
10041         appropriate.
10042         (i386_stap_parse_special_token_three_arg_disp): Likewise.
10043         * stap-probe.c (stap_parse_argument_1): Likewise.
10044         (stap_is_operator): Likewise.
10045         (stap_is_generic_prefix): Likewise.
10046         (stap_is_register_prefix): Likewise.
10047         (stap_is_register_indirection_prefix): Likewise.
10048         (stap_is_integer_prefix): Likewise.
10049         (stap_generic_check_suffix): Likewise.
10050         (stap_check_integer_suffix): Likewise.
10051         (stap_check_register_suffix): Likewise.
10052         (stap_check_register_indirection_suffix): Likewise.
10053         (stap_parse_register_operand): Likewise.
10054         (stap_parse_single_operand): Likewise.
10055         (stap_parse_argument_1): Likewise.
10056         (stap_probe::get_argument_count): Likewise.
10057         (stap_is_operator): Likewise.
10058
10059 2019-05-16  Tom Tromey  <tromey@adacore.com>
10060
10061         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10062         keyword to foreach.
10063
10064 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
10065
10066         * linux-thread-db.c (try_thread_db_load_1): Change return type
10067         to bool.
10068         (try_thread_db_load): Likewise.
10069         (try_thread_db_load_from_pdir_1): Likewise.
10070         (try_thread_db_load_from_pdir): Likewise.
10071         (try_thread_db_load_from_sdir): Likewise.
10072         (try_thread_db_load_from_dir): Likewise.
10073         (thread_db_load_search): Likewise.
10074         (has_libpthread): Likewise.
10075         (thread_db_load): Likewise.
10076
10077 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
10078
10079         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10080         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10081         NULL, and complain/return if that's the case.
10082
10083 2019-05-15  John Darrington <john@darrington.wattle.id.au>
10084
10085         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10086         (advance, posn, abstract_read_memory): New functions.
10087         [struct mem_read_abstraction]: New struct.
10088         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10089
10090 2019-05-14  Tom Tromey  <tromey@adacore.com>
10091
10092         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10093         value is not lval_memory.
10094
10095 2019-05-14  Tom Tromey  <tromey@adacore.com>
10096
10097         * solib.c (info_sharedlibrary_command): Style the file name.
10098
10099 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
10100
10101         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10102         (aarch64_vnv_type): Likewise.
10103         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10104         * common/tdesc.c: Likewise.
10105         * common/tdesc.h (enum tdesc_type_kind): Likewise.
10106         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10107         * features/aarch64-fpu.xml: Add ieee half view.
10108         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10109         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10110         * gdbtypes.h (struct builtin_type): Likewise.
10111         (struct objfile_type): Likewise.
10112
10113 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
10114
10115         * language.c (language_sniff_from_mangled_name): Fix "langauge"
10116         typo.
10117         * location.h (string_to_event_location): Likewise.
10118
10119 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
10120
10121         GDB 8.3 released.
10122
10123 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10124
10125         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10126         New variable declaration.
10127         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10128         New variable.
10129         (print_one_breakpoint): Use ui_out::test_flags and new global
10130         variable to compute use_fixed_output.
10131         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10132         Remove.
10133         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10134         (mi_multi_location_breakpoint_output_fixed): Remove.
10135         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10136         new variable.
10137         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10138         fix_multi_location_breakpoint_output flag if version >= 3.
10139         * ui-out.h (enum ui_out_flag)
10140         <fix_multi_location_breakpoint_output>: New enumerator.
10141
10142 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10143
10144         * contrib/cc-with-tweaks.sh: Validate dwz's work.
10145
10146 2019-05-10  Tom Tromey  <tromey@adacore.com>
10147
10148         * ada-lang.c (catch_ada_completer): New function.
10149         (_initialize_ada_language): Use it.
10150
10151 2019-05-10  Tom Tromey  <tromey@adacore.com>
10152
10153         * thread.c (print_thread_info): Make "requested_threads" const.
10154         * gdbthread.h (print_thread_info): Make "requested_threads"
10155         const.
10156         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10157         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10158
10159 2019-05-08  Tom Tromey  <tom@tromey.com>
10160
10161         * gdbtypes.c (objfile_type_data): Change type.
10162         (objfile_type, _initialize_gdbtypes): Update.
10163
10164 2019-05-08  Tom Tromey  <tom@tromey.com>
10165
10166         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10167         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10168         (_initialize_dwarf2_frame): Update.
10169
10170 2019-05-08  Tom Tromey  <tom@tromey.com>
10171
10172         * objc-lang.c (objc_objfile_data): Change type.
10173         (find_methods): Update.
10174         (_initialize_objc_lang): Remove.
10175
10176 2019-05-08  Tom Tromey  <tom@tromey.com>
10177
10178         * stabsread.c (rs6000_builtin_type_data): Change type.
10179         (rs6000_builtin_type, _initialize_stabsread): Update.
10180
10181 2019-05-08  Tom Tromey  <tom@tromey.com>
10182
10183         * mips-tdep.c (mips_pdr_data): Remove.
10184         (_initialize_mips_tdep): Update.
10185
10186 2019-05-08  Tom Tromey  <tom@tromey.com>
10187
10188         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10189         (hppa_init_objfile_priv_data, read_unwind_info)
10190         (find_unwind_entry, _initialize_hppa_tdep): Update.
10191
10192 2019-05-08  Tom Tromey  <tom@tromey.com>
10193
10194         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10195         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
10196         on obstack.
10197         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10198
10199 2019-05-08  Tom Tromey  <tom@tromey.com>
10200
10201         * mdebugread.c (basic_type_data): Change type.
10202         (basic_type, _initialize_mdebugread): Update.
10203
10204 2019-05-08  Tom Tromey  <tom@tromey.com>
10205
10206         * common/gdb_unique_ptr.h (struct noop_deleter): New.
10207
10208 2019-05-08  Tom Tromey  <tom@tromey.com>
10209
10210         * nto-tdep.c (nto_inferior_data_reg): Change type.
10211         (nto_inferior_data): Update.
10212         (nto_inferior_data_cleanup, nto_new_inferior_data)
10213         (_initialize_nto_tdep): Remove.
10214         * nto-tdep.h (struct nto_inferior_data): Add initializers.
10215
10216 2019-05-08  Tom Tromey  <tom@tromey.com>
10217
10218         * ada-lang.c (struct ada_inferior_data): Add initializers.
10219         (ada_inferior_data): Change type.
10220         (ada_inferior_data_cleanup): Remove.
10221         (get_ada_inferior_data, ada_inferior_exit)
10222         (struct ada_pspace_data): Add initializers, destructor.
10223         (ada_pspace_data_handle): Change type.
10224         (get_ada_pspace_data): Update.
10225         (ada_pspace_data_cleanup): Remove.
10226
10227 2019-05-08  Tom Tromey  <tom@tromey.com>
10228
10229         * coffread.c (struct coff_symfile_info): Add initializers.
10230         (coff_objfile_data_key): Move lower.  Change type.
10231         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10232         Update.
10233         (coff_free_info): Remove.
10234
10235 2019-05-08  Tom Tromey  <tom@tromey.com>
10236
10237         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10238         (fbsd_pspace_data_handle): Move lower.  Change type.
10239         (get_fbsd_pspace_data): Update.
10240         (fbsd_pspace_data_cleanup): Remove.
10241         (_initialize_fbsd_tdep): Update.
10242
10243 2019-05-08  Tom Tromey  <tom@tromey.com>
10244
10245         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10246         (get_ada_tasks_pspace_data): Update.
10247         (ada_tasks_pspace_data_cleanup): Remove.
10248         (_initialize_tasks): Update.
10249         (ada_tasks_inferior_data_handle): Change type.
10250         (get_ada_tasks_inferior_data): Update.
10251         (ada_tasks_inferior_data_cleanup): Remove.
10252         (struct ada_tasks_pspace_data): Add initializers.
10253
10254 2019-05-08  Tom Tromey  <tom@tromey.com>
10255
10256         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10257         * symfile-debug.c (debug_sym_get_probes): Change type.
10258         * stap-probe.c (handle_stap_probe):
10259         (stap_static_probe_ops::get_probes): Change type.
10260         * probe.h (class static_probe_ops) <get_probes>: Change type.
10261         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10262         (parse_probes_in_pspace): Update.
10263         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10264         Update.
10265         (any_static_probe_ops::get_probes): Change type.
10266         * elfread.c (elfread_data): New typedef.
10267         (probe_key): Change type.
10268         (elf_get_probes): Likewise.  Update.
10269         (probe_key_free): Remove.
10270         (_initialize_elfread): Update.
10271         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10272         Change type.
10273         (dtrace_process_dof_probe, dtrace_process_dof)
10274         (dtrace_static_probe_ops::get_probe): Change type.
10275
10276 2019-05-08  Tom Tromey  <tom@tromey.com>
10277
10278         * xcoffread.c (struct xcoff_symfile_info): Rename from
10279         coff_symfile_info.  Add initializers.
10280         (xcoff_objfile_data_key): Move lower.  Change type.
10281         (XCOFF_DATA): Rewrite.
10282         (xcoff_free_info): Remove.
10283         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10284         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10285         (xcoff_initial_scan): Update.
10286
10287 2019-05-08  Tom Tromey  <tom@tromey.com>
10288
10289         * solib-svr4.c (struct svr4_info): Add initializers and
10290         destructor.
10291         <probes_table>: Now an htab_up.
10292         (solib_svr4_pspace_data): Change type.
10293         (free_probes_table): Simplify.
10294         (~svr4_info): Rename from svr4_pspace_data_cleanup.
10295         (get_svr4_info, probes_table_htab_remove_objfile_probes)
10296         (probes_table_remove_objfile_probes, register_solib_event_probe)
10297         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10298         (_initialize_svr4_solib): Update.
10299
10300 2019-05-08  Tom Tromey  <tom@tromey.com>
10301
10302         * remote.c (remote_pspace_data): Change type.
10303         (remote_pspace_data_cleanup): Remove.
10304         (get_remote_exec_file, set_pspace_remote_exec_file)
10305         (_initialize_remote): Update.
10306
10307 2019-05-08  Tom Tromey  <tom@tromey.com>
10308
10309         * breakpoint.c (breakpoint_objfile_key): Change type.
10310         (get_breakpoint_objfile_data): Update.
10311         (free_breakpoint_objfile_data): Remove.
10312         (_initialize_breakpoint): Update.
10313
10314 2019-05-08  Tom Tromey  <tom@tromey.com>
10315
10316         * linux-tdep.c (struct linux_info): Add initializers.
10317         (linux_inferior_data): Move.  Change type.
10318         (invalidate_linux_cache_inf): Update.
10319         (linux_inferior_data_cleanup): Remove.
10320         (get_linux_inferior_data, _initialize_linux_tdep): Update.
10321
10322 2019-05-08  Tom Tromey  <tom@tromey.com>
10323
10324         * auxv.c (auxv_inferior_data): Move.  Change type.
10325         (auxv_inferior_data_cleanup): Remove.
10326         (invalidate_auxv_cache_inf): Rewrite.
10327         (get_auxv_inferior_data, _initialize_auxv): Update.
10328
10329 2019-05-08  Tom Tromey  <tom@tromey.com>
10330
10331         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10332         (symfile_debug_objfile_data_key): Change type.
10333         (symfile_debug_installed, debug_qf_has_symbols)
10334         (debug_qf_find_last_source_symtab)
10335         (debug_qf_forget_cached_source_info)
10336         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10337         (debug_qf_print_stats, debug_qf_dump)
10338         (debug_qf_expand_symtabs_for_function)
10339         (debug_qf_expand_all_symtabs)
10340         (debug_qf_expand_symtabs_with_fullname)
10341         (debug_qf_map_matching_symbols)
10342         (debug_qf_expand_symtabs_matching)
10343         (debug_qf_find_pc_sect_compunit_symtab)
10344         (debug_qf_map_symbol_filenames)
10345         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10346         (debug_sym_new_init, debug_sym_init, debug_sym_read)
10347         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10348         (debug_sym_read_linetable, debug_sym_relocate): Update.
10349         (symfile_debug_free_objfile): Remove.
10350         (install_symfile_debug_logging, _initialize_symfile_debug):
10351         Update.
10352
10353 2019-05-08  Tom Tromey  <tom@tromey.com>
10354
10355         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10356         allocate_on_obstack.
10357         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10358         (get_dwarf2_per_objfile): Update.
10359         (set_dwarf2_per_objfile): Remove.
10360         (dwarf2_has_info, dwarf2_get_section_info): Update.
10361         (dwarf2_free_objfile): Remove.
10362         (_initialize_dwarf2_read): Update.
10363
10364 2019-05-08  Tom Tromey  <tom@tromey.com>
10365
10366         * auto-load.c (struct auto_load_pspace_info): Add destructor and
10367         initializers.
10368         <unsupported_script_warning_printed,
10369         script_not_found_warning_printed>: Now bool.
10370         (auto_load_pspace_data): Change type.
10371         (~auto_load_pspace_info): Rename from
10372         auto_load_pspace_data_cleanup.
10373         (get_auto_load_pspace_data, init_loaded_scripts_info)
10374         (clear_section_scripts, maybe_print_unsupported_script_warning)
10375         (maybe_print_script_not_found_warning, _initialize_auto_load):
10376         Update.
10377
10378 2019-05-08  Tom Tromey  <tom@tromey.com>
10379
10380         * objfiles.c (objfile_pspace_info): Add destructor and
10381         initializers.
10382         (objfiles_pspace_data): Change type.
10383         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10384         (get_objfile_pspace_data): Update.
10385         (objfiles_bfd_data): Change type.
10386         (get_objfile_bfd_data): Update.
10387         (objfile_bfd_data_free, _initialize_objfiles): Remove.
10388
10389 2019-05-08  Tom Tromey  <tom@tromey.com>
10390
10391         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10392         Change type.
10393         (get_catch_syscall_inferior_data): Update.
10394         (catch_syscall_inferior_data_cleanup): Remove.
10395         (_initialize_break_catch_syscall): Update.
10396
10397 2019-05-08  Tom Tromey  <tom@tromey.com>
10398
10399         * inflow.c (struct terminal_info): Add destructor and
10400         initializers.
10401         (inflow_inferior_data): Change type.
10402         (~terminal_info): Rename from inflow_inferior_data_cleanup.
10403         (get_inflow_inferior_data, inflow_inferior_exit)
10404         (swap_terminal_info, _initialize_inflow): Update.
10405
10406 2019-05-08  Tom Tromey  <tom@tromey.com>
10407
10408         * target-dcache.c (target_dcache_cleanup): Remove.
10409         (target_dcache_aspace_key): Change type.
10410         (target_dcache_init_p, target_dcache_invalidate)
10411         (target_dcache_get, target_dcache_get_or_init)
10412         (_initialize_target_dcache): Update.
10413         * dcache.h (struct dcache_deleter): New.
10414
10415 2019-05-08  Tom Tromey  <tom@tromey.com>
10416
10417         * symtab.c (struct symbol_cache): Add destructor and
10418         initializers.
10419         (symbol_cache_key): Move.  Change type.
10420         (make_symbol_cache, free_symbol_cache): Remove.
10421         (get_symbol_cache): Update.
10422         (symbol_cache_cleanup): Remove.
10423         (ALL_PSPACES, symbol_cache_flush)
10424         (maintenance_print_symbol_cache)
10425         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10426         Update.
10427
10428 2019-05-08  Tom Tromey  <tom@tromey.com>
10429
10430         * symtab.c (struct main_info): Add destructor and initializers.
10431         (main_progspace_key): Move.  Change type.
10432         (get_main_info): Update.
10433         (main_info_cleanup): Remove.
10434         (_initialize_symtab): Update.
10435
10436 2019-05-08  Tom Tromey  <tom@tromey.com>
10437
10438         * registry.h (DECLARE_REGISTRY): Define the _key class.
10439
10440 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10441
10442         * NEWS: Merge two 'New commands' sections.
10443
10444 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
10445
10446         * ada-valprint.c (ada_val_print_gnat_array): Remove language
10447         parameter and use Ada language definition instead.
10448         (ada_val_print_ptr): Remove unused language parameter.
10449         (ada_val_print_num): Remove language parameter and use Ada language
10450         definition instead.
10451         (ada_val_print_enum, ada_val_print_flt): Remove unused language
10452         parameter.
10453         (ada_val_print_struct_union, ada_val_print_ref): Remove language
10454         parameter and use Ada language definition instead.
10455         (ada_val_print_1): Update all ada_val_print_xxx calls.
10456         Remove language parameter.
10457         (ada_val_print): Update ada_val_print_1 call.
10458
10459 2019-05-08  Tom Tromey  <tromey@adacore.com>
10460
10461         * remote.c (remote_hw_watchpoint_limit)
10462         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10463         Now static.
10464
10465 2019-05-08  Tom Tromey  <tromey@adacore.com>
10466
10467         * maint.c (_initialize_maint_cmds): Move initialization code to
10468         remote.c.
10469         (watchdog, show_watchdog): Move to remote.c.
10470         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
10471         "watchdog" static.
10472         (_initialize_remote): Move initialization code from maint.c.
10473         * defs.h (watchdog): Don't declare.
10474
10475 2019-05-08  Tom Tromey  <tromey@adacore.com>
10476
10477         * tui/tui-interp.c: Include main.h.
10478         * interps.c: Include main.h.
10479         * main.h (interpreter_p): Declare.
10480         * defs.h (interpreter_p): Don't declare.
10481
10482 2019-05-08  Tom Tromey  <tromey@adacore.com>
10483
10484         * dwarf2loc.c: Include dwarf2read.h.
10485         * defs.h (read_unsigned_leb128): Don't declare.
10486         * dwarf2read.h (read_unsigned_leb128): Declare.
10487
10488 2019-05-08  Tom Tromey  <tromey@adacore.com>
10489
10490         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10491         method.
10492
10493 2019-05-08  Tom Tromey  <tromey@adacore.com>
10494
10495         * utils.c (fputs_maybe_filtered): Reset style after paging, even
10496         when no wrap column is set.
10497
10498 2019-05-08  Tom Tromey  <tromey@adacore.com>
10499
10500         * c-lang.c (c_get_string): Handle non-C-style arrays.
10501
10502 2019-05-08  Tom Tromey  <tromey@adacore.com>
10503
10504         * typeprint.c (print_offset_data::update): Print the bit offset,
10505         not the number of bits remaining.
10506
10507 2019-05-08  Tom Tromey  <tromey@adacore.com>
10508
10509         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10510         padding at end of comment.
10511
10512 2019-05-08  Tom Tromey  <tromey@adacore.com>
10513
10514         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10515         Compare main types.
10516
10517 2019-05-06  Tom Tromey  <tom@tromey.com>
10518
10519         * common/scoped_mmap.c: Include common-defs.h.
10520         * common/scoped_mmap.h: Don't include config.h.
10521
10522 2019-05-04  Tom Tromey  <tom@tromey.com>
10523
10524         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10525         (struct aarch64_call_info): Add initializers.
10526         <si>: Now a std::vector.
10527         (pass_on_stack, aarch64_push_dummy_call): Update.
10528
10529 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
10530             Tom Tromey  <tom@tromey.com>
10531
10532         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10533         (ppc_threads): Now a std::vector.  Now static.
10534         (hwdebug_find_thread_points_by_tid)
10535         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10536         Update.
10537
10538 2019-05-04  Tom Tromey  <tom@tromey.com>
10539
10540         * arc-tdep.c (arc_tdesc_init): Return bool.
10541
10542 2019-05-04  Tom Tromey  <tom@tromey.com>
10543
10544         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10545         Use gdb_assert_not_reached.
10546
10547 2019-05-04  Tom Tromey  <tom@tromey.com>
10548
10549         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10550         "false".
10551
10552 2019-05-04  Tom Tromey  <tom@tromey.com>
10553
10554         * arc-tdep.c (arc_tdesc_init): Use bool.
10555
10556 2019-05-04  Tom Tromey  <tom@tromey.com>
10557
10558         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10559
10560 2019-05-04  Tom Tromey  <tom@tromey.com>
10561
10562         * cli/cli-cmds.c (valid_command_p): Return bool.
10563
10564 2019-05-04  Tom Tromey  <tom@tromey.com>
10565
10566         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10567         * command.h (valid_user_defined_cmd_name_p): Channge return type.
10568
10569 2019-05-04  Raul Tambre  <raul@tambre.ee>
10570
10571         * python/lib/gdb/prompt.py (_ExtendedPrompt)
10572         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10573         operator for comparison.
10574
10575 2019-05-04  Tom Tromey  <tom@tromey.com>
10576
10577         * psymtab.c (psymbol_name_matches, match_partial_symbol)
10578         (lookup_partial_symbol, print_partial_symbols)
10579         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10580         (psymbol_compare): Update.
10581         (add_psymbol_to_bcache): Clear the entire psymbol.
10582         (maintenance_check_psymtabs): Update.
10583         * psympriv.h (struct partial_symbol): Don't derive from
10584         general_symbol_info.
10585         <obj_section, unrelocated_address, address,
10586         set_unrelocated_address>: Update.
10587         <ginfo>: New member.
10588         * dwarf-index-write.c (write_psymbols, debug_names::insert)
10589         (debug_names::write_psymbols): Update.
10590
10591 2019-05-04  Tom de Vries  <tdevries@suse.de>
10592
10593         * contrib/cc-with-tweaks.sh: Support -n arg.
10594
10595 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10596
10597         * corelow.c (core_target::detach): Ensure frame cache and
10598         register caches are cleared.
10599         inferior.c (exit_inferior_1): Likewise.
10600
10601 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
10602             Tom Tromey  <tom@tromey.com>
10603
10604         * dictionary.c (collate_pending_symbols_by_language): Remove
10605         "struct" from foreach.
10606         * symtab.c (lookup_global_symbol_from_objfile)
10607         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10608         foreach.
10609         * ser-tcp.c (net_open): Remove "struct" from foreach.
10610         * objfiles.c (objfile_relocate, objfile_rebase)
10611         (objfile_has_symbols): Remove "struct" from foreach.
10612         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10613         from foreach.
10614         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10615         foreach.
10616         * darwin-nat.c (thread_info_from_private_thread_info): Remove
10617         "struct" from foreach.
10618         * ada-lang.c (create_excep_cond_exprs)
10619         (ada_exception_catchpoint_cond_string): Remove "struct" from
10620         foreach.
10621
10622 2019-05-03  Tom Tromey  <tromey@adacore.com>
10623
10624         * ada-exp.y (convert_char_literal): Check suffix of each
10625         enumerator.
10626
10627 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
10628
10629         PR ada/21406:
10630         * ada-exp.y (yywrap): Don't define.
10631         * ada-lex.l (%option): Add noyywrap
10632         (yywrap): Remove.
10633
10634 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
10635
10636         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10637         _WIN32_WINNT to the XP level, unless already defined to a higher
10638         level.
10639
10640         * unittests/parse-connection-spec-selftests.c:
10641         * ser-tcp.c:
10642         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
10643         override.
10644
10645         * symfile.c (find_separate_debug_file): Remove colon from the
10646         drive spec of DOS/Windows file names of the target, so that the
10647         file name produced from DEBUGDIR and the target's directory will
10648         be valid on DOS/Windows systems.
10649
10650 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
10651
10652         * rust-lang.c (val_print_struct): Handle printing structures
10653         containing strings.
10654
10655 2019-05-02  Tom Tromey  <tromey@adacore.com>
10656
10657         * valarith.c (_initialize_valarith): Remove.
10658
10659 2019-05-01  Tom Tromey  <tromey@adacore.com>
10660
10661         * ada-lang.c (ada_value_primitive_field): Treat more fields as
10662         bitfields.
10663
10664 2019-05-01  Tom Tromey  <tromey@adacore.com>
10665
10666         * ada-lang.c (ada_value_assign): Correctly compute starting offset
10667         for big-endian copies.
10668
10669 2019-04-30  Ali Tamur  <tamur@google.com>
10670         * gdb/dwarf2read.c (read_3_bytes): New declaration.
10671         (read_attribute_value): Added DW_FORM_strx1-4 cases.
10672         (read_3_bytes): New function.
10673
10674 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10675
10676         * windows-nat.c (main_thread_id): Delete.
10677         (handle_output_debug_string): Replace main_thread_id by
10678         current_event.dwThreadId.
10679         (fake_create_process): Likewise.
10680         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10681         Do not set main_thread_id.
10682         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10683         current_event.dwThreadId.
10684         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10685
10686 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10687
10688         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10689         Use current_event.dwThreadId instead of main_thread_id.
10690
10691 2019-04-30  Tom Tromey  <tromey@adacore.com>
10692
10693         * ada-lang.c (ada_lookup_simple_minsyms): New function.
10694         (create_excep_cond_exprs): Iterate over program spaces.
10695         (ada_exception_catchpoint_cond_string): Examine all minimal
10696         symbols for exception types.
10697
10698 2019-04-30  Tom Tromey  <tromey@adacore.com>
10699
10700         PR c++/24470:
10701         * dwarf2read.c (process_structure_scope): Handle case where type
10702         has template parameters but no symbol was created.
10703
10704 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10705             Chris January  <chris.january@arm.com>
10706
10707         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10708         qualifier.
10709         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10710
10711 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10712
10713         * f-typeprint.c (f_print_type): Update rules for printing
10714         whitespace.
10715         (f_type_print_varspec_suffix): Likewise.
10716
10717 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10718             Chris January  <chris.january@arm.com>
10719
10720         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10721         function arguments.
10722
10723 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10724
10725         * f-lang.c (build_fortran_types): Change name of void type to
10726         lower case.
10727         * f-typeprint.c (f_type_print_base): Print the name of the void
10728         type, rather than a fixed string.
10729         * f-valprint.c (f_decorations): Use lower case void string.
10730
10731 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10732             Chris January  <chris.january@arm.com>
10733
10734         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10735         types for Fortran.
10736
10737 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10738             Chris January  <chris.january@arm.com>
10739             David Lecomber  <david.lecomber@arm.com>
10740
10741         * f-exp.y (BINOP_INTRINSIC): New token.
10742         (exp): New parser rule handling BINOP_INTRINSIC.
10743         (f77_keywords): Add new builtin procedures.
10744         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10745         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10746         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10747         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10748         (print_unop_subexp_f): New function.
10749         (print_binop_subexp_f): New function.
10750         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10751         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10752         (dump_subexp_body_f): Likewise.
10753         (operator_check_f): Likewise.
10754         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10755         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10756
10757 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10758
10759         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10760         UNOP_KIND.
10761         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10762         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10763         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10764         (operator_length_f): New fuction.
10765         (print_subexp_f): New function.
10766         (op_name_f): New function.
10767         (dump_subexp_body_f): New function.
10768         (operator_check_f): New function.
10769         (exp_descriptor_f): Replace standard expression handling functions
10770         with new functions.
10771         * gdb/fortran-operator.def: New file.
10772         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10773         * gdb/std-operator.def: Remove UNOP_KIND.
10774
10775 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10776
10777         * std-operator.def: Remove unbalanced, stray double quote
10778         character.
10779
10780 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10781             Chris January  <chris.january@arm.com>
10782             Daniel Everett  <daniel.everett@arm.com>
10783             Nick Forrington  <nick.forrington@arm.com>
10784             Richard Bunt  <richard.bunt@arm.com>
10785
10786         * cp-valprint.c (cp_print_value_fields): Allow an additional level
10787         of depth when printing anonymous structs or unions.
10788         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10789         Don't print either the top-level value, or the children if the
10790         max-depth is exceeded.
10791         (ppscm_print_children): When printing the key of a map, allow one
10792         extra level of depth.
10793         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10794         print either the top-level value, or the children if the max-depth
10795         is exceeded.
10796         (print_children): When printing the key of a map, allow one extra
10797         level of depth.
10798         * python/py-value.c (valpy_format_string): Add max_depth keyword.
10799         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10800         (user_print_options): Initialise max_depth field.
10801         (val_print_scalar_or_string_type_p): New function.
10802         (val_print): Check to see if the max depth has been reached.
10803         (val_print_check_max_depth): Define new function.
10804         (show_print_max_depth): New function.
10805         (_initialize_valprint): Add 'print max-depth' option.
10806         * valprint.h (struct value_print_options) <max_depth>: New field.
10807         (val_print_check_max_depth): Declare new function.
10808         * NEWS: Document new feature.
10809
10810 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10811
10812         * ada-lang.c (ada_language_defn): Initialise new field.
10813         * c-lang.c (c_is_string_type_p): New function.
10814         (c_language_defn): Initialise new field.
10815         (cplus_language_defn): Initialise new field.
10816         (asm_language_defn): Initialise new field.
10817         (minimal_language_defn): Initialise new field.
10818         * c-lang.h (c_is_string_type_p): Declare new function.
10819         * d-lang.c (d_language_defn): Initialise new field.
10820         * f-lang.c (f_is_string_type_p): New function.
10821         (f_language_defn): Initialise new field.
10822         * go-lang.c (go_is_string_type_p): New function.
10823         (go_language_defn): Initialise new field.
10824         * language.c (default_is_string_type_p): New function.
10825         (unknown_language_defn): Initialise new field.
10826         (auto_language_defn): Initialise new field.
10827         * language.h (struct language_defn) <la_is_string_type_p>: New
10828         member variable.
10829         (default_is_string_type_p): Declare new function.
10830         * m2-lang.c (m2_language_defn): Initialise new field.
10831         * objc-lang.c (objc_language_defn): Initialise new field.
10832         * opencl-lang.c (opencl_language_defn): Initialise new field.
10833         * p-lang.c (pascal_is_string_type_p): New function.
10834         (pascal_language_defn): Initialise new field.
10835         * rust-lang.c (rust_is_string_type_p): New function.
10836         (rust_language_defn): Initialise new field.
10837
10838 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10839
10840         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10841         New field.
10842         * ada-lang.c (ada_language_defn): Initialise new field.
10843         * c-lang.c (c_language_defn): Likewise.
10844         (cplus_language_defn): Likewise.
10845         (asm_language_defn): Likewise.
10846         (minimal_language_defn): Likewise.
10847         * d-lang.c (d_language_defn): Likewise.
10848         * f-lang.c (f_language_defn): Likewise.
10849         * go-lang.c (go_language_defn): Likewise.
10850         * language.c (unknown_language_defn): Likewise.
10851         (auto_language_defn): Likewise.
10852         * m2-lang.c (m2_language_defn): Likewise.
10853         * objc-lang.c (objc_language_defn): Likewise.
10854         * opencl-lang.c (opencl_language_defn): Likewise.
10855         * p-lang.c (pascal_language_defn): Likewise.
10856         * rust-lang.c (rust_language_defn): Likewise.
10857
10858 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10859
10860         * ada-lang.c (ada_is_character_type): Change return type to bool.
10861         (ada_is_string_type): Likewise.
10862         * ada-lang.h (ada_is_character_type): Update declaration
10863         (ada_is_string_type): Likewise.
10864
10865 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10866
10867         Support style in 'frame|thread apply'
10868
10869         * gdbcmd.h (execute_command_to_string): New term_out parameter.
10870         * record.c (record_start, record_stop): Update callers of
10871         execute_command_to_string with false.
10872         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10873         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10874         methods.
10875         (class string_file): New constructor with term_out parameter.
10876         Override methods term_out and can_emit_style_escape.  New member
10877         term_out.
10878         (class stdio_file): Override can_emit_style_escape.
10879         (class tee_file): Override term_out and can_emit_style_escape.
10880         * utils.h (can_emit_style_escape): Remove.
10881         * utils.c (can_emit_style_escape): Likewise.
10882         Update all callers of can_emit_style_escape (SOMESTREAM) to
10883         SOMESTREAM->can_emit_style_escape.
10884         * source-cache.c (source_cache::get_source_lines): Likewise.
10885         * stack.c (frame_apply_command_count): Call execute_command_to_string
10886         passing the term_out characteristic of the current gdb_stdout.
10887         * thread.c (thr_try_catch_cmd): Likewise.
10888         * top.c (execute_command_to_string): pass term_out parameter
10889         to construct the string_file for the command output.
10890         * ui-file.c (term_cli_styling): New function (most code moved
10891         from utils.c can_emit_style_escape).
10892         (string_file::string_file, string_file::can_emit_style_escape,
10893         stdio_file::can_emit_style_escape, tee_file::term_out,
10894         tee_file::can_emit_style_escape): New functions.
10895
10896 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10897
10898         * NEWS: Mention the new set|show may-call-functions.
10899         * infcall.c (may_call_functions_p): New variable.
10900         (show_may_call_functions_p): New function.
10901         (call_function_by_hand_dummy): Throws an error if not
10902         may-call-functions.
10903         (_initialize_infcall): Call add_setshow_boolean_cmd for
10904         may-call-functions.
10905
10906 2019-04-25  Keith Seitz  <keiths@redhat.com>
10907
10908         PR c++/24367
10909         * cp-support.c (inspect_type): Don't attempt substitutions
10910         of symbol with the same name.
10911
10912 2019-04-25  Tom Tromey  <tromey@adacore.com>
10913
10914         PR gdb/24475:
10915         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10916         static.
10917
10918 2019-04-25  Tom Tromey  <tromey@adacore.com>
10919
10920         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10921         rvalue reference.
10922         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10923         (gdb_xml_parser::parse): Use std::move.
10924         * python/python-internal.h (gdbpy_convert_exception): Take a const
10925         reference.
10926         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10927         std::move.
10928         * python/py-utils.c (gdbpy_convert_exception): Take a const
10929         reference.
10930         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10931         Use std::move.
10932         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10933         Use std::move.
10934         * mi/mi-main.c (mi_print_exception): Take a const reference.
10935         * main.c (handle_command_errors): Take a const reference.
10936         * linespec.c (parse_linespec): Use std::move.
10937         * infcall.c (run_inferior_call): Use std::move.
10938         (call_function_by_hand_dummy): Use std::move.
10939         * exec.c (try_open_exec_file): Use std::move.
10940         * exceptions.h (exception_print, exception_fprintf)
10941         (exception_print_same): Update.
10942         * exceptions.c (print_exception, exception_print)
10943         (exception_fprintf, exception_print_same): Change parameters to
10944         const reference.
10945         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10946         * common/new-op.c: Use std::move.
10947         * common/common-exceptions.h (struct gdb_exception): Add move
10948         constructor.
10949         (struct gdb_exception_error, struct gdb_exception_quit, struct
10950         gdb_quit_bad_alloc): Change constructor to move constructor.
10951         (throw_exception): Change parameter to rvalue reference.
10952         * common/common-exceptions.c (throw_exception): Take rvalue
10953         reference.
10954         * cli/cli-interp.c (safe_execute_command): Use std::move.
10955         * breakpoint.c (insert_bp_location, location_to_sals): Use
10956         std::move.
10957
10958 2019-04-25  Tom Tromey  <tromey@adacore.com>
10959
10960         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10961         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10962         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10963         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10964         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10965         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10966         guile/scm-value.c: Use unpack.
10967         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10968         gdbscm_gdb_exception.
10969         (gdbscm_throw_gdb_exception): Likewise.
10970         (struct gdbscm_gdb_exception): New.
10971         (unpack): New function.
10972         (gdbscm_wrap): Use unpack.
10973
10974 2019-04-25  Tom Tromey  <tromey@adacore.com>
10975
10976         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10977         (gdb_rl_callback_handler): Use std::move.
10978         * common/common-exceptions.h (struct gdb_exception): Add move
10979         assignment operator.
10980         (throw_exception_sjlj): Change "exception" to const reference.
10981         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10982         (throw_exception_sjlj): Change "exception" to const reference.
10983
10984 2019-04-25  Tom Tromey  <tromey@adacore.com>
10985
10986         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10987         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10988         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10989         Update.
10990         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10991         Update.
10992         * mi/mi-interp.c (mi_interp::exec): Update.
10993         * linespec.c (parse_linespec): Update.
10994         * infcall.c (run_inferior_call): Update.
10995         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10996         * guile/scm-symbol.c (gdbscm_lookup_symbol)
10997         (gdbscm_lookup_global_symbol): Update.
10998         * guile/scm-param.c (gdbscm_parameter_value): Update.
10999         * guile/scm-frame.c (gdbscm_frame_read_register)
11000         (gdbscm_frame_read_var): Update.
11001         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11002         * exec.c (try_open_exec_file): Update.
11003         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11004         (gdb_rl_callback_handler): Update.
11005         * common/common-exceptions.h (exception_none): Don't declare.
11006         * common/common-exceptions.c (exception_none): Don't define.
11007         (struct catcher) <exception>: Update.
11008         * cli/cli-interp.c (safe_execute_command): Update.
11009         * breakpoint.c (insert_bp_location, location_to_sals): Update.
11010
11011 2019-04-25  Ali Tamur  <tamur@google.com>
11012
11013         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11014         (read_attribute_value): Likewise.
11015         (dwarf2_read_addr_index): Update comment.
11016         (read_str_index): Add DW_FORM_strx.
11017         (dwarf2_string_attr): Likewise.
11018         (dwarf2_const_value_attr): Likewise.
11019         (dump_die_shallow): Likewise.
11020         (dwarf2_fetch_constant_bytes): Likewise.
11021         (skip_form_bytes): Likewise.
11022         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11023
11024 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
11025
11026         PR corefiles/11608
11027         PR corefiles/18187
11028         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11029         OFFSET.  Verify if current mapping contains an ELF header.
11030         (linux_find_memory_regions_full): Adjust call to
11031         dump_mapping_p.
11032
11033 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
11034             Kang Li <kanglictf@gmail.com>
11035
11036         PR gdb/21600
11037
11038         * dwarf2-frame.c (read_initial_length): Be consistent about using
11039         unsigned representation of length.
11040         (decode_frame_entry_1): Likewise.  Check for wraparound of
11041         end pointer as well as buffer overflow.
11042
11043 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
11044
11045         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11046         "vq".
11047
11048 2019-04-24  Tom Tromey  <tromey@adacore.com>
11049
11050         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11051
11052 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11053
11054         * s12z-tdep.c (s12z_unwind_pc): Delete.
11055         (s12z_unwind_sp): Delete.
11056         (s12z_gdbarch_init): Don't register deleted functions with
11057         gdbarch.
11058
11059 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11060
11061         * rl78-tdep.c (rl78_unwind_sp): Delete.
11062         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11063
11064 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11065
11066         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11067         (xstormy16_unwind_pc): Delete.
11068         (xstormy16_dummy_id): Delete.
11069         (xstormy16_gdbarch_init): Don't register deleted functions with
11070         gdbarch.
11071
11072 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11073
11074         * vax-tdep.c (vax_unwind_pc): Delete.
11075         (vax_gdbarch_init): Don't register deleted function with gdbarch.
11076
11077 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11078
11079         * v850-tdep.c (v850_unwind_sp): Delete.
11080         (v850_unwind_pc): Delete.
11081         (v850_dummy_id): Delete.
11082         (v850_gdbarch_init): Don't register deleted functions with
11083         gdbarch.
11084
11085 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11086
11087         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11088         (tilegx_unwind_pc): Delete.
11089         (tilegx_unwind_dummy_id): Delete.
11090         (tilegx_gdbarch_init): Don't register deleted functions with
11091         gdbarch.
11092
11093 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11094
11095         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11096         (tic6x_dummy_id): Delete.
11097         (tic6x_gdbarch_init): Don't register deleted functions with
11098         gdbarch.
11099
11100 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11101
11102         * sparc-tdep.c (sparc_unwind_pc): Delete.
11103         (sparc32_gdbarch_init): Don't register deleted function with
11104         gdbarch.
11105
11106 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11107
11108         * sh-tdep.c (sh_unwind_sp): Delete.
11109         (sh_unwind_pc): Delete.
11110         (sh_dummy_id): Delete.
11111         (sh_gdbarch_init): Don't register deleted functions with
11112         gdbarch.
11113
11114 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11115
11116         * score-tdep.c (score_unwind_sp): Delete.
11117         (score_unwind_pc): Delete.
11118         (score_dummy_id): Delete.
11119         (score_gdbarch_init): Don't register deleted functions with
11120         gdbarch.
11121
11122 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11123
11124         * rx-tdep.c (rx_unwind_pc): Delete.
11125         (rx_unwind_sp): Delete.
11126         (rx_dummy_id): Delete.
11127         (rx_gdbarch_init): Don't register deleted functions with
11128         gdbarch.  Update comment.
11129
11130 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11131
11132         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11133         (rs6000_dummy_id): Delete.
11134         (rs6000_gdbarch_init): Don't register deleted functions with
11135         gdbarch.
11136
11137 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11138
11139         * or1k-tdep.c (or1k_dummy_id): Delete.
11140         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11141
11142 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11143
11144         * nios2-tdep.c (nios2_dummy_id): Delete.
11145         (nios2_unwind_sp): Delete.
11146         (nios2_gdbarch_init): Don't register deleted functions with
11147         gdbarch.
11148
11149 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11150
11151         * nds32-tdep.c (nds32_dummy_id): Delete.
11152         (nds32_unwind_pc): Delete.
11153         (nds32_unwind_sp): Delete.
11154         (nds32_gdbarch_init): Don't register deleted functions with
11155         gdbarch.
11156
11157 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11158
11159         * msp430-tdep.c (msp430_unwind_pc): Delete.
11160         (msp430_unwind_sp): Delete.
11161         (msp430_dummy_id): Delete.
11162         (msp430_gdbarch_init): Don't register deleted functions with
11163         gdbarch.
11164
11165 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11166
11167         * moxie-tdep.c (moxie_unwind_sp): Delete.
11168         (moxie_unwind_pc): Delete.
11169         (moxie_dummy_id): Delete.
11170         (moxie_gdbarch_init): Don't register deleted functions with
11171         gdbarch.
11172
11173 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11174
11175         * mn10300-tdep.c (mn10300_dummy_id): Delete.
11176         (mn10300_unwind_pc): Delete.
11177         (mn10300_unwind_sp): Delete.
11178         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11179         mn10300_unwind_sp.
11180         (mn10300_frame_unwind_init): Don't register deleted functions with
11181         gdbarch.
11182
11183 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11184
11185         * mep-tdep.c (mep_unwind_pc): Delete.
11186         (mep_unwind_sp): Delete.
11187         (mep_dummy_id): Delete.
11188         (mep_gdbarch_init): Don't register deleted functions with
11189         gdbarch.
11190
11191 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11192
11193         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11194         (m68hc11_unwind_sp): Delete.
11195         (m68hc11_gdbarch_init): Don't register deleted functions with
11196         gdbarch.
11197
11198 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11199
11200         * m32r-tdep.c (m32r_unwind_sp): Delete.
11201         (m32r_unwind_pc): Delete.
11202         (m32r_dummy_id): Delete.
11203         (m32r_gdbarch_init): Don't register deleted functions with
11204         gdbarch.
11205
11206 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11207
11208         * m32c-tdep.c (m32c_unwind_pc): Delete.
11209         (m32c_unwind_sp): Delete.
11210         (m32c_dummy_id): Delete.
11211         (m32c_gdbarch_init): Don't register deleted functions with
11212         gdbarch.
11213
11214 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11215
11216         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11217         (lm32_unwind_pc): Delete.
11218         (lm32_dummy_id): Delete.
11219         (lm32_gdbarch_init): Don't register deleted functions with
11220         gdbarch.
11221
11222 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11223
11224         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11225         (iq2000_unwind_pc): Delete.
11226         (iq2000_dummy_id): Delete.
11227         (iq2000_gdbarch_init): Don't register deleted functions with
11228         gdbarch.
11229
11230 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11231
11232         * nds32-tdep.c (nds32_type_align): Delete.
11233         (nds32_push_dummy_call): Use type_align instead.
11234
11235 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11236
11237         * arm-tdep.c (arm_type_align): Only handle vector override case.
11238         (arm_push_dummy_call): Use type_align.
11239         (arm_gdbarch_init): Register arm_type_align gdbarch function.
11240
11241 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11242
11243         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11244         case.
11245         (pass_on_stack): Use type_align.
11246         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11247         function.
11248
11249 2019-04-23  Tom Tromey  <tromey@adacore.com>
11250
11251         * dwarf2read.c (line_header::file_name_at): Remove unused
11252         overload.
11253
11254 2019-04-23  Tom de Vries  <tdevries@suse.de>
11255
11256         PR gdb/24438
11257         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11258         invocation.
11259
11260
11261 2019-03-27  Ali Tamur  <tamur@google.com>
11262
11263         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11264         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11265         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11266         (dwarf_expr_context::get_addr_index): Likewise
11267         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11268         (symbol_needs_eval_context::get_addr_index): Likewise
11269         (disassemble_dwarf_expression): Add DW_OP_addrx
11270         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11271         (read_cutu_die_from_dwo): Update comment
11272         (skip_one_die): Add DW_FORM_addrx
11273         (read_attribute_value): Likewise
11274         (var_decode_location): Add DW_OP_addrx
11275         (dwarf2_const_value_attr): Add DW_FORM_addrx
11276         (dump_die_shallow): Likewise
11277         (dwarf2_fetch_constant_bytes): Likewise
11278         (decode_locdesc): Add DW_OP_addrx
11279         (skip_form_bytes): Add DW_FORM_addrx
11280
11281 2019-04-22  Ali Tamur  <tamur@google.com>
11282
11283         * MAINTAINERS (Write After Approval): Add self.
11284
11285 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
11286
11287         * solib-svr4.c (get_svr4_info): Add pspace parameter.
11288         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11289         (open_symbol_file_object): Likewise.
11290         (svr4_default_sos): Add info parameter.
11291         (svr4_read_so_list): Likewise.
11292         (svr4_current_sos_direct): Adjust functions calls to pass down
11293         info.
11294         (svr4_current_sos_1): Add info parameter.
11295         (svr4_current_sos): Call get_svr4_info, pass info down to
11296         svr4_current_sos_1.
11297         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11298         get_svr4_info.
11299         (svr4_in_dynsym_resolve_code): Pass current_program_space to
11300         get_svr4_info.
11301         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11302         to get_svr4_info.
11303         (probes_table_remove_objfile_probes): Likewise.
11304         (register_solib_event_probe): Add info parameter.
11305         (solist_update_incremental): Pass info parameter down to
11306         svr4_read_so_list.
11307         (disable_probes_interface): Add info parameter.
11308         (svr4_handle_solib_event): Pass current_program_space to
11309         get_svr4_info.  Adjust disable_probes_interface cleanup.
11310         (svr4_create_probe_breakpoints): Add info parameter, pass it
11311         down to register_solib_event_probe.
11312         (svr4_create_solib_event_breakpoints): Add info parameter,
11313         pass it down to svr4_create_probe_breakpoints.
11314         (enable_break): Pass info down to
11315         svr4_create_solib_event_breakpoints.
11316         (svr4_solib_create_inferior_hook): Pass current_program_space to
11317         get_svr4_info.
11318         (svr4_clear_solib): Likewise.
11319
11320 2019-04-22  Pedro Alves  <palves@redhat.com>
11321
11322         * solib-svr4.c (svr4_free_objfile_observer): New.
11323         (probe_and_action::objfile): New field.
11324         (probes_table_htab_remove_objfile_probes)
11325         (probes_table_remove_objfile_probes): New functions.
11326         (register_solib_event_probe): Add 'objfile' parameter.  Store it
11327         in the new probe_and_action.  Don't store the probe in 'lookup'.
11328         (svr4_create_probe_breakpoints): Pass objfile to
11329         register_solib_event_probe.
11330         (_initialize_svr4_solib): Register a free_objfile observer.
11331
11332 2019-04-19  Tom Tromey  <tom@tromey.com>
11333
11334         * common/queue.h: Remove.
11335
11336 2019-04-19  Tom Tromey  <tom@tromey.com>
11337
11338         * event-loop.c: Don't include "common/queue.h".
11339
11340 2019-04-19  Tom Tromey  <tom@tromey.com>
11341
11342         * remote.c (remote_target): Use delete.
11343         * remote-notif.h: Include <list>, not "common/queue.h".
11344         (notif_client_p): Remove typedef.
11345         (remote_notif_state): Add constructor, destructor, initializer.
11346         <notif_queue>: Now a std::list.
11347         (remote_notif_state_xfree): Don't declare.
11348         * remote-notif.c (remote_notif_process, handle_notification)
11349         (remote_notif_state_allocate): Update.
11350         (~remote_notif_state): Rename from remote_notif_state_xfree.
11351
11352 2019-04-19  Tom Tromey  <tom@tromey.com>
11353
11354         * symfile.c (reread_symbols): Update.
11355         * objfiles.c (objfile_register_static_link)
11356         (objfile_lookup_static_link): Update
11357         (~objfile) Don't delete static_links.
11358         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11359
11360 2019-04-19  Tom Tromey  <tom@tromey.com>
11361
11362         * type-stack.h (struct type_stack) <insert>: Constify string.
11363         * type-stack.c (type_stack::insert): Constify string.
11364         * gdbtypes.h (lookup_template_type): Update.
11365         (address_space_name_to_int): Update.
11366         * gdbtypes.c (address_space_name_to_int): Make space_identifier
11367         const.
11368         (lookup_template_type): Make name const.
11369         * c-exp.y: Update rules.
11370         (lex_one_token, classify_name, classify_inner_name)
11371         (c_print_token): Update.
11372         * p-exp.y: Update rules.
11373         (yylex): Update.
11374         * f-exp.y: Update rules.
11375         (yylex): Update.
11376         * d-exp.y: Update rules.
11377         (lex_one_token, classify_name, classify_inner_name): Update.
11378         * parse.c (write_dollar_variable, copy_name): Return std::string.
11379         * parser-defs.h (copy_name): Change return type.
11380         * m2-exp.y: Update rules.
11381         (yylex): Update.
11382         * go-exp.y (lex_one_token): Update.
11383         Update rules.
11384         (classify_unsafe_function, classify_packaged_name)
11385         (classify_name, yylex): Update.
11386
11387 2019-04-19  Sergei Trofimovich <siarheit@google.com>
11388
11389         * configure.ac: add --enable-source-highlight switch.
11390         * configure: Regenerate.
11391         * top.c (print_gdb_version): plumb --enable-source-highlight
11392         status to "show configuration".
11393
11394 2019-04-19  Tom Tromey  <tromey@adacore.com>
11395
11396         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11397         Check ADA_TYPE_P.
11398         (empty_record, ada_template_to_fixed_record_type_1)
11399         (template_to_static_fixed_type)
11400         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11401         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11402         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11403         macros.
11404
11405 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
11406
11407         PR symtab/24423:
11408         * source.c (print_source_lines_base): Advance "iter" when a
11409         control character is seen.
11410
11411 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11412
11413         * inferior.h (struct infcall_suspend_state_deleter):
11414         Catch exception in destructor to avoid crash.
11415
11416 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11417
11418         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11419         close to the add_com "shell".
11420
11421 2019-04-18  Tom Tromey  <tromey@adacore.com>
11422
11423         * process-stratum-target.h (class process_stratum_target)
11424         <stratum>: Add "final".
11425
11426 2019-04-17  Tom Tromey  <tromey@adacore.com>
11427
11428         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11429         against nullptr before use.
11430
11431 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
11432
11433         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11434
11435 2019-04-17  Jim Wilson  <jimw@sifive.com>
11436             Andrew Burgess  <andrew.burgess@embecosm.com>
11437
11438         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11439         code read might fail, assume 4-byte breakpoint in that case.
11440
11441 2019-04-15  Leszek Swirski  <leszeks@google.com>
11442
11443         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11444         rather than a hand-rolled POD check when checking for forced MEMORY
11445         classification.
11446
11447 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11448
11449         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11450         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11451         function.
11452         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11453         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11454         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11455         declaration.
11456
11457 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11458
11459         * aarch64-linux-nat.c
11460         (aarch64_linux_nat_target::thread_architecture): Add override.
11461         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11462         each VQ.
11463
11464 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11465
11466         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11467
11468 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11469
11470         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11471         target types of size 96-bits, add some additional comments, and
11472         check that the builtin type we found was the correct size.
11473
11474 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
11475
11476         * utils.c (prompt_for_continue): Don't restore the styling at the
11477         end, as applied_style has the wrong value.  This fixes styling in
11478         long lists of file names that are interrupted by the "Continue?"
11479         prompt.
11480
11481 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11482
11483         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11484         * c-lang.c (c_language_defn): Likewise.
11485         (cplus_language_defn): Likewise.
11486         (asm_language_defn): Likewise.
11487         (minimal_language_defn): Likewise.
11488         * d-lang.c (d_language_defn): Likewise.
11489         * f-lang.c (f_language_defn): Likewise.
11490         * go-lang.c (go_language_defn): Likewise.
11491         * language.c (unknown_language_defn): Likewise.
11492         (auto_language_defn): Likewise.
11493         * language.h (struct language_defn): Remove la_magic field.
11494         (LANG_MAGIC): Delete.
11495         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11496         * objc-lang.c (objc_language_defn): Likewise.
11497         * opencl-lang.c (opencl_language_defn): Likewise.
11498         * p-lang.c (pascal_language_defn): Likewise.
11499         * rust-lang.c (rust_language_defn): Likewise.
11500
11501 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11502
11503         * riscv-tdep.c (riscv_type_align): New function.
11504         (riscv_type_alignment): Delete.
11505         (riscv_arg_location): Use 'type_align'.
11506         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11507
11508 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11509
11510         * gdbtypes.c (type_align): A struct with no non-static fields also
11511         has alignment of 1.
11512
11513 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11514
11515         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11516         component to 0.
11517         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11518         member.
11519         (riscv_struct_info::analyse): New implementation using new
11520         analyse_inner member function.
11521         (riscv_struct_info::field_offset): New member function.
11522         (riscv_struct_info::m_offsets): New member variable.
11523         (riscv_struct_info::analyse_inner): New private member function,
11524         takes the old implementation of riscv_struct_info::analyse but
11525         extended to track field offsets.
11526         (riscv_call_arg_struct): Update the struct folding special cases
11527         to handle cases where empty C++ structs, which are non-zero
11528         length, are found.
11529         (riscv_arg_location): Initialise the length of each location, a
11530         non-zero length now indicates the location is in use.
11531         (riscv_push_dummy_call): Allow for the first location having a
11532         non-zero offset when setting up arguments.
11533         (riscv_return_value): Likewise, but for return values.
11534
11535 2019-04-11  Tom Tromey  <tromey@adacore.com>
11536
11537         * utils.c (internal_vproblem): Make "msg" const.
11538
11539 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
11540
11541         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11542         * trad-frame.c (trad_frame_reset_saved_regs): New function.
11543         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11544         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11545
11546 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
11547
11548         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11549         function.
11550         (fill_gregset): Call amd64_linux_collect_native_gregset instead
11551         of amd64_collect_native_gregset.
11552         (amd64_linux_nat_target::store_registers): Likewise.
11553
11554 2019-04-10  Tom Tromey  <tom@tromey.com>
11555
11556         * symtab.c (lookup_global_symbol_from_objfile)
11557         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11558         * objfiles.h (class separate_debug_iterator): New.
11559         (class separate_debug_range): New.
11560         (struct objfile) <separate_debug_objfiles>: New method.
11561         (objfile_separate_debug_iterate): Don't declare.
11562         * objfiles.c (separate_debug_iterator::operator++): Rename from
11563         objfile_separate_debug_iterate.
11564         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11565         iterator.
11566         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11567         iterator.
11568
11569 2019-04-10  Tom Tromey  <tom@tromey.com>
11570
11571         * symfile.c (reread_symbols): Remove old comment.
11572         * objfiles.c (free_all_objfiles): Fix a typo.
11573
11574 2019-04-10  Tom Tromey  <tom@tromey.com>
11575
11576         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11577         * minsyms.c (lookup_minimal_symbol): Use foreach.
11578         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11579         (lookup_minimal_symbol_solib_trampoline): Likewise.
11580         * symfile.c (reread_symbols): Use foreach.
11581
11582 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
11583             Tom Tromey  <tromey@adacore.com>
11584
11585         PR rust/24414:
11586         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11587         (rust_lex_int_test): Change "value" to be LONGEST.
11588         (rust_lex_tests): Add test for long integer literal.
11589
11590 2019-04-09  Tom Tromey  <tromey@adacore.com>
11591
11592         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11593         to bool.
11594         (extended_remote_target::attach): Update.
11595         (remote_target::remote_notice_new_inferior): Update.
11596         (remote_target::add_current_inferior_and_thread): Update.
11597         * inferior.c (exit_inferior_1): Use "false".
11598         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11599
11600 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
11601
11602         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11603         the "start" command.
11604
11605 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11606
11607         * python/py-inferior.c (infpy_thread_from_thread_handle):
11608         Adjust comments to reflect renaming of thread_from_thread_handle
11609         to thread_from_handle.  Adjust keywords.  Fix type error message.
11610         (inferior_object_methods): Add thread_from_handle.  Retain
11611         thread_from_thread_handle, but mark it as deprecated.
11612
11613 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11614
11615         * gdbthread.h (find_thread_by_handle): Revise declaration.
11616         * thread.c (find_thread_by_handle): Likewise.  Adjust
11617         implementation too.
11618         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11619         support for buffer objects as handles.
11620
11621 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11622
11623         * python/py-infthread.c (thpy_thread_handle): New function.
11624         (thread_object_methods): Register thpy_thread_handle.
11625
11626 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11627
11628         * gdbthread.h (thread_to_thread_handle): Declare.
11629         * thread.c (gdbtypes.h): Include.
11630         (thread_to_thread_handle): New function.
11631
11632         * target.h (struct target_ops): Add thread_info_to_thread_handle.
11633         (target_thread_info_to_thread_handle): Declare.
11634         * target.c (target_thread_info_to_thread_handle): New function.
11635         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11636         * target-delegates.c: Regenerate.
11637
11638         * linux-thread-db.c (class thread_db_target): Add method
11639         thread_info_to_thread_handle.
11640         (thread_db_target::thread_info_to_thread_handle): Define.
11641         * remote.c (class remote_target): Add new method
11642         thread_info_to_thread_handle.
11643         (remote_target::thread_info_to_thread_handle): Define.
11644
11645 2019-04-08  Pedro Alves  <palves@redhat.com>
11646
11647         * common/common-exceptions.c (throw_exception): Don't create
11648         named object to throw; throw directly.
11649         (throw_it): Likewise.  Don't initialize gdb_exception::message
11650         here, with new; pass FMT and AP to the ctor instead.
11651         * common/common-exceptions.h: Include <string>.
11652         (gdb_exception::gdb_exception(enum return_reason, enum errors,
11653         const char *, va_list)): New ctor.  Use std::make_shared.
11654         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11655         errors)): Delete.
11656         (gdb_exception_error::gdb_exception_error(enum errors, const char
11657         *, va_list)): New.
11658         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11659         Add assertion.
11660         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11661         errors)): Delete.
11662         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11663         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11664         Add assertion.
11665
11666 2019-04-08  Tom Tromey  <tom@tromey.com>
11667
11668         * valops.c (value_rtti_indirect_type): Replace throw_exception
11669         with throw.
11670         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11671         with throw.
11672         * thread.c (thr_try_catch_cmd): Replace throw_exception with
11673         throw.
11674         * target.c (target_translate_tls_address): Replace throw_exception
11675         with throw.
11676         * stack.c (frame_apply_command_count): Replace throw_exception
11677         with throw.
11678         * solib-spu.c (append_ocl_sos): Replace throw_exception with
11679         throw.
11680         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11681         with throw.
11682         * rs6000-tdep.c (rs6000_frame_cache)
11683         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11684         * remote.c: Replace throw_exception with throw.
11685         * record-full.c (record_full_message, record_full_wait_1)
11686         (record_full_restore): Replace throw_exception with throw.
11687         * record-btrace.c:
11688         (get_thread_current_frame_id, record_btrace_start_replaying)
11689         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11690         (cmd_record_btrace_start): Replace throw_exception with throw.
11691         * parse.c (parse_exp_in_context_1): Replace throw_exception with
11692         throw.
11693         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11694         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11695         * linespec.c:
11696         (find_linespec_symbols): Replace throw_exception with throw.
11697         * infrun.c (displaced_step_prepare, resume): Replace
11698         throw_exception with throw.
11699         * infcmd.c (post_create_inferior): Replace throw_exception with
11700         throw.
11701         * inf-loop.c (inferior_event_handler): Replace throw_exception
11702         with throw.
11703         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11704         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11705         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11706         (get_prev_frame_always, get_frame_pc_if_available)
11707         (get_frame_address_in_block_if_available, get_frame_language):
11708         Replace throw_exception with throw.
11709         * frame-unwind.c (frame_unwind_try_unwinder): Replace
11710         throw_exception with throw.
11711         * eval.c (fetch_subexp_value, evaluate_var_value)
11712         (evaluate_funcall, evaluate_subexp_standard): Replace
11713         throw_exception with throw.
11714         * dwarf2loc.c (call_site_find_chain)
11715         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11716         Replace throw_exception with throw.
11717         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11718         with throw.
11719         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11720         throw.
11721         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11722         * completer.c (complete_line_internal): Replace throw_exception
11723         with throw.
11724         * compile/compile-object-run.c (compile_object_run): Replace
11725         throw_exception with throw.
11726         * cli/cli-script.c (process_next_line): Replace throw_exception
11727         with throw.
11728         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11729         (btrace_enable, btrace_maint_update_pt_packets): Replace
11730         throw_exception with throw.
11731         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11732         throw_exception with throw.
11733         * break-catch-throw.c (re_set_exception_catchpoint): Replace
11734         throw_exception with throw.
11735         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11736         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11737         * aarch64-tdep.c (aarch64_make_prologue_cache)
11738         (aarch64_make_stub_cache): Replace throw_exception with throw.
11739
11740 2019-04-08  Tom Tromey  <tom@tromey.com>
11741
11742         * common/common-exceptions.c (throw_exception): Rename from
11743         throw_exception_cxx.  Remove old copy.  Make argument const.
11744         (throw_it): Create and throw exception objects directly.
11745         * common/common-exceptions.h (throw_exception): Make argument
11746         const.
11747         (struct gdb_exception_error): Add constructor.
11748         (struct gdb_exception_quit): Add constructor.
11749
11750 2019-04-08  Tom Tromey  <tom@tromey.com>
11751
11752         * common/common-exceptions.h (exception_rethrow): Don't declare.
11753         (TRY_SJLJ): Update comment.
11754         (TRY, CATCH, END_CATCH): Remove.
11755         * common/common-exceptions.c (exception_rethrow): Remove.
11756
11757 2019-04-08  Tom Tromey  <tom@tromey.com>
11758
11759         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11760         Remove.
11761         (gdb_exception_error): Rename from
11762         gdb_exception_RETURN_MASK_ERROR.
11763         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11764         (gdb_quit_bad_alloc): Update.
11765         * aarch64-tdep.c: Update.
11766         * ada-lang.c: Update.
11767         * ada-typeprint.c: Update.
11768         * ada-valprint.c: Update.
11769         * amd64-tdep.c: Update.
11770         * arch-utils.c: Update.
11771         * break-catch-throw.c: Update.
11772         * breakpoint.c: Update.
11773         * btrace.c: Update.
11774         * c-varobj.c: Update.
11775         * cli/cli-cmds.c: Update.
11776         * cli/cli-interp.c: Update.
11777         * cli/cli-script.c: Update.
11778         * common/common-exceptions.c: Update.
11779         * common/new-op.c: Update.
11780         * common/selftest.c: Update.
11781         * compile/compile-c-symbols.c: Update.
11782         * compile/compile-cplus-symbols.c: Update.
11783         * compile/compile-object-load.c: Update.
11784         * compile/compile-object-run.c: Update.
11785         * completer.c: Update.
11786         * corelow.c: Update.
11787         * cp-abi.c: Update.
11788         * cp-support.c: Update.
11789         * cp-valprint.c: Update.
11790         * darwin-nat.c: Update.
11791         * disasm-selftests.c: Update.
11792         * dtrace-probe.c: Update.
11793         * dwarf-index-cache.c: Update.
11794         * dwarf-index-write.c: Update.
11795         * dwarf2-frame-tailcall.c: Update.
11796         * dwarf2-frame.c: Update.
11797         * dwarf2loc.c: Update.
11798         * dwarf2read.c: Update.
11799         * eval.c: Update.
11800         * event-loop.c: Update.
11801         * event-top.c: Update.
11802         * exec.c: Update.
11803         * f-valprint.c: Update.
11804         * fbsd-tdep.c: Update.
11805         * frame-unwind.c: Update.
11806         * frame.c: Update.
11807         * gdbtypes.c: Update.
11808         * gnu-v3-abi.c: Update.
11809         * guile/guile-internal.h: Update.
11810         * guile/scm-block.c: Update.
11811         * guile/scm-breakpoint.c: Update.
11812         * guile/scm-cmd.c: Update.
11813         * guile/scm-disasm.c: Update.
11814         * guile/scm-frame.c: Update.
11815         * guile/scm-lazy-string.c: Update.
11816         * guile/scm-math.c: Update.
11817         * guile/scm-param.c: Update.
11818         * guile/scm-ports.c: Update.
11819         * guile/scm-pretty-print.c: Update.
11820         * guile/scm-symbol.c: Update.
11821         * guile/scm-symtab.c: Update.
11822         * guile/scm-type.c: Update.
11823         * guile/scm-value.c: Update.
11824         * i386-linux-tdep.c: Update.
11825         * i386-tdep.c: Update.
11826         * inf-loop.c: Update.
11827         * infcall.c: Update.
11828         * infcmd.c: Update.
11829         * infrun.c: Update.
11830         * jit.c: Update.
11831         * language.c: Update.
11832         * linespec.c: Update.
11833         * linux-fork.c: Update.
11834         * linux-nat.c: Update.
11835         * linux-tdep.c: Update.
11836         * linux-thread-db.c: Update.
11837         * main.c: Update.
11838         * mi/mi-cmd-break.c: Update.
11839         * mi/mi-cmd-stack.c: Update.
11840         * mi/mi-interp.c: Update.
11841         * mi/mi-main.c: Update.
11842         * objc-lang.c: Update.
11843         * p-valprint.c: Update.
11844         * parse.c: Update.
11845         * ppc-linux-tdep.c: Update.
11846         * printcmd.c: Update.
11847         * python/py-arch.c: Update.
11848         * python/py-breakpoint.c: Update.
11849         * python/py-cmd.c: Update.
11850         * python/py-finishbreakpoint.c: Update.
11851         * python/py-frame.c: Update.
11852         * python/py-framefilter.c: Update.
11853         * python/py-gdb-readline.c: Update.
11854         * python/py-inferior.c: Update.
11855         * python/py-infthread.c: Update.
11856         * python/py-lazy-string.c: Update.
11857         * python/py-linetable.c: Update.
11858         * python/py-objfile.c: Update.
11859         * python/py-param.c: Update.
11860         * python/py-prettyprint.c: Update.
11861         * python/py-progspace.c: Update.
11862         * python/py-record-btrace.c: Update.
11863         * python/py-record.c: Update.
11864         * python/py-symbol.c: Update.
11865         * python/py-type.c: Update.
11866         * python/py-unwind.c: Update.
11867         * python/py-utils.c: Update.
11868         * python/py-value.c: Update.
11869         * python/python.c: Update.
11870         * record-btrace.c: Update.
11871         * record-full.c: Update.
11872         * remote-fileio.c: Update.
11873         * remote.c: Update.
11874         * riscv-tdep.c: Update.
11875         * rs6000-aix-tdep.c: Update.
11876         * rs6000-tdep.c: Update.
11877         * rust-exp.y: Update.
11878         * rust-lang.c: Update.
11879         * s390-tdep.c: Update.
11880         * selftest-arch.c: Update.
11881         * solib-dsbt.c: Update.
11882         * solib-frv.c: Update.
11883         * solib-spu.c: Update.
11884         * solib-svr4.c: Update.
11885         * solib.c: Update.
11886         * sparc64-linux-tdep.c: Update.
11887         * stack.c: Update.
11888         * symfile-mem.c: Update.
11889         * symmisc.c: Update.
11890         * target.c: Update.
11891         * thread.c: Update.
11892         * top.c: Update.
11893         * tracefile-tfile.c: Update.
11894         * tui/tui.c: Update.
11895         * typeprint.c: Update.
11896         * unittests/cli-utils-selftests.c: Update.
11897         * unittests/parse-connection-spec-selftests.c: Update.
11898         * valops.c: Update.
11899         * valprint.c: Update.
11900         * value.c: Update.
11901         * varobj.c: Update.
11902         * windows-nat.c: Update.
11903         * x86-linux-nat.c: Update.
11904         * xml-support.c: Update.
11905
11906 2019-04-08  Tom Tromey  <tom@tromey.com>
11907
11908         * xml-support.c: Use C++ exception handling.
11909         * x86-linux-nat.c: Use C++ exception handling.
11910         * windows-nat.c: Use C++ exception handling.
11911         * varobj.c: Use C++ exception handling.
11912         * value.c: Use C++ exception handling.
11913         * valprint.c: Use C++ exception handling.
11914         * valops.c: Use C++ exception handling.
11915         * unittests/parse-connection-spec-selftests.c: Use C++ exception
11916         handling.
11917         * unittests/cli-utils-selftests.c: Use C++ exception handling.
11918         * typeprint.c: Use C++ exception handling.
11919         * tui/tui.c: Use C++ exception handling.
11920         * tracefile-tfile.c: Use C++ exception handling.
11921         * top.c: Use C++ exception handling.
11922         * thread.c: Use C++ exception handling.
11923         * target.c: Use C++ exception handling.
11924         * symmisc.c: Use C++ exception handling.
11925         * symfile-mem.c: Use C++ exception handling.
11926         * stack.c: Use C++ exception handling.
11927         * sparc64-linux-tdep.c: Use C++ exception handling.
11928         * solib.c: Use C++ exception handling.
11929         * solib-svr4.c: Use C++ exception handling.
11930         * solib-spu.c: Use C++ exception handling.
11931         * solib-frv.c: Use C++ exception handling.
11932         * solib-dsbt.c: Use C++ exception handling.
11933         * selftest-arch.c: Use C++ exception handling.
11934         * s390-tdep.c: Use C++ exception handling.
11935         * rust-lang.c: Use C++ exception handling.
11936         * rust-exp.y: Use C++ exception handling.
11937         * rs6000-tdep.c: Use C++ exception handling.
11938         * rs6000-aix-tdep.c: Use C++ exception handling.
11939         * riscv-tdep.c: Use C++ exception handling.
11940         * remote.c: Use C++ exception handling.
11941         * remote-fileio.c: Use C++ exception handling.
11942         * record-full.c: Use C++ exception handling.
11943         * record-btrace.c: Use C++ exception handling.
11944         * python/python.c: Use C++ exception handling.
11945         * python/py-value.c: Use C++ exception handling.
11946         * python/py-utils.c: Use C++ exception handling.
11947         * python/py-unwind.c: Use C++ exception handling.
11948         * python/py-type.c: Use C++ exception handling.
11949         * python/py-symbol.c: Use C++ exception handling.
11950         * python/py-record.c: Use C++ exception handling.
11951         * python/py-record-btrace.c: Use C++ exception handling.
11952         * python/py-progspace.c: Use C++ exception handling.
11953         * python/py-prettyprint.c: Use C++ exception handling.
11954         * python/py-param.c: Use C++ exception handling.
11955         * python/py-objfile.c: Use C++ exception handling.
11956         * python/py-linetable.c: Use C++ exception handling.
11957         * python/py-lazy-string.c: Use C++ exception handling.
11958         * python/py-infthread.c: Use C++ exception handling.
11959         * python/py-inferior.c: Use C++ exception handling.
11960         * python/py-gdb-readline.c: Use C++ exception handling.
11961         * python/py-framefilter.c: Use C++ exception handling.
11962         * python/py-frame.c: Use C++ exception handling.
11963         * python/py-finishbreakpoint.c: Use C++ exception handling.
11964         * python/py-cmd.c: Use C++ exception handling.
11965         * python/py-breakpoint.c: Use C++ exception handling.
11966         * python/py-arch.c: Use C++ exception handling.
11967         * printcmd.c: Use C++ exception handling.
11968         * ppc-linux-tdep.c: Use C++ exception handling.
11969         * parse.c: Use C++ exception handling.
11970         * p-valprint.c: Use C++ exception handling.
11971         * objc-lang.c: Use C++ exception handling.
11972         * mi/mi-main.c: Use C++ exception handling.
11973         * mi/mi-interp.c: Use C++ exception handling.
11974         * mi/mi-cmd-stack.c: Use C++ exception handling.
11975         * mi/mi-cmd-break.c: Use C++ exception handling.
11976         * main.c: Use C++ exception handling.
11977         * linux-thread-db.c: Use C++ exception handling.
11978         * linux-tdep.c: Use C++ exception handling.
11979         * linux-nat.c: Use C++ exception handling.
11980         * linux-fork.c: Use C++ exception handling.
11981         * linespec.c: Use C++ exception handling.
11982         * language.c: Use C++ exception handling.
11983         * jit.c: Use C++ exception handling.
11984         * infrun.c: Use C++ exception handling.
11985         * infcmd.c: Use C++ exception handling.
11986         * infcall.c: Use C++ exception handling.
11987         * inf-loop.c: Use C++ exception handling.
11988         * i386-tdep.c: Use C++ exception handling.
11989         * i386-linux-tdep.c: Use C++ exception handling.
11990         * guile/scm-value.c: Use C++ exception handling.
11991         * guile/scm-type.c: Use C++ exception handling.
11992         * guile/scm-symtab.c: Use C++ exception handling.
11993         * guile/scm-symbol.c: Use C++ exception handling.
11994         * guile/scm-pretty-print.c: Use C++ exception handling.
11995         * guile/scm-ports.c: Use C++ exception handling.
11996         * guile/scm-param.c: Use C++ exception handling.
11997         * guile/scm-math.c: Use C++ exception handling.
11998         * guile/scm-lazy-string.c: Use C++ exception handling.
11999         * guile/scm-frame.c: Use C++ exception handling.
12000         * guile/scm-disasm.c: Use C++ exception handling.
12001         * guile/scm-cmd.c: Use C++ exception handling.
12002         * guile/scm-breakpoint.c: Use C++ exception handling.
12003         * guile/scm-block.c: Use C++ exception handling.
12004         * guile/guile-internal.h: Use C++ exception handling.
12005         * gnu-v3-abi.c: Use C++ exception handling.
12006         * gdbtypes.c: Use C++ exception handling.
12007         * frame.c: Use C++ exception handling.
12008         * frame-unwind.c: Use C++ exception handling.
12009         * fbsd-tdep.c: Use C++ exception handling.
12010         * f-valprint.c: Use C++ exception handling.
12011         * exec.c: Use C++ exception handling.
12012         * event-top.c: Use C++ exception handling.
12013         * event-loop.c: Use C++ exception handling.
12014         * eval.c: Use C++ exception handling.
12015         * dwarf2read.c: Use C++ exception handling.
12016         * dwarf2loc.c: Use C++ exception handling.
12017         * dwarf2-frame.c: Use C++ exception handling.
12018         * dwarf2-frame-tailcall.c: Use C++ exception handling.
12019         * dwarf-index-write.c: Use C++ exception handling.
12020         * dwarf-index-cache.c: Use C++ exception handling.
12021         * dtrace-probe.c: Use C++ exception handling.
12022         * disasm-selftests.c: Use C++ exception handling.
12023         * darwin-nat.c: Use C++ exception handling.
12024         * cp-valprint.c: Use C++ exception handling.
12025         * cp-support.c: Use C++ exception handling.
12026         * cp-abi.c: Use C++ exception handling.
12027         * corelow.c: Use C++ exception handling.
12028         * completer.c: Use C++ exception handling.
12029         * compile/compile-object-run.c: Use C++ exception handling.
12030         * compile/compile-object-load.c: Use C++ exception handling.
12031         * compile/compile-cplus-symbols.c: Use C++ exception handling.
12032         * compile/compile-c-symbols.c: Use C++ exception handling.
12033         * common/selftest.c: Use C++ exception handling.
12034         * common/new-op.c: Use C++ exception handling.
12035         * cli/cli-script.c: Use C++ exception handling.
12036         * cli/cli-interp.c: Use C++ exception handling.
12037         * cli/cli-cmds.c: Use C++ exception handling.
12038         * c-varobj.c: Use C++ exception handling.
12039         * btrace.c: Use C++ exception handling.
12040         * breakpoint.c: Use C++ exception handling.
12041         * break-catch-throw.c: Use C++ exception handling.
12042         * arch-utils.c: Use C++ exception handling.
12043         * amd64-tdep.c: Use C++ exception handling.
12044         * ada-valprint.c: Use C++ exception handling.
12045         * ada-typeprint.c: Use C++ exception handling.
12046         * ada-lang.c: Use C++ exception handling.
12047         * aarch64-tdep.c: Use C++ exception handling.
12048
12049 2019-04-08  Tom Tromey  <tom@tromey.com>
12050
12051         * xml-support.c (gdb_xml_parser::parse): Update.
12052         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12053         * value.c (show_convenience): Update.
12054         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12055         (test_parse_flags_qcs): Update.
12056         * thread.c (thr_try_catch_cmd): Update.
12057         * target.c (target_translate_tls_address): Update.
12058         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12059         (info_frame_command_core, frame_apply_command_count): Update.
12060         * rust-exp.y (rust_lex_exception_test): Update.
12061         * riscv-tdep.c (riscv_print_one_register_info): Update.
12062         * remote.c (remote_target::enable_btrace): Update.
12063         * record-btrace.c (record_btrace_enable_warn): Update.
12064         * python/py-utils.c (gdbpy_convert_exception): Update.
12065         * printcmd.c (do_one_display, print_variable_and_value): Update.
12066         * mi/mi-main.c (mi_print_exception): Update.
12067         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12068         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12069         * linux-nat.c (linux_nat_target::attach): Update.
12070         * linux-fork.c (class scoped_switch_fork_info): Update.
12071         * infrun.c (displaced_step_prepare): Update.
12072         * infcall.c (call_function_by_hand_dummy): Update.
12073         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12074         * gnu-v3-abi.c (print_one_vtable): Update.
12075         * frame.c (get_prev_frame_always): Update.
12076         * f-valprint.c (info_common_command_for_block): Update.
12077         * exec.c (try_open_exec_file): Update.
12078         * exceptions.c (print_exception, exception_print)
12079         (exception_fprintf, exception_print_same): Update.
12080         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12081         * dwarf-index-cache.c (index_cache::store)
12082         (index_cache::lookup_gdb_index): Update.
12083         * darwin-nat.c (maybe_cache_shell): Update.
12084         * cp-valprint.c (cp_print_value_fields): Update.
12085         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12086         (gcc_cplus_symbol_address): Update.
12087         * compile/compile-c-symbols.c (gcc_convert_symbol)
12088         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12089         * common/selftest.c: Update.
12090         * common/common-exceptions.h (struct gdb_exception) <message>: Now
12091         a std::string.
12092         (exception_try_scope_entry, exception_try_scope_exit): Don't
12093         declare.
12094         (struct exception_try_scope): Remove.
12095         (TRY): Don't use exception_try_scope.
12096         (struct gdb_exception): Add constructor, operator=.
12097         <what>: New method.
12098         (struct gdb_exception_RETURN_MASK_ALL)
12099         (struct gdb_exception_RETURN_MASK_ERROR)
12100         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12101         (struct gdb_quit_bad_alloc): Update.
12102         * common/common-exceptions.c (exception_none): Change
12103         initializer.
12104         (struct catcher) <state, exception>: Initialize inline.
12105         <prev>: Remove member.
12106         (current_catcher): Remove.
12107         (catchers): New global.
12108         (exceptions_state_mc_init): Simplify.
12109         (catcher_pop): Remove.
12110         (exceptions_state_mc, exceptions_state_mc_catch): Update.
12111         (try_scope_depth, exception_try_scope_entry)
12112         (exception_try_scope_exit): Remove.
12113         (throw_exception_sjlj): Update.
12114         (exception_messages, exception_messages_size): Remove.
12115         (throw_it): Simplify.
12116         (gdb_exception_sliced_copy): Remove.
12117         (throw_exception_cxx): Update.
12118         * cli/cli-script.c (script_from_file): Update.
12119         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12120         Update.
12121         * ada-valprint.c (ada_val_print): Update.
12122         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12123         (create_excep_cond_exprs): Update.
12124
12125 2019-04-08  Tom Tromey  <tom@tromey.com>
12126
12127         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12128         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12129         (TRY, CATCH, END_CATCH): Remove some definitions.
12130         * common/common-exceptions.c: Don't use GDB_XCPT.
12131         (catcher_list_size): Remove.
12132         (throw_exception, throw_it): Simplify.
12133
12134 2019-04-05  Tom Tromey  <tom@tromey.com>
12135
12136         Revert the header-sorting patch.
12137         * ft32-tdep.c: Revert.
12138         * frv-tdep.c: Revert.
12139         * frv-linux-tdep.c: Revert.
12140         * frame.c: Revert.
12141         * frame-unwind.c: Revert.
12142         * frame-base.c: Revert.
12143         * fork-child.c: Revert.
12144         * findvar.c: Revert.
12145         * findcmd.c: Revert.
12146         * filesystem.c: Revert.
12147         * filename-seen-cache.h: Revert.
12148         * filename-seen-cache.c: Revert.
12149         * fbsd-tdep.c: Revert.
12150         * fbsd-nat.h: Revert.
12151         * fbsd-nat.c: Revert.
12152         * f-valprint.c: Revert.
12153         * f-typeprint.c: Revert.
12154         * f-lang.c: Revert.
12155         * extension.h: Revert.
12156         * extension.c: Revert.
12157         * extension-priv.h: Revert.
12158         * expprint.c: Revert.
12159         * exec.h: Revert.
12160         * exec.c: Revert.
12161         * exceptions.c: Revert.
12162         * event-top.c: Revert.
12163         * event-loop.c: Revert.
12164         * eval.c: Revert.
12165         * elfread.c: Revert.
12166         * dwarf2read.h: Revert.
12167         * dwarf2read.c: Revert.
12168         * dwarf2loc.c: Revert.
12169         * dwarf2expr.h: Revert.
12170         * dwarf2expr.c: Revert.
12171         * dwarf2-frame.c: Revert.
12172         * dwarf2-frame-tailcall.c: Revert.
12173         * dwarf-index-write.h: Revert.
12174         * dwarf-index-write.c: Revert.
12175         * dwarf-index-common.c: Revert.
12176         * dwarf-index-cache.h: Revert.
12177         * dwarf-index-cache.c: Revert.
12178         * dummy-frame.c: Revert.
12179         * dtrace-probe.c: Revert.
12180         * disasm.h: Revert.
12181         * disasm.c: Revert.
12182         * disasm-selftests.c: Revert.
12183         * dictionary.c: Revert.
12184         * dicos-tdep.c: Revert.
12185         * demangle.c: Revert.
12186         * dcache.h: Revert.
12187         * dcache.c: Revert.
12188         * darwin-nat.h: Revert.
12189         * darwin-nat.c: Revert.
12190         * darwin-nat-info.c: Revert.
12191         * d-valprint.c: Revert.
12192         * d-namespace.c: Revert.
12193         * d-lang.c: Revert.
12194         * ctf.c: Revert.
12195         * csky-tdep.c: Revert.
12196         * csky-linux-tdep.c: Revert.
12197         * cris-tdep.c: Revert.
12198         * cris-linux-tdep.c: Revert.
12199         * cp-valprint.c: Revert.
12200         * cp-support.c: Revert.
12201         * cp-namespace.c: Revert.
12202         * cp-abi.c: Revert.
12203         * corelow.c: Revert.
12204         * corefile.c: Revert.
12205         * continuations.c: Revert.
12206         * completer.h: Revert.
12207         * completer.c: Revert.
12208         * complaints.c: Revert.
12209         * coffread.c: Revert.
12210         * coff-pe-read.c: Revert.
12211         * cli-out.h: Revert.
12212         * cli-out.c: Revert.
12213         * charset.c: Revert.
12214         * c-varobj.c: Revert.
12215         * c-valprint.c: Revert.
12216         * c-typeprint.c: Revert.
12217         * c-lang.c: Revert.
12218         * buildsym.c: Revert.
12219         * buildsym-legacy.c: Revert.
12220         * build-id.h: Revert.
12221         * build-id.c: Revert.
12222         * btrace.c: Revert.
12223         * bsd-uthread.c: Revert.
12224         * breakpoint.h: Revert.
12225         * breakpoint.c: Revert.
12226         * break-catch-throw.c: Revert.
12227         * break-catch-syscall.c: Revert.
12228         * break-catch-sig.c: Revert.
12229         * blockframe.c: Revert.
12230         * block.c: Revert.
12231         * bfin-tdep.c: Revert.
12232         * bfin-linux-tdep.c: Revert.
12233         * bfd-target.c: Revert.
12234         * bcache.c: Revert.
12235         * ax-general.c: Revert.
12236         * ax-gdb.h: Revert.
12237         * ax-gdb.c: Revert.
12238         * avr-tdep.c: Revert.
12239         * auxv.c: Revert.
12240         * auto-load.c: Revert.
12241         * arm-wince-tdep.c: Revert.
12242         * arm-tdep.c: Revert.
12243         * arm-symbian-tdep.c: Revert.
12244         * arm-pikeos-tdep.c: Revert.
12245         * arm-obsd-tdep.c: Revert.
12246         * arm-nbsd-tdep.c: Revert.
12247         * arm-nbsd-nat.c: Revert.
12248         * arm-linux-tdep.c: Revert.
12249         * arm-linux-nat.c: Revert.
12250         * arm-fbsd-tdep.c: Revert.
12251         * arm-fbsd-nat.c: Revert.
12252         * arm-bsd-tdep.c: Revert.
12253         * arch-utils.c: Revert.
12254         * arc-tdep.c: Revert.
12255         * arc-newlib-tdep.c: Revert.
12256         * annotate.h: Revert.
12257         * annotate.c: Revert.
12258         * amd64-windows-tdep.c: Revert.
12259         * amd64-windows-nat.c: Revert.
12260         * amd64-tdep.c: Revert.
12261         * amd64-sol2-tdep.c: Revert.
12262         * amd64-obsd-tdep.c: Revert.
12263         * amd64-obsd-nat.c: Revert.
12264         * amd64-nbsd-tdep.c: Revert.
12265         * amd64-nbsd-nat.c: Revert.
12266         * amd64-nat.c: Revert.
12267         * amd64-linux-tdep.c: Revert.
12268         * amd64-linux-nat.c: Revert.
12269         * amd64-fbsd-tdep.c: Revert.
12270         * amd64-fbsd-nat.c: Revert.
12271         * amd64-dicos-tdep.c: Revert.
12272         * amd64-darwin-tdep.c: Revert.
12273         * amd64-bsd-nat.c: Revert.
12274         * alpha-tdep.c: Revert.
12275         * alpha-obsd-tdep.c: Revert.
12276         * alpha-nbsd-tdep.c: Revert.
12277         * alpha-mdebug-tdep.c: Revert.
12278         * alpha-linux-tdep.c: Revert.
12279         * alpha-linux-nat.c: Revert.
12280         * alpha-bsd-tdep.c: Revert.
12281         * alpha-bsd-nat.c: Revert.
12282         * aix-thread.c: Revert.
12283         * agent.c: Revert.
12284         * addrmap.c: Revert.
12285         * ada-varobj.c: Revert.
12286         * ada-valprint.c: Revert.
12287         * ada-typeprint.c: Revert.
12288         * ada-tasks.c: Revert.
12289         * ada-lang.c: Revert.
12290         * aarch64-tdep.c: Revert.
12291         * aarch64-ravenscar-thread.c: Revert.
12292         * aarch64-newlib-tdep.c: Revert.
12293         * aarch64-linux-tdep.c: Revert.
12294         * aarch64-linux-nat.c: Revert.
12295         * aarch64-fbsd-tdep.c: Revert.
12296         * aarch64-fbsd-nat.c: Revert.
12297         * aarch32-linux-nat.c: Revert.
12298
12299 2019-04-05  Tom Tromey  <tom@tromey.com>
12300
12301         * ft32-tdep.c: Sort headers.
12302         * frv-tdep.c: Sort headers.
12303         * frv-linux-tdep.c: Sort headers.
12304         * frame.c: Sort headers.
12305         * frame-unwind.c: Sort headers.
12306         * frame-base.c: Sort headers.
12307         * fork-child.c: Sort headers.
12308         * findvar.c: Sort headers.
12309         * findcmd.c: Sort headers.
12310         * filesystem.c: Sort headers.
12311         * filename-seen-cache.h: Sort headers.
12312         * filename-seen-cache.c: Sort headers.
12313         * fbsd-tdep.c: Sort headers.
12314         * fbsd-nat.h: Sort headers.
12315         * fbsd-nat.c: Sort headers.
12316         * f-valprint.c: Sort headers.
12317         * f-typeprint.c: Sort headers.
12318         * f-lang.c: Sort headers.
12319         * extension.h: Sort headers.
12320         * extension.c: Sort headers.
12321         * extension-priv.h: Sort headers.
12322         * expprint.c: Sort headers.
12323         * exec.h: Sort headers.
12324         * exec.c: Sort headers.
12325         * exceptions.c: Sort headers.
12326         * event-top.c: Sort headers.
12327         * event-loop.c: Sort headers.
12328         * eval.c: Sort headers.
12329         * elfread.c: Sort headers.
12330         * dwarf2read.h: Sort headers.
12331         * dwarf2read.c: Sort headers.
12332         * dwarf2loc.c: Sort headers.
12333         * dwarf2expr.h: Sort headers.
12334         * dwarf2expr.c: Sort headers.
12335         * dwarf2-frame.c: Sort headers.
12336         * dwarf2-frame-tailcall.c: Sort headers.
12337         * dwarf-index-write.h: Sort headers.
12338         * dwarf-index-write.c: Sort headers.
12339         * dwarf-index-common.c: Sort headers.
12340         * dwarf-index-cache.h: Sort headers.
12341         * dwarf-index-cache.c: Sort headers.
12342         * dummy-frame.c: Sort headers.
12343         * dtrace-probe.c: Sort headers.
12344         * disasm.h: Sort headers.
12345         * disasm.c: Sort headers.
12346         * disasm-selftests.c: Sort headers.
12347         * dictionary.c: Sort headers.
12348         * dicos-tdep.c: Sort headers.
12349         * demangle.c: Sort headers.
12350         * dcache.h: Sort headers.
12351         * dcache.c: Sort headers.
12352         * darwin-nat.h: Sort headers.
12353         * darwin-nat.c: Sort headers.
12354         * darwin-nat-info.c: Sort headers.
12355         * d-valprint.c: Sort headers.
12356         * d-namespace.c: Sort headers.
12357         * d-lang.c: Sort headers.
12358         * ctf.c: Sort headers.
12359         * csky-tdep.c: Sort headers.
12360         * csky-linux-tdep.c: Sort headers.
12361         * cris-tdep.c: Sort headers.
12362         * cris-linux-tdep.c: Sort headers.
12363         * cp-valprint.c: Sort headers.
12364         * cp-support.c: Sort headers.
12365         * cp-namespace.c: Sort headers.
12366         * cp-abi.c: Sort headers.
12367         * corelow.c: Sort headers.
12368         * corefile.c: Sort headers.
12369         * continuations.c: Sort headers.
12370         * completer.h: Sort headers.
12371         * completer.c: Sort headers.
12372         * complaints.c: Sort headers.
12373         * coffread.c: Sort headers.
12374         * coff-pe-read.c: Sort headers.
12375         * cli-out.h: Sort headers.
12376         * cli-out.c: Sort headers.
12377         * charset.c: Sort headers.
12378         * c-varobj.c: Sort headers.
12379         * c-valprint.c: Sort headers.
12380         * c-typeprint.c: Sort headers.
12381         * c-lang.c: Sort headers.
12382         * buildsym.c: Sort headers.
12383         * buildsym-legacy.c: Sort headers.
12384         * build-id.h: Sort headers.
12385         * build-id.c: Sort headers.
12386         * btrace.c: Sort headers.
12387         * bsd-uthread.c: Sort headers.
12388         * breakpoint.h: Sort headers.
12389         * breakpoint.c: Sort headers.
12390         * break-catch-throw.c: Sort headers.
12391         * break-catch-syscall.c: Sort headers.
12392         * break-catch-sig.c: Sort headers.
12393         * blockframe.c: Sort headers.
12394         * block.c: Sort headers.
12395         * bfin-tdep.c: Sort headers.
12396         * bfin-linux-tdep.c: Sort headers.
12397         * bfd-target.c: Sort headers.
12398         * bcache.c: Sort headers.
12399         * ax-general.c: Sort headers.
12400         * ax-gdb.h: Sort headers.
12401         * ax-gdb.c: Sort headers.
12402         * avr-tdep.c: Sort headers.
12403         * auxv.c: Sort headers.
12404         * auto-load.c: Sort headers.
12405         * arm-wince-tdep.c: Sort headers.
12406         * arm-tdep.c: Sort headers.
12407         * arm-symbian-tdep.c: Sort headers.
12408         * arm-pikeos-tdep.c: Sort headers.
12409         * arm-obsd-tdep.c: Sort headers.
12410         * arm-nbsd-tdep.c: Sort headers.
12411         * arm-nbsd-nat.c: Sort headers.
12412         * arm-linux-tdep.c: Sort headers.
12413         * arm-linux-nat.c: Sort headers.
12414         * arm-fbsd-tdep.c: Sort headers.
12415         * arm-fbsd-nat.c: Sort headers.
12416         * arm-bsd-tdep.c: Sort headers.
12417         * arch-utils.c: Sort headers.
12418         * arc-tdep.c: Sort headers.
12419         * arc-newlib-tdep.c: Sort headers.
12420         * annotate.h: Sort headers.
12421         * annotate.c: Sort headers.
12422         * amd64-windows-tdep.c: Sort headers.
12423         * amd64-windows-nat.c: Sort headers.
12424         * amd64-tdep.c: Sort headers.
12425         * amd64-sol2-tdep.c: Sort headers.
12426         * amd64-obsd-tdep.c: Sort headers.
12427         * amd64-obsd-nat.c: Sort headers.
12428         * amd64-nbsd-tdep.c: Sort headers.
12429         * amd64-nbsd-nat.c: Sort headers.
12430         * amd64-nat.c: Sort headers.
12431         * amd64-linux-tdep.c: Sort headers.
12432         * amd64-linux-nat.c: Sort headers.
12433         * amd64-fbsd-tdep.c: Sort headers.
12434         * amd64-fbsd-nat.c: Sort headers.
12435         * amd64-dicos-tdep.c: Sort headers.
12436         * amd64-darwin-tdep.c: Sort headers.
12437         * amd64-bsd-nat.c: Sort headers.
12438         * alpha-tdep.c: Sort headers.
12439         * alpha-obsd-tdep.c: Sort headers.
12440         * alpha-nbsd-tdep.c: Sort headers.
12441         * alpha-mdebug-tdep.c: Sort headers.
12442         * alpha-linux-tdep.c: Sort headers.
12443         * alpha-linux-nat.c: Sort headers.
12444         * alpha-bsd-tdep.c: Sort headers.
12445         * alpha-bsd-nat.c: Sort headers.
12446         * aix-thread.c: Sort headers.
12447         * agent.c: Sort headers.
12448         * addrmap.c: Sort headers.
12449         * ada-varobj.c: Sort headers.
12450         * ada-valprint.c: Sort headers.
12451         * ada-typeprint.c: Sort headers.
12452         * ada-tasks.c: Sort headers.
12453         * ada-lang.c: Sort headers.
12454         * aarch64-tdep.c: Sort headers.
12455         * aarch64-ravenscar-thread.c: Sort headers.
12456         * aarch64-newlib-tdep.c: Sort headers.
12457         * aarch64-linux-tdep.c: Sort headers.
12458         * aarch64-linux-nat.c: Sort headers.
12459         * aarch64-fbsd-tdep.c: Sort headers.
12460         * aarch64-fbsd-nat.c: Sort headers.
12461         * aarch32-linux-nat.c: Sort headers.
12462
12463 2019-04-04  Tom Tromey  <tom@tromey.com>
12464
12465         * varobj.c (varobj_create): Update.
12466         * rust-exp.y (struct rust_parser) <update_innermost_block,
12467         lookup_symbol>: New methods.
12468         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12469         Rename.
12470         (rust_parser::rust_lookup_type)
12471         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12472         * printcmd.c (display_command, do_one_display): Update.
12473         * parser-defs.h (struct parser_state) <parser_state>: Add
12474         "tracker" parameter.
12475         (block_tracker): New member.
12476         (class innermost_block_tracker) <innermost_block_tracker>: Add
12477         "types" parameter.
12478         <reset>: Remove method.
12479         (innermost_block): Don't declare.
12480         (null_post_parser): Update.
12481         * parse.c (innermost_block): Remove global.
12482         (write_dollar_variable): Update.
12483         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12484         Remove "tracker_types" parameter.
12485         (parse_expression): Add "tracker" parameter.
12486         (parse_expression_for_completion): Update.
12487         (null_post_parser): Add "tracker" parameter.
12488         * p-exp.y: Update rules.
12489         * m2-exp.y: Update rules.
12490         * language.h (struct language_defn) <la_post_parser>: Add
12491         "tracker" parameter.
12492         * go-exp.y: Update rules.
12493         * f-exp.y: Update rules.
12494         * expression.h (parse_expression, parse_exp_1): Add "tracker"
12495         parameter.
12496         * d-exp.y: Update rules.
12497         * c-exp.y: Update rules.
12498         * breakpoint.c (set_breakpoint_condition): Create an
12499         innermost_block_tracker.
12500         (watch_command_1): Likewise.
12501         * ada-lang.c (resolve): Add "tracker" parameter.
12502         (resolve_subexp): Likewise.
12503         * ada-exp.y (write_var_from_sym): Update.
12504
12505 2019-04-04  Tom Tromey  <tom@tromey.com>
12506
12507         * type-stack.h: New file.
12508         * type-stack.c: New file.
12509         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12510         type-stack.h.
12511         (insert_into_type_stack, insert_type, push_type, push_type_int)
12512         (insert_type_address_space, pop_type, pop_type_int)
12513         (pop_typelist, pop_type_stack, append_type_stack)
12514         (push_type_stack, get_type_stack, push_typelist)
12515         (follow_type_instance_flags, follow_types): Don't declare.
12516         * parse.c (type_stack): Remove global.
12517         (parse_exp_in_context): Update.
12518         (insert_into_type_stack, insert_type, push_type, push_type_int)
12519         (insert_type_address_space, pop_type, pop_type_int)
12520         (pop_typelist, pop_type_stack, append_type_stack)
12521         (push_type_stack, get_type_stack, push_typelist)
12522         (follow_type_instance_flags, follow_types): Remove (moved to
12523         type-stack.c).
12524         * f-exp.y (type_stack): New global.
12525         Update rules.
12526         (push_kind_type, f_parse): Update.
12527         * d-exp.y (type_stack): New global.
12528         Update rules.
12529         (d_parse): Update.
12530         * c-exp.y (struct c_parse_state) <type_stack>: New member.
12531         Update rules.
12532         * Makefile.in (COMMON_SFILES): Add type-stack.c.
12533         (HFILES_NO_SRCDIR): Add type-stack.h.
12534
12535 2019-04-04  Tom Tromey  <tom@tromey.com>
12536
12537         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12538         (rust_parser::convert_ast_to_expression, rust_parse)
12539         (rust_lex_test_completion, rust_lex_tests): Update.
12540         * parser-defs.h (struct expr_completion_state): New.
12541         (struct parser_state) <parser_state>: Add completion parameter.
12542         <mark_struct_expression, mark_completion_tag>: New methods.
12543         <parse_completion, m_completion_state>: New members.
12544         (prefixify_expression, null_post_parser): Update.
12545         (mark_struct_expression, mark_completion_tag): Don't declare.
12546         * parse.c (parse_completion, expout_last_struct)
12547         (expout_tag_completion_type, expout_completion_name): Remove
12548         globals.
12549         (parser_state::mark_struct_expression)
12550         (parser_state::mark_completion_tag): Now methods.
12551         (prefixify_expression): Add last_struct parameter.
12552         (prefixify_subexp): Likewise.
12553         (parse_exp_1): Update.
12554         (parse_exp_in_context): Add cstate parameter.  Update.
12555         (parse_expression_for_completion): Create an
12556         expr_completion_state.
12557         (null_post_parser): Add "completion" parameter.
12558         * p-exp.y: Update rules.
12559         (yylex): Update.
12560         * language.h (struct language_defn) <la_post_parser>: Add
12561         "completing" parameter.
12562         * go-exp.y: Update rules.
12563         (lex_one_token): Update.
12564         * expression.h (parse_completion): Don't declare.
12565         * d-exp.y: Update rules.
12566         (lex_one_token): Update rules.
12567         * c-exp.y: Update rules.
12568         (lex_one_token): Update.
12569         * ada-lang.c (resolve): Add "parse_completion" parameter.
12570         (resolve_subexp): Likewise.
12571         (ada_resolve_function): Likewise.
12572
12573 2019-04-04  Tom Tromey  <tom@tromey.com>
12574
12575         * parser-defs.h (struct parser_state) <start_arglist,
12576         end_arglist>: New methods.
12577         <arglist_len, m_funcall_chain>: New members.
12578         (arglist_len, start_arglist, end_arglist): Don't declare.
12579         * parse.c (arglist_len, funcall_chain): Remove global.
12580         (start_arglist, end_arglist): Remove functions.
12581         (parse_exp_in_context): Update.
12582         * p-exp.y: Update rules.
12583         * m2-exp.y: Update rules.
12584         * go-exp.y: Update rules.
12585         * f-exp.y: Update rules.
12586         * d-exp.y: Update rules.
12587         * c-exp.y: Update rules.
12588
12589 2019-04-04  Tom Tromey  <tom@tromey.com>
12590
12591         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12592         lex_operator, push_back>: New methods.
12593         Update all rules.
12594         (rust_parser::lex_hex, lex_escape): Rename and update.
12595         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12596         (rust_parser::lex_operator): Rename and update.
12597         (rust_parser::lex_number, rustyylex, rustyyerror)
12598         (rust_lex_test_init, rust_lex_test_sequence)
12599         (rust_lex_test_push_back, rust_lex_tests): Update.
12600         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12601         parameter.
12602         <lexptr, prev_lexptr>: New members.
12603         (lexptr, prev_lexptr): Don't declare.
12604         * parse.c (lexptr, prev_lexptr): Remove globals.
12605         (parse_exp_in_context): Update.
12606         * p-exp.y (yylex, yyerror): Update.
12607         * m2-exp.y (parse_number, yylex, yyerror): Update.
12608         * go-exp.y (lex_one_token, yyerror): Update.
12609         * f-exp.y (match_string_literal, yylex, yyerror): Update.
12610         * d-exp.y (lex_one_token, yyerror): Update.
12611         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12612         (lex_one_token, yyerror): Update.
12613         * ada-lex.l (YY_INPUT): Update.
12614         (rewind_to_char): Update.
12615         * ada-exp.y (yyerror): Update.
12616
12617 2019-04-04  Tom Tromey  <tom@tromey.com>
12618
12619         * rust-exp.y (rustyylex, rust_lex_tests): Update.
12620         * parser-defs.h (struct parser_state) <parser_state>: Add new
12621         parameter.
12622         <comma_terminates>: New member.
12623         (comma_terminates): Don't declare global.
12624         * parse.c (comma_terminates): Remove global.
12625         (parse_exp_in_context): Update.
12626         * p-exp.y (yylex): Update.
12627         * m2-exp.y (yylex): Update.
12628         * go-exp.y (lex_one_token): Update.
12629         * f-exp.y (yylex): Update.
12630         * d-exp.y (lex_one_token): Update.
12631         * c-exp.y (lex_one_token): Update.
12632         * ada-lex.l: Update.
12633
12634 2019-04-04  Tom Tromey  <tom@tromey.com>
12635
12636         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12637         (rustyylex, rust_lex_test_init, rust_lex_test_one)
12638         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12639         * parser-defs.h (paren_depth): Don't declare.
12640         * parse.c (paren_depth): Remove global.
12641         (parse_exp_in_context): Update.
12642         * p-exp.y (paren_depth): New global.
12643         (pascal_parse): Initialize it.
12644         * m2-exp.y (paren_depth): New global.
12645         (m2_parse): Initialize it.
12646         * go-exp.y (paren_depth): New global.
12647         (go_parse): Initialize it.
12648         * f-exp.y (paren_depth): New global.
12649         (f_parse): Initialize it.
12650         * d-exp.y (paren_depth): New global.
12651         (d_parse): Initialize it.
12652         * c-exp.y (paren_depth): New global.
12653         (c_parse): Initialize it.
12654         * ada-lex.l (paren_depth): New global.
12655         (lexer_init): Initialize it.
12656
12657 2019-04-04  Tom Tromey  <tom@tromey.com>
12658
12659         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12660         (rust_parser::convert_ast_to_type)
12661         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12662         * parser-defs.h (struct parser_state) <parser_state>: Add
12663         parameters.  Initialize new members.
12664         <expression_context_block, expression_context_pc>: New members.
12665         * parse.c (expression_context_block, expression_context_pc):
12666         Remove globals.
12667         (parse_exp_in_context): Update.
12668         * p-exp.y: Update all rules.
12669         (yylex): Update.
12670         * m2-exp.y: Update all rules.
12671         (yylex): Update.
12672         * go-exp.y (yylex): Update.
12673         * f-exp.y (yylex): Update.
12674         * d-exp.y: Update all rules.
12675         (yylex): Update.
12676         * c-exp.y: Update all rules.
12677         (lex_one_token, classify_name, yylex, c_parse): Update.
12678         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12679
12680 2019-04-04  Tom Tromey  <tom@tromey.com>
12681
12682         * gdbarch.h, gdbarch.c: Rebuild.
12683         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12684         * stap-probe.h:
12685         (struct stap_parse_info): Replace "parser_state" with
12686         "expr_builder".
12687         * parser-defs.h (struct expr_builder): Rename from "parser_state".
12688         (parser_state): New class.
12689         * parse.c (expr_builder): Rename.
12690         (expr_builder::release): Rename.
12691         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12692         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12693         (write_exp_elt_longcst, write_exp_elt_floatcst)
12694         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12695         (write_exp_string_vector, write_exp_bitstring)
12696         (write_exp_msymbol, mark_struct_expression)
12697         (write_dollar_variable)
12698         (insert_type_address_space, increase_expout_size): Replace
12699         "parser_state" with "expr_builder".
12700         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12701         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12702         "parser_state" with "expr_builder".
12703
12704 2019-04-04  Tom Tromey  <tom@tromey.com>
12705
12706         * rust-exp.y: Replace "parse_language" with method call.
12707         * p-exp.y:
12708         (yylex): Replace "parse_language" with method call.
12709         * m2-exp.y:
12710         (yylex): Replace "parse_language" with method call.
12711         * go-exp.y (classify_name): Replace "parse_language" with method
12712         call.
12713         * f-exp.y (yylex): Replace "parse_language" with method call.
12714         * d-exp.y (lex_one_token): Replace "parse_language" with method
12715         call.
12716         * c-exp.y:
12717         (lex_one_token, classify_name, yylex): Replace "parse_language"
12718         with method call.
12719         * ada-exp.y (find_primitive_type, type_char)
12720         (type_system_address): Replace "parse_language" with method call.
12721
12722 2019-04-04  Tom Tromey  <tom@tromey.com>
12723
12724         * rust-exp.y: Replace "parse_gdbarch" with method call.
12725         * parse.c (write_dollar_variable, insert_type_address_space):
12726         Replace "parse_gdbarch" with method call.
12727         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12728         call.
12729         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12730         call.
12731         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12732         "parse_gdbarch" with method call.
12733         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12734         with method call.
12735         * f-exp.y (parse_type, parse_f_type, yylex): Replace
12736         "parse_gdbarch" with method call.
12737         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12738         "parse_gdbarch" with method call.
12739         * c-exp.y (parse_type, parse_number, classify_name): Replace
12740         "parse_gdbarch" with method call.
12741         * ada-lex.l: Replace "parse_gdbarch" with method call.
12742         * ada-exp.y (parse_type, find_primitive_type, type_char)
12743         (type_system_address): Replace "parse_gdbarch" with method call.
12744
12745 2019-04-04  Tom Tromey  <tom@tromey.com>
12746
12747         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12748         * stap-probe.c (stap_parse_argument): Update.
12749         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12750         initial_size parameter.
12751         * rust-exp.y (rust_lex_tests): Update.
12752         * parse.c (parser_state): Update.
12753         (parse_exp_in_context): Update.
12754         * parser-defs.h (struct parser_state) <parser_state>: Remove
12755         "initial_size" parameter.
12756
12757 2019-04-04  Tom Tromey  <tom@tromey.com>
12758
12759         * parser-defs.h (increase_expout_size): Don't declare.
12760         * parse.c (increase_expout_size): Now static.
12761
12762 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
12763
12764         * gnu-nat.c (gnu_nat_target::wait): Fix
12765         target_waitstatus_to_string call.
12766
12767 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12768
12769         * eval.c (evaluate_subexp_standard): Handle internal functions
12770         during Fortran function call handling.
12771
12772 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12773
12774         * NEWS: Mention new internal functions.
12775         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12776         (read_base_type): Use dwarf2_init_complex_target_type.
12777         * value.c (creal_internal_fn): New function.
12778         (cimag_internal_fn): New function.
12779         (_initialize_values): Register new internal functions.
12780
12781 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12782
12783         * infrun.c (stop_all_threads): If debug_infrun, always
12784         trace the wait status after wait_one, using
12785         target_waitstatus_to_string and target_pid_to_str.
12786         (handle_inferior_event): Replace various trace of
12787         wait status kind by a single trace.
12788         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12789         wait status kind image by target_waitstatus_to_string.
12790         * target/waitstatus.c (target_waitstatus_to_string): Fix
12791         obsolete comment.
12792
12793 2019-04-01  Tom Tromey  <tromey@adacore.com>
12794
12795         PR symtab/23331:
12796         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12797
12798 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
12799             Pedro Alves  <palves@redhat.com>
12800
12801         * top.c (quit_force): Call 'finalize_values'.
12802         * value.c (finalize_values): New function.
12803         * value.h (finalize_values): Declare.
12804
12805 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
12806
12807         * NEWS: Announce $_gdb_major and $_gdb_minor.
12808
12809         * top.c (init_gdb_version_vars): New function.
12810         (gdb_init): Call init_gdb_version_vars.
12811
12812 2019-03-29  Tom Tromey  <tromey@adacore.com>
12813
12814         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
12815         help text.  Remove dead code.
12816
12817 2019-03-29  Keith Seitz  <keiths@redhat.com>
12818
12819         From Siddhesh Poyarekar:
12820         * f-lang.h (f77_get_upperbound): Return LONGEST.
12821         (f77_get_lowerbound): Likewise.
12822         * f-typeprint.c (f_type_print_varspec_suffix): Expand
12823         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
12824         print them.
12825         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
12826         plongest to format print it.
12827         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12828         (f77_get_upperbound): Likewise.
12829         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12830         LOWER_BOUND to LONGEST.
12831         (f77_create_arrayprint_offset_tbl): Likewise.
12832
12833 2019-03-29  Keith Seitz  <keiths@redhat.com>
12834
12835         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12836         %s/pulongest for TYPE_LENGTH instead of %d in format
12837         strings.
12838         * ada-typerint.c (ada_print_type): Likewise.
12839         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12840         * compile/compile-c-support.c (generate_register_struct): Likewise.
12841         * gdbtypes.c (recursive_dump_type): Likewise.
12842         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12843         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
12844         instead of %d in format strings.
12845         * riscv-tdep.c (riscv_type_alignment): Cast second argument
12846         to std::min to ULONGEST.
12847         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12848         instead of %d in format strings.
12849         * tracepoint.c (info_scope_command): Likewise.
12850         * typeprint.c (print_offset_data::update)
12851         (print_offset_data::finish): Likewise.
12852         * xtensa-tdep.c (xtensa_store_return_value)
12853         (xtensa_push_dummy_call): Likewise.
12854
12855 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
12856
12857         * windows-nat.c (display_selector): Fixed format specifications
12858         for 64-bit Cygwin.
12859
12860 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12861
12862         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12863
12864 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
12865
12866         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12867         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12868         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12869         (nios2_linux_init_abi): Install it.
12870
12871 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12872
12873         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12874
12875 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12876
12877         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12878
12879 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12880             Tom Tromey  <tromey@adacore.com>
12881
12882         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12883
12884 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
12885
12886         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12887         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12888         method to compute the bounds of range types. Also print "[evaluated]"
12889         if the bounds' values come from a dynamic evaluation.
12890
12891 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12892
12893         * cp-valprint.c (cp_print_value_fields): Don't print trailing
12894         whitespace when pretty printing is on.
12895
12896 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12897
12898         * ppc-linux-nat.c: Add include.
12899
12900 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12901
12902         * NEWS: Mention AArch64 Pointer Authentication.
12903
12904 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12905
12906         * arm-linux-nat.c: Add include.
12907
12908 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
12909
12910         * source-cache.c (source_cache::get_source_lines): Re-read
12911         fullname after calling open_source_file.
12912
12913 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
12914
12915         * NEWS: Mention TLS support for FreeBSD.
12916
12917 2019-03-25  Tom Tromey  <tromey@adacore.com>
12918
12919         * minsyms.c (BUNCH_SIZE): Update comment.
12920         (~minimal_symbol_reader): Remove old comment.
12921         (compact_minimal_symbols): Update comment.
12922         (minimal_symbol_reader::install): Remove old comment.  Update
12923         other comments.
12924
12925 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12926
12927         * s390-linux-nat.c: Add include.
12928
12929 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12930
12931         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12932         Call linux_get_hwcap.
12933         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12934         Likewise.
12935         (aarch64_linux_get_hwcap): Remove function.
12936         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12937         declaration.
12938         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12939         linux_get_hwcap.
12940         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12941         * linux-tdep.c (linux_get_hwcap): Add function.
12942         (linux_get_hwcap2): Likewise.
12943         * linux-tdep.h (linux_get_hwcap): Add declaration.
12944         (linux_get_hwcap2): Likewise.
12945         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12946         (ppc_linux_get_hwcap2): Likewise.
12947         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12948         linux_get_hwcap.
12949         (ppc_linux_nat_target::insert_watchpoint): Likewise.
12950         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12951         (ppc_linux_nat_target::read_description): Likewise.
12952         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12953         * s390-linux-nat.c: Likewise.
12954         * s390-linux-tdep.c (s390_core_read_description): Likewise.
12955
12956 2019-03-24  Tom Tromey  <tom@tromey.com>
12957
12958         * ada-lang.c (standard_lookup): Simplify initialization.
12959         (ada_lookup_symbol_nonlocal): Simplify return.
12960         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12961         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12962         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12963         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12964         initialization.
12965         * solib.c (solib_global_lookup): Simplify.
12966         * symtab.c (null_block_symbol): Remove.
12967         (symbol_cache_lookup): Simplify returns.
12968         (lookup_language_this): Simplify returns.
12969         (lookup_symbol_aux): Simplify return.
12970         (lookup_local_symbol): Simplify returns.
12971         (lookup_global_symbol_from_objfile): Simplify return.
12972         (lookup_symbol_in_objfile_symtabs)
12973         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12974         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12975         (lookup_static_symbol, lookup_global_symbol): Simplify return.
12976         * cp-namespace.c (cp_lookup_bare_symbol)
12977         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12978         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12979         (cp_lookup_nested_symbol): Don't use null_block_symbol.
12980         (cp_lookup_symbol_via_imports): Simplify initialization.
12981         (find_symbol_in_baseclass): Likewise.
12982         * symtab.h (null_block_symbol): Remove.
12983         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12984         (d_lookup_nested_symbol, d_lookup_symbol_imports)
12985         (d_lookup_symbol_module): Likewise.
12986         (find_symbol_in_baseclass): Simplify initialization.
12987
12988 2019-03-24  Tom Tromey  <tom@tromey.com>
12989
12990         * expression.h: Don't include symtab.h.
12991         (struct block): Forward declare.
12992
12993 2019-03-24  Tom Tromey  <tom@tromey.com>
12994
12995         * c-exp.y (typebase): Remove casts.
12996         * gdbtypes.c (lookup_unsigned_typename, )
12997         (lookup_signed_typename): Remove cast.
12998         * eval.c (parse_to_comma_and_eval): Remove cast.
12999         * parse.c (write_dollar_variable): Remove cast.
13000         * block.h (struct block) <superblock>: Now const.
13001         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13002         * psymtab.c (psym_map_matching_symbols): Make "block" const.
13003         (map_block): Make "block" const.
13004         * symfile.h (struct quick_symbol_functions)
13005         <map_matching_symbols>: Constify block argument to "callback".
13006         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13007         const.
13008         (find_pc_sect_compunit_symtab): Make "b" const.
13009         (find_symbol_at_address): Likewise.
13010         (search_symbols): Likewise.
13011         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13012         (dw2_debug_names_lookup_symbol): Likewise.
13013         (dw2_map_matching_symbols): Update.
13014         * p-valprint.c (pascal_val_print): Remove "block".
13015         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13016         (aux_add_nonlocal_symbols): Make "block" const.
13017         (resolve_subexp): Remove cast.
13018         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13019         const.
13020         (iterate_over_file_blocks): Likewise.
13021         * f-exp.y (%union) <bval>: Remove.
13022         * coffread.c (patch_opaque_types): Make "b" const.
13023         * spu-tdep.c (spu_catch_start): Make "block" const.
13024         * c-valprint.c (print_unpacked_pointer): Remove "block".
13025         * symmisc.c (dump_symtab_1): Make "b" const.
13026         (block_depth): Make "block" const.
13027         * d-exp.y (%union) <bval>: Remove.
13028         * cp-support.h (cp_lookup_rtti_type): Update.
13029         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13030         * psymtab.c (psym_lookup_symbol): Make "block" const.
13031         (maintenance_check_psymtabs): Make "b" const.
13032         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13033         (enumerate_locals, enumerate_args): Update.
13034         * python/py-symtab.c (stpy_global_block): Make "block" const.
13035         (stpy_static_block): Likewise.
13036         * inline-frame.c (block_starting_point_at): Make "new_block"
13037         const.
13038         * block.c (find_block_in_blockvector): Make return type const.
13039         (blockvector_for_pc_sect): Make "b" const.
13040         (find_block_in_blockvector): Make "b" const.
13041
13042 2019-03-23  Tom Tromey  <tom@tromey.com>
13043
13044         * varobj.c (varobj_create): Update.
13045         * symfile.c (clear_symtab_users): Don't reset innermost_block.
13046         * printcmd.c (display_command, do_one_display): Don't reset
13047         innermost_block.
13048         * parser-defs.h (enum innermost_block_tracker_type): Move to
13049         expression.h.
13050         (innermost_block): Update comment.
13051         * parse.c (parse_exp_1): Add tracker_types parameter.
13052         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
13053         tracker_types parameter.  Reset innermost_block.
13054         (parse_exp_in_context): Remove.
13055         (parse_expression_for_completion): Update.
13056         * objfiles.c (~objfile): Don't reset expression_context_block or
13057         innermost_block.
13058         * expression.h (enum innermost_block_tracker_type): Move from
13059         parser-defs.h.
13060         (parse_exp_1): Add tracker_types parameter.
13061         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13062         reset innermost_block.
13063
13064 2019-03-23  Tom Tromey  <tom@tromey.com>
13065
13066         * objfiles.h: Include bcache.h.
13067
13068 2019-03-23  Tom Tromey  <tom@tromey.com>
13069
13070         * linespec.c (get_current_search_block): Use
13071         scoped_restore_current_language.
13072         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13073
13074 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13075             Jiong Wang  <jiong.wang@arm.com>
13076
13077         * aarch64-linux-tdep.c
13078         (aarch64_linux_iterate_over_regset_sections): Check for pauth
13079         section.
13080         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13081
13082 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13083             Jiong Wang  <jiong.wang@arm.com>
13084
13085         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13086         instructions.
13087         (aarch64_analyze_prologue_test): Add PACIASP test.
13088         (aarch64_prologue_prev_register): Unmask PC value.
13089
13090 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13091             Jiong Wang  <jiong.wang@arm.com>
13092
13093         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13094         (aarch64_dwarf2_prev_register): Unmask PC value.
13095         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13096         (aarch64_execute_dwarf_cfa_vendor_op): Check for
13097         DW_CFA_AARCH64_negate_ra_state.
13098         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13099
13100 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13101             Jiong Wang  <jiong.wang@arm.com>
13102
13103         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13104         registers.
13105         (aarch64_pseudo_register_name): Likewise.
13106         (aarch64_pseudo_register_type): Likewise.
13107         (aarch64_pseudo_register_reggroup_p): Likewise.
13108         (aarch64_gdbarch_init): Add pauth registers.
13109         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13110         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13111         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13112         (struct gdbarch_tdep): Add regnum for ra_state.
13113
13114 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13115             Jiong Wang  <jiong.wang@arm.com>
13116
13117         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13118
13119 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13120             Jiong Wang  <jiong.wang@arm.com>
13121
13122         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13123         function.
13124         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13125         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13126         (aarch64_gdbarch_init): Add puth registers.
13127         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13128         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13129         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13130
13131 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13132             Jiong Wang  <jiong.wang@arm.com>
13133
13134         * aarch64-linux-nat.c
13135         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13136         * aarch64-linux-tdep.c
13137         (aarch64_linux_core_read_description): Likewise.
13138         (aarch64_linux_get_hwcap): New function.
13139         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13140         (aarch64_linux_get_hwcap): New declaration.
13141
13142 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13143             Jiong Wang  <jiong.wang@arm.com>
13144
13145         * aarch64-linux-nat.c
13146         (aarch64_linux_nat_target::read_description): Add pauth param.
13147         * aarch64-linux-tdep.c
13148         (aarch64_linux_core_read_description): Likewise.
13149         * aarch64-tdep.c (struct target_desc): Add in pauth.
13150         (aarch64_read_description): Add pauth param.
13151         (aarch64_gdbarch_init): Likewise.
13152         * aarch64-tdep.h (aarch64_read_description): Likewise.
13153         * arch/aarch64.c (aarch64_create_target_description): Likewise.
13154         * arch/aarch64.h (aarch64_create_target_description): Likewise.
13155         * features/Makefile: Add new files.
13156         * features/aarch64-pauth.c: New file.
13157         * features/aarch64-pauth.xml: New file.
13158
13159 2019-03-20  Tom Tromey  <tromey@adacore.com>
13160
13161         * infrun.c (handle_inferior_event): Rename from
13162         handle_inferior_event_1.  Create a scoped_value_mark.
13163         (handle_inferior_event): Remove.
13164
13165 2019-03-19  Tom Tromey  <tromey@adacore.com>
13166
13167         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13168         * infrun.h (print_stop_event): Add "displays" parameter.
13169         * infrun.c (print_stop_event): Add "displays" parameter.
13170
13171 2019-03-19  Pedro Alves  <palves@redhat.com>
13172
13173         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13174         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
13175         to -1.  Fix TABs vs spaces.
13176         (tui_ui_out::tui_ui_out): Don't initialize fields here.
13177         * tui/tui-out.h (tui_ui_out) Add intro comments.
13178         <m_line, m_start_of_line>: In-class initialize, and add describing
13179         comment.
13180
13181 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
13182
13183         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13184         variable names.
13185         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13186
13187 2019-03-18  Pedro Alves  <palves@redhat.com>
13188             Eli Zaretskii <eliz@gnu.org>
13189
13190         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13191         m_line and m_start_of_line.
13192
13193 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
13194
13195         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13196         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13197         it returns a newline.  This fixes a regression in TU mode, whereby
13198         the next line is output on the same screen line as the user input.
13199
13200 2019-03-18  Tom Tromey  <tromey@adacore.com>
13201
13202         * minsyms.c (minimal_symbol_reader::install): Remove call to
13203         obstack_blank.
13204
13205 2019-03-18  Pedro Alves  <palves@redhat.com>
13206
13207         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13208         New globals.
13209         (apply_style): New, factored out from ...
13210         (apply_ansi_escape): ... this.  Handle reverse video mode.
13211         (tui_set_reverse_mode): New function.
13212         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13213         * tui/tui-winsource.c (tui_show_source_line): Use
13214         tui_set_reverse_mode instead of setting A_STANDOUT.
13215         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13216         New setter methods.
13217
13218 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
13219
13220         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13221         Handle tabs.
13222
13223 2019-03-18  Tom Tromey  <tromey@adacore.com>
13224
13225         * ada-lang.c (empty_array): Add "high" parameter.
13226         (ada_evaluate_subexp): Update.
13227
13228 2019-03-17  Sergei Trofimovich <siarheit@google.com>
13229
13230         * unittests/string_view-selftests.c: Define
13231         _initialize_string_view_selftests unconditionally.
13232
13233 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13234
13235         PR gdb/24350
13236         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13237
13238 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13239
13240         PR gdb/24351
13241         * windows-nat.c (display_selector): Fix format specifiers.
13242
13243 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
13244
13245         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13246         tui_refill_source_window instead of tui_refresh_win, to update the
13247         current execution line.  This fixes redisplay of the current line
13248         when stepping through the code with "next" or "step".
13249
13250 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13251
13252         * source-cache.c (source_cache::get_source_lines): Call
13253         find_source_lines to initialize s->nlines.  This fixes vertical
13254         scrolling of TUI source window when the DOWN arrow is pressed.
13255
13256 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13257
13258         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13259         linux-thread-db.c (_initialize_thread_db): Likewise.
13260
13261 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13262
13263         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13264         wclrtoeol in tui_show_source_line".  This reverts changes made in
13265         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13266
13267 2019-03-15  Tom Tromey  <tom@tromey.com>
13268
13269         * symtab.h (struct minimal_symbol): Derive from
13270         general_symbol_info.
13271         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13272         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13273         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13274         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13275         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13276         (MSYMBOL_SEARCH_NAME): Update.
13277         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13278         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13279         * minsyms.c (minimal_symbol_reader::record_full): Update.
13280
13281 2019-03-15  Tom Tromey  <tom@tromey.com>
13282
13283         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13284
13285 2019-03-15  Tom Tromey  <tom@tromey.com>
13286
13287         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13288         unique_xmalloc_ptr.
13289         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13290         Update.
13291         * minsyms.c (lookup_minimal_symbol_by_pc_section)
13292         (build_minimal_symbol_hash_tables)
13293         (minimal_symbol_reader::install): Update.
13294
13295 2019-03-15  Tom Tromey  <tom@tromey.com>
13296
13297         * symtab.c (create_demangled_names_hash): Update.
13298         (symbol_set_names): Update.
13299         * objfiles.h (struct objfile_per_bfd_storage)
13300         <demangled_names_hash>: Now an htab_up.
13301         * objfiles.c (objfile_per_bfd_storage): Simplify.
13302
13303 2019-03-15  Tom Tromey  <tom@tromey.com>
13304
13305         * objfiles.h (struct objfile_per_bfd_storage): Declare
13306         destructor.
13307         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13308         New.
13309         (get_objfile_bfd_data): Use new.  Don't initialize
13310         language_of_main.
13311         (free_objfile_per_bfd_storage): Remove.
13312         (objfile_bfd_data_free, objfile::~objfile): Use delete.
13313
13314 2019-03-15  Tom Tromey  <tom@tromey.com>
13315
13316         * symfile.c (reread_symbols): Update.
13317         * objfiles.c (objfile::objfile): Update.
13318         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13319         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13320         comment.
13321         (minimal_symbol_reader::install): Update.
13322         (terminate_minimal_symbol_table): Remove.
13323         * jit.c (jit_object_close_impl): Update.
13324
13325 2019-03-15  Tom Tromey  <tom@tromey.com>
13326
13327         * minsyms.c (minimal_symbol_reader::record_full): Remove some
13328         initializations.
13329
13330 2019-03-15  Tom Tromey  <tom@tromey.com>
13331
13332         * objfiles.h (struct objfile_per_bfd_storage)
13333         <demangled_hash_languages>: Now a bitset.
13334         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13335         (lookup_minimal_symbol): Update.
13336
13337 2019-03-15  Tom Tromey  <tom@tromey.com>
13338
13339         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13340         Don't return the symbol.
13341         * coffread.c (record_minimal_symbol): Use record_full.
13342
13343 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
13344
13345         The MS-Windows port of ncurses fails to switch to a color pair if
13346         one or both of the colors are the implicit default colors.  This
13347         change records the default colors when TUI is initialized, and
13348         then specifies them explicitly when a color pair uses the default
13349         colors.  This allows color styling in TUI mode on MS-Windows.
13350
13351         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
13352         ncurses_norm_attr.
13353         (tui_initialize_io) [__MINGW32__]: Record the default terminal
13354         colors in ncurses_norm_attr.
13355         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13356         "none", replace it with the default color recorded in
13357         ncurses_norm_attr.
13358
13359 2019-03-14  Tom Tromey  <tromey@adacore.com>
13360
13361         * source-cache.h (class source_cache) <get_source_lines>: Return
13362         std::string.
13363         * source-cache.c (source_cache::extract_lines): Handle case where
13364         first_pos==npos.  Return std::string.
13365         (source_cache::get_source_lines): Update.
13366
13367 2019-03-14  Tom Tromey  <tromey@adacore.com>
13368
13369         * NEWS: Add item for "style sources" commands.
13370         * source-cache.c (source_cache::get_source_lines): Check
13371         source_styling.
13372         * cli/cli-style.c (source_styling): New global.
13373         (_initialize_cli_style): Add "style sources" commands.
13374         (show_style_sources): New function.
13375         * cli/cli-style.h (source_styling): Declare.
13376
13377 2019-03-14  Pedro Alves  <palves@redhat.com>
13378             Tom Tromey  <tromey@adacore.com>
13379
13380         * tui/tui-winsource.h (tui_refill_source_window): Declare.
13381         * tui/tui-winsource.c (tui_refill_source_window): New function,
13382         from...
13383         (tui_horizontal_source_scroll): ... here.  Move some logic.
13384         * cli/cli-style.c (set_style_enabled): Notify new observable.
13385         * tui/tui-hooks.c (tui_redisplay_source): New function.
13386         (tui_attach_detach_observers): Attach or detach
13387         tui_redisplay_source.
13388         * observable.h (source_styling_changed): New observable.
13389         * observable.c: Define source_styling_changed observable.
13390
13391 2019-03-13  Tom Tromey  <tromey@adacore.com>
13392
13393         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13394         (i386_gnu_nat_target::store_registers): Update.
13395         * target-debug.h (target_debug_print_std_string): New macro.
13396         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13397         * windows-tdep.c (display_one_tib): Update.
13398         * tui/tui-stack.c (tui_make_status_line): Update.
13399         * top.c (print_inferior_quit_action): Update.
13400         * thread.c (thr_try_catch_cmd): Update.
13401         (add_thread_with_info): Update.
13402         (thread_target_id_str): Update.
13403         (thr_try_catch_cmd): Update.
13404         (thread_command): Update.
13405         (thread_find_command): Update.
13406         * record-btrace.c (record_btrace_target::info_record)
13407         (record_btrace_resume_thread, record_btrace_target::resume)
13408         (record_btrace_cancel_resume, record_btrace_step_thread)
13409         (record_btrace_target::wait, record_btrace_target::wait)
13410         (record_btrace_target::wait, record_btrace_target::stop): Update.
13411         * progspace.c (print_program_space): Update.
13412         * process-stratum-target.c
13413         (process_stratum_target::thread_address_space): Update.
13414         * linux-fork.c (linux_fork_mourn_inferior)
13415         (detach_checkpoint_command, info_checkpoints_command)
13416         (linux_fork_context): Update.
13417         (linux_fork_detach): Update.
13418         (class scoped_switch_fork_info): Update.
13419         (delete_checkpoint_command): Update.
13420         * infrun.c (follow_fork_inferior): Update.
13421         (follow_fork_inferior): Update.
13422         (proceed_after_vfork_done): Update.
13423         (handle_vfork_child_exec_or_exit): Update.
13424         (follow_exec): Update.
13425         (displaced_step_prepare_throw): Update.
13426         (displaced_step_restore): Update.
13427         (start_step_over): Update.
13428         (resume_1): Update.
13429         (clear_proceed_status_thread): Update.
13430         (proceed): Update.
13431         (print_target_wait_results): Update.
13432         (do_target_wait): Update.
13433         (context_switch): Update.
13434         (stop_all_threads): Update.
13435         (restart_threads): Update.
13436         (finish_step_over): Update.
13437         (handle_signal_stop): Update.
13438         (switch_back_to_stepped_thread): Update.
13439         (keep_going_pass_signal): Update.
13440         (print_exited_reason): Update.
13441         (normal_stop): Update.
13442         * inferior.c (inferior_pid_to_str): Change return type.
13443         (print_selected_inferior): Update.
13444         (add_inferior): Update.
13445         (detach_inferior): Update.
13446         * dummy-frame.c (fprint_dummy_frames): Update.
13447         * dcache.c (dcache_info_1): Update.
13448         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13449         (btrace_fetch, btrace_clear): Update.
13450         * linux-tdep.c (linux_core_pid_to_str): Change return type.
13451         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13452         type.
13453         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13454         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13455         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13456         * gdbarch.c, gdbarch.h: Rebuild.
13457         * gdbarch.sh (core_pid_to_str): Change return type.
13458         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13459         return type.
13460         (windows_nat_target::pid_to_str): Change return type.
13461         (windows_delete_thread): Update.
13462         (windows_nat_target::attach): Update.
13463         (windows_nat_target::files_info): Update.
13464         * target-delegates.c: Rebuild.
13465         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13466         return type.
13467         (sol_thread_target::pid_to_str): Change return type.
13468         * remote.c (class remote_target) <pid_to_str>: Change return
13469         type.
13470         (remote_target::pid_to_str): Change return type.
13471         (extended_remote_target::attach, remote_target::remote_stop_ns)
13472         (remote_target::remote_notif_remove_queued_reply)
13473         (remote_target::push_stop_reply, remote_target::disable_btrace):
13474         Update.
13475         (extended_remote_target::attach): Update.
13476         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13477         type.
13478         (gdbsim_target::pid_to_str): Change return type.
13479         * ravenscar-thread.c (struct ravenscar_thread_target)
13480         <pid_to_str>: Change return type.
13481         (ravenscar_thread_target::pid_to_str): Change return type.
13482         * procfs.c (class procfs_target) <pid_to_str>: Change return
13483         type.
13484         (procfs_target::pid_to_str): Change return type.
13485         (procfs_target::attach): Update.
13486         (procfs_target::detach): Update.
13487         (procfs_target::fetch_registers): Update.
13488         (procfs_target::store_registers): Update.
13489         (procfs_target::wait): Update.
13490         (procfs_target::files_info): Update.
13491         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13492         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13493         return type.
13494         (nto_procfs_target::pid_to_str): Change return type.
13495         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13496         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13497         return type.
13498         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13499         (exit_lwp): Update.
13500         (attach_proc_task_lwp_callback, get_detach_signal)
13501         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13502         (linux_nat_target::resume, wait_lwp, stop_callback)
13503         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13504         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13505         (linux_nat_wait_1, resume_stopped_resumed_lwps)
13506         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13507         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13508         type.
13509         (inf_ptrace_target::attach): Update.
13510         (inf_ptrace_target::files_info): Update.
13511         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13512         type.
13513         (go32_nat_target::pid_to_str): Change return type.
13514         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13515         (gnu_nat_target::wait): Update.
13516         (gnu_nat_target::wait): Update.
13517         (gnu_nat_target::resume): Update.
13518         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13519         (fbsd_nat_target::wait): Update.
13520         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13521         type.
13522         (darwin_nat_target::attach): Update.
13523         * corelow.c (class core_target) <pid_to_str>: Change return type.
13524         (core_target::pid_to_str): Change return type.
13525         * target.c (normal_pid_to_str): Change return type.
13526         (default_pid_to_str): Likewise.
13527         (target_pid_to_str): Change return type.
13528         (target_translate_tls_address): Update.
13529         (target_announce_detach): Update.
13530         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13531         return type.
13532         (bsd_uthread_target::pid_to_str): Change return type.
13533         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13534         type.
13535         (bsd_kvm_target::pid_to_str): Change return type.
13536         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13537         return type.
13538         (aix_thread_target::pid_to_str): Change return type.
13539         * target.h (struct target_ops) <pid_to_str>: Change return type.
13540         (target_pid_to_str, normal_pid_to_str): Likewise.
13541         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13542         type.
13543         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13544         type.
13545         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13546         return type.
13547         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13548         type.
13549         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13550         type.
13551         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13552         return type.
13553
13554 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
13555
13556         * NEWS: Mention that the new default MI version is 3.  Mention
13557         changes to the output of commands and events that deal with
13558         multi-location breakpoints.
13559         * breakpoint.c: Include "mi/mi-out.h".
13560         (print_one_breakpoint): Change output syntax if using MI version
13561         >= 3.
13562         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13563         New.
13564         (mi_multi_location_breakpoint_output_fixed): New.
13565         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13566         (mi_cmd_fix_multi_location_breakpoint_output): New.
13567         (mi_multi_location_breakpoint_output_fixed): New.
13568         * mi/mi-cmds.c (mi_cmds): Register command
13569         -fix-multi-location-breakpoint-output.
13570         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13571         interpreter "mi".
13572
13573 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
13574
13575         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13576         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13577         instantiate mi_ui_out based on interpreter name.
13578         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13579         * mi/mi-main.c (mi_load_progress): Likewise.
13580
13581 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13582
13583         * NEWS: Combine separate "New targets" sections for 8.3.
13584
13585 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13586
13587         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13588         (ppcfbsd_init_abi): Install gdbarch
13589         "fetch_tls_load_module_address" and "get_thread_local_address"
13590         methods.
13591
13592 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13593
13594         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13595         (riscv_fbsd_init_abi): Install gdbarch
13596         "fetch_tls_load_module_address" and "get_thread_local_address"
13597         methods.
13598
13599 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13600
13601         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13602         (i386fbsd_init_abi): Install gdbarch
13603         "fetch_tls_load_module_address" and "get_thread_local_address"
13604         methods.
13605
13606 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13607
13608         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13609         (amd64fbsd_init_abi): Install gdbarch
13610         "fetch_tls_load_module_address" and "get_thread_local_address"
13611         methods.
13612
13613 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13614
13615         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13616         (struct fbsd_pspace_data): New type.
13617         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13618         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13619         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13620         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13621         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13622
13623 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13624
13625         * gdbtypes.c (lookup_struct_elt): New function.
13626         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13627         * gdbtypes.h (struct struct_elt): New type.
13628         (lookup_struct_elt): New prototype.
13629
13630 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13631
13632         * gdbtypes.c (lookup_struct_elt_type): Update comment and
13633         remove disabled code block.
13634
13635 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13636
13637         * gdbarch.sh (get_thread_local_address): New method.
13638         * gdbarch.h, gdbarch.c: Regenerate.
13639         * target.c (target_translate_tls_address): Use
13640         gdbarch_get_thread_local_address if present instead of
13641         target::get_thread_local_address.
13642
13643 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13644
13645         * target.h (target::get_thread_local_address): Update comment.
13646
13647 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13648
13649         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13650         objfile->separate_debug_objfile_backlink if not NULL.
13651
13652 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13653
13654         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13655         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13656         (amd64bsd_store_inferior_registers): Likewise.
13657         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13658         Enable segment base registers.
13659         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13660         PT_GETFSBASE and PT_GETGSBASE.
13661         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13662         PT_SETGSBASE.
13663         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13664         segment base registers.
13665         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13666
13667 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13668
13669         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13670         Update calls to i386_target_description to add 'segments'
13671         parameter.
13672         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
13673         add segment base registers.
13674         * arch/i386.c (i386_create_target_description): Add 'segments'
13675         parameter to enable segment base registers.
13676         * arch/i386.h (i386_create_target_description): Likewise.
13677         * features/i386/32bit-segments.xml: New file.
13678         * features/i386/32bit-segments.c: Generate.
13679         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13680         call to i386_target_description to add 'segments' parameter.
13681         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13682         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13683         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13684         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13685         if feature is present.
13686         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13687         Add 'segments' parameter to call to i386_target_description.
13688         (i386_target_description): Add 'segments' parameter to enable
13689         segment base registers.
13690         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13691         to call to i386_target_description.
13692         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13693         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13694         Define I386_NUM_REGS.
13695         (i386_target_description): Add 'segments' parameter to enable
13696         segment base registers.
13697
13698 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
13699
13700         PR/24325
13701         * source-cache.c: #undef open and close, to avoid unresolved
13702         externals during linking.
13703
13704 2019-03-12  Tom Tromey  <tromey@adacore.com>
13705
13706         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13707         const.  Add initializers.
13708         (_initialize_remote): Don't initialize ptid globals.
13709
13710 2019-03-12  Pedro Alves  <palves@redhat.com>
13711
13712         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13713
13714 2019-03-12  Pedro Alves  <palves@redhat.com>
13715
13716         * cp-name-parser.y (main): Remove unused 'len' variable.
13717
13718 2019-03-12  Tom Tromey  <tromey@adacore.com>
13719
13720         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13721         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13722
13723 2019-03-12  Tom Tromey  <tromey@adacore.com>
13724
13725         * linux-nat.c (iterate_over_lwps): Update.
13726         (stop_callback): Remove parameter.
13727         (stop_wait_callback, detach_callback, resume_set_callback)
13728         (select_singlestep_lwp_callback, set_ignore_sigint)
13729         (status_callback, resumed_callback, resume_clear_callback)
13730         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13731         data parameter.
13732         (linux_nat_target::detach, linux_nat_target::resume)
13733         (linux_stop_and_wait_all_lwps, select_event_lwp)
13734         (linux_nat_filter_event, linux_nat_wait_1)
13735         (linux_nat_target::kill, linux_nat_target::stop)
13736         (linux_nat_target::stop): Update.
13737         (linux_nat_resume_callback): Change type.
13738         (resume_stopped_resumed_lwps, count_events_callback)
13739         (select_event_lwp_callback): Likewise.
13740         (linux_stop_lwp, linux_nat_stop_lwp): Update.
13741         * arm-linux-nat.c (struct update_registers_data): Remove.
13742         (update_registers_callback): Change type.
13743         (arm_linux_insert_hw_breakpoint1): Update.
13744         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13745         parameter.
13746         (x86_linux_dr_set_addr): Update.
13747         (x86_linux_dr_set_control): Update.
13748         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13749         (iterate_over_lwps): Use gdb::function_view.
13750         * nat/aarch64-linux-hw-point.c (struct
13751         aarch64_dr_update_callback_param): Remove.
13752         (debug_reg_change_callback): Change type.
13753         (aarch64_notify_debug_reg_change): Update.
13754         * s390-linux-nat.c (s390_refresh_per_info): Update.
13755
13756 2019-03-11  Tom Tromey  <tromey@adacore.com>
13757
13758         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13759         redundant assignment to "this_cu".
13760
13761 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13762
13763         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13764
13765 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13766
13767         * gdbtypes.c (rank_one_type_parm_set): New function extracted
13768         from...
13769         (rank_one_type): ... this.
13770
13771 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13772
13773         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13774         from...
13775         (rank_one_type): ... this.
13776
13777 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13778
13779         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13780         from...
13781         (rank_one_type): ... this.
13782
13783 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13784
13785         * gdbtypes.c (rank_one_type_parm_float): New function extracted
13786         from...
13787         (rank_one_type): ... this.
13788
13789 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13790
13791         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13792         from...
13793         (rank_one_type): ... this.
13794
13795 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13796
13797         * gdbtypes.c (rank_one_type_parm_range): New function extracted
13798         from...
13799         (rank_one_type): ... this.
13800
13801 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13802
13803         * gdbtypes.c (rank_one_type_parm_char): New function extracted
13804         from...
13805         (rank_one_type): ... this.
13806
13807 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13808
13809         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13810         from...
13811         (rank_one_type): ... this.
13812
13813 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13814
13815         * gdbtypes.c (rank_one_type_parm_int): New function extracted
13816         from...
13817         (rank_one_type): ... this.
13818
13819 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13820
13821         * gdbtypes.c (rank_one_type_parm_func): New function extracted
13822         from...
13823         (rank_one_type): ... this.
13824
13825 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13826
13827         * gdbtypes.c (rank_one_type_parm_array): New function extracted
13828         from...
13829         (rank_one_type): ... this.
13830
13831 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13832
13833         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13834         from...
13835         (rank_one_type): ... this.
13836
13837 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13838
13839         * inferior.c (initialize_inferiors): Ensure 'help set/show print
13840         inferior-events' shows the example events.
13841
13842 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
13843
13844         Support styling on native MS-Windows console
13845
13846         PR/24315
13847         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13848         on MS-Windows if $TERM is not defined.
13849
13850         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13851
13852         * posix-hdep.c (gdb_console_fputs):
13853         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13854         functions.
13855         * ui-file.h (gdb_console_fputs): Add prototype.
13856
13857         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13858         back to fputs only if the former returns zero.
13859
13860 2019-03-07  Tom Tromey  <tom@tromey.com>
13861
13862         * symmisc.c (print_symbol_bcache_statistics): Update.
13863         (print_objfile_statistics): Update.
13864         * symfile.c (allocate_symtab): Update.
13865         * stabsread.c: Don't include bcache.h.
13866         * psymtab.h (struct psymbol_bcache): Don't declare.
13867         (class psymtab_storage) <psymbol_cache>: Now a bcache.
13868         (psymbol_bcache_init, psymbol_bcache_free)
13869         (psymbol_bcache_get_bcache): Don't declare.
13870         * psymtab.c (struct psymbol_bcache): Remove.
13871         (psymtab_storage::psymtab_storage): Update.
13872         (psymtab_storage::~psymtab_storage): Update.
13873         (psymbol_bcache_init, psymbol_bcache_free)
13874         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13875         (add_psymbol_to_bcache): Update.
13876         (allocate_psymtab): Update.
13877         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13878         macro_cache>: No longer pointers.
13879         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13880         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13881         * macrotab.c (macro_bcache): Update.
13882         * macroexp.c: Don't include bcache.h.
13883         * gdbtypes.c (check_types_worklist): Update.
13884         (types_deeply_equal): Remove TRY/CATCH.  Update.
13885         * elfread.c (elf_symtab_read): Update.
13886         * dwarf2read.c: Don't include bcache.h.
13887         * buildsym.c (buildsym_compunit::get_macro_table): Update.
13888         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13889         (print_bcache_statistics, bcache_memory_used): Don't declare.
13890         (struct bcache): Move from bcache.c.  Add constructor, destructor,
13891         methods.  Rename all data members.
13892         * bcache.c (struct bcache): Move to bcache.h.
13893         (bcache::expand_hash_table): Rename from expand_hash_table.
13894         (bcache): Remove.
13895         (bcache::insert): Rename from bcache_full.
13896         (bcache::compare): Rename from bcache_compare.
13897         (bcache_xmalloc): Remove.
13898         (bcache::~bcache): Rename from bcache_xfree.
13899         (bcache::print_statistics): Rename from print_bcache_statistics.
13900         (bcache::memory_used): Rename from bcache_memory_used.
13901
13902 2019-03-07  Pedro Alves  <palves@redhat.com>
13903
13904         * infrun.c (normal_stop): Also check for
13905         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13906
13907 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
13908
13909         * f-lang.c (value_from_host_double): Moved to...
13910         * value.c (value_from_host_double): ...here.
13911         * value.h (value_from_host_double): Declare.
13912         * guile/scm-math.c (vlscm_convert_typed_number): Use
13913         value_from_host_double.
13914         (vlscm_convert_number): Likewise.
13915         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13916         * python/py-value.c (convert_value_from_python): Likewise.
13917
13918 2019-03-06  Tom Tromey  <tom@tromey.com>
13919
13920         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13921
13922 2019-03-06  Tom Tromey  <tom@tromey.com>
13923
13924         * utils.h (free_current_contents): Don't declare.
13925         * utils.c (free_current_contents): Remove.
13926
13927 2019-03-06  Tom Tromey  <tom@tromey.com>
13928
13929         * top.c (quit_force): Update.
13930         * main.c (captured_command_loop): Update.
13931         * common/new-op.c (operator new): Update.
13932         * common/common-exceptions.c (struct catcher)
13933         <save_cleanup_chain>: Remove member.
13934         (exceptions_state_mc_init): Update.
13935         (exception_try_scope_entry): Return nullptr.
13936         (exception_try_scope_exit, exception_rethrow)
13937         (throw_exception_sjlj, throw_exception_cxx): Update.
13938         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13939         (all_cleanups, do_cleanups, discard_cleanups)
13940         (discard_final_cleanups, save_cleanups, save_final_cleanups)
13941         (restore_cleanups, restore_final_cleanups): Don't declare.
13942         (do_final_cleanups): Remove parameter.
13943         * common/cleanups.c (cleanup_chain, make_cleanup)
13944         (make_cleanup_dtor, all_cleanups, do_cleanups)
13945         (discard_my_cleanups, discard_cleanups)
13946         (discard_final_cleanups, save_my_cleanups, save_cleanups)
13947         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13948         (null_cleanup): Remove.
13949         (do_final_cleanups): Remove parameter.
13950
13951 2019-03-06  Tom Tromey  <tom@tromey.com>
13952
13953         * remote.c (remote_target::remote_parse_stop_reply): Use
13954         unique_xmalloc_ptr.
13955
13956 2019-03-06  Tom Tromey  <tom@tromey.com>
13957
13958         * stabsread.c (struct stabs_field_info): Rename from field_info.
13959         <list, fnlist>: Add initializers.
13960         <obstack>: New member.
13961         (read_member_functions, read_struct_fields, read_baseclasses):
13962         Allocate on obstack.  Don't use cleanups.
13963         (read_one_struct_field, read_member_functions, read_struct_fields)
13964         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13965         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13966         (read_struct_type): Update.
13967
13968 2019-03-06  Tom Tromey  <tom@tromey.com>
13969
13970         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13971         * common/filestuff.h (make_cleanup_close): Don't declare.
13972         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13973         Remove.
13974
13975 2019-03-06  Tom Tromey  <tom@tromey.com>
13976
13977         * solib-aix.c: Use make_scope_exit.
13978
13979 2019-03-06  Tom Tromey  <tom@tromey.com>
13980
13981         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13982         Use make_scope_exit.
13983
13984 2019-03-06  Tom Tromey  <tom@tromey.com>
13985
13986         * solib-svr4.c (disable_probes_interface): Remove parameter.
13987         (svr4_handle_solib_event): Use make_scope_exit.
13988
13989 2019-03-06  Tom Tromey  <tom@tromey.com>
13990
13991         * remote.c (struct stop_reply_deleter): Remove.
13992         (stop_reply_up): Update.
13993         (struct stop_reply): Derive from notif_event.  Don't typedef.
13994         <regcache>: Now a std::vector.
13995         (stop_reply_xfree): Remove.
13996         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13997         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
13998         (remote_target::discard_pending_stop_replies): Use delete.
13999         (remote_target::remote_parse_stop_reply): Update.
14000         (remote_target::process_stop_reply): Update.
14001         * remote-notif.h (struct notif_event): Add virtual destructor.
14002         Remove "dtr" member.
14003         (struct notif_client) <alloc_event>: Return a unique_ptr.
14004         (notif_event_xfree): Don't declare.
14005         (notif_event_up): New typedef.
14006         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14007         (notif_event_xfree, do_notif_event_xfree): Remove.
14008         (remote_notif_state_xfree): Update.
14009
14010 2019-03-06  Tom Tromey  <tom@tromey.com>
14011
14012         * infrun.c (displaced_step_clear_cleanup): Now a
14013         forward_scope_exit type.
14014         (displaced_step_prepare_throw): Update.
14015         (displaced_step_fixup): Update.
14016
14017 2019-03-06  Tom Tromey  <tom@tromey.com>
14018
14019         * inferior.h (class inferior): Update comment.
14020         * gdbthread.h (class thread_info): Update comment.
14021
14022 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
14023             Tom Tromey  <tom@tromey.com>
14024
14025         * stabsread.h (struct stab_section_list): Remove.
14026         (coffstab_build_psymtabs): Update.
14027         * dbxread.c (symbuf_sections): Now a std::vector.
14028         (sect_idx): New global.
14029         (fill_symbuf): Update.
14030         (coffstab_build_psymtabs): Change type of stabsects parameter.
14031         Update.
14032         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14033         std::vector.
14034         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14035         (coff_locate_sections): Update.
14036         (coff_symfile_read): Remove cleanups.  Update.
14037         (init_stringtab): Add storage parameter.
14038         (free_stringtab, free_stringtab_cleanup): Remove.
14039         (init_lineno): Add storage parameter.
14040         (free_linetab, free_linetab_cleanup): Remove.
14041
14042 2019-03-06  Pedro Alves  <palves@redhat.com>
14043
14044         * linux-fork.c (fork_info::clobber_regs): Delete.
14045         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14046         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
14047         comment.  Adjust.
14048         (scoped_switch_fork_info::scoped_switch_fork_info)
14049         (checkpoint_command, linux_fork_context): Adjust
14050         fork_save_infrun_state calls.
14051
14052 2019-03-06  Pedro Alves  <palves@redhat.com>
14053
14054         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14055         (inf_has_multiple_threads): Return 'bool' and rewrite using
14056         inferior_info::threads().
14057
14058 2019-03-06  Pedro Alves  <palves@redhat.com>
14059
14060         * linux-fork.c: Include <list>.
14061         (fork_list): Now a std::list instance.
14062         (fork_info): Add ctor, dtor, and in-class initialize all fields.
14063         (forks_exist_p, find_last_fork): Adjust.
14064         (new_fork): Delete.
14065         (one_fork_p): New.
14066         (add_fork): Adjust.
14067         (free_fork): Delete, folded into fork_info::~fork_info().
14068         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14069         Adjust.
14070         (init_fork_list): Delete.
14071         (linux_fork_killall, linux_fork_mourn_inferior)
14072         (linux_fork_detach, info_checkpoints_command): Adjust.
14073         (_initialize_linux_fork): No longer call init_fork_list.
14074
14075 2019-03-06  Pedro Alves  <palves@redhat.com>
14076
14077         * linux-fork.c (new_fork): New, split out of ...
14078         (add_fork): ... this.  Return void.  Move "first fork" special
14079         case from here, to ...
14080         (checkpoint_command): ... here.
14081         * linux-linux.h (add_fork): Return void.
14082
14083 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14084
14085         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14086
14087 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14088             Chris January  <chris.january@arm.com>
14089             David Lecomber  <david.lecomber@arm.com>
14090
14091         * f-exp.y: New token, UNOP_INTRINSIC.
14092         (exp): New pattern using UNOP_INTRINSIC token.
14093         (f77_keywords): Add 'abs' keyword.
14094         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14095         (value_from_host_double): New function.
14096         (evaluate_subexp_f): Support UNOP_ABS.
14097
14098 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14099
14100         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14101         types.
14102
14103 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14104
14105         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14106         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14107         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14108
14109 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14110
14111         * f-exp.y (convert_to_kind_type): Handle more type kinds.
14112
14113 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14114             Chris January  <chris.january@arm.com>
14115
14116         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14117         * f-exp.y: Define 'KIND' token.
14118         (exp): New pattern for KIND expressions.
14119         (ptype): Handle types with a kind extension.
14120         (direct_abs_decl): Extend to spot kind extensions.
14121         (f77_keywords): Add 'kind' to the list.
14122         (push_kind_type): New function.
14123         (convert_to_kind_type): New function.
14124         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14125         * parse.c (operator_length_standard): Likewise.
14126         * parser-defs.h (enum type_pieces): Add tp_kind.
14127         * std-operator.def: Add UNOP_KIND.
14128
14129 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14130
14131         * f-exp.y (f_parse): Set yydebug.
14132
14133 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14134
14135         * f-lang.c (evaluate_subexp_f): New function.
14136         (exp_descriptor_f): New global.
14137         (f_language_defn): Use exp_descriptor_f instead of
14138         exp_descriptor_standard.
14139
14140 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14141
14142         * f-exp.y (struct token): Add comments.
14143         (dot_ops): Remove uppercase versions and the end marker.
14144         (f77_keywords): Likewise.
14145         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14146         entries in the dot_ops array are case insensitive, and use
14147         strncasecmp to compare strings.  Also some whitespace cleanup in
14148         this area.  Similar for the f77_keywords array, except entries in
14149         this list might be case sensitive.
14150
14151 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14152
14153         * f-exp.y (struct f77_boolean_val): Add comments.
14154         (boolean_values): Remove uppercase versions, and end marker.
14155         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14156         and use strncasecmp to achieve case insensitivity.  Additionally,
14157         perform whitespace cleanup around this code.
14158
14159 2019-03-06  Tom Tromey  <tromey@adacore.com>
14160
14161         * remote-sim.c (gdbsim_target_open): Use result of
14162         gdb_argv::release.
14163
14164 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
14165         Dirk Schubert  <dirk.schubert@arm.com>
14166         Chris January  <chris.january@arm.com>
14167
14168         * eval.c (evaluate_subexp_standard): Call Fortran argument
14169         wrapping logic.
14170         * f-lang.c (struct value): A value which can be passed into a
14171         Fortran function call.
14172         (fortran_argument_convert): Wrap Fortran arguments in a pointer
14173         where appropriate.
14174         (struct type): Value ready for a Fortran function call.
14175         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14176         is needed.
14177         * f-lang.h (fortran_argument_convert): Declaration.
14178         (fortran_preserve_arg_pointer): Declaration.
14179         * infcall.c (value_arg_coerce): Call Fortran argument logic.
14180
14181 2019-03-05  Tom Tromey  <tromey@adacore.com>
14182
14183         * python/py-prettyprint.c (print_string_repr): Remove #if.
14184         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14185
14186 2019-03-05  Tom Tromey  <tromey@adacore.com>
14187
14188         * target.c (the_dummy_target): Move later.  Change type to
14189         "dummy_target".
14190         (initialize_targets): Don't initialize the_dummy_target.
14191
14192 2019-03-05  Tom Tromey  <tromey@adacore.com>
14193
14194         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14195         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14196
14197 2019-03-05  Tom Tromey  <tromey@adacore.com>
14198
14199         * windows-nat.c (windows_nat_target::attach)
14200         (windows_nat_target::detach): Don't call gdb_flush.
14201         * valprint.c (generic_val_print, val_print, val_print_string):
14202         Don't call gdb_flush.
14203         * utils.c (defaulted_query): Don't call gdb_flush.
14204         * typeprint.c (print_type_scalar): Don't call gdb_flush.
14205         * target.c (target_announce_detach): Don't call gdb_flush.
14206         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14207         * remote.c (extended_remote_target::attach): Don't call
14208         gdb_flush.
14209         * procfs.c (procfs_target::detach): Don't call gdb_flush.
14210         * printcmd.c (do_examine): Don't call gdb_flush.
14211         (info_display_command): Don't call gdb_flush.
14212         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14213         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14214         * memattr.c (info_mem_command): Don't call gdb_flush.
14215         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14216         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14217         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14218         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14219         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14220         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14221         (gnu_nat_target::detach): Don't call gdb_flush.
14222         * f-valprint.c (f_val_print): Don't call gdb_flush.
14223         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14224         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14225         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14226         gdb_flush.
14227         * c-valprint.c (c_val_print): Don't call gdb_flush.
14228         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14229
14230 2019-03-05  Tom Tromey  <tromey@adacore.com>
14231
14232         * varobj.c (update_dynamic_varobj_children): Update.
14233         (install_default_visualizer): Use reset, not release.
14234         * value.c (set_internalvar): Update.
14235         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14236         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14237         ATTRIBUTE_UNUSED_RESULT.
14238
14239 2019-03-05  Tom Tromey  <tromey@adacore.com>
14240
14241         * remote.c (class scoped_remote_fd) <release>: Add
14242         ATTRIBUTE_UNUSED_RESULT.
14243
14244 2019-03-05  Tom Tromey  <tromey@adacore.com>
14245
14246         * macroexp.c (struct macro_buffer) <release>: Add
14247         ATTRIBUTE_UNUSED_RESULT.
14248
14249 2019-03-05  Tom Tromey  <tromey@adacore.com>
14250
14251         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14252         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14253         ATTRIBUTE_UNUSED_RESULT.
14254
14255 2019-03-05  Tom Tromey  <tromey@adacore.com>
14256
14257         * common/scoped_fd.h (class scoped_fd) <release>: Add
14258         ATTRIBUTE_UNUSED_RESULT.
14259
14260 2019-03-05  Tom Tromey  <tromey@adacore.com>
14261
14262         * parser-defs.h (struct parser_state) <release>: Add
14263         ATTRIBUTE_UNUSED_RESULT.
14264
14265 2019-03-05  Tom Tromey  <tromey@adacore.com>
14266
14267         * utils.h (class gdb_argv) <release>: Add
14268         ATTRIBUTE_UNUSED_RESULT.
14269         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14270
14271 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
14272
14273         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14274         for-loop range, to avoid compiler warnings.
14275
14276         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14277         avoid compiler warnings about unused variables.
14278
14279         * NEWS: Mention end of support for native debugging on MS-Windows
14280         before XP.
14281
14282         PR gdb/24292
14283         * common/netstuff.c:
14284         * gdbserver/gdbreplay.c
14285         * gdbserver/remote-utils.c:
14286         * ser-tcp.c:
14287         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14288         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
14289         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14290         'getaddrinfo' and 'freeaddrinfo' were not available before
14291         Windows XP, and mingw.org's MinGW headers by default define
14292         _WIN32_WINNT to 0x500.
14293
14294 2019-03-01  Gary Benson <gbenson@redhat.com>
14295
14296         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14297
14298 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
14299             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
14300
14301         PR gdb/8527
14302         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14303         set_sigint_trap, clear_sigint_trap.
14304
14305 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14306
14307         * target.c (target_detach): Clear the regcache and the
14308         frame cache.
14309
14310 2019-02-27  Pedro Alves  <palves@redhat.com>
14311
14312         * utils.c (set_screen_size): When we cap the height/width sizes,
14313         tweak the corresponding command variable to show "unlimited":
14314
14315 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
14316             Pedro Alves  <palves@redhat.com>
14317
14318         * utils.c (set_screen_size): Reduce "infinite" rows and columns
14319         before calling rl_set_screen_size.
14320
14321 2019-02-27  Tom Tromey  <tromey@adacore.com>
14322
14323         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14324         define.
14325         * python/py-value.c: Remove Python 2.4 workaround.
14326         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14327         workaround.
14328         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14329         Python 2.4 workaround.
14330         * python/python-internal.h: Remove Python 2.4 comment.
14331         (Py_ssize_t): Don't define.
14332         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14333         (gdb_Py_DECREF): Remove Python 2.4 workaround.
14334         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14335         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14336         * python/python.c (do_start_initialization): Remove Python 2.4
14337         workaround.
14338         * python/py-prettyprint.c (class dummy_python_frame): Remove.
14339         (print_children): Remove Python 2.4 workaround.
14340         * python/py-inferior.c (buffer_procs): Remove Python 2.4
14341         workaround.
14342         (CHARBUFFERPROC_NAME): Remove.
14343         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14344         Python 2.4 workaround.
14345
14346 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14347
14348         * NEWS: Note minimum Python version.
14349
14350 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14351
14352         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14353         code from these functions.  Remove corresponding ifdefs.  Use
14354         Py_buffer_up instead of explicit calls to PyBuffer_Release.
14355         Remove gotos and target of gotos.
14356         (infpy_search_memory): Likewise.
14357
14358 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14359
14360         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14361         (hppa_gdbarch_init): Don't register deleted functions with
14362         gdbarch.
14363
14364 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14365
14366         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14367         (h8300_unwind_sp): Delete.
14368         (h8300_dummy_id): Delete.
14369         (h8300_gdbarch_init): Don't register deleted functions with
14370         gdbarch.
14371
14372 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14373
14374         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14375         (ft32_unwind_pc): Delete.
14376         (ft32_unwind_sp): Delete.
14377         (ft32_gdbarch_init): Don't register deleted functions with
14378         gdbarch.
14379
14380 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14381
14382         * gdb/frv-tdep.c (frv_dummy_id): Delete.
14383         (frv_unwind_pc): Delete.
14384         (frv_unwind_sp): Delete.
14385         (frv_gdbarch_init): Don't register deleted functions with
14386         gdbarch.
14387
14388 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14389
14390         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14391         (riscv_unwind_pc): Delete.
14392         (riscv_unwind_sp): Delete.
14393         (riscv_gdbarch_init): Don't register deleted functions with
14394         gdbarch.
14395
14396 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14397
14398         * gdb/csky-tdep.c (csky_dummy_id): Delete.
14399         (csky_unwind_pc): Delete.
14400         (csky_unwind_sp): Delete.
14401         (csky_gdbarch_init): Don't register deleted functions with
14402         gdbarch.
14403
14404 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14405
14406         * gdb/cris-tdep.c (cris_dummy_id): Delete.
14407         (cris_unwind_pc): Delete.
14408         (cris_unwind_sp): Delete.
14409         (cris_gdbarch_init): Don't register deleted functions with
14410         gdbarch.
14411
14412 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14413
14414         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14415         (bfin_unwind_pc): Delete.
14416         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14417
14418 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14419
14420         * gdb/arm-tdep.c (arm_dummy_id): Delete.
14421         (arm_unwind_pc): Delete.
14422         (arm_unwind_sp): Delete.
14423         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14424
14425 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14426
14427         * gdb/arc-tdep.c (arc_dummy_id): Delete.
14428         (arc_unwind_pc): Delete.
14429         (arc_unwind_sp): Delete.
14430         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14431
14432 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14433
14434         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14435         (alpha_unwind_pc): Delete.
14436         (alpha_gdbarch_init): Don't register deleted functions with
14437         gdbarch.
14438
14439 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14440
14441         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14442         (aarch64_unwind_pc): Delete.
14443         (aarch64_unwind_sp): Delete.
14444         (aarch64_gdbarch_init): Don't register deleted functions with
14445         gdbarch.
14446
14447 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14448
14449         * gdbtypes.c (type_align): Don't consider static members when
14450         computing structure alignment.
14451
14452 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14453
14454         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14455         return 0 for other types.
14456         * arch-utils.c (default_type_align): Always return 0.
14457         * gdbarch.h: Regenerate.
14458         * gdbarch.sh (type_align): Extend comment.
14459         * gdbtypes.c (type_align): Add additional comments, always call
14460         gdbarch_type_align before applying the default rules.
14461         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14462         generic code will then apply a suitable default.
14463         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14464         types, return 0 for other types.
14465
14466 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14467
14468         * NEWS: Create a new section for the next release branch.
14469         Rename the section of the current branch, now that it has
14470         been cut.
14471
14472 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14473
14474         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14475         * version.in: Bump version to 8.3.50.DATE-git.
14476
14477 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
14478
14479         * aix-thread.c (ptid_cmp): Remove unused variable.
14480         (get_signaled_thread): Likewise.
14481         (store_regs_user_thread): Likewise.
14482         (store_regs_kernel_thread): Likewise.
14483         (fetch_regs_kernel_thread): Remove shadowed variable.
14484
14485 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
14486
14487         * features/riscv/32bit-cpu.xml: Add register numbers.
14488         * features/riscv/32bit-fpu.c: Regenerate.
14489         * features/riscv/32bit-fpu.xml: Add register numbers.
14490         * features/riscv/64bit-cpu.xml: Add register numbers.
14491         * features/riscv/64bit-fpu.c: Regenerate.
14492         * features/riscv/64bit-fpu.xml: Add register numbers.
14493
14494 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
14495
14496         * NEWS: Mention two argument form of gdb.Value constructor.
14497         * python/py-value.c (convert_buffer_and_type_to_value): New
14498         function.
14499         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14500         Add support for handling an optional second argument.  Call
14501         convert_buffer_and_type_to_value as appropriate.
14502         * python/python-internal.h (Py_buffer_deleter): New struct.
14503         (Py_buffer_up): New typedef.
14504
14505 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
14506
14507         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14508         instead of releasing ownership.
14509
14510 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
14511
14512         * dwarf2read.c (open_and_init_dwp_file): Call
14513         elf_numsections instead of bfd_count_sections to initialize
14514         dwp_file->num_sections.
14515
14516 2019-02-25  Tom Tromey  <tromey@adacore.com>
14517
14518         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14519
14520 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
14521
14522         * gcore.in: Add '--readnever' option when invoking GDB.
14523
14524 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14525
14526         * MAINTAINERS: Update my email address.
14527
14528 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14529
14530         * build-id.c (build_id_to_debug_bfd_1): New function.
14531         (build_id_to_debug_bfd): Look for separate debug file in
14532         sysroot.
14533
14534 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
14535
14536         * gdbarch.sh: Update the copyright year range that is placed into
14537         generated files.
14538
14539 2019-02-22  Keith Seitz  <keiths@redhat.com>
14540
14541         PR symtab/23853
14542         * linespec.c (create_sals_line_offset): Search for the default
14543         symtab's filename instead of its fullname.
14544
14545 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14546
14547         * NEWS: Update style defaults.
14548
14549 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14550
14551         * main.c (captured_main_1): Disable styling in batch mode.
14552
14553 2019-02-20  Tom Tromey  <tom@tromey.com>
14554
14555         * symtab.c (symtab_symbol_info): Fix typos.
14556
14557 2019-02-20  Tom Tromey  <tromey@adacore.com>
14558
14559         * findcmd.c (_initialize_mem_search): Use upper case for
14560         metasyntactic variables.
14561
14562 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
14563
14564         * aarch64-tdep.c (aarch64_add_reggroups): New function.
14565         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14566
14567 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
14568
14569         * top.h (source_file_name): Change to std::string.
14570         * top.c (source_file_name): Likewise.
14571         (command_line_input): Adjust.
14572         * cli/cli-script.c (script_from_file): Adjust.
14573
14574 2019-02-19  Tom Tromey  <tromey@adacore.com>
14575
14576         * ravenscar-thread.c
14577         (ravenscar_thread_target::update_thread_list): Don't call
14578         ada_build_task_list.
14579         * ada-lang.h (ada_build_task_list): Don't declare.
14580         * ada-tasks.c (struct ada_tasks_inferior_data)
14581         <task_list_valid_p>: Now bool.
14582         (read_known_tasks, ada_task_list_changed)
14583         (ada_tasks_invalidate_inferior_data): Update.
14584         (read_known_tasks_array): Return bool.
14585         (read_known_tasks_list): Likewise.
14586         (read_known_tasks): Return void.
14587         (ada_build_task_list): Now static.
14588
14589 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
14590
14591         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14592         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14593
14594 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14595
14596         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14597         variant for ada_tasks_pspace_data_handle and
14598         ada_tasks_inferior_data_handle.
14599         (ada_tasks_pspace_data_cleanup): New function.
14600         (ada_tasks_inferior_data_cleanup): New function.
14601
14602 2019-02-17  Tom Tromey  <tom@tromey.com>
14603
14604         * macrotab.h (macro_source_fullname): Return a std::string.
14605         * macrotab.c (macro_include, check_for_redefinition)
14606         (macro_undef, macro_lookup_definition, foreach_macro)
14607         (foreach_macro_in_scope): Update.
14608         (macro_source_fullname): Return a std::string.
14609         * macrocmd.c (show_pp_source_pos): Update.
14610
14611 2019-02-17  Tom Tromey  <tom@tromey.com>
14612
14613         * macrocmd.c (show_pp_source_pos): Style the file names.
14614
14615 2019-02-17  Tom Tromey  <tom@tromey.com>
14616
14617         PR tui/24197:
14618         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14619
14620 2019-02-17  Tom Tromey  <tom@tromey.com>
14621
14622         * ada-lang.c (user_select_syms): Use filtered printing.
14623         * utils.c (wrap_style): New global.
14624         (desired_style): Remove.
14625         (emit_style_escape): Add stream parameter.
14626         (set_output_style, reset_terminal_style, prompt_for_continue):
14627         Update.
14628         (flush_wrap_buffer): Only flush gdb_stdout.
14629         (wrap_here): Set wrap_style.
14630         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
14631         treat escape sequences as a character.  Change when wrap buffer is
14632         flushed.
14633         (fputs_styled): Do not set the output style when the default is
14634         requested.
14635         * ui-style.h (struct ui_file_style) <is_default>: New method.
14636         * source.c (print_source_lines_base): Emit escape sequences in one
14637         piece.
14638
14639 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14640
14641         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14642         integers and enumeration types.
14643
14644 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14645
14646         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14647         instead of lookup_symbol_in_language
14648         (do_exact_match): New function.
14649         (ada_get_symbol_name_matcher): Return do_exact_match when
14650         doing a verbatim match.
14651
14652 2019-02-15  Tom Tromey  <tromey@adacore.com>
14653
14654         * ravenscar-thread.c (ravenscar_thread_target::resume)
14655         (ravenscar_thread_target::wait): Special case wildcard requests.
14656
14657 2019-02-15  Tom Tromey  <tromey@adacore.com>
14658
14659         * ravenscar-thread.c (base_ptid): Remove.
14660         (struct ravenscar_thread_target) <close>: New method.
14661         <m_base_ptid>: New member.
14662         <update_inferior_ptid, active_task, task_is_currently_active,
14663         runtime_initialized>: Declare methods.
14664         <ravenscar_thread_target>: Add constructor.
14665         (ravenscar_thread_target::task_is_currently_active)
14666         (ravenscar_thread_target::update_inferior_ptid)
14667         (ravenscar_runtime_initialized): Rename.  Now methods.
14668         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14669         (ravenscar_thread_target::update_thread_list): Update.
14670         (ravenscar_thread_target::active_task): Now method.
14671         (ravenscar_thread_target::store_registers)
14672         (ravenscar_thread_target::prepare_to_store)
14673         (ravenscar_thread_target::prepare_to_store)
14674         (ravenscar_thread_target::mourn_inferior): Update.
14675         (ravenscar_inferior_created): Use "new" to create target.
14676         (ravenscar_thread_target::get_ada_task_ptid): Update.
14677         (_initialize_ravenscar): Don't initialize base_ptid.
14678         (ravenscar_ops): Remove global.
14679
14680 2019-02-15  Tom Tromey  <tromey@adacore.com>
14681
14682         * target.h (push_target): Declare new overload.
14683         * target.c (push_target): New overload, taking an rvalue reference.
14684         * remote.c (remote_target::open_1): Use push_target overload.
14685         * corelow.c (core_target_open): Use push_target overload.
14686
14687 2019-02-15  Tom Tromey  <tromey@adacore.com>
14688
14689         * ravenscar-thread.c (is_ravenscar_task)
14690         (ravenscar_task_is_currently_active): Return bool.
14691         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14692         (_initialize_ravenscar): Remove "(void)".
14693         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14694         Return bool.
14695
14696 2019-02-15  Tom Tromey  <tromey@adacore.com>
14697
14698         * ravenscar-thread.c (ravenscar_runtime_initializer)
14699         (has_ravenscar_runtime, get_running_thread_id)
14700         (ravenscar_thread_target::resume): Fix indentation.
14701
14702 2019-02-15  Tom Tromey  <tromey@adacore.com>
14703
14704         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14705         from ravenscar_arch_ops.
14706         (sparc_ravenscar_ops::fetch_registers)
14707         (sparc_ravenscar_ops::store_registers): Now methods.
14708         (sparc_ravenscar_prepare_to_store): Remove.
14709         (sparc_ravenscar_ops): Redefine.
14710         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14711         methods and destructor.  Remove members.
14712         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14713         (ravenscar_thread_target::store_registers)
14714         (ravenscar_thread_target::prepare_to_store): Update.
14715         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14716         Remove.
14717         (struct ppc_ravenscar_powerpc_ops): Derive from
14718         ravenscar_arch_ops.
14719         (ppc_ravenscar_powerpc_ops::fetch_registers)
14720         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14721         (ppc_ravenscar_powerpc_ops): Redefine.
14722         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14723         (ppc_ravenscar_e500_ops::fetch_registers)
14724         (ppc_ravenscar_e500_ops::store_registers): Now methods.
14725         (ppc_ravenscar_e500_ops): Redefine.
14726         * aarch64-ravenscar-thread.c
14727         (aarch64_ravenscar_generic_prepare_to_store): Remove.
14728         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14729         (aarch64_ravenscar_fetch_registers)
14730         (aarch64_ravenscar_store_registers): Now methods.
14731         (aarch64_ravenscar_ops): Redefine.
14732
14733 2019-02-15  Tom Tromey  <tromey@adacore.com>
14734
14735         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14736         (ravenscar_thread_target::stopped_by_hw_breakpoint)
14737         (ravenscar_thread_target::stopped_by_watchpoint)
14738         (ravenscar_thread_target::stopped_data_address)
14739         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14740
14741 2019-02-15  Tom Tromey  <tromey@adacore.com>
14742
14743         * ravenscar-thread.c: Fix some typos.
14744
14745 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14746             Tom Tromey  <tromey@adacore.com>
14747
14748         * ada-lang.c (ada_exception_sal): Change addr_string to a
14749         std::string.
14750         (create_ada_exception_catchpoint): Update.
14751
14752 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14753             Tom Tromey  <tromey@adacore.com>
14754
14755         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14756         (bp_location_ops): Remove.
14757         (base_breakpoint_allocate_location): Update.
14758         (free_bp_location): Update.
14759         * ada-lang.c (class ada_catchpoint_location)
14760         <ada_catchpoint_location>: Remove ops parameter.
14761         (ada_catchpoint_location_dtor): Remove.
14762         (ada_catchpoint_location_ops): Remove.
14763         (allocate_location_exception): Update.
14764         * breakpoint.h (struct bp_location_ops): Remove.
14765         (class bp_location) <bp_location>: Remove bp_location_ops
14766         parameter.
14767         <~bp_location>: Add destructor.
14768         <ops>: Remove.
14769
14770 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14771             Pedro Alves  <palves@redhat.com>
14772
14773         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14774         'PATH_MAX'.
14775
14776 2019-02-14  David Michael  <fedora.dm0@gmail.com>
14777             Samuel Thibault  <samuel.thibault@gnu.org>
14778             Thomas Schwinge  <thomas@codesourcery.com>
14779
14780         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14781         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14782
14783 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14784
14785         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14786         (check_empty): Use "const char *".
14787
14788         * gnu-nat.c (gnu_nat_target::detach): Instead of
14789         'detach_inferior (pid)' call
14790         'detach_inferior (find_inferior_pid (pid))'.
14791
14792         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14793         'nat/fork-inferior.o'.
14794         * gnu-nat.c: #include "nat/fork-inferior.h".
14795
14796         * gnu-nat.c (gnu_nat_target::detach): Instead of
14797         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14798         * gnu-nat.h: #include "inf-child.h".
14799         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14800         'i386_gnu_nat_target::fetch_registers'.
14801         (gnu_store_registers): Rename/move to
14802         'i386_gnu_nat_target::store_registers'.
14803
14804         * config/i386/nm-i386gnu.h: Don't "#include" any files.
14805         * gnu-nat.h (mach_thread_info): New function.
14806         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14807
14808         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14809
14810 2019-02-14  Frederic Konrad  <konrad@adacore.com>
14811
14812         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14813
14814 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
14815
14816         * windows-nat.c (windows_add_thread): Add new parameter
14817         "main_thread_p" with default value set to false.  Update
14818         function documentation as well as all callers.
14819         (windows_delete_thread): Likewise.
14820         (fake_create_process): Update call to windows_add_thread.
14821         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14822         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14823         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14824         call to windows_delete_thread.
14825
14826 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
14827
14828         * MAINTAINERS: Add Andrew Burgess as global maintainer.
14829
14830 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14831
14832         * symfile.c (find_separate_debug_file): Use canonical path of
14833         sysroot with child_path instead of gdb_sysroot if it is valid.
14834
14835 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14836
14837         * symfile.c (find_separate_debug_file): Use child_path to
14838         determine if an object file is under a sysroot.
14839
14840 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14841
14842         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14843         unittests/child-path-selftests.c.
14844         * common/pathstuff.c (child_path): New function.
14845         * common/pathstuff.h (child_path): New prototype.
14846         * unittests/child-path-selftests.c: New file.
14847
14848 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14849
14850         * symfile.c (find_separate_debug_file): Look for separate debug
14851         files in debug directories under the sysroot.
14852
14853 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14854
14855         * symtab.h (struct minimal_symbol data_p): New const method.
14856         (struct minimal_symbol text_p): Likewise.
14857         * symtab.c (output_source_filename): Use file name style
14858         to print file name.
14859         (print_symbol_info): Likewise.
14860         (print_msymbol_info): Use address style to print addresses.
14861         Use function name style to print executable text symbols.
14862         (expand_symtab_containing_pc): Use data_p.
14863         (find_pc_sect_compunit_symtab): Likewise.
14864
14865 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14866
14867         * breakpoint.c (describe_other_breakpoints): Use address style
14868         to print addresses.
14869         (say_where): Likewise.
14870
14871 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14872
14873         * ada-typeprint.c (print_func_type): Print function name
14874         style to print function name.
14875         * c-typeprint.c (c_print_type_1): Likewise.
14876
14877 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
14878
14879         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14880         for execve.
14881
14882 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14883
14884         * c-exp.y (direct_abs_decl): Use emplace_back to record the
14885         type_stack.
14886
14887 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
14888
14889         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14890         TYPE_CODE_REF types.
14891
14892 2019-02-08  Jim Wilson  <jimw@sifive.com>
14893
14894         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14895         (riscv_linux_fregset): New.
14896         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14897
14898 2019-02-07  Tom Tromey  <tom@tromey.com>
14899
14900         * thread.c (thread_cancel_execution_command): Update.
14901         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14902         methods.
14903         (struct thread_fsm_ops): Remove.
14904         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14905         (thread_fsm_should_stop, thread_fsm_return_value)
14906         (thread_fsm_set_finished, thread_fsm_finished_p)
14907         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14908         Don't declare.
14909         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14910         * infrun.c (clear_proceed_status_thread)
14911         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14912         (print_stop_event): Update.
14913         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14914         Add constructor.
14915         (step_command_fsm_ops): Remove.
14916         (new_step_command_fsm): Remove.
14917         (step_1): Update.
14918         (step_command_fsm::should_stop): Rename from
14919         step_command_fsm_should_stop.
14920         (step_command_fsm::clean_up): Rename from
14921         step_command_fsm_clean_up.
14922         (step_command_fsm::do_async_reply_reason): Rename from
14923         step_command_fsm_async_reply_reason.
14924         (struct until_next_fsm): Inherit from thread_fsm.  Add
14925         constructor.
14926         (until_next_fsm_ops): Remove.
14927         (new_until_next_fsm): Remove.
14928         (until_next_fsm::should_stop): Rename from
14929         until_next_fsm_should_stop.
14930         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14931         (until_next_fsm::do_async_reply_reason): Rename from
14932         until_next_fsm_async_reply_reason.
14933         (struct finish_command_fsm): Inherit from thread_fsm.  Add
14934         constructor.  Change type of breakpoint.
14935         (finish_command_fsm_ops): Remove.
14936         (new_finish_command_fsm): Remove.
14937         (finish_command_fsm::should_stop): Rename from
14938         finish_command_fsm_should_stop.
14939         (finish_command_fsm::clean_up): Rename from
14940         finish_command_fsm_clean_up.
14941         (finish_command_fsm::return_value): Rename from
14942         finish_command_fsm_return_value.
14943         (finish_command_fsm::do_async_reply_reason): Rename from
14944         finish_command_fsm_async_reply_reason.
14945         (finish_command): Update.
14946         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14947         Add constructor.
14948         (call_thread_fsm_ops): Remove.
14949         (call_thread_fsm::call_thread_fsm): Rename from
14950         new_call_thread_fsm.
14951         (call_thread_fsm::should_stop): Rename from
14952         call_thread_fsm_should_stop.
14953         (call_thread_fsm::should_notify_stop): Rename from
14954         call_thread_fsm_should_notify_stop.
14955         (run_inferior_call, call_function_by_hand_dummy): Update.
14956         * cli/cli-interp.c (should_print_stop_to_console): Update.
14957         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14958         Add constructor.  Change type of location_breakpoint,
14959         caller_breakpoint.
14960         (until_break_fsm_ops): Remove.
14961         (new_until_break_fsm): Remove.
14962         (until_break_fsm::should_stop): Rename from
14963         until_break_fsm_should_stop.
14964         (until_break_fsm::clean_up): Rename from
14965         until_break_fsm_clean_up.
14966         (until_break_fsm::do_async_reply_reason): Rename from
14967         until_break_fsm_async_reply_reason.
14968         (until_break_command): Update.
14969         * thread-fsm.c: Remove.
14970         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14971
14972 2019-02-07  Tom Tromey  <tom@tromey.com>
14973
14974         * yy-remap.h: Add include guard.
14975         * xtensa-tdep.h: Add include guard.
14976         * xcoffread.h: Rename include guard.
14977         * varobj-iter.h: Add include guard.
14978         * tui/tui.h: Rename include guard.
14979         * tui/tui-winsource.h: Rename include guard.
14980         * tui/tui-wingeneral.h: Rename include guard.
14981         * tui/tui-windata.h: Rename include guard.
14982         * tui/tui-win.h: Rename include guard.
14983         * tui/tui-stack.h: Rename include guard.
14984         * tui/tui-source.h: Rename include guard.
14985         * tui/tui-regs.h: Rename include guard.
14986         * tui/tui-out.h: Rename include guard.
14987         * tui/tui-layout.h: Rename include guard.
14988         * tui/tui-io.h: Rename include guard.
14989         * tui/tui-hooks.h: Rename include guard.
14990         * tui/tui-file.h: Rename include guard.
14991         * tui/tui-disasm.h: Rename include guard.
14992         * tui/tui-data.h: Rename include guard.
14993         * tui/tui-command.h: Rename include guard.
14994         * tic6x-tdep.h: Add include guard.
14995         * target/waitstatus.h: Rename include guard.
14996         * target/wait.h: Rename include guard.
14997         * target/target.h: Rename include guard.
14998         * target/resume.h: Rename include guard.
14999         * target-float.h: Rename include guard.
15000         * stabsread.h: Add include guard.
15001         * rs6000-tdep.h: Add include guard.
15002         * riscv-fbsd-tdep.h: Add include guard.
15003         * regformats/regdef.h: Rename include guard.
15004         * record.h: Rename include guard.
15005         * python/python.h: Rename include guard.
15006         * python/python-internal.h: Rename include guard.
15007         * python/py-stopevent.h: Rename include guard.
15008         * python/py-ref.h: Rename include guard.
15009         * python/py-record.h: Rename include guard.
15010         * python/py-record-full.h: Rename include guard.
15011         * python/py-record-btrace.h: Rename include guard.
15012         * python/py-instruction.h: Rename include guard.
15013         * python/py-events.h: Rename include guard.
15014         * python/py-event.h: Rename include guard.
15015         * procfs.h: Add include guard.
15016         * proc-utils.h: Add include guard.
15017         * p-lang.h: Add include guard.
15018         * or1k-tdep.h: Rename include guard.
15019         * observable.h: Rename include guard.
15020         * nto-tdep.h: Rename include guard.
15021         * nat/x86-linux.h: Rename include guard.
15022         * nat/x86-linux-dregs.h: Rename include guard.
15023         * nat/x86-gcc-cpuid.h: Add include guard.
15024         * nat/x86-dregs.h: Rename include guard.
15025         * nat/x86-cpuid.h: Rename include guard.
15026         * nat/ppc-linux.h: Rename include guard.
15027         * nat/mips-linux-watch.h: Rename include guard.
15028         * nat/linux-waitpid.h: Rename include guard.
15029         * nat/linux-ptrace.h: Rename include guard.
15030         * nat/linux-procfs.h: Rename include guard.
15031         * nat/linux-osdata.h: Rename include guard.
15032         * nat/linux-nat.h: Rename include guard.
15033         * nat/linux-namespaces.h: Rename include guard.
15034         * nat/linux-btrace.h: Rename include guard.
15035         * nat/glibc_thread_db.h: Rename include guard.
15036         * nat/gdb_thread_db.h: Rename include guard.
15037         * nat/gdb_ptrace.h: Rename include guard.
15038         * nat/fork-inferior.h: Rename include guard.
15039         * nat/amd64-linux-siginfo.h: Rename include guard.
15040         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15041         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15042         * nat/aarch64-linux.h: Rename include guard.
15043         * nat/aarch64-linux-hw-point.h: Rename include guard.
15044         * mn10300-tdep.h: Add include guard.
15045         * mips-linux-tdep.h: Add include guard.
15046         * mi/mi-parse.h: Rename include guard.
15047         * mi/mi-out.h: Rename include guard.
15048         * mi/mi-main.h: Rename include guard.
15049         * mi/mi-interp.h: Rename include guard.
15050         * mi/mi-getopt.h: Rename include guard.
15051         * mi/mi-console.h: Rename include guard.
15052         * mi/mi-common.h: Rename include guard.
15053         * mi/mi-cmds.h: Rename include guard.
15054         * mi/mi-cmd-break.h: Rename include guard.
15055         * m2-lang.h: Add include guard.
15056         * location.h: Rename include guard.
15057         * linux-record.h: Rename include guard.
15058         * linux-nat.h: Add include guard.
15059         * linux-fork.h: Add include guard.
15060         * i386-darwin-tdep.h: Rename include guard.
15061         * hppa-linux-offsets.h: Add include guard.
15062         * guile/guile.h: Rename include guard.
15063         * guile/guile-internal.h: Rename include guard.
15064         * gnu-nat.h: Rename include guard.
15065         * gdb-stabs.h: Rename include guard.
15066         * frv-tdep.h: Add include guard.
15067         * f-lang.h: Add include guard.
15068         * event-loop.h: Add include guard.
15069         * darwin-nat.h: Rename include guard.
15070         * cp-abi.h: Rename include guard.
15071         * config/sparc/nm-sol2.h: Rename include guard.
15072         * config/nm-nto.h: Rename include guard.
15073         * config/nm-linux.h: Add include guard.
15074         * config/i386/nm-i386gnu.h: Rename include guard.
15075         * config/djgpp/nl_types.h: Rename include guard.
15076         * config/djgpp/langinfo.h: Rename include guard.
15077         * compile/gcc-cp-plugin.h: Add include guard.
15078         * compile/gcc-c-plugin.h: Add include guard.
15079         * compile/compile.h: Rename include guard.
15080         * compile/compile-object-run.h: Rename include guard.
15081         * compile/compile-object-load.h: Rename include guard.
15082         * compile/compile-internal.h: Rename include guard.
15083         * compile/compile-cplus.h: Rename include guard.
15084         * compile/compile-c.h: Rename include guard.
15085         * common/xml-utils.h: Rename include guard.
15086         * common/x86-xstate.h: Rename include guard.
15087         * common/version.h: Rename include guard.
15088         * common/vec.h: Rename include guard.
15089         * common/tdesc.h: Rename include guard.
15090         * common/selftest.h: Rename include guard.
15091         * common/scoped_restore.h: Rename include guard.
15092         * common/scoped_mmap.h: Rename include guard.
15093         * common/scoped_fd.h: Rename include guard.
15094         * common/safe-iterator.h: Rename include guard.
15095         * common/run-time-clock.h: Rename include guard.
15096         * common/refcounted-object.h: Rename include guard.
15097         * common/queue.h: Rename include guard.
15098         * common/ptid.h: Rename include guard.
15099         * common/print-utils.h: Rename include guard.
15100         * common/preprocessor.h: Rename include guard.
15101         * common/pathstuff.h: Rename include guard.
15102         * common/observable.h: Rename include guard.
15103         * common/netstuff.h: Rename include guard.
15104         * common/job-control.h: Rename include guard.
15105         * common/host-defs.h: Rename include guard.
15106         * common/gdb_wait.h: Rename include guard.
15107         * common/gdb_vecs.h: Rename include guard.
15108         * common/gdb_unlinker.h: Rename include guard.
15109         * common/gdb_unique_ptr.h: Rename include guard.
15110         * common/gdb_tilde_expand.h: Rename include guard.
15111         * common/gdb_sys_time.h: Rename include guard.
15112         * common/gdb_string_view.h: Rename include guard.
15113         * common/gdb_splay_tree.h: Rename include guard.
15114         * common/gdb_setjmp.h: Rename include guard.
15115         * common/gdb_ref_ptr.h: Rename include guard.
15116         * common/gdb_optional.h: Rename include guard.
15117         * common/gdb_locale.h: Rename include guard.
15118         * common/gdb_assert.h: Rename include guard.
15119         * common/filtered-iterator.h: Rename include guard.
15120         * common/filestuff.h: Rename include guard.
15121         * common/fileio.h: Rename include guard.
15122         * common/environ.h: Rename include guard.
15123         * common/common-utils.h: Rename include guard.
15124         * common/common-types.h: Rename include guard.
15125         * common/common-regcache.h: Rename include guard.
15126         * common/common-inferior.h: Rename include guard.
15127         * common/common-gdbthread.h: Rename include guard.
15128         * common/common-exceptions.h: Rename include guard.
15129         * common/common-defs.h: Rename include guard.
15130         * common/common-debug.h: Rename include guard.
15131         * common/cleanups.h: Rename include guard.
15132         * common/buffer.h: Rename include guard.
15133         * common/btrace-common.h: Rename include guard.
15134         * common/break-common.h: Rename include guard.
15135         * cli/cli-utils.h: Rename include guard.
15136         * cli/cli-style.h: Rename include guard.
15137         * cli/cli-setshow.h: Rename include guard.
15138         * cli/cli-script.h: Rename include guard.
15139         * cli/cli-interp.h: Rename include guard.
15140         * cli/cli-decode.h: Rename include guard.
15141         * cli/cli-cmds.h: Rename include guard.
15142         * charset-list.h: Add include guard.
15143         * buildsym-legacy.h: Rename include guard.
15144         * bfin-tdep.h: Add include guard.
15145         * ax.h: Rename include guard.
15146         * arm-linux-tdep.h: Add include guard.
15147         * arm-fbsd-tdep.h: Add include guard.
15148         * arch/xtensa.h: Rename include guard.
15149         * arch/tic6x.h: Add include guard.
15150         * arch/i386.h: Add include guard.
15151         * arch/arm.h: Rename include guard.
15152         * arch/arm-linux.h: Rename include guard.
15153         * arch/arm-get-next-pcs.h: Rename include guard.
15154         * arch/amd64.h: Add include guard.
15155         * arch/aarch64-insn.h: Rename include guard.
15156         * arch-utils.h: Rename include guard.
15157         * annotate.h: Add include guard.
15158         * amd64-darwin-tdep.h: Rename include guard.
15159         * aarch64-linux-tdep.h: Add include guard.
15160         * aarch64-fbsd-tdep.h: Add include guard.
15161         * aarch32-linux-nat.h: Add include guard.
15162
15163 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15164
15165         * macrotab.c (macro_define_internal): New function that
15166         factorizes macro_define_object_internal and macro_define_function
15167         code.
15168         (macro_define_object_internal): Use macro_define_internal.
15169         (macro_define_function): Likewise.
15170
15171 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15172
15173         * macrocmd.c (extract_identifier): Return
15174         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15175         callers.
15176
15177 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
15178
15179         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15180
15181 2019-02-05  Tom Tromey  <tom@tromey.com>
15182
15183         * target.c (target_stack::unpush): Move assertion earlier.
15184
15185 2019-01-30  Tom Tromey  <tom@tromey.com>
15186
15187         PR python/23615:
15188         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15189         (gdbpy_parse_and_eval): Likewise.
15190         * python/python-internal.h (gdbpy_allow_threads): New class.
15191
15192 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
15193
15194         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15195         (aarch64_fbsd_fpregmap): Move earlier.
15196         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15197         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15198         instead of individual calls to trad_frame_set_reg_addr.
15199         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15200         earlier.
15201         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15202         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15203         instead of individual calls to trad_frame_set_reg_addr.
15204
15205 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
15206
15207         * CONTRIBUTE: Replace contribution list with wiki link.
15208
15209 2019-01-25  Tom Tromey  <tom@tromey.com>
15210
15211         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15212
15213 2019-01-25  Tom Tromey  <tom@tromey.com>
15214
15215         * xtensa-linux-nat.c: Fix common/ includes.
15216         * xml-support.h: Fix common/ includes.
15217         * xml-support.c: Fix common/ includes.
15218         * x86-linux-nat.c: Fix common/ includes.
15219         * windows-nat.c: Fix common/ includes.
15220         * varobj.h: Fix common/ includes.
15221         * varobj.c: Fix common/ includes.
15222         * value.c: Fix common/ includes.
15223         * valops.c: Fix common/ includes.
15224         * utils.c: Fix common/ includes.
15225         * unittests/xml-utils-selftests.c: Fix common/ includes.
15226         * unittests/utils-selftests.c: Fix common/ includes.
15227         * unittests/unpack-selftests.c: Fix common/ includes.
15228         * unittests/tracepoint-selftests.c: Fix common/ includes.
15229         * unittests/style-selftests.c: Fix common/ includes.
15230         * unittests/string_view-selftests.c: Fix common/ includes.
15231         * unittests/scoped_restore-selftests.c: Fix common/ includes.
15232         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15233         * unittests/scoped_fd-selftests.c: Fix common/ includes.
15234         * unittests/rsp-low-selftests.c: Fix common/ includes.
15235         * unittests/parse-connection-spec-selftests.c: Fix common/
15236         includes.
15237         * unittests/optional-selftests.c: Fix common/ includes.
15238         * unittests/offset-type-selftests.c: Fix common/ includes.
15239         * unittests/observable-selftests.c: Fix common/ includes.
15240         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15241         * unittests/memrange-selftests.c: Fix common/ includes.
15242         * unittests/memory-map-selftests.c: Fix common/ includes.
15243         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15244         * unittests/function-view-selftests.c: Fix common/ includes.
15245         * unittests/environ-selftests.c: Fix common/ includes.
15246         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15247         * unittests/common-utils-selftests.c: Fix common/ includes.
15248         * unittests/cli-utils-selftests.c: Fix common/ includes.
15249         * unittests/array-view-selftests.c: Fix common/ includes.
15250         * ui-file.c: Fix common/ includes.
15251         * tui/tui-io.c: Fix common/ includes.
15252         * tracepoint.h: Fix common/ includes.
15253         * tracepoint.c: Fix common/ includes.
15254         * tracefile-tfile.c: Fix common/ includes.
15255         * top.h: Fix common/ includes.
15256         * top.c: Fix common/ includes.
15257         * thread.c: Fix common/ includes.
15258         * target/waitstatus.h: Fix common/ includes.
15259         * target/waitstatus.c: Fix common/ includes.
15260         * target.h: Fix common/ includes.
15261         * target.c: Fix common/ includes.
15262         * target-memory.c: Fix common/ includes.
15263         * target-descriptions.c: Fix common/ includes.
15264         * symtab.h: Fix common/ includes.
15265         * symfile.c: Fix common/ includes.
15266         * stap-probe.c: Fix common/ includes.
15267         * spu-linux-nat.c: Fix common/ includes.
15268         * sparc-nat.c: Fix common/ includes.
15269         * source.c: Fix common/ includes.
15270         * solib.c: Fix common/ includes.
15271         * solib-target.c: Fix common/ includes.
15272         * ser-unix.c: Fix common/ includes.
15273         * ser-tcp.c: Fix common/ includes.
15274         * ser-pipe.c: Fix common/ includes.
15275         * ser-base.c: Fix common/ includes.
15276         * selftest-arch.c: Fix common/ includes.
15277         * s12z-tdep.c: Fix common/ includes.
15278         * rust-exp.y: Fix common/ includes.
15279         * rs6000-aix-tdep.c: Fix common/ includes.
15280         * riscv-tdep.c: Fix common/ includes.
15281         * remote.c: Fix common/ includes.
15282         * remote-notif.h: Fix common/ includes.
15283         * remote-fileio.h: Fix common/ includes.
15284         * remote-fileio.c: Fix common/ includes.
15285         * regcache.h: Fix common/ includes.
15286         * regcache.c: Fix common/ includes.
15287         * record-btrace.c: Fix common/ includes.
15288         * python/python.c: Fix common/ includes.
15289         * python/py-type.c: Fix common/ includes.
15290         * python/py-inferior.c: Fix common/ includes.
15291         * progspace.h: Fix common/ includes.
15292         * producer.c: Fix common/ includes.
15293         * procfs.c: Fix common/ includes.
15294         * proc-api.c: Fix common/ includes.
15295         * printcmd.c: Fix common/ includes.
15296         * ppc-linux-nat.c: Fix common/ includes.
15297         * parser-defs.h: Fix common/ includes.
15298         * osdata.c: Fix common/ includes.
15299         * obsd-nat.c: Fix common/ includes.
15300         * nat/x86-linux.c: Fix common/ includes.
15301         * nat/x86-linux-dregs.c: Fix common/ includes.
15302         * nat/x86-dregs.h: Fix common/ includes.
15303         * nat/x86-dregs.c: Fix common/ includes.
15304         * nat/ppc-linux.c: Fix common/ includes.
15305         * nat/mips-linux-watch.h: Fix common/ includes.
15306         * nat/mips-linux-watch.c: Fix common/ includes.
15307         * nat/linux-waitpid.c: Fix common/ includes.
15308         * nat/linux-ptrace.h: Fix common/ includes.
15309         * nat/linux-ptrace.c: Fix common/ includes.
15310         * nat/linux-procfs.c: Fix common/ includes.
15311         * nat/linux-personality.c: Fix common/ includes.
15312         * nat/linux-osdata.c: Fix common/ includes.
15313         * nat/linux-namespaces.c: Fix common/ includes.
15314         * nat/linux-btrace.h: Fix common/ includes.
15315         * nat/linux-btrace.c: Fix common/ includes.
15316         * nat/fork-inferior.c: Fix common/ includes.
15317         * nat/amd64-linux-siginfo.c: Fix common/ includes.
15318         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15319         * nat/aarch64-linux.c: Fix common/ includes.
15320         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15321         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15322         * namespace.h: Fix common/ includes.
15323         * mips-linux-tdep.c: Fix common/ includes.
15324         * minsyms.c: Fix common/ includes.
15325         * mi/mi-parse.h: Fix common/ includes.
15326         * mi/mi-main.c: Fix common/ includes.
15327         * mi/mi-cmd-env.c: Fix common/ includes.
15328         * memrange.h: Fix common/ includes.
15329         * memattr.c: Fix common/ includes.
15330         * maint.h: Fix common/ includes.
15331         * maint.c: Fix common/ includes.
15332         * main.c: Fix common/ includes.
15333         * machoread.c: Fix common/ includes.
15334         * location.c: Fix common/ includes.
15335         * linux-thread-db.c: Fix common/ includes.
15336         * linux-nat.c: Fix common/ includes.
15337         * linux-fork.c: Fix common/ includes.
15338         * inline-frame.c: Fix common/ includes.
15339         * infrun.c: Fix common/ includes.
15340         * inflow.c: Fix common/ includes.
15341         * inferior.h: Fix common/ includes.
15342         * inferior.c: Fix common/ includes.
15343         * infcmd.c: Fix common/ includes.
15344         * inf-ptrace.c: Fix common/ includes.
15345         * inf-child.c: Fix common/ includes.
15346         * ia64-linux-nat.c: Fix common/ includes.
15347         * i387-tdep.c: Fix common/ includes.
15348         * i386-tdep.c: Fix common/ includes.
15349         * i386-linux-tdep.c: Fix common/ includes.
15350         * i386-linux-nat.c: Fix common/ includes.
15351         * i386-go32-tdep.c: Fix common/ includes.
15352         * i386-fbsd-tdep.c: Fix common/ includes.
15353         * i386-fbsd-nat.c: Fix common/ includes.
15354         * guile/scm-type.c: Fix common/ includes.
15355         * guile/guile.c: Fix common/ includes.
15356         * go32-nat.c: Fix common/ includes.
15357         * gnu-nat.c: Fix common/ includes.
15358         * gdbthread.h: Fix common/ includes.
15359         * gdbarch-selftests.c: Fix common/ includes.
15360         * gdb_usleep.c: Fix common/ includes.
15361         * gdb_select.h: Fix common/ includes.
15362         * gdb_bfd.c: Fix common/ includes.
15363         * gcore.c: Fix common/ includes.
15364         * fork-child.c: Fix common/ includes.
15365         * findvar.c: Fix common/ includes.
15366         * fbsd-nat.c: Fix common/ includes.
15367         * event-top.c: Fix common/ includes.
15368         * event-loop.c: Fix common/ includes.
15369         * dwarf2read.c: Fix common/ includes.
15370         * dwarf2loc.c: Fix common/ includes.
15371         * dwarf2-frame.c: Fix common/ includes.
15372         * dwarf-index-cache.c: Fix common/ includes.
15373         * dtrace-probe.c: Fix common/ includes.
15374         * disasm-selftests.c: Fix common/ includes.
15375         * defs.h: Fix common/ includes.
15376         * csky-tdep.c: Fix common/ includes.
15377         * cp-valprint.c: Fix common/ includes.
15378         * cp-support.h: Fix common/ includes.
15379         * cp-support.c: Fix common/ includes.
15380         * corelow.c: Fix common/ includes.
15381         * completer.h: Fix common/ includes.
15382         * completer.c: Fix common/ includes.
15383         * compile/compile.c: Fix common/ includes.
15384         * compile/compile-loc2c.c: Fix common/ includes.
15385         * compile/compile-cplus-types.c: Fix common/ includes.
15386         * compile/compile-cplus-symbols.c: Fix common/ includes.
15387         * command.h: Fix common/ includes.
15388         * cli/cli-dump.c: Fix common/ includes.
15389         * cli/cli-cmds.c: Fix common/ includes.
15390         * charset.c: Fix common/ includes.
15391         * build-id.c: Fix common/ includes.
15392         * btrace.h: Fix common/ includes.
15393         * btrace.c: Fix common/ includes.
15394         * breakpoint.h: Fix common/ includes.
15395         * breakpoint.c: Fix common/ includes.
15396         * ax.h:
15397         (enum agent_op): Fix common/ includes.
15398         * ax-general.c (struct aop_map): Fix common/ includes.
15399         * ax-gdb.c: Fix common/ includes.
15400         * auxv.c: Fix common/ includes.
15401         * auto-load.c: Fix common/ includes.
15402         * arm-tdep.c: Fix common/ includes.
15403         * arch/riscv.c: Fix common/ includes.
15404         * arch/ppc-linux-common.c: Fix common/ includes.
15405         * arch/i386.c: Fix common/ includes.
15406         * arch/arm.c: Fix common/ includes.
15407         * arch/arm-linux.c: Fix common/ includes.
15408         * arch/arm-get-next-pcs.c: Fix common/ includes.
15409         * arch/amd64.c: Fix common/ includes.
15410         * arch/aarch64.c: Fix common/ includes.
15411         * arch/aarch64-insn.c: Fix common/ includes.
15412         * arch-utils.c: Fix common/ includes.
15413         * amd64-windows-tdep.c: Fix common/ includes.
15414         * amd64-tdep.c: Fix common/ includes.
15415         * amd64-sol2-tdep.c: Fix common/ includes.
15416         * amd64-obsd-tdep.c: Fix common/ includes.
15417         * amd64-nbsd-tdep.c: Fix common/ includes.
15418         * amd64-linux-tdep.c: Fix common/ includes.
15419         * amd64-linux-nat.c: Fix common/ includes.
15420         * amd64-fbsd-tdep.c: Fix common/ includes.
15421         * amd64-fbsd-nat.c: Fix common/ includes.
15422         * amd64-dicos-tdep.c: Fix common/ includes.
15423         * amd64-darwin-tdep.c: Fix common/ includes.
15424         * agent.c: Fix common/ includes.
15425         * ada-lang.h: Fix common/ includes.
15426         * ada-lang.c: Fix common/ includes.
15427         * aarch64-tdep.c: Fix common/ includes.
15428
15429 2019-01-25  Tom Tromey  <tom@tromey.com>
15430
15431         * common/create-version.sh: Use common/version.h.
15432
15433 2019-01-24  Pedro Alves  <palves@redhat.com>
15434
15435         * infrun.c (signal_stop, signal_print, signal_program)
15436         (signal_catch, signal_pass): Now arrays instead of pointers.
15437         (update_signals_program_target, do_target_resume)
15438         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15439         * linux-nat.c (linux_nat_target::pass_signals)
15440         (linux_nat_target::create_inferior, linux_nat_target::attach):
15441         Adjust.
15442         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15443         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15444         * procfs.c (procfs_target::pass_signals): Adjust.
15445         * record-full.c (record_full_target::resume): Adjust.
15446         * remote.c (remote_target::pass_signals)
15447         (remote_target::program_signals): Adjust.
15448         * target-debug.h (target_debug_print_signals): Now takes a
15449         gdb::array_view as parameter.  Adjust.
15450         * target.h (target_ops) <pass_signals, program_signals>: Replace
15451         pointer and length parameters with gdb::array_view.
15452         (target_pass_signals, target_program_signals): Likewise.
15453         * target-delegates.c: Regenerate.
15454
15455 2019-01-24  Pedro Alves  <palves@redhat.com>
15456
15457         * common/forward-scope-exit.h
15458         (forward_scope_exit::forward_scope_exit): Pass arguments to
15459         m_bind_function directly, instead of creating a std::bind and
15460         copying that.
15461
15462 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
15463
15464         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15465         for static members.
15466         (pass_in_v_vfp_candidate): Likewise.
15467
15468 2019-01-23  Tom Tromey  <tom@tromey.com>
15469             Pedro Alves  <palves@redhat.com>
15470
15471         * regcache.c (class regcache_invalidator): Remove.
15472         (regcache::raw_write): Use make_scope_exit.
15473
15474 2019-01-23  Tom Tromey  <tom@tromey.com>
15475
15476         * ui-out.h (class ui_out_emit_type): Update comment.
15477
15478 2019-01-23  Tom Tromey  <tom@tromey.com>
15479
15480         * infrun.c (fetch_inferior_event): Update comment.
15481
15482 2019-01-23  Tom Tromey  <tom@tromey.com>
15483             Pedro Alves  <palves@redhat.com>
15484
15485         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15486         parameter.
15487         (fetch_inferior_event): Use SCOPE_EXIT.
15488
15489
15490 2019-01-23  Tom Tromey  <tom@tromey.com>
15491             Pedro Alves  <palves@redhat.com>
15492
15493         * infrun.c (disable_thread_events): Delete.
15494         (stop_all_threads): Use SCOPE_EXIT.
15495
15496 2019-01-23  Tom Tromey  <tom@tromey.com>
15497             Pedro Alves  <palves@redhat.com>
15498
15499         * symfile.c: Include forward-scope-exit.h.
15500         (clear_symtab_users_cleanup): Replace forward declaration with
15501         a FORWARD_SCOPE_EXIT.
15502         (syms_from_objfile_1): Use the forward_scope_exit and
15503         gdb::optional instead of cleanup_function.
15504         (reread_symbols): Use the forward_scope_exit instead of
15505         cleanup_function.
15506         (clear_symtab_users_cleanup): Remove function.
15507
15508 2019-01-23  Tom Tromey  <tom@tromey.com>
15509             Pedro Alves  <palves@redhat.com>
15510
15511         * linux-nat.c: Include scope-exit.h.
15512         (cleanup_target_stop): Remove.
15513         (linux_nat_target::static_tracepoint_markers_by_strid): Use
15514         SCOPE_EXIT.
15515
15516 2019-01-23  Tom Tromey  <tom@tromey.com>
15517             Pedro Alves  <palves@redhat.com>
15518
15519         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15520         (call_function_by_hand_dummy): Use SCOPE_EXIT.
15521
15522 2019-01-23  Tom Tromey  <tom@tromey.com>
15523             Andrew Burgess  <andrew.burgess@embecosm.com>
15524             Pedro Alves  <palves@redhat.com>
15525
15526         * infrun.c (fetch_inferior_event): Use scope_exit.
15527         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15528         * top.c (execute_command): Use scope_exit.
15529         * breakpoint.c (bpstat_do_actions): Use scope_exit.
15530         * utils.c (do_bpstat_clear_actions_cleanup)
15531         (make_bpstat_clear_actions_cleanup): Remove.
15532
15533 2019-01-23  Tom Tromey  <tom@tromey.com>
15534             Pedro Alves  <palves@redhat.com>
15535
15536         * infrun.c: Include "common/scope-exit.h"
15537         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15538         (wait_for_inferior): Use SCOPE_EXIT.
15539         (fetch_inferior_event): Use scope_exit.
15540
15541 2019-01-23  Tom Tromey  <tom@tromey.com>
15542             Pedro Alves  <palves@redhat.com>
15543
15544         * breakpoint.c (create_breakpoint): Remove cleanup.
15545
15546 2019-01-23  Tom Tromey  <tom@tromey.com>
15547             Andrew Burgess  <andrew.burgess@embecosm.com>
15548             Pedro Alves  <palves@redhat.com>
15549
15550 2019-01-23  Pedro Alves  <palves@redhat.com>
15551
15552         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15553
15554 2019-01-23  Pedro Alves  <palves@redhat.com>
15555             Andrew Burgess  <andrew.burgess@embecosm.com>
15556
15557         * gdbthread.h: Include "common/forward-scope-exit.h".
15558         (scoped_finish_thread_state): Redefine custom class in terms of
15559         forward_scope_exit.
15560
15561 2019-01-23  Pedro Alves  <palves@redhat.com>
15562             Andrew Burgess  <andrew.burgess@embecosm.com>
15563
15564         * common/forward-scope-exit.h: New file.
15565
15566 2019-01-23  Pedro Alves  <palves@redhat.com>
15567             Andrew Burgess  <andrew.burgess@embecosm.com>
15568             Tom Tromey  <tom@tromey.com>
15569
15570         * common/scope-exit.h: New file.
15571
15572 2019-01-23  Pedro Alves  <palves@redhat.com>
15573
15574         * common/preprocessor.h (ESC): Rename to ...
15575         (ESC_PARENS): ... this.
15576         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15577         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15578
15579 2019-01-23  Tom Tromey  <tom@tromey.com>
15580
15581         * language.h (class scoped_switch_to_sym_language_if_auto):
15582         Initialize m_lang in both cases.
15583
15584 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
15585
15586         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15587         with XCNEW.
15588
15589 2019-01-22  Tom Tromey  <tom@tromey.com>
15590
15591         * corelow.c: Do not include sys/file.h.
15592
15593 2019-01-22  Tom Tromey  <tom@tromey.com>
15594
15595         * tui/tui-wingeneral.h: Include gdb_curses.h.
15596
15597 2019-01-22  Tom Tromey  <tom@tromey.com>
15598
15599         * source-cache.h (class source_cache) <get_source_lines,
15600         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15601
15602 2019-01-22  Tom Tromey  <tom@tromey.com>
15603
15604         * remote-fileio.h (struct remote_target): Declare.
15605
15606 2019-01-22  Tom Tromey  <tom@tromey.com>
15607
15608         * python/py-arch.c: Do not include py-ref.h.
15609         * python/py-bpevent.c: Do not include py-ref.h.
15610         * python/py-cmd.c: Do not include py-ref.h.
15611         * python/py-continueevent.c: Do not include py-ref.h.
15612         * python/py-event.h: Do not include py-ref.h.
15613         * python/py-evtregistry.c: Do not include py-ref.h.
15614         * python/py-finishbreakpoint.c: Do not include py-ref.h.
15615         * python/py-frame.c: Do not include py-ref.h.
15616         * python/py-framefilter.c: Do not include py-ref.h.
15617         * python/py-function.c: Do not include py-ref.h.
15618         * python/py-infevents.c: Do not include py-ref.h.
15619         * python/py-linetable.c: Do not include py-ref.h.
15620         * python/py-objfile.c: Do not include py-ref.h.
15621         * python/py-param.c: Do not include py-ref.h.
15622         * python/py-prettyprint.c: Do not include py-ref.h.
15623         * python/py-progspace.c: Do not include py-ref.h.
15624         * python/py-symbol.c: Do not include py-ref.h.
15625         * python/py-symtab.c: Do not include py-ref.h.
15626         * python/py-type.c: Do not include py-ref.h.
15627         * python/py-unwind.c: Do not include py-ref.h.
15628         * python/py-utils.c: Do not include py-ref.h.
15629         * python/py-value.c: Do not include py-ref.h.
15630         * python/py-varobj.c: Do not include py-ref.h.
15631         * python/py-xmethods.c: Do not include py-ref.h.
15632         * python/python.c: Do not include py-ref.h.
15633         * varobj.c: Do not include py-ref.h.
15634
15635 2019-01-22  Tom Tromey  <tom@tromey.com>
15636
15637         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15638         keyword for bcache.
15639
15640 2019-01-22  Tom Tromey  <tom@tromey.com>
15641
15642         * compile/compile-cplus-types.c: Remove a comment by #include.
15643
15644 2019-01-22  Tom Tromey  <tom@tromey.com>
15645
15646         * compile/gcc-c-plugin.h: Include compile-internal.h.
15647
15648 2019-01-22  Tom Tromey  <tom@tromey.com>
15649
15650         * stabsread.c (EXTERN): Do not define.
15651         (symnum, next_symbol_text_func, processing_gcc_compilation)
15652         (within_function, global_sym_chain, global_stabs)
15653         (previous_stab_code, this_object_header_files)
15654         (n_this_object_header_files)
15655         (n_allocated_this_object_header_files): Define.
15656         * stabsread.h (EXTERN): Never define.  Use "extern".
15657
15658 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15659
15660         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15661         history_value.
15662
15663 2019-01-21  Tom Tromey  <tom@tromey.com>
15664
15665         * ui-out.c: Fix includes.
15666         * tui/tui-source.c: Fix includes.
15667         * target.c: Fix includes.
15668         * remote.c: Fix includes.
15669         * regcache.c: Fix includes.
15670         * python/py-block.c: Fix includes.
15671         * printcmd.c: Fix includes.
15672         * or1k-tdep.c: Fix includes.
15673         * mi/mi-main.c: Fix includes.
15674         * m32r-tdep.c: Fix includes.
15675         * csky-tdep.c: Fix includes.
15676         * compile/compile-cplus-types.c: Fix includes.
15677         * cli/cli-interp.c: Fix includes.
15678
15679 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
15680
15681         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15682         for padding.
15683
15684 2019-01-16  Tom Tromey  <tom@tromey.com>
15685
15686         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
15687         earlier.
15688         (struct objfile) <msymbols_range>: Move from top level.
15689         <msymbols>: New method.
15690         (class objfile_msymbols): Remove.
15691         * symtab.c (default_collect_symbol_completion_matches_break_on):
15692         Update.
15693         * symmisc.c (dump_msymbols): Update.
15694         * stabsread.c (scan_file_globals): Update.
15695         * objc-lang.c (info_selectors_command, info_classes_command)
15696         (find_methods): Update.
15697         * minsyms.c (find_solib_trampoline_target): Update.
15698         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15699         * coffread.c (coff_symfile_read): Update.
15700         * ada-lang.c (ada_lookup_simple_minsym)
15701         (ada_collect_symbol_completion_matches): Update.
15702
15703 2019-01-16  Tom Tromey  <tom@tromey.com>
15704
15705         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15706         type.  Remove no-argument constructor.
15707         <iterator::operator++>: Simplify.
15708         <begin>: Update.
15709         <end>: Use minimal_symbol_count.
15710
15711 2019-01-16  Tom Tromey  <tom@tromey.com>
15712
15713         * objfiles.h (struct objfile) <psymtabs>: New method.
15714         (class objfile_psymtabs): Remove.
15715         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15716         typedef.
15717         <range>: New method.
15718         (require_partial_symbols): Change return type.
15719         * psymtab.c (require_partial_symbols)
15720         (psym_expand_symtabs_matching): Update.
15721         * mdebugread.c (parse_partial_symbols): Update.
15722         * dbxread.c (dbx_end_psymtab): Update.
15723
15724 2019-01-15  Tom Tromey  <tom@tromey.com>
15725
15726         * symtab.c (lookup_objfile_from_block)
15727         (lookup_symbol_in_objfile_symtabs)
15728         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15729         (find_line_symtab, info_sources_command)
15730         (default_collect_symbol_completion_matches_break_on)
15731         (make_source_files_completion_list): Update.
15732         * symmisc.c (print_objfile_statistics, dump_objfile)
15733         (maintenance_print_symbols, maintenance_info_symtabs)
15734         (maintenance_check_symtabs, maintenance_info_line_tables):
15735         Update.
15736         * source.c (select_source_symtab)
15737         (forget_cached_source_info_for_objfile): Update.
15738         * objfiles.h (class objfile_compunits): Remove.
15739         (struct objfile) <compunits_range>: New typedef.
15740         (compunits): New method.
15741         * objfiles.c (objfile_relocate1): Update.
15742         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15743         * maint.c (count_symtabs_and_blocks): Update.
15744         * linespec.c (iterate_over_all_matching_symtabs): Update.
15745         * cp-support.c (add_symbol_overload_list_qualified): Update.
15746         * coffread.c (coff_symtab_read): Update.
15747         * ada-lang.c (add_nonlocal_symbols)
15748         (ada_collect_symbol_completion_matches)
15749         (ada_add_global_exceptions): Update.
15750
15751 2019-01-15  Tom Tromey  <tom@tromey.com>
15752
15753         * progspace.h (program_space) <objfiles_safe_range>: New
15754         typedef.
15755         <objfiles_safe>: New method.
15756         * objfiles.h (class all_objfiles_safe): Remove.
15757         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15758         * jit.c (jit_inferior_exit_hook): Update.
15759
15760 2019-01-17  Tom Tromey  <tom@tromey.com>
15761
15762         * progspace.h (program_space) <objfiles_range>: New typedef.
15763         <objfiles>: New method.
15764         <objfiles_head>: Rename from objfiles.
15765         (object_files): Update.
15766         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15767         * guile/scm-pretty-print.c
15768         (ppscm_find_pretty_printer_from_objfiles): Update.
15769         * guile/scm-objfile.c (gdbscm_objfiles): Update.
15770         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15771         Update.
15772         * python/py-progspace.c (pspy_get_objfiles): Update.
15773         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15774         Update.
15775         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15776         (objfpy_lookup_objfile_by_build_id): Update.
15777         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15778         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15779         Update.
15780         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15781         (expand_symtab_containing_pc, lookup_objfile_from_block)
15782         (lookup_static_symbol, basic_lookup_transparent_type)
15783         (find_pc_sect_compunit_symtab, find_symbol_at_address)
15784         (find_line_symtab, info_sources_command)
15785         (default_collect_symbol_completion_matches_break_on)
15786         (make_source_files_completion_list, find_main_name): Update.
15787         * symmisc.c (print_symbol_bcache_statistics)
15788         (print_objfile_statistics, maintenance_print_symbols)
15789         (maintenance_print_msymbols, maintenance_print_objfiles)
15790         (maintenance_info_symtabs, maintenance_check_symtabs)
15791         (maintenance_expand_symtabs, maintenance_info_line_tables):
15792         Update.
15793         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15794         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15795         (map_overlay_command, unmap_overlay_command)
15796         (simple_overlay_update, expand_symtabs_matching)
15797         (map_symbol_filenames): Update.
15798         * symfile-debug.c (set_debug_symfile): Update.
15799         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15800         Update.
15801         * source.c (select_source_symtab, forget_cached_source_info):
15802         Update.
15803         * solib.c (solib_read_symbols): Update.
15804         * solib-spu.c (append_ocl_sos): Update.
15805         * psymtab.c (maintenance_print_psymbols)
15806         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15807         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15808         * printcmd.c (info_symbol_command): Update.
15809         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15810         Update.
15811         * objfiles.h (class all_objfiles): Remove.
15812         * objfiles.c (have_partial_symbols, have_full_symbols)
15813         (have_minimal_symbols, qsort_cmp, update_section_map)
15814         (shared_objfile_contains_address_p)
15815         (default_iterate_over_objfiles_in_search_order): Update.
15816         * objc-lang.c (info_selectors_command, info_classes_command)
15817         (find_methods): Update.
15818         * minsyms.c (find_solib_trampoline_target): Update.
15819         * maint.c (maintenance_info_sections)
15820         (maintenance_translate_address, count_symtabs_and_blocks):
15821         Update.
15822         * main.c (captured_main_1): Update.
15823         * linux-thread-db.c (try_thread_db_load_from_pdir)
15824         (has_libpthread): Update.
15825         * linespec.c (iterate_over_all_matching_symtabs)
15826         (search_minsyms_for_name): Update.
15827         * jit.c (jit_find_objf_with_entry_addr): Update.
15828         * hppa-tdep.c (find_unwind_entry)
15829         (hppa_lookup_stub_minimal_symbol): Update.
15830         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15831         Update.
15832         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15833         (elf_gnu_ifunc_resolve_by_got): Update.
15834         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15835         * dwarf-index-write.c (save_gdb_index_command): Update.
15836         * cp-support.c (add_symbol_overload_list_qualified): Update.
15837         * breakpoint.c (create_overlay_event_breakpoint)
15838         (create_longjmp_master_breakpoint)
15839         (create_std_terminate_master_breakpoint)
15840         (create_exception_master_breakpoint): Update.
15841         * blockframe.c (find_pc_partial_function): Update.
15842         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15843         (ada_collect_symbol_completion_matches)
15844         (ada_add_global_exceptions): Update.
15845
15846 2019-01-17  Tom Tromey  <tom@tromey.com>
15847
15848         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
15849         declare VEC.
15850         (solib_target_parse_libraries): Change return type.
15851         (library_list_start_segment, library_list_start_section)
15852         (library_list_end_library, library_list_start_library); Update.
15853         (solib_target_free_library_list): Remove.
15854         (solib_target_parse_libraries): Remove cleanup.  Change return
15855         type.
15856         (solib_target_current_sos): Update.
15857
15858 2019-01-17  Tom Tromey  <tromey@bapiya>
15859
15860         * valprint.c: Replace "the the" with "the".
15861         * symtab.c: Replace "the the" with "the".
15862         * solib.c: Replace "the the" with "the".
15863         * solib-dsbt.c: Replace "the the" with "the".
15864         * linespec.c: Replace "the the" with "the".
15865         * dwarf2loc.h: Replace "the the" with "the".
15866         * amd64-windows-tdep.c: Replace "the the" with "the".
15867         * aarch64-tdep.c: Replace "the the" with "the".
15868
15869 2019-01-16  Keith Seitz  <keiths@redhat.com>
15870
15871         PR gdb/23773
15872         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15873         <builder>: Rename to ..
15874         <m_builder>: ... this and make private.
15875         (dwarf2_cu::get_builder): New method.  Change all users of
15876         `builder' to use this method.
15877         (dwarf2_start_symtab): Move to ...
15878         (dwarf2_cu::start_symtab): ... here.  Update all callers
15879         (setup_type_unit_groups): Move to ...
15880         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
15881         callers.
15882         (dwarf2_cu::reset_builder): New method.
15883         (process_full_compunit, process_full_type_unit): Use
15884         dwarf2_cu::reset_builder.
15885         (follow_die_offset): Record the ancestor CU if it is different
15886         from the followed DIE's CU.
15887         (follow_die_sig_1): Likewise.
15888
15889 2019-01-15  Tom Tromey  <tom@tromey.com>
15890
15891         * remote.c (class remote_state) <buf>: Now a char_vector.
15892         <buf_size>: Remove.
15893         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
15894         parameter.
15895         (remote_target::getpkt_or_notif_sane_1)
15896         (remote_target::getpkt_sane)
15897         (remote_target::getpkt_or_notif_sane): Likewise.
15898         (class remote_target) <putpkt>: New overload.
15899         (remote_target::read_frame): Change type of "buf_p".  Remove
15900         sizeof_p parameter.
15901         (packet_ok): New overload.
15902         (packet_check_result): New overload.
15903         Update all uses.
15904
15905 2019-01-14  Tom Tromey  <tom@tromey.com>
15906
15907         * remote-notif.c (handle_notification, remote_notif_ack)
15908         (remote_notif_parse): Make "buf" const.
15909         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15910         const.
15911         (remote_notif_parse, remote_notif_ack, handle_notification):
15912         Likewise.
15913         * remote.c (remote_notif_stop_parse): Make "buf" const.
15914         (remote_target::remote_parse_stop_reply): Make "buf" const.
15915         (remote_notif_stop_ack): Make "buf" const.
15916
15917 2019-01-14  Tom Tromey  <tom@tromey.com>
15918
15919         * remote.c (remote_console_output): Make parameter const.
15920
15921 2019-01-14  Tom Tromey  <tom@tromey.com>
15922
15923         * target-debug.h (target_debug_print_signals): Constify.
15924         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15925         * procfs.c (procfs_target::pass_signals): Update.
15926         * linux-nat.c (linux_nat_target::pass_signals): Update.
15927         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15928         * target-delegates.c: Rebuild.
15929         * remote.c (remote_target::program_signals): Update.
15930         (remote_target::pass_signals): Update.
15931         * target.c (target_pass_signals): Constify argument.
15932         (target_program_signals): Likewise.
15933         * target.h (struct target_ops) <pass_signals, program_signals>:
15934         Constify argument.
15935         (target_pass_signals, target_program_signals): Constify argument.
15936
15937 2019-01-14  Tom Tromey  <tom@tromey.com>
15938
15939         PR tui/28819:
15940         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15941
15942 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
15943
15944         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15945         field.
15946         * rs6000-tdep.c: Include reggroups.h.
15947         (IS_V_ALIAS_PSEUDOREG): Define.
15948         (rs6000_register_name): Return names for the "vX" aliases.
15949         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15950         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
15951         aliases.  Call default_register_reggroup_p for all other
15952         pseudo-registers.
15953         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15954         New functions.
15955         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15956         Handle "vX" aliases.
15957         (v_alias_pseudo_register_collect): New function.
15958         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15959         (rs6000_gdbarch_init): Initialize "vX" aliases as
15960         pseudo-registers.  Restore registration of
15961         rs6000_pseudo_register_reggroup_p with
15962         set_tdesc_pseudo_register_reggroup_p.
15963
15964 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
15965
15966         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15967         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15968         set_gdbarch_num_pseudo_regs.
15969
15970 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15971
15972         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15973         Remove arg prefixname, add do_set and do_show.
15974         Add member functions set_list and show_list.
15975         * cli/cli-style.c (class cli_style_option): Update accordingly.
15976         (style_set_list): Move to file scope.
15977         (style_show_list): Likewise.
15978         (set_style): Call help_list.
15979         (show_style): Call cmd_show_list.
15980         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15981         Update to use the new macro.
15982
15983 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
15984
15985         * ada-lang.c (_initialize_ada_language): Expand the help text
15986         for the "catch exception" command.
15987
15988 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15989
15990         * symtab.c (matching_obj_sections): Initialize obj,
15991         declare it closer to its usage.
15992
15993 2019-01-10  Tom Tromey  <tom@tromey.com>
15994
15995         * thread-iter.h (inf_threads_iterator): Use next_iterator.
15996         (basic_inf_threads_range): Remove.
15997         (inf_threads_range, inf_non_exited_threads_range)
15998         (safe_inf_threads_range): Use next_adapter.
15999
16000 2019-01-10  Keith Seitz  <keiths@redhat.com>
16001
16002         PR gdb/23712
16003         PR symtab/23010
16004         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16005         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16006
16007 2019-01-10  Keith Seitz  <keiths@redhat.com>
16008
16009         PR gdb/23712
16010         PR symtab/23010
16011         * dictionary.c (pending_to_vector): Remove.
16012         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16013         Remove _1 suffix, replacing functions of the same name.  Update
16014         all callers.
16015         (dict_create_hashed, dict_create_hashed_expandable)
16016         (dict_create_linear, dict_create_linear_expandable, dict_free)
16017         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16018         Make functions static.
16019
16020 2019-01-10  Keith Seitz  <keiths@redhat.com>
16021
16022         PR gdb/23712
16023         PR symtab/23010
16024         * dictionary.h (struct dictionary): Replace declaration with
16025         multidictionary.
16026         (dict_create_hashed, dict_create_hashed_expandable)
16027         (dict_create_linear, dict_create_linear_expandable)
16028         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16029         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16030         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16031         taking multidictionary argument.
16032         [ALL_DICT_SYMBOLS]: Update for multidictionary.
16033         * block.h (struct block) <dict>: Change to multidictionary
16034         and rename `multidict'.
16035         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16036         symmisc.c: Update all dictionary references to multidictionary.
16037
16038 2019-01-10  Keith Seitz  <keiths@redhat.com>
16039
16040         PR gdb/23712
16041         PR symtab/23010
16042         * dictionary.c: Include unordered_map.
16043         (pending_to_vector): New function.
16044         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16045         Rewrite the non-"_1" functions to take vector instead
16046         of linked list.
16047         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16048         "new" _1 versions of the same name.
16049         (multidictionary): Define.
16050         (std::hash<enum language): New definition.
16051         (collate_pending_symbols_by_language, mdict_create_hashed)
16052         (mdict_create_hashed_expandable, mdict_create_linear)
16053         (mdict_create_linear_expandable, mdict_free)
16054         (find_language_dictionary, create_new_language_dictionary)
16055         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16056         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16057         (mdict_size, mdict_empty): New functions.
16058         * dictionary.h (mdict_iterator): Define.
16059
16060 2019-01-10  Pedro Alves  <palves@redhat.com>
16061
16062         * breakpoint.c (read_uploaded_action)
16063         (create_tracepoint_from_upload): Adjust to use
16064         gdb::unique_xmalloc_ptr.
16065         * ctf.c (ctf_write_uploaded_tp):
16066         (SET_ARRAY_FIELD): Use emplace_back.
16067         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16068         * tracefile-tfile.c (tfile_write_uploaded_tp):
16069         * tracepoint.c (parse_tracepoint_definition): Adjust to use
16070         gdb::unique_xmalloc_ptr.
16071         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16072         at_string, cond_string, cmd_strings>: Replace char pointers
16073         with gdb::unique_xmalloc_ptr.
16074
16075 2019-01-10  Pedro Alves  <palves@redhat.com>
16076
16077         * solib-target.c (library_list_start_library): Don't xstrdup name.
16078
16079 2019-01-10  Pedro Alves  <palves@redhat.com>
16080
16081         * mdebugread.c (parse_partial_symbols): Use
16082         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16083
16084 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16085
16086         * linux-fork.c (scoped_switch_fork_info)
16087         <~scoped_switch_fork_info>: Fix incorrect variable name.
16088
16089 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16090
16091         * linux-fork.c (scoped_switch_fork_info)
16092         <scoped_switch_fork_info>: Make explicit.
16093         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16094
16095 2019-01-10  Tom Tromey  <tom@tromey.com>
16096
16097         * objfiles.h (objfile::reset_psymtabs): Update.
16098         * objfiles.c (objfile::objfile): Update.
16099         * psymtab.h (psymtab_storage::obstack): Update.
16100         (psymtab_storage::m_obstack): Use gdb::optional.
16101         (class psymtab_storage): Update comment.  Remove objfile
16102         parameter.
16103         * psymtab.c (psymtab_storage::psymtab_storage): Update.
16104
16105 2019-01-10  Tom Tromey  <tom@tromey.com>
16106
16107         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16108         <free_psymtabs>: Now private.
16109         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16110         (allocate_psymtab): Use new method.
16111
16112 2019-01-10  Tom Tromey  <tom@tromey.com>
16113
16114         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16115         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16116         * mdebugread.c (parse_partial_symbols): Use
16117         allocate_dependencies.
16118         * dwarf2read.c (dwarf2_create_include_psymtab): Use
16119         allocate_dependencies.
16120         (process_psymtab_comp_unit_reader)
16121         (build_type_psymtab_dependencies): Likewise.
16122         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16123
16124 2019-01-10  Tom Tromey  <tom@tromey.com>
16125
16126         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16127         PSYMBOL_SET_LANGUAGE.
16128         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16129
16130 2019-01-10  Tom Tromey  <tom@tromey.com>
16131
16132         * psymtab.h (psymtab_storage::obstack): New method.
16133         <m_obstack>: Rename from obstack; now private.
16134         * psymtab.c (psymtab_storage): Update.
16135         * dwarf2read.c (create_addrmap_from_index)
16136         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16137         Update.
16138
16139 2019-01-10  Tom Tromey  <tom@tromey.com>
16140
16141         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16142         * objfiles.h (objfile::reset_psymtabs): New method.
16143
16144 2019-01-10  Tom Tromey  <tom@tromey.com>
16145
16146         * symmisc.c (print_symbol_bcache_statistics): Update.
16147         (print_objfile_statistics): Update.
16148         * symfile.c (reread_symbols): Update.
16149         * psymtab.h (class psymtab_storage): New.
16150         * psymtab.c (psymtab_storage): New constructor.
16151         (~psymtab_storage): New destructor.
16152         (require_partial_symbols): Update.
16153         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16154         (find_pc_sect_psymtab, find_pc_sect_psymbol)
16155         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16156         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16157         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16158         (start_psymtab_common, end_psymtab_common)
16159         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16160         (allocate_psymtab): Update.
16161         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16162         Update.
16163         (dump_psymtab_addrmap, maintenance_print_psymbols)
16164         (maintenance_check_psymtabs): Update.
16165         (class objfile_psymtabs): Move to objfiles.h.
16166         * psympriv.h (discard_psymtab): Now inline.
16167         (psymtab_discarder::psymtab_discarder): Update.
16168         (psymtab_discarder::~psymtab_discarder): Update.
16169         (ALL_OBJFILE_PSYMTABS): Rewrite.
16170         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16171         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16172         Remove fields.
16173         <partial_symtabs>: New field.
16174         (class objfile_psymtabs): Move from psymtab.h.  Update.
16175         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16176         psymbol_cache.
16177         (objfile::~objfile): Don't destroy psymbol_cache.
16178         * mdebugread.c (parse_partial_symbols): Update.
16179         * dwarf2read.c (create_addrmap_from_index)
16180         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16181         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16182         (add_partial_subprogram, dwarf2_ranges_read): Update.
16183         * dwarf-index-write.c (write_address_map)
16184         (write_one_signatured_type, recursively_write_psymbols)
16185         (class debug_names, class debug_names, write_psymtabs_to_index):
16186         Update.
16187
16188 2019-01-10  Tom Tromey  <tom@tromey.com>
16189
16190         * symtab.h (SYMBOL_SET_NAMES): Update.
16191         (symbol_set_names): Update.
16192         (MSYMBOL_SET_NAMES): Update.
16193         * symtab.c (symbol_set_names): Change argument to be an
16194         objfile_per_bfd_storage.
16195         * psymtab.c (add_psymbol_to_bcache): Update.
16196         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16197
16198 2019-01-10  Tom Tromey  <tom@tromey.com>
16199
16200         * symtab.c (create_demangled_names_hash): Change argument to be an
16201         objfile_per_bfd_storage.
16202         (symbol_set_names): Update.
16203
16204 2019-01-10  Tom Tromey  <tom@tromey.com>
16205
16206         * xcoffread.c (xcoff_initial_scan): Unconditionally call
16207         init_psymbol_list.
16208         * psymtab.c (init_psymbol_list): Do nothing if already called.
16209         * psympriv.h (init_psymbol_list): Add comment.
16210         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16211         init_psymbol_list.
16212         * dbxread.c (dbx_symfile_read): Unconditionally call
16213         init_psymbol_list.
16214
16215 2019-01-10  Tom Tromey  <tom@tromey.com>
16216
16217         * xcoffread.c (scan_xcoff_symtab): Update.
16218         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16219         "where".
16220         * mdebugread.c (parse_partial_symbols)
16221         (handle_psymbol_enumerators): Update.
16222         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16223         * dbxread.c (read_dbx_symtab): Update.
16224         * psympriv.h (psymbol_placement): New enum.
16225         (add_psymbol_to_list): Update.
16226
16227 2019-01-10  Tom Tromey  <tom@tromey.com>
16228
16229         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16230         static_psymbols parameters.
16231         (scan_xcoff_symtab): Update.
16232         * psymtab.c (start_psymtab_common): Remove global_psymbols and
16233         static_psymbols parameters.
16234         * psympriv.h (start_psymtab_common): Update.
16235         * mdebugread.c (parse_partial_symbols): Update.
16236         * dwarf2read.c (create_partial_symtab): Update.
16237         * dbxread.c (read_dbx_symtab): Update.
16238         (start_psymtab): Remove global_psymbols and static_psymbols
16239         parameters.
16240
16241 2019-01-10  Tom Tromey  <tom@tromey.com>
16242
16243         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16244         * psymtab.c (allocate_psymtab): Add comment.
16245         * psympriv.h (allocate_psymtab): Add comment.
16246         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16247         initializations.
16248         * dbxread.c (dbx_end_psymtab): Remove some initializations.
16249
16250 2019-01-10  Tom Tromey  <tom@tromey.com>
16251
16252         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16253         Don't declare.
16254         * mipsread.c: Include mdebugread.h.
16255         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16256         Declare.
16257         * elfread.c: Include mdebugread.h.
16258
16259 2019-01-09  Tom Tromey  <tom@tromey.com>
16260
16261         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16262         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16263         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16264         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16265         (psym_lookup_symbol, psym_find_last_source_symtab)
16266         (psym_forget_cached_source_info, psym_print_stats)
16267         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16268         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16269         (psym_map_matching_symbols, psym_expand_symtabs_matching)
16270         (psym_find_compunit_symtab_by_address)
16271         (maintenance_print_psymbols, maintenance_info_psymtabs)
16272         (maintenance_check_psymtabs): Use ranged for.
16273         * psymtab.h (class objfile_psymtabs): New.
16274         (require_partial_symbols): Return objfile_psymtabs.
16275         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16276
16277 2019-01-09  Tom Tromey  <tom@tromey.com>
16278
16279         * symfile.c (overlay_invalidate_all, find_pc_overlay)
16280         (find_pc_mapped_section, list_overlays_command)
16281         (map_overlay_command, unmap_overlay_command)
16282         (simple_overlay_update): Use all_objfiles.
16283         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16284         * printcmd.c (info_symbol_command): Use all_objfiles.
16285         * objfiles.h (ALL_OBJSECTIONS): Remove.
16286         * maint.c (maintenance_translate_address): Use all_objfiles.
16287         * gcore.c (gcore_create_callback): Use all_objfiles.
16288         (objfile_find_memory_regions): Likewise.
16289
16290 2019-01-09  Tom Tromey  <tom@tromey.com>
16291
16292         * symtab.c (find_line_symtab, info_sources_command)
16293         (make_source_files_completion_list): Use objfile_compunits.
16294         * source.c (select_source_symtab): Use objfile_compunits.
16295         * objfiles.h (struct objfile): Update comment.
16296         (ALL_OBJFILES): Remove.
16297         (ALL_FILETABS): Remove.
16298         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16299         objfile_compunits.
16300
16301 2019-01-09  Tom Tromey  <tom@tromey.com>
16302
16303         * symmisc.c (print_objfile_statistics, dump_objfile)
16304         (maintenance_print_symbols): Use compunit_filetabs.
16305         * source.c (forget_cached_source_info_for_objfile): Use
16306         compunit_filetabs.
16307         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16308         (ALL_FILETABS): Use compunit_filetabs.
16309         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16310         * coffread.c (coff_symtab_read): Use compunit_filetabs.
16311
16312 2019-01-09  Tom Tromey  <tom@tromey.com>
16313
16314         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16315         (compunit_filetabs): New.
16316         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16317         compunit_filetabs.
16318         (info_sources_command, make_source_files_completion_list): Remove
16319         declaration.
16320         * symmisc.c (print_objfile_statistics, dump_objfile)
16321         (maintenance_print_symbols): Remove declaration.
16322         (maintenance_info_symtabs): Use compunit_filetabs.
16323         (maintenance_info_line_tables): Likewise.
16324         * source.c (select_source_symtab): Change local variable name.
16325         (forget_cached_source_info_for_objfile): Remove declaration.
16326         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16327         * objfiles.c (objfile_relocate1): Remove declaration.
16328         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16329         declaration.
16330         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16331         * coffread.c (coff_symtab_read): Remove declaration.
16332         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16333         compunit_filetabs.
16334
16335 2019-01-09  Tom Tromey  <tom@tromey.com>
16336
16337         * symtab.c (lookup_objfile_from_block)
16338         (find_pc_sect_compunit_symtab, search_symbols)
16339         (default_collect_symbol_completion_matches_break_on): Use
16340         objfile_compunits.
16341         * objfiles.h (ALL_COMPUNITS): Remove.
16342         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16343         * cp-support.c (add_symbol_overload_list_qualified): Use
16344         objfile_compunits.
16345         * ada-lang.c (ada_collect_symbol_completion_matches)
16346         (ada_add_global_exceptions): Use objfile_compunits.
16347
16348 2019-01-09  Tom Tromey  <tom@tromey.com>
16349
16350         * source.c (select_source_symtab)
16351         (forget_cached_source_info_for_objfile): Remove declaration.
16352         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16353         declaration.
16354         * maint.c (count_symtabs_and_blocks): Remove declaration.
16355         * cp-support.c (add_symbol_overload_list_qualified): Remove
16356         declaration.
16357         * coffread.c (coff_symtab_read): Remove declaration.
16358         * symtab.c (lookup_symbol_in_objfile_symtabs)
16359         (basic_lookup_transparent_type_1): Use objfile_compunits.
16360         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16361         (info_sources_command, search_symbols)
16362         (default_collect_symbol_completion_matches_break_on)
16363         (make_source_files_completion_list): Remove declaration.
16364         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16365         (ada_collect_symbol_completion_matches)
16366         (ada_add_global_exceptions): Remove declaration.
16367         * linespec.c (iterate_over_all_matching_symtabs): Use
16368         objfile_compunits.
16369         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16370         (class objfile_compunits): New.
16371         (ALL_COMPUNITS): Use objfile_compunits.
16372         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16373         (maintenance_check_symtabs, maintenance_info_line_tables): Use
16374         objfile_compunits.
16375         * objfiles.c (objfile_relocate1): Use objfile_compunits.
16376
16377 2019-01-09  Tom Tromey  <tom@tromey.com>
16378
16379         * symtab.c (search_symbols)
16380         (default_collect_symbol_completion_matches_break_on): Use
16381         objfile_msymbols.
16382         * ada-lang.c (ada_lookup_simple_minsym)
16383         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16384         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16385         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16386         objfile_msymbols.
16387         * coffread.c (coff_symfile_read): Use objfile_msymbols.
16388         * symmisc.c (dump_msymbols): Use objfile_msymbols.
16389         * objc-lang.c (find_methods): Use objfile_msymbols.
16390         (info_selectors_command, info_classes_command): Likewise.
16391         * stabsread.c (scan_file_globals): Use objfile_msymbols.
16392         * objfiles.h (class objfile_msymbols): New.
16393         (ALL_OBJFILE_MSYMBOLS): Remove.
16394         (ALL_MSYMBOLS): Remove.
16395
16396 2019-01-09  Tom Tromey  <tom@tromey.com>
16397
16398         * common/next-iterator.h (next_adapter): Add Iterator template
16399         parameter.
16400         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16401         (class all_objfiles_safe): New.
16402         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16403         * objfiles.c (put_objfile_before): Update comment.
16404         (add_separate_debug_objfile): Likewise.
16405         (free_all_objfiles): Use all_objfiles_safe.
16406         (objfile_purge_solibs): Likewise.
16407
16408 2019-01-09  Tom Tromey  <tom@tromey.com>
16409
16410         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16411         (expand_symtab_containing_pc, lookup_static_symbol)
16412         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16413         (find_symbol_at_address, find_line_symtab, find_main_name): Use
16414         all_objfiles.
16415         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16416         * breakpoint.c (create_overlay_event_breakpoint)
16417         (create_longjmp_master_breakpoint)
16418         (create_std_terminate_master_breakpoint)
16419         (create_exception_master_breakpoint): Use all_objfiles.
16420         * linux-thread-db.c (try_thread_db_load_from_pdir)
16421         (has_libpthread): Use all_objfiles.
16422         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16423         * linespec.c (iterate_over_all_matching_symtabs)
16424         (search_minsyms_for_name): Use all_objfiles.
16425         * maint.c (maintenance_info_sections): Use all_objfiles.
16426         * main.c (captured_main_1): Use all_objfiles.
16427         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16428         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16429         * guile/scm-pretty-print.c
16430         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16431         * solib-spu.c (append_ocl_sos): Use all_objfiles.
16432         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16433         (maintenance_print_msymbols): Use all_objfiles.
16434         * source.c (select_source_symtab): Use all_objfiles.
16435         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16436         * symfile.c (remove_symbol_file_command)
16437         (expand_symtabs_matching, map_symbol_filenames): Use
16438         all_objfiles.
16439         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16440         all_objfiles.
16441         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16442         * objc-lang.c (find_methods): Use all_objfiles.
16443         * objfiles.c (have_partial_symbols, have_full_symbols)
16444         (have_minimal_symbols, qsort_cmp)
16445         (default_iterate_over_objfiles_in_search_order): Use
16446         all_objfiles.
16447         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16448         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16449         (maintenance_check_psymtabs): Use all_objfiles.
16450         (ALL_PSYMTABS): Remove.
16451         * compile/compile-object-run.c (do_module_cleanup): Use
16452         all_objfiles.
16453         * blockframe.c (find_pc_partial_function): Use all_objfiles.
16454         * cp-support.c (add_symbol_overload_list_qualified): Use
16455         all_objfiles.
16456         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16457         Use all_objfiles.
16458         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16459         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16460         all_objfiles.
16461         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16462         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16463         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16464         Uses all_objfiles.
16465         * solib.c (solib_read_symbols): Use all_objfiles
16466
16467 2019-01-09  Tom Tromey  <tom@tromey.com>
16468
16469         * probe.c (parse_probes_in_pspace): Use all_objfiles.
16470         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16471         all_objfiles.
16472         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16473         * symmisc.c (print_symbol_bcache_statistics)
16474         (print_objfile_statistics, maintenance_print_objfiles)
16475         (maintenance_info_symtabs, maintenance_check_symtabs)
16476         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16477         all_objfiles.
16478         * source.c (forget_cached_source_info): Use all_objfiles.
16479         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16480         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16481         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16482         * objfiles.c (update_section_map): Use all_objfiles.
16483         (shared_objfile_contains_address_p): Likewise.
16484         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16485         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16486
16487 2019-01-09  Tom Tromey  <tom@tromey.com>
16488
16489         * common/next-iterator.h: New file.
16490         * objfiles.h (class all_objfiles): New.
16491         (struct objfile_iterator): New.
16492
16493 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16494
16495         * NEWS: Move the description of the changed "frame", "select-frame",
16496          and "info frame" commands to the Changed commands section.
16497
16498 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
16499
16500         * gdbtypes.c (check_stub_method_group): Remove handling of old
16501         mangling schemes.
16502         * linespec.c (find_methods): Likewise.
16503         * stabsread.c (read_member_functions): Likewise.
16504         * valops.c (search_struct_method): Likewise.
16505         (value_struct_elt_for_reference): Likewise.
16506         * NEWS: Mention this change.
16507
16508 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
16509
16510         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16511         print_source_lines.
16512         * source.c (print_source_lines_base): Update line number check.
16513         (print_source_lines): New function.
16514         (source_lines_range::source_lines_range): New function.
16515         * source.h (class source_lines_range): New class.
16516         (print_source_lines): New declaration.
16517
16518 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16519
16520         * linespec.c (linespec_state_destructor): Free self->canonical_names.
16521
16522 2019-01-08  Tom Tromey  <tom@tromey.com>
16523             Simon Marchi  <simon.marchi@ericsson.com>
16524
16525         PR gdb/24060
16526         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16527         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16528         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16529         * f-exp.y (DOLLAR_VARIABLE): Likewise.
16530         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16531         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16532
16533 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16534
16535         * source.c (select_source_symtab): Move header comment to
16536         declaration in source.h.
16537         (forget_cached_source_info_for_objfile): Likewise.
16538         (forget_cached_source_info): Likewise.
16539         (identify_source_line): Likewise.
16540         * source.h (identify_source_line): Move declaration from symtab.h
16541         and add comment from source.c
16542         (print_source_lines): Likewise.
16543         (forget_cached_source_info_for_objfile): Likewise.
16544         (forget_cached_source_info): Likewise.
16545         (select_source_symtab): Likewise.
16546         (enum print_source_lines_flag): Move definition from symtab.h.
16547         * symtab.h (identify_source_line): Move declaration to source.h.
16548         (print_source_lines): Likewise.
16549         (forget_cached_source_info_for_objfile): Likewise.
16550         (forget_cached_source_info): Likewise.
16551         (select_source_symtab): Likewise.
16552         (enum print_source_lines_flag): Move definition to source.h.
16553         * tui/tui-hooks.c: Add 'source.h' include.
16554
16555 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16556
16557         * source.c (print_source_lines_base): Handle requests to print
16558         reverse line number sequences, and guard against empty lines
16559         string.
16560
16561 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16562
16563         * source.c (print_source_lines_base): Fix skip of '\r' if next
16564         character is '\n'.
16565
16566 2019-01-06  Tom Tromey  <tom@tromey.com>
16567
16568         * c-exp.y (struct c_parse_state) <macro_original_text,
16569         expansion_obstack>: New member.
16570         (macro_original_text, expansion_obstack): Remove globals.
16571         (scan_macro_expansion, scanning_macro_expansion)
16572         (finished_macro_expansion): Update.
16573         (scan_macro_cleanup): Remove.
16574         (yylex, c_parse): Update.
16575
16576 2019-01-06  Tom Tromey  <tom@tromey.com>
16577
16578         * c-exp.y (struct c_parse_state) <strings>: New member.
16579         (operator_stoken): Update.
16580
16581 2019-01-06  Tom Tromey  <tom@tromey.com>
16582
16583         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
16584         (union type_stack_elt) <typelist_val>: Now a pointer to
16585         std::vector.
16586         (type_stack_cleanup): Don't declare.
16587         (push_typelist): Update.
16588         * parse.c (pop_typelist): Return a std::vector.
16589         (push_typelist): Take a std::vector.
16590         (follow_types): Update.  Do not free args.
16591         (type_stack_cleanup): Remove.
16592         * c-exp.y (struct c_parse_state): New.
16593         (cpstate): New global.
16594         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16595         (nonempty_typelist): Update.
16596         (func_mod): Create a new vector.
16597         (c_parse): Create a c_parse_state.
16598         (check_parameter_typelist): Do not delete params.
16599         (function_method): Update.  Do not delete type_list.
16600
16601 2019-01-06  Tom Tromey  <tom@tromey.com>
16602
16603         PR gdb/28155:
16604         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16605         check_typedef.
16606         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16607         (print_return_value): Likewise.
16608
16609 2019-01-05  Tom Tromey  <tom@tromey.com>
16610
16611         * contrib/cleanup_check.py: Remove.
16612         * contrib/gcc-with-excheck: Remove.
16613         * contrib/exsummary.py: Remove.
16614         * contrib/excheck.py: Remove.
16615
16616 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
16617
16618         * thread.c (delete_thread_1): Add gdb_assert that THR is not
16619         NULL. Initialize tpprev to NULL instead of assigning it
16620         to NULL on the next statement.
16621         * windows-nat.c (windows_delete_thread): Remove check for
16622         main_thread_id before printing thread exit notifications.
16623         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16624         Remove thread ID check against main_thread_id.
16625         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16626         windows_delete_thread.
16627         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16628
16629 2019-01-04  Tom Tromey  <tom@tromey.com>
16630
16631         * compile/compile.c (_initialize_compile): Use upper case for
16632         metasyntactic variables.
16633         * symmisc.c (_initialize_symmisc): Use upper case for
16634         metasyntactic variables.
16635         * psymtab.c (_initialize_psymtab): Use upper case for
16636         metasyntactic variables.
16637         * demangle.c (demangle_command): Use upper case for metasyntactic
16638         variables.
16639         (_initialize_demangler): Likewise.
16640         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16641         variables.
16642
16643 2019-01-03  Tom Tromey  <tom@tromey.com>
16644
16645         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16646
16647 2019-01-03  Tom Tromey  <tom@tromey.com>
16648
16649         * python/py-symtab.c (salpy_str): Update.
16650         (struct salpy_sal_object) <symtab>: Now a PyObject.
16651         (salpy_dealloc): Update.
16652         (del_objfile_sal): Use gdbpy_ref.
16653
16654 2019-01-03  Tom Tromey  <tom@tromey.com>
16655
16656         * python/py-type.c (convert_field): Use new_reference.  Return
16657         gdbpy_ref.
16658         (make_fielditem): Return gdbpy_ref.
16659         (typy_fields): Update.
16660         (typy_getitem): Update.
16661         (field_name): Return gdbpy_ref.  Use new_reference.
16662         (typy_iterator_iternext): Update.
16663
16664 2019-01-03  Tom Tromey  <tom@tromey.com>
16665
16666         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16667
16668 2019-01-03  Tom Tromey  <tom@tromey.com>
16669
16670         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16671         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16672         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16673         (pspy_set_frame_filters, pspy_set_frame_unwinders)
16674         (pspy_set_type_printers): Likewise.
16675         * python/py-function.c (fnpy_init): Use gdbpy_ref.
16676         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16677         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16678         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16679         (objfpy_set_type_printers): Likewise.
16680
16681 2019-01-03  Tom Tromey  <tom@tromey.com>
16682
16683         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16684         (gdbpy_print_stack): Use gdbpy_err_fetch.
16685         * python/python-internal.h (class gdbpy_err_fetch): New class.
16686         (class gdbpy_enter) <m_error_type, m_error_value,
16687         m_error_traceback>: Remove.
16688         <m_error>: New member.
16689         (gdbpy_exception_to_string): Don't declare.
16690         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16691         * python/py-value.c (convert_value_from_python): Use
16692         gdbpy_err_fetch.
16693         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16694         gdbpy_exception_to_string.
16695         (gdbpy_handle_exception): Use gdbpy_err_fetch.
16696         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16697         gdbpy_err_fetch.
16698
16699 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16700
16701         * linux-nat.c (delete_lwp_cleanup): Delete.
16702         (struct lwp_deleter): New struct.
16703         (lwp_info_up): New typedef.
16704         (linux_nat_target::follow_fork): Delete cleanup, and make use of
16705         lwp_info_up.
16706
16707 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16708
16709         * linux-fork.c (class scoped_switch_fork_info): New class.
16710         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16711
16712 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16713
16714         * valops.c (find_overload_match): Remove use of null_cleanup, and
16715         calls to do_cleanups.
16716
16717 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16718
16719         * compile/compile-cplus-types.c
16720         (compile_cplus_instance::decl_name): Handle changes to
16721         cp_func_name.
16722         * cp-support.c (cp_func_name): Update header comment, update
16723         return type.
16724         * cp-support.h (cp_func_name): Update return type in declaration.
16725         * valops.c (find_overload_match): Move temp_func local to top
16726         level of function and change its type.  Use temp_func to hold and
16727         delete temporary string obtained from cp_func_name.
16728
16729 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16730
16731         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16732         gdb::char_vector, remove cleanup, and update uses of `msg`.
16733
16734 2019-01-03  Jim Wilson  <jimw@sifive.com>
16735
16736         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16737
16738 2019-01-02  Tom Tromey  <tom@tromey.com>
16739
16740         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16741         (tdesc_parse_xml): Remove cleanups.
16742         * target-descriptions.h (make_cleanup_free_target_description):
16743         Don't declare.
16744         (target_desc_deleter): New struct.
16745         (target_desc_up): New typedef.
16746         * target-descriptions.c (target_desc_deleter::operator()): Rename
16747         from free_target_description.
16748         (make_cleanup_free_target_description): Remove.
16749
16750 2019-01-02  Tom Tromey  <tom@tromey.com>
16751
16752         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
16753         constructor, destructor.
16754         (linespec_parser): Remove typedef.
16755         (~linespec_parser): Rename from linespec_parser_delete.
16756         (linespec_lex_to_end, linespec_complete_label)
16757         (linespec_complete): Update.
16758         (decode_line_full): Remove cleanups.
16759         (decode_line_1): Update.
16760
16761 2019-01-02  Tom Tromey  <tom@tromey.com>
16762
16763         * python/python-internal.h (inferior_to_inferior_object): Change
16764         return type.
16765         * python/py-exitedevent.c (create_exited_event_object): Update.
16766         * python/py-inferior.c (inferior_to_inferior_object): Return
16767         gdbpy_ref.
16768         (python_new_inferior, python_inferior_deleted)
16769         (thread_to_thread_object, delete_thread_object)
16770         (build_inferior_list, gdbpy_selected_inferior): Update.
16771         * python/py-infthread.c (create_thread_object): Update.  Also fail
16772         if inferior_to_inferior_object fails.
16773
16774 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
16775
16776         * inferior.h (class inferior) <displaced_step_state>: New field.
16777         * infrun.h (struct displaced_step_state): Move here from
16778         infrun.c.  Initialize fields, add constructor.
16779         <inf>: Remove field.
16780         <reset>: New method.
16781         * infrun.c (struct displaced_step_inferior_state): Move to
16782         infrun.h.
16783         (displaced_step_inferior_states): Remove.
16784         (get_displaced_stepping_state): Adust.
16785         (displaced_step_in_progress_any_inferior): Adjust.
16786         (displaced_step_in_progress_thread): Adjust.
16787         (displaced_step_in_progress): Adjust.
16788         (add_displaced_stepping_state): Remove.
16789         (get_displaced_step_closure_by_addr): Adjust.
16790         (remove_displaced_stepping_state): Remove.
16791         (infrun_inferior_exit): Call displaced_step_state.reset.
16792         (use_displaced_stepping): Don't check for NULL.
16793         (displaced_step_prepare_throw): Call
16794         get_displaced_stepping_state.
16795         (displaced_step_fixup): Don't check for NULL.
16796         (prepare_for_detach): Don't check for NULL.
16797
16798 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16799
16800         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16801          in case of call that did not complete.
16802
16803 2019-01-02  Andrey Utkin  <autkin@undo.io>
16804
16805         * symfile.c (find_separate_debug_file): Fix search of debug files for
16806         remote debuggee.
16807
16808 2019-01-02  Tom Tromey  <tom@tromey.com>
16809
16810         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16811         indentation.
16812         * python/py-frame.c (frapy_older): Remove cast.
16813         (frapy_newer): Likewise.
16814         * python/py-breakpoint.c (local_setattro): Remove cast.
16815         * python/py-arch.c (archpy_name): Remove local variable.
16816         * python/py-type.c (gdbpy_lookup_type): Remove cast.
16817
16818 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
16819
16820         * unittests/basic_string_view/element_access/char/empty.cc:
16821         Fix year range in copyright header.
16822
16823 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
16824
16825         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16826         Delete.
16827         <operator==>: Update with for removed field.
16828         <hash>: Likewise.
16829         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16830         <isa_features>: ...this.
16831         <abi_features>: New field.
16832         (riscv_isa_flen): Update comment.
16833         (riscv_abi_xlen): New declaration.
16834         (riscv_abi_flen): New declaration.
16835         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16836         isa_features.
16837         (riscv_abi_xlen): New function.
16838         (riscv_isa_flen): Update to get answer from isa_features.
16839         (riscv_abi_flen): New function.
16840         (riscv_has_fp_abi): Update to get answer from abi_features.
16841         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16842         xlen and flen.
16843         (riscv_call_info) <xlen, flen>: Update comment.
16844         (riscv_call_arg_struct): Remove invalid assertions
16845         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16846         is removed.
16847         (riscv_gdbarch_init): Gather isa features and abi features
16848         separately, ensure both match on the gdbarch when reusing an old
16849         gdbarch.  Relax an error check to allow 32-bit abi float to run on
16850         a target with 64-bit float hardware.
16851
16852 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16853
16854         * source.c (search_command_helper): Stop reverse search
16855         when line 1 has been searched.
16856
16857 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16858
16859         * record-full.c (record_full_base_target::close): Rewrite
16860         record_full_core_buf_list free logic.
16861
16862 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16863
16864         * break-catch-syscall.c (print_one_catch_syscall): xfree
16865         the last text.
16866
16867 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16868
16869         * top.c (print_gdb_version): Update Copyright year in version
16870         message.
16871
16872 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16873
16874         Update copyright year range in all GDB files.
16875
16876 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
16877
16878         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16879
16880 For older changes see ChangeLog-2018.
16881 \f
16882 Local Variables:
16883 mode: change-log
16884 left-margin: 8
16885 fill-column: 74
16886 version-control: never
16887 coding: utf-8
16888 End:
16889