ecd21247200688dc26a35a05139dcf799cff04ad
[deliverable/binutils-gdb.git] / gdb / ChangeLog
1 2019-12-12 Tom Tromey <tom@tromey.com>
2
3 * objfiles.h (struct objfile) <partial_symtabs>: Now a
4 unique_ptr.
5
6 2019-12-12 Tom Tromey <tom@tromey.com>
7
8 * progspace.h (objfile_list): New typedef.
9 (class unwrapping_objfile_iterator)
10 (struct unwrapping_objfile_range): Newl
11 (struct program_space) <objfiles_range>: Change type.
12 <objfiles>: Change return type.
13 <add_objfile>: Change type of "objfile" parameter.
14 <objfiles_list>: Now a list of shared_ptr.
15 * progspace.c (program_space::add_objfile): Change type of
16 "objfile". Update.
17 (program_space::remove_objfile): Update.
18 * objfiles.h (struct objfile) <~objfile>: Make public.
19 * objfiles.c (objfile::make): Update.
20 (objfile::unlink): Don't call delete.
21
22 2019-12-12 Tom Tromey <tom@tromey.com>
23
24 * symfile.c (symbol_file_clear): Update.
25 * progspace.h (struct program_space) <free_all_objfiles>: Declare
26 method.
27 * progspace.c (program_space::free_all_objfiles): New method.
28 * objfiles.h (free_all_objfiles): Don't declare.
29 * objfiles.c (free_all_objfiles): Move to program_space.
30
31 2019-12-12 Tom Tromey <tom@tromey.com>
32
33 * progspace.c (program_space::add_objfile)
34 (program_space::remove_objfile): Update.
35 (program_space::multi_objfile_p): Remove.
36 * objfiles.h (struct objfile) <next>: Remove.
37 * objfiles.c (objfile::objfile): Update.
38 (put_objfile_before): Update.
39 (unlink_objfile): Update.
40 * progspace.h (object_files): Remove.
41 (struct program_space) <objfiles_head>: Remove.
42 <objfiles_list>: New member.
43 <objfiles_range, objfiles_safe_range>: Change type.
44 (objfiles): Change return type.
45 (objfiles_safe): Update.
46 (multi_objfile_p): Rewrite and inline.
47 (object_files): Remove macro.
48
49 2019-12-12 Tom Tromey <tom@tromey.com>
50
51 * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify. Add
52 second constructor.
53 (basic_safe_range): New class.
54
55 2019-12-12 Tom Tromey <tom@tromey.com>
56
57 * progspace.c (program_space::multi_objfile_p): New method.
58 * printcmd.c (info_symbol_command): Update.
59 * maint.c (maintenance_translate_address): Update.
60 * objfiles.h (MULTI_OBJFILE_P): Remove.
61 * progspace.h (struct program_space) <multi_objfile_p>: New
62 method.
63
64 2019-12-12 Tom Tromey <tom@tromey.com>
65
66 * progspace.h (struct program_space) <remove_objfile>: Declare.
67 * progspace.c (program_space::remove_objfile): New method.
68 * objfiles.c (unlink_objfile): Remove.
69 (objfile::unlink): Call remove_objfile.
70 (objfile): Don't call unlink_objfile.
71
72 2019-12-12 Tom Tromey <tom@tromey.com>
73
74 * progspace.h (struct program_space) <add_objfile>: Declare
75 method.
76 * progspace.c (program_space::add_objfile): New method.
77 * objfiles.c (~objfile): Don't unlink objfile.
78 (put_objfile_before): Remove.
79 (add_separate_debug_objfile): Don't call put_objfile_before.
80 (objfile::make): Call add_objfile. Set new_objfiles_available on
81 the per-program-space data.
82
83 2019-12-12 Tom Tromey <tom@tromey.com>
84
85 * symfile.c (syms_from_objfile_1): Use objfile_up.
86 (syms_from_objfile_1, remove_symbol_file_command): Call unlink
87 method.
88 (reread_symbols): Use objfile_up.
89 * solib.c (update_solib_list, reload_shared_libraries_1): Call
90 unlink method.
91 * objfiles.h (struct objfile) <~objfile>: Now private.
92 <unlink>: New method.
93 (struct objfile_deleter): New.
94 (objfile_up): New typedef.
95 * objfiles.c (objfile::unlink): New method.
96 (free_objfile_separate_debug, free_all_objfiles)
97 (objfile_purge_solibs): Use it.
98 * jit.c (jit_unregister_code): Remove.
99 (jit_inferior_exit_hook, jit_event_handler): Call unlink on
100 objfile.
101 * compile/compile-object-run.c (do_module_cleanup): Call unlink on
102 objfile.
103 * compile/compile-object-load.c (compile_object_load): Use
104 objfile_up.
105
106 2019-12-12 Tom Tromey <tom@tromey.com>
107
108 * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
109 objfile::make.
110 * objfiles.h (struct objjfile) <make>: No longer inline.
111 (add_separate_debug_objfile): Don't declare.
112 * objfiles.c (add_separate_debug_objfile): Now static.
113 (objfile::make): Move from objfiles.h. Call
114 add_separate_debug_objfile. Add "parent" parameter.
115
116 2019-12-12 Tom Tromey <tom@tromey.com>
117
118 * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
119 * objfiles.h (struct objfile): Make constructor private.
120 <make>: New static method.
121 * jit.c (jit_object_close_impl): Update.
122
123 2019-12-12 Simon Marchi <simon.marchi@polymtl.ca>
124
125 * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
126 gdb::byte_vector.
127
128 2019-12-12 Tom Tromey <tromey@adacore.com>
129
130 * xml-support.c (xml_fetch_content_from_file): Don't call
131 malloc_failure.
132 * utils.h (class gdb_argv): Remove malloc_failure comment.
133 * utils.c (gdb_argv::reset): Don't call malloc_failure.
134
135 2019-12-12 Tom Tromey <tromey@adacore.com>
136
137 * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
138 (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
139 (ALLDEPFILES): Add riscv-ravenscar-thread.c.
140 * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
141 * riscv-ravenscar-thread.c: New file.
142 * riscv-ravenscar-thread.h: New file.
143 * riscv-tdep.c (riscv_gdbarch_init): Call
144 register_riscv_ravenscar_ops.
145
146 2019-12-12 Tom Tromey <tromey@adacore.com>
147
148 * gdbsupport/thread-pool.c (set_thread_name): Use
149 ATTRIBUTE_UNUSED.
150
151 2019-12-12 Luis Machado <luis.machado@linaro.org>
152
153 * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
154 (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
155 macros.
156
157 2019-12-11 Tom Tromey <tom@tromey.com>
158
159 * tui/tui-win.c (tui_set_win_height_command): Call
160 tui_adjust_window_height.
161 (tui_adjust_win_heights, new_height_ok): Remove.
162 * tui/tui-layout.h (tui_adjust_window_height): Declare.
163 * tui/tui-layout.c (tui_adjust_window_height): New function.
164
165 2019-12-11 Tom Tromey <tom@tromey.com>
166
167 * tui/tui-win.c (tui_resize_all): Remove code, call
168 tui_apply_current_layout.
169
170 2019-12-11 Tom Tromey <tom@tromey.com>
171
172 * tui/tui-layout.h (tui_apply_current_layout): Declare.
173 * tui/tui-layout.c (standard_layouts, applied_layout): New
174 globals.
175 (tui_apply_current_layout): New function.
176 (show_layout): Set applied_layout. Call
177 tui_apply_current_layout.
178 (show_source_command, show_disasm_command)
179 (show_source_disasm_command, show_data)
180 (show_source_or_disasm_and_command): Remove.
181 (initialize_layouts): New function.
182 (_initialize_tui_layout): Call initialize_layouts.
183
184 2019-12-11 Tom Tromey <tom@tromey.com>
185
186 * tui/tui-layout.h (class tui_layout_base)
187 (class tui_layout_window, class tui_layout_split): New.
188 * tui/tui-layout.c (tui_get_window_by_name)
189 (tui_layout_window::clone, tui_layout_window::apply)
190 (tui_layout_window::get_sizes, tui_layout_window::add_split)
191 (tui_layout_split::add_window, tui_layout_split::clone)
192 (tui_layout_split::get_sizes)
193 (tui_layout_split::set_weights_from_heights)
194 (tui_layout_split::adjust_size, tui_layout_split::apply): New
195 functions.
196 (tui_layout_split::add_split, tui_layout_split::add_split)
197 (tui_layout_split::set_weights_from_heights)
198 (tui_layout_split::set_weights_from_heights): New functions.
199
200 2019-12-11 Tom Tromey <tom@tromey.com>
201
202 * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
203 * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
204 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
205 * tui/tui-data.h (struct tui_point): Remove.
206 (struct tui_gen_win_info) <origin>: Remove.
207 <x, y>: New fields.
208 * tui/tui-command.c (tui_cmd_window::resize): Update.
209
210 2019-12-11 Tom Tromey <tom@tromey.com>
211
212 * tui/tui-stack.h (struct tui_locator_window) <min_height>:
213 Implement.
214 * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
215 Implement.
216 * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
217 method.
218 (struct tui_win_info) <min_height>: Implement.
219
220 2019-12-11 Tom Tromey <tom@tromey.com>
221
222 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
223 (struct tui_win_info) <can_box>: Update.
224
225 2019-12-11 Tom Tromey <tom@tromey.com>
226
227 * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
228 method.
229 * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
230 method.
231 * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
232 method.
233 (struct tui_win_info) <max_height>: Now override.
234
235 2019-12-11 Joel Brobecker <brobecker@adacore.com>
236
237 * NEWS: Create a new section for the next release branch.
238 Rename the section of the current branch, now that it has
239 been cut.
240
241 2019-12-11 Joel Brobecker <brobecker@adacore.com>
242
243 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
244 * version.in: Bump version to 10.0.50.DATE-git.
245
246 2019-12-11 Tom Tromey <tromey@adacore.com>
247
248 PR build/25268:
249 * gdbsupport/thread-pool.c (set_thread_name): New function.
250 (thread_pool::set_thread_count): Don't call pthread_setname_np.
251 (thread_pool::thread_function): Call set_thread_name.
252
253 2019-12-11 Tom Tromey <tromey@adacore.com>
254
255 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
256 bfd_get_signed_8.
257
258 2019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
259
260 * NEWS: Document -raw-values option and the related setting commands.
261 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
262 only set it on when /r is given.
263 * valprint.c (value_print_option_defs): New element raw-values.
264 * Makefile.in: Add the new file.
265
266 2019-12-10 Christian Biesinger <cbiesinger@google.com>
267
268 * gdbsupport/safe-strerror.c: Supress the unused function warning
269 for select_strerror_r.
270
271 2019-12-10 Christian Biesinger <cbiesinger@google.com>
272
273 * config.in: Regenerate.
274 * configure: Regenerate.
275 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
276 safe_strerror instead of strerror.
277 * gdbsupport/common.m4: Don't check for strerror.
278 * gdbsupport/safe-strerror.c: Support both the glibc version
279 of strerror_r and the XSI version.
280
281 2019-12-10 Tom Tromey <tromey@adacore.com>
282
283 * ada-typeprint.c (print_choices): Use a single "?".
284 (print_variant_part): Print "?" if the discriminant name
285 is not known.
286
287 2019-12-10 George Barrett <bob@bob131.so>
288
289 Fix scripted probe breakpoints.
290 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
291 declaration forward.
292 (breakpoint_ops_for_event_location_type)
293 (breakpoint_ops_for_event_location): Add function definitions.
294 (break_command_1, trace_command): Use
295 breakpoint_ops_for_event_location.
296 * breakpoint.h (breakpoint_ops_for_event_location): Add function
297 declarations.
298 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
299 breakpoint_ops_for_event_location.
300 * python/py-breakpoint.c (bppy_init): Use
301 breakpoint_ops_for_event_location.
302
303 2019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
304
305 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
306 when ranking an lvalue argument for an rvalue parameter.
307
308 2019-12-08 Wataru Ashihara <wataash@wataash.com>
309
310 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
311 template argument for scoped_restore_tmpl from bool to int.
312
313 2019-12-07 Keith Seitz <keiths@redhat.com>
314
315 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
316 (build_id_to_debug_bfd): Make static, rewriting to use
317 build_id_to_bfd_suffix.
318 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
319 adding `suffix' parameter. Append SUFFIX to file names
320 when searching for matching files.
321 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
322 (build_id_to_exec_bfd): Likewise.
323 * build-id.h (build_id_to_debug_bfd): Clarify that function
324 searches for BFD of debug info file.
325 (build_id_to_exec_bfd): Declare.
326 * corelow.c: Include build-id.h.
327 (locate_exec_from_corefile_build_id): New function.
328 (core_target_open): If no executable BFD is found,
329 search for a core file BFD using build-id.
330
331 2019-12-06 Christian Biesinger <cbiesinger@google.com>
332
333 * bcache.c: Put in namespace gdb.
334 * bcache.h: Likewise.
335 * gdbtypes.c (check_types_worklist): Update.
336 (types_deeply_equal): Update.
337 * macrotab.c (struct macro_table) <bcache>: Update.
338 (new_macro_table): Update.
339 * macrotab.h (struct bcache): Put this forward declaration
340 inside namespace gdb.
341 (new_macro_table): Update.
342 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
343 Update.
344 <macro_cache>: Update.
345 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
346
347 2019-12-06 Tom de Vries <tdevries@suse.de>
348
349 PR symtab/24971
350 * block.c (best_symbol, better_symbol): New function.
351 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
352 decl.
353
354 2019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
355
356 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
357 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
358 for ranking see-through reference cases.
359
360 2019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
361 * stack.c (faas_command): Check a command is provided.
362 * thread.c (taas_command, tfaas_command): Likewise.
363
364 2019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
365 * inferior.c (prune_inferiors): Only call delete_inferior,
366 Do not modify the inferior list.
367
368 2019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
369
370 * c-exp.y: Update calls to lookup_typename,
371 lookup_signed_typename and lookup_unsigned_typename.
372 * c-lang.c (evaluate_subexp_c): Likewise.
373 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
374 Likewise.
375 * eval.c (binop_promote): Likewise.
376 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
377 (lookup_unsigned_typename): Likewise.
378 (lookup_signed_typename): Likewise.
379 * gdbtypes.h (lookup_unsigned_typename): Likewise.
380 (lookup_signed_typename): Likewise.
381 (lookup_typename): Likewise.
382 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
383 lookup_typename, lookup_signed_typename,
384 lookup_unsigned_typename.
385 * m2-exp.y: Likewise.
386 * printcmd.c (printf_wide_c_string): Likewise.
387 (ui_printf): Likewise.
388 * python/py-type.c (typy_lookup_typename): Likewise.
389 * python/py-xmethods.c (python_xmethod_worker::invoke):
390 Likewise.
391 * rust-exp.y: Likewise.
392
393 2019-12-04 Christian Biesinger <cbiesinger@google.com>
394
395 * configure.nat (obsd64): Add missing files x86-nat.o and
396 nat/x86-dregs.o.
397
398 2019-12-04 Tom Tromey <tom@tromey.com>
399
400 * valprint.c (val_print_string): Use metadata_style.
401 * go-valprint.c (print_go_string): Use metadata style.
402 * p-valprint.c (pascal_object_print_static_field): Use metadata
403 style.
404 * cp-valprint.c (cp_print_static_field): Use metadata style.
405
406 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
407 Chris January <chris.january@arm.com>
408
409 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
410 tokens.
411 (typebase): New patterns for complex, single/double precision, and
412 single/double complex.
413 (f77_keywords): Change token for complex keyword, and add single,
414 double, and precision keywords.
415
416 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
417
418 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
419 "info io_registers".
420
421 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
422
423 * regcache.c (cooked_read_test): Initialize thread list of
424 mock_inferior.
425
426 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
427
428 * aarch64-linux-tdep.c: Remove includes.
429
430 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
431
432 * aarch64-tdep.c: Remove includes.
433
434 2019-12-04 Simon Marchi <simon.marchi@efficios.com>
435
436 * filtered-iterator.h (filtered_iterator) <operator==,
437 operator!=>: Compare wrapped iterators, not wrapped pointers.
438 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
439 unittests/filtered_iterator-selftests.c.
440 * unittests/filtered_iterator-selftests.c: New file.
441
442 2019-12-04 Tom Tromey <tromey@adacore.com>
443
444 * gdbtypes.c (create_range_type): Inherit endianity
445 from base type.
446
447 2019-12-04 Tom Tromey <tromey@adacore.com>
448
449 * ada-lang.c (decode_constrained_packed_array)
450 (ada_value_assign, value_assign_to_component): Update.
451 * dwarf2loc.c (rw_pieced_value, access_memory)
452 (dwarf2_compile_expr_to_ax): Update.
453 * dwarf2read.c (dwarf2_add_field): Update.
454 * eval.c (evaluate_subexp_standard): Update.
455 * gdbarch.c, gdbarch.h: Rebuild.
456 * gdbarch.sh (bits_big_endian): Remove.
457 * gdbtypes.h (union field_location): Update comment.
458 * target-descriptions.c (make_gdb_type): Update.
459 * valarith.c (value_bit_index): Update.
460 * value.c (struct value) <bitpos>: Update comment.
461 (unpack_bits_as_long, modify_field): Update.
462 * value.h (value_bitpos): Update comment.
463
464 2019-12-04 Tom Tromey <tromey@adacore.com>
465
466 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
467 endian-ness.
468
469 2019-12-04 Tom Tromey <tromey@adacore.com>
470
471 * dwarf2read.c (dwarf2_init_float_type)
472 (dwarf2_init_complex_target_type): Add byte_order parameter.
473 (read_base_type): Compute byte order earlier.
474 * gdbtypes.c (init_float_type): Add byte_order parameter.
475 * gdbtypes.h (init_float_type): Add byte_order parameter.
476
477 2019-12-04 Tom Tromey <tromey@adacore.com>
478
479 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
480
481 2019-12-04 Tom Tromey <tromey@adacore.com>
482
483 * dwarf2read.c (process_structure_scope): Initialize
484 "discr_offset".
485
486 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
487
488 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
489 add it into the search spec.
490 (parse_max_results_option): New function.
491 (mi_info_functions_or_variables): Parse -max-results flag and pass
492 it to mi_symbol_info.
493 (mi_cmd_symbol_info_modules): Likewise.
494 (mi_cmd_symbol_info_types): Likewise.
495 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
496 return type to bool, change result container into a set, and don't
497 add new results if we have enough already.
498 (global_symbol_searcher::add_matching_msymbols): Change return
499 type to bool, and don't add new results if we have enough already.
500 (sort_search_symbols_remove_dups): Delete.
501 (global_symbol_searcher::search): Early exit from search loop when
502 we have enough results. Use a std::set to collect the results
503 from calling add_matching_symbols.
504 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
505 member function.
506 (global_symbol_searcher) <m_max_search_results>: New member
507 variable.
508 (global_symbol_searcher) <add_matching_symbols>: Update header
509 comment and change return type to bool.
510 (global_symbol_searcher) <add_matching_msymbols>: Update header
511 comment and change return type to bool.
512
513 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
514
515 * symtab.c (symbol_search::compare_search_syms): Update header
516 comment.
517 (global_symbol_searcher::is_suitable_msymbol): New function.
518 (global_symbol_searcher::expand_symtabs): New function.
519 (global_symbol_searcher::add_matching_symbols): New function.
520 (global_symbol_searcher::add_matching_msymbols): New function.
521 (global_symbol_searcher::search): Move most of the content
522 into the new functions above, and call them as needed.
523 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
524 function.
525 (global_symbol_searcher) <add_matching_symbols>: New member
526 function.
527 (global_symbol_searcher) <add_matching_msymbols>: New member
528 function.
529 (global_symbol_searcher) <is_suitable_msymbol>: New member
530 function.
531
532 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
533
534 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
535 -symbol-info-module-variables entries.
536 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
537 (mi_cmd_symbol_info_module_variables): Declare.
538 * mi/mi-symbol-cmds.c
539 (module_symbol_search_iterator): New typedef.
540 (output_module_symbols_in_single_module_and_file): New function.
541 (output_module_symbols_in_single_module): New function.
542 (mi_info_module_functions_or_variables): New function.
543 (mi_cmd_symbol_info_module_functions): New function.
544 (mi_cmd_symbol_info_module_variables): New function.
545 * NEWS: Mention new MI command.
546
547 2019-12-03 Christian Biesinger <cbiesinger@google.com>
548
549 * bcache.c (hash): Remove.
550 (hash_continue): Remove.
551 * bcache.h (hash): Remove.
552 (hash_continue): Remove.
553 (struct bcache) <ctor>: Update.
554 * psymtab.c (psymbol_hash): Update.
555 * stabsread.c (hashname): Update.
556 * utils.h (fast_hash): Add an argument for a start value,
557 defaulting to zero.
558
559 2019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
560 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
561 (destroy_block_symbol_cache): New function.
562 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
563 (resize_symbol_cache): Likewise.
564
565 2019-12-02 Tom Tromey <tom@tromey.com>
566
567 * unittests/tui-selftests.c (run_tests): Make conditional.
568 (_initialize_tui_selftest): Make conditional.
569
570 2019-12-02 Christian Biesinger <cbiesinger@google.com>
571
572 * aix-thread.c (debug_aix_thread): Change type to bool.
573
574 2019-12-02 Luis Machado <luis.machado@linaro.org>
575
576 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
577
578 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
579
580 * dwarf2read.c (read_tag_string_type): Read the fields required to
581 make a dynamic string, and possibly create a dynamic range for the
582 string.
583 (attr_to_dynamic_prop): Setup is_reference based on the type of
584 attribute being processed.
585 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
586 (resolve_dynamic_array): Rename to...
587 (resolve_dynamic_array_or_string): ...this, update header comment,
588 and accept TYPE_CODE_STRING.
589 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
590
591 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
592
593 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
594 of its implementation from...
595 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
596 the new function.
597
598 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
599
600 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
601 create a range with stride where appropriate.
602 * f-valprint.c: Include 'gdbarch.h'.
603 (f77_print_array_1): Take the stride into account when walking the
604 array. Also convert the stride into addressable units.
605 * gdbtypes.c (create_range_type): Initialise the stride to
606 constant zero.
607 (create_range_type_with_stride): New function, initialise the
608 range as normal, and then setup the stride.
609 (has_static_range): Include the stride here. Also change the
610 return type to bool.
611 (create_array_type_with_stride): Consider the range stride if the
612 array isn't given its own stride.
613 (resolve_dynamic_range): Resolve the stride if needed.
614 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
615 (struct range_bounds) <flag_is_byte_stride>: New member variable.
616 (TYPE_BIT_STRIDE): Define.
617 (TYPE_ARRAY_BIT_STRIDE): Define.
618 (create_range_type_with_stride): Declare.
619 * valarith.c (value_subscripted_rvalue): Take range stride into
620 account when walking the array.
621
622 2019-12-01 Tom Tromey <tom@tromey.com>
623
624 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
625 specially.
626
627 2019-12-01 Tom Tromey <tom@tromey.com>
628
629 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
630 \0.
631 * unittests/tui-selftests.c: New file.
632 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
633
634 2019-12-01 Tom Tromey <tom@tromey.com>
635
636 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
637
638 2019-12-01 Tom Tromey <tom@tromey.com>
639
640 * NEWS: Document new settings.
641 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
642 * tui/tui-win.c (_initialize_tui_win): Add border style
643 observers.
644 * tui/tui-io.h (tui_apply_style): Declare.
645 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
646 longer static.
647 (apply_ansi_escape, tui_set_reverse_mode): Update.
648 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
649 Add "skip_intensity" parameter.
650 <changed>: New member.
651 <do_set_value>: Declare.
652 (tui_border_style, tui_active_border_style): Declare.
653 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
654 globals.
655 (cli_style_option): Initialize "changed".
656 (cli_style_option::do_set_value): New function.
657 (cli_style_option::add_setshow_commands): Add "skip_intensity"
658 parameter. Update.
659 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
660 (_initialize_cli_style): Update. Create TUI border style
661 commands.
662
663 2019-12-01 Tom Tromey <tom@tromey.com>
664
665 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
666 parameter.
667 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
668 parameter.
669 * tui/tui-win.h (compact_source): Declare.
670 * tui/tui-win.c (compact_source): New global.
671 (tui_set_compact_source, tui_show_compact_source): New functions.
672 (_initialize_tui_win): Add "compact-source" setting.
673 * tui/tui-source.c (tui_source_window::set_contents): Handle
674 compact_source setting.
675 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
676 * NEWS: Document new setting.
677
678 2019-11-30 Tom Tromey <tom@tromey.com>
679
680 * dwarf2read.c (dwarf2_add_field): Include field offset when
681 computing variant part length.
682
683 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
684 * NEWS: Mention define-prefix. Tell that command names can now
685 contain a . character.
686
687 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
688
689 * command.h (valid_cmd_char_p): Declare.
690 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
691 the check of valid command char.
692 (find_command_name_length, valid_user_defined_cmd_name_p): Use
693 valid_cmd_char_p.
694 * cli/cli-script.c (validate_comname): Likewise.
695 * completer.c (gdb_completer_command_word_break_characters):
696 Do not remove . from the word break char, update comments.
697 (complete_line_internal_1): Use valid_cmd_char_p.
698 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
699 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
700
701 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
702
703 * cli/cli-script.c (do_define_command): Ensure a redefined
704 prefix command is kept as a prefix command.
705 (define_prefix_command): New function.
706 (show_user_1): Report user defined prefixes.
707 (_initialize_cli_script): Create the new 'define-prefix' command.
708 Add completers for 'define' and 'document'.
709 * top.c (execute_command): If command is a user-defined prefix only
710 command, report the list of commands for this prefix command.
711
712 2019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
713
714 * valops.c (find_oload_champ): Improve debug output.
715
716 2019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
717
718 * valops.c (find_oload_champ): Print part of debug messages
719 before the badness vector is std::move'd.
720
721 2019-11-28 Tom Tromey <tom@tromey.com>
722
723 * value.c (creal_internal_fn): Fix comment.
724
725 2019-11-28 Tom Tromey <tom@tromey.com>
726
727 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
728 flag_bound_evaluated>: Now unsigned.
729
730 2019-11-28 Tom Tromey <tom@tromey.com>
731
732 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
733 declare.
734
735 2019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
736
737 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
738 debug output.
739 * jit.c (jit_unregister_code): Add debug print to match
740 `jit_register_code`.
741
742 2019-11-27 Christian Biesinger <cbiesinger@google.com>
743
744 * NEWS: Mention the new multithreaded symbol loading.
745
746 2019-11-27 Christian Biesinger <cbiesinger@google.com>
747
748 * maint.c (n_worker_threads): Default to 0.
749 (worker_threads_disabled): New function.
750 * maint.h (worker_threads_disabled): New function.
751 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
752 here if worker_threads_disabled () is true.
753 (minimal_symbol_reader::install): Skip all threading if
754 worker_threads_disabled () is true.
755
756 2019-11-27 Christian Biesinger <cbiesinger@google.com>
757
758 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
759 hash code if possible.
760 (add_minsym_to_demangled_hash_table): Likewise.
761 (minimal_symbol_reader::install): Compute the hash codes for msymbol
762 on the background thread.
763 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
764 Add these fields.
765
766 2019-11-27 Christian Biesinger <cbiesinger@google.com>
767
768 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
769 of the mangled name on the background thread.
770 * symtab.c (symbol_set_names): Allow passing in the hash of the
771 linkage_name.
772 * symtab.h (symbol_set_names): Likewise.
773
774 2019-11-27 Kevin Buettner <kevinb@redhat.com>
775
776 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
777 physnames are computed for inherited DIEs.
778
779 2019-11-27 Tom Tromey <tromey@adacore.com>
780
781 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
782 backslashes.
783 * cp-support.c: Remove unnecessary backslashes.
784
785 2019-11-27 Christian Biesinger <cbiesinger@google.com>
786
787 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
788 with sym->set_linkage_name.
789 * coffread.c (coff_read_enum_type): Likewise.
790 * mdebugread.c (parse_symbol): Likewise.
791 * stabsread.c (patch_block_stabs): Likewise.
792 (define_symbol): Likewise.
793 (read_enum_type): Likewise.
794 (common_block_end): Likewise.
795 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
796 function.
797 (SYMBOL_SET_LINKAGE_NAME): Remove.
798 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
799 with sym->set_linkage_name.
800
801 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
802
803 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
804 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
805 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
806 * NEWS: Mention new MI command.
807
808 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
809
810 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
811 '-symbol-info-types', and '-symbol-info-variables'.
812 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
813 (mi_cmd_symbol_info_types): Declare.
814 (mi_cmd_symbol_info_variables): Declare.
815 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
816 (output_debug_symbol): New function.
817 (output_nondebug_symbol): New function.
818 (mi_symbol_info): New function.
819 (mi_info_functions_or_variables): New function.
820 (mi_cmd_symbol_info_functions): New function.
821 (mi_cmd_symbol_info_types): New function.
822 (mi_cmd_symbol_info_variables): New function.
823 * NEWS: Mention new commands.
824
825 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
826
827 * symtab.c (symbol_to_info_string): New function, most content
828 moved from print_symbol_info, but updated to return a std::string.
829 (print_symbol_info): Update to use symbol_to_info_string and print
830 returned string.
831 * symtab.h (symbol_to_info_string): Declare new function.
832
833 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
834
835 * python/python.c (gdbpy_rbreak): Convert to using
836 global_symbol_searcher.
837 * symtab.c (file_matches): Convert return type to bool, change
838 file list to std::vector, update header comment.
839 (search_symbols): Rename to...
840 (global_symbol_searcher::search): ...this and update now its
841 a member function of global_symbol_searcher. Take account of the
842 changes to file_matches.
843 (symtab_symbol_info): Convert to using global_symbol_searcher.
844 (rbreak_command): Likewise.
845 (search_module_symbols): Likewise.
846 * symtab.h (enum symbol_search): Update comment.
847 (search_symbols): Remove declaration.
848 (class global_symbol_searcher): New class.
849
850 2019-11-26 Tom Tromey <tromey@adacore.com>
851
852 * cp-support.c (_initialize_cp_support): Conditionally initialize
853 gdb_demangle_attempt_core_dump.
854
855 2019-11-26 Tom Tromey <tom@tromey.com>
856
857 * python/py-function.c (fnpy_init): Update.
858 * value.h (add_internal_function): Adjust declaration.
859 * value.c (function_destroyer): Remove.
860 (do_add_internal_function): Don't set destroyer or copy name.
861 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
862 Set name_allocated.
863 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
864 (cmdpy_init): Set name_allocated.
865 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
866 member.
867 (~cmd_list_element): Free "name" if needed.
868
869 2019-11-26 Tom Tromey <tom@tromey.com>
870
871 * value.h (add_internal_function): Add new overload. Move
872 documentation from value.h.
873 * value.c (do_add_internal_function): New function.
874 (add_internal_function): Use it. Add new overload.
875 (function_destroyer): Don't free doc.
876 * python/py-function.c (fnpy_init): Update.
877
878 2019-11-26 Tom Tromey <tom@tromey.com>
879
880 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
881 (cmdpy_init): Set "doc_allocated".
882
883 2019-11-26 Tom Tromey <tom@tromey.com>
884
885 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
886 name of worker thread.
887 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
888 pthread_setname_np.
889 * configure, config.in: Rebuild.
890
891 2019-11-26 Tom Tromey <tom@tromey.com>
892
893 * python/python.c (class gdbpy_gil): New.
894 (struct gdbpy_event): Add constructor, destructor, operator().
895 (gdbpy_post_event): Use run_on_main_thread.
896 (gdbpy_initialize_events): Remove.
897 (do_start_initialization): Update.
898
899 2019-11-26 Tom Tromey <tom@tromey.com>
900
901 * NEWS: Add entry.
902 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
903 commands. Call update_thread_pool_size.
904 (update_thread_pool_size, maintenance_set_worker_threads): New
905 functions.
906 (n_worker_threads): New global.
907
908 2019-11-26 Christian Biesinger <cbiesinger@google.com>
909 Tom Tromey <tom@tromey.com>
910
911 * minsyms.c (minimal_symbol_reader::install): Use
912 parallel_for_each.
913 * gdbsupport/parallel-for.h: New file.
914 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
915
916 2019-11-26 Christian Biesinger <cbiesinger@google.com>
917 Tom Tromey <tom@tromey.com>
918
919 * gdbsupport/thread-pool.h: New file.
920 * gdbsupport/thread-pool.c: New file.
921 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
922 (HFILES_NO_SRCDIR): Add thread-pool.h.
923
924 2019-11-26 Tom Tromey <tom@tromey.com>
925
926 * event-top.h (thread_local_segv_handler): Declare.
927 * event-top.c (thread_local_segv_handler): New global.
928 (install_handle_sigsegv, handle_sigsegv): New functions.
929 (async_init_signals): Install SIGSEGV handler.
930 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
931 thread-local.
932 (report_failed_demangle): New function.
933 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
934 handler-setting code, instead use segv_handler. Run warning code
935 on main thread.
936
937 2019-11-26 Tom Tromey <tom@tromey.com>
938
939 * run-on-main-thread.c: New file.
940 * run-on-main-thread.h: New file.
941 * unittests/main-thread-selftests.c: New file.
942 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
943 main-thread-selftests.c.
944 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
945 (COMMON_SFILES): Add run-on-main-thread.c.
946
947 2019-11-26 Tom Tromey <tom@tromey.com>
948
949 * main.c (setup_alternate_signal_stack): Remove.
950 (captured_main_1): Use gdb::alternate_signal_stack.
951 * gdbsupport/alt-stack.h: New file.
952
953 2019-11-26 Tom Tromey <tom@tromey.com>
954
955 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
956 Remove comment.
957 (save_original_signals_state, restore_original_signals_state): Use
958 gdb_sigmask.
959 * linux-nat.c (block_child_signals, restore_child_signals_mask)
960 (_initialize_linux_nat): Use gdb_sigmask.
961 * guile/guile.c (_initialize_guile): Use block_signals.
962 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
963 * gdbsupport/gdb-sigmask.h: New file.
964 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
965 * cp-support.c (gdb_demangle): Use gdb_sigmask.
966 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
967 pthread_sigmask.
968 * configure, config.in: Rebuild.
969 * gdbsupport/block-signals.h: New file.
970
971 2019-11-26 Tom Tromey <tom@tromey.com>
972
973 * acinclude.m4: Include ax_pthread.m4.
974 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
975 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
976 (CLIBS): Use PTHREAD_LIBS.
977 (aclocal_m4_deps): Add ax_pthread.m4.
978 * config.in, configure: Rebuild.
979 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
980
981 2019-11-26 Tom Tromey <tom@tromey.com>
982
983 * symtab.h (struct minimal_symbol) <name_set>: New member.
984 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
985 Don't call symbol_set_names.
986 (minimal_symbol_reader::install): Call symbol_set_names.
987
988 2019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
989
990 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
991 restore_active_ext_lang, as GIL is needed for (indirectly)
992 called PyOS_InterruptOccurred.
993
994 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
995
996 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
997 definition.
998
999 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1000
1001 * remote-sim.c (simulator_command): Make static, remove
1002 declaration.
1003
1004 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1005
1006 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1007 static.
1008 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1009 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1010 (main): Likewise.
1011 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1012 (main): Likewise.
1013 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1014 (main): Likewise.
1015 * unittests/basic_string_view/element_access/char/1.cc (test01):
1016 Likewise.
1017 (main): Likewise.
1018 * unittests/basic_string_view/element_access/char/empty.cc (main):
1019 Likewise.
1020 * unittests/basic_string_view/element_access/char/front_back.cc
1021 (test01): Likewise.
1022 (main): Likewise.
1023 * unittests/basic_string_view/inserters/char/2.cc (test05):
1024 Likewise.
1025 (main): Likewise.
1026 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1027 (test01): Likewise.
1028 (main): Likewise.
1029 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1030 (test01): Likewise.
1031 (main): Likewise.
1032 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1033 Likewise.
1034 * unittests/basic_string_view/operations/compare/char/1.cc
1035 (test01): Likewise.
1036 (main): Likewise.
1037 * unittests/basic_string_view/operations/compare/char/13650.cc
1038 (test01): Likewise.
1039 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1040 Likewise.
1041 (main): Likewise.
1042 * unittests/basic_string_view/operations/data/char/1.cc (test01):
1043 Likewise.
1044 (main): Likewise.
1045 * unittests/basic_string_view/operations/find/char/1.cc (test01):
1046 Likewise.
1047 (main): Likewise.
1048 * unittests/basic_string_view/operations/find/char/2.cc (test02):
1049 Likewise.
1050 (main): Likewise.
1051 * unittests/basic_string_view/operations/find/char/3.cc (test03):
1052 Likewise.
1053 (main): Likewise.
1054 * unittests/basic_string_view/operations/find/char/4.cc (main):
1055 Likewise.
1056 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1057 Likewise.
1058 (main): Likewise.
1059 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1060 Likewise.
1061 (main): Likewise.
1062 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1063 Likewise.
1064 (main): Likewise.
1065 * unittests/basic_string_view/operations/substr/char/1.cc
1066 (test01): Likewise.
1067 (main): Likewise.
1068 * unittests/basic_string_view/operators/char/2.cc (main):
1069 Likewise.
1070 * unittests/optional/assignment/1.cc (test): Likewise.
1071 * unittests/optional/assignment/2.cc (test): Likewise.
1072 * unittests/optional/assignment/3.cc (test): Likewise.
1073 * unittests/optional/assignment/4.cc (test): Likewise.
1074 * unittests/optional/assignment/5.cc (test): Likewise.
1075 * unittests/optional/assignment/6.cc (test): Likewise.
1076 * unittests/optional/assignment/7.cc (test): Likewise.
1077 * unittests/optional/cons/copy.cc (test): Likewise.
1078 * unittests/optional/cons/default.cc (test): Likewise.
1079 * unittests/optional/cons/move.cc (test): Likewise.
1080 * unittests/optional/cons/value.cc (test): Likewise.
1081 * unittests/optional/in_place.cc (test): Likewise.
1082 * unittests/optional/observers/1.cc (test): Likewise.
1083 * unittests/optional/observers/2.cc (test): Likewise.
1084
1085 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1086
1087 * tui-win.h (tui_set_var_cmd): Remove.
1088 * tui-win.c (tui_set_var_cmd): Make static.
1089
1090 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1091
1092 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1093 rbreak_command_wrapper): Remove.
1094 * symtab.c (rbreak_command_wrapper): Remove.
1095
1096 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1097
1098 * inferior.h (info_terminal_command): Remove declaration.
1099 * inflow.c (info_terminal_command): Make static.
1100
1101 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1102
1103 * inferior.c (exit_inferior_silent): Remove.
1104
1105 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1106
1107 * dictionary.c (dict_empty, mdict_empty): Remove.
1108 * dictionary.c (mdict_empty): Remove.
1109
1110 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1111
1112 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1113 (arc_insn_get_memory_offset): Likewise.
1114 (arc_insn_dump): Likewise.
1115 * cp-support.c (test_cp_symbol_name_matches): Likewise.
1116 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1117 * dictionary.c (dict_iterator_next): Likewise.
1118 (dict_iter_match_first): Likewise.
1119 (dict_iter_match_next): Likewise.
1120 * f-lang.c (evaluate_subexp_f): Likewise.
1121 * hppa-tdep.c (hppa_read_pc): Likewise.
1122 * i386-tdep.c (i386_floatformat_for_type): Likewise.
1123 * parse.c (write_exp_elt_msym): Likewise.
1124 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1125 * remote.c (remote_packet_size): Likewise.
1126 (remote_notif_stop_parse): Likewise.
1127 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1128 * s12z-tdep.c (s12z_disassemble_info): Likewise.
1129 * source.c (prepare_path_for_appending): Likewise.
1130 * sparc64-linux-tdep.c
1131 (sparc64_linux_handle_segmentation_fault); Likewise.
1132 * stack.c (frame_selection_by_function_completer): Likewise.
1133
1134 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1135
1136 * completer.c (set_gdb_completion_word_break_characters):
1137 Remove.
1138
1139 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1140
1141 * dwarf-index-write.c: Include dwarf-index-write.h.
1142 * mi/mi-interp.c: Include mi/mi-interp.h.
1143
1144 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1145
1146 * aarch32-tdep.c: Include aarch32-tdep.h.
1147 * aarch32-tdep.h: Forward-declare struct target_desc.
1148
1149 2019-11-26 Christian Biesinger <cbiesinger@google.com>
1150
1151 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1152 strerror.
1153 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1154 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1155
1156 2019-11-25 Tom de Vries <tdevries@suse.de>
1157
1158 * contrib/words.sh: Add -c option.
1159
1160 2019-11-25 Christian Biesinger <cbiesinger@google.com>
1161
1162 * solib.c (solib_find_1): Change int to bool.
1163 (exec_file_find): Change int to bool.
1164 (solib_find): Change int to bool.
1165 (solib_read_symbols): Change int to bool.
1166 (solib_used): Change int to bool.
1167 (solib_add): Change int to bool.
1168 (info_sharedlibrary_command): Change int to bool.
1169 (solib_contains_address_p): Change int to bool.
1170 (solib_keep_data_in_core): Change int to bool.
1171 (in_solib_dynsym_resolve_code): Change int to bool.
1172 (reload_shared_libraries_1): Change int to bool.
1173 (gdb_sysroot_changed): Change int to bool.
1174 * solib.h (solib_read_symbols): Change int to bool.
1175 (solib_contains_address_p): Change int to bool.
1176 (solib_keep_data_in_core): Change int to bool.
1177 (in_solib_dynsym_resolve_code): Change int to bool.
1178 (libpthread_name_p): Change int to bool.
1179
1180 2019-11-25 Luis Machado <luis.machado@linaro.org>
1181
1182 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1183 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1184 (remote_packet_max_chars): New static global.
1185 (show_remote_packet_max_chars): New function.
1186 (remote_target::putpkt_binary): Adjust to use new
1187 remote_packet_max_chars option.
1188 (remote_target::getpkt_or_notif_sane_1): Likewise.
1189 (_initialize_remote): Register new remote-packet-max-chars option.
1190
1191 2019-11-24 Simon Marchi <simon.marchi@efficios.com>
1192
1193 * m68k-linux-nat.c: Include gdbarch.h.
1194
1195 2019-11-24 Tom Tromey <tom@tromey.com>
1196
1197 * symfile.c (read_symbols): Update.
1198 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1199 bool.
1200 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1201 (psym_lookup_symbol, psym_find_last_source_symtab)
1202 (psym_forget_cached_source_info, psym_print_stats)
1203 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1204 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1205 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1206 (psym_find_compunit_symtab_by_address)
1207 (maintenance_print_psymbols, maintenance_info_psymtabs)
1208 (maintenance_check_psymtabs): Update.
1209 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1210 bool.
1211
1212 2019-11-22 Tom Tromey <tom@tromey.com>
1213
1214 * observable.h: Update comments.
1215
1216 2019-11-22 Tom Tromey <tromey@adacore.com>
1217
1218 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1219 (print_ada_task_info): Don't try to fetch thread id if task is not
1220 alive.
1221
1222 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1223
1224 * ada-exp.y: Update.
1225 * ada-lang.c (sort_choices): Update.
1226 (ada_print_symbol_signature): Update.
1227 (resolve_subexp): Update.
1228 (ada_parse_renaming): Update.
1229 (ada_read_renaming_var_value): Update.
1230 (lesseq_defined_than): Update.
1231 (remove_extra_symbols): Update.
1232 (remove_irrelevant_renamings): Update.
1233 (ada_add_block_symbols): Update.
1234 (ada_collect_symbol_completion_matches): Update.
1235 (ada_is_renaming_symbol): Update.
1236 (aggregate_assign_from_choices): Update.
1237 (ada_evaluate_subexp): Update.
1238 (ada_has_this_exception_support): Update.
1239 (ada_is_non_standard_exception_sym): Update.
1240 (ada_add_exceptions_from_frame): Update.
1241 (ada_add_global_exceptions): Update.
1242 (ada_print_subexp): Update.
1243 * ax-gdb.c (gen_var_ref): Update.
1244 (gen_maybe_namespace_elt): Update.
1245 (gen_expr_for_cast): Update.
1246 (gen_expr): Update.
1247 * block.h: Update.
1248 * blockframe.c (find_pc_partial_function): Update.
1249 * breakpoint.c (print_breakpoint_location): Update.
1250 (update_static_tracepoint): Update.
1251 * btrace.c (ftrace_print_function_name): Update.
1252 (ftrace_function_switched): Update.
1253 * buildsym.c (find_symbol_in_list): Update.
1254 * c-exp.y: Update.
1255 * c-typeprint.c (c_print_typedef): Update.
1256 (c_type_print_template_args): Update.
1257 * cli/cli-cmds.c (edit_command): Update.
1258 (list_command): Update.
1259 (print_sal_location): Update.
1260 * coffread.c (patch_opaque_types): Update.
1261 (process_coff_symbol): Update.
1262 (coff_read_enum_type): Update.
1263 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1264 (convert_one_symbol): Update.
1265 (hash_symname): Update.
1266 (eq_symname): Update.
1267 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1268 * compile/compile-cplus-types.c (debug_print_scope): Update.
1269 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1270 * compile/compile-object-load.c (get_out_value_type): Update.
1271 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1272 (search_symbol_list): Update.
1273 (cp_lookup_symbol_imports_or_template): Update.
1274 * cp-support.c (overload_list_add_symbol): Update.
1275 * ctfread.c (psymtab_to_symtab): Update.
1276 * dbxread.c (cp_set_block_scope): Update.
1277 * dictionary.c (iter_match_first_hashed): Update.
1278 (iter_match_next_hashed): Update.
1279 (insert_symbol_hashed): Update.
1280 (iter_match_next_linear): Update.
1281 * dictionary.h: Update.
1282 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1283 (locexpr_describe_location_piece): Update.
1284 (locexpr_describe_location_1): Update.
1285 (locexpr_generate_c_location): Update.
1286 (loclist_describe_location): Update.
1287 (loclist_generate_c_location): Update.
1288 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1289 (read_func_scope): Update.
1290 (process_enumeration_scope): Update.
1291 (new_symbol): Update.
1292 (dwarf2_const_value): Update.
1293 (dwarf2_symbol_mark_computed): Update.
1294 * eval.c (evaluate_funcall): Update.
1295 (evaluate_subexp_standard): Update.
1296 * expprint.c (print_subexp_standard): Update.
1297 (dump_subexp_body_standard): Update.
1298 * f-valprint.c (info_common_command_for_block): Update.
1299 * findvar.c (get_hosting_frame): Update.
1300 (default_read_var_value): Update.
1301 * go-lang.c (go_symbol_package_name): Update.
1302 * guile/scm-block.c (bkscm_print_block_smob): Update.
1303 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1304 (gdbscm_symbol_name): Update.
1305 (gdbscm_symbol_linkage_name): Update.
1306 (gdbscm_symbol_print_name): Update.
1307 * infcall.c (get_function_name): Update.
1308 * infcmd.c (jump_command): Update.
1309 (finish_command): Update.
1310 * infrun.c (insert_exception_resume_breakpoint): Update.
1311 * linespec.c (canonicalize_linespec): Update.
1312 (create_sals_line_offset): Update.
1313 (convert_linespec_to_sals): Update.
1314 (complete_label): Update.
1315 (find_label_symbols_in_block): Update.
1316 * m2-typeprint.c (m2_print_typedef): Update.
1317 * mdebugread.c (mdebug_reg_to_regnum): Update.
1318 (parse_symbol): Update.
1319 (mylookup_symbol): Update.
1320 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1321 (list_args_or_locals): Update.
1322 * objc-lang.c (compare_selectors): Update.
1323 (info_selectors_command): Update.
1324 (compare_classes): Update.
1325 (info_classes_command): Update.
1326 (find_imps): Update.
1327 * p-typeprint.c (pascal_print_typedef): Update.
1328 * printcmd.c (build_address_symbolic): Update.
1329 (info_address_command): Update.
1330 (print_variable_and_value): Update.
1331 * python/py-framefilter.c (extract_sym): Update.
1332 (py_print_single_arg): Update.
1333 * python/py-symbol.c (sympy_str): Update.
1334 (sympy_get_name): Update.
1335 (sympy_get_linkage_name): Update.
1336 * python/python.c (gdbpy_rbreak): Update.
1337 * record-btrace.c (btrace_get_bfun_name): Update.
1338 (btrace_call_history): Update.
1339 * rust-lang.c (rust_print_typedef): Update.
1340 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1341 * stabsread.c (stab_reg_to_regnum): Update.
1342 (define_symbol): Update.
1343 (read_enum_type): Update.
1344 (common_block_end): Update.
1345 (cleanup_undefined_types_1): Update.
1346 (scan_file_globals): Update.
1347 * stack.c (print_frame_arg): Update.
1348 (print_frame_args): Update.
1349 (find_frame_funname): Update.
1350 (info_frame_command_core): Update.
1351 (iterate_over_block_locals): Update.
1352 (print_block_frame_labels): Update.
1353 (do_print_variable_and_value): Update.
1354 (iterate_over_block_arg_vars): Update.
1355 (return_command): Update.
1356 * symmisc.c (dump_symtab_1): Update.
1357 (print_symbol): Update.
1358 * symtab.c (eq_symbol_entry): Update.
1359 (symbol_cache_dump): Update.
1360 (lookup_language_this): Update.
1361 (find_pc_sect_line): Update.
1362 (skip_prologue_sal): Update.
1363 (symbol_search::compare_search_syms): Update.
1364 (treg_matches_sym_type_name): Update.
1365 (search_symbols): Update.
1366 (print_symbol_info): Update.
1367 (rbreak_command): Update.
1368 (completion_list_add_symbol): Update.
1369 (find_gnu_ifunc): Update.
1370 (get_symbol_address): Update.
1371 (search_module_symbols): Update.
1372 (info_module_subcommand): Update.
1373 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1374 (SYMBOL_LINKAGE_NAME): Remove.
1375 (SYMBOL_DEMANGLED_NAME): Remove.
1376 (SYMBOL_PRINT_NAME): Remove.
1377 (SYMBOL_SEARCH_NAME): Remove.
1378 * tracepoint.c (set_traceframe_context): Update.
1379 (validate_actionline): Update.
1380 (collection_list::collect_symbol): Update.
1381 (encode_actions_1): Update.
1382 (info_scope_command): Update.
1383 (print_one_static_tracepoint_marker): Update.
1384 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1385 * valops.c (address_of_variable): Update.
1386 (find_overload_match): Update.
1387 (find_oload_champ): Update.
1388
1389 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1390
1391 * ada-lang.c (ada_lookup_simple_minsym): Update.
1392 (ada_collect_symbol_completion_matches): Update.
1393 * ada-tasks.c (read_atcb): Update.
1394 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1395 (amd64_windows_skip_trampoline_code): Update.
1396 * arm-tdep.c (skip_prologue_function): Update.
1397 (arm_skip_stack_protector): Update.
1398 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1399 (arm_wince_skip_main_prologue): Update.
1400 * ax-gdb.c (gen_expr): Update.
1401 * block.c (call_site_for_pc): Update.
1402 * blockframe.c (find_pc_partial_function): Update.
1403 * breakpoint.c (set_breakpoint_location_function): Update.
1404 * btrace.c (ftrace_print_function_name): Update.
1405 (ftrace_function_switched): Update.
1406 * c-valprint.c (print_unpacked_pointer): Update.
1407 * coffread.c (coff_symfile_read): Update.
1408 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1409 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1410 * dwarf-index-write.c (write_psymbols): Update.
1411 * dwarf2loc.c (call_site_to_target_addr): Update.
1412 (func_verify_no_selftailcall): Update.
1413 (tailcall_dump): Update.
1414 (call_site_find_chain_1): Update.
1415 (dwarf_expr_reg_to_entry_parameter): Update.
1416 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1417 * eval.c (evaluate_funcall): Update.
1418 (evaluate_subexp_standard): Update.
1419 (evaluate_subexp_for_sizeof): Update.
1420 * expprint.c (print_subexp_standard): Update.
1421 (dump_subexp_body_standard): Update.
1422 * frame.c (get_prev_frame_always_1): Update.
1423 * frv-tdep.c (frv_skip_main_prologue): Update.
1424 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1425 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1426 (gnuv3_get_typename_from_type_info): Update.
1427 (gnuv3_skip_trampoline): Update.
1428 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1429 * i386-tdep.c (i386_skip_main_prologue): Update.
1430 (i386_pe_skip_trampoline_code): Update.
1431 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1432 * infcall.c (get_function_name): Update.
1433 * linespec.c (minsym_found): Update.
1434 * linux-fork.c (info_checkpoints_command): Update.
1435 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1436 (m32c_m16c_pointer_to_address): Update.
1437 * maint.c (maintenance_translate_address): Update.
1438 * minsyms.c (add_minsym_to_hash_table): Update.
1439 (add_minsym_to_demangled_hash_table): Update.
1440 (lookup_minimal_symbol_mangled): Update.
1441 (lookup_minimal_symbol_demangled): Update.
1442 (lookup_minimal_symbol_linkage): Update.
1443 (lookup_minimal_symbol_text): Update.
1444 (lookup_minimal_symbol_by_pc_name): Update.
1445 (minimal_symbol_is_less_than): Update.
1446 (compact_minimal_symbols): Update.
1447 (build_minimal_symbol_hash_tables): Update.
1448 (find_solib_trampoline_target): Update.
1449 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1450 (mips_skip_pic_trampoline_code): Update.
1451 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1452 * objc-lang.c (info_selectors_command): Update.
1453 (info_classes_command): Update.
1454 (find_methods): Update.
1455 (find_imps): Update.
1456 * p-valprint.c (pascal_val_print): Update.
1457 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1458 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1459 * printcmd.c (build_address_symbolic): Update.
1460 (info_symbol_command): Update.
1461 * psymtab.c (psymbol_name_matches): Update.
1462 (match_partial_symbol): Update.
1463 (lookup_partial_symbol): Update.
1464 (print_partial_symbols): Update.
1465 (sort_pst_symbols): Update.
1466 (maintenance_check_psymtabs): Update.
1467 * python/py-framefilter.c (py_print_frame): Update.
1468 * python/python.c (gdbpy_rbreak): Update.
1469 * record-btrace.c (btrace_get_bfun_name): Update.
1470 (btrace_call_history): Update.
1471 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1472 (rs6000_skip_trampoline_code): Update.
1473 * sol-thread.c (info_cb): Update.
1474 * stabsread.c (scan_file_globals): Update.
1475 * stack.c (find_frame_funname): Update.
1476 (info_frame_command_core): Update.
1477 * symmisc.c (dump_msymbols): Update.
1478 * symtab.c (symbol_natural_name): Rename to..,
1479 (general_symbol_info::natural_name): ...this.
1480 (symbol_demangled_name): Rename to...
1481 (general_symbol_info::demangled_name): ...this.
1482 (symbol_search_name): Rename to...
1483 (general_symbol_info::search_name): ...this.
1484 (symbol_matches_search_name): Update.
1485 (find_pc_sect_line): Update.
1486 (skip_prologue_sal): Update.
1487 (search_symbols): Update.
1488 (print_msymbol_info): Update.
1489 (rbreak_command): Update.
1490 (completion_list_add_msymbol): Update.
1491 (completion_list_objc_symbol): Update.
1492 (get_msymbol_address): Update.
1493 * symtab.h (struct general_symbol_info): Add member functions
1494 natural_name (), linkage_name (), print_name (), demangled_name (),
1495 and search_name ().
1496 (SYMBOL_NATURAL_NAME): Update.
1497 (symbol_natural_name): Move to a member function on general_symbol_info.
1498 (SYMBOL_DEMANGLED_NAME): Update.
1499 (symbol_demangled_name): Move to a member function on
1500 general_symbol_info.
1501 (SYMBOL_SEARCH_NAME): Update.
1502 (symbol_search_name): Move to a member function on general_symbol_info.
1503 (MSYMBOL_NATURAL_NAME): Remove.
1504 (MSYMBOL_LINKAGE_NAME): Remove.
1505 (MSYMBOL_PRINT_NAME): Remove.
1506 (MSYMBOL_DEMANGLED_NAME): Remove.
1507 (MSYMBOL_SEARCH_NAME): Remove.
1508 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1509
1510 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1511
1512 * symtab.c (create_demangled_names_hash): Use per_bfd->
1513 minimal_symbol_count for computing the initial size, if greater
1514 than our default size.
1515
1516 2019-11-22 Tom de Vries <tdevries@suse.de>
1517
1518 * contrib/words.sh: Improve words extraction.
1519
1520 2019-11-22 Tom de Vries <tdevries@suse.de>
1521
1522 * contrib/words.sh: Combine sed invocations.
1523
1524 2019-11-21 Christian Biesinger <cbiesinger@google.com>
1525
1526 * Makefile.in: Update.
1527 * demangle.c: Rename to...
1528 * gdb-demangle.c: ..this.
1529 (is_cplus_marker): Change return type to bool.
1530 (_initialize_demangler): Rename to...
1531 (_initialize_gdb_demangle): ...this.
1532 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1533 * symtab.h (demangle): Remove declaration; instead include
1534 gdb-demangle.h.
1535
1536 2019-11-21 Tom Tromey <tromey@adacore.com>
1537
1538 * gdbsupport/format.c (format_pieces): Parse %I64d.
1539 * unittests/format_pieces-selftests.c (test_windows_formats): New
1540 function.
1541 (run_tests): Call it.
1542
1543 2019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1544
1545 Byte reverse display of variables with DW_END_big, DW_END_little
1546 (DW_AT_endianity) dwarf attributes if different than the native
1547 byte order.
1548 * ada-lang.c (ada_value_binop):
1549 Use type_byte_order instead of gdbarch_byte_order.
1550 * ada-valprint.c (printstr):
1551 (ada_val_print_string):
1552 * ada-lang.c (value_pointer):
1553 (ada_value_binop):
1554 Use type_byte_order instead of gdbarch_byte_order.
1555 * c-lang.c (c_get_string):
1556 Use type_byte_order instead of gdbarch_byte_order.
1557 * c-valprint.c (c_val_print_array):
1558 Use type_byte_order instead of gdbarch_byte_order.
1559 * cp-valprint.c (cp_print_class_member):
1560 Use type_byte_order instead of gdbarch_byte_order.
1561 * dwarf2loc.c (rw_pieced_value):
1562 Use type_byte_order instead of gdbarch_byte_order.
1563 * dwarf2read.c (read_base_type): Handle DW_END_big,
1564 DW_END_little
1565 * f-lang.c (f_get_encoding):
1566 Use type_byte_order instead of gdbarch_byte_order.
1567 * findvar.c (default_read_var_value):
1568 Use type_byte_order instead of gdbarch_byte_order.
1569 * gdbtypes.c (check_types_equal):
1570 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1571 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1572 and TYPE_ENDIANITY_LITTLE if set.
1573 (type_byte_order): new function.
1574 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1575 (struct main_type) <flag_endianity_not_default>:
1576 New field.
1577 (type_byte_order): New function.
1578 * infcmd.c (default_print_one_register_info):
1579 Use type_byte_order instead of gdbarch_byte_order.
1580 * p-lang.c (pascal_printstr):
1581 Use type_byte_order instead of gdbarch_byte_order.
1582 * p-valprint.c (pascal_val_print):
1583 Use type_byte_order instead of gdbarch_byte_order.
1584 * printcmd.c (print_scalar_formatted):
1585 Use type_byte_order instead of gdbarch_byte_order.
1586 * solib-darwin.c (darwin_current_sos):
1587 Use type_byte_order instead of gdbarch_byte_order.
1588 * solib-svr4.c (solib_svr4_r_ldsomap):
1589 Use type_byte_order instead of gdbarch_byte_order.
1590 * stap-probe.c (stap_modify_semaphore):
1591 Use type_byte_order instead of gdbarch_byte_order.
1592 * target-float.c (target_float_same_format_p):
1593 Use type_byte_order instead of gdbarch_byte_order.
1594 * valarith.c (scalar_binop):
1595 (value_bit_index):
1596 Use type_byte_order instead of gdbarch_byte_order.
1597 * valops.c (value_cast):
1598 Use type_byte_order instead of gdbarch_byte_order.
1599 * valprint.c (generic_emit_char):
1600 (generic_printstr):
1601 (val_print_string):
1602 Use type_byte_order instead of gdbarch_byte_order.
1603 * value.c (unpack_long):
1604 (unpack_bits_as_long):
1605 (unpack_value_bitfield):
1606 (modify_field):
1607 (pack_long):
1608 (pack_unsigned_long):
1609 Use type_byte_order instead of gdbarch_byte_order.
1610 * findvar.c (unsigned_pointer_to_address):
1611 (signed_pointer_to_address):
1612 (unsigned_address_to_pointer):
1613 (address_to_signed_pointer):
1614 (default_read_var_value):
1615 (default_value_from_register):
1616 Use type_byte_order instead of gdbarch_byte_order.
1617 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1618 Use type_byte_order instead of gdbarch_byte_order.
1619 * riscv-tdep.c (riscv_print_one_register_info):
1620 Use type_byte_order instead of gdbarch_byte_order.
1621
1622 2019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1623
1624 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1625 (current_ui_gdb_stdin_ptr): Likewise.
1626 (current_ui_gdb_stderr_ptr): Likewise.
1627 (current_ui_gdb_stdlog_ptr): Likewise.
1628 (current_ui_current_uiout_ptr): Likewise.
1629 (gen_ret_current_ui_field_ptr): Remove.
1630
1631 2019-11-21 Tom de Vries <tdevries@suse.de>
1632
1633 PR gdb/24956
1634 * cli/cli-script.c (execute_control_command): Only switch to
1635 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1636
1637 2019-11-19 Tom Tromey <tom@tromey.com>
1638
1639 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1640 Now static. Change type of "name".
1641 (tui_set_win_height_command): Don't copy "arg".
1642 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1643 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1644
1645 2019-11-19 Ali Tamur <tamur@google.com>
1646
1647 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1648 "if (attr != nullptr)".
1649 (dwarf2_find_base_address): Likewise.
1650 (dwarf2_build_include_psymtabs): Likewise.
1651 (read_cutu_die_from_dwo): Likewise.
1652 (read_func_scope): Likewise.
1653 (read_call_site_scope): Likewise.
1654 (dwarf2_get_pc_bounds): Likewise.
1655 (dwarf2_record_block_ranges): Likewise.
1656 (dwarf2_add_field): Likewise.
1657 (dwarf2_add_member_fn): Likewise.
1658 (read_structure_type): Likewise.
1659 (read_enumeration_type): Likewise.
1660 (read_array_type): Likewise.
1661 (read_array_order): Likewise.
1662 (read_set_type): Likewise.
1663 (read_common_block): Likewise.
1664 (read_tag_reference_type): Likewise.
1665 (read_tag_string_type): Likewise.
1666 (read_subroutine_type): Likewise.
1667 (read_base_type): Likewise.
1668 (read_subrange_type): Likewise.
1669 (new_symbol): Likewise.
1670 (prepare_one_comp_unit): Likewise.
1671
1672 2019-11-19 Tom Tromey <tromey@adacore.com>
1673
1674 * windows-nat.c (windows_nat_target::attach): Include GetLastError
1675 result in error when DebugActiveProcess fails.
1676
1677 2019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
1678 Pedro Alves <palves@redhat.com>
1679
1680 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1681 * target.c (target_stack::push): Call 'unpush' if there's a
1682 target on top of the stack.
1683
1684 2019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1685
1686 * python/py-block.c (blpy_dealloc): Call tp_free.
1687 (blpy_block_syms_dealloc): Likewise.
1688 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1689 * python/py-inferior.c (infpy_dealloc): Likewise.
1690 * python/py-lazy-string.c (stpy_dealloc): Likewise.
1691 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1692 * python/py-symbol.c (sympy_dealloc): Likewise.
1693 * python/py-symtab.c (stpy_dealloc): Likewise.
1694 * python/py-type.c (typy_iterator_dealloc): Likewise.
1695
1696 2019-11-18 Christian Biesinger <cbiesinger@google.com>
1697
1698 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1699 constructor instead of using a class initializer.
1700
1701 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1702
1703 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1704 * configure: Regenerate.
1705 * configure.ac: Don't source common.host.
1706 * gdbsupport/common.host: Remove.
1707 * gdbsupport/mingw-strerror.c: Remove.
1708 * gdbsupport/posix-strerror.c: Rename to...
1709 * gdbsupport/safe-strerror.c: ...this.
1710
1711 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1712
1713 * maint.c (scoped_command_stats::print_time): Use localtime_r
1714 instead of localtime (provided through gnulib if necessary).
1715 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1716 of ctime.
1717
1718 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1719
1720 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1721 avoid compile errors.
1722
1723 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1724
1725 * config.in: Regenerate.
1726 * configure: Regenerate.
1727 * gdbsupport/common.m4: No longer check for strerror_r.
1728 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1729 POSIX version of strerror_r, now that gnulib provides it if
1730 necessary.
1731
1732 2019-11-14 Christian Biesinger <cbiesinger@google.com>
1733
1734 * README (`configure' options): Update.
1735
1736 2019-11-14 Tom Tromey <tromey@adacore.com>
1737
1738 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1739 expected type for the RHS if the LHS is a convenience variable.
1740
1741 2019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
1742
1743 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1744 Provide explicit default and copy constructor.
1745
1746 2019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1747
1748 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1749 only call Py_INCREF (newbp) in the bppy_pending_object case.
1750
1751 2019-11-13 Tom Tromey <tromey@adacore.com>
1752
1753 PR build/25182:
1754 * psympriv.h (partial_symbol): Remove static assert.
1755 * symtab.h (general_symbol_info, symbol): Remove static assert.
1756
1757 2019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
1758
1759 * gdbsupport/format.c (format_pieces::format_pieces): Support
1760 printf 'z' size modifier.
1761 * gdbsupport/format.h (enum argclass): Add size_t_arg.
1762 * printcmd.c (ui_printf): Handle size_t_arg.
1763 * ui-out.c (ui_out::vmessage): Likewise.
1764 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1765 function.
1766 (run_tests): Call test_format_int_sizes.
1767
1768 2019-11-12 Christian Biesinger <cbiesinger@google.com>
1769
1770 * ada-exp.y (write_ambiguous_var): Update.
1771 * buildsym.c (add_symbol_to_list): Update.
1772 * dwarf2read.c (read_variable): Update.
1773 (new_symbol): Update.
1774 * jit.c (finalize_symtab): Update.
1775 * language.c (language_alloc_type_symbol): Update.
1776 * symtab.c (fixup_symbol_section): Update.
1777 (initialize_objfile_symbol_1): Move code to...
1778 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1779 (allocate_symbol): Update.
1780 (allocate_template_symbol): Update.
1781 (get_symbol_address): Update.
1782 * symtab.h (struct symbol): Inherit from general_symbol_info instead
1783 of having as a field, and add a constructor.
1784 (SYMBOL_VALUE): Update.
1785 (SYMBOL_VALUE_ADDRESS): Update.
1786 (SET_SYMBOL_VALUE_ADDRESS): Update.
1787 (SYMBOL_VALUE_BYTES): Update.
1788 (SYMBOL_VALUE_COMMON_BLOCK): Update.
1789 (SYMBOL_BLOCK_VALUE): Update.
1790 (SYMBOL_VALUE_CHAIN): Update.
1791 (SYMBOL_LANGUAGE): Update.
1792 (SYMBOL_SECTION): Update.
1793 (SYMBOL_OBJ_SECTION): Update.
1794 (SYMBOL_SET_LANGUAGE): Update.
1795 (SYMBOL_SET_LINKAGE_NAME): Update.
1796 (SYMBOL_SET_NAMES): Update.
1797 (SYMBOL_NATURAL_NAME): Update.
1798 (SYMBOL_LINKAGE_NAME): Update.
1799 (SYMBOL_DEMANGLED_NAME): Update.
1800 (SYMBOL_SEARCH_NAME): Update.
1801 (SYMBOL_MATCHES_SEARCH_NAME): Update.
1802 (struct symbol): Update.
1803 (struct template_symbol): Update.
1804 (struct rust_vtable_symbol): Update.
1805 * xcoffread.c (SYMBOL_DUP): Update.
1806
1807 2019-11-12 Tom Tromey <tom@tromey.com>
1808
1809 * tui/tui-layout.c (show_layout): Set current_layout.
1810 (show_source_disasm_command, show_data)
1811 (show_source_or_disasm_and_command): Don't set current_layout.
1812
1813 2019-11-12 Tom Tromey <tom@tromey.com>
1814
1815 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1816
1817 2019-11-12 Tom Tromey <tom@tromey.com>
1818
1819 * tui/tui-win.c (resize_message): New global.
1820 (show_tui_resize_message): New function.
1821 (tui_async_resize_screen): Print message if requested.
1822 (_initialize_tui_win): Add tui-resize-message setting.
1823 * NEWS: Add entry for new commands.
1824
1825 2019-11-11 Tom Tromey <tom@tromey.com>
1826
1827 * tui/tui.c (tui_initialize_readline): Add new bindable readline
1828 functions.
1829
1830 2019-11-11 Christian Biesinger <cbiesinger@google.com>
1831
1832 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1833
1834 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1835
1836 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1837 function.
1838 * python/python-internal.h (gdbpy_lookup_static_symbols):
1839 Declare new function.
1840 * python/python.c (python_GdbMethods): Add
1841 gdb.lookup_static_symbols method.
1842 * NEWS: Mention gdb.lookup_static_symbols.
1843
1844 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1845
1846 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1847 static block of current object file first. Also fix typo in
1848 header comment.
1849
1850 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1851
1852 * stack.c (set_last_displayed_sal): Delete.
1853 (last_displayed_sal_valid): Delete.
1854 (last_displayed_pspace): Delete.
1855 (last_displayed_addr): Delete.
1856 (last_displayed_symtab): Delete.
1857 (last_displayed_line): Delete.
1858 (class last_displayed_symtab_info_type): New.
1859 (last_displayed_symtab_info): New static global variable.
1860 (print_frame_info): Call methods on last_displayed_symtab_info.
1861 (clear_last_displayed_sal): Update header comment, and make use of
1862 last_displayed_symtab_info.
1863 (last_displayed_sal_is_valid): Likewise.
1864 (get_last_displayed_pspace): Likewise.
1865 (get_last_displayed_addr): Likewise.
1866 (get_last_displayed_symtab): Likewise.
1867 (get_last_displayed_line): Likewise.
1868 (get_last_displayed_sal): Likewise.
1869 * stack.h (clear_last_displayed_sal): Update header comment.
1870 (last_displayed_sal_is_valid): Likewise.
1871 (get_last_displayed_pspace): Likewise.
1872 (get_last_displayed_addr): Likewise.
1873 (get_last_displayed_symtab): Likewise.
1874 (get_last_displayed_line): Likewise.
1875 (get_last_displayed_sal): Likewise.
1876
1877 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1878
1879 * stack.c (frame_show_address): Convert return type to bool.
1880 * stack.h (frame_show_address): Likewise, and update header
1881 comment.
1882
1883 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1884
1885 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1886 * unittests/vec-utils-selftests.c: New file.
1887 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1888
1889 2019-11-10 Tom Tromey <tom@tromey.com>
1890
1891 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1892 (tui_highlight_win): Likewise.
1893 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1894 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1895 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1896 Don't set can_highlight.
1897
1898 2019-11-10 Tom Tromey <tom@tromey.com>
1899
1900 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1901 Remove unused declaration.
1902
1903 2019-11-08 Tom Tromey <tromey@adacore.com>
1904
1905 * top.c (read_command_file): Update.
1906 (command_line_input): Make return type const.
1907 * python/py-gdb-readline.c: Update.
1908 * linespec.c (decode_line_2): Update.
1909 * defs.h (command_line_input): Make return type const.
1910 * cli/cli-script.c (read_next_line): Make return type const.
1911 * ada-lang.c (get_selections): Update.
1912
1913 2019-11-06 Christian Biesinger <cbiesinger@google.com>
1914
1915 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1916 * mi/mi-main.c (output_cores): Likewise.
1917 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1918 (linux_xfer_osdata_modules): Likewise.
1919 * remote.c (register_remote_support_xml): Likewise.
1920 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1921 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1922
1923 2019-11-06 Tom Tromey <tom@tromey.com>
1924
1925 * tui/tui-interp.c: Don't include readline.h.
1926 * tui/tui-hooks.c: Don't include readline.h.
1927 * symmisc.c: Include tilde.h, not readline.h.
1928 * symfile.c: Include tilde.h, not readline.h.
1929 * source.c: Include tilde.h, not readline.h.
1930 * solib.c: Include tilde.h, not readline.h.
1931 * psymtab.c: Include tilde.h, not readline.h.
1932 * exec.c: Include tilde.h, not readline.h.
1933 * corelow.c: Include tilde.h, not readline.h.
1934 * cli/cli-dump.c: Include tilde.h, not readline.h.
1935 * cli/cli-cmds.c: Don't include readline.h.
1936
1937 2019-11-05 Tom Tromey <tom@tromey.com>
1938
1939 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1940 (tui_disassemble): Set addr_size.
1941 (tui_disasm_window::set_contents): Use addr_size.
1942
1943 2019-11-05 Tom Tromey <tom@tromey.com>
1944
1945 * rust-lang.c (rust_language_defn): Update.
1946 * python/py-value.c (valpy_string): Call c_get_string.
1947 * p-lang.c (pascal_language_defn): Update.
1948 * opencl-lang.c (opencl_language_defn): Update.
1949 * objc-lang.c (objc_language_defn): Update.
1950 * m2-lang.c (m2_language_defn): Update.
1951 * language.c (unknown_language_defn, auto_language_defn): Update.
1952 (default_get_string): Remove.
1953 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1954 * go-lang.c (go_language_defn): Update.
1955 * f-lang.c (f_language_defn): Update.
1956 * d-lang.c (d_language_defn): Update.
1957 * c-lang.c (c_language_defn, cplus_language_defn)
1958 (asm_language_defn, minimal_language_defn): Update.
1959 * ada-lang.c (ada_language_defn): Update.
1960 * language.h (struct language_defn) <la_get_string>: Remove.
1961 (LA_GET_STRING): Remove.
1962 (default_get_string): Don't declare.
1963
1964 2019-11-05 Tom Tromey <tom@tromey.com>
1965
1966 * tui/tui-source.h (struct tui_source_window): Inline
1967 constructor. Remove destructor.
1968 <style_changed, m_observable>: Move to superclass.
1969 * tui/tui-winsource.h (tui_copy_source_line): Declare.
1970 (struct tui_source_window_base): Move private members to end.
1971 <style_changed, m_observable>: Move from tui_source_window.
1972 * tui/tui-winsource.c (tui_copy_source_line): Move from
1973 tui-source.c. Rename from copy_source_line. Add special handling
1974 for negative line number.
1975 (tui_source_window_base::style_changed): Move from
1976 tui_source_window.
1977 (tui_source_window_base): Register observer.
1978 (~tui_source_window_base): New.
1979 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1980 rename.
1981 (tui_source_window::set_contents): Use tui_copy_source_line.
1982 (tui_source_window::tui_source_window): Move to tui-source.h.
1983 (tui_source_window::~tui_source_window): Remove.
1984 (tui_source_window::style_changed): Move to superclass.
1985 * tui/tui-disasm.c (tui_disassemble): Create string file with
1986 styling, when possible. Add "addr_size" parameter.
1987 (tui_disasm_window::set_contents): Use tui_copy_source_line.
1988 Don't compute maximum size.
1989 (len_without_escapes): New function
1990
1991 2019-11-05 Tom Tromey <tom@tromey.com>
1992
1993 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1994 std::string.
1995 * tui/tui-winsource.c (tui_show_source_line): Update.
1996 * tui/tui-source.c (tui_source_window::set_contents): Update.
1997 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1998
1999 2019-11-05 Christian Biesinger <cbiesinger@google.com>
2000
2001 * symtab.h (gdb_static_assert): Put && operator at the beginning
2002 of the line instead of the end.
2003
2004 2019-11-04 Christian Biesinger <cbiesinger@google.com>
2005
2006 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2007 and sizeof (symbol).
2008 * symtab.h: Add a static_assert for sizeof (partial_symbol).
2009
2010 2019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
2011
2012 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2013 * configure.host: Mark *-*-solaris2.10* obsolete.
2014 * configure.tgt: Mark Solaris < 11 obsolete.
2015 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2016 Update target triplet.
2017
2018 2019-11-01 Tom Tromey <tromey@adacore.com>
2019
2020 * utils.c (print_sys_errmsg): Simplify.
2021
2022 2019-11-01 Tom Tromey <tromey@adacore.com>
2023
2024 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2025
2026 2019-11-01 Christian Biesinger <cbiesinger@google.com>
2027
2028 * configure: Regenerate.
2029 * configure.ac: Remove check for strerror_r.
2030 * gdbsupport/common.m4: Check for strerror_r.
2031
2032 2019-11-01 Luis Machado <luis.machado@linaro.org>
2033
2034 PR gdb/25124
2035
2036 * arm-tdep.c (arm_per_objfile): Rename to ...
2037 (arm_per_bfd): ... this.
2038 (arm_objfile_data_key): Rename to ...
2039 (arm_bfd_data_key): ... this.
2040 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2041 data.
2042 (arm_record_special_symbol): Likewise.
2043
2044 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2045
2046 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2047 end.
2048 * c-typeprint.c (c_print_typedef): Likewise.
2049 * f-typeprint.c (f_print_typedef): Likewise.
2050 * m2-typeprint.c (m2_print_typedef): Likewise.
2051 * p-typeprint.c (pascal_print_typedef): Likewise.
2052 * rust-lang.c (rust_print_typedef): Likewise.
2053 * symtab.c (print_symbol_info): Print a newline after calling
2054 typedef_print.
2055
2056 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2057
2058 * symtab.c (info_module_cmdlist): New variable.
2059 (info_module_command): New function.
2060 (search_module_symbols): New function.
2061 (info_module_subcommand): New function.
2062 (struct info_modules_var_func_options): New struct.
2063 (info_modules_var_func_options_defs): New variable.
2064 (make_info_modules_var_func_options_def_group): New function.
2065 (info_module_functions_command): New function.
2066 (info_module_variables_command): New function.
2067 (info_module_var_func_command_completer): New function.
2068 (_initialize_symtab): Register new 'info module functions' and
2069 'info module variables' commands.
2070 * symtab.h (typedef symbol_search_in_module): New typedef.
2071 (search_module_symbols): Declare new function.
2072 * NEWS: Mention new commands.
2073
2074 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2075
2076 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2077 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2078 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2079 MODULES_DOMAIN.
2080 (scan_partial_symbols): Only create partial module symbols for non
2081 declarations.
2082 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2083 and MODULES_DOMAIN.
2084 * symtab.c (search_domain_name): Likewise.
2085 (search_symbols): Likewise.
2086 (print_symbol_info): Likewise.
2087 (symtab_symbol_info): Likewise.
2088 (info_modules_command): New function.
2089 (_initialize_symtab): Register 'info modules' command.
2090 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2091 * NEWS: Mention new 'info modules' command.
2092
2093 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2094
2095 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2096 and $_gdb_maint_setting_str.
2097
2098 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2099
2100 * cli/cli-cmds.c (setting_cmd, value_from_setting)
2101 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2102 (str_value_from_setting, gdb_setting_str_internal_fn)
2103 (gdb_maint_setting_str_internal_fn): New functions.
2104 (_initialize_cli_cmds): Define the new convenience functions.
2105 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2106 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2107
2108 2019-10-31 Christian Biesinger <cbiesinger@google.com>
2109
2110 * agent.c (set_can_use_agent): When the setting is turned on,
2111 look up agent symbols if we don't have them yet.
2112 (agent_new_objfile): Don't look up agent symbols when the agent
2113 setting is off.
2114
2115 2019-10-31 Christian Biesinger <cbiesinger@google.com>
2116
2117 * config.in: Regenerate.
2118
2119 2019-10-31 Christian Biesinger <cbiesinger@google.com>
2120
2121 * configure: Regenerate.
2122 * configure.ac: Check for strerror_r.
2123 * gdbsupport/common-utils.h (safe_strerror): Change return value
2124 to const char * and document that this function is now threadsafe.
2125 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2126 thread_local and call strerror_r, if available.
2127 * utils.c (perror_string): Update.
2128 (print_sys_errmsg): Update.
2129
2130 2019-10-31 Luis Machado <luis.machado@linaro.org>
2131
2132 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2133 objfile_key.
2134 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2135 objfile to fetch per-bfd data.
2136 (arm_find_exidx_entry): Likewise.
2137
2138 2019-10-31 Christian Biesinger <cbiesinger@google.com>
2139
2140 * gdbsupport/agent.c (debug_agent): Change type to bool.
2141 (use_agent): Likewise.
2142 (all_agent_symbols_look_up): Likewise.
2143 (agent_loaded_p): Change return value to bool.
2144 (agent_look_up_symbols): Update.
2145 (agent_capability_check): Change return value to bool.
2146 * gdbsupport/agent.h (agent_loaded_p): Likewise.
2147 (debug_agent): Change type to bool.
2148 (use_agent): Likewise.
2149 (agent_capability_check): Change return value to bool.
2150
2151 2019-10-30 Christian Biesinger <cbiesinger@google.com>
2152
2153 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2154 (build_minimal_symbol_hash_tables): Code to clear the table moved
2155 to clear_minimal_symbol_hash_tables.
2156 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2157 when needed.
2158
2159 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2160
2161 * infcmd.c: Remove includes.
2162 * infrun.c: Remove includes.
2163
2164 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2165
2166 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2167 (grow_vect): Remove declaration.
2168 (ada_type_of_array): Remove declaration.
2169 (ada_update_initial_language): Remove declaration.
2170 (ada_fold_name): Remove declaration.
2171 (ada_fill_in_ada_prototype): Remove declaration.
2172 (user_select_syms): Remove declaration.
2173 (get_selections): Remove declaration.
2174 (ada_tag_type): Remove declaration.
2175 (ada_value_tag): Remove declaration.
2176 (ada_is_others_clause): Remove declaration.
2177 (ada_in_variant): Remove declaration.
2178 (ada_value_struct_elt): Remove declaration.
2179 (ada_attribute_name): Remove declaration.
2180 (ada_system_address_type): Remove declaration.
2181 * ada-lang.c (ada_watch_location_expression): Make static.
2182 (GROW_VECT): Move here from ada-lang.h.
2183 (grow_vect): Make static.
2184 (ada_update_initial_language): Make static.
2185 (ada_fold_name): Make static.
2186 (ada_type_of_array): Make static.
2187 (encoded_ordered_before): Move up.
2188 (sort_choices): Move up.
2189 (print_signatures): Move up.
2190 (ada_print_symbol_signature): Move up.
2191 (get_selections): Move up and make static.
2192 (user_select_syms): Move up and make static.
2193 (ada_value_struct_elt): Move up and make static.
2194 (ada_tag_type): Make static.
2195 (ada_value_tag): Make static.
2196 (ada_is_others_clause): Make static.
2197 (ada_in_variant): Make static.
2198 (ada_attribute_name): Make static.
2199
2200 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2201
2202 * ada-lang.c: Remove includes.
2203 * ada-typeprint.c: Remove includes.
2204 * ada-valprint.c: Remove includes.
2205
2206 2019-10-29 Simon Marchi <simon.marchi@efficios.com>
2207
2208 * addrmap.c: Add static assertions of type size, moved from
2209 _initialize_addrmap.
2210 (_initialize_addrmap): Remove.
2211
2212 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2213
2214 * coffread.c (record_minimal_symbol): Update.
2215 (process_coff_symbol): Update.
2216 * dbxread.c (read_dbx_symtab): Update.
2217 * dwarf2read.c (add_partial_symbol): Update.
2218 (fixup_go_packaging): Update.
2219 (load_partial_dies): Update.
2220 (new_symbol): Update.
2221 * elfread.c (record_minimal_symbol): Change signature to use
2222 gdb::string_view instead of name+len.
2223 (elf_symtab_read): Update.
2224 (elf_rel_plt_read): Update.
2225 * mdebugread.c (parse_partial_symbols): Update.
2226 (handle_psymbol_enumerators): Update.
2227 (new_symbol): Update.
2228 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2229 to use gdb::string_view instead of name+len.
2230 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2231 * psympriv.h (add_psymbol_to_list): Likewise.
2232 * psymtab.c (add_psymbol_to_bcache): Likewise.
2233 (add_psymbol_to_list): Likewise.
2234 * stabsread.c (define_symbol): Update.
2235 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2236 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2237 (symbol_set_names): Likewise.
2238 * xcoffread.c (scan_xcoff_symtab): Update.
2239
2240 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2241
2242 * symtab.h (symbol_set_names): Document that copy_name must be
2243 set to true for non-nullterminated strings.
2244 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2245 linkage_name if the entry was not found and we need to demangle.
2246
2247 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2248
2249 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2250 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2251 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2252 * gdbsupport/gdb_binary_search.h: New file.
2253
2254 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2255
2256 * NEWS: Mention new --with-system-gdbinit-dir option.
2257 * config.in: Regenerate.
2258 * configure: Regenerate.
2259 * configure.ac: Add new option --with-system-gdbinit-dir.
2260 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2261 for a ".gdb" suffix.
2262 * main.c (get_init_files): Change system_gdbinit argument to
2263 a vector and return the files in SYSTEM_GDBINIT_DIR in
2264 addition to SYSTEM_GDBINIT.
2265 (captured_main_1): Update.
2266 (print_gdb_help): Update.
2267 * top.c (print_gdb_configuration): Also print the value of
2268 SYSTEM_GDBINIT_DIR.
2269
2270 2019-10-28 Christian Biesinger <cbiesinger@google.com>
2271
2272 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2273 that takes gdb::string_view arguments.
2274
2275 2019-10-26 Tom de Vries <tdevries@suse.de>
2276
2277 * aarch64-linux-tdep.c: Fix typos in comments.
2278 * aarch64-tdep.c: Same.
2279 * ada-lang.c: Same.
2280 * amd64-nat.c: Same.
2281 * arc-tdep.c: Same.
2282 * arch/aarch64-insn.c: Same.
2283 * block.c: Same.
2284 * breakpoint.h: Same.
2285 * btrace.h: Same.
2286 * c-varobj.c: Same.
2287 * cli/cli-decode.c: Same.
2288 * cli/cli-script.c: Same.
2289 * cli/cli-utils.h: Same.
2290 * coff-pe-read.c: Same.
2291 * coffread.c: Same.
2292 * compile/compile-cplus-symbols.c: Same.
2293 * compile/compile-object-run.c: Same.
2294 * completer.c: Same.
2295 * corelow.c: Same.
2296 * cp-support.c: Same.
2297 * demangle.c: Same.
2298 * dwarf-index-write.c: Same.
2299 * dwarf2-frame.c: Same.
2300 * dwarf2-frame.h: Same.
2301 * eval.c: Same.
2302 * frame-base.h: Same.
2303 * frame.h: Same.
2304 * gdbcmd.h: Same.
2305 * gdbtypes.h: Same.
2306 * gnu-nat.c: Same.
2307 * guile/scm-objfile.c: Same.
2308 * i386-tdep.c: Same.
2309 * i386-tdep.h: Same.
2310 * infcall.c: Same.
2311 * infcall.h: Same.
2312 * linux-nat.c: Same.
2313 * m68k-tdep.c: Same.
2314 * macroexp.c: Same.
2315 * memattr.c: Same.
2316 * mi/mi-cmd-disas.c: Same.
2317 * mi/mi-getopt.h: Same.
2318 * mi/mi-main.c: Same.
2319 * minsyms.c: Same.
2320 * nat/aarch64-sve-linux-sigcontext.h: Same.
2321 * objfiles.h: Same.
2322 * ppc-linux-nat.c: Same.
2323 * ppc-linux-tdep.c: Same.
2324 * ppc-tdep.h: Same.
2325 * progspace.h: Same.
2326 * prologue-value.h: Same.
2327 * python/py-evtregistry.c: Same.
2328 * python/py-instruction.h: Same.
2329 * record-btrace.c: Same.
2330 * record-full.c: Same.
2331 * remote.c: Same.
2332 * rs6000-tdep.c: Same.
2333 * ser-tcp.c: Same.
2334 * sol-thread.c: Same.
2335 * sparc-sol2-tdep.c: Same.
2336 * sparc64-tdep.c: Same.
2337 * stabsread.c: Same.
2338 * symfile.c: Same.
2339 * symtab.h: Same.
2340 * target.c: Same.
2341 * tracepoint.c: Same.
2342 * tui/tui-data.h: Same.
2343 * tui/tui-io.c: Same.
2344 * tui/tui-win.c: Same.
2345 * tui/tui.c: Same.
2346 * unittests/rsp-low-selftests.c: Same.
2347 * user-regs.h: Same.
2348 * utils.c: Same.
2349 * utils.h: Same.
2350 * valarith.c: Same.
2351 * valops.c: Same.
2352 * valprint.c: Same.
2353 * valprint.h: Same.
2354 * value.c: Same.
2355 * value.h: Same.
2356 * varobj.c: Same.
2357 * x86-nat.h: Same.
2358 * xtensa-tdep.c: Same.
2359
2360 2019-10-25 Ali Tamur <tamur@google.com>
2361
2362 * charset.c (find_charset_names): Reflect API change.
2363
2364 2019-10-25 Christian Biesinger <cbiesinger@google.com>
2365
2366 * symtab.c (struct demangled_name_entry): Change demangled name
2367 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2368 part of the struct anymore.
2369 (symbol_set_names): No longer obstack allocate + copy the demangled
2370 name, just store the allocated name from bfd.
2371
2372 2019-10-25 Tom Tromey <tromey@adacore.com>
2373
2374 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2375 (bsearch_cie_cmp, add_cie): Remove.
2376 (find_cie): Reimplement.
2377 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2378 (dwarf2_build_frame_info): Update.
2379
2380 2019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2381
2382 PR gdb/25126
2383 * symfile.c (reread_symbols): Call forget_cached_source_info to
2384 clear the stale source cache.
2385
2386 2019-10-24 Christian Biesinger <cbiesinger@google.com>
2387
2388 * configure: Regenerate.
2389 * configure.ac: Remove code that sets python_has_threads.
2390
2391 2019-10-24 Christian Biesinger <cbiesinger@google.com>
2392
2393 * config.in: Regenerate.
2394 * configure: Regenerate.
2395 * configure.ac: Remove the code that uses sed to get the python
2396 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2397
2398 2019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2399
2400 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2401 error paths.
2402
2403 2019-10-23 Tom Tromey <tom@tromey.com>
2404
2405 * arc-tdep.c: Remove ".." from include.
2406 * frv-tdep.c: Remove ".." from include.
2407 * lm32-tdep.c: Remove ".." from include.
2408 * microblaze-tdep.c: Remove ".." from include.
2409 * or1k-tdep.h: Remove ".." from include.
2410 * s12z-tdep.c: Remove ".." from include.
2411 * Makefile.in (OPCODES_CFLAGS): Add comment.
2412 (TOP_CFLAGS): New variable.
2413 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2414
2415 2019-10-23 Tom Tromey <tom@tromey.com>
2416
2417 * Makefile.in (READLINE_DIR): Update.
2418
2419 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2420
2421 * infcall.c (call_function_by_hand_dummy): Fix the function
2422 comment. And extract out a code section into...
2423 (reserve_stack_space): ...this new function.
2424
2425 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2426
2427 * infcall.c (value_arg_coerce): Remove an unused parameter.
2428 (call_function_by_hand_dummy): Update the call to
2429 'value_arg_coerce'.
2430
2431 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2432
2433 * infcall.c (call_function_by_hand_dummy): Refactor.
2434
2435 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2436
2437 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2438
2439 2019-10-23 Tom Tromey <tom@tromey.com>
2440
2441 * configure: Rebuild.
2442 * configure.ac: Don't check for sigprocmask.
2443 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2444
2445 2019-10-23 Tom Tromey <tom@tromey.com>
2446
2447 * configure: Rebuild.
2448 * acinclude.m4: Use m4_include, not sinclude.
2449
2450 2019-10-23 Tom de Vries <tdevries@suse.de>
2451
2452 PR breakpoints/24687
2453 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2454
2455 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2456
2457 * symtab.c (struct demangled_name_entry) <language>: Change from
2458 bitfield to regular variable.
2459
2460 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2461
2462 * symtab.c (struct demangled_name_entry): Add a constructor.
2463 (free_demangled_name_entry): New function to call the destructor
2464 for demangled_name_entry.
2465 (create_demangled_names_hash): Pass free_demangled_name_entry to
2466 htab_create_alloc.
2467 (symbol_set_names): Call placement new for demangled_name_entry.
2468 * utils.c: No longer include xxhash.h here, now that fast_hash
2469 is inlined in the header.
2470 * utils.h: Instead, include it here.
2471
2472 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2473
2474 * Makefile.in: Link with libxxhash.
2475 * config.in: Regenerate.
2476 * configure: Regenerate.
2477 * configure.ac: Search for libxxhash.
2478 * utils.c (fast_hash): Use xxhash if present.
2479
2480 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2481
2482 * utils.h (fast_hash): New function.
2483 * symtab.c (hash_demangled_name_entry): Call new function
2484 fast_hash.
2485
2486 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2487
2488 * symtab.c (struct demangled_name_entry): Change type of mangled
2489 to gdb::string_view. Also adds a constructor that takes the
2490 mangled name.
2491 (hash_demangled_name_entry): Update.
2492 (eq_demangled_name_entry): Update.
2493 (free_demangled_name_entry): New function to call the destructor
2494 now that this is not a POD anymore.
2495 (create_demangled_names_hash): Pass free_demangled_name_entry to
2496 htab_create_alloc.
2497 (symbol_set_names): Update.
2498
2499 2019-10-21 Ali Tamur <tamu@google.com>
2500
2501 * dwarf2read.c (dir_index): Change type.
2502 (file_name_index): Likewise.
2503 (line_header::include_dir_at): Change comment and implementation on
2504 whether it is DWARF 5.
2505 (line_header::is_valid_file_index): New function.
2506 (line_header::file_name_at): Change comment and implementation on
2507 whether it is DWARF 5.
2508 (line_header::file_names): Change to private field renamed as
2509 m_file_names and introduce a new accessor method.
2510 (line_header::file_names_size): New method.
2511 (line_header::include_dirs): Change to private field and rename as
2512 m_include_dirs.
2513 (dw2_get_file_names_reader): Define local var at a smaller scope and
2514 reflect API change.
2515 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2516 (process_structure_scope): Likewise.
2517 (line_header::add_include_dir): Change message and reflect renaming.
2518 (line_header::add_file_name): Likewise.
2519 (read_formatted_entries): Handle DW_FORM_data16.
2520 (dwarf_decode_line_header): Fix line header length calculation.
2521 (psymtab_include_file_name): Change comment and API.
2522 (lnp_state_machine::m_file): Update comment and reflect type change.
2523 (lnp_state_machine::record_line): Reflect type change.
2524 (dwarf_decode_lines): Reflect API change.
2525 (file_file_name): Likewise.
2526 (file_full_name): Likewise.
2527
2528 2019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2529
2530 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2531
2532 2019-10-21 Tom Tromey <tom@tromey.com>
2533
2534 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2535
2536 2019-10-21 Tom Tromey <tom@tromey.com>
2537
2538 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2539 NM_H. Use AC_CONFIG_LINKS.
2540 * configure: Rebuild.
2541 * Makefile.in (NM_H): New variable.
2542 (generated_files): Add NM_H. Remove gcore.
2543 (nm.h, stamp-nmh): New targets.
2544
2545 2019-10-20 Tom Tromey <tom@tromey.com>
2546
2547 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2548 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2549 obsolete comment.
2550 (put_objfile_before): Now static.
2551
2552 2019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2553
2554 * gdbsupport/common-utils.h (startswith): Change return type to
2555 bool.
2556
2557 2019-10-19 Christian Biesinger <cbiesinger@google.com>
2558
2559 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2560 * breakpoint.c (bp_locations_compare): Rename to...
2561 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2562 (update_global_location_list): Use std::sort instead of qsort.
2563 * buildsym.c (compare_line_numbers): Rename to...
2564 (lte_is_less_than): ...this, and change to std::sort semantics.
2565 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2566 instead of qsort.
2567 * disasm.c (compare_lines): Rename to...
2568 (line_is_less_than): ...this, and change to std::sort semantics.
2569 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2570 of qsort.
2571 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2572 (fde_is_less_than): ...this, and change to std::sort semantics.
2573 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2574 * mdebugread.c (compare_blocks):
2575 (block_is_less_than): ...this, and change to std::sort semantics.
2576 (sort_blocks): Call std::sort instead of qsort.
2577 * objfiles.c (qsort_cmp): Rename to...
2578 (sort_cmp): ...this, and change to std::sort semantics.
2579 (update_section_map): Call std::sort instead of qsort.
2580 * remote.c (compare_pnums): Remove.
2581 (map_regcache_remote_table): Call std::sort instead of qsort.
2582 * utils.c (compare_positive_ints): Remove.
2583 * utils.h (compare_positive_ints): Remove.
2584 * xcoffread.c (compare_lte): Remove.
2585 (arrange_linetable): Call std::sort instead of qsort.
2586
2587 2019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2588
2589 * symfile.c (init_entry_point_info): Fix typo.
2590 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2591
2592 2019-10-18 Tom de Vries <tdevries@suse.de>
2593
2594 * aarch64-tdep.c: Fix typos in comments.
2595 * ada-lang.c: Same.
2596 * ada-tasks.c: Same.
2597 * alpha-tdep.c: Same.
2598 * alpha-tdep.h: Same.
2599 * amd64-nat.c: Same.
2600 * amd64-windows-tdep.c: Same.
2601 * arc-tdep.c: Same.
2602 * arc-tdep.h: Same.
2603 * arch-utils.c: Same.
2604 * arm-nbsd-tdep.c: Same.
2605 * arm-tdep.c: Same.
2606 * ax-gdb.c: Same.
2607 * blockframe.c: Same.
2608 * btrace.c: Same.
2609 * c-varobj.c: Same.
2610 * coff-pe-read.c: Same.
2611 * coffread.c: Same.
2612 * cris-tdep.c: Same.
2613 * darwin-nat.c: Same.
2614 * dbxread.c: Same.
2615 * dcache.c: Same.
2616 * disasm.c: Same.
2617 * dtrace-probe.c: Same.
2618 * dwarf-index-write.c: Same.
2619 * dwarf2-frame-tailcall.c: Same.
2620 * dwarf2-frame.c: Same.
2621 * dwarf2read.c: Same.
2622 * eval.c: Same.
2623 * exceptions.c: Same.
2624 * fbsd-tdep.c: Same.
2625 * findvar.c: Same.
2626 * frame.c: Same.
2627 * frv-tdep.c: Same.
2628 * gnu-v3-abi.c: Same.
2629 * go32-nat.c: Same.
2630 * h8300-tdep.c: Same.
2631 * hppa-tdep.c: Same.
2632 * i386-linux-tdep.c: Same.
2633 * i386-tdep.c: Same.
2634 * ia64-libunwind-tdep.c: Same.
2635 * ia64-tdep.c: Same.
2636 * infcmd.c: Same.
2637 * infrun.c: Same.
2638 * linespec.c: Same.
2639 * linux-nat.c: Same.
2640 * linux-thread-db.c: Same.
2641 * machoread.c: Same.
2642 * mdebugread.c: Same.
2643 * mep-tdep.c: Same.
2644 * mn10300-tdep.c: Same.
2645 * namespace.c: Same.
2646 * objfiles.c: Same.
2647 * opencl-lang.c: Same.
2648 * or1k-tdep.c: Same.
2649 * osabi.c: Same.
2650 * ppc-linux-nat.c: Same.
2651 * ppc-linux-tdep.c: Same.
2652 * ppc-sysv-tdep.c: Same.
2653 * printcmd.c: Same.
2654 * procfs.c: Same.
2655 * record-btrace.c: Same.
2656 * record-full.c: Same.
2657 * remote-fileio.c: Same.
2658 * remote.c: Same.
2659 * rs6000-tdep.c: Same.
2660 * s12z-tdep.c: Same.
2661 * score-tdep.c: Same.
2662 * ser-base.c: Same.
2663 * ser-go32.c: Same.
2664 * skip.c: Same.
2665 * sol-thread.c: Same.
2666 * solib-svr4.c: Same.
2667 * solib.c: Same.
2668 * source.c: Same.
2669 * sparc-nat.c: Same.
2670 * sparc-sol2-tdep.c: Same.
2671 * sparc-tdep.c: Same.
2672 * sparc64-tdep.c: Same.
2673 * stabsread.c: Same.
2674 * stack.c: Same.
2675 * symfile.c: Same.
2676 * symtab.c: Same.
2677 * target-descriptions.c: Same.
2678 * target-float.c: Same.
2679 * thread.c: Same.
2680 * utils.c: Same.
2681 * valops.c: Same.
2682 * valprint.c: Same.
2683 * value.c: Same.
2684 * varobj.c: Same.
2685 * windows-nat.c: Same.
2686 * xcoffread.c: Same.
2687 * xstormy16-tdep.c: Same.
2688 * xtensa-tdep.c: Same.
2689
2690 2019-10-17 Tom Tromey <tromey@adacore.com>
2691
2692 * configure: Rebuild.
2693 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
2694 in AC_CONFIG_FILES invocation.
2695 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2696 new-style config.status invocation.
2697
2698 2019-10-17 Tom de Vries <tdevries@suse.de>
2699
2700 * arm-nbsd-nat.c: Fix typos in comments.
2701 * arm-tdep.c: Same.
2702 * darwin-nat-info.c: Same.
2703 * dwarf2read.c: Same.
2704 * elfread.c: Same.
2705 * event-top.c: Same.
2706 * findvar.c: Same.
2707 * gdbtypes.c: Same.
2708 * hppa-tdep.c: Same.
2709 * i386-tdep.c: Same.
2710 * jit.c: Same.
2711 * main.c: Same.
2712 * mdebugread.c: Same.
2713 * moxie-tdep.c: Same.
2714 * nto-procfs.c: Same.
2715 * osabi.c: Same.
2716 * ppc-linux-tdep.c: Same.
2717 * remote.c: Same.
2718 * riscv-tdep.c: Same.
2719 * s390-tdep.c: Same.
2720 * sh-tdep.c: Same.
2721 * sparc-linux-tdep.c: Same.
2722 * sparc-nat.c: Same.
2723 * stack.c: Same.
2724 * target-descriptions.c: Same.
2725 * top.c: Same.
2726 * varobj.c: Same.
2727
2728 2019-10-16 Tom Tromey <tom@tromey.com>
2729
2730 * objfiles.h (struct objfile) <original_name>: Now const.
2731
2732 2019-10-16 Christian Biesinger <cbiesinger@google.com>
2733
2734 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2735 pass on to sigsetjmp's second argument.
2736 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2737
2738 2019-10-16 Keith Seitz <keiths@redhat.com>
2739
2740 PR gdb/23567
2741 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2742 sections whose size is greater than the file size.
2743
2744 2019-10-16 Jim Wilson <jimw@sifive.com>
2745
2746 * riscv-tdep.c (riscv_gcc_target_options): New.
2747 (riscv_gnu_triplet_regexp): New.
2748 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2749 set_gdbarch_gnu_triplet_regexp.
2750
2751 2019-10-16 Christian Biesinger <cbiesinger@google.com>
2752
2753 * Makefile.in: Add xml-builtin.h.
2754 * features/feature_to_c.sh: Add an include for xml-builtin.h
2755 to ensure that the compiler checks that the types match.
2756 * xml-builtin.h: New file.
2757 * xml-support.c (fetch_xml_builtin): Add missing const.
2758 * xml-support.h: Remove declaration of xml_builtins.
2759
2760 2019-10-16 Tom de Vries <tdevries@suse.de>
2761
2762 PR tdep/25096
2763 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2764 (amd64_classify_aggregate): ... here.
2765 (amd64_classify_aggregate_field): Handled fiels of nested structs
2766 recursively.
2767
2768 2019-10-16 Tom de Vries <tdevries@suse.de>
2769
2770 PR tdep/24104
2771 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2772 that handles 'theclass'.
2773
2774 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2775
2776 * linespec.c (decode_digits_ordinary): Update comment.
2777 * make-target-delegates: No longer need to handle VEC case.
2778 * memrange.c (normalize_mem_ranges): Update comment.
2779 * namespace.c (add_using_directive): Update comment.
2780 * objc-lang.c (uniquify_strings): Update comment.
2781 * ppc-linux-nat.c (struct thread_points): Update comment.
2782 * probe.h (find_probes_in_objfile): Update comment.
2783 * target.h (enum flash_preserve_mode): Update comment.
2784 * varobj.c (varobj_restrict_range): Update comment.
2785 * varobj.h (varobj_list_children): Update comment.
2786
2787 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2788
2789 * Makefile.in: Remove references to vec.h and vec.c.
2790 * aarch64-tdep.c: No longer include vec.h.
2791 * ada-lang.c: Likewise.
2792 * ada-lang.h: Likewise.
2793 * arm-tdep.c: Likewise.
2794 * ax.h: Likewise.
2795 * breakpoint.h: Likewise.
2796 * charset.c: Likewise.
2797 * cp-support.h: Likewise.
2798 * dtrace-probe.c: Likewise.
2799 * dwarf2read.c: Likewise.
2800 * extension.h: Likewise.
2801 * gdb_bfd.c: Likewise.
2802 * gdbsupport/gdb_vecs.h: Likewise.
2803 * gdbsupport/vec.c: Remove.
2804 * gdbsupport/vec.h: Remove.
2805 * gdbthread.h: Likewise.
2806 * guile/scm-type.c: Likewise.
2807 * inline-frame.c: Likewise.
2808 * machoread.c: Likewise.
2809 * memattr.c: Likewise.
2810 * memrange.h: Likewise.
2811 * namespace.h: Likewise.
2812 * nat/linux-btrace.h: Likewise.
2813 * osdata.c: Likewise.
2814 * parser-defs.h: Likewise.
2815 * progspace.h: Likewise.
2816 * python/py-type.c: Likewise.
2817 * record-btrace.c: Likewise.
2818 * rust-exp.y: Likewise.
2819 * solib-target.c: Likewise.
2820 * stap-probe.c: Likewise.
2821 * target-descriptions.c: Likewise.
2822 * target-memory.c: Likewise.
2823 * target.h: Likewise.
2824 * varobj.c: Likewise.
2825 * varobj.h: Likewise.
2826 * xml-support.h: Likewise.
2827
2828 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2829
2830 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2831 Update for new std::vector based implementation.
2832 (process_psymtab_comp_unit_reader): Likewise.
2833 (scan_partial_symbols): Likewise.
2834 (recursively_compute_inclusions): Likewise.
2835 (compute_compunit_symtab_includes): Likewise.
2836 (process_imported_unit_die): Likewise.
2837 (queue_and_load_dwo_tu): Likewise.
2838 (follow_die_sig_1): Likewise.
2839 * gdb/dwarf2read.h: Remove DEF_VEC_P.
2840 (typedef dwarf2_per_cu_ptr): Remove.
2841 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2842 function.
2843 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2844 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2845 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2846 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2847 std::vector.
2848
2849 2019-10-15 Tom Tromey <tromey@adacore.com>
2850
2851 * windows-nat.c (windows_nat_target::resume): Use %x when logging
2852 TID.
2853
2854 2019-10-15 Tom Tromey <tromey@adacore.com>
2855
2856 * windows-nat.c (windows_nat_target::fetch_registers)
2857 (windows_nat_target::store_registers): Rename "pid" to "tid".
2858
2859 2019-10-15 Tom Tromey <tromey@adacore.com>
2860
2861 * gdbarch.h, gdbarch.c: Rebuild.
2862 * gdbarch.sh (gcc_target_options): Change return type to
2863 std::string.
2864 * compile/compile.c (get_args): Update.
2865 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2866 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2867 std::string.
2868 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2869 std::string.
2870 * arch-utils.c (default_gcc_target_options): Return std::string.
2871 * arch-utils.h (default_gcc_target_options): Return std::string.
2872 * s390-tdep.c (s390_gcc_target_options): Return std::string.
2873
2874 2019-10-15 Christian Biesinger <cbiesinger@google.com>
2875
2876 * breakpoint.c (breakpoint_chain): Make static.
2877 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2878 of accessing breakpoint_chain.
2879
2880 2019-10-15 Christian Biesinger <cbiesinger@google.com>
2881
2882 * breakpoint.c (iterate_over_breakpoints): Change function pointer
2883 to a gdb::function_view and return value to bool.
2884 * breakpoint.h (iterate_over_breakpoints): Likewise.
2885 * dummy-frame.c (pop_dummy_frame_bpt): Update.
2886 (pop_dummy_frame): Update.
2887 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2888 (gdbscm_breakpoints): Update.
2889 * python/py-breakpoint.c (build_bp_list): Update.
2890 (gdbpy_breakpoints): Update.
2891 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2892 Update.
2893 (bpfinishpy_handle_stop): Update.
2894 (bpfinishpy_handle_exit): Update.
2895 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2896 (svr4_update_solib_event_breakpoints): Update.
2897
2898 2019-10-15 Andreas Arnez <arnez@linux.ibm.com>
2899
2900 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2901 when unwrapping single-field structs.
2902
2903 2019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
2904
2905 * dwarf2read.c: Remove includes.
2906
2907 2019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
2908
2909 * ui-out.c (ui_out::call_do_message): Silence
2910 -Wformat-nonliteral warning.
2911
2912 2019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
2913
2914 * breakpoint.c: Remove some includes: continuations.h, skip.h,
2915 mi/mi-main.h, readline/readline.h, readline/history.h. Add
2916 include: readline/tilde.h.
2917
2918 2019-10-12 Christian Biesinger <cbiesinger@google.com>
2919
2920 * remote.c (remote_target::get_trace_status): Remove declaration of
2921 trace_regblock_size.
2922
2923 2019-10-12 Christian Biesinger <cbiesinger@google.com>
2924
2925 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2926 (show_user): Remove declaration of cmdlist.
2927 * cli/cli-cmds.h (max_user_call_depth): Declare.
2928 * cli/cli-script.c (execute_user_command): Remove declaration
2929 of max_user_call_depth.
2930
2931 2019-10-11 Jim Wilson <jimw@sifive.com>
2932
2933 * gdbsupport/print-utils.h (pulongest): Fix comment.
2934 (plongest): Likewise.
2935 (phex): Add missing comment, mention leading zeros.
2936 (phex_nz): Add mention of no leading zeros to comment.
2937
2938 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2939 plongest instead of unsigned long long cast.
2940
2941 2019-10-10 Christian Biesinger <cbiesinger@google.com>
2942
2943 * main.c (captured_main_1): Include gdbtk.h and remove declarations
2944 for external_editor_command and gdbtk_test.
2945
2946 2019-10-10 Christian Biesinger <cbiesinger@google.com>
2947
2948 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2949 * varobj.c (varobjdebug): Move comment to...
2950 * varobj.h (varobjdebug): ...here, and declare.
2951
2952 2019-10-09 Tom Tromey <tom@tromey.com>
2953
2954 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2955 erase_data_content.
2956
2957 2019-10-09 Tom Tromey <tom@tromey.com>
2958
2959 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2960 * tui/tui-stack.c (tui_locator_window::rerender): Update.
2961 * tui/tui-command.c (tui_cmd_window::resize)
2962 (tui_refresh_cmd_win): Update.
2963 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2964 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2965 * tui/tui-data.c (~tui_gen_win_info): Remove.
2966 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2967 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2968 (tui_redisplay_readline, tui_mld_flush)
2969 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2970 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2971 (tui_data_window::erase_data_content)
2972 (tui_data_item_window::rerender)
2973 (tui_data_item_window::refresh_window): Update.
2974 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2975 (box_win, tui_gen_win_info::make_window)
2976 (tui_gen_win_info::make_visible): Update.
2977 (tui_delete_win): Remove.
2978 * tui/tui-winsource.c
2979 (tui_source_window_base::do_erase_source_content): Update.
2980 (tui_show_source_line, tui_source_window_base::update_tab_width)
2981 (tui_source_window_base::update_exec_info): Update.
2982 * tui/tui-data.h (struct curses_deleter): New.
2983 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2984 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2985
2986 2019-10-09 Tom Tromey <tom@tromey.com>
2987
2988 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2989
2990 2019-10-09 Tom Tromey <tom@tromey.com>
2991
2992 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2993 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2994
2995 2019-10-09 Tom Tromey <tom@tromey.com>
2996
2997 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2998 window height directly.
2999 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3000 declare.
3001 * tui/tui-layout.c (tui_default_win_height): Remove.
3002 (tui_default_win_viewport_height): Remove.
3003
3004 2019-10-09 Tom Tromey <tom@tromey.com>
3005
3006 * tui/tui.h: Remove comments.
3007
3008 2019-10-09 Tom de Vries <tdevries@suse.de>
3009
3010 * python/lib/gdb/printer/bound_registers.py: Use
3011 '^builtin_type_bound128' as regexp argument for
3012 add_builtin_pretty_printer.
3013
3014 2019-10-09 Christian Biesinger <cbiesinger@google.com>
3015
3016 * guile/guile.c (guile_extension_script_ops): Remove forward
3017 declaration and mark as static.
3018 (guile_script_ops): Likewise.
3019 (extension_language_guile): Move further down in the file so
3020 it can reference the definitions for guile_{extension_,}script_ops.
3021
3022 2019-10-09 Andreas Arnez <arnez@linux.ibm.com>
3023
3024 * s390-tdep.c (390_process_record): Handle new arch13 instructions
3025 except SORTL, DFLTCC, and KDSA.
3026
3027 2019-10-08 Tom Tromey <tromey@adacore.com>
3028
3029 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3030 (struct safe_symbol_file_add_args): Remove.
3031
3032 2019-10-08 Tom Tromey <tromey@adacore.com>
3033
3034 * windows-nat.c: Don't include buildsym-legacy.h.
3035
3036 2019-10-08 Tom Tromey <tromey@adacore.com>
3037
3038 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3039
3040 2019-10-08 Christian Biesinger <cbiesinger@google.com>
3041
3042 * gdbtypes.c (overload_debug): Move comment to header.
3043 * gdbtypes.h (overload_debug): Declare.
3044 * valops.c: Remove declaration of overload_debug, instead
3045 include gdbtypes.h.
3046
3047 2019-10-08 Christian Biesinger <cbiesinger@google.com>
3048
3049 * language.c (show_language_command): Pass lang_frame_mismatch_warn
3050 through _().
3051 (lang_frame_mismatch_warn): Make const, mark with N_(), and
3052 move comment...
3053 * language.h (lang_frame_mismatch_warn): ... here. Also add
3054 declaration.
3055 * top.c (lang_frame_mismatch_warn): Remove declaration.
3056 (check_frame_language_change): Pass lang_frame_mismatch_warn
3057 through _().
3058
3059 2019-10-07 Christian Biesinger <cbiesinger@google.com>
3060
3061 * c-lang.h (vtbl_ptr_name): Declare.
3062 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3063 it from the header.
3064 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3065
3066 2019-10-07 Christian Biesinger <cbiesinger@google.com>
3067
3068 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3069 gdb_static_assert.
3070
3071 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
3072
3073 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3074 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3075 * ctfread.c: New file.
3076 * ctfread.h: New file.
3077 * elfread.c: Include ctfread.h.
3078 (struct elfinfo text_p): New member ctfsect.
3079 (elf_locate_sections): Mark CTF section.
3080 (elf_symfile_read): Call elfctf_build_psymtabs.
3081 * Makefile.in (LIBCTF): Add.
3082 (CLIBS): Use it.
3083 (CDEPS): Likewise.
3084 (DIST): Add ctfread.c.
3085
3086 2019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
3087
3088 * ctfread.c (struct nextfield): Renamed to ...
3089 (struct ctf_nextfield): ... this.
3090 (struct field_info): Renamed to ...
3091 (strut ctf_field_info): ... this.
3092 (attach_fields_to_type): Update for renamed structures.
3093 (ctf_add_member_cb): Likewise.
3094 (ctf_add_enum_member_cb): Likewise.
3095 (process_struct_members): Likewise.
3096 (process_enum_type): Likewise.
3097
3098 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
3099
3100 * tracectf.h: Rename, was ctf.h.
3101 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3102 * tracefile.c: Likewise.
3103 * tracepoint.c: Remove unused include ctf.h.
3104 * mi/mi-main.c: Likewise.
3105 * Makefile.in Replace ctf.c with tracectf.c.
3106
3107 2019-10-06 Joel Brobecker <brobecker@adacore.com>
3108
3109 * version.in: Change version number to "9.0.50.DATE-git".
3110
3111 2019-10-03 Tom Tromey <tom@tromey.com>
3112
3113 PR rust/24976:
3114 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3115
3116 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3117
3118 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3119 cp_search_name_hash.
3120 * NEWS: Add entry about nested function support.
3121
3122 2019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
3123 Andrew Burgess <andrew.burgess@embecosm.com>
3124
3125 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3126 for nested static variables when searchin VAR_DOMAIN.
3127 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3128 global scope, update comment.
3129 (add_partial_subprogram): Call add_partial_subprogram recursively
3130 for nested subroutines when processinng Fortran.
3131 (load_partial_dies): Process the child entities of a subprogram
3132 when processing Fortran.
3133 (partial_die_parent_scope): Handle building scope
3134 for Fortran nested functions.
3135 (process_die): Record that nested functions have a scope.
3136 (new_symbol): Always record Fortran subprograms on the global
3137 symbol list.
3138 (determine_prefix): How to build the prefix for Fortran
3139 subprograms.
3140
3141 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3142
3143 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3144 have just sent the thread a SIGSTOP and are waiting for it to
3145 arrive.
3146
3147 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3148
3149 * btrace.c (btrace_add_pc): Remove whitespace before the template
3150 parameter in 'std::vector <...>'.
3151 (parse_xml_btrace_block): Likewise.
3152 (btrace_maint_decode_pt): Likewise.
3153 (btrace_maint_update_packets): Likewise.
3154 (btrace_maint_print_packets): Likewise.
3155 * btrace.h (struct btrace_maint_info): Likewise.
3156 * dwarf2read.c (struct type_unit_group): Likewise.
3157 (build_type_psymtabs_reader): Likewise.
3158 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3159 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3160 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3161
3162 2019-10-03 Tom de Vries <tdevries@suse.de>
3163
3164 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3165 the first line of the help text for set/show style metadata.
3166
3167 2019-10-02 Tom Tromey <tromey@adacore.com>
3168
3169 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3170 * gdbsupport/common-inferior.c: New file.
3171 * infcmd.c (startup_with_shell): Don't define.
3172 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3173 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3174 * inferior.h (startup_with_shell): Don't declare.
3175
3176 2019-10-02 Christian Biesinger <cbiesinger@google.com>
3177
3178 * gdbsupport/gdb_assert.h: Include errors.h.
3179 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3180
3181 2019-10-02 Tom Tromey <tromey@adacore.com>
3182
3183 * NEWS: Add $_ada_exception entry.
3184 * ada-lang.c (struct ada_catchpoint): Add constructor.
3185 <m_kind>: New member.
3186 (allocate_location_exception, re_set_exception): Remove
3187 "ex" parameter.
3188 (should_stop_exception): Compute $_ada_exception.
3189 (check_status_exception, print_it_exception)
3190 (print_one_exception, print_mention_exception): Remove
3191 "ex" parameter.
3192 (allocate_location_catch_exception, re_set_catch_exception)
3193 (check_status_exception, print_it_catch_exception)
3194 (print_one_catch_exception, print_mention_catch_exception)
3195 (print_recreate_catch_exception)
3196 (allocate_location_catch_exception_unhandled)
3197 (re_set_catch_exception_unhandled)
3198 (check_status_exception, print_it_catch_exception_unhandled)
3199 (print_one_catch_exception_unhandled)
3200 (print_mention_catch_exception_unhandled)
3201 (print_recreate_catch_exception_unhandled)
3202 (allocate_location_catch_assert, re_set_catch_assert)
3203 (check_status_assert, print_it_catch_assert)
3204 (print_one_catch_assert, print_mention_catch_assert)
3205 (print_recreate_catch_assert)
3206 (allocate_location_catch_handlers, re_set_catch_handlers)
3207 (check_status_handlers, print_it_catch_handlers)
3208 (print_one_catch_handlers, print_mention_catch_handlers)
3209 (print_recreate_catch_handlers): Remove.
3210 (create_ada_exception_catchpoint): Update.
3211 (initialize_ada_catchpoint_ops): Update.
3212
3213 2019-10-02 Tom Tromey <tromey@adacore.com>
3214
3215 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3216 (create_excep_cond_exprs): Simplify exception string computation.
3217 (ada_exception_catchpoint_cond_string): Likewise.
3218
3219 2019-10-02 Tom Tromey <tromey@adacore.com>
3220
3221 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3222 * ada-lang.c (lesseq_defined_than): Handle
3223 LOC_STATIC.
3224 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3225 parameter.
3226 (dwarf2_has_info): Likewise.
3227 (new_symbol): Set maybe_copied on symbol when
3228 appropriate.
3229 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3230 parameter.
3231 <can_copy>: New member.
3232 * elfread.c (record_minimal_symbol): Set maybe_copied
3233 on symbol when appropriate.
3234 (elf_symfile_read): Update call to dwarf2_has_info.
3235 * minsyms.c (lookup_minimal_symbol_linkage): New
3236 function.
3237 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3238 * symtab.c (get_symbol_address, get_msymbol_address):
3239 New functions.
3240 * symtab.h (get_symbol_address, get_msymbol_address):
3241 Declare.
3242 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3243 maybe_copied.
3244 (struct symbol, struct minimal_symbol) <maybe_copied>:
3245 New member.
3246
3247 2019-10-02 Tom Tromey <tromey@adacore.com>
3248
3249 * source.c (struct current_source_location): New.
3250 (current_source_key): New global.
3251 (current_source_symtab, current_source_line)
3252 (current_source_pspace): Remove.
3253 (get_source_location): New function.
3254 (get_current_source_symtab_and_line)
3255 (set_default_source_symtab_and_line)
3256 (set_current_source_symtab_and_line)
3257 (clear_current_source_symtab_and_line, select_source_symtab)
3258 (info_source_command, print_source_lines_base)
3259 (info_line_command, search_command_helper, _initialize_source):
3260 Update.
3261
3262 2019-10-02 Tom Tromey <tromey@adacore.com>
3263
3264 * source.c (select_source_symtab): Don't call
3265 decode_line_with_current_source.
3266
3267 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3268
3269 * symtab.c (lookup_global_symbol): Search global block.
3270
3271 2019-10-02 Tom Tromey <tromey@adacore.com>
3272
3273 * coffread.c (process_coff_symbol): Update.
3274 * dwarf2read.c (var_decode_location, new_symbol): Update.
3275 * mdebugread.c (parse_symbol): Update.
3276 * objfiles.c (relocate_one_symbol): Update.
3277 * stabsread.c (define_symbol, fix_common_block)
3278 (scan_file_globals): Update.
3279 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3280 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3281 * xcoffread.c (process_xcoff_symbol): Update.
3282
3283 2019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3284
3285 * MAINTAINERS: Update my email address.
3286
3287 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3288
3289 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3290 std::vector.
3291 (build_type_psymtabs_reader): Update for std::vector.
3292 (build_type_psymtab_dependencies): Likewise.
3293 * dwarf2read.h: Remove use of DEF_VEC_P.
3294 (typedef sig_type_ptr): Delete.
3295
3296 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3297
3298 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3299 to std::vector.
3300 (btrace_maint_decode_pt): Likewise, and move allocation of the
3301 vector outside of the loop.
3302 (btrace_maint_update_packets): Update to handle change from VEC to
3303 std::vector.
3304 (btrace_maint_print_packets): Likewise.
3305 (maint_info_btrace_cmd): Likewise.
3306 * btrace.h: Remove use of DEF_VEC_O.
3307 (typedef btrace_pt_packet_s): Delete.
3308 (struct btrace_maint_info) <packets>: Change fromm VEC to
3309 std::vector.
3310 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3311
3312 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3313
3314 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3315 make accesses into the vector constant references.
3316 (btrace_add_pc): Update for std::vector.
3317 (btrace_stitch_bts): Likewise.
3318 (parse_xml_btrace_block): Likewise.
3319 (btrace_maint_update_packets): Likewise.
3320 (btrace_maint_print_packets): Likewise.
3321 (maint_info_btrace_cmd): Likewise.
3322 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3323 std::vector.
3324 (btrace_data::empty): Likewise.
3325 (btrace_data_append): Likewise.
3326 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3327 (typedef btrace_block_s): Delete.
3328 (struct btrace_block): Add constructor.
3329 (struct btrace_data_bts) <blocks>: Change to std::vector.
3330 * nat/linux-btrace.c (perf_event_read_bts): Update for
3331 std::vector.
3332 (linux_read_bts): Likewise.
3333
3334 2019-10-01 Tom Tromey <tom@tromey.com>
3335
3336 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3337
3338 2019-10-01 Tom Tromey <tom@tromey.com>
3339
3340 * stack.c (print_frame, info_frame_command_core): Use
3341 styled_string.
3342 * linux-thread-db.c (try_thread_db_load_1)
3343 (try_thread_db_load_from_pdir_1): Use styled_string.
3344 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3345 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3346 (maybe_print_unsupported_script_warning)
3347 (maybe_print_script_not_found_warning): Use styled_string.
3348 * ada-lang.c (user_select_syms): Use styled_string.
3349
3350 2019-10-01 Tom Tromey <tom@tromey.com>
3351
3352 * p-lang.c (pascal_printstr): Use metadata style.
3353 * value.c (show_convenience): Use metadata style.
3354 * valprint.c (valprint_check_validity, val_print_optimized_out)
3355 (val_print_not_saved, val_print_unavailable)
3356 (val_print_invalid_address, generic_val_print, val_print)
3357 (value_check_printable, val_print_array_elements): Use metadata
3358 style.
3359 * ui-out.h (class ui_out) <field_fmt>: New overload.
3360 <do_field_fmt>: Add style parameter.
3361 * ui-out.c (ui_out::field_fmt): New overload.
3362 * typeprint.c (type_print_unknown_return_type)
3363 (val_print_not_allocated, val_print_not_associated): Use metadata
3364 style.
3365 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3366 parameter.
3367 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3368 * tracepoint.c (tvariables_info_1): Use metadata style.
3369 * stack.c (print_frame_arg, print_frame_info, print_frame)
3370 (info_frame_command_core): Use metadata style.
3371 * skip.c (info_skip_command): Use metadata style.
3372 * rust-lang.c (rust_print_enum): Use metadata style.
3373 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3374 metadata style.
3375 * python/py-framefilter.c (py_print_single_arg): Use metadata
3376 style.
3377 * printcmd.c (do_one_display, print_variable_and_value): Use
3378 metadata style.
3379 * p-valprint.c (pascal_val_print)
3380 (pascal_object_print_value_fields): Use metadata style.
3381 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3382 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3383 parameter.
3384 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3385 * m2-valprint.c (m2_print_long_set): Use metadata style.
3386 * m2-typeprint.c (m2_print_type): Use metadata style.
3387 * infcmd.c (print_return_value_1): Use metadata style.
3388 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3389 * f-valprint.c (info_common_command_for_block): Use metadata
3390 style.
3391 * f-typeprint.c (f_type_print_base): Use metadata style.
3392 * expprint.c (print_subexp_standard): Use metadata style.
3393 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3394 * cli/cli-style.h (class cli_style_option): Add constructor.
3395 (metadata_style): Declare.
3396 * cli/cli-style.c (metadata_style): New global.
3397 (_initialize_cli_style): Register metadata style.
3398 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3399 parameter.
3400 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3401 * c-typeprint.c (c_type_print_base_struct_union)
3402 (c_type_print_base_1): Use metadata style.
3403 * breakpoint.c (watchpoint_value_print)
3404 (print_one_breakpoint_location): Use metadata style.
3405 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3406 style.
3407 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3408 style.
3409 * ada-valprint.c (val_print_packed_array_elements, printstr)
3410 (print_field_values, ada_val_print_ref, ada_val_print): Use
3411 metadata style.
3412 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3413 style.
3414 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3415 style.
3416 * ada-lang.c (user_select_syms): Use metadata style.
3417
3418 2019-10-01 Tom Tromey <tom@tromey.com>
3419
3420 * cli/cli-cmds.c (pwd_command): Style output.
3421
3422 2019-10-01 Pedro Alves <palves@redhat.com>
3423 Tom Tromey <tom@tromey.com>
3424
3425 * symtab.c (print_symbol_info): Use %ps.
3426 (print_msymbol_info): Use %ps.
3427 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3428 * printcmd.c (print_variable_and_value): Use %ps.
3429 * macrocmd.c (show_pp_source_pos): Use %ps.
3430 * infrun.c (print_exited_reason): Use ui_out::message.
3431 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3432 (describe_other_breakpoints): Use ui_out::message and new
3433 formats.
3434 (say_where): Use new formats.
3435 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3436 and new formats.
3437
3438 2019-10-01 Pedro Alves <palves@redhat.com>
3439 Tom Tromey <tom@tromey.com>
3440
3441 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3442 (test_gdb_formats): New function.
3443 (run_tests): Call it.
3444 (test_format_specifier): Update.
3445 * utils.h (fputs_filtered): Update comment.
3446 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3447 (fputs_styled_unfiltered): Declare.
3448 * utils.c (fputs_styled_unfiltered): New function.
3449 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3450 (vfprintf_filtered): Update.
3451 (vfprintf_unfiltered, vprintf_filtered): Update.
3452 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3453 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3454 disallow_ui_out_field>: New constants.
3455 (enum class field_kind): New.
3456 (struct base_field_s, struct signed_field_s): New.
3457 (signed_field): New function.
3458 (struct string_field_s): New.
3459 (string_field): New function.
3460 (struct styled_string_s): New.
3461 (styled_string): New function.
3462 (class ui_out) <message>: Add comment.
3463 <vmessage, call_do_message>: New methods.
3464 <do_message>: Add style parameter.
3465 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3466 methods.
3467 (ui_out::message): Rewrite.
3468 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3469 parameter.
3470 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3471 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3472 gdb_extensions parameter.
3473 (class format_piece): Add parameter to constructor.
3474 (n_int_args): New field.
3475 * gdbsupport/format.c (format_pieces::format_pieces): Add
3476 gdb_extensions parameter. Handle '*'.
3477 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3478 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3479 vfprintf_styled_no_gdbfmt.
3480 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3481 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3482 unfiltered output.
3483 * ui-style.h (struct ui_file_style) <ptr>: New method.
3484
3485 2019-10-01 Tom Tromey <tom@tromey.com>
3486
3487 * unittests/format_pieces-selftests.c: Update. Add final format.
3488 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3489 empty literal pieces.
3490
3491 2019-10-01 Tom Tromey <tom@tromey.com>
3492
3493 * ui-out.h (enum class ui_out_style_kind): Remove.
3494 (class ui_out) <field_string, field_stsream, do_field_string>:
3495 Change type of "style".
3496 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3497 (ui_out::field_string): Update.
3498 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3499 of "style".
3500 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3501 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3502 * stack.c (print_frame_arg, print_frame_info, print_frame):
3503 Update.
3504 * source.c (print_source_lines_base): Update.
3505 * solib.c (info_sharedlibrary_command): Update.
3506 * skip.c (info_skip_command): Update.
3507 * record-btrace.c (btrace_call_history_src_line)
3508 (btrace_call_history): Update.
3509 * python/py-framefilter.c (py_print_frame): Update.
3510 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3511 "style".
3512 * mi/mi-out.c (mi_ui_out::do_table_header)
3513 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3514 (mi_ui_out::do_field_string): Update.
3515 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3516 Update.
3517 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3518 "style".
3519 * cli-out.c (cli_ui_out::do_table_header)
3520 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3521 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3522 (cli_ui_out::do_field_fmt): Update.
3523 * breakpoint.c (print_breakpoint_location): Update.
3524 (update_static_tracepoint): Update.
3525
3526 2019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3527
3528 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3529 conversion of gdb_datadir.
3530 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3531 remove not needed c_str ().
3532
3533 2019-09-30 Ali Tamur <tamur@google.com>
3534
3535 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3536 (dwarf2_string_attr): Likewise.
3537
3538 2019-09-30 Ali Tamur <tamur@google.com>
3539
3540 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3541 (process_full_type_unit): Likewise.
3542 (dump_die_shallow): Likewise.
3543 (cu_debug_loc_section): Likewise.
3544
3545 2019-09-28 Christian Biesinger <cbiesinger@google.com>
3546
3547 * minsyms.c (compare_minimal_symbols): Rename to...
3548 (minimal_symbol_is_less_than): ...this, and adjust to STL
3549 conventions (return bool, take arguments as references)
3550 (minimal_symbol_reader::install): Call std::sort instead
3551 of qsort.
3552
3553 2019-09-29 Christian Biesinger <cbiesinger@google.com>
3554
3555 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3556 hash and why.
3557 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3558 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3559
3560 2019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3561
3562 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3563 * psympriv.h (add_psymbol_to_list): Move comment here and update
3564 it.
3565
3566 2019-09-29 Tom de Vries <tdevries@suse.de>
3567
3568 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3569 Use $tmpdir/$(basename "$output_file").dwz instead of
3570 "${output_file}.dwz".
3571
3572 2019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3573
3574 PR gdb/25045
3575 * hppa-linux-nat.c: Include gdbarch.h.
3576
3577 2019-09-26 Christian Biesinger <cbiesinger@google.com>
3578
3579 * blockframe.c (find_pc_partial_function): Change return type to bool.
3580 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3581 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3582 (stub_gnu_ifunc_resolve_name): Likewise.
3583 * symtab.c (compare_filenames_for_search): Likewise.
3584 (compare_glob_filenames_for_search): Likewise.
3585 (matching_obj_sections): Likewise.
3586 (symbol_matches_domain): Likewise.
3587 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3588 (find_line_pc): Change return type to bool.
3589 (find_line_pc_range): Likewise.
3590 (producer_is_realview): Likewise.
3591 * symtab.h (symbol_matches_domain): Likewise.
3592 (find_pc_partial_function): Likewise.
3593 (find_pc_line_pc_range): Likewise.
3594 (in_gnu_ifunc_stub): Likewise.
3595 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3596 (find_line_pc): Likewise.
3597 (find_line_pc_range): Likewise.
3598 (matching_obj_sections): Likewise.
3599 (find_line_symtab): Change out parameter to bool.
3600 (producer_is_realview): Change return type to bool.
3601 (compare_filenames_for_search): Likewise.
3602 (compare_glob_filenames_for_search): Likewise.
3603
3604 2019-09-26 Tom Tromey <tom@tromey.com>
3605
3606 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3607 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3608 * gdb_usleep.h: Remove.
3609 * gdb_usleep.c: Remove.
3610 * utils.c: Don't include gdb_usleep.h.
3611
3612 2019-09-26 Tom Tromey <tromey@adacore.com>
3613
3614 * python/py-type.c (type_to_type_object): Call check_typedef
3615 for stub types.
3616
3617 2019-09-26 Tom Tromey <tom@tromey.com>
3618
3619 * utils.h (initialize_utils): Don't declare.
3620 * top.c (gdb_init): Don't call initialize_utils.
3621 * utils.c (initialize_utils): Remove. Move contents...
3622 (_initialize_utils): ... here.
3623
3624 2019-09-25 Tom Tromey <tom@tromey.com>
3625
3626 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3627 * utils.h (make_hex_string): Don't declare.
3628 * utils.c (make_hex_string): Remove.
3629
3630 2019-09-24 Tom de Vries <tdevries@suse.de>
3631
3632 PR gdb/23815
3633 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3634 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3635
3636 2019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3637
3638 * NEWS: Mention new simulator port for PRU.
3639
3640 2019-09-23 Christian Biesinger <cbiesinger@google.com>
3641
3642 * ada-exp.y (write_object_remaining): Update.
3643 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3644 and eliminate the static buffer.
3645 (ada_decode_symbol): Update.
3646 (ada_la_decode): Update.
3647 (ada_sniff_from_mangled_name): Update.
3648 (is_valid_name_for_wild_match): Update.
3649 (ada_lookup_name_info::matches): Update and simplify.
3650 (name_matches_regex): Update.
3651 (ada_add_global_exceptions): Update.
3652 * ada-lang.h (ada_decode): Update signature.
3653 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3654 * dwarf-index-write.c (debug_names::insert): Update.
3655
3656 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3657
3658 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3659 formatting.
3660
3661 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3662
3663 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3664 Change "nonzero" to "true" in documentation.
3665
3666 2019-09-20 Christian Biesinger <cbiesinger@google.com>
3667
3668 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3669 (_initialize_darwin_solib): Don't set
3670 darwin_so_ops.lookup_lib_global_symbol.
3671 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3672 set_gdbarch_iterate_over_objfiles_in_search_order.
3673 (elf_lookup_lib_symbol): Rename to...
3674 (svr4_iterate_over_objfiles_in_search_order): this, and update
3675 to iterate semantics.
3676 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3677 * solib.c (solib_global_lookup): Remove.
3678 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3679 (solib_global_lookup): Remove.
3680 * symtab.c (lookup_global_or_static_symbol): Remove call to
3681 solib_global_lookup.
3682
3683 2019-09-20 Joel Brobecker <brobecker@adacore.com>
3684
3685 * NEWS: Move entries about default MI version now being
3686 version 3, and about the GDB/MI fix for multi-location
3687 breakpoints to the "since GDB 8.3" section.
3688
3689 2019-09-20 Joel Brobecker <brobecker@adacore.com>
3690
3691 GDB 8.3.1 released.
3692
3693 2019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
3694
3695 * NEWS: Mention that Cell/B.E. debugging support was removed.
3696 * MAINTAINERS: Remove spu target.
3697
3698 * config/djgpp/fnchange.lst: Remove entries for removed files.
3699
3700 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3701 spu-multiarch.o, and spu-tdep.o.
3702 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3703 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3704 spu-multiarch.c, and spu-tdep.c.
3705 * spu-linux-nat.c: Remove file.
3706 * spu-multiarch.c: Remove file.
3707 * spu-tdep.c: Remove file.
3708 * spu-tdep.h: Remove file.
3709 * solib-spu.c: Remove file.
3710 * solib-spu.h: Remove file.
3711
3712 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3713 * configure.nat (spu-linux): Remove.
3714 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3715 solib-multiarch.o from gdb_target_obs.
3716 (spu*-*-*): Remove.
3717
3718 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3719 feature flag.
3720 (ppc_linux_no_features): Update.
3721 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3722 Cell/B.E. support.
3723 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3724 (tdesc_powerpc_cell64l): Likewise.
3725 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3726 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3727 Cell/B.E. support.
3728 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3729 Do not include "features/rs6000/powerpc-cell32l.c" or
3730 "features/rs6000/powerpc-cell64l.c".
3731 (ppc_linux_spu_section): Remove.
3732 (ppc_linux_core_read_description): Remove Cell/B.E. support.
3733 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3734 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3735 (ppc_linux_spe_context_lookup): Remove.
3736 (ppc_linux_spe_context_inferior_created): Remove.
3737 (ppc_linux_spe_context_solib_loaded): Remove.
3738 (ppc_linux_spe_context_solib_unloaded): Remove.
3739 (ppc_linux_spe_context): Remove.
3740 (struct ppu2spu_cache): Remove.
3741 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3742 (struct ppu2spu_data): Remove.
3743 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3744 ppu2spu_unwind): Remove.
3745 (ppc_linux_init_abi): Remove Cell/B.E. support.
3746 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3747
3748 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3749 (rs6000/powerpc-cell64l-expedite): Likewise
3750 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3751 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3752 rs6000/powerpc-cell64l.xml.
3753 * features/rs6000/powerpc-cell32l.xml: Remove.
3754 * features/rs6000/powerpc-cell64l.xml: Likewise.
3755 * features/rs6000/powerpc-cell32l.c: Remove generated file.
3756 * features/rs6000/powerpc-cell64l.c: Likewise.
3757 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3758 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3759 * regformats/reg-spu.dat: Remove.
3760
3761 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3762 * corelow.c (struct spuid_list): Remove.
3763 (add_to_spuid_list): Remove.
3764 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3765 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3766 (remote_protocol_features): Remove associated entries.
3767 (_initialize_remote): No longer initialize them.
3768 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3769 * linux-nat.c (SPUFS_MAGIC): Remove.
3770 (linux_proc_xfer_spu): Remove.
3771 (spu_enumerate_spu_ids): Remove.
3772 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3773 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3774 (linux_make_corefile_notes): No longer call it.
3775
3776 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3777 (cooked_write_test): Likewise.
3778
3779 2019-09-20 Tom Tromey <tom@tromey.com>
3780
3781 * NEWS: Mention case-sensitivity of TUI commands.
3782 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3783 (tui_set_win_height_command, parse_scrolling_args): Likewise.
3784 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3785
3786 2019-09-20 Tom Tromey <tom@tromey.com>
3787
3788 * tui/tui-source.c (tui_source_window::set_contents): Use
3789 make_unique_xstrdup.
3790 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3791 make_unique_xstrdup.
3792
3793 2019-09-20 Tom Tromey <tom@tromey.com>
3794
3795 * tui/tui-data.c: Remove separator comments.
3796 * tui/tui-layout.c: Remove separator comments.
3797 * tui/tui-win.c: Remove separator comments.
3798 * tui/tui-wingeneral.c: Remove separator comments.
3799
3800 2019-09-20 Tom Tromey <tom@tromey.com>
3801
3802 * tui/tui.h (strcat_to_buf): Don't declare.
3803 * tui/tui.c (strcat_to_buf): Remove.
3804
3805 2019-09-20 Tom Tromey <tom@tromey.com>
3806
3807 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3808 from "fullname".
3809 * tui/tui-source.c (tui_source_window::set_contents)
3810 (tui_source_window::location_matches_p)
3811 (tui_source_window::maybe_update): Update.
3812
3813 2019-09-20 Tom Tromey <tom@tromey.com>
3814
3815 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3816 Update.
3817 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3818 prefix.
3819 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3820 (tui_data_window::line_from_reg_element_no)
3821 (tui_data_window::first_reg_element_no_inline)
3822 (tui_data_window::show_registers)
3823 (tui_data_window::show_register_group)
3824 (tui_data_window::display_registers_from)
3825 (tui_data_window::display_registers_from_line)
3826 (tui_data_window::first_data_item_displayed)
3827 (tui_data_window::delete_data_content_windows)
3828 (tui_data_window::erase_data_content)
3829 (tui_data_window::do_scroll_vertical)
3830 (tui_data_window::refresh_window)
3831 (tui_data_window::check_register_values): Update.
3832
3833 2019-09-20 Tom Tromey <tom@tromey.com>
3834
3835 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3836 (struct tui_locator_window) <full_name, proc_name>: Now
3837 std::string.
3838 * tui/tui-stack.c (tui_locator_window::make_status_line)
3839 (tui_locator_window::set_locator_fullname)
3840 (tui_locator_window::set_locator_info): Update.
3841 * tui/tui-source.c (tui_source_window::set_contents)
3842 (tui_source_window::showing_source_p): Update.
3843
3844 2019-09-20 Tom Tromey <tom@tromey.com>
3845
3846 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3847 Don't call tui_locator_win_info_ptr.
3848
3849 2019-09-20 Tom Tromey <tom@tromey.com>
3850
3851 * tui/tui-win.c (tui_resize_all): Don't call refresh.
3852
3853 2019-09-20 Tom Tromey <tom@tromey.com>
3854
3855 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3856 height for locator.
3857 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3858 * tui/tui-layout.c (show_source_disasm_command, show_data)
3859 (show_source_or_disasm_and_command): Use 1 as height for locator.
3860
3861 2019-09-20 Tom Tromey <tom@tromey.com>
3862
3863 * tui/tui.c (tui_enable): Update.
3864 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3865 Update.
3866 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3867 Update.
3868 * tui/tui-data.c (win_resized): Now bool.
3869 (tui_win_resized): Return bool.
3870 (tui_set_win_resized_to): Accept a bool.
3871
3872 2019-09-20 Tom Tromey <tom@tromey.com>
3873
3874 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3875 Change type of "refresh_values_only".
3876 * tui/tui-regs.c (tui_data_window::show_register_group): Change
3877 type of "refresh_values_only".
3878
3879 2019-09-20 Tom Tromey <tom@tromey.com>
3880
3881 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3882 std::string.
3883 (tui_disassemble): Add "pos" parameter.
3884 (tui_disasm_window::set_contents): Simplify.
3885
3886 2019-09-20 Tom Tromey <tom@tromey.com>
3887
3888 * tui/tui-winsource.h (struct tui_source_window_base)
3889 <show_source_content>: Now private.
3890 * tui/tui-winsource.c
3891 (tui_source_window_base::show_source_content): Don't handle empty
3892 content case.
3893
3894 2019-09-20 Tom Tromey <tom@tromey.com>
3895
3896 * tui/tui-layout.c (show_source_disasm_command)
3897 (show_source_or_disasm_and_command): Don't call
3898 show_source_content.
3899
3900 2019-09-20 Tom Tromey <tom@tromey.com>
3901
3902 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3903 Declare.
3904 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3905 from tui_make_status_line.
3906 (tui_locator_window::rerender): Update.
3907
3908 2019-09-20 Tom Tromey <tom@tromey.com>
3909
3910 * tui/tui-stack.c (tui_make_status_line): Return std::string.
3911 (tui_locator_window::rerender): Update.
3912
3913 2019-09-20 Tom Tromey <tom@tromey.com>
3914
3915 * tui/tui-winsource.h (struct tui_source_window_base)
3916 <~tui_source_window_base>: Don't declare.
3917 <fullname>: Remove.
3918 * tui/tui-winsource.c (~tui_source_window_base): Remove.
3919 * tui/tui-source.h (struct tui_source_window) <fullname>: New
3920 member.
3921 * tui/tui-source.c (tui_source_window::set_contents): Update.
3922 (tui_source_window::location_matches_p)
3923 (tui_source_window::maybe_update): Update.
3924
3925 2019-09-20 Tom Tromey <tom@tromey.com>
3926
3927 * tui/tui-winsource.h (~tui_source_element): Remove.
3928 (tui_source_element): Update.
3929 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3930 * tui/tui-winsource.c (tui_show_source_line): Update.
3931 * tui/tui-source.c (tui_source_window::set_contents): Update.
3932 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3933
3934 2019-09-20 Tom Tromey <tom@tromey.com>
3935
3936 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3937 declare.
3938 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3939 tui_clear_source_windows_detail.
3940 * tui/tui-winsource.h (struct tui_source_window_base)
3941 <clear_detail>: Don't declare.
3942 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3943 Remove.
3944 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3945
3946 2019-09-20 Tom Tromey <tromey@adacore.com>
3947
3948 PR ada/24919:
3949 * block.c (contained_in): Fix final return value.
3950
3951 2019-09-20 Alan Modra <amodra@gmail.com>
3952
3953 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3954 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3955 (read_indirect_string_from_dwz): Use bfd accessor.
3956 * dwarf2read.h (struct dwz_file <filename>): Likewise.
3957 * machoread.c (macho_symfile_read_all_oso): Likewise.
3958 * solib.c (solib_bfd_open): Likewise.
3959
3960 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3961
3962 * eval.c: Move declaration of overload_resolution to...
3963 * value.h: ...here.
3964
3965 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3966
3967 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3968 * arm-linux-tdep.c: Likewise.
3969 * arm-nbsd-nat.c: Likewise.
3970 * arm-tdep.h: Declare arm_apcs_32.
3971 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3972
3973 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3974
3975 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3976 * dwarf2read.h: Declare dwarf_always_disassemble.
3977
3978 2019-09-19 Tom de Vries <tdevries@suse.de>
3979
3980 PR gdb/25009
3981 * source-cache.c (source_cache::ensure): Catch exception thrown during
3982 construction of the highlighter.
3983
3984 2019-09-18 Alan Modra <amodra@gmail.com>
3985
3986 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3987 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3988 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3989 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3990 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3991 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3992 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3993 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3994 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3995 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3996 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3997 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3998 * solib-spu.c, * solib-svr4.c, * solib-target.c,
3999 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4000 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4001 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4002 * mi/mi-interp.c: Update throughout for bfd section macro and
4003 function changes.
4004 * gcore (gcore_create_callback): Use bfd_set_section_lma.
4005 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4006
4007 2019-09-18 Tom Tromey <tom@tromey.com>
4008
4009 * NEWS: Add entry.
4010 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
4011 call rl_initialize.
4012 (tui_enable): Do not call rl_initialize.
4013
4014 2019-09-18 Christian Groessler <chris@groessler.org>
4015
4016 * alpha-linux-nat.c: Include gdbarch.h.
4017
4018 2019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
4019
4020 * ui-file.c: Include cli/cli-style.h.
4021 (term_cli_styling): Remove cli_styling declaration.
4022
4023 2019-09-18 Alan Modra <amodra@gmail.com>
4024
4025 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4026 to bfd_asymbol_section.
4027
4028 2019-09-18 Alan Modra <amodra@gmail.com>
4029
4030 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4031 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4032 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4033
4034 2019-09-18 Alan Modra <amodra@gmail.com>
4035
4036 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4037 * spu-linux-nat.c (spu_bfd_open): Likewise.
4038
4039 2019-09-18 Christian Biesinger <cbiesinger@google.com>
4040
4041 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4042 to bool to match definition in dwarf2read.c.
4043
4044 2019-09-17 Christian Biesinger <cbiesinger@google.com>
4045
4046 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4047 (print_signatures): Likewise.
4048 (trust_pad_over_xvs): Likewise.
4049 * arch/aarch64-insn.c (aarch64_debug): Likewise.
4050 * arch/aarch64-insn.h (aarch64_debug): Likewise.
4051 * arm-linux-nat.c (arm_apcs_32): Likewise.
4052 * arm-linux-tdep.c (arm_apcs_32): Likewise.
4053 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4054 * arm-tdep.c (arm_debug): Likewise.
4055 (arm_apcs_32): Likewise.
4056 * auto-load.c (debug_auto_load): Likewise.
4057 (auto_load_gdb_scripts): Likewise.
4058 (global_auto_load): Likewise.
4059 (auto_load_local_gdbinit): Likewise.
4060 (auto_load_local_gdbinit_loaded): Likewise.
4061 * auto-load.h (global_auto_load): Likewise.
4062 (auto_load_local_gdbinit): Likewise.
4063 (auto_load_local_gdbinit_loaded): Likewise.
4064 * breakpoint.c (disconnected_dprintf): Likewise.
4065 (breakpoint_proceeded): Likewise.
4066 (automatic_hardware_breakpoints): Likewise.
4067 (always_inserted_mode): Likewise.
4068 (target_exact_watchpoints): Likewise.
4069 (_initialize_breakpoint): Update.
4070 * breakpoint.h (target_exact_watchpoints): Change to bool.
4071 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4072 * cli/cli-cmds.c (trace_commands): Likewise.
4073 * cli/cli-cmds.h (trace_commands): Likewise.
4074 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4075 to bool*.
4076 * cli/cli-logging.c (logging_overwrite): Change to bool.
4077 (logging_redirect): Likewise.
4078 (debug_redirect): Likewise.
4079 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4080 (struct boolean_option_def) <get_var_address_cb_>: Change return type
4081 to bool.
4082 <boolean_option_def>: Update.
4083 (struct flag_option_def): Change default type of Context to bool
4084 from int.
4085 <flag_option_def>: Change return type of var_address_cb_ to bool*.
4086 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4087 (get_setshow_command_value_string): Likewise.
4088 * cli/cli-style.c (cli_styling): Change to bool.
4089 (source_styling): Likewise.
4090 * cli/cli-style.h (source_styling): Likewise.
4091 (cli_styling): Likewise.
4092 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4093 to bool.
4094 * command.h (var_types): Update comment.
4095 (add_setshow_boolean_cmd): Change int* var argument to bool*.
4096 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4097 bool.
4098 (debug_compile_cplus_scopes): Likewise.
4099 * compile/compile-internal.h (compile_debug): Likewise.
4100 * compile/compile.c (compile_debug): Likewise.
4101 (struct compile_options) <raw>: Likewise.
4102 * cp-support.c (catch_demangler_crashes): Likewise.
4103 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4104 (usr_cmd_cris_dwarf2_cfi): Likewise.
4105 * csky-tdep.c (csky_debug): Likewise.
4106 * darwin-nat.c (enable_mach_exceptions): Likewise.
4107 * dcache.c (dcache_enabled_p): Likewise.
4108 * defs.h (info_verbose): Likewise.
4109 * demangle.c (demangle): Likewise.
4110 (asm_demangle): Likewise.
4111 * dwarf-index-cache.c (debug_index_cache): Likewise.
4112 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4113 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4114 * dwarf2read.c (check_physname): Likewise.
4115 (use_deprecated_index_sections): Likewise.
4116 (dwarf_always_disassemble): Likewise.
4117 * eval.c (overload_resolution): Likewise.
4118 * event-top.c (set_editing_cmd_var): Likewise.
4119 (exec_done_display_p): Likewise.
4120 * event-top.h (set_editing_cmd_var): Likewise.
4121 (exec_done_display_p): Likewise.
4122 * exec.c (write_files): Likewise.
4123 * fbsd-nat.c (debug_fbsd_lwp): Likewise
4124 (debug_fbsd_nat): Likewise.
4125 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4126 Likewise.
4127 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4128 <backtrace_past_entry> Likewise.
4129 * gdb-demangle.h (demangle): Likewise.
4130 (asm_demangle): Likewise.
4131 * gdb_bfd.c (bfd_sharing): Likewise.
4132 * gdbcore.h (write_files): Likewise.
4133 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4134 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4135 * gdbthread.h (print_thread_events): Likewise.
4136 * gdbtypes.c (opaque_type_resolution): Likewise.
4137 (strict_type_checking): Likewise.
4138 * gnu-nat.c (gnu_debug_flag): Likewise.
4139 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4140 * guile/scm-param.c (pascm_variable): Add boolval.
4141 (add_setshow_generic): Update.
4142 (pascm_param_value): Update.
4143 (pascm_set_param_value_x): Update.
4144 * hppa-tdep.c (hppa_debug): Change to bool..
4145 * infcall.c (may_call_functions_p): Likewise.
4146 (coerce_float_to_double_p): Likewise.
4147 (unwind_on_signal_p): Likewise.
4148 (unwind_on_terminating_exception_p): Likewise.
4149 * infcmd.c (startup_with_shell): Likewise.
4150 * inferior.c (print_inferior_events): Likewise.
4151 * inferior.h (startup_with_shell): Likewise.
4152 (print_inferior_events): Likewise.
4153 * infrun.c (step_stop_if_no_debug): Likewise.
4154 (detach_fork): Likewise.
4155 (debug_displaced): Likewise.
4156 (disable_randomization): Likewise.
4157 (non_stop): Likewise.
4158 (non_stop_1): Likewise.
4159 (observer_mode): Likewise.
4160 (observer_mode_1): Likewise.
4161 (set_observer_mode): Update.
4162 (sched_multi): Change to bool.
4163 * infrun.h (debug_displaced): Likewise.
4164 (sched_multi): Likewise.
4165 (step_stop_if_no_debug): Likewise.
4166 (non_stop): Likewise.
4167 (disable_randomization): Likewise.
4168 * linux-tdep.c (use_coredump_filter): Likewise.
4169 (dump_excluded_mappings): Likewise.
4170 * linux-thread-db.c (auto_load_thread_db): Likewise.
4171 (check_thread_db_on_load): Likewise.
4172 * main.c (captured_main_1): Update.
4173 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4174 xx2_opt, boolean_opt>: Change to bool.
4175 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4176 * maint.c (maintenance_profile_p): Likewise.
4177 (per_command_time): Likewise.
4178 (per_command_space): Likewise.
4179 (per_command_symtab): Likewise.
4180 * memattr.c (inaccessible_by_default): Likewise.
4181 * mi/mi-main.c (mi_async): Likewise.
4182 (mi_async_1): Likewise.
4183 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4184 * nat/fork-inferior.h (startup_with_shell): Likewise.
4185 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4186 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4187 * nios2-tdep.c (nios2_debug): Likewise.
4188 * or1k-tdep.c (or1k_debug): Likewise.
4189 * parse.c (parser_debug): Likewise.
4190 * parser-defs.h (parser_debug): Likewise.
4191 * printcmd.c (print_symbol_filename): Likewise.
4192 * proc-api.c (procfs_trace): Likewise.
4193 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4194 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4195 (set_parameter_value): Update.
4196 (add_setshow_generic): Update.
4197 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4198 to bool*.
4199 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4200 int*.
4201 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4202 * record-btrace.c (record_btrace_target::store_registers): Update.
4203 * record-full.c (record_full_memory_query): Change to bool.
4204 (record_full_stop_at_limit): Likewise.
4205 * record-full.h (record_full_memory_query): Likewise.
4206 * remote-notif.c (notif_debug): Likewise.
4207 * remote-notif.h (notif_debug): Likewise.
4208 * remote.c (use_range_stepping): Likewise.
4209 (interrupt_on_connect): Likewise.
4210 (remote_break): Likewise.
4211 * ser-tcp.c (tcp_auto_retry): Likewise.
4212 * ser-unix.c (serial_hwflow): Likewise.
4213 * skip.c (debug_skip): Likewise.
4214 * solib-aix.c (solib_aix_debug): Likewise.
4215 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4216 (spu_auto_flush_cache_p): Likewise.
4217 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4218 Likewise.
4219 (struct info_print_options) <quiet>: Likewise.
4220 * symfile-debug.c (debug_symfile): Likewise.
4221 * symfile.c (auto_solib_add): Likewise.
4222 (separate_debug_file_debug): Likewise.
4223 * symfile.h (auto_solib_add): Likewise.
4224 (separate_debug_file_debug): Likewise.
4225 * symtab.c (basenames_may_differ): Likewise.
4226 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4227 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4228 (struct info_types_options) <quiet>: Likewise.
4229 * symtab.h (demangle): Likewise.
4230 (basenames_may_differ): Likewise.
4231 * target-dcache.c (stack_cache_enabled_1): Likewise.
4232 (code_cache_enabled_1): Likewise.
4233 * target.c (trust_readonly): Likewise.
4234 (may_write_registers): Likewise.
4235 (may_write_memory): Likewise.
4236 (may_insert_breakpoints): Likewise.
4237 (may_insert_tracepoints): Likewise.
4238 (may_insert_fast_tracepoints): Likewise.
4239 (may_stop): Likewise.
4240 (auto_connect_native_target): Likewise.
4241 (target_stop_and_wait): Update.
4242 (target_async_permitted): Change to bool.
4243 (target_async_permitted_1): Likewise.
4244 (may_write_registers_1): Likewise.
4245 (may_write_memory_1): Likewise.
4246 (may_insert_breakpoints_1): Likewise.
4247 (may_insert_tracepoints_1): Likewise.
4248 (may_insert_fast_tracepoints_1): Likewise.
4249 (may_stop_1): Likewise.
4250 * target.h (target_async_permitted): Likewise.
4251 (may_write_registers): Likewise.
4252 (may_write_memory): Likewise.
4253 (may_insert_breakpoints): Likewise.
4254 (may_insert_tracepoints): Likewise.
4255 (may_insert_fast_tracepoints): Likewise.
4256 (may_stop): Likewise.
4257 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4258 (make_thread_apply_all_options_def_group): Change argument from int*
4259 to bool*.
4260 (thread_apply_all_command): Update.
4261 (print_thread_events): Change to bool.
4262 * top.c (confirm): Likewise.
4263 (command_editing_p): Likewise.
4264 (history_expansion_p): Likewise.
4265 (write_history_p): Likewise.
4266 (info_verbose): Likewise.
4267 * top.h (confirm): Likewise.
4268 (history_expansion_p): Likewise.
4269 * tracepoint.c (disconnected_tracing): Likewise.
4270 (circular_trace_buffer): Likewise.
4271 * typeprint.c (print_methods): Likewise.
4272 (print_typedefs): Likewise.
4273 * utils.c (debug_timestamp): Likewise.
4274 (sevenbit_strings): Likewise.
4275 (pagination_enabled): Likewise.
4276 * utils.h (sevenbit_strings): Likewise.
4277 (pagination_enabled): Likewise.
4278 * valops.c (overload_resolution): Likewise.
4279 * valprint.h (struct value_print_options) <prettyformat_arrays,
4280 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4281 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4282 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4283 Likewise.
4284 * windows-nat.c (new_console): Likewise.
4285 (cygwin_exceptions): Likewise.
4286 (new_group): Likewise.
4287 (debug_exec): Likewise.
4288 (debug_events): Likewise.
4289 (debug_memory): Likewise.
4290 (debug_exceptions): Likewise.
4291 (useshell): Likewise.
4292 * windows-tdep.c (maint_display_all_tib): Likewise.
4293 * xml-support.c (debug_xml): Likewise.
4294
4295 2019-09-17 Mike Gulick <mgulick@mathworks.com>
4296
4297 * source.c (prepare_path_for_appending): New function.
4298 (openp): Make use of new function.
4299 (find_and_open_source): Search for the compilation directory and
4300 source file as a relative path beneath the directory search path.
4301
4302 2019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4303
4304 * source-cache.c (source_cache::get_line_charpos): Catch
4305 exceptions and return false, this matches the behaviour documented
4306 in the header file.
4307
4308 2019-09-17 Joel Brobecker <brobecker@adacore.com>
4309
4310 * ada-tasks.c (info_task): Remove quoting of the task's name.
4311
4312 2019-09-16 Christian Biesinger <cbiesinger@google.com>
4313
4314 * symfile.c (auto_solib_add): Replace comment with a reference
4315 to the header file.
4316
4317 2019-09-14 Christian Biesinger <cbiesinger@google.com>
4318
4319 * NEWS: Mention that gdb can now be compiled with Python 3
4320 on Windows.
4321
4322 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4323
4324 * maint.c (maint_print_section_data::maint_print_section_data):
4325 Force use of 'float log10 (float)' by casting the argument to
4326 float.
4327
4328 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4329
4330 * maint.c: Add 'cmath' include.
4331 (struct maint_print_section_data): New structure.
4332 (print_section_index): New function.
4333 (print_bfd_section_info): Add header comment, small whitespace
4334 cleanup, and update to call new print_section_index function.
4335 (print_objfile_section_info): Likewise.
4336 (maint_obj_section_from_bfd_section): New function.
4337 (print_bfd_section_info_maybe_relocated): New function.
4338 (maintenance_info_sections): Add header comment, always use
4339 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4340
4341 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4342
4343 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4344 inner scope, add check that the objfile has psymtabs before
4345 checking psymtabs_addrmap.
4346 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4347
4348 2019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4349
4350 * NEWS: Announce that Ada task names are now shown at more places,
4351 and between quotes (except in info task output).
4352 * gdb/ada-tasks.c (task_to_str): New function.
4353 (display_current_task_id): Call task_to_str.
4354 (task_command_1): Likewise.
4355 (print_ada_task_info): In non-mi mode, Properly align headers and data
4356 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4357
4358 2019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4359
4360 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4361 prstatus.pr_lwp.pr_info instead of making it up.
4362
4363 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4364
4365 * auto-load.c (auto_load_expand_dir_vars): Update.
4366 * defs.h (gdb_datadir): Change to std::string.
4367 (python_libdir): Likewise.
4368 (relocate_gdb_directory): Change return type to std::string.
4369 * guile/guile.c (gdbscm_data_directory): Update.
4370 (initialize_scheme_side): Update.
4371 * jit.c (jit_reader_dir): Change to std::string.
4372 (jit_reader_load_command): Update.
4373 * main.c (gdb_datadir): Change to std::string.
4374 (python_libdir): Likewise.
4375 (set_gdb_data_directory): Update.
4376 (relocate_path): Change to return std::string.
4377 (relocate_gdb_directory): Change to return std::string.
4378 (relocate_gdbinit_path_maybe_in_datadir): Update.
4379 (captured_main_1): Update.
4380 * python/python.c (do_start_initialization): Update.
4381 * top.c (show_gdb_datadir): Update.
4382 * xml-syscall.c (xml_init_syscalls_info): Update.
4383 (init_syscalls_info): Update.
4384
4385 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4386
4387 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4388 out of get_init_files.
4389 (get_init_files): Update.
4390
4391 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4392
4393 * main.c (get_init_files): Change to use std::string.
4394 (captured_main_1): Update.
4395 (print_gdb_help): Update.
4396
4397 2019-09-11 Ali Tamur <tamur@google.com>
4398
4399 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4400 implementation.
4401
4402 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4403
4404 * dbxread.c (read_dbx_symtab): Update.
4405 * dwarf2read.c (load_partial_dies): Update.
4406 * mdebugread.c (parse_partial_symbols): Update.
4407 (handle_psymbol_enumerators): Update.
4408 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4409 * psymtab.c (add_psymbol_to_bcache): Likewise.
4410 (add_psymbol_to_list): Likewise.
4411 * symtab.c (symbol_set_names): Likewise.
4412 * symtab.h (symbol_set_names): Likewise.
4413 * xcoffread.c (scan_xcoff_symtab): Update.
4414
4415 2019-09-11 Tom Tromey <tom@tromey.com>
4416
4417 * symfile-mem.c (symbol_file_add_from_memory): Use
4418 bfd_set_filename.
4419 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4420 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4421
4422 2019-09-10 Tom Tromey <tromey@adacore.com>
4423
4424 * dwarf-index-write.c (write_psymbols): Extend error message.
4425 (debug_names::insert): Add Ada code.
4426 (debug_names::write_psymbols): Remove Ada check.
4427 (debug_names) <m_string_obstack>: New member.
4428 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4429 (gdb_index_symbol_name_matcher::matches): Remove.
4430 (mapped_index_base::find_name_components_bounds): Add "lang"
4431 parameter.
4432 (mapped_index_base::build_name_components): Also split names
4433 according to Ada syntax.
4434 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4435 type of "match_callback".
4436 (check_match, check_find_bounds_finds)
4437 (dw2_expand_symtabs_matching): Update.
4438 (dw2_debug_names_iterator): Add new constructor.
4439 (dw2_debug_names_map_matching_symbols): New function.
4440 (dw2_debug_names_expand_symtabs_matching): Update.
4441 (dwarf2_debug_names_functions): Use
4442 dw2_debug_names_map_matching_symbols.
4443
4444 2019-09-10 Tom Tromey <tromey@adacore.com>
4445
4446 * dwarf2read.c (dw2_get_file_names_reader): Add the
4447 CU's file name to the results.
4448
4449 2019-09-10 Tom Tromey <tromey@adacore.com>
4450
4451 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4452 map_matching_symbols. Update.
4453 * dwarf2read.c (dw2_map_matching_symbols): Update.
4454 * psymtab.c (match_partial_symbol): Change type; update.
4455 (psym_map_matching_symbols): Likewise.
4456 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4457 type; update.
4458 * symfile.h (struct quick_symbol_functions)
4459 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4460 Remove "match".
4461
4462 2019-09-10 Tom Tromey <tromey@adacore.com>
4463
4464 * psymtab.c (map_block): Remove.
4465 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4466 * symtab.c (iterate_over_symbols_terminated): New function.
4467 * symtab.c (iterate_over_symbols_terminated): Declare.
4468
4469 2019-09-10 Tom Tromey <tromey@adacore.com>
4470
4471 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4472 * language.h (struct language_defn) <la_iterate_over_symbols>:
4473 Return bool.
4474 * symtab.c (iterate_over_symbols): Return bool.
4475 * symtab.h (iterate_over_symbols): Return bool.
4476
4477 2019-09-10 Tom Tromey <tromey@adacore.com>
4478
4479 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4480 (add_nonlocal_symbols): Update.
4481 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4482 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4483 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4484 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4485 Change type of "callback". Remove "data".
4486
4487
4488 2019-09-09 Ali Tamur <tamur@google.com>
4489
4490 * dwarf2read.c (comp_unit_head): Update comment.
4491 (dwarf2_dwo_name): New function declaration.
4492 (dwarf_unit_type_name): New function declaration.
4493 (read_comp_unit_head): Add support for new compilation units,
4494 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4495 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4496 (currently named as "signature") in their header. Also clarify error
4497 messages.
4498 (lookup_dwo_id): New function. Returns the dwo id of the given
4499 compile unit.
4500 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4501 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4502 functions.
4503 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4504 (dwarf2_dwo_name): Get the dwo name if present.
4505 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4506 purposes.
4507
4508 2019-09-09 Tom Tromey <tom@tromey.com>
4509
4510 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4511
4512 2019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4513
4514 * python/python.c (do_start_initialization): Make progname_copy static,
4515 to avoid a leak report.
4516
4517 2019-09-08 Tom Tromey <tom@tromey.com>
4518
4519 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4520
4521 2019-09-07 Simon Marchi <simon.marchi@efficios.com>
4522
4523 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4524 Change type to gdb::optional<block_enum>.
4525 (dw2_symtab_iter_init): Change block_index parameter type
4526 to gdb::optional<block_enum>.
4527 (dw2_lookup_symbol): Change block_index parameter
4528 type to block_enum.c
4529 (dw2_debug_names_lookup_symbol): Likewise.
4530 * psymtab.c (psym_lookup_symbol): Likewise.
4531 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4532 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4533 Likewise.
4534
4535 2019-09-06 Christian Biesinger <cbiesinger@google.com>
4536
4537 * defs.h (relocate_gdb_directory): Change int to bool in
4538 signature and rename flag to relocatable.
4539 * main.c (relocate_path): Likewise.
4540 (relocate_gdb_directory): Likewise.
4541
4542 2019-09-06 Alan Modra <amodra@gmail.com>
4543
4544 * coffread.c (coff_symfile_read): Constify filename variable.
4545 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4546 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4547 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4548 * solib.c (reload_shared_libraries_1): Likewise.
4549 * symfile.c (reread_symbols): Likewise.
4550 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4551 * solib-darwin.c (darwin_bfd_open): Likewise.
4552 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4553
4554 2019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4555
4556 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4557 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4558
4559 2019-09-03 Tom Tromey <tromey@adacore.com>
4560
4561 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4562 types.
4563 (has_negatives): Unbias a range type bound.
4564 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4565 * gdbtypes.c (operator==): Handle new field.
4566 (create_range_type): Add "bias" parameter.
4567 (create_static_range_type, resolve_dynamic_range): Update.
4568 * gdbtypes.h (struct range_bounds) <bias>: New member.
4569 (create_range_type): Add bias parameter.
4570 * printcmd.c (print_scalar_formatted): Unbias range types.
4571 * value.c (unpack_long): Unbias range types.
4572 (pack_long): Bias range types.
4573
4574 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4575
4576 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4577 probe arguments.
4578
4579 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4580
4581 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4582 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4583 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4584 (compile_probe_arg): Likewise.
4585 * probe.h (get_argument_count): Likewise.
4586 * solib-svr4.c (solib_event_probe_action): Likewise.
4587 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4588
4589 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4590
4591 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4592 code to here...
4593 (svr4_create_solib_event_breakpoints): ...from here.
4594
4595 2019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4596
4597 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4598 suffix from warning message.
4599
4600 2019-08-30 Tom Tromey <tom@tromey.com>
4601
4602 * tui/tui-winsource.h (struct tui_source_window_base)
4603 <refresh_all>: Don't declare.
4604 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4605 Remove.
4606 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4607 tui_show_locator_content.
4608 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4609 declare.
4610 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4611 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4612 declare.
4613
4614 2019-08-30 Tom Tromey <tom@tromey.com>
4615
4616 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4617
4618 2019-08-30 Tom Tromey <tom@tromey.com>
4619
4620 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4621 Remove unnecessary forward declarations.
4622
4623 2019-08-30 Tom Tromey <tom@tromey.com>
4624
4625 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4626 rerender.
4627 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4628 tui_show_locator_content.
4629
4630 2019-08-30 Tom Tromey <tom@tromey.com>
4631
4632 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4633 (tui_locator_window::rerender): Rewrite using body of previous
4634 tui_show_locator_content.
4635
4636 2019-08-30 Tom Tromey <tom@tromey.com>
4637
4638 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4639 set_locator_fullname>: New methods.
4640 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4641 Rename from tui_set_locator_fullname.
4642 (tui_locator_window::set_locator_info): Rename from
4643 tui_set_locator_info. Return bool.
4644 (tui_update_locator_fullname, tui_show_frame_info): Update.
4645
4646 2019-08-30 Tom Tromey <tom@tromey.com>
4647
4648 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4649
4650 2019-08-30 Tom Tromey <tom@tromey.com>
4651
4652 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4653 call touchwin.
4654
4655 2019-08-30 Tom Tromey <tom@tromey.com>
4656
4657 * tui/tui-wingeneral.c (box_win): Assume win_info and
4658 win_info->handle cannot be NULL.
4659
4660 2019-08-30 Tom Tromey <tom@tromey.com>
4661
4662 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4663 refresh_window>: Declare.
4664 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4665 resize.
4666 (tui_data_item_window::rerender): Rename from
4667 tui_display_register.
4668 (tui_data_item_window::refresh_window): New method.
4669 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4670 no-op.
4671
4672 2019-08-30 Tom Tromey <tom@tromey.com>
4673
4674 * tui/tui-regs.h (struct tui_data_window) <regs_content,
4675 regs_column_count, current_group>: Move later. Now private.
4676 <get_current_group>: New method.
4677 * tui/tui-regs.c (tui_reg_command): Update.
4678 * tui/tui-layout.c (tui_set_layout): Update.
4679
4680 2019-08-30 Tom Tromey <tom@tromey.com>
4681
4682 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4683 (tui_data_window::rerender): Don't call
4684 check_and_display_highlight_if_needed.
4685 (tui_data_window::refresh_all): Remove call to
4686 erase_data_content.
4687
4688 2019-08-30 Tom Tromey <tom@tromey.com>
4689
4690 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4691 (tui_data_window::display_registers_from)
4692 (tui_data_window::display_reg_element_at_line)
4693 (tui_data_window::display_registers_from_line): Remove checks of
4694 "empty".
4695
4696 2019-08-30 Tom Tromey <tom@tromey.com>
4697
4698 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4699 Don't declare.
4700 * tui/tui-regs.c (tui_data_window::show_registers): Call
4701 rerender.
4702 (tui_data_window::rerender): Rename from display_all_data.
4703 (tui_data_window::rerender): Remove old implementation.
4704
4705 2019-08-30 Tom Tromey <tom@tromey.com>
4706
4707 * tui/tui-regs.c (tui_data_window::display_all_data): Change
4708 text.
4709 * tui/tui-data.h (NO_DATA_STRING): Remove define.
4710
4711 2019-08-29 Bernhard Wodok <barto@gmx.net>
4712 Sergio Durigan Junior <sergiodj@redhat.com>
4713
4714 PR win32/24284
4715 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4716
4717 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4718
4719 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4720 when searching for types.
4721
4722 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4723
4724 * f-lang.c (f_language_defn): Use f_print_typedef.
4725 * f-lang.h (f_print_typedef): Declare.
4726 * f-typeprint.c (f_print_typedef): Define.
4727
4728 2019-08-27 Christian Biesinger <cbiesinger@google.com>
4729
4730 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4731
4732 2019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
4733
4734 * cli/cli-utils.c (info_print_options_defs): Delete.
4735 (make_info_print_options_def_group): Delete.
4736 (extract_info_print_options): Delete.
4737 (info_print_command_completer): Delete.
4738 (info_print_args_help): Add extra parameter, and optionally
4739 include text about -n flag.
4740 * cli/cli-utils.h (struct info_print_options): Delete.
4741 (extract_info_print_options): Delete declaration.
4742 (info_print_command_completer): Delete declaration.
4743 (info_print_args_help): Add extra parameter, extend header
4744 comment.
4745 * python/python.c (gdbpy_rbreak): Pass additional parameter to
4746 search_symbols.
4747 * stack.c (struct info_print_options): New type.
4748 (info_print_options_defs): New file scoped variable.
4749 (make_info_print_options_def_group): New static function.
4750 (info_print_command_completer): New static function.
4751 (info_locals_command): Update to use new local functions.
4752 (info_args_command): Likewise.
4753 (_initialize_stack): Add extra parameter to calls to
4754 info_print_args_help.
4755 * symtab.c (search_symbols): Add extra parameter, use this to
4756 possibly excluse non-debug symbols.
4757 (symtab_symbol_info): Add extra parameter, which is passed on to
4758 search_symbols.
4759 (struct info_print_options): New type.
4760 (info_print_options_defs): New file scoped variable.
4761 (make_info_print_options_def_group): New static function.
4762 (info_print_command_completer): New static function.
4763 (info_variables_command): Update to use local functions, and pass
4764 extra parameter through to symtab_symbol_info.
4765 (info_functions_command): Likewise.
4766 (info_types_command): Pass additional argument through to
4767 symtab_symbol_info.
4768 (rbreak_command): Pass extra argument to search_symbols.
4769 (_initialize_symtab): Add extra arguments for calls to
4770 info_print_args_help, and update help text for 'info variables',
4771 'whereis', and 'info functions' commands.
4772 * symtab.h (search_symbols): Add extra argument to declaration.
4773 * NEWS: Mention new flags.
4774
4775 2019-08-26 Christian Biesinger <cbiesinger@google.com>
4776
4777 * symtab.c (lookup_static_symbol): Call the new function (and move
4778 it down to be next to lookup_global_symbol).
4779 (struct global_sym_lookup_data): Add block_enum member and rename to...
4780 (struct global_or_static_sym_lookup_data): ...this.
4781 (lookup_symbol_global_iterator_cb): Pass block_index instead of
4782 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4783 (lookup_symbol_global_or_static_iterator_cb): ...this.
4784 (lookup_global_or_static_symbol): New function.
4785 (lookup_global_symbol): Call new function.
4786
4787 2019-08-26 Tom de Vries <tdevries@suse.de>
4788
4789 PR c++/24852
4790 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4791 when pc_probe.prob == NULL.
4792
4793 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
4794
4795 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4796 variable symbol_linkage to symbol_linkage_.
4797
4798 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
4799
4800 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4801 represent whether the symbol is static, dynamic, or we don't
4802 know.
4803
4804 2019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
4805
4806 * gdb/rx-tdep.c (rx_register_names): New.
4807 (rx_register_name): Delete.
4808 (rx_psw_type): Delete.
4809 (rx_fpsw_type): Delete.
4810 (rx_register_type): Delete.
4811 (rx_gdbarch_init): Convert target-descriptions.
4812 (_initialize_rx_tdep): Add initialize_tdesc_rx.
4813 * gdb/features/Makefile: Add rx.xml.
4814 * gdb/features/rx.xml: New.
4815 * gdb/features/rx.c: Generated.
4816 * gdb/NEWS: Mention target description support.
4817
4818 2019-08-22 Christian Biesinger <cbiesinger@google.com>
4819
4820 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4821 *slot_ptr.
4822
4823 2019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
4824
4825 * configure.ac: Don't check for 'dlfcn.h' (moved to
4826 gdbsupport/common.m4).
4827 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4828 'gdbsupport/'.
4829 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4830 * compile/compile-c-support.c: Include
4831 'gdbsupport/gdb-dlfcn.h'.
4832 * gdbsupport/common.m4: Check for 'dlfcn.h'.
4833 * gdb-dlfcn.c: Move to...
4834 * gdbsupport/gdb-dlfcn.c: ... here.
4835 * gdb-dlfcn.h: Move to...
4836 * gdbsupport/gdb-dlfcn.h: ... here.
4837
4838 2019-08-23 Sandra Loosemore <sandra@codesourcery.com>
4839
4840 * nios2-tdep.c (struct reg_value): Improve comments. Make
4841 the offset field signed.
4842
4843 2019-08-22 Christian Biesinger <cbiesinger@google.com>
4844
4845 * python/lib/gdb/__init__.py (_execute_file): New function.
4846 * python/python.c (python_run_simple_file): Call gdb._execute_file
4847 on Windows.
4848
4849 2019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
4850
4851 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4852 all uses as this was never set to anything but a zero value.
4853
4854 2019-08-21 Bogdan Harjoc <harjoc@gmail.com>
4855
4856 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4857
4858 2019-08-21 Christian Biesinger <cbiesinger@google.com>
4859
4860 * tui/tui-data.h (tui_gen_win_info): Add an =default
4861 move constructor, required by some GCC versions.
4862
4863 2019-08-21 Jinke Fan <fanjinke51@yeah.net>
4864
4865 * go32-nat.c (go32_sysinfo): Add hygon_p.
4866
4867 2019-08-20 Tom Tromey <tom@tromey.com>
4868
4869 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4870 line_from_reg_element_no, first_reg_element_no_inline,
4871 display_all_data, delete_data_content_windows,
4872 erase_data_content>: Now private.
4873
4874 2019-08-20 Tom Tromey <tom@tromey.com>
4875
4876 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4877 (tui_unhighlight_win, tui_highlight_win)
4878 (tui_win_info::make_window): Update.
4879 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4880
4881 2019-08-20 Tom Tromey <tom@tromey.com>
4882
4883 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4884 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4885 (MAX_PID_WIDTH): Move to tui-stack.c.
4886 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4887 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4888 (MAX_PID_WIDTH): Move from tui-data.h.
4889
4890 2019-08-20 Tom Tromey <tom@tromey.com>
4891
4892 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4893 * tui/tui-wingeneral.c (box_win): Change type of win_info.
4894 (box_win): Update.
4895 (tui_gen_win_info::make_window): Rename from tui_make_window.
4896 (tui_win_info::make_window): New method.
4897 (tui_gen_win_info::make_visible): Update.
4898 * tui/tui-source.c (tui_source_window::set_contents): Update.
4899 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4900 (tui_data_window::display_registers_from): Update.
4901 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4902 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4903 Declare.
4904 <can_box>: Remove.
4905 <title>: Remove.
4906 (struct tui_win_info) <make_window>: Declare.
4907 <can_box>: Now virtual.
4908 <title>: New member.
4909 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4910 * tui/tui-command.c (tui_cmd_window::resize): Update.
4911
4912 2019-08-20 Tom Tromey <tom@tromey.com>
4913
4914 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4915 * tui/tui-regs.c (tui_data_window::show_registers): Update.
4916 (tui_data_window::check_register_values): Update.
4917
4918 2019-08-20 Tom Tromey <tom@tromey.com>
4919
4920 * tui/tui-regs.h (struct tui_data_window): Use
4921 DISABLE_COPY_AND_ASSIGN.
4922 <regs_content>: Change type, removing unique_ptr.
4923 <tui_data_window>: Add move constructor.
4924 * tui/tui-regs.c (tui_data_window::show_registers)
4925 (tui_data_window::show_register_group)
4926 (tui_data_window::display_registers_from)
4927 (tui_data_window::display_registers_from)
4928 (tui_data_window::first_data_item_displayed)
4929 (tui_data_window::delete_data_content_windows)
4930 (tui_data_window::rerender, tui_data_window::refresh_window)
4931 (tui_data_window::check_register_values): Update.
4932
4933 2019-08-20 Tom Tromey <tom@tromey.com>
4934
4935 * tui/tui-regs.h (struct tui_data_window) <show_registers,
4936 show_register_group>: Declare.
4937 (tui_show_register_group): Don't declare.
4938 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4939 tui_show_registers.
4940 (tui_data_window::show_register_group): Rename from
4941 tui_show_register_group.
4942 (tui_data_window::check_register_values, tui_reg_command):
4943 Update.
4944 * tui/tui-layout.c (tui_set_layout): Update.
4945
4946 2019-08-20 Tom Tromey <tom@tromey.com>
4947
4948 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4949 Declare.
4950 (tui_check_register_values): Don't declare.
4951 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4952 from tui_check_register_values.
4953 * tui/tui-hooks.c (tui_register_changed): Update.
4954
4955 2019-08-20 Tom Tromey <tom@tromey.com>
4956
4957 * tui/tui-regs.c (tui_reg_layout): Move later.
4958 (tui_show_registers): Don't enable TUI mode or change layout.
4959
4960 2019-08-20 Tom Tromey <tom@tromey.com>
4961
4962 * tui/tui-regs.h (struct tui_data_item_window)
4963 <~tui_data_item_window>: Remove.
4964 <content>: Now a unique_xmalloc_ptr.
4965 * tui/tui-regs.c (tui_register_format): Return a
4966 unique_xmalloc_ptr.
4967 (tui_get_register): Update.
4968 (~tui_data_item_window): Remove.
4969 (tui_data_window::display_registers_from, tui_display_register):
4970 Update.
4971 * tui/tui-io.h (tui_expand_tabs): Update.
4972 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4973 Remove "col" parameter.
4974
4975 2019-08-20 Tom Tromey <tom@tromey.com>
4976
4977 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4978 field.
4979 * tui/tui-regs.c (~tui_data_item_window): Update.
4980
4981 2019-08-20 Tom Tromey <tom@tromey.com>
4982
4983 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4984 earlier.
4985
4986 2019-08-20 Tom Tromey <tom@tromey.com>
4987
4988 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4989
4990 2019-08-20 Tom Tromey <tom@tromey.com>
4991
4992 * tui/tui-source.h (struct tui_source_window): Update.
4993 * tui/tui-regs.c (tui_show_registers): Update.
4994 * tui/tui-disasm.h (struct tui_disasm_window): Update.
4995 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4996 (NO_REGS_STRING): Remove defines.
4997
4998 2019-08-20 Conrad Meyer <cem@FreeBSD.org>
4999
5000 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5001 unnecessary thread walk if remote doesn't support the packet.
5002
5003 2019-08-19 Tom Tromey <tromey@adacore.com>
5004
5005 * python/py-value.c (value_has_field): Fix indentation.
5006
5007 2019-08-19 Tom Tromey <tromey@adacore.com>
5008
5009 * printcmd.c (do_one_display, info_display_command): Update.
5010 * block.h (contained_in): Return bool. Add allow_nested
5011 parameter.
5012 * block.c (contained_in): Return bool. Add allow_nested
5013 parameter.
5014
5015 2019-08-19 Tom Tromey <tom@tromey.com>
5016
5017 * configure: Rebuild.
5018 * configure.ac: Disallow the combination of -static-libstdc++ and
5019 source highlight.
5020 * source-cache.c (get_language_name): Handle rust.
5021 (source_cache::get_source_lines): Ignore highlighting exceptions.
5022
5023 2019-08-16 Tom Tromey <tom@tromey.com>
5024
5025 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5026 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5027 (struct tui_source_window_base) <make_visible, refresh_window,
5028 resize>: Remove methods.
5029 <execution_info>: Remove field.
5030 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5031 (tui_show_source_line, tui_source_window_base)
5032 (~tui_source_window_base): Update.
5033 (tui_source_window_base::resize)
5034 (tui_source_window_base::make_visible)
5035 (tui_source_window_base::refresh_window): Remove.
5036 (tui_source_window_base::update_exec_info): Update.
5037 * tui/tui-source.c (tui_source_window::set_contents): Update.
5038 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5039
5040 2019-08-16 Tom Tromey <tom@tromey.com>
5041
5042 * tui/tui-hooks.c (tui_remove_hooks): Don't set
5043 deprecated_query_hook.
5044
5045 2019-08-16 Tom Tromey <tom@tromey.com>
5046
5047 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5048 (tui_update_source_windows_with_line): Update.
5049 * tui/tui-source.h (struct tui_source_window)
5050 <show_symtab_source>: Declare.
5051 (tui_show_symtab_source): Don't declare.
5052 * tui/tui-source.c (tui_show_symtab_source): Rename from
5053 tui_show_symtab_source.
5054
5055 2019-08-16 Tom Tromey <tom@tromey.com>
5056
5057 * tui/tui-winsource.h (struct tui_source_window_base)
5058 <set_contents>: Declare.
5059 * tui/tui-winsource.c
5060 (tui_source_window_base::update_source_window_as_is): Update.
5061 * tui/tui-source.h (struct tui_source_window) <set_contents>:
5062 Declare.
5063 (tui_set_source_content): Don't declare.
5064 * tui/tui-source.c (tui_source_window::set_contents): Rename from
5065 tui_set_source_content.
5066 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5067 Declare.
5068 (tui_set_disassem_content): Don't declare.
5069 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5070 tui_set_disassem_content.
5071
5072 2019-08-16 Tom Tromey <tom@tromey.com>
5073
5074 * tui/tui-winsource.h (struct tui_source_window_base)
5075 <update_breakpoint_info>: Declare.
5076 (tui_update_breakpoint_info): Don't declare.
5077 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5078 (tui_update_all_breakpoint_info): Update.
5079 (tui_source_window_base::update_breakpoint_info): Rename from
5080 tui_update_breakpoint_info.
5081 (tui_source_window_base::update_exec_info): Update.
5082
5083 2019-08-16 Tom Tromey <tom@tromey.com>
5084
5085 * tui/tui-winsource.h (struct tui_source_window_base)
5086 <update_source_window>: Declare.
5087 (tui_update_source_window): Don't declare.
5088 * tui/tui-winsource.c
5089 (tui_source_window_base::update_source_window): Rename from
5090 tui_update_source_window.
5091 (tui_source_window_base::rerender): Update.
5092 * tui/tui-source.c (tui_source_window::maybe_update): Update.
5093 * tui/tui-disasm.c (tui_show_disassem)
5094 (tui_show_disassem_and_update_source)
5095 (tui_disasm_window::maybe_update): Update.
5096
5097 2019-08-16 Tom Tromey <tom@tromey.com>
5098
5099 * tui/tui-winsource.h (struct tui_source_window_base)
5100 <update_source_window_as_is>: Declare.
5101 (tui_update_source_window_as_is): Don't declare.
5102 * tui/tui-winsource.c (tui_update_source_window): Update
5103 (tui_source_window_base::update_source_window_as_is): Rename from
5104 tui_update_source_window_as_is.
5105 (tui_source_window_base::refill): Update.
5106 * tui/tui-source.c (tui_show_symtab_source): Update.
5107 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5108 Update.
5109
5110 2019-08-16 Tom Tromey <tom@tromey.com>
5111
5112 * tui/tui-winsource.h (tui_update_source_window)
5113 (tui_update_source_window_as_is): Remove "noerror" parameter.
5114 * tui/tui-winsource.c (tui_update_source_window)
5115 (tui_update_source_window_as_is): Remove "noerror" parameter.
5116 (tui_update_source_windows_with_addr)
5117 (tui_update_source_windows_with_line)
5118 (tui_source_window_base::rerender)
5119 (tui_source_window_base::refill): Update.
5120 * tui/tui-source.h (tui_set_source_content)
5121 (tui_show_symtab_source): Remove "noerror" parameter.
5122 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5123 parameter.
5124 (tui_show_symtab_source): Likewise.
5125 (tui_source_window::maybe_update): Update.
5126 * tui/tui-disasm.c (tui_show_disassem)
5127 (tui_show_disassem_and_update_source)
5128 (tui_disasm_window::do_scroll_vertical)
5129 (tui_disasm_window::maybe_update): Update.
5130
5131 2019-08-16 Tom Tromey <tom@tromey.com>
5132
5133 * tui/tui.c (tui_is_window_visible): Update.
5134 * tui/tui-wingeneral.c (tui_make_window)
5135 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5136 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5137 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5138 (tui_set_win_height_command, parse_scrolling_args): Update.
5139 * tui/tui-source.c (tui_source_window::style_changed): Update.
5140 * tui/tui-regs.c (tui_show_registers)
5141 (tui_data_window::first_data_item_displayed)
5142 (tui_data_window::delete_data_content_windows)
5143 (tui_check_register_values, tui_reg_command): Update.
5144 * tui/tui-disasm.c (tui_show_disassem): Update.
5145 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5146 method.
5147 <is_visible>: Remove field.
5148 * tui/tui-data.c (tui_next_win, tui_prev_win)
5149 (tui_delete_invisible_windows): Update.
5150
5151 2019-08-16 Tom Tromey <tom@tromey.com>
5152
5153 * tui/tui-winsource.h (struct tui_source_window_base)
5154 <m_has_locator>: Remove.
5155 * tui/tui-layout.c (show_source_disasm_command, show_data)
5156 (show_source_or_disasm_and_command): Update.
5157
5158 2019-08-16 Alan Hayward <alan.hayward@arm.com>
5159
5160 * NEWS (Other MI changes): New subsection.
5161 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5162 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5163 * arch-utils.c (default_get_pc_address_flags): New function.
5164 * arch-utils.h (default_get_pc_address_flags): New declaration.
5165 * gdbarch.sh: Add get_pc_address_flags.
5166 * gdbarch.c: Regenerate.
5167 * gdbarch.h: Likewise.
5168 * stack.c (print_pc): New function.
5169 (print_frame_info) (print_frame): Call print_pc.
5170
5171 2019-08-16 Tom de Vries <tdevries@suse.de>
5172
5173 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5174 print_objfile_section_info.
5175
5176 2019-08-15 Tom Tromey <tom@tromey.com>
5177
5178 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5179 calling update_cmdwin_start_line.
5180 * tui/tui-winsource.h (struct tui_source_window_base)
5181 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5182 <rerender>: Declare.
5183 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5184 Call rerender.
5185 (tui_source_window_base::set_new_height): Remove.
5186 (tui_source_window_base::rerender): Rename from
5187 do_make_visible_with_new_height.
5188 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5189 resize method.
5190 (tui_win_info::make_invisible_and_set_new_height)
5191 (tui_win_info::make_visible_with_new_height): Remove.
5192 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5193 Declare.
5194 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5195 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5196 do_make_visible_with_new_height>: Don't declare.
5197 <rerender>: Declare.
5198 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5199 set_new_height.
5200 (tui_data_window::do_make_visible_with_new_height): Remove.
5201 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5202 call tui_show_locator_content.
5203 (tui_gen_win_info::resize): Call rerender.
5204 (show_source_or_disasm_and_command): Don't call
5205 tui_show_locator_content.
5206 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5207 method.
5208 (struct tui_win_info) <rerender>: Declare.
5209 <set_new_height, make_invisible_and_set_new_height,
5210 make_visible_with_new_height>: Don't declare.
5211 * tui/tui-data.c (tui_win_list::rerender): New method.
5212 * tui/tui-command.h (struct tui_cmd_window)
5213 <do_make_visible_with_new_height>: Don't declare.
5214 * tui/tui-command.c
5215 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5216
5217 2019-08-15 Tom Tromey <tromey@adacore.com>
5218
5219 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5220 * ada-lang.c (ada_enum_name): Likewise.
5221
5222 2019-08-15 Christian Biesinger <cbiesinger@google.com>
5223
5224 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5225 leading underscore.
5226 (GdbOutputErrorFile): Likewise.
5227 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5228 accordingly.
5229 (execute_unwinders): Rename to have a leading underscore.
5230 (auto_load_packages): Likewise.
5231 (global scope): Adjust call to auto_load_packages accordingly.
5232 (GdbSetPythonDirectory): Likewise.
5233 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5234 instead of execute_unwinders.
5235
5236 2019-08-15 Tom Tromey <tom@tromey.com>
5237
5238 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5239 (show_data): Don't change window visibility.
5240 (tui_gen_win_info::resize): Remove special case for command
5241 window. Use wresize, when available.
5242 (show_source_or_disasm_and_command): Don't change window
5243 visibility.
5244 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5245 <make_visible>: New method.
5246 * tui/tui-command.c (tui_cmd_window::resize): New method.
5247
5248 2019-08-15 Tom Tromey <tom@tromey.com>
5249
5250 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5251 (struct tui_source_windows): New.
5252 * tui/tui-winsource.c (tui_display_main): Update.
5253 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5254 (new_height_ok, parse_scrolling_args): Update.
5255 * tui/tui-layout.c (show_layout, show_data): Update.
5256 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5257 (tui_add_to_source_windows): Don't declare.
5258 * tui/tui-data.c (source_windows, tui_source_windows)
5259 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5260
5261 2019-08-15 Tom Tromey <tom@tromey.com>
5262
5263 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5264 Rename from reset.
5265 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5266 * tui/tui-layout.c (show_source_disasm_command, show_data):
5267 Update.
5268 (tui_gen_win_info::resize): Rename.
5269 (show_source_or_disasm_and_command): Update.
5270 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5271 reset.
5272
5273 2019-08-15 Tom Tromey <tom@tromey.com>
5274
5275 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5276 * tui/tui-interp.c (tui_interp::init): Don't call
5277 tui_initialize_static_data.
5278 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5279
5280 2019-08-15 Tom Tromey <tom@tromey.com>
5281
5282 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5283 examine tui_win_list.
5284
5285 2019-08-15 Tom Tromey <tom@tromey.com>
5286
5287 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5288 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5289 tui_clear_source_content.
5290 (tui_clear_source_content): Remove.
5291 (tui_source_window_base::do_erase_source_content): Hoist call to
5292 content.clear().
5293 * tui/tui-stack.c (tui_show_frame_info): Don't call
5294 tui_clear_source_content.
5295
5296 2019-08-15 Tom Tromey <tom@tromey.com>
5297
5298 * tui/tui-winsource.h (struct tui_source_window_base)
5299 <do_erase_source_content>: New method.
5300 <erase_source_content>: New method.
5301 (tui_erase_source_content): Don't declare.
5302 * tui/tui-winsource.c (tui_clear_source_content): Update.
5303 (tui_source_window_base::do_erase_source_content): Rename from
5304 tui_erase_source_content.
5305 (tui_source_window_base::show_source_content): Update.
5306 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5307 * tui/tui-source.h (struct tui_source_window)
5308 <erase_source_content>: New method.
5309 * tui/tui-disasm.h (struct tui_disasm_window)
5310 <erase_source_content>: New method.
5311
5312 2019-08-15 Tom Tromey <tom@tromey.com>
5313
5314 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5315 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5316 constructor.
5317 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5318 * tui/tui-source.c (tui_set_source_content): Update.
5319 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5320
5321 2019-08-15 Tom Tromey <tom@tromey.com>
5322
5323 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5324 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5325 tui-source.c.
5326 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5327 Declare.
5328 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5329 method.
5330 (tui_source_window::maybe_update): Update.
5331
5332 2019-08-15 Tom Tromey <tom@tromey.com>
5333
5334 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5335 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5336 tui-disasm.c.
5337 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5338 Declare.
5339 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5340 method.
5341 (tui_disasm_window::maybe_update): Update.
5342
5343 2019-08-15 Tom Tromey <tom@tromey.com>
5344
5345 * tui/tui-winsource.h (struct tui_source_window_base)
5346 <maybe_update>: Declare.
5347 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5348 method.
5349 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5350 Declare.
5351 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5352 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5353 Declare.
5354 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5355
5356 2019-08-15 Tom Tromey <tom@tromey.com>
5357
5358 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5359
5360 2019-08-15 Tom Tromey <tom@tromey.com>
5361
5362 * tui/tui-wingeneral.c: Include tui-stack.h.
5363 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5364 (struct tui_locator_window): Move from tui-data.h.
5365 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5366 (tui_initialize_static_data): Move from tui-data.c.
5367 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5368 (struct tui_locator_window): Move to tui-stack.c.
5369 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5370 (tui_initialize_static_data): Move to tui-stack.c.
5371
5372 2019-08-15 Tom Tromey <tom@tromey.com>
5373
5374 * tui/tui-layout.c (show_source_disasm_command)
5375 (show_source_or_disasm_and_command): Use make_visible method, not
5376 tui_make_window.
5377 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5378 Remove.
5379
5380 2019-08-15 Tom Tromey <tom@tromey.com>
5381
5382 * tui/tui-wingeneral.h (tui_make_window): Update.
5383 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5384 parameter.
5385 (tui_gen_win_info::make_visible): Update.
5386 * tui/tui-regs.c (tui_data_window::display_registers_from):
5387 Update.
5388 * tui/tui-layout.c (show_source_disasm_command)
5389 (show_source_or_disasm_and_command): Update.
5390 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5391 (enum tui_box): Remove.
5392 (struct tui_win_info) <can_box>: New method.
5393 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5394 method.
5395
5396 2019-08-15 Tom de Vries <tdevries@suse.de>
5397
5398 * linux-nat-trad.c: Include gdbarch.h.
5399
5400 2019-08-14 Alan Hayward <alan.hayward@arm.com>
5401
5402 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5403 register sizes.
5404
5405 2019-08-14 Tom Tromey <tromey@adacore.com>
5406
5407 * darwin-nat.c: Include gdbarch.h.
5408 * darwin-nat-info.c: Include gdbarch.h.
5409
5410 2019-08-13 Tom Tromey <tom@tromey.com>
5411
5412 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5413 Remove.
5414 * tui/tui-data.c (tui_initialize_static_data): Update.
5415
5416 2019-08-13 Tom Tromey <tom@tromey.com>
5417
5418 * tui/tui-winsource.h (struct tui_exec_info_window)
5419 <~tui_exec_info_window, maybe_allocate_content, get_content,
5420 m_content>: Remove.
5421 (struct tui_source_window_base) <set_exec_info_content,
5422 show_exec_info_content>: Don't declare.
5423 * tui/tui-winsource.c
5424 (tui_exec_info_window::maybe_allocate_content): Remove.
5425 (tui_source_window_base::update_exec_info): Rename from
5426 set_exec_info_content.
5427 (tui_source_window_base::show_exec_info_content)
5428 (tui_source_window_base::update_exec_info): Remove.
5429
5430 2019-08-13 Tom Tromey <tom@tromey.com>
5431
5432 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5433 declare.
5434 * tui/tui-winsource.c (tui_update_source_window_as_is)
5435 (tui_update_source_windows_with_addr, tui_erase_source_content):
5436 Update.
5437 (tui_clear_exec_info_content): Remove.
5438
5439 2019-08-13 Tom Tromey <tom@tromey.com>
5440
5441 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5442 declare.
5443 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5444 call tui_erase_exec_info_content.
5445 (tui_clear_exec_info_content): Rename from
5446 tui_erase_exec_info_content.
5447 (tui_clear_exec_info_content): Delete.
5448
5449 2019-08-13 Tom Tromey <tom@tromey.com>
5450
5451 * tui/tui-winsource.h (struct tui_source_window_base)
5452 <show_exec_info_content>: Declare.
5453 (tui_show_exec_info_content): Don't declare.
5454 * tui/tui-winsource.c
5455 (tui_source_window_base::show_exec_info_content): Rename from
5456 tui_show_exec_info_content.
5457 (tui_source_window_base::update_exec_info): Update.
5458
5459 2019-08-13 Tom Tromey <tom@tromey.com>
5460
5461 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5462 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5463 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5464 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5465 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5466 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5467 ... here.
5468
5469 2019-08-13 Tom Tromey <tom@tromey.com>
5470
5471 * tui/tui-winsource.h (struct tui_source_window_base)
5472 <update_exec_info>: Declare.
5473 (tui_update_exec_info): Don't declare.
5474 * tui/tui-winsource.c (tui_update_source_window_as_is)
5475 (tui_source_window_base::refresh_all)
5476 (tui_update_all_breakpoint_info): Update.
5477 (tui_source_window_base::update_exec_info): Rename from
5478 tui_update_exec_info.
5479 * tui/tui-stack.c (tui_show_frame_info): Update.
5480
5481 2019-08-13 Tom Tromey <tom@tromey.com>
5482
5483 * tui/tui-winsource.h (struct tui_source_window_base)
5484 <set_exec_info_content>: Declare.
5485 (tui_set_exec_info_content): Don't declare.
5486 * tui/tui-winsource.c
5487 (tui_source_window_base::set_exec_info_content): Rename from
5488 tui_set_exec_info_content.
5489 (tui_update_exec_info): Update.
5490
5491 2019-08-13 Tom Tromey <tom@tromey.com>
5492
5493 * tui/tui-winsource.h (struct tui_source_window_base)
5494 <show_source_content>: Declare.
5495 (tui_show_source_content): Don't declare.
5496 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5497 (tui_source_window_base::show_source_content): Rename from
5498 tui_show_source_content.
5499 (tui_source_window_base::refresh_all): Update.
5500 * tui/tui-layout.c (show_source_disasm_command)
5501 (show_source_or_disasm_and_command): Update.
5502
5503 2019-08-13 Tom Tromey <tom@tromey.com>
5504
5505 * tui/tui-winsource.c (tui_erase_source_content)
5506 (tui_show_source_content, tui_source_window_base::refresh_all):
5507 Update.
5508 * tui/tui-wingeneral.h
5509 (tui_check_and_display_highlight_if_needed): Don't declare.
5510 * tui/tui-wingeneral.c
5511 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5512 check_and_display_highlight_if_needed.
5513 * tui/tui-win.c (tui_rehighlight_all)
5514 (tui_win_info::make_visible_with_new_height): Update.
5515 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5516 (tui_data_window::erase_data_content)
5517 (tui_data_window::display_all_data): Update.
5518 * tui/tui-data.h (struct tui_win_info)
5519 <check_and_display_highlight_if_needed>: Declare.
5520
5521 2019-08-13 Tom Tromey <tom@tromey.com>
5522
5523 * tui/tui-win.c (tui_resize_all): Call
5524 tui_delete_invisible_windows.
5525 * tui/tui-layout.c (show_layout): Call
5526 tui_delete_invisible_windows.
5527 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5528 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5529
5530 2019-08-13 Tom Tromey <tom@tromey.com>
5531
5532 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5533 tui_add_win_to_layout.
5534
5535 2019-08-13 Tom Tromey <tom@tromey.com>
5536
5537 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5538 * tui/tui-layout.c (tui_default_win_height): Now static.
5539
5540 2019-08-13 Tom Tromey <tom@tromey.com>
5541
5542 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5543 single switch.
5544 (show_source_disasm_command, show_source_or_disasm_and_command):
5545 Don't check current layout.
5546
5547 2019-08-13 Tom Tromey <tom@tromey.com>
5548
5549 * tui/tui-wingeneral.c (make_all_visible): Remove.
5550 (tui_make_all_invisible): Simplify.
5551 * tui/tui-layout.c (tui_make_all_invisible): Move from
5552 tui-wingeneral.c; simplify.
5553 (show_layout): Hoist call to tui_make_all_invisible.
5554 (show_data): Don't call tui_make_all_invisible.
5555
5556 2019-08-13 Tom Tromey <tom@tromey.com>
5557
5558 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5559 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5560
5561 2019-08-13 Tom Tromey <tom@tromey.com>
5562
5563 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5564 tui-data.c.
5565 (show_source_disasm_command, show_data)
5566 (show_source_or_disasm_and_command): Don't use
5567 tui_set_current_layout_to.
5568 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5569 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5570 tui-layout.c.
5571 (tui_set_current_layout_to): Remove.
5572
5573 2019-08-13 Tom Tromey <tom@tromey.com>
5574
5575 * tui/tui-layout.c (tui_set_layout): Update.
5576 * tui/tui-data.h (struct tui_layout_def): Remove.
5577 (tui_layout_def): Don't declare.
5578 * tui/tui-data.c (layout_def): Remove.
5579 (tui_layout_def): Remove.
5580
5581 2019-08-13 Tom Tromey <tom@tromey.com>
5582
5583 * tui/tui-winsource.h (struct tui_source_window_base)
5584 <clear_detail>: No longer "override".
5585 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5586 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5587 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5588 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5589 Remove.
5590 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5591
5592 2019-08-13 Tom Tromey <tromey@adacore.com>
5593
5594 * tracepoint.c: Don't include readline.h or history.h.
5595
5596 2019-08-12 Tom Tromey <tom@tromey.com>
5597
5598 * configure: Rebuild.
5599 * configure.ac: Check for readline 7.
5600 * NEWS: Mention readline 7 requirement.
5601 * README: Update.
5602
5603 2019-08-12 Tom Tromey <tom@tromey.com>
5604
5605 * mingw-hdep.c (gdb_select): Remove readline hack.
5606
5607 2019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5608
5609 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5610 when the function fails.
5611
5612 2019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5613
5614 * s390-tdep.c (s390_type_align): New function.
5615 (s390_gdbarch_init): Set it as type_align gdbarch method.
5616
5617 2019-08-09 Tom de Vries <tdevries@suse.de>
5618
5619 PR gdb/24591
5620 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5621 pc_low with relocation offset.
5622
5623 2019-08-07 Tom Tromey <tromey@adacore.com>
5624
5625 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5626 (print_frame_args): Update.
5627 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5628 Update.
5629 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5630 * frame.h (struct frame_arg): Add initializers.
5631 <error>: Now a unique_xmalloc_ptr.
5632
5633 2019-08-07 Alan Hayward <alan.hayward@arm.com>
5634
5635 * NEWS: Expand the Pointer Authentication entry.
5636 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5637 (aarch64_frame_unmask_lr): ... to this.
5638 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5639 Call aarch64_frame_unmask_lr.
5640 * frame.c (struct frame_info): Add "masked" variable.
5641 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5642 (fprint_frame): Check for masked pc.
5643 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5644 declarations.
5645 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5646 * stack.c (print_frame): Check for masked pc.
5647
5648 2019-08-06 Tom Tromey <tom@tromey.com>
5649
5650 * stabsread.c (patch_block_stabs, read_one_struct_field)
5651 (read_enum_type): Use obstack_strndup.
5652 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5653 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5654 * dwarf2read.c (guess_full_die_structure_name)
5655 (anonymous_struct_prefix): Use obstack_strndup.
5656 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5657 * c-exp.y (yylex): Use obstack_strndup.
5658 * ada-exp.y (write_object_renaming, write_ambiguous_var)
5659 (write_var_or_type): Use obstack_strndup.
5660
5661 2019-08-06 Tom Tromey <tom@tromey.com>
5662
5663 * symfile.c (reread_symbols): Use obstack_strdup.
5664 * stabsread.c (read_type): Use obstack_strdup.
5665 * gdb_obstack.h (obstack_strdup): New overload.
5666 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5667 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5668 (dwarf2_canonicalize_name): Use obstack_strdup.
5669 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5670 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5671 Use obstack_strdup.
5672
5673 2019-08-06 Tom Tromey <tom@tromey.com>
5674
5675 * gdb_obstack.h (obstack_strdup): Define.
5676 * gdb_obstack.c (obstack_strdup): Don't define.
5677
5678 2019-08-06 Tom Tromey <tom@tromey.com>
5679
5680 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5681 obstack_strdup.
5682 * typeprint.c (typedef_hash_table::find_global_typedef): Use
5683 obstack_strdup.
5684 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5685 * stabsread.c (common_block_start): Use obstack_strdup.
5686 * objfiles.c (set_objfile_main_name, objfile): Use
5687 obstack_strdup.
5688 * namespace.c (add_using_directive): Use obstack_strdup.
5689 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5690 * jit.c (finalize_symtab): Use obstack_strdup.
5691 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5692 (guess_partial_die_structure_name, partial_die_info::fixup)
5693 (dwarf2_name): Use obstack_strdup.
5694 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5695 obstack_strdup.
5696 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5697 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5698 obstack_strdup.
5699 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5700
5701 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5702
5703 * unittests/help-doc-selftests.c: New file.
5704 * Makefile.in: Add the new file.
5705
5706 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5707
5708 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5709 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
5710 the full first line, except when FOR_VALUE_PREFIX. In this case,
5711 the trailing '.' is not output, and the first character is uppercased.
5712 (print_help_for_command): Update call to print_doc_line.
5713 (print_doc_of_command): Likewise.
5714 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5715 * cli/cli-option.c (append_indented_doc): Do not append newline.
5716 (build_help_option): Append newline after first appended_indented_doc
5717 only if a second call is done.
5718 (build_help): Append 2 new lines before each option, except the first
5719 one.
5720 * compile/compile.c (_initialize_compile): Add new lines after
5721 %OPTIONS%, when not at the end of the help.
5722 Change help doc or code
5723 producing the help doc to respect the invariants.
5724 * maint-test-options.c (_initialize_maint_test_options): Likewise.
5725 Also removed the new line after 'Options:', as all other commands
5726 do not put an empty line between 'Options:' and the first option.
5727 * printcmd.c (_initialize_printcmd): Likewise.
5728 * stack.c (_initialize_stack): Likewise.
5729 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5730 incorrectly telling COMMAND is optional.
5731 * ada-lang.c (_initialize_ada_language): Change help doc or code
5732 producing the help doc to respect the invariants.
5733 * ada-tasks.c (_initialize_ada_tasks): Likewise.
5734 * breakpoint.c (_initialize_breakpoint): Likewise.
5735 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5736 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5737 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5738 * cli/cli-style.c (cli_style_option::add_setshow_commands,
5739 _initialize_cli_style): Likewise.
5740 * corelow.c (core_target_info): Likewise.
5741 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5742 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5743 * filesystem.c (_initialize_filesystem): Likewise.
5744 * frame.c (_initialize_frame): Likewise.
5745 * gnu-nat.c (add_task_commands): Likewise.
5746 * infcall.c (_initialize_infcall): Likewise.
5747 * infcmd.c (_initialize_infcmd): Likewise.
5748 * interps.c (_initialize_interpreter): Likewise.
5749 * language.c (_initialize_language): Likewise.
5750 * linux-fork.c (_initialize_linux_fork): Likewise.
5751 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5752 * maint.c (_initialize_maint_cmds): Likewise.
5753 * memattr.c (_initialize_mem): Likewise.
5754 * printcmd.c (_initialize_printcmd): Likewise.
5755 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5756 _RegEx): Likewise.
5757 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5758 * record-btrace.c (_initialize_record_btrace): Likewise.
5759 * record-full.c (_initialize_record_full): Likewise.
5760 * record.c (_initialize_record): Likewise.
5761 * regcache-dump.c (_initialize_regcache_dump): Likewise.
5762 * regcache.c (_initialize_regcache): Likewise.
5763 * remote.c (add_packet_config_cmd, init_remote_threadtests,
5764 _initialize_remote): Likewise.
5765 * ser-tcp.c (_initialize_ser_tcp): Likewise.
5766 * serial.c (_initialize_serial): Likewise.
5767 * skip.c (_initialize_step_skip): Likewise.
5768 * source.c (_initialize_source): Likewise.
5769 * stack.c (_initialize_stack): Likewise.
5770 * symfile.c (_initialize_symfile): Likewise.
5771 * symtab.c (_initialize_symtab): Likewise.
5772 * target-descriptions.c (_initialize_target_descriptions): Likewise.
5773 * top.c (init_main): Likewise.
5774 * tracefile-tfile.c (tfile_target_info): Likewise.
5775 * tracepoint.c (_initialize_tracepoint): Likewise.
5776 * tui/tui-win.c (_initialize_tui_win): Likewise.
5777 * utils.c (add_internal_problem_command): Likewise.
5778 * valprint.c (value_print_option_defs): Likewise.
5779
5780 2019-08-06 Frank Ch. Eigler <fche@redhat.com>
5781
5782 PR build/24886
5783 * configure.ac: Drop enable-libmcheck support.
5784 * configure, config.in: Rebuild.
5785 * libmcheck.m4: Remove.
5786 * acinclude.m4: Don't include it.
5787 * Makefile.in: Don't distribute it.
5788 * top.c (print_gdb_configuration): Don't mention it.
5789
5790 2019-08-06 Tom Tromey <tom@tromey.com>
5791
5792 * utils.c (set_output_style): Sometimes pass stream to
5793 emit_style_escape.
5794 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5795 * record-btrace.c (btrace_insn_history): Update.
5796 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5797 method.
5798 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5799 Update initializers.
5800 <m_uiout>: New field.
5801 <m_di>: Move lower.
5802 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5803 Remove "uiout" parameter.
5804 (dump_insns): Update.
5805 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5806 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5807
5808 2019-08-06 Christian Biesinger <cbiesinger@google.com>
5809
5810 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5811 (error_in_psymtab_expansion): Likewise.
5812 (lookup_symbol_via_quick_fns): Likewise.
5813 (basic_lookup_transparent_type_quick): Likewise.
5814 (basic_lookup_transparent_type_1): Likewise.
5815
5816 2019-08-06 Tom Tromey <tromey@adacore.com>
5817
5818 * source.c (last_source_error): Now bool.
5819 (print_source_lines_base): Make "noprint" bool. Only open
5820 source file when last_source_visited changes.
5821
5822 2019-08-06 Tom Tromey <tromey@adacore.com>
5823
5824 * annotate.c (annotate_source_line): Use g_source_cache.
5825 * source-cache.c (source_cache::get_plain_source_lines): Change
5826 parameters. Populate m_offset_cache.
5827 (source_cache::ensure): New method.
5828 (source_cache::get_line_charpos): New method.
5829 (extract_lines): Move lower. Change parameters.
5830 (source_cache::get_source_lines): Move lower.
5831 * source-cache.h (class source_cache): Update comment.
5832 <get_line_charpos>: New method.
5833 <get_source_lines>: Update comment.
5834 <clear>: Clear m_offset_cache.
5835 <get_plain_source_lines>: Change parameters.
5836 <ensure>: New method
5837 <m_offset_cache>: New member.
5838 * source.c (forget_cached_source_info_for_objfile): Update.
5839 (info_source_command): Use g_source_cache.
5840 (find_source_lines, open_source_file_with_line_charpos): Remove.
5841 (print_source_lines_base, search_command_helper): Use g_source_cache.
5842 * source.h (open_source_file_with_line_charpos): Don't declare.
5843 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5844 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5845 Use g_source_cache.
5846
5847 2019-08-06 Tom Tromey <tromey@adacore.com>
5848
5849 * source-cache.c (source_cache::get_plain_source_lines):
5850 Remove "first_line" and "last_line" parameters.
5851 (source_cache::get_source_lines): Cache plain text.
5852 * source-cache.h (class source_cache)
5853 <get_plain_source_lines>: Update.
5854
5855 2019-08-06 Tom Tromey <tromey@adacore.com>
5856
5857 * source-cache.c (extract_lines): No longer a method.
5858 Changed type of parameter. Include final newline.
5859 (selftests::extract_lines_test): New function.
5860 (_initialize_source_cache): Likewise.
5861 * source-cache.h (class source_cache)
5862 <extract_lines>: Don't declare.
5863
5864 2019-08-06 Tom Tromey <tromey@adacore.com>
5865
5866 * breakpoint.c (init_breakpoint_sal): Update.
5867 (breakpoint): Update.
5868 * breakpoint.h (struct breakpoint) <filter>: Now a
5869 unique_xmalloc_ptr.
5870
5871 2019-08-05 Christian Biesinger <cbiesinger@google.com>
5872
5873 * NEWS: Mention dictionary access on blocks.
5874 * python/py-block.c (blpy_getitem): New function.
5875 (block_object_as_mapping): New struct.
5876 (block_object_type): Use new struct for tp_as_mapping field.
5877
5878 2019-08-05 Christian Biesinger <cbiesinger@google.com>
5879
5880 * objfiles.h (objfile): Add a comment describing partial symbols.
5881
5882 2019-08-05 Tom Tromey <tromey@adacore.com>
5883
5884 * compile/compile.c (_initialize_compile): Use _(), not N_().
5885 * thread.c (_initialize_thread): Use _(), not N_().
5886 * stack.c (_initialize_stack): Use _(), not N_().
5887 * printcmd.c (_initialize_printcmd): Use _(), not N_().
5888
5889 2019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
5890
5891 * dwarf2read.c (struct dw2_symtab_iterator):
5892 <want_specific_block>: Remove.
5893 <block_index>: Change type to gdb::optional.
5894 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5895 change type of BLOCK_INDEX parameter to gdb::optional.
5896 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5897 (dw2_lookup_symbol): Don't pass argument for
5898 WANT_SPECIFIC_BLOCK.
5899 (dw2_expand_symtabs_for_function): Don't pass argument for
5900 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5901 (class dw2_debug_names_iterator)
5902 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5903 parameter, change BLOCK_INDEX type to gdb::optional.
5904 <m_want_specific_block>: Remove.
5905 <m_block_index>: Change type to gdb::optional.
5906 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5907 gdb::optional. Re-write in function of gdb::optional.
5908 (dw2_debug_names_lookup_symbol): Don't pass argument for
5909 WANT_SPECIFIC_BLOCK.
5910 (dw2_debug_names_expand_symtabs_for_function): Don't pass
5911 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5912 BLOCK_INDEX.
5913
5914 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5915
5916 * NEWS: Mention changes to "info sources" command.
5917
5918 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5919
5920 * symtab.c (filename_partial_match_opts): New struct type.
5921 (struct output_source_filename_data): New members
5922 regexp, c_regexp, partial_match.
5923 (output_source_filename): Use new members to decide to print file.
5924 (info_sources_option_defs): New variable.
5925 (make_info_sources_options_def_group, print_info_sources_header,
5926 info_sources_command_completer):
5927 New functions.
5928 (info_sources_command): Read new optional arguments.
5929 (_initialize_symtab): Update info sources help.
5930
5931 2019-08-02 Alexandre Oliva <oliva@adacore.com>
5932
5933 * ada-lang.c (exception_support_info_v0): Renamed from...
5934 (default_exception_support_info): ... this. Create new
5935 definition for v1.
5936 (ada_has_this_exception_support): Look up catch_handlers_sym.
5937 (ada_exception_support_info_sniffer): Try v0 after default.
5938
5939 2019-08-01 Tom Tromey <tromey@adacore.com>
5940
5941 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5942 gdbarch.h.
5943
5944 2019-08-01 Christian Biesinger <cbiesinger@google.com>
5945
5946 * s12z-tdep.c: Fix include path for s12z-opc.h.
5947
5948 2019-08-01 Alan Hayward <alan.hayward@arm.com>
5949
5950 * NEWS: Require GNU make 3.82.
5951
5952 2019-07-16 Tom Tromey <tom@tromey.com>
5953
5954 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5955 declare.
5956
5957 2019-07-30 Tom Tromey <tromey@adacore.com>
5958
5959 * block.c (contained_in): Remove BLOCK_FUNCTION check.
5960
5961 2019-07-30 Kevin Buettner <kevinb@redhat.com>
5962
5963 * printcmd.c (print_address_symbolic): Print negative offsets.
5964 (build_address_symbolic): Force signed arithmetic when computing
5965 offset.
5966
5967 2019-07-30 Christian Biesinger <cbiesinger@google.com>
5968
5969 PR/24474: Add a function to lookup static variables.
5970 * NEWS: Mention this new function.
5971 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5972 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5973 * python/python.c (python_GdbMethods): Add new function.
5974
5975 2019-07-29 Christian Biesinger <cbiesinger@google.com>
5976
5977 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5978 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5979 (objfpy_lookup_static_symbol): New function.
5980 (objfile_object_methods): Add new functions.
5981
5982 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5983
5984 * NEWS: Mention 'set|show print frame-info'. Mention new
5985 'presence' value for 'frame-arguments'. Mention new '-frame-info'
5986 backtrace argument. Mention that python frame filtering code
5987 is now consistent with what 'backtrace' command prints.
5988
5989 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5990
5991 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5992 comments.
5993 (print_frame_info_auto, print_frame_info_source_line,
5994 print_frame_info_location, print_frame_info_source_and_location,
5995 print_frame_info_location_and_address, print_frame_info_short_location):
5996 New declarations.
5997 (struct frame_print_options): New member print_frame_info.
5998 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5999 * stack.h (get_user_print_what_frame_info): New declaration.
6000 (frame_show_address): New declaration.
6001 * stack.c (print_frame_arguments_choices): New value 'presence'.
6002 (print_frame_info_auto, print_frame_info_source_line,
6003 print_frame_info_location, print_frame_info_source_and_location,
6004 print_frame_info_location_and_address, print_frame_info_short_location,
6005 print_frame_info_choices, print_frame_info_print_what): New definitions.
6006 (print_frame_args): Only print dots for args if print frame-arguments
6007 is 'presence'.
6008 (frame_print_option_defs): New element for "frame-info".
6009 (get_user_print_what_frame_info): New function.
6010 (frame_show_address): Make non static. Move comment to stack.h.
6011 (print_frame_info_to_print_what): New function.
6012 (print_frame_info): Update comment. Use fp_opts.print_frame_info
6013 to decide what to print.
6014 (backtrace_command_1): Handle the new print_frame_arguments_presence
6015 value.
6016 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6017 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6018 (py_print_frame): In non-mi mode, use LOCATION as default for
6019 print_what, similarly to frame information printed directly by
6020 backtrace command. Handle frame-info user option in non MI mode.
6021
6022 2019-07-27 Kevin Buettner <kevinb@redhat.com>
6023
6024 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6025 Add case for debugging 32-bit target on 64-bit host. Revise
6026 comment.
6027
6028 2019-07-27 Kevin Buettner <kevinb@redhat.com>
6029
6030 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6031 instead of find_function_entry_range_from_pc.
6032
6033 2019-07-27 Kevin Buettner <kevinb@redhat.com>
6034
6035 * stack.c (find_frame_funname): Remove code which preferred
6036 minsym over symtab sym in "certain pathological cases".
6037
6038 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6039 parameter. Change type of "do_demangle" to bool.
6040 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6041 Pass suitable "prefer_sym_over_minsym" flag to
6042 build_address_symbolic(). Don't output "+" for negative offsets.
6043 * printcmd.c (print_address_symbolic): Update invocation of
6044 build_address_symbolic to include a "prefer_sym_over_minsym"
6045 flag.
6046 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6047 Restrict cases in which use of minimal symbol is preferred to that
6048 of a found symbol. Update comments.
6049
6050 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6051 for entry pc when entry pc is out of range for that FDE.
6052
6053 2019-07-26 Brian Callahan <bcallah@openbsd.org>
6054
6055 PR gdb/24839:
6056 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6057 type.
6058
6059 2019-07-25 Christian Biesinger <cbiesinger@google.com>
6060
6061 * python/py-objfile.c (add_separate_debug_file): Fix comment about
6062 this function's Python signature.
6063
6064
6065 2019-07-24 Christian Biesinger <cbiesinger@google.com>
6066
6067 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6068 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6069 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6070 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6071 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6072
6073
6074 2019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
6075
6076 * h8300-tdep.c (h8300_register_name_common): New.
6077 h8300_register_name): Use h8300_register_name_common.
6078 (h8300s_register_name): Likewise.
6079 (h8300sx_register_name): Likewise.
6080 (h8300h_register_nam): New.
6081 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6082
6083
6084 2019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
6085
6086 * arm-tdep.c (arm_skip_cmse_entry): New function.
6087 (arm_is_sgstubs_section): New function.
6088 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6089
6090 2019-07-22 Tom Tromey <tom@tromey.com>
6091
6092 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6093 Don't self-assign.
6094
6095 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6096
6097 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6098 type_print.
6099
6100 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6101
6102 * symtab.c (search_symbols): Adjust msymbol matching type arrays
6103 so that GDB doesn't match any msymbols when searching in the
6104 TYPES_DOMAIN.
6105 (print_symbol_info): Print using typedef_print or type_print based
6106 on the type of the symbol. Add updated FIXME comment moved from...
6107 (_initialize_symtab): ... move and update FIXME comment to above.
6108
6109 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6110
6111 * NEWS: Mention adding -q option to "info types".
6112 * symtab.c (struct info_types_options): New struct.
6113 (info_types_options_defs): New variable.
6114 (make_info_types_options_def_group): New function.
6115 (info_types_command): Use gdb::option framework to parse options.
6116 (info_types_command_completer): New function.
6117 (_initialize_symtab): Extend the help text on "info types" and
6118 register command completer.
6119
6120 2019-07-21 Christian Biesinger <cbiesinger@google.com>
6121
6122 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6123 (lookup_symbol_in_objfile): Change int to block_enum and add a
6124 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6125
6126 2019-07-20 Christian Biesinger <cbiesinger@google.com>
6127
6128 * MAINTAINERS (Write After Approval): Add self.
6129
6130 2019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
6131
6132 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6133 instruction to the dummy code region.
6134
6135 2019-07-19 Tom Tromey <tromey@adacore.com>
6136
6137 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6138 (ARGSUSED, PARAMS, __func__): Remove rules.
6139
6140 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6141
6142 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6143 * features/arm/arm-with-iwmmxt.c: Remove.
6144 * features/arm/arm-with-iwmmxt.xml: Remove.
6145 * features/arm/arm-with-m-fpa-layout.c: Remove.
6146 * features/arm/arm-with-m-fpa-layout.xml: Remove.
6147 * features/arm/arm-with-m-vfp-d16.c: Remove.
6148 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6149 * features/arm/arm-with-m.c: Remove.
6150 * features/arm/arm-with-m.xml: Remove.
6151 * features/arm/arm-with-neon.c: Remove.
6152 * features/arm/arm-with-neon.xml: Remove.
6153 * features/arm/arm-with-vfpv2.c: Remove.
6154 * features/arm/arm-with-vfpv2.xml: Remove.
6155 * features/arm/arm-with-vfpv3.c: Remove.
6156 * features/arm/arm-with-vfpv3.xml: Remove.
6157
6158 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6159
6160 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6161
6162 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6163
6164 * arch/aarch32.c (aarch32_create_target_description): Create
6165 target descriptions using features.
6166 * arch/arm.c (arm_create_target_description)
6167 (arm_create_mprofile_target_description): Likewise.
6168 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6169
6170 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6171
6172 * Makefile.in: Add new files.
6173 * aarch32-tdep.c: New file.
6174 * aarch32-tdep.h: New file.
6175 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6176 Call aarch32_read_description.
6177 * arch/aarch32.c: New file.
6178 * arch/aarch32.h: New file.
6179 * arch/arm.c (arm_create_target_description)
6180 (arm_create_mprofile_target_description): New function.
6181 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6182 (arm_create_target_description)
6183 (arm_create_mprofile_target_description): New declaration.
6184 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6185 read_description functions.
6186 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6187 Likewise.
6188 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6189 * arm-tdep.c (tdesc_arm_list): New variable.
6190 (arm_register_g_packet_guesses): Call create description functions.
6191 (arm_read_description) (arm_read_mprofile_description): New
6192 function.
6193 * arm-tdep.h (arm_read_description)
6194 (arm_read_mprofile_description): Add declaration.
6195 * configure.tgt: Add new files.
6196
6197 2019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6198
6199 * top.c (new_ui_command): Open specified terminal just once.
6200
6201 2019-07-18 Tom Tromey <tromey@adacore.com>
6202
6203 * symtab.c (main_name): Constify return type.
6204 * symfile.c (set_initial_language): Update.
6205 * symtab.h (main_name): Constify return type.
6206
6207 2019-07-17 Tom Tromey <tom@tromey.com>
6208
6209 * tui/tui-winsource.c (tui_update_source_window)
6210 (tui_update_source_window_as_is)
6211 (tui_update_source_windows_with_line): Remove return.
6212 * tui/tui-disasm.c (tui_show_disassem)
6213 (tui_show_disassem_and_update_source): Remove return.
6214 * tui/tui.c (tui_reset): Remove return.
6215 * tui/tui-wingeneral.c
6216 (tui_check_and_display_highlight_if_needed): Remove return.
6217
6218 2019-07-17 Tom Tromey <tom@tromey.com>
6219
6220 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6221
6222 2019-07-17 Tom Tromey <tom@tromey.com>
6223
6224 * tui/tui-winsource.h (struct tui_exec_info_window)
6225 (struct tui_source_window_base): Move from tui-data.h.
6226 * tui/tui-winsource.c: Move many method definitions from
6227 elsewhere. Remove "structuring" comments.
6228 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6229 (tui_source_window_base::refresh_window): Move to
6230 tui-winsource.c.
6231 * tui/tui-win.c (tui_source_window_base::refresh_all)
6232 (tui_source_window_base::update_tab_width)
6233 (tui_source_window_base::set_new_height)
6234 (tui_source_window_base::do_make_visible_with_new_height): Move to
6235 tui-winsource.c.
6236 * tui/tui-source.h: Update.
6237 * tui/tui-source.c (tui_source_window_base::reset): Move to
6238 tui-winsource.c.
6239 * tui/tui-disasm.h: Update.
6240 * tui/tui-data.h (struct tui_exec_info_window): Move to
6241 tui-winsource.h.
6242 (struct tui_source_window_base): Likewise.
6243 * tui/tui-data.c (tui_source_window_base::clear_detail)
6244 (tui_source_window_base, ~tui_source_window_base): Move to
6245 tui-winsource.c.
6246
6247 2019-07-17 Tom Tromey <tom@tromey.com>
6248
6249 * tui/tui-win.c (tui_resize_all)
6250 (tui_source_window_base::update_tab_width)
6251 (tui_adjust_win_heights): Update.
6252 (tui_win_info::make_invisible_and_set_new_height): Rename from
6253 make_invisible_and_set_new_height.
6254 * tui/tui-data.h (struct tui_win_info)
6255 <make_invisible_and_set_new_height>: New method.
6256
6257 2019-07-17 Tom Tromey <tom@tromey.com>
6258
6259 * tui/tui.c: Update.
6260 * tui/tui-source.h (struct tui_source_window): Move from
6261 tui-data.h.
6262 * tui/tui-layout.c: Update.
6263 * tui/tui-disasm.c: Update.
6264 * tui/tui-data.h (struct tui_source_window): Move to
6265 tui-source.h.
6266
6267 2019-07-17 Tom Tromey <tom@tromey.com>
6268
6269 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6270 tui-data.h.
6271 * tui/tui-data.h (struct tui_disasm_window): Move to
6272 tui-disasm.h.
6273
6274 2019-07-17 Tom Tromey <tom@tromey.com>
6275
6276 * tui/tui-regs.h (struct tui_data_item_window): Move from
6277 tui-data.h.
6278 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6279 * tui/tui-data.h (struct tui_data_item_window): Move to
6280 tui-regs.h.
6281 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6282
6283 2019-07-17 Tom Tromey <tom@tromey.com>
6284
6285 * tui/tui.c: Update.
6286 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6287 (tui_cmd_window::max_height): Move to tui-command.c.
6288 * tui/tui-layout.c: Update.
6289 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6290 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6291 tui-command.c.
6292 * tui/tui-command.h (struct tui_cmd_window): Move from
6293 tui-data.h.
6294 * tui/tui-command.c: Remove "structuring" comments.
6295 (tui_cmd_window::clear_detail)
6296 (tui_cmd_window::do_make_visible_with_new_height)
6297 (tui_cmd_window::max_height): Move from elsewhere.
6298
6299 2019-07-17 Tom Tromey <tom@tromey.com>
6300
6301 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6302 Now static.
6303 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6304 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6305
6306 2019-07-17 Tom Tromey <tom@tromey.com>
6307
6308 * tui/tui.c: Update.
6309 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6310 tui-regs.c.
6311 * tui/tui-windata.h: Remove file.
6312 * tui/tui-windata.c: Remove file.
6313 * tui/tui-win.c (tui_data_window::set_new_height)
6314 (tui_data_window::do_make_visible_with_new_height): Move to
6315 tui-regs.c.
6316 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6317 * tui/tui-regs.c: Remove "structuring" comments.
6318 (tui_data_window::first_data_item_displayed)
6319 (tui_data_window::delete_data_content_windows)
6320 (tui_data_window::erase_data_content)
6321 (tui_data_window::display_all_data)
6322 (tui_data_window::refresh_all)
6323 (tui_data_window::do_scroll_vertical)
6324 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6325 (tui_data_window::do_make_visible_with_new_height)
6326 (tui_data_window::refresh_window): Move from elsewhere.
6327 (_initialize_tui_regs): Move to end of file.
6328 * tui/tui-layout.c: Update.
6329 * tui/tui-hooks.c: Update.
6330 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6331 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6332 tui-regs.c.
6333 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6334
6335 2019-07-17 Tom Tromey <tom@tromey.com>
6336
6337 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6338 seen.
6339
6340 2019-07-17 Tom Tromey <tom@tromey.com>
6341
6342 * tui/tui-win.c (tui_source_window_base::set_new_height)
6343 (tui_source_window_base::do_make_visible_with_new_height): Use
6344 m_has_locator field directly.
6345 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6346 method.
6347 (struct tui_source_window_base) <has_locator>: Likewise.
6348
6349 2019-07-17 Tom Tromey <tom@tromey.com>
6350
6351 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6352 Don't declare.
6353 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6354 Remove.
6355 * tui/tui-win.c (tui_source_window_base::set_new_height)
6356 (tui_source_window_base::set_new_height)
6357 (make_invisible_and_set_new_height)
6358 (tui_source_window_base::do_make_visible_with_new_height)
6359 (tui_source_window_base::do_make_visible_with_new_height):
6360 Update.
6361 * tui/tui-layout.c (show_source_disasm_command, show_data)
6362 (show_source_or_disasm_and_command): Update.
6363 * tui/tui-layout.c (show_layout): Update.
6364
6365 2019-07-17 Tom Tromey <tom@tromey.com>
6366
6367 * tui/tui-layout.c (make_data_window): Remove.
6368 (show_data): Unify creation and re-initialization cases.
6369
6370 2019-07-17 Tom Tromey <tom@tromey.com>
6371
6372 * tui/tui-layout.c (make_source_window, make_disasm_window):
6373 Remove.
6374 (show_data): Unify creation and re-initialization cases.
6375
6376 2019-07-17 Tom Tromey <tom@tromey.com>
6377
6378 * tui/tui-layout.c (make_command_window): Remove.
6379 (show_source_disasm_command, show_source_or_disasm_and_command):
6380 Unify creation and re-initialization cases.
6381
6382 2019-07-17 Tom Tromey <tom@tromey.com>
6383
6384 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6385 creation and re-initialization cases.
6386
6387 2019-07-17 Tom Tromey <tom@tromey.com>
6388
6389 * tui/tui-regs.c (tui_get_register): Return void.
6390
6391 2019-07-17 Tom Tromey <tom@tromey.com>
6392
6393 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6394 Simplify.
6395
6396 2019-07-17 Tom Tromey <tom@tromey.com>
6397
6398 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6399 resetting.
6400
6401 2019-07-17 Tom Tromey <tom@tromey.com>
6402
6403 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6404 * tui/tui-regs.c (tui_reg_layout): New function.
6405 (tui_show_registers, tui_reg_command): Use it.
6406 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6407 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6408 parameters.
6409 (tui_layout_command): Remove.
6410
6411 2019-07-17 Tom Tromey <tom@tromey.com>
6412
6413 * tui/tui-layout.h (tui/tui-layout): Return void.
6414 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6415
6416 2019-07-17 Tom Tromey <tom@tromey.com>
6417
6418 * tui/tui-layout.c (show_source_disasm_command, show_data):
6419 Update.
6420 (reset_locator): Remove.
6421 (show_source_or_disasm_and_command): Update.
6422
6423 2019-07-17 Tom Tromey <tom@tromey.com>
6424
6425 * tui/tui-source.c (tui_source_window_base::reset): Remove
6426 win_type parameter.
6427 * tui/tui-layout.c (make_command_window, make_source_window)
6428 (make_disasm_window, make_data_window)
6429 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6430 (reset_locator, show_source_or_disasm_and_command): Update.
6431 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6432 win_type parameter.
6433 (struct tui_source_window_base) <reset>: Likewise.
6434
6435 2019-07-17 Tom Tromey <tom@tromey.com>
6436
6437 * tui/tui-layout.c (show_source_disasm_command): Use
6438 reset_locator.
6439 (reset_locator): New function.
6440 (init_and_make_win): Remove.
6441 (show_source_or_disasm_and_command): Use reset_locator.
6442
6443 2019-07-17 Tom Tromey <tom@tromey.com>
6444
6445 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6446 condition.
6447 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6448 Remove condition.
6449 * tui/tui-source.c (tui_source_window_base::reset): New method.
6450 * tui/tui-layout.c (make_command_window): Don't call
6451 init_and_make_win.
6452 (make_source_window, make_disasm_window): Don't call
6453 make_source_or_disasm_window.
6454 (make_data_window): Don't call init_and_make_win. Change calling
6455 convention.
6456 (show_source_disasm_command, show_data): Simplify.
6457 (make_source_or_disasm_window): Remove.
6458 (show_source_or_disasm_and_command): Simplify.
6459 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6460 (struct tui_source_window_base) <reset>: Likewise.
6461 <execution_info>: Remove initializer.
6462 * tui/tui-data.c (tui_source_window_base): Initialize
6463 execution_info.
6464
6465 2019-07-17 Tom Tromey <tom@tromey.com>
6466
6467 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6468 variable.
6469
6470 2019-07-17 Tom Tromey <tom@tromey.com>
6471
6472 * tui/tui.c (tui_rl_other_window): Update.
6473 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6474 superclass method first. Always iterate over regs_content.
6475 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6476 method.
6477 * tui/tui-win.c (tui_set_focus_command): Update.
6478
6479 2019-07-17 Tom Tromey <tom@tromey.com>
6480
6481 * tui/tui-win.c (tui_set_focus_command): Rename from
6482 tui_set_focus. Call tui_enable.
6483 (tui_set_focus_command): Remove.
6484
6485 2019-07-17 Tom Tromey <tom@tromey.com>
6486
6487 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6488 refresh_window.
6489 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6490 touchwin.
6491 (tui_data_window::refresh_window): Call refresh_window on data
6492 items. Always call superclass refresh_window.
6493 (tui_win_info::refresh): Remove.
6494 (tui_source_window_base::refresh_window): Update.
6495 (tui_refresh_all): Update.
6496 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6497 refresh_window.
6498 (show_source_or_disasm_and_command): Likewise.
6499 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6500 (struct tui_source_window_base) <refresh>: Likewise.
6501
6502 2019-07-17 Tom Tromey <tom@tromey.com>
6503
6504 * tui/tui-winsource.c (tui_clear_source_content)
6505 (tui_show_source_content): Update.
6506 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6507 whether content is empty.
6508 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6509 Remove.
6510
6511 2019-07-17 Tom Tromey <tom@tromey.com>
6512
6513 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6514 window's contents.
6515 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6516 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6517
6518 2019-07-17 Tom Tromey <tom@tromey.com>
6519
6520 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6521 (struct tui_data_item_window): Update.
6522
6523 2019-07-17 Tom Tromey <tom@tromey.com>
6524
6525 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6526 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6527 defines.
6528
6529 2019-07-17 Tom Tromey <tom@tromey.com>
6530
6531 * tui/tui-winsource.h (tui_erase_source_content)
6532 (tui_clear_source_content): Remove "display_prompt" parameter.
6533 * tui/tui-winsource.c (tui_update_source_window_as_is)
6534 (tui_update_source_windows_with_addr): Update.
6535 (tui_clear_source_content): Remove "display_prompt" parameter.
6536 (tui_erase_source_content): Likewise. Simplify.
6537 (tui_show_source_content): Update.
6538 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6539 * tui/tui-stack.c (tui_show_frame_info): Update.
6540 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6541 Remove defines.
6542
6543 2019-07-17 Tom Tromey <tom@tromey.com>
6544
6545 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6546 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6547 parameter.
6548 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6549 parameter.
6550
6551 2019-07-17 Tom Tromey <tom@tromey.com>
6552
6553 * tui/tui-winsource.c (tui_clear_source_content)
6554 (tui_show_source_content, tui_show_exec_info_content)
6555 (tui_clear_exec_info_content): Update.
6556 * tui/tui-stack.c (tui_show_locator_content): Update.
6557 (tui_show_frame_info): Update.
6558 * tui/tui-source.h (tui_source_window): Don't declare.
6559 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6560 from tui_source_is_displayed.
6561 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6562 Remove field.
6563 (struct tui_source_window_base) <content_in_use>: New field. Now
6564 bool.
6565 (struct tui_source_window) <showing_source_p>: New method.
6566 (TUI_SRC_WIN): Change cast.
6567 * tui/tui-data.c (tui_initialize_static_data): Update.
6568
6569 2019-07-17 Tom Tromey <tom@tromey.com>
6570
6571 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6572 location_matches_p.
6573 * tui/tui-source.c (tui_source_window::location_matches_p): New
6574 method.
6575 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6576 method.
6577 * tui/tui-data.h (struct tui_source_window_base)
6578 <location_matches_p>: New method.
6579 (struct tui_source_window, struct tui_disasm_window)
6580 <location_matches_p>: Likewise.
6581
6582 2019-07-17 Tom Tromey <tom@tromey.com>
6583
6584 * tui/tui-win.c (tui_set_win_height_command): Rename from
6585 tui_set_win_height.
6586 (tui_set_win_height_command): Remove.
6587
6588 2019-07-17 Tom Tromey <tom@tromey.com>
6589
6590 * tui/tui-source.c (tui_source_window): New constructor. Add
6591 observer.
6592 (~tui_source_window): New destructor.
6593 (tui_source_window::style_changed): New method.
6594 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6595 (tui_attach_detach_observers): Update.
6596 * tui/tui-data.h (struct tui_source_window): Make constructor not
6597 inline. Add destructor.
6598 (struct tui_source_window) <style_changed>: New method.
6599 <m_observable>: New member.
6600
6601 2019-07-17 Tom Tromey <tom@tromey.com>
6602
6603 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6604 * tui/tui-win.c (tui_resize_all): Fix typo.
6605
6606 2019-07-17 Tom Tromey <tom@tromey.com>
6607
6608 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6609 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6610 (tui_refresh_all): Remove "list" parameter. Use foreach.
6611 * tui/tui-win.c (window_name_completer): Use foreach.
6612 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6613 (update_tab_width): Likewise.
6614 * tui/tui-layout.c (show_layout): Update.
6615 * tui/tui-data.h (class tui_window_iterator): New.
6616 (struct all_tui_windows): New.
6617 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6618
6619 2019-07-17 Tom Tromey <tom@tromey.com>
6620
6621 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6622 parameter. Don't reference globals.
6623 (tui_reg_command): Update.
6624
6625 2019-07-17 Tom Tromey <tom@tromey.com>
6626
6627 * tui/tui-regs.c (tui_show_registers): Simplify.
6628
6629 2019-07-17 Tom Tromey <tom@tromey.com>
6630
6631 * tui/tui-regs.c (tui_show_registers): Update.
6632 (tui_show_register_group): Add win_info parameter.
6633
6634 2019-07-17 Tom Tromey <tom@tromey.com>
6635
6636 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6637 Rename from tui_display_reg_element_at_line.
6638 (tui_data_window::display_registers_from_line): Update.
6639 * tui/tui-data.h (struct tui_data_window)
6640 <display_reg_element_at_line>: New method.
6641
6642 2019-07-17 Tom Tromey <tom@tromey.com>
6643
6644 * tui/tui-regs.h (tui_display_registers_from)
6645 (tui_display_registers_from_line): Don't declare.
6646 * tui/tui-windata.c (tui_data_window::display_all_data)
6647 (tui_data_window::refresh_all)
6648 (tui_data_window::do_scroll_vertical): Update.
6649 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6650 from tui_display_registers_from.
6651 (tui_display_reg_element_at_line): Update.
6652 (tui_data_window::display_registers_from_line): Rename from
6653 tui_display_registers_from_line.
6654 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6655 display_registers_from_line>: New methods.
6656
6657 2019-07-17 Tom Tromey <tom@tromey.com>
6658
6659 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6660 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6661 from tui_erase_data_content.
6662 (tui_data_window::display_all_data)
6663 (tui_data_window::refresh_all)
6664 (tui_data_window::do_scroll_vertical): Update.
6665 * tui/tui-regs.c (tui_show_registers): Update.
6666 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6667 New method.
6668
6669 2019-07-17 Tom Tromey <tom@tromey.com>
6670
6671 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6672 declare.
6673 * tui/tui-windata.c
6674 (tui_data_window::delete_data_content_windows): Rename from
6675 tui_delete_data_content_windows.
6676 (tui_data_window::display_all_data)
6677 (tui_data_window::do_scroll_vertical): Update.
6678 * tui/tui-data.h (struct tui_data_window)
6679 <delete_data_content_windows>: New method.
6680
6681 2019-07-17 Tom Tromey <tom@tromey.com>
6682
6683 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6684 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6685
6686 2019-07-17 Tom Tromey <tom@tromey.com>
6687
6688 * tui/tui-windata.h (tui_display_all_data): Don't declare.
6689 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6690 from tui_display_all_data.
6691 * tui/tui-win.c
6692 (tui_data_window::do_make_visible_with_new_height): Update.
6693 * tui/tui-regs.c (tui_show_registers): Update.
6694 * tui/tui-layout.c (tui_set_layout): Update.
6695 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6696 method.
6697
6698 2019-07-17 Tom Tromey <tom@tromey.com>
6699
6700 * tui/tui-windata.h (tui_display_data_from): Don't declare.
6701 * tui/tui-windata.c (tui_display_data_from): Remove.
6702 (tui_data_window::refresh_all): Update.
6703
6704 2019-07-17 Tom Tromey <tom@tromey.com>
6705
6706 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6707 * tui/tui-windata.c (tui_display_data_from_line): Remove.
6708 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6709 tui_display_registers_from_line.
6710 * tui/tui-regs.h (tui_display_registers_from_line): Update.
6711 * tui/tui-regs.c (tui_display_registers_from_line): Remove
6712 "force_display" parameter.
6713
6714 2019-07-17 Tom Tromey <tom@tromey.com>
6715
6716 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6717 declare.
6718 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6719 Rename from tui_first_reg_element_no_inline.
6720 (tui_display_reg_element_at_line)
6721 (tui_display_registers_from_line): Update.
6722 * tui/tui-data.h (struct tui_data_window)
6723 <first_reg_element_no_inline>: New method.
6724
6725 2019-07-17 Tom Tromey <tom@tromey.com>
6726
6727 * tui/tui-windata.c (tui_display_data_from)
6728 (tui_data_window::do_scroll_vertical): Update.
6729 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6730 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6731 Rename from tui_line_from_reg_element_no.
6732 (tui_display_registers_from_line): Update.
6733 * tui/tui-data.h (struct tui_data_window)
6734 <line_from_reg_element_no>: New method.
6735
6736 2019-07-17 Tom Tromey <tom@tromey.com>
6737
6738 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6739 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6740 tui_last_regs_line_no.
6741 (tui_display_reg_element_at_line)
6742 (tui_display_registers_from_line): Update.
6743 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6744 method.
6745
6746 2019-07-17 Tom Tromey <tom@tromey.com>
6747
6748 PR tui/24722:
6749 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6750 (tui_update_breakpoint_info): Add "being_deleted" parameter.
6751 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6752 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6753 (tui_update_breakpoint_info): Likewise.
6754 * tui/tui-hooks.c (tui_event_create_breakpoint)
6755 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6756 Update.
6757
6758 2019-07-17 Tom Tromey <tom@tromey.com>
6759
6760 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6761
6762 2019-07-17 Tom Tromey <tom@tromey.com>
6763
6764 * tui/tui-winsource.c (tui_update_source_window_as_is)
6765 (tui_update_source_windows_with_addr): Update.
6766 * tui/tui-source.h (tui_set_source_content)
6767 (tui_show_symtab_source): Add "win_info" parameter.
6768 * tui/tui-source.c (tui_set_source_content): Add "win_info"
6769 parameter.
6770 (tui_show_symtab_source): Likewise.
6771
6772 2019-07-17 Tom Tromey <tom@tromey.com>
6773
6774 * tui/tui-wingeneral.c
6775 (tui_check_and_display_highlight_if_needed): Check can_highlight.
6776
6777 2019-07-17 Tom Tromey <tom@tromey.com>
6778
6779 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6780 (struct tui_cmd_window) <can_scroll>: New method.
6781 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6782 method.
6783
6784 2019-07-17 Tom Tromey <tromey@adacore.com>
6785
6786 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6787 do_field_signed>: Rename. Change type of "value".
6788 * ui-out.c (ui_out::field_signed): Rename from field_int.
6789 Change type of "value".
6790 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
6791 type of "value".
6792 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6793 do_field_int. Change type of "value".
6794 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6795 do_field_int. Change type of "value".
6796 * tracepoint.c (trace_status_mi, tfind_1)
6797 (print_one_static_tracepoint_marker): Update.
6798 * thread.c (print_thread_info_1, print_selected_thread_frame):
6799 Update.
6800 * stack.c (print_frame, print_frame_info): Update.
6801 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6802 Update.
6803 * source.c (print_source_lines_base): Update.
6804 * skip.c (info_skip_command): Update.
6805 * record-btrace.c (btrace_ui_out_decode_error)
6806 (btrace_call_history_src_line): Update.
6807 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6808 Update.
6809 * progspace.c (print_program_space): Update.
6810 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6811 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6812 do_field_int. Change type of "value".
6813 * mi/mi-out.c (mi_ui_out::do_table_begin)
6814 (mi_ui_out::do_table_header): Update.
6815 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
6816 type of "value".
6817 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6818 (mi_cmd_data_list_changed_registers, output_register)
6819 (mi_cmd_data_read_memory, mi_load_progress)
6820 (mi_cmd_trace_frame_collected): Update.
6821 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6822 Update.
6823 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6824 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6825 (mi_cmd_var_list_children, varobj_update_one): Update.
6826 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6827 (mi_cmd_stack_list_args, list_arg_or_local): Update.
6828 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6829 * inferior.c (print_inferior): Update.
6830 * gdb_bfd.c (print_one_bfd): Update.
6831 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6832 Update.
6833 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6834 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6835 do_field_int. Change type of "value".
6836 * cli-out.c (cli_ui_out::do_field_signed): Rename from
6837 do_field_int. Change type of "value".
6838 * breakpoint.c (watchpoint_check, print_breakpoint_location)
6839 (print_one_breakpoint_location, print_it_catch_fork)
6840 (print_one_catch_fork, print_it_catch_vfork)
6841 (print_one_catch_vfork, print_it_catch_solib)
6842 (print_it_catch_exec, print_it_ranged_breakpoint)
6843 (print_mention_watchpoint, print_mention_masked_watchpoint)
6844 (bkpt_print_it, update_static_tracepoint): Update.
6845 * break-catch-throw.c (print_it_exception_catchpoint): Update.
6846 * break-catch-syscall.c (print_it_catch_syscall): Update.
6847 * ada-tasks.c (print_ada_task_info): Update.
6848 * ada-lang.c (print_it_exception, print_mention_exception):
6849 Update.
6850
6851 2019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
6852
6853 PR breakpoints/24541
6854 * gdbarch.c: Regenerate.
6855 * gdbarch.h: Regenerate.
6856 * gdbarch.sh: Adjust return type and parameter types for
6857 'stap_adjust_register'.
6858 (i386_stap_adjust_register): Adjust signature and return new
6859 register name.
6860 * stap-probe.c (stap_parse_register_operand): Adjust use of
6861 'gdbarch_stap_adjust_register'.
6862
6863 2019-07-17 Tom Tromey <tromey@adacore.com>
6864
6865 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
6866 declare VEC.
6867 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6868 std::vector.
6869 (struct s390_process_info): Add initializers.
6870 (s390_add_process): Use new.
6871 (s390_linux_nat_target::low_forget_process): Use delete.
6872 (s390_linux_nat_target::low_new_fork)
6873 (s390_linux_nat_target::stopped_by_watchpoint)
6874 (s390_linux_nat_target::low_prepare_to_resume)
6875 (s390_linux_nat_target::insert_watchpoint)
6876 (s390_linux_nat_target::insert_hw_breakpoint)
6877 (s390_linux_nat_target::remove_watchpoint)
6878 (s390_linux_nat_target::remove_hw_breakpoint): Update.
6879
6880 2019-07-16 John Baldwin <jhb@FreeBSD.org>
6881
6882 * aarch64-fbsd-nat.c: Include regcache.h.
6883 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6884 argument.
6885 (aarch64_fbsd_nat_target::fetch_registers)
6886 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6887 variable.
6888 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6889
6890 2019-07-16 John Baldwin <jhb@FreeBSD.org>
6891
6892 * fbsd-nat.c: Include gdbarch.h.
6893
6894 2019-07-15 Tom Tromey <tromey@adacore.com>
6895
6896 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6897
6898 2019-07-15 Tom Tromey <tromey@adacore.com>
6899
6900 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6901 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6902 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6903 * cli-out.c (cli_ui_out::do_field_int): New method.
6904 * ui-out.c (ui_out::field_unsigned): New method.
6905 * symfile.c (generic_load): Use field_unsigned.
6906 (print_transfer_performance): Likewise.
6907 * record-btrace.c (ui_out_field_uint): Remove.
6908 (btrace_call_history_insn_range, btrace_call_history): Use
6909 field_unsigned.
6910 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6911 field_unsigned.
6912 * ui-out.h (class ui_out) <field_unsigned>: New method.
6913 <do_field_unsigned>: Likewise.
6914
6915 2019-07-15 Tom Tromey <tromey@adacore.com>
6916
6917 * mi/mi-main.c (list_available_thread_groups): Use field_string.
6918 * mi/mi-interp.c (mi_memory_changed): Use field_string.
6919 * target.c (flash_erase_command): Use field_string.
6920 * infrun.c (print_signal_received_reason): Use field_string.
6921 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6922 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6923 field_string.
6924 * ada-tasks.c (print_ada_task_info): Use field_string.
6925
6926 2019-07-15 Tom Tromey <tromey@adacore.com>
6927
6928 * target.c (flash_erase_command): Use field_core_addr.
6929 * symfile.c (generic_load): Use field_core_addr.
6930 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6931 Use field_core_addr.
6932 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6933 field_core_addr.
6934
6935 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6936
6937 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6938 value if its desired type is smaller than a CORE_ADDR and signed.
6939
6940 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6941
6942 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6943 of changes to field names, and use new is_reference field to
6944 decide if a property is a reference or not.
6945 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6946 field.
6947 (struct dwarf2_property_baton): Update header comment, rename
6948 'referenced_type' to 'property_type' and update comments.
6949 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6950 default property type, store in property baton, update to take
6951 accound of renamed field.
6952 (read_func_scope): Update call to attr_to_dynamic_prop.
6953 (read_array_type): Likewise.
6954 (dwarf2_per_cu_addr_sized_int_type): New function.
6955 (read_subrange_index_type): Move type finding code to
6956 dwarf2_per_cu_addr_sized_int_type.
6957 (read_subrange_type): Update calls to attr_to_dynamic_prop.
6958 (dwarf2_per_cu_addr_type): New function.
6959 (set_die_type): Update calls to attr_to_dynamic_prop.
6960
6961 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6962
6963 * dwarf2read.c (read_subrange_index_type): New function.
6964 (read_subrange_type): Move code into new function and call it.
6965 * gdbtypes.c (create_range_type): Add some asserts.
6966
6967 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6968
6969 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6970 update return statements.
6971 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6972 declaration, and update comment to match.
6973 * gdbtypes.c (resolve_dynamic_array): Update call to
6974 dwarf2_evaluate_property to match new return type.
6975
6976 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6977
6978 * valarith.c (value_subscripted_rvalue): Change lowerbound
6979 parameter type from int to LONGEST.
6980 * value.h (value_subscripted_rvalue): Likewise in declaration.
6981
6982 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6983
6984 * cli/cli-utils.c (info_print_command_completer): New function.
6985 * cli/cli-utils.h: Add 'completer.h' include, and forward
6986 declaration for 'struct cmd_list_element'.
6987 (info_print_command_completer): Declare.
6988 * stack.c (_initialize_stack): Add completer for 'info locals' and
6989 'info args'.
6990 * symtab.c (_initialize_symtab): Add completer for 'info
6991 variables' and 'info functions'.
6992 * NEWS: Mention completion for additional info commands.
6993
6994 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6995
6996 * cli/cli-utils.c (extract_info_print_args): Delete.
6997 (extract_arg_maybe_quoted): Delete.
6998 (info_print_options_defs): New variable.
6999 (make_info_print_options_def_group): New function.
7000 (extract_info_print_options): Define new function.
7001 * cli/cli-utils.h (extract_info_print_args): Delete.
7002 (struct info_print_options): New structure.
7003 (extract_info_print_options): Declare new function.
7004 * stack.c (info_locals_command): Update to use new
7005 extract_info_print_options, also add a header comment.
7006 (info_args_command): Likewise.
7007 * symtab.c (info_variables_command): Likewise.
7008 (info_functions_command): Likewise.
7009
7010 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7011
7012 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7013 to extract string arguments.
7014 * common/common-utils.c (extract_string_maybe_quoted): New function.
7015 * common/common-utils.h (extract_string_maybe_quoted): Declare.
7016
7017 2019-07-11 Tom Tromey <tromey@adacore.com>
7018
7019 * main.c (get_init_files): Use GDBINIT, not gdbinit.
7020 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7021 * top.h (gdbinit): Don't declare.
7022 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7023 into...
7024 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
7025 * top.c (gdb_init): Don't call init_cli_cmds.
7026 (gdbinit): Remove.
7027 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7028
7029 2019-07-11 Tom Tromey <tromey@adacore.com>
7030
7031 * python/py-inferior.c (add_thread_object): Don't use thread_obj
7032 after it has been moved.
7033
7034 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7035
7036 * valops.c (value_must_coerce_to_target): Change return type to
7037 bool.
7038 * value.h (value_must_coerce_to_target): Likewise.
7039
7040 2019-07-10 Simon Marchi <simon.marchi@efficios.com>
7041
7042 * breakpoint.c (is_hardware_watchpoint): Remove
7043 forward-declaration.
7044 (is_masked_watchpoint): Change return type to bool.
7045 (is_tracepoint): Likewise.
7046 (is_breakpoint): Likewise.
7047 (is_hardware_watchpoint): Likewise.
7048 (is_watchpoint): Likewise.
7049 (is_no_memory_software_watchpoint): Likewise.
7050 (is_catchpoint): Likewise.
7051 (breakpoint_1): Make FILTER parameter's return type bool.
7052 is_masked_watchpoint): Change return type to bool.
7053 (save_breakpoints): Make FILTER parameter's return type bool.
7054 * breakpoint.h (is_breakpoint): Change return type to bool.
7055 (is_watchpoint): Likewise.
7056 (is_catchpoint): Likewise.
7057 (is_tracepoint): Likewise.
7058
7059 2019-07-10 Tom Tromey <tom@tromey.com>
7060
7061 * defs.h: Don't include gdbarch.h.
7062 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7063 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7064 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7065 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7066 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7067 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7068 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7069 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7070 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7071 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7072 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7073 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7074 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7075 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7076 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7077 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7078 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7079 record-btrace.c, record.h, regcache-dump.c, regcache.h,
7080 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7081 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7082 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7083 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7084 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7085 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7086 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7087 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7088 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7089
7090 2019-07-10 Tom Tromey <tromey@adacore.com>
7091
7092 * ada-lang.h (is_ada_exception_catchpoint): Declare.
7093 * breakpoint.c (init_ada_exception_breakpoint): Register as
7094 bp_catchpoint.
7095 (print_one_breakpoint_location, print_one_breakpoint): Use
7096 is_ada_exception_catchpoint.
7097 * ada-lang.c (class ada_catchpoint_location): Pass
7098 bp_loc_software_breakpoint to bp_location constructor.
7099 (is_ada_exception_catchpoint): New function.
7100
7101 2019-07-10 Tom Tromey <tromey@adacore.com>
7102
7103 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
7104 VEC.
7105 (struct arm_exidx_entry): New method operator<.
7106 (struct arm_exidx_data) <section_maps>: Change type.
7107 (arm_exidx_data_free): Remove.
7108 (arm_exidx_data_key): Change type. Move lower.
7109 (arm_exidx_new_objfile): Update.
7110 (arm_compare_exidx_entries): Remove.
7111 (arm_find_exidx_entry, _initialize_arm_tdep)
7112
7113 2019-07-10 Tom Tromey <tromey@adacore.com>
7114
7115 * solib-spu.c (ocl_program_data_key): Change type.
7116 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7117 Update.
7118
7119 2019-07-10 Tom Tromey <tromey@adacore.com>
7120
7121 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
7122 (struct solib_aix_inferior_data) <library_list>: Change type.
7123 (solib_aix_inferior_data_handle): Change type.
7124 (get_solib_aix_inferior_data): Update.
7125 (solib_aix_free_library_list): Remove.
7126 (library_list_start_library): Update.
7127 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7128 return type.
7129 (solib_aix_get_library_list)
7130 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7131 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7132
7133 2019-07-10 Tom Tromey <tromey@adacore.com>
7134
7135 * solib-dsbt.c (struct dsbt_info): Add initializers.
7136 (solib_dsbt_pspace_data): Change type.
7137 (dsbt_pspace_data_cleanup): Remove.
7138 (get_dsbt_info, _initialize_dsbt_solib): Update.
7139
7140 2019-07-10 Tom Tromey <tromey@adacore.com>
7141
7142 * spu-tdep.c (spu_overlay_data): Change type.
7143 (spu_get_overlay_table, spu_overlay_new_objfile)
7144 (_initialize_spu_tdep): Update.
7145
7146 2019-07-10 Tom Tromey <tromey@adacore.com>
7147
7148 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7149 destructor.
7150 (dbx_objfile_data_key): Change type and declare later.
7151 (DBX_SYMFILE_INFO): Rewrite.
7152 * dbxread.c (dbx_objfile_data_key): Change type.
7153 (dbx_symfile_init): Update.
7154 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7155 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7156 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7157
7158 2019-07-10 Tom Tromey <tromey@adacore.com>
7159
7160 * jit.c (jit_program_space_key): Change type. Move lower.
7161 (get_jit_program_space_data): Update.
7162 (jit_program_space_data_cleanup): Remove.
7163 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7164 Update.
7165 (struct jit_program_space_data): Add initializers.
7166
7167 2019-07-10 Tom Tromey <tromey@adacore.com>
7168
7169 * solib-darwin.c (struct darwin_info): Add initializers.
7170 (solib_darwin_pspace_data): Change type.
7171 (darwin_pspace_data_cleanup): Remove.
7172 (get_darwin_info, _initialize_darwin_solib): Update.
7173
7174 2019-07-10 Tom Tromey <tromey@adacore.com>
7175
7176 * remote-sim.c (struct sim_inferior_data): Add initializers,
7177 constructor, and destructor.
7178 (sim_inferior_data_key): Change type. Move lower.
7179 (check_for_duplicate_sim_descriptor): Update.
7180 (get_sim_inferior_data): Use new. Update.
7181 (~sim_inferior_data_cleanup): Rename from
7182 sim_inferior_data_cleanup. Simplify.
7183 (gdbsim_close_inferior, simulator_command)
7184 (sim_command_completer, _initialize_remote_sim): Update.
7185 (next_pid, INITIAL_PID): Move earlier.
7186
7187 2019-07-10 Tom Tromey <tromey@adacore.com>
7188
7189 * python/python-internal.h (create_thread_object): Return
7190 gdbpy_ref.
7191 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7192 * python/py-inferior.c (struct threadlist_entry): Add
7193 constructor.
7194 <thread_obj>: Now a gdbpy_ref.
7195 (thread_to_thread_object): Update.
7196 (add_thread_object): Use new.
7197 (delete_thread_object): Use delete.
7198 (infpy_threads): Update.
7199 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7200 GIL.
7201
7202 2019-07-10 Tom Tromey <tromey@adacore.com>
7203
7204 * valops.c (value_cast): Specialize error message for Ada.
7205
7206 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7207
7208 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7209
7210 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7211
7212 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7213 bpstat_should_step): Return bool, adjust comments.
7214 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7215 bpstat_should_step): Likewise.
7216
7217 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7218
7219 * features/Makefile: Use feature target descriptions for Arm.
7220 * features/arm/arm-core.c: Generate new file.
7221 * features/arm/arm-fpa.c: Likewise.
7222 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7223 * features/arm/arm-m-profile.c: Likewise.
7224 * features/arm/arm-vfpv2.c: Likewise.
7225 * features/arm/arm-vfpv3.c: Likewise.
7226 * features/arm/xscale-iwmmxt.c: Likewise.
7227 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7228
7229 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7230
7231 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7232 ptrace earlier.
7233
7234 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7235
7236 * features/aarch64-pauth.c: Regenerate.
7237
7238 2019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7239
7240 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7241 bool.
7242 (bpstat_what): Use false instead of 0.
7243
7244 2019-07-09 Pedro Alves <palves@redhat.com>
7245
7246 * break-catch-throw.c (is_exception_catchpoint): New.
7247 * breakpoint.c (print_one_breakpoint_location): New parameter
7248 'raw_loc'. Handle it. Use
7249 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7250 looking at the breakpoint's type.
7251 (print_one_breakpoint): If handling "maint info breakpoints", also
7252 print locations of exception catchpoints.
7253 * breakpoint.h (is_exception_catchpoint): Declare.
7254
7255 2019-07-09 Pedro Alves <palves@redhat.com>
7256
7257 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7258 "addr" field.
7259 (allocate_location_exception_catchpoint): New.
7260 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7261 (initialize_throw_catchpoint_ops): Install
7262 allocate_location_exception_catchpoint as allocate_location
7263 method.
7264 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7265 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7266 bp_loc_other.
7267 (breakpoint_address_is_meaningful): Delete.
7268 (bl_address_is_meaningful): New.
7269 (breakpoint_locations_match): Adjust comment.
7270 (bp_location_from_bp_type): New, factored out of...
7271 (bp_location::bp_location(breakpoint *)): ... this.
7272 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7273 factored out of...
7274 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7275 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7276 breakpoint_address_is_meaningful.
7277 (bp_locations_compare): Adjust comment.
7278 (update_global_location_list): Use bl_address_is_meaningful
7279 instead of breakpoint_address_is_meaningful.
7280 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7281 explicit.
7282 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7283 * python/py-breakpoint.c (bppy_get_location): No longer check
7284 whether location is null.
7285
7286 2019-07-09 Pedro Alves <palves@redhat.com>
7287
7288 PR c++/15468
7289 * breakpoint.c (print_one_breakpoint_location): Remove
7290 single-location assert.
7291
7292 2019-07-09 Tom Tromey <tom@tromey.com>
7293
7294 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7295 * configure: Rebuild.
7296 * configure.ac: Change common to gdbsupport.
7297 * gdbsupport: Rename from common.
7298 * acinclude.m4: Change common to gdbsupport.
7299 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7300 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7301 gdbsupport.
7302 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7303 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7304 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7305 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7306 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7307 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7308 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7309 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7310 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7311 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7312 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7313 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7314 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7315 coff-pe-read.c, command.h, compile/compile-c-support.c,
7316 compile/compile-c.h, compile/compile-cplus-symbols.c,
7317 compile/compile-cplus-types.c, compile/compile-cplus.h,
7318 compile/compile-loc2c.c, compile/compile.c, completer.c,
7319 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7320 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7321 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7322 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7323 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7324 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7325 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7326 features/aarch64-core.c, features/aarch64-fpu.c,
7327 features/aarch64-pauth.c, features/aarch64-sve.c,
7328 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7329 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7330 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7331 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7332 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7333 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7334 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7335 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7336 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7337 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7338 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7339 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7340 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7341 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7342 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7343 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7344 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7345 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7346 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7347 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7348 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7349 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7350 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7351 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7352 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7353 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7354 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7355 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7356 minsyms.c, mips-linux-tdep.c, namespace.h,
7357 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7358 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7359 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7360 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7361 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7362 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7363 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7364 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7365 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7366 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7367 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7368 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7369 procfs.c, producer.c, progspace.h, psymtab.h,
7370 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7371 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7372 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7373 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7374 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7375 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7376 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7377 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7378 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7379 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7380 target-memory.c, target.c, target.h, target/waitstatus.c,
7381 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7382 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7383 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7384 unittests/array-view-selftests.c,
7385 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7386 unittests/common-utils-selftests.c,
7387 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7388 unittests/format_pieces-selftests.c,
7389 unittests/function-view-selftests.c,
7390 unittests/lookup_name_info-selftests.c,
7391 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7392 unittests/mkdir-recursive-selftests.c,
7393 unittests/observable-selftests.c,
7394 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7395 unittests/parse-connection-spec-selftests.c,
7396 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7397 unittests/scoped_fd-selftests.c,
7398 unittests/scoped_mmap-selftests.c,
7399 unittests/scoped_restore-selftests.c,
7400 unittests/string_view-selftests.c, unittests/style-selftests.c,
7401 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7402 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7403 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7404 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7405 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7406 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7407
7408 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7409
7410 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7411 bool value.
7412 (decode_digits_ordinary): Set explicit_line field in sal.
7413 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7414 symtab_and_line that was set on an explicit line number in
7415 assembler code. Do always update the recorded symtab and line if
7416 we do skip the prologue.
7417
7418 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7419
7420 * breakpoint.c (set_breakpoint_location_function): Remove
7421 explicit_loc parameter.
7422 (momentary_breakpoint_from_master): Update call to
7423 set_breakpoint_location_function.
7424 (add_location_to_breakpoint): Likewise.
7425
7426 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7427
7428 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7429 required features based on default bfd type when no specific bfd
7430 is present.
7431
7432 2019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7433
7434 * NEWS: Mention that GDB printf and eval commands can now print
7435 C-style and Ada-style convenience var strings without
7436 calling the inferior.
7437 * printcmd.c (printf_c_string): Locally print GDB internal var
7438 instead of transiting via the inferior.
7439 (printf_wide_c_string): Likewise.
7440
7441 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7442
7443 PR breakpoints/25011
7444 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7445
7446 2019-07-04 Tom Tromey <tom@tromey.com>
7447
7448 PR tui/24724:
7449 * tui/tui-winsource.c (tui_clear_source_content): Update.
7450 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7451 (tui_update_breakpoint_info): Update.
7452 (tui_set_exec_info_content): Update.
7453 * tui/tui-source.c (tui_set_source_content_nil): Update.
7454 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7455 has_break.
7456 * tui/tui-data.h (enum tui_bp_flag): New.
7457 (tui_bp_flags): New enum flags type.
7458 (struct tui_source_element) <break_mode>: Change type. Rename
7459 from has_break.
7460 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7461 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7462 constants.
7463 * tui/tui-winsource.h: Fix comment.
7464
7465 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7466
7467 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7468 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7469 (store_fpregs_to_thread)
7470 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7471 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7472 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7473 (IWMMXT_REGS_SIZE): Add define.
7474 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7475 (fetch_vfp_regs, store_vfp_regs)
7476 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7477 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7478
7479 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7480
7481 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7482 defines.
7483 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7484 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7485 (ARM_INT_REGISTER_SIZE): ...to this.
7486 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7487 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7488 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7489 (arm_linux_collect_gregset, supply_nwfpe_register)
7490 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7491 defines.
7492 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7493 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7494 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7495 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7496 (arm_return_in_memory, arm_store_return_value)
7497 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7498 (arm_record_ld_st_multiple): Likewise.
7499 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7500 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7501
7502 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7503
7504 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7505 AARCH64_DISPLACED_MODIFIED_INSNS.
7506 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7507 (aarch64_displaced_step_copy_insn): Likewise.
7508 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7509 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7510 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7511 ARM_DISPLACED_MODIFIED_INSNS.
7512 * arm-tdep.c (arm_gdbarch_init): Likewise.
7513 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7514 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7515 (struct arm_displaced_step_closure): Use
7516 ARM_DISPLACED_MODIFIED_INSNS.
7517
7518 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7519
7520 * features/Makefile: Remove unused xml files.
7521 * features/aarch64.xml: Remove.
7522 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7523 * features/i386/amd64-avx-avx512.xml: Remove.
7524 * features/i386/amd64-avx-linux.xml: Remove.
7525 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7526 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7527 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7528 * features/i386/amd64-avx-mpx.xml: Remove.
7529 * features/i386/amd64-avx.xml: Remove.
7530 * features/i386/amd64-linux.xml: Remove.
7531 * features/i386/amd64-mpx-linux.xml: Remove.
7532 * features/i386/amd64-mpx.xml: Remove.
7533 * features/i386/amd64.xml: Remove.
7534 * features/i386/i386-avx-avx512-linux.xml: Remove.
7535 * features/i386/i386-avx-avx512.xml: Remove.
7536 * features/i386/i386-avx-linux.xml: Remove.
7537 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7538 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7539 * features/i386/i386-avx-mpx-linux.xml: Remove.
7540 * features/i386/i386-avx-mpx.xml: Remove.
7541 * features/i386/i386-avx.xml: Remove.
7542 * features/i386/i386-linux.xml: Remove.
7543 * features/i386/i386-mmx-linux.xml: Remove.
7544 * features/i386/i386-mmx.xml: Remove.
7545 * features/i386/i386-mpx-linux.xml: Remove.
7546 * features/i386/i386-mpx.xml: Remove.
7547 * features/i386/i386.xml: Remove.
7548 * features/i386/x32-avx-avx512-linux.xml: Remove.
7549 * features/i386/x32-avx-linux.xml: Remove.
7550 * features/i386/x32-linux.xml: Remove.
7551
7552 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7553
7554 * regformats/aarch64.dat: Remove.
7555 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7556 * regformats/i386/amd64-avx-linux.dat: Remove.
7557 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7558 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7559 * regformats/i386/amd64-linux.dat: Remove.
7560 * regformats/i386/amd64-mpx-linux.dat: Remove.
7561 * regformats/i386/amd64.dat: Remove.
7562 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7563 * regformats/i386/i386-avx-linux.dat: Remove.
7564 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7565 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7566 * regformats/i386/i386-linux.dat: Remove.
7567 * regformats/i386/i386-mmx-linux.dat: Remove.
7568 * regformats/i386/i386-mpx-linux.dat: Remove.
7569 * regformats/i386/i386.dat: Remove.
7570 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7571 * regformats/i386/x32-avx-linux.dat: Remove.
7572 * regformats/i386/x32-linux.dat: Remove.
7573
7574 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7575
7576 * aarch64-tdep.c: Remove xml self tests.
7577 * amd64-linux-tdep.c: Likewise.
7578 * amd64-tdep.c: Likewise.
7579 * i386-linux-tdep.c: Likewise.
7580 * i386-tdep.c: Likewise.
7581
7582 2019-07-03 Pedro Alves <palves@redhat.com>
7583
7584 PR cli/24732
7585 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7586 (pipe_cmd_option_defs): New.
7587 (make_pipe_cmd_options_def_group): New.
7588 (pipe_command): Use gdb::option::process_options.
7589 (pipe_command_completer): New function.
7590 (_initialize_cli_cmds): Install completer for "pipe" command.
7591
7592 2019-07-03 Pedro Alves <palves@redhat.com>
7593
7594 * cli/cli-option.c (union option_value) <string>: New field.
7595 (struct option_def_and_value): Add ctor, move ctor, dtor and
7596 use DISABLE_COPY_AND_ASSIGN.
7597 (option_def_and_value::clear_value): New.
7598 (parse_option, save_option_value_in_ctx, get_val_type_str)
7599 (add_setshow_cmds_for_options): Handle var_string.
7600 * cli-option.h (union option_def::var_address) <string>: New
7601 field.
7602 (struct string_option_def): New.
7603 * maint-test-options.c (struct test_options_opts): Add default
7604 ctor and use DISABLE_COPY_AND_ASSIGN.
7605 <string_opt>: New field.
7606 (test_options_opts::~test_options_opts): New.
7607 (test_options_opts::dump): Also dump "-string".
7608 (test_options_option_defs): Install "string.
7609
7610 2019-07-03 Pedro Alves <palves@redhat.com>
7611
7612 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7613 option_value with a null enumeration.
7614 (complete_options): Save the option values in the context.
7615 (save_option_value_in_ctx): New, factored out from ...
7616 (process_options): ... here.
7617 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7618 of the function.
7619 * maint-test-options.c (test_options_opts::dump): New, factored
7620 out from ...
7621 (maintenance_test_options_command_mode): ... here.
7622 (maintenance_test_options_command_completion_result): Delete.
7623 (maintenance_test_options_command_completion_text): Update
7624 comment.
7625 (maintenance_show_test_options_completion_result): Change
7626 prototype. Just print
7627 maintenance_test_options_command_completion_text.
7628 (save_completion_result): New.
7629 (maintenance_test_options_completer_mode): Pass options context to
7630 complete_options, and then save a dump.
7631 (_initialize_maint_test_options): Use add_cmd to install "maint
7632 show test-options-completion-result".
7633
7634 2019-07-03 Pedro Alves <palves@redhat.com>
7635
7636 * NEWS (New commands): Mention "with" and "maint with".
7637 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7638 (with_command, with_command_completer): New.
7639 (pipe_command): Adjust to new repeat_previous
7640 interface.
7641 (_initialize_cli_cmds): Install the "with" command and its "w"
7642 alias.
7643 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7644 declarations.
7645 * cli/cli-setshow.c (parse_cli_var_uinteger)
7646 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7647 argument strings for all var_types.
7648 (get_setshow_command_value_string): New, factored out from ...
7649 (do_show_command): ... this.
7650 * cli/cli-setshow.h: Include <string>.
7651 (get_setshow_command_value_string): Declare.
7652 * command.h (repeat_previous): Now returns const char *. Adjust
7653 comment.
7654 * maint.c: Include "cli/cli-cmds.h".
7655 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7656 (_initialize_maint_cmds): Register the "maintenance with" command.
7657 * top.c (repeat_previous): Move bits from pipe_command here:
7658 Return the saved command line, if any; error out if there's no
7659 command to relaunch.
7660
7661 2019-07-03 Pedro Alves <palves@redhat.com>
7662
7663 * NEWS (New commands): Mention "maint set/show test-settings"
7664 instead of "maint test-settings".
7665 * maint-test-settings.c (maintenance_test_settings_list): Delete.
7666 (maintenance_test_settings_set_list): Rename to ...
7667 (maintenance_set_test_settings_list): ... this.
7668 (maintenance_test_settings_show_list): Rename to ...
7669 (maintenance_show_test_settings_list): ... this.
7670 (maintenance_test_settings_cmd): Delete.
7671 (maintenance_test_settings_set_cmd): ...
7672 (maintenance_set_test_settings_cmd): ... this.
7673 (maintenance_test_settings_show_cmd): ...
7674 (maintenance_show_test_settings_cmd): ... this.
7675 (maintenance_test_settings_show_value_cmd):
7676 (maintenance_show_test_settings_value_cmd): ... this.
7677 (_initialize_maint_test_settings): No longer install the "maint
7678 test-settings" prefix command. Rename "maint test-settings set"
7679 to "maint set test-settings", and "maint test-settings show" to
7680 "maint show test-settings". Adjust all subcommands.
7681
7682 2019-07-03 Pedro Alves <palves@redhat.com>
7683
7684 * maint-test-settings.c: Fix file's intro comment. Replace all
7685 references to "test-options" with references to "test-settings",
7686 in comments.
7687
7688 2019-07-03 Pedro Alves <palves@redhat.com>
7689
7690 * maint-test-settings.c (maintenance_test_settings_xxx)
7691 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7692 New.
7693 (maintenance_test_settings_enums): Use them.
7694 (maintenance_test_settings_enum): Default to
7695 maintenance_test_settings_xxx.
7696 (_initialize_maint_test_settings): Initialize
7697 MAINTENANCE_TEST_SETTINGS_FILENAME.
7698
7699 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7700
7701 * breakpoint.h (remove_breakpoints_inf): Change return type to
7702 void, move function documentation here.
7703 * breakpoint.c (remove_breakpoints_inf): Change return type to
7704 void, move function documentation to header.
7705
7706 2019-07-02 Pedro Alves <palves@redhat.com>
7707
7708 * NEWS (Completion improvements): Mention "info threads".
7709 * thread.c (struct info_threads_opts, info_threads_option_defs)
7710 (make_info_threads_options_def_group): New.
7711 (info_threads_command): Use gdb::option::process_options.
7712 (info_threads_command_completer): New.
7713 (_initialize_thread): Use gdb::option::build_help to build the
7714 help text for "info threads".
7715
7716 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7717
7718 * defs.h (generic_load): Move from here...
7719 * symfile.h (generic_load): ... to here. Rename name parameter
7720 to args.
7721 * symfile.c (generic_load): Add comment.
7722
7723 2019-07-01 Tom Tromey <tromey@adacore.com>
7724
7725 * dwarf2read.c
7726 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7727 declaration of without_params. Fix formatting.
7728
7729 2019-07-01 Tom Tromey <tromey@adacore.com>
7730
7731 * ada-exp.y (find_primitive_type): Update.
7732 * ada-lang.h (ada_lookup_symbol): Update.
7733 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7734 parameter.
7735 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7736
7737 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7738
7739 PR breakpoints/24541
7740 * gdbarch.c: Regenerate.
7741 * gdbarch.h: Regenerate.
7742 * gdbarch.sh: Add 'stap_adjust_register'.
7743 * i386-tdep.c: Include '<unordered_set>'.
7744 (i386_stap_adjust_register): New function.
7745 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7746 * stap-probe.c (stap_parse_register_operand): Call
7747 'gdbarch_stap_adjust_register'.
7748
7749 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7750
7751 PR python/24742
7752 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7753 * python/python.c (do_start_initialization): Use 'xmalloc'
7754 instead of 'PyMem_Malloc'.
7755
7756 2019-06-28 Tom Tromey <tromey@adacore.com>
7757
7758 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7759 for Ada.
7760
7761 2019-06-27 Tom Tromey <tromey@adacore.com>
7762
7763 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
7764 objfile_key.
7765 (arm_find_mapping_symbol, arm_record_special_symbol)
7766 (_initialize_arm_tdep): Update.
7767 (arm_objfile_data_free): Remove.
7768
7769 2019-06-27 Tom Tromey <tromey@adacore.com>
7770
7771 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7772 to cp_print_static_field.
7773
7774 2019-06-26 Tom Tromey <tromey@adacore.com>
7775
7776 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7777 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7778 declare.
7779
7780 2019-06-26 Alan Hayward <alan.hayward@arm.com>
7781
7782 * features/aarch64-core.c (create_feature_aarch64_core):
7783 Regenerate.
7784 * features/aarch64-core.xml: Add cpsr flags.
7785
7786 2019-06-26 Alan Hayward <alan.hayward@arm.com>
7787
7788 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7789 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7790
7791 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7792
7793 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7794 field.
7795 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7796 use.
7797 (arm_record_special_symbol): Don't insert new symbol in sorted
7798 position, push it at the end.
7799
7800 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7801
7802 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7803 (arm_mapping_symbol_s): Remove.
7804 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7805 (arm_mapping_symbol_vec): New typedef.
7806 (struct arm_per_objfile): Add constructor.
7807 <section_maps>: Change type to
7808 std::unique_ptr<arm_mapping_symbol_vec[]>.
7809 (arm_compare_mapping_symbols): Remove.
7810 (arm_find_mapping_symbol): Adjust to section_maps type change.
7811 (arm_objfile_data_free): Call delete on arm_per_objfile.
7812 (arm_record_special_symbol): Adjust to section_maps type change.
7813 Allocate arm_per_objfile with new.
7814
7815 2019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7816
7817 * cli/cli-cmds.c (alias_command): Compare the alias prefix
7818 with the command prefix.
7819
7820 2019-06-25 Tom Tromey <tom@tromey.com>
7821
7822 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7823 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7824
7825 2019-06-25 Tom Tromey <tom@tromey.com>
7826
7827 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7828 type.
7829 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7830 protected.
7831
7832 2019-06-25 Tom Tromey <tom@tromey.com>
7833
7834 * tui/tui-winsource.c
7835 (tui_source_window_base::set_is_exec_point_at): Add check against
7836 LOA_ADDRESS.
7837
7838 2019-06-25 Tom Tromey <tom@tromey.com>
7839
7840 * tui/tui-source.c (tui_set_source_content): Don't check before
7841 xfree.
7842 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7843
7844 2019-06-25 Tom Tromey <tom@tromey.com>
7845
7846 * tui/tui-winsource.h (tui_update_source_window_as_is)
7847 (tui_alloc_source_buffer, tui_line_is_displayed)
7848 (tui_addr_is_displayed): Change type of win_info.
7849 * tui/tui-winsource.c (tui_update_source_window_as_is)
7850 (tui_clear_source_content, tui_show_source_line)
7851 (tui_show_source_content, tui_source_window_base::refill)
7852 (tui_source_window_base::set_is_exec_point_at)
7853 (tui_source_window_base::set_is_exec_point_at)
7854 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7855 (tui_alloc_source_buffer, tui_line_is_displayed)
7856 (tui_addr_is_displayed): Change type of win_info. Update.
7857 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7858 (tui_source_window_base::do_make_visible_with_new_height):
7859 Update.
7860 * tui/tui-source.c (tui_set_source_content)
7861 (tui_set_source_content_nil)
7862 (tui_source_window::do_scroll_vertical): Update.
7863 * tui/tui-layout.c (show_layout): Update.
7864 * tui/tui-disasm.c (tui_set_disassem_content)
7865 (tui_disasm_window::do_scroll_vertical): Update.
7866 * tui/tui-data.h (tui_win_content): Remove.
7867 (struct tui_gen_win_info) <content, content_size>: Remove.
7868 (struct tui_source_element): Add initializers and destructor.
7869 (union tui_which_element, struct tui_win_element): Remove.
7870 (struct tui_source_window_base) <content>: New field.
7871 (struct tui_data_window): Remove destructor.
7872 (tui_alloc_content, tui_free_win_content)
7873 (tui_free_all_source_wins_content): Don't declare.
7874 * tui/tui-data.c (tui_initialize_static_data): Update.
7875 (init_content_element, tui_alloc_content): Remove.
7876 (~tui_gen_win_info): Update.
7877 (~tui_data_window, tui_free_all_source_wins_content)
7878 (tui_free_win_content, free_content, free_content_elements):
7879 Remove.
7880
7881 2019-06-25 Tom Tromey <tom@tromey.com>
7882
7883 * tui/tui-winsource.h (tui_clear_source_content)
7884 (tui_erase_source_content, tui_show_source_content): Change type
7885 of win_info.
7886 * tui/tui-winsource.c (tui_clear_source_content)
7887 (tui_erase_source_content, tui_show_source_content): Change type
7888 of win_info.
7889 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7890 * tui/tui-source.h (tui_set_source_content_nil): Change type of
7891 win_info.
7892 * tui/tui-source.c (tui_set_source_content_nil): Change type of
7893 win_info.
7894 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7895
7896 2019-06-25 Tom Tromey <tom@tromey.com>
7897
7898 * tui/tui-winsource.c (tui_clear_source_content)
7899 (tui_source_window_base::set_is_exec_point_at): Update.
7900 * tui/tui-source.c (tui_set_source_content_nil): Update.
7901 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7902 a bool.
7903 * tui/tui-data.c (init_content_element): Update.
7904
7905 2019-06-25 Tom Tromey <tom@tromey.com>
7906
7907 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7908 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7909 * tui/tui-layout.c (init_and_make_win): Update.
7910 * tui/tui.h (enum tui_win_type): Update.
7911 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7912 tui_win_is_auxillary.
7913 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7914 tui_win_is_auxillary.
7915
7916 2019-06-25 Tom Tromey <tom@tromey.com>
7917
7918 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7919 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7920 (tui_delete_data_content_windows, tui_display_all_data)
7921 (tui_data_window::do_scroll_vertical, tui_display_data_from):
7922 Update.
7923 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7924 * tui/tui-regs.c (tui_last_regs_line_no)
7925 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7926 (tui_show_registers): Update.
7927 (tui_show_register_group): Return void. Update.
7928 (tui_display_registers_from, tui_display_reg_element_at_line)
7929 (tui_display_registers_from_line, tui_check_register_values):
7930 Update.
7931 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7932 member.
7933 (struct tui_data_window) <regs_content>: Now a std::vector.
7934 <regs_content_count>: Remove.
7935 (tui_add_content_elements, tui_free_data_content): Don't declare.
7936 * tui/tui-data.c (tui_data_window::clear_detail): Update.
7937 (init_content_element): Remove DATA_WIN case. Add assert.
7938 (tui_add_content_elements): Remove.
7939 (tui_data_window): Update.
7940 (tui_free_data_content): Remove.
7941 (free_content_elements): Remove DATA_WIN case.
7942
7943 2019-06-25 Tom Tromey <tom@tromey.com>
7944
7945 * tui/tui-data.c (tui_data_item_window): Update.
7946 * tui/tui-windata.h (tui_check_data_values): Don't declare.
7947 * tui/tui-windata.c (tui_display_all_data)
7948 (tui_display_data_from_line): Update.
7949 (tui_check_data_values): Remove.
7950 * tui/tui-regs.c (tui_show_register_group)
7951 (tui_display_reg_element_at_line): Update.
7952 * tui/tui-hooks.c (tui_register_changed)
7953 (tui_refresh_frame_and_register_information): Call
7954 tui_check_register_values.
7955 * tui/tui-data.h (struct tui_data_window) <data_content,
7956 data_content_count, data_type>: Remove.
7957 (enum tui_data_type): Remove.
7958
7959 * tui/tui-data.c (tui_data_window::clear_detail)
7960 (~tui_data_window): Update.
7961
7962 2019-06-25 Tom Tromey <tom@tromey.com>
7963
7964 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7965 declare.
7966 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7967 Rename from tui_first_data_item_displayed. Update.
7968 (tui_data_window::refresh_all)
7969 (tui_data_window::do_scroll_vertical): Update.
7970 * tui/tui-data.h (struct tui_data_window)
7971 <first_data_item_displayed>: Declare new method.
7972
7973 2019-06-25 Tom Tromey <tom@tromey.com>
7974
7975 * tui/tui-data.h (tui_init_generic_part): Don't declare.
7976 * tui/tui-data.c (tui_init_generic_part): Remove, moving
7977 contents...
7978 (tui_initialize_static_data): ...here.
7979
7980 2019-06-25 Tom Tromey <tom@tromey.com>
7981
7982 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7983 (tui_display_registers_from, tui_check_register_values): Update.
7984 (tui_display_register): Remove win_info parameter; update.
7985 (tui_get_register): Change type of parameters.
7986 * tui/tui-data.h (struct tui_data_element): Remove.
7987 (union tui_which_element) <data>: Remove.
7988 <data_window>: Change type.
7989 (struct tui_data_item_window): New.
7990 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7991 case. Add assert.
7992 (~tui_data_item_window): New destructor.
7993 (free_content_elements): Remove DATA_ITEM_WIN case.
7994
7995 2019-06-25 Tom Tromey <tom@tromey.com>
7996
7997 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7998 Remove.
7999
8000 2019-06-25 Tom Tromey <tom@tromey.com>
8001
8002 * tui/tui-data.h (struct tui_command_element): Remove.
8003 (union tui_which_element) <command>: Remove.
8004 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
8005 assert.
8006 (free_content_elements): Remove CMD_WIN case.
8007
8008 2019-06-25 Tom Tromey <tom@tromey.com>
8009
8010 * tui/tui-layout.c (tui_set_layout): Update.
8011 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8012 * tui/tui-data.c (layout_def): Update.
8013
8014 2019-06-25 Tom Tromey <tom@tromey.com>
8015
8016 * tui/tui-wingeneral.c (tui_refresh_all): Update.
8017 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8018 (tui_source_window_base::set_new_height): Update.
8019 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8020 Update.
8021 (tui_set_locator_fullname, tui_set_locator_info)
8022 (tui_show_frame_info): Update.
8023 * tui/tui-source.c (tui_set_source_content)
8024 (tui_source_is_displayed): Update.
8025 * tui/tui-layout.c (show_source_disasm_command, show_data)
8026 (show_source_or_disasm_and_command): Update.
8027 * tui/tui-disasm.c (tui_set_disassem_content)
8028 (tui_get_begin_asm_address): Update.
8029 * tui/tui-data.h (struct tui_locator_element): Remove.
8030 (union tui_which_element) <locator>: Remove.
8031 (struct tui_locator_window): New.
8032 (tui_locator_win_info_ptr): Change return type.
8033 * tui/tui-data.c (_locator): Change type.
8034 (tui_locator_win_info_ptr): Change return type.
8035 (init_content_element): Remove LOCATOR_WIN case. Add assert.
8036 (tui_alloc_content): Add assert.
8037
8038 2019-06-25 Tom Tromey <tom@tromey.com>
8039
8040 * tui/tui-winsource.c
8041 (tui_exec_info_window::maybe_allocate_content): New method.
8042 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8043 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8044 (make_source_or_disasm_window): Add cast.
8045 * tui/tui-data.h (union tui_which_element) <simple_string>:
8046 Remove.
8047 (struct tui_source_info): New.
8048 (struct tui_source_window_base) <execution_info>: Change type.
8049 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8050 case, and add assert.
8051 (tui_alloc_content): Add assert.
8052
8053 2019-06-25 Tom Tromey <tom@tromey.com>
8054
8055 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8056 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8057 * tui/tui-data.c (tui_alloc_win_info): Remove.
8058
8059 2019-06-25 Tom Tromey <tom@tromey.com>
8060
8061 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8062 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8063 can_highlight.
8064
8065 2019-06-25 Tom Tromey <tom@tromey.com>
8066
8067 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8068 make_visible_with_new_height method.
8069 (tui_win_info::make_visible_with_new_height): New method.
8070 (tui_source_window_base::do_make_visible_with_new_height)
8071 (tui_data_window::do_make_visible_with_new_height)
8072 (tui_cmd_window::do_make_visible_with_new_height): New methods.
8073 (make_visible_with_new_height): Remove.
8074 (tui_resize_all, tui_adjust_win_heights): Use
8075 make_visible_with_new_height method.
8076 * tui/tui-data.h (struct tui_win_info)
8077 <do_make_visible_with_new_height, make_visible_with_new_height>:
8078 New methods.
8079 (struct tui_source_window_base, struct tui_data_window)
8080 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8081 methods.
8082
8083 2019-06-25 Tom Tromey <tom@tromey.com>
8084
8085 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8086 method.
8087 (update_tab_width): Call update_tab_width method.
8088 * tui/tui-data.h (struct tui_win_info)
8089 (struct tui_source_window_base) <update_tab_width>: New methods.
8090
8091 2019-06-25 Tom Tromey <tom@tromey.com>
8092
8093 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8094 parameter.
8095 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8096 parameter.
8097 (tui_gen_win_info::make_visible): Update.
8098 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8099 parameter.
8100 * tui/tui-data.h (enum tui_box): New enum.
8101 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8102
8103 2019-06-25 Tom Tromey <tom@tromey.com>
8104
8105 * tui/tui-layout.c (make_source_or_disasm_window): Always use
8106 init_and_make_win for EXEC_INFO_WIN.
8107 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8108 longer inline.
8109 (struct tui_win_info) <~tui_win_info>: Inline.
8110 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8111 Don't declare.
8112 * tui/tui-data.c (source_win, disasm_win): Remove globals.
8113 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8114 Remove.
8115 (tui_initialize_static_data): Update.
8116 (~tui_gen_win_info): Handle more cleanup here.
8117 (~tui_source_window_base): Delete "execution_info".
8118 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8119
8120 2019-06-25 Tom Tromey <tom@tromey.com>
8121
8122 * tui/tui-layout.c (make_command_window): Don't set
8123 can_highlight.
8124 (show_source_disasm_command): Call the reset method.
8125 (show_data): Don't set can_highlight. Call the reset method.
8126 (tui_gen_win_info::reset): Rename from init_gen_win_info
8127 (init_and_make_win): Simplify. Return tui_gen_win_info.
8128 (show_source_or_disasm_and_command): Call the reset method.
8129 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8130 (struct tui_cmd_window): Set can_highlight.
8131
8132 2019-06-25 Tom Tromey <tom@tromey.com>
8133
8134 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8135 from make_visible.
8136 (tui_make_visible, tui_make_invisible): Rewrite.
8137 (tui_win_info::make_visible): Remove.
8138 (tui_source_window_base::make_visible): Update.
8139 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8140 method. Moved from...
8141 (struct tui_win_info) <make_visible>: ...here.
8142
8143 2019-06-25 Tom Tromey <tom@tromey.com>
8144
8145 * tui/tui-winsource.c
8146 (tui_source_window_base::do_scroll_horizontal): Remove direction
8147 parameter.
8148 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8149 direction parameter.
8150 * tui/tui-win.c (tui_win_info::forward_scroll)
8151 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8152 (tui_win_info::right_scroll): Update.
8153 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8154 direction parameter.
8155 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8156 direction parameter.
8157 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8158 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8159 Remove direction parameter.
8160 (struct tui_source_window_base, struct tui_source_window)
8161 (struct tui_disasm_window, struct tui_data_window)
8162 (struct tui_cmd_window): Update.
8163
8164 2019-06-25 Tom Tromey <tom@tromey.com>
8165
8166 * tui/tui-winsource.h (tui_set_exec_info_content)
8167 (tui_show_exec_info_content, tui_erase_exec_info_content)
8168 (tui_clear_exec_info_content, tui_update_exec_info): Change
8169 argument to tui_source_window_base.
8170 * tui/tui-winsource.c (tui_set_exec_info_content)
8171 (tui_show_exec_info_content, tui_erase_exec_info_content)
8172 (tui_clear_exec_info_content, tui_update_exec_info): Change
8173 argument to tui_source_window_base.
8174
8175 2019-06-25 Tom Tromey <tom@tromey.com>
8176
8177 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8178 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8179
8180 2019-06-25 Tom Tromey <tom@tromey.com>
8181
8182 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8183 check.
8184
8185 2019-06-25 Tom Tromey <tom@tromey.com>
8186
8187 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8188 type to void.
8189 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8190 type to void.
8191 * tui/tui-source.c (tui_set_source_content): Update.
8192 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8193
8194 2019-06-25 Tom Tromey <tom@tromey.com>
8195
8196 * tui/tui-win.c (window_name_completer, tui_set_focus)
8197 (tui_all_windows_info): Use name method.
8198 * tui/tui-data.h (struct tui_gen_win_info)
8199 (struct tui_source_window, struct tui_disasm_window)
8200 (struct tui_data_window, struct tui_cmd_window) <name>: New
8201 method.
8202 (tui_win_name): Don't declare.
8203 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8204 (tui_win_name): Remove.
8205
8206 2019-06-25 Tom Tromey <tom@tromey.com>
8207
8208 * tui/tui-winsource.h (tui_update_source_window)
8209 (tui_update_source_window_as_is): Change parameter type.
8210 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8211 to be a tui_source_window_base.
8212 (tui_update_source_window_as_is): Likewise.
8213 * tui/tui-win.c (make_visible_with_new_height): Update.
8214
8215 2019-06-25 Tom Tromey <tom@tromey.com>
8216
8217 * tui/tui-winsource.c (tui_erase_source_content)
8218 (tui_show_source_content, tui_show_exec_info_content)
8219 (tui_erase_exec_info_content): Use refresh_window method.
8220 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8221 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8222 from tui_refresh_win.
8223 (tui_data_window::refresh_window): New method.
8224 (tui_win_info::refresh, tui_source_window_base::refresh)
8225 (tui_refresh_all): Use refresh_window method.
8226 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8227 method.
8228 * tui/tui-regs.c (tui_display_register): Call refresh_window
8229 method.
8230 * tui/tui-layout.c (show_source_disasm_command)
8231 (show_source_or_disasm_and_command): Call refresh_window method.
8232 * tui/tui-data.h (struct tui_gen_win_info)
8233 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8234 New method.
8235
8236 2019-06-25 Tom Tromey <tom@tromey.com>
8237
8238 * tui/tui.c (tui_rl_other_window, tui_enable)
8239 (tui_is_window_visible, tui_get_command_dimension): Update.
8240 * tui/tui-winsource.c (tui_update_source_window_as_is)
8241 (tui_clear_source_content, tui_erase_source_content)
8242 (tui_show_source_line, tui_source_window_base::refill)
8243 (tui_source_window_base::do_scroll_horizontal)
8244 (tui_source_window_base::set_is_exec_point_at)
8245 (tui_update_breakpoint_info, tui_set_exec_info_content)
8246 (tui_alloc_source_buffer, tui_line_is_displayed)
8247 (tui_addr_is_displayed): Update.
8248 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8249 (tui_check_and_display_highlight_if_needed)
8250 (tui_win_info::make_visible, tui_win_info::refresh)
8251 (tui_refresh_all): Update.
8252 * tui/tui-windata.c (tui_first_data_item_displayed)
8253 (tui_delete_data_content_windows, tui_erase_data_content)
8254 (tui_display_all_data, tui_data_window::refresh_all)
8255 (tui_check_data_values): Update.
8256 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8257 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8258 (tui_win_info::backward_scroll, tui_refresh_all_win)
8259 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8260 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8261 (tui_source_window_base::set_new_height)
8262 (tui_data_window::set_new_height)
8263 (make_invisible_and_set_new_height)
8264 (make_visible_with_new_height, new_height_ok)
8265 (parse_scrolling_args): Update.
8266 * tui/tui-stack.c (tui_show_frame_info): Update.
8267 * tui/tui-source.c (tui_set_source_content)
8268 (tui_set_source_content_nil, tui_source_is_displayed)
8269 (tui_source_window::do_scroll_vertical): Update.
8270 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8271 (tui_display_registers_from, tui_display_reg_element_at_line)
8272 (tui_check_register_values, tui_reg_command): Update.
8273 * tui/tui-layout.c (tui_default_win_height)
8274 (show_source_disasm_command, show_data, init_and_make_win)
8275 (show_source_or_disasm_and_command): Update.
8276 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8277 (tui_redisplay_readline, tui_mld_flush)
8278 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8279 (tui_getc): Update.
8280 * tui/tui-disasm.c (tui_set_disassem_content)
8281 (tui_disasm_window::do_scroll_vertical): Update.
8282 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8283 Now virtual.
8284 (struct tui_win_info): Derive from tui_gen_win_info.
8285 <~tui_win_info>: Mark as override.
8286 <generic>: Remove member.
8287 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8288 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8289 (~tui_data_window, ~tui_win_info)
8290 (tui_free_all_source_wins_content): Update.
8291 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8292
8293 2019-06-25 Tom Tromey <tom@tromey.com>
8294
8295 * tui/tui-layout.c (init_and_make_win): Use new.
8296 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8297 destructor, initializers.
8298 (tui_alloc_generic_win_info): Don't declare.
8299 * tui/tui-data.c (_locator): Add argument to constructor.
8300 (source_win, disasm_win): New globals.
8301 (exec_info): Remove.
8302 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8303 Update.
8304 (tui_alloc_generic_win_info): Remove.
8305 (init_content_element): Use new.
8306 (tui_win_info::tui_win_info): Update.
8307 (free_content_elements) <case DATA_WIN>: Use delete.
8308
8309 2019-06-25 Tom Tromey <tom@tromey.com>
8310
8311 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8312 * tui/tui-windata.c (tui_first_data_item_displayed)
8313 (tui_delete_data_content_windows): Update.
8314 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8315 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8316 (tui_display_registers_from, tui_check_register_values): Update.
8317 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8318 pointer.
8319 * tui/tui-data.c (init_content_element): Update. Allocate the new
8320 window.
8321 (tui_free_data_content): Update.
8322 (free_content_elements) <case DATA_WIN>: Free the window.
8323
8324 2019-06-25 Tom Tromey <tom@tromey.com>
8325
8326 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8327 Update.
8328 * tui/tui-layout.c (make_command_window)
8329 (show_source_disasm_command, show_data, init_and_make_win)
8330 (show_source_or_disasm_and_command): Update.
8331 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8332 method.
8333 <can_highight, is_highlighted>: Now bool.
8334 (tui_set_win_highlight): Don't declare.
8335 * tui/tui-data.c (tui_set_win_highlight): Remove.
8336
8337 2019-06-25 Tom Tromey <tom@tromey.com>
8338
8339 * tui/tui-wingeneral.c (make_visible): Remove check of window
8340 type.
8341
8342 2019-06-25 Tom Tromey <tom@tromey.com>
8343
8344 * tui/tui-win.c (tui_win_info::max_height)
8345 (tui_cmd_window::max_height): New methods.
8346 (new_height_ok): Call max_height.
8347 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8348 <max_height>: New method.
8349
8350 2019-06-25 Tom Tromey <tom@tromey.com>
8351
8352 * tui/tui-win.c (tui_source_window_base::set_new_height)
8353 (tui_data_window::set_new_height): New methods.
8354 (make_invisible_and_set_new_height): Call set_new_height method.
8355 * tui/tui-data.h (struct tui_win_info)
8356 (struct tui_source_window_base, struct tui_data_window)
8357 <set_new_height>: New method.
8358
8359 2019-06-25 Tom Tromey <tom@tromey.com>
8360
8361 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8362 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8363 tui_refresh_data_win.
8364 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8365 method.
8366 (tui_refresh_all_win): Call the refresh_all method.
8367 (tui_set_focus): Likewise.
8368 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8369 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8370 Likewise.
8371
8372 2019-06-25 Tom Tromey <tom@tromey.com>
8373
8374 * tui/tui-winsource.h (tui_refill_source_window)
8375 (tui_set_is_exec_point_at): Don't declare.
8376 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8377 (tui_source_window_base::refill): Rename from
8378 tui_refill_source_window.
8379 (tui_source_window_base::do_scroll_horizontal): Update.
8380 (tui_source_window_base::set_is_exec_point_at): Rename from
8381 tui_set_is_exec_point_at.
8382 (tui_update_all_breakpoint_info): Update.
8383 * tui/tui-stack.c (tui_show_frame_info): Update.
8384 * tui/tui-layout.c (show_data): Add cast.
8385 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8386 * tui/tui-data.h (struct tui_source_window_base) <refill,
8387 set_is_exec_point_at>: New methods.
8388 (tui_source_windows, tui_add_to_source_windows): Update types.
8389 (tui_add_to_source_windows): Remove redundant declaration.
8390 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8391 (tui_source_windows): Change return type.
8392 (tui_clear_source_windows_detail): Update.
8393 (tui_add_to_source_windows): Change type of parameter.
8394 (tui_free_all_source_wins_content): Update.
8395
8396 2019-06-25 Tom Tromey <tom@tromey.com>
8397
8398 * tui/tui-wingeneral.c (tui_win_info::refresh)
8399 (tui_source_window_base::refresh): New methods.
8400 (tui_refresh_all): Call the refresh method.
8401 * tui/tui-data.h (struct tui_win_info)
8402 (struct tui_source_window_base) <refresh>: New method.
8403
8404 2019-06-25 Tom Tromey <tom@tromey.com>
8405
8406 * tui/tui.h (tui_is_window_visible): Return bool.
8407 * tui/tui.c (tui_is_window_visible): Return bool.
8408 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8409 (tui_make_visible, tui_make_invisible)
8410 (tui_win_info::make_visible)
8411 (tui_source_window_base::make_visible, make_all_visible)
8412 (tui_make_all_visible, tui_make_all_invisible): Update.
8413 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8414 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8415 bool.
8416 (struct tui_win_info, struct tui_source_window_base)
8417 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8418 * tui/tui-data.c (tui_init_generic_part): Update.
8419
8420 2019-06-25 Tom Tromey <tom@tromey.com>
8421
8422 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8423 (tui_source_window_base::make_visible): New methods.
8424 (make_all_visible): Make method call.
8425 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8426 (struct tui_source_window_base, struct tui_cmd_window): Override
8427 make_visible.
8428 (tui_win_is_source_type): Don't declare.
8429 * tui/tui-data.c (tui_win_is_source_type): Remove.
8430
8431 2019-06-25 Tom Tromey <tom@tromey.com>
8432
8433 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8434 NULL check.
8435
8436 2019-06-25 Tom Tromey <tom@tromey.com>
8437
8438 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8439 Inline constructor. Add initializers for members.
8440 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8441 constructors; now inline in class.
8442
8443 2019-06-25 Tom Tromey <tom@tromey.com>
8444
8445 * tui/tui-regs.c (tui_show_registers): Update.
8446 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8447 bool.
8448 * tui/tui-data.c (tui_data_window::clear_detail)
8449 (tui_data_window): Update.
8450
8451 2019-06-25 Tom Tromey <tom@tromey.com>
8452
8453 * tui/tui-windata.c (tui_display_all_data)
8454 (tui_display_data_from_line, tui_display_data_from)
8455 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8456 Update.
8457 * tui/tui-regs.c (tui_last_regs_line_no)
8458 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8459 (tui_show_registers, tui_show_register_group)
8460 (tui_display_registers_from, tui_display_reg_element_at_line)
8461 (tui_display_registers_from_line, tui_check_register_values)
8462 (tui_reg_next, tui_reg_prev): Update.
8463 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8464 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8465 tui_data_window.
8466 (struct tui_win_info) <detail>: Remove. Add new fields from
8467 tui_data_info.
8468 (TUI_DATA_WIN): Add cast.
8469 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8470 (~tui_data_window): Simplify.
8471
8472 2019-06-25 Tom Tromey <tom@tromey.com>
8473
8474 * tui/tui-layout.c (show_source_disasm_command)
8475 (show_source_or_disasm_and_command): Update.
8476 * tui/tui-io.c (update_cmdwin_start_line)
8477 (tui_redisplay_readline): Update.
8478 * tui/tui-data.h (struct tui_command_info): Remove.
8479 (struct tui_win_info) <detail>: Remove command_info member.
8480 (struct tui_data_window) <start_line>: New member, from
8481 tui_command_info.
8482 (TUI_CMD_WIN): Add casts.
8483
8484 2019-06-25 Tom Tromey <tom@tromey.com>
8485
8486 * tui/tui-winsource.c (tui_update_source_window)
8487 (tui_refill_source_window)
8488 (tui_source_window_base::do_scroll_horizontal)
8489 (tui_update_breakpoint_info, tui_set_exec_info_content)
8490 (tui_show_exec_info_content, tui_erase_exec_info_content)
8491 (tui_clear_exec_info_content): Update.
8492 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8493 Update.
8494 * tui/tui-win.c (make_invisible_and_set_new_height)
8495 (make_visible_with_new_height): Update.
8496 * tui/tui-source.c (tui_set_source_content)
8497 (tui_show_symtab_source): Update.
8498 * tui/tui-layout.c (extract_display_start_addr)
8499 (show_source_disasm_command, show_data)
8500 (make_source_or_disasm_window)
8501 (show_source_or_disasm_and_command): Update.
8502 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8503 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8504 "gdbarch".
8505 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8506 to tui_source_window_base.
8507 (struct tui_win_info) <detail>: Remove source_info member.
8508 (struct tui_source_window_base) <has_locator>: Inline.
8509 Move contents from tui_source_info; rename has_locator member to
8510 m_has_locator.
8511 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8512 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8513 header file.
8514 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8515 Simplify.
8516 (tui_free_all_source_wins_content): Cast to
8517 tui_source_window_base.
8518
8519 2019-06-25 Tom Tromey <tom@tromey.com>
8520
8521 * tui/tui-win.c (make_invisible_and_set_new_height)
8522 (make_visible_with_new_height): Call has_locator method.
8523 * tui/tui-layout.c (show_source_disasm_command, show_data)
8524 (show_source_or_disasm_and_command): Update for bool change.
8525 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8526 (tui_win_info) <has_locator>: New method.
8527 (struct tui_source_window_base) <has_locator>: New method.
8528 (tui_win_has_locator): Don't declare.
8529 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8530 from tui_win_has_locator.
8531 (tui_source_window_base): Use false, not FALSE.
8532
8533 2019-06-25 Tom Tromey <tom@tromey.com>
8534
8535 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8536 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8537 clear_detail method directly.
8538 (tui_clear_win_detail): Remove.
8539
8540 2019-06-25 Tom Tromey <tom@tromey.com>
8541
8542 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8543 "this", not TUI_DISASM_WIN.
8544
8545 2019-06-25 Tom Tromey <tom@tromey.com>
8546
8547 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8548 declare.
8549 * tui/tui-winsource.c
8550 (tui_source_window_base::do_scroll_horizontal): Rename from
8551 tui_horizontal_source_scroll.
8552 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8553 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8554 from tui_vertical_data_scroll.
8555 * tui/tui-win.h (tui_scroll): Don't declare.
8556 * tui/tui-win.c (tui_win_info::forward_scroll)
8557 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8558 (tui_win_info::right_scroll): Rename and update.
8559 (tui_scroll_forward_command, tui_scroll_backward_command)
8560 (tui_scroll_left_command, tui_scroll_right_command): Update.
8561 (tui_scroll): Remove.
8562 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8563 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8564 from tui_vertical_source_scroll.
8565 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8566 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8567 from tui_vertical_disassem_scroll.
8568 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8569 do_scroll_horizontal>: New methods.
8570 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8571 Likewise.
8572 (struct tui_source_window_base): Add do_scroll_horizontal.
8573 (struct tui_source_window, struct tui_disasm_window): Add
8574 do_scroll_vertical.
8575 (struct tui_data_window, struct tui_cmd_window): Add
8576 do_scroll_horizontal and do_scroll_vertical.
8577 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8578
8579 2019-06-25 Tom Tromey <tom@tromey.com>
8580
8581 * tui/tui-data.h (struct tui_source_window_base): New struct.
8582 (struct tui_source_window): Derive from tui_source_window_base.
8583 (struct tui_disasm_window): New struct.
8584 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8585 from tui_source_window::clear_detail.
8586 (tui_source_window_base): Rename from tui_source_window.
8587 (~tui_source_window_base): Rename from ~tui_source_window.
8588 (tui_alloc_win_info): Create a tui_disasm_window.
8589
8590 2019-06-25 Tom Tromey <tom@tromey.com>
8591
8592 * tui/tui-data.h (struct tui_source_window)
8593 (struct tui_data_window): Declare destructors.
8594 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8595 destructors.
8596 (tui_win_info): Simplify.
8597
8598 2019-06-25 Tom Tromey <tom@tromey.com>
8599
8600 * tui/tui-winsource.c (tui_display_main)
8601 (tui_update_source_windows_with_addr)
8602 (tui_update_all_breakpoint_info): Update.
8603 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8604 (new_height_ok, parse_scrolling_args): Update.
8605 * tui/tui-stack.c (tui_show_frame_info): Update.
8606 * tui/tui-data.h (struct tui_list): Remove.
8607 (tui_source_windows): Return a reference to a std::vector.
8608 * tui/tui-data.c (source_windows): Now a std::vector.
8609 (tui_source_windows): Change return type.
8610 (tui_clear_source_windows): Rewrite.
8611 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8612 (tui_free_all_source_wins_content): Rewrite.
8613
8614 2019-06-25 Tom Tromey <tom@tromey.com>
8615
8616 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8617 (struct tui_data_window, struct tui_cmd_window): Declare
8618 clear_detail method.
8619 * tui/tui-data.c (tui_source_window::clear_detail)
8620 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8621 methods.
8622 (tui_clear_win_detail): Simplify.
8623
8624 2019-06-25 Tom Tromey <tom@tromey.com>
8625
8626 * tui/tui-layout.c (make_source_window, make_disasm_window)
8627 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8628 Return the new window.
8629 (show_source_disasm_command, show_data)
8630 (show_source_or_disasm_and_command): Update.
8631
8632 2019-06-25 Tom Tromey <tom@tromey.com>
8633
8634 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8635 parameter. Return the new window.
8636 (show_source_disasm_command): Update and remove NULL check.
8637 (show_source_or_disasm_and_command): Update.
8638
8639 2019-06-25 Tom Tromey <tom@tromey.com>
8640
8641 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8642
8643 2019-06-25 Tom Tromey <tom@tromey.com>
8644
8645 * tui/tui-data.h (struct tui_win_info): Make constructor
8646 protected. Make destructor virtual. Add initializers.
8647 (tui_source_window, tui_data_window, tui_cmd_window): New
8648 classes.
8649 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8650 constructor. Add "type" parameter.
8651 (tui_source_window, tui_data_window, tui_cmd_window): New
8652 constructors.
8653 (tui_alloc_win_info): Instantiate the appropriate subclass.
8654
8655 2019-06-25 Tom Tromey <tom@tromey.com>
8656
8657 * tui/tui-win.c (tui_resize_all): Use delete.
8658 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8659 destructor.
8660 (tui_free_window): Don't declare.
8661 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8662 Update.
8663
8664 2019-06-25 Tom Tromey <tom@tromey.com>
8665
8666 * tui/tui-data.h (struct tui_win_info): Add constructor.
8667 * tui/tui-data.c (tui_alloc_win_info): Use new.
8668 (tui_free_window): Use delete.
8669
8670 2019-06-22 Tom Tromey <tom@tromey.com>
8671
8672 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8673 declare.
8674 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8675
8676 2019-06-22 Tom Tromey <tom@tromey.com>
8677
8678 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8679 declare.
8680 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8681
8682 2019-06-22 Tom de Vries <tdevries@suse.de>
8683
8684 * dwarf2read.c (create_addrmap_from_aranges)
8685 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8686 instead of '%zu'.
8687
8688 2019-06-21 Simon Marchi <simon.marchi@efficios.com>
8689
8690 * dwarf2read.h (dwarf2_section_info_def): Remove.
8691 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8692 * dwarf2read.c (struct dwo_sections) <types>: Change type to
8693 std::vector<dwarf2_section_info>.
8694 (struct dwo_file) <~dwo_file>: Remove.
8695 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8696 types field.
8697 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8698 (dwarf2_read_debug_names): Likewise.
8699 (create_debug_types_hash_table): Change parameter type to
8700 array_view, adjust code accordingly.
8701 (dwarf2_locate_dwo_sections): Adjust to std::vector.
8702 (partial_die_info::fixup): Likewise.
8703 (determine_prefix): Likewise.
8704 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8705
8706 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8707
8708 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8709 gdb_bfd_ref_ptr.
8710 <~dwo_file>: Remove call to gdb_bfd_unref.
8711 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8712 gdb_bfd_ref_ptr::get.
8713
8714 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8715
8716 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8717 type to htab_up.
8718 * dwarf2read.c (struct dwo_file): Initialize fields.
8719 <~dwo_file>: New.
8720 (free_dwo_file): Remove, move content to ~dwo_file.
8721 (struct dwo_file_deleter): Remove.
8722 (dwo_file_up>: Remove custom deleter.
8723 (free_dwo_files): Remove.
8724 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8725 dwo_files.
8726 (process_skeletonless_type_units): Call unique_ptr::get.
8727 (allocate_dwo_file_hash_table): Add deleter to created hash
8728 table. Change return type to htab_up.
8729 (lookup_dwo_file_slot): Don't memset dwo_file, call
8730 unique_ptr::get.
8731 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8732 (create_dwo_unit_in_dwp_v2): Likewise.
8733 (open_and_init_dwo_file): Likewise.
8734 (free_dwo_file_from_slot): Remove.
8735
8736 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8737
8738 * dwarf2read.h (struct dwarf2_section_info) <readin,
8739 is_virtual>: Change type to bool.
8740 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8741 true instead of 1.
8742
8743 2019-06-19 Tom Tromey <tom@tromey.com>
8744
8745 * tui/tui-data.h (tui_init_content_element): Don't declare.
8746
8747 2019-06-19 Tom Tromey <tom@tromey.com>
8748
8749 * tui/tui-data.h (tui_init_win_info): Don't declare.
8750
8751 2019-06-19 Tom de Vries <tdevries@suse.de>
8752
8753 * dwarf2read.h (abstract_to_concrete): Change type to
8754 std::unordered_map<sect_offset, std::vector<sect_offset>,
8755 gdb::hash_enum<sect_offset>>.
8756
8757 2019-06-19 Tom Tromey <tromey@adacore.com>
8758
8759 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8760 EVAL_AVOID_SIDE_EFFECTS specially.
8761
8762 2019-06-19 Tom Tromey <tromey@adacore.com>
8763
8764 * source-cache.c (highlighter): New global.
8765 (source_cache::get_source_lines): Create a highlighter on demand.
8766
8767 2019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
8768
8769 * defs.h (deprecated_interactive_hook): Delete declaration.
8770 * interps.c (clear_interpreter_hooks): Remove use of
8771 deprecated_interactive_hook.
8772 * top.c (deprecated_interactive_hook): Delete definition.
8773 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8774
8775 2019-06-18 Tom de Vries <tdevries@suse.de>
8776
8777 PR gdb/24515
8778 * dwarf2read.h (abstract_to_concrete): Change type from
8779 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8780 std::unordered_map<sect_offset, std::vector<sect_offset>>.
8781 * dwarf2read.c (read_variable): Update.
8782 (dwarf2_fetch_die_loc_sect_off): Update.
8783
8784 2019-06-17 Tom de Vries <tdevries@suse.de>
8785
8786 PR gdb/24617
8787 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8788 accessing parent[parent_len - 1].
8789
8790 2019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
8791
8792 PR gdb/24364
8793 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8794 call dtrace_process_dof with NULL dof.
8795
8796 2019-06-16 Tom de Vries <tdevries@suse.de>
8797
8798 PR gdb/24445
8799 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8800
8801 2019-06-16 Tom Tromey <tom@tromey.com>
8802
8803 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8804 (make_all_visible): Use address of member.
8805
8806 2019-06-16 Tom Tromey <tom@tromey.com>
8807
8808 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8809 (tui_free_window, free_content, free_content_elements): Remove
8810 unnecessary cast.
8811 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8812 cast.
8813 * tui/tui-regs.c (tui_show_register_group)
8814 (tui_display_registers_from, tui_display_reg_element_at_line):
8815 Remove unnecessary cast.
8816
8817 2019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
8818
8819 * linux-nat.c (normal_mask): Delete.
8820 (_initialize_linux_nat): Don't initialise normal_mask.
8821
8822 2019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
8823
8824 PR gdb/24445
8825 * dwarf-index-write.h (write_psymtabs_to_index): Add
8826 dwz_basename parameter.
8827 * dwarf-index-write.c (write_gdbindex): Move file writing to
8828 write_gdbindex_1. Change return type void.
8829 (assert_file_size): Move up, remove filename parameter.
8830 (write_gdbindex_1): New function.
8831 (write_debug_names): Change return type to void, call
8832 assert_file_size.
8833 (struct index_wip_file): New struct.
8834 (write_psymtabs_to_index): Add dwz_basename parameter. Move
8835 file logic to index_wip_file. Write index for dwz file if
8836 needed.
8837 (save_gdb_index_command): Pass basename of dwz file, if present.
8838 * dwarf-index-cache.c (index_cache::store): Obtain and pass
8839 build-id of dwz file, if present.
8840 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8841 (dwarf2_get_dwz_file): Likewise.
8842 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8843 (dwarf2_get_dwz_file): Likewise.
8844
8845 2019-06-16 Tom Tromey <tom@tromey.com>
8846
8847 * coffread.c (process_coff_symbol): Use xstrdup.
8848 * value.c (create_internalvar): Use xstrdup.
8849
8850 2019-06-16 Tom Tromey <tom@tromey.com>
8851
8852 * valops.c (value_cast, value_slice): Remove unnecessary cast.
8853 * breakpoint.c (stopin_command, stopat_command)
8854 (until_break_command, decode_location_default): Remove unnecessary
8855 cast.
8856 * utils.c (subset_compare): Remove unnecessary cast.
8857 * ada-lang.c (ada_update_initial_language): Remove unnecessary
8858 cast.
8859 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8860 cast.
8861 * infcmd.c (path_command): Remove unnecessary cast.
8862 * coffread.c (decode_type): Remove unnecessary cast.
8863 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8864 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8865 * tui/tui-stack.c (tui_show_locator_content)
8866 (tui_show_frame_info): Remove unnecessary cast.
8867 * tui/tui-win.c (tui_scroll_forward_command)
8868 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8869 (parse_scrolling_args): Remove unnecessary cast.
8870 * tui/tui-data.c (init_win_info, tui_del_window)
8871 (tui_free_window, tui_del_data_windows, tui_free_data_content)
8872 (free_content_elements): Remove unnecessary cast.
8873 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8874 unnecessary cast.
8875 * tui/tui-source.c (tui_set_source_content)
8876 (tui_vertical_source_scroll): Remove unnecessary cast.
8877 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8878 cast.
8879 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8880 * tui/tui-regs.c (tui_display_registers_from)
8881 (tui_display_register): Remove unnecessary cast.
8882 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8883 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8884 (make_visible): Remove unnecessary cast.
8885 * tui/tui-winsource.c (tui_erase_source_content)
8886 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8887 unnecessary cast.
8888 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8889 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8890 * stabsread.c (read_type, read_array_type, read_range_type):
8891 Remove unnecessary cast.
8892 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8893 (parse_symbol, parse_type, upgrade_type, parse_external)
8894 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8895 unnecessary cast.
8896 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8897
8898 2019-06-16 Tom Tromey <tom@tromey.com>
8899
8900 * tui/tui-data.c (tui_alloc_generic_win_info)
8901 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8902 checks.
8903
8904 2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
8905 Andrew Burgess <andrew.burgess@embecosm.com>
8906
8907 * f-typeprint.c (f_print_type): Don't return early for not
8908 associated or not allocated types.
8909 (f_type_print_varspec_suffix): Add print_rank parameter and print
8910 ranks of array types in case they dangling.
8911 (f_type_print_base): Add print_rank parameter.
8912
8913 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8914
8915 * NEWS: Mention new MI commands.
8916 * break-catch-throw.c (enum exception_event_kind): Move to
8917 breakpoint.h.
8918 (print_mention_exception_catchpoint): Output text as a single
8919 message.
8920 (catch_exception_command_1): Rename to...
8921 (catch_exception_event): ...this, make non-static, update header
8922 command, and change some parameter types.
8923 (catch_catch_command): Update for changes to
8924 catch_exception_command_1.
8925 (catch_throw_command): Likewise.
8926 (catch_rethrow_command): Likewise.
8927 * breakpoint.c (enum exception_event_kind): Delete.
8928 * breakpoint.h (enum exception_event_kind): Moved here from
8929 break-catch-throw.c.
8930 (catch_exception_event): Declare.
8931 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8932 (mi_cmd_catch_throw): New function.
8933 (mi_cmd_catch_rethrow): New function.
8934 (mi_cmd_catch_catch): New function.
8935 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8936 'catch-catch' entries.
8937 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8938 (mi_cmd_catch_rethrow): Declare.
8939 (mi_cmd_catch_catch): Declare.
8940
8941 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8942
8943 * annotate.c (annotate_source_line): Change return type to void,
8944 update implementation to match.
8945 * annotate.h (annotate_source_line): Change return type to void,
8946 update header comment.
8947 * stack.c (print_frame_info): Don't change what frame information
8948 is printed based on whether annotations are on or not.
8949
8950 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8951
8952 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8953 (annotate_source): Make static.
8954 (annotate_source_line): Moved from source.c and renamed from
8955 identify_source_line. Update the return type.
8956 * annotate.h (annotate_source): Delete declaration.
8957 (annotate_source_line): Declaration moved from source.h, and
8958 renamed from identify_source_line. Return type updated.
8959 * source.c (identify_source_line): Moved to annotate.c and renamed
8960 to annotate_source_line.
8961 (info_line_command): Remove check of annotation_level.
8962 * source.h (identify_source_line): Move declaration to annotate.h
8963 and rename to annotate_source_line.
8964 * stack.c: Add 'annotate.h' include.
8965 (print_frame_info): Remove check of annotation_level before
8966 calling annotate_source_line.
8967
8968 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8969
8970 * source-cache.c (source_cache::get_plain_source_lines): Use
8971 open_source_file_with_line_charpos instead of just
8972 open_source_file, remove call to find_source_lines.
8973 (source_cache::get_source_lines): Likewise.
8974 * source.c (find_source_lines): Make static.
8975 (get_filename_and_charpos): Renamed into...
8976 (open_source_file_with_line_charpos): ..this along with changes to
8977 return a scoped_fd, and some other minor clean ups.
8978 (identify_source_line): Use open_source_file_with_line_charpos.
8979 (search_command_helper): Use open_source_file_with_line_charpos
8980 instead of just open_source_file, remove call to
8981 find_source_lines.
8982 * source.h (open_source_file_with_line_charpos): Declare new
8983 function.
8984 (find_source_lines): Delete declaration.
8985
8986 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8987
8988 * source.c (get_filename_and_charpos): Remove fullname
8989 parameter.
8990 (identify_source_line): Update call to get_filename_and_charpos.
8991
8992 2019-06-14 Tom Tromey <tromey@adacore.com>
8993
8994 PR gdb/24502:
8995 * ui-style.h (skip_ansi_escape): Update comment.
8996 * ui-file.h (class no_terminal_escape_file): New class.
8997 * ui-file.c (no_terminal_escape_file::write)
8998 (no_terminal_escape_file::puts): New methods.
8999 * cli/cli-logging.c (handle_redirections): Use
9000 no_terminal_escape_file.
9001
9002 2019-06-14 Tom Tromey <tromey@adacore.com>
9003
9004 * NEWS: Move convenience variable news above Python news.
9005
9006 2019-06-14 Tom Tromey <tom@tromey.com>
9007
9008 * gnulib: Move directory to top-level.
9009 * configure.ac: Don't configure gnulib.
9010 * configure: Rebuild.
9011 * common/common-defs.h: Use new path to gnulib.
9012 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9013 (GNULIB_H): Remove.
9014 (INCGNU): Look in new gnulib location.
9015 (HFILES_NO_SRCDIR): Remove gnulib files.
9016 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9017 (generated_files): Remove GNULIB_H.
9018 ($(LIBGNU), all-lib): Remove targets.
9019 (distclean): Don't mention GNULIB_BUILDDIR.
9020 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9021
9022 2019-06-14 Tom Tromey <tromey@adacore.com>
9023
9024 * symfile.c (add_symbol_file_command): Remove obsolete comment.
9025 Warn if symbol file does not provide any symbols.
9026
9027 2019-06-14 Tom Tromey <tromey@adacore.com>
9028
9029 * source.c (find_and_open_source): Respect basenames_may_differ.
9030
9031 2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
9032
9033 * annotate.c (annotate_breakpoints_invalid): Make use of
9034 scoped_restore_terminal_state.
9035 (annotate_frames_invalid): Likewise.
9036
9037 2019-06-14 Tom Tromey <tromey@adacore.com>
9038
9039 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9040 allow assignment to an internalvar.
9041
9042 2019-06-14 Tom Tromey <tromey@adacore.com>
9043
9044 * ada-lex.l: Allow "_" in attribute names.
9045
9046 2019-06-14 Tom Tromey <tromey@adacore.com>
9047
9048 PR gdb/24653:
9049 * regcache.c (registers_changed): Don't call alloca.
9050 * top.c (execute_command): Don't call alloca.
9051
9052 2019-06-13 Pedro Alves <palves@redhat.com>
9053
9054 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9055 'expression'. When parsing an expression, error out if there's
9056 junk after "unlimited".
9057 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9058 (do_set_command): Adjust calls to is_unlimited_literal.
9059
9060 2019-06-13 Pedro Alves <palves@redhat.com>
9061
9062 * compile/compile.c (make_compile_options_def_group): Add braces
9063 around array_view initializer.
9064 * thread.c (make_thread_apply_all_options_def_group)
9065 (make_thread_apply_all_options_def_group): Likewise.
9066
9067 2019-06-13 Pedro Alves <palves@redhat.com>
9068
9069 * NEWS (New commands): Mention "maint test-options
9070 require-delimiter", "maint test-options unknown-is-error", "maint
9071 test-options unknown-is-operand" and "maint show
9072 test-options-completion-result".
9073 (New command options, command completion): New section.
9074 (Completion improvements): New section.
9075 Mention that you can abbreviate "unlimited".
9076
9077 2019-06-13 Pedro Alves <palves@redhat.com>
9078
9079 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9080 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9081 * unittests/cli-utils-selftests.c (test_parse_flags)
9082 (test_parse_flags_qcs): Delete.
9083 (test_cli_utils): Don't call deleted functions.
9084
9085 2019-06-13 Pedro Alves <palves@redhat.com>
9086
9087 * thread.c: Include "cli/cli-option.h".
9088 (tp_array_compar_ascending): Global.
9089 (tp_array_compar): Delete function.
9090 (tp_array_compar_ascending, tp_array_compar_descending): New
9091 functions.
9092 (ascending_option_def, qcs_flag_option_def)
9093 (thr_qcs_flags_option_defs)
9094 (make_thread_apply_all_options_def_group)
9095 (make_thread_apply_options_def_group): New.
9096 (thread_apply_all_command): Use gdb::option::process_options.
9097 (thread_apply_command_completer)
9098 (thread_apply_all_command_completer): New.
9099 (thread_apply_command): Use gdb::option::process_options.
9100 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9101 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
9102 to generate help text of "thread apply". Adjust "taas"'s help.
9103 * tid-parse.c (tid_range_parser::in_thread_range): New method.
9104 * tid-parse.h (tid_range_parser::in_thread_range): New method.
9105
9106 2019-06-13 Pedro Alves <palves@redhat.com>
9107
9108 * thread.c (thread_apply_command): Check for invalid TID with
9109 isdigit instead of !isalpha.
9110
9111 2019-06-13 Pedro Alves <palves@redhat.com>
9112
9113 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9114 (validate_flags_qcs): New.
9115 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9116 (validate_flags_qcs): Declare.
9117 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9118 (make_frame_apply_options_def_group): New.
9119 (frame_apply_command_count): Process options with
9120 gdb::option::process_options.
9121 (frame_apply_completer): New.
9122 (frame_apply_level_completer, frame_apply_all_completer)
9123 (frame_apply_completer): New.
9124 (_initialize_stack): Update help of "frame apply", "frame apply
9125 level", "frame apply all" and "faas" to mention supported options
9126 and install command completers.
9127 * stack.h (frame_apply_all_completer): Declare.
9128 * thread.c: Include "stack.h".
9129 (tfaas_command): Add "--".
9130 (_initialize_thread): Update help "tfaas" to mention supported
9131 options and install command completer.
9132
9133 2019-06-13 Pedro Alves <palves@redhat.com>
9134
9135 * completer.c (complete_nested_command_line): New.
9136 (gdb_completion_word_break_characters_throw): Add assertion.
9137 * completer.h (complete_nested_command_line): Declare.
9138
9139 2019-06-13 Pedro Alves <palves@redhat.com>
9140
9141 * stack.c (parse_backtrace_qualifiers): New.
9142 (backtrace_command): Use it.
9143 (backtrace_command_completer): Complete on qualifiers.
9144
9145 2019-06-13 Pedro Alves <palves@redhat.com>
9146
9147 * frame.c: Include "cli/cli-option.h.
9148 (user_set_backtrace_options): New.
9149 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9150 Delete.
9151 (get_prev_frame): Adjust.
9152 (boolean_option_def, uinteger_option_def)
9153 (set_backtrace_option_defs): New.
9154 (_initialize_frame): Adjust and use
9155 gdb::option::add_setshow_cmds_for_options to install "set
9156 backtrace past-main" and "set backtrace past-entry".
9157 * frame.h: Include "cli/cli-option.h".
9158 (struct frame_print_options): Forward declare.
9159 (print_frame_arguments_all, print_frame_arguments_scalars)
9160 (print_frame_arguments_none): Declare.
9161 (print_entry_values): Delete declaration.
9162 (struct frame_print_options, user_frame_print_options): New.
9163 (struct set_backtrace_options): New.
9164 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9165 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9166 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9167 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9168 (list_args_or_locals): Add frame_print_options parameter.
9169 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9170 * python/py-framefilter.c (enumerate_args): Pass down
9171 USER_FRAME_PRINT_OPTIONS.
9172 * stack.c: Include "cli/cli-option.h".
9173 (print_frame_arguments_all, print_frame_arguments_scalars)
9174 (print_frame_arguments_none): Declare.
9175 (print_raw_frame_arguments, print_entry_values): Delete.
9176 (user_frame_print_options): New.
9177 (boolean_option_def, enum_option_def, frame_print_option_defs):
9178 New.
9179 (struct backtrace_cmd_options): New.
9180 (bt_flag_option_def): New.
9181 (backtrace_command_option_defs): New.
9182 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9183 (print_frame_arg, read_frame_arg, print_frame_args)
9184 (print_frame_info, print_frame): Add frame_print_options parameter
9185 and use it.
9186 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9187 (backtrace_command_1): Add frame_print_options and
9188 backtrace_cmd_options parameters and use them.
9189 (make_backtrace_options_def_group): New.
9190 (backtrace_command): Process command options with
9191 gdb::option::process_options.
9192 (backtrace_command_completer): New.
9193 (_initialize_stack): Extend "backtrace"'s help to mention
9194 supported options. Install completer for "backtrace".
9195 Install some settings commands with add_setshow_cmds_for_options.
9196
9197 2019-06-13 Pedro Alves <palves@redhat.com>
9198
9199 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9200 and that "set/show print raw frame-arguments" are now deprecated.
9201
9202 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9203 command.
9204 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9205 * stack.c (_initialize_stack): Install "set/show print
9206 raw-frame-arguments", and deprecate "set/show print raw
9207 frame-arguments".
9208 * valprint.c (_initialize_valprint): Deprecate "set/show print
9209 raw".
9210
9211 2019-06-13 Pedro Alves <palves@redhat.com>
9212
9213 * compile/compile.c (struct compile_options): New.
9214 (compile_flag_option_def, compile_command_option_defs)
9215 (make_compile_options_def_group): New.
9216 (compile_file_command): Handle options with
9217 gdb::option::process_options.
9218 (compile_file_command_completer): New function.
9219 (compile_code_command): Handle options with
9220 gdb::option::process_options.
9221 (compile_code_command_completer): New function.
9222 (_initialize_compiler): Install completers for "compile code" and
9223 "compile file". Mention available options in "compile code" and
9224 "compile code"'s help.
9225 * completer.c (advance_to_completion_word): New, factored out from
9226 ...
9227 (advance_to_expression_complete_word_point): ... this.
9228 (advance_to_filename_complete_word_point): New.
9229 * completer.h (advance_to_filename_complete_word_point): New
9230 declaration.
9231
9232 2019-06-13 Pedro Alves <palves@redhat.com>
9233
9234 * compile/compile.c: Include "cli/cli-option.h".
9235 (compile_print_value): Scope data pointer is now a
9236 value_print_options pointer; adjust.
9237 (compile_print_command): Process options. Scope data pointer is
9238 now a value_print_options pointer; adjust.
9239 (_initialize_compile): Update "compile print"'s help to include
9240 supported options. Install a completer for "compile print".
9241 * cp-valprint.c (show_vtblprint, show_objectprint)
9242 (show_static_field_print): Delete.
9243 (_initialize_cp_valprint): Don't install "set print
9244 static-members", "set print vtbl", "set print object" here.
9245 * printcmd.c: Include "cli/cli-option.h" and
9246 "common/gdb_optional.h".
9247 (print_command_parse_format): Rework to fill in a
9248 value_print_options instead of a format_data.
9249 (print_value): Change parameter type from format_data pointer to
9250 value_print_options reference. Adjust.
9251 (print_command_1): Process options. Adjust to pass down a
9252 value_print_options.
9253 (print_command_completer): New.
9254 (_initialize_printcmd): Install print_command_completer as
9255 handle_brkchars completer for the "print" command. Update
9256 "print"'s help to include supported options.
9257 * valprint.c: Include "cli/cli-option.h".
9258 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9259 here from cp-valprint.c.
9260 (boolean_option_def, uinteger_option_def)
9261 (value_print_option_defs, make_value_print_options_def_group):
9262 New. Use gdb::option::add_setshow_cmds_for_options to install
9263 "set print elements", "set print null-stop", "set print repeats",
9264 "set print pretty", "set print union", "set print array", "set
9265 print address", "set print symbol", "set print array-indexes".
9266 * valprint.h: Include <string> and "cli/cli-option.h".
9267 (make_value_print_options_def_group): Declare.
9268 (print_value): Change parameter type from format_data pointer to
9269 value_print_options reference.
9270 (print_command_completer): Declare.
9271
9272 2019-06-13 Pedro Alves <palves@redhat.com>
9273
9274 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9275 (COMMON_SFILES): Add maint-test-settings.c.
9276 * cli/cli-decode.c (boolean_enums): New global, factored out from
9277 ...
9278 (add_setshow_boolean_cmd): ... here.
9279 * cli/cli-decode.h (boolean_enums): Declare.
9280 * cli/cli-option.c: New file.
9281 * cli/cli-option.h: New file.
9282 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9283 factored out from ...
9284 (parse_cli_boolean_value(const char *)): ... this.
9285 (is_unlimited_literal): Change parameter type to pointer to
9286 pointer. Adjust and advance ARG pointer.
9287 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9288 (parse_cli_var_enum): New, factored out from ...
9289 (do_set_command): ... this. Adjust.
9290 * cli/cli-setshow.h (parse_cli_boolean_value)
9291 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9292 (parse_cli_var_enum): Declare.
9293 * cli/cli-utils.c: Include "cli/cli-option.h".
9294 (get_ulongest): New.
9295 * cli/cli-utils.h (get_ulongest): Declare.
9296 (check_for_argument): New overloads.
9297 * maint-test-options.c: New file.
9298
9299 2019-06-13 Pedro Alves <palves@redhat.com>
9300
9301 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9302 parse a range if "-" is at the end of the string.
9303
9304 2019-06-13 Pedro Alves <palves@redhat.com>
9305
9306 * cli/cli-setshow.c (parse_auto_binary_operation)
9307 (parse_cli_boolean_value): Don't allow "o".
9308
9309 2019-06-13 Pedro Alves <palves@redhat.com>
9310
9311 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9312 * NEWS: Mention maint test-settings KIND.
9313 * maint-test-settings.c: New file.
9314
9315 2019-06-13 Pedro Alves <palves@redhat.com>
9316
9317 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9318 completer.
9319 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9320 "set" completers.
9321
9322 2019-06-13 Pedro Alves <palves@redhat.com>
9323
9324 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9325 after item.
9326
9327 2019-06-13 Pedro Alves <palves@redhat.com>
9328
9329 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9330
9331 2019-06-13 Pedro Alves <palves@redhat.com>
9332
9333 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9334 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9335 call.
9336 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9337 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9338 calls.
9339 (check_for_argument): Skip spaces after argument.
9340
9341 2019-06-13 Pedro Alves <palves@redhat.com>
9342
9343 * thread.c (thread_apply_command): Adjust TID parsing.
9344 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9345 detected before end of string.
9346 (tid_is_in_list): Error out if LIST is invalid.
9347
9348 2019-06-13 Pedro Alves <palves@redhat.com>
9349
9350 * completer.c (complete_line_internal_1): Rewind completion word
9351 point.
9352 (completion_tracker::advance_custom_word_point_by): Change
9353 parameter type to int.
9354 * completer.h (completion_tracker::advance_custom_word_point_by):
9355 Likewise.
9356
9357 2019-06-13 Pedro Alves <palves@redhat.com>
9358
9359 * completer.c (advance_to_completion_word): Handle delimiters.
9360
9361 2019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9362
9363 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9364
9365 2019-06-11 Tom Tromey <tom@tromey.com>
9366
9367 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9368 (xmalloc_failed): Move to alloc.c.
9369 * alloc.c: New file.
9370 * Makefile.in (COMMON_SFILES): Add alloc.c.
9371
9372 2019-06-11 Tom Tromey <tom@tromey.com>
9373
9374 * nat/linux-waitpid.c: Don't include server.h.
9375 (linux_debug): Remove.
9376 (my_waitpid): Update.
9377
9378 2019-06-11 Tom Tromey <tromey@adacore.com>
9379
9380 * infcall.c (_initialize_infcall): Remove trailing newline from
9381 help.
9382 * user-regs.c (_initialize_user_regs): Remove trailing newline
9383 from help.
9384 * typeprint.c (_initialize_typeprint): Remove trailing newline
9385 from help.
9386 * reverse.c (_initialize_reverse): Remove trailing newlines from
9387 help.
9388 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9389 from help.
9390 * language.c (add_set_language_command): Remove trailing newline
9391 from help.
9392 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9393 help.
9394 * disasm.c (_initialize_disasm): Remove trailing newline from
9395 help.
9396 * top.c (init_main): Remove trailing newline from help.
9397 * interps.c (_initialize_interpreter): Remove trailing newline
9398 from help.
9399 * btrace.c (_initialize_btrace): Remove trailing newlines from
9400 help.
9401 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9402 from help.
9403 * python/python.c (_initialize_python): Remove trailing newline
9404 from help.
9405 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9406 help.
9407 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9408 from help. Reformat some text.
9409 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9410 from help.
9411 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9412 newline from help.
9413
9414 2019-06-11 Tom Tromey <tromey@adacore.com>
9415
9416 * darwin-nat.c (darwin_decode_exception_message)
9417 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9418
9419 2019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9420
9421 * valops.c (value_slice): Check for not allocated or not
9422 associated values.
9423
9424 2019-06-10 Tom de Vries <tdevries@suse.de>
9425
9426 PR gdb/24618
9427 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9428 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9429 invalid.
9430
9431 2019-06-10 Tom de Vries <tdevries@suse.de>
9432
9433 PR gdb/24611
9434 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9435 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9436
9437 2019-06-10 Tom de Vries <tdevries@suse.de>
9438
9439 PR symtab/24545
9440 * symtab.c (struct demangled_name_entry): Add language field.
9441 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9442 static minimal symbol". Set and use language field.
9443
9444 2019-06-10 Tom Tromey <tromey@adacore.com>
9445
9446 * ada-lang.c (_initialize_ada_language): Update help text.
9447
9448 2019-06-10 Tom Tromey <tromey@adacore.com>
9449
9450 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9451 with a newline.
9452 * guile/guile.c (handle_boot_error): Don't end warning with a
9453 newline.
9454 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9455 warning with a newline.
9456 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9457 newline.
9458 (s12z_frame_cache): Likewise.
9459 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9460 a newline.
9461 * solib-svr4.c (disable_probes_interface): Don't end warning with
9462 a newline.
9463 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9464 newline.
9465 * python/python.c (do_finish_initialization): Don't end warning
9466 with a newline.
9467
9468 2019-06-10 Tom Tromey <tom@tromey.com>
9469
9470 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9471 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9472 gdbpy_enter.
9473
9474 2019-06-10 Tom Tromey <tromey@adacore.com>
9475
9476 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9477 data.
9478 (elf_new_init): Don't call stabsread_new_init.
9479 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9480 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9481 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9482
9483 2019-06-10 Tom de Vries <tdevries@suse.de>
9484
9485 PR symtab/16264
9486 PR symtab/24517
9487 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9488
9489 2019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9490
9491 * source.c (find_and_open_source): Also rewrite relative file
9492 names.
9493
9494 2019-04-26 Amos Bird <amosbird@gmail.com>
9495
9496 * annotate.c (annotate_thread_exited): Add "thread-exited"
9497 annotation.
9498
9499 2019-06-06 Tom Tromey <tromey@adacore.com>
9500
9501 * maint.h (class scoped_command_stats): Use
9502 DISABLE_COPY_AND_ASSIGN.
9503 <print_time>: New method.
9504 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9505 print_time.
9506 (scoped_command_stats::print_time): New method.
9507
9508 2019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9509
9510 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9511 instructions of lengths 6 or 8 bytes.
9512
9513 2019-06-04 Pedro Alves <palves@redhat.com>
9514
9515 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9516
9517 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9518 * breakpoint.c (condition_completer): Likewise.
9519 * cli/cli-dump.c (scan_expression): Likewise.
9520 * common/filestuff.c (mkdir_recursive): Likewise.
9521 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9522 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9523 (gdb_abspath): Likewise.
9524 * compile/compile-cplus-types.c
9525 (compile_cplus_instance::decl_name): Likewise.
9526 * completer.c (complete_explicit_location):
9527 (signal_completer, reg_or_group_completer_1): Likewise.
9528 * cp-support.c (cp_remove_params_if_any): Likewise.
9529 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9530 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9531 * infcmd.c (strip_bg_char): Likewise.
9532 * linespec.c (copy_token_string): Likewise.
9533 * mi/mi-main.c (output_cores): Likewise.
9534 * psymtab.c (psymtab_search_name):
9535 * symfile.c (test_set_ext_lang_command): Likewise.
9536 * target.c (target_fileio_read_stralloc): Likewise.
9537 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9538 * value.c (complete_internalvar): Likewise.
9539
9540 2019-06-04 Christian Biesinger <cbiesinger@google.com>
9541
9542 Add objfile property to gdb.Type.
9543 * NEWS: Mention Python API addition.
9544 * python/py-type.c (typy_get_objfile): New method.
9545
9546 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9547
9548 * NEWS: Mention the new set|show style [title|highlight].
9549 Mention changes to "show style", "help" and "apropos".
9550
9551 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9552
9553 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9554 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9555 instead of print_help_for_command.
9556 (print_doc_of_command): New function.
9557 (help_list): Add 'apropos -v word' suggestion.
9558 (print_help_for_command): Style the command name using title style.
9559 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9560 (_initialize_cli_cmds): Describe -v in apropos_command help.
9561
9562 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9563
9564 * cli/cli-style.h (cli_style_option): Add name in constructor,
9565 add m_name class member, add constructor with intensity,
9566 add name class function.
9567 (cli_style_option::add_setshow_commands): Remove name argument.
9568 (highlight_style, title_style): New styles.
9569 * cli/cli-style.c (do_show): New function that shows a style
9570 characteristic styling the style name with itself.
9571 (set_style_name): New function.
9572 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9573 Update all callers according to the changes in cli/cli-style.h.
9574 * utils.h (fputs_highlighted): New function.
9575 * utils.c (fputs_highlighted): Likewise.
9576
9577 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9578
9579 * NEWS: Mention new pipe command and new convenience variables.
9580
9581 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9582
9583 * cli/cli-cmds.c (pipe_command): New function.
9584 (_initialize_cli_cmds): Call add_com for pipe_command.
9585 Define | as an alias for pipe.
9586 (exit_status_set_internal_vars): New function.
9587 (shell_escape): Call exit_status_set_internal_vars.
9588 cli/cli-decode.c (find_command_name_length): Recognize | as
9589 a single character command.
9590
9591 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9592
9593 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9594 top.c (execute_command_to_ui_file): New function, mostly a copy
9595 of execute_command_to_string.
9596 (execute_command_to_string): Implement by calling
9597 execute_command_to_ui_file.
9598
9599 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9600
9601 * top.h (saved_command_line): Remove declaration.
9602 * top.c (previous_saved_command_line, previous_repeat_arguments):
9603 New variables.
9604 (saved_command_line): Make static, define together with other
9605 'repeat variables'.
9606 (dont_repeat): Clear repeat_arguments.
9607 (repeat_previous, get_saved_command_line, save_command_line):
9608 New functions.
9609 (gdb_init): Initialize saved_command_line
9610 and previous_saved_command_line.
9611 * main.c (captured_main_1): Remove saved_command_line initialization.
9612 * event-top.c (handle_line_of_input): Update to use
9613 the new 'repeat' related functions instead of direct access to
9614 saved_command_line.
9615 * command.h (repeat_previous, get_saved_command_line,
9616 save_command_line): New declarations.
9617 (dont_repeat): Add comment.
9618
9619 2019-05-30 Tom Tromey <tromey@adacore.com>
9620
9621 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9622 Fix comment.
9623 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9624
9625 2019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9626
9627 PR cli/24587
9628 * completer.c (complete): Initialize variable word.
9629
9630 2019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9631
9632 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9633 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9634 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9635 'body' is NULL to the outter 'if', protecting the '!is_define'
9636 situation as well.
9637
9638 2019-05-29 Tom Tromey <tromey@adacore.com>
9639
9640 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9641 (dwarf_unknown): New function.
9642 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9643 (dwarf_type_encoding_name): Use dwarf_unknown.
9644
9645 2019-05-29 Tom Tromey <tromey@adacore.com>
9646
9647 PR c++/20020:
9648 * cp-valprint.c (cp_print_value_fields): Call
9649 cp_print_static_field inside "try".
9650
9651 2019-05-29 Tom Tromey <tromey@adacore.com>
9652
9653 * inflow.c (struct terminal_info): Add default operator=.
9654 * configure: Rebuild.
9655 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9656 -Wdeprecated-copy-dtor, -Wredundant-move.
9657
9658 2019-05-29 Tom Tromey <tromey@adacore.com>
9659
9660 * NEWS: Add entry.
9661 * infcmd.c (print_return_value_1): Handle finish_print
9662 option.
9663 (show_print_finish): New function.
9664 (_initialize_infcmd): Add "set/show print finish" commands.
9665 * valprint.c (user_print_options): Initialize new member.
9666 * valprint.h (struct value_print_options) <finish_print>: New
9667 member.
9668
9669 2019-05-28 Tom Tromey <tromey@adacore.com>
9670
9671 * ada-lang.c (ada_remove_Xbn_suffix)
9672 (find_old_style_renaming_symbol)
9673 (parse_old_style_renaming): Remove.
9674 (ada_find_renaming_symbol): Don't call
9675 find_old_style_renaming_symbol.
9676 (ada_is_renaming_symbol): Rename from
9677 ada_find_renaming_symbol. Remove "block" parameter. Return
9678 bool. Now static.
9679 (ada_read_var_value): Update and simplify.
9680 * ada-exp.y (write_var_or_type): Remove old code.
9681
9682 2019-05-28 Alan Hayward <alan.hayward@arm.com>
9683
9684 PR gdb/25010
9685 * event-top.c: Remove include comment.
9686 * inflow.c (class scoped_ignore_sigttou): Move from here...
9687 * inflow.h (class scoped_ignore_sigttou): ...to here.
9688 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9689 * top.c: Remove include comment.
9690
9691 2019-05-27 Tom Tromey <tom@tromey.com>
9692
9693 * NEWS: Fix typo.
9694
9695 2019-05-22 Tom Tromey <tromey@adacore.com>
9696
9697 * target.c (target_follow_exec): Constify parameter.
9698 * target-delegates.c: Rebuild.
9699 * remote.c (remote_target::follow_exec): Constify parameter.
9700 * infrun.c (follow_exec): Constify parameter.
9701 * target.h (struct target_ops) <follow_exec>: Constify parameter.
9702 (target_follow_exec): Likewise.
9703
9704 2019-05-22 Alan Hayward <alan.hayward@arm.com>
9705
9706 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9707 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9708
9709 2019-05-22 Alan Hayward <alan.hayward@arm.com>
9710
9711 * NEWS: Add debugredirect and testsuite sections.
9712
9713 2019-05-22 Simon Cook <simon.cook@embecosm.com>
9714
9715 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9716 target descriptions using exclusively floating point register name
9717 aliases.
9718
9719 2019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
9720
9721 PR gdb/18644:
9722 * f-lang.c (build_fortran_types): Handle the case where
9723 gdbarch_floatformat_for_type returns a nullptr.
9724
9725 2019-05-21 Tom de Vries <tdevries@suse.de>
9726
9727 PR cli/24587
9728 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9729
9730 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9731
9732 PR gdb/18644:
9733 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9734 16-byte floats.
9735 * i386-tdep.c (i386_floatformat_for_type): Use
9736 floatformats_ia64_quad for the 16-byte floating point component
9737 within a fortran 32-byte complex number.
9738
9739 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9740
9741 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9742 delete default constructor.
9743 (find_partial_die): Update to return const struct.
9744 (partial_die_parent_scope): Move variable declaration into scope
9745 of its use and change its type to auto.
9746 (guess_partial_die_structure_name): Likewise.
9747 (partial_die_info::fixup): Likewise.
9748
9749 2019-05-17 Tom Tromey <tromey@adacore.com>
9750
9751 * source.c (find_and_open_source): Remove cast.
9752
9753 2019-05-17 Tom Tromey <tromey@adacore.com>
9754
9755 * annotate.c (annotate_source): Make "filename" const.
9756 * annotate.h (annotate_source): Use const.
9757
9758 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9759
9760 * disasm.c (set_disassembler_options): Send errors to stderr.
9761
9762 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9763
9764 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9765 (cli_interp_base::set_logging): Check debug_redirect.
9766 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9767 * cli/cli-logging.c (debug_redirect): Add static variable.
9768 (pop_output_files): Add default param.
9769 (handle_redirections): Print debug setting.
9770 (show_logging_command): Likewise.
9771 (_initialize_cli_logging): Add debugredirect command.
9772 * interps.c (current_interp_set_logging): Add debug_redirect
9773 parameter.
9774 * interps.h (set_logging): Add debug_redirect parameter.
9775 (current_interp_set_logging): Likewise.
9776 * mi/mi-common.h: Likewise.
9777 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9778
9779 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9780 Tom Tromey <tromey@adacore.com>
9781
9782 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9783 directly.
9784 * cli/cli-interp.h (make_logging_output): Remove declaration.
9785 * cli/cli-logging.c (make_logging_output): Remove function.
9786 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9787 directly.
9788 * ui-file.c (tee_file::tee_file): Remove bools.
9789 (tee_file::~tee_file): Remove deletes.
9790 * ui-file.h (tee_file): Remove bools.
9791
9792 2019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
9793
9794 * mi/mi-cmds.h (mi_cmd_complete): New function.
9795 * mi/mi-main.c (mi_cmd_complete): Likewise.
9796 * mi/mi-cmds.c: Define new MI command -complete.
9797 * NEWS: Mention new -complete command.
9798
9799 2019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
9800
9801 * completer.h (complete): New function.
9802 * completer.c (complete): Likewise.
9803 * cli/cli-cmds.c: (complete_command): Update to use new complete()
9804 function defined in completer.h.
9805
9806 2019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
9807
9808 * MAINTAINERS (Write After Approval): Add myself.
9809
9810 2019-05-17 Tom de Vries <tdevries@suse.de>
9811
9812 PR gdb/24094
9813 * dwarf2read.c (struct cu_partial_die_info): New struct.
9814 (find_partial_die): Return cu_partial_die_info.
9815 (partial_die_parent_scope, guess_partial_die_structure_name)
9816 (partial_die_info::fixup): Handle new return type of find_partial_die.
9817
9818 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9819
9820 PR breakpoints/24541
9821 * stap-probe.c (stap_parse_register_operand): Make "regname" an
9822 "std::string", simplifying the algorithm.
9823
9824 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9825
9826 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9827 (stap_static_probe_ops::get_probes): Likewise.
9828
9829 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9830
9831 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9832 '-')" and "else if".
9833 (stap_parse_single_operand): Join checks for
9834 "gdbarch_stap_parse_special_token_p" and
9835 "gdbarch_stap_parse_special_token" in the same "if" statement.
9836 Invert check when verifying for operation on register
9837 displacement.
9838
9839 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9840
9841 * stap-probe.c (stap_get_opcode): Update comment.
9842 (stap_get_expected_argument_type): Likewise.
9843 (handle_stap_probe): Likewise.
9844
9845 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9846
9847 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9848 return type to 'bool'. Adjust comment. Use 'bool' when
9849 appropriate.
9850 (i386_stap_parse_special_token_three_arg_disp): Likewise.
9851 * stap-probe.c (stap_parse_argument_1): Likewise.
9852 (stap_is_operator): Likewise.
9853 (stap_is_generic_prefix): Likewise.
9854 (stap_is_register_prefix): Likewise.
9855 (stap_is_register_indirection_prefix): Likewise.
9856 (stap_is_integer_prefix): Likewise.
9857 (stap_generic_check_suffix): Likewise.
9858 (stap_check_integer_suffix): Likewise.
9859 (stap_check_register_suffix): Likewise.
9860 (stap_check_register_indirection_suffix): Likewise.
9861 (stap_parse_register_operand): Likewise.
9862 (stap_parse_single_operand): Likewise.
9863 (stap_parse_argument_1): Likewise.
9864 (stap_probe::get_argument_count): Likewise.
9865 (stap_is_operator): Likewise.
9866
9867 2019-05-16 Tom Tromey <tromey@adacore.com>
9868
9869 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9870 keyword to foreach.
9871
9872 2019-05-15 Simon Marchi <simon.marchi@efficios.com>
9873
9874 * linux-thread-db.c (try_thread_db_load_1): Change return type
9875 to bool.
9876 (try_thread_db_load): Likewise.
9877 (try_thread_db_load_from_pdir_1): Likewise.
9878 (try_thread_db_load_from_pdir): Likewise.
9879 (try_thread_db_load_from_sdir): Likewise.
9880 (try_thread_db_load_from_dir): Likewise.
9881 (thread_db_load_search): Likewise.
9882 (has_libpthread): Likewise.
9883 (thread_db_load): Likewise.
9884
9885 2019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
9886
9887 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9888 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9889 NULL, and complain/return if that's the case.
9890
9891 2019-05-15 John Darrington <john@darrington.wattle.id.au>
9892
9893 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9894 (advance, posn, abstract_read_memory): New functions.
9895 [struct mem_read_abstraction]: New struct.
9896 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9897
9898 2019-05-14 Tom Tromey <tromey@adacore.com>
9899
9900 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9901 value is not lval_memory.
9902
9903 2019-05-14 Tom Tromey <tromey@adacore.com>
9904
9905 * solib.c (info_sharedlibrary_command): Style the file name.
9906
9907 2019-05-14 Alan Hayward <alan.hayward@arm.com>
9908
9909 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9910 (aarch64_vnv_type): Likewise.
9911 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9912 * common/tdesc.c: Likewise.
9913 * common/tdesc.h (enum tdesc_type_kind): Likewise.
9914 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9915 * features/aarch64-fpu.xml: Add ieee half view.
9916 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9917 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9918 * gdbtypes.h (struct builtin_type): Likewise.
9919 (struct objfile_type): Likewise.
9920
9921 2019-05-12 Paul Naert <paul.naert@polymtl.ca>
9922
9923 * language.c (language_sniff_from_mangled_name): Fix "langauge"
9924 typo.
9925 * location.h (string_to_event_location): Likewise.
9926
9927 2019-05-11 Joel Brobecker <brobecker@adacore.com>
9928
9929 GDB 8.3 released.
9930
9931 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
9932
9933 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9934 New variable declaration.
9935 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9936 New variable.
9937 (print_one_breakpoint): Use ui_out::test_flags and new global
9938 variable to compute use_fixed_output.
9939 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9940 Remove.
9941 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9942 (mi_multi_location_breakpoint_output_fixed): Remove.
9943 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9944 new variable.
9945 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9946 fix_multi_location_breakpoint_output flag if version >= 3.
9947 * ui-out.h (enum ui_out_flag)
9948 <fix_multi_location_breakpoint_output>: New enumerator.
9949
9950 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
9951
9952 * contrib/cc-with-tweaks.sh: Validate dwz's work.
9953
9954 2019-05-10 Tom Tromey <tromey@adacore.com>
9955
9956 * ada-lang.c (catch_ada_completer): New function.
9957 (_initialize_ada_language): Use it.
9958
9959 2019-05-10 Tom Tromey <tromey@adacore.com>
9960
9961 * thread.c (print_thread_info): Make "requested_threads" const.
9962 * gdbthread.h (print_thread_info): Make "requested_threads"
9963 const.
9964 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9965 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9966
9967 2019-05-08 Tom Tromey <tom@tromey.com>
9968
9969 * gdbtypes.c (objfile_type_data): Change type.
9970 (objfile_type, _initialize_gdbtypes): Update.
9971
9972 2019-05-08 Tom Tromey <tom@tromey.com>
9973
9974 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9975 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9976 (_initialize_dwarf2_frame): Update.
9977
9978 2019-05-08 Tom Tromey <tom@tromey.com>
9979
9980 * objc-lang.c (objc_objfile_data): Change type.
9981 (find_methods): Update.
9982 (_initialize_objc_lang): Remove.
9983
9984 2019-05-08 Tom Tromey <tom@tromey.com>
9985
9986 * stabsread.c (rs6000_builtin_type_data): Change type.
9987 (rs6000_builtin_type, _initialize_stabsread): Update.
9988
9989 2019-05-08 Tom Tromey <tom@tromey.com>
9990
9991 * mips-tdep.c (mips_pdr_data): Remove.
9992 (_initialize_mips_tdep): Update.
9993
9994 2019-05-08 Tom Tromey <tom@tromey.com>
9995
9996 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9997 (hppa_init_objfile_priv_data, read_unwind_info)
9998 (find_unwind_entry, _initialize_hppa_tdep): Update.
9999
10000 2019-05-08 Tom Tromey <tom@tromey.com>
10001
10002 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10003 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
10004 on obstack.
10005 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10006
10007 2019-05-08 Tom Tromey <tom@tromey.com>
10008
10009 * mdebugread.c (basic_type_data): Change type.
10010 (basic_type, _initialize_mdebugread): Update.
10011
10012 2019-05-08 Tom Tromey <tom@tromey.com>
10013
10014 * common/gdb_unique_ptr.h (struct noop_deleter): New.
10015
10016 2019-05-08 Tom Tromey <tom@tromey.com>
10017
10018 * nto-tdep.c (nto_inferior_data_reg): Change type.
10019 (nto_inferior_data): Update.
10020 (nto_inferior_data_cleanup, nto_new_inferior_data)
10021 (_initialize_nto_tdep): Remove.
10022 * nto-tdep.h (struct nto_inferior_data): Add initializers.
10023
10024 2019-05-08 Tom Tromey <tom@tromey.com>
10025
10026 * ada-lang.c (struct ada_inferior_data): Add initializers.
10027 (ada_inferior_data): Change type.
10028 (ada_inferior_data_cleanup): Remove.
10029 (get_ada_inferior_data, ada_inferior_exit)
10030 (struct ada_pspace_data): Add initializers, destructor.
10031 (ada_pspace_data_handle): Change type.
10032 (get_ada_pspace_data): Update.
10033 (ada_pspace_data_cleanup): Remove.
10034
10035 2019-05-08 Tom Tromey <tom@tromey.com>
10036
10037 * coffread.c (struct coff_symfile_info): Add initializers.
10038 (coff_objfile_data_key): Move lower. Change type.
10039 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10040 Update.
10041 (coff_free_info): Remove.
10042
10043 2019-05-08 Tom Tromey <tom@tromey.com>
10044
10045 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10046 (fbsd_pspace_data_handle): Move lower. Change type.
10047 (get_fbsd_pspace_data): Update.
10048 (fbsd_pspace_data_cleanup): Remove.
10049 (_initialize_fbsd_tdep): Update.
10050
10051 2019-05-08 Tom Tromey <tom@tromey.com>
10052
10053 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10054 (get_ada_tasks_pspace_data): Update.
10055 (ada_tasks_pspace_data_cleanup): Remove.
10056 (_initialize_tasks): Update.
10057 (ada_tasks_inferior_data_handle): Change type.
10058 (get_ada_tasks_inferior_data): Update.
10059 (ada_tasks_inferior_data_cleanup): Remove.
10060 (struct ada_tasks_pspace_data): Add initializers.
10061
10062 2019-05-08 Tom Tromey <tom@tromey.com>
10063
10064 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10065 * symfile-debug.c (debug_sym_get_probes): Change type.
10066 * stap-probe.c (handle_stap_probe):
10067 (stap_static_probe_ops::get_probes): Change type.
10068 * probe.h (class static_probe_ops) <get_probes>: Change type.
10069 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10070 (parse_probes_in_pspace): Update.
10071 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10072 Update.
10073 (any_static_probe_ops::get_probes): Change type.
10074 * elfread.c (elfread_data): New typedef.
10075 (probe_key): Change type.
10076 (elf_get_probes): Likewise. Update.
10077 (probe_key_free): Remove.
10078 (_initialize_elfread): Update.
10079 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10080 Change type.
10081 (dtrace_process_dof_probe, dtrace_process_dof)
10082 (dtrace_static_probe_ops::get_probe): Change type.
10083
10084 2019-05-08 Tom Tromey <tom@tromey.com>
10085
10086 * xcoffread.c (struct xcoff_symfile_info): Rename from
10087 coff_symfile_info. Add initializers.
10088 (xcoff_objfile_data_key): Move lower. Change type.
10089 (XCOFF_DATA): Rewrite.
10090 (xcoff_free_info): Remove.
10091 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10092 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10093 (xcoff_initial_scan): Update.
10094
10095 2019-05-08 Tom Tromey <tom@tromey.com>
10096
10097 * solib-svr4.c (struct svr4_info): Add initializers and
10098 destructor.
10099 <probes_table>: Now an htab_up.
10100 (solib_svr4_pspace_data): Change type.
10101 (free_probes_table): Simplify.
10102 (~svr4_info): Rename from svr4_pspace_data_cleanup.
10103 (get_svr4_info, probes_table_htab_remove_objfile_probes)
10104 (probes_table_remove_objfile_probes, register_solib_event_probe)
10105 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10106 (_initialize_svr4_solib): Update.
10107
10108 2019-05-08 Tom Tromey <tom@tromey.com>
10109
10110 * remote.c (remote_pspace_data): Change type.
10111 (remote_pspace_data_cleanup): Remove.
10112 (get_remote_exec_file, set_pspace_remote_exec_file)
10113 (_initialize_remote): Update.
10114
10115 2019-05-08 Tom Tromey <tom@tromey.com>
10116
10117 * breakpoint.c (breakpoint_objfile_key): Change type.
10118 (get_breakpoint_objfile_data): Update.
10119 (free_breakpoint_objfile_data): Remove.
10120 (_initialize_breakpoint): Update.
10121
10122 2019-05-08 Tom Tromey <tom@tromey.com>
10123
10124 * linux-tdep.c (struct linux_info): Add initializers.
10125 (linux_inferior_data): Move. Change type.
10126 (invalidate_linux_cache_inf): Update.
10127 (linux_inferior_data_cleanup): Remove.
10128 (get_linux_inferior_data, _initialize_linux_tdep): Update.
10129
10130 2019-05-08 Tom Tromey <tom@tromey.com>
10131
10132 * auxv.c (auxv_inferior_data): Move. Change type.
10133 (auxv_inferior_data_cleanup): Remove.
10134 (invalidate_auxv_cache_inf): Rewrite.
10135 (get_auxv_inferior_data, _initialize_auxv): Update.
10136
10137 2019-05-08 Tom Tromey <tom@tromey.com>
10138
10139 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10140 (symfile_debug_objfile_data_key): Change type.
10141 (symfile_debug_installed, debug_qf_has_symbols)
10142 (debug_qf_find_last_source_symtab)
10143 (debug_qf_forget_cached_source_info)
10144 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10145 (debug_qf_print_stats, debug_qf_dump)
10146 (debug_qf_expand_symtabs_for_function)
10147 (debug_qf_expand_all_symtabs)
10148 (debug_qf_expand_symtabs_with_fullname)
10149 (debug_qf_map_matching_symbols)
10150 (debug_qf_expand_symtabs_matching)
10151 (debug_qf_find_pc_sect_compunit_symtab)
10152 (debug_qf_map_symbol_filenames)
10153 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10154 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10155 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10156 (debug_sym_read_linetable, debug_sym_relocate): Update.
10157 (symfile_debug_free_objfile): Remove.
10158 (install_symfile_debug_logging, _initialize_symfile_debug):
10159 Update.
10160
10161 2019-05-08 Tom Tromey <tom@tromey.com>
10162
10163 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10164 allocate_on_obstack.
10165 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10166 (get_dwarf2_per_objfile): Update.
10167 (set_dwarf2_per_objfile): Remove.
10168 (dwarf2_has_info, dwarf2_get_section_info): Update.
10169 (dwarf2_free_objfile): Remove.
10170 (_initialize_dwarf2_read): Update.
10171
10172 2019-05-08 Tom Tromey <tom@tromey.com>
10173
10174 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10175 initializers.
10176 <unsupported_script_warning_printed,
10177 script_not_found_warning_printed>: Now bool.
10178 (auto_load_pspace_data): Change type.
10179 (~auto_load_pspace_info): Rename from
10180 auto_load_pspace_data_cleanup.
10181 (get_auto_load_pspace_data, init_loaded_scripts_info)
10182 (clear_section_scripts, maybe_print_unsupported_script_warning)
10183 (maybe_print_script_not_found_warning, _initialize_auto_load):
10184 Update.
10185
10186 2019-05-08 Tom Tromey <tom@tromey.com>
10187
10188 * objfiles.c (objfile_pspace_info): Add destructor and
10189 initializers.
10190 (objfiles_pspace_data): Change type.
10191 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10192 (get_objfile_pspace_data): Update.
10193 (objfiles_bfd_data): Change type.
10194 (get_objfile_bfd_data): Update.
10195 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10196
10197 2019-05-08 Tom Tromey <tom@tromey.com>
10198
10199 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10200 Change type.
10201 (get_catch_syscall_inferior_data): Update.
10202 (catch_syscall_inferior_data_cleanup): Remove.
10203 (_initialize_break_catch_syscall): Update.
10204
10205 2019-05-08 Tom Tromey <tom@tromey.com>
10206
10207 * inflow.c (struct terminal_info): Add destructor and
10208 initializers.
10209 (inflow_inferior_data): Change type.
10210 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10211 (get_inflow_inferior_data, inflow_inferior_exit)
10212 (swap_terminal_info, _initialize_inflow): Update.
10213
10214 2019-05-08 Tom Tromey <tom@tromey.com>
10215
10216 * target-dcache.c (target_dcache_cleanup): Remove.
10217 (target_dcache_aspace_key): Change type.
10218 (target_dcache_init_p, target_dcache_invalidate)
10219 (target_dcache_get, target_dcache_get_or_init)
10220 (_initialize_target_dcache): Update.
10221 * dcache.h (struct dcache_deleter): New.
10222
10223 2019-05-08 Tom Tromey <tom@tromey.com>
10224
10225 * symtab.c (struct symbol_cache): Add destructor and
10226 initializers.
10227 (symbol_cache_key): Move. Change type.
10228 (make_symbol_cache, free_symbol_cache): Remove.
10229 (get_symbol_cache): Update.
10230 (symbol_cache_cleanup): Remove.
10231 (ALL_PSPACES, symbol_cache_flush)
10232 (maintenance_print_symbol_cache)
10233 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10234 Update.
10235
10236 2019-05-08 Tom Tromey <tom@tromey.com>
10237
10238 * symtab.c (struct main_info): Add destructor and initializers.
10239 (main_progspace_key): Move. Change type.
10240 (get_main_info): Update.
10241 (main_info_cleanup): Remove.
10242 (_initialize_symtab): Update.
10243
10244 2019-05-08 Tom Tromey <tom@tromey.com>
10245
10246 * registry.h (DECLARE_REGISTRY): Define the _key class.
10247
10248 2019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10249
10250 * NEWS: Merge two 'New commands' sections.
10251
10252 2019-05-08 Joel Brobecker <brobecker@adacore.com>
10253
10254 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10255 parameter and use Ada language definition instead.
10256 (ada_val_print_ptr): Remove unused language parameter.
10257 (ada_val_print_num): Remove language parameter and use Ada language
10258 definition instead.
10259 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10260 parameter.
10261 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10262 parameter and use Ada language definition instead.
10263 (ada_val_print_1): Update all ada_val_print_xxx calls.
10264 Remove language parameter.
10265 (ada_val_print): Update ada_val_print_1 call.
10266
10267 2019-05-08 Tom Tromey <tromey@adacore.com>
10268
10269 * remote.c (remote_hw_watchpoint_limit)
10270 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10271 Now static.
10272
10273 2019-05-08 Tom Tromey <tromey@adacore.com>
10274
10275 * maint.c (_initialize_maint_cmds): Move initialization code to
10276 remote.c.
10277 (watchdog, show_watchdog): Move to remote.c.
10278 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10279 "watchdog" static.
10280 (_initialize_remote): Move initialization code from maint.c.
10281 * defs.h (watchdog): Don't declare.
10282
10283 2019-05-08 Tom Tromey <tromey@adacore.com>
10284
10285 * tui/tui-interp.c: Include main.h.
10286 * interps.c: Include main.h.
10287 * main.h (interpreter_p): Declare.
10288 * defs.h (interpreter_p): Don't declare.
10289
10290 2019-05-08 Tom Tromey <tromey@adacore.com>
10291
10292 * dwarf2loc.c: Include dwarf2read.h.
10293 * defs.h (read_unsigned_leb128): Don't declare.
10294 * dwarf2read.h (read_unsigned_leb128): Declare.
10295
10296 2019-05-08 Tom Tromey <tromey@adacore.com>
10297
10298 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10299 method.
10300
10301 2019-05-08 Tom Tromey <tromey@adacore.com>
10302
10303 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10304 when no wrap column is set.
10305
10306 2019-05-08 Tom Tromey <tromey@adacore.com>
10307
10308 * c-lang.c (c_get_string): Handle non-C-style arrays.
10309
10310 2019-05-08 Tom Tromey <tromey@adacore.com>
10311
10312 * typeprint.c (print_offset_data::update): Print the bit offset,
10313 not the number of bits remaining.
10314
10315 2019-05-08 Tom Tromey <tromey@adacore.com>
10316
10317 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10318 padding at end of comment.
10319
10320 2019-05-08 Tom Tromey <tromey@adacore.com>
10321
10322 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10323 Compare main types.
10324
10325 2019-05-06 Tom Tromey <tom@tromey.com>
10326
10327 * common/scoped_mmap.c: Include common-defs.h.
10328 * common/scoped_mmap.h: Don't include config.h.
10329
10330 2019-05-04 Tom Tromey <tom@tromey.com>
10331
10332 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10333 (struct aarch64_call_info): Add initializers.
10334 <si>: Now a std::vector.
10335 (pass_on_stack, aarch64_push_dummy_call): Update.
10336
10337 2019-05-04 Simon Marchi <simon.marchi@efficios.com>
10338 Tom Tromey <tom@tromey.com>
10339
10340 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10341 (ppc_threads): Now a std::vector. Now static.
10342 (hwdebug_find_thread_points_by_tid)
10343 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10344 Update.
10345
10346 2019-05-04 Tom Tromey <tom@tromey.com>
10347
10348 * arc-tdep.c (arc_tdesc_init): Return bool.
10349
10350 2019-05-04 Tom Tromey <tom@tromey.com>
10351
10352 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10353 Use gdb_assert_not_reached.
10354
10355 2019-05-04 Tom Tromey <tom@tromey.com>
10356
10357 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10358 "false".
10359
10360 2019-05-04 Tom Tromey <tom@tromey.com>
10361
10362 * arc-tdep.c (arc_tdesc_init): Use bool.
10363
10364 2019-05-04 Tom Tromey <tom@tromey.com>
10365
10366 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10367
10368 2019-05-04 Tom Tromey <tom@tromey.com>
10369
10370 * cli/cli-cmds.c (valid_command_p): Return bool.
10371
10372 2019-05-04 Tom Tromey <tom@tromey.com>
10373
10374 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10375 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10376
10377 2019-05-04 Raul Tambre <raul@tambre.ee>
10378
10379 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10380 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10381 operator for comparison.
10382
10383 2019-05-04 Tom Tromey <tom@tromey.com>
10384
10385 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10386 (lookup_partial_symbol, print_partial_symbols)
10387 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10388 (psymbol_compare): Update.
10389 (add_psymbol_to_bcache): Clear the entire psymbol.
10390 (maintenance_check_psymtabs): Update.
10391 * psympriv.h (struct partial_symbol): Don't derive from
10392 general_symbol_info.
10393 <obj_section, unrelocated_address, address,
10394 set_unrelocated_address>: Update.
10395 <ginfo>: New member.
10396 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10397 (debug_names::write_psymbols): Update.
10398
10399 2019-05-04 Tom de Vries <tdevries@suse.de>
10400
10401 * contrib/cc-with-tweaks.sh: Support -n arg.
10402
10403 2019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10404
10405 * corelow.c (core_target::detach): Ensure frame cache and
10406 register caches are cleared.
10407 inferior.c (exit_inferior_1): Likewise.
10408
10409 2019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10410 Tom Tromey <tom@tromey.com>
10411
10412 * dictionary.c (collate_pending_symbols_by_language): Remove
10413 "struct" from foreach.
10414 * symtab.c (lookup_global_symbol_from_objfile)
10415 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10416 foreach.
10417 * ser-tcp.c (net_open): Remove "struct" from foreach.
10418 * objfiles.c (objfile_relocate, objfile_rebase)
10419 (objfile_has_symbols): Remove "struct" from foreach.
10420 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10421 from foreach.
10422 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10423 foreach.
10424 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10425 "struct" from foreach.
10426 * ada-lang.c (create_excep_cond_exprs)
10427 (ada_exception_catchpoint_cond_string): Remove "struct" from
10428 foreach.
10429
10430 2019-05-03 Tom Tromey <tromey@adacore.com>
10431
10432 * ada-exp.y (convert_char_literal): Check suffix of each
10433 enumerator.
10434
10435 2019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10436
10437 PR ada/21406:
10438 * ada-exp.y (yywrap): Don't define.
10439 * ada-lex.l (%option): Add noyywrap
10440 (yywrap): Remove.
10441
10442 2019-05-03 Eli Zaretskii <eliz@gnu.org>
10443
10444 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10445 _WIN32_WINNT to the XP level, unless already defined to a higher
10446 level.
10447
10448 * unittests/parse-connection-spec-selftests.c:
10449 * ser-tcp.c:
10450 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10451 override.
10452
10453 * symfile.c (find_separate_debug_file): Remove colon from the
10454 drive spec of DOS/Windows file names of the target, so that the
10455 file name produced from DEBUGDIR and the target's directory will
10456 be valid on DOS/Windows systems.
10457
10458 2019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10459
10460 * rust-lang.c (val_print_struct): Handle printing structures
10461 containing strings.
10462
10463 2019-05-02 Tom Tromey <tromey@adacore.com>
10464
10465 * valarith.c (_initialize_valarith): Remove.
10466
10467 2019-05-01 Tom Tromey <tromey@adacore.com>
10468
10469 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10470 bitfields.
10471
10472 2019-05-01 Tom Tromey <tromey@adacore.com>
10473
10474 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10475 for big-endian copies.
10476
10477 2019-04-30 Ali Tamur <tamur@google.com>
10478 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10479 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10480 (read_3_bytes): New function.
10481
10482 2019-04-30 Joel Brobecker <brobecker@adacore.com>
10483
10484 * windows-nat.c (main_thread_id): Delete.
10485 (handle_output_debug_string): Replace main_thread_id by
10486 current_event.dwThreadId.
10487 (fake_create_process): Likewise.
10488 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10489 Do not set main_thread_id.
10490 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10491 current_event.dwThreadId.
10492 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10493
10494 2019-04-30 Joel Brobecker <brobecker@adacore.com>
10495
10496 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10497 Use current_event.dwThreadId instead of main_thread_id.
10498
10499 2019-04-30 Tom Tromey <tromey@adacore.com>
10500
10501 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10502 (create_excep_cond_exprs): Iterate over program spaces.
10503 (ada_exception_catchpoint_cond_string): Examine all minimal
10504 symbols for exception types.
10505
10506 2019-04-30 Tom Tromey <tromey@adacore.com>
10507
10508 PR c++/24470:
10509 * dwarf2read.c (process_structure_scope): Handle case where type
10510 has template parameters but no symbol was created.
10511
10512 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10513 Chris January <chris.january@arm.com>
10514
10515 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10516 qualifier.
10517 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10518
10519 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10520
10521 * f-typeprint.c (f_print_type): Update rules for printing
10522 whitespace.
10523 (f_type_print_varspec_suffix): Likewise.
10524
10525 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10526 Chris January <chris.january@arm.com>
10527
10528 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10529 function arguments.
10530
10531 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10532
10533 * f-lang.c (build_fortran_types): Change name of void type to
10534 lower case.
10535 * f-typeprint.c (f_type_print_base): Print the name of the void
10536 type, rather than a fixed string.
10537 * f-valprint.c (f_decorations): Use lower case void string.
10538
10539 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10540 Chris January <chris.january@arm.com>
10541
10542 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10543 types for Fortran.
10544
10545 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10546 Chris January <chris.january@arm.com>
10547 David Lecomber <david.lecomber@arm.com>
10548
10549 * f-exp.y (BINOP_INTRINSIC): New token.
10550 (exp): New parser rule handling BINOP_INTRINSIC.
10551 (f77_keywords): Add new builtin procedures.
10552 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10553 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10554 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10555 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10556 (print_unop_subexp_f): New function.
10557 (print_binop_subexp_f): New function.
10558 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10559 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10560 (dump_subexp_body_f): Likewise.
10561 (operator_check_f): Likewise.
10562 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10563 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10564
10565 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10566
10567 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10568 UNOP_KIND.
10569 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10570 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10571 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10572 (operator_length_f): New fuction.
10573 (print_subexp_f): New function.
10574 (op_name_f): New function.
10575 (dump_subexp_body_f): New function.
10576 (operator_check_f): New function.
10577 (exp_descriptor_f): Replace standard expression handling functions
10578 with new functions.
10579 * gdb/fortran-operator.def: New file.
10580 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10581 * gdb/std-operator.def: Remove UNOP_KIND.
10582
10583 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10584
10585 * std-operator.def: Remove unbalanced, stray double quote
10586 character.
10587
10588 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10589 Chris January <chris.january@arm.com>
10590 Daniel Everett <daniel.everett@arm.com>
10591 Nick Forrington <nick.forrington@arm.com>
10592 Richard Bunt <richard.bunt@arm.com>
10593
10594 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10595 of depth when printing anonymous structs or unions.
10596 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10597 Don't print either the top-level value, or the children if the
10598 max-depth is exceeded.
10599 (ppscm_print_children): When printing the key of a map, allow one
10600 extra level of depth.
10601 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10602 print either the top-level value, or the children if the max-depth
10603 is exceeded.
10604 (print_children): When printing the key of a map, allow one extra
10605 level of depth.
10606 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10607 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10608 (user_print_options): Initialise max_depth field.
10609 (val_print_scalar_or_string_type_p): New function.
10610 (val_print): Check to see if the max depth has been reached.
10611 (val_print_check_max_depth): Define new function.
10612 (show_print_max_depth): New function.
10613 (_initialize_valprint): Add 'print max-depth' option.
10614 * valprint.h (struct value_print_options) <max_depth>: New field.
10615 (val_print_check_max_depth): Declare new function.
10616 * NEWS: Document new feature.
10617
10618 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10619
10620 * ada-lang.c (ada_language_defn): Initialise new field.
10621 * c-lang.c (c_is_string_type_p): New function.
10622 (c_language_defn): Initialise new field.
10623 (cplus_language_defn): Initialise new field.
10624 (asm_language_defn): Initialise new field.
10625 (minimal_language_defn): Initialise new field.
10626 * c-lang.h (c_is_string_type_p): Declare new function.
10627 * d-lang.c (d_language_defn): Initialise new field.
10628 * f-lang.c (f_is_string_type_p): New function.
10629 (f_language_defn): Initialise new field.
10630 * go-lang.c (go_is_string_type_p): New function.
10631 (go_language_defn): Initialise new field.
10632 * language.c (default_is_string_type_p): New function.
10633 (unknown_language_defn): Initialise new field.
10634 (auto_language_defn): Initialise new field.
10635 * language.h (struct language_defn) <la_is_string_type_p>: New
10636 member variable.
10637 (default_is_string_type_p): Declare new function.
10638 * m2-lang.c (m2_language_defn): Initialise new field.
10639 * objc-lang.c (objc_language_defn): Initialise new field.
10640 * opencl-lang.c (opencl_language_defn): Initialise new field.
10641 * p-lang.c (pascal_is_string_type_p): New function.
10642 (pascal_language_defn): Initialise new field.
10643 * rust-lang.c (rust_is_string_type_p): New function.
10644 (rust_language_defn): Initialise new field.
10645
10646 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10647
10648 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10649 New field.
10650 * ada-lang.c (ada_language_defn): Initialise new field.
10651 * c-lang.c (c_language_defn): Likewise.
10652 (cplus_language_defn): Likewise.
10653 (asm_language_defn): Likewise.
10654 (minimal_language_defn): Likewise.
10655 * d-lang.c (d_language_defn): Likewise.
10656 * f-lang.c (f_language_defn): Likewise.
10657 * go-lang.c (go_language_defn): Likewise.
10658 * language.c (unknown_language_defn): Likewise.
10659 (auto_language_defn): Likewise.
10660 * m2-lang.c (m2_language_defn): Likewise.
10661 * objc-lang.c (objc_language_defn): Likewise.
10662 * opencl-lang.c (opencl_language_defn): Likewise.
10663 * p-lang.c (pascal_language_defn): Likewise.
10664 * rust-lang.c (rust_language_defn): Likewise.
10665
10666 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10667
10668 * ada-lang.c (ada_is_character_type): Change return type to bool.
10669 (ada_is_string_type): Likewise.
10670 * ada-lang.h (ada_is_character_type): Update declaration
10671 (ada_is_string_type): Likewise.
10672
10673 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10674
10675 Support style in 'frame|thread apply'
10676
10677 * gdbcmd.h (execute_command_to_string): New term_out parameter.
10678 * record.c (record_start, record_stop): Update callers of
10679 execute_command_to_string with false.
10680 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10681 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10682 methods.
10683 (class string_file): New constructor with term_out parameter.
10684 Override methods term_out and can_emit_style_escape. New member
10685 term_out.
10686 (class stdio_file): Override can_emit_style_escape.
10687 (class tee_file): Override term_out and can_emit_style_escape.
10688 * utils.h (can_emit_style_escape): Remove.
10689 * utils.c (can_emit_style_escape): Likewise.
10690 Update all callers of can_emit_style_escape (SOMESTREAM) to
10691 SOMESTREAM->can_emit_style_escape.
10692 * source-cache.c (source_cache::get_source_lines): Likewise.
10693 * stack.c (frame_apply_command_count): Call execute_command_to_string
10694 passing the term_out characteristic of the current gdb_stdout.
10695 * thread.c (thr_try_catch_cmd): Likewise.
10696 * top.c (execute_command_to_string): pass term_out parameter
10697 to construct the string_file for the command output.
10698 * ui-file.c (term_cli_styling): New function (most code moved
10699 from utils.c can_emit_style_escape).
10700 (string_file::string_file, string_file::can_emit_style_escape,
10701 stdio_file::can_emit_style_escape, tee_file::term_out,
10702 tee_file::can_emit_style_escape): New functions.
10703
10704 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10705
10706 * NEWS: Mention the new set|show may-call-functions.
10707 * infcall.c (may_call_functions_p): New variable.
10708 (show_may_call_functions_p): New function.
10709 (call_function_by_hand_dummy): Throws an error if not
10710 may-call-functions.
10711 (_initialize_infcall): Call add_setshow_boolean_cmd for
10712 may-call-functions.
10713
10714 2019-04-25 Keith Seitz <keiths@redhat.com>
10715
10716 PR c++/24367
10717 * cp-support.c (inspect_type): Don't attempt substitutions
10718 of symbol with the same name.
10719
10720 2019-04-25 Tom Tromey <tromey@adacore.com>
10721
10722 PR gdb/24475:
10723 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10724 static.
10725
10726 2019-04-25 Tom Tromey <tromey@adacore.com>
10727
10728 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10729 rvalue reference.
10730 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10731 (gdb_xml_parser::parse): Use std::move.
10732 * python/python-internal.h (gdbpy_convert_exception): Take a const
10733 reference.
10734 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10735 std::move.
10736 * python/py-utils.c (gdbpy_convert_exception): Take a const
10737 reference.
10738 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10739 Use std::move.
10740 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10741 Use std::move.
10742 * mi/mi-main.c (mi_print_exception): Take a const reference.
10743 * main.c (handle_command_errors): Take a const reference.
10744 * linespec.c (parse_linespec): Use std::move.
10745 * infcall.c (run_inferior_call): Use std::move.
10746 (call_function_by_hand_dummy): Use std::move.
10747 * exec.c (try_open_exec_file): Use std::move.
10748 * exceptions.h (exception_print, exception_fprintf)
10749 (exception_print_same): Update.
10750 * exceptions.c (print_exception, exception_print)
10751 (exception_fprintf, exception_print_same): Change parameters to
10752 const reference.
10753 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10754 * common/new-op.c: Use std::move.
10755 * common/common-exceptions.h (struct gdb_exception): Add move
10756 constructor.
10757 (struct gdb_exception_error, struct gdb_exception_quit, struct
10758 gdb_quit_bad_alloc): Change constructor to move constructor.
10759 (throw_exception): Change parameter to rvalue reference.
10760 * common/common-exceptions.c (throw_exception): Take rvalue
10761 reference.
10762 * cli/cli-interp.c (safe_execute_command): Use std::move.
10763 * breakpoint.c (insert_bp_location, location_to_sals): Use
10764 std::move.
10765
10766 2019-04-25 Tom Tromey <tromey@adacore.com>
10767
10768 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10769 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10770 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10771 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10772 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10773 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10774 guile/scm-value.c: Use unpack.
10775 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10776 gdbscm_gdb_exception.
10777 (gdbscm_throw_gdb_exception): Likewise.
10778 (struct gdbscm_gdb_exception): New.
10779 (unpack): New function.
10780 (gdbscm_wrap): Use unpack.
10781
10782 2019-04-25 Tom Tromey <tromey@adacore.com>
10783
10784 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10785 (gdb_rl_callback_handler): Use std::move.
10786 * common/common-exceptions.h (struct gdb_exception): Add move
10787 assignment operator.
10788 (throw_exception_sjlj): Change "exception" to const reference.
10789 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10790 (throw_exception_sjlj): Change "exception" to const reference.
10791
10792 2019-04-25 Tom Tromey <tromey@adacore.com>
10793
10794 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10795 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10796 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10797 Update.
10798 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10799 Update.
10800 * mi/mi-interp.c (mi_interp::exec): Update.
10801 * linespec.c (parse_linespec): Update.
10802 * infcall.c (run_inferior_call): Update.
10803 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10804 * guile/scm-symbol.c (gdbscm_lookup_symbol)
10805 (gdbscm_lookup_global_symbol): Update.
10806 * guile/scm-param.c (gdbscm_parameter_value): Update.
10807 * guile/scm-frame.c (gdbscm_frame_read_register)
10808 (gdbscm_frame_read_var): Update.
10809 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10810 * exec.c (try_open_exec_file): Update.
10811 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10812 (gdb_rl_callback_handler): Update.
10813 * common/common-exceptions.h (exception_none): Don't declare.
10814 * common/common-exceptions.c (exception_none): Don't define.
10815 (struct catcher) <exception>: Update.
10816 * cli/cli-interp.c (safe_execute_command): Update.
10817 * breakpoint.c (insert_bp_location, location_to_sals): Update.
10818
10819 2019-04-25 Ali Tamur <tamur@google.com>
10820
10821 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10822 (read_attribute_value): Likewise.
10823 (dwarf2_read_addr_index): Update comment.
10824 (read_str_index): Add DW_FORM_strx.
10825 (dwarf2_string_attr): Likewise.
10826 (dwarf2_const_value_attr): Likewise.
10827 (dump_die_shallow): Likewise.
10828 (dwarf2_fetch_constant_bytes): Likewise.
10829 (skip_form_bytes): Likewise.
10830 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10831
10832 2019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
10833
10834 PR corefiles/11608
10835 PR corefiles/18187
10836 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10837 OFFSET. Verify if current mapping contains an ELF header.
10838 (linux_find_memory_regions_full): Adjust call to
10839 dump_mapping_p.
10840
10841 2019-04-25 Sandra Loosemore <sandra@codesourcery.com>
10842 Kang Li <kanglictf@gmail.com>
10843
10844 PR gdb/21600
10845
10846 * dwarf2-frame.c (read_initial_length): Be consistent about using
10847 unsigned representation of length.
10848 (decode_frame_entry_1): Likewise. Check for wraparound of
10849 end pointer as well as buffer overflow.
10850
10851 2019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
10852
10853 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10854 "vq".
10855
10856 2019-04-24 Tom Tromey <tromey@adacore.com>
10857
10858 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10859
10860 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10861
10862 * s12z-tdep.c (s12z_unwind_pc): Delete.
10863 (s12z_unwind_sp): Delete.
10864 (s12z_gdbarch_init): Don't register deleted functions with
10865 gdbarch.
10866
10867 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10868
10869 * rl78-tdep.c (rl78_unwind_sp): Delete.
10870 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10871
10872 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10873
10874 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10875 (xstormy16_unwind_pc): Delete.
10876 (xstormy16_dummy_id): Delete.
10877 (xstormy16_gdbarch_init): Don't register deleted functions with
10878 gdbarch.
10879
10880 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10881
10882 * vax-tdep.c (vax_unwind_pc): Delete.
10883 (vax_gdbarch_init): Don't register deleted function with gdbarch.
10884
10885 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10886
10887 * v850-tdep.c (v850_unwind_sp): Delete.
10888 (v850_unwind_pc): Delete.
10889 (v850_dummy_id): Delete.
10890 (v850_gdbarch_init): Don't register deleted functions with
10891 gdbarch.
10892
10893 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10894
10895 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10896 (tilegx_unwind_pc): Delete.
10897 (tilegx_unwind_dummy_id): Delete.
10898 (tilegx_gdbarch_init): Don't register deleted functions with
10899 gdbarch.
10900
10901 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10902
10903 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10904 (tic6x_dummy_id): Delete.
10905 (tic6x_gdbarch_init): Don't register deleted functions with
10906 gdbarch.
10907
10908 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10909
10910 * sparc-tdep.c (sparc_unwind_pc): Delete.
10911 (sparc32_gdbarch_init): Don't register deleted function with
10912 gdbarch.
10913
10914 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10915
10916 * sh-tdep.c (sh_unwind_sp): Delete.
10917 (sh_unwind_pc): Delete.
10918 (sh_dummy_id): Delete.
10919 (sh_gdbarch_init): Don't register deleted functions with
10920 gdbarch.
10921
10922 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10923
10924 * score-tdep.c (score_unwind_sp): Delete.
10925 (score_unwind_pc): Delete.
10926 (score_dummy_id): Delete.
10927 (score_gdbarch_init): Don't register deleted functions with
10928 gdbarch.
10929
10930 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10931
10932 * rx-tdep.c (rx_unwind_pc): Delete.
10933 (rx_unwind_sp): Delete.
10934 (rx_dummy_id): Delete.
10935 (rx_gdbarch_init): Don't register deleted functions with
10936 gdbarch. Update comment.
10937
10938 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10939
10940 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10941 (rs6000_dummy_id): Delete.
10942 (rs6000_gdbarch_init): Don't register deleted functions with
10943 gdbarch.
10944
10945 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10946
10947 * or1k-tdep.c (or1k_dummy_id): Delete.
10948 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10949
10950 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10951
10952 * nios2-tdep.c (nios2_dummy_id): Delete.
10953 (nios2_unwind_sp): Delete.
10954 (nios2_gdbarch_init): Don't register deleted functions with
10955 gdbarch.
10956
10957 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10958
10959 * nds32-tdep.c (nds32_dummy_id): Delete.
10960 (nds32_unwind_pc): Delete.
10961 (nds32_unwind_sp): Delete.
10962 (nds32_gdbarch_init): Don't register deleted functions with
10963 gdbarch.
10964
10965 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10966
10967 * msp430-tdep.c (msp430_unwind_pc): Delete.
10968 (msp430_unwind_sp): Delete.
10969 (msp430_dummy_id): Delete.
10970 (msp430_gdbarch_init): Don't register deleted functions with
10971 gdbarch.
10972
10973 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10974
10975 * moxie-tdep.c (moxie_unwind_sp): Delete.
10976 (moxie_unwind_pc): Delete.
10977 (moxie_dummy_id): Delete.
10978 (moxie_gdbarch_init): Don't register deleted functions with
10979 gdbarch.
10980
10981 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10982
10983 * mn10300-tdep.c (mn10300_dummy_id): Delete.
10984 (mn10300_unwind_pc): Delete.
10985 (mn10300_unwind_sp): Delete.
10986 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10987 mn10300_unwind_sp.
10988 (mn10300_frame_unwind_init): Don't register deleted functions with
10989 gdbarch.
10990
10991 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10992
10993 * mep-tdep.c (mep_unwind_pc): Delete.
10994 (mep_unwind_sp): Delete.
10995 (mep_dummy_id): Delete.
10996 (mep_gdbarch_init): Don't register deleted functions with
10997 gdbarch.
10998
10999 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11000
11001 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11002 (m68hc11_unwind_sp): Delete.
11003 (m68hc11_gdbarch_init): Don't register deleted functions with
11004 gdbarch.
11005
11006 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11007
11008 * m32r-tdep.c (m32r_unwind_sp): Delete.
11009 (m32r_unwind_pc): Delete.
11010 (m32r_dummy_id): Delete.
11011 (m32r_gdbarch_init): Don't register deleted functions with
11012 gdbarch.
11013
11014 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11015
11016 * m32c-tdep.c (m32c_unwind_pc): Delete.
11017 (m32c_unwind_sp): Delete.
11018 (m32c_dummy_id): Delete.
11019 (m32c_gdbarch_init): Don't register deleted functions with
11020 gdbarch.
11021
11022 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11023
11024 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11025 (lm32_unwind_pc): Delete.
11026 (lm32_dummy_id): Delete.
11027 (lm32_gdbarch_init): Don't register deleted functions with
11028 gdbarch.
11029
11030 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11031
11032 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11033 (iq2000_unwind_pc): Delete.
11034 (iq2000_dummy_id): Delete.
11035 (iq2000_gdbarch_init): Don't register deleted functions with
11036 gdbarch.
11037
11038 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11039
11040 * nds32-tdep.c (nds32_type_align): Delete.
11041 (nds32_push_dummy_call): Use type_align instead.
11042
11043 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11044
11045 * arm-tdep.c (arm_type_align): Only handle vector override case.
11046 (arm_push_dummy_call): Use type_align.
11047 (arm_gdbarch_init): Register arm_type_align gdbarch function.
11048
11049 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11050
11051 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11052 case.
11053 (pass_on_stack): Use type_align.
11054 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11055 function.
11056
11057 2019-04-23 Tom Tromey <tromey@adacore.com>
11058
11059 * dwarf2read.c (line_header::file_name_at): Remove unused
11060 overload.
11061
11062 2019-04-23 Tom de Vries <tdevries@suse.de>
11063
11064 PR gdb/24438
11065 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11066 invocation.
11067
11068
11069 2019-03-27 Ali Tamur <tamur@google.com>
11070
11071 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11072 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11073 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11074 (dwarf_expr_context::get_addr_index): Likewise
11075 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11076 (symbol_needs_eval_context::get_addr_index): Likewise
11077 (disassemble_dwarf_expression): Add DW_OP_addrx
11078 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11079 (read_cutu_die_from_dwo): Update comment
11080 (skip_one_die): Add DW_FORM_addrx
11081 (read_attribute_value): Likewise
11082 (var_decode_location): Add DW_OP_addrx
11083 (dwarf2_const_value_attr): Add DW_FORM_addrx
11084 (dump_die_shallow): Likewise
11085 (dwarf2_fetch_constant_bytes): Likewise
11086 (decode_locdesc): Add DW_OP_addrx
11087 (skip_form_bytes): Add DW_FORM_addrx
11088
11089 2019-04-22 Ali Tamur <tamur@google.com>
11090
11091 * MAINTAINERS (Write After Approval): Add self.
11092
11093 2019-04-22 Simon Marchi <simon.marchi@efficios.com>
11094
11095 * solib-svr4.c (get_svr4_info): Add pspace parameter.
11096 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11097 (open_symbol_file_object): Likewise.
11098 (svr4_default_sos): Add info parameter.
11099 (svr4_read_so_list): Likewise.
11100 (svr4_current_sos_direct): Adjust functions calls to pass down
11101 info.
11102 (svr4_current_sos_1): Add info parameter.
11103 (svr4_current_sos): Call get_svr4_info, pass info down to
11104 svr4_current_sos_1.
11105 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11106 get_svr4_info.
11107 (svr4_in_dynsym_resolve_code): Pass current_program_space to
11108 get_svr4_info.
11109 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11110 to get_svr4_info.
11111 (probes_table_remove_objfile_probes): Likewise.
11112 (register_solib_event_probe): Add info parameter.
11113 (solist_update_incremental): Pass info parameter down to
11114 svr4_read_so_list.
11115 (disable_probes_interface): Add info parameter.
11116 (svr4_handle_solib_event): Pass current_program_space to
11117 get_svr4_info. Adjust disable_probes_interface cleanup.
11118 (svr4_create_probe_breakpoints): Add info parameter, pass it
11119 down to register_solib_event_probe.
11120 (svr4_create_solib_event_breakpoints): Add info parameter,
11121 pass it down to svr4_create_probe_breakpoints.
11122 (enable_break): Pass info down to
11123 svr4_create_solib_event_breakpoints.
11124 (svr4_solib_create_inferior_hook): Pass current_program_space to
11125 get_svr4_info.
11126 (svr4_clear_solib): Likewise.
11127
11128 2019-04-22 Pedro Alves <palves@redhat.com>
11129
11130 * solib-svr4.c (svr4_free_objfile_observer): New.
11131 (probe_and_action::objfile): New field.
11132 (probes_table_htab_remove_objfile_probes)
11133 (probes_table_remove_objfile_probes): New functions.
11134 (register_solib_event_probe): Add 'objfile' parameter. Store it
11135 in the new probe_and_action. Don't store the probe in 'lookup'.
11136 (svr4_create_probe_breakpoints): Pass objfile to
11137 register_solib_event_probe.
11138 (_initialize_svr4_solib): Register a free_objfile observer.
11139
11140 2019-04-19 Tom Tromey <tom@tromey.com>
11141
11142 * common/queue.h: Remove.
11143
11144 2019-04-19 Tom Tromey <tom@tromey.com>
11145
11146 * event-loop.c: Don't include "common/queue.h".
11147
11148 2019-04-19 Tom Tromey <tom@tromey.com>
11149
11150 * remote.c (remote_target): Use delete.
11151 * remote-notif.h: Include <list>, not "common/queue.h".
11152 (notif_client_p): Remove typedef.
11153 (remote_notif_state): Add constructor, destructor, initializer.
11154 <notif_queue>: Now a std::list.
11155 (remote_notif_state_xfree): Don't declare.
11156 * remote-notif.c (remote_notif_process, handle_notification)
11157 (remote_notif_state_allocate): Update.
11158 (~remote_notif_state): Rename from remote_notif_state_xfree.
11159
11160 2019-04-19 Tom Tromey <tom@tromey.com>
11161
11162 * symfile.c (reread_symbols): Update.
11163 * objfiles.c (objfile_register_static_link)
11164 (objfile_lookup_static_link): Update
11165 (~objfile) Don't delete static_links.
11166 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11167
11168 2019-04-19 Tom Tromey <tom@tromey.com>
11169
11170 * type-stack.h (struct type_stack) <insert>: Constify string.
11171 * type-stack.c (type_stack::insert): Constify string.
11172 * gdbtypes.h (lookup_template_type): Update.
11173 (address_space_name_to_int): Update.
11174 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11175 const.
11176 (lookup_template_type): Make name const.
11177 * c-exp.y: Update rules.
11178 (lex_one_token, classify_name, classify_inner_name)
11179 (c_print_token): Update.
11180 * p-exp.y: Update rules.
11181 (yylex): Update.
11182 * f-exp.y: Update rules.
11183 (yylex): Update.
11184 * d-exp.y: Update rules.
11185 (lex_one_token, classify_name, classify_inner_name): Update.
11186 * parse.c (write_dollar_variable, copy_name): Return std::string.
11187 * parser-defs.h (copy_name): Change return type.
11188 * m2-exp.y: Update rules.
11189 (yylex): Update.
11190 * go-exp.y (lex_one_token): Update.
11191 Update rules.
11192 (classify_unsafe_function, classify_packaged_name)
11193 (classify_name, yylex): Update.
11194
11195 2019-04-19 Sergei Trofimovich <siarheit@google.com>
11196
11197 * configure.ac: add --enable-source-highlight switch.
11198 * configure: Regenerate.
11199 * top.c (print_gdb_version): plumb --enable-source-highlight
11200 status to "show configuration".
11201
11202 2019-04-19 Tom Tromey <tromey@adacore.com>
11203
11204 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11205 Check ADA_TYPE_P.
11206 (empty_record, ada_template_to_fixed_record_type_1)
11207 (template_to_static_fixed_type)
11208 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11209 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11210 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11211 macros.
11212
11213 2019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11214
11215 PR symtab/24423:
11216 * source.c (print_source_lines_base): Advance "iter" when a
11217 control character is seen.
11218
11219 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11220
11221 * inferior.h (struct infcall_suspend_state_deleter):
11222 Catch exception in destructor to avoid crash.
11223
11224 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11225
11226 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11227 close to the add_com "shell".
11228
11229 2019-04-18 Tom Tromey <tromey@adacore.com>
11230
11231 * process-stratum-target.h (class process_stratum_target)
11232 <stratum>: Add "final".
11233
11234 2019-04-17 Tom Tromey <tromey@adacore.com>
11235
11236 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11237 against nullptr before use.
11238
11239 2019-04-17 Alan Hayward <alan.hayward@arm.com>
11240
11241 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11242
11243 2019-04-17 Jim Wilson <jimw@sifive.com>
11244 Andrew Burgess <andrew.burgess@embecosm.com>
11245
11246 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11247 code read might fail, assume 4-byte breakpoint in that case.
11248
11249 2019-04-15 Leszek Swirski <leszeks@google.com>
11250
11251 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11252 rather than a hand-rolled POD check when checking for forced MEMORY
11253 classification.
11254
11255 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11256
11257 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11258 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11259 function.
11260 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11261 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11262 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11263 declaration.
11264
11265 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11266
11267 * aarch64-linux-nat.c
11268 (aarch64_linux_nat_target::thread_architecture): Add override.
11269 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11270 each VQ.
11271
11272 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11273
11274 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11275
11276 2019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11277
11278 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11279 target types of size 96-bits, add some additional comments, and
11280 check that the builtin type we found was the correct size.
11281
11282 2019-04-12 Eli Zaretskii <eliz@gnu.org>
11283
11284 * utils.c (prompt_for_continue): Don't restore the styling at the
11285 end, as applied_style has the wrong value. This fixes styling in
11286 long lists of file names that are interrupted by the "Continue?"
11287 prompt.
11288
11289 2019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11290
11291 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11292 * c-lang.c (c_language_defn): Likewise.
11293 (cplus_language_defn): Likewise.
11294 (asm_language_defn): Likewise.
11295 (minimal_language_defn): Likewise.
11296 * d-lang.c (d_language_defn): Likewise.
11297 * f-lang.c (f_language_defn): Likewise.
11298 * go-lang.c (go_language_defn): Likewise.
11299 * language.c (unknown_language_defn): Likewise.
11300 (auto_language_defn): Likewise.
11301 * language.h (struct language_defn): Remove la_magic field.
11302 (LANG_MAGIC): Delete.
11303 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11304 * objc-lang.c (objc_language_defn): Likewise.
11305 * opencl-lang.c (opencl_language_defn): Likewise.
11306 * p-lang.c (pascal_language_defn): Likewise.
11307 * rust-lang.c (rust_language_defn): Likewise.
11308
11309 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11310
11311 * riscv-tdep.c (riscv_type_align): New function.
11312 (riscv_type_alignment): Delete.
11313 (riscv_arg_location): Use 'type_align'.
11314 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11315
11316 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11317
11318 * gdbtypes.c (type_align): A struct with no non-static fields also
11319 has alignment of 1.
11320
11321 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11322
11323 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11324 component to 0.
11325 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11326 member.
11327 (riscv_struct_info::analyse): New implementation using new
11328 analyse_inner member function.
11329 (riscv_struct_info::field_offset): New member function.
11330 (riscv_struct_info::m_offsets): New member variable.
11331 (riscv_struct_info::analyse_inner): New private member function,
11332 takes the old implementation of riscv_struct_info::analyse but
11333 extended to track field offsets.
11334 (riscv_call_arg_struct): Update the struct folding special cases
11335 to handle cases where empty C++ structs, which are non-zero
11336 length, are found.
11337 (riscv_arg_location): Initialise the length of each location, a
11338 non-zero length now indicates the location is in use.
11339 (riscv_push_dummy_call): Allow for the first location having a
11340 non-zero offset when setting up arguments.
11341 (riscv_return_value): Likewise, but for return values.
11342
11343 2019-04-11 Tom Tromey <tromey@adacore.com>
11344
11345 * utils.c (internal_vproblem): Make "msg" const.
11346
11347 2019-04-11 Alan Hayward <alan.hayward@arm.com>
11348
11349 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11350 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11351 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11352 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11353
11354 2019-04-10 Kevin Buettner <kevinb@redhat.com>
11355
11356 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11357 function.
11358 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11359 of amd64_collect_native_gregset.
11360 (amd64_linux_nat_target::store_registers): Likewise.
11361
11362 2019-04-10 Tom Tromey <tom@tromey.com>
11363
11364 * symtab.c (lookup_global_symbol_from_objfile)
11365 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11366 * objfiles.h (class separate_debug_iterator): New.
11367 (class separate_debug_range): New.
11368 (struct objfile) <separate_debug_objfiles>: New method.
11369 (objfile_separate_debug_iterate): Don't declare.
11370 * objfiles.c (separate_debug_iterator::operator++): Rename from
11371 objfile_separate_debug_iterate.
11372 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11373 iterator.
11374 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11375 iterator.
11376
11377 2019-04-10 Tom Tromey <tom@tromey.com>
11378
11379 * symfile.c (reread_symbols): Remove old comment.
11380 * objfiles.c (free_all_objfiles): Fix a typo.
11381
11382 2019-04-10 Tom Tromey <tom@tromey.com>
11383
11384 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11385 * minsyms.c (lookup_minimal_symbol): Use foreach.
11386 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11387 (lookup_minimal_symbol_solib_trampoline): Likewise.
11388 * symfile.c (reread_symbols): Use foreach.
11389
11390 2019-04-09 Ivan Begert <ivanbegert@gmail.com>
11391 Tom Tromey <tromey@adacore.com>
11392
11393 PR rust/24414:
11394 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11395 (rust_lex_int_test): Change "value" to be LONGEST.
11396 (rust_lex_tests): Add test for long integer literal.
11397
11398 2019-04-09 Tom Tromey <tromey@adacore.com>
11399
11400 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11401 to bool.
11402 (extended_remote_target::attach): Update.
11403 (remote_target::remote_notice_new_inferior): Update.
11404 (remote_target::add_current_inferior_and_thread): Update.
11405 * inferior.c (exit_inferior_1): Use "false".
11406 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11407
11408 2019-04-09 Simon Marchi <simon.marchi@efficios.com>
11409
11410 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11411 the "start" command.
11412
11413 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11414
11415 * python/py-inferior.c (infpy_thread_from_thread_handle):
11416 Adjust comments to reflect renaming of thread_from_thread_handle
11417 to thread_from_handle. Adjust keywords. Fix type error message.
11418 (inferior_object_methods): Add thread_from_handle. Retain
11419 thread_from_thread_handle, but mark it as deprecated.
11420
11421 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11422
11423 * gdbthread.h (find_thread_by_handle): Revise declaration.
11424 * thread.c (find_thread_by_handle): Likewise. Adjust
11425 implementation too.
11426 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11427 support for buffer objects as handles.
11428
11429 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11430
11431 * python/py-infthread.c (thpy_thread_handle): New function.
11432 (thread_object_methods): Register thpy_thread_handle.
11433
11434 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11435
11436 * gdbthread.h (thread_to_thread_handle): Declare.
11437 * thread.c (gdbtypes.h): Include.
11438 (thread_to_thread_handle): New function.
11439
11440 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11441 (target_thread_info_to_thread_handle): Declare.
11442 * target.c (target_thread_info_to_thread_handle): New function.
11443 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11444 * target-delegates.c: Regenerate.
11445
11446 * linux-thread-db.c (class thread_db_target): Add method
11447 thread_info_to_thread_handle.
11448 (thread_db_target::thread_info_to_thread_handle): Define.
11449 * remote.c (class remote_target): Add new method
11450 thread_info_to_thread_handle.
11451 (remote_target::thread_info_to_thread_handle): Define.
11452
11453 2019-04-08 Pedro Alves <palves@redhat.com>
11454
11455 * common/common-exceptions.c (throw_exception): Don't create
11456 named object to throw; throw directly.
11457 (throw_it): Likewise. Don't initialize gdb_exception::message
11458 here, with new; pass FMT and AP to the ctor instead.
11459 * common/common-exceptions.h: Include <string>.
11460 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11461 const char *, va_list)): New ctor. Use std::make_shared.
11462 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11463 errors)): Delete.
11464 (gdb_exception_error::gdb_exception_error(enum errors, const char
11465 *, va_list)): New.
11466 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11467 Add assertion.
11468 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11469 errors)): Delete.
11470 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11471 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11472 Add assertion.
11473
11474 2019-04-08 Tom Tromey <tom@tromey.com>
11475
11476 * valops.c (value_rtti_indirect_type): Replace throw_exception
11477 with throw.
11478 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11479 with throw.
11480 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11481 throw.
11482 * target.c (target_translate_tls_address): Replace throw_exception
11483 with throw.
11484 * stack.c (frame_apply_command_count): Replace throw_exception
11485 with throw.
11486 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11487 throw.
11488 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11489 with throw.
11490 * rs6000-tdep.c (rs6000_frame_cache)
11491 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11492 * remote.c: Replace throw_exception with throw.
11493 * record-full.c (record_full_message, record_full_wait_1)
11494 (record_full_restore): Replace throw_exception with throw.
11495 * record-btrace.c:
11496 (get_thread_current_frame_id, record_btrace_start_replaying)
11497 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11498 (cmd_record_btrace_start): Replace throw_exception with throw.
11499 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11500 throw.
11501 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11502 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11503 * linespec.c:
11504 (find_linespec_symbols): Replace throw_exception with throw.
11505 * infrun.c (displaced_step_prepare, resume): Replace
11506 throw_exception with throw.
11507 * infcmd.c (post_create_inferior): Replace throw_exception with
11508 throw.
11509 * inf-loop.c (inferior_event_handler): Replace throw_exception
11510 with throw.
11511 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11512 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11513 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11514 (get_prev_frame_always, get_frame_pc_if_available)
11515 (get_frame_address_in_block_if_available, get_frame_language):
11516 Replace throw_exception with throw.
11517 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11518 throw_exception with throw.
11519 * eval.c (fetch_subexp_value, evaluate_var_value)
11520 (evaluate_funcall, evaluate_subexp_standard): Replace
11521 throw_exception with throw.
11522 * dwarf2loc.c (call_site_find_chain)
11523 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11524 Replace throw_exception with throw.
11525 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11526 with throw.
11527 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11528 throw.
11529 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11530 * completer.c (complete_line_internal): Replace throw_exception
11531 with throw.
11532 * compile/compile-object-run.c (compile_object_run): Replace
11533 throw_exception with throw.
11534 * cli/cli-script.c (process_next_line): Replace throw_exception
11535 with throw.
11536 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11537 (btrace_enable, btrace_maint_update_pt_packets): Replace
11538 throw_exception with throw.
11539 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11540 throw_exception with throw.
11541 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11542 throw_exception with throw.
11543 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11544 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11545 * aarch64-tdep.c (aarch64_make_prologue_cache)
11546 (aarch64_make_stub_cache): Replace throw_exception with throw.
11547
11548 2019-04-08 Tom Tromey <tom@tromey.com>
11549
11550 * common/common-exceptions.c (throw_exception): Rename from
11551 throw_exception_cxx. Remove old copy. Make argument const.
11552 (throw_it): Create and throw exception objects directly.
11553 * common/common-exceptions.h (throw_exception): Make argument
11554 const.
11555 (struct gdb_exception_error): Add constructor.
11556 (struct gdb_exception_quit): Add constructor.
11557
11558 2019-04-08 Tom Tromey <tom@tromey.com>
11559
11560 * common/common-exceptions.h (exception_rethrow): Don't declare.
11561 (TRY_SJLJ): Update comment.
11562 (TRY, CATCH, END_CATCH): Remove.
11563 * common/common-exceptions.c (exception_rethrow): Remove.
11564
11565 2019-04-08 Tom Tromey <tom@tromey.com>
11566
11567 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11568 Remove.
11569 (gdb_exception_error): Rename from
11570 gdb_exception_RETURN_MASK_ERROR.
11571 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11572 (gdb_quit_bad_alloc): Update.
11573 * aarch64-tdep.c: Update.
11574 * ada-lang.c: Update.
11575 * ada-typeprint.c: Update.
11576 * ada-valprint.c: Update.
11577 * amd64-tdep.c: Update.
11578 * arch-utils.c: Update.
11579 * break-catch-throw.c: Update.
11580 * breakpoint.c: Update.
11581 * btrace.c: Update.
11582 * c-varobj.c: Update.
11583 * cli/cli-cmds.c: Update.
11584 * cli/cli-interp.c: Update.
11585 * cli/cli-script.c: Update.
11586 * common/common-exceptions.c: Update.
11587 * common/new-op.c: Update.
11588 * common/selftest.c: Update.
11589 * compile/compile-c-symbols.c: Update.
11590 * compile/compile-cplus-symbols.c: Update.
11591 * compile/compile-object-load.c: Update.
11592 * compile/compile-object-run.c: Update.
11593 * completer.c: Update.
11594 * corelow.c: Update.
11595 * cp-abi.c: Update.
11596 * cp-support.c: Update.
11597 * cp-valprint.c: Update.
11598 * darwin-nat.c: Update.
11599 * disasm-selftests.c: Update.
11600 * dtrace-probe.c: Update.
11601 * dwarf-index-cache.c: Update.
11602 * dwarf-index-write.c: Update.
11603 * dwarf2-frame-tailcall.c: Update.
11604 * dwarf2-frame.c: Update.
11605 * dwarf2loc.c: Update.
11606 * dwarf2read.c: Update.
11607 * eval.c: Update.
11608 * event-loop.c: Update.
11609 * event-top.c: Update.
11610 * exec.c: Update.
11611 * f-valprint.c: Update.
11612 * fbsd-tdep.c: Update.
11613 * frame-unwind.c: Update.
11614 * frame.c: Update.
11615 * gdbtypes.c: Update.
11616 * gnu-v3-abi.c: Update.
11617 * guile/guile-internal.h: Update.
11618 * guile/scm-block.c: Update.
11619 * guile/scm-breakpoint.c: Update.
11620 * guile/scm-cmd.c: Update.
11621 * guile/scm-disasm.c: Update.
11622 * guile/scm-frame.c: Update.
11623 * guile/scm-lazy-string.c: Update.
11624 * guile/scm-math.c: Update.
11625 * guile/scm-param.c: Update.
11626 * guile/scm-ports.c: Update.
11627 * guile/scm-pretty-print.c: Update.
11628 * guile/scm-symbol.c: Update.
11629 * guile/scm-symtab.c: Update.
11630 * guile/scm-type.c: Update.
11631 * guile/scm-value.c: Update.
11632 * i386-linux-tdep.c: Update.
11633 * i386-tdep.c: Update.
11634 * inf-loop.c: Update.
11635 * infcall.c: Update.
11636 * infcmd.c: Update.
11637 * infrun.c: Update.
11638 * jit.c: Update.
11639 * language.c: Update.
11640 * linespec.c: Update.
11641 * linux-fork.c: Update.
11642 * linux-nat.c: Update.
11643 * linux-tdep.c: Update.
11644 * linux-thread-db.c: Update.
11645 * main.c: Update.
11646 * mi/mi-cmd-break.c: Update.
11647 * mi/mi-cmd-stack.c: Update.
11648 * mi/mi-interp.c: Update.
11649 * mi/mi-main.c: Update.
11650 * objc-lang.c: Update.
11651 * p-valprint.c: Update.
11652 * parse.c: Update.
11653 * ppc-linux-tdep.c: Update.
11654 * printcmd.c: Update.
11655 * python/py-arch.c: Update.
11656 * python/py-breakpoint.c: Update.
11657 * python/py-cmd.c: Update.
11658 * python/py-finishbreakpoint.c: Update.
11659 * python/py-frame.c: Update.
11660 * python/py-framefilter.c: Update.
11661 * python/py-gdb-readline.c: Update.
11662 * python/py-inferior.c: Update.
11663 * python/py-infthread.c: Update.
11664 * python/py-lazy-string.c: Update.
11665 * python/py-linetable.c: Update.
11666 * python/py-objfile.c: Update.
11667 * python/py-param.c: Update.
11668 * python/py-prettyprint.c: Update.
11669 * python/py-progspace.c: Update.
11670 * python/py-record-btrace.c: Update.
11671 * python/py-record.c: Update.
11672 * python/py-symbol.c: Update.
11673 * python/py-type.c: Update.
11674 * python/py-unwind.c: Update.
11675 * python/py-utils.c: Update.
11676 * python/py-value.c: Update.
11677 * python/python.c: Update.
11678 * record-btrace.c: Update.
11679 * record-full.c: Update.
11680 * remote-fileio.c: Update.
11681 * remote.c: Update.
11682 * riscv-tdep.c: Update.
11683 * rs6000-aix-tdep.c: Update.
11684 * rs6000-tdep.c: Update.
11685 * rust-exp.y: Update.
11686 * rust-lang.c: Update.
11687 * s390-tdep.c: Update.
11688 * selftest-arch.c: Update.
11689 * solib-dsbt.c: Update.
11690 * solib-frv.c: Update.
11691 * solib-spu.c: Update.
11692 * solib-svr4.c: Update.
11693 * solib.c: Update.
11694 * sparc64-linux-tdep.c: Update.
11695 * stack.c: Update.
11696 * symfile-mem.c: Update.
11697 * symmisc.c: Update.
11698 * target.c: Update.
11699 * thread.c: Update.
11700 * top.c: Update.
11701 * tracefile-tfile.c: Update.
11702 * tui/tui.c: Update.
11703 * typeprint.c: Update.
11704 * unittests/cli-utils-selftests.c: Update.
11705 * unittests/parse-connection-spec-selftests.c: Update.
11706 * valops.c: Update.
11707 * valprint.c: Update.
11708 * value.c: Update.
11709 * varobj.c: Update.
11710 * windows-nat.c: Update.
11711 * x86-linux-nat.c: Update.
11712 * xml-support.c: Update.
11713
11714 2019-04-08 Tom Tromey <tom@tromey.com>
11715
11716 * xml-support.c: Use C++ exception handling.
11717 * x86-linux-nat.c: Use C++ exception handling.
11718 * windows-nat.c: Use C++ exception handling.
11719 * varobj.c: Use C++ exception handling.
11720 * value.c: Use C++ exception handling.
11721 * valprint.c: Use C++ exception handling.
11722 * valops.c: Use C++ exception handling.
11723 * unittests/parse-connection-spec-selftests.c: Use C++ exception
11724 handling.
11725 * unittests/cli-utils-selftests.c: Use C++ exception handling.
11726 * typeprint.c: Use C++ exception handling.
11727 * tui/tui.c: Use C++ exception handling.
11728 * tracefile-tfile.c: Use C++ exception handling.
11729 * top.c: Use C++ exception handling.
11730 * thread.c: Use C++ exception handling.
11731 * target.c: Use C++ exception handling.
11732 * symmisc.c: Use C++ exception handling.
11733 * symfile-mem.c: Use C++ exception handling.
11734 * stack.c: Use C++ exception handling.
11735 * sparc64-linux-tdep.c: Use C++ exception handling.
11736 * solib.c: Use C++ exception handling.
11737 * solib-svr4.c: Use C++ exception handling.
11738 * solib-spu.c: Use C++ exception handling.
11739 * solib-frv.c: Use C++ exception handling.
11740 * solib-dsbt.c: Use C++ exception handling.
11741 * selftest-arch.c: Use C++ exception handling.
11742 * s390-tdep.c: Use C++ exception handling.
11743 * rust-lang.c: Use C++ exception handling.
11744 * rust-exp.y: Use C++ exception handling.
11745 * rs6000-tdep.c: Use C++ exception handling.
11746 * rs6000-aix-tdep.c: Use C++ exception handling.
11747 * riscv-tdep.c: Use C++ exception handling.
11748 * remote.c: Use C++ exception handling.
11749 * remote-fileio.c: Use C++ exception handling.
11750 * record-full.c: Use C++ exception handling.
11751 * record-btrace.c: Use C++ exception handling.
11752 * python/python.c: Use C++ exception handling.
11753 * python/py-value.c: Use C++ exception handling.
11754 * python/py-utils.c: Use C++ exception handling.
11755 * python/py-unwind.c: Use C++ exception handling.
11756 * python/py-type.c: Use C++ exception handling.
11757 * python/py-symbol.c: Use C++ exception handling.
11758 * python/py-record.c: Use C++ exception handling.
11759 * python/py-record-btrace.c: Use C++ exception handling.
11760 * python/py-progspace.c: Use C++ exception handling.
11761 * python/py-prettyprint.c: Use C++ exception handling.
11762 * python/py-param.c: Use C++ exception handling.
11763 * python/py-objfile.c: Use C++ exception handling.
11764 * python/py-linetable.c: Use C++ exception handling.
11765 * python/py-lazy-string.c: Use C++ exception handling.
11766 * python/py-infthread.c: Use C++ exception handling.
11767 * python/py-inferior.c: Use C++ exception handling.
11768 * python/py-gdb-readline.c: Use C++ exception handling.
11769 * python/py-framefilter.c: Use C++ exception handling.
11770 * python/py-frame.c: Use C++ exception handling.
11771 * python/py-finishbreakpoint.c: Use C++ exception handling.
11772 * python/py-cmd.c: Use C++ exception handling.
11773 * python/py-breakpoint.c: Use C++ exception handling.
11774 * python/py-arch.c: Use C++ exception handling.
11775 * printcmd.c: Use C++ exception handling.
11776 * ppc-linux-tdep.c: Use C++ exception handling.
11777 * parse.c: Use C++ exception handling.
11778 * p-valprint.c: Use C++ exception handling.
11779 * objc-lang.c: Use C++ exception handling.
11780 * mi/mi-main.c: Use C++ exception handling.
11781 * mi/mi-interp.c: Use C++ exception handling.
11782 * mi/mi-cmd-stack.c: Use C++ exception handling.
11783 * mi/mi-cmd-break.c: Use C++ exception handling.
11784 * main.c: Use C++ exception handling.
11785 * linux-thread-db.c: Use C++ exception handling.
11786 * linux-tdep.c: Use C++ exception handling.
11787 * linux-nat.c: Use C++ exception handling.
11788 * linux-fork.c: Use C++ exception handling.
11789 * linespec.c: Use C++ exception handling.
11790 * language.c: Use C++ exception handling.
11791 * jit.c: Use C++ exception handling.
11792 * infrun.c: Use C++ exception handling.
11793 * infcmd.c: Use C++ exception handling.
11794 * infcall.c: Use C++ exception handling.
11795 * inf-loop.c: Use C++ exception handling.
11796 * i386-tdep.c: Use C++ exception handling.
11797 * i386-linux-tdep.c: Use C++ exception handling.
11798 * guile/scm-value.c: Use C++ exception handling.
11799 * guile/scm-type.c: Use C++ exception handling.
11800 * guile/scm-symtab.c: Use C++ exception handling.
11801 * guile/scm-symbol.c: Use C++ exception handling.
11802 * guile/scm-pretty-print.c: Use C++ exception handling.
11803 * guile/scm-ports.c: Use C++ exception handling.
11804 * guile/scm-param.c: Use C++ exception handling.
11805 * guile/scm-math.c: Use C++ exception handling.
11806 * guile/scm-lazy-string.c: Use C++ exception handling.
11807 * guile/scm-frame.c: Use C++ exception handling.
11808 * guile/scm-disasm.c: Use C++ exception handling.
11809 * guile/scm-cmd.c: Use C++ exception handling.
11810 * guile/scm-breakpoint.c: Use C++ exception handling.
11811 * guile/scm-block.c: Use C++ exception handling.
11812 * guile/guile-internal.h: Use C++ exception handling.
11813 * gnu-v3-abi.c: Use C++ exception handling.
11814 * gdbtypes.c: Use C++ exception handling.
11815 * frame.c: Use C++ exception handling.
11816 * frame-unwind.c: Use C++ exception handling.
11817 * fbsd-tdep.c: Use C++ exception handling.
11818 * f-valprint.c: Use C++ exception handling.
11819 * exec.c: Use C++ exception handling.
11820 * event-top.c: Use C++ exception handling.
11821 * event-loop.c: Use C++ exception handling.
11822 * eval.c: Use C++ exception handling.
11823 * dwarf2read.c: Use C++ exception handling.
11824 * dwarf2loc.c: Use C++ exception handling.
11825 * dwarf2-frame.c: Use C++ exception handling.
11826 * dwarf2-frame-tailcall.c: Use C++ exception handling.
11827 * dwarf-index-write.c: Use C++ exception handling.
11828 * dwarf-index-cache.c: Use C++ exception handling.
11829 * dtrace-probe.c: Use C++ exception handling.
11830 * disasm-selftests.c: Use C++ exception handling.
11831 * darwin-nat.c: Use C++ exception handling.
11832 * cp-valprint.c: Use C++ exception handling.
11833 * cp-support.c: Use C++ exception handling.
11834 * cp-abi.c: Use C++ exception handling.
11835 * corelow.c: Use C++ exception handling.
11836 * completer.c: Use C++ exception handling.
11837 * compile/compile-object-run.c: Use C++ exception handling.
11838 * compile/compile-object-load.c: Use C++ exception handling.
11839 * compile/compile-cplus-symbols.c: Use C++ exception handling.
11840 * compile/compile-c-symbols.c: Use C++ exception handling.
11841 * common/selftest.c: Use C++ exception handling.
11842 * common/new-op.c: Use C++ exception handling.
11843 * cli/cli-script.c: Use C++ exception handling.
11844 * cli/cli-interp.c: Use C++ exception handling.
11845 * cli/cli-cmds.c: Use C++ exception handling.
11846 * c-varobj.c: Use C++ exception handling.
11847 * btrace.c: Use C++ exception handling.
11848 * breakpoint.c: Use C++ exception handling.
11849 * break-catch-throw.c: Use C++ exception handling.
11850 * arch-utils.c: Use C++ exception handling.
11851 * amd64-tdep.c: Use C++ exception handling.
11852 * ada-valprint.c: Use C++ exception handling.
11853 * ada-typeprint.c: Use C++ exception handling.
11854 * ada-lang.c: Use C++ exception handling.
11855 * aarch64-tdep.c: Use C++ exception handling.
11856
11857 2019-04-08 Tom Tromey <tom@tromey.com>
11858
11859 * xml-support.c (gdb_xml_parser::parse): Update.
11860 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11861 * value.c (show_convenience): Update.
11862 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11863 (test_parse_flags_qcs): Update.
11864 * thread.c (thr_try_catch_cmd): Update.
11865 * target.c (target_translate_tls_address): Update.
11866 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11867 (info_frame_command_core, frame_apply_command_count): Update.
11868 * rust-exp.y (rust_lex_exception_test): Update.
11869 * riscv-tdep.c (riscv_print_one_register_info): Update.
11870 * remote.c (remote_target::enable_btrace): Update.
11871 * record-btrace.c (record_btrace_enable_warn): Update.
11872 * python/py-utils.c (gdbpy_convert_exception): Update.
11873 * printcmd.c (do_one_display, print_variable_and_value): Update.
11874 * mi/mi-main.c (mi_print_exception): Update.
11875 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11876 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11877 * linux-nat.c (linux_nat_target::attach): Update.
11878 * linux-fork.c (class scoped_switch_fork_info): Update.
11879 * infrun.c (displaced_step_prepare): Update.
11880 * infcall.c (call_function_by_hand_dummy): Update.
11881 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11882 * gnu-v3-abi.c (print_one_vtable): Update.
11883 * frame.c (get_prev_frame_always): Update.
11884 * f-valprint.c (info_common_command_for_block): Update.
11885 * exec.c (try_open_exec_file): Update.
11886 * exceptions.c (print_exception, exception_print)
11887 (exception_fprintf, exception_print_same): Update.
11888 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11889 * dwarf-index-cache.c (index_cache::store)
11890 (index_cache::lookup_gdb_index): Update.
11891 * darwin-nat.c (maybe_cache_shell): Update.
11892 * cp-valprint.c (cp_print_value_fields): Update.
11893 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11894 (gcc_cplus_symbol_address): Update.
11895 * compile/compile-c-symbols.c (gcc_convert_symbol)
11896 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11897 * common/selftest.c: Update.
11898 * common/common-exceptions.h (struct gdb_exception) <message>: Now
11899 a std::string.
11900 (exception_try_scope_entry, exception_try_scope_exit): Don't
11901 declare.
11902 (struct exception_try_scope): Remove.
11903 (TRY): Don't use exception_try_scope.
11904 (struct gdb_exception): Add constructor, operator=.
11905 <what>: New method.
11906 (struct gdb_exception_RETURN_MASK_ALL)
11907 (struct gdb_exception_RETURN_MASK_ERROR)
11908 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11909 (struct gdb_quit_bad_alloc): Update.
11910 * common/common-exceptions.c (exception_none): Change
11911 initializer.
11912 (struct catcher) <state, exception>: Initialize inline.
11913 <prev>: Remove member.
11914 (current_catcher): Remove.
11915 (catchers): New global.
11916 (exceptions_state_mc_init): Simplify.
11917 (catcher_pop): Remove.
11918 (exceptions_state_mc, exceptions_state_mc_catch): Update.
11919 (try_scope_depth, exception_try_scope_entry)
11920 (exception_try_scope_exit): Remove.
11921 (throw_exception_sjlj): Update.
11922 (exception_messages, exception_messages_size): Remove.
11923 (throw_it): Simplify.
11924 (gdb_exception_sliced_copy): Remove.
11925 (throw_exception_cxx): Update.
11926 * cli/cli-script.c (script_from_file): Update.
11927 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11928 Update.
11929 * ada-valprint.c (ada_val_print): Update.
11930 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11931 (create_excep_cond_exprs): Update.
11932
11933 2019-04-08 Tom Tromey <tom@tromey.com>
11934
11935 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11936 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11937 (TRY, CATCH, END_CATCH): Remove some definitions.
11938 * common/common-exceptions.c: Don't use GDB_XCPT.
11939 (catcher_list_size): Remove.
11940 (throw_exception, throw_it): Simplify.
11941
11942 2019-04-05 Tom Tromey <tom@tromey.com>
11943
11944 Revert the header-sorting patch.
11945 * ft32-tdep.c: Revert.
11946 * frv-tdep.c: Revert.
11947 * frv-linux-tdep.c: Revert.
11948 * frame.c: Revert.
11949 * frame-unwind.c: Revert.
11950 * frame-base.c: Revert.
11951 * fork-child.c: Revert.
11952 * findvar.c: Revert.
11953 * findcmd.c: Revert.
11954 * filesystem.c: Revert.
11955 * filename-seen-cache.h: Revert.
11956 * filename-seen-cache.c: Revert.
11957 * fbsd-tdep.c: Revert.
11958 * fbsd-nat.h: Revert.
11959 * fbsd-nat.c: Revert.
11960 * f-valprint.c: Revert.
11961 * f-typeprint.c: Revert.
11962 * f-lang.c: Revert.
11963 * extension.h: Revert.
11964 * extension.c: Revert.
11965 * extension-priv.h: Revert.
11966 * expprint.c: Revert.
11967 * exec.h: Revert.
11968 * exec.c: Revert.
11969 * exceptions.c: Revert.
11970 * event-top.c: Revert.
11971 * event-loop.c: Revert.
11972 * eval.c: Revert.
11973 * elfread.c: Revert.
11974 * dwarf2read.h: Revert.
11975 * dwarf2read.c: Revert.
11976 * dwarf2loc.c: Revert.
11977 * dwarf2expr.h: Revert.
11978 * dwarf2expr.c: Revert.
11979 * dwarf2-frame.c: Revert.
11980 * dwarf2-frame-tailcall.c: Revert.
11981 * dwarf-index-write.h: Revert.
11982 * dwarf-index-write.c: Revert.
11983 * dwarf-index-common.c: Revert.
11984 * dwarf-index-cache.h: Revert.
11985 * dwarf-index-cache.c: Revert.
11986 * dummy-frame.c: Revert.
11987 * dtrace-probe.c: Revert.
11988 * disasm.h: Revert.
11989 * disasm.c: Revert.
11990 * disasm-selftests.c: Revert.
11991 * dictionary.c: Revert.
11992 * dicos-tdep.c: Revert.
11993 * demangle.c: Revert.
11994 * dcache.h: Revert.
11995 * dcache.c: Revert.
11996 * darwin-nat.h: Revert.
11997 * darwin-nat.c: Revert.
11998 * darwin-nat-info.c: Revert.
11999 * d-valprint.c: Revert.
12000 * d-namespace.c: Revert.
12001 * d-lang.c: Revert.
12002 * ctf.c: Revert.
12003 * csky-tdep.c: Revert.
12004 * csky-linux-tdep.c: Revert.
12005 * cris-tdep.c: Revert.
12006 * cris-linux-tdep.c: Revert.
12007 * cp-valprint.c: Revert.
12008 * cp-support.c: Revert.
12009 * cp-namespace.c: Revert.
12010 * cp-abi.c: Revert.
12011 * corelow.c: Revert.
12012 * corefile.c: Revert.
12013 * continuations.c: Revert.
12014 * completer.h: Revert.
12015 * completer.c: Revert.
12016 * complaints.c: Revert.
12017 * coffread.c: Revert.
12018 * coff-pe-read.c: Revert.
12019 * cli-out.h: Revert.
12020 * cli-out.c: Revert.
12021 * charset.c: Revert.
12022 * c-varobj.c: Revert.
12023 * c-valprint.c: Revert.
12024 * c-typeprint.c: Revert.
12025 * c-lang.c: Revert.
12026 * buildsym.c: Revert.
12027 * buildsym-legacy.c: Revert.
12028 * build-id.h: Revert.
12029 * build-id.c: Revert.
12030 * btrace.c: Revert.
12031 * bsd-uthread.c: Revert.
12032 * breakpoint.h: Revert.
12033 * breakpoint.c: Revert.
12034 * break-catch-throw.c: Revert.
12035 * break-catch-syscall.c: Revert.
12036 * break-catch-sig.c: Revert.
12037 * blockframe.c: Revert.
12038 * block.c: Revert.
12039 * bfin-tdep.c: Revert.
12040 * bfin-linux-tdep.c: Revert.
12041 * bfd-target.c: Revert.
12042 * bcache.c: Revert.
12043 * ax-general.c: Revert.
12044 * ax-gdb.h: Revert.
12045 * ax-gdb.c: Revert.
12046 * avr-tdep.c: Revert.
12047 * auxv.c: Revert.
12048 * auto-load.c: Revert.
12049 * arm-wince-tdep.c: Revert.
12050 * arm-tdep.c: Revert.
12051 * arm-symbian-tdep.c: Revert.
12052 * arm-pikeos-tdep.c: Revert.
12053 * arm-obsd-tdep.c: Revert.
12054 * arm-nbsd-tdep.c: Revert.
12055 * arm-nbsd-nat.c: Revert.
12056 * arm-linux-tdep.c: Revert.
12057 * arm-linux-nat.c: Revert.
12058 * arm-fbsd-tdep.c: Revert.
12059 * arm-fbsd-nat.c: Revert.
12060 * arm-bsd-tdep.c: Revert.
12061 * arch-utils.c: Revert.
12062 * arc-tdep.c: Revert.
12063 * arc-newlib-tdep.c: Revert.
12064 * annotate.h: Revert.
12065 * annotate.c: Revert.
12066 * amd64-windows-tdep.c: Revert.
12067 * amd64-windows-nat.c: Revert.
12068 * amd64-tdep.c: Revert.
12069 * amd64-sol2-tdep.c: Revert.
12070 * amd64-obsd-tdep.c: Revert.
12071 * amd64-obsd-nat.c: Revert.
12072 * amd64-nbsd-tdep.c: Revert.
12073 * amd64-nbsd-nat.c: Revert.
12074 * amd64-nat.c: Revert.
12075 * amd64-linux-tdep.c: Revert.
12076 * amd64-linux-nat.c: Revert.
12077 * amd64-fbsd-tdep.c: Revert.
12078 * amd64-fbsd-nat.c: Revert.
12079 * amd64-dicos-tdep.c: Revert.
12080 * amd64-darwin-tdep.c: Revert.
12081 * amd64-bsd-nat.c: Revert.
12082 * alpha-tdep.c: Revert.
12083 * alpha-obsd-tdep.c: Revert.
12084 * alpha-nbsd-tdep.c: Revert.
12085 * alpha-mdebug-tdep.c: Revert.
12086 * alpha-linux-tdep.c: Revert.
12087 * alpha-linux-nat.c: Revert.
12088 * alpha-bsd-tdep.c: Revert.
12089 * alpha-bsd-nat.c: Revert.
12090 * aix-thread.c: Revert.
12091 * agent.c: Revert.
12092 * addrmap.c: Revert.
12093 * ada-varobj.c: Revert.
12094 * ada-valprint.c: Revert.
12095 * ada-typeprint.c: Revert.
12096 * ada-tasks.c: Revert.
12097 * ada-lang.c: Revert.
12098 * aarch64-tdep.c: Revert.
12099 * aarch64-ravenscar-thread.c: Revert.
12100 * aarch64-newlib-tdep.c: Revert.
12101 * aarch64-linux-tdep.c: Revert.
12102 * aarch64-linux-nat.c: Revert.
12103 * aarch64-fbsd-tdep.c: Revert.
12104 * aarch64-fbsd-nat.c: Revert.
12105 * aarch32-linux-nat.c: Revert.
12106
12107 2019-04-05 Tom Tromey <tom@tromey.com>
12108
12109 * ft32-tdep.c: Sort headers.
12110 * frv-tdep.c: Sort headers.
12111 * frv-linux-tdep.c: Sort headers.
12112 * frame.c: Sort headers.
12113 * frame-unwind.c: Sort headers.
12114 * frame-base.c: Sort headers.
12115 * fork-child.c: Sort headers.
12116 * findvar.c: Sort headers.
12117 * findcmd.c: Sort headers.
12118 * filesystem.c: Sort headers.
12119 * filename-seen-cache.h: Sort headers.
12120 * filename-seen-cache.c: Sort headers.
12121 * fbsd-tdep.c: Sort headers.
12122 * fbsd-nat.h: Sort headers.
12123 * fbsd-nat.c: Sort headers.
12124 * f-valprint.c: Sort headers.
12125 * f-typeprint.c: Sort headers.
12126 * f-lang.c: Sort headers.
12127 * extension.h: Sort headers.
12128 * extension.c: Sort headers.
12129 * extension-priv.h: Sort headers.
12130 * expprint.c: Sort headers.
12131 * exec.h: Sort headers.
12132 * exec.c: Sort headers.
12133 * exceptions.c: Sort headers.
12134 * event-top.c: Sort headers.
12135 * event-loop.c: Sort headers.
12136 * eval.c: Sort headers.
12137 * elfread.c: Sort headers.
12138 * dwarf2read.h: Sort headers.
12139 * dwarf2read.c: Sort headers.
12140 * dwarf2loc.c: Sort headers.
12141 * dwarf2expr.h: Sort headers.
12142 * dwarf2expr.c: Sort headers.
12143 * dwarf2-frame.c: Sort headers.
12144 * dwarf2-frame-tailcall.c: Sort headers.
12145 * dwarf-index-write.h: Sort headers.
12146 * dwarf-index-write.c: Sort headers.
12147 * dwarf-index-common.c: Sort headers.
12148 * dwarf-index-cache.h: Sort headers.
12149 * dwarf-index-cache.c: Sort headers.
12150 * dummy-frame.c: Sort headers.
12151 * dtrace-probe.c: Sort headers.
12152 * disasm.h: Sort headers.
12153 * disasm.c: Sort headers.
12154 * disasm-selftests.c: Sort headers.
12155 * dictionary.c: Sort headers.
12156 * dicos-tdep.c: Sort headers.
12157 * demangle.c: Sort headers.
12158 * dcache.h: Sort headers.
12159 * dcache.c: Sort headers.
12160 * darwin-nat.h: Sort headers.
12161 * darwin-nat.c: Sort headers.
12162 * darwin-nat-info.c: Sort headers.
12163 * d-valprint.c: Sort headers.
12164 * d-namespace.c: Sort headers.
12165 * d-lang.c: Sort headers.
12166 * ctf.c: Sort headers.
12167 * csky-tdep.c: Sort headers.
12168 * csky-linux-tdep.c: Sort headers.
12169 * cris-tdep.c: Sort headers.
12170 * cris-linux-tdep.c: Sort headers.
12171 * cp-valprint.c: Sort headers.
12172 * cp-support.c: Sort headers.
12173 * cp-namespace.c: Sort headers.
12174 * cp-abi.c: Sort headers.
12175 * corelow.c: Sort headers.
12176 * corefile.c: Sort headers.
12177 * continuations.c: Sort headers.
12178 * completer.h: Sort headers.
12179 * completer.c: Sort headers.
12180 * complaints.c: Sort headers.
12181 * coffread.c: Sort headers.
12182 * coff-pe-read.c: Sort headers.
12183 * cli-out.h: Sort headers.
12184 * cli-out.c: Sort headers.
12185 * charset.c: Sort headers.
12186 * c-varobj.c: Sort headers.
12187 * c-valprint.c: Sort headers.
12188 * c-typeprint.c: Sort headers.
12189 * c-lang.c: Sort headers.
12190 * buildsym.c: Sort headers.
12191 * buildsym-legacy.c: Sort headers.
12192 * build-id.h: Sort headers.
12193 * build-id.c: Sort headers.
12194 * btrace.c: Sort headers.
12195 * bsd-uthread.c: Sort headers.
12196 * breakpoint.h: Sort headers.
12197 * breakpoint.c: Sort headers.
12198 * break-catch-throw.c: Sort headers.
12199 * break-catch-syscall.c: Sort headers.
12200 * break-catch-sig.c: Sort headers.
12201 * blockframe.c: Sort headers.
12202 * block.c: Sort headers.
12203 * bfin-tdep.c: Sort headers.
12204 * bfin-linux-tdep.c: Sort headers.
12205 * bfd-target.c: Sort headers.
12206 * bcache.c: Sort headers.
12207 * ax-general.c: Sort headers.
12208 * ax-gdb.h: Sort headers.
12209 * ax-gdb.c: Sort headers.
12210 * avr-tdep.c: Sort headers.
12211 * auxv.c: Sort headers.
12212 * auto-load.c: Sort headers.
12213 * arm-wince-tdep.c: Sort headers.
12214 * arm-tdep.c: Sort headers.
12215 * arm-symbian-tdep.c: Sort headers.
12216 * arm-pikeos-tdep.c: Sort headers.
12217 * arm-obsd-tdep.c: Sort headers.
12218 * arm-nbsd-tdep.c: Sort headers.
12219 * arm-nbsd-nat.c: Sort headers.
12220 * arm-linux-tdep.c: Sort headers.
12221 * arm-linux-nat.c: Sort headers.
12222 * arm-fbsd-tdep.c: Sort headers.
12223 * arm-fbsd-nat.c: Sort headers.
12224 * arm-bsd-tdep.c: Sort headers.
12225 * arch-utils.c: Sort headers.
12226 * arc-tdep.c: Sort headers.
12227 * arc-newlib-tdep.c: Sort headers.
12228 * annotate.h: Sort headers.
12229 * annotate.c: Sort headers.
12230 * amd64-windows-tdep.c: Sort headers.
12231 * amd64-windows-nat.c: Sort headers.
12232 * amd64-tdep.c: Sort headers.
12233 * amd64-sol2-tdep.c: Sort headers.
12234 * amd64-obsd-tdep.c: Sort headers.
12235 * amd64-obsd-nat.c: Sort headers.
12236 * amd64-nbsd-tdep.c: Sort headers.
12237 * amd64-nbsd-nat.c: Sort headers.
12238 * amd64-nat.c: Sort headers.
12239 * amd64-linux-tdep.c: Sort headers.
12240 * amd64-linux-nat.c: Sort headers.
12241 * amd64-fbsd-tdep.c: Sort headers.
12242 * amd64-fbsd-nat.c: Sort headers.
12243 * amd64-dicos-tdep.c: Sort headers.
12244 * amd64-darwin-tdep.c: Sort headers.
12245 * amd64-bsd-nat.c: Sort headers.
12246 * alpha-tdep.c: Sort headers.
12247 * alpha-obsd-tdep.c: Sort headers.
12248 * alpha-nbsd-tdep.c: Sort headers.
12249 * alpha-mdebug-tdep.c: Sort headers.
12250 * alpha-linux-tdep.c: Sort headers.
12251 * alpha-linux-nat.c: Sort headers.
12252 * alpha-bsd-tdep.c: Sort headers.
12253 * alpha-bsd-nat.c: Sort headers.
12254 * aix-thread.c: Sort headers.
12255 * agent.c: Sort headers.
12256 * addrmap.c: Sort headers.
12257 * ada-varobj.c: Sort headers.
12258 * ada-valprint.c: Sort headers.
12259 * ada-typeprint.c: Sort headers.
12260 * ada-tasks.c: Sort headers.
12261 * ada-lang.c: Sort headers.
12262 * aarch64-tdep.c: Sort headers.
12263 * aarch64-ravenscar-thread.c: Sort headers.
12264 * aarch64-newlib-tdep.c: Sort headers.
12265 * aarch64-linux-tdep.c: Sort headers.
12266 * aarch64-linux-nat.c: Sort headers.
12267 * aarch64-fbsd-tdep.c: Sort headers.
12268 * aarch64-fbsd-nat.c: Sort headers.
12269 * aarch32-linux-nat.c: Sort headers.
12270
12271 2019-04-04 Tom Tromey <tom@tromey.com>
12272
12273 * varobj.c (varobj_create): Update.
12274 * rust-exp.y (struct rust_parser) <update_innermost_block,
12275 lookup_symbol>: New methods.
12276 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12277 Rename.
12278 (rust_parser::rust_lookup_type)
12279 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12280 * printcmd.c (display_command, do_one_display): Update.
12281 * parser-defs.h (struct parser_state) <parser_state>: Add
12282 "tracker" parameter.
12283 (block_tracker): New member.
12284 (class innermost_block_tracker) <innermost_block_tracker>: Add
12285 "types" parameter.
12286 <reset>: Remove method.
12287 (innermost_block): Don't declare.
12288 (null_post_parser): Update.
12289 * parse.c (innermost_block): Remove global.
12290 (write_dollar_variable): Update.
12291 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12292 Remove "tracker_types" parameter.
12293 (parse_expression): Add "tracker" parameter.
12294 (parse_expression_for_completion): Update.
12295 (null_post_parser): Add "tracker" parameter.
12296 * p-exp.y: Update rules.
12297 * m2-exp.y: Update rules.
12298 * language.h (struct language_defn) <la_post_parser>: Add
12299 "tracker" parameter.
12300 * go-exp.y: Update rules.
12301 * f-exp.y: Update rules.
12302 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12303 parameter.
12304 * d-exp.y: Update rules.
12305 * c-exp.y: Update rules.
12306 * breakpoint.c (set_breakpoint_condition): Create an
12307 innermost_block_tracker.
12308 (watch_command_1): Likewise.
12309 * ada-lang.c (resolve): Add "tracker" parameter.
12310 (resolve_subexp): Likewise.
12311 * ada-exp.y (write_var_from_sym): Update.
12312
12313 2019-04-04 Tom Tromey <tom@tromey.com>
12314
12315 * type-stack.h: New file.
12316 * type-stack.c: New file.
12317 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12318 type-stack.h.
12319 (insert_into_type_stack, insert_type, push_type, push_type_int)
12320 (insert_type_address_space, pop_type, pop_type_int)
12321 (pop_typelist, pop_type_stack, append_type_stack)
12322 (push_type_stack, get_type_stack, push_typelist)
12323 (follow_type_instance_flags, follow_types): Don't declare.
12324 * parse.c (type_stack): Remove global.
12325 (parse_exp_in_context): Update.
12326 (insert_into_type_stack, insert_type, push_type, push_type_int)
12327 (insert_type_address_space, pop_type, pop_type_int)
12328 (pop_typelist, pop_type_stack, append_type_stack)
12329 (push_type_stack, get_type_stack, push_typelist)
12330 (follow_type_instance_flags, follow_types): Remove (moved to
12331 type-stack.c).
12332 * f-exp.y (type_stack): New global.
12333 Update rules.
12334 (push_kind_type, f_parse): Update.
12335 * d-exp.y (type_stack): New global.
12336 Update rules.
12337 (d_parse): Update.
12338 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12339 Update rules.
12340 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12341 (HFILES_NO_SRCDIR): Add type-stack.h.
12342
12343 2019-04-04 Tom Tromey <tom@tromey.com>
12344
12345 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12346 (rust_parser::convert_ast_to_expression, rust_parse)
12347 (rust_lex_test_completion, rust_lex_tests): Update.
12348 * parser-defs.h (struct expr_completion_state): New.
12349 (struct parser_state) <parser_state>: Add completion parameter.
12350 <mark_struct_expression, mark_completion_tag>: New methods.
12351 <parse_completion, m_completion_state>: New members.
12352 (prefixify_expression, null_post_parser): Update.
12353 (mark_struct_expression, mark_completion_tag): Don't declare.
12354 * parse.c (parse_completion, expout_last_struct)
12355 (expout_tag_completion_type, expout_completion_name): Remove
12356 globals.
12357 (parser_state::mark_struct_expression)
12358 (parser_state::mark_completion_tag): Now methods.
12359 (prefixify_expression): Add last_struct parameter.
12360 (prefixify_subexp): Likewise.
12361 (parse_exp_1): Update.
12362 (parse_exp_in_context): Add cstate parameter. Update.
12363 (parse_expression_for_completion): Create an
12364 expr_completion_state.
12365 (null_post_parser): Add "completion" parameter.
12366 * p-exp.y: Update rules.
12367 (yylex): Update.
12368 * language.h (struct language_defn) <la_post_parser>: Add
12369 "completing" parameter.
12370 * go-exp.y: Update rules.
12371 (lex_one_token): Update.
12372 * expression.h (parse_completion): Don't declare.
12373 * d-exp.y: Update rules.
12374 (lex_one_token): Update rules.
12375 * c-exp.y: Update rules.
12376 (lex_one_token): Update.
12377 * ada-lang.c (resolve): Add "parse_completion" parameter.
12378 (resolve_subexp): Likewise.
12379 (ada_resolve_function): Likewise.
12380
12381 2019-04-04 Tom Tromey <tom@tromey.com>
12382
12383 * parser-defs.h (struct parser_state) <start_arglist,
12384 end_arglist>: New methods.
12385 <arglist_len, m_funcall_chain>: New members.
12386 (arglist_len, start_arglist, end_arglist): Don't declare.
12387 * parse.c (arglist_len, funcall_chain): Remove global.
12388 (start_arglist, end_arglist): Remove functions.
12389 (parse_exp_in_context): Update.
12390 * p-exp.y: Update rules.
12391 * m2-exp.y: Update rules.
12392 * go-exp.y: Update rules.
12393 * f-exp.y: Update rules.
12394 * d-exp.y: Update rules.
12395 * c-exp.y: Update rules.
12396
12397 2019-04-04 Tom Tromey <tom@tromey.com>
12398
12399 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12400 lex_operator, push_back>: New methods.
12401 Update all rules.
12402 (rust_parser::lex_hex, lex_escape): Rename and update.
12403 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12404 (rust_parser::lex_operator): Rename and update.
12405 (rust_parser::lex_number, rustyylex, rustyyerror)
12406 (rust_lex_test_init, rust_lex_test_sequence)
12407 (rust_lex_test_push_back, rust_lex_tests): Update.
12408 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12409 parameter.
12410 <lexptr, prev_lexptr>: New members.
12411 (lexptr, prev_lexptr): Don't declare.
12412 * parse.c (lexptr, prev_lexptr): Remove globals.
12413 (parse_exp_in_context): Update.
12414 * p-exp.y (yylex, yyerror): Update.
12415 * m2-exp.y (parse_number, yylex, yyerror): Update.
12416 * go-exp.y (lex_one_token, yyerror): Update.
12417 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12418 * d-exp.y (lex_one_token, yyerror): Update.
12419 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12420 (lex_one_token, yyerror): Update.
12421 * ada-lex.l (YY_INPUT): Update.
12422 (rewind_to_char): Update.
12423 * ada-exp.y (yyerror): Update.
12424
12425 2019-04-04 Tom Tromey <tom@tromey.com>
12426
12427 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12428 * parser-defs.h (struct parser_state) <parser_state>: Add new
12429 parameter.
12430 <comma_terminates>: New member.
12431 (comma_terminates): Don't declare global.
12432 * parse.c (comma_terminates): Remove global.
12433 (parse_exp_in_context): Update.
12434 * p-exp.y (yylex): Update.
12435 * m2-exp.y (yylex): Update.
12436 * go-exp.y (lex_one_token): Update.
12437 * f-exp.y (yylex): Update.
12438 * d-exp.y (lex_one_token): Update.
12439 * c-exp.y (lex_one_token): Update.
12440 * ada-lex.l: Update.
12441
12442 2019-04-04 Tom Tromey <tom@tromey.com>
12443
12444 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12445 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12446 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12447 * parser-defs.h (paren_depth): Don't declare.
12448 * parse.c (paren_depth): Remove global.
12449 (parse_exp_in_context): Update.
12450 * p-exp.y (paren_depth): New global.
12451 (pascal_parse): Initialize it.
12452 * m2-exp.y (paren_depth): New global.
12453 (m2_parse): Initialize it.
12454 * go-exp.y (paren_depth): New global.
12455 (go_parse): Initialize it.
12456 * f-exp.y (paren_depth): New global.
12457 (f_parse): Initialize it.
12458 * d-exp.y (paren_depth): New global.
12459 (d_parse): Initialize it.
12460 * c-exp.y (paren_depth): New global.
12461 (c_parse): Initialize it.
12462 * ada-lex.l (paren_depth): New global.
12463 (lexer_init): Initialize it.
12464
12465 2019-04-04 Tom Tromey <tom@tromey.com>
12466
12467 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12468 (rust_parser::convert_ast_to_type)
12469 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12470 * parser-defs.h (struct parser_state) <parser_state>: Add
12471 parameters. Initialize new members.
12472 <expression_context_block, expression_context_pc>: New members.
12473 * parse.c (expression_context_block, expression_context_pc):
12474 Remove globals.
12475 (parse_exp_in_context): Update.
12476 * p-exp.y: Update all rules.
12477 (yylex): Update.
12478 * m2-exp.y: Update all rules.
12479 (yylex): Update.
12480 * go-exp.y (yylex): Update.
12481 * f-exp.y (yylex): Update.
12482 * d-exp.y: Update all rules.
12483 (yylex): Update.
12484 * c-exp.y: Update all rules.
12485 (lex_one_token, classify_name, yylex, c_parse): Update.
12486 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12487
12488 2019-04-04 Tom Tromey <tom@tromey.com>
12489
12490 * gdbarch.h, gdbarch.c: Rebuild.
12491 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12492 * stap-probe.h:
12493 (struct stap_parse_info): Replace "parser_state" with
12494 "expr_builder".
12495 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12496 (parser_state): New class.
12497 * parse.c (expr_builder): Rename.
12498 (expr_builder::release): Rename.
12499 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12500 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12501 (write_exp_elt_longcst, write_exp_elt_floatcst)
12502 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12503 (write_exp_string_vector, write_exp_bitstring)
12504 (write_exp_msymbol, mark_struct_expression)
12505 (write_dollar_variable)
12506 (insert_type_address_space, increase_expout_size): Replace
12507 "parser_state" with "expr_builder".
12508 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12509 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12510 "parser_state" with "expr_builder".
12511
12512 2019-04-04 Tom Tromey <tom@tromey.com>
12513
12514 * rust-exp.y: Replace "parse_language" with method call.
12515 * p-exp.y:
12516 (yylex): Replace "parse_language" with method call.
12517 * m2-exp.y:
12518 (yylex): Replace "parse_language" with method call.
12519 * go-exp.y (classify_name): Replace "parse_language" with method
12520 call.
12521 * f-exp.y (yylex): Replace "parse_language" with method call.
12522 * d-exp.y (lex_one_token): Replace "parse_language" with method
12523 call.
12524 * c-exp.y:
12525 (lex_one_token, classify_name, yylex): Replace "parse_language"
12526 with method call.
12527 * ada-exp.y (find_primitive_type, type_char)
12528 (type_system_address): Replace "parse_language" with method call.
12529
12530 2019-04-04 Tom Tromey <tom@tromey.com>
12531
12532 * rust-exp.y: Replace "parse_gdbarch" with method call.
12533 * parse.c (write_dollar_variable, insert_type_address_space):
12534 Replace "parse_gdbarch" with method call.
12535 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12536 call.
12537 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12538 call.
12539 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12540 "parse_gdbarch" with method call.
12541 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12542 with method call.
12543 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12544 "parse_gdbarch" with method call.
12545 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12546 "parse_gdbarch" with method call.
12547 * c-exp.y (parse_type, parse_number, classify_name): Replace
12548 "parse_gdbarch" with method call.
12549 * ada-lex.l: Replace "parse_gdbarch" with method call.
12550 * ada-exp.y (parse_type, find_primitive_type, type_char)
12551 (type_system_address): Replace "parse_gdbarch" with method call.
12552
12553 2019-04-04 Tom Tromey <tom@tromey.com>
12554
12555 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12556 * stap-probe.c (stap_parse_argument): Update.
12557 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12558 initial_size parameter.
12559 * rust-exp.y (rust_lex_tests): Update.
12560 * parse.c (parser_state): Update.
12561 (parse_exp_in_context): Update.
12562 * parser-defs.h (struct parser_state) <parser_state>: Remove
12563 "initial_size" parameter.
12564
12565 2019-04-04 Tom Tromey <tom@tromey.com>
12566
12567 * parser-defs.h (increase_expout_size): Don't declare.
12568 * parse.c (increase_expout_size): Now static.
12569
12570 2019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12571
12572 * gnu-nat.c (gnu_nat_target::wait): Fix
12573 target_waitstatus_to_string call.
12574
12575 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12576
12577 * eval.c (evaluate_subexp_standard): Handle internal functions
12578 during Fortran function call handling.
12579
12580 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12581
12582 * NEWS: Mention new internal functions.
12583 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12584 (read_base_type): Use dwarf2_init_complex_target_type.
12585 * value.c (creal_internal_fn): New function.
12586 (cimag_internal_fn): New function.
12587 (_initialize_values): Register new internal functions.
12588
12589 2019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12590
12591 * infrun.c (stop_all_threads): If debug_infrun, always
12592 trace the wait status after wait_one, using
12593 target_waitstatus_to_string and target_pid_to_str.
12594 (handle_inferior_event): Replace various trace of
12595 wait status kind by a single trace.
12596 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12597 wait status kind image by target_waitstatus_to_string.
12598 * target/waitstatus.c (target_waitstatus_to_string): Fix
12599 obsolete comment.
12600
12601 2019-04-01 Tom Tromey <tromey@adacore.com>
12602
12603 PR symtab/23331:
12604 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12605
12606 2019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12607 Pedro Alves <palves@redhat.com>
12608
12609 * top.c (quit_force): Call 'finalize_values'.
12610 * value.c (finalize_values): New function.
12611 * value.h (finalize_values): Declare.
12612
12613 2019-03-30 Eli Zaretskii <eliz@gnu.org>
12614
12615 * NEWS: Announce $_gdb_major and $_gdb_minor.
12616
12617 * top.c (init_gdb_version_vars): New function.
12618 (gdb_init): Call init_gdb_version_vars.
12619
12620 2019-03-29 Tom Tromey <tromey@adacore.com>
12621
12622 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12623 help text. Remove dead code.
12624
12625 2019-03-29 Keith Seitz <keiths@redhat.com>
12626
12627 From Siddhesh Poyarekar:
12628 * f-lang.h (f77_get_upperbound): Return LONGEST.
12629 (f77_get_lowerbound): Likewise.
12630 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12631 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12632 print them.
12633 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12634 plongest to format print it.
12635 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12636 (f77_get_upperbound): Likewise.
12637 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12638 LOWER_BOUND to LONGEST.
12639 (f77_create_arrayprint_offset_tbl): Likewise.
12640
12641 2019-03-29 Keith Seitz <keiths@redhat.com>
12642
12643 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12644 %s/pulongest for TYPE_LENGTH instead of %d in format
12645 strings.
12646 * ada-typerint.c (ada_print_type): Likewise.
12647 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12648 * compile/compile-c-support.c (generate_register_struct): Likewise.
12649 * gdbtypes.c (recursive_dump_type): Likewise.
12650 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12651 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12652 instead of %d in format strings.
12653 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12654 to std::min to ULONGEST.
12655 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12656 instead of %d in format strings.
12657 * tracepoint.c (info_scope_command): Likewise.
12658 * typeprint.c (print_offset_data::update)
12659 (print_offset_data::finish): Likewise.
12660 * xtensa-tdep.c (xtensa_store_return_value)
12661 (xtensa_push_dummy_call): Likewise.
12662
12663 2019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
12664
12665 * windows-nat.c (display_selector): Fixed format specifications
12666 for 64-bit Cygwin.
12667
12668 2019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12669
12670 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12671
12672 2019-03-28 Sandra Loosemore <sandra@codesourcery.com>
12673
12674 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12675 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12676 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12677 (nios2_linux_init_abi): Install it.
12678
12679 2019-03-28 Alan Hayward <alan.hayward@arm.com>
12680
12681 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12682
12683 2019-03-28 Alan Hayward <alan.hayward@arm.com>
12684
12685 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12686
12687 2019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12688 Tom Tromey <tromey@adacore.com>
12689
12690 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12691
12692 2019-03-26 Joel Brobecker <brobecker@adacore.com>
12693
12694 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12695 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12696 method to compute the bounds of range types. Also print "[evaluated]"
12697 if the bounds' values come from a dynamic evaluation.
12698
12699 2019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
12700
12701 * cp-valprint.c (cp_print_value_fields): Don't print trailing
12702 whitespace when pretty printing is on.
12703
12704 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12705
12706 * ppc-linux-nat.c: Add include.
12707
12708 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12709
12710 * NEWS: Mention AArch64 Pointer Authentication.
12711
12712 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12713
12714 * arm-linux-nat.c: Add include.
12715
12716 2019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
12717
12718 * source-cache.c (source_cache::get_source_lines): Re-read
12719 fullname after calling open_source_file.
12720
12721 2019-03-25 John Baldwin <jhb@FreeBSD.org>
12722
12723 * NEWS: Mention TLS support for FreeBSD.
12724
12725 2019-03-25 Tom Tromey <tromey@adacore.com>
12726
12727 * minsyms.c (BUNCH_SIZE): Update comment.
12728 (~minimal_symbol_reader): Remove old comment.
12729 (compact_minimal_symbols): Update comment.
12730 (minimal_symbol_reader::install): Remove old comment. Update
12731 other comments.
12732
12733 2019-03-25 Alan Hayward <alan.hayward@arm.com>
12734
12735 * s390-linux-nat.c: Add include.
12736
12737 2019-03-25 Alan Hayward <alan.hayward@arm.com>
12738
12739 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12740 Call linux_get_hwcap.
12741 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12742 Likewise.
12743 (aarch64_linux_get_hwcap): Remove function.
12744 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12745 declaration.
12746 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12747 linux_get_hwcap.
12748 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12749 * linux-tdep.c (linux_get_hwcap): Add function.
12750 (linux_get_hwcap2): Likewise.
12751 * linux-tdep.h (linux_get_hwcap): Add declaration.
12752 (linux_get_hwcap2): Likewise.
12753 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12754 (ppc_linux_get_hwcap2): Likewise.
12755 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12756 linux_get_hwcap.
12757 (ppc_linux_nat_target::insert_watchpoint): Likewise.
12758 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12759 (ppc_linux_nat_target::read_description): Likewise.
12760 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12761 * s390-linux-nat.c: Likewise.
12762 * s390-linux-tdep.c (s390_core_read_description): Likewise.
12763
12764 2019-03-24 Tom Tromey <tom@tromey.com>
12765
12766 * ada-lang.c (standard_lookup): Simplify initialization.
12767 (ada_lookup_symbol_nonlocal): Simplify return.
12768 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12769 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12770 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12771 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12772 initialization.
12773 * solib.c (solib_global_lookup): Simplify.
12774 * symtab.c (null_block_symbol): Remove.
12775 (symbol_cache_lookup): Simplify returns.
12776 (lookup_language_this): Simplify returns.
12777 (lookup_symbol_aux): Simplify return.
12778 (lookup_local_symbol): Simplify returns.
12779 (lookup_global_symbol_from_objfile): Simplify return.
12780 (lookup_symbol_in_objfile_symtabs)
12781 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12782 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12783 (lookup_static_symbol, lookup_global_symbol): Simplify return.
12784 * cp-namespace.c (cp_lookup_bare_symbol)
12785 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12786 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12787 (cp_lookup_nested_symbol): Don't use null_block_symbol.
12788 (cp_lookup_symbol_via_imports): Simplify initialization.
12789 (find_symbol_in_baseclass): Likewise.
12790 * symtab.h (null_block_symbol): Remove.
12791 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12792 (d_lookup_nested_symbol, d_lookup_symbol_imports)
12793 (d_lookup_symbol_module): Likewise.
12794 (find_symbol_in_baseclass): Simplify initialization.
12795
12796 2019-03-24 Tom Tromey <tom@tromey.com>
12797
12798 * expression.h: Don't include symtab.h.
12799 (struct block): Forward declare.
12800
12801 2019-03-24 Tom Tromey <tom@tromey.com>
12802
12803 * c-exp.y (typebase): Remove casts.
12804 * gdbtypes.c (lookup_unsigned_typename, )
12805 (lookup_signed_typename): Remove cast.
12806 * eval.c (parse_to_comma_and_eval): Remove cast.
12807 * parse.c (write_dollar_variable): Remove cast.
12808 * block.h (struct block) <superblock>: Now const.
12809 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12810 * psymtab.c (psym_map_matching_symbols): Make "block" const.
12811 (map_block): Make "block" const.
12812 * symfile.h (struct quick_symbol_functions)
12813 <map_matching_symbols>: Constify block argument to "callback".
12814 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12815 const.
12816 (find_pc_sect_compunit_symtab): Make "b" const.
12817 (find_symbol_at_address): Likewise.
12818 (search_symbols): Likewise.
12819 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12820 (dw2_debug_names_lookup_symbol): Likewise.
12821 (dw2_map_matching_symbols): Update.
12822 * p-valprint.c (pascal_val_print): Remove "block".
12823 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12824 (aux_add_nonlocal_symbols): Make "block" const.
12825 (resolve_subexp): Remove cast.
12826 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12827 const.
12828 (iterate_over_file_blocks): Likewise.
12829 * f-exp.y (%union) <bval>: Remove.
12830 * coffread.c (patch_opaque_types): Make "b" const.
12831 * spu-tdep.c (spu_catch_start): Make "block" const.
12832 * c-valprint.c (print_unpacked_pointer): Remove "block".
12833 * symmisc.c (dump_symtab_1): Make "b" const.
12834 (block_depth): Make "block" const.
12835 * d-exp.y (%union) <bval>: Remove.
12836 * cp-support.h (cp_lookup_rtti_type): Update.
12837 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12838 * psymtab.c (psym_lookup_symbol): Make "block" const.
12839 (maintenance_check_psymtabs): Make "b" const.
12840 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12841 (enumerate_locals, enumerate_args): Update.
12842 * python/py-symtab.c (stpy_global_block): Make "block" const.
12843 (stpy_static_block): Likewise.
12844 * inline-frame.c (block_starting_point_at): Make "new_block"
12845 const.
12846 * block.c (find_block_in_blockvector): Make return type const.
12847 (blockvector_for_pc_sect): Make "b" const.
12848 (find_block_in_blockvector): Make "b" const.
12849
12850 2019-03-23 Tom Tromey <tom@tromey.com>
12851
12852 * varobj.c (varobj_create): Update.
12853 * symfile.c (clear_symtab_users): Don't reset innermost_block.
12854 * printcmd.c (display_command, do_one_display): Don't reset
12855 innermost_block.
12856 * parser-defs.h (enum innermost_block_tracker_type): Move to
12857 expression.h.
12858 (innermost_block): Update comment.
12859 * parse.c (parse_exp_1): Add tracker_types parameter.
12860 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
12861 tracker_types parameter. Reset innermost_block.
12862 (parse_exp_in_context): Remove.
12863 (parse_expression_for_completion): Update.
12864 * objfiles.c (~objfile): Don't reset expression_context_block or
12865 innermost_block.
12866 * expression.h (enum innermost_block_tracker_type): Move from
12867 parser-defs.h.
12868 (parse_exp_1): Add tracker_types parameter.
12869 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12870 reset innermost_block.
12871
12872 2019-03-23 Tom Tromey <tom@tromey.com>
12873
12874 * objfiles.h: Include bcache.h.
12875
12876 2019-03-23 Tom Tromey <tom@tromey.com>
12877
12878 * linespec.c (get_current_search_block): Use
12879 scoped_restore_current_language.
12880 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12881
12882 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12883 Jiong Wang <jiong.wang@arm.com>
12884
12885 * aarch64-linux-tdep.c
12886 (aarch64_linux_iterate_over_regset_sections): Check for pauth
12887 section.
12888 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12889
12890 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12891 Jiong Wang <jiong.wang@arm.com>
12892
12893 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12894 instructions.
12895 (aarch64_analyze_prologue_test): Add PACIASP test.
12896 (aarch64_prologue_prev_register): Unmask PC value.
12897
12898 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12899 Jiong Wang <jiong.wang@arm.com>
12900
12901 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12902 (aarch64_dwarf2_prev_register): Unmask PC value.
12903 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12904 (aarch64_execute_dwarf_cfa_vendor_op): Check for
12905 DW_CFA_AARCH64_negate_ra_state.
12906 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12907
12908 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12909 Jiong Wang <jiong.wang@arm.com>
12910
12911 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12912 registers.
12913 (aarch64_pseudo_register_name): Likewise.
12914 (aarch64_pseudo_register_type): Likewise.
12915 (aarch64_pseudo_register_reggroup_p): Likewise.
12916 (aarch64_gdbarch_init): Add pauth registers.
12917 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12918 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12919 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12920 (struct gdbarch_tdep): Add regnum for ra_state.
12921
12922 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12923 Jiong Wang <jiong.wang@arm.com>
12924
12925 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12926
12927 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12928 Jiong Wang <jiong.wang@arm.com>
12929
12930 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12931 function.
12932 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12933 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12934 (aarch64_gdbarch_init): Add puth registers.
12935 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12936 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12937 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12938
12939 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12940 Jiong Wang <jiong.wang@arm.com>
12941
12942 * aarch64-linux-nat.c
12943 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12944 * aarch64-linux-tdep.c
12945 (aarch64_linux_core_read_description): Likewise.
12946 (aarch64_linux_get_hwcap): New function.
12947 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12948 (aarch64_linux_get_hwcap): New declaration.
12949
12950 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12951 Jiong Wang <jiong.wang@arm.com>
12952
12953 * aarch64-linux-nat.c
12954 (aarch64_linux_nat_target::read_description): Add pauth param.
12955 * aarch64-linux-tdep.c
12956 (aarch64_linux_core_read_description): Likewise.
12957 * aarch64-tdep.c (struct target_desc): Add in pauth.
12958 (aarch64_read_description): Add pauth param.
12959 (aarch64_gdbarch_init): Likewise.
12960 * aarch64-tdep.h (aarch64_read_description): Likewise.
12961 * arch/aarch64.c (aarch64_create_target_description): Likewise.
12962 * arch/aarch64.h (aarch64_create_target_description): Likewise.
12963 * features/Makefile: Add new files.
12964 * features/aarch64-pauth.c: New file.
12965 * features/aarch64-pauth.xml: New file.
12966
12967 2019-03-20 Tom Tromey <tromey@adacore.com>
12968
12969 * infrun.c (handle_inferior_event): Rename from
12970 handle_inferior_event_1. Create a scoped_value_mark.
12971 (handle_inferior_event): Remove.
12972
12973 2019-03-19 Tom Tromey <tromey@adacore.com>
12974
12975 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12976 * infrun.h (print_stop_event): Add "displays" parameter.
12977 * infrun.c (print_stop_event): Add "displays" parameter.
12978
12979 2019-03-19 Pedro Alves <palves@redhat.com>
12980
12981 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12982 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
12983 to -1. Fix TABs vs spaces.
12984 (tui_ui_out::tui_ui_out): Don't initialize fields here.
12985 * tui/tui-out.h (tui_ui_out) Add intro comments.
12986 <m_line, m_start_of_line>: In-class initialize, and add describing
12987 comment.
12988
12989 2019-03-18 Alan Hayward <alan.hayward@arm.com>
12990
12991 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12992 variable names.
12993 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12994
12995 2019-03-18 Pedro Alves <palves@redhat.com>
12996 Eli Zaretskii <eliz@gnu.org>
12997
12998 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12999 m_line and m_start_of_line.
13000
13001 2019-03-18 Eli Zaretskii <eliz@gnu.org>
13002
13003 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13004 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13005 it returns a newline. This fixes a regression in TU mode, whereby
13006 the next line is output on the same screen line as the user input.
13007
13008 2019-03-18 Tom Tromey <tromey@adacore.com>
13009
13010 * minsyms.c (minimal_symbol_reader::install): Remove call to
13011 obstack_blank.
13012
13013 2019-03-18 Pedro Alves <palves@redhat.com>
13014
13015 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13016 New globals.
13017 (apply_style): New, factored out from ...
13018 (apply_ansi_escape): ... this. Handle reverse video mode.
13019 (tui_set_reverse_mode): New function.
13020 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13021 * tui/tui-winsource.c (tui_show_source_line): Use
13022 tui_set_reverse_mode instead of setting A_STANDOUT.
13023 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13024 New setter methods.
13025
13026 2019-03-18 Hannes Domani <ssbssa@yahoo.de>
13027
13028 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13029 Handle tabs.
13030
13031 2019-03-18 Tom Tromey <tromey@adacore.com>
13032
13033 * ada-lang.c (empty_array): Add "high" parameter.
13034 (ada_evaluate_subexp): Update.
13035
13036 2019-03-17 Sergei Trofimovich <siarheit@google.com>
13037
13038 * unittests/string_view-selftests.c: Define
13039 _initialize_string_view_selftests unconditionally.
13040
13041 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13042
13043 PR gdb/24350
13044 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13045
13046 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13047
13048 PR gdb/24351
13049 * windows-nat.c (display_selector): Fix format specifiers.
13050
13051 2019-03-17 Eli Zaretskii <eliz@gnu.org>
13052
13053 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13054 tui_refill_source_window instead of tui_refresh_win, to update the
13055 current execution line. This fixes redisplay of the current line
13056 when stepping through the code with "next" or "step".
13057
13058 2019-03-16 Eli Zaretskii <eliz@gnu.org>
13059
13060 * source-cache.c (source_cache::get_source_lines): Call
13061 find_source_lines to initialize s->nlines. This fixes vertical
13062 scrolling of TUI source window when the DOWN arrow is pressed.
13063
13064 2019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13065
13066 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13067 linux-thread-db.c (_initialize_thread_db): Likewise.
13068
13069 2019-03-16 Eli Zaretskii <eliz@gnu.org>
13070
13071 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13072 wclrtoeol in tui_show_source_line". This reverts changes made in
13073 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13074
13075 2019-03-15 Tom Tromey <tom@tromey.com>
13076
13077 * symtab.h (struct minimal_symbol): Derive from
13078 general_symbol_info.
13079 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13080 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13081 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13082 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13083 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13084 (MSYMBOL_SEARCH_NAME): Update.
13085 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13086 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13087 * minsyms.c (minimal_symbol_reader::record_full): Update.
13088
13089 2019-03-15 Tom Tromey <tom@tromey.com>
13090
13091 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13092
13093 2019-03-15 Tom Tromey <tom@tromey.com>
13094
13095 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13096 unique_xmalloc_ptr.
13097 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13098 Update.
13099 * minsyms.c (lookup_minimal_symbol_by_pc_section)
13100 (build_minimal_symbol_hash_tables)
13101 (minimal_symbol_reader::install): Update.
13102
13103 2019-03-15 Tom Tromey <tom@tromey.com>
13104
13105 * symtab.c (create_demangled_names_hash): Update.
13106 (symbol_set_names): Update.
13107 * objfiles.h (struct objfile_per_bfd_storage)
13108 <demangled_names_hash>: Now an htab_up.
13109 * objfiles.c (objfile_per_bfd_storage): Simplify.
13110
13111 2019-03-15 Tom Tromey <tom@tromey.com>
13112
13113 * objfiles.h (struct objfile_per_bfd_storage): Declare
13114 destructor.
13115 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13116 New.
13117 (get_objfile_bfd_data): Use new. Don't initialize
13118 language_of_main.
13119 (free_objfile_per_bfd_storage): Remove.
13120 (objfile_bfd_data_free, objfile::~objfile): Use delete.
13121
13122 2019-03-15 Tom Tromey <tom@tromey.com>
13123
13124 * symfile.c (reread_symbols): Update.
13125 * objfiles.c (objfile::objfile): Update.
13126 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13127 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13128 comment.
13129 (minimal_symbol_reader::install): Update.
13130 (terminate_minimal_symbol_table): Remove.
13131 * jit.c (jit_object_close_impl): Update.
13132
13133 2019-03-15 Tom Tromey <tom@tromey.com>
13134
13135 * minsyms.c (minimal_symbol_reader::record_full): Remove some
13136 initializations.
13137
13138 2019-03-15 Tom Tromey <tom@tromey.com>
13139
13140 * objfiles.h (struct objfile_per_bfd_storage)
13141 <demangled_hash_languages>: Now a bitset.
13142 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13143 (lookup_minimal_symbol): Update.
13144
13145 2019-03-15 Tom Tromey <tom@tromey.com>
13146
13147 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13148 Don't return the symbol.
13149 * coffread.c (record_minimal_symbol): Use record_full.
13150
13151 2019-03-14 Eli Zaretskii <eliz@gnu.org>
13152
13153 The MS-Windows port of ncurses fails to switch to a color pair if
13154 one or both of the colors are the implicit default colors. This
13155 change records the default colors when TUI is initialized, and
13156 then specifies them explicitly when a color pair uses the default
13157 colors. This allows color styling in TUI mode on MS-Windows.
13158
13159 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13160 ncurses_norm_attr.
13161 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13162 colors in ncurses_norm_attr.
13163 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13164 "none", replace it with the default color recorded in
13165 ncurses_norm_attr.
13166
13167 2019-03-14 Tom Tromey <tromey@adacore.com>
13168
13169 * source-cache.h (class source_cache) <get_source_lines>: Return
13170 std::string.
13171 * source-cache.c (source_cache::extract_lines): Handle case where
13172 first_pos==npos. Return std::string.
13173 (source_cache::get_source_lines): Update.
13174
13175 2019-03-14 Tom Tromey <tromey@adacore.com>
13176
13177 * NEWS: Add item for "style sources" commands.
13178 * source-cache.c (source_cache::get_source_lines): Check
13179 source_styling.
13180 * cli/cli-style.c (source_styling): New global.
13181 (_initialize_cli_style): Add "style sources" commands.
13182 (show_style_sources): New function.
13183 * cli/cli-style.h (source_styling): Declare.
13184
13185 2019-03-14 Pedro Alves <palves@redhat.com>
13186 Tom Tromey <tromey@adacore.com>
13187
13188 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13189 * tui/tui-winsource.c (tui_refill_source_window): New function,
13190 from...
13191 (tui_horizontal_source_scroll): ... here. Move some logic.
13192 * cli/cli-style.c (set_style_enabled): Notify new observable.
13193 * tui/tui-hooks.c (tui_redisplay_source): New function.
13194 (tui_attach_detach_observers): Attach or detach
13195 tui_redisplay_source.
13196 * observable.h (source_styling_changed): New observable.
13197 * observable.c: Define source_styling_changed observable.
13198
13199 2019-03-13 Tom Tromey <tromey@adacore.com>
13200
13201 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13202 (i386_gnu_nat_target::store_registers): Update.
13203 * target-debug.h (target_debug_print_std_string): New macro.
13204 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13205 * windows-tdep.c (display_one_tib): Update.
13206 * tui/tui-stack.c (tui_make_status_line): Update.
13207 * top.c (print_inferior_quit_action): Update.
13208 * thread.c (thr_try_catch_cmd): Update.
13209 (add_thread_with_info): Update.
13210 (thread_target_id_str): Update.
13211 (thr_try_catch_cmd): Update.
13212 (thread_command): Update.
13213 (thread_find_command): Update.
13214 * record-btrace.c (record_btrace_target::info_record)
13215 (record_btrace_resume_thread, record_btrace_target::resume)
13216 (record_btrace_cancel_resume, record_btrace_step_thread)
13217 (record_btrace_target::wait, record_btrace_target::wait)
13218 (record_btrace_target::wait, record_btrace_target::stop): Update.
13219 * progspace.c (print_program_space): Update.
13220 * process-stratum-target.c
13221 (process_stratum_target::thread_address_space): Update.
13222 * linux-fork.c (linux_fork_mourn_inferior)
13223 (detach_checkpoint_command, info_checkpoints_command)
13224 (linux_fork_context): Update.
13225 (linux_fork_detach): Update.
13226 (class scoped_switch_fork_info): Update.
13227 (delete_checkpoint_command): Update.
13228 * infrun.c (follow_fork_inferior): Update.
13229 (follow_fork_inferior): Update.
13230 (proceed_after_vfork_done): Update.
13231 (handle_vfork_child_exec_or_exit): Update.
13232 (follow_exec): Update.
13233 (displaced_step_prepare_throw): Update.
13234 (displaced_step_restore): Update.
13235 (start_step_over): Update.
13236 (resume_1): Update.
13237 (clear_proceed_status_thread): Update.
13238 (proceed): Update.
13239 (print_target_wait_results): Update.
13240 (do_target_wait): Update.
13241 (context_switch): Update.
13242 (stop_all_threads): Update.
13243 (restart_threads): Update.
13244 (finish_step_over): Update.
13245 (handle_signal_stop): Update.
13246 (switch_back_to_stepped_thread): Update.
13247 (keep_going_pass_signal): Update.
13248 (print_exited_reason): Update.
13249 (normal_stop): Update.
13250 * inferior.c (inferior_pid_to_str): Change return type.
13251 (print_selected_inferior): Update.
13252 (add_inferior): Update.
13253 (detach_inferior): Update.
13254 * dummy-frame.c (fprint_dummy_frames): Update.
13255 * dcache.c (dcache_info_1): Update.
13256 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13257 (btrace_fetch, btrace_clear): Update.
13258 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13259 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13260 type.
13261 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13262 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13263 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13264 * gdbarch.c, gdbarch.h: Rebuild.
13265 * gdbarch.sh (core_pid_to_str): Change return type.
13266 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13267 return type.
13268 (windows_nat_target::pid_to_str): Change return type.
13269 (windows_delete_thread): Update.
13270 (windows_nat_target::attach): Update.
13271 (windows_nat_target::files_info): Update.
13272 * target-delegates.c: Rebuild.
13273 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13274 return type.
13275 (sol_thread_target::pid_to_str): Change return type.
13276 * remote.c (class remote_target) <pid_to_str>: Change return
13277 type.
13278 (remote_target::pid_to_str): Change return type.
13279 (extended_remote_target::attach, remote_target::remote_stop_ns)
13280 (remote_target::remote_notif_remove_queued_reply)
13281 (remote_target::push_stop_reply, remote_target::disable_btrace):
13282 Update.
13283 (extended_remote_target::attach): Update.
13284 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13285 type.
13286 (gdbsim_target::pid_to_str): Change return type.
13287 * ravenscar-thread.c (struct ravenscar_thread_target)
13288 <pid_to_str>: Change return type.
13289 (ravenscar_thread_target::pid_to_str): Change return type.
13290 * procfs.c (class procfs_target) <pid_to_str>: Change return
13291 type.
13292 (procfs_target::pid_to_str): Change return type.
13293 (procfs_target::attach): Update.
13294 (procfs_target::detach): Update.
13295 (procfs_target::fetch_registers): Update.
13296 (procfs_target::store_registers): Update.
13297 (procfs_target::wait): Update.
13298 (procfs_target::files_info): Update.
13299 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13300 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13301 return type.
13302 (nto_procfs_target::pid_to_str): Change return type.
13303 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13304 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13305 return type.
13306 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13307 (exit_lwp): Update.
13308 (attach_proc_task_lwp_callback, get_detach_signal)
13309 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13310 (linux_nat_target::resume, wait_lwp, stop_callback)
13311 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13312 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13313 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13314 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13315 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13316 type.
13317 (inf_ptrace_target::attach): Update.
13318 (inf_ptrace_target::files_info): Update.
13319 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13320 type.
13321 (go32_nat_target::pid_to_str): Change return type.
13322 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13323 (gnu_nat_target::wait): Update.
13324 (gnu_nat_target::wait): Update.
13325 (gnu_nat_target::resume): Update.
13326 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13327 (fbsd_nat_target::wait): Update.
13328 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13329 type.
13330 (darwin_nat_target::attach): Update.
13331 * corelow.c (class core_target) <pid_to_str>: Change return type.
13332 (core_target::pid_to_str): Change return type.
13333 * target.c (normal_pid_to_str): Change return type.
13334 (default_pid_to_str): Likewise.
13335 (target_pid_to_str): Change return type.
13336 (target_translate_tls_address): Update.
13337 (target_announce_detach): Update.
13338 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13339 return type.
13340 (bsd_uthread_target::pid_to_str): Change return type.
13341 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13342 type.
13343 (bsd_kvm_target::pid_to_str): Change return type.
13344 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13345 return type.
13346 (aix_thread_target::pid_to_str): Change return type.
13347 * target.h (struct target_ops) <pid_to_str>: Change return type.
13348 (target_pid_to_str, normal_pid_to_str): Likewise.
13349 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13350 type.
13351 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13352 type.
13353 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13354 return type.
13355 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13356 type.
13357 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13358 type.
13359 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13360 return type.
13361
13362 2019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13363
13364 * NEWS: Mention that the new default MI version is 3. Mention
13365 changes to the output of commands and events that deal with
13366 multi-location breakpoints.
13367 * breakpoint.c: Include "mi/mi-out.h".
13368 (print_one_breakpoint): Change output syntax if using MI version
13369 >= 3.
13370 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13371 New.
13372 (mi_multi_location_breakpoint_output_fixed): New.
13373 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13374 (mi_cmd_fix_multi_location_breakpoint_output): New.
13375 (mi_multi_location_breakpoint_output_fixed): New.
13376 * mi/mi-cmds.c (mi_cmds): Register command
13377 -fix-multi-location-breakpoint-output.
13378 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13379 interpreter "mi".
13380
13381 2019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13382
13383 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13384 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13385 instantiate mi_ui_out based on interpreter name.
13386 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13387 * mi/mi-main.c (mi_load_progress): Likewise.
13388
13389 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13390
13391 * NEWS: Combine separate "New targets" sections for 8.3.
13392
13393 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13394
13395 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13396 (ppcfbsd_init_abi): Install gdbarch
13397 "fetch_tls_load_module_address" and "get_thread_local_address"
13398 methods.
13399
13400 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13401
13402 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13403 (riscv_fbsd_init_abi): Install gdbarch
13404 "fetch_tls_load_module_address" and "get_thread_local_address"
13405 methods.
13406
13407 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13408
13409 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13410 (i386fbsd_init_abi): Install gdbarch
13411 "fetch_tls_load_module_address" and "get_thread_local_address"
13412 methods.
13413
13414 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13415
13416 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13417 (amd64fbsd_init_abi): Install gdbarch
13418 "fetch_tls_load_module_address" and "get_thread_local_address"
13419 methods.
13420
13421 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13422
13423 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13424 (struct fbsd_pspace_data): New type.
13425 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13426 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13427 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13428 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13429 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13430
13431 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13432
13433 * gdbtypes.c (lookup_struct_elt): New function.
13434 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13435 * gdbtypes.h (struct struct_elt): New type.
13436 (lookup_struct_elt): New prototype.
13437
13438 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13439
13440 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13441 remove disabled code block.
13442
13443 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13444
13445 * gdbarch.sh (get_thread_local_address): New method.
13446 * gdbarch.h, gdbarch.c: Regenerate.
13447 * target.c (target_translate_tls_address): Use
13448 gdbarch_get_thread_local_address if present instead of
13449 target::get_thread_local_address.
13450
13451 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13452
13453 * target.h (target::get_thread_local_address): Update comment.
13454
13455 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13456
13457 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13458 objfile->separate_debug_objfile_backlink if not NULL.
13459
13460 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13461
13462 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13463 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13464 (amd64bsd_store_inferior_registers): Likewise.
13465 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13466 Enable segment base registers.
13467 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13468 PT_GETFSBASE and PT_GETGSBASE.
13469 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13470 PT_SETGSBASE.
13471 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13472 segment base registers.
13473 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13474
13475 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13476
13477 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13478 Update calls to i386_target_description to add 'segments'
13479 parameter.
13480 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13481 add segment base registers.
13482 * arch/i386.c (i386_create_target_description): Add 'segments'
13483 parameter to enable segment base registers.
13484 * arch/i386.h (i386_create_target_description): Likewise.
13485 * features/i386/32bit-segments.xml: New file.
13486 * features/i386/32bit-segments.c: Generate.
13487 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13488 call to i386_target_description to add 'segments' parameter.
13489 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13490 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13491 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13492 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13493 if feature is present.
13494 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13495 Add 'segments' parameter to call to i386_target_description.
13496 (i386_target_description): Add 'segments' parameter to enable
13497 segment base registers.
13498 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13499 to call to i386_target_description.
13500 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13501 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13502 Define I386_NUM_REGS.
13503 (i386_target_description): Add 'segments' parameter to enable
13504 segment base registers.
13505
13506 2019-03-12 Eli Zaretskii <eliz@gnu.org>
13507
13508 PR/24325
13509 * source-cache.c: #undef open and close, to avoid unresolved
13510 externals during linking.
13511
13512 2019-03-12 Tom Tromey <tromey@adacore.com>
13513
13514 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13515 const. Add initializers.
13516 (_initialize_remote): Don't initialize ptid globals.
13517
13518 2019-03-12 Pedro Alves <palves@redhat.com>
13519
13520 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13521
13522 2019-03-12 Pedro Alves <palves@redhat.com>
13523
13524 * cp-name-parser.y (main): Remove unused 'len' variable.
13525
13526 2019-03-12 Tom Tromey <tromey@adacore.com>
13527
13528 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13529 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13530
13531 2019-03-12 Tom Tromey <tromey@adacore.com>
13532
13533 * linux-nat.c (iterate_over_lwps): Update.
13534 (stop_callback): Remove parameter.
13535 (stop_wait_callback, detach_callback, resume_set_callback)
13536 (select_singlestep_lwp_callback, set_ignore_sigint)
13537 (status_callback, resumed_callback, resume_clear_callback)
13538 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13539 data parameter.
13540 (linux_nat_target::detach, linux_nat_target::resume)
13541 (linux_stop_and_wait_all_lwps, select_event_lwp)
13542 (linux_nat_filter_event, linux_nat_wait_1)
13543 (linux_nat_target::kill, linux_nat_target::stop)
13544 (linux_nat_target::stop): Update.
13545 (linux_nat_resume_callback): Change type.
13546 (resume_stopped_resumed_lwps, count_events_callback)
13547 (select_event_lwp_callback): Likewise.
13548 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13549 * arm-linux-nat.c (struct update_registers_data): Remove.
13550 (update_registers_callback): Change type.
13551 (arm_linux_insert_hw_breakpoint1): Update.
13552 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13553 parameter.
13554 (x86_linux_dr_set_addr): Update.
13555 (x86_linux_dr_set_control): Update.
13556 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13557 (iterate_over_lwps): Use gdb::function_view.
13558 * nat/aarch64-linux-hw-point.c (struct
13559 aarch64_dr_update_callback_param): Remove.
13560 (debug_reg_change_callback): Change type.
13561 (aarch64_notify_debug_reg_change): Update.
13562 * s390-linux-nat.c (s390_refresh_per_info): Update.
13563
13564 2019-03-11 Tom Tromey <tromey@adacore.com>
13565
13566 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13567 redundant assignment to "this_cu".
13568
13569 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13570
13571 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13572
13573 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13574
13575 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13576 from...
13577 (rank_one_type): ... this.
13578
13579 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13580
13581 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13582 from...
13583 (rank_one_type): ... this.
13584
13585 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13586
13587 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13588 from...
13589 (rank_one_type): ... this.
13590
13591 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13592
13593 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13594 from...
13595 (rank_one_type): ... this.
13596
13597 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13598
13599 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13600 from...
13601 (rank_one_type): ... this.
13602
13603 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13604
13605 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13606 from...
13607 (rank_one_type): ... this.
13608
13609 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13610
13611 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13612 from...
13613 (rank_one_type): ... this.
13614
13615 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13616
13617 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13618 from...
13619 (rank_one_type): ... this.
13620
13621 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13622
13623 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13624 from...
13625 (rank_one_type): ... this.
13626
13627 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13628
13629 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13630 from...
13631 (rank_one_type): ... this.
13632
13633 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13634
13635 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13636 from...
13637 (rank_one_type): ... this.
13638
13639 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13640
13641 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13642 from...
13643 (rank_one_type): ... this.
13644
13645 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13646
13647 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13648 inferior-events' shows the example events.
13649
13650 2019-03-08 Eli Zaretskii <eliz@gnu.org>
13651
13652 Support styling on native MS-Windows console
13653
13654 PR/24315
13655 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13656 on MS-Windows if $TERM is not defined.
13657
13658 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13659
13660 * posix-hdep.c (gdb_console_fputs):
13661 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13662 functions.
13663 * ui-file.h (gdb_console_fputs): Add prototype.
13664
13665 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13666 back to fputs only if the former returns zero.
13667
13668 2019-03-07 Tom Tromey <tom@tromey.com>
13669
13670 * symmisc.c (print_symbol_bcache_statistics): Update.
13671 (print_objfile_statistics): Update.
13672 * symfile.c (allocate_symtab): Update.
13673 * stabsread.c: Don't include bcache.h.
13674 * psymtab.h (struct psymbol_bcache): Don't declare.
13675 (class psymtab_storage) <psymbol_cache>: Now a bcache.
13676 (psymbol_bcache_init, psymbol_bcache_free)
13677 (psymbol_bcache_get_bcache): Don't declare.
13678 * psymtab.c (struct psymbol_bcache): Remove.
13679 (psymtab_storage::psymtab_storage): Update.
13680 (psymtab_storage::~psymtab_storage): Update.
13681 (psymbol_bcache_init, psymbol_bcache_free)
13682 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13683 (add_psymbol_to_bcache): Update.
13684 (allocate_psymtab): Update.
13685 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13686 macro_cache>: No longer pointers.
13687 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13688 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13689 * macrotab.c (macro_bcache): Update.
13690 * macroexp.c: Don't include bcache.h.
13691 * gdbtypes.c (check_types_worklist): Update.
13692 (types_deeply_equal): Remove TRY/CATCH. Update.
13693 * elfread.c (elf_symtab_read): Update.
13694 * dwarf2read.c: Don't include bcache.h.
13695 * buildsym.c (buildsym_compunit::get_macro_table): Update.
13696 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13697 (print_bcache_statistics, bcache_memory_used): Don't declare.
13698 (struct bcache): Move from bcache.c. Add constructor, destructor,
13699 methods. Rename all data members.
13700 * bcache.c (struct bcache): Move to bcache.h.
13701 (bcache::expand_hash_table): Rename from expand_hash_table.
13702 (bcache): Remove.
13703 (bcache::insert): Rename from bcache_full.
13704 (bcache::compare): Rename from bcache_compare.
13705 (bcache_xmalloc): Remove.
13706 (bcache::~bcache): Rename from bcache_xfree.
13707 (bcache::print_statistics): Rename from print_bcache_statistics.
13708 (bcache::memory_used): Rename from bcache_memory_used.
13709
13710 2019-03-07 Pedro Alves <palves@redhat.com>
13711
13712 * infrun.c (normal_stop): Also check for
13713 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13714
13715 2019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
13716
13717 * f-lang.c (value_from_host_double): Moved to...
13718 * value.c (value_from_host_double): ...here.
13719 * value.h (value_from_host_double): Declare.
13720 * guile/scm-math.c (vlscm_convert_typed_number): Use
13721 value_from_host_double.
13722 (vlscm_convert_number): Likewise.
13723 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13724 * python/py-value.c (convert_value_from_python): Likewise.
13725
13726 2019-03-06 Tom Tromey <tom@tromey.com>
13727
13728 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13729
13730 2019-03-06 Tom Tromey <tom@tromey.com>
13731
13732 * utils.h (free_current_contents): Don't declare.
13733 * utils.c (free_current_contents): Remove.
13734
13735 2019-03-06 Tom Tromey <tom@tromey.com>
13736
13737 * top.c (quit_force): Update.
13738 * main.c (captured_command_loop): Update.
13739 * common/new-op.c (operator new): Update.
13740 * common/common-exceptions.c (struct catcher)
13741 <save_cleanup_chain>: Remove member.
13742 (exceptions_state_mc_init): Update.
13743 (exception_try_scope_entry): Return nullptr.
13744 (exception_try_scope_exit, exception_rethrow)
13745 (throw_exception_sjlj, throw_exception_cxx): Update.
13746 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13747 (all_cleanups, do_cleanups, discard_cleanups)
13748 (discard_final_cleanups, save_cleanups, save_final_cleanups)
13749 (restore_cleanups, restore_final_cleanups): Don't declare.
13750 (do_final_cleanups): Remove parameter.
13751 * common/cleanups.c (cleanup_chain, make_cleanup)
13752 (make_cleanup_dtor, all_cleanups, do_cleanups)
13753 (discard_my_cleanups, discard_cleanups)
13754 (discard_final_cleanups, save_my_cleanups, save_cleanups)
13755 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13756 (null_cleanup): Remove.
13757 (do_final_cleanups): Remove parameter.
13758
13759 2019-03-06 Tom Tromey <tom@tromey.com>
13760
13761 * remote.c (remote_target::remote_parse_stop_reply): Use
13762 unique_xmalloc_ptr.
13763
13764 2019-03-06 Tom Tromey <tom@tromey.com>
13765
13766 * stabsread.c (struct stabs_field_info): Rename from field_info.
13767 <list, fnlist>: Add initializers.
13768 <obstack>: New member.
13769 (read_member_functions, read_struct_fields, read_baseclasses):
13770 Allocate on obstack. Don't use cleanups.
13771 (read_one_struct_field, read_member_functions, read_struct_fields)
13772 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13773 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13774 (read_struct_type): Update.
13775
13776 2019-03-06 Tom Tromey <tom@tromey.com>
13777
13778 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13779 * common/filestuff.h (make_cleanup_close): Don't declare.
13780 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13781 Remove.
13782
13783 2019-03-06 Tom Tromey <tom@tromey.com>
13784
13785 * solib-aix.c: Use make_scope_exit.
13786
13787 2019-03-06 Tom Tromey <tom@tromey.com>
13788
13789 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13790 Use make_scope_exit.
13791
13792 2019-03-06 Tom Tromey <tom@tromey.com>
13793
13794 * solib-svr4.c (disable_probes_interface): Remove parameter.
13795 (svr4_handle_solib_event): Use make_scope_exit.
13796
13797 2019-03-06 Tom Tromey <tom@tromey.com>
13798
13799 * remote.c (struct stop_reply_deleter): Remove.
13800 (stop_reply_up): Update.
13801 (struct stop_reply): Derive from notif_event. Don't typedef.
13802 <regcache>: Now a std::vector.
13803 (stop_reply_xfree): Remove.
13804 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13805 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
13806 (remote_target::discard_pending_stop_replies): Use delete.
13807 (remote_target::remote_parse_stop_reply): Update.
13808 (remote_target::process_stop_reply): Update.
13809 * remote-notif.h (struct notif_event): Add virtual destructor.
13810 Remove "dtr" member.
13811 (struct notif_client) <alloc_event>: Return a unique_ptr.
13812 (notif_event_xfree): Don't declare.
13813 (notif_event_up): New typedef.
13814 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13815 (notif_event_xfree, do_notif_event_xfree): Remove.
13816 (remote_notif_state_xfree): Update.
13817
13818 2019-03-06 Tom Tromey <tom@tromey.com>
13819
13820 * infrun.c (displaced_step_clear_cleanup): Now a
13821 forward_scope_exit type.
13822 (displaced_step_prepare_throw): Update.
13823 (displaced_step_fixup): Update.
13824
13825 2019-03-06 Tom Tromey <tom@tromey.com>
13826
13827 * inferior.h (class inferior): Update comment.
13828 * gdbthread.h (class thread_info): Update comment.
13829
13830 2019-03-06 Joel Brobecker <brobecker@adacore.com>
13831 Tom Tromey <tom@tromey.com>
13832
13833 * stabsread.h (struct stab_section_list): Remove.
13834 (coffstab_build_psymtabs): Update.
13835 * dbxread.c (symbuf_sections): Now a std::vector.
13836 (sect_idx): New global.
13837 (fill_symbuf): Update.
13838 (coffstab_build_psymtabs): Change type of stabsects parameter.
13839 Update.
13840 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13841 std::vector.
13842 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13843 (coff_locate_sections): Update.
13844 (coff_symfile_read): Remove cleanups. Update.
13845 (init_stringtab): Add storage parameter.
13846 (free_stringtab, free_stringtab_cleanup): Remove.
13847 (init_lineno): Add storage parameter.
13848 (free_linetab, free_linetab_cleanup): Remove.
13849
13850 2019-03-06 Pedro Alves <palves@redhat.com>
13851
13852 * linux-fork.c (fork_info::clobber_regs): Delete.
13853 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13854 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
13855 comment. Adjust.
13856 (scoped_switch_fork_info::scoped_switch_fork_info)
13857 (checkpoint_command, linux_fork_context): Adjust
13858 fork_save_infrun_state calls.
13859
13860 2019-03-06 Pedro Alves <palves@redhat.com>
13861
13862 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13863 (inf_has_multiple_threads): Return 'bool' and rewrite using
13864 inferior_info::threads().
13865
13866 2019-03-06 Pedro Alves <palves@redhat.com>
13867
13868 * linux-fork.c: Include <list>.
13869 (fork_list): Now a std::list instance.
13870 (fork_info): Add ctor, dtor, and in-class initialize all fields.
13871 (forks_exist_p, find_last_fork): Adjust.
13872 (new_fork): Delete.
13873 (one_fork_p): New.
13874 (add_fork): Adjust.
13875 (free_fork): Delete, folded into fork_info::~fork_info().
13876 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13877 Adjust.
13878 (init_fork_list): Delete.
13879 (linux_fork_killall, linux_fork_mourn_inferior)
13880 (linux_fork_detach, info_checkpoints_command): Adjust.
13881 (_initialize_linux_fork): No longer call init_fork_list.
13882
13883 2019-03-06 Pedro Alves <palves@redhat.com>
13884
13885 * linux-fork.c (new_fork): New, split out of ...
13886 (add_fork): ... this. Return void. Move "first fork" special
13887 case from here, to ...
13888 (checkpoint_command): ... here.
13889 * linux-linux.h (add_fork): Return void.
13890
13891 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13892
13893 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13894
13895 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13896 Chris January <chris.january@arm.com>
13897 David Lecomber <david.lecomber@arm.com>
13898
13899 * f-exp.y: New token, UNOP_INTRINSIC.
13900 (exp): New pattern using UNOP_INTRINSIC token.
13901 (f77_keywords): Add 'abs' keyword.
13902 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13903 (value_from_host_double): New function.
13904 (evaluate_subexp_f): Support UNOP_ABS.
13905
13906 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13907
13908 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13909 types.
13910
13911 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13912
13913 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13914 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13915 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13916
13917 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13918
13919 * f-exp.y (convert_to_kind_type): Handle more type kinds.
13920
13921 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13922 Chris January <chris.january@arm.com>
13923
13924 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13925 * f-exp.y: Define 'KIND' token.
13926 (exp): New pattern for KIND expressions.
13927 (ptype): Handle types with a kind extension.
13928 (direct_abs_decl): Extend to spot kind extensions.
13929 (f77_keywords): Add 'kind' to the list.
13930 (push_kind_type): New function.
13931 (convert_to_kind_type): New function.
13932 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13933 * parse.c (operator_length_standard): Likewise.
13934 * parser-defs.h (enum type_pieces): Add tp_kind.
13935 * std-operator.def: Add UNOP_KIND.
13936
13937 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13938
13939 * f-exp.y (f_parse): Set yydebug.
13940
13941 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13942
13943 * f-lang.c (evaluate_subexp_f): New function.
13944 (exp_descriptor_f): New global.
13945 (f_language_defn): Use exp_descriptor_f instead of
13946 exp_descriptor_standard.
13947
13948 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13949
13950 * f-exp.y (struct token): Add comments.
13951 (dot_ops): Remove uppercase versions and the end marker.
13952 (f77_keywords): Likewise.
13953 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13954 entries in the dot_ops array are case insensitive, and use
13955 strncasecmp to compare strings. Also some whitespace cleanup in
13956 this area. Similar for the f77_keywords array, except entries in
13957 this list might be case sensitive.
13958
13959 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13960
13961 * f-exp.y (struct f77_boolean_val): Add comments.
13962 (boolean_values): Remove uppercase versions, and end marker.
13963 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13964 and use strncasecmp to achieve case insensitivity. Additionally,
13965 perform whitespace cleanup around this code.
13966
13967 2019-03-06 Tom Tromey <tromey@adacore.com>
13968
13969 * remote-sim.c (gdbsim_target_open): Use result of
13970 gdb_argv::release.
13971
13972 2019-03-06 Richard Bunt <richard.bunt@arm.com>
13973 Dirk Schubert <dirk.schubert@arm.com>
13974 Chris January <chris.january@arm.com>
13975
13976 * eval.c (evaluate_subexp_standard): Call Fortran argument
13977 wrapping logic.
13978 * f-lang.c (struct value): A value which can be passed into a
13979 Fortran function call.
13980 (fortran_argument_convert): Wrap Fortran arguments in a pointer
13981 where appropriate.
13982 (struct type): Value ready for a Fortran function call.
13983 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13984 is needed.
13985 * f-lang.h (fortran_argument_convert): Declaration.
13986 (fortran_preserve_arg_pointer): Declaration.
13987 * infcall.c (value_arg_coerce): Call Fortran argument logic.
13988
13989 2019-03-05 Tom Tromey <tromey@adacore.com>
13990
13991 * python/py-prettyprint.c (print_string_repr): Remove #if.
13992 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13993
13994 2019-03-05 Tom Tromey <tromey@adacore.com>
13995
13996 * target.c (the_dummy_target): Move later. Change type to
13997 "dummy_target".
13998 (initialize_targets): Don't initialize the_dummy_target.
13999
14000 2019-03-05 Tom Tromey <tromey@adacore.com>
14001
14002 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14003 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14004
14005 2019-03-05 Tom Tromey <tromey@adacore.com>
14006
14007 * windows-nat.c (windows_nat_target::attach)
14008 (windows_nat_target::detach): Don't call gdb_flush.
14009 * valprint.c (generic_val_print, val_print, val_print_string):
14010 Don't call gdb_flush.
14011 * utils.c (defaulted_query): Don't call gdb_flush.
14012 * typeprint.c (print_type_scalar): Don't call gdb_flush.
14013 * target.c (target_announce_detach): Don't call gdb_flush.
14014 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14015 * remote.c (extended_remote_target::attach): Don't call
14016 gdb_flush.
14017 * procfs.c (procfs_target::detach): Don't call gdb_flush.
14018 * printcmd.c (do_examine): Don't call gdb_flush.
14019 (info_display_command): Don't call gdb_flush.
14020 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14021 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14022 * memattr.c (info_mem_command): Don't call gdb_flush.
14023 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14024 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14025 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14026 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14027 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14028 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14029 (gnu_nat_target::detach): Don't call gdb_flush.
14030 * f-valprint.c (f_val_print): Don't call gdb_flush.
14031 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14032 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14033 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14034 gdb_flush.
14035 * c-valprint.c (c_val_print): Don't call gdb_flush.
14036 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14037
14038 2019-03-05 Tom Tromey <tromey@adacore.com>
14039
14040 * varobj.c (update_dynamic_varobj_children): Update.
14041 (install_default_visualizer): Use reset, not release.
14042 * value.c (set_internalvar): Update.
14043 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14044 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14045 ATTRIBUTE_UNUSED_RESULT.
14046
14047 2019-03-05 Tom Tromey <tromey@adacore.com>
14048
14049 * remote.c (class scoped_remote_fd) <release>: Add
14050 ATTRIBUTE_UNUSED_RESULT.
14051
14052 2019-03-05 Tom Tromey <tromey@adacore.com>
14053
14054 * macroexp.c (struct macro_buffer) <release>: Add
14055 ATTRIBUTE_UNUSED_RESULT.
14056
14057 2019-03-05 Tom Tromey <tromey@adacore.com>
14058
14059 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14060 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14061 ATTRIBUTE_UNUSED_RESULT.
14062
14063 2019-03-05 Tom Tromey <tromey@adacore.com>
14064
14065 * common/scoped_fd.h (class scoped_fd) <release>: Add
14066 ATTRIBUTE_UNUSED_RESULT.
14067
14068 2019-03-05 Tom Tromey <tromey@adacore.com>
14069
14070 * parser-defs.h (struct parser_state) <release>: Add
14071 ATTRIBUTE_UNUSED_RESULT.
14072
14073 2019-03-05 Tom Tromey <tromey@adacore.com>
14074
14075 * utils.h (class gdb_argv) <release>: Add
14076 ATTRIBUTE_UNUSED_RESULT.
14077 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14078
14079 2019-03-02 Eli Zaretskii <eliz@gnu.org>
14080
14081 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14082 for-loop range, to avoid compiler warnings.
14083
14084 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14085 avoid compiler warnings about unused variables.
14086
14087 * NEWS: Mention end of support for native debugging on MS-Windows
14088 before XP.
14089
14090 PR gdb/24292
14091 * common/netstuff.c:
14092 * gdbserver/gdbreplay.c
14093 * gdbserver/remote-utils.c:
14094 * ser-tcp.c:
14095 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14096 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
14097 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14098 'getaddrinfo' and 'freeaddrinfo' were not available before
14099 Windows XP, and mingw.org's MinGW headers by default define
14100 _WIN32_WINNT to 0x500.
14101
14102 2019-03-01 Gary Benson <gbenson@redhat.com>
14103
14104 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14105
14106 2019-02-28 Brian Vandenberg <phantall@gmail.com>
14107 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
14108
14109 PR gdb/8527
14110 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14111 set_sigint_trap, clear_sigint_trap.
14112
14113 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14114
14115 * target.c (target_detach): Clear the regcache and the
14116 frame cache.
14117
14118 2019-02-27 Pedro Alves <palves@redhat.com>
14119
14120 * utils.c (set_screen_size): When we cap the height/width sizes,
14121 tweak the corresponding command variable to show "unlimited":
14122
14123 2019-02-27 Saagar Jha <saagar@saagarjha.com>
14124 Pedro Alves <palves@redhat.com>
14125
14126 * utils.c (set_screen_size): Reduce "infinite" rows and columns
14127 before calling rl_set_screen_size.
14128
14129 2019-02-27 Tom Tromey <tromey@adacore.com>
14130
14131 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14132 define.
14133 * python/py-value.c: Remove Python 2.4 workaround.
14134 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14135 workaround.
14136 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14137 Python 2.4 workaround.
14138 * python/python-internal.h: Remove Python 2.4 comment.
14139 (Py_ssize_t): Don't define.
14140 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14141 (gdb_Py_DECREF): Remove Python 2.4 workaround.
14142 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14143 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14144 * python/python.c (do_start_initialization): Remove Python 2.4
14145 workaround.
14146 * python/py-prettyprint.c (class dummy_python_frame): Remove.
14147 (print_children): Remove Python 2.4 workaround.
14148 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14149 workaround.
14150 (CHARBUFFERPROC_NAME): Remove.
14151 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14152 Python 2.4 workaround.
14153
14154 2019-02-27 Kevin Buettner <kevinb@redhat.com>
14155
14156 * NEWS: Note minimum Python version.
14157
14158 2019-02-27 Kevin Buettner <kevinb@redhat.com>
14159
14160 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14161 code from these functions. Remove corresponding ifdefs. Use
14162 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14163 Remove gotos and target of gotos.
14164 (infpy_search_memory): Likewise.
14165
14166 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14167
14168 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14169 (hppa_gdbarch_init): Don't register deleted functions with
14170 gdbarch.
14171
14172 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14173
14174 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14175 (h8300_unwind_sp): Delete.
14176 (h8300_dummy_id): Delete.
14177 (h8300_gdbarch_init): Don't register deleted functions with
14178 gdbarch.
14179
14180 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14181
14182 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14183 (ft32_unwind_pc): Delete.
14184 (ft32_unwind_sp): Delete.
14185 (ft32_gdbarch_init): Don't register deleted functions with
14186 gdbarch.
14187
14188 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14189
14190 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14191 (frv_unwind_pc): Delete.
14192 (frv_unwind_sp): Delete.
14193 (frv_gdbarch_init): Don't register deleted functions with
14194 gdbarch.
14195
14196 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14197
14198 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14199 (riscv_unwind_pc): Delete.
14200 (riscv_unwind_sp): Delete.
14201 (riscv_gdbarch_init): Don't register deleted functions with
14202 gdbarch.
14203
14204 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14205
14206 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14207 (csky_unwind_pc): Delete.
14208 (csky_unwind_sp): Delete.
14209 (csky_gdbarch_init): Don't register deleted functions with
14210 gdbarch.
14211
14212 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14213
14214 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14215 (cris_unwind_pc): Delete.
14216 (cris_unwind_sp): Delete.
14217 (cris_gdbarch_init): Don't register deleted functions with
14218 gdbarch.
14219
14220 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14221
14222 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14223 (bfin_unwind_pc): Delete.
14224 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14225
14226 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14227
14228 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14229 (arm_unwind_pc): Delete.
14230 (arm_unwind_sp): Delete.
14231 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14232
14233 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14234
14235 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14236 (arc_unwind_pc): Delete.
14237 (arc_unwind_sp): Delete.
14238 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14239
14240 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14241
14242 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14243 (alpha_unwind_pc): Delete.
14244 (alpha_gdbarch_init): Don't register deleted functions with
14245 gdbarch.
14246
14247 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14248
14249 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14250 (aarch64_unwind_pc): Delete.
14251 (aarch64_unwind_sp): Delete.
14252 (aarch64_gdbarch_init): Don't register deleted functions with
14253 gdbarch.
14254
14255 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14256
14257 * gdbtypes.c (type_align): Don't consider static members when
14258 computing structure alignment.
14259
14260 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14261
14262 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14263 return 0 for other types.
14264 * arch-utils.c (default_type_align): Always return 0.
14265 * gdbarch.h: Regenerate.
14266 * gdbarch.sh (type_align): Extend comment.
14267 * gdbtypes.c (type_align): Add additional comments, always call
14268 gdbarch_type_align before applying the default rules.
14269 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14270 generic code will then apply a suitable default.
14271 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14272 types, return 0 for other types.
14273
14274 2019-02-27 Joel Brobecker <brobecker@adacore.com>
14275
14276 * NEWS: Create a new section for the next release branch.
14277 Rename the section of the current branch, now that it has
14278 been cut.
14279
14280 2019-02-27 Joel Brobecker <brobecker@adacore.com>
14281
14282 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14283 * version.in: Bump version to 8.3.50.DATE-git.
14284
14285 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
14286
14287 * aix-thread.c (ptid_cmp): Remove unused variable.
14288 (get_signaled_thread): Likewise.
14289 (store_regs_user_thread): Likewise.
14290 (store_regs_kernel_thread): Likewise.
14291 (fetch_regs_kernel_thread): Remove shadowed variable.
14292
14293 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14294
14295 * features/riscv/32bit-cpu.xml: Add register numbers.
14296 * features/riscv/32bit-fpu.c: Regenerate.
14297 * features/riscv/32bit-fpu.xml: Add register numbers.
14298 * features/riscv/64bit-cpu.xml: Add register numbers.
14299 * features/riscv/64bit-fpu.c: Regenerate.
14300 * features/riscv/64bit-fpu.xml: Add register numbers.
14301
14302 2019-02-26 Kevin Buettner <kevinb@redhat.com>
14303
14304 * NEWS: Mention two argument form of gdb.Value constructor.
14305 * python/py-value.c (convert_buffer_and_type_to_value): New
14306 function.
14307 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14308 Add support for handling an optional second argument. Call
14309 convert_buffer_and_type_to_value as appropriate.
14310 * python/python-internal.h (Py_buffer_deleter): New struct.
14311 (Py_buffer_up): New typedef.
14312
14313 2019-02-25 John Baldwin <jhb@FreeBSD.org>
14314
14315 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14316 instead of releasing ownership.
14317
14318 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
14319
14320 * dwarf2read.c (open_and_init_dwp_file): Call
14321 elf_numsections instead of bfd_count_sections to initialize
14322 dwp_file->num_sections.
14323
14324 2019-02-25 Tom Tromey <tromey@adacore.com>
14325
14326 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14327
14328 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14329
14330 * gcore.in: Add '--readnever' option when invoking GDB.
14331
14332 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14333
14334 * MAINTAINERS: Update my email address.
14335
14336 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14337
14338 * build-id.c (build_id_to_debug_bfd_1): New function.
14339 (build_id_to_debug_bfd): Look for separate debug file in
14340 sysroot.
14341
14342 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14343
14344 * gdbarch.sh: Update the copyright year range that is placed into
14345 generated files.
14346
14347 2019-02-22 Keith Seitz <keiths@redhat.com>
14348
14349 PR symtab/23853
14350 * linespec.c (create_sals_line_offset): Search for the default
14351 symtab's filename instead of its fullname.
14352
14353 2019-02-21 Alan Hayward <alan.hayward@arm.com>
14354
14355 * NEWS: Update style defaults.
14356
14357 2019-02-21 Alan Hayward <alan.hayward@arm.com>
14358
14359 * main.c (captured_main_1): Disable styling in batch mode.
14360
14361 2019-02-20 Tom Tromey <tom@tromey.com>
14362
14363 * symtab.c (symtab_symbol_info): Fix typos.
14364
14365 2019-02-20 Tom Tromey <tromey@adacore.com>
14366
14367 * findcmd.c (_initialize_mem_search): Use upper case for
14368 metasyntactic variables.
14369
14370 2019-02-20 Alan Hayward <alan.hayward@arm.com>
14371
14372 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14373 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14374
14375 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14376
14377 * top.h (source_file_name): Change to std::string.
14378 * top.c (source_file_name): Likewise.
14379 (command_line_input): Adjust.
14380 * cli/cli-script.c (script_from_file): Adjust.
14381
14382 2019-02-19 Tom Tromey <tromey@adacore.com>
14383
14384 * ravenscar-thread.c
14385 (ravenscar_thread_target::update_thread_list): Don't call
14386 ada_build_task_list.
14387 * ada-lang.h (ada_build_task_list): Don't declare.
14388 * ada-tasks.c (struct ada_tasks_inferior_data)
14389 <task_list_valid_p>: Now bool.
14390 (read_known_tasks, ada_task_list_changed)
14391 (ada_tasks_invalidate_inferior_data): Update.
14392 (read_known_tasks_array): Return bool.
14393 (read_known_tasks_list): Likewise.
14394 (read_known_tasks): Return void.
14395 (ada_build_task_list): Now static.
14396
14397 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14398
14399 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14400 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14401
14402 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14403
14404 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14405 variant for ada_tasks_pspace_data_handle and
14406 ada_tasks_inferior_data_handle.
14407 (ada_tasks_pspace_data_cleanup): New function.
14408 (ada_tasks_inferior_data_cleanup): New function.
14409
14410 2019-02-17 Tom Tromey <tom@tromey.com>
14411
14412 * macrotab.h (macro_source_fullname): Return a std::string.
14413 * macrotab.c (macro_include, check_for_redefinition)
14414 (macro_undef, macro_lookup_definition, foreach_macro)
14415 (foreach_macro_in_scope): Update.
14416 (macro_source_fullname): Return a std::string.
14417 * macrocmd.c (show_pp_source_pos): Update.
14418
14419 2019-02-17 Tom Tromey <tom@tromey.com>
14420
14421 * macrocmd.c (show_pp_source_pos): Style the file names.
14422
14423 2019-02-17 Tom Tromey <tom@tromey.com>
14424
14425 PR tui/24197:
14426 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14427
14428 2019-02-17 Tom Tromey <tom@tromey.com>
14429
14430 * ada-lang.c (user_select_syms): Use filtered printing.
14431 * utils.c (wrap_style): New global.
14432 (desired_style): Remove.
14433 (emit_style_escape): Add stream parameter.
14434 (set_output_style, reset_terminal_style, prompt_for_continue):
14435 Update.
14436 (flush_wrap_buffer): Only flush gdb_stdout.
14437 (wrap_here): Set wrap_style.
14438 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14439 treat escape sequences as a character. Change when wrap buffer is
14440 flushed.
14441 (fputs_styled): Do not set the output style when the default is
14442 requested.
14443 * ui-style.h (struct ui_file_style) <is_default>: New method.
14444 * source.c (print_source_lines_base): Emit escape sequences in one
14445 piece.
14446
14447 2019-02-17 Joel Brobecker <brobecker@adacore.com>
14448
14449 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14450 integers and enumeration types.
14451
14452 2019-02-17 Joel Brobecker <brobecker@adacore.com>
14453
14454 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14455 instead of lookup_symbol_in_language
14456 (do_exact_match): New function.
14457 (ada_get_symbol_name_matcher): Return do_exact_match when
14458 doing a verbatim match.
14459
14460 2019-02-15 Tom Tromey <tromey@adacore.com>
14461
14462 * ravenscar-thread.c (ravenscar_thread_target::resume)
14463 (ravenscar_thread_target::wait): Special case wildcard requests.
14464
14465 2019-02-15 Tom Tromey <tromey@adacore.com>
14466
14467 * ravenscar-thread.c (base_ptid): Remove.
14468 (struct ravenscar_thread_target) <close>: New method.
14469 <m_base_ptid>: New member.
14470 <update_inferior_ptid, active_task, task_is_currently_active,
14471 runtime_initialized>: Declare methods.
14472 <ravenscar_thread_target>: Add constructor.
14473 (ravenscar_thread_target::task_is_currently_active)
14474 (ravenscar_thread_target::update_inferior_ptid)
14475 (ravenscar_runtime_initialized): Rename. Now methods.
14476 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14477 (ravenscar_thread_target::update_thread_list): Update.
14478 (ravenscar_thread_target::active_task): Now method.
14479 (ravenscar_thread_target::store_registers)
14480 (ravenscar_thread_target::prepare_to_store)
14481 (ravenscar_thread_target::prepare_to_store)
14482 (ravenscar_thread_target::mourn_inferior): Update.
14483 (ravenscar_inferior_created): Use "new" to create target.
14484 (ravenscar_thread_target::get_ada_task_ptid): Update.
14485 (_initialize_ravenscar): Don't initialize base_ptid.
14486 (ravenscar_ops): Remove global.
14487
14488 2019-02-15 Tom Tromey <tromey@adacore.com>
14489
14490 * target.h (push_target): Declare new overload.
14491 * target.c (push_target): New overload, taking an rvalue reference.
14492 * remote.c (remote_target::open_1): Use push_target overload.
14493 * corelow.c (core_target_open): Use push_target overload.
14494
14495 2019-02-15 Tom Tromey <tromey@adacore.com>
14496
14497 * ravenscar-thread.c (is_ravenscar_task)
14498 (ravenscar_task_is_currently_active): Return bool.
14499 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14500 (_initialize_ravenscar): Remove "(void)".
14501 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14502 Return bool.
14503
14504 2019-02-15 Tom Tromey <tromey@adacore.com>
14505
14506 * ravenscar-thread.c (ravenscar_runtime_initializer)
14507 (has_ravenscar_runtime, get_running_thread_id)
14508 (ravenscar_thread_target::resume): Fix indentation.
14509
14510 2019-02-15 Tom Tromey <tromey@adacore.com>
14511
14512 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14513 from ravenscar_arch_ops.
14514 (sparc_ravenscar_ops::fetch_registers)
14515 (sparc_ravenscar_ops::store_registers): Now methods.
14516 (sparc_ravenscar_prepare_to_store): Remove.
14517 (sparc_ravenscar_ops): Redefine.
14518 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14519 methods and destructor. Remove members.
14520 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14521 (ravenscar_thread_target::store_registers)
14522 (ravenscar_thread_target::prepare_to_store): Update.
14523 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14524 Remove.
14525 (struct ppc_ravenscar_powerpc_ops): Derive from
14526 ravenscar_arch_ops.
14527 (ppc_ravenscar_powerpc_ops::fetch_registers)
14528 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14529 (ppc_ravenscar_powerpc_ops): Redefine.
14530 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14531 (ppc_ravenscar_e500_ops::fetch_registers)
14532 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14533 (ppc_ravenscar_e500_ops): Redefine.
14534 * aarch64-ravenscar-thread.c
14535 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14536 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14537 (aarch64_ravenscar_fetch_registers)
14538 (aarch64_ravenscar_store_registers): Now methods.
14539 (aarch64_ravenscar_ops): Redefine.
14540
14541 2019-02-15 Tom Tromey <tromey@adacore.com>
14542
14543 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14544 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14545 (ravenscar_thread_target::stopped_by_watchpoint)
14546 (ravenscar_thread_target::stopped_data_address)
14547 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14548
14549 2019-02-15 Tom Tromey <tromey@adacore.com>
14550
14551 * ravenscar-thread.c: Fix some typos.
14552
14553 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14554 Tom Tromey <tromey@adacore.com>
14555
14556 * ada-lang.c (ada_exception_sal): Change addr_string to a
14557 std::string.
14558 (create_ada_exception_catchpoint): Update.
14559
14560 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14561 Tom Tromey <tromey@adacore.com>
14562
14563 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14564 (bp_location_ops): Remove.
14565 (base_breakpoint_allocate_location): Update.
14566 (free_bp_location): Update.
14567 * ada-lang.c (class ada_catchpoint_location)
14568 <ada_catchpoint_location>: Remove ops parameter.
14569 (ada_catchpoint_location_dtor): Remove.
14570 (ada_catchpoint_location_ops): Remove.
14571 (allocate_location_exception): Update.
14572 * breakpoint.h (struct bp_location_ops): Remove.
14573 (class bp_location) <bp_location>: Remove bp_location_ops
14574 parameter.
14575 <~bp_location>: Add destructor.
14576 <ops>: Remove.
14577
14578 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14579 Pedro Alves <palves@redhat.com>
14580
14581 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14582 'PATH_MAX'.
14583
14584 2019-02-14 David Michael <fedora.dm0@gmail.com>
14585 Samuel Thibault <samuel.thibault@gnu.org>
14586 Thomas Schwinge <thomas@codesourcery.com>
14587
14588 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14589 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14590
14591 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14592
14593 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14594 (check_empty): Use "const char *".
14595
14596 * gnu-nat.c (gnu_nat_target::detach): Instead of
14597 'detach_inferior (pid)' call
14598 'detach_inferior (find_inferior_pid (pid))'.
14599
14600 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14601 'nat/fork-inferior.o'.
14602 * gnu-nat.c: #include "nat/fork-inferior.h".
14603
14604 * gnu-nat.c (gnu_nat_target::detach): Instead of
14605 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14606 * gnu-nat.h: #include "inf-child.h".
14607 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14608 'i386_gnu_nat_target::fetch_registers'.
14609 (gnu_store_registers): Rename/move to
14610 'i386_gnu_nat_target::store_registers'.
14611
14612 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14613 * gnu-nat.h (mach_thread_info): New function.
14614 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14615
14616 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14617
14618 2019-02-14 Frederic Konrad <konrad@adacore.com>
14619
14620 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14621
14622 2019-02-14 Joel Brobecker <brobecker@adacore.com>
14623
14624 * windows-nat.c (windows_add_thread): Add new parameter
14625 "main_thread_p" with default value set to false. Update
14626 function documentation as well as all callers.
14627 (windows_delete_thread): Likewise.
14628 (fake_create_process): Update call to windows_add_thread.
14629 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14630 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14631 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14632 call to windows_delete_thread.
14633
14634 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14635
14636 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14637
14638 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14639
14640 * symfile.c (find_separate_debug_file): Use canonical path of
14641 sysroot with child_path instead of gdb_sysroot if it is valid.
14642
14643 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14644
14645 * symfile.c (find_separate_debug_file): Use child_path to
14646 determine if an object file is under a sysroot.
14647
14648 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14649
14650 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14651 unittests/child-path-selftests.c.
14652 * common/pathstuff.c (child_path): New function.
14653 * common/pathstuff.h (child_path): New prototype.
14654 * unittests/child-path-selftests.c: New file.
14655
14656 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14657
14658 * symfile.c (find_separate_debug_file): Look for separate debug
14659 files in debug directories under the sysroot.
14660
14661 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14662
14663 * symtab.h (struct minimal_symbol data_p): New const method.
14664 (struct minimal_symbol text_p): Likewise.
14665 * symtab.c (output_source_filename): Use file name style
14666 to print file name.
14667 (print_symbol_info): Likewise.
14668 (print_msymbol_info): Use address style to print addresses.
14669 Use function name style to print executable text symbols.
14670 (expand_symtab_containing_pc): Use data_p.
14671 (find_pc_sect_compunit_symtab): Likewise.
14672
14673 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14674
14675 * breakpoint.c (describe_other_breakpoints): Use address style
14676 to print addresses.
14677 (say_where): Likewise.
14678
14679 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14680
14681 * ada-typeprint.c (print_func_type): Print function name
14682 style to print function name.
14683 * c-typeprint.c (c_print_type_1): Likewise.
14684
14685 2019-02-11 Alan Hayward <alan.hayward@arm.com>
14686
14687 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14688 for execve.
14689
14690 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14691
14692 * c-exp.y (direct_abs_decl): Use emplace_back to record the
14693 type_stack.
14694
14695 2019-02-10 Joel Brobecker <brobecker@adacore.com>
14696
14697 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14698 TYPE_CODE_REF types.
14699
14700 2019-02-08 Jim Wilson <jimw@sifive.com>
14701
14702 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14703 (riscv_linux_fregset): New.
14704 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14705
14706 2019-02-07 Tom Tromey <tom@tromey.com>
14707
14708 * thread.c (thread_cancel_execution_command): Update.
14709 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14710 methods.
14711 (struct thread_fsm_ops): Remove.
14712 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14713 (thread_fsm_should_stop, thread_fsm_return_value)
14714 (thread_fsm_set_finished, thread_fsm_finished_p)
14715 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14716 Don't declare.
14717 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14718 * infrun.c (clear_proceed_status_thread)
14719 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14720 (print_stop_event): Update.
14721 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14722 Add constructor.
14723 (step_command_fsm_ops): Remove.
14724 (new_step_command_fsm): Remove.
14725 (step_1): Update.
14726 (step_command_fsm::should_stop): Rename from
14727 step_command_fsm_should_stop.
14728 (step_command_fsm::clean_up): Rename from
14729 step_command_fsm_clean_up.
14730 (step_command_fsm::do_async_reply_reason): Rename from
14731 step_command_fsm_async_reply_reason.
14732 (struct until_next_fsm): Inherit from thread_fsm. Add
14733 constructor.
14734 (until_next_fsm_ops): Remove.
14735 (new_until_next_fsm): Remove.
14736 (until_next_fsm::should_stop): Rename from
14737 until_next_fsm_should_stop.
14738 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14739 (until_next_fsm::do_async_reply_reason): Rename from
14740 until_next_fsm_async_reply_reason.
14741 (struct finish_command_fsm): Inherit from thread_fsm. Add
14742 constructor. Change type of breakpoint.
14743 (finish_command_fsm_ops): Remove.
14744 (new_finish_command_fsm): Remove.
14745 (finish_command_fsm::should_stop): Rename from
14746 finish_command_fsm_should_stop.
14747 (finish_command_fsm::clean_up): Rename from
14748 finish_command_fsm_clean_up.
14749 (finish_command_fsm::return_value): Rename from
14750 finish_command_fsm_return_value.
14751 (finish_command_fsm::do_async_reply_reason): Rename from
14752 finish_command_fsm_async_reply_reason.
14753 (finish_command): Update.
14754 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14755 Add constructor.
14756 (call_thread_fsm_ops): Remove.
14757 (call_thread_fsm::call_thread_fsm): Rename from
14758 new_call_thread_fsm.
14759 (call_thread_fsm::should_stop): Rename from
14760 call_thread_fsm_should_stop.
14761 (call_thread_fsm::should_notify_stop): Rename from
14762 call_thread_fsm_should_notify_stop.
14763 (run_inferior_call, call_function_by_hand_dummy): Update.
14764 * cli/cli-interp.c (should_print_stop_to_console): Update.
14765 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14766 Add constructor. Change type of location_breakpoint,
14767 caller_breakpoint.
14768 (until_break_fsm_ops): Remove.
14769 (new_until_break_fsm): Remove.
14770 (until_break_fsm::should_stop): Rename from
14771 until_break_fsm_should_stop.
14772 (until_break_fsm::clean_up): Rename from
14773 until_break_fsm_clean_up.
14774 (until_break_fsm::do_async_reply_reason): Rename from
14775 until_break_fsm_async_reply_reason.
14776 (until_break_command): Update.
14777 * thread-fsm.c: Remove.
14778 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14779
14780 2019-02-07 Tom Tromey <tom@tromey.com>
14781
14782 * yy-remap.h: Add include guard.
14783 * xtensa-tdep.h: Add include guard.
14784 * xcoffread.h: Rename include guard.
14785 * varobj-iter.h: Add include guard.
14786 * tui/tui.h: Rename include guard.
14787 * tui/tui-winsource.h: Rename include guard.
14788 * tui/tui-wingeneral.h: Rename include guard.
14789 * tui/tui-windata.h: Rename include guard.
14790 * tui/tui-win.h: Rename include guard.
14791 * tui/tui-stack.h: Rename include guard.
14792 * tui/tui-source.h: Rename include guard.
14793 * tui/tui-regs.h: Rename include guard.
14794 * tui/tui-out.h: Rename include guard.
14795 * tui/tui-layout.h: Rename include guard.
14796 * tui/tui-io.h: Rename include guard.
14797 * tui/tui-hooks.h: Rename include guard.
14798 * tui/tui-file.h: Rename include guard.
14799 * tui/tui-disasm.h: Rename include guard.
14800 * tui/tui-data.h: Rename include guard.
14801 * tui/tui-command.h: Rename include guard.
14802 * tic6x-tdep.h: Add include guard.
14803 * target/waitstatus.h: Rename include guard.
14804 * target/wait.h: Rename include guard.
14805 * target/target.h: Rename include guard.
14806 * target/resume.h: Rename include guard.
14807 * target-float.h: Rename include guard.
14808 * stabsread.h: Add include guard.
14809 * rs6000-tdep.h: Add include guard.
14810 * riscv-fbsd-tdep.h: Add include guard.
14811 * regformats/regdef.h: Rename include guard.
14812 * record.h: Rename include guard.
14813 * python/python.h: Rename include guard.
14814 * python/python-internal.h: Rename include guard.
14815 * python/py-stopevent.h: Rename include guard.
14816 * python/py-ref.h: Rename include guard.
14817 * python/py-record.h: Rename include guard.
14818 * python/py-record-full.h: Rename include guard.
14819 * python/py-record-btrace.h: Rename include guard.
14820 * python/py-instruction.h: Rename include guard.
14821 * python/py-events.h: Rename include guard.
14822 * python/py-event.h: Rename include guard.
14823 * procfs.h: Add include guard.
14824 * proc-utils.h: Add include guard.
14825 * p-lang.h: Add include guard.
14826 * or1k-tdep.h: Rename include guard.
14827 * observable.h: Rename include guard.
14828 * nto-tdep.h: Rename include guard.
14829 * nat/x86-linux.h: Rename include guard.
14830 * nat/x86-linux-dregs.h: Rename include guard.
14831 * nat/x86-gcc-cpuid.h: Add include guard.
14832 * nat/x86-dregs.h: Rename include guard.
14833 * nat/x86-cpuid.h: Rename include guard.
14834 * nat/ppc-linux.h: Rename include guard.
14835 * nat/mips-linux-watch.h: Rename include guard.
14836 * nat/linux-waitpid.h: Rename include guard.
14837 * nat/linux-ptrace.h: Rename include guard.
14838 * nat/linux-procfs.h: Rename include guard.
14839 * nat/linux-osdata.h: Rename include guard.
14840 * nat/linux-nat.h: Rename include guard.
14841 * nat/linux-namespaces.h: Rename include guard.
14842 * nat/linux-btrace.h: Rename include guard.
14843 * nat/glibc_thread_db.h: Rename include guard.
14844 * nat/gdb_thread_db.h: Rename include guard.
14845 * nat/gdb_ptrace.h: Rename include guard.
14846 * nat/fork-inferior.h: Rename include guard.
14847 * nat/amd64-linux-siginfo.h: Rename include guard.
14848 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14849 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14850 * nat/aarch64-linux.h: Rename include guard.
14851 * nat/aarch64-linux-hw-point.h: Rename include guard.
14852 * mn10300-tdep.h: Add include guard.
14853 * mips-linux-tdep.h: Add include guard.
14854 * mi/mi-parse.h: Rename include guard.
14855 * mi/mi-out.h: Rename include guard.
14856 * mi/mi-main.h: Rename include guard.
14857 * mi/mi-interp.h: Rename include guard.
14858 * mi/mi-getopt.h: Rename include guard.
14859 * mi/mi-console.h: Rename include guard.
14860 * mi/mi-common.h: Rename include guard.
14861 * mi/mi-cmds.h: Rename include guard.
14862 * mi/mi-cmd-break.h: Rename include guard.
14863 * m2-lang.h: Add include guard.
14864 * location.h: Rename include guard.
14865 * linux-record.h: Rename include guard.
14866 * linux-nat.h: Add include guard.
14867 * linux-fork.h: Add include guard.
14868 * i386-darwin-tdep.h: Rename include guard.
14869 * hppa-linux-offsets.h: Add include guard.
14870 * guile/guile.h: Rename include guard.
14871 * guile/guile-internal.h: Rename include guard.
14872 * gnu-nat.h: Rename include guard.
14873 * gdb-stabs.h: Rename include guard.
14874 * frv-tdep.h: Add include guard.
14875 * f-lang.h: Add include guard.
14876 * event-loop.h: Add include guard.
14877 * darwin-nat.h: Rename include guard.
14878 * cp-abi.h: Rename include guard.
14879 * config/sparc/nm-sol2.h: Rename include guard.
14880 * config/nm-nto.h: Rename include guard.
14881 * config/nm-linux.h: Add include guard.
14882 * config/i386/nm-i386gnu.h: Rename include guard.
14883 * config/djgpp/nl_types.h: Rename include guard.
14884 * config/djgpp/langinfo.h: Rename include guard.
14885 * compile/gcc-cp-plugin.h: Add include guard.
14886 * compile/gcc-c-plugin.h: Add include guard.
14887 * compile/compile.h: Rename include guard.
14888 * compile/compile-object-run.h: Rename include guard.
14889 * compile/compile-object-load.h: Rename include guard.
14890 * compile/compile-internal.h: Rename include guard.
14891 * compile/compile-cplus.h: Rename include guard.
14892 * compile/compile-c.h: Rename include guard.
14893 * common/xml-utils.h: Rename include guard.
14894 * common/x86-xstate.h: Rename include guard.
14895 * common/version.h: Rename include guard.
14896 * common/vec.h: Rename include guard.
14897 * common/tdesc.h: Rename include guard.
14898 * common/selftest.h: Rename include guard.
14899 * common/scoped_restore.h: Rename include guard.
14900 * common/scoped_mmap.h: Rename include guard.
14901 * common/scoped_fd.h: Rename include guard.
14902 * common/safe-iterator.h: Rename include guard.
14903 * common/run-time-clock.h: Rename include guard.
14904 * common/refcounted-object.h: Rename include guard.
14905 * common/queue.h: Rename include guard.
14906 * common/ptid.h: Rename include guard.
14907 * common/print-utils.h: Rename include guard.
14908 * common/preprocessor.h: Rename include guard.
14909 * common/pathstuff.h: Rename include guard.
14910 * common/observable.h: Rename include guard.
14911 * common/netstuff.h: Rename include guard.
14912 * common/job-control.h: Rename include guard.
14913 * common/host-defs.h: Rename include guard.
14914 * common/gdb_wait.h: Rename include guard.
14915 * common/gdb_vecs.h: Rename include guard.
14916 * common/gdb_unlinker.h: Rename include guard.
14917 * common/gdb_unique_ptr.h: Rename include guard.
14918 * common/gdb_tilde_expand.h: Rename include guard.
14919 * common/gdb_sys_time.h: Rename include guard.
14920 * common/gdb_string_view.h: Rename include guard.
14921 * common/gdb_splay_tree.h: Rename include guard.
14922 * common/gdb_setjmp.h: Rename include guard.
14923 * common/gdb_ref_ptr.h: Rename include guard.
14924 * common/gdb_optional.h: Rename include guard.
14925 * common/gdb_locale.h: Rename include guard.
14926 * common/gdb_assert.h: Rename include guard.
14927 * common/filtered-iterator.h: Rename include guard.
14928 * common/filestuff.h: Rename include guard.
14929 * common/fileio.h: Rename include guard.
14930 * common/environ.h: Rename include guard.
14931 * common/common-utils.h: Rename include guard.
14932 * common/common-types.h: Rename include guard.
14933 * common/common-regcache.h: Rename include guard.
14934 * common/common-inferior.h: Rename include guard.
14935 * common/common-gdbthread.h: Rename include guard.
14936 * common/common-exceptions.h: Rename include guard.
14937 * common/common-defs.h: Rename include guard.
14938 * common/common-debug.h: Rename include guard.
14939 * common/cleanups.h: Rename include guard.
14940 * common/buffer.h: Rename include guard.
14941 * common/btrace-common.h: Rename include guard.
14942 * common/break-common.h: Rename include guard.
14943 * cli/cli-utils.h: Rename include guard.
14944 * cli/cli-style.h: Rename include guard.
14945 * cli/cli-setshow.h: Rename include guard.
14946 * cli/cli-script.h: Rename include guard.
14947 * cli/cli-interp.h: Rename include guard.
14948 * cli/cli-decode.h: Rename include guard.
14949 * cli/cli-cmds.h: Rename include guard.
14950 * charset-list.h: Add include guard.
14951 * buildsym-legacy.h: Rename include guard.
14952 * bfin-tdep.h: Add include guard.
14953 * ax.h: Rename include guard.
14954 * arm-linux-tdep.h: Add include guard.
14955 * arm-fbsd-tdep.h: Add include guard.
14956 * arch/xtensa.h: Rename include guard.
14957 * arch/tic6x.h: Add include guard.
14958 * arch/i386.h: Add include guard.
14959 * arch/arm.h: Rename include guard.
14960 * arch/arm-linux.h: Rename include guard.
14961 * arch/arm-get-next-pcs.h: Rename include guard.
14962 * arch/amd64.h: Add include guard.
14963 * arch/aarch64-insn.h: Rename include guard.
14964 * arch-utils.h: Rename include guard.
14965 * annotate.h: Add include guard.
14966 * amd64-darwin-tdep.h: Rename include guard.
14967 * aarch64-linux-tdep.h: Add include guard.
14968 * aarch64-fbsd-tdep.h: Add include guard.
14969 * aarch32-linux-nat.h: Add include guard.
14970
14971 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14972
14973 * macrotab.c (macro_define_internal): New function that
14974 factorizes macro_define_object_internal and macro_define_function
14975 code.
14976 (macro_define_object_internal): Use macro_define_internal.
14977 (macro_define_function): Likewise.
14978
14979 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14980
14981 * macrocmd.c (extract_identifier): Return
14982 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14983 callers.
14984
14985 2019-02-06 John Baldwin <jhb@FreeBSD.org>
14986
14987 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14988
14989 2019-02-05 Tom Tromey <tom@tromey.com>
14990
14991 * target.c (target_stack::unpush): Move assertion earlier.
14992
14993 2019-01-30 Tom Tromey <tom@tromey.com>
14994
14995 PR python/23615:
14996 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14997 (gdbpy_parse_and_eval): Likewise.
14998 * python/python-internal.h (gdbpy_allow_threads): New class.
14999
15000 2019-01-28 John Baldwin <jhb@FreeBSD.org>
15001
15002 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15003 (aarch64_fbsd_fpregmap): Move earlier.
15004 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15005 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15006 instead of individual calls to trad_frame_set_reg_addr.
15007 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15008 earlier.
15009 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15010 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15011 instead of individual calls to trad_frame_set_reg_addr.
15012
15013 2019-01-28 Alan Hayward <alan.hayward@arm.com>
15014
15015 * CONTRIBUTE: Replace contribution list with wiki link.
15016
15017 2019-01-25 Tom Tromey <tom@tromey.com>
15018
15019 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15020
15021 2019-01-25 Tom Tromey <tom@tromey.com>
15022
15023 * xtensa-linux-nat.c: Fix common/ includes.
15024 * xml-support.h: Fix common/ includes.
15025 * xml-support.c: Fix common/ includes.
15026 * x86-linux-nat.c: Fix common/ includes.
15027 * windows-nat.c: Fix common/ includes.
15028 * varobj.h: Fix common/ includes.
15029 * varobj.c: Fix common/ includes.
15030 * value.c: Fix common/ includes.
15031 * valops.c: Fix common/ includes.
15032 * utils.c: Fix common/ includes.
15033 * unittests/xml-utils-selftests.c: Fix common/ includes.
15034 * unittests/utils-selftests.c: Fix common/ includes.
15035 * unittests/unpack-selftests.c: Fix common/ includes.
15036 * unittests/tracepoint-selftests.c: Fix common/ includes.
15037 * unittests/style-selftests.c: Fix common/ includes.
15038 * unittests/string_view-selftests.c: Fix common/ includes.
15039 * unittests/scoped_restore-selftests.c: Fix common/ includes.
15040 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15041 * unittests/scoped_fd-selftests.c: Fix common/ includes.
15042 * unittests/rsp-low-selftests.c: Fix common/ includes.
15043 * unittests/parse-connection-spec-selftests.c: Fix common/
15044 includes.
15045 * unittests/optional-selftests.c: Fix common/ includes.
15046 * unittests/offset-type-selftests.c: Fix common/ includes.
15047 * unittests/observable-selftests.c: Fix common/ includes.
15048 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15049 * unittests/memrange-selftests.c: Fix common/ includes.
15050 * unittests/memory-map-selftests.c: Fix common/ includes.
15051 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15052 * unittests/function-view-selftests.c: Fix common/ includes.
15053 * unittests/environ-selftests.c: Fix common/ includes.
15054 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15055 * unittests/common-utils-selftests.c: Fix common/ includes.
15056 * unittests/cli-utils-selftests.c: Fix common/ includes.
15057 * unittests/array-view-selftests.c: Fix common/ includes.
15058 * ui-file.c: Fix common/ includes.
15059 * tui/tui-io.c: Fix common/ includes.
15060 * tracepoint.h: Fix common/ includes.
15061 * tracepoint.c: Fix common/ includes.
15062 * tracefile-tfile.c: Fix common/ includes.
15063 * top.h: Fix common/ includes.
15064 * top.c: Fix common/ includes.
15065 * thread.c: Fix common/ includes.
15066 * target/waitstatus.h: Fix common/ includes.
15067 * target/waitstatus.c: Fix common/ includes.
15068 * target.h: Fix common/ includes.
15069 * target.c: Fix common/ includes.
15070 * target-memory.c: Fix common/ includes.
15071 * target-descriptions.c: Fix common/ includes.
15072 * symtab.h: Fix common/ includes.
15073 * symfile.c: Fix common/ includes.
15074 * stap-probe.c: Fix common/ includes.
15075 * spu-linux-nat.c: Fix common/ includes.
15076 * sparc-nat.c: Fix common/ includes.
15077 * source.c: Fix common/ includes.
15078 * solib.c: Fix common/ includes.
15079 * solib-target.c: Fix common/ includes.
15080 * ser-unix.c: Fix common/ includes.
15081 * ser-tcp.c: Fix common/ includes.
15082 * ser-pipe.c: Fix common/ includes.
15083 * ser-base.c: Fix common/ includes.
15084 * selftest-arch.c: Fix common/ includes.
15085 * s12z-tdep.c: Fix common/ includes.
15086 * rust-exp.y: Fix common/ includes.
15087 * rs6000-aix-tdep.c: Fix common/ includes.
15088 * riscv-tdep.c: Fix common/ includes.
15089 * remote.c: Fix common/ includes.
15090 * remote-notif.h: Fix common/ includes.
15091 * remote-fileio.h: Fix common/ includes.
15092 * remote-fileio.c: Fix common/ includes.
15093 * regcache.h: Fix common/ includes.
15094 * regcache.c: Fix common/ includes.
15095 * record-btrace.c: Fix common/ includes.
15096 * python/python.c: Fix common/ includes.
15097 * python/py-type.c: Fix common/ includes.
15098 * python/py-inferior.c: Fix common/ includes.
15099 * progspace.h: Fix common/ includes.
15100 * producer.c: Fix common/ includes.
15101 * procfs.c: Fix common/ includes.
15102 * proc-api.c: Fix common/ includes.
15103 * printcmd.c: Fix common/ includes.
15104 * ppc-linux-nat.c: Fix common/ includes.
15105 * parser-defs.h: Fix common/ includes.
15106 * osdata.c: Fix common/ includes.
15107 * obsd-nat.c: Fix common/ includes.
15108 * nat/x86-linux.c: Fix common/ includes.
15109 * nat/x86-linux-dregs.c: Fix common/ includes.
15110 * nat/x86-dregs.h: Fix common/ includes.
15111 * nat/x86-dregs.c: Fix common/ includes.
15112 * nat/ppc-linux.c: Fix common/ includes.
15113 * nat/mips-linux-watch.h: Fix common/ includes.
15114 * nat/mips-linux-watch.c: Fix common/ includes.
15115 * nat/linux-waitpid.c: Fix common/ includes.
15116 * nat/linux-ptrace.h: Fix common/ includes.
15117 * nat/linux-ptrace.c: Fix common/ includes.
15118 * nat/linux-procfs.c: Fix common/ includes.
15119 * nat/linux-personality.c: Fix common/ includes.
15120 * nat/linux-osdata.c: Fix common/ includes.
15121 * nat/linux-namespaces.c: Fix common/ includes.
15122 * nat/linux-btrace.h: Fix common/ includes.
15123 * nat/linux-btrace.c: Fix common/ includes.
15124 * nat/fork-inferior.c: Fix common/ includes.
15125 * nat/amd64-linux-siginfo.c: Fix common/ includes.
15126 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15127 * nat/aarch64-linux.c: Fix common/ includes.
15128 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15129 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15130 * namespace.h: Fix common/ includes.
15131 * mips-linux-tdep.c: Fix common/ includes.
15132 * minsyms.c: Fix common/ includes.
15133 * mi/mi-parse.h: Fix common/ includes.
15134 * mi/mi-main.c: Fix common/ includes.
15135 * mi/mi-cmd-env.c: Fix common/ includes.
15136 * memrange.h: Fix common/ includes.
15137 * memattr.c: Fix common/ includes.
15138 * maint.h: Fix common/ includes.
15139 * maint.c: Fix common/ includes.
15140 * main.c: Fix common/ includes.
15141 * machoread.c: Fix common/ includes.
15142 * location.c: Fix common/ includes.
15143 * linux-thread-db.c: Fix common/ includes.
15144 * linux-nat.c: Fix common/ includes.
15145 * linux-fork.c: Fix common/ includes.
15146 * inline-frame.c: Fix common/ includes.
15147 * infrun.c: Fix common/ includes.
15148 * inflow.c: Fix common/ includes.
15149 * inferior.h: Fix common/ includes.
15150 * inferior.c: Fix common/ includes.
15151 * infcmd.c: Fix common/ includes.
15152 * inf-ptrace.c: Fix common/ includes.
15153 * inf-child.c: Fix common/ includes.
15154 * ia64-linux-nat.c: Fix common/ includes.
15155 * i387-tdep.c: Fix common/ includes.
15156 * i386-tdep.c: Fix common/ includes.
15157 * i386-linux-tdep.c: Fix common/ includes.
15158 * i386-linux-nat.c: Fix common/ includes.
15159 * i386-go32-tdep.c: Fix common/ includes.
15160 * i386-fbsd-tdep.c: Fix common/ includes.
15161 * i386-fbsd-nat.c: Fix common/ includes.
15162 * guile/scm-type.c: Fix common/ includes.
15163 * guile/guile.c: Fix common/ includes.
15164 * go32-nat.c: Fix common/ includes.
15165 * gnu-nat.c: Fix common/ includes.
15166 * gdbthread.h: Fix common/ includes.
15167 * gdbarch-selftests.c: Fix common/ includes.
15168 * gdb_usleep.c: Fix common/ includes.
15169 * gdb_select.h: Fix common/ includes.
15170 * gdb_bfd.c: Fix common/ includes.
15171 * gcore.c: Fix common/ includes.
15172 * fork-child.c: Fix common/ includes.
15173 * findvar.c: Fix common/ includes.
15174 * fbsd-nat.c: Fix common/ includes.
15175 * event-top.c: Fix common/ includes.
15176 * event-loop.c: Fix common/ includes.
15177 * dwarf2read.c: Fix common/ includes.
15178 * dwarf2loc.c: Fix common/ includes.
15179 * dwarf2-frame.c: Fix common/ includes.
15180 * dwarf-index-cache.c: Fix common/ includes.
15181 * dtrace-probe.c: Fix common/ includes.
15182 * disasm-selftests.c: Fix common/ includes.
15183 * defs.h: Fix common/ includes.
15184 * csky-tdep.c: Fix common/ includes.
15185 * cp-valprint.c: Fix common/ includes.
15186 * cp-support.h: Fix common/ includes.
15187 * cp-support.c: Fix common/ includes.
15188 * corelow.c: Fix common/ includes.
15189 * completer.h: Fix common/ includes.
15190 * completer.c: Fix common/ includes.
15191 * compile/compile.c: Fix common/ includes.
15192 * compile/compile-loc2c.c: Fix common/ includes.
15193 * compile/compile-cplus-types.c: Fix common/ includes.
15194 * compile/compile-cplus-symbols.c: Fix common/ includes.
15195 * command.h: Fix common/ includes.
15196 * cli/cli-dump.c: Fix common/ includes.
15197 * cli/cli-cmds.c: Fix common/ includes.
15198 * charset.c: Fix common/ includes.
15199 * build-id.c: Fix common/ includes.
15200 * btrace.h: Fix common/ includes.
15201 * btrace.c: Fix common/ includes.
15202 * breakpoint.h: Fix common/ includes.
15203 * breakpoint.c: Fix common/ includes.
15204 * ax.h:
15205 (enum agent_op): Fix common/ includes.
15206 * ax-general.c (struct aop_map): Fix common/ includes.
15207 * ax-gdb.c: Fix common/ includes.
15208 * auxv.c: Fix common/ includes.
15209 * auto-load.c: Fix common/ includes.
15210 * arm-tdep.c: Fix common/ includes.
15211 * arch/riscv.c: Fix common/ includes.
15212 * arch/ppc-linux-common.c: Fix common/ includes.
15213 * arch/i386.c: Fix common/ includes.
15214 * arch/arm.c: Fix common/ includes.
15215 * arch/arm-linux.c: Fix common/ includes.
15216 * arch/arm-get-next-pcs.c: Fix common/ includes.
15217 * arch/amd64.c: Fix common/ includes.
15218 * arch/aarch64.c: Fix common/ includes.
15219 * arch/aarch64-insn.c: Fix common/ includes.
15220 * arch-utils.c: Fix common/ includes.
15221 * amd64-windows-tdep.c: Fix common/ includes.
15222 * amd64-tdep.c: Fix common/ includes.
15223 * amd64-sol2-tdep.c: Fix common/ includes.
15224 * amd64-obsd-tdep.c: Fix common/ includes.
15225 * amd64-nbsd-tdep.c: Fix common/ includes.
15226 * amd64-linux-tdep.c: Fix common/ includes.
15227 * amd64-linux-nat.c: Fix common/ includes.
15228 * amd64-fbsd-tdep.c: Fix common/ includes.
15229 * amd64-fbsd-nat.c: Fix common/ includes.
15230 * amd64-dicos-tdep.c: Fix common/ includes.
15231 * amd64-darwin-tdep.c: Fix common/ includes.
15232 * agent.c: Fix common/ includes.
15233 * ada-lang.h: Fix common/ includes.
15234 * ada-lang.c: Fix common/ includes.
15235 * aarch64-tdep.c: Fix common/ includes.
15236
15237 2019-01-25 Tom Tromey <tom@tromey.com>
15238
15239 * common/create-version.sh: Use common/version.h.
15240
15241 2019-01-24 Pedro Alves <palves@redhat.com>
15242
15243 * infrun.c (signal_stop, signal_print, signal_program)
15244 (signal_catch, signal_pass): Now arrays instead of pointers.
15245 (update_signals_program_target, do_target_resume)
15246 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15247 * linux-nat.c (linux_nat_target::pass_signals)
15248 (linux_nat_target::create_inferior, linux_nat_target::attach):
15249 Adjust.
15250 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15251 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15252 * procfs.c (procfs_target::pass_signals): Adjust.
15253 * record-full.c (record_full_target::resume): Adjust.
15254 * remote.c (remote_target::pass_signals)
15255 (remote_target::program_signals): Adjust.
15256 * target-debug.h (target_debug_print_signals): Now takes a
15257 gdb::array_view as parameter. Adjust.
15258 * target.h (target_ops) <pass_signals, program_signals>: Replace
15259 pointer and length parameters with gdb::array_view.
15260 (target_pass_signals, target_program_signals): Likewise.
15261 * target-delegates.c: Regenerate.
15262
15263 2019-01-24 Pedro Alves <palves@redhat.com>
15264
15265 * common/forward-scope-exit.h
15266 (forward_scope_exit::forward_scope_exit): Pass arguments to
15267 m_bind_function directly, instead of creating a std::bind and
15268 copying that.
15269
15270 2019-01-24 Alan Hayward <alan.hayward@arm.com>
15271
15272 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15273 for static members.
15274 (pass_in_v_vfp_candidate): Likewise.
15275
15276 2019-01-23 Tom Tromey <tom@tromey.com>
15277 Pedro Alves <palves@redhat.com>
15278
15279 * regcache.c (class regcache_invalidator): Remove.
15280 (regcache::raw_write): Use make_scope_exit.
15281
15282 2019-01-23 Tom Tromey <tom@tromey.com>
15283
15284 * ui-out.h (class ui_out_emit_type): Update comment.
15285
15286 2019-01-23 Tom Tromey <tom@tromey.com>
15287
15288 * infrun.c (fetch_inferior_event): Update comment.
15289
15290 2019-01-23 Tom Tromey <tom@tromey.com>
15291 Pedro Alves <palves@redhat.com>
15292
15293 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15294 parameter.
15295 (fetch_inferior_event): Use SCOPE_EXIT.
15296
15297
15298 2019-01-23 Tom Tromey <tom@tromey.com>
15299 Pedro Alves <palves@redhat.com>
15300
15301 * infrun.c (disable_thread_events): Delete.
15302 (stop_all_threads): Use SCOPE_EXIT.
15303
15304 2019-01-23 Tom Tromey <tom@tromey.com>
15305 Pedro Alves <palves@redhat.com>
15306
15307 * symfile.c: Include forward-scope-exit.h.
15308 (clear_symtab_users_cleanup): Replace forward declaration with
15309 a FORWARD_SCOPE_EXIT.
15310 (syms_from_objfile_1): Use the forward_scope_exit and
15311 gdb::optional instead of cleanup_function.
15312 (reread_symbols): Use the forward_scope_exit instead of
15313 cleanup_function.
15314 (clear_symtab_users_cleanup): Remove function.
15315
15316 2019-01-23 Tom Tromey <tom@tromey.com>
15317 Pedro Alves <palves@redhat.com>
15318
15319 * linux-nat.c: Include scope-exit.h.
15320 (cleanup_target_stop): Remove.
15321 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15322 SCOPE_EXIT.
15323
15324 2019-01-23 Tom Tromey <tom@tromey.com>
15325 Pedro Alves <palves@redhat.com>
15326
15327 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15328 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15329
15330 2019-01-23 Tom Tromey <tom@tromey.com>
15331 Andrew Burgess <andrew.burgess@embecosm.com>
15332 Pedro Alves <palves@redhat.com>
15333
15334 * infrun.c (fetch_inferior_event): Use scope_exit.
15335 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15336 * top.c (execute_command): Use scope_exit.
15337 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15338 * utils.c (do_bpstat_clear_actions_cleanup)
15339 (make_bpstat_clear_actions_cleanup): Remove.
15340
15341 2019-01-23 Tom Tromey <tom@tromey.com>
15342 Pedro Alves <palves@redhat.com>
15343
15344 * infrun.c: Include "common/scope-exit.h"
15345 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15346 (wait_for_inferior): Use SCOPE_EXIT.
15347 (fetch_inferior_event): Use scope_exit.
15348
15349 2019-01-23 Tom Tromey <tom@tromey.com>
15350 Pedro Alves <palves@redhat.com>
15351
15352 * breakpoint.c (create_breakpoint): Remove cleanup.
15353
15354 2019-01-23 Tom Tromey <tom@tromey.com>
15355 Andrew Burgess <andrew.burgess@embecosm.com>
15356 Pedro Alves <palves@redhat.com>
15357
15358 2019-01-23 Pedro Alves <palves@redhat.com>
15359
15360 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15361
15362 2019-01-23 Pedro Alves <palves@redhat.com>
15363 Andrew Burgess <andrew.burgess@embecosm.com>
15364
15365 * gdbthread.h: Include "common/forward-scope-exit.h".
15366 (scoped_finish_thread_state): Redefine custom class in terms of
15367 forward_scope_exit.
15368
15369 2019-01-23 Pedro Alves <palves@redhat.com>
15370 Andrew Burgess <andrew.burgess@embecosm.com>
15371
15372 * common/forward-scope-exit.h: New file.
15373
15374 2019-01-23 Pedro Alves <palves@redhat.com>
15375 Andrew Burgess <andrew.burgess@embecosm.com>
15376 Tom Tromey <tom@tromey.com>
15377
15378 * common/scope-exit.h: New file.
15379
15380 2019-01-23 Pedro Alves <palves@redhat.com>
15381
15382 * common/preprocessor.h (ESC): Rename to ...
15383 (ESC_PARENS): ... this.
15384 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15385 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15386
15387 2019-01-23 Tom Tromey <tom@tromey.com>
15388
15389 * language.h (class scoped_switch_to_sym_language_if_auto):
15390 Initialize m_lang in both cases.
15391
15392 2019-01-23 Alan Hayward <alan.hayward@arm.com>
15393
15394 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15395 with XCNEW.
15396
15397 2019-01-22 Tom Tromey <tom@tromey.com>
15398
15399 * corelow.c: Do not include sys/file.h.
15400
15401 2019-01-22 Tom Tromey <tom@tromey.com>
15402
15403 * tui/tui-wingeneral.h: Include gdb_curses.h.
15404
15405 2019-01-22 Tom Tromey <tom@tromey.com>
15406
15407 * source-cache.h (class source_cache) <get_source_lines,
15408 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15409
15410 2019-01-22 Tom Tromey <tom@tromey.com>
15411
15412 * remote-fileio.h (struct remote_target): Declare.
15413
15414 2019-01-22 Tom Tromey <tom@tromey.com>
15415
15416 * python/py-arch.c: Do not include py-ref.h.
15417 * python/py-bpevent.c: Do not include py-ref.h.
15418 * python/py-cmd.c: Do not include py-ref.h.
15419 * python/py-continueevent.c: Do not include py-ref.h.
15420 * python/py-event.h: Do not include py-ref.h.
15421 * python/py-evtregistry.c: Do not include py-ref.h.
15422 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15423 * python/py-frame.c: Do not include py-ref.h.
15424 * python/py-framefilter.c: Do not include py-ref.h.
15425 * python/py-function.c: Do not include py-ref.h.
15426 * python/py-infevents.c: Do not include py-ref.h.
15427 * python/py-linetable.c: Do not include py-ref.h.
15428 * python/py-objfile.c: Do not include py-ref.h.
15429 * python/py-param.c: Do not include py-ref.h.
15430 * python/py-prettyprint.c: Do not include py-ref.h.
15431 * python/py-progspace.c: Do not include py-ref.h.
15432 * python/py-symbol.c: Do not include py-ref.h.
15433 * python/py-symtab.c: Do not include py-ref.h.
15434 * python/py-type.c: Do not include py-ref.h.
15435 * python/py-unwind.c: Do not include py-ref.h.
15436 * python/py-utils.c: Do not include py-ref.h.
15437 * python/py-value.c: Do not include py-ref.h.
15438 * python/py-varobj.c: Do not include py-ref.h.
15439 * python/py-xmethods.c: Do not include py-ref.h.
15440 * python/python.c: Do not include py-ref.h.
15441 * varobj.c: Do not include py-ref.h.
15442
15443 2019-01-22 Tom Tromey <tom@tromey.com>
15444
15445 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15446 keyword for bcache.
15447
15448 2019-01-22 Tom Tromey <tom@tromey.com>
15449
15450 * compile/compile-cplus-types.c: Remove a comment by #include.
15451
15452 2019-01-22 Tom Tromey <tom@tromey.com>
15453
15454 * compile/gcc-c-plugin.h: Include compile-internal.h.
15455
15456 2019-01-22 Tom Tromey <tom@tromey.com>
15457
15458 * stabsread.c (EXTERN): Do not define.
15459 (symnum, next_symbol_text_func, processing_gcc_compilation)
15460 (within_function, global_sym_chain, global_stabs)
15461 (previous_stab_code, this_object_header_files)
15462 (n_this_object_header_files)
15463 (n_allocated_this_object_header_files): Define.
15464 * stabsread.h (EXTERN): Never define. Use "extern".
15465
15466 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15467
15468 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15469 history_value.
15470
15471 2019-01-21 Tom Tromey <tom@tromey.com>
15472
15473 * ui-out.c: Fix includes.
15474 * tui/tui-source.c: Fix includes.
15475 * target.c: Fix includes.
15476 * remote.c: Fix includes.
15477 * regcache.c: Fix includes.
15478 * python/py-block.c: Fix includes.
15479 * printcmd.c: Fix includes.
15480 * or1k-tdep.c: Fix includes.
15481 * mi/mi-main.c: Fix includes.
15482 * m32r-tdep.c: Fix includes.
15483 * csky-tdep.c: Fix includes.
15484 * compile/compile-cplus-types.c: Fix includes.
15485 * cli/cli-interp.c: Fix includes.
15486
15487 2019-01-21 Alan Hayward <alan.hayward@arm.com>
15488
15489 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15490 for padding.
15491
15492 2019-01-16 Tom Tromey <tom@tromey.com>
15493
15494 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15495 earlier.
15496 (struct objfile) <msymbols_range>: Move from top level.
15497 <msymbols>: New method.
15498 (class objfile_msymbols): Remove.
15499 * symtab.c (default_collect_symbol_completion_matches_break_on):
15500 Update.
15501 * symmisc.c (dump_msymbols): Update.
15502 * stabsread.c (scan_file_globals): Update.
15503 * objc-lang.c (info_selectors_command, info_classes_command)
15504 (find_methods): Update.
15505 * minsyms.c (find_solib_trampoline_target): Update.
15506 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15507 * coffread.c (coff_symfile_read): Update.
15508 * ada-lang.c (ada_lookup_simple_minsym)
15509 (ada_collect_symbol_completion_matches): Update.
15510
15511 2019-01-16 Tom Tromey <tom@tromey.com>
15512
15513 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15514 type. Remove no-argument constructor.
15515 <iterator::operator++>: Simplify.
15516 <begin>: Update.
15517 <end>: Use minimal_symbol_count.
15518
15519 2019-01-16 Tom Tromey <tom@tromey.com>
15520
15521 * objfiles.h (struct objfile) <psymtabs>: New method.
15522 (class objfile_psymtabs): Remove.
15523 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15524 typedef.
15525 <range>: New method.
15526 (require_partial_symbols): Change return type.
15527 * psymtab.c (require_partial_symbols)
15528 (psym_expand_symtabs_matching): Update.
15529 * mdebugread.c (parse_partial_symbols): Update.
15530 * dbxread.c (dbx_end_psymtab): Update.
15531
15532 2019-01-15 Tom Tromey <tom@tromey.com>
15533
15534 * symtab.c (lookup_objfile_from_block)
15535 (lookup_symbol_in_objfile_symtabs)
15536 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15537 (find_line_symtab, info_sources_command)
15538 (default_collect_symbol_completion_matches_break_on)
15539 (make_source_files_completion_list): Update.
15540 * symmisc.c (print_objfile_statistics, dump_objfile)
15541 (maintenance_print_symbols, maintenance_info_symtabs)
15542 (maintenance_check_symtabs, maintenance_info_line_tables):
15543 Update.
15544 * source.c (select_source_symtab)
15545 (forget_cached_source_info_for_objfile): Update.
15546 * objfiles.h (class objfile_compunits): Remove.
15547 (struct objfile) <compunits_range>: New typedef.
15548 (compunits): New method.
15549 * objfiles.c (objfile_relocate1): Update.
15550 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15551 * maint.c (count_symtabs_and_blocks): Update.
15552 * linespec.c (iterate_over_all_matching_symtabs): Update.
15553 * cp-support.c (add_symbol_overload_list_qualified): Update.
15554 * coffread.c (coff_symtab_read): Update.
15555 * ada-lang.c (add_nonlocal_symbols)
15556 (ada_collect_symbol_completion_matches)
15557 (ada_add_global_exceptions): Update.
15558
15559 2019-01-15 Tom Tromey <tom@tromey.com>
15560
15561 * progspace.h (program_space) <objfiles_safe_range>: New
15562 typedef.
15563 <objfiles_safe>: New method.
15564 * objfiles.h (class all_objfiles_safe): Remove.
15565 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15566 * jit.c (jit_inferior_exit_hook): Update.
15567
15568 2019-01-17 Tom Tromey <tom@tromey.com>
15569
15570 * progspace.h (program_space) <objfiles_range>: New typedef.
15571 <objfiles>: New method.
15572 <objfiles_head>: Rename from objfiles.
15573 (object_files): Update.
15574 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15575 * guile/scm-pretty-print.c
15576 (ppscm_find_pretty_printer_from_objfiles): Update.
15577 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15578 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15579 Update.
15580 * python/py-progspace.c (pspy_get_objfiles): Update.
15581 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15582 Update.
15583 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15584 (objfpy_lookup_objfile_by_build_id): Update.
15585 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15586 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15587 Update.
15588 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15589 (expand_symtab_containing_pc, lookup_objfile_from_block)
15590 (lookup_static_symbol, basic_lookup_transparent_type)
15591 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15592 (find_line_symtab, info_sources_command)
15593 (default_collect_symbol_completion_matches_break_on)
15594 (make_source_files_completion_list, find_main_name): Update.
15595 * symmisc.c (print_symbol_bcache_statistics)
15596 (print_objfile_statistics, maintenance_print_symbols)
15597 (maintenance_print_msymbols, maintenance_print_objfiles)
15598 (maintenance_info_symtabs, maintenance_check_symtabs)
15599 (maintenance_expand_symtabs, maintenance_info_line_tables):
15600 Update.
15601 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15602 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15603 (map_overlay_command, unmap_overlay_command)
15604 (simple_overlay_update, expand_symtabs_matching)
15605 (map_symbol_filenames): Update.
15606 * symfile-debug.c (set_debug_symfile): Update.
15607 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15608 Update.
15609 * source.c (select_source_symtab, forget_cached_source_info):
15610 Update.
15611 * solib.c (solib_read_symbols): Update.
15612 * solib-spu.c (append_ocl_sos): Update.
15613 * psymtab.c (maintenance_print_psymbols)
15614 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15615 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15616 * printcmd.c (info_symbol_command): Update.
15617 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15618 Update.
15619 * objfiles.h (class all_objfiles): Remove.
15620 * objfiles.c (have_partial_symbols, have_full_symbols)
15621 (have_minimal_symbols, qsort_cmp, update_section_map)
15622 (shared_objfile_contains_address_p)
15623 (default_iterate_over_objfiles_in_search_order): Update.
15624 * objc-lang.c (info_selectors_command, info_classes_command)
15625 (find_methods): Update.
15626 * minsyms.c (find_solib_trampoline_target): Update.
15627 * maint.c (maintenance_info_sections)
15628 (maintenance_translate_address, count_symtabs_and_blocks):
15629 Update.
15630 * main.c (captured_main_1): Update.
15631 * linux-thread-db.c (try_thread_db_load_from_pdir)
15632 (has_libpthread): Update.
15633 * linespec.c (iterate_over_all_matching_symtabs)
15634 (search_minsyms_for_name): Update.
15635 * jit.c (jit_find_objf_with_entry_addr): Update.
15636 * hppa-tdep.c (find_unwind_entry)
15637 (hppa_lookup_stub_minimal_symbol): Update.
15638 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15639 Update.
15640 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15641 (elf_gnu_ifunc_resolve_by_got): Update.
15642 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15643 * dwarf-index-write.c (save_gdb_index_command): Update.
15644 * cp-support.c (add_symbol_overload_list_qualified): Update.
15645 * breakpoint.c (create_overlay_event_breakpoint)
15646 (create_longjmp_master_breakpoint)
15647 (create_std_terminate_master_breakpoint)
15648 (create_exception_master_breakpoint): Update.
15649 * blockframe.c (find_pc_partial_function): Update.
15650 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15651 (ada_collect_symbol_completion_matches)
15652 (ada_add_global_exceptions): Update.
15653
15654 2019-01-17 Tom Tromey <tom@tromey.com>
15655
15656 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15657 declare VEC.
15658 (solib_target_parse_libraries): Change return type.
15659 (library_list_start_segment, library_list_start_section)
15660 (library_list_end_library, library_list_start_library); Update.
15661 (solib_target_free_library_list): Remove.
15662 (solib_target_parse_libraries): Remove cleanup. Change return
15663 type.
15664 (solib_target_current_sos): Update.
15665
15666 2019-01-17 Tom Tromey <tromey@bapiya>
15667
15668 * valprint.c: Replace "the the" with "the".
15669 * symtab.c: Replace "the the" with "the".
15670 * solib.c: Replace "the the" with "the".
15671 * solib-dsbt.c: Replace "the the" with "the".
15672 * linespec.c: Replace "the the" with "the".
15673 * dwarf2loc.h: Replace "the the" with "the".
15674 * amd64-windows-tdep.c: Replace "the the" with "the".
15675 * aarch64-tdep.c: Replace "the the" with "the".
15676
15677 2019-01-16 Keith Seitz <keiths@redhat.com>
15678
15679 PR gdb/23773
15680 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15681 <builder>: Rename to ..
15682 <m_builder>: ... this and make private.
15683 (dwarf2_cu::get_builder): New method. Change all users of
15684 `builder' to use this method.
15685 (dwarf2_start_symtab): Move to ...
15686 (dwarf2_cu::start_symtab): ... here. Update all callers
15687 (setup_type_unit_groups): Move to ...
15688 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
15689 callers.
15690 (dwarf2_cu::reset_builder): New method.
15691 (process_full_compunit, process_full_type_unit): Use
15692 dwarf2_cu::reset_builder.
15693 (follow_die_offset): Record the ancestor CU if it is different
15694 from the followed DIE's CU.
15695 (follow_die_sig_1): Likewise.
15696
15697 2019-01-15 Tom Tromey <tom@tromey.com>
15698
15699 * remote.c (class remote_state) <buf>: Now a char_vector.
15700 <buf_size>: Remove.
15701 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
15702 parameter.
15703 (remote_target::getpkt_or_notif_sane_1)
15704 (remote_target::getpkt_sane)
15705 (remote_target::getpkt_or_notif_sane): Likewise.
15706 (class remote_target) <putpkt>: New overload.
15707 (remote_target::read_frame): Change type of "buf_p". Remove
15708 sizeof_p parameter.
15709 (packet_ok): New overload.
15710 (packet_check_result): New overload.
15711 Update all uses.
15712
15713 2019-01-14 Tom Tromey <tom@tromey.com>
15714
15715 * remote-notif.c (handle_notification, remote_notif_ack)
15716 (remote_notif_parse): Make "buf" const.
15717 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15718 const.
15719 (remote_notif_parse, remote_notif_ack, handle_notification):
15720 Likewise.
15721 * remote.c (remote_notif_stop_parse): Make "buf" const.
15722 (remote_target::remote_parse_stop_reply): Make "buf" const.
15723 (remote_notif_stop_ack): Make "buf" const.
15724
15725 2019-01-14 Tom Tromey <tom@tromey.com>
15726
15727 * remote.c (remote_console_output): Make parameter const.
15728
15729 2019-01-14 Tom Tromey <tom@tromey.com>
15730
15731 * target-debug.h (target_debug_print_signals): Constify.
15732 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15733 * procfs.c (procfs_target::pass_signals): Update.
15734 * linux-nat.c (linux_nat_target::pass_signals): Update.
15735 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15736 * target-delegates.c: Rebuild.
15737 * remote.c (remote_target::program_signals): Update.
15738 (remote_target::pass_signals): Update.
15739 * target.c (target_pass_signals): Constify argument.
15740 (target_program_signals): Likewise.
15741 * target.h (struct target_ops) <pass_signals, program_signals>:
15742 Constify argument.
15743 (target_pass_signals, target_program_signals): Constify argument.
15744
15745 2019-01-14 Tom Tromey <tom@tromey.com>
15746
15747 PR tui/28819:
15748 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15749
15750 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
15751
15752 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15753 field.
15754 * rs6000-tdep.c: Include reggroups.h.
15755 (IS_V_ALIAS_PSEUDOREG): Define.
15756 (rs6000_register_name): Return names for the "vX" aliases.
15757 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15758 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
15759 aliases. Call default_register_reggroup_p for all other
15760 pseudo-registers.
15761 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15762 New functions.
15763 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15764 Handle "vX" aliases.
15765 (v_alias_pseudo_register_collect): New function.
15766 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15767 (rs6000_gdbarch_init): Initialize "vX" aliases as
15768 pseudo-registers. Restore registration of
15769 rs6000_pseudo_register_reggroup_p with
15770 set_tdesc_pseudo_register_reggroup_p.
15771
15772 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
15773
15774 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15775 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15776 set_gdbarch_num_pseudo_regs.
15777
15778 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15779
15780 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15781 Remove arg prefixname, add do_set and do_show.
15782 Add member functions set_list and show_list.
15783 * cli/cli-style.c (class cli_style_option): Update accordingly.
15784 (style_set_list): Move to file scope.
15785 (style_show_list): Likewise.
15786 (set_style): Call help_list.
15787 (show_style): Call cmd_show_list.
15788 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15789 Update to use the new macro.
15790
15791 2019-10-12 Joel Brobecker <brobecker@adacore.com>
15792
15793 * ada-lang.c (_initialize_ada_language): Expand the help text
15794 for the "catch exception" command.
15795
15796 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15797
15798 * symtab.c (matching_obj_sections): Initialize obj,
15799 declare it closer to its usage.
15800
15801 2019-01-10 Tom Tromey <tom@tromey.com>
15802
15803 * thread-iter.h (inf_threads_iterator): Use next_iterator.
15804 (basic_inf_threads_range): Remove.
15805 (inf_threads_range, inf_non_exited_threads_range)
15806 (safe_inf_threads_range): Use next_adapter.
15807
15808 2019-01-10 Keith Seitz <keiths@redhat.com>
15809
15810 PR gdb/23712
15811 PR symtab/23010
15812 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15813 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15814
15815 2019-01-10 Keith Seitz <keiths@redhat.com>
15816
15817 PR gdb/23712
15818 PR symtab/23010
15819 * dictionary.c (pending_to_vector): Remove.
15820 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15821 Remove _1 suffix, replacing functions of the same name. Update
15822 all callers.
15823 (dict_create_hashed, dict_create_hashed_expandable)
15824 (dict_create_linear, dict_create_linear_expandable, dict_free)
15825 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15826 Make functions static.
15827
15828 2019-01-10 Keith Seitz <keiths@redhat.com>
15829
15830 PR gdb/23712
15831 PR symtab/23010
15832 * dictionary.h (struct dictionary): Replace declaration with
15833 multidictionary.
15834 (dict_create_hashed, dict_create_hashed_expandable)
15835 (dict_create_linear, dict_create_linear_expandable)
15836 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15837 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15838 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15839 taking multidictionary argument.
15840 [ALL_DICT_SYMBOLS]: Update for multidictionary.
15841 * block.h (struct block) <dict>: Change to multidictionary
15842 and rename `multidict'.
15843 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15844 symmisc.c: Update all dictionary references to multidictionary.
15845
15846 2019-01-10 Keith Seitz <keiths@redhat.com>
15847
15848 PR gdb/23712
15849 PR symtab/23010
15850 * dictionary.c: Include unordered_map.
15851 (pending_to_vector): New function.
15852 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15853 Rewrite the non-"_1" functions to take vector instead
15854 of linked list.
15855 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15856 "new" _1 versions of the same name.
15857 (multidictionary): Define.
15858 (std::hash<enum language): New definition.
15859 (collate_pending_symbols_by_language, mdict_create_hashed)
15860 (mdict_create_hashed_expandable, mdict_create_linear)
15861 (mdict_create_linear_expandable, mdict_free)
15862 (find_language_dictionary, create_new_language_dictionary)
15863 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15864 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15865 (mdict_size, mdict_empty): New functions.
15866 * dictionary.h (mdict_iterator): Define.
15867
15868 2019-01-10 Pedro Alves <palves@redhat.com>
15869
15870 * breakpoint.c (read_uploaded_action)
15871 (create_tracepoint_from_upload): Adjust to use
15872 gdb::unique_xmalloc_ptr.
15873 * ctf.c (ctf_write_uploaded_tp):
15874 (SET_ARRAY_FIELD): Use emplace_back.
15875 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15876 * tracefile-tfile.c (tfile_write_uploaded_tp):
15877 * tracepoint.c (parse_tracepoint_definition): Adjust to use
15878 gdb::unique_xmalloc_ptr.
15879 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15880 at_string, cond_string, cmd_strings>: Replace char pointers
15881 with gdb::unique_xmalloc_ptr.
15882
15883 2019-01-10 Pedro Alves <palves@redhat.com>
15884
15885 * solib-target.c (library_list_start_library): Don't xstrdup name.
15886
15887 2019-01-10 Pedro Alves <palves@redhat.com>
15888
15889 * mdebugread.c (parse_partial_symbols): Use
15890 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15891
15892 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15893
15894 * linux-fork.c (scoped_switch_fork_info)
15895 <~scoped_switch_fork_info>: Fix incorrect variable name.
15896
15897 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15898
15899 * linux-fork.c (scoped_switch_fork_info)
15900 <scoped_switch_fork_info>: Make explicit.
15901 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15902
15903 2019-01-10 Tom Tromey <tom@tromey.com>
15904
15905 * objfiles.h (objfile::reset_psymtabs): Update.
15906 * objfiles.c (objfile::objfile): Update.
15907 * psymtab.h (psymtab_storage::obstack): Update.
15908 (psymtab_storage::m_obstack): Use gdb::optional.
15909 (class psymtab_storage): Update comment. Remove objfile
15910 parameter.
15911 * psymtab.c (psymtab_storage::psymtab_storage): Update.
15912
15913 2019-01-10 Tom Tromey <tom@tromey.com>
15914
15915 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15916 <free_psymtabs>: Now private.
15917 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15918 (allocate_psymtab): Use new method.
15919
15920 2019-01-10 Tom Tromey <tom@tromey.com>
15921
15922 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15923 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15924 * mdebugread.c (parse_partial_symbols): Use
15925 allocate_dependencies.
15926 * dwarf2read.c (dwarf2_create_include_psymtab): Use
15927 allocate_dependencies.
15928 (process_psymtab_comp_unit_reader)
15929 (build_type_psymtab_dependencies): Likewise.
15930 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15931
15932 2019-01-10 Tom Tromey <tom@tromey.com>
15933
15934 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15935 PSYMBOL_SET_LANGUAGE.
15936 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15937
15938 2019-01-10 Tom Tromey <tom@tromey.com>
15939
15940 * psymtab.h (psymtab_storage::obstack): New method.
15941 <m_obstack>: Rename from obstack; now private.
15942 * psymtab.c (psymtab_storage): Update.
15943 * dwarf2read.c (create_addrmap_from_index)
15944 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15945 Update.
15946
15947 2019-01-10 Tom Tromey <tom@tromey.com>
15948
15949 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15950 * objfiles.h (objfile::reset_psymtabs): New method.
15951
15952 2019-01-10 Tom Tromey <tom@tromey.com>
15953
15954 * symmisc.c (print_symbol_bcache_statistics): Update.
15955 (print_objfile_statistics): Update.
15956 * symfile.c (reread_symbols): Update.
15957 * psymtab.h (class psymtab_storage): New.
15958 * psymtab.c (psymtab_storage): New constructor.
15959 (~psymtab_storage): New destructor.
15960 (require_partial_symbols): Update.
15961 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15962 (find_pc_sect_psymtab, find_pc_sect_psymbol)
15963 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15964 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15965 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15966 (start_psymtab_common, end_psymtab_common)
15967 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15968 (allocate_psymtab): Update.
15969 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15970 Update.
15971 (dump_psymtab_addrmap, maintenance_print_psymbols)
15972 (maintenance_check_psymtabs): Update.
15973 (class objfile_psymtabs): Move to objfiles.h.
15974 * psympriv.h (discard_psymtab): Now inline.
15975 (psymtab_discarder::psymtab_discarder): Update.
15976 (psymtab_discarder::~psymtab_discarder): Update.
15977 (ALL_OBJFILE_PSYMTABS): Rewrite.
15978 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15979 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15980 Remove fields.
15981 <partial_symtabs>: New field.
15982 (class objfile_psymtabs): Move from psymtab.h. Update.
15983 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15984 psymbol_cache.
15985 (objfile::~objfile): Don't destroy psymbol_cache.
15986 * mdebugread.c (parse_partial_symbols): Update.
15987 * dwarf2read.c (create_addrmap_from_index)
15988 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15989 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15990 (add_partial_subprogram, dwarf2_ranges_read): Update.
15991 * dwarf-index-write.c (write_address_map)
15992 (write_one_signatured_type, recursively_write_psymbols)
15993 (class debug_names, class debug_names, write_psymtabs_to_index):
15994 Update.
15995
15996 2019-01-10 Tom Tromey <tom@tromey.com>
15997
15998 * symtab.h (SYMBOL_SET_NAMES): Update.
15999 (symbol_set_names): Update.
16000 (MSYMBOL_SET_NAMES): Update.
16001 * symtab.c (symbol_set_names): Change argument to be an
16002 objfile_per_bfd_storage.
16003 * psymtab.c (add_psymbol_to_bcache): Update.
16004 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16005
16006 2019-01-10 Tom Tromey <tom@tromey.com>
16007
16008 * symtab.c (create_demangled_names_hash): Change argument to be an
16009 objfile_per_bfd_storage.
16010 (symbol_set_names): Update.
16011
16012 2019-01-10 Tom Tromey <tom@tromey.com>
16013
16014 * xcoffread.c (xcoff_initial_scan): Unconditionally call
16015 init_psymbol_list.
16016 * psymtab.c (init_psymbol_list): Do nothing if already called.
16017 * psympriv.h (init_psymbol_list): Add comment.
16018 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16019 init_psymbol_list.
16020 * dbxread.c (dbx_symfile_read): Unconditionally call
16021 init_psymbol_list.
16022
16023 2019-01-10 Tom Tromey <tom@tromey.com>
16024
16025 * xcoffread.c (scan_xcoff_symtab): Update.
16026 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16027 "where".
16028 * mdebugread.c (parse_partial_symbols)
16029 (handle_psymbol_enumerators): Update.
16030 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16031 * dbxread.c (read_dbx_symtab): Update.
16032 * psympriv.h (psymbol_placement): New enum.
16033 (add_psymbol_to_list): Update.
16034
16035 2019-01-10 Tom Tromey <tom@tromey.com>
16036
16037 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16038 static_psymbols parameters.
16039 (scan_xcoff_symtab): Update.
16040 * psymtab.c (start_psymtab_common): Remove global_psymbols and
16041 static_psymbols parameters.
16042 * psympriv.h (start_psymtab_common): Update.
16043 * mdebugread.c (parse_partial_symbols): Update.
16044 * dwarf2read.c (create_partial_symtab): Update.
16045 * dbxread.c (read_dbx_symtab): Update.
16046 (start_psymtab): Remove global_psymbols and static_psymbols
16047 parameters.
16048
16049 2019-01-10 Tom Tromey <tom@tromey.com>
16050
16051 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16052 * psymtab.c (allocate_psymtab): Add comment.
16053 * psympriv.h (allocate_psymtab): Add comment.
16054 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16055 initializations.
16056 * dbxread.c (dbx_end_psymtab): Remove some initializations.
16057
16058 2019-01-10 Tom Tromey <tom@tromey.com>
16059
16060 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16061 Don't declare.
16062 * mipsread.c: Include mdebugread.h.
16063 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16064 Declare.
16065 * elfread.c: Include mdebugread.h.
16066
16067 2019-01-09 Tom Tromey <tom@tromey.com>
16068
16069 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16070 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16071 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16072 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16073 (psym_lookup_symbol, psym_find_last_source_symtab)
16074 (psym_forget_cached_source_info, psym_print_stats)
16075 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16076 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16077 (psym_map_matching_symbols, psym_expand_symtabs_matching)
16078 (psym_find_compunit_symtab_by_address)
16079 (maintenance_print_psymbols, maintenance_info_psymtabs)
16080 (maintenance_check_psymtabs): Use ranged for.
16081 * psymtab.h (class objfile_psymtabs): New.
16082 (require_partial_symbols): Return objfile_psymtabs.
16083 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16084
16085 2019-01-09 Tom Tromey <tom@tromey.com>
16086
16087 * symfile.c (overlay_invalidate_all, find_pc_overlay)
16088 (find_pc_mapped_section, list_overlays_command)
16089 (map_overlay_command, unmap_overlay_command)
16090 (simple_overlay_update): Use all_objfiles.
16091 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16092 * printcmd.c (info_symbol_command): Use all_objfiles.
16093 * objfiles.h (ALL_OBJSECTIONS): Remove.
16094 * maint.c (maintenance_translate_address): Use all_objfiles.
16095 * gcore.c (gcore_create_callback): Use all_objfiles.
16096 (objfile_find_memory_regions): Likewise.
16097
16098 2019-01-09 Tom Tromey <tom@tromey.com>
16099
16100 * symtab.c (find_line_symtab, info_sources_command)
16101 (make_source_files_completion_list): Use objfile_compunits.
16102 * source.c (select_source_symtab): Use objfile_compunits.
16103 * objfiles.h (struct objfile): Update comment.
16104 (ALL_OBJFILES): Remove.
16105 (ALL_FILETABS): Remove.
16106 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16107 objfile_compunits.
16108
16109 2019-01-09 Tom Tromey <tom@tromey.com>
16110
16111 * symmisc.c (print_objfile_statistics, dump_objfile)
16112 (maintenance_print_symbols): Use compunit_filetabs.
16113 * source.c (forget_cached_source_info_for_objfile): Use
16114 compunit_filetabs.
16115 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16116 (ALL_FILETABS): Use compunit_filetabs.
16117 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16118 * coffread.c (coff_symtab_read): Use compunit_filetabs.
16119
16120 2019-01-09 Tom Tromey <tom@tromey.com>
16121
16122 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16123 (compunit_filetabs): New.
16124 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16125 compunit_filetabs.
16126 (info_sources_command, make_source_files_completion_list): Remove
16127 declaration.
16128 * symmisc.c (print_objfile_statistics, dump_objfile)
16129 (maintenance_print_symbols): Remove declaration.
16130 (maintenance_info_symtabs): Use compunit_filetabs.
16131 (maintenance_info_line_tables): Likewise.
16132 * source.c (select_source_symtab): Change local variable name.
16133 (forget_cached_source_info_for_objfile): Remove declaration.
16134 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16135 * objfiles.c (objfile_relocate1): Remove declaration.
16136 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16137 declaration.
16138 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16139 * coffread.c (coff_symtab_read): Remove declaration.
16140 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16141 compunit_filetabs.
16142
16143 2019-01-09 Tom Tromey <tom@tromey.com>
16144
16145 * symtab.c (lookup_objfile_from_block)
16146 (find_pc_sect_compunit_symtab, search_symbols)
16147 (default_collect_symbol_completion_matches_break_on): Use
16148 objfile_compunits.
16149 * objfiles.h (ALL_COMPUNITS): Remove.
16150 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16151 * cp-support.c (add_symbol_overload_list_qualified): Use
16152 objfile_compunits.
16153 * ada-lang.c (ada_collect_symbol_completion_matches)
16154 (ada_add_global_exceptions): Use objfile_compunits.
16155
16156 2019-01-09 Tom Tromey <tom@tromey.com>
16157
16158 * source.c (select_source_symtab)
16159 (forget_cached_source_info_for_objfile): Remove declaration.
16160 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16161 declaration.
16162 * maint.c (count_symtabs_and_blocks): Remove declaration.
16163 * cp-support.c (add_symbol_overload_list_qualified): Remove
16164 declaration.
16165 * coffread.c (coff_symtab_read): Remove declaration.
16166 * symtab.c (lookup_symbol_in_objfile_symtabs)
16167 (basic_lookup_transparent_type_1): Use objfile_compunits.
16168 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16169 (info_sources_command, search_symbols)
16170 (default_collect_symbol_completion_matches_break_on)
16171 (make_source_files_completion_list): Remove declaration.
16172 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16173 (ada_collect_symbol_completion_matches)
16174 (ada_add_global_exceptions): Remove declaration.
16175 * linespec.c (iterate_over_all_matching_symtabs): Use
16176 objfile_compunits.
16177 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16178 (class objfile_compunits): New.
16179 (ALL_COMPUNITS): Use objfile_compunits.
16180 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16181 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16182 objfile_compunits.
16183 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16184
16185 2019-01-09 Tom Tromey <tom@tromey.com>
16186
16187 * symtab.c (search_symbols)
16188 (default_collect_symbol_completion_matches_break_on): Use
16189 objfile_msymbols.
16190 * ada-lang.c (ada_lookup_simple_minsym)
16191 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16192 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16193 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16194 objfile_msymbols.
16195 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16196 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16197 * objc-lang.c (find_methods): Use objfile_msymbols.
16198 (info_selectors_command, info_classes_command): Likewise.
16199 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16200 * objfiles.h (class objfile_msymbols): New.
16201 (ALL_OBJFILE_MSYMBOLS): Remove.
16202 (ALL_MSYMBOLS): Remove.
16203
16204 2019-01-09 Tom Tromey <tom@tromey.com>
16205
16206 * common/next-iterator.h (next_adapter): Add Iterator template
16207 parameter.
16208 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16209 (class all_objfiles_safe): New.
16210 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16211 * objfiles.c (put_objfile_before): Update comment.
16212 (add_separate_debug_objfile): Likewise.
16213 (free_all_objfiles): Use all_objfiles_safe.
16214 (objfile_purge_solibs): Likewise.
16215
16216 2019-01-09 Tom Tromey <tom@tromey.com>
16217
16218 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16219 (expand_symtab_containing_pc, lookup_static_symbol)
16220 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16221 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16222 all_objfiles.
16223 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16224 * breakpoint.c (create_overlay_event_breakpoint)
16225 (create_longjmp_master_breakpoint)
16226 (create_std_terminate_master_breakpoint)
16227 (create_exception_master_breakpoint): Use all_objfiles.
16228 * linux-thread-db.c (try_thread_db_load_from_pdir)
16229 (has_libpthread): Use all_objfiles.
16230 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16231 * linespec.c (iterate_over_all_matching_symtabs)
16232 (search_minsyms_for_name): Use all_objfiles.
16233 * maint.c (maintenance_info_sections): Use all_objfiles.
16234 * main.c (captured_main_1): Use all_objfiles.
16235 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16236 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16237 * guile/scm-pretty-print.c
16238 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16239 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16240 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16241 (maintenance_print_msymbols): Use all_objfiles.
16242 * source.c (select_source_symtab): Use all_objfiles.
16243 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16244 * symfile.c (remove_symbol_file_command)
16245 (expand_symtabs_matching, map_symbol_filenames): Use
16246 all_objfiles.
16247 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16248 all_objfiles.
16249 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16250 * objc-lang.c (find_methods): Use all_objfiles.
16251 * objfiles.c (have_partial_symbols, have_full_symbols)
16252 (have_minimal_symbols, qsort_cmp)
16253 (default_iterate_over_objfiles_in_search_order): Use
16254 all_objfiles.
16255 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16256 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16257 (maintenance_check_psymtabs): Use all_objfiles.
16258 (ALL_PSYMTABS): Remove.
16259 * compile/compile-object-run.c (do_module_cleanup): Use
16260 all_objfiles.
16261 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16262 * cp-support.c (add_symbol_overload_list_qualified): Use
16263 all_objfiles.
16264 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16265 Use all_objfiles.
16266 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16267 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16268 all_objfiles.
16269 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16270 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16271 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16272 Uses all_objfiles.
16273 * solib.c (solib_read_symbols): Use all_objfiles
16274
16275 2019-01-09 Tom Tromey <tom@tromey.com>
16276
16277 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16278 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16279 all_objfiles.
16280 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16281 * symmisc.c (print_symbol_bcache_statistics)
16282 (print_objfile_statistics, maintenance_print_objfiles)
16283 (maintenance_info_symtabs, maintenance_check_symtabs)
16284 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16285 all_objfiles.
16286 * source.c (forget_cached_source_info): Use all_objfiles.
16287 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16288 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16289 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16290 * objfiles.c (update_section_map): Use all_objfiles.
16291 (shared_objfile_contains_address_p): Likewise.
16292 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16293 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16294
16295 2019-01-09 Tom Tromey <tom@tromey.com>
16296
16297 * common/next-iterator.h: New file.
16298 * objfiles.h (class all_objfiles): New.
16299 (struct objfile_iterator): New.
16300
16301 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16302
16303 * NEWS: Move the description of the changed "frame", "select-frame",
16304 and "info frame" commands to the Changed commands section.
16305
16306 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16307
16308 * gdbtypes.c (check_stub_method_group): Remove handling of old
16309 mangling schemes.
16310 * linespec.c (find_methods): Likewise.
16311 * stabsread.c (read_member_functions): Likewise.
16312 * valops.c (search_struct_method): Likewise.
16313 (value_struct_elt_for_reference): Likewise.
16314 * NEWS: Mention this change.
16315
16316 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16317
16318 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16319 print_source_lines.
16320 * source.c (print_source_lines_base): Update line number check.
16321 (print_source_lines): New function.
16322 (source_lines_range::source_lines_range): New function.
16323 * source.h (class source_lines_range): New class.
16324 (print_source_lines): New declaration.
16325
16326 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16327
16328 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16329
16330 2019-01-08 Tom Tromey <tom@tromey.com>
16331 Simon Marchi <simon.marchi@ericsson.com>
16332
16333 PR gdb/24060
16334 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16335 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16336 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16337 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16338 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16339 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16340
16341 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16342
16343 * source.c (select_source_symtab): Move header comment to
16344 declaration in source.h.
16345 (forget_cached_source_info_for_objfile): Likewise.
16346 (forget_cached_source_info): Likewise.
16347 (identify_source_line): Likewise.
16348 * source.h (identify_source_line): Move declaration from symtab.h
16349 and add comment from source.c
16350 (print_source_lines): Likewise.
16351 (forget_cached_source_info_for_objfile): Likewise.
16352 (forget_cached_source_info): Likewise.
16353 (select_source_symtab): Likewise.
16354 (enum print_source_lines_flag): Move definition from symtab.h.
16355 * symtab.h (identify_source_line): Move declaration to source.h.
16356 (print_source_lines): Likewise.
16357 (forget_cached_source_info_for_objfile): Likewise.
16358 (forget_cached_source_info): Likewise.
16359 (select_source_symtab): Likewise.
16360 (enum print_source_lines_flag): Move definition to source.h.
16361 * tui/tui-hooks.c: Add 'source.h' include.
16362
16363 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16364
16365 * source.c (print_source_lines_base): Handle requests to print
16366 reverse line number sequences, and guard against empty lines
16367 string.
16368
16369 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16370
16371 * source.c (print_source_lines_base): Fix skip of '\r' if next
16372 character is '\n'.
16373
16374 2019-01-06 Tom Tromey <tom@tromey.com>
16375
16376 * c-exp.y (struct c_parse_state) <macro_original_text,
16377 expansion_obstack>: New member.
16378 (macro_original_text, expansion_obstack): Remove globals.
16379 (scan_macro_expansion, scanning_macro_expansion)
16380 (finished_macro_expansion): Update.
16381 (scan_macro_cleanup): Remove.
16382 (yylex, c_parse): Update.
16383
16384 2019-01-06 Tom Tromey <tom@tromey.com>
16385
16386 * c-exp.y (struct c_parse_state) <strings>: New member.
16387 (operator_stoken): Update.
16388
16389 2019-01-06 Tom Tromey <tom@tromey.com>
16390
16391 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16392 (union type_stack_elt) <typelist_val>: Now a pointer to
16393 std::vector.
16394 (type_stack_cleanup): Don't declare.
16395 (push_typelist): Update.
16396 * parse.c (pop_typelist): Return a std::vector.
16397 (push_typelist): Take a std::vector.
16398 (follow_types): Update. Do not free args.
16399 (type_stack_cleanup): Remove.
16400 * c-exp.y (struct c_parse_state): New.
16401 (cpstate): New global.
16402 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16403 (nonempty_typelist): Update.
16404 (func_mod): Create a new vector.
16405 (c_parse): Create a c_parse_state.
16406 (check_parameter_typelist): Do not delete params.
16407 (function_method): Update. Do not delete type_list.
16408
16409 2019-01-06 Tom Tromey <tom@tromey.com>
16410
16411 PR gdb/28155:
16412 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16413 check_typedef.
16414 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16415 (print_return_value): Likewise.
16416
16417 2019-01-05 Tom Tromey <tom@tromey.com>
16418
16419 * contrib/cleanup_check.py: Remove.
16420 * contrib/gcc-with-excheck: Remove.
16421 * contrib/exsummary.py: Remove.
16422 * contrib/excheck.py: Remove.
16423
16424 2019-01-05 Joel Brobecker <brobecker@adacore.com>
16425
16426 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16427 NULL. Initialize tpprev to NULL instead of assigning it
16428 to NULL on the next statement.
16429 * windows-nat.c (windows_delete_thread): Remove check for
16430 main_thread_id before printing thread exit notifications.
16431 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16432 Remove thread ID check against main_thread_id.
16433 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16434 windows_delete_thread.
16435 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16436
16437 2019-01-04 Tom Tromey <tom@tromey.com>
16438
16439 * compile/compile.c (_initialize_compile): Use upper case for
16440 metasyntactic variables.
16441 * symmisc.c (_initialize_symmisc): Use upper case for
16442 metasyntactic variables.
16443 * psymtab.c (_initialize_psymtab): Use upper case for
16444 metasyntactic variables.
16445 * demangle.c (demangle_command): Use upper case for metasyntactic
16446 variables.
16447 (_initialize_demangler): Likewise.
16448 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16449 variables.
16450
16451 2019-01-03 Tom Tromey <tom@tromey.com>
16452
16453 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16454
16455 2019-01-03 Tom Tromey <tom@tromey.com>
16456
16457 * python/py-symtab.c (salpy_str): Update.
16458 (struct salpy_sal_object) <symtab>: Now a PyObject.
16459 (salpy_dealloc): Update.
16460 (del_objfile_sal): Use gdbpy_ref.
16461
16462 2019-01-03 Tom Tromey <tom@tromey.com>
16463
16464 * python/py-type.c (convert_field): Use new_reference. Return
16465 gdbpy_ref.
16466 (make_fielditem): Return gdbpy_ref.
16467 (typy_fields): Update.
16468 (typy_getitem): Update.
16469 (field_name): Return gdbpy_ref. Use new_reference.
16470 (typy_iterator_iternext): Update.
16471
16472 2019-01-03 Tom Tromey <tom@tromey.com>
16473
16474 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16475
16476 2019-01-03 Tom Tromey <tom@tromey.com>
16477
16478 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16479 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16480 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16481 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16482 (pspy_set_type_printers): Likewise.
16483 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16484 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16485 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16486 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16487 (objfpy_set_type_printers): Likewise.
16488
16489 2019-01-03 Tom Tromey <tom@tromey.com>
16490
16491 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16492 (gdbpy_print_stack): Use gdbpy_err_fetch.
16493 * python/python-internal.h (class gdbpy_err_fetch): New class.
16494 (class gdbpy_enter) <m_error_type, m_error_value,
16495 m_error_traceback>: Remove.
16496 <m_error>: New member.
16497 (gdbpy_exception_to_string): Don't declare.
16498 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16499 * python/py-value.c (convert_value_from_python): Use
16500 gdbpy_err_fetch.
16501 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16502 gdbpy_exception_to_string.
16503 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16504 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16505 gdbpy_err_fetch.
16506
16507 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16508
16509 * linux-nat.c (delete_lwp_cleanup): Delete.
16510 (struct lwp_deleter): New struct.
16511 (lwp_info_up): New typedef.
16512 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16513 lwp_info_up.
16514
16515 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16516
16517 * linux-fork.c (class scoped_switch_fork_info): New class.
16518 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16519
16520 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16521
16522 * valops.c (find_overload_match): Remove use of null_cleanup, and
16523 calls to do_cleanups.
16524
16525 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16526
16527 * compile/compile-cplus-types.c
16528 (compile_cplus_instance::decl_name): Handle changes to
16529 cp_func_name.
16530 * cp-support.c (cp_func_name): Update header comment, update
16531 return type.
16532 * cp-support.h (cp_func_name): Update return type in declaration.
16533 * valops.c (find_overload_match): Move temp_func local to top
16534 level of function and change its type. Use temp_func to hold and
16535 delete temporary string obtained from cp_func_name.
16536
16537 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16538
16539 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16540 gdb::char_vector, remove cleanup, and update uses of `msg`.
16541
16542 2019-01-03 Jim Wilson <jimw@sifive.com>
16543
16544 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16545
16546 2019-01-02 Tom Tromey <tom@tromey.com>
16547
16548 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16549 (tdesc_parse_xml): Remove cleanups.
16550 * target-descriptions.h (make_cleanup_free_target_description):
16551 Don't declare.
16552 (target_desc_deleter): New struct.
16553 (target_desc_up): New typedef.
16554 * target-descriptions.c (target_desc_deleter::operator()): Rename
16555 from free_target_description.
16556 (make_cleanup_free_target_description): Remove.
16557
16558 2019-01-02 Tom Tromey <tom@tromey.com>
16559
16560 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16561 constructor, destructor.
16562 (linespec_parser): Remove typedef.
16563 (~linespec_parser): Rename from linespec_parser_delete.
16564 (linespec_lex_to_end, linespec_complete_label)
16565 (linespec_complete): Update.
16566 (decode_line_full): Remove cleanups.
16567 (decode_line_1): Update.
16568
16569 2019-01-02 Tom Tromey <tom@tromey.com>
16570
16571 * python/python-internal.h (inferior_to_inferior_object): Change
16572 return type.
16573 * python/py-exitedevent.c (create_exited_event_object): Update.
16574 * python/py-inferior.c (inferior_to_inferior_object): Return
16575 gdbpy_ref.
16576 (python_new_inferior, python_inferior_deleted)
16577 (thread_to_thread_object, delete_thread_object)
16578 (build_inferior_list, gdbpy_selected_inferior): Update.
16579 * python/py-infthread.c (create_thread_object): Update. Also fail
16580 if inferior_to_inferior_object fails.
16581
16582 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16583
16584 * inferior.h (class inferior) <displaced_step_state>: New field.
16585 * infrun.h (struct displaced_step_state): Move here from
16586 infrun.c. Initialize fields, add constructor.
16587 <inf>: Remove field.
16588 <reset>: New method.
16589 * infrun.c (struct displaced_step_inferior_state): Move to
16590 infrun.h.
16591 (displaced_step_inferior_states): Remove.
16592 (get_displaced_stepping_state): Adust.
16593 (displaced_step_in_progress_any_inferior): Adjust.
16594 (displaced_step_in_progress_thread): Adjust.
16595 (displaced_step_in_progress): Adjust.
16596 (add_displaced_stepping_state): Remove.
16597 (get_displaced_step_closure_by_addr): Adjust.
16598 (remove_displaced_stepping_state): Remove.
16599 (infrun_inferior_exit): Call displaced_step_state.reset.
16600 (use_displaced_stepping): Don't check for NULL.
16601 (displaced_step_prepare_throw): Call
16602 get_displaced_stepping_state.
16603 (displaced_step_fixup): Don't check for NULL.
16604 (prepare_for_detach): Don't check for NULL.
16605
16606 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16607
16608 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16609 in case of call that did not complete.
16610
16611 2019-01-02 Andrey Utkin <autkin@undo.io>
16612
16613 * symfile.c (find_separate_debug_file): Fix search of debug files for
16614 remote debuggee.
16615
16616 2019-01-02 Tom Tromey <tom@tromey.com>
16617
16618 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16619 indentation.
16620 * python/py-frame.c (frapy_older): Remove cast.
16621 (frapy_newer): Likewise.
16622 * python/py-breakpoint.c (local_setattro): Remove cast.
16623 * python/py-arch.c (archpy_name): Remove local variable.
16624 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16625
16626 2019-01-02 Joel Brobecker <brobecker@adacore.com>
16627
16628 * unittests/basic_string_view/element_access/char/empty.cc:
16629 Fix year range in copyright header.
16630
16631 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16632
16633 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16634 Delete.
16635 <operator==>: Update with for removed field.
16636 <hash>: Likewise.
16637 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16638 <isa_features>: ...this.
16639 <abi_features>: New field.
16640 (riscv_isa_flen): Update comment.
16641 (riscv_abi_xlen): New declaration.
16642 (riscv_abi_flen): New declaration.
16643 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16644 isa_features.
16645 (riscv_abi_xlen): New function.
16646 (riscv_isa_flen): Update to get answer from isa_features.
16647 (riscv_abi_flen): New function.
16648 (riscv_has_fp_abi): Update to get answer from abi_features.
16649 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16650 xlen and flen.
16651 (riscv_call_info) <xlen, flen>: Update comment.
16652 (riscv_call_arg_struct): Remove invalid assertions
16653 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16654 is removed.
16655 (riscv_gdbarch_init): Gather isa features and abi features
16656 separately, ensure both match on the gdbarch when reusing an old
16657 gdbarch. Relax an error check to allow 32-bit abi float to run on
16658 a target with 64-bit float hardware.
16659
16660 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16661
16662 * source.c (search_command_helper): Stop reverse search
16663 when line 1 has been searched.
16664
16665 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16666
16667 * record-full.c (record_full_base_target::close): Rewrite
16668 record_full_core_buf_list free logic.
16669
16670 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16671
16672 * break-catch-syscall.c (print_one_catch_syscall): xfree
16673 the last text.
16674
16675 2019-01-01 Joel Brobecker <brobecker@adacore.com>
16676
16677 * top.c (print_gdb_version): Update Copyright year in version
16678 message.
16679
16680 2019-01-01 Joel Brobecker <brobecker@adacore.com>
16681
16682 Update copyright year range in all GDB files.
16683
16684 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
16685
16686 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16687
16688 For older changes see ChangeLog-2018.
16689 \f
16690 Local Variables:
16691 mode: change-log
16692 left-margin: 8
16693 fill-column: 74
16694 version-control: never
16695 coding: utf-8
16696 End:
16697
This page took 0.425029 seconds and 3 git commands to generate.