gdb/ChangeLog

   1 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
   2
   3         * jit.c (struct gdb_block) <next>: Remove field.
   4         (struct gdb_symtab) <~gdb_symtab>: Remove.
   5         <blocks>: Change type to std::forward_list<gdb_block>.
   6         (compare_block): Remove.
   7         (jit_block_open_impl): Adjust to std::forward_list.  Place the new
   8         block at the beginning, don't mind about sorting.
   9         (finalize_symtab): Adjust to std::forward_list, sort the blocks list
  10         before using it.
  11
  12 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  13
  14         * jit.c (struct gdb_block): Add constructor, initialize
  15         real_block and next fields.
  16         <name>: Change type to gdb::unique_xmalloc_ptr.
  17         (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
  18         (jit_block_open_impl): Allocate gdb_block with new.
  19         (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
  20
  21 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  22
  23         * jit.c: Include forward_list.
  24         (struct gdb_symtab) <next>: Remove field.
  25         (struct gdb_object) <symtabs>: Change type to
  26         std::forward_list<gdb_symtab>.
  27         (jit_object_open_impl): Allocate gdb_object with new.
  28         (jit_symtab_open_impl): Adjust to std::forward_list.
  29         (finalize_symtab): Don't delete symtab.
  30         (jit_object_close_impl):  Adjust to std::forward_list.  Free
  31         gdb_object with delete.
  32
  33 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  34
  35         * jit.c (struct gdb_symtab): Add constructor, destructor,
  36         initialize fields.
  37         <linetable>: Change type to unique_xmalloc_ptr.
  38         <file_name>: Change type to std::string.
  39         (jit_symtab_open_impl): Allocate gdb_symtab with new.
  40         (jit_symtab_line_mapping_add_impl): Adjust.
  41         (finalize_symtab): Adjust, call delete on stab.
  42
  43 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  44
  45         * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
  46
  47 2019-12-16  Tom Tromey  <tromey@adacore.com>
  48
  49         * windows-nat.c (windows_nat_target::attach): Update.
  50         * remote.c (extended_remote_target::attach): Update.
  51         * procfs.c (procfs_target::attach): Update.
  52         * nto-procfs.c (nto_procfs_target::attach): Update.
  53         (nto_procfs_target::create_inferior): Update.
  54         * inf-ptrace.c (inf_ptrace_target::attach): Update.
  55         * gnu-nat.c (gnu_nat_target::attach): Update.
  56         (gnu_nat_target::detach): Update.
  57         * darwin-nat.c (darwin_nat_target::attach): Update.
  58         * corefile.c (get_exec_file): Constify result.  Remove extraneous
  59         return.
  60         * bsd-kvm.c (bsd_kvm_target_open): Update.
  61         * gdbsupport/common-inferior.h (get_exec_file): Constify result.
  62
  63 2019-12-16  Christian Biesinger  <cbiesinger@google.com>
  64
  65         * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
  66         (we no longer need to include time.h before pathmax.h)
  67
  68 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
  69
  70         * ada-exp.y (write_ambiguous_var): Update.
  71         * coffread.c (process_coff_symbol): Update.
  72         * ctfread.c (ctf_add_enum_member_cb): Update.
  73         (new_symbol): Update.
  74         * dwarf2read.c (fixup_go_packaging): Update.
  75         (new_symbol): Update.
  76         * language.c (language_alloc_type_symbol): Update.
  77         * mdebugread.c (new_symbol): Update.
  78         * minsyms.c (minimal_symbol_reader::record_full): Update.
  79         * psymtab.c (add_psymbol_to_bcache): Update.
  80         * stabsread.c (define_symbol): Update.
  81         (read_enum_type): Update.
  82         * symtab.c (symbol_set_language): Make this a member function...
  83         (general_symbol_info::set_language): ... here.
  84         * symtab.h (struct general_symbol_info) <set_language>: New function.
  85         (SYMBOL_SET_LANGUAGE): Remove.
  86         (symbol_set_language): Remove.
  87
  88 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
  89
  90         * ada-lang.c (ada_add_block_symbols): Update.
  91         (ada_collect_symbol_completion_matches): Update.
  92         * ax-gdb.c (gen_expr): Update.
  93         * block.c (block_lookup_symbol): Update.
  94         (block_lookup_symbol_primary): Update.
  95         (block_find_symbol): Update.
  96         * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
  97         * dbxread.c (process_one_symbol): Update.
  98         * dictionary.c (insert_symbol_hashed): Update.
  99         (collate_pending_symbols_by_language): Update.
 100         (mdict_add_symbol): Update.
 101         * dwarf-index-write.c (write_psymbols): Update.
 102         * dwarf2read.c (fixup_go_packaging): Update.
 103         * findvar.c (read_var_value): Update.
 104         * ft32-tdep.c (ft32_skip_prologue): Update.
 105         * go-lang.c (go_symbol_package_name): Update.
 106         * language.h (scoped_switch_to_sym_language_if_auto::
 107         scoped_switch_to_sym_language_if_auto): Update.
 108         * linespec.c (find_method): Update.
 109         (find_label_symbols_in_block): Update.
 110         * mdebugread.c (parse_symbol): Update.
 111         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 112         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 113         (minimal_symbol_reader::install): Update.
 114         * moxie-tdep.c (moxie_skip_prologue): Update.
 115         * parse.c (parse_exp_in_context): Update.
 116         * psymtab.c (psymbol_name_matches): Update.
 117         (match_partial_symbol): Update.
 118         (lookup_partial_symbol): Update.
 119         (psymbol_hash): Update.
 120         (psymbol_compare): Update.
 121         * python/py-framefilter.c (extract_sym): Update.
 122         (py_print_single_arg): Update.
 123         * stabsread.c (define_symbol): Update.
 124         * stack.c (print_frame_arg): Update.
 125         (find_frame_funname): Update.
 126         (info_frame_command_core): Update.
 127         * symfile.c (set_initial_language): Update.
 128         * symtab.c (symbol_set_demangled_name): Update.
 129         (symbol_get_demangled_name): Update.
 130         (symbol_set_language): Update.
 131         (symbol_find_demangled_name): Update.
 132         (symbol_set_names): Update.
 133         (general_symbol_info::natural_name): Update.
 134         (general_symbol_info::demangled_name): Update.
 135         (general_symbol_info::search_name): Update.
 136         (symbol_matches_search_name): Update.
 137         (eq_symbol_entry): Update.
 138         (iterate_over_symbols): Update.
 139         (completion_list_add_symbol): Update.
 140         (completion_list_add_msymbol): Update.
 141         (completion_list_add_fields): Update.
 142         * symtab.h (struct general_symbol_info) <language>: New function.
 143         <language>: Rename to...
 144         <m_language>: ...this.
 145         (SYMBOL_LANGUAGE): Remove.
 146         (MSYMBOL_LANGUAGE): Remove.
 147         (struct symbol) <ctor>: Update.
 148         * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
 149
 150 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 151
 152         * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
 153         set the language of sym.
 154         * language.c (language_alloc_type_symbol): Likewise.
 155
 156 2019-12-14  Sergio Durigan Junior  <sergiodj@redhat.com>
 157
 158         https://bugzilla.redhat.com/show_bug.cgi?id=1728147
 159         PR gdb/23613
 160         * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
 161         * corelow.c: Include 'gdbsupport/pathstuff.h'.
 162         (core_target_open): Use 'gdb_abspath'.
 163         * gdbsupport/pathstuff.c (gdb_abspath): Guard against
 164         'current_directory == NULL' case.
 165         * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
 166         explain what happens when 'current_directory' is NULL.
 167         * go32-nat.c (go32_nat_target::wait): Check if
 168         'current_directory' is NULL before call to 'chdir'.
 169         * source.c (add_path): Use 'gdb_abspath'.
 170         * top.c: Include 'gdbsupport/pathstuff.h'.
 171         (init_history): Use 'gdb_abspath'.
 172         (set_history_filename): Likewise.
 173         * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
 174         (tfile_target_open): Use 'gdb_abspath'.
 175
 176 2019-12-13  Tom Tromey  <tromey@adacore.com>
 177
 178         * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
 179         warning or error.
 180
 181 2019-12-13  Tom Tromey  <tromey@adacore.com>
 182
 183         * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
 184
 185 2019-12-13  Tom Tromey  <tromey@adacore.com>
 186
 187         * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
 188
 189 2019-12-13  Tom Tromey  <tromey@adacore.com>
 190
 191         * contrib/ari/gdb_ari.sh (usage): Use GNU style.
 192
 193 2019-12-13  Tom Tromey  <tromey@adacore.com>
 194
 195         * gdbsupport/common-utils.c (string_printf, string_vprintf)
 196         (string_vappendf): Add ARI comment.
 197
 198 2019-12-13  Tom Tromey  <tromey@adacore.com>
 199
 200         * contrib/ari/gdb_ari.sh: Remove "fix" call for
 201         floatformat_to_double.
 202         * target-float.c (host_float_ops<T>::from_target): Add ARI
 203         comment.
 204
 205 2019-12-13  Tom Tromey  <tromey@adacore.com>
 206
 207         * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
 208         * utils.c (abort_with_message, dump_core, internal_vproblem): Add
 209         ARI marker to abort.
 210         * event-top.c (handle_sigsegv): Add ARI marker to abort.
 211
 212 2019-12-13  Tom Tromey  <tromey@adacore.com>
 213
 214         * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
 215
 216 2019-12-13  Tom Tromey  <tromey@adacore.com>
 217
 218         * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
 219
 220 2019-12-13  Tom Tromey  <tromey@adacore.com>
 221
 222         * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
 223         checks.
 224
 225 2019-12-13  Tom Tromey  <tromey@adacore.com>
 226
 227         * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
 228         end>: No longer "const".
 229
 230 2019-12-13  Simon Marchi  <simon.marchi@polymtl.ca>
 231
 232         * jit.c: Fix indentation, replace spaces with tabs where
 233         applicable.
 234
 235 2019-12-13  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
 236
 237         * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
 238
 239 2019-12-12  Tom Tromey  <tom@tromey.com>
 240
 241         * objfiles.h (struct objfile) <partial_symtabs>: Now a
 242         unique_ptr.
 243
 244 2019-12-12  Tom Tromey  <tom@tromey.com>
 245
 246         * progspace.h (objfile_list): New typedef.
 247         (class unwrapping_objfile_iterator)
 248         (struct unwrapping_objfile_range): Newl
 249         (struct program_space) <objfiles_range>: Change type.
 250         <objfiles>: Change return type.
 251         <add_objfile>: Change type of "objfile" parameter.
 252         <objfiles_list>: Now a list of shared_ptr.
 253         * progspace.c (program_space::add_objfile): Change type of
 254         "objfile".  Update.
 255         (program_space::remove_objfile): Update.
 256         * objfiles.h (struct objfile) <~objfile>: Make public.
 257         * objfiles.c (objfile::make): Update.
 258         (objfile::unlink): Don't call delete.
 259
 260 2019-12-12  Tom Tromey  <tom@tromey.com>
 261
 262         * symfile.c (symbol_file_clear): Update.
 263         * progspace.h (struct program_space) <free_all_objfiles>: Declare
 264         method.
 265         * progspace.c (program_space::free_all_objfiles): New method.
 266         * objfiles.h (free_all_objfiles): Don't declare.
 267         * objfiles.c (free_all_objfiles): Move to program_space.
 268
 269 2019-12-12  Tom Tromey  <tom@tromey.com>
 270
 271         * progspace.c (program_space::add_objfile)
 272         (program_space::remove_objfile): Update.
 273         (program_space::multi_objfile_p): Remove.
 274         * objfiles.h (struct objfile) <next>: Remove.
 275         * objfiles.c (objfile::objfile): Update.
 276         (put_objfile_before): Update.
 277         (unlink_objfile): Update.
 278         * progspace.h (object_files): Remove.
 279         (struct program_space) <objfiles_head>: Remove.
 280         <objfiles_list>: New member.
 281         <objfiles_range, objfiles_safe_range>: Change type.
 282         (objfiles): Change return type.
 283         (objfiles_safe): Update.
 284         (multi_objfile_p): Rewrite and inline.
 285         (object_files): Remove macro.
 286
 287 2019-12-12  Tom Tromey  <tom@tromey.com>
 288
 289         * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify.  Add
 290         second constructor.
 291         (basic_safe_range): New class.
 292
 293 2019-12-12  Tom Tromey  <tom@tromey.com>
 294
 295         * progspace.c (program_space::multi_objfile_p): New method.
 296         * printcmd.c (info_symbol_command): Update.
 297         * maint.c (maintenance_translate_address): Update.
 298         * objfiles.h (MULTI_OBJFILE_P): Remove.
 299         * progspace.h (struct program_space) <multi_objfile_p>: New
 300         method.
 301
 302 2019-12-12  Tom Tromey  <tom@tromey.com>
 303
 304         * progspace.h (struct program_space) <remove_objfile>: Declare.
 305         * progspace.c (program_space::remove_objfile): New method.
 306         * objfiles.c (unlink_objfile): Remove.
 307         (objfile::unlink): Call remove_objfile.
 308         (objfile): Don't call unlink_objfile.
 309
 310 2019-12-12  Tom Tromey  <tom@tromey.com>
 311
 312         * progspace.h (struct program_space) <add_objfile>: Declare
 313         method.
 314         * progspace.c (program_space::add_objfile): New method.
 315         * objfiles.c (~objfile): Don't unlink objfile.
 316         (put_objfile_before): Remove.
 317         (add_separate_debug_objfile): Don't call put_objfile_before.
 318         (objfile::make): Call add_objfile.  Set new_objfiles_available on
 319         the per-program-space data.
 320
 321 2019-12-12  Tom Tromey  <tom@tromey.com>
 322
 323         * symfile.c (syms_from_objfile_1): Use objfile_up.
 324         (syms_from_objfile_1, remove_symbol_file_command): Call unlink
 325         method.
 326         (reread_symbols): Use objfile_up.
 327         * solib.c (update_solib_list, reload_shared_libraries_1): Call
 328         unlink method.
 329         * objfiles.h (struct objfile) <~objfile>: Now private.
 330         <unlink>: New method.
 331         (struct objfile_deleter): New.
 332         (objfile_up): New typedef.
 333         * objfiles.c (objfile::unlink): New method.
 334         (free_objfile_separate_debug, free_all_objfiles)
 335         (objfile_purge_solibs): Use it.
 336         * jit.c (jit_unregister_code): Remove.
 337         (jit_inferior_exit_hook, jit_event_handler): Call unlink on
 338         objfile.
 339         * compile/compile-object-run.c (do_module_cleanup): Call unlink on
 340         objfile.
 341         * compile/compile-object-load.c (compile_object_load): Use
 342         objfile_up.
 343
 344 2019-12-12  Tom Tromey  <tom@tromey.com>
 345
 346         * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
 347         objfile::make.
 348         * objfiles.h (struct objjfile) <make>: No longer inline.
 349         (add_separate_debug_objfile): Don't declare.
 350         * objfiles.c (add_separate_debug_objfile): Now static.
 351         (objfile::make): Move from objfiles.h.  Call
 352         add_separate_debug_objfile.  Add "parent" parameter.
 353
 354 2019-12-12  Tom Tromey  <tom@tromey.com>
 355
 356         * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
 357         * objfiles.h (struct objfile): Make constructor private.
 358         <make>: New static method.
 359         * jit.c (jit_object_close_impl): Update.
 360
 361 2019-12-12  Simon Marchi  <simon.marchi@polymtl.ca>
 362
 363         * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
 364         gdb::byte_vector.
 365
 366 2019-12-12  Tom Tromey  <tromey@adacore.com>
 367
 368         * xml-support.c (xml_fetch_content_from_file): Don't call
 369         malloc_failure.
 370         * utils.h (class gdb_argv): Remove malloc_failure comment.
 371         * utils.c (gdb_argv::reset): Don't call malloc_failure.
 372
 373 2019-12-12  Tom Tromey  <tromey@adacore.com>
 374
 375         * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
 376         (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
 377         (ALLDEPFILES): Add riscv-ravenscar-thread.c.
 378         * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
 379         * riscv-ravenscar-thread.c: New file.
 380         * riscv-ravenscar-thread.h: New file.
 381         * riscv-tdep.c (riscv_gdbarch_init): Call
 382         register_riscv_ravenscar_ops.
 383
 384 2019-12-12  Tom Tromey  <tromey@adacore.com>
 385
 386         * gdbsupport/thread-pool.c (set_thread_name): Use
 387         ATTRIBUTE_UNUSED.
 388
 389 2019-12-12  Luis Machado  <luis.machado@linaro.org>
 390
 391         * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
 392         (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
 393         macros.
 394
 395 2019-12-11  Tom Tromey  <tom@tromey.com>
 396
 397         * tui/tui-win.c (tui_set_win_height_command): Call
 398         tui_adjust_window_height.
 399         (tui_adjust_win_heights, new_height_ok): Remove.
 400         * tui/tui-layout.h (tui_adjust_window_height): Declare.
 401         * tui/tui-layout.c (tui_adjust_window_height): New function.
 402
 403 2019-12-11  Tom Tromey  <tom@tromey.com>
 404
 405         * tui/tui-win.c (tui_resize_all): Remove code, call
 406         tui_apply_current_layout.
 407
 408 2019-12-11  Tom Tromey  <tom@tromey.com>
 409
 410         * tui/tui-layout.h (tui_apply_current_layout): Declare.
 411         * tui/tui-layout.c (standard_layouts, applied_layout): New
 412         globals.
 413         (tui_apply_current_layout): New function.
 414         (show_layout): Set applied_layout.  Call
 415         tui_apply_current_layout.
 416         (show_source_command, show_disasm_command)
 417         (show_source_disasm_command, show_data)
 418         (show_source_or_disasm_and_command): Remove.
 419         (initialize_layouts): New function.
 420         (_initialize_tui_layout): Call initialize_layouts.
 421
 422 2019-12-11  Tom Tromey  <tom@tromey.com>
 423
 424         * tui/tui-layout.h (class tui_layout_base)
 425         (class tui_layout_window, class tui_layout_split): New.
 426         * tui/tui-layout.c (tui_get_window_by_name)
 427         (tui_layout_window::clone, tui_layout_window::apply)
 428         (tui_layout_window::get_sizes, tui_layout_window::add_split)
 429         (tui_layout_split::add_window, tui_layout_split::clone)
 430         (tui_layout_split::get_sizes)
 431         (tui_layout_split::set_weights_from_heights)
 432         (tui_layout_split::adjust_size, tui_layout_split::apply): New
 433         functions.
 434         (tui_layout_split::add_split, tui_layout_split::add_split)
 435         (tui_layout_split::set_weights_from_heights)
 436         (tui_layout_split::set_weights_from_heights): New functions.
 437
 438 2019-12-11  Tom Tromey  <tom@tromey.com>
 439
 440         * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
 441         * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
 442         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 443         * tui/tui-data.h (struct tui_point): Remove.
 444         (struct tui_gen_win_info) <origin>: Remove.
 445         <x, y>: New fields.
 446         * tui/tui-command.c (tui_cmd_window::resize): Update.
 447
 448 2019-12-11  Tom Tromey  <tom@tromey.com>
 449
 450         * tui/tui-stack.h (struct tui_locator_window) <min_height>:
 451         Implement.
 452         * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
 453         Implement.
 454         * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
 455         method.
 456         (struct tui_win_info) <min_height>: Implement.
 457
 458 2019-12-11  Tom Tromey  <tom@tromey.com>
 459
 460         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 461         (struct tui_win_info) <can_box>: Update.
 462
 463 2019-12-11  Tom Tromey  <tom@tromey.com>
 464
 465         * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
 466         method.
 467         * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
 468         method.
 469         * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
 470         method.
 471         (struct tui_win_info) <max_height>: Now override.
 472
 473 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 474
 475         * NEWS: Create a new section for the next release branch.
 476         Rename the section of the current branch, now that it has
 477         been cut.
 478
 479 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 480
 481         GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
 482         * version.in: Bump version to 10.0.50.DATE-git.
 483
 484 2019-12-11  Tom Tromey  <tromey@adacore.com>
 485
 486         PR build/25268:
 487         * gdbsupport/thread-pool.c (set_thread_name): New function.
 488         (thread_pool::set_thread_count): Don't call pthread_setname_np.
 489         (thread_pool::thread_function): Call set_thread_name.
 490
 491 2019-12-11  Tom Tromey  <tromey@adacore.com>
 492
 493         * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
 494         bfd_get_signed_8.
 495
 496 2019-12-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 497
 498         * NEWS: Document -raw-values option and the related setting commands.
 499         * printcmd.c (print_command_parse_format): Do not set opts->raw off,
 500         only set it on when /r is given.
 501         * valprint.c (value_print_option_defs): New element raw-values.
 502         * Makefile.in: Add the new file.
 503
 504 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 505
 506         * gdbsupport/safe-strerror.c: Supress the unused function warning
 507         for select_strerror_r.
 508
 509 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 510
 511         * config.in: Regenerate.
 512         * configure: Regenerate.
 513         * gdbsupport/agent.c (gdb_connect_sync_socket): Call
 514         safe_strerror instead of strerror.
 515         * gdbsupport/common.m4: Don't check for strerror.
 516         * gdbsupport/safe-strerror.c: Support both the glibc version
 517         of strerror_r and the XSI version.
 518
 519 2019-12-10  Tom Tromey  <tromey@adacore.com>
 520
 521         * ada-typeprint.c (print_choices): Use a single "?".
 522         (print_variant_part): Print "?" if the discriminant name
 523         is not known.
 524
 525 2019-12-10  George Barrett  <bob@bob131.so>
 526
 527         Fix scripted probe breakpoints.
 528         * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
 529         declaration forward.
 530         (breakpoint_ops_for_event_location_type)
 531         (breakpoint_ops_for_event_location): Add function definitions.
 532         (break_command_1, trace_command): Use
 533         breakpoint_ops_for_event_location.
 534         * breakpoint.h (breakpoint_ops_for_event_location): Add function
 535         declarations.
 536         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
 537         breakpoint_ops_for_event_location.
 538         * python/py-breakpoint.c (bppy_init): Use
 539         breakpoint_ops_for_event_location.
 540
 541 2019-12-09  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 542
 543         * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
 544         when ranking an lvalue argument for an rvalue parameter.
 545
 546 2019-12-08  Wataru Ashihara  <wataash@wataash.com>
 547
 548         * darwin-nat.c (darwin_nat_target::create_inferior): Fix
 549         template argument for scoped_restore_tmpl from bool to int.
 550
 551 2019-12-07  Keith Seitz  <keiths@redhat.com>
 552
 553         * build-id.c (build_id_bfd_get): Permit bfd_core, too.
 554         (build_id_to_debug_bfd): Make static, rewriting to use
 555         build_id_to_bfd_suffix.
 556         (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
 557         adding `suffix' parameter. Append SUFFIX to file names
 558         when searching for matching files.
 559         (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
 560         (build_id_to_exec_bfd): Likewise.
 561         * build-id.h (build_id_to_debug_bfd): Clarify that function
 562         searches for BFD of debug info file.
 563         (build_id_to_exec_bfd): Declare.
 564         * corelow.c: Include build-id.h.
 565         (locate_exec_from_corefile_build_id): New function.
 566         (core_target_open): If no executable BFD is found,
 567         search for a core file BFD using build-id.
 568
 569 2019-12-06  Christian Biesinger  <cbiesinger@google.com>
 570
 571         * bcache.c: Put in namespace gdb.
 572         * bcache.h: Likewise.
 573         * gdbtypes.c (check_types_worklist): Update.
 574         (types_deeply_equal): Update.
 575         * macrotab.c (struct macro_table) <bcache>: Update.
 576         (new_macro_table): Update.
 577         * macrotab.h (struct bcache): Put this forward declaration
 578         inside namespace gdb.
 579         (new_macro_table): Update.
 580         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
 581         Update.
 582         <macro_cache>: Update.
 583         * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
 584
 585 2019-12-06  Tom de Vries  <tdevries@suse.de>
 586
 587         PR symtab/24971
 588         * block.c (best_symbol, better_symbol): New function.
 589         (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
 590         decl.
 591
 592 2019-12-06  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 593
 594         * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
 595         * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
 596         for ranking see-through reference cases.
 597
 598 2019-12-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 599         * stack.c (faas_command): Check a command is provided.
 600         * thread.c (taas_command, tfaas_command): Likewise.
 601
 602 2019-12-05  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 603         * inferior.c (prune_inferiors):  Only call delete_inferior,
 604         Do not modify the inferior list.
 605
 606 2019-12-05  Simon Marchi  <simon.marchi@polymtl.ca>
 607
 608         * c-exp.y: Update calls to lookup_typename,
 609         lookup_signed_typename and lookup_unsigned_typename.
 610         * c-lang.c (evaluate_subexp_c): Likewise.
 611         * cp-namespace.c (cp_lookup_symbol_imports_or_template):
 612         Likewise.
 613         * eval.c (binop_promote): Likewise.
 614         * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
 615         (lookup_unsigned_typename): Likewise.
 616         (lookup_signed_typename): Likewise.
 617         * gdbtypes.h (lookup_unsigned_typename): Likewise.
 618         (lookup_signed_typename): Likewise.
 619         (lookup_typename): Likewise.
 620         * guile/scm-type.c (tyscm_lookup_typename): Update calls to
 621         lookup_typename, lookup_signed_typename,
 622         lookup_unsigned_typename.
 623         * m2-exp.y: Likewise.
 624         * printcmd.c (printf_wide_c_string): Likewise.
 625         (ui_printf): Likewise.
 626         * python/py-type.c (typy_lookup_typename): Likewise.
 627         * python/py-xmethods.c (python_xmethod_worker::invoke):
 628         Likewise.
 629         * rust-exp.y: Likewise.
 630
 631 2019-12-04  Christian Biesinger  <cbiesinger@google.com>
 632
 633         * configure.nat (obsd64): Add missing files x86-nat.o and
 634         nat/x86-dregs.o.
 635
 636 2019-12-04  Tom Tromey  <tom@tromey.com>
 637
 638         * valprint.c (val_print_string): Use metadata_style.
 639         * go-valprint.c (print_go_string): Use metadata style.
 640         * p-valprint.c (pascal_object_print_static_field): Use metadata
 641         style.
 642         * cp-valprint.c (cp_print_static_field): Use metadata style.
 643
 644 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 645             Chris January  <chris.january@arm.com>
 646
 647         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
 648         tokens.
 649         (typebase): New patterns for complex, single/double precision, and
 650         single/double complex.
 651         (f77_keywords): Change token for complex keyword, and add single,
 652         double, and precision keywords.
 653
 654 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 655
 656         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
 657         "info io_registers".
 658
 659 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 660
 661         * regcache.c (cooked_read_test): Initialize thread list of
 662         mock_inferior.
 663
 664 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 665
 666         * aarch64-linux-tdep.c: Remove includes.
 667
 668 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 669
 670         * aarch64-tdep.c: Remove includes.
 671
 672 2019-12-04  Simon Marchi  <simon.marchi@efficios.com>
 673
 674         * filtered-iterator.h (filtered_iterator) <operator==,
 675         operator!=>: Compare wrapped iterators, not wrapped pointers.
 676         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 677         unittests/filtered_iterator-selftests.c.
 678         * unittests/filtered_iterator-selftests.c: New file.
 679
 680 2019-12-04  Tom Tromey  <tromey@adacore.com>
 681
 682         * gdbtypes.c (create_range_type): Inherit endianity
 683         from base type.
 684
 685 2019-12-04  Tom Tromey  <tromey@adacore.com>
 686
 687         * ada-lang.c (decode_constrained_packed_array)
 688         (ada_value_assign, value_assign_to_component): Update.
 689         * dwarf2loc.c (rw_pieced_value, access_memory)
 690         (dwarf2_compile_expr_to_ax): Update.
 691         * dwarf2read.c (dwarf2_add_field): Update.
 692         * eval.c (evaluate_subexp_standard): Update.
 693         * gdbarch.c, gdbarch.h: Rebuild.
 694         * gdbarch.sh (bits_big_endian): Remove.
 695         * gdbtypes.h (union field_location): Update comment.
 696         * target-descriptions.c (make_gdb_type): Update.
 697         * valarith.c (value_bit_index): Update.
 698         * value.c (struct value) <bitpos>: Update comment.
 699         (unpack_bits_as_long, modify_field): Update.
 700         * value.h (value_bitpos): Update comment.
 701
 702 2019-12-04  Tom Tromey  <tromey@adacore.com>
 703
 704         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
 705         endian-ness.
 706
 707 2019-12-04  Tom Tromey  <tromey@adacore.com>
 708
 709         * dwarf2read.c (dwarf2_init_float_type)
 710         (dwarf2_init_complex_target_type): Add byte_order parameter.
 711         (read_base_type): Compute byte order earlier.
 712         * gdbtypes.c (init_float_type): Add byte_order parameter.
 713         * gdbtypes.h (init_float_type): Add byte_order parameter.
 714
 715 2019-12-04  Tom Tromey  <tromey@adacore.com>
 716
 717         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
 718
 719 2019-12-04  Tom Tromey  <tromey@adacore.com>
 720
 721         * dwarf2read.c (process_structure_scope): Initialize
 722         "discr_offset".
 723
 724 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 725
 726         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
 727         add it into the search spec.
 728         (parse_max_results_option): New function.
 729         (mi_info_functions_or_variables): Parse -max-results flag and pass
 730         it to mi_symbol_info.
 731         (mi_cmd_symbol_info_modules): Likewise.
 732         (mi_cmd_symbol_info_types): Likewise.
 733         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
 734         return type to bool, change result container into a set, and don't
 735         add new results if we have enough already.
 736         (global_symbol_searcher::add_matching_msymbols): Change return
 737         type to bool, and don't add new results if we have enough already.
 738         (sort_search_symbols_remove_dups): Delete.
 739         (global_symbol_searcher::search): Early exit from search loop when
 740         we have enough results.  Use a std::set to collect the results
 741         from calling add_matching_symbols.
 742         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
 743         member function.
 744         (global_symbol_searcher) <m_max_search_results>: New member
 745         variable.
 746         (global_symbol_searcher) <add_matching_symbols>: Update header
 747         comment and change return type to bool.
 748         (global_symbol_searcher) <add_matching_msymbols>: Update header
 749         comment and change return type to bool.
 750
 751 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 752
 753         * symtab.c (symbol_search::compare_search_syms): Update header
 754         comment.
 755         (global_symbol_searcher::is_suitable_msymbol): New function.
 756         (global_symbol_searcher::expand_symtabs): New function.
 757         (global_symbol_searcher::add_matching_symbols): New function.
 758         (global_symbol_searcher::add_matching_msymbols): New function.
 759         (global_symbol_searcher::search): Move most of the content
 760         into the new functions above, and call them as needed.
 761         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
 762         function.
 763         (global_symbol_searcher) <add_matching_symbols>: New member
 764         function.
 765         (global_symbol_searcher) <add_matching_msymbols>: New member
 766         function.
 767         (global_symbol_searcher) <is_suitable_msymbol>: New member
 768         function.
 769
 770 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 771
 772         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
 773         -symbol-info-module-variables entries.
 774         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
 775         (mi_cmd_symbol_info_module_variables): Declare.
 776         * mi/mi-symbol-cmds.c
 777         (module_symbol_search_iterator): New typedef.
 778         (output_module_symbols_in_single_module_and_file): New function.
 779         (output_module_symbols_in_single_module): New function.
 780         (mi_info_module_functions_or_variables): New function.
 781         (mi_cmd_symbol_info_module_functions): New function.
 782         (mi_cmd_symbol_info_module_variables): New function.
 783         * NEWS: Mention new MI command.
 784
 785 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
 786
 787         * bcache.c (hash): Remove.
 788         (hash_continue): Remove.
 789         * bcache.h (hash): Remove.
 790         (hash_continue): Remove.
 791         (struct bcache) <ctor>: Update.
 792         * psymtab.c (psymbol_hash): Update.
 793         * stabsread.c (hashname): Update.
 794         * utils.h (fast_hash): Add an argument for a start value,
 795         defaulting to zero.
 796
 797 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 798         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
 799         (destroy_block_symbol_cache): New function.
 800         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
 801         (resize_symbol_cache): Likewise.
 802
 803 2019-12-02  Tom Tromey  <tom@tromey.com>
 804
 805         * unittests/tui-selftests.c (run_tests): Make conditional.
 806         (_initialize_tui_selftest): Make conditional.
 807
 808 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
 809
 810         * aix-thread.c (debug_aix_thread): Change type to bool.
 811
 812 2019-12-02  Luis Machado  <luis.machado@linaro.org>
 813
 814         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
 815
 816 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 817
 818         * dwarf2read.c (read_tag_string_type): Read the fields required to
 819         make a dynamic string, and possibly create a dynamic range for the
 820         string.
 821         (attr_to_dynamic_prop): Setup is_reference based on the type of
 822         attribute being processed.
 823         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
 824         (resolve_dynamic_array): Rename to...
 825         (resolve_dynamic_array_or_string): ...this, update header comment,
 826         and accept TYPE_CODE_STRING.
 827         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
 828
 829 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 830
 831         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
 832         of its implementation from...
 833         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
 834         the new function.
 835
 836 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 837
 838         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
 839         create a range with stride where appropriate.
 840         * f-valprint.c: Include 'gdbarch.h'.
 841         (f77_print_array_1): Take the stride into account when walking the
 842         array.  Also convert the stride into addressable units.
 843         * gdbtypes.c (create_range_type): Initialise the stride to
 844         constant zero.
 845         (create_range_type_with_stride): New function, initialise the
 846         range as normal, and then setup the stride.
 847         (has_static_range): Include the stride here.  Also change the
 848         return type to bool.
 849         (create_array_type_with_stride): Consider the range stride if the
 850         array isn't given its own stride.
 851         (resolve_dynamic_range): Resolve the stride if needed.
 852         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
 853         (struct range_bounds) <flag_is_byte_stride>: New member variable.
 854         (TYPE_BIT_STRIDE): Define.
 855         (TYPE_ARRAY_BIT_STRIDE): Define.
 856         (create_range_type_with_stride): Declare.
 857         * valarith.c (value_subscripted_rvalue): Take range stride into
 858         account when walking the array.
 859
 860 2019-12-01  Tom Tromey  <tom@tromey.com>
 861
 862         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
 863         specially.
 864
 865 2019-12-01  Tom Tromey  <tom@tromey.com>
 866
 867         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
 868         \0.
 869         * unittests/tui-selftests.c: New file.
 870         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
 871
 872 2019-12-01  Tom Tromey  <tom@tromey.com>
 873
 874         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
 875
 876 2019-12-01  Tom Tromey  <tom@tromey.com>
 877
 878         * NEWS: Document new settings.
 879         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
 880         * tui/tui-win.c (_initialize_tui_win): Add border style
 881         observers.
 882         * tui/tui-io.h (tui_apply_style): Declare.
 883         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
 884         longer static.
 885         (apply_ansi_escape, tui_set_reverse_mode): Update.
 886         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
 887         Add "skip_intensity" parameter.
 888         <changed>: New member.
 889         <do_set_value>: Declare.
 890         (tui_border_style, tui_active_border_style): Declare.
 891         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
 892         globals.
 893         (cli_style_option): Initialize "changed".
 894         (cli_style_option::do_set_value): New function.
 895         (cli_style_option::add_setshow_commands): Add "skip_intensity"
 896         parameter.  Update.
 897         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
 898         (_initialize_cli_style): Update.  Create TUI border style
 899         commands.
 900
 901 2019-12-01  Tom Tromey  <tom@tromey.com>
 902
 903         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
 904         parameter.
 905         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
 906         parameter.
 907         * tui/tui-win.h (compact_source): Declare.
 908         * tui/tui-win.c (compact_source): New global.
 909         (tui_set_compact_source, tui_show_compact_source): New functions.
 910         (_initialize_tui_win): Add "compact-source" setting.
 911         * tui/tui-source.c (tui_source_window::set_contents): Handle
 912         compact_source setting.
 913         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 914         * NEWS: Document new setting.
 915
 916 2019-11-30  Tom Tromey  <tom@tromey.com>
 917
 918         * dwarf2read.c (dwarf2_add_field): Include field offset when
 919         computing variant part length.
 920
 921 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 922         * NEWS:  Mention define-prefix.  Tell that command names can now
 923         contain a . character.
 924
 925 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 926
 927         * command.h (valid_cmd_char_p): Declare.
 928         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
 929         the check of valid command char.
 930         (find_command_name_length, valid_user_defined_cmd_name_p): Use
 931         valid_cmd_char_p.
 932         * cli/cli-script.c (validate_comname): Likewise.
 933         * completer.c (gdb_completer_command_word_break_characters):
 934         Do not remove . from the word break char, update comments.
 935         (complete_line_internal_1): Use valid_cmd_char_p.
 936         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
 937         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
 938
 939 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 940
 941         * cli/cli-script.c (do_define_command): Ensure a redefined
 942         prefix command is kept as a prefix command.
 943         (define_prefix_command): New function.
 944         (show_user_1): Report user defined prefixes.
 945         (_initialize_cli_script):  Create the new 'define-prefix' command.
 946         Add completers for 'define' and 'document'.
 947         * top.c (execute_command):  If command is a user-defined prefix only
 948         command, report the list of commands for this prefix command.
 949
 950 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 951
 952         * valops.c (find_oload_champ): Improve debug output.
 953
 954 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 955
 956         * valops.c (find_oload_champ): Print part of debug messages
 957         before the badness vector is std::move'd.
 958
 959 2019-11-28  Tom Tromey  <tom@tromey.com>
 960
 961         * value.c (creal_internal_fn): Fix comment.
 962
 963 2019-11-28  Tom Tromey  <tom@tromey.com>
 964
 965         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
 966         flag_bound_evaluated>: Now unsigned.
 967
 968 2019-11-28  Tom Tromey  <tom@tromey.com>
 969
 970         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
 971         declare.
 972
 973 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
 974
 975         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
 976         debug output.
 977         * jit.c (jit_unregister_code): Add debug print to match
 978         `jit_register_code`.
 979
 980 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 981
 982         * NEWS: Mention the new multithreaded symbol loading.
 983
 984 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 985
 986         * maint.c (n_worker_threads): Default to 0.
 987         (worker_threads_disabled): New function.
 988         * maint.h (worker_threads_disabled): New function.
 989         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
 990         here if worker_threads_disabled () is true.
 991         (minimal_symbol_reader::install): Skip all threading if
 992         worker_threads_disabled () is true.
 993
 994 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 995
 996         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
 997         hash code if possible.
 998         (add_minsym_to_demangled_hash_table): Likewise.
 999         (minimal_symbol_reader::install): Compute the hash codes for msymbol
1000         on the background thread.
1001         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1002         Add these fields.
1003
1004 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1005
1006         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1007         of the mangled name on the background thread.
1008         * symtab.c (symbol_set_names): Allow passing in the hash of the
1009         linkage_name.
1010         * symtab.h (symbol_set_names): Likewise.
1011
1012 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
1013
1014         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1015         physnames are computed for inherited DIEs.
1016
1017 2019-11-27  Tom Tromey  <tromey@adacore.com>
1018
1019         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1020         backslashes.
1021         * cp-support.c: Remove unnecessary backslashes.
1022
1023 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1024
1025         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1026         with sym->set_linkage_name.
1027         * coffread.c (coff_read_enum_type): Likewise.
1028         * mdebugread.c (parse_symbol): Likewise.
1029         * stabsread.c (patch_block_stabs): Likewise.
1030         (define_symbol): Likewise.
1031         (read_enum_type): Likewise.
1032         (common_block_end): Likewise.
1033         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1034         function.
1035         (SYMBOL_SET_LINKAGE_NAME): Remove.
1036         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1037         with sym->set_linkage_name.
1038
1039 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1040
1041         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1042         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1043         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1044         * NEWS: Mention new MI command.
1045
1046 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1047
1048         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1049         '-symbol-info-types', and '-symbol-info-variables'.
1050         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1051         (mi_cmd_symbol_info_types): Declare.
1052         (mi_cmd_symbol_info_variables): Declare.
1053         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1054         (output_debug_symbol): New function.
1055         (output_nondebug_symbol): New function.
1056         (mi_symbol_info): New function.
1057         (mi_info_functions_or_variables): New function.
1058         (mi_cmd_symbol_info_functions): New function.
1059         (mi_cmd_symbol_info_types): New function.
1060         (mi_cmd_symbol_info_variables): New function.
1061         * NEWS: Mention new commands.
1062
1063 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1064
1065         * symtab.c (symbol_to_info_string): New function, most content
1066         moved from print_symbol_info, but updated to return a std::string.
1067         (print_symbol_info): Update to use symbol_to_info_string and print
1068         returned string.
1069         * symtab.h (symbol_to_info_string): Declare new function.
1070
1071 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1072
1073         * python/python.c (gdbpy_rbreak): Convert to using
1074         global_symbol_searcher.
1075         * symtab.c (file_matches): Convert return type to bool, change
1076         file list to std::vector, update header comment.
1077         (search_symbols): Rename to...
1078         (global_symbol_searcher::search): ...this and update now its
1079         a member function of global_symbol_searcher.  Take account of the
1080         changes to file_matches.
1081         (symtab_symbol_info): Convert to using global_symbol_searcher.
1082         (rbreak_command): Likewise.
1083         (search_module_symbols): Likewise.
1084         * symtab.h (enum symbol_search): Update comment.
1085         (search_symbols): Remove declaration.
1086         (class global_symbol_searcher): New class.
1087
1088 2019-11-26  Tom Tromey  <tromey@adacore.com>
1089
1090         * cp-support.c (_initialize_cp_support): Conditionally initialize
1091         gdb_demangle_attempt_core_dump.
1092
1093 2019-11-26  Tom Tromey  <tom@tromey.com>
1094
1095         * python/py-function.c (fnpy_init): Update.
1096         * value.h (add_internal_function): Adjust declaration.
1097         * value.c (function_destroyer): Remove.
1098         (do_add_internal_function): Don't set destroyer or copy name.
1099         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1100         Set name_allocated.
1101         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1102         (cmdpy_init): Set name_allocated.
1103         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1104         member.
1105         (~cmd_list_element): Free "name" if needed.
1106
1107 2019-11-26  Tom Tromey  <tom@tromey.com>
1108
1109         * value.h (add_internal_function): Add new overload.  Move
1110         documentation from value.h.
1111         * value.c (do_add_internal_function): New function.
1112         (add_internal_function): Use it.  Add new overload.
1113         (function_destroyer): Don't free doc.
1114         * python/py-function.c (fnpy_init): Update.
1115
1116 2019-11-26  Tom Tromey  <tom@tromey.com>
1117
1118         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1119         (cmdpy_init): Set "doc_allocated".
1120
1121 2019-11-26  Tom Tromey  <tom@tromey.com>
1122
1123         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1124         name of worker thread.
1125         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1126         pthread_setname_np.
1127         * configure, config.in: Rebuild.
1128
1129 2019-11-26  Tom Tromey  <tom@tromey.com>
1130
1131         * python/python.c (class gdbpy_gil): New.
1132         (struct gdbpy_event): Add constructor, destructor, operator().
1133         (gdbpy_post_event): Use run_on_main_thread.
1134         (gdbpy_initialize_events): Remove.
1135         (do_start_initialization): Update.
1136
1137 2019-11-26  Tom Tromey  <tom@tromey.com>
1138
1139         * NEWS: Add entry.
1140         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1141         commands.  Call update_thread_pool_size.
1142         (update_thread_pool_size, maintenance_set_worker_threads): New
1143         functions.
1144         (n_worker_threads): New global.
1145
1146 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1147             Tom Tromey  <tom@tromey.com>
1148
1149         * minsyms.c (minimal_symbol_reader::install): Use
1150         parallel_for_each.
1151         * gdbsupport/parallel-for.h: New file.
1152         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1153
1154 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1155             Tom Tromey  <tom@tromey.com>
1156
1157         * gdbsupport/thread-pool.h: New file.
1158         * gdbsupport/thread-pool.c: New file.
1159         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1160         (HFILES_NO_SRCDIR): Add thread-pool.h.
1161
1162 2019-11-26  Tom Tromey  <tom@tromey.com>
1163
1164         * event-top.h (thread_local_segv_handler): Declare.
1165         * event-top.c (thread_local_segv_handler): New global.
1166         (install_handle_sigsegv, handle_sigsegv): New functions.
1167         (async_init_signals): Install SIGSEGV handler.
1168         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
1169         thread-local.
1170         (report_failed_demangle): New function.
1171         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
1172         handler-setting code, instead use segv_handler.  Run warning code
1173         on main thread.
1174
1175 2019-11-26  Tom Tromey  <tom@tromey.com>
1176
1177         * run-on-main-thread.c: New file.
1178         * run-on-main-thread.h: New file.
1179         * unittests/main-thread-selftests.c: New file.
1180         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1181         main-thread-selftests.c.
1182         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1183         (COMMON_SFILES): Add run-on-main-thread.c.
1184
1185 2019-11-26  Tom Tromey  <tom@tromey.com>
1186
1187         * main.c (setup_alternate_signal_stack): Remove.
1188         (captured_main_1): Use gdb::alternate_signal_stack.
1189         * gdbsupport/alt-stack.h: New file.
1190
1191 2019-11-26  Tom Tromey  <tom@tromey.com>
1192
1193         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1194         Remove comment.
1195         (save_original_signals_state, restore_original_signals_state): Use
1196         gdb_sigmask.
1197         * linux-nat.c (block_child_signals, restore_child_signals_mask)
1198         (_initialize_linux_nat): Use gdb_sigmask.
1199         * guile/guile.c (_initialize_guile): Use block_signals.
1200         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1201         * gdbsupport/gdb-sigmask.h: New file.
1202         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1203         * cp-support.c (gdb_demangle): Use gdb_sigmask.
1204         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1205         pthread_sigmask.
1206         * configure, config.in: Rebuild.
1207         * gdbsupport/block-signals.h: New file.
1208
1209 2019-11-26  Tom Tromey  <tom@tromey.com>
1210
1211         * acinclude.m4: Include ax_pthread.m4.
1212         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1213         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1214         (CLIBS): Use PTHREAD_LIBS.
1215         (aclocal_m4_deps): Add ax_pthread.m4.
1216         * config.in, configure: Rebuild.
1217         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1218
1219 2019-11-26  Tom Tromey  <tom@tromey.com>
1220
1221         * symtab.h (struct minimal_symbol) <name_set>: New member.
1222         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1223         Don't call symbol_set_names.
1224         (minimal_symbol_reader::install): Call symbol_set_names.
1225
1226 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1227
1228         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1229         restore_active_ext_lang, as GIL is needed for (indirectly)
1230         called PyOS_InterruptOccurred.
1231
1232 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1233
1234         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1235         definition.
1236
1237 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1238
1239         * remote-sim.c (simulator_command): Make static, remove
1240         declaration.
1241
1242 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1243
1244         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1245         static.
1246         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1247         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1248         (main): Likewise.
1249         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1250         (main): Likewise.
1251         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1252         (main): Likewise.
1253         * unittests/basic_string_view/element_access/char/1.cc (test01):
1254         Likewise.
1255         (main): Likewise.
1256         * unittests/basic_string_view/element_access/char/empty.cc (main):
1257         Likewise.
1258         * unittests/basic_string_view/element_access/char/front_back.cc
1259         (test01): Likewise.
1260         (main): Likewise.
1261         * unittests/basic_string_view/inserters/char/2.cc (test05):
1262         Likewise.
1263         (main): Likewise.
1264         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1265         (test01): Likewise.
1266         (main): Likewise.
1267         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1268         (test01): Likewise.
1269         (main): Likewise.
1270         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1271         Likewise.
1272         * unittests/basic_string_view/operations/compare/char/1.cc
1273         (test01): Likewise.
1274         (main): Likewise.
1275         * unittests/basic_string_view/operations/compare/char/13650.cc
1276         (test01): Likewise.
1277         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1278         Likewise.
1279         (main): Likewise.
1280         * unittests/basic_string_view/operations/data/char/1.cc (test01):
1281         Likewise.
1282         (main): Likewise.
1283         * unittests/basic_string_view/operations/find/char/1.cc (test01):
1284         Likewise.
1285         (main): Likewise.
1286         * unittests/basic_string_view/operations/find/char/2.cc (test02):
1287         Likewise.
1288         (main): Likewise.
1289         * unittests/basic_string_view/operations/find/char/3.cc (test03):
1290         Likewise.
1291         (main): Likewise.
1292         * unittests/basic_string_view/operations/find/char/4.cc (main):
1293         Likewise.
1294         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1295         Likewise.
1296         (main): Likewise.
1297         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1298         Likewise.
1299         (main): Likewise.
1300         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1301         Likewise.
1302         (main): Likewise.
1303         * unittests/basic_string_view/operations/substr/char/1.cc
1304         (test01): Likewise.
1305         (main): Likewise.
1306         * unittests/basic_string_view/operators/char/2.cc (main):
1307         Likewise.
1308         * unittests/optional/assignment/1.cc (test): Likewise.
1309         * unittests/optional/assignment/2.cc (test): Likewise.
1310         * unittests/optional/assignment/3.cc (test): Likewise.
1311         * unittests/optional/assignment/4.cc (test): Likewise.
1312         * unittests/optional/assignment/5.cc (test): Likewise.
1313         * unittests/optional/assignment/6.cc (test): Likewise.
1314         * unittests/optional/assignment/7.cc (test): Likewise.
1315         * unittests/optional/cons/copy.cc (test): Likewise.
1316         * unittests/optional/cons/default.cc (test): Likewise.
1317         * unittests/optional/cons/move.cc (test): Likewise.
1318         * unittests/optional/cons/value.cc (test): Likewise.
1319         * unittests/optional/in_place.cc (test): Likewise.
1320         * unittests/optional/observers/1.cc (test): Likewise.
1321         * unittests/optional/observers/2.cc (test): Likewise.
1322
1323 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1324
1325         * tui-win.h (tui_set_var_cmd): Remove.
1326         * tui-win.c (tui_set_var_cmd): Make static.
1327
1328 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1329
1330         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1331         rbreak_command_wrapper): Remove.
1332         * symtab.c (rbreak_command_wrapper): Remove.
1333
1334 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1335
1336         * inferior.h (info_terminal_command): Remove declaration.
1337         * inflow.c (info_terminal_command): Make static.
1338
1339 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1340
1341         * inferior.c (exit_inferior_silent): Remove.
1342
1343 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1344
1345         * dictionary.c (dict_empty, mdict_empty): Remove.
1346         * dictionary.c (mdict_empty): Remove.
1347
1348 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1349
1350          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1351          (arc_insn_get_memory_offset): Likewise.
1352          (arc_insn_dump): Likewise.
1353          * cp-support.c (test_cp_symbol_name_matches): Likewise.
1354          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1355          * dictionary.c (dict_iterator_next): Likewise.
1356          (dict_iter_match_first): Likewise.
1357          (dict_iter_match_next): Likewise.
1358          * f-lang.c (evaluate_subexp_f): Likewise.
1359          * hppa-tdep.c (hppa_read_pc): Likewise.
1360          * i386-tdep.c (i386_floatformat_for_type): Likewise.
1361          * parse.c (write_exp_elt_msym): Likewise.
1362          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1363          * remote.c (remote_packet_size): Likewise.
1364          (remote_notif_stop_parse): Likewise.
1365          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1366          * s12z-tdep.c (s12z_disassemble_info): Likewise.
1367          * source.c (prepare_path_for_appending): Likewise.
1368          * sparc64-linux-tdep.c
1369          (sparc64_linux_handle_segmentation_fault); Likewise.
1370          * stack.c (frame_selection_by_function_completer): Likewise.
1371
1372 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1373
1374         * completer.c (set_gdb_completion_word_break_characters):
1375         Remove.
1376
1377 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1378
1379         * dwarf-index-write.c: Include dwarf-index-write.h.
1380         * mi/mi-interp.c: Include mi/mi-interp.h.
1381
1382 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1383
1384         * aarch32-tdep.c: Include aarch32-tdep.h.
1385         * aarch32-tdep.h: Forward-declare struct target_desc.
1386
1387 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1388
1389         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1390         strerror.
1391         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1392         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1393
1394 2019-11-25  Tom de Vries  <tdevries@suse.de>
1395
1396         * contrib/words.sh: Add -c option.
1397
1398 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
1399
1400         * solib.c (solib_find_1): Change int to bool.
1401         (exec_file_find): Change int to bool.
1402         (solib_find): Change int to bool.
1403         (solib_read_symbols): Change int to bool.
1404         (solib_used): Change int to bool.
1405         (solib_add): Change int to bool.
1406         (info_sharedlibrary_command): Change int to bool.
1407         (solib_contains_address_p): Change int to bool.
1408         (solib_keep_data_in_core): Change int to bool.
1409         (in_solib_dynsym_resolve_code): Change int to bool.
1410         (reload_shared_libraries_1): Change int to bool.
1411         (gdb_sysroot_changed): Change int to bool.
1412         * solib.h (solib_read_symbols): Change int to bool.
1413         (solib_contains_address_p): Change int to bool.
1414         (solib_keep_data_in_core): Change int to bool.
1415         (in_solib_dynsym_resolve_code): Change int to bool.
1416         (libpthread_name_p): Change int to bool.
1417
1418 2019-11-25  Luis Machado  <luis.machado@linaro.org>
1419
1420         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1421         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1422         (remote_packet_max_chars): New static global.
1423         (show_remote_packet_max_chars): New function.
1424         (remote_target::putpkt_binary): Adjust to use new
1425         remote_packet_max_chars option.
1426         (remote_target::getpkt_or_notif_sane_1): Likewise.
1427         (_initialize_remote): Register new remote-packet-max-chars option.
1428
1429 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
1430
1431         * m68k-linux-nat.c: Include gdbarch.h.
1432
1433 2019-11-24  Tom Tromey  <tom@tromey.com>
1434
1435         * symfile.c (read_symbols): Update.
1436         * psymtab.c (require_partial_symbols): Change type of "verbose" to
1437         bool.
1438         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1439         (psym_lookup_symbol, psym_find_last_source_symtab)
1440         (psym_forget_cached_source_info, psym_print_stats)
1441         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1442         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1443         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1444         (psym_find_compunit_symtab_by_address)
1445         (maintenance_print_psymbols, maintenance_info_psymtabs)
1446         (maintenance_check_psymtabs): Update.
1447         * psymtab.h (require_partial_symbols): Change type of "verbose" to
1448         bool.
1449
1450 2019-11-22  Tom Tromey  <tom@tromey.com>
1451
1452         * observable.h: Update comments.
1453
1454 2019-11-22  Tom Tromey  <tromey@adacore.com>
1455
1456         * ada-tasks.c (ada_task_is_alive): Make parameter const.
1457         (print_ada_task_info): Don't try to fetch thread id if task is not
1458         alive.
1459
1460 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1461
1462         * ada-exp.y: Update.
1463         * ada-lang.c (sort_choices): Update.
1464         (ada_print_symbol_signature): Update.
1465         (resolve_subexp): Update.
1466         (ada_parse_renaming): Update.
1467         (ada_read_renaming_var_value): Update.
1468         (lesseq_defined_than): Update.
1469         (remove_extra_symbols): Update.
1470         (remove_irrelevant_renamings): Update.
1471         (ada_add_block_symbols): Update.
1472         (ada_collect_symbol_completion_matches): Update.
1473         (ada_is_renaming_symbol): Update.
1474         (aggregate_assign_from_choices): Update.
1475         (ada_evaluate_subexp): Update.
1476         (ada_has_this_exception_support): Update.
1477         (ada_is_non_standard_exception_sym): Update.
1478         (ada_add_exceptions_from_frame): Update.
1479         (ada_add_global_exceptions): Update.
1480         (ada_print_subexp): Update.
1481         * ax-gdb.c (gen_var_ref): Update.
1482         (gen_maybe_namespace_elt): Update.
1483         (gen_expr_for_cast): Update.
1484         (gen_expr): Update.
1485         * block.h: Update.
1486         * blockframe.c (find_pc_partial_function): Update.
1487         * breakpoint.c (print_breakpoint_location): Update.
1488         (update_static_tracepoint): Update.
1489         * btrace.c (ftrace_print_function_name): Update.
1490         (ftrace_function_switched): Update.
1491         * buildsym.c (find_symbol_in_list): Update.
1492         * c-exp.y: Update.
1493         * c-typeprint.c (c_print_typedef): Update.
1494         (c_type_print_template_args): Update.
1495         * cli/cli-cmds.c (edit_command): Update.
1496         (list_command): Update.
1497         (print_sal_location): Update.
1498         * coffread.c (patch_opaque_types): Update.
1499         (process_coff_symbol): Update.
1500         (coff_read_enum_type): Update.
1501         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1502         (convert_one_symbol): Update.
1503         (hash_symname): Update.
1504         (eq_symname): Update.
1505         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1506         * compile/compile-cplus-types.c (debug_print_scope): Update.
1507         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1508         * compile/compile-object-load.c (get_out_value_type): Update.
1509         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1510         (search_symbol_list): Update.
1511         (cp_lookup_symbol_imports_or_template): Update.
1512         * cp-support.c (overload_list_add_symbol): Update.
1513         * ctfread.c (psymtab_to_symtab): Update.
1514         * dbxread.c (cp_set_block_scope): Update.
1515         * dictionary.c (iter_match_first_hashed): Update.
1516         (iter_match_next_hashed): Update.
1517         (insert_symbol_hashed): Update.
1518         (iter_match_next_linear): Update.
1519         * dictionary.h: Update.
1520         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1521         (locexpr_describe_location_piece): Update.
1522         (locexpr_describe_location_1): Update.
1523         (locexpr_generate_c_location): Update.
1524         (loclist_describe_location): Update.
1525         (loclist_generate_c_location): Update.
1526         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1527         (read_func_scope): Update.
1528         (process_enumeration_scope): Update.
1529         (new_symbol): Update.
1530         (dwarf2_const_value): Update.
1531         (dwarf2_symbol_mark_computed): Update.
1532         * eval.c (evaluate_funcall): Update.
1533         (evaluate_subexp_standard): Update.
1534         * expprint.c (print_subexp_standard): Update.
1535         (dump_subexp_body_standard): Update.
1536         * f-valprint.c (info_common_command_for_block): Update.
1537         * findvar.c (get_hosting_frame): Update.
1538         (default_read_var_value): Update.
1539         * go-lang.c (go_symbol_package_name): Update.
1540         * guile/scm-block.c (bkscm_print_block_smob): Update.
1541         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1542         (gdbscm_symbol_name): Update.
1543         (gdbscm_symbol_linkage_name): Update.
1544         (gdbscm_symbol_print_name): Update.
1545         * infcall.c (get_function_name): Update.
1546         * infcmd.c (jump_command): Update.
1547         (finish_command): Update.
1548         * infrun.c (insert_exception_resume_breakpoint): Update.
1549         * linespec.c (canonicalize_linespec): Update.
1550         (create_sals_line_offset): Update.
1551         (convert_linespec_to_sals): Update.
1552         (complete_label): Update.
1553         (find_label_symbols_in_block): Update.
1554         * m2-typeprint.c (m2_print_typedef): Update.
1555         * mdebugread.c (mdebug_reg_to_regnum): Update.
1556         (parse_symbol): Update.
1557         (mylookup_symbol): Update.
1558         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1559         (list_args_or_locals): Update.
1560         * objc-lang.c (compare_selectors): Update.
1561         (info_selectors_command): Update.
1562         (compare_classes): Update.
1563         (info_classes_command): Update.
1564         (find_imps): Update.
1565         * p-typeprint.c (pascal_print_typedef): Update.
1566         * printcmd.c (build_address_symbolic): Update.
1567         (info_address_command): Update.
1568         (print_variable_and_value): Update.
1569         * python/py-framefilter.c (extract_sym): Update.
1570         (py_print_single_arg): Update.
1571         * python/py-symbol.c (sympy_str): Update.
1572         (sympy_get_name): Update.
1573         (sympy_get_linkage_name): Update.
1574         * python/python.c (gdbpy_rbreak): Update.
1575         * record-btrace.c (btrace_get_bfun_name): Update.
1576         (btrace_call_history): Update.
1577         * rust-lang.c (rust_print_typedef): Update.
1578         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1579         * stabsread.c (stab_reg_to_regnum): Update.
1580         (define_symbol): Update.
1581         (read_enum_type): Update.
1582         (common_block_end): Update.
1583         (cleanup_undefined_types_1): Update.
1584         (scan_file_globals): Update.
1585         * stack.c (print_frame_arg): Update.
1586         (print_frame_args): Update.
1587         (find_frame_funname): Update.
1588         (info_frame_command_core): Update.
1589         (iterate_over_block_locals): Update.
1590         (print_block_frame_labels): Update.
1591         (do_print_variable_and_value): Update.
1592         (iterate_over_block_arg_vars): Update.
1593         (return_command): Update.
1594         * symmisc.c (dump_symtab_1): Update.
1595         (print_symbol): Update.
1596         * symtab.c (eq_symbol_entry): Update.
1597         (symbol_cache_dump): Update.
1598         (lookup_language_this): Update.
1599         (find_pc_sect_line): Update.
1600         (skip_prologue_sal): Update.
1601         (symbol_search::compare_search_syms): Update.
1602         (treg_matches_sym_type_name): Update.
1603         (search_symbols): Update.
1604         (print_symbol_info): Update.
1605         (rbreak_command): Update.
1606         (completion_list_add_symbol): Update.
1607         (find_gnu_ifunc): Update.
1608         (get_symbol_address): Update.
1609         (search_module_symbols): Update.
1610         (info_module_subcommand): Update.
1611         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1612         (SYMBOL_LINKAGE_NAME): Remove.
1613         (SYMBOL_DEMANGLED_NAME): Remove.
1614         (SYMBOL_PRINT_NAME): Remove.
1615         (SYMBOL_SEARCH_NAME): Remove.
1616         * tracepoint.c (set_traceframe_context): Update.
1617         (validate_actionline): Update.
1618         (collection_list::collect_symbol): Update.
1619         (encode_actions_1): Update.
1620         (info_scope_command): Update.
1621         (print_one_static_tracepoint_marker): Update.
1622         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1623         * valops.c (address_of_variable): Update.
1624         (find_overload_match): Update.
1625         (find_oload_champ): Update.
1626
1627 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1628
1629         * ada-lang.c (ada_lookup_simple_minsym): Update.
1630         (ada_collect_symbol_completion_matches): Update.
1631         * ada-tasks.c (read_atcb): Update.
1632         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1633         (amd64_windows_skip_trampoline_code): Update.
1634         * arm-tdep.c (skip_prologue_function): Update.
1635         (arm_skip_stack_protector): Update.
1636         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1637         (arm_wince_skip_main_prologue): Update.
1638         * ax-gdb.c (gen_expr): Update.
1639         * block.c (call_site_for_pc): Update.
1640         * blockframe.c (find_pc_partial_function): Update.
1641         * breakpoint.c (set_breakpoint_location_function): Update.
1642         * btrace.c (ftrace_print_function_name): Update.
1643         (ftrace_function_switched): Update.
1644         * c-valprint.c (print_unpacked_pointer): Update.
1645         * coffread.c (coff_symfile_read): Update.
1646         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1647         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1648         * dwarf-index-write.c (write_psymbols): Update.
1649         * dwarf2loc.c (call_site_to_target_addr): Update.
1650         (func_verify_no_selftailcall): Update.
1651         (tailcall_dump): Update.
1652         (call_site_find_chain_1): Update.
1653         (dwarf_expr_reg_to_entry_parameter): Update.
1654         * elfread.c (elf_gnu_ifunc_record_cache): Update.
1655         * eval.c (evaluate_funcall): Update.
1656         (evaluate_subexp_standard): Update.
1657         (evaluate_subexp_for_sizeof): Update.
1658         * expprint.c (print_subexp_standard): Update.
1659         (dump_subexp_body_standard): Update.
1660         * frame.c (get_prev_frame_always_1): Update.
1661         * frv-tdep.c (frv_skip_main_prologue): Update.
1662         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1663         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1664         (gnuv3_get_typename_from_type_info): Update.
1665         (gnuv3_skip_trampoline): Update.
1666         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1667         * i386-tdep.c (i386_skip_main_prologue): Update.
1668         (i386_pe_skip_trampoline_code): Update.
1669         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1670         * infcall.c (get_function_name): Update.
1671         * linespec.c (minsym_found): Update.
1672         * linux-fork.c (info_checkpoints_command): Update.
1673         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1674         (m32c_m16c_pointer_to_address): Update.
1675         * maint.c (maintenance_translate_address): Update.
1676         * minsyms.c (add_minsym_to_hash_table): Update.
1677         (add_minsym_to_demangled_hash_table): Update.
1678         (lookup_minimal_symbol_mangled): Update.
1679         (lookup_minimal_symbol_demangled): Update.
1680         (lookup_minimal_symbol_linkage): Update.
1681         (lookup_minimal_symbol_text): Update.
1682         (lookup_minimal_symbol_by_pc_name): Update.
1683         (minimal_symbol_is_less_than): Update.
1684         (compact_minimal_symbols): Update.
1685         (build_minimal_symbol_hash_tables): Update.
1686         (find_solib_trampoline_target): Update.
1687         * mips-tdep.c (mips_stub_frame_sniffer): Update.
1688         (mips_skip_pic_trampoline_code): Update.
1689         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1690         * objc-lang.c (info_selectors_command): Update.
1691         (info_classes_command): Update.
1692         (find_methods): Update.
1693         (find_imps): Update.
1694         * p-valprint.c (pascal_val_print): Update.
1695         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1696         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1697         * printcmd.c (build_address_symbolic): Update.
1698         (info_symbol_command): Update.
1699         * psymtab.c (psymbol_name_matches): Update.
1700         (match_partial_symbol): Update.
1701         (lookup_partial_symbol): Update.
1702         (print_partial_symbols): Update.
1703         (sort_pst_symbols): Update.
1704         (maintenance_check_psymtabs): Update.
1705         * python/py-framefilter.c (py_print_frame): Update.
1706         * python/python.c (gdbpy_rbreak): Update.
1707         * record-btrace.c (btrace_get_bfun_name): Update.
1708         (btrace_call_history): Update.
1709         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1710         (rs6000_skip_trampoline_code): Update.
1711         * sol-thread.c (info_cb): Update.
1712         * stabsread.c (scan_file_globals): Update.
1713         * stack.c (find_frame_funname): Update.
1714         (info_frame_command_core): Update.
1715         * symmisc.c (dump_msymbols): Update.
1716         * symtab.c (symbol_natural_name): Rename to..,
1717         (general_symbol_info::natural_name): ...this.
1718         (symbol_demangled_name): Rename to...
1719         (general_symbol_info::demangled_name): ...this.
1720         (symbol_search_name): Rename to...
1721         (general_symbol_info::search_name): ...this.
1722         (symbol_matches_search_name): Update.
1723         (find_pc_sect_line): Update.
1724         (skip_prologue_sal): Update.
1725         (search_symbols): Update.
1726         (print_msymbol_info): Update.
1727         (rbreak_command): Update.
1728         (completion_list_add_msymbol): Update.
1729         (completion_list_objc_symbol): Update.
1730         (get_msymbol_address): Update.
1731         * symtab.h (struct general_symbol_info): Add member functions
1732         natural_name (), linkage_name (), print_name (), demangled_name (),
1733         and search_name ().
1734         (SYMBOL_NATURAL_NAME): Update.
1735         (symbol_natural_name): Move to a member function on general_symbol_info.
1736         (SYMBOL_DEMANGLED_NAME): Update.
1737         (symbol_demangled_name): Move to a member function on
1738         general_symbol_info.
1739         (SYMBOL_SEARCH_NAME): Update.
1740         (symbol_search_name): Move to a member function on general_symbol_info.
1741         (MSYMBOL_NATURAL_NAME): Remove.
1742         (MSYMBOL_LINKAGE_NAME): Remove.
1743         (MSYMBOL_PRINT_NAME): Remove.
1744         (MSYMBOL_DEMANGLED_NAME): Remove.
1745         (MSYMBOL_SEARCH_NAME): Remove.
1746         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1747
1748 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1749
1750         * symtab.c (create_demangled_names_hash): Use per_bfd->
1751         minimal_symbol_count for computing the initial size, if greater
1752         than our default size.
1753
1754 2019-11-22  Tom de Vries  <tdevries@suse.de>
1755
1756         * contrib/words.sh: Improve words extraction.
1757
1758 2019-11-22  Tom de Vries  <tdevries@suse.de>
1759
1760         * contrib/words.sh: Combine sed invocations.
1761
1762 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
1763
1764         * Makefile.in: Update.
1765         * demangle.c: Rename to...
1766         * gdb-demangle.c: ..this.
1767         (is_cplus_marker): Change return type to bool.
1768         (_initialize_demangler): Rename to...
1769         (_initialize_gdb_demangle): ...this.
1770         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1771         * symtab.h (demangle): Remove declaration; instead include
1772         gdb-demangle.h.
1773
1774 2019-11-21  Tom Tromey  <tromey@adacore.com>
1775
1776         * gdbsupport/format.c (format_pieces): Parse %I64d.
1777         * unittests/format_pieces-selftests.c (test_windows_formats): New
1778         function.
1779         (run_tests): Call it.
1780
1781 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
1782
1783         Byte reverse display of variables with DW_END_big, DW_END_little
1784         (DW_AT_endianity) dwarf attributes if different than the native
1785         byte order.
1786         * ada-lang.c (ada_value_binop):
1787         Use type_byte_order instead of gdbarch_byte_order.
1788         * ada-valprint.c (printstr):
1789         (ada_val_print_string):
1790         * ada-lang.c (value_pointer):
1791         (ada_value_binop):
1792         Use type_byte_order instead of gdbarch_byte_order.
1793         * c-lang.c (c_get_string):
1794         Use type_byte_order instead of gdbarch_byte_order.
1795         * c-valprint.c (c_val_print_array):
1796         Use type_byte_order instead of gdbarch_byte_order.
1797         * cp-valprint.c (cp_print_class_member):
1798         Use type_byte_order instead of gdbarch_byte_order.
1799         * dwarf2loc.c (rw_pieced_value):
1800         Use type_byte_order instead of gdbarch_byte_order.
1801         * dwarf2read.c (read_base_type): Handle DW_END_big,
1802         DW_END_little
1803         * f-lang.c (f_get_encoding):
1804         Use type_byte_order instead of gdbarch_byte_order.
1805         * findvar.c (default_read_var_value):
1806         Use type_byte_order instead of gdbarch_byte_order.
1807         * gdbtypes.c (check_types_equal):
1808         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1809         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1810         and TYPE_ENDIANITY_LITTLE if set.
1811         (type_byte_order): new function.
1812         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1813         (struct main_type) <flag_endianity_not_default>:
1814         New field.
1815         (type_byte_order): New function.
1816         * infcmd.c (default_print_one_register_info):
1817         Use type_byte_order instead of gdbarch_byte_order.
1818         * p-lang.c (pascal_printstr):
1819         Use type_byte_order instead of gdbarch_byte_order.
1820         * p-valprint.c (pascal_val_print):
1821         Use type_byte_order instead of gdbarch_byte_order.
1822         * printcmd.c (print_scalar_formatted):
1823         Use type_byte_order instead of gdbarch_byte_order.
1824         * solib-darwin.c (darwin_current_sos):
1825         Use type_byte_order instead of gdbarch_byte_order.
1826         * solib-svr4.c (solib_svr4_r_ldsomap):
1827         Use type_byte_order instead of gdbarch_byte_order.
1828         * stap-probe.c (stap_modify_semaphore):
1829         Use type_byte_order instead of gdbarch_byte_order.
1830         * target-float.c (target_float_same_format_p):
1831         Use type_byte_order instead of gdbarch_byte_order.
1832         * valarith.c (scalar_binop):
1833         (value_bit_index):
1834         Use type_byte_order instead of gdbarch_byte_order.
1835         * valops.c (value_cast):
1836         Use type_byte_order instead of gdbarch_byte_order.
1837         * valprint.c (generic_emit_char):
1838         (generic_printstr):
1839         (val_print_string):
1840         Use type_byte_order instead of gdbarch_byte_order.
1841         * value.c (unpack_long):
1842         (unpack_bits_as_long):
1843         (unpack_value_bitfield):
1844         (modify_field):
1845         (pack_long):
1846         (pack_unsigned_long):
1847         Use type_byte_order instead of gdbarch_byte_order.
1848         * findvar.c (unsigned_pointer_to_address):
1849         (signed_pointer_to_address):
1850         (unsigned_address_to_pointer):
1851         (address_to_signed_pointer):
1852         (default_read_var_value):
1853         (default_value_from_register):
1854         Use type_byte_order instead of gdbarch_byte_order.
1855         * gnu-v3-abi.c (gnuv3_make_method_ptr):
1856         Use type_byte_order instead of gdbarch_byte_order.
1857         * riscv-tdep.c (riscv_print_one_register_info):
1858         Use type_byte_order instead of gdbarch_byte_order.
1859
1860 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
1861
1862         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1863         (current_ui_gdb_stdin_ptr): Likewise.
1864         (current_ui_gdb_stderr_ptr): Likewise.
1865         (current_ui_gdb_stdlog_ptr): Likewise.
1866         (current_ui_current_uiout_ptr): Likewise.
1867         (gen_ret_current_ui_field_ptr): Remove.
1868
1869 2019-11-21  Tom de Vries  <tdevries@suse.de>
1870
1871         PR gdb/24956
1872         * cli/cli-script.c (execute_control_command): Only switch to
1873         INTERP_CONSOLE's ui_out when INTERP_MI is active.
1874
1875 2019-11-19  Tom Tromey  <tom@tromey.com>
1876
1877         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1878         Now static.  Change type of "name".
1879         (tui_set_win_height_command): Don't copy "arg".
1880         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1881         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1882
1883 2019-11-19  Ali Tamur <tamur@google.com>
1884
1885         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1886         "if (attr != nullptr)".
1887         (dwarf2_find_base_address): Likewise.
1888         (dwarf2_build_include_psymtabs): Likewise.
1889         (read_cutu_die_from_dwo): Likewise.
1890         (read_func_scope): Likewise.
1891         (read_call_site_scope): Likewise.
1892         (dwarf2_get_pc_bounds): Likewise.
1893         (dwarf2_record_block_ranges): Likewise.
1894         (dwarf2_add_field): Likewise.
1895         (dwarf2_add_member_fn): Likewise.
1896         (read_structure_type): Likewise.
1897         (read_enumeration_type): Likewise.
1898         (read_array_type): Likewise.
1899         (read_array_order): Likewise.
1900         (read_set_type): Likewise.
1901         (read_common_block): Likewise.
1902         (read_tag_reference_type): Likewise.
1903         (read_tag_string_type): Likewise.
1904         (read_subroutine_type): Likewise.
1905         (read_base_type): Likewise.
1906         (read_subrange_type): Likewise.
1907         (new_symbol): Likewise.
1908         (prepare_one_comp_unit): Likewise.
1909
1910 2019-11-19  Tom Tromey  <tromey@adacore.com>
1911
1912         * windows-nat.c (windows_nat_target::attach): Include GetLastError
1913         result in error when DebugActiveProcess fails.
1914
1915 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
1916             Pedro Alves  <palves@redhat.com>
1917
1918         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1919         * target.c (target_stack::push): Call 'unpush' if there's a
1920         target on top of the stack.
1921
1922 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1923
1924         * python/py-block.c (blpy_dealloc): Call tp_free.
1925         (blpy_block_syms_dealloc): Likewise.
1926         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1927         * python/py-inferior.c (infpy_dealloc): Likewise.
1928         * python/py-lazy-string.c (stpy_dealloc): Likewise.
1929         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1930         * python/py-symbol.c (sympy_dealloc): Likewise.
1931         * python/py-symtab.c (stpy_dealloc): Likewise.
1932         * python/py-type.c (typy_iterator_dealloc): Likewise.
1933
1934 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
1935
1936         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1937         constructor instead of using a class initializer.
1938
1939 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1940
1941         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1942         * configure: Regenerate.
1943         * configure.ac: Don't source common.host.
1944         * gdbsupport/common.host: Remove.
1945         * gdbsupport/mingw-strerror.c: Remove.
1946         * gdbsupport/posix-strerror.c: Rename to...
1947         * gdbsupport/safe-strerror.c: ...this.
1948
1949 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1950
1951         * maint.c (scoped_command_stats::print_time): Use localtime_r
1952         instead of localtime (provided through gnulib if necessary).
1953         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1954         of ctime.
1955
1956 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1957
1958         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1959         avoid compile errors.
1960
1961 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1962
1963         * config.in: Regenerate.
1964         * configure: Regenerate.
1965         * gdbsupport/common.m4: No longer check for strerror_r.
1966         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1967         POSIX version of strerror_r, now that gnulib provides it if
1968         necessary.
1969
1970 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
1971
1972         * README (`configure' options): Update.
1973
1974 2019-11-14  Tom Tromey  <tromey@adacore.com>
1975
1976         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1977         expected type for the RHS if the LHS is a convenience variable.
1978
1979 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
1980
1981         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1982         Provide explicit default and copy constructor.
1983
1984 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1985
1986         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1987         only call Py_INCREF (newbp) in the bppy_pending_object case.
1988
1989 2019-11-13  Tom Tromey  <tromey@adacore.com>
1990
1991         PR build/25182:
1992         * psympriv.h (partial_symbol): Remove static assert.
1993         * symtab.h (general_symbol_info, symbol): Remove static assert.
1994
1995 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1996
1997         * gdbsupport/format.c (format_pieces::format_pieces): Support
1998         printf 'z' size modifier.
1999         * gdbsupport/format.h (enum argclass): Add size_t_arg.
2000         * printcmd.c (ui_printf):  Handle size_t_arg.
2001         * ui-out.c (ui_out::vmessage): Likewise.
2002         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2003         function.
2004         (run_tests): Call test_format_int_sizes.
2005
2006 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
2007
2008         * ada-exp.y (write_ambiguous_var): Update.
2009         * buildsym.c (add_symbol_to_list): Update.
2010         * dwarf2read.c (read_variable): Update.
2011         (new_symbol): Update.
2012         * jit.c (finalize_symtab): Update.
2013         * language.c (language_alloc_type_symbol): Update.
2014         * symtab.c (fixup_symbol_section): Update.
2015         (initialize_objfile_symbol_1): Move code to...
2016         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2017         (allocate_symbol): Update.
2018         (allocate_template_symbol): Update.
2019         (get_symbol_address): Update.
2020         * symtab.h (struct symbol): Inherit from general_symbol_info instead
2021         of having as a field, and add a constructor.
2022         (SYMBOL_VALUE): Update.
2023         (SYMBOL_VALUE_ADDRESS): Update.
2024         (SET_SYMBOL_VALUE_ADDRESS): Update.
2025         (SYMBOL_VALUE_BYTES): Update.
2026         (SYMBOL_VALUE_COMMON_BLOCK): Update.
2027         (SYMBOL_BLOCK_VALUE): Update.
2028         (SYMBOL_VALUE_CHAIN): Update.
2029         (SYMBOL_LANGUAGE): Update.
2030         (SYMBOL_SECTION): Update.
2031         (SYMBOL_OBJ_SECTION): Update.
2032         (SYMBOL_SET_LANGUAGE): Update.
2033         (SYMBOL_SET_LINKAGE_NAME): Update.
2034         (SYMBOL_SET_NAMES): Update.
2035         (SYMBOL_NATURAL_NAME): Update.
2036         (SYMBOL_LINKAGE_NAME): Update.
2037         (SYMBOL_DEMANGLED_NAME): Update.
2038         (SYMBOL_SEARCH_NAME): Update.
2039         (SYMBOL_MATCHES_SEARCH_NAME): Update.
2040         (struct symbol): Update.
2041         (struct template_symbol): Update.
2042         (struct rust_vtable_symbol): Update.
2043         * xcoffread.c (SYMBOL_DUP): Update.
2044
2045 2019-11-12  Tom Tromey  <tom@tromey.com>
2046
2047         * tui/tui-layout.c (show_layout): Set current_layout.
2048         (show_source_disasm_command, show_data)
2049         (show_source_or_disasm_and_command): Don't set current_layout.
2050
2051 2019-11-12  Tom Tromey  <tom@tromey.com>
2052
2053         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2054
2055 2019-11-12  Tom Tromey  <tom@tromey.com>
2056
2057         * tui/tui-win.c (resize_message): New global.
2058         (show_tui_resize_message): New function.
2059         (tui_async_resize_screen): Print message if requested.
2060         (_initialize_tui_win): Add tui-resize-message setting.
2061         * NEWS: Add entry for new commands.
2062
2063 2019-11-11  Tom Tromey  <tom@tromey.com>
2064
2065         * tui/tui.c (tui_initialize_readline): Add new bindable readline
2066         functions.
2067
2068 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
2069
2070         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2071
2072 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2073
2074         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2075         function.
2076         * python/python-internal.h (gdbpy_lookup_static_symbols):
2077         Declare new function.
2078         * python/python.c (python_GdbMethods): Add
2079         gdb.lookup_static_symbols method.
2080         * NEWS: Mention gdb.lookup_static_symbols.
2081
2082 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2083
2084         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2085         static block of current object file first.  Also fix typo in
2086         header comment.
2087
2088 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2089
2090         * stack.c (set_last_displayed_sal): Delete.
2091         (last_displayed_sal_valid): Delete.
2092         (last_displayed_pspace): Delete.
2093         (last_displayed_addr): Delete.
2094         (last_displayed_symtab): Delete.
2095         (last_displayed_line): Delete.
2096         (class last_displayed_symtab_info_type): New.
2097         (last_displayed_symtab_info): New static global variable.
2098         (print_frame_info): Call methods on last_displayed_symtab_info.
2099         (clear_last_displayed_sal): Update header comment, and make use of
2100         last_displayed_symtab_info.
2101         (last_displayed_sal_is_valid): Likewise.
2102         (get_last_displayed_pspace): Likewise.
2103         (get_last_displayed_addr): Likewise.
2104         (get_last_displayed_symtab): Likewise.
2105         (get_last_displayed_line): Likewise.
2106         (get_last_displayed_sal): Likewise.
2107         * stack.h (clear_last_displayed_sal): Update header comment.
2108         (last_displayed_sal_is_valid): Likewise.
2109         (get_last_displayed_pspace): Likewise.
2110         (get_last_displayed_addr): Likewise.
2111         (get_last_displayed_symtab): Likewise.
2112         (get_last_displayed_line): Likewise.
2113         (get_last_displayed_sal): Likewise.
2114
2115 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2116
2117         * stack.c (frame_show_address): Convert return type to bool.
2118         * stack.h (frame_show_address): Likewise, and update header
2119         comment.
2120
2121 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2122
2123         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2124         * unittests/vec-utils-selftests.c: New file.
2125         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2126
2127 2019-11-10  Tom Tromey  <tom@tromey.com>
2128
2129         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2130         (tui_highlight_win): Likewise.
2131         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2132         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2133         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2134         Don't set can_highlight.
2135
2136 2019-11-10  Tom Tromey  <tom@tromey.com>
2137
2138         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2139         Remove unused declaration.
2140
2141 2019-11-08  Tom Tromey  <tromey@adacore.com>
2142
2143         * top.c (read_command_file): Update.
2144         (command_line_input): Make return type const.
2145         * python/py-gdb-readline.c: Update.
2146         * linespec.c (decode_line_2): Update.
2147         * defs.h (command_line_input): Make return type const.
2148         * cli/cli-script.c (read_next_line): Make return type const.
2149         * ada-lang.c (get_selections): Update.
2150
2151 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
2152
2153         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2154         * mi/mi-main.c (output_cores): Likewise.
2155         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2156         (linux_xfer_osdata_modules): Likewise.
2157         * remote.c (register_remote_support_xml): Likewise.
2158         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2159         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2160
2161 2019-11-06  Tom Tromey  <tom@tromey.com>
2162
2163         * tui/tui-interp.c: Don't include readline.h.
2164         * tui/tui-hooks.c: Don't include readline.h.
2165         * symmisc.c: Include tilde.h, not readline.h.
2166         * symfile.c: Include tilde.h, not readline.h.
2167         * source.c: Include tilde.h, not readline.h.
2168         * solib.c: Include tilde.h, not readline.h.
2169         * psymtab.c: Include tilde.h, not readline.h.
2170         * exec.c: Include tilde.h, not readline.h.
2171         * corelow.c: Include tilde.h, not readline.h.
2172         * cli/cli-dump.c: Include tilde.h, not readline.h.
2173         * cli/cli-cmds.c: Don't include readline.h.
2174
2175 2019-11-05  Tom Tromey  <tom@tromey.com>
2176
2177         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2178         (tui_disassemble): Set addr_size.
2179         (tui_disasm_window::set_contents): Use addr_size.
2180
2181 2019-11-05  Tom Tromey  <tom@tromey.com>
2182
2183         * rust-lang.c (rust_language_defn): Update.
2184         * python/py-value.c (valpy_string): Call c_get_string.
2185         * p-lang.c (pascal_language_defn): Update.
2186         * opencl-lang.c (opencl_language_defn): Update.
2187         * objc-lang.c (objc_language_defn): Update.
2188         * m2-lang.c (m2_language_defn): Update.
2189         * language.c (unknown_language_defn, auto_language_defn): Update.
2190         (default_get_string): Remove.
2191         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2192         * go-lang.c (go_language_defn): Update.
2193         * f-lang.c (f_language_defn): Update.
2194         * d-lang.c (d_language_defn): Update.
2195         * c-lang.c (c_language_defn, cplus_language_defn)
2196         (asm_language_defn, minimal_language_defn): Update.
2197         * ada-lang.c (ada_language_defn): Update.
2198         * language.h (struct language_defn) <la_get_string>: Remove.
2199         (LA_GET_STRING): Remove.
2200         (default_get_string): Don't declare.
2201
2202 2019-11-05  Tom Tromey  <tom@tromey.com>
2203
2204         * tui/tui-source.h (struct tui_source_window): Inline
2205         constructor.  Remove destructor.
2206         <style_changed, m_observable>: Move to superclass.
2207         * tui/tui-winsource.h (tui_copy_source_line): Declare.
2208         (struct tui_source_window_base): Move private members to end.
2209         <style_changed, m_observable>: Move from tui_source_window.
2210         * tui/tui-winsource.c (tui_copy_source_line): Move from
2211         tui-source.c.  Rename from copy_source_line.  Add special handling
2212         for negative line number.
2213         (tui_source_window_base::style_changed): Move from
2214         tui_source_window.
2215         (tui_source_window_base): Register observer.
2216         (~tui_source_window_base): New.
2217         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2218         rename.
2219         (tui_source_window::set_contents): Use tui_copy_source_line.
2220         (tui_source_window::tui_source_window): Move to tui-source.h.
2221         (tui_source_window::~tui_source_window): Remove.
2222         (tui_source_window::style_changed): Move to superclass.
2223         * tui/tui-disasm.c (tui_disassemble): Create string file with
2224         styling, when possible.  Add "addr_size" parameter.
2225         (tui_disasm_window::set_contents): Use tui_copy_source_line.
2226         Don't compute maximum size.
2227         (len_without_escapes): New function
2228
2229 2019-11-05  Tom Tromey  <tom@tromey.com>
2230
2231         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2232         std::string.
2233         * tui/tui-winsource.c (tui_show_source_line): Update.
2234         * tui/tui-source.c (tui_source_window::set_contents): Update.
2235         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2236
2237 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
2238
2239         * symtab.h (gdb_static_assert): Put && operator at the beginning
2240         of the line instead of the end.
2241
2242 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
2243
2244         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2245         and sizeof (symbol).
2246         * symtab.h: Add a static_assert for sizeof (partial_symbol).
2247
2248 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2249
2250         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2251         * configure.host: Mark *-*-solaris2.10* obsolete.
2252         * configure.tgt: Mark Solaris < 11 obsolete.
2253         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2254         Update target triplet.
2255
2256 2019-11-01  Tom Tromey  <tromey@adacore.com>
2257
2258         * utils.c (print_sys_errmsg): Simplify.
2259
2260 2019-11-01  Tom Tromey  <tromey@adacore.com>
2261
2262         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2263
2264 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
2265
2266         * configure: Regenerate.
2267         * configure.ac: Remove check for strerror_r.
2268         * gdbsupport/common.m4: Check for strerror_r.
2269
2270 2019-11-01  Luis Machado  <luis.machado@linaro.org>
2271
2272         PR gdb/25124
2273
2274         * arm-tdep.c (arm_per_objfile): Rename to ...
2275         (arm_per_bfd): ... this.
2276         (arm_objfile_data_key): Rename to ...
2277         (arm_bfd_data_key): ... this.
2278         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2279         data.
2280         (arm_record_special_symbol): Likewise.
2281
2282 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2283
2284         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2285         end.
2286         * c-typeprint.c (c_print_typedef): Likewise.
2287         * f-typeprint.c (f_print_typedef): Likewise.
2288         * m2-typeprint.c (m2_print_typedef): Likewise.
2289         * p-typeprint.c (pascal_print_typedef): Likewise.
2290         * rust-lang.c (rust_print_typedef): Likewise.
2291         * symtab.c (print_symbol_info): Print a newline after calling
2292         typedef_print.
2293
2294 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2295
2296         * symtab.c (info_module_cmdlist): New variable.
2297         (info_module_command): New function.
2298         (search_module_symbols): New function.
2299         (info_module_subcommand): New function.
2300         (struct info_modules_var_func_options): New struct.
2301         (info_modules_var_func_options_defs): New variable.
2302         (make_info_modules_var_func_options_def_group): New function.
2303         (info_module_functions_command): New function.
2304         (info_module_variables_command): New function.
2305         (info_module_var_func_command_completer): New function.
2306         (_initialize_symtab): Register new 'info module functions' and
2307         'info module variables' commands.
2308         * symtab.h (typedef symbol_search_in_module): New typedef.
2309         (search_module_symbols): Declare new function.
2310         * NEWS: Mention new commands.
2311
2312 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2313
2314         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2315         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2316         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2317         MODULES_DOMAIN.
2318         (scan_partial_symbols): Only create partial module symbols for non
2319         declarations.
2320         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2321         and MODULES_DOMAIN.
2322         * symtab.c (search_domain_name): Likewise.
2323         (search_symbols): Likewise.
2324         (print_symbol_info): Likewise.
2325         (symtab_symbol_info): Likewise.
2326         (info_modules_command): New function.
2327         (_initialize_symtab): Register 'info modules' command.
2328         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2329         * NEWS: Mention new 'info modules' command.
2330
2331 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2332
2333         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2334         and $_gdb_maint_setting_str.
2335
2336 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2337
2338         * cli/cli-cmds.c (setting_cmd, value_from_setting)
2339         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2340         (str_value_from_setting, gdb_setting_str_internal_fn)
2341         (gdb_maint_setting_str_internal_fn): New functions.
2342         (_initialize_cli_cmds): Define the new convenience functions.
2343         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2344         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2345
2346 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2347
2348         * agent.c (set_can_use_agent): When the setting is turned on,
2349         look up agent symbols if we don't have them yet.
2350         (agent_new_objfile): Don't look up agent symbols when the agent
2351         setting is off.
2352
2353 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2354
2355         * config.in: Regenerate.
2356
2357 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2358
2359         * configure: Regenerate.
2360         * configure.ac: Check for strerror_r.
2361         * gdbsupport/common-utils.h (safe_strerror): Change return value
2362         to const char * and document that this function is now threadsafe.
2363         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2364         thread_local and call strerror_r, if available.
2365         * utils.c (perror_string): Update.
2366         (print_sys_errmsg): Update.
2367
2368 2019-10-31  Luis Machado  <luis.machado@linaro.org>
2369
2370         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2371         objfile_key.
2372         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2373         objfile to fetch per-bfd data.
2374         (arm_find_exidx_entry): Likewise.
2375
2376 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2377
2378         * gdbsupport/agent.c (debug_agent): Change type to bool.
2379         (use_agent): Likewise.
2380         (all_agent_symbols_look_up): Likewise.
2381         (agent_loaded_p): Change return value to bool.
2382         (agent_look_up_symbols): Update.
2383         (agent_capability_check): Change return value to bool.
2384         * gdbsupport/agent.h (agent_loaded_p): Likewise.
2385         (debug_agent): Change type to bool.
2386         (use_agent): Likewise.
2387         (agent_capability_check): Change return value to bool.
2388
2389 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
2390
2391         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2392         (build_minimal_symbol_hash_tables): Code to clear the table moved
2393         to clear_minimal_symbol_hash_tables.
2394         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2395         when needed.
2396
2397 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2398
2399         * infcmd.c: Remove includes.
2400         * infrun.c: Remove includes.
2401
2402 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2403
2404         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2405         (grow_vect): Remove declaration.
2406         (ada_type_of_array): Remove declaration.
2407         (ada_update_initial_language): Remove declaration.
2408         (ada_fold_name): Remove declaration.
2409         (ada_fill_in_ada_prototype): Remove declaration.
2410         (user_select_syms): Remove declaration.
2411         (get_selections): Remove declaration.
2412         (ada_tag_type): Remove declaration.
2413         (ada_value_tag): Remove declaration.
2414         (ada_is_others_clause): Remove declaration.
2415         (ada_in_variant): Remove declaration.
2416         (ada_value_struct_elt): Remove declaration.
2417         (ada_attribute_name): Remove declaration.
2418         (ada_system_address_type): Remove declaration.
2419         * ada-lang.c (ada_watch_location_expression): Make static.
2420         (GROW_VECT): Move here from ada-lang.h.
2421         (grow_vect): Make static.
2422         (ada_update_initial_language): Make static.
2423         (ada_fold_name): Make static.
2424         (ada_type_of_array): Make static.
2425         (encoded_ordered_before): Move up.
2426         (sort_choices): Move up.
2427         (print_signatures): Move up.
2428         (ada_print_symbol_signature): Move up.
2429         (get_selections): Move up and make static.
2430         (user_select_syms): Move up and make static.
2431         (ada_value_struct_elt): Move up and make static.
2432         (ada_tag_type): Make static.
2433         (ada_value_tag): Make static.
2434         (ada_is_others_clause): Make static.
2435         (ada_in_variant): Make static.
2436         (ada_attribute_name): Make static.
2437
2438 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2439
2440         * ada-lang.c: Remove includes.
2441         * ada-typeprint.c: Remove includes.
2442         * ada-valprint.c: Remove includes.
2443
2444 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
2445
2446         * addrmap.c: Add static assertions of type size, moved from
2447         _initialize_addrmap.
2448         (_initialize_addrmap): Remove.
2449
2450 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2451
2452         * coffread.c (record_minimal_symbol): Update.
2453         (process_coff_symbol): Update.
2454         * dbxread.c (read_dbx_symtab): Update.
2455         * dwarf2read.c (add_partial_symbol): Update.
2456         (fixup_go_packaging): Update.
2457         (load_partial_dies): Update.
2458         (new_symbol): Update.
2459         * elfread.c (record_minimal_symbol): Change signature to use
2460         gdb::string_view instead of name+len.
2461         (elf_symtab_read): Update.
2462         (elf_rel_plt_read): Update.
2463         * mdebugread.c (parse_partial_symbols): Update.
2464         (handle_psymbol_enumerators): Update.
2465         (new_symbol): Update.
2466         * minsyms.c (minimal_symbol_reader::record_full): Change signature
2467         to use gdb::string_view instead of name+len.
2468         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2469         * psympriv.h (add_psymbol_to_list): Likewise.
2470         * psymtab.c (add_psymbol_to_bcache): Likewise.
2471         (add_psymbol_to_list): Likewise.
2472         * stabsread.c (define_symbol): Update.
2473         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2474         * symtab.h (SYMBOL_SET_NAMES): Likewise.
2475         (symbol_set_names): Likewise.
2476         * xcoffread.c (scan_xcoff_symtab): Update.
2477
2478 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2479
2480         * symtab.h (symbol_set_names): Document that copy_name must be
2481         set to true for non-nullterminated strings.
2482         * symtab.c (symbol_set_names): Only make a nullterminated copy of
2483         linkage_name if the entry was not found and we need to demangle.
2484
2485 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2486
2487         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2488         * dwarf2-frame.c (bsearch_fde_cmp): Update.
2489         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2490         * gdbsupport/gdb_binary_search.h: New file.
2491
2492 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2493
2494         * NEWS: Mention new --with-system-gdbinit-dir option.
2495         * config.in: Regenerate.
2496         * configure: Regenerate.
2497         * configure.ac: Add new option --with-system-gdbinit-dir.
2498         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2499         for a ".gdb" suffix.
2500         * main.c (get_init_files): Change system_gdbinit argument to
2501         a vector and return the files in SYSTEM_GDBINIT_DIR in
2502         addition to SYSTEM_GDBINIT.
2503         (captured_main_1): Update.
2504         (print_gdb_help): Update.
2505         * top.c (print_gdb_configuration): Also print the value of
2506         SYSTEM_GDBINIT_DIR.
2507
2508 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
2509
2510         * gdbsupport/common-utils.h (startswith): Add an overloaded version
2511         that takes gdb::string_view arguments.
2512
2513 2019-10-26  Tom de Vries  <tdevries@suse.de>
2514
2515         * aarch64-linux-tdep.c: Fix typos in comments.
2516         * aarch64-tdep.c: Same.
2517         * ada-lang.c: Same.
2518         * amd64-nat.c: Same.
2519         * arc-tdep.c: Same.
2520         * arch/aarch64-insn.c: Same.
2521         * block.c: Same.
2522         * breakpoint.h: Same.
2523         * btrace.h: Same.
2524         * c-varobj.c: Same.
2525         * cli/cli-decode.c: Same.
2526         * cli/cli-script.c: Same.
2527         * cli/cli-utils.h: Same.
2528         * coff-pe-read.c: Same.
2529         * coffread.c: Same.
2530         * compile/compile-cplus-symbols.c: Same.
2531         * compile/compile-object-run.c: Same.
2532         * completer.c: Same.
2533         * corelow.c: Same.
2534         * cp-support.c: Same.
2535         * demangle.c: Same.
2536         * dwarf-index-write.c: Same.
2537         * dwarf2-frame.c: Same.
2538         * dwarf2-frame.h: Same.
2539         * eval.c: Same.
2540         * frame-base.h: Same.
2541         * frame.h: Same.
2542         * gdbcmd.h: Same.
2543         * gdbtypes.h: Same.
2544         * gnu-nat.c: Same.
2545         * guile/scm-objfile.c: Same.
2546         * i386-tdep.c: Same.
2547         * i386-tdep.h: Same.
2548         * infcall.c: Same.
2549         * infcall.h: Same.
2550         * linux-nat.c: Same.
2551         * m68k-tdep.c: Same.
2552         * macroexp.c: Same.
2553         * memattr.c: Same.
2554         * mi/mi-cmd-disas.c: Same.
2555         * mi/mi-getopt.h: Same.
2556         * mi/mi-main.c: Same.
2557         * minsyms.c: Same.
2558         * nat/aarch64-sve-linux-sigcontext.h: Same.
2559         * objfiles.h: Same.
2560         * ppc-linux-nat.c: Same.
2561         * ppc-linux-tdep.c: Same.
2562         * ppc-tdep.h: Same.
2563         * progspace.h: Same.
2564         * prologue-value.h: Same.
2565         * python/py-evtregistry.c: Same.
2566         * python/py-instruction.h: Same.
2567         * record-btrace.c: Same.
2568         * record-full.c: Same.
2569         * remote.c: Same.
2570         * rs6000-tdep.c: Same.
2571         * ser-tcp.c: Same.
2572         * sol-thread.c: Same.
2573         * sparc-sol2-tdep.c: Same.
2574         * sparc64-tdep.c: Same.
2575         * stabsread.c: Same.
2576         * symfile.c: Same.
2577         * symtab.h: Same.
2578         * target.c: Same.
2579         * tracepoint.c: Same.
2580         * tui/tui-data.h: Same.
2581         * tui/tui-io.c: Same.
2582         * tui/tui-win.c: Same.
2583         * tui/tui.c: Same.
2584         * unittests/rsp-low-selftests.c: Same.
2585         * user-regs.h: Same.
2586         * utils.c: Same.
2587         * utils.h: Same.
2588         * valarith.c: Same.
2589         * valops.c: Same.
2590         * valprint.c: Same.
2591         * valprint.h: Same.
2592         * value.c: Same.
2593         * value.h: Same.
2594         * varobj.c: Same.
2595         * x86-nat.h: Same.
2596         * xtensa-tdep.c: Same.
2597
2598 2019-10-25  Ali Tamur <tamur@google.com>
2599
2600         * charset.c (find_charset_names): Reflect API change.
2601
2602 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
2603
2604         * symtab.c (struct demangled_name_entry): Change demangled name
2605         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2606         part of the struct anymore.
2607         (symbol_set_names): No longer obstack allocate + copy the demangled
2608         name, just store the allocated name from bfd.
2609
2610 2019-10-25  Tom Tromey  <tromey@adacore.com>
2611
2612         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2613         (bsearch_cie_cmp, add_cie): Remove.
2614         (find_cie): Reimplement.
2615         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
2616         (dwarf2_build_frame_info): Update.
2617
2618 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
2619
2620         PR gdb/25126
2621         * symfile.c (reread_symbols): Call forget_cached_source_info to
2622         clear the stale source cache.
2623
2624 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2625
2626         * configure: Regenerate.
2627         * configure.ac: Remove code that sets python_has_threads.
2628
2629 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2630
2631         * config.in: Regenerate.
2632         * configure: Regenerate.
2633         * configure.ac: Remove the code that uses sed to get the python
2634         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2635
2636 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2637
2638         * python/py-progspace.c (pspy_block_for_pc): Return None for all
2639         error paths.
2640
2641 2019-10-23  Tom Tromey  <tom@tromey.com>
2642
2643         * arc-tdep.c: Remove ".." from include.
2644         * frv-tdep.c: Remove ".." from include.
2645         * lm32-tdep.c: Remove ".." from include.
2646         * microblaze-tdep.c: Remove ".." from include.
2647         * or1k-tdep.h: Remove ".." from include.
2648         * s12z-tdep.c: Remove ".." from include.
2649         * Makefile.in (OPCODES_CFLAGS): Add comment.
2650         (TOP_CFLAGS): New variable.
2651         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2652
2653 2019-10-23  Tom Tromey  <tom@tromey.com>
2654
2655         * Makefile.in (READLINE_DIR): Update.
2656
2657 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2658
2659         * infcall.c (call_function_by_hand_dummy): Fix the function
2660         comment.  And extract out a code section into...
2661         (reserve_stack_space): ...this new function.
2662
2663 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2664
2665         * infcall.c (value_arg_coerce): Remove an unused parameter.
2666         (call_function_by_hand_dummy): Update the call to
2667         'value_arg_coerce'.
2668
2669 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2670
2671         * infcall.c (call_function_by_hand_dummy): Refactor.
2672
2673 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2674
2675         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2676
2677 2019-10-23  Tom Tromey  <tom@tromey.com>
2678
2679         * configure: Rebuild.
2680         * configure.ac: Don't check for sigprocmask.
2681         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2682
2683 2019-10-23  Tom Tromey  <tom@tromey.com>
2684
2685         * configure: Rebuild.
2686         * acinclude.m4: Use m4_include, not sinclude.
2687
2688 2019-10-23  Tom de Vries  <tdevries@suse.de>
2689
2690         PR breakpoints/24687
2691         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2692
2693 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2694
2695         * symtab.c (struct demangled_name_entry) <language>: Change from
2696         bitfield to regular variable.
2697
2698 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2699
2700         * symtab.c (struct demangled_name_entry): Add a constructor.
2701         (free_demangled_name_entry): New function to call the destructor
2702         for demangled_name_entry.
2703         (create_demangled_names_hash): Pass free_demangled_name_entry to
2704         htab_create_alloc.
2705         (symbol_set_names): Call placement new for demangled_name_entry.
2706         * utils.c: No longer include xxhash.h here, now that fast_hash
2707         is inlined in the header.
2708         * utils.h: Instead, include it here.
2709
2710 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2711
2712         * Makefile.in: Link with libxxhash.
2713         * config.in: Regenerate.
2714         * configure: Regenerate.
2715         * configure.ac: Search for libxxhash.
2716         * utils.c (fast_hash): Use xxhash if present.
2717
2718 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2719
2720         * utils.h (fast_hash): New function.
2721         * symtab.c (hash_demangled_name_entry): Call new function
2722         fast_hash.
2723
2724 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2725
2726         * symtab.c (struct demangled_name_entry): Change type of mangled
2727         to gdb::string_view. Also adds a constructor that takes the
2728         mangled name.
2729         (hash_demangled_name_entry): Update.
2730         (eq_demangled_name_entry): Update.
2731         (free_demangled_name_entry): New function to call the destructor
2732         now that this is not a POD anymore.
2733         (create_demangled_names_hash): Pass free_demangled_name_entry to
2734         htab_create_alloc.
2735         (symbol_set_names): Update.
2736
2737 2019-10-21  Ali Tamur  <tamu@google.com>
2738
2739         * dwarf2read.c (dir_index): Change type.
2740         (file_name_index): Likewise.
2741         (line_header::include_dir_at): Change comment and implementation on
2742         whether it is DWARF 5.
2743         (line_header::is_valid_file_index): New function.
2744         (line_header::file_name_at): Change comment and implementation on
2745         whether it is DWARF 5.
2746         (line_header::file_names): Change to private field renamed as
2747         m_file_names and introduce a new accessor method.
2748         (line_header::file_names_size): New method.
2749         (line_header::include_dirs): Change to private field and rename as
2750         m_include_dirs.
2751         (dw2_get_file_names_reader): Define local var at a smaller scope and
2752         reflect API change.
2753         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2754         (process_structure_scope): Likewise.
2755         (line_header::add_include_dir): Change message and reflect renaming.
2756         (line_header::add_file_name): Likewise.
2757         (read_formatted_entries): Handle DW_FORM_data16.
2758         (dwarf_decode_line_header): Fix line header length calculation.
2759         (psymtab_include_file_name): Change comment and API.
2760         (lnp_state_machine::m_file): Update comment and reflect type change.
2761         (lnp_state_machine::record_line): Reflect type change.
2762         (dwarf_decode_lines): Reflect API change.
2763         (file_file_name): Likewise.
2764         (file_full_name): Likewise.
2765
2766 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2767
2768         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2769
2770 2019-10-21  Tom Tromey  <tom@tromey.com>
2771
2772         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2773
2774 2019-10-21  Tom Tromey  <tom@tromey.com>
2775
2776         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
2777         NM_H.   Use AC_CONFIG_LINKS.
2778         * configure: Rebuild.
2779         * Makefile.in (NM_H): New variable.
2780         (generated_files): Add NM_H.  Remove gcore.
2781         (nm.h, stamp-nmh): New targets.
2782
2783 2019-10-20  Tom Tromey  <tom@tromey.com>
2784
2785         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2786         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
2787         obsolete comment.
2788         (put_objfile_before): Now static.
2789
2790 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
2791
2792         * gdbsupport/common-utils.h (startswith): Change return type to
2793         bool.
2794
2795 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
2796
2797         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2798         * breakpoint.c (bp_locations_compare): Rename to...
2799         (bp_location_is_less_than): ...this, and change to std::sort semantics.
2800         (update_global_location_list): Use std::sort instead of qsort.
2801         * buildsym.c (compare_line_numbers): Rename to...
2802         (lte_is_less_than): ...this, and change to std::sort semantics.
2803         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2804         instead of qsort.
2805         * disasm.c (compare_lines): Rename to...
2806         (line_is_less_than): ...this, and change to std::sort semantics.
2807         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2808         of qsort.
2809         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2810         (fde_is_less_than): ...this, and change to std::sort semantics.
2811         (dwarf2_build_frame_info): Call std::sort instead of qsort.
2812         * mdebugread.c (compare_blocks):
2813         (block_is_less_than): ...this, and change to std::sort semantics.
2814         (sort_blocks): Call std::sort instead of qsort.
2815         * objfiles.c (qsort_cmp): Rename to...
2816         (sort_cmp): ...this, and change to std::sort semantics.
2817         (update_section_map): Call std::sort instead of qsort.
2818         * remote.c (compare_pnums): Remove.
2819         (map_regcache_remote_table): Call std::sort instead of qsort.
2820         * utils.c (compare_positive_ints): Remove.
2821         * utils.h (compare_positive_ints): Remove.
2822         * xcoffread.c (compare_lte): Remove.
2823         (arrange_linetable): Call std::sort instead of qsort.
2824
2825 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
2826
2827         * symfile.c (init_entry_point_info): Fix typo.
2828         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2829
2830 2019-10-18  Tom de Vries  <tdevries@suse.de>
2831
2832         * aarch64-tdep.c: Fix typos in comments.
2833         * ada-lang.c: Same.
2834         * ada-tasks.c: Same.
2835         * alpha-tdep.c: Same.
2836         * alpha-tdep.h: Same.
2837         * amd64-nat.c: Same.
2838         * amd64-windows-tdep.c: Same.
2839         * arc-tdep.c: Same.
2840         * arc-tdep.h: Same.
2841         * arch-utils.c: Same.
2842         * arm-nbsd-tdep.c: Same.
2843         * arm-tdep.c: Same.
2844         * ax-gdb.c: Same.
2845         * blockframe.c: Same.
2846         * btrace.c: Same.
2847         * c-varobj.c: Same.
2848         * coff-pe-read.c: Same.
2849         * coffread.c: Same.
2850         * cris-tdep.c: Same.
2851         * darwin-nat.c: Same.
2852         * dbxread.c: Same.
2853         * dcache.c: Same.
2854         * disasm.c: Same.
2855         * dtrace-probe.c: Same.
2856         * dwarf-index-write.c: Same.
2857         * dwarf2-frame-tailcall.c: Same.
2858         * dwarf2-frame.c: Same.
2859         * dwarf2read.c: Same.
2860         * eval.c: Same.
2861         * exceptions.c: Same.
2862         * fbsd-tdep.c: Same.
2863         * findvar.c: Same.
2864         * frame.c: Same.
2865         * frv-tdep.c: Same.
2866         * gnu-v3-abi.c: Same.
2867         * go32-nat.c: Same.
2868         * h8300-tdep.c: Same.
2869         * hppa-tdep.c: Same.
2870         * i386-linux-tdep.c: Same.
2871         * i386-tdep.c: Same.
2872         * ia64-libunwind-tdep.c: Same.
2873         * ia64-tdep.c: Same.
2874         * infcmd.c: Same.
2875         * infrun.c: Same.
2876         * linespec.c: Same.
2877         * linux-nat.c: Same.
2878         * linux-thread-db.c: Same.
2879         * machoread.c: Same.
2880         * mdebugread.c: Same.
2881         * mep-tdep.c: Same.
2882         * mn10300-tdep.c: Same.
2883         * namespace.c: Same.
2884         * objfiles.c: Same.
2885         * opencl-lang.c: Same.
2886         * or1k-tdep.c: Same.
2887         * osabi.c: Same.
2888         * ppc-linux-nat.c: Same.
2889         * ppc-linux-tdep.c: Same.
2890         * ppc-sysv-tdep.c: Same.
2891         * printcmd.c: Same.
2892         * procfs.c: Same.
2893         * record-btrace.c: Same.
2894         * record-full.c: Same.
2895         * remote-fileio.c: Same.
2896         * remote.c: Same.
2897         * rs6000-tdep.c: Same.
2898         * s12z-tdep.c: Same.
2899         * score-tdep.c: Same.
2900         * ser-base.c: Same.
2901         * ser-go32.c: Same.
2902         * skip.c: Same.
2903         * sol-thread.c: Same.
2904         * solib-svr4.c: Same.
2905         * solib.c: Same.
2906         * source.c: Same.
2907         * sparc-nat.c: Same.
2908         * sparc-sol2-tdep.c: Same.
2909         * sparc-tdep.c: Same.
2910         * sparc64-tdep.c: Same.
2911         * stabsread.c: Same.
2912         * stack.c: Same.
2913         * symfile.c: Same.
2914         * symtab.c: Same.
2915         * target-descriptions.c: Same.
2916         * target-float.c: Same.
2917         * thread.c: Same.
2918         * utils.c: Same.
2919         * valops.c: Same.
2920         * valprint.c: Same.
2921         * value.c: Same.
2922         * varobj.c: Same.
2923         * windows-nat.c: Same.
2924         * xcoffread.c: Same.
2925         * xstormy16-tdep.c: Same.
2926         * xtensa-tdep.c: Same.
2927
2928 2019-10-17  Tom Tromey  <tromey@adacore.com>
2929
2930         * configure: Rebuild.
2931         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
2932         in AC_CONFIG_FILES invocation.
2933         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2934         new-style config.status invocation.
2935
2936 2019-10-17  Tom de Vries  <tdevries@suse.de>
2937
2938         * arm-nbsd-nat.c: Fix typos in comments.
2939         * arm-tdep.c: Same.
2940         * darwin-nat-info.c: Same.
2941         * dwarf2read.c: Same.
2942         * elfread.c: Same.
2943         * event-top.c: Same.
2944         * findvar.c: Same.
2945         * gdbtypes.c: Same.
2946         * hppa-tdep.c: Same.
2947         * i386-tdep.c: Same.
2948         * jit.c: Same.
2949         * main.c: Same.
2950         * mdebugread.c: Same.
2951         * moxie-tdep.c: Same.
2952         * nto-procfs.c: Same.
2953         * osabi.c: Same.
2954         * ppc-linux-tdep.c: Same.
2955         * remote.c: Same.
2956         * riscv-tdep.c: Same.
2957         * s390-tdep.c: Same.
2958         * sh-tdep.c: Same.
2959         * sparc-linux-tdep.c: Same.
2960         * sparc-nat.c: Same.
2961         * stack.c: Same.
2962         * target-descriptions.c: Same.
2963         * top.c: Same.
2964         * varobj.c: Same.
2965
2966 2019-10-16  Tom Tromey  <tom@tromey.com>
2967
2968         * objfiles.h (struct objfile) <original_name>: Now const.
2969
2970 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2971
2972         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2973         pass on to sigsetjmp's second argument.
2974         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2975
2976 2019-10-16  Keith Seitz  <keiths@redhat.com>
2977
2978         PR gdb/23567
2979         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2980         sections whose size is greater than the file size.
2981
2982 2019-10-16  Jim Wilson  <jimw@sifive.com>
2983
2984         * riscv-tdep.c (riscv_gcc_target_options): New.
2985         (riscv_gnu_triplet_regexp): New.
2986         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2987         set_gdbarch_gnu_triplet_regexp.
2988
2989 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2990
2991         * Makefile.in: Add xml-builtin.h.
2992         * features/feature_to_c.sh: Add an include for xml-builtin.h
2993         to ensure that the compiler checks that the types match.
2994         * xml-builtin.h: New file.
2995         * xml-support.c (fetch_xml_builtin): Add missing const.
2996         * xml-support.h: Remove declaration of xml_builtins.
2997
2998 2019-10-16  Tom de Vries  <tdevries@suse.de>
2999
3000         PR tdep/25096
3001         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3002         (amd64_classify_aggregate): ... here.
3003         (amd64_classify_aggregate_field): Handled fiels of nested structs
3004         recursively.
3005
3006 2019-10-16  Tom de Vries  <tdevries@suse.de>
3007
3008         PR tdep/24104
3009         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3010         that handles 'theclass'.
3011
3012 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3013
3014         * linespec.c (decode_digits_ordinary): Update comment.
3015         * make-target-delegates: No longer need to handle VEC case.
3016         * memrange.c (normalize_mem_ranges): Update comment.
3017         * namespace.c (add_using_directive): Update comment.
3018         * objc-lang.c (uniquify_strings): Update comment.
3019         * ppc-linux-nat.c (struct thread_points): Update comment.
3020         * probe.h (find_probes_in_objfile): Update comment.
3021         * target.h (enum flash_preserve_mode): Update comment.
3022         * varobj.c (varobj_restrict_range): Update comment.
3023         * varobj.h (varobj_list_children): Update comment.
3024
3025 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3026
3027         * Makefile.in: Remove references to vec.h and vec.c.
3028         * aarch64-tdep.c: No longer include vec.h.
3029         * ada-lang.c: Likewise.
3030         * ada-lang.h: Likewise.
3031         * arm-tdep.c: Likewise.
3032         * ax.h: Likewise.
3033         * breakpoint.h: Likewise.
3034         * charset.c: Likewise.
3035         * cp-support.h: Likewise.
3036         * dtrace-probe.c: Likewise.
3037         * dwarf2read.c: Likewise.
3038         * extension.h: Likewise.
3039         * gdb_bfd.c: Likewise.
3040         * gdbsupport/gdb_vecs.h: Likewise.
3041         * gdbsupport/vec.c: Remove.
3042         * gdbsupport/vec.h: Remove.
3043         * gdbthread.h: Likewise.
3044         * guile/scm-type.c: Likewise.
3045         * inline-frame.c: Likewise.
3046         * machoread.c: Likewise.
3047         * memattr.c: Likewise.
3048         * memrange.h: Likewise.
3049         * namespace.h: Likewise.
3050         * nat/linux-btrace.h: Likewise.
3051         * osdata.c: Likewise.
3052         * parser-defs.h: Likewise.
3053         * progspace.h: Likewise.
3054         * python/py-type.c: Likewise.
3055         * record-btrace.c: Likewise.
3056         * rust-exp.y: Likewise.
3057         * solib-target.c: Likewise.
3058         * stap-probe.c: Likewise.
3059         * target-descriptions.c: Likewise.
3060         * target-memory.c: Likewise.
3061         * target.h: Likewise.
3062         * varobj.c: Likewise.
3063         * varobj.h: Likewise.
3064         * xml-support.h: Likewise.
3065
3066 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3067
3068         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3069         Update for new std::vector based implementation.
3070         (process_psymtab_comp_unit_reader): Likewise.
3071         (scan_partial_symbols): Likewise.
3072         (recursively_compute_inclusions): Likewise.
3073         (compute_compunit_symtab_includes): Likewise.
3074         (process_imported_unit_die): Likewise.
3075         (queue_and_load_dwo_tu): Likewise.
3076         (follow_die_sig_1): Likewise.
3077         * gdb/dwarf2read.h: Remove DEF_VEC_P.
3078         (typedef dwarf2_per_cu_ptr): Remove.
3079         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3080         function.
3081         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3082         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3083         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3084         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3085         std::vector.
3086
3087 2019-10-15  Tom Tromey  <tromey@adacore.com>
3088
3089         * windows-nat.c (windows_nat_target::resume): Use %x when logging
3090         TID.
3091
3092 2019-10-15  Tom Tromey  <tromey@adacore.com>
3093
3094         * windows-nat.c (windows_nat_target::fetch_registers)
3095         (windows_nat_target::store_registers): Rename "pid" to "tid".
3096
3097 2019-10-15  Tom Tromey  <tromey@adacore.com>
3098
3099         * gdbarch.h, gdbarch.c: Rebuild.
3100         * gdbarch.sh (gcc_target_options): Change return type to
3101         std::string.
3102         * compile/compile.c (get_args): Update.
3103         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3104         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3105         std::string.
3106         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3107         std::string.
3108         * arch-utils.c (default_gcc_target_options): Return std::string.
3109         * arch-utils.h (default_gcc_target_options): Return std::string.
3110         * s390-tdep.c (s390_gcc_target_options): Return std::string.
3111
3112 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3113
3114         * breakpoint.c (breakpoint_chain): Make static.
3115         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3116         of accessing breakpoint_chain.
3117
3118 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3119
3120         * breakpoint.c (iterate_over_breakpoints): Change function pointer
3121         to a gdb::function_view and return value to bool.
3122         * breakpoint.h (iterate_over_breakpoints): Likewise.
3123         * dummy-frame.c (pop_dummy_frame_bpt): Update.
3124         (pop_dummy_frame): Update.
3125         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3126         (gdbscm_breakpoints): Update.
3127         * python/py-breakpoint.c (build_bp_list): Update.
3128         (gdbpy_breakpoints): Update.
3129         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3130         Update.
3131         (bpfinishpy_handle_stop): Update.
3132         (bpfinishpy_handle_exit): Update.
3133         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3134         (svr4_update_solib_event_breakpoints): Update.
3135
3136 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
3137
3138         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3139         when unwrapping single-field structs.
3140
3141 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
3142
3143         * dwarf2read.c: Remove includes.
3144
3145 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
3146
3147         * ui-out.c (ui_out::call_do_message): Silence
3148         -Wformat-nonliteral warning.
3149
3150 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
3151
3152         * breakpoint.c: Remove some includes: continuations.h, skip.h,
3153         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
3154         include: readline/tilde.h.
3155
3156 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3157
3158         * remote.c (remote_target::get_trace_status): Remove declaration of
3159         trace_regblock_size.
3160
3161 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3162
3163         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3164         (show_user): Remove declaration of cmdlist.
3165         * cli/cli-cmds.h (max_user_call_depth): Declare.
3166         * cli/cli-script.c (execute_user_command): Remove declaration
3167         of max_user_call_depth.
3168
3169 2019-10-11  Jim Wilson  <jimw@sifive.com>
3170
3171         * gdbsupport/print-utils.h (pulongest): Fix comment.
3172         (plongest): Likewise.
3173         (phex): Add missing comment, mention leading zeros.
3174         (phex_nz): Add mention of no leading zeros to comment.
3175
3176         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3177         plongest instead of unsigned long long cast.
3178
3179 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3180
3181         * main.c (captured_main_1): Include gdbtk.h and remove declarations
3182         for external_editor_command and gdbtk_test.
3183
3184 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3185
3186         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3187         * varobj.c (varobjdebug): Move comment to...
3188         * varobj.h (varobjdebug): ...here, and declare.
3189
3190 2019-10-09  Tom Tromey  <tom@tromey.com>
3191
3192         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3193         erase_data_content.
3194
3195 2019-10-09  Tom Tromey  <tom@tromey.com>
3196
3197         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3198         * tui/tui-stack.c (tui_locator_window::rerender): Update.
3199         * tui/tui-command.c (tui_cmd_window::resize)
3200         (tui_refresh_cmd_win): Update.
3201         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3202         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3203         * tui/tui-data.c (~tui_gen_win_info): Remove.
3204         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3205         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3206         (tui_redisplay_readline, tui_mld_flush)
3207         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3208         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3209         (tui_data_window::erase_data_content)
3210         (tui_data_item_window::rerender)
3211         (tui_data_item_window::refresh_window): Update.
3212         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3213         (box_win, tui_gen_win_info::make_window)
3214         (tui_gen_win_info::make_visible): Update.
3215         (tui_delete_win): Remove.
3216         * tui/tui-winsource.c
3217         (tui_source_window_base::do_erase_source_content): Update.
3218         (tui_show_source_line, tui_source_window_base::update_tab_width)
3219         (tui_source_window_base::update_exec_info): Update.
3220         * tui/tui-data.h (struct curses_deleter): New.
3221         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3222         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3223
3224 2019-10-09  Tom Tromey  <tom@tromey.com>
3225
3226         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3227
3228 2019-10-09  Tom Tromey  <tom@tromey.com>
3229
3230         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3231         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3232
3233 2019-10-09  Tom Tromey  <tom@tromey.com>
3234
3235         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3236         window height directly.
3237         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3238         declare.
3239         * tui/tui-layout.c (tui_default_win_height): Remove.
3240         (tui_default_win_viewport_height): Remove.
3241
3242 2019-10-09  Tom Tromey  <tom@tromey.com>
3243
3244         * tui/tui.h: Remove comments.
3245
3246 2019-10-09  Tom de Vries  <tdevries@suse.de>
3247
3248         * python/lib/gdb/printer/bound_registers.py: Use
3249         '^builtin_type_bound128' as regexp argument for
3250         add_builtin_pretty_printer.
3251
3252 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
3253
3254         * guile/guile.c (guile_extension_script_ops): Remove forward
3255         declaration and mark as static.
3256         (guile_script_ops): Likewise.
3257         (extension_language_guile): Move further down in the file so
3258         it can reference the definitions for guile_{extension_,}script_ops.
3259
3260 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
3261
3262         * s390-tdep.c (390_process_record): Handle new arch13 instructions
3263         except SORTL, DFLTCC, and KDSA.
3264
3265 2019-10-08  Tom Tromey  <tromey@adacore.com>
3266
3267         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3268         (struct safe_symbol_file_add_args): Remove.
3269
3270 2019-10-08  Tom Tromey  <tromey@adacore.com>
3271
3272         * windows-nat.c: Don't include buildsym-legacy.h.
3273
3274 2019-10-08  Tom Tromey  <tromey@adacore.com>
3275
3276         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3277
3278 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3279
3280         * gdbtypes.c (overload_debug): Move comment to header.
3281         * gdbtypes.h (overload_debug): Declare.
3282         * valops.c: Remove declaration of overload_debug, instead
3283         include gdbtypes.h.
3284
3285 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3286
3287         * language.c (show_language_command): Pass lang_frame_mismatch_warn
3288         through _().
3289         (lang_frame_mismatch_warn): Make const, mark with N_(), and
3290         move comment...
3291         * language.h (lang_frame_mismatch_warn): ... here. Also add
3292         declaration.
3293         * top.c (lang_frame_mismatch_warn): Remove declaration.
3294         (check_frame_language_change): Pass lang_frame_mismatch_warn
3295         through _().
3296
3297 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3298
3299         * c-lang.h (vtbl_ptr_name): Declare.
3300         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3301         it from the header.
3302         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3303
3304 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3305
3306         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3307         gdb_static_assert.
3308
3309 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3310
3311         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3312         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3313         * ctfread.c: New file.
3314         * ctfread.h: New file.
3315         * elfread.c: Include ctfread.h.
3316         (struct elfinfo text_p): New member ctfsect.
3317         (elf_locate_sections): Mark CTF section.
3318         (elf_symfile_read): Call elfctf_build_psymtabs.
3319         * Makefile.in (LIBCTF): Add.
3320         (CLIBS): Use it.
3321         (CDEPS): Likewise.
3322         (DIST): Add ctfread.c.
3323
3324 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3325
3326         * ctfread.c (struct nextfield): Renamed to ...
3327         (struct ctf_nextfield): ... this.
3328         (struct field_info): Renamed to ...
3329         (strut ctf_field_info): ... this.
3330         (attach_fields_to_type): Update for renamed structures.
3331         (ctf_add_member_cb): Likewise.
3332         (ctf_add_enum_member_cb): Likewise.
3333         (process_struct_members): Likewise.
3334         (process_enum_type): Likewise.
3335
3336 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3337
3338         * tracectf.h: Rename, was ctf.h.
3339         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3340         * tracefile.c: Likewise.
3341         * tracepoint.c: Remove unused include ctf.h.
3342         * mi/mi-main.c: Likewise.
3343         * Makefile.in Replace ctf.c with tracectf.c.
3344
3345 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
3346
3347         * version.in: Change version number to "9.0.50.DATE-git".
3348
3349 2019-10-03  Tom Tromey  <tom@tromey.com>
3350
3351         PR rust/24976:
3352         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3353
3354 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3355
3356         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3357         cp_search_name_hash.
3358         * NEWS: Add entry about nested function support.
3359
3360 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
3361             Andrew Burgess  <andrew.burgess@embecosm.com>
3362
3363         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3364         for nested static variables when searchin VAR_DOMAIN.
3365         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3366         global scope, update comment.
3367         (add_partial_subprogram): Call add_partial_subprogram recursively
3368         for nested subroutines when processinng Fortran.
3369         (load_partial_dies): Process the child entities of a subprogram
3370         when processing Fortran.
3371         (partial_die_parent_scope): Handle building scope
3372         for Fortran nested functions.
3373         (process_die): Record that nested functions have a scope.
3374         (new_symbol): Always record Fortran subprograms on the global
3375         symbol list.
3376         (determine_prefix): How to build the prefix for Fortran
3377         subprograms.
3378
3379 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3380
3381         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3382         have just sent the thread a SIGSTOP and are waiting for it to
3383         arrive.
3384
3385 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3386
3387         * btrace.c (btrace_add_pc): Remove whitespace before the template
3388         parameter in 'std::vector <...>'.
3389         (parse_xml_btrace_block): Likewise.
3390         (btrace_maint_decode_pt): Likewise.
3391         (btrace_maint_update_packets): Likewise.
3392         (btrace_maint_print_packets): Likewise.
3393         * btrace.h (struct btrace_maint_info): Likewise.
3394         * dwarf2read.c (struct type_unit_group): Likewise.
3395         (build_type_psymtabs_reader): Likewise.
3396         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3397         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3398         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3399
3400 2019-10-03  Tom de Vries  <tdevries@suse.de>
3401
3402         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3403         the first line of the help text for set/show style metadata.
3404
3405 2019-10-02  Tom Tromey  <tromey@adacore.com>
3406
3407         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3408         * gdbsupport/common-inferior.c: New file.
3409         * infcmd.c (startup_with_shell): Don't define.
3410         * nat/fork-inferior.h (startup_with_shell): Don't declare.
3411         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3412         * inferior.h (startup_with_shell): Don't declare.
3413
3414 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
3415
3416         * gdbsupport/gdb_assert.h: Include errors.h.
3417         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3418
3419 2019-10-02  Tom Tromey  <tromey@adacore.com>
3420
3421         * NEWS: Add $_ada_exception entry.
3422         * ada-lang.c (struct ada_catchpoint): Add constructor.
3423         <m_kind>: New member.
3424         (allocate_location_exception, re_set_exception): Remove
3425         "ex" parameter.
3426         (should_stop_exception): Compute $_ada_exception.
3427         (check_status_exception, print_it_exception)
3428         (print_one_exception, print_mention_exception): Remove
3429         "ex" parameter.
3430         (allocate_location_catch_exception, re_set_catch_exception)
3431         (check_status_exception, print_it_catch_exception)
3432         (print_one_catch_exception, print_mention_catch_exception)
3433         (print_recreate_catch_exception)
3434         (allocate_location_catch_exception_unhandled)
3435         (re_set_catch_exception_unhandled)
3436         (check_status_exception, print_it_catch_exception_unhandled)
3437         (print_one_catch_exception_unhandled)
3438         (print_mention_catch_exception_unhandled)
3439         (print_recreate_catch_exception_unhandled)
3440         (allocate_location_catch_assert, re_set_catch_assert)
3441         (check_status_assert, print_it_catch_assert)
3442         (print_one_catch_assert, print_mention_catch_assert)
3443         (print_recreate_catch_assert)
3444         (allocate_location_catch_handlers, re_set_catch_handlers)
3445         (check_status_handlers, print_it_catch_handlers)
3446         (print_one_catch_handlers, print_mention_catch_handlers)
3447         (print_recreate_catch_handlers): Remove.
3448         (create_ada_exception_catchpoint): Update.
3449         (initialize_ada_catchpoint_ops): Update.
3450
3451 2019-10-02  Tom Tromey  <tromey@adacore.com>
3452
3453         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3454         (create_excep_cond_exprs): Simplify exception string computation.
3455         (ada_exception_catchpoint_cond_string): Likewise.
3456
3457 2019-10-02  Tom Tromey  <tromey@adacore.com>
3458
3459         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3460         * ada-lang.c (lesseq_defined_than): Handle
3461         LOC_STATIC.
3462         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3463         parameter.
3464         (dwarf2_has_info): Likewise.
3465         (new_symbol): Set maybe_copied on symbol when
3466         appropriate.
3467         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3468         parameter.
3469         <can_copy>: New member.
3470         * elfread.c (record_minimal_symbol): Set maybe_copied
3471         on symbol when appropriate.
3472         (elf_symfile_read): Update call to dwarf2_has_info.
3473         * minsyms.c (lookup_minimal_symbol_linkage): New
3474         function.
3475         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3476         * symtab.c (get_symbol_address, get_msymbol_address):
3477         New functions.
3478         * symtab.h (get_symbol_address, get_msymbol_address):
3479         Declare.
3480         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3481         maybe_copied.
3482         (struct symbol, struct minimal_symbol) <maybe_copied>:
3483         New member.
3484
3485 2019-10-02  Tom Tromey  <tromey@adacore.com>
3486
3487         * source.c (struct current_source_location): New.
3488         (current_source_key): New global.
3489         (current_source_symtab, current_source_line)
3490         (current_source_pspace): Remove.
3491         (get_source_location): New function.
3492         (get_current_source_symtab_and_line)
3493         (set_default_source_symtab_and_line)
3494         (set_current_source_symtab_and_line)
3495         (clear_current_source_symtab_and_line, select_source_symtab)
3496         (info_source_command, print_source_lines_base)
3497         (info_line_command, search_command_helper, _initialize_source):
3498         Update.
3499
3500 2019-10-02  Tom Tromey  <tromey@adacore.com>
3501
3502         * source.c (select_source_symtab): Don't call
3503         decode_line_with_current_source.
3504
3505 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3506
3507         * symtab.c (lookup_global_symbol): Search global block.
3508
3509 2019-10-02  Tom Tromey  <tromey@adacore.com>
3510
3511         * coffread.c (process_coff_symbol): Update.
3512         * dwarf2read.c (var_decode_location, new_symbol): Update.
3513         * mdebugread.c (parse_symbol): Update.
3514         * objfiles.c (relocate_one_symbol): Update.
3515         * stabsread.c (define_symbol, fix_common_block)
3516         (scan_file_globals): Update.
3517         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3518         (SET_SYMBOL_VALUE_ADDRESS): New macro.
3519         * xcoffread.c (process_xcoff_symbol): Update.
3520
3521 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
3522
3523         * MAINTAINERS: Update my email address.
3524
3525 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3526
3527         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3528         std::vector.
3529         (build_type_psymtabs_reader): Update for std::vector.
3530         (build_type_psymtab_dependencies): Likewise.
3531         * dwarf2read.h: Remove use of DEF_VEC_P.
3532         (typedef sig_type_ptr): Delete.
3533
3534 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3535
3536         * btrace.c (btrace_maint_clear): Update to handle change from VEC
3537         to std::vector.
3538         (btrace_maint_decode_pt): Likewise, and move allocation of the
3539         vector outside of the loop.
3540         (btrace_maint_update_packets): Update to handle change from VEC to
3541         std::vector.
3542         (btrace_maint_print_packets): Likewise.
3543         (maint_info_btrace_cmd): Likewise.
3544         * btrace.h: Remove use of DEF_VEC_O.
3545         (typedef btrace_pt_packet_s): Delete.
3546         (struct btrace_maint_info) <packets>: Change fromm VEC to
3547         std::vector.
3548         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3549
3550 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3551
3552         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3553         make accesses into the vector constant references.
3554         (btrace_add_pc): Update for std::vector.
3555         (btrace_stitch_bts): Likewise.
3556         (parse_xml_btrace_block): Likewise.
3557         (btrace_maint_update_packets): Likewise.
3558         (btrace_maint_print_packets): Likewise.
3559         (maint_info_btrace_cmd): Likewise.
3560         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3561         std::vector.
3562         (btrace_data::empty): Likewise.
3563         (btrace_data_append): Likewise.
3564         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3565         (typedef btrace_block_s): Delete.
3566         (struct btrace_block): Add constructor.
3567         (struct btrace_data_bts) <blocks>: Change to std::vector.
3568         * nat/linux-btrace.c (perf_event_read_bts): Update for
3569         std::vector.
3570         (linux_read_bts): Likewise.
3571
3572 2019-10-01  Tom Tromey  <tom@tromey.com>
3573
3574         * cli/cli-logging.c (show_logging_filename): Use styled_string.
3575
3576 2019-10-01  Tom Tromey  <tom@tromey.com>
3577
3578         * stack.c (print_frame, info_frame_command_core): Use
3579         styled_string.
3580         * linux-thread-db.c (try_thread_db_load_1)
3581         (try_thread_db_load_from_pdir_1): Use styled_string.
3582         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3583         (auto_load_section_scripts, info_auto_load_local_gdbinit)
3584         (maybe_print_unsupported_script_warning)
3585         (maybe_print_script_not_found_warning): Use styled_string.
3586         * ada-lang.c (user_select_syms): Use styled_string.
3587
3588 2019-10-01  Tom Tromey  <tom@tromey.com>
3589
3590         * p-lang.c (pascal_printstr): Use metadata style.
3591         * value.c (show_convenience): Use metadata style.
3592         * valprint.c (valprint_check_validity, val_print_optimized_out)
3593         (val_print_not_saved, val_print_unavailable)
3594         (val_print_invalid_address, generic_val_print, val_print)
3595         (value_check_printable, val_print_array_elements): Use metadata
3596         style.
3597         * ui-out.h (class ui_out) <field_fmt>: New overload.
3598         <do_field_fmt>: Add style parameter.
3599         * ui-out.c (ui_out::field_fmt): New overload.
3600         * typeprint.c (type_print_unknown_return_type)
3601         (val_print_not_allocated, val_print_not_associated): Use metadata
3602         style.
3603         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3604         parameter.
3605         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3606         * tracepoint.c (tvariables_info_1): Use metadata style.
3607         * stack.c (print_frame_arg, print_frame_info, print_frame)
3608         (info_frame_command_core): Use metadata style.
3609         * skip.c (info_skip_command): Use metadata style.
3610         * rust-lang.c (rust_print_enum): Use metadata style.
3611         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3612         metadata style.
3613         * python/py-framefilter.c (py_print_single_arg): Use metadata
3614         style.
3615         * printcmd.c (do_one_display, print_variable_and_value): Use
3616         metadata style.
3617         * p-valprint.c (pascal_val_print)
3618         (pascal_object_print_value_fields): Use metadata style.
3619         * p-typeprint.c (pascal_type_print_base): Use metadata style.
3620         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3621         parameter.
3622         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3623         * m2-valprint.c (m2_print_long_set): Use metadata style.
3624         * m2-typeprint.c (m2_print_type): Use metadata style.
3625         * infcmd.c (print_return_value_1): Use metadata style.
3626         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3627         * f-valprint.c (info_common_command_for_block): Use metadata
3628         style.
3629         * f-typeprint.c (f_type_print_base): Use metadata style.
3630         * expprint.c (print_subexp_standard): Use metadata style.
3631         * cp-valprint.c (cp_print_value_fields): Use metadata style.
3632         * cli/cli-style.h (class cli_style_option): Add constructor.
3633         (metadata_style): Declare.
3634         * cli/cli-style.c (metadata_style): New global.
3635         (_initialize_cli_style): Register metadata style.
3636         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3637         parameter.
3638         * cli-out.c (cli_ui_out::do_field_fmt): Update.
3639         * c-typeprint.c (c_type_print_base_struct_union)
3640         (c_type_print_base_1): Use metadata style.
3641         * breakpoint.c (watchpoint_value_print)
3642         (print_one_breakpoint_location): Use metadata style.
3643         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3644         style.
3645         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3646         style.
3647         * ada-valprint.c (val_print_packed_array_elements, printstr)
3648         (print_field_values, ada_val_print_ref, ada_val_print): Use
3649         metadata style.
3650         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3651         style.
3652         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3653         style.
3654         * ada-lang.c (user_select_syms): Use metadata style.
3655
3656 2019-10-01  Tom Tromey  <tom@tromey.com>
3657
3658         * cli/cli-cmds.c (pwd_command): Style output.
3659
3660 2019-10-01  Pedro Alves  <palves@redhat.com>
3661             Tom Tromey  <tom@tromey.com>
3662
3663         * symtab.c (print_symbol_info): Use %ps.
3664         (print_msymbol_info): Use %ps.
3665         * symfile.c (symbol_file_add_with_addrs): Use %ps.
3666         * printcmd.c (print_variable_and_value): Use %ps.
3667         * macrocmd.c (show_pp_source_pos): Use %ps.
3668         * infrun.c (print_exited_reason): Use ui_out::message.
3669         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3670         (describe_other_breakpoints): Use ui_out::message and new
3671         formats.
3672         (say_where): Use new formats.
3673         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3674         and new formats.
3675
3676 2019-10-01  Pedro Alves  <palves@redhat.com>
3677             Tom Tromey  <tom@tromey.com>
3678
3679         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3680         (test_gdb_formats): New function.
3681         (run_tests): Call it.
3682         (test_format_specifier): Update.
3683         * utils.h (fputs_filtered): Update comment.
3684         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3685         (fputs_styled_unfiltered): Declare.
3686         * utils.c (fputs_styled_unfiltered): New function.
3687         (vfprintf_maybe_filtered): Add gdbfmt parameter.
3688         (vfprintf_filtered): Update.
3689         (vfprintf_unfiltered, vprintf_filtered): Update.
3690         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3691         * ui-out.h (enum ui_out_flag) <unfiltered_output,
3692         disallow_ui_out_field>: New constants.
3693         (enum class field_kind): New.
3694         (struct base_field_s, struct signed_field_s): New.
3695         (signed_field): New function.
3696         (struct string_field_s): New.
3697         (string_field): New function.
3698         (struct styled_string_s): New.
3699         (styled_string): New function.
3700         (class ui_out) <message>: Add comment.
3701         <vmessage, call_do_message>: New methods.
3702         <do_message>: Add style parameter.
3703         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3704         methods.
3705         (ui_out::message): Rewrite.
3706         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3707         parameter.
3708         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3709         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3710         gdb_extensions parameter.
3711         (class format_piece): Add parameter to constructor.
3712         (n_int_args): New field.
3713         * gdbsupport/format.c (format_pieces::format_pieces): Add
3714         gdb_extensions parameter.  Handle '*'.
3715         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3716         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
3717         vfprintf_styled_no_gdbfmt.
3718         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3719         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3720         unfiltered output.
3721         * ui-style.h (struct ui_file_style) <ptr>: New method.
3722
3723 2019-10-01  Tom Tromey  <tom@tromey.com>
3724
3725         * unittests/format_pieces-selftests.c: Update.  Add final format.
3726         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3727         empty literal pieces.
3728
3729 2019-10-01  Tom Tromey  <tom@tromey.com>
3730
3731         * ui-out.h (enum class ui_out_style_kind): Remove.
3732         (class ui_out) <field_string, field_stsream, do_field_string>:
3733         Change type of "style".
3734         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3735         (ui_out::field_string): Update.
3736         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3737         of "style".
3738         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3739         * tracepoint.c (print_one_static_tracepoint_marker): Update.
3740         * stack.c (print_frame_arg, print_frame_info, print_frame):
3741         Update.
3742         * source.c (print_source_lines_base): Update.
3743         * solib.c (info_sharedlibrary_command): Update.
3744         * skip.c (info_skip_command): Update.
3745         * record-btrace.c (btrace_call_history_src_line)
3746         (btrace_call_history): Update.
3747         * python/py-framefilter.c (py_print_frame): Update.
3748         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3749         "style".
3750         * mi/mi-out.c (mi_ui_out::do_table_header)
3751         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3752         (mi_ui_out::do_field_string): Update.
3753         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3754         Update.
3755         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3756         "style".
3757         * cli-out.c (cli_ui_out::do_table_header)
3758         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3759         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3760         (cli_ui_out::do_field_fmt): Update.
3761         * breakpoint.c (print_breakpoint_location): Update.
3762         (update_static_tracepoint): Update.
3763
3764 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3765
3766         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3767         conversion of gdb_datadir.
3768         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3769         remove not needed c_str ().
3770
3771 2019-09-30  Ali Tamur <tamur@google.com>
3772
3773         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3774         (dwarf2_string_attr): Likewise.
3775
3776 2019-09-30  Ali Tamur <tamur@google.com>
3777
3778         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3779         (process_full_type_unit): Likewise.
3780         (dump_die_shallow): Likewise.
3781         (cu_debug_loc_section): Likewise.
3782
3783 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
3784
3785         * minsyms.c (compare_minimal_symbols): Rename to...
3786         (minimal_symbol_is_less_than): ...this, and adjust to STL
3787         conventions (return bool, take arguments as references)
3788         (minimal_symbol_reader::install): Call std::sort instead
3789         of qsort.
3790
3791 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
3792
3793         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3794         hash and why.
3795         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3796         msymbol_hash, msymbol_demangled_hash>: Improve comments.
3797
3798 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
3799
3800         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3801         * psympriv.h (add_psymbol_to_list): Move comment here and update
3802         it.
3803
3804 2019-09-29  Tom de Vries  <tdevries@suse.de>
3805
3806         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3807         Use $tmpdir/$(basename "$output_file").dwz instead of
3808         "${output_file}.dwz".
3809
3810 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
3811
3812         PR gdb/25045
3813         * hppa-linux-nat.c: Include gdbarch.h.
3814
3815 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
3816
3817         * blockframe.c (find_pc_partial_function): Change return type to bool.
3818         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3819         * minsyms.c (in_gnu_ifunc_stub): Likewise.
3820         (stub_gnu_ifunc_resolve_name): Likewise.
3821         * symtab.c (compare_filenames_for_search): Likewise.
3822         (compare_glob_filenames_for_search): Likewise.
3823         (matching_obj_sections): Likewise.
3824         (symbol_matches_domain): Likewise.
3825         (find_line_symtab): Change out param EXACT_MATCH to bool *.
3826         (find_line_pc): Change return type to bool.
3827         (find_line_pc_range): Likewise.
3828         (producer_is_realview): Likewise.
3829         * symtab.h (symbol_matches_domain): Likewise.
3830         (find_pc_partial_function): Likewise.
3831         (find_pc_line_pc_range): Likewise.
3832         (in_gnu_ifunc_stub): Likewise.
3833         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3834         (find_line_pc): Likewise.
3835         (find_line_pc_range): Likewise.
3836         (matching_obj_sections): Likewise.
3837         (find_line_symtab): Change out parameter to bool.
3838         (producer_is_realview): Change return type to bool.
3839         (compare_filenames_for_search): Likewise.
3840         (compare_glob_filenames_for_search): Likewise.
3841
3842 2019-09-26  Tom Tromey  <tom@tromey.com>
3843
3844         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3845         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3846         * gdb_usleep.h: Remove.
3847         * gdb_usleep.c: Remove.
3848         * utils.c: Don't include gdb_usleep.h.
3849
3850 2019-09-26  Tom Tromey  <tromey@adacore.com>
3851
3852         * python/py-type.c (type_to_type_object): Call check_typedef
3853         for stub types.
3854
3855 2019-09-26  Tom Tromey  <tom@tromey.com>
3856
3857         * utils.h (initialize_utils): Don't declare.
3858         * top.c (gdb_init): Don't call initialize_utils.
3859         * utils.c (initialize_utils): Remove.  Move contents...
3860         (_initialize_utils): ... here.
3861
3862 2019-09-25  Tom Tromey  <tom@tromey.com>
3863
3864         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3865         * utils.h (make_hex_string): Don't declare.
3866         * utils.c (make_hex_string): Remove.
3867
3868 2019-09-24  Tom de Vries  <tdevries@suse.de>
3869
3870         PR gdb/23815
3871         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3872         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3873
3874 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
3875
3876         * NEWS: Mention new simulator port for PRU.
3877
3878 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
3879
3880         * ada-exp.y (write_object_remaining): Update.
3881         * ada-lang.c (ada_decode): Return a std::string instead of a char*
3882         and eliminate the static buffer.
3883         (ada_decode_symbol): Update.
3884         (ada_la_decode): Update.
3885         (ada_sniff_from_mangled_name): Update.
3886         (is_valid_name_for_wild_match): Update.
3887         (ada_lookup_name_info::matches): Update and simplify.
3888         (name_matches_regex): Update.
3889         (ada_add_global_exceptions): Update.
3890         * ada-lang.h (ada_decode): Update signature.
3891         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3892         * dwarf-index-write.c (debug_names::insert): Update.
3893
3894 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3895
3896         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3897         formatting.
3898
3899 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3900
3901         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3902         Change "nonzero" to "true" in documentation.
3903
3904 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
3905
3906         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3907         (_initialize_darwin_solib): Don't set
3908         darwin_so_ops.lookup_lib_global_symbol.
3909         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3910         set_gdbarch_iterate_over_objfiles_in_search_order.
3911         (elf_lookup_lib_symbol): Rename to...
3912         (svr4_iterate_over_objfiles_in_search_order): this, and update
3913         to iterate semantics.
3914         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3915         * solib.c (solib_global_lookup): Remove.
3916         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3917         (solib_global_lookup): Remove.
3918         * symtab.c (lookup_global_or_static_symbol): Remove call to
3919         solib_global_lookup.
3920
3921 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3922
3923         * NEWS: Move entries about default MI version now being
3924         version 3, and about the GDB/MI fix for multi-location
3925         breakpoints to the "since GDB 8.3" section.
3926
3927 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3928
3929         GDB 8.3.1 released.
3930
3931 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
3932
3933         * NEWS: Mention that Cell/B.E. debugging support was removed.
3934         * MAINTAINERS: Remove spu target.
3935
3936         * config/djgpp/fnchange.lst: Remove entries for removed files.
3937
3938         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3939         spu-multiarch.o, and spu-tdep.o.
3940         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3941         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3942         spu-multiarch.c, and spu-tdep.c.
3943         * spu-linux-nat.c: Remove file.
3944         * spu-multiarch.c: Remove file.
3945         * spu-tdep.c: Remove file.
3946         * spu-tdep.h: Remove file.
3947         * solib-spu.c: Remove file.
3948         * solib-spu.h: Remove file.
3949
3950         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3951         * configure.nat (spu-linux): Remove.
3952         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3953         solib-multiarch.o from gdb_target_obs.
3954         (spu*-*-*): Remove.
3955
3956         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3957         feature flag.
3958         (ppc_linux_no_features): Update.
3959         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3960         Cell/B.E. support.
3961         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3962         (tdesc_powerpc_cell64l): Likewise.
3963         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3964         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3965         Cell/B.E. support.
3966         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3967         Do not include "features/rs6000/powerpc-cell32l.c" or
3968         "features/rs6000/powerpc-cell64l.c".
3969         (ppc_linux_spu_section): Remove.
3970         (ppc_linux_core_read_description): Remove Cell/B.E. support.
3971         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3972         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3973         (ppc_linux_spe_context_lookup): Remove.
3974         (ppc_linux_spe_context_inferior_created): Remove.
3975         (ppc_linux_spe_context_solib_loaded): Remove.
3976         (ppc_linux_spe_context_solib_unloaded): Remove.
3977         (ppc_linux_spe_context): Remove.
3978         (struct ppu2spu_cache): Remove.
3979         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3980         (struct ppu2spu_data): Remove.
3981         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3982         ppu2spu_unwind): Remove.
3983         (ppc_linux_init_abi): Remove Cell/B.E. support.
3984         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3985
3986         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3987         (rs6000/powerpc-cell64l-expedite): Likewise
3988         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3989         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3990         rs6000/powerpc-cell64l.xml.
3991         * features/rs6000/powerpc-cell32l.xml: Remove.
3992         * features/rs6000/powerpc-cell64l.xml: Likewise.
3993         * features/rs6000/powerpc-cell32l.c: Remove generated file.
3994         * features/rs6000/powerpc-cell64l.c: Likewise.
3995         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3996         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3997         * regformats/reg-spu.dat: Remove.
3998
3999         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4000         * corelow.c (struct spuid_list): Remove.
4001         (add_to_spuid_list): Remove.
4002         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4003         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4004         (remote_protocol_features): Remove associated entries.
4005         (_initialize_remote): No longer initialize them.
4006         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4007         * linux-nat.c (SPUFS_MAGIC): Remove.
4008         (linux_proc_xfer_spu): Remove.
4009         (spu_enumerate_spu_ids): Remove.
4010         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4011         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4012         (linux_make_corefile_notes): No longer call it.
4013
4014         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4015         (cooked_write_test): Likewise.
4016
4017 2019-09-20  Tom Tromey  <tom@tromey.com>
4018
4019         * NEWS: Mention case-sensitivity of TUI commands.
4020         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4021         (tui_set_win_height_command, parse_scrolling_args): Likewise.
4022         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4023
4024 2019-09-20  Tom Tromey  <tom@tromey.com>
4025
4026         * tui/tui-source.c (tui_source_window::set_contents): Use
4027         make_unique_xstrdup.
4028         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4029         make_unique_xstrdup.
4030
4031 2019-09-20  Tom Tromey  <tom@tromey.com>
4032
4033         * tui/tui-data.c: Remove separator comments.
4034         * tui/tui-layout.c: Remove separator comments.
4035         * tui/tui-win.c: Remove separator comments.
4036         * tui/tui-wingeneral.c: Remove separator comments.
4037
4038 2019-09-20  Tom Tromey  <tom@tromey.com>
4039
4040         * tui/tui.h (strcat_to_buf): Don't declare.
4041         * tui/tui.c (strcat_to_buf): Remove.
4042
4043 2019-09-20  Tom Tromey  <tom@tromey.com>
4044
4045         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4046         from "fullname".
4047         * tui/tui-source.c (tui_source_window::set_contents)
4048         (tui_source_window::location_matches_p)
4049         (tui_source_window::maybe_update): Update.
4050
4051 2019-09-20  Tom Tromey  <tom@tromey.com>
4052
4053         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4054         Update.
4055         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4056         prefix.
4057         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4058         (tui_data_window::line_from_reg_element_no)
4059         (tui_data_window::first_reg_element_no_inline)
4060         (tui_data_window::show_registers)
4061         (tui_data_window::show_register_group)
4062         (tui_data_window::display_registers_from)
4063         (tui_data_window::display_registers_from_line)
4064         (tui_data_window::first_data_item_displayed)
4065         (tui_data_window::delete_data_content_windows)
4066         (tui_data_window::erase_data_content)
4067         (tui_data_window::do_scroll_vertical)
4068         (tui_data_window::refresh_window)
4069         (tui_data_window::check_register_values): Update.
4070
4071 2019-09-20  Tom Tromey  <tom@tromey.com>
4072
4073         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4074         (struct tui_locator_window) <full_name, proc_name>: Now
4075         std::string.
4076         * tui/tui-stack.c (tui_locator_window::make_status_line)
4077         (tui_locator_window::set_locator_fullname)
4078         (tui_locator_window::set_locator_info): Update.
4079         * tui/tui-source.c (tui_source_window::set_contents)
4080         (tui_source_window::showing_source_p): Update.
4081
4082 2019-09-20  Tom Tromey  <tom@tromey.com>
4083
4084         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4085         Don't call tui_locator_win_info_ptr.
4086
4087 2019-09-20  Tom Tromey  <tom@tromey.com>
4088
4089         * tui/tui-win.c (tui_resize_all): Don't call refresh.
4090
4091 2019-09-20  Tom Tromey  <tom@tromey.com>
4092
4093         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4094         height for locator.
4095         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4096         * tui/tui-layout.c (show_source_disasm_command, show_data)
4097         (show_source_or_disasm_and_command): Use 1 as height for locator.
4098
4099 2019-09-20  Tom Tromey  <tom@tromey.com>
4100
4101         * tui/tui.c (tui_enable): Update.
4102         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4103         Update.
4104         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4105         Update.
4106         * tui/tui-data.c (win_resized): Now bool.
4107         (tui_win_resized): Return bool.
4108         (tui_set_win_resized_to): Accept a bool.
4109
4110 2019-09-20  Tom Tromey  <tom@tromey.com>
4111
4112         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4113         Change type of "refresh_values_only".
4114         * tui/tui-regs.c (tui_data_window::show_register_group): Change
4115         type of "refresh_values_only".
4116
4117 2019-09-20  Tom Tromey  <tom@tromey.com>
4118
4119         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4120         std::string.
4121         (tui_disassemble): Add "pos" parameter.
4122         (tui_disasm_window::set_contents): Simplify.
4123
4124 2019-09-20  Tom Tromey  <tom@tromey.com>
4125
4126         * tui/tui-winsource.h (struct tui_source_window_base)
4127         <show_source_content>: Now private.
4128         * tui/tui-winsource.c
4129         (tui_source_window_base::show_source_content): Don't handle empty
4130         content case.
4131
4132 2019-09-20  Tom Tromey  <tom@tromey.com>
4133
4134         * tui/tui-layout.c (show_source_disasm_command)
4135         (show_source_or_disasm_and_command): Don't call
4136         show_source_content.
4137
4138 2019-09-20  Tom Tromey  <tom@tromey.com>
4139
4140         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4141         Declare.
4142         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4143         from tui_make_status_line.
4144         (tui_locator_window::rerender): Update.
4145
4146 2019-09-20  Tom Tromey  <tom@tromey.com>
4147
4148         * tui/tui-stack.c (tui_make_status_line): Return std::string.
4149         (tui_locator_window::rerender): Update.
4150
4151 2019-09-20  Tom Tromey  <tom@tromey.com>
4152
4153         * tui/tui-winsource.h (struct tui_source_window_base)
4154         <~tui_source_window_base>: Don't declare.
4155         <fullname>: Remove.
4156         * tui/tui-winsource.c (~tui_source_window_base): Remove.
4157         * tui/tui-source.h (struct tui_source_window) <fullname>: New
4158         member.
4159         * tui/tui-source.c (tui_source_window::set_contents): Update.
4160         (tui_source_window::location_matches_p)
4161         (tui_source_window::maybe_update): Update.
4162
4163 2019-09-20  Tom Tromey  <tom@tromey.com>
4164
4165         * tui/tui-winsource.h (~tui_source_element): Remove.
4166         (tui_source_element): Update.
4167         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4168         * tui/tui-winsource.c (tui_show_source_line): Update.
4169         * tui/tui-source.c (tui_source_window::set_contents): Update.
4170         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4171
4172 2019-09-20  Tom Tromey  <tom@tromey.com>
4173
4174         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4175         declare.
4176         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4177         tui_clear_source_windows_detail.
4178         * tui/tui-winsource.h (struct tui_source_window_base)
4179         <clear_detail>: Don't declare.
4180         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4181         Remove.
4182         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4183
4184 2019-09-20  Tom Tromey  <tromey@adacore.com>
4185
4186         PR ada/24919:
4187         * block.c (contained_in): Fix final return value.
4188
4189 2019-09-20  Alan Modra  <amodra@gmail.com>
4190
4191         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4192         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4193         (read_indirect_string_from_dwz): Use bfd accessor.
4194         * dwarf2read.h (struct dwz_file <filename>): Likewise.
4195         * machoread.c (macho_symfile_read_all_oso): Likewise.
4196         * solib.c (solib_bfd_open): Likewise.
4197
4198 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4199
4200         * eval.c: Move declaration of overload_resolution to...
4201         * value.h: ...here.
4202
4203 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4204
4205         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4206         * arm-linux-tdep.c: Likewise.
4207         * arm-nbsd-nat.c: Likewise.
4208         * arm-tdep.h: Declare arm_apcs_32.
4209         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4210
4211 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4212
4213         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4214         * dwarf2read.h: Declare dwarf_always_disassemble.
4215
4216 2019-09-19  Tom de Vries  <tdevries@suse.de>
4217
4218         PR gdb/25009
4219         * source-cache.c (source_cache::ensure): Catch exception thrown during
4220         construction of the highlighter.
4221
4222 2019-09-18  Alan Modra  <amodra@gmail.com>
4223
4224         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4225         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4226         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4227         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4228         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4229         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4230         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4231         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4232         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4233         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4234         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4235         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4236         * solib-spu.c, * solib-svr4.c, * solib-target.c,
4237         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4238         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4239         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4240         * mi/mi-interp.c: Update throughout for bfd section macro and
4241         function changes.
4242         * gcore (gcore_create_callback): Use bfd_set_section_lma.
4243         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4244
4245 2019-09-18  Tom Tromey  <tom@tromey.com>
4246
4247         * NEWS: Add entry.
4248         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
4249         call rl_initialize.
4250         (tui_enable): Do not call rl_initialize.
4251
4252 2019-09-18  Christian Groessler  <chris@groessler.org>
4253
4254         * alpha-linux-nat.c: Include gdbarch.h.
4255
4256 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
4257
4258         * ui-file.c: Include cli/cli-style.h.
4259         (term_cli_styling): Remove cli_styling declaration.
4260
4261 2019-09-18  Alan Modra  <amodra@gmail.com>
4262
4263         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4264         to bfd_asymbol_section.
4265
4266 2019-09-18  Alan Modra  <amodra@gmail.com>
4267
4268         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4269         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4270         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4271
4272 2019-09-18  Alan Modra  <amodra@gmail.com>
4273
4274         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4275         * spu-linux-nat.c (spu_bfd_open): Likewise.
4276
4277 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
4278
4279         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4280         to bool to match definition in dwarf2read.c.
4281
4282 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
4283
4284         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4285         (print_signatures): Likewise.
4286         (trust_pad_over_xvs): Likewise.
4287         * arch/aarch64-insn.c (aarch64_debug): Likewise.
4288         * arch/aarch64-insn.h (aarch64_debug): Likewise.
4289         * arm-linux-nat.c (arm_apcs_32): Likewise.
4290         * arm-linux-tdep.c (arm_apcs_32): Likewise.
4291         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4292         * arm-tdep.c (arm_debug): Likewise.
4293         (arm_apcs_32): Likewise.
4294         * auto-load.c (debug_auto_load): Likewise.
4295         (auto_load_gdb_scripts): Likewise.
4296         (global_auto_load): Likewise.
4297         (auto_load_local_gdbinit): Likewise.
4298         (auto_load_local_gdbinit_loaded): Likewise.
4299         * auto-load.h (global_auto_load): Likewise.
4300         (auto_load_local_gdbinit): Likewise.
4301         (auto_load_local_gdbinit_loaded): Likewise.
4302         * breakpoint.c (disconnected_dprintf): Likewise.
4303         (breakpoint_proceeded): Likewise.
4304         (automatic_hardware_breakpoints): Likewise.
4305         (always_inserted_mode): Likewise.
4306         (target_exact_watchpoints): Likewise.
4307         (_initialize_breakpoint): Update.
4308         * breakpoint.h (target_exact_watchpoints): Change to bool.
4309         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4310         * cli/cli-cmds.c (trace_commands): Likewise.
4311         * cli/cli-cmds.h (trace_commands): Likewise.
4312         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4313         to bool*.
4314         * cli/cli-logging.c (logging_overwrite): Change to bool.
4315         (logging_redirect): Likewise.
4316         (debug_redirect): Likewise.
4317         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4318         (struct boolean_option_def) <get_var_address_cb_>: Change return type
4319         to bool.
4320         <boolean_option_def>: Update.
4321         (struct flag_option_def): Change default type of Context to bool
4322         from int.
4323         <flag_option_def>: Change return type of var_address_cb_ to bool*.
4324         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4325         (get_setshow_command_value_string): Likewise.
4326         * cli/cli-style.c (cli_styling): Change to bool.
4327         (source_styling): Likewise.
4328         * cli/cli-style.h (source_styling): Likewise.
4329         (cli_styling): Likewise.
4330         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4331         to bool.
4332         * command.h (var_types): Update comment.
4333         (add_setshow_boolean_cmd): Change int* var argument to bool*.
4334         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4335         bool.
4336         (debug_compile_cplus_scopes): Likewise.
4337         * compile/compile-internal.h (compile_debug): Likewise.
4338         * compile/compile.c (compile_debug): Likewise.
4339         (struct compile_options) <raw>: Likewise.
4340         * cp-support.c (catch_demangler_crashes): Likewise.
4341         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4342         (usr_cmd_cris_dwarf2_cfi): Likewise.
4343         * csky-tdep.c (csky_debug): Likewise.
4344         * darwin-nat.c (enable_mach_exceptions): Likewise.
4345         * dcache.c (dcache_enabled_p): Likewise.
4346         * defs.h (info_verbose): Likewise.
4347         * demangle.c (demangle): Likewise.
4348         (asm_demangle): Likewise.
4349         * dwarf-index-cache.c (debug_index_cache): Likewise.
4350         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4351         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4352         * dwarf2read.c (check_physname): Likewise.
4353         (use_deprecated_index_sections): Likewise.
4354         (dwarf_always_disassemble): Likewise.
4355         * eval.c (overload_resolution): Likewise.
4356         * event-top.c (set_editing_cmd_var): Likewise.
4357         (exec_done_display_p): Likewise.
4358         * event-top.h (set_editing_cmd_var): Likewise.
4359         (exec_done_display_p): Likewise.
4360         * exec.c (write_files): Likewise.
4361         * fbsd-nat.c (debug_fbsd_lwp): Likewise
4362         (debug_fbsd_nat): Likewise.
4363         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4364         Likewise.
4365         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4366         <backtrace_past_entry> Likewise.
4367         * gdb-demangle.h (demangle): Likewise.
4368         (asm_demangle): Likewise.
4369         * gdb_bfd.c (bfd_sharing): Likewise.
4370         * gdbcore.h (write_files): Likewise.
4371         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4372         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4373         * gdbthread.h (print_thread_events): Likewise.
4374         * gdbtypes.c (opaque_type_resolution): Likewise.
4375         (strict_type_checking): Likewise.
4376         * gnu-nat.c (gnu_debug_flag): Likewise.
4377         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4378         * guile/scm-param.c (pascm_variable): Add boolval.
4379         (add_setshow_generic): Update.
4380         (pascm_param_value): Update.
4381         (pascm_set_param_value_x): Update.
4382         * hppa-tdep.c (hppa_debug): Change to bool..
4383         * infcall.c (may_call_functions_p): Likewise.
4384         (coerce_float_to_double_p): Likewise.
4385         (unwind_on_signal_p): Likewise.
4386         (unwind_on_terminating_exception_p): Likewise.
4387         * infcmd.c (startup_with_shell): Likewise.
4388         * inferior.c (print_inferior_events): Likewise.
4389         * inferior.h (startup_with_shell): Likewise.
4390         (print_inferior_events): Likewise.
4391         * infrun.c (step_stop_if_no_debug): Likewise.
4392         (detach_fork): Likewise.
4393         (debug_displaced): Likewise.
4394         (disable_randomization): Likewise.
4395         (non_stop): Likewise.
4396         (non_stop_1): Likewise.
4397         (observer_mode): Likewise.
4398         (observer_mode_1): Likewise.
4399         (set_observer_mode): Update.
4400         (sched_multi): Change to bool.
4401         * infrun.h (debug_displaced): Likewise.
4402         (sched_multi): Likewise.
4403         (step_stop_if_no_debug): Likewise.
4404         (non_stop): Likewise.
4405         (disable_randomization): Likewise.
4406         * linux-tdep.c (use_coredump_filter): Likewise.
4407         (dump_excluded_mappings): Likewise.
4408         * linux-thread-db.c (auto_load_thread_db): Likewise.
4409         (check_thread_db_on_load): Likewise.
4410         * main.c (captured_main_1): Update.
4411         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4412         xx2_opt, boolean_opt>: Change to bool.
4413         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4414         * maint.c (maintenance_profile_p): Likewise.
4415         (per_command_time): Likewise.
4416         (per_command_space): Likewise.
4417         (per_command_symtab): Likewise.
4418         * memattr.c (inaccessible_by_default): Likewise.
4419         * mi/mi-main.c (mi_async): Likewise.
4420         (mi_async_1): Likewise.
4421         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4422         * nat/fork-inferior.h (startup_with_shell): Likewise.
4423         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4424         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4425         * nios2-tdep.c (nios2_debug): Likewise.
4426         * or1k-tdep.c (or1k_debug): Likewise.
4427         * parse.c (parser_debug): Likewise.
4428         * parser-defs.h (parser_debug): Likewise.
4429         * printcmd.c (print_symbol_filename): Likewise.
4430         * proc-api.c (procfs_trace): Likewise.
4431         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4432         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4433         (set_parameter_value): Update.
4434         (add_setshow_generic): Update.
4435         * python/py-value.c (copy_py_bool_obj): Change argument from int*
4436         to bool*.
4437         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4438         int*.
4439         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4440         * record-btrace.c (record_btrace_target::store_registers): Update.
4441         * record-full.c (record_full_memory_query): Change to bool.
4442         (record_full_stop_at_limit): Likewise.
4443         * record-full.h (record_full_memory_query): Likewise.
4444         * remote-notif.c (notif_debug): Likewise.
4445         * remote-notif.h (notif_debug): Likewise.
4446         * remote.c (use_range_stepping): Likewise.
4447         (interrupt_on_connect): Likewise.
4448         (remote_break): Likewise.
4449         * ser-tcp.c (tcp_auto_retry): Likewise.
4450         * ser-unix.c (serial_hwflow): Likewise.
4451         * skip.c (debug_skip): Likewise.
4452         * solib-aix.c (solib_aix_debug): Likewise.
4453         * spu-tdep.c (spu_stop_on_load_p): Likewise.
4454         (spu_auto_flush_cache_p): Likewise.
4455         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4456         Likewise.
4457         (struct info_print_options) <quiet>: Likewise.
4458         * symfile-debug.c (debug_symfile): Likewise.
4459         * symfile.c (auto_solib_add): Likewise.
4460         (separate_debug_file_debug): Likewise.
4461         * symfile.h (auto_solib_add): Likewise.
4462         (separate_debug_file_debug): Likewise.
4463         * symtab.c (basenames_may_differ): Likewise.
4464         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4465         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4466         (struct info_types_options) <quiet>: Likewise.
4467         * symtab.h (demangle): Likewise.
4468         (basenames_may_differ): Likewise.
4469         * target-dcache.c (stack_cache_enabled_1): Likewise.
4470         (code_cache_enabled_1): Likewise.
4471         * target.c (trust_readonly): Likewise.
4472         (may_write_registers): Likewise.
4473         (may_write_memory): Likewise.
4474         (may_insert_breakpoints): Likewise.
4475         (may_insert_tracepoints): Likewise.
4476         (may_insert_fast_tracepoints): Likewise.
4477         (may_stop): Likewise.
4478         (auto_connect_native_target): Likewise.
4479         (target_stop_and_wait): Update.
4480         (target_async_permitted): Change to bool.
4481         (target_async_permitted_1): Likewise.
4482         (may_write_registers_1): Likewise.
4483         (may_write_memory_1): Likewise.
4484         (may_insert_breakpoints_1): Likewise.
4485         (may_insert_tracepoints_1): Likewise.
4486         (may_insert_fast_tracepoints_1): Likewise.
4487         (may_stop_1): Likewise.
4488         * target.h (target_async_permitted): Likewise.
4489         (may_write_registers): Likewise.
4490         (may_write_memory): Likewise.
4491         (may_insert_breakpoints): Likewise.
4492         (may_insert_tracepoints): Likewise.
4493         (may_insert_fast_tracepoints): Likewise.
4494         (may_stop): Likewise.
4495         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4496         (make_thread_apply_all_options_def_group): Change argument from int*
4497         to bool*.
4498         (thread_apply_all_command): Update.
4499         (print_thread_events): Change to bool.
4500         * top.c (confirm): Likewise.
4501         (command_editing_p): Likewise.
4502         (history_expansion_p): Likewise.
4503         (write_history_p): Likewise.
4504         (info_verbose): Likewise.
4505         * top.h (confirm): Likewise.
4506         (history_expansion_p): Likewise.
4507         * tracepoint.c (disconnected_tracing): Likewise.
4508         (circular_trace_buffer): Likewise.
4509         * typeprint.c (print_methods): Likewise.
4510         (print_typedefs): Likewise.
4511         * utils.c (debug_timestamp): Likewise.
4512         (sevenbit_strings): Likewise.
4513         (pagination_enabled): Likewise.
4514         * utils.h (sevenbit_strings): Likewise.
4515         (pagination_enabled): Likewise.
4516         * valops.c (overload_resolution): Likewise.
4517         * valprint.h (struct value_print_options) <prettyformat_arrays,
4518         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4519         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4520         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4521         Likewise.
4522         * windows-nat.c (new_console): Likewise.
4523         (cygwin_exceptions): Likewise.
4524         (new_group): Likewise.
4525         (debug_exec): Likewise.
4526         (debug_events): Likewise.
4527         (debug_memory): Likewise.
4528         (debug_exceptions): Likewise.
4529         (useshell): Likewise.
4530         * windows-tdep.c (maint_display_all_tib): Likewise.
4531         * xml-support.c (debug_xml): Likewise.
4532
4533 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
4534
4535         * source.c (prepare_path_for_appending): New function.
4536         (openp): Make use of new function.
4537         (find_and_open_source): Search for the compilation directory and
4538         source file as a relative path beneath the directory search path.
4539
4540 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4541
4542         * source-cache.c (source_cache::get_line_charpos): Catch
4543         exceptions and return false, this matches the behaviour documented
4544         in the header file.
4545
4546 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
4547
4548         * ada-tasks.c (info_task): Remove quoting of the task's name.
4549
4550 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
4551
4552         * symfile.c (auto_solib_add): Replace comment with a reference
4553         to the header file.
4554
4555 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
4556
4557         * NEWS: Mention that gdb can now be compiled with Python 3
4558         on Windows.
4559
4560 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4561
4562         * maint.c (maint_print_section_data::maint_print_section_data):
4563         Force use of 'float log10 (float)' by casting the argument to
4564         float.
4565
4566 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4567
4568         * maint.c: Add 'cmath' include.
4569         (struct maint_print_section_data): New structure.
4570         (print_section_index): New function.
4571         (print_bfd_section_info): Add header comment, small whitespace
4572         cleanup, and update to call new print_section_index function.
4573         (print_objfile_section_info): Likewise.
4574         (maint_obj_section_from_bfd_section): New function.
4575         (print_bfd_section_info_maybe_relocated): New function.
4576         (maintenance_info_sections): Add header comment, always use
4577         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4578
4579 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4580
4581         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4582         inner scope, add check that the objfile has psymtabs before
4583         checking psymtabs_addrmap.
4584         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4585
4586 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4587
4588         * NEWS: Announce that Ada task names are now shown at more places,
4589         and between quotes (except in info task output).
4590         * gdb/ada-tasks.c (task_to_str): New function.
4591         (display_current_task_id): Call task_to_str.
4592         (task_command_1): Likewise.
4593         (print_ada_task_info): In non-mi mode, Properly align headers and data
4594         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4595
4596 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4597
4598         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4599         prstatus.pr_lwp.pr_info instead of making it up.
4600
4601 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4602
4603         * auto-load.c (auto_load_expand_dir_vars): Update.
4604         * defs.h (gdb_datadir): Change to std::string.
4605         (python_libdir): Likewise.
4606         (relocate_gdb_directory): Change return type to std::string.
4607         * guile/guile.c (gdbscm_data_directory): Update.
4608         (initialize_scheme_side): Update.
4609         * jit.c (jit_reader_dir): Change to std::string.
4610         (jit_reader_load_command): Update.
4611         * main.c (gdb_datadir): Change to std::string.
4612         (python_libdir): Likewise.
4613         (set_gdb_data_directory): Update.
4614         (relocate_path): Change to return std::string.
4615         (relocate_gdb_directory): Change to return std::string.
4616         (relocate_gdbinit_path_maybe_in_datadir): Update.
4617         (captured_main_1): Update.
4618         * python/python.c (do_start_initialization): Update.
4619         * top.c (show_gdb_datadir): Update.
4620         * xml-syscall.c (xml_init_syscalls_info): Update.
4621         (init_syscalls_info): Update.
4622
4623 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4624
4625         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4626         out of get_init_files.
4627         (get_init_files): Update.
4628
4629 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4630
4631         * main.c (get_init_files): Change to use std::string.
4632         (captured_main_1): Update.
4633         (print_gdb_help): Update.
4634
4635 2019-09-11  Ali Tamur  <tamur@google.com>
4636
4637         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4638         implementation.
4639
4640 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4641
4642         * dbxread.c (read_dbx_symtab): Update.
4643         * dwarf2read.c (load_partial_dies): Update.
4644         * mdebugread.c (parse_partial_symbols): Update.
4645         (handle_psymbol_enumerators): Update.
4646         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4647         * psymtab.c (add_psymbol_to_bcache): Likewise.
4648         (add_psymbol_to_list): Likewise.
4649         * symtab.c (symbol_set_names): Likewise.
4650         * symtab.h (symbol_set_names): Likewise.
4651         * xcoffread.c (scan_xcoff_symtab): Update.
4652
4653 2019-09-11  Tom Tromey  <tom@tromey.com>
4654
4655         * symfile-mem.c (symbol_file_add_from_memory): Use
4656         bfd_set_filename.
4657         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4658         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4659
4660 2019-09-10  Tom Tromey  <tromey@adacore.com>
4661
4662         * dwarf-index-write.c (write_psymbols): Extend error message.
4663         (debug_names::insert): Add Ada code.
4664         (debug_names::write_psymbols): Remove Ada check.
4665         (debug_names) <m_string_obstack>: New member.
4666         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4667         (gdb_index_symbol_name_matcher::matches): Remove.
4668         (mapped_index_base::find_name_components_bounds): Add "lang"
4669         parameter.
4670         (mapped_index_base::build_name_components): Also split names
4671         according to Ada syntax.
4672         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
4673         type of "match_callback".
4674         (check_match, check_find_bounds_finds)
4675         (dw2_expand_symtabs_matching): Update.
4676         (dw2_debug_names_iterator): Add new constructor.
4677         (dw2_debug_names_map_matching_symbols): New function.
4678         (dw2_debug_names_expand_symtabs_matching): Update.
4679         (dwarf2_debug_names_functions): Use
4680         dw2_debug_names_map_matching_symbols.
4681
4682 2019-09-10  Tom Tromey  <tromey@adacore.com>
4683
4684         * dwarf2read.c (dw2_get_file_names_reader): Add the
4685         CU's file name to the results.
4686
4687 2019-09-10  Tom Tromey  <tromey@adacore.com>
4688
4689         * ada-lang.c (add_nonlocal_symbols): Combine calls to
4690         map_matching_symbols.  Update.
4691         * dwarf2read.c (dw2_map_matching_symbols): Update.
4692         * psymtab.c (match_partial_symbol): Change type; update.
4693         (psym_map_matching_symbols): Likewise.
4694         * symfile-debug.c (debug_qf_map_matching_symbols): Change
4695         type; update.
4696         * symfile.h (struct quick_symbol_functions)
4697         <map_matching_symbols>: Change "name" to be a lookup_name_info.
4698         Remove "match".
4699
4700 2019-09-10  Tom Tromey  <tromey@adacore.com>
4701
4702         * psymtab.c (map_block): Remove.
4703         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4704         * symtab.c (iterate_over_symbols_terminated): New function.
4705         * symtab.c (iterate_over_symbols_terminated): Declare.
4706
4707 2019-09-10  Tom Tromey  <tromey@adacore.com>
4708
4709         * ada-lang.c (ada_iterate_over_symbols): Return bool.
4710         * language.h (struct language_defn) <la_iterate_over_symbols>:
4711         Return bool.
4712         * symtab.c (iterate_over_symbols): Return bool.
4713         * symtab.h (iterate_over_symbols): Return bool.
4714
4715 2019-09-10  Tom Tromey  <tromey@adacore.com>
4716
4717         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4718         (add_nonlocal_symbols): Update.
4719         * dwarf2read.c (dw2_map_matching_symbols): Change type.
4720         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4721         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4722         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4723         Change type of "callback".  Remove "data".
4724
4725
4726 2019-09-09  Ali Tamur  <tamur@google.com>
4727
4728         * dwarf2read.c (comp_unit_head): Update comment.
4729         (dwarf2_dwo_name): New function declaration.
4730         (dwarf_unit_type_name): New function declaration.
4731         (read_comp_unit_head): Add support for new compilation units,
4732         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4733         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4734         (currently named as "signature") in their header. Also clarify error
4735         messages.
4736         (lookup_dwo_id): New function. Returns the dwo id of the given
4737         compile unit.
4738         (lookup_dwo_unit): Use the new lookup_dwo_id function.
4739         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4740         functions.
4741         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4742         (dwarf2_dwo_name): Get the dwo name if present.
4743         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4744         purposes.
4745
4746 2019-09-09  Tom Tromey  <tom@tromey.com>
4747
4748         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4749
4750 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4751
4752         * python/python.c (do_start_initialization): Make progname_copy static,
4753         to avoid a leak report.
4754
4755 2019-09-08  Tom Tromey  <tom@tromey.com>
4756
4757         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4758
4759 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
4760
4761         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4762         Change type to gdb::optional<block_enum>.
4763         (dw2_symtab_iter_init): Change block_index parameter type
4764         to gdb::optional<block_enum>.
4765         (dw2_lookup_symbol): Change block_index parameter
4766         type to block_enum.c
4767         (dw2_debug_names_lookup_symbol): Likewise.
4768         * psymtab.c (psym_lookup_symbol): Likewise.
4769         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4770         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4771         Likewise.
4772
4773 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
4774
4775         * defs.h (relocate_gdb_directory): Change int to bool in
4776         signature and rename flag to relocatable.
4777         * main.c (relocate_path): Likewise.
4778         (relocate_gdb_directory): Likewise.
4779
4780 2019-09-06  Alan Modra  <amodra@gmail.com>
4781
4782         * coffread.c (coff_symfile_read): Constify filename variable.
4783         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4784         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4785         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4786         * solib.c (reload_shared_libraries_1): Likewise.
4787         * symfile.c (reread_symbols): Likewise.
4788         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4789         * solib-darwin.c (darwin_bfd_open): Likewise.
4790         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4791
4792 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4793
4794         * psymtab.c (print_partial_symbols): Handle missing domain_enum
4795         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4796
4797 2019-09-03  Tom Tromey  <tromey@adacore.com>
4798
4799         * ada-valprint.c (ada_val_print_num): Don't recurse for range
4800         types.
4801         (has_negatives): Unbias a range type bound.
4802         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4803         * gdbtypes.c (operator==): Handle new field.
4804         (create_range_type): Add "bias" parameter.
4805         (create_static_range_type, resolve_dynamic_range): Update.
4806         * gdbtypes.h (struct range_bounds) <bias>: New member.
4807         (create_range_type): Add bias parameter.
4808         * printcmd.c (print_scalar_formatted): Unbias range types.
4809         * value.c (unpack_long): Unbias range types.
4810         (pack_long): Bias range types.
4811
4812 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4813
4814         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4815         probe arguments.
4816
4817 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4818
4819         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4820         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4821         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4822         (compile_probe_arg): Likewise.
4823         * probe.h (get_argument_count): Likewise.
4824         * solib-svr4.c (solib_event_probe_action): Likewise.
4825         * stap-probe.c (stap_probe::get_argument_count): Likewise.
4826
4827 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4828
4829         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4830         code to here...
4831         (svr4_create_solib_event_breakpoints): ...from here.
4832
4833 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
4834
4835         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4836         suffix from warning message.
4837
4838 2019-08-30  Tom Tromey  <tom@tromey.com>
4839
4840         * tui/tui-winsource.h (struct tui_source_window_base)
4841         <refresh_all>: Don't declare.
4842         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4843         Remove.
4844         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4845         tui_show_locator_content.
4846         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4847         declare.
4848         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4849         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4850         declare.
4851
4852 2019-08-30  Tom Tromey  <tom@tromey.com>
4853
4854         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4855
4856 2019-08-30  Tom Tromey  <tom@tromey.com>
4857
4858         * tui/tui-stack.c (_initialize_tui_stack): Move later.
4859         Remove unnecessary forward declarations.
4860
4861 2019-08-30  Tom Tromey  <tom@tromey.com>
4862
4863         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4864         rerender.
4865         (tui_update_locator_fullname, tui_show_frame_info): Don't call
4866         tui_show_locator_content.
4867
4868 2019-08-30  Tom Tromey  <tom@tromey.com>
4869
4870         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
4871         (tui_locator_window::rerender): Rewrite using body of previous
4872         tui_show_locator_content.
4873
4874 2019-08-30  Tom Tromey  <tom@tromey.com>
4875
4876         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4877         set_locator_fullname>: New methods.
4878         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4879         Rename from tui_set_locator_fullname.
4880         (tui_locator_window::set_locator_info): Rename from
4881         tui_set_locator_info.  Return bool.
4882         (tui_update_locator_fullname, tui_show_frame_info): Update.
4883
4884 2019-08-30  Tom Tromey  <tom@tromey.com>
4885
4886         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4887
4888 2019-08-30  Tom Tromey  <tom@tromey.com>
4889
4890         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4891         call touchwin.
4892
4893 2019-08-30  Tom Tromey  <tom@tromey.com>
4894
4895         * tui/tui-wingeneral.c (box_win): Assume win_info and
4896         win_info->handle cannot be NULL.
4897
4898 2019-08-30  Tom Tromey  <tom@tromey.com>
4899
4900         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4901         refresh_window>: Declare.
4902         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4903         resize.
4904         (tui_data_item_window::rerender): Rename from
4905         tui_display_register.
4906         (tui_data_item_window::refresh_window): New method.
4907         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4908         no-op.
4909
4910 2019-08-30  Tom Tromey  <tom@tromey.com>
4911
4912         * tui/tui-regs.h (struct tui_data_window) <regs_content,
4913         regs_column_count, current_group>: Move later.  Now private.
4914         <get_current_group>: New method.
4915         * tui/tui-regs.c (tui_reg_command): Update.
4916         * tui/tui-layout.c (tui_set_layout): Update.
4917
4918 2019-08-30  Tom Tromey  <tom@tromey.com>
4919
4920         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4921         (tui_data_window::rerender): Don't call
4922         check_and_display_highlight_if_needed.
4923         (tui_data_window::refresh_all): Remove call to
4924         erase_data_content.
4925
4926 2019-08-30  Tom Tromey  <tom@tromey.com>
4927
4928         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4929         (tui_data_window::display_registers_from)
4930         (tui_data_window::display_reg_element_at_line)
4931         (tui_data_window::display_registers_from_line): Remove checks of
4932         "empty".
4933
4934 2019-08-30  Tom Tromey  <tom@tromey.com>
4935
4936         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4937         Don't declare.
4938         * tui/tui-regs.c (tui_data_window::show_registers): Call
4939         rerender.
4940         (tui_data_window::rerender): Rename from display_all_data.
4941         (tui_data_window::rerender): Remove old implementation.
4942
4943 2019-08-30  Tom Tromey  <tom@tromey.com>
4944
4945         * tui/tui-regs.c (tui_data_window::display_all_data): Change
4946         text.
4947         * tui/tui-data.h (NO_DATA_STRING): Remove define.
4948
4949 2019-08-29  Bernhard Wodok  <barto@gmx.net>
4950             Sergio Durigan Junior  <sergiodj@redhat.com>
4951
4952         PR win32/24284
4953         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4954
4955 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4956
4957         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4958         when searching for types.
4959
4960 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4961
4962         * f-lang.c (f_language_defn): Use f_print_typedef.
4963         * f-lang.h (f_print_typedef): Declare.
4964         * f-typeprint.c (f_print_typedef): Define.
4965
4966 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
4967
4968         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4969
4970 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4971
4972         * cli/cli-utils.c (info_print_options_defs): Delete.
4973         (make_info_print_options_def_group): Delete.
4974         (extract_info_print_options): Delete.
4975         (info_print_command_completer): Delete.
4976         (info_print_args_help): Add extra parameter, and optionally
4977         include text about -n flag.
4978         * cli/cli-utils.h (struct info_print_options): Delete.
4979         (extract_info_print_options): Delete declaration.
4980         (info_print_command_completer): Delete declaration.
4981         (info_print_args_help): Add extra parameter, extend header
4982         comment.
4983         * python/python.c (gdbpy_rbreak): Pass additional parameter to
4984         search_symbols.
4985         * stack.c (struct info_print_options): New type.
4986         (info_print_options_defs): New file scoped variable.
4987         (make_info_print_options_def_group): New static function.
4988         (info_print_command_completer): New static function.
4989         (info_locals_command): Update to use new local functions.
4990         (info_args_command): Likewise.
4991         (_initialize_stack): Add extra parameter to calls to
4992         info_print_args_help.
4993         * symtab.c (search_symbols): Add extra parameter, use this to
4994         possibly excluse non-debug symbols.
4995         (symtab_symbol_info): Add extra parameter, which is passed on to
4996         search_symbols.
4997         (struct info_print_options): New type.
4998         (info_print_options_defs): New file scoped variable.
4999         (make_info_print_options_def_group): New static function.
5000         (info_print_command_completer): New static function.
5001         (info_variables_command): Update to use local functions, and pass
5002         extra parameter through to symtab_symbol_info.
5003         (info_functions_command): Likewise.
5004         (info_types_command): Pass additional argument through to
5005         symtab_symbol_info.
5006         (rbreak_command): Pass extra argument to search_symbols.
5007         (_initialize_symtab): Add extra arguments for calls to
5008         info_print_args_help, and update help text for 'info variables',
5009         'whereis', and 'info functions' commands.
5010         * symtab.h (search_symbols): Add extra argument to declaration.
5011         * NEWS: Mention new flags.
5012
5013 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
5014
5015         * symtab.c (lookup_static_symbol): Call the new function (and move
5016         it down to be next to lookup_global_symbol).
5017         (struct global_sym_lookup_data): Add block_enum member and rename to...
5018         (struct global_or_static_sym_lookup_data): ...this.
5019         (lookup_symbol_global_iterator_cb): Pass block_index instead of
5020         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5021         (lookup_symbol_global_or_static_iterator_cb): ...this.
5022         (lookup_global_or_static_symbol): New function.
5023         (lookup_global_symbol): Call new function.
5024
5025 2019-08-26  Tom de Vries  <tdevries@suse.de>
5026
5027         PR c++/24852
5028         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5029         when pc_probe.prob == NULL.
5030
5031 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5032
5033         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5034         variable symbol_linkage to symbol_linkage_.
5035
5036 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5037
5038         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5039         represent whether the symbol is static, dynamic, or we don't
5040         know.
5041
5042 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
5043
5044         * gdb/rx-tdep.c (rx_register_names): New.
5045         (rx_register_name): Delete.
5046         (rx_psw_type): Delete.
5047         (rx_fpsw_type): Delete.
5048         (rx_register_type): Delete.
5049         (rx_gdbarch_init): Convert target-descriptions.
5050         (_initialize_rx_tdep): Add initialize_tdesc_rx.
5051         * gdb/features/Makefile: Add rx.xml.
5052         * gdb/features/rx.xml: New.
5053         * gdb/features/rx.c: Generated.
5054         * gdb/NEWS: Mention target description support.
5055
5056 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5057
5058         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5059         *slot_ptr.
5060
5061 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5062
5063         * configure.ac: Don't check for 'dlfcn.h' (moved to
5064         gdbsupport/common.m4).
5065         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5066         'gdbsupport/'.
5067         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5068         * compile/compile-c-support.c: Include
5069         'gdbsupport/gdb-dlfcn.h'.
5070         * gdbsupport/common.m4: Check for 'dlfcn.h'.
5071         * gdb-dlfcn.c: Move to...
5072         * gdbsupport/gdb-dlfcn.c: ... here.
5073         * gdb-dlfcn.h: Move to...
5074         * gdbsupport/gdb-dlfcn.h: ... here.
5075
5076 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
5077
5078         * nios2-tdep.c (struct reg_value): Improve comments.  Make
5079         the offset field signed.
5080
5081 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5082
5083         * python/lib/gdb/__init__.py (_execute_file): New function.
5084         * python/python.c (python_run_simple_file): Call gdb._execute_file
5085         on Windows.
5086
5087 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5088
5089         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5090         all uses as this was never set to anything but a zero value.
5091
5092 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
5093
5094         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5095
5096 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
5097
5098         * tui/tui-data.h (tui_gen_win_info): Add an =default
5099         move constructor, required by some GCC versions.
5100
5101 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
5102
5103         * go32-nat.c (go32_sysinfo): Add hygon_p.
5104
5105 2019-08-20  Tom Tromey  <tom@tromey.com>
5106
5107         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5108         line_from_reg_element_no, first_reg_element_no_inline,
5109         display_all_data, delete_data_content_windows,
5110         erase_data_content>: Now private.
5111
5112 2019-08-20  Tom Tromey  <tom@tromey.com>
5113
5114         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5115         (tui_unhighlight_win, tui_highlight_win)
5116         (tui_win_info::make_window): Update.
5117         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5118
5119 2019-08-20  Tom Tromey  <tom@tromey.com>
5120
5121         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5122         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5123         (MAX_PID_WIDTH): Move to tui-stack.c.
5124         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5125         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5126         (MAX_PID_WIDTH): Move from tui-data.h.
5127
5128 2019-08-20  Tom Tromey  <tom@tromey.com>
5129
5130         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5131         * tui/tui-wingeneral.c (box_win): Change type of win_info.
5132         (box_win): Update.
5133         (tui_gen_win_info::make_window): Rename from tui_make_window.
5134         (tui_win_info::make_window): New method.
5135         (tui_gen_win_info::make_visible): Update.
5136         * tui/tui-source.c (tui_source_window::set_contents): Update.
5137         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5138         (tui_data_window::display_registers_from): Update.
5139         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5140         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5141         Declare.
5142         <can_box>: Remove.
5143         <title>: Remove.
5144         (struct tui_win_info) <make_window>: Declare.
5145         <can_box>: Now virtual.
5146         <title>: New member.
5147         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5148         * tui/tui-command.c (tui_cmd_window::resize): Update.
5149
5150 2019-08-20  Tom Tromey  <tom@tromey.com>
5151
5152         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5153         * tui/tui-regs.c (tui_data_window::show_registers): Update.
5154         (tui_data_window::check_register_values): Update.
5155
5156 2019-08-20  Tom Tromey  <tom@tromey.com>
5157
5158         * tui/tui-regs.h (struct tui_data_window): Use
5159         DISABLE_COPY_AND_ASSIGN.
5160         <regs_content>: Change type, removing unique_ptr.
5161         <tui_data_window>: Add move constructor.
5162         * tui/tui-regs.c (tui_data_window::show_registers)
5163         (tui_data_window::show_register_group)
5164         (tui_data_window::display_registers_from)
5165         (tui_data_window::display_registers_from)
5166         (tui_data_window::first_data_item_displayed)
5167         (tui_data_window::delete_data_content_windows)
5168         (tui_data_window::rerender, tui_data_window::refresh_window)
5169         (tui_data_window::check_register_values): Update.
5170
5171 2019-08-20  Tom Tromey  <tom@tromey.com>
5172
5173         * tui/tui-regs.h (struct tui_data_window) <show_registers,
5174         show_register_group>: Declare.
5175         (tui_show_register_group): Don't declare.
5176         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5177         tui_show_registers.
5178         (tui_data_window::show_register_group): Rename from
5179         tui_show_register_group.
5180         (tui_data_window::check_register_values, tui_reg_command):
5181         Update.
5182         * tui/tui-layout.c (tui_set_layout): Update.
5183
5184 2019-08-20  Tom Tromey  <tom@tromey.com>
5185
5186         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5187         Declare.
5188         (tui_check_register_values): Don't declare.
5189         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5190         from tui_check_register_values.
5191         * tui/tui-hooks.c (tui_register_changed): Update.
5192
5193 2019-08-20  Tom Tromey  <tom@tromey.com>
5194
5195         * tui/tui-regs.c (tui_reg_layout): Move later.
5196         (tui_show_registers): Don't enable TUI mode or change layout.
5197
5198 2019-08-20  Tom Tromey  <tom@tromey.com>
5199
5200         * tui/tui-regs.h (struct tui_data_item_window)
5201         <~tui_data_item_window>: Remove.
5202         <content>: Now a unique_xmalloc_ptr.
5203         * tui/tui-regs.c (tui_register_format): Return a
5204         unique_xmalloc_ptr.
5205         (tui_get_register): Update.
5206         (~tui_data_item_window): Remove.
5207         (tui_data_window::display_registers_from, tui_display_register):
5208         Update.
5209         * tui/tui-io.h (tui_expand_tabs): Update.
5210         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5211         Remove "col" parameter.
5212
5213 2019-08-20  Tom Tromey  <tom@tromey.com>
5214
5215         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5216         field.
5217         * tui/tui-regs.c (~tui_data_item_window): Update.
5218
5219 2019-08-20  Tom Tromey  <tom@tromey.com>
5220
5221         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5222         earlier.
5223
5224 2019-08-20  Tom Tromey  <tom@tromey.com>
5225
5226         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5227
5228 2019-08-20  Tom Tromey  <tom@tromey.com>
5229
5230         * tui/tui-source.h (struct tui_source_window): Update.
5231         * tui/tui-regs.c (tui_show_registers): Update.
5232         * tui/tui-disasm.h (struct tui_disasm_window): Update.
5233         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5234         (NO_REGS_STRING): Remove defines.
5235
5236 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
5237
5238         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5239         unnecessary thread walk if remote doesn't support the packet.
5240
5241 2019-08-19  Tom Tromey  <tromey@adacore.com>
5242
5243         * python/py-value.c (value_has_field): Fix indentation.
5244
5245 2019-08-19  Tom Tromey  <tromey@adacore.com>
5246
5247         * printcmd.c (do_one_display, info_display_command): Update.
5248         * block.h (contained_in): Return bool.  Add allow_nested
5249         parameter.
5250         * block.c (contained_in): Return bool.  Add allow_nested
5251         parameter.
5252
5253 2019-08-19  Tom Tromey  <tom@tromey.com>
5254
5255         * configure: Rebuild.
5256         * configure.ac: Disallow the combination of -static-libstdc++ and
5257         source highlight.
5258         * source-cache.c (get_language_name): Handle rust.
5259         (source_cache::get_source_lines): Ignore highlighting exceptions.
5260
5261 2019-08-16  Tom Tromey  <tom@tromey.com>
5262
5263         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5264         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5265         (struct tui_source_window_base) <make_visible, refresh_window,
5266         resize>: Remove methods.
5267         <execution_info>: Remove field.
5268         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5269         (tui_show_source_line, tui_source_window_base)
5270         (~tui_source_window_base): Update.
5271         (tui_source_window_base::resize)
5272         (tui_source_window_base::make_visible)
5273         (tui_source_window_base::refresh_window): Remove.
5274         (tui_source_window_base::update_exec_info): Update.
5275         * tui/tui-source.c (tui_source_window::set_contents): Update.
5276         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5277
5278 2019-08-16  Tom Tromey  <tom@tromey.com>
5279
5280         * tui/tui-hooks.c (tui_remove_hooks): Don't set
5281         deprecated_query_hook.
5282
5283 2019-08-16  Tom Tromey  <tom@tromey.com>
5284
5285         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5286         (tui_update_source_windows_with_line): Update.
5287         * tui/tui-source.h (struct tui_source_window)
5288         <show_symtab_source>: Declare.
5289         (tui_show_symtab_source): Don't declare.
5290         * tui/tui-source.c (tui_show_symtab_source): Rename from
5291         tui_show_symtab_source.
5292
5293 2019-08-16  Tom Tromey  <tom@tromey.com>
5294
5295         * tui/tui-winsource.h (struct tui_source_window_base)
5296         <set_contents>: Declare.
5297         * tui/tui-winsource.c
5298         (tui_source_window_base::update_source_window_as_is): Update.
5299         * tui/tui-source.h (struct tui_source_window) <set_contents>:
5300         Declare.
5301         (tui_set_source_content): Don't declare.
5302         * tui/tui-source.c (tui_source_window::set_contents): Rename from
5303         tui_set_source_content.
5304         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5305         Declare.
5306         (tui_set_disassem_content): Don't declare.
5307         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5308         tui_set_disassem_content.
5309
5310 2019-08-16  Tom Tromey  <tom@tromey.com>
5311
5312         * tui/tui-winsource.h (struct tui_source_window_base)
5313         <update_breakpoint_info>: Declare.
5314         (tui_update_breakpoint_info): Don't declare.
5315         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5316         (tui_update_all_breakpoint_info): Update.
5317         (tui_source_window_base::update_breakpoint_info): Rename from
5318         tui_update_breakpoint_info.
5319         (tui_source_window_base::update_exec_info): Update.
5320
5321 2019-08-16  Tom Tromey  <tom@tromey.com>
5322
5323         * tui/tui-winsource.h (struct tui_source_window_base)
5324         <update_source_window>: Declare.
5325         (tui_update_source_window): Don't declare.
5326         * tui/tui-winsource.c
5327         (tui_source_window_base::update_source_window): Rename from
5328         tui_update_source_window.
5329         (tui_source_window_base::rerender): Update.
5330         * tui/tui-source.c (tui_source_window::maybe_update): Update.
5331         * tui/tui-disasm.c (tui_show_disassem)
5332         (tui_show_disassem_and_update_source)
5333         (tui_disasm_window::maybe_update): Update.
5334
5335 2019-08-16  Tom Tromey  <tom@tromey.com>
5336
5337         * tui/tui-winsource.h (struct tui_source_window_base)
5338         <update_source_window_as_is>: Declare.
5339         (tui_update_source_window_as_is): Don't declare.
5340         * tui/tui-winsource.c (tui_update_source_window): Update
5341         (tui_source_window_base::update_source_window_as_is): Rename from
5342         tui_update_source_window_as_is.
5343         (tui_source_window_base::refill): Update.
5344         * tui/tui-source.c (tui_show_symtab_source): Update.
5345         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5346         Update.
5347
5348 2019-08-16  Tom Tromey  <tom@tromey.com>
5349
5350         * tui/tui-winsource.h (tui_update_source_window)
5351         (tui_update_source_window_as_is): Remove "noerror" parameter.
5352         * tui/tui-winsource.c (tui_update_source_window)
5353         (tui_update_source_window_as_is): Remove "noerror" parameter.
5354         (tui_update_source_windows_with_addr)
5355         (tui_update_source_windows_with_line)
5356         (tui_source_window_base::rerender)
5357         (tui_source_window_base::refill): Update.
5358         * tui/tui-source.h (tui_set_source_content)
5359         (tui_show_symtab_source): Remove "noerror" parameter.
5360         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5361         parameter.
5362         (tui_show_symtab_source): Likewise.
5363         (tui_source_window::maybe_update): Update.
5364         * tui/tui-disasm.c (tui_show_disassem)
5365         (tui_show_disassem_and_update_source)
5366         (tui_disasm_window::do_scroll_vertical)
5367         (tui_disasm_window::maybe_update): Update.
5368
5369 2019-08-16  Tom Tromey  <tom@tromey.com>
5370
5371         * tui/tui.c (tui_is_window_visible): Update.
5372         * tui/tui-wingeneral.c (tui_make_window)
5373         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5374         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5375         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5376         (tui_set_win_height_command, parse_scrolling_args): Update.
5377         * tui/tui-source.c (tui_source_window::style_changed): Update.
5378         * tui/tui-regs.c (tui_show_registers)
5379         (tui_data_window::first_data_item_displayed)
5380         (tui_data_window::delete_data_content_windows)
5381         (tui_check_register_values, tui_reg_command): Update.
5382         * tui/tui-disasm.c (tui_show_disassem): Update.
5383         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5384         method.
5385         <is_visible>: Remove field.
5386         * tui/tui-data.c (tui_next_win, tui_prev_win)
5387         (tui_delete_invisible_windows): Update.
5388
5389 2019-08-16  Tom Tromey  <tom@tromey.com>
5390
5391         * tui/tui-winsource.h (struct tui_source_window_base)
5392         <m_has_locator>: Remove.
5393         * tui/tui-layout.c (show_source_disasm_command, show_data)
5394         (show_source_or_disasm_and_command): Update.
5395
5396 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
5397
5398         * NEWS (Other MI changes): New subsection.
5399         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5400         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5401         * arch-utils.c (default_get_pc_address_flags): New function.
5402         * arch-utils.h (default_get_pc_address_flags): New declaration.
5403         * gdbarch.sh: Add get_pc_address_flags.
5404         * gdbarch.c: Regenerate.
5405         * gdbarch.h: Likewise.
5406         * stack.c (print_pc): New function.
5407         (print_frame_info) (print_frame): Call print_pc.
5408
5409 2019-08-16  Tom de Vries  <tdevries@suse.de>
5410
5411         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5412         print_objfile_section_info.
5413
5414 2019-08-15  Tom Tromey  <tom@tromey.com>
5415
5416         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5417         calling update_cmdwin_start_line.
5418         * tui/tui-winsource.h (struct tui_source_window_base)
5419         <do_make_visible_with_new_height, set_new_height>: Don't declare.
5420         <rerender>: Declare.
5421         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5422         Call rerender.
5423         (tui_source_window_base::set_new_height): Remove.
5424         (tui_source_window_base::rerender): Rename from
5425         do_make_visible_with_new_height.
5426         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5427         resize method.
5428         (tui_win_info::make_invisible_and_set_new_height)
5429         (tui_win_info::make_visible_with_new_height): Remove.
5430         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5431         Declare.
5432         * tui/tui-stack.c (tui_locator_window::rerender): New method.
5433         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5434         do_make_visible_with_new_height>: Don't declare.
5435         <rerender>: Declare.
5436         * tui/tui-regs.c (tui_data_window::rerender): Rename from
5437         set_new_height.
5438         (tui_data_window::do_make_visible_with_new_height): Remove.
5439         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5440         call tui_show_locator_content.
5441         (tui_gen_win_info::resize): Call rerender.
5442         (show_source_or_disasm_and_command): Don't call
5443         tui_show_locator_content.
5444         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5445         method.
5446         (struct tui_win_info) <rerender>: Declare.
5447         <set_new_height, make_invisible_and_set_new_height,
5448         make_visible_with_new_height>: Don't declare.
5449         * tui/tui-data.c (tui_win_list::rerender): New method.
5450         * tui/tui-command.h (struct tui_cmd_window)
5451         <do_make_visible_with_new_height>: Don't declare.
5452         * tui/tui-command.c
5453         (tui_cmd_window::do_make_visible_with_new_height): Remove.
5454
5455 2019-08-15  Tom Tromey  <tromey@adacore.com>
5456
5457         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5458         * ada-lang.c (ada_enum_name): Likewise.
5459
5460 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
5461
5462         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5463         leading underscore.
5464         (GdbOutputErrorFile): Likewise.
5465         (global scope): Adjust constructor calls to GdbOutput{,Error}File
5466         accordingly.
5467         (execute_unwinders): Rename to have a leading underscore.
5468         (auto_load_packages): Likewise.
5469         (global scope): Adjust call to auto_load_packages accordingly.
5470         (GdbSetPythonDirectory): Likewise.
5471         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5472         instead of execute_unwinders.
5473
5474 2019-08-15  Tom Tromey  <tom@tromey.com>
5475
5476         * tui/tui-layout.c (show_layout, show_source_disasm_command)
5477         (show_data): Don't change window visibility.
5478         (tui_gen_win_info::resize): Remove special case for command
5479         window.  Use wresize, when available.
5480         (show_source_or_disasm_and_command): Don't change window
5481         visibility.
5482         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5483         <make_visible>: New method.
5484         * tui/tui-command.c (tui_cmd_window::resize): New method.
5485
5486 2019-08-15  Tom Tromey  <tom@tromey.com>
5487
5488         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5489         (struct tui_source_windows): New.
5490         * tui/tui-winsource.c (tui_display_main): Update.
5491         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5492         (new_height_ok, parse_scrolling_args): Update.
5493         * tui/tui-layout.c (show_layout, show_data): Update.
5494         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5495         (tui_add_to_source_windows): Don't declare.
5496         * tui/tui-data.c (source_windows, tui_source_windows)
5497         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5498
5499 2019-08-15  Tom Tromey  <tom@tromey.com>
5500
5501         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5502         Rename from reset.
5503         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5504         * tui/tui-layout.c (show_source_disasm_command, show_data):
5505         Update.
5506         (tui_gen_win_info::resize): Rename.
5507         (show_source_or_disasm_and_command): Update.
5508         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5509         reset.
5510
5511 2019-08-15  Tom Tromey  <tom@tromey.com>
5512
5513         * tui/tui-stack.c (tui_initialize_static_data): Remove.
5514         * tui/tui-interp.c (tui_interp::init): Don't call
5515         tui_initialize_static_data.
5516         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5517
5518 2019-08-15  Tom Tromey  <tom@tromey.com>
5519
5520         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5521         examine tui_win_list.
5522
5523 2019-08-15  Tom Tromey  <tom@tromey.com>
5524
5525         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5526         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5527         tui_clear_source_content.
5528         (tui_clear_source_content): Remove.
5529         (tui_source_window_base::do_erase_source_content): Hoist call to
5530         content.clear().
5531         * tui/tui-stack.c (tui_show_frame_info): Don't call
5532         tui_clear_source_content.
5533
5534 2019-08-15  Tom Tromey  <tom@tromey.com>
5535
5536         * tui/tui-winsource.h (struct tui_source_window_base)
5537         <do_erase_source_content>: New method.
5538         <erase_source_content>: New method.
5539         (tui_erase_source_content): Don't declare.
5540         * tui/tui-winsource.c (tui_clear_source_content): Update.
5541         (tui_source_window_base::do_erase_source_content): Rename from
5542         tui_erase_source_content.
5543         (tui_source_window_base::show_source_content): Update.
5544         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5545         * tui/tui-source.h (struct tui_source_window)
5546         <erase_source_content>: New method.
5547         * tui/tui-disasm.h (struct tui_disasm_window)
5548         <erase_source_content>: New method.
5549
5550 2019-08-15  Tom Tromey  <tom@tromey.com>
5551
5552         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5553         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5554         constructor.
5555         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5556         * tui/tui-source.c (tui_set_source_content): Update.
5557         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5558
5559 2019-08-15  Tom Tromey  <tom@tromey.com>
5560
5561         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5562         * tui/tui-winsource.c (tui_line_is_displayed): Move to
5563         tui-source.c.
5564         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5565         Declare.
5566         * tui/tui-source.c (tui_source_window::line_is_displayed): New
5567         method.
5568         (tui_source_window::maybe_update): Update.
5569
5570 2019-08-15  Tom Tromey  <tom@tromey.com>
5571
5572         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5573         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5574         tui-disasm.c.
5575         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5576         Declare.
5577         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5578         method.
5579         (tui_disasm_window::maybe_update): Update.
5580
5581 2019-08-15  Tom Tromey  <tom@tromey.com>
5582
5583         * tui/tui-winsource.h (struct tui_source_window_base)
5584         <maybe_update>: Declare.
5585         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5586         method.
5587         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5588         Declare.
5589         * tui/tui-source.c (tui_source_window::maybe_update): New method.
5590         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5591         Declare.
5592         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5593
5594 2019-08-15  Tom Tromey  <tom@tromey.com>
5595
5596         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5597
5598 2019-08-15  Tom Tromey  <tom@tromey.com>
5599
5600         * tui/tui-wingeneral.c: Include tui-stack.h.
5601         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5602         (struct tui_locator_window): Move from tui-data.h.
5603         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5604         (tui_initialize_static_data): Move from tui-data.c.
5605         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5606         (struct tui_locator_window): Move to tui-stack.c.
5607         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5608         (tui_initialize_static_data): Move to tui-stack.c.
5609
5610 2019-08-15  Tom Tromey  <tom@tromey.com>
5611
5612         * tui/tui-layout.c (show_source_disasm_command)
5613         (show_source_or_disasm_and_command): Use make_visible method, not
5614         tui_make_window.
5615         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5616         Remove.
5617
5618 2019-08-15  Tom Tromey  <tom@tromey.com>
5619
5620         * tui/tui-wingeneral.h (tui_make_window): Update.
5621         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5622         parameter.
5623         (tui_gen_win_info::make_visible): Update.
5624         * tui/tui-regs.c (tui_data_window::display_registers_from):
5625         Update.
5626         * tui/tui-layout.c (show_source_disasm_command)
5627         (show_source_or_disasm_and_command): Update.
5628         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5629         (enum tui_box): Remove.
5630         (struct tui_win_info) <can_box>: New method.
5631         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5632         method.
5633
5634 2019-08-15  Tom de Vries  <tdevries@suse.de>
5635
5636         * linux-nat-trad.c: Include gdbarch.h.
5637
5638 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
5639
5640         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5641         register sizes.
5642
5643 2019-08-14  Tom Tromey  <tromey@adacore.com>
5644
5645         * darwin-nat.c: Include gdbarch.h.
5646         * darwin-nat-info.c: Include gdbarch.h.
5647
5648 2019-08-13  Tom Tromey  <tom@tromey.com>
5649
5650         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5651         Remove.
5652         * tui/tui-data.c (tui_initialize_static_data): Update.
5653
5654 2019-08-13  Tom Tromey  <tom@tromey.com>
5655
5656         * tui/tui-winsource.h (struct tui_exec_info_window)
5657         <~tui_exec_info_window, maybe_allocate_content, get_content,
5658         m_content>: Remove.
5659         (struct tui_source_window_base) <set_exec_info_content,
5660         show_exec_info_content>: Don't declare.
5661         * tui/tui-winsource.c
5662         (tui_exec_info_window::maybe_allocate_content): Remove.
5663         (tui_source_window_base::update_exec_info): Rename from
5664         set_exec_info_content.
5665         (tui_source_window_base::show_exec_info_content)
5666         (tui_source_window_base::update_exec_info): Remove.
5667
5668 2019-08-13  Tom Tromey  <tom@tromey.com>
5669
5670         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5671         declare.
5672         * tui/tui-winsource.c (tui_update_source_window_as_is)
5673         (tui_update_source_windows_with_addr, tui_erase_source_content):
5674         Update.
5675         (tui_clear_exec_info_content): Remove.
5676
5677 2019-08-13  Tom Tromey  <tom@tromey.com>
5678
5679         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5680         declare.
5681         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5682         call tui_erase_exec_info_content.
5683         (tui_clear_exec_info_content): Rename from
5684         tui_erase_exec_info_content.
5685         (tui_clear_exec_info_content): Delete.
5686
5687 2019-08-13  Tom Tromey  <tom@tromey.com>
5688
5689         * tui/tui-winsource.h (struct tui_source_window_base)
5690         <show_exec_info_content>: Declare.
5691         (tui_show_exec_info_content): Don't declare.
5692         * tui/tui-winsource.c
5693         (tui_source_window_base::show_exec_info_content): Rename from
5694         tui_show_exec_info_content.
5695         (tui_source_window_base::update_exec_info): Update.
5696
5697 2019-08-13  Tom Tromey  <tom@tromey.com>
5698
5699         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5700         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5701         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5702         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5703         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5704         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5705         ... here.
5706
5707 2019-08-13  Tom Tromey  <tom@tromey.com>
5708
5709         * tui/tui-winsource.h (struct tui_source_window_base)
5710         <update_exec_info>: Declare.
5711         (tui_update_exec_info): Don't declare.
5712         * tui/tui-winsource.c (tui_update_source_window_as_is)
5713         (tui_source_window_base::refresh_all)
5714         (tui_update_all_breakpoint_info): Update.
5715         (tui_source_window_base::update_exec_info): Rename from
5716         tui_update_exec_info.
5717         * tui/tui-stack.c (tui_show_frame_info): Update.
5718
5719 2019-08-13  Tom Tromey  <tom@tromey.com>
5720
5721         * tui/tui-winsource.h (struct tui_source_window_base)
5722         <set_exec_info_content>: Declare.
5723         (tui_set_exec_info_content): Don't declare.
5724         * tui/tui-winsource.c
5725         (tui_source_window_base::set_exec_info_content): Rename from
5726         tui_set_exec_info_content.
5727         (tui_update_exec_info): Update.
5728
5729 2019-08-13  Tom Tromey  <tom@tromey.com>
5730
5731         * tui/tui-winsource.h (struct tui_source_window_base)
5732         <show_source_content>: Declare.
5733         (tui_show_source_content): Don't declare.
5734         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5735         (tui_source_window_base::show_source_content): Rename from
5736         tui_show_source_content.
5737         (tui_source_window_base::refresh_all): Update.
5738         * tui/tui-layout.c (show_source_disasm_command)
5739         (show_source_or_disasm_and_command): Update.
5740
5741 2019-08-13  Tom Tromey  <tom@tromey.com>
5742
5743         * tui/tui-winsource.c (tui_erase_source_content)
5744         (tui_show_source_content, tui_source_window_base::refresh_all):
5745         Update.
5746         * tui/tui-wingeneral.h
5747         (tui_check_and_display_highlight_if_needed): Don't declare.
5748         * tui/tui-wingeneral.c
5749         (tui_win_info::check_and_display_highlight_if_needed): Rename from
5750         check_and_display_highlight_if_needed.
5751         * tui/tui-win.c (tui_rehighlight_all)
5752         (tui_win_info::make_visible_with_new_height): Update.
5753         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5754         (tui_data_window::erase_data_content)
5755         (tui_data_window::display_all_data): Update.
5756         * tui/tui-data.h (struct tui_win_info)
5757         <check_and_display_highlight_if_needed>: Declare.
5758
5759 2019-08-13  Tom Tromey  <tom@tromey.com>
5760
5761         * tui/tui-win.c (tui_resize_all): Call
5762         tui_delete_invisible_windows.
5763         * tui/tui-layout.c (show_layout): Call
5764         tui_delete_invisible_windows.
5765         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5766         * tui/tui-data.c (tui_delete_invisible_windows): New function.
5767
5768 2019-08-13  Tom Tromey  <tom@tromey.com>
5769
5770         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
5771         tui_add_win_to_layout.
5772
5773 2019-08-13  Tom Tromey  <tom@tromey.com>
5774
5775         * tui/tui-layout.h (tui_default_win_height): Don't declare.
5776         * tui/tui-layout.c (tui_default_win_height): Now static.
5777
5778 2019-08-13  Tom Tromey  <tom@tromey.com>
5779
5780         * tui/tui-layout.c (show_layout): Unify all layout cases into a
5781         single switch.
5782         (show_source_disasm_command, show_source_or_disasm_and_command):
5783         Don't check current layout.
5784
5785 2019-08-13  Tom Tromey  <tom@tromey.com>
5786
5787         * tui/tui-wingeneral.c (make_all_visible): Remove.
5788         (tui_make_all_invisible): Simplify.
5789         * tui/tui-layout.c (tui_make_all_invisible): Move from
5790         tui-wingeneral.c; simplify.
5791         (show_layout): Hoist call to tui_make_all_invisible.
5792         (show_data): Don't call tui_make_all_invisible.
5793
5794 2019-08-13  Tom Tromey  <tom@tromey.com>
5795
5796         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5797         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5798
5799 2019-08-13  Tom Tromey  <tom@tromey.com>
5800
5801         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5802         tui-data.c.
5803         (show_source_disasm_command, show_data)
5804         (show_source_or_disasm_and_command): Don't use
5805         tui_set_current_layout_to.
5806         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5807         * tui/tui-data.c (current_layout, tui_current_layout): Move to
5808         tui-layout.c.
5809         (tui_set_current_layout_to): Remove.
5810
5811 2019-08-13  Tom Tromey  <tom@tromey.com>
5812
5813         * tui/tui-layout.c (tui_set_layout): Update.
5814         * tui/tui-data.h (struct tui_layout_def): Remove.
5815         (tui_layout_def): Don't declare.
5816         * tui/tui-data.c (layout_def): Remove.
5817         (tui_layout_def): Remove.
5818
5819 2019-08-13  Tom Tromey  <tom@tromey.com>
5820
5821         * tui/tui-winsource.h (struct tui_source_window_base)
5822         <clear_detail>: No longer "override".
5823         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5824         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5825         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5826         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5827         Remove.
5828         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5829
5830 2019-08-13  Tom Tromey  <tromey@adacore.com>
5831
5832         * tracepoint.c: Don't include readline.h or history.h.
5833
5834 2019-08-12  Tom Tromey  <tom@tromey.com>
5835
5836         * configure: Rebuild.
5837         * configure.ac: Check for readline 7.
5838         * NEWS: Mention readline 7 requirement.
5839         * README: Update.
5840
5841 2019-08-12  Tom Tromey  <tom@tromey.com>
5842
5843         * mingw-hdep.c (gdb_select): Remove readline hack.
5844
5845 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5846
5847         * blockframe.c (find_pc_partial_function): Set *block to nullptr
5848         when the function fails.
5849
5850 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
5851
5852         * s390-tdep.c (s390_type_align): New function.
5853         (s390_gdbarch_init): Set it as type_align gdbarch method.
5854
5855 2019-08-09  Tom de Vries  <tdevries@suse.de>
5856
5857         PR gdb/24591
5858         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5859         pc_low with relocation offset.
5860
5861 2019-08-07  Tom Tromey  <tromey@adacore.com>
5862
5863         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5864         (print_frame_args): Update.
5865         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5866         Update.
5867         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5868         * frame.h (struct frame_arg): Add initializers.
5869         <error>: Now a unique_xmalloc_ptr.
5870
5871 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
5872
5873         * NEWS: Expand the Pointer Authentication entry.
5874         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5875         (aarch64_frame_unmask_lr): ... to this.
5876         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5877         Call aarch64_frame_unmask_lr.
5878         * frame.c (struct frame_info): Add "masked" variable.
5879         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5880         (fprint_frame): Check for masked pc.
5881         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5882         declarations.
5883         * python/py-framefilter.c (py_print_frame): Check for masked pc.
5884         * stack.c (print_frame): Check for masked pc.
5885
5886 2019-08-06  Tom Tromey  <tom@tromey.com>
5887
5888         * stabsread.c (patch_block_stabs, read_one_struct_field)
5889         (read_enum_type): Use obstack_strndup.
5890         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5891         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5892         * dwarf2read.c (guess_full_die_structure_name)
5893         (anonymous_struct_prefix): Use obstack_strndup.
5894         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5895         * c-exp.y (yylex): Use obstack_strndup.
5896         * ada-exp.y (write_object_renaming, write_ambiguous_var)
5897         (write_var_or_type): Use obstack_strndup.
5898
5899 2019-08-06  Tom Tromey  <tom@tromey.com>
5900
5901         * symfile.c (reread_symbols): Use obstack_strdup.
5902         * stabsread.c (read_type): Use obstack_strdup.
5903         * gdb_obstack.h (obstack_strdup): New overload.
5904         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5905         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5906         (dwarf2_canonicalize_name): Use obstack_strdup.
5907         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5908         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5909         Use obstack_strdup.
5910
5911 2019-08-06  Tom Tromey  <tom@tromey.com>
5912
5913         * gdb_obstack.h (obstack_strdup): Define.
5914         * gdb_obstack.c (obstack_strdup): Don't define.
5915
5916 2019-08-06  Tom Tromey  <tom@tromey.com>
5917
5918         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5919         obstack_strdup.
5920         * typeprint.c (typedef_hash_table::find_global_typedef): Use
5921         obstack_strdup.
5922         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5923         * stabsread.c (common_block_start): Use obstack_strdup.
5924         * objfiles.c (set_objfile_main_name, objfile): Use
5925         obstack_strdup.
5926         * namespace.c (add_using_directive): Use obstack_strdup.
5927         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5928         * jit.c (finalize_symtab): Use obstack_strdup.
5929         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5930         (guess_partial_die_structure_name, partial_die_info::fixup)
5931         (dwarf2_name): Use obstack_strdup.
5932         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5933         obstack_strdup.
5934         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5935         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5936         obstack_strdup.
5937         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5938
5939 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5940
5941         * unittests/help-doc-selftests.c: New file.
5942         * Makefile.in: Add the new file.
5943
5944 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5945
5946         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5947         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
5948         the full first line, except when FOR_VALUE_PREFIX.  In this case,
5949         the trailing '.' is not output, and the first character is uppercased.
5950         (print_help_for_command): Update call to print_doc_line.
5951         (print_doc_of_command): Likewise.
5952         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5953         * cli/cli-option.c (append_indented_doc): Do not append newline.
5954         (build_help_option): Append newline after first appended_indented_doc
5955         only if a second call is done.
5956         (build_help): Append 2 new lines before each option, except the first
5957         one.
5958         * compile/compile.c (_initialize_compile): Add new lines after
5959         %OPTIONS%, when not at the end of the help.
5960         Change help doc or code
5961         producing the help doc to respect the invariants.
5962         * maint-test-options.c (_initialize_maint_test_options): Likewise.
5963         Also removed the new line after 'Options:', as all other commands
5964         do not put an empty line between 'Options:' and the first option.
5965         * printcmd.c (_initialize_printcmd): Likewise.
5966         * stack.c (_initialize_stack): Likewise.
5967         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5968         incorrectly telling COMMAND is optional.
5969         * ada-lang.c (_initialize_ada_language): Change help doc or code
5970         producing the help doc to respect the invariants.
5971         * ada-tasks.c (_initialize_ada_tasks): Likewise.
5972         * breakpoint.c (_initialize_breakpoint): Likewise.
5973         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5974         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5975         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5976         * cli/cli-style.c (cli_style_option::add_setshow_commands,
5977         _initialize_cli_style): Likewise.
5978         * corelow.c (core_target_info): Likewise.
5979         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5980         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5981         * filesystem.c (_initialize_filesystem): Likewise.
5982         * frame.c (_initialize_frame): Likewise.
5983         * gnu-nat.c (add_task_commands): Likewise.
5984         * infcall.c (_initialize_infcall): Likewise.
5985         * infcmd.c (_initialize_infcmd): Likewise.
5986         * interps.c (_initialize_interpreter): Likewise.
5987         * language.c (_initialize_language): Likewise.
5988         * linux-fork.c (_initialize_linux_fork): Likewise.
5989         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5990         * maint.c (_initialize_maint_cmds): Likewise.
5991         * memattr.c (_initialize_mem): Likewise.
5992         * printcmd.c (_initialize_printcmd): Likewise.
5993         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5994         _RegEx): Likewise.
5995         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5996         * record-btrace.c (_initialize_record_btrace): Likewise.
5997         * record-full.c (_initialize_record_full): Likewise.
5998         * record.c (_initialize_record): Likewise.
5999         * regcache-dump.c (_initialize_regcache_dump): Likewise.
6000         * regcache.c (_initialize_regcache): Likewise.
6001         * remote.c (add_packet_config_cmd, init_remote_threadtests,
6002         _initialize_remote): Likewise.
6003         * ser-tcp.c (_initialize_ser_tcp): Likewise.
6004         * serial.c (_initialize_serial): Likewise.
6005         * skip.c (_initialize_step_skip): Likewise.
6006         * source.c (_initialize_source): Likewise.
6007         * stack.c (_initialize_stack): Likewise.
6008         * symfile.c (_initialize_symfile): Likewise.
6009         * symtab.c (_initialize_symtab): Likewise.
6010         * target-descriptions.c (_initialize_target_descriptions): Likewise.
6011         * top.c (init_main): Likewise.
6012         * tracefile-tfile.c (tfile_target_info): Likewise.
6013         * tracepoint.c (_initialize_tracepoint): Likewise.
6014         * tui/tui-win.c (_initialize_tui_win): Likewise.
6015         * utils.c (add_internal_problem_command): Likewise.
6016         * valprint.c (value_print_option_defs): Likewise.
6017
6018 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
6019
6020         PR build/24886
6021         * configure.ac: Drop enable-libmcheck support.
6022         * configure, config.in: Rebuild.
6023         * libmcheck.m4: Remove.
6024         * acinclude.m4: Don't include it.
6025         * Makefile.in: Don't distribute it.
6026         * top.c (print_gdb_configuration): Don't mention it.
6027
6028 2019-08-06  Tom Tromey  <tom@tromey.com>
6029
6030         * utils.c (set_output_style): Sometimes pass stream to
6031         emit_style_escape.
6032         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6033         * record-btrace.c (btrace_insn_history): Update.
6034         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6035         method.
6036         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6037         Update initializers.
6038         <m_uiout>: New field.
6039         <m_di>: Move lower.
6040         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6041         Remove "uiout" parameter.
6042         (dump_insns): Update.
6043         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6044         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6045
6046 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
6047
6048         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6049         (error_in_psymtab_expansion): Likewise.
6050         (lookup_symbol_via_quick_fns): Likewise.
6051         (basic_lookup_transparent_type_quick): Likewise.
6052         (basic_lookup_transparent_type_1): Likewise.
6053
6054 2019-08-06  Tom Tromey  <tromey@adacore.com>
6055
6056         * source.c (last_source_error): Now bool.
6057         (print_source_lines_base): Make "noprint" bool.  Only open
6058         source file when last_source_visited changes.
6059
6060 2019-08-06  Tom Tromey  <tromey@adacore.com>
6061
6062         * annotate.c (annotate_source_line): Use g_source_cache.
6063         * source-cache.c (source_cache::get_plain_source_lines): Change
6064         parameters.  Populate m_offset_cache.
6065         (source_cache::ensure): New method.
6066         (source_cache::get_line_charpos): New method.
6067         (extract_lines): Move lower.  Change parameters.
6068         (source_cache::get_source_lines): Move lower.
6069         * source-cache.h (class source_cache): Update comment.
6070         <get_line_charpos>: New method.
6071         <get_source_lines>: Update comment.
6072         <clear>: Clear m_offset_cache.
6073         <get_plain_source_lines>: Change parameters.
6074         <ensure>: New method
6075         <m_offset_cache>: New member.
6076         * source.c (forget_cached_source_info_for_objfile): Update.
6077         (info_source_command): Use g_source_cache.
6078         (find_source_lines, open_source_file_with_line_charpos): Remove.
6079         (print_source_lines_base, search_command_helper): Use g_source_cache.
6080         * source.h (open_source_file_with_line_charpos): Don't declare.
6081         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6082         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6083         Use g_source_cache.
6084
6085 2019-08-06  Tom Tromey  <tromey@adacore.com>
6086
6087         * source-cache.c (source_cache::get_plain_source_lines):
6088         Remove "first_line" and "last_line" parameters.
6089         (source_cache::get_source_lines): Cache plain text.
6090         * source-cache.h (class source_cache)
6091         <get_plain_source_lines>: Update.
6092
6093 2019-08-06  Tom Tromey  <tromey@adacore.com>
6094
6095         * source-cache.c (extract_lines): No longer a method.
6096         Changed type of parameter.  Include final newline.
6097         (selftests::extract_lines_test): New function.
6098         (_initialize_source_cache): Likewise.
6099         * source-cache.h (class source_cache)
6100         <extract_lines>: Don't declare.
6101
6102 2019-08-06  Tom Tromey  <tromey@adacore.com>
6103
6104         * breakpoint.c (init_breakpoint_sal): Update.
6105         (breakpoint): Update.
6106         * breakpoint.h (struct breakpoint) <filter>: Now a
6107         unique_xmalloc_ptr.
6108
6109 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6110
6111         * NEWS: Mention dictionary access on blocks.
6112         * python/py-block.c (blpy_getitem): New function.
6113         (block_object_as_mapping): New struct.
6114         (block_object_type): Use new struct for tp_as_mapping field.
6115
6116 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6117
6118         * objfiles.h (objfile): Add a comment describing partial symbols.
6119
6120 2019-08-05  Tom Tromey  <tromey@adacore.com>
6121
6122         * compile/compile.c (_initialize_compile): Use _(), not N_().
6123         * thread.c (_initialize_thread): Use _(), not N_().
6124         * stack.c (_initialize_stack): Use _(), not N_().
6125         * printcmd.c (_initialize_printcmd): Use _(), not N_().
6126
6127 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
6128
6129         * dwarf2read.c (struct dw2_symtab_iterator):
6130         <want_specific_block>: Remove.
6131         <block_index>: Change type to gdb::optional.
6132         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6133         change type of BLOCK_INDEX parameter to gdb::optional.
6134         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6135         (dw2_lookup_symbol): Don't pass argument for
6136         WANT_SPECIFIC_BLOCK.
6137         (dw2_expand_symtabs_for_function): Don't pass argument for
6138         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6139         (class dw2_debug_names_iterator)
6140         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6141         parameter, change BLOCK_INDEX type to gdb::optional.
6142         <m_want_specific_block>: Remove.
6143         <m_block_index>: Change type to gdb::optional.
6144         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6145         gdb::optional.  Re-write in function of gdb::optional.
6146         (dw2_debug_names_lookup_symbol): Don't pass argument for
6147         WANT_SPECIFIC_BLOCK.
6148         (dw2_debug_names_expand_symtabs_for_function): Don't pass
6149         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6150         BLOCK_INDEX.
6151
6152 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6153
6154         * NEWS: Mention changes to "info sources" command.
6155
6156 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6157
6158         * symtab.c (filename_partial_match_opts): New struct type.
6159         (struct output_source_filename_data): New members
6160         regexp, c_regexp, partial_match.
6161         (output_source_filename): Use new members to decide to print file.
6162         (info_sources_option_defs): New variable.
6163         (make_info_sources_options_def_group, print_info_sources_header,
6164         info_sources_command_completer):
6165         New functions.
6166         (info_sources_command): Read new optional arguments.
6167         (_initialize_symtab): Update info sources help.
6168
6169 2019-08-02  Alexandre Oliva <oliva@adacore.com>
6170
6171         * ada-lang.c (exception_support_info_v0): Renamed from...
6172         (default_exception_support_info): ... this.  Create new
6173         definition for v1.
6174         (ada_has_this_exception_support): Look up catch_handlers_sym.
6175         (ada_exception_support_info_sniffer): Try v0 after default.
6176
6177 2019-08-01  Tom Tromey  <tromey@adacore.com>
6178
6179         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6180         gdbarch.h.
6181
6182 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
6183
6184         * s12z-tdep.c: Fix include path for s12z-opc.h.
6185
6186 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
6187
6188         * NEWS: Require GNU make 3.82.
6189
6190 2019-07-16  Tom Tromey  <tom@tromey.com>
6191
6192         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6193         declare.
6194
6195 2019-07-30  Tom Tromey  <tromey@adacore.com>
6196
6197         * block.c (contained_in): Remove BLOCK_FUNCTION check.
6198
6199 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
6200
6201         * printcmd.c (print_address_symbolic): Print negative offsets.
6202         (build_address_symbolic): Force signed arithmetic when computing
6203         offset.
6204
6205 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
6206
6207         PR/24474: Add a function to lookup static variables.
6208         * NEWS: Mention this new function.
6209         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6210         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6211         * python/python.c (python_GdbMethods): Add new function.
6212
6213 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
6214
6215         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6216         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6217         (objfpy_lookup_static_symbol): New function.
6218         (objfile_object_methods): Add new functions.
6219
6220 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6221
6222         * NEWS: Mention 'set|show print frame-info'.  Mention new
6223         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
6224         backtrace argument.  Mention that python frame filtering code
6225         is now consistent with what 'backtrace' command prints.
6226
6227 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6228
6229         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6230         comments.
6231         (print_frame_info_auto, print_frame_info_source_line,
6232         print_frame_info_location, print_frame_info_source_and_location,
6233         print_frame_info_location_and_address, print_frame_info_short_location):
6234         New declarations.
6235         (struct frame_print_options): New member print_frame_info.
6236         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6237         * stack.h (get_user_print_what_frame_info): New declaration.
6238         (frame_show_address): New declaration.
6239         * stack.c (print_frame_arguments_choices): New value 'presence'.
6240         (print_frame_info_auto, print_frame_info_source_line,
6241         print_frame_info_location, print_frame_info_source_and_location,
6242         print_frame_info_location_and_address, print_frame_info_short_location,
6243         print_frame_info_choices, print_frame_info_print_what): New definitions.
6244         (print_frame_args): Only print dots for args if print frame-arguments
6245         is 'presence'.
6246         (frame_print_option_defs): New element for "frame-info".
6247         (get_user_print_what_frame_info): New function.
6248         (frame_show_address): Make non static.  Move comment to stack.h.
6249         (print_frame_info_to_print_what): New function.
6250         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
6251         to decide what to print.
6252         (backtrace_command_1): Handle the new print_frame_arguments_presence
6253         value.
6254         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6255         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6256         (py_print_frame): In non-mi mode, use LOCATION as default for
6257         print_what, similarly to frame information printed directly by
6258         backtrace command. Handle frame-info user option in non MI mode.
6259
6260 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6261
6262         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6263         Add case for debugging 32-bit target on 64-bit host.  Revise
6264         comment.
6265
6266 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6267
6268         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6269         instead of find_function_entry_range_from_pc.
6270
6271 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6272
6273         * stack.c (find_frame_funname): Remove code which preferred
6274         minsym over symtab sym in "certain pathological cases".
6275
6276         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6277         parameter.  Change type of "do_demangle" to bool.
6278         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6279         Pass suitable "prefer_sym_over_minsym" flag to
6280         build_address_symbolic().  Don't output "+" for negative offsets.
6281         * printcmd.c (print_address_symbolic): Update invocation of
6282         build_address_symbolic to include a "prefer_sym_over_minsym"
6283         flag.
6284         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6285         Restrict cases in which use of minimal symbol is preferred to that
6286         of a found symbol.  Update comments.
6287
6288         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6289         for entry pc when entry pc is out of range for that FDE.
6290
6291 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
6292
6293         PR gdb/24839:
6294         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6295         type.
6296
6297 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
6298
6299         * python/py-objfile.c (add_separate_debug_file): Fix comment about
6300         this function's Python signature.
6301
6302
6303 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
6304
6305         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6306         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6307         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6308         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6309         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6310
6311
6312 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
6313
6314         * h8300-tdep.c (h8300_register_name_common): New.
6315         h8300_register_name): Use h8300_register_name_common.
6316         (h8300s_register_name): Likewise.
6317         (h8300sx_register_name): Likewise.
6318         (h8300h_register_nam): New.
6319         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6320
6321
6322 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
6323
6324         * arm-tdep.c (arm_skip_cmse_entry): New function.
6325         (arm_is_sgstubs_section): New function.
6326         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6327
6328 2019-07-22  Tom Tromey  <tom@tromey.com>
6329
6330         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6331         Don't self-assign.
6332
6333 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6334
6335         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6336         type_print.
6337
6338 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6339
6340         * symtab.c (search_symbols): Adjust msymbol matching type arrays
6341         so that GDB doesn't match any msymbols when searching in the
6342         TYPES_DOMAIN.
6343         (print_symbol_info): Print using typedef_print or type_print based
6344         on the type of the symbol.  Add updated FIXME comment moved from...
6345         (_initialize_symtab): ... move and update FIXME comment to above.
6346
6347 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6348
6349         * NEWS: Mention adding -q option to "info types".
6350         * symtab.c (struct info_types_options): New struct.
6351         (info_types_options_defs): New variable.
6352         (make_info_types_options_def_group): New function.
6353         (info_types_command): Use gdb::option framework to parse options.
6354         (info_types_command_completer): New function.
6355         (_initialize_symtab): Extend the help text on "info types" and
6356         register command completer.
6357
6358 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
6359
6360         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6361         (lookup_symbol_in_objfile): Change int to block_enum and add a
6362         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6363
6364 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
6365
6366         * MAINTAINERS (Write After Approval): Add self.
6367
6368 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6369
6370         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6371         instruction to the dummy code region.
6372
6373 2019-07-19  Tom Tromey  <tromey@adacore.com>
6374
6375         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6376         (ARGSUSED, PARAMS, __func__): Remove rules.
6377
6378 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6379
6380         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6381         * features/arm/arm-with-iwmmxt.c: Remove.
6382         * features/arm/arm-with-iwmmxt.xml: Remove.
6383         * features/arm/arm-with-m-fpa-layout.c: Remove.
6384         * features/arm/arm-with-m-fpa-layout.xml: Remove.
6385         * features/arm/arm-with-m-vfp-d16.c: Remove.
6386         * features/arm/arm-with-m-vfp-d16.xml: Remove.
6387         * features/arm/arm-with-m.c: Remove.
6388         * features/arm/arm-with-m.xml: Remove.
6389         * features/arm/arm-with-neon.c: Remove.
6390         * features/arm/arm-with-neon.xml: Remove.
6391         * features/arm/arm-with-vfpv2.c: Remove.
6392         * features/arm/arm-with-vfpv2.xml: Remove.
6393         * features/arm/arm-with-vfpv3.c: Remove.
6394         * features/arm/arm-with-vfpv3.xml: Remove.
6395
6396 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6397
6398         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6399
6400 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6401
6402         * arch/aarch32.c (aarch32_create_target_description): Create
6403         target descriptions using features.
6404         * arch/arm.c (arm_create_target_description)
6405         (arm_create_mprofile_target_description): Likewise.
6406         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6407
6408 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6409
6410         * Makefile.in: Add new files.
6411         * aarch32-tdep.c: New file.
6412         * aarch32-tdep.h: New file.
6413         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6414         Call aarch32_read_description.
6415         * arch/aarch32.c: New file.
6416         * arch/aarch32.h: New file.
6417         * arch/arm.c (arm_create_target_description)
6418         (arm_create_mprofile_target_description): New function.
6419         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6420         (arm_create_target_description)
6421         (arm_create_mprofile_target_description): New declaration.
6422         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6423         read_description functions.
6424         * arm-linux-nat.c (arm_linux_nat_target::read_description):
6425         Likewise.
6426         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6427         * arm-tdep.c (tdesc_arm_list): New variable.
6428         (arm_register_g_packet_guesses): Call create description functions.
6429         (arm_read_description) (arm_read_mprofile_description): New
6430         function.
6431         * arm-tdep.h (arm_read_description)
6432         (arm_read_mprofile_description): Add declaration.
6433         * configure.tgt: Add new files.
6434
6435 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
6436
6437         * top.c (new_ui_command): Open specified terminal just once.
6438
6439 2019-07-18  Tom Tromey  <tromey@adacore.com>
6440
6441         * symtab.c (main_name): Constify return type.
6442         * symfile.c (set_initial_language): Update.
6443         * symtab.h (main_name): Constify return type.
6444
6445 2019-07-17  Tom Tromey  <tom@tromey.com>
6446
6447         * tui/tui-winsource.c (tui_update_source_window)
6448         (tui_update_source_window_as_is)
6449         (tui_update_source_windows_with_line): Remove return.
6450         * tui/tui-disasm.c (tui_show_disassem)
6451         (tui_show_disassem_and_update_source): Remove return.
6452         * tui/tui.c (tui_reset): Remove return.
6453         * tui/tui-wingeneral.c
6454         (tui_check_and_display_highlight_if_needed): Remove return.
6455
6456 2019-07-17  Tom Tromey  <tom@tromey.com>
6457
6458         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6459
6460 2019-07-17  Tom Tromey  <tom@tromey.com>
6461
6462         * tui/tui-winsource.h (struct tui_exec_info_window)
6463         (struct tui_source_window_base): Move from tui-data.h.
6464         * tui/tui-winsource.c: Move many method definitions from
6465         elsewhere.  Remove "structuring" comments.
6466         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6467         (tui_source_window_base::refresh_window): Move to
6468         tui-winsource.c.
6469         * tui/tui-win.c (tui_source_window_base::refresh_all)
6470         (tui_source_window_base::update_tab_width)
6471         (tui_source_window_base::set_new_height)
6472         (tui_source_window_base::do_make_visible_with_new_height): Move to
6473         tui-winsource.c.
6474         * tui/tui-source.h: Update.
6475         * tui/tui-source.c (tui_source_window_base::reset): Move to
6476         tui-winsource.c.
6477         * tui/tui-disasm.h: Update.
6478         * tui/tui-data.h (struct tui_exec_info_window): Move to
6479         tui-winsource.h.
6480         (struct tui_source_window_base): Likewise.
6481         * tui/tui-data.c (tui_source_window_base::clear_detail)
6482         (tui_source_window_base, ~tui_source_window_base): Move to
6483         tui-winsource.c.
6484
6485 2019-07-17  Tom Tromey  <tom@tromey.com>
6486
6487         * tui/tui-win.c (tui_resize_all)
6488         (tui_source_window_base::update_tab_width)
6489         (tui_adjust_win_heights): Update.
6490         (tui_win_info::make_invisible_and_set_new_height): Rename from
6491         make_invisible_and_set_new_height.
6492         * tui/tui-data.h (struct tui_win_info)
6493         <make_invisible_and_set_new_height>: New method.
6494
6495 2019-07-17  Tom Tromey  <tom@tromey.com>
6496
6497         * tui/tui.c: Update.
6498         * tui/tui-source.h (struct tui_source_window): Move from
6499         tui-data.h.
6500         * tui/tui-layout.c: Update.
6501         * tui/tui-disasm.c: Update.
6502         * tui/tui-data.h (struct tui_source_window): Move to
6503         tui-source.h.
6504
6505 2019-07-17  Tom Tromey  <tom@tromey.com>
6506
6507         * tui/tui-disasm.h (struct tui_disasm_window): Move from
6508         tui-data.h.
6509         * tui/tui-data.h (struct tui_disasm_window): Move to
6510         tui-disasm.h.
6511
6512 2019-07-17  Tom Tromey  <tom@tromey.com>
6513
6514         * tui/tui-regs.h (struct tui_data_item_window): Move from
6515         tui-data.h.
6516         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6517         * tui/tui-data.h (struct tui_data_item_window): Move to
6518         tui-regs.h.
6519         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6520
6521 2019-07-17  Tom Tromey  <tom@tromey.com>
6522
6523         * tui/tui.c: Update.
6524         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6525         (tui_cmd_window::max_height): Move to tui-command.c.
6526         * tui/tui-layout.c: Update.
6527         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6528         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6529         tui-command.c.
6530         * tui/tui-command.h (struct tui_cmd_window): Move from
6531         tui-data.h.
6532         * tui/tui-command.c: Remove "structuring" comments.
6533         (tui_cmd_window::clear_detail)
6534         (tui_cmd_window::do_make_visible_with_new_height)
6535         (tui_cmd_window::max_height): Move from elsewhere.
6536
6537 2019-07-17  Tom Tromey  <tom@tromey.com>
6538
6539         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6540         Now static.
6541         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6542         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6543
6544 2019-07-17  Tom Tromey  <tom@tromey.com>
6545
6546         * tui/tui.c: Update.
6547         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6548         tui-regs.c.
6549         * tui/tui-windata.h: Remove file.
6550         * tui/tui-windata.c: Remove file.
6551         * tui/tui-win.c (tui_data_window::set_new_height)
6552         (tui_data_window::do_make_visible_with_new_height): Move to
6553         tui-regs.c.
6554         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6555         * tui/tui-regs.c: Remove "structuring" comments.
6556         (tui_data_window::first_data_item_displayed)
6557         (tui_data_window::delete_data_content_windows)
6558         (tui_data_window::erase_data_content)
6559         (tui_data_window::display_all_data)
6560         (tui_data_window::refresh_all)
6561         (tui_data_window::do_scroll_vertical)
6562         (tui_data_window::clear_detail, tui_data_window::set_new_height)
6563         (tui_data_window::do_make_visible_with_new_height)
6564         (tui_data_window::refresh_window): Move from elsewhere.
6565         (_initialize_tui_regs): Move to end of file.
6566         * tui/tui-layout.c: Update.
6567         * tui/tui-hooks.c: Update.
6568         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6569         * tui/tui-data.c (tui_data_window::clear_detail): Move to
6570         tui-regs.c.
6571         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6572
6573 2019-07-17  Tom Tromey  <tom@tromey.com>
6574
6575         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6576         seen.
6577
6578 2019-07-17  Tom Tromey  <tom@tromey.com>
6579
6580         * tui/tui-win.c (tui_source_window_base::set_new_height)
6581         (tui_source_window_base::do_make_visible_with_new_height): Use
6582         m_has_locator field directly.
6583         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6584         method.
6585         (struct tui_source_window_base) <has_locator>: Likewise.
6586
6587 2019-07-17  Tom Tromey  <tom@tromey.com>
6588
6589         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6590         Don't declare.
6591         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6592         Remove.
6593         * tui/tui-win.c (tui_source_window_base::set_new_height)
6594         (tui_source_window_base::set_new_height)
6595         (make_invisible_and_set_new_height)
6596         (tui_source_window_base::do_make_visible_with_new_height)
6597         (tui_source_window_base::do_make_visible_with_new_height):
6598         Update.
6599         * tui/tui-layout.c (show_source_disasm_command, show_data)
6600         (show_source_or_disasm_and_command): Update.
6601         * tui/tui-layout.c (show_layout): Update.
6602
6603 2019-07-17  Tom Tromey  <tom@tromey.com>
6604
6605         * tui/tui-layout.c (make_data_window): Remove.
6606         (show_data): Unify creation and re-initialization cases.
6607
6608 2019-07-17  Tom Tromey  <tom@tromey.com>
6609
6610         * tui/tui-layout.c (make_source_window, make_disasm_window):
6611         Remove.
6612         (show_data): Unify creation and re-initialization cases.
6613
6614 2019-07-17  Tom Tromey  <tom@tromey.com>
6615
6616         * tui/tui-layout.c (make_command_window): Remove.
6617         (show_source_disasm_command, show_source_or_disasm_and_command):
6618         Unify creation and re-initialization cases.
6619
6620 2019-07-17  Tom Tromey  <tom@tromey.com>
6621
6622         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6623         creation and re-initialization cases.
6624
6625 2019-07-17  Tom Tromey  <tom@tromey.com>
6626
6627         * tui/tui-regs.c (tui_get_register): Return void.
6628
6629 2019-07-17  Tom Tromey  <tom@tromey.com>
6630
6631         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6632         Simplify.
6633
6634 2019-07-17  Tom Tromey  <tom@tromey.com>
6635
6636         * tui/tui-layout.c (show_source_disasm_command): Simplify window
6637         resetting.
6638
6639 2019-07-17  Tom Tromey  <tom@tromey.com>
6640
6641         * tui/tui.h (tui_set_layout_by_name): Don't declare.
6642         * tui/tui-regs.c (tui_reg_layout): New function.
6643         (tui_show_registers, tui_reg_command): Use it.
6644         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6645         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
6646         parameters.
6647         (tui_layout_command): Remove.
6648
6649 2019-07-17  Tom Tromey  <tom@tromey.com>
6650
6651         * tui/tui-layout.h (tui/tui-layout): Return void.
6652         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
6653
6654 2019-07-17  Tom Tromey  <tom@tromey.com>
6655
6656         * tui/tui-layout.c (show_source_disasm_command, show_data):
6657         Update.
6658         (reset_locator): Remove.
6659         (show_source_or_disasm_and_command): Update.
6660
6661 2019-07-17  Tom Tromey  <tom@tromey.com>
6662
6663         * tui/tui-source.c (tui_source_window_base::reset): Remove
6664         win_type parameter.
6665         * tui/tui-layout.c (make_command_window, make_source_window)
6666         (make_disasm_window, make_data_window)
6667         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6668         (reset_locator, show_source_or_disasm_and_command): Update.
6669         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6670         win_type parameter.
6671         (struct tui_source_window_base) <reset>: Likewise.
6672
6673 2019-07-17  Tom Tromey  <tom@tromey.com>
6674
6675         * tui/tui-layout.c (show_source_disasm_command): Use
6676         reset_locator.
6677         (reset_locator): New function.
6678         (init_and_make_win): Remove.
6679         (show_source_or_disasm_and_command): Use reset_locator.
6680
6681 2019-07-17  Tom Tromey  <tom@tromey.com>
6682
6683         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6684         condition.
6685         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6686         Remove condition.
6687         * tui/tui-source.c (tui_source_window_base::reset): New method.
6688         * tui/tui-layout.c (make_command_window): Don't call
6689         init_and_make_win.
6690         (make_source_window, make_disasm_window): Don't call
6691         make_source_or_disasm_window.
6692         (make_data_window): Don't call init_and_make_win.  Change calling
6693         convention.
6694         (show_source_disasm_command, show_data): Simplify.
6695         (make_source_or_disasm_window): Remove.
6696         (show_source_or_disasm_and_command): Simplify.
6697         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6698         (struct tui_source_window_base) <reset>: Likewise.
6699         <execution_info>: Remove initializer.
6700         * tui/tui-data.c (tui_source_window_base): Initialize
6701         execution_info.
6702
6703 2019-07-17  Tom Tromey  <tom@tromey.com>
6704
6705         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6706         variable.
6707
6708 2019-07-17  Tom Tromey  <tom@tromey.com>
6709
6710         * tui/tui.c (tui_rl_other_window): Update.
6711         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6712         superclass method first.  Always iterate over regs_content.
6713         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6714         method.
6715         * tui/tui-win.c (tui_set_focus_command): Update.
6716
6717 2019-07-17  Tom Tromey  <tom@tromey.com>
6718
6719         * tui/tui-win.c (tui_set_focus_command): Rename from
6720         tui_set_focus.  Call tui_enable.
6721         (tui_set_focus_command): Remove.
6722
6723 2019-07-17  Tom Tromey  <tom@tromey.com>
6724
6725         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6726         refresh_window.
6727         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6728         touchwin.
6729         (tui_data_window::refresh_window): Call refresh_window on data
6730         items.  Always call superclass refresh_window.
6731         (tui_win_info::refresh): Remove.
6732         (tui_source_window_base::refresh_window): Update.
6733         (tui_refresh_all): Update.
6734         * tui/tui-layout.c (show_source_disasm_command): Remove call to
6735         refresh_window.
6736         (show_source_or_disasm_and_command): Likewise.
6737         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6738         (struct tui_source_window_base) <refresh>: Likewise.
6739
6740 2019-07-17  Tom Tromey  <tom@tromey.com>
6741
6742         * tui/tui-winsource.c (tui_clear_source_content)
6743         (tui_show_source_content): Update.
6744         * tui/tui-source.c (tui_source_window::showing_source_p): Check
6745         whether content is empty.
6746         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6747         Remove.
6748
6749 2019-07-17  Tom Tromey  <tom@tromey.com>
6750
6751         * tui/tui-winsource.c (tui_erase_source_content): Clear the
6752         window's contents.
6753         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6754         * tui/tui-source.c (tui_set_source_content_nil): Remove.
6755
6756 2019-07-17  Tom Tromey  <tom@tromey.com>
6757
6758         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6759         (struct tui_data_item_window): Update.
6760
6761 2019-07-17  Tom Tromey  <tom@tromey.com>
6762
6763         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6764         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6765         defines.
6766
6767 2019-07-17  Tom Tromey  <tom@tromey.com>
6768
6769         * tui/tui-winsource.h (tui_erase_source_content)
6770         (tui_clear_source_content): Remove "display_prompt" parameter.
6771         * tui/tui-winsource.c (tui_update_source_window_as_is)
6772         (tui_update_source_windows_with_addr): Update.
6773         (tui_clear_source_content): Remove "display_prompt" parameter.
6774         (tui_erase_source_content): Likewise.  Simplify.
6775         (tui_show_source_content): Update.
6776         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6777         * tui/tui-stack.c (tui_show_frame_info): Update.
6778         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6779         Remove defines.
6780
6781 2019-07-17  Tom Tromey  <tom@tromey.com>
6782
6783         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6784         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6785         parameter.
6786         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6787         parameter.
6788
6789 2019-07-17  Tom Tromey  <tom@tromey.com>
6790
6791         * tui/tui-winsource.c (tui_clear_source_content)
6792         (tui_show_source_content, tui_show_exec_info_content)
6793         (tui_clear_exec_info_content): Update.
6794         * tui/tui-stack.c (tui_show_locator_content): Update.
6795         (tui_show_frame_info): Update.
6796         * tui/tui-source.h (tui_source_window): Don't declare.
6797         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6798         from tui_source_is_displayed.
6799         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6800         Remove field.
6801         (struct tui_source_window_base) <content_in_use>: New field.  Now
6802         bool.
6803         (struct tui_source_window) <showing_source_p>: New method.
6804         (TUI_SRC_WIN): Change cast.
6805         * tui/tui-data.c (tui_initialize_static_data): Update.
6806
6807 2019-07-17  Tom Tromey  <tom@tromey.com>
6808
6809         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6810         location_matches_p.
6811         * tui/tui-source.c (tui_source_window::location_matches_p): New
6812         method.
6813         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6814         method.
6815         * tui/tui-data.h (struct tui_source_window_base)
6816         <location_matches_p>: New method.
6817         (struct tui_source_window, struct tui_disasm_window)
6818         <location_matches_p>: Likewise.
6819
6820 2019-07-17  Tom Tromey  <tom@tromey.com>
6821
6822         * tui/tui-win.c (tui_set_win_height_command): Rename from
6823         tui_set_win_height.
6824         (tui_set_win_height_command): Remove.
6825
6826 2019-07-17  Tom Tromey  <tom@tromey.com>
6827
6828         * tui/tui-source.c (tui_source_window): New constructor.  Add
6829         observer.
6830         (~tui_source_window): New destructor.
6831         (tui_source_window::style_changed): New method.
6832         * tui/tui-hooks.c (tui_redisplay_source): Remove.
6833         (tui_attach_detach_observers): Update.
6834         * tui/tui-data.h (struct tui_source_window): Make constructor not
6835         inline.  Add destructor.
6836         (struct tui_source_window) <style_changed>: New method.
6837         <m_observable>: New member.
6838
6839 2019-07-17  Tom Tromey  <tom@tromey.com>
6840
6841         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6842         * tui/tui-win.c (tui_resize_all): Fix typo.
6843
6844 2019-07-17  Tom Tromey  <tom@tromey.com>
6845
6846         * tui/tui-wingeneral.h (tui_refresh_all): Update.
6847         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6848         (tui_refresh_all): Remove "list" parameter.  Use foreach.
6849         * tui/tui-win.c (window_name_completer): Use foreach.
6850         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6851         (update_tab_width): Likewise.
6852         * tui/tui-layout.c (show_layout): Update.
6853         * tui/tui-data.h (class tui_window_iterator): New.
6854         (struct all_tui_windows): New.
6855         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6856
6857 2019-07-17  Tom Tromey  <tom@tromey.com>
6858
6859         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6860         parameter.  Don't reference globals.
6861         (tui_reg_command): Update.
6862
6863 2019-07-17  Tom Tromey  <tom@tromey.com>
6864
6865         * tui/tui-regs.c (tui_show_registers): Simplify.
6866
6867 2019-07-17  Tom Tromey  <tom@tromey.com>
6868
6869         * tui/tui-regs.c (tui_show_registers): Update.
6870         (tui_show_register_group): Add win_info parameter.
6871
6872 2019-07-17  Tom Tromey  <tom@tromey.com>
6873
6874         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6875         Rename from tui_display_reg_element_at_line.
6876         (tui_data_window::display_registers_from_line): Update.
6877         * tui/tui-data.h (struct tui_data_window)
6878         <display_reg_element_at_line>: New method.
6879
6880 2019-07-17  Tom Tromey  <tom@tromey.com>
6881
6882         * tui/tui-regs.h (tui_display_registers_from)
6883         (tui_display_registers_from_line): Don't declare.
6884         * tui/tui-windata.c (tui_data_window::display_all_data)
6885         (tui_data_window::refresh_all)
6886         (tui_data_window::do_scroll_vertical): Update.
6887         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6888         from tui_display_registers_from.
6889         (tui_display_reg_element_at_line): Update.
6890         (tui_data_window::display_registers_from_line): Rename from
6891         tui_display_registers_from_line.
6892         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6893         display_registers_from_line>: New methods.
6894
6895 2019-07-17  Tom Tromey  <tom@tromey.com>
6896
6897         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6898         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6899         from tui_erase_data_content.
6900         (tui_data_window::display_all_data)
6901         (tui_data_window::refresh_all)
6902         (tui_data_window::do_scroll_vertical): Update.
6903         * tui/tui-regs.c (tui_show_registers): Update.
6904         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6905         New method.
6906
6907 2019-07-17  Tom Tromey  <tom@tromey.com>
6908
6909         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6910         declare.
6911         * tui/tui-windata.c
6912         (tui_data_window::delete_data_content_windows): Rename from
6913         tui_delete_data_content_windows.
6914         (tui_data_window::display_all_data)
6915         (tui_data_window::do_scroll_vertical): Update.
6916         * tui/tui-data.h (struct tui_data_window)
6917         <delete_data_content_windows>: New method.
6918
6919 2019-07-17  Tom Tromey  <tom@tromey.com>
6920
6921         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6922         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6923
6924 2019-07-17  Tom Tromey  <tom@tromey.com>
6925
6926         * tui/tui-windata.h (tui_display_all_data): Don't declare.
6927         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6928         from tui_display_all_data.
6929         * tui/tui-win.c
6930         (tui_data_window::do_make_visible_with_new_height): Update.
6931         * tui/tui-regs.c (tui_show_registers): Update.
6932         * tui/tui-layout.c (tui_set_layout): Update.
6933         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6934         method.
6935
6936 2019-07-17  Tom Tromey  <tom@tromey.com>
6937
6938         * tui/tui-windata.h (tui_display_data_from): Don't declare.
6939         * tui/tui-windata.c (tui_display_data_from): Remove.
6940         (tui_data_window::refresh_all): Update.
6941
6942 2019-07-17  Tom Tromey  <tom@tromey.com>
6943
6944         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6945         * tui/tui-windata.c (tui_display_data_from_line): Remove.
6946         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6947         tui_display_registers_from_line.
6948         * tui/tui-regs.h (tui_display_registers_from_line): Update.
6949         * tui/tui-regs.c (tui_display_registers_from_line): Remove
6950         "force_display" parameter.
6951
6952 2019-07-17  Tom Tromey  <tom@tromey.com>
6953
6954         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6955         declare.
6956         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6957         Rename from tui_first_reg_element_no_inline.
6958         (tui_display_reg_element_at_line)
6959         (tui_display_registers_from_line): Update.
6960         * tui/tui-data.h (struct tui_data_window)
6961         <first_reg_element_no_inline>: New method.
6962
6963 2019-07-17  Tom Tromey  <tom@tromey.com>
6964
6965         * tui/tui-windata.c (tui_display_data_from)
6966         (tui_data_window::do_scroll_vertical): Update.
6967         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6968         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6969         Rename from tui_line_from_reg_element_no.
6970         (tui_display_registers_from_line): Update.
6971         * tui/tui-data.h (struct tui_data_window)
6972         <line_from_reg_element_no>: New method.
6973
6974 2019-07-17  Tom Tromey  <tom@tromey.com>
6975
6976         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6977         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6978         tui_last_regs_line_no.
6979         (tui_display_reg_element_at_line)
6980         (tui_display_registers_from_line): Update.
6981         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6982         method.
6983
6984 2019-07-17  Tom Tromey  <tom@tromey.com>
6985
6986         PR tui/24722:
6987         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6988         (tui_update_breakpoint_info): Add "being_deleted" parameter.
6989         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6990         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6991         (tui_update_breakpoint_info): Likewise.
6992         * tui/tui-hooks.c (tui_event_create_breakpoint)
6993         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6994         Update.
6995
6996 2019-07-17  Tom Tromey  <tom@tromey.com>
6997
6998         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6999
7000 2019-07-17  Tom Tromey  <tom@tromey.com>
7001
7002         * tui/tui-winsource.c (tui_update_source_window_as_is)
7003         (tui_update_source_windows_with_addr): Update.
7004         * tui/tui-source.h (tui_set_source_content)
7005         (tui_show_symtab_source): Add "win_info" parameter.
7006         * tui/tui-source.c (tui_set_source_content): Add "win_info"
7007         parameter.
7008         (tui_show_symtab_source): Likewise.
7009
7010 2019-07-17  Tom Tromey  <tom@tromey.com>
7011
7012         * tui/tui-wingeneral.c
7013         (tui_check_and_display_highlight_if_needed): Check can_highlight.
7014
7015 2019-07-17  Tom Tromey  <tom@tromey.com>
7016
7017         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7018         (struct tui_cmd_window) <can_scroll>: New method.
7019         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7020         method.
7021
7022 2019-07-17  Tom Tromey  <tromey@adacore.com>
7023
7024         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7025         do_field_signed>: Rename.  Change type of "value".
7026         * ui-out.c (ui_out::field_signed): Rename from field_int.
7027         Change type of "value".
7028         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
7029         type of "value".
7030         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7031         do_field_int.  Change type of "value".
7032         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7033         do_field_int.  Change type of "value".
7034         * tracepoint.c (trace_status_mi, tfind_1)
7035         (print_one_static_tracepoint_marker): Update.
7036         * thread.c (print_thread_info_1, print_selected_thread_frame):
7037         Update.
7038         * stack.c (print_frame, print_frame_info): Update.
7039         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7040         Update.
7041         * source.c (print_source_lines_base): Update.
7042         * skip.c (info_skip_command): Update.
7043         * record-btrace.c (btrace_ui_out_decode_error)
7044         (btrace_call_history_src_line): Update.
7045         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7046         Update.
7047         * progspace.c (print_program_space): Update.
7048         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7049         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7050         do_field_int.  Change type of "value".
7051         * mi/mi-out.c (mi_ui_out::do_table_begin)
7052         (mi_ui_out::do_table_header): Update.
7053         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
7054         type of "value".
7055         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7056         (mi_cmd_data_list_changed_registers, output_register)
7057         (mi_cmd_data_read_memory, mi_load_progress)
7058         (mi_cmd_trace_frame_collected): Update.
7059         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7060         Update.
7061         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7062         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7063         (mi_cmd_var_list_children, varobj_update_one): Update.
7064         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7065         (mi_cmd_stack_list_args, list_arg_or_local): Update.
7066         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7067         * inferior.c (print_inferior): Update.
7068         * gdb_bfd.c (print_one_bfd): Update.
7069         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7070         Update.
7071         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7072         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7073         do_field_int.  Change type of "value".
7074         * cli-out.c (cli_ui_out::do_field_signed): Rename from
7075         do_field_int.  Change type of "value".
7076         * breakpoint.c (watchpoint_check, print_breakpoint_location)
7077         (print_one_breakpoint_location, print_it_catch_fork)
7078         (print_one_catch_fork, print_it_catch_vfork)
7079         (print_one_catch_vfork, print_it_catch_solib)
7080         (print_it_catch_exec, print_it_ranged_breakpoint)
7081         (print_mention_watchpoint, print_mention_masked_watchpoint)
7082         (bkpt_print_it, update_static_tracepoint): Update.
7083         * break-catch-throw.c (print_it_exception_catchpoint): Update.
7084         * break-catch-syscall.c (print_it_catch_syscall): Update.
7085         * ada-tasks.c (print_ada_task_info): Update.
7086         * ada-lang.c (print_it_exception, print_mention_exception):
7087         Update.
7088
7089 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
7090
7091         PR breakpoints/24541
7092         * gdbarch.c: Regenerate.
7093         * gdbarch.h: Regenerate.
7094         * gdbarch.sh: Adjust return type and parameter types for
7095         'stap_adjust_register'.
7096         (i386_stap_adjust_register): Adjust signature and return new
7097         register name.
7098         * stap-probe.c (stap_parse_register_operand): Adjust use of
7099         'gdbarch_stap_adjust_register'.
7100
7101 2019-07-17  Tom Tromey  <tromey@adacore.com>
7102
7103         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
7104         declare VEC.
7105         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7106         std::vector.
7107         (struct s390_process_info): Add initializers.
7108         (s390_add_process): Use new.
7109         (s390_linux_nat_target::low_forget_process): Use delete.
7110         (s390_linux_nat_target::low_new_fork)
7111         (s390_linux_nat_target::stopped_by_watchpoint)
7112         (s390_linux_nat_target::low_prepare_to_resume)
7113         (s390_linux_nat_target::insert_watchpoint)
7114         (s390_linux_nat_target::insert_hw_breakpoint)
7115         (s390_linux_nat_target::remove_watchpoint)
7116         (s390_linux_nat_target::remove_hw_breakpoint): Update.
7117
7118 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7119
7120         * aarch64-fbsd-nat.c: Include regcache.h.
7121         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7122         argument.
7123         (aarch64_fbsd_nat_target::fetch_registers)
7124         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7125         variable.
7126         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7127
7128 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7129
7130         * fbsd-nat.c: Include gdbarch.h.
7131
7132 2019-07-15  Tom Tromey  <tromey@adacore.com>
7133
7134         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7135
7136 2019-07-15  Tom Tromey  <tromey@adacore.com>
7137
7138         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7139         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7140         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7141         * cli-out.c (cli_ui_out::do_field_int): New method.
7142         * ui-out.c (ui_out::field_unsigned): New method.
7143         * symfile.c (generic_load): Use field_unsigned.
7144         (print_transfer_performance): Likewise.
7145         * record-btrace.c (ui_out_field_uint): Remove.
7146         (btrace_call_history_insn_range, btrace_call_history): Use
7147         field_unsigned.
7148         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7149         field_unsigned.
7150         * ui-out.h (class ui_out) <field_unsigned>: New method.
7151         <do_field_unsigned>: Likewise.
7152
7153 2019-07-15  Tom Tromey  <tromey@adacore.com>
7154
7155         * mi/mi-main.c (list_available_thread_groups): Use field_string.
7156         * mi/mi-interp.c (mi_memory_changed): Use field_string.
7157         * target.c (flash_erase_command): Use field_string.
7158         * infrun.c (print_signal_received_reason): Use field_string.
7159         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7160         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7161         field_string.
7162         * ada-tasks.c (print_ada_task_info): Use field_string.
7163
7164 2019-07-15  Tom Tromey  <tromey@adacore.com>
7165
7166         * target.c (flash_erase_command): Use field_core_addr.
7167         * symfile.c (generic_load): Use field_core_addr.
7168         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7169         Use field_core_addr.
7170         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7171         field_core_addr.
7172
7173 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7174
7175         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7176         value if its desired type is smaller than a CORE_ADDR and signed.
7177
7178 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7179
7180         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7181         of changes to field names, and use new is_reference field to
7182         decide if a property is a reference or not.
7183         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7184         field.
7185         (struct dwarf2_property_baton): Update header comment, rename
7186         'referenced_type' to 'property_type' and update comments.
7187         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7188         default property type, store in property baton, update to take
7189         accound of renamed field.
7190         (read_func_scope): Update call to attr_to_dynamic_prop.
7191         (read_array_type): Likewise.
7192         (dwarf2_per_cu_addr_sized_int_type): New function.
7193         (read_subrange_index_type): Move type finding code to
7194         dwarf2_per_cu_addr_sized_int_type.
7195         (read_subrange_type): Update calls to attr_to_dynamic_prop.
7196         (dwarf2_per_cu_addr_type): New function.
7197         (set_die_type): Update calls to attr_to_dynamic_prop.
7198
7199 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7200
7201         * dwarf2read.c (read_subrange_index_type): New function.
7202         (read_subrange_type): Move code into new function and call it.
7203         * gdbtypes.c (create_range_type): Add some asserts.
7204
7205 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7206
7207         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7208         update return statements.
7209         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7210         declaration, and update comment to match.
7211         * gdbtypes.c (resolve_dynamic_array): Update call to
7212         dwarf2_evaluate_property to match new return type.
7213
7214 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7215
7216         * valarith.c (value_subscripted_rvalue): Change lowerbound
7217         parameter type from int to LONGEST.
7218         * value.h (value_subscripted_rvalue): Likewise in declaration.
7219
7220 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7221
7222         * cli/cli-utils.c (info_print_command_completer): New function.
7223         * cli/cli-utils.h: Add 'completer.h' include, and forward
7224         declaration for 'struct cmd_list_element'.
7225         (info_print_command_completer): Declare.
7226         * stack.c (_initialize_stack): Add completer for 'info locals' and
7227         'info args'.
7228         * symtab.c (_initialize_symtab): Add completer for 'info
7229         variables' and 'info functions'.
7230         * NEWS: Mention completion for additional info commands.
7231
7232 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7233
7234         * cli/cli-utils.c (extract_info_print_args): Delete.
7235         (extract_arg_maybe_quoted): Delete.
7236         (info_print_options_defs): New variable.
7237         (make_info_print_options_def_group): New function.
7238         (extract_info_print_options): Define new function.
7239         * cli/cli-utils.h (extract_info_print_args): Delete.
7240         (struct info_print_options): New structure.
7241         (extract_info_print_options): Declare new function.
7242         * stack.c (info_locals_command): Update to use new
7243         extract_info_print_options, also add a header comment.
7244         (info_args_command): Likewise.
7245         * symtab.c (info_variables_command): Likewise.
7246         (info_functions_command): Likewise.
7247
7248 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7249
7250         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7251         to extract string arguments.
7252         * common/common-utils.c (extract_string_maybe_quoted): New function.
7253         * common/common-utils.h (extract_string_maybe_quoted): Declare.
7254
7255 2019-07-11  Tom Tromey  <tromey@adacore.com>
7256
7257         * main.c (get_init_files): Use GDBINIT, not gdbinit.
7258         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7259         * top.h (gdbinit): Don't declare.
7260         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7261         into...
7262         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
7263         * top.c (gdb_init): Don't call init_cli_cmds.
7264         (gdbinit): Remove.
7265         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7266
7267 2019-07-11  Tom Tromey  <tromey@adacore.com>
7268
7269         * python/py-inferior.c (add_thread_object): Don't use thread_obj
7270         after it has been moved.
7271
7272 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7273
7274         * valops.c (value_must_coerce_to_target): Change return type to
7275         bool.
7276         * value.h (value_must_coerce_to_target): Likewise.
7277
7278 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
7279
7280         * breakpoint.c (is_hardware_watchpoint): Remove
7281         forward-declaration.
7282         (is_masked_watchpoint): Change return type to bool.
7283         (is_tracepoint): Likewise.
7284         (is_breakpoint): Likewise.
7285         (is_hardware_watchpoint): Likewise.
7286         (is_watchpoint): Likewise.
7287         (is_no_memory_software_watchpoint): Likewise.
7288         (is_catchpoint): Likewise.
7289         (breakpoint_1): Make FILTER parameter's return type bool.
7290         is_masked_watchpoint): Change return type to bool.
7291         (save_breakpoints): Make FILTER parameter's return type bool.
7292         * breakpoint.h (is_breakpoint): Change return type to bool.
7293         (is_watchpoint): Likewise.
7294         (is_catchpoint): Likewise.
7295         (is_tracepoint): Likewise.
7296
7297 2019-07-10  Tom Tromey  <tom@tromey.com>
7298
7299         * defs.h: Don't include gdbarch.h.
7300         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7301         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7302         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7303         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7304         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7305         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7306         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7307         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7308         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7309         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7310         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7311         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7312         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7313         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7314         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7315         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7316         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7317         record-btrace.c, record.h, regcache-dump.c, regcache.h,
7318         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7319         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7320         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7321         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7322         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7323         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7324         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7325         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7326         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7327
7328 2019-07-10  Tom Tromey  <tromey@adacore.com>
7329
7330         * ada-lang.h (is_ada_exception_catchpoint): Declare.
7331         * breakpoint.c (init_ada_exception_breakpoint): Register as
7332         bp_catchpoint.
7333         (print_one_breakpoint_location, print_one_breakpoint): Use
7334         is_ada_exception_catchpoint.
7335         * ada-lang.c (class ada_catchpoint_location): Pass
7336         bp_loc_software_breakpoint to bp_location constructor.
7337         (is_ada_exception_catchpoint): New function.
7338
7339 2019-07-10  Tom Tromey  <tromey@adacore.com>
7340
7341         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
7342         VEC.
7343         (struct arm_exidx_entry): New method operator<.
7344         (struct arm_exidx_data) <section_maps>: Change type.
7345         (arm_exidx_data_free): Remove.
7346         (arm_exidx_data_key): Change type.  Move lower.
7347         (arm_exidx_new_objfile): Update.
7348         (arm_compare_exidx_entries): Remove.
7349         (arm_find_exidx_entry, _initialize_arm_tdep)
7350
7351 2019-07-10  Tom Tromey  <tromey@adacore.com>
7352
7353         * solib-spu.c (ocl_program_data_key): Change type.
7354         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7355         Update.
7356
7357 2019-07-10  Tom Tromey  <tromey@adacore.com>
7358
7359         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
7360         (struct solib_aix_inferior_data) <library_list>: Change type.
7361         (solib_aix_inferior_data_handle): Change type.
7362         (get_solib_aix_inferior_data): Update.
7363         (solib_aix_free_library_list): Remove.
7364         (library_list_start_library): Update.
7365         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7366         return type.
7367         (solib_aix_get_library_list)
7368         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7369         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7370
7371 2019-07-10  Tom Tromey  <tromey@adacore.com>
7372
7373         * solib-dsbt.c (struct dsbt_info): Add initializers.
7374         (solib_dsbt_pspace_data): Change type.
7375         (dsbt_pspace_data_cleanup): Remove.
7376         (get_dsbt_info, _initialize_dsbt_solib): Update.
7377
7378 2019-07-10  Tom Tromey  <tromey@adacore.com>
7379
7380         * spu-tdep.c (spu_overlay_data): Change type.
7381         (spu_get_overlay_table, spu_overlay_new_objfile)
7382         (_initialize_spu_tdep): Update.
7383
7384 2019-07-10  Tom Tromey  <tromey@adacore.com>
7385
7386         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7387         destructor.
7388         (dbx_objfile_data_key): Change type and declare later.
7389         (DBX_SYMFILE_INFO): Rewrite.
7390         * dbxread.c (dbx_objfile_data_key): Change type.
7391         (dbx_symfile_init): Update.
7392         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
7393         (coffstab_build_psymtabs, elfstab_build_psymtabs)
7394         (stabsect_build_psymtabs, _initialize_dbxread): Update.
7395
7396 2019-07-10  Tom Tromey  <tromey@adacore.com>
7397
7398         * jit.c (jit_program_space_key): Change type.  Move lower.
7399         (get_jit_program_space_data): Update.
7400         (jit_program_space_data_cleanup): Remove.
7401         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7402         Update.
7403         (struct jit_program_space_data): Add initializers.
7404
7405 2019-07-10  Tom Tromey  <tromey@adacore.com>
7406
7407         * solib-darwin.c (struct darwin_info): Add initializers.
7408         (solib_darwin_pspace_data): Change type.
7409         (darwin_pspace_data_cleanup): Remove.
7410         (get_darwin_info, _initialize_darwin_solib): Update.
7411
7412 2019-07-10  Tom Tromey  <tromey@adacore.com>
7413
7414         * remote-sim.c (struct sim_inferior_data): Add initializers,
7415         constructor, and destructor.
7416         (sim_inferior_data_key): Change type.  Move lower.
7417         (check_for_duplicate_sim_descriptor): Update.
7418         (get_sim_inferior_data): Use new.  Update.
7419         (~sim_inferior_data_cleanup): Rename from
7420         sim_inferior_data_cleanup.  Simplify.
7421         (gdbsim_close_inferior, simulator_command)
7422         (sim_command_completer, _initialize_remote_sim): Update.
7423         (next_pid, INITIAL_PID): Move earlier.
7424
7425 2019-07-10  Tom Tromey  <tromey@adacore.com>
7426
7427         * python/python-internal.h (create_thread_object): Return
7428         gdbpy_ref.
7429         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7430         * python/py-inferior.c (struct threadlist_entry): Add
7431         constructor.
7432         <thread_obj>: Now a gdbpy_ref.
7433         (thread_to_thread_object): Update.
7434         (add_thread_object): Use new.
7435         (delete_thread_object): Use delete.
7436         (infpy_threads): Update.
7437         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
7438         GIL.
7439
7440 2019-07-10  Tom Tromey  <tromey@adacore.com>
7441
7442         * valops.c (value_cast): Specialize error message for Ada.
7443
7444 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7445
7446         * breakpoint.c (breakpoint_1): Update doc and parameter names.
7447
7448 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7449
7450         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7451         bpstat_should_step): Return bool, adjust comments.
7452         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7453         bpstat_should_step): Likewise.
7454
7455 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7456
7457         * features/Makefile: Use feature target descriptions for Arm.
7458         * features/arm/arm-core.c: Generate new file.
7459         * features/arm/arm-fpa.c: Likewise.
7460         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7461         * features/arm/arm-m-profile.c: Likewise.
7462         * features/arm/arm-vfpv2.c: Likewise.
7463         * features/arm/arm-vfpv3.c: Likewise.
7464         * features/arm/xscale-iwmmxt.c: Likewise.
7465         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7466
7467 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7468
7469         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7470         ptrace earlier.
7471
7472 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7473
7474         * features/aarch64-pauth.c: Regenerate.
7475
7476 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
7477
7478         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7479         bool.
7480         (bpstat_what): Use false instead of 0.
7481
7482 2019-07-09  Pedro Alves  <palves@redhat.com>
7483
7484         * break-catch-throw.c (is_exception_catchpoint): New.
7485         * breakpoint.c (print_one_breakpoint_location): New parameter
7486         'raw_loc'.  Handle it.  Use
7487         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7488         looking at the breakpoint's type.
7489         (print_one_breakpoint): If handling "maint info breakpoints", also
7490         print locations of exception catchpoints.
7491         * breakpoint.h (is_exception_catchpoint): Declare.
7492
7493 2019-07-09  Pedro Alves  <palves@redhat.com>
7494
7495         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7496         "addr" field.
7497         (allocate_location_exception_catchpoint): New.
7498         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7499         (initialize_throw_catchpoint_ops): Install
7500         allocate_location_exception_catchpoint as allocate_location
7501         method.
7502         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7503         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7504         bp_loc_other.
7505         (breakpoint_address_is_meaningful): Delete.
7506         (bl_address_is_meaningful): New.
7507         (breakpoint_locations_match): Adjust comment.
7508         (bp_location_from_bp_type): New, factored out of...
7509         (bp_location::bp_location(breakpoint *)): ... this.
7510         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7511         factored out of...
7512         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
7513         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7514         breakpoint_address_is_meaningful.
7515         (bp_locations_compare): Adjust comment.
7516         (update_global_location_list): Use bl_address_is_meaningful
7517         instead of breakpoint_address_is_meaningful.
7518         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7519         explicit.
7520         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7521         * python/py-breakpoint.c (bppy_get_location): No longer check
7522         whether location is null.
7523
7524 2019-07-09  Pedro Alves  <palves@redhat.com>
7525
7526         PR c++/15468
7527         * breakpoint.c (print_one_breakpoint_location): Remove
7528         single-location assert.
7529
7530 2019-07-09  Tom Tromey  <tom@tromey.com>
7531
7532         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7533         * configure: Rebuild.
7534         * configure.ac: Change common to gdbsupport.
7535         * gdbsupport: Rename from common.
7536         * acinclude.m4: Change common to gdbsupport.
7537         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7538         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7539         gdbsupport.
7540         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7541         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7542         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7543         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7544         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7545         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7546         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7547         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7548         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7549         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7550         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7551         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7552         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7553         coff-pe-read.c, command.h, compile/compile-c-support.c,
7554         compile/compile-c.h, compile/compile-cplus-symbols.c,
7555         compile/compile-cplus-types.c, compile/compile-cplus.h,
7556         compile/compile-loc2c.c, compile/compile.c, completer.c,
7557         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7558         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7559         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7560         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7561         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7562         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7563         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7564         features/aarch64-core.c, features/aarch64-fpu.c,
7565         features/aarch64-pauth.c, features/aarch64-sve.c,
7566         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7567         features/i386/32bit-core.c, features/i386/32bit-linux.c,
7568         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7569         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7570         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7571         features/i386/64bit-core.c, features/i386/64bit-linux.c,
7572         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7573         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7574         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7575         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7576         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7577         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7578         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7579         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7580         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7581         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7582         go32-nat.c, guile/guile.c, guile/scm-ports.c,
7583         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7584         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7585         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7586         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7587         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7588         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7589         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7590         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7591         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7592         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7593         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7594         minsyms.c, mips-linux-tdep.c, namespace.h,
7595         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7596         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7597         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7598         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7599         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7600         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7601         nat/linux-waitpid.c, nat/mips-linux-watch.c,
7602         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7603         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7604         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7605         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7606         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7607         procfs.c, producer.c, progspace.h, psymtab.h,
7608         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7609         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7610         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7611         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7612         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7613         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7614         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7615         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7616         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7617         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7618         target-memory.c, target.c, target.h, target/waitstatus.c,
7619         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7620         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7621         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7622         unittests/array-view-selftests.c,
7623         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7624         unittests/common-utils-selftests.c,
7625         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7626         unittests/format_pieces-selftests.c,
7627         unittests/function-view-selftests.c,
7628         unittests/lookup_name_info-selftests.c,
7629         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7630         unittests/mkdir-recursive-selftests.c,
7631         unittests/observable-selftests.c,
7632         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7633         unittests/parse-connection-spec-selftests.c,
7634         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7635         unittests/scoped_fd-selftests.c,
7636         unittests/scoped_mmap-selftests.c,
7637         unittests/scoped_restore-selftests.c,
7638         unittests/string_view-selftests.c, unittests/style-selftests.c,
7639         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7640         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7641         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7642         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7643         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7644         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7645
7646 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7647
7648         * linespec.c (decode_digits_list_mode): Set explicit_line to a
7649         bool value.
7650         (decode_digits_ordinary): Set explicit_line field in sal.
7651         * symtab.c (skip_prologue_sal): Don't skip prologue for a
7652         symtab_and_line that was set on an explicit line number in
7653         assembler code.  Do always update the recorded symtab and line if
7654         we do skip the prologue.
7655
7656 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7657
7658         * breakpoint.c (set_breakpoint_location_function): Remove
7659         explicit_loc parameter.
7660         (momentary_breakpoint_from_master): Update call to
7661         set_breakpoint_location_function.
7662         (add_location_to_breakpoint): Likewise.
7663
7664 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7665
7666         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7667         required features based on default bfd type when no specific bfd
7668         is present.
7669
7670 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7671
7672         * NEWS: Mention that GDB printf and eval commands can now print
7673         C-style and Ada-style convenience var strings without
7674         calling the inferior.
7675         * printcmd.c (printf_c_string): Locally print GDB internal var
7676         instead of transiting via the inferior.
7677         (printf_wide_c_string): Likewise.
7678
7679 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7680
7681         PR breakpoints/25011
7682         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7683
7684 2019-07-04  Tom Tromey  <tom@tromey.com>
7685
7686         PR tui/24724:
7687         * tui/tui-winsource.c (tui_clear_source_content): Update.
7688         (tui_source_window_base::set_is_exec_point_at): Fix comment.
7689         (tui_update_breakpoint_info): Update.
7690         (tui_set_exec_info_content): Update.
7691         * tui/tui-source.c (tui_set_source_content_nil): Update.
7692         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7693         has_break.
7694         * tui/tui-data.h (enum tui_bp_flag): New.
7695         (tui_bp_flags): New enum flags type.
7696         (struct tui_source_element) <break_mode>: Change type.  Rename
7697         from has_break.
7698         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7699         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
7700         constants.
7701         * tui/tui-winsource.h: Fix comment.
7702
7703 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7704
7705         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7706         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7707         (store_fpregs_to_thread)
7708         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7709         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7710         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7711         (IWMMXT_REGS_SIZE): Add define.
7712         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7713         (fetch_vfp_regs, store_vfp_regs)
7714         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7715         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7716
7717 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7718
7719         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7720         defines.
7721         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7722         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7723         (ARM_INT_REGISTER_SIZE): ...to this.
7724         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7725         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7726         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7727         (arm_linux_collect_gregset, supply_nwfpe_register)
7728         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7729         defines.
7730         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7731         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7732         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7733         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7734         (arm_return_in_memory, arm_store_return_value)
7735         (arm_get_longjmp_target, arm_register_g_packet_guesses)
7736         (arm_record_ld_st_multiple): Likewise.
7737         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7738         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7739
7740 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7741
7742         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7743         AARCH64_DISPLACED_MODIFIED_INSNS.
7744         * aarch64-tdep.c (struct aarch64_displaced_step_data)
7745         (aarch64_displaced_step_copy_insn): Likewise.
7746         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7747         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7748         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7749         ARM_DISPLACED_MODIFIED_INSNS.
7750         * arm-tdep.c (arm_gdbarch_init): Likewise.
7751         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7752         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7753         (struct arm_displaced_step_closure): Use
7754         ARM_DISPLACED_MODIFIED_INSNS.
7755
7756 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7757
7758         * features/Makefile: Remove unused xml files.
7759         * features/aarch64.xml: Remove.
7760         * features/i386/amd64-avx-avx512-linux.xml: Remove.
7761         * features/i386/amd64-avx-avx512.xml: Remove.
7762         * features/i386/amd64-avx-linux.xml: Remove.
7763         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7764         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7765         * features/i386/amd64-avx-mpx-linux.xml: Remove.
7766         * features/i386/amd64-avx-mpx.xml: Remove.
7767         * features/i386/amd64-avx.xml: Remove.
7768         * features/i386/amd64-linux.xml: Remove.
7769         * features/i386/amd64-mpx-linux.xml: Remove.
7770         * features/i386/amd64-mpx.xml: Remove.
7771         * features/i386/amd64.xml: Remove.
7772         * features/i386/i386-avx-avx512-linux.xml: Remove.
7773         * features/i386/i386-avx-avx512.xml: Remove.
7774         * features/i386/i386-avx-linux.xml: Remove.
7775         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7776         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7777         * features/i386/i386-avx-mpx-linux.xml: Remove.
7778         * features/i386/i386-avx-mpx.xml: Remove.
7779         * features/i386/i386-avx.xml: Remove.
7780         * features/i386/i386-linux.xml: Remove.
7781         * features/i386/i386-mmx-linux.xml: Remove.
7782         * features/i386/i386-mmx.xml: Remove.
7783         * features/i386/i386-mpx-linux.xml: Remove.
7784         * features/i386/i386-mpx.xml: Remove.
7785         * features/i386/i386.xml: Remove.
7786         * features/i386/x32-avx-avx512-linux.xml: Remove.
7787         * features/i386/x32-avx-linux.xml: Remove.
7788         * features/i386/x32-linux.xml: Remove.
7789
7790 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7791
7792         * regformats/aarch64.dat: Remove.
7793         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7794         * regformats/i386/amd64-avx-linux.dat: Remove.
7795         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7796         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7797         * regformats/i386/amd64-linux.dat: Remove.
7798         * regformats/i386/amd64-mpx-linux.dat: Remove.
7799         * regformats/i386/amd64.dat: Remove.
7800         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7801         * regformats/i386/i386-avx-linux.dat: Remove.
7802         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7803         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7804         * regformats/i386/i386-linux.dat: Remove.
7805         * regformats/i386/i386-mmx-linux.dat: Remove.
7806         * regformats/i386/i386-mpx-linux.dat: Remove.
7807         * regformats/i386/i386.dat: Remove.
7808         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7809         * regformats/i386/x32-avx-linux.dat: Remove.
7810         * regformats/i386/x32-linux.dat: Remove.
7811
7812 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7813
7814         * aarch64-tdep.c: Remove xml self tests.
7815         * amd64-linux-tdep.c: Likewise.
7816         * amd64-tdep.c: Likewise.
7817         * i386-linux-tdep.c: Likewise.
7818         * i386-tdep.c: Likewise.
7819
7820 2019-07-03  Pedro Alves  <palves@redhat.com>
7821
7822         PR cli/24732
7823         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7824         (pipe_cmd_option_defs): New.
7825         (make_pipe_cmd_options_def_group): New.
7826         (pipe_command): Use gdb::option::process_options.
7827         (pipe_command_completer): New function.
7828         (_initialize_cli_cmds): Install completer for "pipe" command.
7829
7830 2019-07-03  Pedro Alves  <palves@redhat.com>
7831
7832         * cli/cli-option.c (union option_value) <string>: New field.
7833         (struct option_def_and_value): Add ctor, move ctor, dtor and
7834         use DISABLE_COPY_AND_ASSIGN.
7835         (option_def_and_value::clear_value): New.
7836         (parse_option, save_option_value_in_ctx, get_val_type_str)
7837         (add_setshow_cmds_for_options): Handle var_string.
7838         * cli-option.h (union option_def::var_address) <string>: New
7839         field.
7840         (struct string_option_def): New.
7841         * maint-test-options.c (struct test_options_opts): Add default
7842         ctor and use DISABLE_COPY_AND_ASSIGN.
7843         <string_opt>: New field.
7844         (test_options_opts::~test_options_opts): New.
7845         (test_options_opts::dump): Also dump "-string".
7846         (test_options_option_defs): Install "string.
7847
7848 2019-07-03  Pedro Alves  <palves@redhat.com>
7849
7850         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7851         option_value with a null enumeration.
7852         (complete_options): Save the option values in the context.
7853         (save_option_value_in_ctx): New, factored out from ...
7854         (process_options): ... here.
7855         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7856         of the function.
7857         * maint-test-options.c (test_options_opts::dump): New, factored
7858         out from ...
7859         (maintenance_test_options_command_mode): ... here.
7860         (maintenance_test_options_command_completion_result): Delete.
7861         (maintenance_test_options_command_completion_text): Update
7862         comment.
7863         (maintenance_show_test_options_completion_result): Change
7864         prototype.  Just print
7865         maintenance_test_options_command_completion_text.
7866         (save_completion_result): New.
7867         (maintenance_test_options_completer_mode): Pass options context to
7868         complete_options, and then save a dump.
7869         (_initialize_maint_test_options): Use add_cmd to install "maint
7870         show test-options-completion-result".
7871
7872 2019-07-03  Pedro Alves  <palves@redhat.com>
7873
7874         * NEWS (New commands): Mention "with" and "maint with".
7875         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7876         (with_command, with_command_completer): New.
7877         (pipe_command): Adjust to new repeat_previous
7878         interface.
7879         (_initialize_cli_cmds): Install the "with" command and its "w"
7880         alias.
7881         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7882         declarations.
7883         * cli/cli-setshow.c (parse_cli_var_uinteger)
7884         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7885         argument strings for all var_types.
7886         (get_setshow_command_value_string): New, factored out from ...
7887         (do_show_command): ... this.
7888         * cli/cli-setshow.h: Include <string>.
7889         (get_setshow_command_value_string): Declare.
7890         * command.h (repeat_previous): Now returns const char *.  Adjust
7891         comment.
7892         * maint.c: Include "cli/cli-cmds.h".
7893         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7894         (_initialize_maint_cmds): Register the "maintenance with" command.
7895         * top.c (repeat_previous): Move bits from pipe_command here:
7896         Return the saved command line, if any; error out if there's no
7897         command to relaunch.
7898
7899 2019-07-03  Pedro Alves  <palves@redhat.com>
7900
7901         * NEWS (New commands): Mention "maint set/show test-settings"
7902         instead of "maint test-settings".
7903         * maint-test-settings.c (maintenance_test_settings_list): Delete.
7904         (maintenance_test_settings_set_list): Rename to ...
7905         (maintenance_set_test_settings_list): ... this.
7906         (maintenance_test_settings_show_list): Rename to  ...
7907         (maintenance_show_test_settings_list): ... this.
7908         (maintenance_test_settings_cmd): Delete.
7909         (maintenance_test_settings_set_cmd): ...
7910         (maintenance_set_test_settings_cmd): ... this.
7911         (maintenance_test_settings_show_cmd): ...
7912         (maintenance_show_test_settings_cmd): ... this.
7913         (maintenance_test_settings_show_value_cmd):
7914         (maintenance_show_test_settings_value_cmd): ... this.
7915         (_initialize_maint_test_settings): No longer install the "maint
7916         test-settings" prefix command.  Rename "maint test-settings set"
7917         to "maint set test-settings", and "maint test-settings show" to
7918         "maint show test-settings".  Adjust all subcommands.
7919
7920 2019-07-03  Pedro Alves  <palves@redhat.com>
7921
7922         * maint-test-settings.c: Fix file's intro comment.  Replace all
7923         references to "test-options" with references to "test-settings",
7924         in comments.
7925
7926 2019-07-03  Pedro Alves  <palves@redhat.com>
7927
7928         * maint-test-settings.c (maintenance_test_settings_xxx)
7929         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7930         New.
7931         (maintenance_test_settings_enums): Use them.
7932         (maintenance_test_settings_enum): Default to
7933         maintenance_test_settings_xxx.
7934         (_initialize_maint_test_settings): Initialize
7935         MAINTENANCE_TEST_SETTINGS_FILENAME.
7936
7937 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7938
7939         * breakpoint.h (remove_breakpoints_inf): Change return type to
7940         void, move function documentation here.
7941         * breakpoint.c (remove_breakpoints_inf): Change return type to
7942         void, move function documentation to header.
7943
7944 2019-07-02  Pedro Alves  <palves@redhat.com>
7945
7946         * NEWS (Completion improvements): Mention "info threads".
7947         * thread.c (struct info_threads_opts, info_threads_option_defs)
7948         (make_info_threads_options_def_group): New.
7949         (info_threads_command): Use gdb::option::process_options.
7950         (info_threads_command_completer): New.
7951         (_initialize_thread): Use gdb::option::build_help to build the
7952         help text for "info threads".
7953
7954 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7955
7956         * defs.h (generic_load): Move from here...
7957         * symfile.h (generic_load): ... to here.  Rename name parameter
7958         to args.
7959         * symfile.c (generic_load): Add comment.
7960
7961 2019-07-01  Tom Tromey  <tromey@adacore.com>
7962
7963         * dwarf2read.c
7964         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7965         declaration of without_params.  Fix formatting.
7966
7967 2019-07-01  Tom Tromey  <tromey@adacore.com>
7968
7969         * ada-exp.y (find_primitive_type): Update.
7970         * ada-lang.h (ada_lookup_symbol): Update.
7971         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7972         parameter.
7973         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7974
7975 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7976
7977         PR breakpoints/24541
7978         * gdbarch.c: Regenerate.
7979         * gdbarch.h: Regenerate.
7980         * gdbarch.sh: Add 'stap_adjust_register'.
7981         * i386-tdep.c: Include '<unordered_set>'.
7982         (i386_stap_adjust_register): New function.
7983         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7984         * stap-probe.c (stap_parse_register_operand): Call
7985         'gdbarch_stap_adjust_register'.
7986
7987 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7988
7989         PR python/24742
7990         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7991         * python/python.c (do_start_initialization): Use 'xmalloc'
7992         instead of 'PyMem_Malloc'.
7993
7994 2019-06-28  Tom Tromey  <tromey@adacore.com>
7995
7996         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7997         for Ada.
7998
7999 2019-06-27  Tom Tromey  <tromey@adacore.com>
8000
8001         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
8002         objfile_key.
8003         (arm_find_mapping_symbol, arm_record_special_symbol)
8004         (_initialize_arm_tdep): Update.
8005         (arm_objfile_data_free): Remove.
8006
8007 2019-06-27  Tom Tromey  <tromey@adacore.com>
8008
8009         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8010         to cp_print_static_field.
8011
8012 2019-06-26  Tom Tromey  <tromey@adacore.com>
8013
8014         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8015         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8016         declare.
8017
8018 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8019
8020         * features/aarch64-core.c (create_feature_aarch64_core):
8021         Regenerate.
8022         * features/aarch64-core.xml: Add cpsr flags.
8023
8024 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8025
8026         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8027         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8028
8029 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8030
8031         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8032         field.
8033         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8034         use.
8035         (arm_record_special_symbol): Don't insert new symbol in sorted
8036         position, push it at the end.
8037
8038 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8039
8040         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8041         (arm_mapping_symbol_s): Remove.
8042         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8043         (arm_mapping_symbol_vec): New typedef.
8044         (struct arm_per_objfile): Add constructor.
8045         <section_maps>: Change type to
8046         std::unique_ptr<arm_mapping_symbol_vec[]>.
8047         (arm_compare_mapping_symbols): Remove.
8048         (arm_find_mapping_symbol): Adjust to section_maps type change.
8049         (arm_objfile_data_free): Call delete on arm_per_objfile.
8050         (arm_record_special_symbol): Adjust to section_maps type change.
8051         Allocate arm_per_objfile with new.
8052
8053 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8054
8055         * cli/cli-cmds.c (alias_command): Compare the alias prefix
8056         with the command prefix.
8057
8058 2019-06-25  Tom Tromey  <tom@tromey.com>
8059
8060         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8061         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8062
8063 2019-06-25  Tom Tromey  <tom@tromey.com>
8064
8065         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8066         type.
8067         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8068         protected.
8069
8070 2019-06-25  Tom Tromey  <tom@tromey.com>
8071
8072         * tui/tui-winsource.c
8073         (tui_source_window_base::set_is_exec_point_at): Add check against
8074         LOA_ADDRESS.
8075
8076 2019-06-25  Tom Tromey  <tom@tromey.com>
8077
8078         * tui/tui-source.c (tui_set_source_content): Don't check before
8079         xfree.
8080         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8081
8082 2019-06-25  Tom Tromey  <tom@tromey.com>
8083
8084         * tui/tui-winsource.h (tui_update_source_window_as_is)
8085         (tui_alloc_source_buffer, tui_line_is_displayed)
8086         (tui_addr_is_displayed): Change type of win_info.
8087         * tui/tui-winsource.c (tui_update_source_window_as_is)
8088         (tui_clear_source_content, tui_show_source_line)
8089         (tui_show_source_content, tui_source_window_base::refill)
8090         (tui_source_window_base::set_is_exec_point_at)
8091         (tui_source_window_base::set_is_exec_point_at)
8092         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8093         (tui_alloc_source_buffer, tui_line_is_displayed)
8094         (tui_addr_is_displayed): Change type of win_info.  Update.
8095         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8096         (tui_source_window_base::do_make_visible_with_new_height):
8097         Update.
8098         * tui/tui-source.c (tui_set_source_content)
8099         (tui_set_source_content_nil)
8100         (tui_source_window::do_scroll_vertical): Update.
8101         * tui/tui-layout.c (show_layout): Update.
8102         * tui/tui-disasm.c (tui_set_disassem_content)
8103         (tui_disasm_window::do_scroll_vertical): Update.
8104         * tui/tui-data.h (tui_win_content): Remove.
8105         (struct tui_gen_win_info) <content, content_size>: Remove.
8106         (struct tui_source_element): Add initializers and destructor.
8107         (union tui_which_element, struct tui_win_element): Remove.
8108         (struct tui_source_window_base) <content>: New field.
8109         (struct tui_data_window): Remove destructor.
8110         (tui_alloc_content, tui_free_win_content)
8111         (tui_free_all_source_wins_content): Don't declare.
8112         * tui/tui-data.c (tui_initialize_static_data): Update.
8113         (init_content_element, tui_alloc_content): Remove.
8114         (~tui_gen_win_info): Update.
8115         (~tui_data_window, tui_free_all_source_wins_content)
8116         (tui_free_win_content, free_content, free_content_elements):
8117         Remove.
8118
8119 2019-06-25  Tom Tromey  <tom@tromey.com>
8120
8121         * tui/tui-winsource.h (tui_clear_source_content)
8122         (tui_erase_source_content, tui_show_source_content): Change type
8123         of win_info.
8124         * tui/tui-winsource.c (tui_clear_source_content)
8125         (tui_erase_source_content, tui_show_source_content): Change type
8126         of win_info.
8127         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8128         * tui/tui-source.h (tui_set_source_content_nil): Change type of
8129         win_info.
8130         * tui/tui-source.c (tui_set_source_content_nil): Change type of
8131         win_info.
8132         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8133
8134 2019-06-25  Tom Tromey  <tom@tromey.com>
8135
8136         * tui/tui-winsource.c (tui_clear_source_content)
8137         (tui_source_window_base::set_is_exec_point_at): Update.
8138         * tui/tui-source.c (tui_set_source_content_nil): Update.
8139         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8140         a bool.
8141         * tui/tui-data.c (init_content_element): Update.
8142
8143 2019-06-25  Tom Tromey  <tom@tromey.com>
8144
8145         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8146         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8147         * tui/tui-layout.c (init_and_make_win): Update.
8148         * tui/tui.h (enum tui_win_type): Update.
8149         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8150         tui_win_is_auxillary.
8151         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8152         tui_win_is_auxillary.
8153
8154 2019-06-25  Tom Tromey  <tom@tromey.com>
8155
8156         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8157         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8158         (tui_delete_data_content_windows, tui_display_all_data)
8159         (tui_data_window::do_scroll_vertical, tui_display_data_from):
8160         Update.
8161         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8162         * tui/tui-regs.c (tui_last_regs_line_no)
8163         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8164         (tui_show_registers): Update.
8165         (tui_show_register_group): Return void.  Update.
8166         (tui_display_registers_from, tui_display_reg_element_at_line)
8167         (tui_display_registers_from_line, tui_check_register_values):
8168         Update.
8169         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8170         member.
8171         (struct tui_data_window) <regs_content>: Now a std::vector.
8172         <regs_content_count>: Remove.
8173         (tui_add_content_elements, tui_free_data_content): Don't declare.
8174         * tui/tui-data.c (tui_data_window::clear_detail): Update.
8175         (init_content_element): Remove DATA_WIN case.  Add assert.
8176         (tui_add_content_elements): Remove.
8177         (tui_data_window): Update.
8178         (tui_free_data_content): Remove.
8179         (free_content_elements): Remove DATA_WIN case.
8180
8181 2019-06-25  Tom Tromey  <tom@tromey.com>
8182
8183         * tui/tui-data.c (tui_data_item_window): Update.
8184         * tui/tui-windata.h (tui_check_data_values): Don't declare.
8185         * tui/tui-windata.c (tui_display_all_data)
8186         (tui_display_data_from_line): Update.
8187         (tui_check_data_values): Remove.
8188         * tui/tui-regs.c (tui_show_register_group)
8189         (tui_display_reg_element_at_line): Update.
8190         * tui/tui-hooks.c (tui_register_changed)
8191         (tui_refresh_frame_and_register_information): Call
8192         tui_check_register_values.
8193         * tui/tui-data.h (struct tui_data_window) <data_content,
8194         data_content_count, data_type>: Remove.
8195         (enum tui_data_type): Remove.
8196
8197         * tui/tui-data.c (tui_data_window::clear_detail)
8198         (~tui_data_window): Update.
8199
8200 2019-06-25  Tom Tromey  <tom@tromey.com>
8201
8202         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8203         declare.
8204         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8205         Rename from tui_first_data_item_displayed.  Update.
8206         (tui_data_window::refresh_all)
8207         (tui_data_window::do_scroll_vertical): Update.
8208         * tui/tui-data.h (struct tui_data_window)
8209         <first_data_item_displayed>: Declare new method.
8210
8211 2019-06-25  Tom Tromey  <tom@tromey.com>
8212
8213         * tui/tui-data.h (tui_init_generic_part): Don't declare.
8214         * tui/tui-data.c (tui_init_generic_part): Remove, moving
8215         contents...
8216         (tui_initialize_static_data): ...here.
8217
8218 2019-06-25  Tom Tromey  <tom@tromey.com>
8219
8220         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8221         (tui_display_registers_from, tui_check_register_values): Update.
8222         (tui_display_register): Remove win_info parameter; update.
8223         (tui_get_register): Change type of parameters.
8224         * tui/tui-data.h (struct tui_data_element): Remove.
8225         (union tui_which_element) <data>: Remove.
8226         <data_window>: Change type.
8227         (struct tui_data_item_window): New.
8228         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8229         case.  Add assert.
8230         (~tui_data_item_window): New destructor.
8231         (free_content_elements): Remove DATA_ITEM_WIN case.
8232
8233 2019-06-25  Tom Tromey  <tom@tromey.com>
8234
8235         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8236         Remove.
8237
8238 2019-06-25  Tom Tromey  <tom@tromey.com>
8239
8240         * tui/tui-data.h (struct tui_command_element): Remove.
8241         (union tui_which_element) <command>: Remove.
8242         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
8243         assert.
8244         (free_content_elements): Remove CMD_WIN case.
8245
8246 2019-06-25  Tom Tromey  <tom@tromey.com>
8247
8248         * tui/tui-layout.c (tui_set_layout): Update.
8249         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8250         * tui/tui-data.c (layout_def): Update.
8251
8252 2019-06-25  Tom Tromey  <tom@tromey.com>
8253
8254         * tui/tui-wingeneral.c (tui_refresh_all): Update.
8255         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8256         (tui_source_window_base::set_new_height): Update.
8257         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8258         Update.
8259         (tui_set_locator_fullname, tui_set_locator_info)
8260         (tui_show_frame_info): Update.
8261         * tui/tui-source.c (tui_set_source_content)
8262         (tui_source_is_displayed): Update.
8263         * tui/tui-layout.c (show_source_disasm_command, show_data)
8264         (show_source_or_disasm_and_command): Update.
8265         * tui/tui-disasm.c (tui_set_disassem_content)
8266         (tui_get_begin_asm_address): Update.
8267         * tui/tui-data.h (struct tui_locator_element): Remove.
8268         (union tui_which_element) <locator>: Remove.
8269         (struct tui_locator_window): New.
8270         (tui_locator_win_info_ptr): Change return type.
8271         * tui/tui-data.c (_locator): Change type.
8272         (tui_locator_win_info_ptr): Change return type.
8273         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
8274         (tui_alloc_content): Add assert.
8275
8276 2019-06-25  Tom Tromey  <tom@tromey.com>
8277
8278         * tui/tui-winsource.c
8279         (tui_exec_info_window::maybe_allocate_content): New method.
8280         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8281         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8282         (make_source_or_disasm_window): Add cast.
8283         * tui/tui-data.h (union tui_which_element) <simple_string>:
8284         Remove.
8285         (struct tui_source_info): New.
8286         (struct tui_source_window_base) <execution_info>: Change type.
8287         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8288         case, and add assert.
8289         (tui_alloc_content): Add assert.
8290
8291 2019-06-25  Tom Tromey  <tom@tromey.com>
8292
8293         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8294         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8295         * tui/tui-data.c (tui_alloc_win_info): Remove.
8296
8297 2019-06-25  Tom Tromey  <tom@tromey.com>
8298
8299         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8300         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8301         can_highlight.
8302
8303 2019-06-25  Tom Tromey  <tom@tromey.com>
8304
8305         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8306         make_visible_with_new_height method.
8307         (tui_win_info::make_visible_with_new_height): New method.
8308         (tui_source_window_base::do_make_visible_with_new_height)
8309         (tui_data_window::do_make_visible_with_new_height)
8310         (tui_cmd_window::do_make_visible_with_new_height): New methods.
8311         (make_visible_with_new_height): Remove.
8312         (tui_resize_all, tui_adjust_win_heights): Use
8313         make_visible_with_new_height method.
8314         * tui/tui-data.h (struct tui_win_info)
8315         <do_make_visible_with_new_height, make_visible_with_new_height>:
8316         New methods.
8317         (struct tui_source_window_base, struct tui_data_window)
8318         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8319         methods.
8320
8321 2019-06-25  Tom Tromey  <tom@tromey.com>
8322
8323         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8324         method.
8325         (update_tab_width): Call update_tab_width method.
8326         * tui/tui-data.h (struct tui_win_info)
8327         (struct tui_source_window_base) <update_tab_width>: New methods.
8328
8329 2019-06-25  Tom Tromey  <tom@tromey.com>
8330
8331         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8332         parameter.
8333         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8334         parameter.
8335         (tui_gen_win_info::make_visible): Update.
8336         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8337         parameter.
8338         * tui/tui-data.h (enum tui_box): New enum.
8339         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8340
8341 2019-06-25  Tom Tromey  <tom@tromey.com>
8342
8343         * tui/tui-layout.c (make_source_or_disasm_window): Always use
8344         init_and_make_win for EXEC_INFO_WIN.
8345         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8346         longer inline.
8347         (struct tui_win_info) <~tui_win_info>: Inline.
8348         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8349         Don't declare.
8350         * tui/tui-data.c (source_win, disasm_win): Remove globals.
8351         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8352         Remove.
8353         (tui_initialize_static_data): Update.
8354         (~tui_gen_win_info): Handle more cleanup here.
8355         (~tui_source_window_base): Delete "execution_info".
8356         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8357
8358 2019-06-25  Tom Tromey  <tom@tromey.com>
8359
8360         * tui/tui-layout.c (make_command_window): Don't set
8361         can_highlight.
8362         (show_source_disasm_command): Call the reset method.
8363         (show_data): Don't set can_highlight.  Call the reset method.
8364         (tui_gen_win_info::reset): Rename from init_gen_win_info
8365         (init_and_make_win): Simplify.  Return tui_gen_win_info.
8366         (show_source_or_disasm_and_command): Call the reset method.
8367         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8368         (struct tui_cmd_window): Set can_highlight.
8369
8370 2019-06-25  Tom Tromey  <tom@tromey.com>
8371
8372         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8373         from make_visible.
8374         (tui_make_visible, tui_make_invisible): Rewrite.
8375         (tui_win_info::make_visible): Remove.
8376         (tui_source_window_base::make_visible): Update.
8377         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8378         method.  Moved from...
8379         (struct tui_win_info) <make_visible>: ...here.
8380
8381 2019-06-25  Tom Tromey  <tom@tromey.com>
8382
8383         * tui/tui-winsource.c
8384         (tui_source_window_base::do_scroll_horizontal): Remove direction
8385         parameter.
8386         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8387         direction parameter.
8388         * tui/tui-win.c (tui_win_info::forward_scroll)
8389         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8390         (tui_win_info::right_scroll): Update.
8391         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8392         direction parameter.
8393         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8394         direction parameter.
8395         * tui/tui-data.h (enum tui_scroll_direction): Remove.
8396         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8397         Remove direction parameter.
8398         (struct tui_source_window_base, struct tui_source_window)
8399         (struct tui_disasm_window, struct tui_data_window)
8400         (struct tui_cmd_window): Update.
8401
8402 2019-06-25  Tom Tromey  <tom@tromey.com>
8403
8404         * tui/tui-winsource.h (tui_set_exec_info_content)
8405         (tui_show_exec_info_content, tui_erase_exec_info_content)
8406         (tui_clear_exec_info_content, tui_update_exec_info): Change
8407         argument to tui_source_window_base.
8408         * tui/tui-winsource.c (tui_set_exec_info_content)
8409         (tui_show_exec_info_content, tui_erase_exec_info_content)
8410         (tui_clear_exec_info_content, tui_update_exec_info): Change
8411         argument to tui_source_window_base.
8412
8413 2019-06-25  Tom Tromey  <tom@tromey.com>
8414
8415         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8416         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8417
8418 2019-06-25  Tom Tromey  <tom@tromey.com>
8419
8420         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8421         check.
8422
8423 2019-06-25  Tom Tromey  <tom@tromey.com>
8424
8425         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8426         type to void.
8427         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8428         type to void.
8429         * tui/tui-source.c (tui_set_source_content): Update.
8430         * tui/tui-disasm.c (tui_set_disassem_content): Update.
8431
8432 2019-06-25  Tom Tromey  <tom@tromey.com>
8433
8434         * tui/tui-win.c (window_name_completer, tui_set_focus)
8435         (tui_all_windows_info): Use name method.
8436         * tui/tui-data.h (struct tui_gen_win_info)
8437         (struct tui_source_window, struct tui_disasm_window)
8438         (struct tui_data_window, struct tui_cmd_window) <name>: New
8439         method.
8440         (tui_win_name): Don't declare.
8441         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8442         (tui_win_name): Remove.
8443
8444 2019-06-25  Tom Tromey  <tom@tromey.com>
8445
8446         * tui/tui-winsource.h (tui_update_source_window)
8447         (tui_update_source_window_as_is): Change parameter type.
8448         * tui/tui-winsource.c (tui_update_source_window): Change win_info
8449         to be a tui_source_window_base.
8450         (tui_update_source_window_as_is): Likewise.
8451         * tui/tui-win.c (make_visible_with_new_height): Update.
8452
8453 2019-06-25  Tom Tromey  <tom@tromey.com>
8454
8455         * tui/tui-winsource.c (tui_erase_source_content)
8456         (tui_show_source_content, tui_show_exec_info_content)
8457         (tui_erase_exec_info_content): Use refresh_window method.
8458         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8459         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8460         from tui_refresh_win.
8461         (tui_data_window::refresh_window): New method.
8462         (tui_win_info::refresh, tui_source_window_base::refresh)
8463         (tui_refresh_all): Use refresh_window method.
8464         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8465         method.
8466         * tui/tui-regs.c (tui_display_register): Call refresh_window
8467         method.
8468         * tui/tui-layout.c (show_source_disasm_command)
8469         (show_source_or_disasm_and_command): Call refresh_window method.
8470         * tui/tui-data.h (struct tui_gen_win_info)
8471         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8472         New method.
8473
8474 2019-06-25  Tom Tromey  <tom@tromey.com>
8475
8476         * tui/tui.c (tui_rl_other_window, tui_enable)
8477         (tui_is_window_visible, tui_get_command_dimension): Update.
8478         * tui/tui-winsource.c (tui_update_source_window_as_is)
8479         (tui_clear_source_content, tui_erase_source_content)
8480         (tui_show_source_line, tui_source_window_base::refill)
8481         (tui_source_window_base::do_scroll_horizontal)
8482         (tui_source_window_base::set_is_exec_point_at)
8483         (tui_update_breakpoint_info, tui_set_exec_info_content)
8484         (tui_alloc_source_buffer, tui_line_is_displayed)
8485         (tui_addr_is_displayed): Update.
8486         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8487         (tui_check_and_display_highlight_if_needed)
8488         (tui_win_info::make_visible, tui_win_info::refresh)
8489         (tui_refresh_all): Update.
8490         * tui/tui-windata.c (tui_first_data_item_displayed)
8491         (tui_delete_data_content_windows, tui_erase_data_content)
8492         (tui_display_all_data, tui_data_window::refresh_all)
8493         (tui_check_data_values): Update.
8494         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8495         (tui_set_win_focus_to, tui_win_info::forward_scroll)
8496         (tui_win_info::backward_scroll, tui_refresh_all_win)
8497         (tui_resize_all, tui_set_focus, tui_all_windows_info)
8498         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8499         (tui_source_window_base::set_new_height)
8500         (tui_data_window::set_new_height)
8501         (make_invisible_and_set_new_height)
8502         (make_visible_with_new_height, new_height_ok)
8503         (parse_scrolling_args): Update.
8504         * tui/tui-stack.c (tui_show_frame_info): Update.
8505         * tui/tui-source.c (tui_set_source_content)
8506         (tui_set_source_content_nil, tui_source_is_displayed)
8507         (tui_source_window::do_scroll_vertical): Update.
8508         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8509         (tui_display_registers_from, tui_display_reg_element_at_line)
8510         (tui_check_register_values, tui_reg_command): Update.
8511         * tui/tui-layout.c (tui_default_win_height)
8512         (show_source_disasm_command, show_data, init_and_make_win)
8513         (show_source_or_disasm_and_command): Update.
8514         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8515         (tui_redisplay_readline, tui_mld_flush)
8516         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8517         (tui_getc): Update.
8518         * tui/tui-disasm.c (tui_set_disassem_content)
8519         (tui_disasm_window::do_scroll_vertical): Update.
8520         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8521         Now virtual.
8522         (struct tui_win_info): Derive from tui_gen_win_info.
8523         <~tui_win_info>: Mark as override.
8524         <generic>: Remove member.
8525         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8526         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8527         (~tui_data_window, ~tui_win_info)
8528         (tui_free_all_source_wins_content): Update.
8529         * tui/tui-command.c (tui_refresh_cmd_win): Update.
8530
8531 2019-06-25  Tom Tromey  <tom@tromey.com>
8532
8533         * tui/tui-layout.c (init_and_make_win): Use new.
8534         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8535         destructor, initializers.
8536         (tui_alloc_generic_win_info): Don't declare.
8537         * tui/tui-data.c (_locator): Add argument to constructor.
8538         (source_win, disasm_win): New globals.
8539         (exec_info): Remove.
8540         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8541         Update.
8542         (tui_alloc_generic_win_info): Remove.
8543         (init_content_element): Use new.
8544         (tui_win_info::tui_win_info): Update.
8545         (free_content_elements) <case DATA_WIN>: Use delete.
8546
8547 2019-06-25  Tom Tromey  <tom@tromey.com>
8548
8549         * tui/tui-wingeneral.c (tui_refresh_win): Update.
8550         * tui/tui-windata.c (tui_first_data_item_displayed)
8551         (tui_delete_data_content_windows): Update.
8552         * tui/tui-win.c (tui_data_window::set_new_height): Update.
8553         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8554         (tui_display_registers_from, tui_check_register_values): Update.
8555         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8556         pointer.
8557         * tui/tui-data.c (init_content_element): Update.  Allocate the new
8558         window.
8559         (tui_free_data_content): Update.
8560         (free_content_elements) <case DATA_WIN>: Free the window.
8561
8562 2019-06-25  Tom Tromey  <tom@tromey.com>
8563
8564         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8565         Update.
8566         * tui/tui-layout.c (make_command_window)
8567         (show_source_disasm_command, show_data, init_and_make_win)
8568         (show_source_or_disasm_and_command): Update.
8569         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8570         method.
8571         <can_highight, is_highlighted>: Now bool.
8572         (tui_set_win_highlight): Don't declare.
8573         * tui/tui-data.c (tui_set_win_highlight): Remove.
8574
8575 2019-06-25  Tom Tromey  <tom@tromey.com>
8576
8577         * tui/tui-wingeneral.c (make_visible): Remove check of window
8578         type.
8579
8580 2019-06-25  Tom Tromey  <tom@tromey.com>
8581
8582         * tui/tui-win.c (tui_win_info::max_height)
8583         (tui_cmd_window::max_height): New methods.
8584         (new_height_ok): Call max_height.
8585         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8586         <max_height>: New method.
8587
8588 2019-06-25  Tom Tromey  <tom@tromey.com>
8589
8590         * tui/tui-win.c (tui_source_window_base::set_new_height)
8591         (tui_data_window::set_new_height): New methods.
8592         (make_invisible_and_set_new_height): Call set_new_height method.
8593         * tui/tui-data.h (struct tui_win_info)
8594         (struct tui_source_window_base, struct tui_data_window)
8595         <set_new_height>: New method.
8596
8597 2019-06-25  Tom Tromey  <tom@tromey.com>
8598
8599         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8600         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8601         tui_refresh_data_win.
8602         * tui/tui-win.c (tui_source_window_base::refresh_all): New
8603         method.
8604         (tui_refresh_all_win): Call the refresh_all method.
8605         (tui_set_focus): Likewise.
8606         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8607         (struct tui_source_window_base, struct tui_data_window) <refresh>:
8608         Likewise.
8609
8610 2019-06-25  Tom Tromey  <tom@tromey.com>
8611
8612         * tui/tui-winsource.h (tui_refill_source_window)
8613         (tui_set_is_exec_point_at): Don't declare.
8614         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8615         (tui_source_window_base::refill): Rename from
8616         tui_refill_source_window.
8617         (tui_source_window_base::do_scroll_horizontal): Update.
8618         (tui_source_window_base::set_is_exec_point_at): Rename from
8619         tui_set_is_exec_point_at.
8620         (tui_update_all_breakpoint_info): Update.
8621         * tui/tui-stack.c (tui_show_frame_info): Update.
8622         * tui/tui-layout.c (show_data): Add cast.
8623         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8624         * tui/tui-data.h (struct tui_source_window_base) <refill,
8625         set_is_exec_point_at>: New methods.
8626         (tui_source_windows, tui_add_to_source_windows): Update types.
8627         (tui_add_to_source_windows): Remove redundant declaration.
8628         * tui/tui-data.c (source_windows): Store tui_source_window_base.
8629         (tui_source_windows): Change return type.
8630         (tui_clear_source_windows_detail): Update.
8631         (tui_add_to_source_windows): Change type of parameter.
8632         (tui_free_all_source_wins_content): Update.
8633
8634 2019-06-25  Tom Tromey  <tom@tromey.com>
8635
8636         * tui/tui-wingeneral.c (tui_win_info::refresh)
8637         (tui_source_window_base::refresh): New methods.
8638         (tui_refresh_all): Call the refresh method.
8639         * tui/tui-data.h (struct tui_win_info)
8640         (struct tui_source_window_base) <refresh>: New method.
8641
8642 2019-06-25  Tom Tromey  <tom@tromey.com>
8643
8644         * tui/tui.h (tui_is_window_visible): Return bool.
8645         * tui/tui.c (tui_is_window_visible): Return bool.
8646         * tui/tui-wingeneral.c (tui_make_window, make_visible)
8647         (tui_make_visible, tui_make_invisible)
8648         (tui_win_info::make_visible)
8649         (tui_source_window_base::make_visible, make_all_visible)
8650         (tui_make_all_visible, tui_make_all_invisible): Update.
8651         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8652         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8653         bool.
8654         (struct tui_win_info, struct tui_source_window_base)
8655         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8656         * tui/tui-data.c (tui_init_generic_part): Update.
8657
8658 2019-06-25  Tom Tromey  <tom@tromey.com>
8659
8660         * tui/tui-wingeneral.c (tui_win_info::make_visible)
8661         (tui_source_window_base::make_visible): New methods.
8662         (make_all_visible): Make method call.
8663         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8664         (struct tui_source_window_base, struct tui_cmd_window): Override
8665         make_visible.
8666         (tui_win_is_source_type): Don't declare.
8667         * tui/tui-data.c (tui_win_is_source_type): Remove.
8668
8669 2019-06-25  Tom Tromey  <tom@tromey.com>
8670
8671         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8672         NULL check.
8673
8674 2019-06-25  Tom Tromey  <tom@tromey.com>
8675
8676         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8677         Inline constructor.  Add initializers for members.
8678         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8679         constructors; now inline in class.
8680
8681 2019-06-25  Tom Tromey  <tom@tromey.com>
8682
8683         * tui/tui-regs.c (tui_show_registers): Update.
8684         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8685         bool.
8686         * tui/tui-data.c (tui_data_window::clear_detail)
8687         (tui_data_window): Update.
8688
8689 2019-06-25  Tom Tromey  <tom@tromey.com>
8690
8691         * tui/tui-windata.c (tui_display_all_data)
8692         (tui_display_data_from_line, tui_display_data_from)
8693         (tui_check_data_values, tui_data_window::do_scroll_vertical):
8694         Update.
8695         * tui/tui-regs.c (tui_last_regs_line_no)
8696         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8697         (tui_show_registers, tui_show_register_group)
8698         (tui_display_registers_from, tui_display_reg_element_at_line)
8699         (tui_display_registers_from_line, tui_check_register_values)
8700         (tui_reg_next, tui_reg_prev): Update.
8701         * tui/tui-layout.c (tui_set_layout, show_data): Update.
8702         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
8703         tui_data_window.
8704         (struct tui_win_info) <detail>: Remove.  Add new fields from
8705         tui_data_info.
8706         (TUI_DATA_WIN): Add cast.
8707         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8708         (~tui_data_window): Simplify.
8709
8710 2019-06-25  Tom Tromey  <tom@tromey.com>
8711
8712         * tui/tui-layout.c (show_source_disasm_command)
8713         (show_source_or_disasm_and_command): Update.
8714         * tui/tui-io.c (update_cmdwin_start_line)
8715         (tui_redisplay_readline): Update.
8716         * tui/tui-data.h (struct tui_command_info): Remove.
8717         (struct tui_win_info) <detail>: Remove command_info member.
8718         (struct tui_data_window) <start_line>: New member, from
8719         tui_command_info.
8720         (TUI_CMD_WIN): Add casts.
8721
8722 2019-06-25  Tom Tromey  <tom@tromey.com>
8723
8724         * tui/tui-winsource.c (tui_update_source_window)
8725         (tui_refill_source_window)
8726         (tui_source_window_base::do_scroll_horizontal)
8727         (tui_update_breakpoint_info, tui_set_exec_info_content)
8728         (tui_show_exec_info_content, tui_erase_exec_info_content)
8729         (tui_clear_exec_info_content): Update.
8730         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8731         Update.
8732         * tui/tui-win.c (make_invisible_and_set_new_height)
8733         (make_visible_with_new_height): Update.
8734         * tui/tui-source.c (tui_set_source_content)
8735         (tui_show_symtab_source): Update.
8736         * tui/tui-layout.c (extract_display_start_addr)
8737         (show_source_disasm_command, show_data)
8738         (make_source_or_disasm_window)
8739         (show_source_or_disasm_and_command): Update.
8740         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8741         (tui_disasm_window::do_scroll_vertical): Remove shadowing
8742         "gdbarch".
8743         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
8744         to tui_source_window_base.
8745         (struct tui_win_info) <detail>: Remove source_info member.
8746         (struct tui_source_window_base) <has_locator>: Inline.
8747         Move contents from tui_source_info; rename has_locator member to
8748         m_has_locator.
8749         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8750         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8751         header file.
8752         (tui_source_window_base::clear_detail, ~tui_source_window_base):
8753         Simplify.
8754         (tui_free_all_source_wins_content): Cast to
8755         tui_source_window_base.
8756
8757 2019-06-25  Tom Tromey  <tom@tromey.com>
8758
8759         * tui/tui-win.c (make_invisible_and_set_new_height)
8760         (make_visible_with_new_height): Call has_locator method.
8761         * tui/tui-layout.c (show_source_disasm_command, show_data)
8762         (show_source_or_disasm_and_command): Update for bool change.
8763         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8764         (tui_win_info) <has_locator>: New method.
8765         (struct tui_source_window_base) <has_locator>: New method.
8766         (tui_win_has_locator): Don't declare.
8767         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8768         from tui_win_has_locator.
8769         (tui_source_window_base): Use false, not FALSE.
8770
8771 2019-06-25  Tom Tromey  <tom@tromey.com>
8772
8773         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8774         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8775         clear_detail method directly.
8776         (tui_clear_win_detail): Remove.
8777
8778 2019-06-25  Tom Tromey  <tom@tromey.com>
8779
8780         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8781         "this", not TUI_DISASM_WIN.
8782
8783 2019-06-25  Tom Tromey  <tom@tromey.com>
8784
8785         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
8786         declare.
8787         * tui/tui-winsource.c
8788         (tui_source_window_base::do_scroll_horizontal): Rename from
8789         tui_horizontal_source_scroll.
8790         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8791         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8792         from tui_vertical_data_scroll.
8793         * tui/tui-win.h (tui_scroll): Don't declare.
8794         * tui/tui-win.c (tui_win_info::forward_scroll)
8795         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8796         (tui_win_info::right_scroll): Rename and update.
8797         (tui_scroll_forward_command, tui_scroll_backward_command)
8798         (tui_scroll_left_command, tui_scroll_right_command): Update.
8799         (tui_scroll): Remove.
8800         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8801         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8802         from tui_vertical_source_scroll.
8803         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8804         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8805         from tui_vertical_disassem_scroll.
8806         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8807         do_scroll_horizontal>: New methods.
8808         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8809         Likewise.
8810         (struct tui_source_window_base): Add do_scroll_horizontal.
8811         (struct tui_source_window, struct tui_disasm_window): Add
8812         do_scroll_vertical.
8813         (struct tui_data_window, struct tui_cmd_window): Add
8814         do_scroll_horizontal and do_scroll_vertical.
8815         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8816
8817 2019-06-25  Tom Tromey  <tom@tromey.com>
8818
8819         * tui/tui-data.h (struct tui_source_window_base): New struct.
8820         (struct tui_source_window): Derive from tui_source_window_base.
8821         (struct tui_disasm_window): New struct.
8822         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8823         from tui_source_window::clear_detail.
8824         (tui_source_window_base): Rename from tui_source_window.
8825         (~tui_source_window_base): Rename from ~tui_source_window.
8826         (tui_alloc_win_info): Create a tui_disasm_window.
8827
8828 2019-06-25  Tom Tromey  <tom@tromey.com>
8829
8830         * tui/tui-data.h (struct tui_source_window)
8831         (struct tui_data_window): Declare destructors.
8832         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8833         destructors.
8834         (tui_win_info): Simplify.
8835
8836 2019-06-25  Tom Tromey  <tom@tromey.com>
8837
8838         * tui/tui-winsource.c (tui_display_main)
8839         (tui_update_source_windows_with_addr)
8840         (tui_update_all_breakpoint_info): Update.
8841         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8842         (new_height_ok, parse_scrolling_args): Update.
8843         * tui/tui-stack.c (tui_show_frame_info): Update.
8844         * tui/tui-data.h (struct tui_list): Remove.
8845         (tui_source_windows): Return a reference to a std::vector.
8846         * tui/tui-data.c (source_windows): Now a std::vector.
8847         (tui_source_windows): Change return type.
8848         (tui_clear_source_windows): Rewrite.
8849         (tui_clear_source_windows_detail, tui_add_to_source_windows)
8850         (tui_free_all_source_wins_content): Rewrite.
8851
8852 2019-06-25  Tom Tromey  <tom@tromey.com>
8853
8854         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8855         (struct tui_data_window, struct tui_cmd_window): Declare
8856         clear_detail method.
8857         * tui/tui-data.c (tui_source_window::clear_detail)
8858         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8859         methods.
8860         (tui_clear_win_detail): Simplify.
8861
8862 2019-06-25  Tom Tromey  <tom@tromey.com>
8863
8864         * tui/tui-layout.c (make_source_window, make_disasm_window)
8865         (make_source_or_disasm_window): Remove win_info_ptr parameter.
8866         Return the new window.
8867         (show_source_disasm_command, show_data)
8868         (show_source_or_disasm_and_command): Update.
8869
8870 2019-06-25  Tom Tromey  <tom@tromey.com>
8871
8872         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8873         parameter.  Return the new window.
8874         (show_source_disasm_command): Update and remove NULL check.
8875         (show_source_or_disasm_and_command): Update.
8876
8877 2019-06-25  Tom Tromey  <tom@tromey.com>
8878
8879         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8880
8881 2019-06-25  Tom Tromey  <tom@tromey.com>
8882
8883         * tui/tui-data.h (struct tui_win_info): Make constructor
8884         protected.  Make destructor virtual.  Add initializers.
8885         (tui_source_window, tui_data_window, tui_cmd_window): New
8886         classes.
8887         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
8888         constructor.  Add "type" parameter.
8889         (tui_source_window, tui_data_window, tui_cmd_window): New
8890         constructors.
8891         (tui_alloc_win_info): Instantiate the appropriate subclass.
8892
8893 2019-06-25  Tom Tromey  <tom@tromey.com>
8894
8895         * tui/tui-win.c (tui_resize_all): Use delete.
8896         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8897         destructor.
8898         (tui_free_window): Don't declare.
8899         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8900         Update.
8901
8902 2019-06-25  Tom Tromey  <tom@tromey.com>
8903
8904         * tui/tui-data.h (struct tui_win_info): Add constructor.
8905         * tui/tui-data.c (tui_alloc_win_info): Use new.
8906         (tui_free_window): Use delete.
8907
8908 2019-06-22  Tom Tromey  <tom@tromey.com>
8909
8910         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8911         declare.
8912         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8913
8914 2019-06-22  Tom Tromey  <tom@tromey.com>
8915
8916         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8917         declare.
8918         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8919
8920 2019-06-22  Tom de Vries  <tdevries@suse.de>
8921
8922         * dwarf2read.c (create_addrmap_from_aranges)
8923         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8924         instead of '%zu'.
8925
8926 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
8927
8928         * dwarf2read.h (dwarf2_section_info_def): Remove.
8929         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8930         * dwarf2read.c (struct dwo_sections) <types>: Change type to
8931         std::vector<dwarf2_section_info>.
8932         (struct dwo_file) <~dwo_file>: Remove.
8933         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8934         types field.
8935         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8936         (dwarf2_read_debug_names): Likewise.
8937         (create_debug_types_hash_table): Change parameter type to
8938         array_view, adjust code accordingly.
8939         (dwarf2_locate_dwo_sections): Adjust to std::vector.
8940         (partial_die_info::fixup): Likewise.
8941         (determine_prefix): Likewise.
8942         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8943
8944 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8945
8946         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8947         gdb_bfd_ref_ptr.
8948         <~dwo_file>: Remove call to gdb_bfd_unref.
8949         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8950         gdb_bfd_ref_ptr::get.
8951
8952 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8953
8954         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8955         type to htab_up.
8956         * dwarf2read.c (struct dwo_file): Initialize fields.
8957         <~dwo_file>: New.
8958         (free_dwo_file): Remove, move content to ~dwo_file.
8959         (struct dwo_file_deleter): Remove.
8960         (dwo_file_up>: Remove custom deleter.
8961         (free_dwo_files): Remove.
8962         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8963         dwo_files.
8964         (process_skeletonless_type_units): Call unique_ptr::get.
8965         (allocate_dwo_file_hash_table): Add deleter to created hash
8966         table.  Change return type to htab_up.
8967         (lookup_dwo_file_slot): Don't memset dwo_file, call
8968         unique_ptr::get.
8969         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8970         (create_dwo_unit_in_dwp_v2): Likewise.
8971         (open_and_init_dwo_file): Likewise.
8972         (free_dwo_file_from_slot): Remove.
8973
8974 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8975
8976         * dwarf2read.h (struct dwarf2_section_info) <readin,
8977         is_virtual>: Change type to bool.
8978         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8979         true instead of 1.
8980
8981 2019-06-19  Tom Tromey  <tom@tromey.com>
8982
8983         * tui/tui-data.h (tui_init_content_element): Don't declare.
8984
8985 2019-06-19  Tom Tromey  <tom@tromey.com>
8986
8987         * tui/tui-data.h (tui_init_win_info): Don't declare.
8988
8989 2019-06-19  Tom de Vries  <tdevries@suse.de>
8990
8991         * dwarf2read.h (abstract_to_concrete): Change type to
8992         std::unordered_map<sect_offset, std::vector<sect_offset>,
8993         gdb::hash_enum<sect_offset>>.
8994
8995 2019-06-19  Tom Tromey  <tromey@adacore.com>
8996
8997         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8998         EVAL_AVOID_SIDE_EFFECTS specially.
8999
9000 2019-06-19  Tom Tromey  <tromey@adacore.com>
9001
9002         * source-cache.c (highlighter): New global.
9003         (source_cache::get_source_lines): Create a highlighter on demand.
9004
9005 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9006
9007         * defs.h (deprecated_interactive_hook): Delete declaration.
9008         * interps.c (clear_interpreter_hooks): Remove use of
9009         deprecated_interactive_hook.
9010         * top.c (deprecated_interactive_hook): Delete definition.
9011         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9012
9013 2019-06-18  Tom de Vries  <tdevries@suse.de>
9014
9015         PR gdb/24515
9016         * dwarf2read.h (abstract_to_concrete): Change type from
9017         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9018         std::unordered_map<sect_offset, std::vector<sect_offset>>.
9019         * dwarf2read.c (read_variable): Update.
9020         (dwarf2_fetch_die_loc_sect_off): Update.
9021
9022 2019-06-17  Tom de Vries  <tdevries@suse.de>
9023
9024         PR gdb/24617
9025         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9026         accessing parent[parent_len - 1].
9027
9028 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
9029
9030         PR gdb/24364
9031         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9032         call dtrace_process_dof with NULL dof.
9033
9034 2019-06-16  Tom de Vries  <tdevries@suse.de>
9035
9036         PR gdb/24445
9037         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9038
9039 2019-06-16  Tom Tromey  <tom@tromey.com>
9040
9041         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9042         (make_all_visible): Use address of member.
9043
9044 2019-06-16  Tom Tromey  <tom@tromey.com>
9045
9046         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9047         (tui_free_window, free_content, free_content_elements): Remove
9048         unnecessary cast.
9049         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9050         cast.
9051         * tui/tui-regs.c (tui_show_register_group)
9052         (tui_display_registers_from, tui_display_reg_element_at_line):
9053         Remove unnecessary cast.
9054
9055 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
9056
9057         * linux-nat.c (normal_mask): Delete.
9058         (_initialize_linux_nat): Don't initialise normal_mask.
9059
9060 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
9061
9062         PR gdb/24445
9063         * dwarf-index-write.h (write_psymtabs_to_index): Add
9064         dwz_basename parameter.
9065         * dwarf-index-write.c (write_gdbindex): Move file writing to
9066         write_gdbindex_1.  Change return type void.
9067         (assert_file_size): Move up, remove filename parameter.
9068         (write_gdbindex_1): New function.
9069         (write_debug_names): Change return type to void, call
9070         assert_file_size.
9071         (struct index_wip_file): New struct.
9072         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
9073         file logic to index_wip_file.  Write index for dwz file if
9074         needed.
9075         (save_gdb_index_command): Pass basename of dwz file, if present.
9076         * dwarf-index-cache.c (index_cache::store): Obtain and pass
9077         build-id of dwz file, if present.
9078         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9079         (dwarf2_get_dwz_file): Likewise.
9080         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9081         (dwarf2_get_dwz_file): Likewise.
9082
9083 2019-06-16  Tom Tromey  <tom@tromey.com>
9084
9085         * coffread.c (process_coff_symbol): Use xstrdup.
9086         * value.c (create_internalvar): Use xstrdup.
9087
9088 2019-06-16  Tom Tromey  <tom@tromey.com>
9089
9090         * valops.c (value_cast, value_slice): Remove unnecessary cast.
9091         * breakpoint.c (stopin_command, stopat_command)
9092         (until_break_command, decode_location_default): Remove unnecessary
9093         cast.
9094         * utils.c (subset_compare): Remove unnecessary cast.
9095         * ada-lang.c (ada_update_initial_language): Remove unnecessary
9096         cast.
9097         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9098         cast.
9099         * infcmd.c (path_command): Remove unnecessary cast.
9100         * coffread.c (decode_type): Remove unnecessary cast.
9101         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9102         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9103         * tui/tui-stack.c (tui_show_locator_content)
9104         (tui_show_frame_info): Remove unnecessary cast.
9105         * tui/tui-win.c (tui_scroll_forward_command)
9106         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9107         (parse_scrolling_args): Remove unnecessary cast.
9108         * tui/tui-data.c (init_win_info, tui_del_window)
9109         (tui_free_window, tui_del_data_windows, tui_free_data_content)
9110         (free_content_elements): Remove unnecessary cast.
9111         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9112         unnecessary cast.
9113         * tui/tui-source.c (tui_set_source_content)
9114         (tui_vertical_source_scroll): Remove unnecessary cast.
9115         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9116         cast.
9117         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9118         * tui/tui-regs.c (tui_display_registers_from)
9119         (tui_display_register): Remove unnecessary cast.
9120         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9121         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9122         (make_visible): Remove unnecessary cast.
9123         * tui/tui-winsource.c (tui_erase_source_content)
9124         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9125         unnecessary cast.
9126         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9127         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9128         * stabsread.c (read_type, read_array_type, read_range_type):
9129         Remove unnecessary cast.
9130         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9131         (parse_symbol, parse_type, upgrade_type, parse_external)
9132         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9133         unnecessary cast.
9134         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9135
9136 2019-06-16  Tom Tromey  <tom@tromey.com>
9137
9138         * tui/tui-data.c (tui_alloc_generic_win_info)
9139         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9140         checks.
9141
9142 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
9143             Andrew Burgess  <andrew.burgess@embecosm.com>
9144
9145         * f-typeprint.c (f_print_type): Don't return early for not
9146         associated or not allocated types.
9147         (f_type_print_varspec_suffix): Add print_rank parameter and print
9148         ranks of array types in case they dangling.
9149         (f_type_print_base): Add print_rank parameter.
9150
9151 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9152
9153         * NEWS: Mention new MI commands.
9154         * break-catch-throw.c (enum exception_event_kind): Move to
9155         breakpoint.h.
9156         (print_mention_exception_catchpoint): Output text as a single
9157         message.
9158         (catch_exception_command_1): Rename to...
9159         (catch_exception_event): ...this, make non-static, update header
9160         command, and change some parameter types.
9161         (catch_catch_command): Update for changes to
9162         catch_exception_command_1.
9163         (catch_throw_command): Likewise.
9164         (catch_rethrow_command): Likewise.
9165         * breakpoint.c (enum exception_event_kind): Delete.
9166         * breakpoint.h (enum exception_event_kind): Moved here from
9167         break-catch-throw.c.
9168         (catch_exception_event): Declare.
9169         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9170         (mi_cmd_catch_throw): New function.
9171         (mi_cmd_catch_rethrow): New function.
9172         (mi_cmd_catch_catch): New function.
9173         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9174         'catch-catch' entries.
9175         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9176         (mi_cmd_catch_rethrow): Declare.
9177         (mi_cmd_catch_catch): Declare.
9178
9179 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9180
9181         * annotate.c (annotate_source_line): Change return type to void,
9182         update implementation to match.
9183         * annotate.h (annotate_source_line): Change return type to void,
9184         update header comment.
9185         * stack.c (print_frame_info): Don't change what frame information
9186         is printed based on whether annotations are on or not.
9187
9188 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9189
9190         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9191         (annotate_source): Make static.
9192         (annotate_source_line): Moved from source.c and renamed from
9193         identify_source_line.  Update the return type.
9194         * annotate.h (annotate_source): Delete declaration.
9195         (annotate_source_line): Declaration moved from source.h, and
9196         renamed from identify_source_line.  Return type updated.
9197         * source.c (identify_source_line): Moved to annotate.c and renamed
9198         to annotate_source_line.
9199         (info_line_command): Remove check of annotation_level.
9200         * source.h (identify_source_line): Move declaration to annotate.h
9201         and rename to annotate_source_line.
9202         * stack.c: Add 'annotate.h' include.
9203         (print_frame_info): Remove check of annotation_level before
9204         calling annotate_source_line.
9205
9206 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9207
9208         * source-cache.c (source_cache::get_plain_source_lines): Use
9209         open_source_file_with_line_charpos instead of just
9210         open_source_file, remove call to find_source_lines.
9211         (source_cache::get_source_lines): Likewise.
9212         * source.c (find_source_lines): Make static.
9213         (get_filename_and_charpos): Renamed into...
9214         (open_source_file_with_line_charpos): ..this along with changes to
9215         return a scoped_fd, and some other minor clean ups.
9216         (identify_source_line): Use open_source_file_with_line_charpos.
9217         (search_command_helper): Use open_source_file_with_line_charpos
9218         instead of just open_source_file, remove call to
9219         find_source_lines.
9220         * source.h (open_source_file_with_line_charpos): Declare new
9221         function.
9222         (find_source_lines): Delete declaration.
9223
9224 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9225
9226         * source.c (get_filename_and_charpos): Remove fullname
9227         parameter.
9228         (identify_source_line): Update call to get_filename_and_charpos.
9229
9230 2019-06-14  Tom Tromey  <tromey@adacore.com>
9231
9232         PR gdb/24502:
9233         * ui-style.h (skip_ansi_escape): Update comment.
9234         * ui-file.h (class no_terminal_escape_file): New class.
9235         * ui-file.c (no_terminal_escape_file::write)
9236         (no_terminal_escape_file::puts): New methods.
9237         * cli/cli-logging.c (handle_redirections): Use
9238         no_terminal_escape_file.
9239
9240 2019-06-14  Tom Tromey  <tromey@adacore.com>
9241
9242         * NEWS: Move convenience variable news above Python news.
9243
9244 2019-06-14  Tom Tromey  <tom@tromey.com>
9245
9246         * gnulib: Move directory to top-level.
9247         * configure.ac: Don't configure gnulib.
9248         * configure: Rebuild.
9249         * common/common-defs.h: Use new path to gnulib.
9250         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9251         (GNULIB_H): Remove.
9252         (INCGNU): Look in new gnulib location.
9253         (HFILES_NO_SRCDIR): Remove gnulib files.
9254         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9255         (generated_files): Remove GNULIB_H.
9256         ($(LIBGNU), all-lib): Remove targets.
9257         (distclean): Don't mention GNULIB_BUILDDIR.
9258         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9259
9260 2019-06-14  Tom Tromey  <tromey@adacore.com>
9261
9262         * symfile.c (add_symbol_file_command): Remove obsolete comment.
9263         Warn if symbol file does not provide any symbols.
9264
9265 2019-06-14  Tom Tromey  <tromey@adacore.com>
9266
9267         * source.c (find_and_open_source): Respect basenames_may_differ.
9268
9269 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
9270
9271         * annotate.c (annotate_breakpoints_invalid): Make use of
9272         scoped_restore_terminal_state.
9273         (annotate_frames_invalid): Likewise.
9274
9275 2019-06-14  Tom Tromey  <tromey@adacore.com>
9276
9277         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9278         allow assignment to an internalvar.
9279
9280 2019-06-14  Tom Tromey  <tromey@adacore.com>
9281
9282         * ada-lex.l: Allow "_" in attribute names.
9283
9284 2019-06-14  Tom Tromey  <tromey@adacore.com>
9285
9286         PR gdb/24653:
9287         * regcache.c (registers_changed): Don't call alloca.
9288         * top.c (execute_command): Don't call alloca.
9289
9290 2019-06-13  Pedro Alves  <palves@redhat.com>
9291
9292         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9293         'expression'.  When parsing an expression, error out if there's
9294         junk after "unlimited".
9295         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9296         (do_set_command): Adjust calls to is_unlimited_literal.
9297
9298 2019-06-13  Pedro Alves  <palves@redhat.com>
9299
9300         * compile/compile.c (make_compile_options_def_group): Add braces
9301         around array_view initializer.
9302         * thread.c (make_thread_apply_all_options_def_group)
9303         (make_thread_apply_all_options_def_group): Likewise.
9304
9305 2019-06-13  Pedro Alves  <palves@redhat.com>
9306
9307         * NEWS (New commands): Mention "maint test-options
9308         require-delimiter", "maint test-options unknown-is-error", "maint
9309         test-options unknown-is-operand" and "maint show
9310         test-options-completion-result".
9311         (New command options, command completion): New section.
9312         (Completion improvements): New section.
9313         Mention that you can abbreviate "unlimited".
9314
9315 2019-06-13  Pedro Alves  <palves@redhat.com>
9316
9317         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9318         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9319         * unittests/cli-utils-selftests.c (test_parse_flags)
9320         (test_parse_flags_qcs): Delete.
9321         (test_cli_utils): Don't call deleted functions.
9322
9323 2019-06-13  Pedro Alves  <palves@redhat.com>
9324
9325         * thread.c: Include "cli/cli-option.h".
9326         (tp_array_compar_ascending): Global.
9327         (tp_array_compar): Delete function.
9328         (tp_array_compar_ascending, tp_array_compar_descending): New
9329         functions.
9330         (ascending_option_def, qcs_flag_option_def)
9331         (thr_qcs_flags_option_defs)
9332         (make_thread_apply_all_options_def_group)
9333         (make_thread_apply_options_def_group): New.
9334         (thread_apply_all_command): Use gdb::option::process_options.
9335         (thread_apply_command_completer)
9336         (thread_apply_all_command_completer): New.
9337         (thread_apply_command): Use gdb::option::process_options.
9338         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9339         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
9340         to generate help text of "thread apply".  Adjust "taas"'s help.
9341         * tid-parse.c (tid_range_parser::in_thread_range): New method.
9342         * tid-parse.h (tid_range_parser::in_thread_range): New method.
9343
9344 2019-06-13  Pedro Alves  <palves@redhat.com>
9345
9346         * thread.c (thread_apply_command): Check for invalid TID with
9347         isdigit instead of !isalpha.
9348
9349 2019-06-13  Pedro Alves  <palves@redhat.com>
9350
9351         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9352         (validate_flags_qcs): New.
9353         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9354         (validate_flags_qcs): Declare.
9355         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9356         (make_frame_apply_options_def_group): New.
9357         (frame_apply_command_count): Process options with
9358         gdb::option::process_options.
9359         (frame_apply_completer): New.
9360         (frame_apply_level_completer, frame_apply_all_completer)
9361         (frame_apply_completer): New.
9362         (_initialize_stack): Update help of "frame apply", "frame apply
9363         level", "frame apply all" and "faas" to mention supported options
9364         and install command completers.
9365         * stack.h (frame_apply_all_completer): Declare.
9366         * thread.c: Include "stack.h".
9367         (tfaas_command): Add "--".
9368         (_initialize_thread): Update help "tfaas" to mention supported
9369         options and install command completer.
9370
9371 2019-06-13  Pedro Alves  <palves@redhat.com>
9372
9373         * completer.c (complete_nested_command_line): New.
9374         (gdb_completion_word_break_characters_throw): Add assertion.
9375         * completer.h (complete_nested_command_line): Declare.
9376
9377 2019-06-13  Pedro Alves  <palves@redhat.com>
9378
9379         * stack.c (parse_backtrace_qualifiers): New.
9380         (backtrace_command): Use it.
9381         (backtrace_command_completer): Complete on qualifiers.
9382
9383 2019-06-13  Pedro Alves  <palves@redhat.com>
9384
9385         * frame.c: Include "cli/cli-option.h.
9386         (user_set_backtrace_options): New.
9387         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9388         Delete.
9389         (get_prev_frame): Adjust.
9390         (boolean_option_def, uinteger_option_def)
9391         (set_backtrace_option_defs): New.
9392         (_initialize_frame): Adjust and use
9393         gdb::option::add_setshow_cmds_for_options to install "set
9394         backtrace past-main" and "set backtrace past-entry".
9395         * frame.h: Include "cli/cli-option.h".
9396         (struct frame_print_options): Forward declare.
9397         (print_frame_arguments_all, print_frame_arguments_scalars)
9398         (print_frame_arguments_none): Declare.
9399         (print_entry_values): Delete declaration.
9400         (struct frame_print_options, user_frame_print_options): New.
9401         (struct set_backtrace_options): New.
9402         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9403         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9404         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9405         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9406         (list_args_or_locals): Add frame_print_options parameter.
9407         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9408         * python/py-framefilter.c (enumerate_args): Pass down
9409         USER_FRAME_PRINT_OPTIONS.
9410         * stack.c: Include "cli/cli-option.h".
9411         (print_frame_arguments_all, print_frame_arguments_scalars)
9412         (print_frame_arguments_none): Declare.
9413         (print_raw_frame_arguments, print_entry_values): Delete.
9414         (user_frame_print_options): New.
9415         (boolean_option_def, enum_option_def, frame_print_option_defs):
9416         New.
9417         (struct backtrace_cmd_options): New.
9418         (bt_flag_option_def): New.
9419         (backtrace_command_option_defs): New.
9420         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9421         (print_frame_arg, read_frame_arg, print_frame_args)
9422         (print_frame_info, print_frame): Add frame_print_options parameter
9423         and use it.
9424         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9425         (backtrace_command_1): Add frame_print_options and
9426         backtrace_cmd_options parameters and use them.
9427         (make_backtrace_options_def_group): New.
9428         (backtrace_command): Process command options with
9429         gdb::option::process_options.
9430         (backtrace_command_completer): New.
9431         (_initialize_stack): Extend "backtrace"'s help to mention
9432         supported options.  Install completer for "backtrace".
9433         Install some settings commands with add_setshow_cmds_for_options.
9434
9435 2019-06-13  Pedro Alves  <palves@redhat.com>
9436
9437         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9438         and that "set/show print raw frame-arguments" are now deprecated.
9439
9440         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9441         command.
9442         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9443         * stack.c (_initialize_stack): Install "set/show print
9444         raw-frame-arguments", and deprecate "set/show print raw
9445         frame-arguments".
9446         * valprint.c (_initialize_valprint): Deprecate "set/show print
9447         raw".
9448
9449 2019-06-13  Pedro Alves  <palves@redhat.com>
9450
9451         * compile/compile.c (struct compile_options): New.
9452         (compile_flag_option_def, compile_command_option_defs)
9453         (make_compile_options_def_group): New.
9454         (compile_file_command): Handle options with
9455         gdb::option::process_options.
9456         (compile_file_command_completer): New function.
9457         (compile_code_command): Handle options with
9458         gdb::option::process_options.
9459         (compile_code_command_completer): New function.
9460         (_initialize_compiler): Install completers for "compile code" and
9461         "compile file".  Mention available options in "compile code" and
9462         "compile code"'s help.
9463         * completer.c (advance_to_completion_word): New, factored out from
9464         ...
9465         (advance_to_expression_complete_word_point): ... this.
9466         (advance_to_filename_complete_word_point): New.
9467         * completer.h (advance_to_filename_complete_word_point): New
9468         declaration.
9469
9470 2019-06-13  Pedro Alves  <palves@redhat.com>
9471
9472         * compile/compile.c: Include "cli/cli-option.h".
9473         (compile_print_value): Scope data pointer is now a
9474         value_print_options pointer; adjust.
9475         (compile_print_command): Process options.  Scope data pointer is
9476         now a value_print_options pointer; adjust.
9477         (_initialize_compile): Update "compile print"'s help to include
9478         supported options.  Install a completer for "compile print".
9479         * cp-valprint.c (show_vtblprint, show_objectprint)
9480         (show_static_field_print): Delete.
9481         (_initialize_cp_valprint): Don't install "set print
9482         static-members", "set print vtbl", "set print object" here.
9483         * printcmd.c: Include "cli/cli-option.h" and
9484         "common/gdb_optional.h".
9485         (print_command_parse_format): Rework to fill in a
9486         value_print_options instead of a format_data.
9487         (print_value): Change parameter type from format_data pointer to
9488         value_print_options reference.  Adjust.
9489         (print_command_1): Process options.  Adjust to pass down a
9490         value_print_options.
9491         (print_command_completer): New.
9492         (_initialize_printcmd): Install print_command_completer as
9493         handle_brkchars completer for the "print" command.  Update
9494         "print"'s help to include supported options.
9495         * valprint.c: Include "cli/cli-option.h".
9496         (show_vtblprint, show_objectprint, show_static_field_print): Moved
9497         here from cp-valprint.c.
9498         (boolean_option_def, uinteger_option_def)
9499         (value_print_option_defs, make_value_print_options_def_group):
9500         New.  Use gdb::option::add_setshow_cmds_for_options to install
9501         "set print elements", "set print null-stop", "set print repeats",
9502         "set print pretty", "set print union", "set print array", "set
9503         print address", "set print symbol", "set print array-indexes".
9504         * valprint.h: Include <string> and "cli/cli-option.h".
9505         (make_value_print_options_def_group): Declare.
9506         (print_value): Change parameter type from format_data pointer to
9507         value_print_options reference.
9508         (print_command_completer): Declare.
9509
9510 2019-06-13  Pedro Alves  <palves@redhat.com>
9511
9512         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9513         (COMMON_SFILES): Add maint-test-settings.c.
9514         * cli/cli-decode.c (boolean_enums): New global, factored out from
9515         ...
9516         (add_setshow_boolean_cmd): ... here.
9517         * cli/cli-decode.h (boolean_enums): Declare.
9518         * cli/cli-option.c: New file.
9519         * cli/cli-option.h: New file.
9520         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9521         factored out from ...
9522         (parse_cli_boolean_value(const char *)): ... this.
9523         (is_unlimited_literal): Change parameter type to pointer to
9524         pointer.  Adjust and advance ARG pointer.
9525         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9526         (parse_cli_var_enum): New, factored out from ...
9527         (do_set_command): ... this.  Adjust.
9528         * cli/cli-setshow.h (parse_cli_boolean_value)
9529         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9530         (parse_cli_var_enum): Declare.
9531         * cli/cli-utils.c: Include "cli/cli-option.h".
9532         (get_ulongest): New.
9533         * cli/cli-utils.h (get_ulongest): Declare.
9534         (check_for_argument): New overloads.
9535         * maint-test-options.c: New file.
9536
9537 2019-06-13  Pedro Alves  <palves@redhat.com>
9538
9539         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9540         parse a range if "-" is at the end of the string.
9541
9542 2019-06-13  Pedro Alves  <palves@redhat.com>
9543
9544         * cli/cli-setshow.c (parse_auto_binary_operation)
9545         (parse_cli_boolean_value): Don't allow "o".
9546
9547 2019-06-13  Pedro Alves  <palves@redhat.com>
9548
9549         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9550         * NEWS: Mention maint test-settings KIND.
9551         * maint-test-settings.c: New file.
9552
9553 2019-06-13  Pedro Alves  <palves@redhat.com>
9554
9555         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9556         completer.
9557         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9558         "set" completers.
9559
9560 2019-06-13  Pedro Alves  <palves@redhat.com>
9561
9562         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9563         after item.
9564
9565 2019-06-13  Pedro Alves  <palves@redhat.com>
9566
9567         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9568
9569 2019-06-13  Pedro Alves <palves@redhat.com>
9570
9571         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9572         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9573         call.
9574         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9575         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9576         calls.
9577         (check_for_argument): Skip spaces after argument.
9578
9579 2019-06-13  Pedro Alves  <palves@redhat.com>
9580
9581         * thread.c (thread_apply_command): Adjust TID parsing.
9582         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9583         detected before end of string.
9584         (tid_is_in_list): Error out if LIST is invalid.
9585
9586 2019-06-13  Pedro Alves  <palves@redhat.com>
9587
9588         * completer.c (complete_line_internal_1): Rewind completion word
9589         point.
9590         (completion_tracker::advance_custom_word_point_by): Change
9591         parameter type to int.
9592         * completer.h (completion_tracker::advance_custom_word_point_by):
9593         Likewise.
9594
9595 2019-06-13  Pedro Alves  <palves@redhat.com>
9596
9597         * completer.c (advance_to_completion_word): Handle delimiters.
9598
9599 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
9600
9601         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9602
9603 2019-06-11  Tom Tromey  <tom@tromey.com>
9604
9605         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9606         (xmalloc_failed): Move to alloc.c.
9607         * alloc.c: New file.
9608         * Makefile.in (COMMON_SFILES): Add alloc.c.
9609
9610 2019-06-11  Tom Tromey  <tom@tromey.com>
9611
9612         * nat/linux-waitpid.c: Don't include server.h.
9613         (linux_debug): Remove.
9614         (my_waitpid): Update.
9615
9616 2019-06-11  Tom Tromey  <tromey@adacore.com>
9617
9618         * infcall.c (_initialize_infcall): Remove trailing newline from
9619         help.
9620         * user-regs.c (_initialize_user_regs): Remove trailing newline
9621         from help.
9622         * typeprint.c (_initialize_typeprint): Remove trailing newline
9623         from help.
9624         * reverse.c (_initialize_reverse): Remove trailing newlines from
9625         help.
9626         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9627         from help.
9628         * language.c (add_set_language_command): Remove trailing newline
9629         from help.
9630         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9631         help.
9632         * disasm.c (_initialize_disasm): Remove trailing newline from
9633         help.
9634         * top.c (init_main): Remove trailing newline from help.
9635         * interps.c (_initialize_interpreter): Remove trailing newline
9636         from help.
9637         * btrace.c (_initialize_btrace): Remove trailing newlines from
9638         help.
9639         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9640         from help.
9641         * python/python.c (_initialize_python): Remove trailing newline
9642         from help.
9643         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9644         help.
9645         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9646         from help.  Reformat some text.
9647         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9648         from help.
9649         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9650         newline from help.
9651
9652 2019-06-11  Tom Tromey  <tromey@adacore.com>
9653
9654         * darwin-nat.c (darwin_decode_exception_message)
9655         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9656
9657 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9658
9659         * valops.c (value_slice): Check for not allocated or not
9660         associated values.
9661
9662 2019-06-10  Tom de Vries  <tdevries@suse.de>
9663
9664         PR gdb/24618
9665         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9666         sure an empty slot (defined by a 32-bit zero pair) is recognized as
9667         invalid.
9668
9669 2019-06-10  Tom de Vries  <tdevries@suse.de>
9670
9671         PR gdb/24611
9672         * linespec.c (linespec_lexer_lex_string): Remove incorrect
9673         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
9674
9675 2019-06-10  Tom de Vries  <tdevries@suse.de>
9676
9677         PR symtab/24545
9678         * symtab.c (struct demangled_name_entry): Add language field.
9679         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
9680         static minimal symbol".  Set and use language field.
9681
9682 2019-06-10  Tom Tromey  <tromey@adacore.com>
9683
9684         * ada-lang.c (_initialize_ada_language): Update help text.
9685
9686 2019-06-10  Tom Tromey  <tromey@adacore.com>
9687
9688         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9689         with a newline.
9690         * guile/guile.c (handle_boot_error): Don't end warning with a
9691         newline.
9692         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9693         warning with a newline.
9694         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9695         newline.
9696         (s12z_frame_cache): Likewise.
9697         * dwarf-index-cache.c (index_cache::store): Don't end warning with
9698         a newline.
9699         * solib-svr4.c (disable_probes_interface): Don't end warning with
9700         a newline.
9701         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9702         newline.
9703         * python/python.c (do_finish_initialization): Don't end warning
9704         with a newline.
9705
9706 2019-06-10  Tom Tromey  <tom@tromey.com>
9707
9708         * python/py-breakpoint.c (gdbpy_breakpoint_created)
9709         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9710         gdbpy_enter.
9711
9712 2019-06-10  Tom Tromey  <tromey@adacore.com>
9713
9714         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9715         data.
9716         (elf_new_init): Don't call stabsread_new_init.
9717         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9718         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
9719         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9720
9721 2019-06-10  Tom de Vries  <tdevries@suse.de>
9722
9723         PR symtab/16264
9724         PR symtab/24517
9725         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9726
9727 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
9728
9729         * source.c (find_and_open_source): Also rewrite relative file
9730         names.
9731
9732 2019-04-26  Amos Bird  <amosbird@gmail.com>
9733
9734         * annotate.c (annotate_thread_exited): Add "thread-exited"
9735         annotation.
9736
9737 2019-06-06  Tom Tromey  <tromey@adacore.com>
9738
9739         * maint.h (class scoped_command_stats): Use
9740         DISABLE_COPY_AND_ASSIGN.
9741         <print_time>: New method.
9742         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9743         print_time.
9744         (scoped_command_stats::print_time): New method.
9745
9746 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
9747
9748         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9749         instructions of lengths 6 or 8 bytes.
9750
9751 2019-06-04  Pedro Alves  <palves@redhat.com>
9752
9753         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9754
9755         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9756         * breakpoint.c (condition_completer): Likewise.
9757         * cli/cli-dump.c (scan_expression): Likewise.
9758         * common/filestuff.c (mkdir_recursive): Likewise.
9759         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9760         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9761         (gdb_abspath): Likewise.
9762         * compile/compile-cplus-types.c
9763         (compile_cplus_instance::decl_name): Likewise.
9764         * completer.c (complete_explicit_location):
9765         (signal_completer, reg_or_group_completer_1): Likewise.
9766         * cp-support.c (cp_remove_params_if_any): Likewise.
9767         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9768         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9769         * infcmd.c (strip_bg_char): Likewise.
9770         * linespec.c (copy_token_string): Likewise.
9771         * mi/mi-main.c (output_cores): Likewise.
9772         * psymtab.c (psymtab_search_name):
9773         * symfile.c (test_set_ext_lang_command): Likewise.
9774         * target.c (target_fileio_read_stralloc): Likewise.
9775         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9776         * value.c (complete_internalvar): Likewise.
9777
9778 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
9779
9780         Add objfile property to gdb.Type.
9781         * NEWS: Mention Python API addition.
9782         * python/py-type.c (typy_get_objfile): New method.
9783
9784 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9785
9786         * NEWS: Mention the new set|show style [title|highlight].
9787         Mention changes to "show style", "help" and "apropos".
9788
9789 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9790
9791         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9792         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
9793         instead of print_help_for_command.
9794         (print_doc_of_command): New function.
9795         (help_list): Add 'apropos -v word' suggestion.
9796         (print_help_for_command): Style the command name using title style.
9797         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9798         (_initialize_cli_cmds): Describe -v in apropos_command help.
9799
9800 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9801
9802         * cli/cli-style.h (cli_style_option): Add name in constructor,
9803         add m_name class member, add constructor with intensity,
9804         add name class function.
9805         (cli_style_option::add_setshow_commands): Remove name argument.
9806         (highlight_style, title_style): New styles.
9807         * cli/cli-style.c (do_show): New function that shows a style
9808         characteristic styling the style name with itself.
9809         (set_style_name): New function.
9810         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9811         Update all callers according to the changes in cli/cli-style.h.
9812         * utils.h (fputs_highlighted): New function.
9813         * utils.c (fputs_highlighted): Likewise.
9814
9815 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9816
9817         * NEWS: Mention new pipe command and new convenience variables.
9818
9819 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9820
9821         * cli/cli-cmds.c (pipe_command): New function.
9822         (_initialize_cli_cmds): Call add_com for pipe_command.
9823         Define | as an alias for pipe.
9824         (exit_status_set_internal_vars): New function.
9825         (shell_escape): Call exit_status_set_internal_vars.
9826         cli/cli-decode.c (find_command_name_length): Recognize | as
9827         a single character command.
9828
9829 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9830
9831         * gdbcmd.h (execute_command_to_ui_file): New declaration.
9832         top.c (execute_command_to_ui_file): New function, mostly a copy
9833         of execute_command_to_string.
9834         (execute_command_to_string): Implement by calling
9835         execute_command_to_ui_file.
9836
9837 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9838
9839         * top.h (saved_command_line): Remove declaration.
9840         * top.c (previous_saved_command_line, previous_repeat_arguments):
9841         New variables.
9842         (saved_command_line): Make static, define together with other
9843         'repeat variables'.
9844         (dont_repeat): Clear repeat_arguments.
9845         (repeat_previous, get_saved_command_line, save_command_line):
9846         New functions.
9847         (gdb_init): Initialize saved_command_line
9848         and previous_saved_command_line.
9849         * main.c (captured_main_1): Remove saved_command_line initialization.
9850         * event-top.c (handle_line_of_input): Update to use
9851         the new 'repeat' related functions instead of direct access to
9852         saved_command_line.
9853         * command.h (repeat_previous, get_saved_command_line,
9854         save_command_line): New declarations.
9855         (dont_repeat): Add comment.
9856
9857 2019-05-30  Tom Tromey  <tromey@adacore.com>
9858
9859         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9860         Fix comment.
9861         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9862
9863 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
9864
9865         PR cli/24587
9866         * completer.c (complete): Initialize variable word.
9867
9868 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
9869
9870         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9871         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9872         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9873         'body' is NULL to the outter 'if', protecting the '!is_define'
9874         situation as well.
9875
9876 2019-05-29  Tom Tromey  <tromey@adacore.com>
9877
9878         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9879         (dwarf_unknown): New function.
9880         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9881         (dwarf_type_encoding_name): Use dwarf_unknown.
9882
9883 2019-05-29  Tom Tromey  <tromey@adacore.com>
9884
9885         PR c++/20020:
9886         * cp-valprint.c (cp_print_value_fields): Call
9887         cp_print_static_field inside "try".
9888
9889 2019-05-29  Tom Tromey  <tromey@adacore.com>
9890
9891         * inflow.c (struct terminal_info): Add default operator=.
9892         * configure: Rebuild.
9893         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9894         -Wdeprecated-copy-dtor, -Wredundant-move.
9895
9896 2019-05-29  Tom Tromey  <tromey@adacore.com>
9897
9898         * NEWS: Add entry.
9899         * infcmd.c (print_return_value_1): Handle finish_print
9900         option.
9901         (show_print_finish): New function.
9902         (_initialize_infcmd): Add "set/show print finish" commands.
9903         * valprint.c (user_print_options): Initialize new member.
9904         * valprint.h (struct value_print_options) <finish_print>: New
9905         member.
9906
9907 2019-05-28  Tom Tromey  <tromey@adacore.com>
9908
9909         * ada-lang.c (ada_remove_Xbn_suffix)
9910         (find_old_style_renaming_symbol)
9911         (parse_old_style_renaming): Remove.
9912         (ada_find_renaming_symbol): Don't call
9913         find_old_style_renaming_symbol.
9914         (ada_is_renaming_symbol): Rename from
9915         ada_find_renaming_symbol.  Remove "block" parameter.  Return
9916         bool.  Now static.
9917         (ada_read_var_value): Update and simplify.
9918         * ada-exp.y (write_var_or_type): Remove old code.
9919
9920 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
9921
9922         PR gdb/25010
9923         * event-top.c: Remove include comment.
9924         * inflow.c (class scoped_ignore_sigttou): Move from here...
9925         * inflow.h (class scoped_ignore_sigttou): ...to here.
9926         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9927         * top.c:  Remove include comment.
9928
9929 2019-05-27  Tom Tromey  <tom@tromey.com>
9930
9931         * NEWS: Fix typo.
9932
9933 2019-05-22  Tom Tromey  <tromey@adacore.com>
9934
9935         * target.c (target_follow_exec): Constify parameter.
9936         * target-delegates.c: Rebuild.
9937         * remote.c (remote_target::follow_exec): Constify parameter.
9938         * infrun.c (follow_exec): Constify parameter.
9939         * target.h (struct target_ops) <follow_exec>: Constify parameter.
9940         (target_follow_exec): Likewise.
9941
9942 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9943
9944         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9945         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9946
9947 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9948
9949         * NEWS: Add debugredirect and testsuite sections.
9950
9951 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
9952
9953         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9954         target descriptions using exclusively floating point register name
9955         aliases.
9956
9957 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
9958
9959         PR gdb/18644:
9960         * f-lang.c (build_fortran_types): Handle the case where
9961         gdbarch_floatformat_for_type returns a nullptr.
9962
9963 2019-05-21  Tom de Vries  <tdevries@suse.de>
9964
9965         PR cli/24587
9966         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9967
9968 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9969
9970         PR gdb/18644:
9971         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9972         16-byte floats.
9973         * i386-tdep.c (i386_floatformat_for_type): Use
9974         floatformats_ia64_quad for the 16-byte floating point component
9975         within a fortran 32-byte complex number.
9976
9977 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9978
9979         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9980         delete default constructor.
9981         (find_partial_die): Update to return const struct.
9982         (partial_die_parent_scope): Move variable declaration into scope
9983         of its use and change its type to auto.
9984         (guess_partial_die_structure_name): Likewise.
9985         (partial_die_info::fixup): Likewise.
9986
9987 2019-05-17  Tom Tromey  <tromey@adacore.com>
9988
9989         * source.c (find_and_open_source): Remove cast.
9990
9991 2019-05-17  Tom Tromey  <tromey@adacore.com>
9992
9993         * annotate.c (annotate_source): Make "filename" const.
9994         * annotate.h (annotate_source): Use const.
9995
9996 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9997
9998         * disasm.c (set_disassembler_options): Send errors to stderr.
9999
10000 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10001
10002         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10003         (cli_interp_base::set_logging): Check debug_redirect.
10004         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10005         * cli/cli-logging.c (debug_redirect): Add static variable.
10006         (pop_output_files): Add default param.
10007         (handle_redirections): Print debug setting.
10008         (show_logging_command): Likewise.
10009         (_initialize_cli_logging): Add debugredirect command.
10010         * interps.c (current_interp_set_logging): Add debug_redirect
10011         parameter.
10012         * interps.h (set_logging): Add debug_redirect parameter.
10013         (current_interp_set_logging): Likewise.
10014         * mi/mi-common.h: Likewise.
10015         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10016
10017 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10018             Tom Tromey  <tromey@adacore.com>
10019
10020         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10021         directly.
10022         * cli/cli-interp.h (make_logging_output): Remove declaration.
10023         * cli/cli-logging.c (make_logging_output): Remove function.
10024         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10025         directly.
10026         * ui-file.c (tee_file::tee_file): Remove bools.
10027         (tee_file::~tee_file): Remove deletes.
10028         * ui-file.h (tee_file): Remove bools.
10029
10030 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
10031
10032         * mi/mi-cmds.h (mi_cmd_complete): New function.
10033         * mi/mi-main.c (mi_cmd_complete): Likewise.
10034         * mi/mi-cmds.c: Define new MI command -complete.
10035         * NEWS: Mention new -complete command.
10036
10037 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
10038
10039         * completer.h (complete): New function.
10040         * completer.c (complete): Likewise.
10041         * cli/cli-cmds.c: (complete_command): Update to use new complete()
10042         function defined in completer.h.
10043
10044 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
10045
10046         * MAINTAINERS (Write After Approval): Add myself.
10047
10048 2019-05-17  Tom de Vries  <tdevries@suse.de>
10049
10050         PR gdb/24094
10051         * dwarf2read.c (struct cu_partial_die_info): New struct.
10052         (find_partial_die): Return cu_partial_die_info.
10053         (partial_die_parent_scope, guess_partial_die_structure_name)
10054         (partial_die_info::fixup): Handle new return type of find_partial_die.
10055
10056 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10057
10058         PR breakpoints/24541
10059         * stap-probe.c (stap_parse_register_operand): Make "regname" an
10060         "std::string", simplifying the algorithm.
10061
10062 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10063
10064         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10065         (stap_static_probe_ops::get_probes): Likewise.
10066
10067 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10068
10069         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10070         '-')" and "else if".
10071         (stap_parse_single_operand): Join checks for
10072         "gdbarch_stap_parse_special_token_p" and
10073         "gdbarch_stap_parse_special_token" in the same "if" statement.
10074         Invert check when verifying for operation on register
10075         displacement.
10076
10077 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10078
10079         * stap-probe.c (stap_get_opcode): Update comment.
10080         (stap_get_expected_argument_type): Likewise.
10081         (handle_stap_probe): Likewise.
10082
10083 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10084
10085         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10086         return type to 'bool'.  Adjust comment.  Use 'bool' when
10087         appropriate.
10088         (i386_stap_parse_special_token_three_arg_disp): Likewise.
10089         * stap-probe.c (stap_parse_argument_1): Likewise.
10090         (stap_is_operator): Likewise.
10091         (stap_is_generic_prefix): Likewise.
10092         (stap_is_register_prefix): Likewise.
10093         (stap_is_register_indirection_prefix): Likewise.
10094         (stap_is_integer_prefix): Likewise.
10095         (stap_generic_check_suffix): Likewise.
10096         (stap_check_integer_suffix): Likewise.
10097         (stap_check_register_suffix): Likewise.
10098         (stap_check_register_indirection_suffix): Likewise.
10099         (stap_parse_register_operand): Likewise.
10100         (stap_parse_single_operand): Likewise.
10101         (stap_parse_argument_1): Likewise.
10102         (stap_probe::get_argument_count): Likewise.
10103         (stap_is_operator): Likewise.
10104
10105 2019-05-16  Tom Tromey  <tromey@adacore.com>
10106
10107         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10108         keyword to foreach.
10109
10110 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
10111
10112         * linux-thread-db.c (try_thread_db_load_1): Change return type
10113         to bool.
10114         (try_thread_db_load): Likewise.
10115         (try_thread_db_load_from_pdir_1): Likewise.
10116         (try_thread_db_load_from_pdir): Likewise.
10117         (try_thread_db_load_from_sdir): Likewise.
10118         (try_thread_db_load_from_dir): Likewise.
10119         (thread_db_load_search): Likewise.
10120         (has_libpthread): Likewise.
10121         (thread_db_load): Likewise.
10122
10123 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
10124
10125         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10126         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10127         NULL, and complain/return if that's the case.
10128
10129 2019-05-15  John Darrington <john@darrington.wattle.id.au>
10130
10131         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10132         (advance, posn, abstract_read_memory): New functions.
10133         [struct mem_read_abstraction]: New struct.
10134         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10135
10136 2019-05-14  Tom Tromey  <tromey@adacore.com>
10137
10138         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10139         value is not lval_memory.
10140
10141 2019-05-14  Tom Tromey  <tromey@adacore.com>
10142
10143         * solib.c (info_sharedlibrary_command): Style the file name.
10144
10145 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
10146
10147         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10148         (aarch64_vnv_type): Likewise.
10149         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10150         * common/tdesc.c: Likewise.
10151         * common/tdesc.h (enum tdesc_type_kind): Likewise.
10152         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10153         * features/aarch64-fpu.xml: Add ieee half view.
10154         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10155         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10156         * gdbtypes.h (struct builtin_type): Likewise.
10157         (struct objfile_type): Likewise.
10158
10159 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
10160
10161         * language.c (language_sniff_from_mangled_name): Fix "langauge"
10162         typo.
10163         * location.h (string_to_event_location): Likewise.
10164
10165 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
10166
10167         GDB 8.3 released.
10168
10169 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10170
10171         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10172         New variable declaration.
10173         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10174         New variable.
10175         (print_one_breakpoint): Use ui_out::test_flags and new global
10176         variable to compute use_fixed_output.
10177         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10178         Remove.
10179         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10180         (mi_multi_location_breakpoint_output_fixed): Remove.
10181         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10182         new variable.
10183         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10184         fix_multi_location_breakpoint_output flag if version >= 3.
10185         * ui-out.h (enum ui_out_flag)
10186         <fix_multi_location_breakpoint_output>: New enumerator.
10187
10188 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10189
10190         * contrib/cc-with-tweaks.sh: Validate dwz's work.
10191
10192 2019-05-10  Tom Tromey  <tromey@adacore.com>
10193
10194         * ada-lang.c (catch_ada_completer): New function.
10195         (_initialize_ada_language): Use it.
10196
10197 2019-05-10  Tom Tromey  <tromey@adacore.com>
10198
10199         * thread.c (print_thread_info): Make "requested_threads" const.
10200         * gdbthread.h (print_thread_info): Make "requested_threads"
10201         const.
10202         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10203         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10204
10205 2019-05-08  Tom Tromey  <tom@tromey.com>
10206
10207         * gdbtypes.c (objfile_type_data): Change type.
10208         (objfile_type, _initialize_gdbtypes): Update.
10209
10210 2019-05-08  Tom Tromey  <tom@tromey.com>
10211
10212         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10213         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10214         (_initialize_dwarf2_frame): Update.
10215
10216 2019-05-08  Tom Tromey  <tom@tromey.com>
10217
10218         * objc-lang.c (objc_objfile_data): Change type.
10219         (find_methods): Update.
10220         (_initialize_objc_lang): Remove.
10221
10222 2019-05-08  Tom Tromey  <tom@tromey.com>
10223
10224         * stabsread.c (rs6000_builtin_type_data): Change type.
10225         (rs6000_builtin_type, _initialize_stabsread): Update.
10226
10227 2019-05-08  Tom Tromey  <tom@tromey.com>
10228
10229         * mips-tdep.c (mips_pdr_data): Remove.
10230         (_initialize_mips_tdep): Update.
10231
10232 2019-05-08  Tom Tromey  <tom@tromey.com>
10233
10234         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10235         (hppa_init_objfile_priv_data, read_unwind_info)
10236         (find_unwind_entry, _initialize_hppa_tdep): Update.
10237
10238 2019-05-08  Tom Tromey  <tom@tromey.com>
10239
10240         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10241         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
10242         on obstack.
10243         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10244
10245 2019-05-08  Tom Tromey  <tom@tromey.com>
10246
10247         * mdebugread.c (basic_type_data): Change type.
10248         (basic_type, _initialize_mdebugread): Update.
10249
10250 2019-05-08  Tom Tromey  <tom@tromey.com>
10251
10252         * common/gdb_unique_ptr.h (struct noop_deleter): New.
10253
10254 2019-05-08  Tom Tromey  <tom@tromey.com>
10255
10256         * nto-tdep.c (nto_inferior_data_reg): Change type.
10257         (nto_inferior_data): Update.
10258         (nto_inferior_data_cleanup, nto_new_inferior_data)
10259         (_initialize_nto_tdep): Remove.
10260         * nto-tdep.h (struct nto_inferior_data): Add initializers.
10261
10262 2019-05-08  Tom Tromey  <tom@tromey.com>
10263
10264         * ada-lang.c (struct ada_inferior_data): Add initializers.
10265         (ada_inferior_data): Change type.
10266         (ada_inferior_data_cleanup): Remove.
10267         (get_ada_inferior_data, ada_inferior_exit)
10268         (struct ada_pspace_data): Add initializers, destructor.
10269         (ada_pspace_data_handle): Change type.
10270         (get_ada_pspace_data): Update.
10271         (ada_pspace_data_cleanup): Remove.
10272
10273 2019-05-08  Tom Tromey  <tom@tromey.com>
10274
10275         * coffread.c (struct coff_symfile_info): Add initializers.
10276         (coff_objfile_data_key): Move lower.  Change type.
10277         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10278         Update.
10279         (coff_free_info): Remove.
10280
10281 2019-05-08  Tom Tromey  <tom@tromey.com>
10282
10283         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10284         (fbsd_pspace_data_handle): Move lower.  Change type.
10285         (get_fbsd_pspace_data): Update.
10286         (fbsd_pspace_data_cleanup): Remove.
10287         (_initialize_fbsd_tdep): Update.
10288
10289 2019-05-08  Tom Tromey  <tom@tromey.com>
10290
10291         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10292         (get_ada_tasks_pspace_data): Update.
10293         (ada_tasks_pspace_data_cleanup): Remove.
10294         (_initialize_tasks): Update.
10295         (ada_tasks_inferior_data_handle): Change type.
10296         (get_ada_tasks_inferior_data): Update.
10297         (ada_tasks_inferior_data_cleanup): Remove.
10298         (struct ada_tasks_pspace_data): Add initializers.
10299
10300 2019-05-08  Tom Tromey  <tom@tromey.com>
10301
10302         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10303         * symfile-debug.c (debug_sym_get_probes): Change type.
10304         * stap-probe.c (handle_stap_probe):
10305         (stap_static_probe_ops::get_probes): Change type.
10306         * probe.h (class static_probe_ops) <get_probes>: Change type.
10307         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10308         (parse_probes_in_pspace): Update.
10309         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10310         Update.
10311         (any_static_probe_ops::get_probes): Change type.
10312         * elfread.c (elfread_data): New typedef.
10313         (probe_key): Change type.
10314         (elf_get_probes): Likewise.  Update.
10315         (probe_key_free): Remove.
10316         (_initialize_elfread): Update.
10317         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10318         Change type.
10319         (dtrace_process_dof_probe, dtrace_process_dof)
10320         (dtrace_static_probe_ops::get_probe): Change type.
10321
10322 2019-05-08  Tom Tromey  <tom@tromey.com>
10323
10324         * xcoffread.c (struct xcoff_symfile_info): Rename from
10325         coff_symfile_info.  Add initializers.
10326         (xcoff_objfile_data_key): Move lower.  Change type.
10327         (XCOFF_DATA): Rewrite.
10328         (xcoff_free_info): Remove.
10329         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10330         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10331         (xcoff_initial_scan): Update.
10332
10333 2019-05-08  Tom Tromey  <tom@tromey.com>
10334
10335         * solib-svr4.c (struct svr4_info): Add initializers and
10336         destructor.
10337         <probes_table>: Now an htab_up.
10338         (solib_svr4_pspace_data): Change type.
10339         (free_probes_table): Simplify.
10340         (~svr4_info): Rename from svr4_pspace_data_cleanup.
10341         (get_svr4_info, probes_table_htab_remove_objfile_probes)
10342         (probes_table_remove_objfile_probes, register_solib_event_probe)
10343         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10344         (_initialize_svr4_solib): Update.
10345
10346 2019-05-08  Tom Tromey  <tom@tromey.com>
10347
10348         * remote.c (remote_pspace_data): Change type.
10349         (remote_pspace_data_cleanup): Remove.
10350         (get_remote_exec_file, set_pspace_remote_exec_file)
10351         (_initialize_remote): Update.
10352
10353 2019-05-08  Tom Tromey  <tom@tromey.com>
10354
10355         * breakpoint.c (breakpoint_objfile_key): Change type.
10356         (get_breakpoint_objfile_data): Update.
10357         (free_breakpoint_objfile_data): Remove.
10358         (_initialize_breakpoint): Update.
10359
10360 2019-05-08  Tom Tromey  <tom@tromey.com>
10361
10362         * linux-tdep.c (struct linux_info): Add initializers.
10363         (linux_inferior_data): Move.  Change type.
10364         (invalidate_linux_cache_inf): Update.
10365         (linux_inferior_data_cleanup): Remove.
10366         (get_linux_inferior_data, _initialize_linux_tdep): Update.
10367
10368 2019-05-08  Tom Tromey  <tom@tromey.com>
10369
10370         * auxv.c (auxv_inferior_data): Move.  Change type.
10371         (auxv_inferior_data_cleanup): Remove.
10372         (invalidate_auxv_cache_inf): Rewrite.
10373         (get_auxv_inferior_data, _initialize_auxv): Update.
10374
10375 2019-05-08  Tom Tromey  <tom@tromey.com>
10376
10377         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10378         (symfile_debug_objfile_data_key): Change type.
10379         (symfile_debug_installed, debug_qf_has_symbols)
10380         (debug_qf_find_last_source_symtab)
10381         (debug_qf_forget_cached_source_info)
10382         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10383         (debug_qf_print_stats, debug_qf_dump)
10384         (debug_qf_expand_symtabs_for_function)
10385         (debug_qf_expand_all_symtabs)
10386         (debug_qf_expand_symtabs_with_fullname)
10387         (debug_qf_map_matching_symbols)
10388         (debug_qf_expand_symtabs_matching)
10389         (debug_qf_find_pc_sect_compunit_symtab)
10390         (debug_qf_map_symbol_filenames)
10391         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10392         (debug_sym_new_init, debug_sym_init, debug_sym_read)
10393         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10394         (debug_sym_read_linetable, debug_sym_relocate): Update.
10395         (symfile_debug_free_objfile): Remove.
10396         (install_symfile_debug_logging, _initialize_symfile_debug):
10397         Update.
10398
10399 2019-05-08  Tom Tromey  <tom@tromey.com>
10400
10401         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10402         allocate_on_obstack.
10403         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10404         (get_dwarf2_per_objfile): Update.
10405         (set_dwarf2_per_objfile): Remove.
10406         (dwarf2_has_info, dwarf2_get_section_info): Update.
10407         (dwarf2_free_objfile): Remove.
10408         (_initialize_dwarf2_read): Update.
10409
10410 2019-05-08  Tom Tromey  <tom@tromey.com>
10411
10412         * auto-load.c (struct auto_load_pspace_info): Add destructor and
10413         initializers.
10414         <unsupported_script_warning_printed,
10415         script_not_found_warning_printed>: Now bool.
10416         (auto_load_pspace_data): Change type.
10417         (~auto_load_pspace_info): Rename from
10418         auto_load_pspace_data_cleanup.
10419         (get_auto_load_pspace_data, init_loaded_scripts_info)
10420         (clear_section_scripts, maybe_print_unsupported_script_warning)
10421         (maybe_print_script_not_found_warning, _initialize_auto_load):
10422         Update.
10423
10424 2019-05-08  Tom Tromey  <tom@tromey.com>
10425
10426         * objfiles.c (objfile_pspace_info): Add destructor and
10427         initializers.
10428         (objfiles_pspace_data): Change type.
10429         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10430         (get_objfile_pspace_data): Update.
10431         (objfiles_bfd_data): Change type.
10432         (get_objfile_bfd_data): Update.
10433         (objfile_bfd_data_free, _initialize_objfiles): Remove.
10434
10435 2019-05-08  Tom Tromey  <tom@tromey.com>
10436
10437         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10438         Change type.
10439         (get_catch_syscall_inferior_data): Update.
10440         (catch_syscall_inferior_data_cleanup): Remove.
10441         (_initialize_break_catch_syscall): Update.
10442
10443 2019-05-08  Tom Tromey  <tom@tromey.com>
10444
10445         * inflow.c (struct terminal_info): Add destructor and
10446         initializers.
10447         (inflow_inferior_data): Change type.
10448         (~terminal_info): Rename from inflow_inferior_data_cleanup.
10449         (get_inflow_inferior_data, inflow_inferior_exit)
10450         (swap_terminal_info, _initialize_inflow): Update.
10451
10452 2019-05-08  Tom Tromey  <tom@tromey.com>
10453
10454         * target-dcache.c (target_dcache_cleanup): Remove.
10455         (target_dcache_aspace_key): Change type.
10456         (target_dcache_init_p, target_dcache_invalidate)
10457         (target_dcache_get, target_dcache_get_or_init)
10458         (_initialize_target_dcache): Update.
10459         * dcache.h (struct dcache_deleter): New.
10460
10461 2019-05-08  Tom Tromey  <tom@tromey.com>
10462
10463         * symtab.c (struct symbol_cache): Add destructor and
10464         initializers.
10465         (symbol_cache_key): Move.  Change type.
10466         (make_symbol_cache, free_symbol_cache): Remove.
10467         (get_symbol_cache): Update.
10468         (symbol_cache_cleanup): Remove.
10469         (ALL_PSPACES, symbol_cache_flush)
10470         (maintenance_print_symbol_cache)
10471         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10472         Update.
10473
10474 2019-05-08  Tom Tromey  <tom@tromey.com>
10475
10476         * symtab.c (struct main_info): Add destructor and initializers.
10477         (main_progspace_key): Move.  Change type.
10478         (get_main_info): Update.
10479         (main_info_cleanup): Remove.
10480         (_initialize_symtab): Update.
10481
10482 2019-05-08  Tom Tromey  <tom@tromey.com>
10483
10484         * registry.h (DECLARE_REGISTRY): Define the _key class.
10485
10486 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10487
10488         * NEWS: Merge two 'New commands' sections.
10489
10490 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
10491
10492         * ada-valprint.c (ada_val_print_gnat_array): Remove language
10493         parameter and use Ada language definition instead.
10494         (ada_val_print_ptr): Remove unused language parameter.
10495         (ada_val_print_num): Remove language parameter and use Ada language
10496         definition instead.
10497         (ada_val_print_enum, ada_val_print_flt): Remove unused language
10498         parameter.
10499         (ada_val_print_struct_union, ada_val_print_ref): Remove language
10500         parameter and use Ada language definition instead.
10501         (ada_val_print_1): Update all ada_val_print_xxx calls.
10502         Remove language parameter.
10503         (ada_val_print): Update ada_val_print_1 call.
10504
10505 2019-05-08  Tom Tromey  <tromey@adacore.com>
10506
10507         * remote.c (remote_hw_watchpoint_limit)
10508         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10509         Now static.
10510
10511 2019-05-08  Tom Tromey  <tromey@adacore.com>
10512
10513         * maint.c (_initialize_maint_cmds): Move initialization code to
10514         remote.c.
10515         (watchdog, show_watchdog): Move to remote.c.
10516         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
10517         "watchdog" static.
10518         (_initialize_remote): Move initialization code from maint.c.
10519         * defs.h (watchdog): Don't declare.
10520
10521 2019-05-08  Tom Tromey  <tromey@adacore.com>
10522
10523         * tui/tui-interp.c: Include main.h.
10524         * interps.c: Include main.h.
10525         * main.h (interpreter_p): Declare.
10526         * defs.h (interpreter_p): Don't declare.
10527
10528 2019-05-08  Tom Tromey  <tromey@adacore.com>
10529
10530         * dwarf2loc.c: Include dwarf2read.h.
10531         * defs.h (read_unsigned_leb128): Don't declare.
10532         * dwarf2read.h (read_unsigned_leb128): Declare.
10533
10534 2019-05-08  Tom Tromey  <tromey@adacore.com>
10535
10536         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10537         method.
10538
10539 2019-05-08  Tom Tromey  <tromey@adacore.com>
10540
10541         * utils.c (fputs_maybe_filtered): Reset style after paging, even
10542         when no wrap column is set.
10543
10544 2019-05-08  Tom Tromey  <tromey@adacore.com>
10545
10546         * c-lang.c (c_get_string): Handle non-C-style arrays.
10547
10548 2019-05-08  Tom Tromey  <tromey@adacore.com>
10549
10550         * typeprint.c (print_offset_data::update): Print the bit offset,
10551         not the number of bits remaining.
10552
10553 2019-05-08  Tom Tromey  <tromey@adacore.com>
10554
10555         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10556         padding at end of comment.
10557
10558 2019-05-08  Tom Tromey  <tromey@adacore.com>
10559
10560         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10561         Compare main types.
10562
10563 2019-05-06  Tom Tromey  <tom@tromey.com>
10564
10565         * common/scoped_mmap.c: Include common-defs.h.
10566         * common/scoped_mmap.h: Don't include config.h.
10567
10568 2019-05-04  Tom Tromey  <tom@tromey.com>
10569
10570         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10571         (struct aarch64_call_info): Add initializers.
10572         <si>: Now a std::vector.
10573         (pass_on_stack, aarch64_push_dummy_call): Update.
10574
10575 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
10576             Tom Tromey  <tom@tromey.com>
10577
10578         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10579         (ppc_threads): Now a std::vector.  Now static.
10580         (hwdebug_find_thread_points_by_tid)
10581         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10582         Update.
10583
10584 2019-05-04  Tom Tromey  <tom@tromey.com>
10585
10586         * arc-tdep.c (arc_tdesc_init): Return bool.
10587
10588 2019-05-04  Tom Tromey  <tom@tromey.com>
10589
10590         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10591         Use gdb_assert_not_reached.
10592
10593 2019-05-04  Tom Tromey  <tom@tromey.com>
10594
10595         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10596         "false".
10597
10598 2019-05-04  Tom Tromey  <tom@tromey.com>
10599
10600         * arc-tdep.c (arc_tdesc_init): Use bool.
10601
10602 2019-05-04  Tom Tromey  <tom@tromey.com>
10603
10604         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10605
10606 2019-05-04  Tom Tromey  <tom@tromey.com>
10607
10608         * cli/cli-cmds.c (valid_command_p): Return bool.
10609
10610 2019-05-04  Tom Tromey  <tom@tromey.com>
10611
10612         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10613         * command.h (valid_user_defined_cmd_name_p): Channge return type.
10614
10615 2019-05-04  Raul Tambre  <raul@tambre.ee>
10616
10617         * python/lib/gdb/prompt.py (_ExtendedPrompt)
10618         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10619         operator for comparison.
10620
10621 2019-05-04  Tom Tromey  <tom@tromey.com>
10622
10623         * psymtab.c (psymbol_name_matches, match_partial_symbol)
10624         (lookup_partial_symbol, print_partial_symbols)
10625         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10626         (psymbol_compare): Update.
10627         (add_psymbol_to_bcache): Clear the entire psymbol.
10628         (maintenance_check_psymtabs): Update.
10629         * psympriv.h (struct partial_symbol): Don't derive from
10630         general_symbol_info.
10631         <obj_section, unrelocated_address, address,
10632         set_unrelocated_address>: Update.
10633         <ginfo>: New member.
10634         * dwarf-index-write.c (write_psymbols, debug_names::insert)
10635         (debug_names::write_psymbols): Update.
10636
10637 2019-05-04  Tom de Vries  <tdevries@suse.de>
10638
10639         * contrib/cc-with-tweaks.sh: Support -n arg.
10640
10641 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10642
10643         * corelow.c (core_target::detach): Ensure frame cache and
10644         register caches are cleared.
10645         inferior.c (exit_inferior_1): Likewise.
10646
10647 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
10648             Tom Tromey  <tom@tromey.com>
10649
10650         * dictionary.c (collate_pending_symbols_by_language): Remove
10651         "struct" from foreach.
10652         * symtab.c (lookup_global_symbol_from_objfile)
10653         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10654         foreach.
10655         * ser-tcp.c (net_open): Remove "struct" from foreach.
10656         * objfiles.c (objfile_relocate, objfile_rebase)
10657         (objfile_has_symbols): Remove "struct" from foreach.
10658         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10659         from foreach.
10660         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10661         foreach.
10662         * darwin-nat.c (thread_info_from_private_thread_info): Remove
10663         "struct" from foreach.
10664         * ada-lang.c (create_excep_cond_exprs)
10665         (ada_exception_catchpoint_cond_string): Remove "struct" from
10666         foreach.
10667
10668 2019-05-03  Tom Tromey  <tromey@adacore.com>
10669
10670         * ada-exp.y (convert_char_literal): Check suffix of each
10671         enumerator.
10672
10673 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
10674
10675         PR ada/21406:
10676         * ada-exp.y (yywrap): Don't define.
10677         * ada-lex.l (%option): Add noyywrap
10678         (yywrap): Remove.
10679
10680 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
10681
10682         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10683         _WIN32_WINNT to the XP level, unless already defined to a higher
10684         level.
10685
10686         * unittests/parse-connection-spec-selftests.c:
10687         * ser-tcp.c:
10688         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
10689         override.
10690
10691         * symfile.c (find_separate_debug_file): Remove colon from the
10692         drive spec of DOS/Windows file names of the target, so that the
10693         file name produced from DEBUGDIR and the target's directory will
10694         be valid on DOS/Windows systems.
10695
10696 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
10697
10698         * rust-lang.c (val_print_struct): Handle printing structures
10699         containing strings.
10700
10701 2019-05-02  Tom Tromey  <tromey@adacore.com>
10702
10703         * valarith.c (_initialize_valarith): Remove.
10704
10705 2019-05-01  Tom Tromey  <tromey@adacore.com>
10706
10707         * ada-lang.c (ada_value_primitive_field): Treat more fields as
10708         bitfields.
10709
10710 2019-05-01  Tom Tromey  <tromey@adacore.com>
10711
10712         * ada-lang.c (ada_value_assign): Correctly compute starting offset
10713         for big-endian copies.
10714
10715 2019-04-30  Ali Tamur  <tamur@google.com>
10716         * gdb/dwarf2read.c (read_3_bytes): New declaration.
10717         (read_attribute_value): Added DW_FORM_strx1-4 cases.
10718         (read_3_bytes): New function.
10719
10720 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10721
10722         * windows-nat.c (main_thread_id): Delete.
10723         (handle_output_debug_string): Replace main_thread_id by
10724         current_event.dwThreadId.
10725         (fake_create_process): Likewise.
10726         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10727         Do not set main_thread_id.
10728         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10729         current_event.dwThreadId.
10730         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10731
10732 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10733
10734         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10735         Use current_event.dwThreadId instead of main_thread_id.
10736
10737 2019-04-30  Tom Tromey  <tromey@adacore.com>
10738
10739         * ada-lang.c (ada_lookup_simple_minsyms): New function.
10740         (create_excep_cond_exprs): Iterate over program spaces.
10741         (ada_exception_catchpoint_cond_string): Examine all minimal
10742         symbols for exception types.
10743
10744 2019-04-30  Tom Tromey  <tromey@adacore.com>
10745
10746         PR c++/24470:
10747         * dwarf2read.c (process_structure_scope): Handle case where type
10748         has template parameters but no symbol was created.
10749
10750 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10751             Chris January  <chris.january@arm.com>
10752
10753         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10754         qualifier.
10755         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10756
10757 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10758
10759         * f-typeprint.c (f_print_type): Update rules for printing
10760         whitespace.
10761         (f_type_print_varspec_suffix): Likewise.
10762
10763 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10764             Chris January  <chris.january@arm.com>
10765
10766         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10767         function arguments.
10768
10769 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10770
10771         * f-lang.c (build_fortran_types): Change name of void type to
10772         lower case.
10773         * f-typeprint.c (f_type_print_base): Print the name of the void
10774         type, rather than a fixed string.
10775         * f-valprint.c (f_decorations): Use lower case void string.
10776
10777 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10778             Chris January  <chris.january@arm.com>
10779
10780         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10781         types for Fortran.
10782
10783 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10784             Chris January  <chris.january@arm.com>
10785             David Lecomber  <david.lecomber@arm.com>
10786
10787         * f-exp.y (BINOP_INTRINSIC): New token.
10788         (exp): New parser rule handling BINOP_INTRINSIC.
10789         (f77_keywords): Add new builtin procedures.
10790         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10791         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10792         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10793         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10794         (print_unop_subexp_f): New function.
10795         (print_binop_subexp_f): New function.
10796         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10797         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10798         (dump_subexp_body_f): Likewise.
10799         (operator_check_f): Likewise.
10800         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10801         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10802
10803 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10804
10805         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10806         UNOP_KIND.
10807         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10808         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10809         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10810         (operator_length_f): New fuction.
10811         (print_subexp_f): New function.
10812         (op_name_f): New function.
10813         (dump_subexp_body_f): New function.
10814         (operator_check_f): New function.
10815         (exp_descriptor_f): Replace standard expression handling functions
10816         with new functions.
10817         * gdb/fortran-operator.def: New file.
10818         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10819         * gdb/std-operator.def: Remove UNOP_KIND.
10820
10821 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10822
10823         * std-operator.def: Remove unbalanced, stray double quote
10824         character.
10825
10826 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10827             Chris January  <chris.january@arm.com>
10828             Daniel Everett  <daniel.everett@arm.com>
10829             Nick Forrington  <nick.forrington@arm.com>
10830             Richard Bunt  <richard.bunt@arm.com>
10831
10832         * cp-valprint.c (cp_print_value_fields): Allow an additional level
10833         of depth when printing anonymous structs or unions.
10834         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10835         Don't print either the top-level value, or the children if the
10836         max-depth is exceeded.
10837         (ppscm_print_children): When printing the key of a map, allow one
10838         extra level of depth.
10839         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10840         print either the top-level value, or the children if the max-depth
10841         is exceeded.
10842         (print_children): When printing the key of a map, allow one extra
10843         level of depth.
10844         * python/py-value.c (valpy_format_string): Add max_depth keyword.
10845         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10846         (user_print_options): Initialise max_depth field.
10847         (val_print_scalar_or_string_type_p): New function.
10848         (val_print): Check to see if the max depth has been reached.
10849         (val_print_check_max_depth): Define new function.
10850         (show_print_max_depth): New function.
10851         (_initialize_valprint): Add 'print max-depth' option.
10852         * valprint.h (struct value_print_options) <max_depth>: New field.
10853         (val_print_check_max_depth): Declare new function.
10854         * NEWS: Document new feature.
10855
10856 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10857
10858         * ada-lang.c (ada_language_defn): Initialise new field.
10859         * c-lang.c (c_is_string_type_p): New function.
10860         (c_language_defn): Initialise new field.
10861         (cplus_language_defn): Initialise new field.
10862         (asm_language_defn): Initialise new field.
10863         (minimal_language_defn): Initialise new field.
10864         * c-lang.h (c_is_string_type_p): Declare new function.
10865         * d-lang.c (d_language_defn): Initialise new field.
10866         * f-lang.c (f_is_string_type_p): New function.
10867         (f_language_defn): Initialise new field.
10868         * go-lang.c (go_is_string_type_p): New function.
10869         (go_language_defn): Initialise new field.
10870         * language.c (default_is_string_type_p): New function.
10871         (unknown_language_defn): Initialise new field.
10872         (auto_language_defn): Initialise new field.
10873         * language.h (struct language_defn) <la_is_string_type_p>: New
10874         member variable.
10875         (default_is_string_type_p): Declare new function.
10876         * m2-lang.c (m2_language_defn): Initialise new field.
10877         * objc-lang.c (objc_language_defn): Initialise new field.
10878         * opencl-lang.c (opencl_language_defn): Initialise new field.
10879         * p-lang.c (pascal_is_string_type_p): New function.
10880         (pascal_language_defn): Initialise new field.
10881         * rust-lang.c (rust_is_string_type_p): New function.
10882         (rust_language_defn): Initialise new field.
10883
10884 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10885
10886         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10887         New field.
10888         * ada-lang.c (ada_language_defn): Initialise new field.
10889         * c-lang.c (c_language_defn): Likewise.
10890         (cplus_language_defn): Likewise.
10891         (asm_language_defn): Likewise.
10892         (minimal_language_defn): Likewise.
10893         * d-lang.c (d_language_defn): Likewise.
10894         * f-lang.c (f_language_defn): Likewise.
10895         * go-lang.c (go_language_defn): Likewise.
10896         * language.c (unknown_language_defn): Likewise.
10897         (auto_language_defn): Likewise.
10898         * m2-lang.c (m2_language_defn): Likewise.
10899         * objc-lang.c (objc_language_defn): Likewise.
10900         * opencl-lang.c (opencl_language_defn): Likewise.
10901         * p-lang.c (pascal_language_defn): Likewise.
10902         * rust-lang.c (rust_language_defn): Likewise.
10903
10904 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10905
10906         * ada-lang.c (ada_is_character_type): Change return type to bool.
10907         (ada_is_string_type): Likewise.
10908         * ada-lang.h (ada_is_character_type): Update declaration
10909         (ada_is_string_type): Likewise.
10910
10911 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10912
10913         Support style in 'frame|thread apply'
10914
10915         * gdbcmd.h (execute_command_to_string): New term_out parameter.
10916         * record.c (record_start, record_stop): Update callers of
10917         execute_command_to_string with false.
10918         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10919         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10920         methods.
10921         (class string_file): New constructor with term_out parameter.
10922         Override methods term_out and can_emit_style_escape.  New member
10923         term_out.
10924         (class stdio_file): Override can_emit_style_escape.
10925         (class tee_file): Override term_out and can_emit_style_escape.
10926         * utils.h (can_emit_style_escape): Remove.
10927         * utils.c (can_emit_style_escape): Likewise.
10928         Update all callers of can_emit_style_escape (SOMESTREAM) to
10929         SOMESTREAM->can_emit_style_escape.
10930         * source-cache.c (source_cache::get_source_lines): Likewise.
10931         * stack.c (frame_apply_command_count): Call execute_command_to_string
10932         passing the term_out characteristic of the current gdb_stdout.
10933         * thread.c (thr_try_catch_cmd): Likewise.
10934         * top.c (execute_command_to_string): pass term_out parameter
10935         to construct the string_file for the command output.
10936         * ui-file.c (term_cli_styling): New function (most code moved
10937         from utils.c can_emit_style_escape).
10938         (string_file::string_file, string_file::can_emit_style_escape,
10939         stdio_file::can_emit_style_escape, tee_file::term_out,
10940         tee_file::can_emit_style_escape): New functions.
10941
10942 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10943
10944         * NEWS: Mention the new set|show may-call-functions.
10945         * infcall.c (may_call_functions_p): New variable.
10946         (show_may_call_functions_p): New function.
10947         (call_function_by_hand_dummy): Throws an error if not
10948         may-call-functions.
10949         (_initialize_infcall): Call add_setshow_boolean_cmd for
10950         may-call-functions.
10951
10952 2019-04-25  Keith Seitz  <keiths@redhat.com>
10953
10954         PR c++/24367
10955         * cp-support.c (inspect_type): Don't attempt substitutions
10956         of symbol with the same name.
10957
10958 2019-04-25  Tom Tromey  <tromey@adacore.com>
10959
10960         PR gdb/24475:
10961         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10962         static.
10963
10964 2019-04-25  Tom Tromey  <tromey@adacore.com>
10965
10966         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10967         rvalue reference.
10968         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10969         (gdb_xml_parser::parse): Use std::move.
10970         * python/python-internal.h (gdbpy_convert_exception): Take a const
10971         reference.
10972         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10973         std::move.
10974         * python/py-utils.c (gdbpy_convert_exception): Take a const
10975         reference.
10976         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10977         Use std::move.
10978         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10979         Use std::move.
10980         * mi/mi-main.c (mi_print_exception): Take a const reference.
10981         * main.c (handle_command_errors): Take a const reference.
10982         * linespec.c (parse_linespec): Use std::move.
10983         * infcall.c (run_inferior_call): Use std::move.
10984         (call_function_by_hand_dummy): Use std::move.
10985         * exec.c (try_open_exec_file): Use std::move.
10986         * exceptions.h (exception_print, exception_fprintf)
10987         (exception_print_same): Update.
10988         * exceptions.c (print_exception, exception_print)
10989         (exception_fprintf, exception_print_same): Change parameters to
10990         const reference.
10991         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10992         * common/new-op.c: Use std::move.
10993         * common/common-exceptions.h (struct gdb_exception): Add move
10994         constructor.
10995         (struct gdb_exception_error, struct gdb_exception_quit, struct
10996         gdb_quit_bad_alloc): Change constructor to move constructor.
10997         (throw_exception): Change parameter to rvalue reference.
10998         * common/common-exceptions.c (throw_exception): Take rvalue
10999         reference.
11000         * cli/cli-interp.c (safe_execute_command): Use std::move.
11001         * breakpoint.c (insert_bp_location, location_to_sals): Use
11002         std::move.
11003
11004 2019-04-25  Tom Tromey  <tromey@adacore.com>
11005
11006         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11007         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11008         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11009         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11010         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11011         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11012         guile/scm-value.c: Use unpack.
11013         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11014         gdbscm_gdb_exception.
11015         (gdbscm_throw_gdb_exception): Likewise.
11016         (struct gdbscm_gdb_exception): New.
11017         (unpack): New function.
11018         (gdbscm_wrap): Use unpack.
11019
11020 2019-04-25  Tom Tromey  <tromey@adacore.com>
11021
11022         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11023         (gdb_rl_callback_handler): Use std::move.
11024         * common/common-exceptions.h (struct gdb_exception): Add move
11025         assignment operator.
11026         (throw_exception_sjlj): Change "exception" to const reference.
11027         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11028         (throw_exception_sjlj): Change "exception" to const reference.
11029
11030 2019-04-25  Tom Tromey  <tromey@adacore.com>
11031
11032         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11033         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11034         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11035         Update.
11036         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11037         Update.
11038         * mi/mi-interp.c (mi_interp::exec): Update.
11039         * linespec.c (parse_linespec): Update.
11040         * infcall.c (run_inferior_call): Update.
11041         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11042         * guile/scm-symbol.c (gdbscm_lookup_symbol)
11043         (gdbscm_lookup_global_symbol): Update.
11044         * guile/scm-param.c (gdbscm_parameter_value): Update.
11045         * guile/scm-frame.c (gdbscm_frame_read_register)
11046         (gdbscm_frame_read_var): Update.
11047         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11048         * exec.c (try_open_exec_file): Update.
11049         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11050         (gdb_rl_callback_handler): Update.
11051         * common/common-exceptions.h (exception_none): Don't declare.
11052         * common/common-exceptions.c (exception_none): Don't define.
11053         (struct catcher) <exception>: Update.
11054         * cli/cli-interp.c (safe_execute_command): Update.
11055         * breakpoint.c (insert_bp_location, location_to_sals): Update.
11056
11057 2019-04-25  Ali Tamur  <tamur@google.com>
11058
11059         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11060         (read_attribute_value): Likewise.
11061         (dwarf2_read_addr_index): Update comment.
11062         (read_str_index): Add DW_FORM_strx.
11063         (dwarf2_string_attr): Likewise.
11064         (dwarf2_const_value_attr): Likewise.
11065         (dump_die_shallow): Likewise.
11066         (dwarf2_fetch_constant_bytes): Likewise.
11067         (skip_form_bytes): Likewise.
11068         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11069
11070 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
11071
11072         PR corefiles/11608
11073         PR corefiles/18187
11074         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11075         OFFSET.  Verify if current mapping contains an ELF header.
11076         (linux_find_memory_regions_full): Adjust call to
11077         dump_mapping_p.
11078
11079 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
11080             Kang Li <kanglictf@gmail.com>
11081
11082         PR gdb/21600
11083
11084         * dwarf2-frame.c (read_initial_length): Be consistent about using
11085         unsigned representation of length.
11086         (decode_frame_entry_1): Likewise.  Check for wraparound of
11087         end pointer as well as buffer overflow.
11088
11089 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
11090
11091         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11092         "vq".
11093
11094 2019-04-24  Tom Tromey  <tromey@adacore.com>
11095
11096         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11097
11098 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11099
11100         * s12z-tdep.c (s12z_unwind_pc): Delete.
11101         (s12z_unwind_sp): Delete.
11102         (s12z_gdbarch_init): Don't register deleted functions with
11103         gdbarch.
11104
11105 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11106
11107         * rl78-tdep.c (rl78_unwind_sp): Delete.
11108         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11109
11110 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11111
11112         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11113         (xstormy16_unwind_pc): Delete.
11114         (xstormy16_dummy_id): Delete.
11115         (xstormy16_gdbarch_init): Don't register deleted functions with
11116         gdbarch.
11117
11118 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11119
11120         * vax-tdep.c (vax_unwind_pc): Delete.
11121         (vax_gdbarch_init): Don't register deleted function with gdbarch.
11122
11123 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11124
11125         * v850-tdep.c (v850_unwind_sp): Delete.
11126         (v850_unwind_pc): Delete.
11127         (v850_dummy_id): Delete.
11128         (v850_gdbarch_init): Don't register deleted functions with
11129         gdbarch.
11130
11131 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11132
11133         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11134         (tilegx_unwind_pc): Delete.
11135         (tilegx_unwind_dummy_id): Delete.
11136         (tilegx_gdbarch_init): Don't register deleted functions with
11137         gdbarch.
11138
11139 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11140
11141         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11142         (tic6x_dummy_id): Delete.
11143         (tic6x_gdbarch_init): Don't register deleted functions with
11144         gdbarch.
11145
11146 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11147
11148         * sparc-tdep.c (sparc_unwind_pc): Delete.
11149         (sparc32_gdbarch_init): Don't register deleted function with
11150         gdbarch.
11151
11152 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11153
11154         * sh-tdep.c (sh_unwind_sp): Delete.
11155         (sh_unwind_pc): Delete.
11156         (sh_dummy_id): Delete.
11157         (sh_gdbarch_init): Don't register deleted functions with
11158         gdbarch.
11159
11160 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11161
11162         * score-tdep.c (score_unwind_sp): Delete.
11163         (score_unwind_pc): Delete.
11164         (score_dummy_id): Delete.
11165         (score_gdbarch_init): Don't register deleted functions with
11166         gdbarch.
11167
11168 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11169
11170         * rx-tdep.c (rx_unwind_pc): Delete.
11171         (rx_unwind_sp): Delete.
11172         (rx_dummy_id): Delete.
11173         (rx_gdbarch_init): Don't register deleted functions with
11174         gdbarch.  Update comment.
11175
11176 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11177
11178         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11179         (rs6000_dummy_id): Delete.
11180         (rs6000_gdbarch_init): Don't register deleted functions with
11181         gdbarch.
11182
11183 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11184
11185         * or1k-tdep.c (or1k_dummy_id): Delete.
11186         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11187
11188 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11189
11190         * nios2-tdep.c (nios2_dummy_id): Delete.
11191         (nios2_unwind_sp): Delete.
11192         (nios2_gdbarch_init): Don't register deleted functions with
11193         gdbarch.
11194
11195 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11196
11197         * nds32-tdep.c (nds32_dummy_id): Delete.
11198         (nds32_unwind_pc): Delete.
11199         (nds32_unwind_sp): Delete.
11200         (nds32_gdbarch_init): Don't register deleted functions with
11201         gdbarch.
11202
11203 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11204
11205         * msp430-tdep.c (msp430_unwind_pc): Delete.
11206         (msp430_unwind_sp): Delete.
11207         (msp430_dummy_id): Delete.
11208         (msp430_gdbarch_init): Don't register deleted functions with
11209         gdbarch.
11210
11211 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11212
11213         * moxie-tdep.c (moxie_unwind_sp): Delete.
11214         (moxie_unwind_pc): Delete.
11215         (moxie_dummy_id): Delete.
11216         (moxie_gdbarch_init): Don't register deleted functions with
11217         gdbarch.
11218
11219 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11220
11221         * mn10300-tdep.c (mn10300_dummy_id): Delete.
11222         (mn10300_unwind_pc): Delete.
11223         (mn10300_unwind_sp): Delete.
11224         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11225         mn10300_unwind_sp.
11226         (mn10300_frame_unwind_init): Don't register deleted functions with
11227         gdbarch.
11228
11229 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11230
11231         * mep-tdep.c (mep_unwind_pc): Delete.
11232         (mep_unwind_sp): Delete.
11233         (mep_dummy_id): Delete.
11234         (mep_gdbarch_init): Don't register deleted functions with
11235         gdbarch.
11236
11237 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11238
11239         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11240         (m68hc11_unwind_sp): Delete.
11241         (m68hc11_gdbarch_init): Don't register deleted functions with
11242         gdbarch.
11243
11244 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11245
11246         * m32r-tdep.c (m32r_unwind_sp): Delete.
11247         (m32r_unwind_pc): Delete.
11248         (m32r_dummy_id): Delete.
11249         (m32r_gdbarch_init): Don't register deleted functions with
11250         gdbarch.
11251
11252 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11253
11254         * m32c-tdep.c (m32c_unwind_pc): Delete.
11255         (m32c_unwind_sp): Delete.
11256         (m32c_dummy_id): Delete.
11257         (m32c_gdbarch_init): Don't register deleted functions with
11258         gdbarch.
11259
11260 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11261
11262         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11263         (lm32_unwind_pc): Delete.
11264         (lm32_dummy_id): Delete.
11265         (lm32_gdbarch_init): Don't register deleted functions with
11266         gdbarch.
11267
11268 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11269
11270         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11271         (iq2000_unwind_pc): Delete.
11272         (iq2000_dummy_id): Delete.
11273         (iq2000_gdbarch_init): Don't register deleted functions with
11274         gdbarch.
11275
11276 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11277
11278         * nds32-tdep.c (nds32_type_align): Delete.
11279         (nds32_push_dummy_call): Use type_align instead.
11280
11281 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11282
11283         * arm-tdep.c (arm_type_align): Only handle vector override case.
11284         (arm_push_dummy_call): Use type_align.
11285         (arm_gdbarch_init): Register arm_type_align gdbarch function.
11286
11287 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11288
11289         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11290         case.
11291         (pass_on_stack): Use type_align.
11292         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11293         function.
11294
11295 2019-04-23  Tom Tromey  <tromey@adacore.com>
11296
11297         * dwarf2read.c (line_header::file_name_at): Remove unused
11298         overload.
11299
11300 2019-04-23  Tom de Vries  <tdevries@suse.de>
11301
11302         PR gdb/24438
11303         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11304         invocation.
11305
11306
11307 2019-03-27  Ali Tamur  <tamur@google.com>
11308
11309         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11310         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11311         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11312         (dwarf_expr_context::get_addr_index): Likewise
11313         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11314         (symbol_needs_eval_context::get_addr_index): Likewise
11315         (disassemble_dwarf_expression): Add DW_OP_addrx
11316         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11317         (read_cutu_die_from_dwo): Update comment
11318         (skip_one_die): Add DW_FORM_addrx
11319         (read_attribute_value): Likewise
11320         (var_decode_location): Add DW_OP_addrx
11321         (dwarf2_const_value_attr): Add DW_FORM_addrx
11322         (dump_die_shallow): Likewise
11323         (dwarf2_fetch_constant_bytes): Likewise
11324         (decode_locdesc): Add DW_OP_addrx
11325         (skip_form_bytes): Add DW_FORM_addrx
11326
11327 2019-04-22  Ali Tamur  <tamur@google.com>
11328
11329         * MAINTAINERS (Write After Approval): Add self.
11330
11331 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
11332
11333         * solib-svr4.c (get_svr4_info): Add pspace parameter.
11334         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11335         (open_symbol_file_object): Likewise.
11336         (svr4_default_sos): Add info parameter.
11337         (svr4_read_so_list): Likewise.
11338         (svr4_current_sos_direct): Adjust functions calls to pass down
11339         info.
11340         (svr4_current_sos_1): Add info parameter.
11341         (svr4_current_sos): Call get_svr4_info, pass info down to
11342         svr4_current_sos_1.
11343         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11344         get_svr4_info.
11345         (svr4_in_dynsym_resolve_code): Pass current_program_space to
11346         get_svr4_info.
11347         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11348         to get_svr4_info.
11349         (probes_table_remove_objfile_probes): Likewise.
11350         (register_solib_event_probe): Add info parameter.
11351         (solist_update_incremental): Pass info parameter down to
11352         svr4_read_so_list.
11353         (disable_probes_interface): Add info parameter.
11354         (svr4_handle_solib_event): Pass current_program_space to
11355         get_svr4_info.  Adjust disable_probes_interface cleanup.
11356         (svr4_create_probe_breakpoints): Add info parameter, pass it
11357         down to register_solib_event_probe.
11358         (svr4_create_solib_event_breakpoints): Add info parameter,
11359         pass it down to svr4_create_probe_breakpoints.
11360         (enable_break): Pass info down to
11361         svr4_create_solib_event_breakpoints.
11362         (svr4_solib_create_inferior_hook): Pass current_program_space to
11363         get_svr4_info.
11364         (svr4_clear_solib): Likewise.
11365
11366 2019-04-22  Pedro Alves  <palves@redhat.com>
11367
11368         * solib-svr4.c (svr4_free_objfile_observer): New.
11369         (probe_and_action::objfile): New field.
11370         (probes_table_htab_remove_objfile_probes)
11371         (probes_table_remove_objfile_probes): New functions.
11372         (register_solib_event_probe): Add 'objfile' parameter.  Store it
11373         in the new probe_and_action.  Don't store the probe in 'lookup'.
11374         (svr4_create_probe_breakpoints): Pass objfile to
11375         register_solib_event_probe.
11376         (_initialize_svr4_solib): Register a free_objfile observer.
11377
11378 2019-04-19  Tom Tromey  <tom@tromey.com>
11379
11380         * common/queue.h: Remove.
11381
11382 2019-04-19  Tom Tromey  <tom@tromey.com>
11383
11384         * event-loop.c: Don't include "common/queue.h".
11385
11386 2019-04-19  Tom Tromey  <tom@tromey.com>
11387
11388         * remote.c (remote_target): Use delete.
11389         * remote-notif.h: Include <list>, not "common/queue.h".
11390         (notif_client_p): Remove typedef.
11391         (remote_notif_state): Add constructor, destructor, initializer.
11392         <notif_queue>: Now a std::list.
11393         (remote_notif_state_xfree): Don't declare.
11394         * remote-notif.c (remote_notif_process, handle_notification)
11395         (remote_notif_state_allocate): Update.
11396         (~remote_notif_state): Rename from remote_notif_state_xfree.
11397
11398 2019-04-19  Tom Tromey  <tom@tromey.com>
11399
11400         * symfile.c (reread_symbols): Update.
11401         * objfiles.c (objfile_register_static_link)
11402         (objfile_lookup_static_link): Update
11403         (~objfile) Don't delete static_links.
11404         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11405
11406 2019-04-19  Tom Tromey  <tom@tromey.com>
11407
11408         * type-stack.h (struct type_stack) <insert>: Constify string.
11409         * type-stack.c (type_stack::insert): Constify string.
11410         * gdbtypes.h (lookup_template_type): Update.
11411         (address_space_name_to_int): Update.
11412         * gdbtypes.c (address_space_name_to_int): Make space_identifier
11413         const.
11414         (lookup_template_type): Make name const.
11415         * c-exp.y: Update rules.
11416         (lex_one_token, classify_name, classify_inner_name)
11417         (c_print_token): Update.
11418         * p-exp.y: Update rules.
11419         (yylex): Update.
11420         * f-exp.y: Update rules.
11421         (yylex): Update.
11422         * d-exp.y: Update rules.
11423         (lex_one_token, classify_name, classify_inner_name): Update.
11424         * parse.c (write_dollar_variable, copy_name): Return std::string.
11425         * parser-defs.h (copy_name): Change return type.
11426         * m2-exp.y: Update rules.
11427         (yylex): Update.
11428         * go-exp.y (lex_one_token): Update.
11429         Update rules.
11430         (classify_unsafe_function, classify_packaged_name)
11431         (classify_name, yylex): Update.
11432
11433 2019-04-19  Sergei Trofimovich <siarheit@google.com>
11434
11435         * configure.ac: add --enable-source-highlight switch.
11436         * configure: Regenerate.
11437         * top.c (print_gdb_version): plumb --enable-source-highlight
11438         status to "show configuration".
11439
11440 2019-04-19  Tom Tromey  <tromey@adacore.com>
11441
11442         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11443         Check ADA_TYPE_P.
11444         (empty_record, ada_template_to_fixed_record_type_1)
11445         (template_to_static_fixed_type)
11446         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11447         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11448         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11449         macros.
11450
11451 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
11452
11453         PR symtab/24423:
11454         * source.c (print_source_lines_base): Advance "iter" when a
11455         control character is seen.
11456
11457 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11458
11459         * inferior.h (struct infcall_suspend_state_deleter):
11460         Catch exception in destructor to avoid crash.
11461
11462 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11463
11464         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11465         close to the add_com "shell".
11466
11467 2019-04-18  Tom Tromey  <tromey@adacore.com>
11468
11469         * process-stratum-target.h (class process_stratum_target)
11470         <stratum>: Add "final".
11471
11472 2019-04-17  Tom Tromey  <tromey@adacore.com>
11473
11474         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11475         against nullptr before use.
11476
11477 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
11478
11479         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11480
11481 2019-04-17  Jim Wilson  <jimw@sifive.com>
11482             Andrew Burgess  <andrew.burgess@embecosm.com>
11483
11484         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11485         code read might fail, assume 4-byte breakpoint in that case.
11486
11487 2019-04-15  Leszek Swirski  <leszeks@google.com>
11488
11489         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11490         rather than a hand-rolled POD check when checking for forced MEMORY
11491         classification.
11492
11493 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11494
11495         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11496         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11497         function.
11498         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11499         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11500         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11501         declaration.
11502
11503 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11504
11505         * aarch64-linux-nat.c
11506         (aarch64_linux_nat_target::thread_architecture): Add override.
11507         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11508         each VQ.
11509
11510 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11511
11512         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11513
11514 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11515
11516         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11517         target types of size 96-bits, add some additional comments, and
11518         check that the builtin type we found was the correct size.
11519
11520 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
11521
11522         * utils.c (prompt_for_continue): Don't restore the styling at the
11523         end, as applied_style has the wrong value.  This fixes styling in
11524         long lists of file names that are interrupted by the "Continue?"
11525         prompt.
11526
11527 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11528
11529         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11530         * c-lang.c (c_language_defn): Likewise.
11531         (cplus_language_defn): Likewise.
11532         (asm_language_defn): Likewise.
11533         (minimal_language_defn): Likewise.
11534         * d-lang.c (d_language_defn): Likewise.
11535         * f-lang.c (f_language_defn): Likewise.
11536         * go-lang.c (go_language_defn): Likewise.
11537         * language.c (unknown_language_defn): Likewise.
11538         (auto_language_defn): Likewise.
11539         * language.h (struct language_defn): Remove la_magic field.
11540         (LANG_MAGIC): Delete.
11541         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11542         * objc-lang.c (objc_language_defn): Likewise.
11543         * opencl-lang.c (opencl_language_defn): Likewise.
11544         * p-lang.c (pascal_language_defn): Likewise.
11545         * rust-lang.c (rust_language_defn): Likewise.
11546
11547 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11548
11549         * riscv-tdep.c (riscv_type_align): New function.
11550         (riscv_type_alignment): Delete.
11551         (riscv_arg_location): Use 'type_align'.
11552         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11553
11554 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11555
11556         * gdbtypes.c (type_align): A struct with no non-static fields also
11557         has alignment of 1.
11558
11559 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11560
11561         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11562         component to 0.
11563         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11564         member.
11565         (riscv_struct_info::analyse): New implementation using new
11566         analyse_inner member function.
11567         (riscv_struct_info::field_offset): New member function.
11568         (riscv_struct_info::m_offsets): New member variable.
11569         (riscv_struct_info::analyse_inner): New private member function,
11570         takes the old implementation of riscv_struct_info::analyse but
11571         extended to track field offsets.
11572         (riscv_call_arg_struct): Update the struct folding special cases
11573         to handle cases where empty C++ structs, which are non-zero
11574         length, are found.
11575         (riscv_arg_location): Initialise the length of each location, a
11576         non-zero length now indicates the location is in use.
11577         (riscv_push_dummy_call): Allow for the first location having a
11578         non-zero offset when setting up arguments.
11579         (riscv_return_value): Likewise, but for return values.
11580
11581 2019-04-11  Tom Tromey  <tromey@adacore.com>
11582
11583         * utils.c (internal_vproblem): Make "msg" const.
11584
11585 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
11586
11587         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11588         * trad-frame.c (trad_frame_reset_saved_regs): New function.
11589         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11590         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11591
11592 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
11593
11594         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11595         function.
11596         (fill_gregset): Call amd64_linux_collect_native_gregset instead
11597         of amd64_collect_native_gregset.
11598         (amd64_linux_nat_target::store_registers): Likewise.
11599
11600 2019-04-10  Tom Tromey  <tom@tromey.com>
11601
11602         * symtab.c (lookup_global_symbol_from_objfile)
11603         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11604         * objfiles.h (class separate_debug_iterator): New.
11605         (class separate_debug_range): New.
11606         (struct objfile) <separate_debug_objfiles>: New method.
11607         (objfile_separate_debug_iterate): Don't declare.
11608         * objfiles.c (separate_debug_iterator::operator++): Rename from
11609         objfile_separate_debug_iterate.
11610         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11611         iterator.
11612         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11613         iterator.
11614
11615 2019-04-10  Tom Tromey  <tom@tromey.com>
11616
11617         * symfile.c (reread_symbols): Remove old comment.
11618         * objfiles.c (free_all_objfiles): Fix a typo.
11619
11620 2019-04-10  Tom Tromey  <tom@tromey.com>
11621
11622         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11623         * minsyms.c (lookup_minimal_symbol): Use foreach.
11624         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11625         (lookup_minimal_symbol_solib_trampoline): Likewise.
11626         * symfile.c (reread_symbols): Use foreach.
11627
11628 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
11629             Tom Tromey  <tromey@adacore.com>
11630
11631         PR rust/24414:
11632         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11633         (rust_lex_int_test): Change "value" to be LONGEST.
11634         (rust_lex_tests): Add test for long integer literal.
11635
11636 2019-04-09  Tom Tromey  <tromey@adacore.com>
11637
11638         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11639         to bool.
11640         (extended_remote_target::attach): Update.
11641         (remote_target::remote_notice_new_inferior): Update.
11642         (remote_target::add_current_inferior_and_thread): Update.
11643         * inferior.c (exit_inferior_1): Use "false".
11644         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11645
11646 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
11647
11648         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11649         the "start" command.
11650
11651 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11652
11653         * python/py-inferior.c (infpy_thread_from_thread_handle):
11654         Adjust comments to reflect renaming of thread_from_thread_handle
11655         to thread_from_handle.  Adjust keywords.  Fix type error message.
11656         (inferior_object_methods): Add thread_from_handle.  Retain
11657         thread_from_thread_handle, but mark it as deprecated.
11658
11659 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11660
11661         * gdbthread.h (find_thread_by_handle): Revise declaration.
11662         * thread.c (find_thread_by_handle): Likewise.  Adjust
11663         implementation too.
11664         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11665         support for buffer objects as handles.
11666
11667 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11668
11669         * python/py-infthread.c (thpy_thread_handle): New function.
11670         (thread_object_methods): Register thpy_thread_handle.
11671
11672 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11673
11674         * gdbthread.h (thread_to_thread_handle): Declare.
11675         * thread.c (gdbtypes.h): Include.
11676         (thread_to_thread_handle): New function.
11677
11678         * target.h (struct target_ops): Add thread_info_to_thread_handle.
11679         (target_thread_info_to_thread_handle): Declare.
11680         * target.c (target_thread_info_to_thread_handle): New function.
11681         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11682         * target-delegates.c: Regenerate.
11683
11684         * linux-thread-db.c (class thread_db_target): Add method
11685         thread_info_to_thread_handle.
11686         (thread_db_target::thread_info_to_thread_handle): Define.
11687         * remote.c (class remote_target): Add new method
11688         thread_info_to_thread_handle.
11689         (remote_target::thread_info_to_thread_handle): Define.
11690
11691 2019-04-08  Pedro Alves  <palves@redhat.com>
11692
11693         * common/common-exceptions.c (throw_exception): Don't create
11694         named object to throw; throw directly.
11695         (throw_it): Likewise.  Don't initialize gdb_exception::message
11696         here, with new; pass FMT and AP to the ctor instead.
11697         * common/common-exceptions.h: Include <string>.
11698         (gdb_exception::gdb_exception(enum return_reason, enum errors,
11699         const char *, va_list)): New ctor.  Use std::make_shared.
11700         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11701         errors)): Delete.
11702         (gdb_exception_error::gdb_exception_error(enum errors, const char
11703         *, va_list)): New.
11704         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11705         Add assertion.
11706         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11707         errors)): Delete.
11708         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11709         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11710         Add assertion.
11711
11712 2019-04-08  Tom Tromey  <tom@tromey.com>
11713
11714         * valops.c (value_rtti_indirect_type): Replace throw_exception
11715         with throw.
11716         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11717         with throw.
11718         * thread.c (thr_try_catch_cmd): Replace throw_exception with
11719         throw.
11720         * target.c (target_translate_tls_address): Replace throw_exception
11721         with throw.
11722         * stack.c (frame_apply_command_count): Replace throw_exception
11723         with throw.
11724         * solib-spu.c (append_ocl_sos): Replace throw_exception with
11725         throw.
11726         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11727         with throw.
11728         * rs6000-tdep.c (rs6000_frame_cache)
11729         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11730         * remote.c: Replace throw_exception with throw.
11731         * record-full.c (record_full_message, record_full_wait_1)
11732         (record_full_restore): Replace throw_exception with throw.
11733         * record-btrace.c:
11734         (get_thread_current_frame_id, record_btrace_start_replaying)
11735         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11736         (cmd_record_btrace_start): Replace throw_exception with throw.
11737         * parse.c (parse_exp_in_context_1): Replace throw_exception with
11738         throw.
11739         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11740         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11741         * linespec.c:
11742         (find_linespec_symbols): Replace throw_exception with throw.
11743         * infrun.c (displaced_step_prepare, resume): Replace
11744         throw_exception with throw.
11745         * infcmd.c (post_create_inferior): Replace throw_exception with
11746         throw.
11747         * inf-loop.c (inferior_event_handler): Replace throw_exception
11748         with throw.
11749         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11750         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11751         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11752         (get_prev_frame_always, get_frame_pc_if_available)
11753         (get_frame_address_in_block_if_available, get_frame_language):
11754         Replace throw_exception with throw.
11755         * frame-unwind.c (frame_unwind_try_unwinder): Replace
11756         throw_exception with throw.
11757         * eval.c (fetch_subexp_value, evaluate_var_value)
11758         (evaluate_funcall, evaluate_subexp_standard): Replace
11759         throw_exception with throw.
11760         * dwarf2loc.c (call_site_find_chain)
11761         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11762         Replace throw_exception with throw.
11763         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11764         with throw.
11765         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11766         throw.
11767         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11768         * completer.c (complete_line_internal): Replace throw_exception
11769         with throw.
11770         * compile/compile-object-run.c (compile_object_run): Replace
11771         throw_exception with throw.
11772         * cli/cli-script.c (process_next_line): Replace throw_exception
11773         with throw.
11774         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11775         (btrace_enable, btrace_maint_update_pt_packets): Replace
11776         throw_exception with throw.
11777         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11778         throw_exception with throw.
11779         * break-catch-throw.c (re_set_exception_catchpoint): Replace
11780         throw_exception with throw.
11781         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11782         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11783         * aarch64-tdep.c (aarch64_make_prologue_cache)
11784         (aarch64_make_stub_cache): Replace throw_exception with throw.
11785
11786 2019-04-08  Tom Tromey  <tom@tromey.com>
11787
11788         * common/common-exceptions.c (throw_exception): Rename from
11789         throw_exception_cxx.  Remove old copy.  Make argument const.
11790         (throw_it): Create and throw exception objects directly.
11791         * common/common-exceptions.h (throw_exception): Make argument
11792         const.
11793         (struct gdb_exception_error): Add constructor.
11794         (struct gdb_exception_quit): Add constructor.
11795
11796 2019-04-08  Tom Tromey  <tom@tromey.com>
11797
11798         * common/common-exceptions.h (exception_rethrow): Don't declare.
11799         (TRY_SJLJ): Update comment.
11800         (TRY, CATCH, END_CATCH): Remove.
11801         * common/common-exceptions.c (exception_rethrow): Remove.
11802
11803 2019-04-08  Tom Tromey  <tom@tromey.com>
11804
11805         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11806         Remove.
11807         (gdb_exception_error): Rename from
11808         gdb_exception_RETURN_MASK_ERROR.
11809         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11810         (gdb_quit_bad_alloc): Update.
11811         * aarch64-tdep.c: Update.
11812         * ada-lang.c: Update.
11813         * ada-typeprint.c: Update.
11814         * ada-valprint.c: Update.
11815         * amd64-tdep.c: Update.
11816         * arch-utils.c: Update.
11817         * break-catch-throw.c: Update.
11818         * breakpoint.c: Update.
11819         * btrace.c: Update.
11820         * c-varobj.c: Update.
11821         * cli/cli-cmds.c: Update.
11822         * cli/cli-interp.c: Update.
11823         * cli/cli-script.c: Update.
11824         * common/common-exceptions.c: Update.
11825         * common/new-op.c: Update.
11826         * common/selftest.c: Update.
11827         * compile/compile-c-symbols.c: Update.
11828         * compile/compile-cplus-symbols.c: Update.
11829         * compile/compile-object-load.c: Update.
11830         * compile/compile-object-run.c: Update.
11831         * completer.c: Update.
11832         * corelow.c: Update.
11833         * cp-abi.c: Update.
11834         * cp-support.c: Update.
11835         * cp-valprint.c: Update.
11836         * darwin-nat.c: Update.
11837         * disasm-selftests.c: Update.
11838         * dtrace-probe.c: Update.
11839         * dwarf-index-cache.c: Update.
11840         * dwarf-index-write.c: Update.
11841         * dwarf2-frame-tailcall.c: Update.
11842         * dwarf2-frame.c: Update.
11843         * dwarf2loc.c: Update.
11844         * dwarf2read.c: Update.
11845         * eval.c: Update.
11846         * event-loop.c: Update.
11847         * event-top.c: Update.
11848         * exec.c: Update.
11849         * f-valprint.c: Update.
11850         * fbsd-tdep.c: Update.
11851         * frame-unwind.c: Update.
11852         * frame.c: Update.
11853         * gdbtypes.c: Update.
11854         * gnu-v3-abi.c: Update.
11855         * guile/guile-internal.h: Update.
11856         * guile/scm-block.c: Update.
11857         * guile/scm-breakpoint.c: Update.
11858         * guile/scm-cmd.c: Update.
11859         * guile/scm-disasm.c: Update.
11860         * guile/scm-frame.c: Update.
11861         * guile/scm-lazy-string.c: Update.
11862         * guile/scm-math.c: Update.
11863         * guile/scm-param.c: Update.
11864         * guile/scm-ports.c: Update.
11865         * guile/scm-pretty-print.c: Update.
11866         * guile/scm-symbol.c: Update.
11867         * guile/scm-symtab.c: Update.
11868         * guile/scm-type.c: Update.
11869         * guile/scm-value.c: Update.
11870         * i386-linux-tdep.c: Update.
11871         * i386-tdep.c: Update.
11872         * inf-loop.c: Update.
11873         * infcall.c: Update.
11874         * infcmd.c: Update.
11875         * infrun.c: Update.
11876         * jit.c: Update.
11877         * language.c: Update.
11878         * linespec.c: Update.
11879         * linux-fork.c: Update.
11880         * linux-nat.c: Update.
11881         * linux-tdep.c: Update.
11882         * linux-thread-db.c: Update.
11883         * main.c: Update.
11884         * mi/mi-cmd-break.c: Update.
11885         * mi/mi-cmd-stack.c: Update.
11886         * mi/mi-interp.c: Update.
11887         * mi/mi-main.c: Update.
11888         * objc-lang.c: Update.
11889         * p-valprint.c: Update.
11890         * parse.c: Update.
11891         * ppc-linux-tdep.c: Update.
11892         * printcmd.c: Update.
11893         * python/py-arch.c: Update.
11894         * python/py-breakpoint.c: Update.
11895         * python/py-cmd.c: Update.
11896         * python/py-finishbreakpoint.c: Update.
11897         * python/py-frame.c: Update.
11898         * python/py-framefilter.c: Update.
11899         * python/py-gdb-readline.c: Update.
11900         * python/py-inferior.c: Update.
11901         * python/py-infthread.c: Update.
11902         * python/py-lazy-string.c: Update.
11903         * python/py-linetable.c: Update.
11904         * python/py-objfile.c: Update.
11905         * python/py-param.c: Update.
11906         * python/py-prettyprint.c: Update.
11907         * python/py-progspace.c: Update.
11908         * python/py-record-btrace.c: Update.
11909         * python/py-record.c: Update.
11910         * python/py-symbol.c: Update.
11911         * python/py-type.c: Update.
11912         * python/py-unwind.c: Update.
11913         * python/py-utils.c: Update.
11914         * python/py-value.c: Update.
11915         * python/python.c: Update.
11916         * record-btrace.c: Update.
11917         * record-full.c: Update.
11918         * remote-fileio.c: Update.
11919         * remote.c: Update.
11920         * riscv-tdep.c: Update.
11921         * rs6000-aix-tdep.c: Update.
11922         * rs6000-tdep.c: Update.
11923         * rust-exp.y: Update.
11924         * rust-lang.c: Update.
11925         * s390-tdep.c: Update.
11926         * selftest-arch.c: Update.
11927         * solib-dsbt.c: Update.
11928         * solib-frv.c: Update.
11929         * solib-spu.c: Update.
11930         * solib-svr4.c: Update.
11931         * solib.c: Update.
11932         * sparc64-linux-tdep.c: Update.
11933         * stack.c: Update.
11934         * symfile-mem.c: Update.
11935         * symmisc.c: Update.
11936         * target.c: Update.
11937         * thread.c: Update.
11938         * top.c: Update.
11939         * tracefile-tfile.c: Update.
11940         * tui/tui.c: Update.
11941         * typeprint.c: Update.
11942         * unittests/cli-utils-selftests.c: Update.
11943         * unittests/parse-connection-spec-selftests.c: Update.
11944         * valops.c: Update.
11945         * valprint.c: Update.
11946         * value.c: Update.
11947         * varobj.c: Update.
11948         * windows-nat.c: Update.
11949         * x86-linux-nat.c: Update.
11950         * xml-support.c: Update.
11951
11952 2019-04-08  Tom Tromey  <tom@tromey.com>
11953
11954         * xml-support.c: Use C++ exception handling.
11955         * x86-linux-nat.c: Use C++ exception handling.
11956         * windows-nat.c: Use C++ exception handling.
11957         * varobj.c: Use C++ exception handling.
11958         * value.c: Use C++ exception handling.
11959         * valprint.c: Use C++ exception handling.
11960         * valops.c: Use C++ exception handling.
11961         * unittests/parse-connection-spec-selftests.c: Use C++ exception
11962         handling.
11963         * unittests/cli-utils-selftests.c: Use C++ exception handling.
11964         * typeprint.c: Use C++ exception handling.
11965         * tui/tui.c: Use C++ exception handling.
11966         * tracefile-tfile.c: Use C++ exception handling.
11967         * top.c: Use C++ exception handling.
11968         * thread.c: Use C++ exception handling.
11969         * target.c: Use C++ exception handling.
11970         * symmisc.c: Use C++ exception handling.
11971         * symfile-mem.c: Use C++ exception handling.
11972         * stack.c: Use C++ exception handling.
11973         * sparc64-linux-tdep.c: Use C++ exception handling.
11974         * solib.c: Use C++ exception handling.
11975         * solib-svr4.c: Use C++ exception handling.
11976         * solib-spu.c: Use C++ exception handling.
11977         * solib-frv.c: Use C++ exception handling.
11978         * solib-dsbt.c: Use C++ exception handling.
11979         * selftest-arch.c: Use C++ exception handling.
11980         * s390-tdep.c: Use C++ exception handling.
11981         * rust-lang.c: Use C++ exception handling.
11982         * rust-exp.y: Use C++ exception handling.
11983         * rs6000-tdep.c: Use C++ exception handling.
11984         * rs6000-aix-tdep.c: Use C++ exception handling.
11985         * riscv-tdep.c: Use C++ exception handling.
11986         * remote.c: Use C++ exception handling.
11987         * remote-fileio.c: Use C++ exception handling.
11988         * record-full.c: Use C++ exception handling.
11989         * record-btrace.c: Use C++ exception handling.
11990         * python/python.c: Use C++ exception handling.
11991         * python/py-value.c: Use C++ exception handling.
11992         * python/py-utils.c: Use C++ exception handling.
11993         * python/py-unwind.c: Use C++ exception handling.
11994         * python/py-type.c: Use C++ exception handling.
11995         * python/py-symbol.c: Use C++ exception handling.
11996         * python/py-record.c: Use C++ exception handling.
11997         * python/py-record-btrace.c: Use C++ exception handling.
11998         * python/py-progspace.c: Use C++ exception handling.
11999         * python/py-prettyprint.c: Use C++ exception handling.
12000         * python/py-param.c: Use C++ exception handling.
12001         * python/py-objfile.c: Use C++ exception handling.
12002         * python/py-linetable.c: Use C++ exception handling.
12003         * python/py-lazy-string.c: Use C++ exception handling.
12004         * python/py-infthread.c: Use C++ exception handling.
12005         * python/py-inferior.c: Use C++ exception handling.
12006         * python/py-gdb-readline.c: Use C++ exception handling.
12007         * python/py-framefilter.c: Use C++ exception handling.
12008         * python/py-frame.c: Use C++ exception handling.
12009         * python/py-finishbreakpoint.c: Use C++ exception handling.
12010         * python/py-cmd.c: Use C++ exception handling.
12011         * python/py-breakpoint.c: Use C++ exception handling.
12012         * python/py-arch.c: Use C++ exception handling.
12013         * printcmd.c: Use C++ exception handling.
12014         * ppc-linux-tdep.c: Use C++ exception handling.
12015         * parse.c: Use C++ exception handling.
12016         * p-valprint.c: Use C++ exception handling.
12017         * objc-lang.c: Use C++ exception handling.
12018         * mi/mi-main.c: Use C++ exception handling.
12019         * mi/mi-interp.c: Use C++ exception handling.
12020         * mi/mi-cmd-stack.c: Use C++ exception handling.
12021         * mi/mi-cmd-break.c: Use C++ exception handling.
12022         * main.c: Use C++ exception handling.
12023         * linux-thread-db.c: Use C++ exception handling.
12024         * linux-tdep.c: Use C++ exception handling.
12025         * linux-nat.c: Use C++ exception handling.
12026         * linux-fork.c: Use C++ exception handling.
12027         * linespec.c: Use C++ exception handling.
12028         * language.c: Use C++ exception handling.
12029         * jit.c: Use C++ exception handling.
12030         * infrun.c: Use C++ exception handling.
12031         * infcmd.c: Use C++ exception handling.
12032         * infcall.c: Use C++ exception handling.
12033         * inf-loop.c: Use C++ exception handling.
12034         * i386-tdep.c: Use C++ exception handling.
12035         * i386-linux-tdep.c: Use C++ exception handling.
12036         * guile/scm-value.c: Use C++ exception handling.
12037         * guile/scm-type.c: Use C++ exception handling.
12038         * guile/scm-symtab.c: Use C++ exception handling.
12039         * guile/scm-symbol.c: Use C++ exception handling.
12040         * guile/scm-pretty-print.c: Use C++ exception handling.
12041         * guile/scm-ports.c: Use C++ exception handling.
12042         * guile/scm-param.c: Use C++ exception handling.
12043         * guile/scm-math.c: Use C++ exception handling.
12044         * guile/scm-lazy-string.c: Use C++ exception handling.
12045         * guile/scm-frame.c: Use C++ exception handling.
12046         * guile/scm-disasm.c: Use C++ exception handling.
12047         * guile/scm-cmd.c: Use C++ exception handling.
12048         * guile/scm-breakpoint.c: Use C++ exception handling.
12049         * guile/scm-block.c: Use C++ exception handling.
12050         * guile/guile-internal.h: Use C++ exception handling.
12051         * gnu-v3-abi.c: Use C++ exception handling.
12052         * gdbtypes.c: Use C++ exception handling.
12053         * frame.c: Use C++ exception handling.
12054         * frame-unwind.c: Use C++ exception handling.
12055         * fbsd-tdep.c: Use C++ exception handling.
12056         * f-valprint.c: Use C++ exception handling.
12057         * exec.c: Use C++ exception handling.
12058         * event-top.c: Use C++ exception handling.
12059         * event-loop.c: Use C++ exception handling.
12060         * eval.c: Use C++ exception handling.
12061         * dwarf2read.c: Use C++ exception handling.
12062         * dwarf2loc.c: Use C++ exception handling.
12063         * dwarf2-frame.c: Use C++ exception handling.
12064         * dwarf2-frame-tailcall.c: Use C++ exception handling.
12065         * dwarf-index-write.c: Use C++ exception handling.
12066         * dwarf-index-cache.c: Use C++ exception handling.
12067         * dtrace-probe.c: Use C++ exception handling.
12068         * disasm-selftests.c: Use C++ exception handling.
12069         * darwin-nat.c: Use C++ exception handling.
12070         * cp-valprint.c: Use C++ exception handling.
12071         * cp-support.c: Use C++ exception handling.
12072         * cp-abi.c: Use C++ exception handling.
12073         * corelow.c: Use C++ exception handling.
12074         * completer.c: Use C++ exception handling.
12075         * compile/compile-object-run.c: Use C++ exception handling.
12076         * compile/compile-object-load.c: Use C++ exception handling.
12077         * compile/compile-cplus-symbols.c: Use C++ exception handling.
12078         * compile/compile-c-symbols.c: Use C++ exception handling.
12079         * common/selftest.c: Use C++ exception handling.
12080         * common/new-op.c: Use C++ exception handling.
12081         * cli/cli-script.c: Use C++ exception handling.
12082         * cli/cli-interp.c: Use C++ exception handling.
12083         * cli/cli-cmds.c: Use C++ exception handling.
12084         * c-varobj.c: Use C++ exception handling.
12085         * btrace.c: Use C++ exception handling.
12086         * breakpoint.c: Use C++ exception handling.
12087         * break-catch-throw.c: Use C++ exception handling.
12088         * arch-utils.c: Use C++ exception handling.
12089         * amd64-tdep.c: Use C++ exception handling.
12090         * ada-valprint.c: Use C++ exception handling.
12091         * ada-typeprint.c: Use C++ exception handling.
12092         * ada-lang.c: Use C++ exception handling.
12093         * aarch64-tdep.c: Use C++ exception handling.
12094
12095 2019-04-08  Tom Tromey  <tom@tromey.com>
12096
12097         * xml-support.c (gdb_xml_parser::parse): Update.
12098         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12099         * value.c (show_convenience): Update.
12100         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12101         (test_parse_flags_qcs): Update.
12102         * thread.c (thr_try_catch_cmd): Update.
12103         * target.c (target_translate_tls_address): Update.
12104         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12105         (info_frame_command_core, frame_apply_command_count): Update.
12106         * rust-exp.y (rust_lex_exception_test): Update.
12107         * riscv-tdep.c (riscv_print_one_register_info): Update.
12108         * remote.c (remote_target::enable_btrace): Update.
12109         * record-btrace.c (record_btrace_enable_warn): Update.
12110         * python/py-utils.c (gdbpy_convert_exception): Update.
12111         * printcmd.c (do_one_display, print_variable_and_value): Update.
12112         * mi/mi-main.c (mi_print_exception): Update.
12113         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12114         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12115         * linux-nat.c (linux_nat_target::attach): Update.
12116         * linux-fork.c (class scoped_switch_fork_info): Update.
12117         * infrun.c (displaced_step_prepare): Update.
12118         * infcall.c (call_function_by_hand_dummy): Update.
12119         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12120         * gnu-v3-abi.c (print_one_vtable): Update.
12121         * frame.c (get_prev_frame_always): Update.
12122         * f-valprint.c (info_common_command_for_block): Update.
12123         * exec.c (try_open_exec_file): Update.
12124         * exceptions.c (print_exception, exception_print)
12125         (exception_fprintf, exception_print_same): Update.
12126         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12127         * dwarf-index-cache.c (index_cache::store)
12128         (index_cache::lookup_gdb_index): Update.
12129         * darwin-nat.c (maybe_cache_shell): Update.
12130         * cp-valprint.c (cp_print_value_fields): Update.
12131         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12132         (gcc_cplus_symbol_address): Update.
12133         * compile/compile-c-symbols.c (gcc_convert_symbol)
12134         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12135         * common/selftest.c: Update.
12136         * common/common-exceptions.h (struct gdb_exception) <message>: Now
12137         a std::string.
12138         (exception_try_scope_entry, exception_try_scope_exit): Don't
12139         declare.
12140         (struct exception_try_scope): Remove.
12141         (TRY): Don't use exception_try_scope.
12142         (struct gdb_exception): Add constructor, operator=.
12143         <what>: New method.
12144         (struct gdb_exception_RETURN_MASK_ALL)
12145         (struct gdb_exception_RETURN_MASK_ERROR)
12146         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12147         (struct gdb_quit_bad_alloc): Update.
12148         * common/common-exceptions.c (exception_none): Change
12149         initializer.
12150         (struct catcher) <state, exception>: Initialize inline.
12151         <prev>: Remove member.
12152         (current_catcher): Remove.
12153         (catchers): New global.
12154         (exceptions_state_mc_init): Simplify.
12155         (catcher_pop): Remove.
12156         (exceptions_state_mc, exceptions_state_mc_catch): Update.
12157         (try_scope_depth, exception_try_scope_entry)
12158         (exception_try_scope_exit): Remove.
12159         (throw_exception_sjlj): Update.
12160         (exception_messages, exception_messages_size): Remove.
12161         (throw_it): Simplify.
12162         (gdb_exception_sliced_copy): Remove.
12163         (throw_exception_cxx): Update.
12164         * cli/cli-script.c (script_from_file): Update.
12165         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12166         Update.
12167         * ada-valprint.c (ada_val_print): Update.
12168         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12169         (create_excep_cond_exprs): Update.
12170
12171 2019-04-08  Tom Tromey  <tom@tromey.com>
12172
12173         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12174         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12175         (TRY, CATCH, END_CATCH): Remove some definitions.
12176         * common/common-exceptions.c: Don't use GDB_XCPT.
12177         (catcher_list_size): Remove.
12178         (throw_exception, throw_it): Simplify.
12179
12180 2019-04-05  Tom Tromey  <tom@tromey.com>
12181
12182         Revert the header-sorting patch.
12183         * ft32-tdep.c: Revert.
12184         * frv-tdep.c: Revert.
12185         * frv-linux-tdep.c: Revert.
12186         * frame.c: Revert.
12187         * frame-unwind.c: Revert.
12188         * frame-base.c: Revert.
12189         * fork-child.c: Revert.
12190         * findvar.c: Revert.
12191         * findcmd.c: Revert.
12192         * filesystem.c: Revert.
12193         * filename-seen-cache.h: Revert.
12194         * filename-seen-cache.c: Revert.
12195         * fbsd-tdep.c: Revert.
12196         * fbsd-nat.h: Revert.
12197         * fbsd-nat.c: Revert.
12198         * f-valprint.c: Revert.
12199         * f-typeprint.c: Revert.
12200         * f-lang.c: Revert.
12201         * extension.h: Revert.
12202         * extension.c: Revert.
12203         * extension-priv.h: Revert.
12204         * expprint.c: Revert.
12205         * exec.h: Revert.
12206         * exec.c: Revert.
12207         * exceptions.c: Revert.
12208         * event-top.c: Revert.
12209         * event-loop.c: Revert.
12210         * eval.c: Revert.
12211         * elfread.c: Revert.
12212         * dwarf2read.h: Revert.
12213         * dwarf2read.c: Revert.
12214         * dwarf2loc.c: Revert.
12215         * dwarf2expr.h: Revert.
12216         * dwarf2expr.c: Revert.
12217         * dwarf2-frame.c: Revert.
12218         * dwarf2-frame-tailcall.c: Revert.
12219         * dwarf-index-write.h: Revert.
12220         * dwarf-index-write.c: Revert.
12221         * dwarf-index-common.c: Revert.
12222         * dwarf-index-cache.h: Revert.
12223         * dwarf-index-cache.c: Revert.
12224         * dummy-frame.c: Revert.
12225         * dtrace-probe.c: Revert.
12226         * disasm.h: Revert.
12227         * disasm.c: Revert.
12228         * disasm-selftests.c: Revert.
12229         * dictionary.c: Revert.
12230         * dicos-tdep.c: Revert.
12231         * demangle.c: Revert.
12232         * dcache.h: Revert.
12233         * dcache.c: Revert.
12234         * darwin-nat.h: Revert.
12235         * darwin-nat.c: Revert.
12236         * darwin-nat-info.c: Revert.
12237         * d-valprint.c: Revert.
12238         * d-namespace.c: Revert.
12239         * d-lang.c: Revert.
12240         * ctf.c: Revert.
12241         * csky-tdep.c: Revert.
12242         * csky-linux-tdep.c: Revert.
12243         * cris-tdep.c: Revert.
12244         * cris-linux-tdep.c: Revert.
12245         * cp-valprint.c: Revert.
12246         * cp-support.c: Revert.
12247         * cp-namespace.c: Revert.
12248         * cp-abi.c: Revert.
12249         * corelow.c: Revert.
12250         * corefile.c: Revert.
12251         * continuations.c: Revert.
12252         * completer.h: Revert.
12253         * completer.c: Revert.
12254         * complaints.c: Revert.
12255         * coffread.c: Revert.
12256         * coff-pe-read.c: Revert.
12257         * cli-out.h: Revert.
12258         * cli-out.c: Revert.
12259         * charset.c: Revert.
12260         * c-varobj.c: Revert.
12261         * c-valprint.c: Revert.
12262         * c-typeprint.c: Revert.
12263         * c-lang.c: Revert.
12264         * buildsym.c: Revert.
12265         * buildsym-legacy.c: Revert.
12266         * build-id.h: Revert.
12267         * build-id.c: Revert.
12268         * btrace.c: Revert.
12269         * bsd-uthread.c: Revert.
12270         * breakpoint.h: Revert.
12271         * breakpoint.c: Revert.
12272         * break-catch-throw.c: Revert.
12273         * break-catch-syscall.c: Revert.
12274         * break-catch-sig.c: Revert.
12275         * blockframe.c: Revert.
12276         * block.c: Revert.
12277         * bfin-tdep.c: Revert.
12278         * bfin-linux-tdep.c: Revert.
12279         * bfd-target.c: Revert.
12280         * bcache.c: Revert.
12281         * ax-general.c: Revert.
12282         * ax-gdb.h: Revert.
12283         * ax-gdb.c: Revert.
12284         * avr-tdep.c: Revert.
12285         * auxv.c: Revert.
12286         * auto-load.c: Revert.
12287         * arm-wince-tdep.c: Revert.
12288         * arm-tdep.c: Revert.
12289         * arm-symbian-tdep.c: Revert.
12290         * arm-pikeos-tdep.c: Revert.
12291         * arm-obsd-tdep.c: Revert.
12292         * arm-nbsd-tdep.c: Revert.
12293         * arm-nbsd-nat.c: Revert.
12294         * arm-linux-tdep.c: Revert.
12295         * arm-linux-nat.c: Revert.
12296         * arm-fbsd-tdep.c: Revert.
12297         * arm-fbsd-nat.c: Revert.
12298         * arm-bsd-tdep.c: Revert.
12299         * arch-utils.c: Revert.
12300         * arc-tdep.c: Revert.
12301         * arc-newlib-tdep.c: Revert.
12302         * annotate.h: Revert.
12303         * annotate.c: Revert.
12304         * amd64-windows-tdep.c: Revert.
12305         * amd64-windows-nat.c: Revert.
12306         * amd64-tdep.c: Revert.
12307         * amd64-sol2-tdep.c: Revert.
12308         * amd64-obsd-tdep.c: Revert.
12309         * amd64-obsd-nat.c: Revert.
12310         * amd64-nbsd-tdep.c: Revert.
12311         * amd64-nbsd-nat.c: Revert.
12312         * amd64-nat.c: Revert.
12313         * amd64-linux-tdep.c: Revert.
12314         * amd64-linux-nat.c: Revert.
12315         * amd64-fbsd-tdep.c: Revert.
12316         * amd64-fbsd-nat.c: Revert.
12317         * amd64-dicos-tdep.c: Revert.
12318         * amd64-darwin-tdep.c: Revert.
12319         * amd64-bsd-nat.c: Revert.
12320         * alpha-tdep.c: Revert.
12321         * alpha-obsd-tdep.c: Revert.
12322         * alpha-nbsd-tdep.c: Revert.
12323         * alpha-mdebug-tdep.c: Revert.
12324         * alpha-linux-tdep.c: Revert.
12325         * alpha-linux-nat.c: Revert.
12326         * alpha-bsd-tdep.c: Revert.
12327         * alpha-bsd-nat.c: Revert.
12328         * aix-thread.c: Revert.
12329         * agent.c: Revert.
12330         * addrmap.c: Revert.
12331         * ada-varobj.c: Revert.
12332         * ada-valprint.c: Revert.
12333         * ada-typeprint.c: Revert.
12334         * ada-tasks.c: Revert.
12335         * ada-lang.c: Revert.
12336         * aarch64-tdep.c: Revert.
12337         * aarch64-ravenscar-thread.c: Revert.
12338         * aarch64-newlib-tdep.c: Revert.
12339         * aarch64-linux-tdep.c: Revert.
12340         * aarch64-linux-nat.c: Revert.
12341         * aarch64-fbsd-tdep.c: Revert.
12342         * aarch64-fbsd-nat.c: Revert.
12343         * aarch32-linux-nat.c: Revert.
12344
12345 2019-04-05  Tom Tromey  <tom@tromey.com>
12346
12347         * ft32-tdep.c: Sort headers.
12348         * frv-tdep.c: Sort headers.
12349         * frv-linux-tdep.c: Sort headers.
12350         * frame.c: Sort headers.
12351         * frame-unwind.c: Sort headers.
12352         * frame-base.c: Sort headers.
12353         * fork-child.c: Sort headers.
12354         * findvar.c: Sort headers.
12355         * findcmd.c: Sort headers.
12356         * filesystem.c: Sort headers.
12357         * filename-seen-cache.h: Sort headers.
12358         * filename-seen-cache.c: Sort headers.
12359         * fbsd-tdep.c: Sort headers.
12360         * fbsd-nat.h: Sort headers.
12361         * fbsd-nat.c: Sort headers.
12362         * f-valprint.c: Sort headers.
12363         * f-typeprint.c: Sort headers.
12364         * f-lang.c: Sort headers.
12365         * extension.h: Sort headers.
12366         * extension.c: Sort headers.
12367         * extension-priv.h: Sort headers.
12368         * expprint.c: Sort headers.
12369         * exec.h: Sort headers.
12370         * exec.c: Sort headers.
12371         * exceptions.c: Sort headers.
12372         * event-top.c: Sort headers.
12373         * event-loop.c: Sort headers.
12374         * eval.c: Sort headers.
12375         * elfread.c: Sort headers.
12376         * dwarf2read.h: Sort headers.
12377         * dwarf2read.c: Sort headers.
12378         * dwarf2loc.c: Sort headers.
12379         * dwarf2expr.h: Sort headers.
12380         * dwarf2expr.c: Sort headers.
12381         * dwarf2-frame.c: Sort headers.
12382         * dwarf2-frame-tailcall.c: Sort headers.
12383         * dwarf-index-write.h: Sort headers.
12384         * dwarf-index-write.c: Sort headers.
12385         * dwarf-index-common.c: Sort headers.
12386         * dwarf-index-cache.h: Sort headers.
12387         * dwarf-index-cache.c: Sort headers.
12388         * dummy-frame.c: Sort headers.
12389         * dtrace-probe.c: Sort headers.
12390         * disasm.h: Sort headers.
12391         * disasm.c: Sort headers.
12392         * disasm-selftests.c: Sort headers.
12393         * dictionary.c: Sort headers.
12394         * dicos-tdep.c: Sort headers.
12395         * demangle.c: Sort headers.
12396         * dcache.h: Sort headers.
12397         * dcache.c: Sort headers.
12398         * darwin-nat.h: Sort headers.
12399         * darwin-nat.c: Sort headers.
12400         * darwin-nat-info.c: Sort headers.
12401         * d-valprint.c: Sort headers.
12402         * d-namespace.c: Sort headers.
12403         * d-lang.c: Sort headers.
12404         * ctf.c: Sort headers.
12405         * csky-tdep.c: Sort headers.
12406         * csky-linux-tdep.c: Sort headers.
12407         * cris-tdep.c: Sort headers.
12408         * cris-linux-tdep.c: Sort headers.
12409         * cp-valprint.c: Sort headers.
12410         * cp-support.c: Sort headers.
12411         * cp-namespace.c: Sort headers.
12412         * cp-abi.c: Sort headers.
12413         * corelow.c: Sort headers.
12414         * corefile.c: Sort headers.
12415         * continuations.c: Sort headers.
12416         * completer.h: Sort headers.
12417         * completer.c: Sort headers.
12418         * complaints.c: Sort headers.
12419         * coffread.c: Sort headers.
12420         * coff-pe-read.c: Sort headers.
12421         * cli-out.h: Sort headers.
12422         * cli-out.c: Sort headers.
12423         * charset.c: Sort headers.
12424         * c-varobj.c: Sort headers.
12425         * c-valprint.c: Sort headers.
12426         * c-typeprint.c: Sort headers.
12427         * c-lang.c: Sort headers.
12428         * buildsym.c: Sort headers.
12429         * buildsym-legacy.c: Sort headers.
12430         * build-id.h: Sort headers.
12431         * build-id.c: Sort headers.
12432         * btrace.c: Sort headers.
12433         * bsd-uthread.c: Sort headers.
12434         * breakpoint.h: Sort headers.
12435         * breakpoint.c: Sort headers.
12436         * break-catch-throw.c: Sort headers.
12437         * break-catch-syscall.c: Sort headers.
12438         * break-catch-sig.c: Sort headers.
12439         * blockframe.c: Sort headers.
12440         * block.c: Sort headers.
12441         * bfin-tdep.c: Sort headers.
12442         * bfin-linux-tdep.c: Sort headers.
12443         * bfd-target.c: Sort headers.
12444         * bcache.c: Sort headers.
12445         * ax-general.c: Sort headers.
12446         * ax-gdb.h: Sort headers.
12447         * ax-gdb.c: Sort headers.
12448         * avr-tdep.c: Sort headers.
12449         * auxv.c: Sort headers.
12450         * auto-load.c: Sort headers.
12451         * arm-wince-tdep.c: Sort headers.
12452         * arm-tdep.c: Sort headers.
12453         * arm-symbian-tdep.c: Sort headers.
12454         * arm-pikeos-tdep.c: Sort headers.
12455         * arm-obsd-tdep.c: Sort headers.
12456         * arm-nbsd-tdep.c: Sort headers.
12457         * arm-nbsd-nat.c: Sort headers.
12458         * arm-linux-tdep.c: Sort headers.
12459         * arm-linux-nat.c: Sort headers.
12460         * arm-fbsd-tdep.c: Sort headers.
12461         * arm-fbsd-nat.c: Sort headers.
12462         * arm-bsd-tdep.c: Sort headers.
12463         * arch-utils.c: Sort headers.
12464         * arc-tdep.c: Sort headers.
12465         * arc-newlib-tdep.c: Sort headers.
12466         * annotate.h: Sort headers.
12467         * annotate.c: Sort headers.
12468         * amd64-windows-tdep.c: Sort headers.
12469         * amd64-windows-nat.c: Sort headers.
12470         * amd64-tdep.c: Sort headers.
12471         * amd64-sol2-tdep.c: Sort headers.
12472         * amd64-obsd-tdep.c: Sort headers.
12473         * amd64-obsd-nat.c: Sort headers.
12474         * amd64-nbsd-tdep.c: Sort headers.
12475         * amd64-nbsd-nat.c: Sort headers.
12476         * amd64-nat.c: Sort headers.
12477         * amd64-linux-tdep.c: Sort headers.
12478         * amd64-linux-nat.c: Sort headers.
12479         * amd64-fbsd-tdep.c: Sort headers.
12480         * amd64-fbsd-nat.c: Sort headers.
12481         * amd64-dicos-tdep.c: Sort headers.
12482         * amd64-darwin-tdep.c: Sort headers.
12483         * amd64-bsd-nat.c: Sort headers.
12484         * alpha-tdep.c: Sort headers.
12485         * alpha-obsd-tdep.c: Sort headers.
12486         * alpha-nbsd-tdep.c: Sort headers.
12487         * alpha-mdebug-tdep.c: Sort headers.
12488         * alpha-linux-tdep.c: Sort headers.
12489         * alpha-linux-nat.c: Sort headers.
12490         * alpha-bsd-tdep.c: Sort headers.
12491         * alpha-bsd-nat.c: Sort headers.
12492         * aix-thread.c: Sort headers.
12493         * agent.c: Sort headers.
12494         * addrmap.c: Sort headers.
12495         * ada-varobj.c: Sort headers.
12496         * ada-valprint.c: Sort headers.
12497         * ada-typeprint.c: Sort headers.
12498         * ada-tasks.c: Sort headers.
12499         * ada-lang.c: Sort headers.
12500         * aarch64-tdep.c: Sort headers.
12501         * aarch64-ravenscar-thread.c: Sort headers.
12502         * aarch64-newlib-tdep.c: Sort headers.
12503         * aarch64-linux-tdep.c: Sort headers.
12504         * aarch64-linux-nat.c: Sort headers.
12505         * aarch64-fbsd-tdep.c: Sort headers.
12506         * aarch64-fbsd-nat.c: Sort headers.
12507         * aarch32-linux-nat.c: Sort headers.
12508
12509 2019-04-04  Tom Tromey  <tom@tromey.com>
12510
12511         * varobj.c (varobj_create): Update.
12512         * rust-exp.y (struct rust_parser) <update_innermost_block,
12513         lookup_symbol>: New methods.
12514         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12515         Rename.
12516         (rust_parser::rust_lookup_type)
12517         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12518         * printcmd.c (display_command, do_one_display): Update.
12519         * parser-defs.h (struct parser_state) <parser_state>: Add
12520         "tracker" parameter.
12521         (block_tracker): New member.
12522         (class innermost_block_tracker) <innermost_block_tracker>: Add
12523         "types" parameter.
12524         <reset>: Remove method.
12525         (innermost_block): Don't declare.
12526         (null_post_parser): Update.
12527         * parse.c (innermost_block): Remove global.
12528         (write_dollar_variable): Update.
12529         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12530         Remove "tracker_types" parameter.
12531         (parse_expression): Add "tracker" parameter.
12532         (parse_expression_for_completion): Update.
12533         (null_post_parser): Add "tracker" parameter.
12534         * p-exp.y: Update rules.
12535         * m2-exp.y: Update rules.
12536         * language.h (struct language_defn) <la_post_parser>: Add
12537         "tracker" parameter.
12538         * go-exp.y: Update rules.
12539         * f-exp.y: Update rules.
12540         * expression.h (parse_expression, parse_exp_1): Add "tracker"
12541         parameter.
12542         * d-exp.y: Update rules.
12543         * c-exp.y: Update rules.
12544         * breakpoint.c (set_breakpoint_condition): Create an
12545         innermost_block_tracker.
12546         (watch_command_1): Likewise.
12547         * ada-lang.c (resolve): Add "tracker" parameter.
12548         (resolve_subexp): Likewise.
12549         * ada-exp.y (write_var_from_sym): Update.
12550
12551 2019-04-04  Tom Tromey  <tom@tromey.com>
12552
12553         * type-stack.h: New file.
12554         * type-stack.c: New file.
12555         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12556         type-stack.h.
12557         (insert_into_type_stack, insert_type, push_type, push_type_int)
12558         (insert_type_address_space, pop_type, pop_type_int)
12559         (pop_typelist, pop_type_stack, append_type_stack)
12560         (push_type_stack, get_type_stack, push_typelist)
12561         (follow_type_instance_flags, follow_types): Don't declare.
12562         * parse.c (type_stack): Remove global.
12563         (parse_exp_in_context): Update.
12564         (insert_into_type_stack, insert_type, push_type, push_type_int)
12565         (insert_type_address_space, pop_type, pop_type_int)
12566         (pop_typelist, pop_type_stack, append_type_stack)
12567         (push_type_stack, get_type_stack, push_typelist)
12568         (follow_type_instance_flags, follow_types): Remove (moved to
12569         type-stack.c).
12570         * f-exp.y (type_stack): New global.
12571         Update rules.
12572         (push_kind_type, f_parse): Update.
12573         * d-exp.y (type_stack): New global.
12574         Update rules.
12575         (d_parse): Update.
12576         * c-exp.y (struct c_parse_state) <type_stack>: New member.
12577         Update rules.
12578         * Makefile.in (COMMON_SFILES): Add type-stack.c.
12579         (HFILES_NO_SRCDIR): Add type-stack.h.
12580
12581 2019-04-04  Tom Tromey  <tom@tromey.com>
12582
12583         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12584         (rust_parser::convert_ast_to_expression, rust_parse)
12585         (rust_lex_test_completion, rust_lex_tests): Update.
12586         * parser-defs.h (struct expr_completion_state): New.
12587         (struct parser_state) <parser_state>: Add completion parameter.
12588         <mark_struct_expression, mark_completion_tag>: New methods.
12589         <parse_completion, m_completion_state>: New members.
12590         (prefixify_expression, null_post_parser): Update.
12591         (mark_struct_expression, mark_completion_tag): Don't declare.
12592         * parse.c (parse_completion, expout_last_struct)
12593         (expout_tag_completion_type, expout_completion_name): Remove
12594         globals.
12595         (parser_state::mark_struct_expression)
12596         (parser_state::mark_completion_tag): Now methods.
12597         (prefixify_expression): Add last_struct parameter.
12598         (prefixify_subexp): Likewise.
12599         (parse_exp_1): Update.
12600         (parse_exp_in_context): Add cstate parameter.  Update.
12601         (parse_expression_for_completion): Create an
12602         expr_completion_state.
12603         (null_post_parser): Add "completion" parameter.
12604         * p-exp.y: Update rules.
12605         (yylex): Update.
12606         * language.h (struct language_defn) <la_post_parser>: Add
12607         "completing" parameter.
12608         * go-exp.y: Update rules.
12609         (lex_one_token): Update.
12610         * expression.h (parse_completion): Don't declare.
12611         * d-exp.y: Update rules.
12612         (lex_one_token): Update rules.
12613         * c-exp.y: Update rules.
12614         (lex_one_token): Update.
12615         * ada-lang.c (resolve): Add "parse_completion" parameter.
12616         (resolve_subexp): Likewise.
12617         (ada_resolve_function): Likewise.
12618
12619 2019-04-04  Tom Tromey  <tom@tromey.com>
12620
12621         * parser-defs.h (struct parser_state) <start_arglist,
12622         end_arglist>: New methods.
12623         <arglist_len, m_funcall_chain>: New members.
12624         (arglist_len, start_arglist, end_arglist): Don't declare.
12625         * parse.c (arglist_len, funcall_chain): Remove global.
12626         (start_arglist, end_arglist): Remove functions.
12627         (parse_exp_in_context): Update.
12628         * p-exp.y: Update rules.
12629         * m2-exp.y: Update rules.
12630         * go-exp.y: Update rules.
12631         * f-exp.y: Update rules.
12632         * d-exp.y: Update rules.
12633         * c-exp.y: Update rules.
12634
12635 2019-04-04  Tom Tromey  <tom@tromey.com>
12636
12637         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12638         lex_operator, push_back>: New methods.
12639         Update all rules.
12640         (rust_parser::lex_hex, lex_escape): Rename and update.
12641         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12642         (rust_parser::lex_operator): Rename and update.
12643         (rust_parser::lex_number, rustyylex, rustyyerror)
12644         (rust_lex_test_init, rust_lex_test_sequence)
12645         (rust_lex_test_push_back, rust_lex_tests): Update.
12646         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12647         parameter.
12648         <lexptr, prev_lexptr>: New members.
12649         (lexptr, prev_lexptr): Don't declare.
12650         * parse.c (lexptr, prev_lexptr): Remove globals.
12651         (parse_exp_in_context): Update.
12652         * p-exp.y (yylex, yyerror): Update.
12653         * m2-exp.y (parse_number, yylex, yyerror): Update.
12654         * go-exp.y (lex_one_token, yyerror): Update.
12655         * f-exp.y (match_string_literal, yylex, yyerror): Update.
12656         * d-exp.y (lex_one_token, yyerror): Update.
12657         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12658         (lex_one_token, yyerror): Update.
12659         * ada-lex.l (YY_INPUT): Update.
12660         (rewind_to_char): Update.
12661         * ada-exp.y (yyerror): Update.
12662
12663 2019-04-04  Tom Tromey  <tom@tromey.com>
12664
12665         * rust-exp.y (rustyylex, rust_lex_tests): Update.
12666         * parser-defs.h (struct parser_state) <parser_state>: Add new
12667         parameter.
12668         <comma_terminates>: New member.
12669         (comma_terminates): Don't declare global.
12670         * parse.c (comma_terminates): Remove global.
12671         (parse_exp_in_context): Update.
12672         * p-exp.y (yylex): Update.
12673         * m2-exp.y (yylex): Update.
12674         * go-exp.y (lex_one_token): Update.
12675         * f-exp.y (yylex): Update.
12676         * d-exp.y (lex_one_token): Update.
12677         * c-exp.y (lex_one_token): Update.
12678         * ada-lex.l: Update.
12679
12680 2019-04-04  Tom Tromey  <tom@tromey.com>
12681
12682         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12683         (rustyylex, rust_lex_test_init, rust_lex_test_one)
12684         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12685         * parser-defs.h (paren_depth): Don't declare.
12686         * parse.c (paren_depth): Remove global.
12687         (parse_exp_in_context): Update.
12688         * p-exp.y (paren_depth): New global.
12689         (pascal_parse): Initialize it.
12690         * m2-exp.y (paren_depth): New global.
12691         (m2_parse): Initialize it.
12692         * go-exp.y (paren_depth): New global.
12693         (go_parse): Initialize it.
12694         * f-exp.y (paren_depth): New global.
12695         (f_parse): Initialize it.
12696         * d-exp.y (paren_depth): New global.
12697         (d_parse): Initialize it.
12698         * c-exp.y (paren_depth): New global.
12699         (c_parse): Initialize it.
12700         * ada-lex.l (paren_depth): New global.
12701         (lexer_init): Initialize it.
12702
12703 2019-04-04  Tom Tromey  <tom@tromey.com>
12704
12705         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12706         (rust_parser::convert_ast_to_type)
12707         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12708         * parser-defs.h (struct parser_state) <parser_state>: Add
12709         parameters.  Initialize new members.
12710         <expression_context_block, expression_context_pc>: New members.
12711         * parse.c (expression_context_block, expression_context_pc):
12712         Remove globals.
12713         (parse_exp_in_context): Update.
12714         * p-exp.y: Update all rules.
12715         (yylex): Update.
12716         * m2-exp.y: Update all rules.
12717         (yylex): Update.
12718         * go-exp.y (yylex): Update.
12719         * f-exp.y (yylex): Update.
12720         * d-exp.y: Update all rules.
12721         (yylex): Update.
12722         * c-exp.y: Update all rules.
12723         (lex_one_token, classify_name, yylex, c_parse): Update.
12724         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12725
12726 2019-04-04  Tom Tromey  <tom@tromey.com>
12727
12728         * gdbarch.h, gdbarch.c: Rebuild.
12729         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12730         * stap-probe.h:
12731         (struct stap_parse_info): Replace "parser_state" with
12732         "expr_builder".
12733         * parser-defs.h (struct expr_builder): Rename from "parser_state".
12734         (parser_state): New class.
12735         * parse.c (expr_builder): Rename.
12736         (expr_builder::release): Rename.
12737         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12738         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12739         (write_exp_elt_longcst, write_exp_elt_floatcst)
12740         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12741         (write_exp_string_vector, write_exp_bitstring)
12742         (write_exp_msymbol, mark_struct_expression)
12743         (write_dollar_variable)
12744         (insert_type_address_space, increase_expout_size): Replace
12745         "parser_state" with "expr_builder".
12746         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12747         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12748         "parser_state" with "expr_builder".
12749
12750 2019-04-04  Tom Tromey  <tom@tromey.com>
12751
12752         * rust-exp.y: Replace "parse_language" with method call.
12753         * p-exp.y:
12754         (yylex): Replace "parse_language" with method call.
12755         * m2-exp.y:
12756         (yylex): Replace "parse_language" with method call.
12757         * go-exp.y (classify_name): Replace "parse_language" with method
12758         call.
12759         * f-exp.y (yylex): Replace "parse_language" with method call.
12760         * d-exp.y (lex_one_token): Replace "parse_language" with method
12761         call.
12762         * c-exp.y:
12763         (lex_one_token, classify_name, yylex): Replace "parse_language"
12764         with method call.
12765         * ada-exp.y (find_primitive_type, type_char)
12766         (type_system_address): Replace "parse_language" with method call.
12767
12768 2019-04-04  Tom Tromey  <tom@tromey.com>
12769
12770         * rust-exp.y: Replace "parse_gdbarch" with method call.
12771         * parse.c (write_dollar_variable, insert_type_address_space):
12772         Replace "parse_gdbarch" with method call.
12773         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12774         call.
12775         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12776         call.
12777         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12778         "parse_gdbarch" with method call.
12779         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12780         with method call.
12781         * f-exp.y (parse_type, parse_f_type, yylex): Replace
12782         "parse_gdbarch" with method call.
12783         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12784         "parse_gdbarch" with method call.
12785         * c-exp.y (parse_type, parse_number, classify_name): Replace
12786         "parse_gdbarch" with method call.
12787         * ada-lex.l: Replace "parse_gdbarch" with method call.
12788         * ada-exp.y (parse_type, find_primitive_type, type_char)
12789         (type_system_address): Replace "parse_gdbarch" with method call.
12790
12791 2019-04-04  Tom Tromey  <tom@tromey.com>
12792
12793         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12794         * stap-probe.c (stap_parse_argument): Update.
12795         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12796         initial_size parameter.
12797         * rust-exp.y (rust_lex_tests): Update.
12798         * parse.c (parser_state): Update.
12799         (parse_exp_in_context): Update.
12800         * parser-defs.h (struct parser_state) <parser_state>: Remove
12801         "initial_size" parameter.
12802
12803 2019-04-04  Tom Tromey  <tom@tromey.com>
12804
12805         * parser-defs.h (increase_expout_size): Don't declare.
12806         * parse.c (increase_expout_size): Now static.
12807
12808 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
12809
12810         * gnu-nat.c (gnu_nat_target::wait): Fix
12811         target_waitstatus_to_string call.
12812
12813 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12814
12815         * eval.c (evaluate_subexp_standard): Handle internal functions
12816         during Fortran function call handling.
12817
12818 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12819
12820         * NEWS: Mention new internal functions.
12821         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12822         (read_base_type): Use dwarf2_init_complex_target_type.
12823         * value.c (creal_internal_fn): New function.
12824         (cimag_internal_fn): New function.
12825         (_initialize_values): Register new internal functions.
12826
12827 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12828
12829         * infrun.c (stop_all_threads): If debug_infrun, always
12830         trace the wait status after wait_one, using
12831         target_waitstatus_to_string and target_pid_to_str.
12832         (handle_inferior_event): Replace various trace of
12833         wait status kind by a single trace.
12834         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12835         wait status kind image by target_waitstatus_to_string.
12836         * target/waitstatus.c (target_waitstatus_to_string): Fix
12837         obsolete comment.
12838
12839 2019-04-01  Tom Tromey  <tromey@adacore.com>
12840
12841         PR symtab/23331:
12842         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12843
12844 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
12845             Pedro Alves  <palves@redhat.com>
12846
12847         * top.c (quit_force): Call 'finalize_values'.
12848         * value.c (finalize_values): New function.
12849         * value.h (finalize_values): Declare.
12850
12851 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
12852
12853         * NEWS: Announce $_gdb_major and $_gdb_minor.
12854
12855         * top.c (init_gdb_version_vars): New function.
12856         (gdb_init): Call init_gdb_version_vars.
12857
12858 2019-03-29  Tom Tromey  <tromey@adacore.com>
12859
12860         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
12861         help text.  Remove dead code.
12862
12863 2019-03-29  Keith Seitz  <keiths@redhat.com>
12864
12865         From Siddhesh Poyarekar:
12866         * f-lang.h (f77_get_upperbound): Return LONGEST.
12867         (f77_get_lowerbound): Likewise.
12868         * f-typeprint.c (f_type_print_varspec_suffix): Expand
12869         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
12870         print them.
12871         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
12872         plongest to format print it.
12873         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12874         (f77_get_upperbound): Likewise.
12875         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12876         LOWER_BOUND to LONGEST.
12877         (f77_create_arrayprint_offset_tbl): Likewise.
12878
12879 2019-03-29  Keith Seitz  <keiths@redhat.com>
12880
12881         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12882         %s/pulongest for TYPE_LENGTH instead of %d in format
12883         strings.
12884         * ada-typerint.c (ada_print_type): Likewise.
12885         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12886         * compile/compile-c-support.c (generate_register_struct): Likewise.
12887         * gdbtypes.c (recursive_dump_type): Likewise.
12888         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12889         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
12890         instead of %d in format strings.
12891         * riscv-tdep.c (riscv_type_alignment): Cast second argument
12892         to std::min to ULONGEST.
12893         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12894         instead of %d in format strings.
12895         * tracepoint.c (info_scope_command): Likewise.
12896         * typeprint.c (print_offset_data::update)
12897         (print_offset_data::finish): Likewise.
12898         * xtensa-tdep.c (xtensa_store_return_value)
12899         (xtensa_push_dummy_call): Likewise.
12900
12901 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
12902
12903         * windows-nat.c (display_selector): Fixed format specifications
12904         for 64-bit Cygwin.
12905
12906 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12907
12908         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12909
12910 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
12911
12912         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12913         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12914         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12915         (nios2_linux_init_abi): Install it.
12916
12917 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12918
12919         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12920
12921 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12922
12923         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12924
12925 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12926             Tom Tromey  <tromey@adacore.com>
12927
12928         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12929
12930 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
12931
12932         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12933         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12934         method to compute the bounds of range types. Also print "[evaluated]"
12935         if the bounds' values come from a dynamic evaluation.
12936
12937 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12938
12939         * cp-valprint.c (cp_print_value_fields): Don't print trailing
12940         whitespace when pretty printing is on.
12941
12942 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12943
12944         * ppc-linux-nat.c: Add include.
12945
12946 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12947
12948         * NEWS: Mention AArch64 Pointer Authentication.
12949
12950 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12951
12952         * arm-linux-nat.c: Add include.
12953
12954 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
12955
12956         * source-cache.c (source_cache::get_source_lines): Re-read
12957         fullname after calling open_source_file.
12958
12959 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
12960
12961         * NEWS: Mention TLS support for FreeBSD.
12962
12963 2019-03-25  Tom Tromey  <tromey@adacore.com>
12964
12965         * minsyms.c (BUNCH_SIZE): Update comment.
12966         (~minimal_symbol_reader): Remove old comment.
12967         (compact_minimal_symbols): Update comment.
12968         (minimal_symbol_reader::install): Remove old comment.  Update
12969         other comments.
12970
12971 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12972
12973         * s390-linux-nat.c: Add include.
12974
12975 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12976
12977         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12978         Call linux_get_hwcap.
12979         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12980         Likewise.
12981         (aarch64_linux_get_hwcap): Remove function.
12982         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12983         declaration.
12984         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12985         linux_get_hwcap.
12986         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12987         * linux-tdep.c (linux_get_hwcap): Add function.
12988         (linux_get_hwcap2): Likewise.
12989         * linux-tdep.h (linux_get_hwcap): Add declaration.
12990         (linux_get_hwcap2): Likewise.
12991         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12992         (ppc_linux_get_hwcap2): Likewise.
12993         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12994         linux_get_hwcap.
12995         (ppc_linux_nat_target::insert_watchpoint): Likewise.
12996         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12997         (ppc_linux_nat_target::read_description): Likewise.
12998         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12999         * s390-linux-nat.c: Likewise.
13000         * s390-linux-tdep.c (s390_core_read_description): Likewise.
13001
13002 2019-03-24  Tom Tromey  <tom@tromey.com>
13003
13004         * ada-lang.c (standard_lookup): Simplify initialization.
13005         (ada_lookup_symbol_nonlocal): Simplify return.
13006         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13007         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13008         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13009         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13010         initialization.
13011         * solib.c (solib_global_lookup): Simplify.
13012         * symtab.c (null_block_symbol): Remove.
13013         (symbol_cache_lookup): Simplify returns.
13014         (lookup_language_this): Simplify returns.
13015         (lookup_symbol_aux): Simplify return.
13016         (lookup_local_symbol): Simplify returns.
13017         (lookup_global_symbol_from_objfile): Simplify return.
13018         (lookup_symbol_in_objfile_symtabs)
13019         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13020         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13021         (lookup_static_symbol, lookup_global_symbol): Simplify return.
13022         * cp-namespace.c (cp_lookup_bare_symbol)
13023         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13024         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13025         (cp_lookup_nested_symbol): Don't use null_block_symbol.
13026         (cp_lookup_symbol_via_imports): Simplify initialization.
13027         (find_symbol_in_baseclass): Likewise.
13028         * symtab.h (null_block_symbol): Remove.
13029         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13030         (d_lookup_nested_symbol, d_lookup_symbol_imports)
13031         (d_lookup_symbol_module): Likewise.
13032         (find_symbol_in_baseclass): Simplify initialization.
13033
13034 2019-03-24  Tom Tromey  <tom@tromey.com>
13035
13036         * expression.h: Don't include symtab.h.
13037         (struct block): Forward declare.
13038
13039 2019-03-24  Tom Tromey  <tom@tromey.com>
13040
13041         * c-exp.y (typebase): Remove casts.
13042         * gdbtypes.c (lookup_unsigned_typename, )
13043         (lookup_signed_typename): Remove cast.
13044         * eval.c (parse_to_comma_and_eval): Remove cast.
13045         * parse.c (write_dollar_variable): Remove cast.
13046         * block.h (struct block) <superblock>: Now const.
13047         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13048         * psymtab.c (psym_map_matching_symbols): Make "block" const.
13049         (map_block): Make "block" const.
13050         * symfile.h (struct quick_symbol_functions)
13051         <map_matching_symbols>: Constify block argument to "callback".
13052         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13053         const.
13054         (find_pc_sect_compunit_symtab): Make "b" const.
13055         (find_symbol_at_address): Likewise.
13056         (search_symbols): Likewise.
13057         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13058         (dw2_debug_names_lookup_symbol): Likewise.
13059         (dw2_map_matching_symbols): Update.
13060         * p-valprint.c (pascal_val_print): Remove "block".
13061         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13062         (aux_add_nonlocal_symbols): Make "block" const.
13063         (resolve_subexp): Remove cast.
13064         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13065         const.
13066         (iterate_over_file_blocks): Likewise.
13067         * f-exp.y (%union) <bval>: Remove.
13068         * coffread.c (patch_opaque_types): Make "b" const.
13069         * spu-tdep.c (spu_catch_start): Make "block" const.
13070         * c-valprint.c (print_unpacked_pointer): Remove "block".
13071         * symmisc.c (dump_symtab_1): Make "b" const.
13072         (block_depth): Make "block" const.
13073         * d-exp.y (%union) <bval>: Remove.
13074         * cp-support.h (cp_lookup_rtti_type): Update.
13075         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13076         * psymtab.c (psym_lookup_symbol): Make "block" const.
13077         (maintenance_check_psymtabs): Make "b" const.
13078         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13079         (enumerate_locals, enumerate_args): Update.
13080         * python/py-symtab.c (stpy_global_block): Make "block" const.
13081         (stpy_static_block): Likewise.
13082         * inline-frame.c (block_starting_point_at): Make "new_block"
13083         const.
13084         * block.c (find_block_in_blockvector): Make return type const.
13085         (blockvector_for_pc_sect): Make "b" const.
13086         (find_block_in_blockvector): Make "b" const.
13087
13088 2019-03-23  Tom Tromey  <tom@tromey.com>
13089
13090         * varobj.c (varobj_create): Update.
13091         * symfile.c (clear_symtab_users): Don't reset innermost_block.
13092         * printcmd.c (display_command, do_one_display): Don't reset
13093         innermost_block.
13094         * parser-defs.h (enum innermost_block_tracker_type): Move to
13095         expression.h.
13096         (innermost_block): Update comment.
13097         * parse.c (parse_exp_1): Add tracker_types parameter.
13098         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
13099         tracker_types parameter.  Reset innermost_block.
13100         (parse_exp_in_context): Remove.
13101         (parse_expression_for_completion): Update.
13102         * objfiles.c (~objfile): Don't reset expression_context_block or
13103         innermost_block.
13104         * expression.h (enum innermost_block_tracker_type): Move from
13105         parser-defs.h.
13106         (parse_exp_1): Add tracker_types parameter.
13107         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13108         reset innermost_block.
13109
13110 2019-03-23  Tom Tromey  <tom@tromey.com>
13111
13112         * objfiles.h: Include bcache.h.
13113
13114 2019-03-23  Tom Tromey  <tom@tromey.com>
13115
13116         * linespec.c (get_current_search_block): Use
13117         scoped_restore_current_language.
13118         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13119
13120 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13121             Jiong Wang  <jiong.wang@arm.com>
13122
13123         * aarch64-linux-tdep.c
13124         (aarch64_linux_iterate_over_regset_sections): Check for pauth
13125         section.
13126         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13127
13128 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13129             Jiong Wang  <jiong.wang@arm.com>
13130
13131         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13132         instructions.
13133         (aarch64_analyze_prologue_test): Add PACIASP test.
13134         (aarch64_prologue_prev_register): Unmask PC value.
13135
13136 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13137             Jiong Wang  <jiong.wang@arm.com>
13138
13139         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13140         (aarch64_dwarf2_prev_register): Unmask PC value.
13141         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13142         (aarch64_execute_dwarf_cfa_vendor_op): Check for
13143         DW_CFA_AARCH64_negate_ra_state.
13144         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13145
13146 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13147             Jiong Wang  <jiong.wang@arm.com>
13148
13149         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13150         registers.
13151         (aarch64_pseudo_register_name): Likewise.
13152         (aarch64_pseudo_register_type): Likewise.
13153         (aarch64_pseudo_register_reggroup_p): Likewise.
13154         (aarch64_gdbarch_init): Add pauth registers.
13155         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13156         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13157         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13158         (struct gdbarch_tdep): Add regnum for ra_state.
13159
13160 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13161             Jiong Wang  <jiong.wang@arm.com>
13162
13163         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13164
13165 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13166             Jiong Wang  <jiong.wang@arm.com>
13167
13168         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13169         function.
13170         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13171         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13172         (aarch64_gdbarch_init): Add puth registers.
13173         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13174         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13175         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13176
13177 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13178             Jiong Wang  <jiong.wang@arm.com>
13179
13180         * aarch64-linux-nat.c
13181         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13182         * aarch64-linux-tdep.c
13183         (aarch64_linux_core_read_description): Likewise.
13184         (aarch64_linux_get_hwcap): New function.
13185         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13186         (aarch64_linux_get_hwcap): New declaration.
13187
13188 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13189             Jiong Wang  <jiong.wang@arm.com>
13190
13191         * aarch64-linux-nat.c
13192         (aarch64_linux_nat_target::read_description): Add pauth param.
13193         * aarch64-linux-tdep.c
13194         (aarch64_linux_core_read_description): Likewise.
13195         * aarch64-tdep.c (struct target_desc): Add in pauth.
13196         (aarch64_read_description): Add pauth param.
13197         (aarch64_gdbarch_init): Likewise.
13198         * aarch64-tdep.h (aarch64_read_description): Likewise.
13199         * arch/aarch64.c (aarch64_create_target_description): Likewise.
13200         * arch/aarch64.h (aarch64_create_target_description): Likewise.
13201         * features/Makefile: Add new files.
13202         * features/aarch64-pauth.c: New file.
13203         * features/aarch64-pauth.xml: New file.
13204
13205 2019-03-20  Tom Tromey  <tromey@adacore.com>
13206
13207         * infrun.c (handle_inferior_event): Rename from
13208         handle_inferior_event_1.  Create a scoped_value_mark.
13209         (handle_inferior_event): Remove.
13210
13211 2019-03-19  Tom Tromey  <tromey@adacore.com>
13212
13213         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13214         * infrun.h (print_stop_event): Add "displays" parameter.
13215         * infrun.c (print_stop_event): Add "displays" parameter.
13216
13217 2019-03-19  Pedro Alves  <palves@redhat.com>
13218
13219         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13220         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
13221         to -1.  Fix TABs vs spaces.
13222         (tui_ui_out::tui_ui_out): Don't initialize fields here.
13223         * tui/tui-out.h (tui_ui_out) Add intro comments.
13224         <m_line, m_start_of_line>: In-class initialize, and add describing
13225         comment.
13226
13227 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
13228
13229         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13230         variable names.
13231         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13232
13233 2019-03-18  Pedro Alves  <palves@redhat.com>
13234             Eli Zaretskii <eliz@gnu.org>
13235
13236         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13237         m_line and m_start_of_line.
13238
13239 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
13240
13241         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13242         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13243         it returns a newline.  This fixes a regression in TU mode, whereby
13244         the next line is output on the same screen line as the user input.
13245
13246 2019-03-18  Tom Tromey  <tromey@adacore.com>
13247
13248         * minsyms.c (minimal_symbol_reader::install): Remove call to
13249         obstack_blank.
13250
13251 2019-03-18  Pedro Alves  <palves@redhat.com>
13252
13253         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13254         New globals.
13255         (apply_style): New, factored out from ...
13256         (apply_ansi_escape): ... this.  Handle reverse video mode.
13257         (tui_set_reverse_mode): New function.
13258         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13259         * tui/tui-winsource.c (tui_show_source_line): Use
13260         tui_set_reverse_mode instead of setting A_STANDOUT.
13261         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13262         New setter methods.
13263
13264 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
13265
13266         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13267         Handle tabs.
13268
13269 2019-03-18  Tom Tromey  <tromey@adacore.com>
13270
13271         * ada-lang.c (empty_array): Add "high" parameter.
13272         (ada_evaluate_subexp): Update.
13273
13274 2019-03-17  Sergei Trofimovich <siarheit@google.com>
13275
13276         * unittests/string_view-selftests.c: Define
13277         _initialize_string_view_selftests unconditionally.
13278
13279 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13280
13281         PR gdb/24350
13282         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13283
13284 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13285
13286         PR gdb/24351
13287         * windows-nat.c (display_selector): Fix format specifiers.
13288
13289 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
13290
13291         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13292         tui_refill_source_window instead of tui_refresh_win, to update the
13293         current execution line.  This fixes redisplay of the current line
13294         when stepping through the code with "next" or "step".
13295
13296 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13297
13298         * source-cache.c (source_cache::get_source_lines): Call
13299         find_source_lines to initialize s->nlines.  This fixes vertical
13300         scrolling of TUI source window when the DOWN arrow is pressed.
13301
13302 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13303
13304         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13305         linux-thread-db.c (_initialize_thread_db): Likewise.
13306
13307 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13308
13309         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13310         wclrtoeol in tui_show_source_line".  This reverts changes made in
13311         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13312
13313 2019-03-15  Tom Tromey  <tom@tromey.com>
13314
13315         * symtab.h (struct minimal_symbol): Derive from
13316         general_symbol_info.
13317         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13318         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13319         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13320         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13321         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13322         (MSYMBOL_SEARCH_NAME): Update.
13323         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13324         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13325         * minsyms.c (minimal_symbol_reader::record_full): Update.
13326
13327 2019-03-15  Tom Tromey  <tom@tromey.com>
13328
13329         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13330
13331 2019-03-15  Tom Tromey  <tom@tromey.com>
13332
13333         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13334         unique_xmalloc_ptr.
13335         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13336         Update.
13337         * minsyms.c (lookup_minimal_symbol_by_pc_section)
13338         (build_minimal_symbol_hash_tables)
13339         (minimal_symbol_reader::install): Update.
13340
13341 2019-03-15  Tom Tromey  <tom@tromey.com>
13342
13343         * symtab.c (create_demangled_names_hash): Update.
13344         (symbol_set_names): Update.
13345         * objfiles.h (struct objfile_per_bfd_storage)
13346         <demangled_names_hash>: Now an htab_up.
13347         * objfiles.c (objfile_per_bfd_storage): Simplify.
13348
13349 2019-03-15  Tom Tromey  <tom@tromey.com>
13350
13351         * objfiles.h (struct objfile_per_bfd_storage): Declare
13352         destructor.
13353         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13354         New.
13355         (get_objfile_bfd_data): Use new.  Don't initialize
13356         language_of_main.
13357         (free_objfile_per_bfd_storage): Remove.
13358         (objfile_bfd_data_free, objfile::~objfile): Use delete.
13359
13360 2019-03-15  Tom Tromey  <tom@tromey.com>
13361
13362         * symfile.c (reread_symbols): Update.
13363         * objfiles.c (objfile::objfile): Update.
13364         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13365         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13366         comment.
13367         (minimal_symbol_reader::install): Update.
13368         (terminate_minimal_symbol_table): Remove.
13369         * jit.c (jit_object_close_impl): Update.
13370
13371 2019-03-15  Tom Tromey  <tom@tromey.com>
13372
13373         * minsyms.c (minimal_symbol_reader::record_full): Remove some
13374         initializations.
13375
13376 2019-03-15  Tom Tromey  <tom@tromey.com>
13377
13378         * objfiles.h (struct objfile_per_bfd_storage)
13379         <demangled_hash_languages>: Now a bitset.
13380         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13381         (lookup_minimal_symbol): Update.
13382
13383 2019-03-15  Tom Tromey  <tom@tromey.com>
13384
13385         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13386         Don't return the symbol.
13387         * coffread.c (record_minimal_symbol): Use record_full.
13388
13389 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
13390
13391         The MS-Windows port of ncurses fails to switch to a color pair if
13392         one or both of the colors are the implicit default colors.  This
13393         change records the default colors when TUI is initialized, and
13394         then specifies them explicitly when a color pair uses the default
13395         colors.  This allows color styling in TUI mode on MS-Windows.
13396
13397         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
13398         ncurses_norm_attr.
13399         (tui_initialize_io) [__MINGW32__]: Record the default terminal
13400         colors in ncurses_norm_attr.
13401         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13402         "none", replace it with the default color recorded in
13403         ncurses_norm_attr.
13404
13405 2019-03-14  Tom Tromey  <tromey@adacore.com>
13406
13407         * source-cache.h (class source_cache) <get_source_lines>: Return
13408         std::string.
13409         * source-cache.c (source_cache::extract_lines): Handle case where
13410         first_pos==npos.  Return std::string.
13411         (source_cache::get_source_lines): Update.
13412
13413 2019-03-14  Tom Tromey  <tromey@adacore.com>
13414
13415         * NEWS: Add item for "style sources" commands.
13416         * source-cache.c (source_cache::get_source_lines): Check
13417         source_styling.
13418         * cli/cli-style.c (source_styling): New global.
13419         (_initialize_cli_style): Add "style sources" commands.
13420         (show_style_sources): New function.
13421         * cli/cli-style.h (source_styling): Declare.
13422
13423 2019-03-14  Pedro Alves  <palves@redhat.com>
13424             Tom Tromey  <tromey@adacore.com>
13425
13426         * tui/tui-winsource.h (tui_refill_source_window): Declare.
13427         * tui/tui-winsource.c (tui_refill_source_window): New function,
13428         from...
13429         (tui_horizontal_source_scroll): ... here.  Move some logic.
13430         * cli/cli-style.c (set_style_enabled): Notify new observable.
13431         * tui/tui-hooks.c (tui_redisplay_source): New function.
13432         (tui_attach_detach_observers): Attach or detach
13433         tui_redisplay_source.
13434         * observable.h (source_styling_changed): New observable.
13435         * observable.c: Define source_styling_changed observable.
13436
13437 2019-03-13  Tom Tromey  <tromey@adacore.com>
13438
13439         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13440         (i386_gnu_nat_target::store_registers): Update.
13441         * target-debug.h (target_debug_print_std_string): New macro.
13442         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13443         * windows-tdep.c (display_one_tib): Update.
13444         * tui/tui-stack.c (tui_make_status_line): Update.
13445         * top.c (print_inferior_quit_action): Update.
13446         * thread.c (thr_try_catch_cmd): Update.
13447         (add_thread_with_info): Update.
13448         (thread_target_id_str): Update.
13449         (thr_try_catch_cmd): Update.
13450         (thread_command): Update.
13451         (thread_find_command): Update.
13452         * record-btrace.c (record_btrace_target::info_record)
13453         (record_btrace_resume_thread, record_btrace_target::resume)
13454         (record_btrace_cancel_resume, record_btrace_step_thread)
13455         (record_btrace_target::wait, record_btrace_target::wait)
13456         (record_btrace_target::wait, record_btrace_target::stop): Update.
13457         * progspace.c (print_program_space): Update.
13458         * process-stratum-target.c
13459         (process_stratum_target::thread_address_space): Update.
13460         * linux-fork.c (linux_fork_mourn_inferior)
13461         (detach_checkpoint_command, info_checkpoints_command)
13462         (linux_fork_context): Update.
13463         (linux_fork_detach): Update.
13464         (class scoped_switch_fork_info): Update.
13465         (delete_checkpoint_command): Update.
13466         * infrun.c (follow_fork_inferior): Update.
13467         (follow_fork_inferior): Update.
13468         (proceed_after_vfork_done): Update.
13469         (handle_vfork_child_exec_or_exit): Update.
13470         (follow_exec): Update.
13471         (displaced_step_prepare_throw): Update.
13472         (displaced_step_restore): Update.
13473         (start_step_over): Update.
13474         (resume_1): Update.
13475         (clear_proceed_status_thread): Update.
13476         (proceed): Update.
13477         (print_target_wait_results): Update.
13478         (do_target_wait): Update.
13479         (context_switch): Update.
13480         (stop_all_threads): Update.
13481         (restart_threads): Update.
13482         (finish_step_over): Update.
13483         (handle_signal_stop): Update.
13484         (switch_back_to_stepped_thread): Update.
13485         (keep_going_pass_signal): Update.
13486         (print_exited_reason): Update.
13487         (normal_stop): Update.
13488         * inferior.c (inferior_pid_to_str): Change return type.
13489         (print_selected_inferior): Update.
13490         (add_inferior): Update.
13491         (detach_inferior): Update.
13492         * dummy-frame.c (fprint_dummy_frames): Update.
13493         * dcache.c (dcache_info_1): Update.
13494         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13495         (btrace_fetch, btrace_clear): Update.
13496         * linux-tdep.c (linux_core_pid_to_str): Change return type.
13497         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13498         type.
13499         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13500         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13501         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13502         * gdbarch.c, gdbarch.h: Rebuild.
13503         * gdbarch.sh (core_pid_to_str): Change return type.
13504         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13505         return type.
13506         (windows_nat_target::pid_to_str): Change return type.
13507         (windows_delete_thread): Update.
13508         (windows_nat_target::attach): Update.
13509         (windows_nat_target::files_info): Update.
13510         * target-delegates.c: Rebuild.
13511         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13512         return type.
13513         (sol_thread_target::pid_to_str): Change return type.
13514         * remote.c (class remote_target) <pid_to_str>: Change return
13515         type.
13516         (remote_target::pid_to_str): Change return type.
13517         (extended_remote_target::attach, remote_target::remote_stop_ns)
13518         (remote_target::remote_notif_remove_queued_reply)
13519         (remote_target::push_stop_reply, remote_target::disable_btrace):
13520         Update.
13521         (extended_remote_target::attach): Update.
13522         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13523         type.
13524         (gdbsim_target::pid_to_str): Change return type.
13525         * ravenscar-thread.c (struct ravenscar_thread_target)
13526         <pid_to_str>: Change return type.
13527         (ravenscar_thread_target::pid_to_str): Change return type.
13528         * procfs.c (class procfs_target) <pid_to_str>: Change return
13529         type.
13530         (procfs_target::pid_to_str): Change return type.
13531         (procfs_target::attach): Update.
13532         (procfs_target::detach): Update.
13533         (procfs_target::fetch_registers): Update.
13534         (procfs_target::store_registers): Update.
13535         (procfs_target::wait): Update.
13536         (procfs_target::files_info): Update.
13537         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13538         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13539         return type.
13540         (nto_procfs_target::pid_to_str): Change return type.
13541         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13542         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13543         return type.
13544         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13545         (exit_lwp): Update.
13546         (attach_proc_task_lwp_callback, get_detach_signal)
13547         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13548         (linux_nat_target::resume, wait_lwp, stop_callback)
13549         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13550         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13551         (linux_nat_wait_1, resume_stopped_resumed_lwps)
13552         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13553         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13554         type.
13555         (inf_ptrace_target::attach): Update.
13556         (inf_ptrace_target::files_info): Update.
13557         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13558         type.
13559         (go32_nat_target::pid_to_str): Change return type.
13560         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13561         (gnu_nat_target::wait): Update.
13562         (gnu_nat_target::wait): Update.
13563         (gnu_nat_target::resume): Update.
13564         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13565         (fbsd_nat_target::wait): Update.
13566         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13567         type.
13568         (darwin_nat_target::attach): Update.
13569         * corelow.c (class core_target) <pid_to_str>: Change return type.
13570         (core_target::pid_to_str): Change return type.
13571         * target.c (normal_pid_to_str): Change return type.
13572         (default_pid_to_str): Likewise.
13573         (target_pid_to_str): Change return type.
13574         (target_translate_tls_address): Update.
13575         (target_announce_detach): Update.
13576         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13577         return type.
13578         (bsd_uthread_target::pid_to_str): Change return type.
13579         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13580         type.
13581         (bsd_kvm_target::pid_to_str): Change return type.
13582         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13583         return type.
13584         (aix_thread_target::pid_to_str): Change return type.
13585         * target.h (struct target_ops) <pid_to_str>: Change return type.
13586         (target_pid_to_str, normal_pid_to_str): Likewise.
13587         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13588         type.
13589         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13590         type.
13591         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13592         return type.
13593         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13594         type.
13595         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13596         type.
13597         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13598         return type.
13599
13600 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
13601
13602         * NEWS: Mention that the new default MI version is 3.  Mention
13603         changes to the output of commands and events that deal with
13604         multi-location breakpoints.
13605         * breakpoint.c: Include "mi/mi-out.h".
13606         (print_one_breakpoint): Change output syntax if using MI version
13607         >= 3.
13608         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13609         New.
13610         (mi_multi_location_breakpoint_output_fixed): New.
13611         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13612         (mi_cmd_fix_multi_location_breakpoint_output): New.
13613         (mi_multi_location_breakpoint_output_fixed): New.
13614         * mi/mi-cmds.c (mi_cmds): Register command
13615         -fix-multi-location-breakpoint-output.
13616         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13617         interpreter "mi".
13618
13619 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
13620
13621         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13622         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13623         instantiate mi_ui_out based on interpreter name.
13624         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13625         * mi/mi-main.c (mi_load_progress): Likewise.
13626
13627 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13628
13629         * NEWS: Combine separate "New targets" sections for 8.3.
13630
13631 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13632
13633         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13634         (ppcfbsd_init_abi): Install gdbarch
13635         "fetch_tls_load_module_address" and "get_thread_local_address"
13636         methods.
13637
13638 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13639
13640         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13641         (riscv_fbsd_init_abi): Install gdbarch
13642         "fetch_tls_load_module_address" and "get_thread_local_address"
13643         methods.
13644
13645 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13646
13647         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13648         (i386fbsd_init_abi): Install gdbarch
13649         "fetch_tls_load_module_address" and "get_thread_local_address"
13650         methods.
13651
13652 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13653
13654         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13655         (amd64fbsd_init_abi): Install gdbarch
13656         "fetch_tls_load_module_address" and "get_thread_local_address"
13657         methods.
13658
13659 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13660
13661         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13662         (struct fbsd_pspace_data): New type.
13663         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13664         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13665         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13666         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13667         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13668
13669 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13670
13671         * gdbtypes.c (lookup_struct_elt): New function.
13672         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13673         * gdbtypes.h (struct struct_elt): New type.
13674         (lookup_struct_elt): New prototype.
13675
13676 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13677
13678         * gdbtypes.c (lookup_struct_elt_type): Update comment and
13679         remove disabled code block.
13680
13681 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13682
13683         * gdbarch.sh (get_thread_local_address): New method.
13684         * gdbarch.h, gdbarch.c: Regenerate.
13685         * target.c (target_translate_tls_address): Use
13686         gdbarch_get_thread_local_address if present instead of
13687         target::get_thread_local_address.
13688
13689 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13690
13691         * target.h (target::get_thread_local_address): Update comment.
13692
13693 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13694
13695         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13696         objfile->separate_debug_objfile_backlink if not NULL.
13697
13698 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13699
13700         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13701         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13702         (amd64bsd_store_inferior_registers): Likewise.
13703         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13704         Enable segment base registers.
13705         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13706         PT_GETFSBASE and PT_GETGSBASE.
13707         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13708         PT_SETGSBASE.
13709         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13710         segment base registers.
13711         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13712
13713 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13714
13715         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13716         Update calls to i386_target_description to add 'segments'
13717         parameter.
13718         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
13719         add segment base registers.
13720         * arch/i386.c (i386_create_target_description): Add 'segments'
13721         parameter to enable segment base registers.
13722         * arch/i386.h (i386_create_target_description): Likewise.
13723         * features/i386/32bit-segments.xml: New file.
13724         * features/i386/32bit-segments.c: Generate.
13725         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13726         call to i386_target_description to add 'segments' parameter.
13727         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13728         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13729         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13730         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13731         if feature is present.
13732         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13733         Add 'segments' parameter to call to i386_target_description.
13734         (i386_target_description): Add 'segments' parameter to enable
13735         segment base registers.
13736         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13737         to call to i386_target_description.
13738         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13739         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13740         Define I386_NUM_REGS.
13741         (i386_target_description): Add 'segments' parameter to enable
13742         segment base registers.
13743
13744 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
13745
13746         PR/24325
13747         * source-cache.c: #undef open and close, to avoid unresolved
13748         externals during linking.
13749
13750 2019-03-12  Tom Tromey  <tromey@adacore.com>
13751
13752         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13753         const.  Add initializers.
13754         (_initialize_remote): Don't initialize ptid globals.
13755
13756 2019-03-12  Pedro Alves  <palves@redhat.com>
13757
13758         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13759
13760 2019-03-12  Pedro Alves  <palves@redhat.com>
13761
13762         * cp-name-parser.y (main): Remove unused 'len' variable.
13763
13764 2019-03-12  Tom Tromey  <tromey@adacore.com>
13765
13766         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13767         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13768
13769 2019-03-12  Tom Tromey  <tromey@adacore.com>
13770
13771         * linux-nat.c (iterate_over_lwps): Update.
13772         (stop_callback): Remove parameter.
13773         (stop_wait_callback, detach_callback, resume_set_callback)
13774         (select_singlestep_lwp_callback, set_ignore_sigint)
13775         (status_callback, resumed_callback, resume_clear_callback)
13776         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13777         data parameter.
13778         (linux_nat_target::detach, linux_nat_target::resume)
13779         (linux_stop_and_wait_all_lwps, select_event_lwp)
13780         (linux_nat_filter_event, linux_nat_wait_1)
13781         (linux_nat_target::kill, linux_nat_target::stop)
13782         (linux_nat_target::stop): Update.
13783         (linux_nat_resume_callback): Change type.
13784         (resume_stopped_resumed_lwps, count_events_callback)
13785         (select_event_lwp_callback): Likewise.
13786         (linux_stop_lwp, linux_nat_stop_lwp): Update.
13787         * arm-linux-nat.c (struct update_registers_data): Remove.
13788         (update_registers_callback): Change type.
13789         (arm_linux_insert_hw_breakpoint1): Update.
13790         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13791         parameter.
13792         (x86_linux_dr_set_addr): Update.
13793         (x86_linux_dr_set_control): Update.
13794         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13795         (iterate_over_lwps): Use gdb::function_view.
13796         * nat/aarch64-linux-hw-point.c (struct
13797         aarch64_dr_update_callback_param): Remove.
13798         (debug_reg_change_callback): Change type.
13799         (aarch64_notify_debug_reg_change): Update.
13800         * s390-linux-nat.c (s390_refresh_per_info): Update.
13801
13802 2019-03-11  Tom Tromey  <tromey@adacore.com>
13803
13804         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13805         redundant assignment to "this_cu".
13806
13807 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13808
13809         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13810
13811 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13812
13813         * gdbtypes.c (rank_one_type_parm_set): New function extracted
13814         from...
13815         (rank_one_type): ... this.
13816
13817 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13818
13819         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13820         from...
13821         (rank_one_type): ... this.
13822
13823 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13824
13825         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13826         from...
13827         (rank_one_type): ... this.
13828
13829 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13830
13831         * gdbtypes.c (rank_one_type_parm_float): New function extracted
13832         from...
13833         (rank_one_type): ... this.
13834
13835 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13836
13837         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13838         from...
13839         (rank_one_type): ... this.
13840
13841 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13842
13843         * gdbtypes.c (rank_one_type_parm_range): New function extracted
13844         from...
13845         (rank_one_type): ... this.
13846
13847 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13848
13849         * gdbtypes.c (rank_one_type_parm_char): New function extracted
13850         from...
13851         (rank_one_type): ... this.
13852
13853 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13854
13855         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13856         from...
13857         (rank_one_type): ... this.
13858
13859 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13860
13861         * gdbtypes.c (rank_one_type_parm_int): New function extracted
13862         from...
13863         (rank_one_type): ... this.
13864
13865 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13866
13867         * gdbtypes.c (rank_one_type_parm_func): New function extracted
13868         from...
13869         (rank_one_type): ... this.
13870
13871 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13872
13873         * gdbtypes.c (rank_one_type_parm_array): New function extracted
13874         from...
13875         (rank_one_type): ... this.
13876
13877 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13878
13879         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13880         from...
13881         (rank_one_type): ... this.
13882
13883 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13884
13885         * inferior.c (initialize_inferiors): Ensure 'help set/show print
13886         inferior-events' shows the example events.
13887
13888 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
13889
13890         Support styling on native MS-Windows console
13891
13892         PR/24315
13893         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13894         on MS-Windows if $TERM is not defined.
13895
13896         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13897
13898         * posix-hdep.c (gdb_console_fputs):
13899         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13900         functions.
13901         * ui-file.h (gdb_console_fputs): Add prototype.
13902
13903         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13904         back to fputs only if the former returns zero.
13905
13906 2019-03-07  Tom Tromey  <tom@tromey.com>
13907
13908         * symmisc.c (print_symbol_bcache_statistics): Update.
13909         (print_objfile_statistics): Update.
13910         * symfile.c (allocate_symtab): Update.
13911         * stabsread.c: Don't include bcache.h.
13912         * psymtab.h (struct psymbol_bcache): Don't declare.
13913         (class psymtab_storage) <psymbol_cache>: Now a bcache.
13914         (psymbol_bcache_init, psymbol_bcache_free)
13915         (psymbol_bcache_get_bcache): Don't declare.
13916         * psymtab.c (struct psymbol_bcache): Remove.
13917         (psymtab_storage::psymtab_storage): Update.
13918         (psymtab_storage::~psymtab_storage): Update.
13919         (psymbol_bcache_init, psymbol_bcache_free)
13920         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13921         (add_psymbol_to_bcache): Update.
13922         (allocate_psymtab): Update.
13923         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13924         macro_cache>: No longer pointers.
13925         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13926         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13927         * macrotab.c (macro_bcache): Update.
13928         * macroexp.c: Don't include bcache.h.
13929         * gdbtypes.c (check_types_worklist): Update.
13930         (types_deeply_equal): Remove TRY/CATCH.  Update.
13931         * elfread.c (elf_symtab_read): Update.
13932         * dwarf2read.c: Don't include bcache.h.
13933         * buildsym.c (buildsym_compunit::get_macro_table): Update.
13934         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13935         (print_bcache_statistics, bcache_memory_used): Don't declare.
13936         (struct bcache): Move from bcache.c.  Add constructor, destructor,
13937         methods.  Rename all data members.
13938         * bcache.c (struct bcache): Move to bcache.h.
13939         (bcache::expand_hash_table): Rename from expand_hash_table.
13940         (bcache): Remove.
13941         (bcache::insert): Rename from bcache_full.
13942         (bcache::compare): Rename from bcache_compare.
13943         (bcache_xmalloc): Remove.
13944         (bcache::~bcache): Rename from bcache_xfree.
13945         (bcache::print_statistics): Rename from print_bcache_statistics.
13946         (bcache::memory_used): Rename from bcache_memory_used.
13947
13948 2019-03-07  Pedro Alves  <palves@redhat.com>
13949
13950         * infrun.c (normal_stop): Also check for
13951         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13952
13953 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
13954
13955         * f-lang.c (value_from_host_double): Moved to...
13956         * value.c (value_from_host_double): ...here.
13957         * value.h (value_from_host_double): Declare.
13958         * guile/scm-math.c (vlscm_convert_typed_number): Use
13959         value_from_host_double.
13960         (vlscm_convert_number): Likewise.
13961         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13962         * python/py-value.c (convert_value_from_python): Likewise.
13963
13964 2019-03-06  Tom Tromey  <tom@tromey.com>
13965
13966         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13967
13968 2019-03-06  Tom Tromey  <tom@tromey.com>
13969
13970         * utils.h (free_current_contents): Don't declare.
13971         * utils.c (free_current_contents): Remove.
13972
13973 2019-03-06  Tom Tromey  <tom@tromey.com>
13974
13975         * top.c (quit_force): Update.
13976         * main.c (captured_command_loop): Update.
13977         * common/new-op.c (operator new): Update.
13978         * common/common-exceptions.c (struct catcher)
13979         <save_cleanup_chain>: Remove member.
13980         (exceptions_state_mc_init): Update.
13981         (exception_try_scope_entry): Return nullptr.
13982         (exception_try_scope_exit, exception_rethrow)
13983         (throw_exception_sjlj, throw_exception_cxx): Update.
13984         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13985         (all_cleanups, do_cleanups, discard_cleanups)
13986         (discard_final_cleanups, save_cleanups, save_final_cleanups)
13987         (restore_cleanups, restore_final_cleanups): Don't declare.
13988         (do_final_cleanups): Remove parameter.
13989         * common/cleanups.c (cleanup_chain, make_cleanup)
13990         (make_cleanup_dtor, all_cleanups, do_cleanups)
13991         (discard_my_cleanups, discard_cleanups)
13992         (discard_final_cleanups, save_my_cleanups, save_cleanups)
13993         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13994         (null_cleanup): Remove.
13995         (do_final_cleanups): Remove parameter.
13996
13997 2019-03-06  Tom Tromey  <tom@tromey.com>
13998
13999         * remote.c (remote_target::remote_parse_stop_reply): Use
14000         unique_xmalloc_ptr.
14001
14002 2019-03-06  Tom Tromey  <tom@tromey.com>
14003
14004         * stabsread.c (struct stabs_field_info): Rename from field_info.
14005         <list, fnlist>: Add initializers.
14006         <obstack>: New member.
14007         (read_member_functions, read_struct_fields, read_baseclasses):
14008         Allocate on obstack.  Don't use cleanups.
14009         (read_one_struct_field, read_member_functions, read_struct_fields)
14010         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14011         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14012         (read_struct_type): Update.
14013
14014 2019-03-06  Tom Tromey  <tom@tromey.com>
14015
14016         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14017         * common/filestuff.h (make_cleanup_close): Don't declare.
14018         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14019         Remove.
14020
14021 2019-03-06  Tom Tromey  <tom@tromey.com>
14022
14023         * solib-aix.c: Use make_scope_exit.
14024
14025 2019-03-06  Tom Tromey  <tom@tromey.com>
14026
14027         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14028         Use make_scope_exit.
14029
14030 2019-03-06  Tom Tromey  <tom@tromey.com>
14031
14032         * solib-svr4.c (disable_probes_interface): Remove parameter.
14033         (svr4_handle_solib_event): Use make_scope_exit.
14034
14035 2019-03-06  Tom Tromey  <tom@tromey.com>
14036
14037         * remote.c (struct stop_reply_deleter): Remove.
14038         (stop_reply_up): Update.
14039         (struct stop_reply): Derive from notif_event.  Don't typedef.
14040         <regcache>: Now a std::vector.
14041         (stop_reply_xfree): Remove.
14042         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14043         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
14044         (remote_target::discard_pending_stop_replies): Use delete.
14045         (remote_target::remote_parse_stop_reply): Update.
14046         (remote_target::process_stop_reply): Update.
14047         * remote-notif.h (struct notif_event): Add virtual destructor.
14048         Remove "dtr" member.
14049         (struct notif_client) <alloc_event>: Return a unique_ptr.
14050         (notif_event_xfree): Don't declare.
14051         (notif_event_up): New typedef.
14052         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14053         (notif_event_xfree, do_notif_event_xfree): Remove.
14054         (remote_notif_state_xfree): Update.
14055
14056 2019-03-06  Tom Tromey  <tom@tromey.com>
14057
14058         * infrun.c (displaced_step_clear_cleanup): Now a
14059         forward_scope_exit type.
14060         (displaced_step_prepare_throw): Update.
14061         (displaced_step_fixup): Update.
14062
14063 2019-03-06  Tom Tromey  <tom@tromey.com>
14064
14065         * inferior.h (class inferior): Update comment.
14066         * gdbthread.h (class thread_info): Update comment.
14067
14068 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
14069             Tom Tromey  <tom@tromey.com>
14070
14071         * stabsread.h (struct stab_section_list): Remove.
14072         (coffstab_build_psymtabs): Update.
14073         * dbxread.c (symbuf_sections): Now a std::vector.
14074         (sect_idx): New global.
14075         (fill_symbuf): Update.
14076         (coffstab_build_psymtabs): Change type of stabsects parameter.
14077         Update.
14078         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14079         std::vector.
14080         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14081         (coff_locate_sections): Update.
14082         (coff_symfile_read): Remove cleanups.  Update.
14083         (init_stringtab): Add storage parameter.
14084         (free_stringtab, free_stringtab_cleanup): Remove.
14085         (init_lineno): Add storage parameter.
14086         (free_linetab, free_linetab_cleanup): Remove.
14087
14088 2019-03-06  Pedro Alves  <palves@redhat.com>
14089
14090         * linux-fork.c (fork_info::clobber_regs): Delete.
14091         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14092         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
14093         comment.  Adjust.
14094         (scoped_switch_fork_info::scoped_switch_fork_info)
14095         (checkpoint_command, linux_fork_context): Adjust
14096         fork_save_infrun_state calls.
14097
14098 2019-03-06  Pedro Alves  <palves@redhat.com>
14099
14100         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14101         (inf_has_multiple_threads): Return 'bool' and rewrite using
14102         inferior_info::threads().
14103
14104 2019-03-06  Pedro Alves  <palves@redhat.com>
14105
14106         * linux-fork.c: Include <list>.
14107         (fork_list): Now a std::list instance.
14108         (fork_info): Add ctor, dtor, and in-class initialize all fields.
14109         (forks_exist_p, find_last_fork): Adjust.
14110         (new_fork): Delete.
14111         (one_fork_p): New.
14112         (add_fork): Adjust.
14113         (free_fork): Delete, folded into fork_info::~fork_info().
14114         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14115         Adjust.
14116         (init_fork_list): Delete.
14117         (linux_fork_killall, linux_fork_mourn_inferior)
14118         (linux_fork_detach, info_checkpoints_command): Adjust.
14119         (_initialize_linux_fork): No longer call init_fork_list.
14120
14121 2019-03-06  Pedro Alves  <palves@redhat.com>
14122
14123         * linux-fork.c (new_fork): New, split out of ...
14124         (add_fork): ... this.  Return void.  Move "first fork" special
14125         case from here, to ...
14126         (checkpoint_command): ... here.
14127         * linux-linux.h (add_fork): Return void.
14128
14129 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14130
14131         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14132
14133 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14134             Chris January  <chris.january@arm.com>
14135             David Lecomber  <david.lecomber@arm.com>
14136
14137         * f-exp.y: New token, UNOP_INTRINSIC.
14138         (exp): New pattern using UNOP_INTRINSIC token.
14139         (f77_keywords): Add 'abs' keyword.
14140         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14141         (value_from_host_double): New function.
14142         (evaluate_subexp_f): Support UNOP_ABS.
14143
14144 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14145
14146         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14147         types.
14148
14149 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14150
14151         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14152         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14153         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14154
14155 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14156
14157         * f-exp.y (convert_to_kind_type): Handle more type kinds.
14158
14159 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14160             Chris January  <chris.january@arm.com>
14161
14162         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14163         * f-exp.y: Define 'KIND' token.
14164         (exp): New pattern for KIND expressions.
14165         (ptype): Handle types with a kind extension.
14166         (direct_abs_decl): Extend to spot kind extensions.
14167         (f77_keywords): Add 'kind' to the list.
14168         (push_kind_type): New function.
14169         (convert_to_kind_type): New function.
14170         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14171         * parse.c (operator_length_standard): Likewise.
14172         * parser-defs.h (enum type_pieces): Add tp_kind.
14173         * std-operator.def: Add UNOP_KIND.
14174
14175 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14176
14177         * f-exp.y (f_parse): Set yydebug.
14178
14179 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14180
14181         * f-lang.c (evaluate_subexp_f): New function.
14182         (exp_descriptor_f): New global.
14183         (f_language_defn): Use exp_descriptor_f instead of
14184         exp_descriptor_standard.
14185
14186 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14187
14188         * f-exp.y (struct token): Add comments.
14189         (dot_ops): Remove uppercase versions and the end marker.
14190         (f77_keywords): Likewise.
14191         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14192         entries in the dot_ops array are case insensitive, and use
14193         strncasecmp to compare strings.  Also some whitespace cleanup in
14194         this area.  Similar for the f77_keywords array, except entries in
14195         this list might be case sensitive.
14196
14197 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14198
14199         * f-exp.y (struct f77_boolean_val): Add comments.
14200         (boolean_values): Remove uppercase versions, and end marker.
14201         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14202         and use strncasecmp to achieve case insensitivity.  Additionally,
14203         perform whitespace cleanup around this code.
14204
14205 2019-03-06  Tom Tromey  <tromey@adacore.com>
14206
14207         * remote-sim.c (gdbsim_target_open): Use result of
14208         gdb_argv::release.
14209
14210 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
14211         Dirk Schubert  <dirk.schubert@arm.com>
14212         Chris January  <chris.january@arm.com>
14213
14214         * eval.c (evaluate_subexp_standard): Call Fortran argument
14215         wrapping logic.
14216         * f-lang.c (struct value): A value which can be passed into a
14217         Fortran function call.
14218         (fortran_argument_convert): Wrap Fortran arguments in a pointer
14219         where appropriate.
14220         (struct type): Value ready for a Fortran function call.
14221         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14222         is needed.
14223         * f-lang.h (fortran_argument_convert): Declaration.
14224         (fortran_preserve_arg_pointer): Declaration.
14225         * infcall.c (value_arg_coerce): Call Fortran argument logic.
14226
14227 2019-03-05  Tom Tromey  <tromey@adacore.com>
14228
14229         * python/py-prettyprint.c (print_string_repr): Remove #if.
14230         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14231
14232 2019-03-05  Tom Tromey  <tromey@adacore.com>
14233
14234         * target.c (the_dummy_target): Move later.  Change type to
14235         "dummy_target".
14236         (initialize_targets): Don't initialize the_dummy_target.
14237
14238 2019-03-05  Tom Tromey  <tromey@adacore.com>
14239
14240         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14241         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14242
14243 2019-03-05  Tom Tromey  <tromey@adacore.com>
14244
14245         * windows-nat.c (windows_nat_target::attach)
14246         (windows_nat_target::detach): Don't call gdb_flush.
14247         * valprint.c (generic_val_print, val_print, val_print_string):
14248         Don't call gdb_flush.
14249         * utils.c (defaulted_query): Don't call gdb_flush.
14250         * typeprint.c (print_type_scalar): Don't call gdb_flush.
14251         * target.c (target_announce_detach): Don't call gdb_flush.
14252         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14253         * remote.c (extended_remote_target::attach): Don't call
14254         gdb_flush.
14255         * procfs.c (procfs_target::detach): Don't call gdb_flush.
14256         * printcmd.c (do_examine): Don't call gdb_flush.
14257         (info_display_command): Don't call gdb_flush.
14258         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14259         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14260         * memattr.c (info_mem_command): Don't call gdb_flush.
14261         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14262         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14263         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14264         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14265         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14266         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14267         (gnu_nat_target::detach): Don't call gdb_flush.
14268         * f-valprint.c (f_val_print): Don't call gdb_flush.
14269         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14270         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14271         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14272         gdb_flush.
14273         * c-valprint.c (c_val_print): Don't call gdb_flush.
14274         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14275
14276 2019-03-05  Tom Tromey  <tromey@adacore.com>
14277
14278         * varobj.c (update_dynamic_varobj_children): Update.
14279         (install_default_visualizer): Use reset, not release.
14280         * value.c (set_internalvar): Update.
14281         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14282         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14283         ATTRIBUTE_UNUSED_RESULT.
14284
14285 2019-03-05  Tom Tromey  <tromey@adacore.com>
14286
14287         * remote.c (class scoped_remote_fd) <release>: Add
14288         ATTRIBUTE_UNUSED_RESULT.
14289
14290 2019-03-05  Tom Tromey  <tromey@adacore.com>
14291
14292         * macroexp.c (struct macro_buffer) <release>: Add
14293         ATTRIBUTE_UNUSED_RESULT.
14294
14295 2019-03-05  Tom Tromey  <tromey@adacore.com>
14296
14297         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14298         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14299         ATTRIBUTE_UNUSED_RESULT.
14300
14301 2019-03-05  Tom Tromey  <tromey@adacore.com>
14302
14303         * common/scoped_fd.h (class scoped_fd) <release>: Add
14304         ATTRIBUTE_UNUSED_RESULT.
14305
14306 2019-03-05  Tom Tromey  <tromey@adacore.com>
14307
14308         * parser-defs.h (struct parser_state) <release>: Add
14309         ATTRIBUTE_UNUSED_RESULT.
14310
14311 2019-03-05  Tom Tromey  <tromey@adacore.com>
14312
14313         * utils.h (class gdb_argv) <release>: Add
14314         ATTRIBUTE_UNUSED_RESULT.
14315         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14316
14317 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
14318
14319         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14320         for-loop range, to avoid compiler warnings.
14321
14322         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14323         avoid compiler warnings about unused variables.
14324
14325         * NEWS: Mention end of support for native debugging on MS-Windows
14326         before XP.
14327
14328         PR gdb/24292
14329         * common/netstuff.c:
14330         * gdbserver/gdbreplay.c
14331         * gdbserver/remote-utils.c:
14332         * ser-tcp.c:
14333         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14334         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
14335         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14336         'getaddrinfo' and 'freeaddrinfo' were not available before
14337         Windows XP, and mingw.org's MinGW headers by default define
14338         _WIN32_WINNT to 0x500.
14339
14340 2019-03-01  Gary Benson <gbenson@redhat.com>
14341
14342         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14343
14344 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
14345             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
14346
14347         PR gdb/8527
14348         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14349         set_sigint_trap, clear_sigint_trap.
14350
14351 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14352
14353         * target.c (target_detach): Clear the regcache and the
14354         frame cache.
14355
14356 2019-02-27  Pedro Alves  <palves@redhat.com>
14357
14358         * utils.c (set_screen_size): When we cap the height/width sizes,
14359         tweak the corresponding command variable to show "unlimited":
14360
14361 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
14362             Pedro Alves  <palves@redhat.com>
14363
14364         * utils.c (set_screen_size): Reduce "infinite" rows and columns
14365         before calling rl_set_screen_size.
14366
14367 2019-02-27  Tom Tromey  <tromey@adacore.com>
14368
14369         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14370         define.
14371         * python/py-value.c: Remove Python 2.4 workaround.
14372         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14373         workaround.
14374         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14375         Python 2.4 workaround.
14376         * python/python-internal.h: Remove Python 2.4 comment.
14377         (Py_ssize_t): Don't define.
14378         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14379         (gdb_Py_DECREF): Remove Python 2.4 workaround.
14380         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14381         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14382         * python/python.c (do_start_initialization): Remove Python 2.4
14383         workaround.
14384         * python/py-prettyprint.c (class dummy_python_frame): Remove.
14385         (print_children): Remove Python 2.4 workaround.
14386         * python/py-inferior.c (buffer_procs): Remove Python 2.4
14387         workaround.
14388         (CHARBUFFERPROC_NAME): Remove.
14389         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14390         Python 2.4 workaround.
14391
14392 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14393
14394         * NEWS: Note minimum Python version.
14395
14396 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14397
14398         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14399         code from these functions.  Remove corresponding ifdefs.  Use
14400         Py_buffer_up instead of explicit calls to PyBuffer_Release.
14401         Remove gotos and target of gotos.
14402         (infpy_search_memory): Likewise.
14403
14404 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14405
14406         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14407         (hppa_gdbarch_init): Don't register deleted functions with
14408         gdbarch.
14409
14410 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14411
14412         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14413         (h8300_unwind_sp): Delete.
14414         (h8300_dummy_id): Delete.
14415         (h8300_gdbarch_init): Don't register deleted functions with
14416         gdbarch.
14417
14418 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14419
14420         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14421         (ft32_unwind_pc): Delete.
14422         (ft32_unwind_sp): Delete.
14423         (ft32_gdbarch_init): Don't register deleted functions with
14424         gdbarch.
14425
14426 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14427
14428         * gdb/frv-tdep.c (frv_dummy_id): Delete.
14429         (frv_unwind_pc): Delete.
14430         (frv_unwind_sp): Delete.
14431         (frv_gdbarch_init): Don't register deleted functions with
14432         gdbarch.
14433
14434 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14435
14436         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14437         (riscv_unwind_pc): Delete.
14438         (riscv_unwind_sp): Delete.
14439         (riscv_gdbarch_init): Don't register deleted functions with
14440         gdbarch.
14441
14442 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14443
14444         * gdb/csky-tdep.c (csky_dummy_id): Delete.
14445         (csky_unwind_pc): Delete.
14446         (csky_unwind_sp): Delete.
14447         (csky_gdbarch_init): Don't register deleted functions with
14448         gdbarch.
14449
14450 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14451
14452         * gdb/cris-tdep.c (cris_dummy_id): Delete.
14453         (cris_unwind_pc): Delete.
14454         (cris_unwind_sp): Delete.
14455         (cris_gdbarch_init): Don't register deleted functions with
14456         gdbarch.
14457
14458 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14459
14460         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14461         (bfin_unwind_pc): Delete.
14462         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14463
14464 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14465
14466         * gdb/arm-tdep.c (arm_dummy_id): Delete.
14467         (arm_unwind_pc): Delete.
14468         (arm_unwind_sp): Delete.
14469         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14470
14471 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14472
14473         * gdb/arc-tdep.c (arc_dummy_id): Delete.
14474         (arc_unwind_pc): Delete.
14475         (arc_unwind_sp): Delete.
14476         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14477
14478 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14479
14480         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14481         (alpha_unwind_pc): Delete.
14482         (alpha_gdbarch_init): Don't register deleted functions with
14483         gdbarch.
14484
14485 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14486
14487         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14488         (aarch64_unwind_pc): Delete.
14489         (aarch64_unwind_sp): Delete.
14490         (aarch64_gdbarch_init): Don't register deleted functions with
14491         gdbarch.
14492
14493 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14494
14495         * gdbtypes.c (type_align): Don't consider static members when
14496         computing structure alignment.
14497
14498 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14499
14500         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14501         return 0 for other types.
14502         * arch-utils.c (default_type_align): Always return 0.
14503         * gdbarch.h: Regenerate.
14504         * gdbarch.sh (type_align): Extend comment.
14505         * gdbtypes.c (type_align): Add additional comments, always call
14506         gdbarch_type_align before applying the default rules.
14507         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14508         generic code will then apply a suitable default.
14509         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14510         types, return 0 for other types.
14511
14512 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14513
14514         * NEWS: Create a new section for the next release branch.
14515         Rename the section of the current branch, now that it has
14516         been cut.
14517
14518 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14519
14520         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14521         * version.in: Bump version to 8.3.50.DATE-git.
14522
14523 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
14524
14525         * aix-thread.c (ptid_cmp): Remove unused variable.
14526         (get_signaled_thread): Likewise.
14527         (store_regs_user_thread): Likewise.
14528         (store_regs_kernel_thread): Likewise.
14529         (fetch_regs_kernel_thread): Remove shadowed variable.
14530
14531 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
14532
14533         * features/riscv/32bit-cpu.xml: Add register numbers.
14534         * features/riscv/32bit-fpu.c: Regenerate.
14535         * features/riscv/32bit-fpu.xml: Add register numbers.
14536         * features/riscv/64bit-cpu.xml: Add register numbers.
14537         * features/riscv/64bit-fpu.c: Regenerate.
14538         * features/riscv/64bit-fpu.xml: Add register numbers.
14539
14540 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
14541
14542         * NEWS: Mention two argument form of gdb.Value constructor.
14543         * python/py-value.c (convert_buffer_and_type_to_value): New
14544         function.
14545         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14546         Add support for handling an optional second argument.  Call
14547         convert_buffer_and_type_to_value as appropriate.
14548         * python/python-internal.h (Py_buffer_deleter): New struct.
14549         (Py_buffer_up): New typedef.
14550
14551 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
14552
14553         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14554         instead of releasing ownership.
14555
14556 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
14557
14558         * dwarf2read.c (open_and_init_dwp_file): Call
14559         elf_numsections instead of bfd_count_sections to initialize
14560         dwp_file->num_sections.
14561
14562 2019-02-25  Tom Tromey  <tromey@adacore.com>
14563
14564         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14565
14566 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
14567
14568         * gcore.in: Add '--readnever' option when invoking GDB.
14569
14570 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14571
14572         * MAINTAINERS: Update my email address.
14573
14574 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14575
14576         * build-id.c (build_id_to_debug_bfd_1): New function.
14577         (build_id_to_debug_bfd): Look for separate debug file in
14578         sysroot.
14579
14580 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
14581
14582         * gdbarch.sh: Update the copyright year range that is placed into
14583         generated files.
14584
14585 2019-02-22  Keith Seitz  <keiths@redhat.com>
14586
14587         PR symtab/23853
14588         * linespec.c (create_sals_line_offset): Search for the default
14589         symtab's filename instead of its fullname.
14590
14591 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14592
14593         * NEWS: Update style defaults.
14594
14595 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14596
14597         * main.c (captured_main_1): Disable styling in batch mode.
14598
14599 2019-02-20  Tom Tromey  <tom@tromey.com>
14600
14601         * symtab.c (symtab_symbol_info): Fix typos.
14602
14603 2019-02-20  Tom Tromey  <tromey@adacore.com>
14604
14605         * findcmd.c (_initialize_mem_search): Use upper case for
14606         metasyntactic variables.
14607
14608 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
14609
14610         * aarch64-tdep.c (aarch64_add_reggroups): New function.
14611         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14612
14613 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
14614
14615         * top.h (source_file_name): Change to std::string.
14616         * top.c (source_file_name): Likewise.
14617         (command_line_input): Adjust.
14618         * cli/cli-script.c (script_from_file): Adjust.
14619
14620 2019-02-19  Tom Tromey  <tromey@adacore.com>
14621
14622         * ravenscar-thread.c
14623         (ravenscar_thread_target::update_thread_list): Don't call
14624         ada_build_task_list.
14625         * ada-lang.h (ada_build_task_list): Don't declare.
14626         * ada-tasks.c (struct ada_tasks_inferior_data)
14627         <task_list_valid_p>: Now bool.
14628         (read_known_tasks, ada_task_list_changed)
14629         (ada_tasks_invalidate_inferior_data): Update.
14630         (read_known_tasks_array): Return bool.
14631         (read_known_tasks_list): Likewise.
14632         (read_known_tasks): Return void.
14633         (ada_build_task_list): Now static.
14634
14635 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
14636
14637         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14638         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14639
14640 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14641
14642         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14643         variant for ada_tasks_pspace_data_handle and
14644         ada_tasks_inferior_data_handle.
14645         (ada_tasks_pspace_data_cleanup): New function.
14646         (ada_tasks_inferior_data_cleanup): New function.
14647
14648 2019-02-17  Tom Tromey  <tom@tromey.com>
14649
14650         * macrotab.h (macro_source_fullname): Return a std::string.
14651         * macrotab.c (macro_include, check_for_redefinition)
14652         (macro_undef, macro_lookup_definition, foreach_macro)
14653         (foreach_macro_in_scope): Update.
14654         (macro_source_fullname): Return a std::string.
14655         * macrocmd.c (show_pp_source_pos): Update.
14656
14657 2019-02-17  Tom Tromey  <tom@tromey.com>
14658
14659         * macrocmd.c (show_pp_source_pos): Style the file names.
14660
14661 2019-02-17  Tom Tromey  <tom@tromey.com>
14662
14663         PR tui/24197:
14664         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14665
14666 2019-02-17  Tom Tromey  <tom@tromey.com>
14667
14668         * ada-lang.c (user_select_syms): Use filtered printing.
14669         * utils.c (wrap_style): New global.
14670         (desired_style): Remove.
14671         (emit_style_escape): Add stream parameter.
14672         (set_output_style, reset_terminal_style, prompt_for_continue):
14673         Update.
14674         (flush_wrap_buffer): Only flush gdb_stdout.
14675         (wrap_here): Set wrap_style.
14676         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
14677         treat escape sequences as a character.  Change when wrap buffer is
14678         flushed.
14679         (fputs_styled): Do not set the output style when the default is
14680         requested.
14681         * ui-style.h (struct ui_file_style) <is_default>: New method.
14682         * source.c (print_source_lines_base): Emit escape sequences in one
14683         piece.
14684
14685 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14686
14687         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14688         integers and enumeration types.
14689
14690 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14691
14692         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14693         instead of lookup_symbol_in_language
14694         (do_exact_match): New function.
14695         (ada_get_symbol_name_matcher): Return do_exact_match when
14696         doing a verbatim match.
14697
14698 2019-02-15  Tom Tromey  <tromey@adacore.com>
14699
14700         * ravenscar-thread.c (ravenscar_thread_target::resume)
14701         (ravenscar_thread_target::wait): Special case wildcard requests.
14702
14703 2019-02-15  Tom Tromey  <tromey@adacore.com>
14704
14705         * ravenscar-thread.c (base_ptid): Remove.
14706         (struct ravenscar_thread_target) <close>: New method.
14707         <m_base_ptid>: New member.
14708         <update_inferior_ptid, active_task, task_is_currently_active,
14709         runtime_initialized>: Declare methods.
14710         <ravenscar_thread_target>: Add constructor.
14711         (ravenscar_thread_target::task_is_currently_active)
14712         (ravenscar_thread_target::update_inferior_ptid)
14713         (ravenscar_runtime_initialized): Rename.  Now methods.
14714         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14715         (ravenscar_thread_target::update_thread_list): Update.
14716         (ravenscar_thread_target::active_task): Now method.
14717         (ravenscar_thread_target::store_registers)
14718         (ravenscar_thread_target::prepare_to_store)
14719         (ravenscar_thread_target::prepare_to_store)
14720         (ravenscar_thread_target::mourn_inferior): Update.
14721         (ravenscar_inferior_created): Use "new" to create target.
14722         (ravenscar_thread_target::get_ada_task_ptid): Update.
14723         (_initialize_ravenscar): Don't initialize base_ptid.
14724         (ravenscar_ops): Remove global.
14725
14726 2019-02-15  Tom Tromey  <tromey@adacore.com>
14727
14728         * target.h (push_target): Declare new overload.
14729         * target.c (push_target): New overload, taking an rvalue reference.
14730         * remote.c (remote_target::open_1): Use push_target overload.
14731         * corelow.c (core_target_open): Use push_target overload.
14732
14733 2019-02-15  Tom Tromey  <tromey@adacore.com>
14734
14735         * ravenscar-thread.c (is_ravenscar_task)
14736         (ravenscar_task_is_currently_active): Return bool.
14737         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14738         (_initialize_ravenscar): Remove "(void)".
14739         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14740         Return bool.
14741
14742 2019-02-15  Tom Tromey  <tromey@adacore.com>
14743
14744         * ravenscar-thread.c (ravenscar_runtime_initializer)
14745         (has_ravenscar_runtime, get_running_thread_id)
14746         (ravenscar_thread_target::resume): Fix indentation.
14747
14748 2019-02-15  Tom Tromey  <tromey@adacore.com>
14749
14750         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14751         from ravenscar_arch_ops.
14752         (sparc_ravenscar_ops::fetch_registers)
14753         (sparc_ravenscar_ops::store_registers): Now methods.
14754         (sparc_ravenscar_prepare_to_store): Remove.
14755         (sparc_ravenscar_ops): Redefine.
14756         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14757         methods and destructor.  Remove members.
14758         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14759         (ravenscar_thread_target::store_registers)
14760         (ravenscar_thread_target::prepare_to_store): Update.
14761         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14762         Remove.
14763         (struct ppc_ravenscar_powerpc_ops): Derive from
14764         ravenscar_arch_ops.
14765         (ppc_ravenscar_powerpc_ops::fetch_registers)
14766         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14767         (ppc_ravenscar_powerpc_ops): Redefine.
14768         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14769         (ppc_ravenscar_e500_ops::fetch_registers)
14770         (ppc_ravenscar_e500_ops::store_registers): Now methods.
14771         (ppc_ravenscar_e500_ops): Redefine.
14772         * aarch64-ravenscar-thread.c
14773         (aarch64_ravenscar_generic_prepare_to_store): Remove.
14774         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14775         (aarch64_ravenscar_fetch_registers)
14776         (aarch64_ravenscar_store_registers): Now methods.
14777         (aarch64_ravenscar_ops): Redefine.
14778
14779 2019-02-15  Tom Tromey  <tromey@adacore.com>
14780
14781         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14782         (ravenscar_thread_target::stopped_by_hw_breakpoint)
14783         (ravenscar_thread_target::stopped_by_watchpoint)
14784         (ravenscar_thread_target::stopped_data_address)
14785         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14786
14787 2019-02-15  Tom Tromey  <tromey@adacore.com>
14788
14789         * ravenscar-thread.c: Fix some typos.
14790
14791 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14792             Tom Tromey  <tromey@adacore.com>
14793
14794         * ada-lang.c (ada_exception_sal): Change addr_string to a
14795         std::string.
14796         (create_ada_exception_catchpoint): Update.
14797
14798 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14799             Tom Tromey  <tromey@adacore.com>
14800
14801         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14802         (bp_location_ops): Remove.
14803         (base_breakpoint_allocate_location): Update.
14804         (free_bp_location): Update.
14805         * ada-lang.c (class ada_catchpoint_location)
14806         <ada_catchpoint_location>: Remove ops parameter.
14807         (ada_catchpoint_location_dtor): Remove.
14808         (ada_catchpoint_location_ops): Remove.
14809         (allocate_location_exception): Update.
14810         * breakpoint.h (struct bp_location_ops): Remove.
14811         (class bp_location) <bp_location>: Remove bp_location_ops
14812         parameter.
14813         <~bp_location>: Add destructor.
14814         <ops>: Remove.
14815
14816 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14817             Pedro Alves  <palves@redhat.com>
14818
14819         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14820         'PATH_MAX'.
14821
14822 2019-02-14  David Michael  <fedora.dm0@gmail.com>
14823             Samuel Thibault  <samuel.thibault@gnu.org>
14824             Thomas Schwinge  <thomas@codesourcery.com>
14825
14826         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14827         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14828
14829 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14830
14831         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14832         (check_empty): Use "const char *".
14833
14834         * gnu-nat.c (gnu_nat_target::detach): Instead of
14835         'detach_inferior (pid)' call
14836         'detach_inferior (find_inferior_pid (pid))'.
14837
14838         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14839         'nat/fork-inferior.o'.
14840         * gnu-nat.c: #include "nat/fork-inferior.h".
14841
14842         * gnu-nat.c (gnu_nat_target::detach): Instead of
14843         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14844         * gnu-nat.h: #include "inf-child.h".
14845         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14846         'i386_gnu_nat_target::fetch_registers'.
14847         (gnu_store_registers): Rename/move to
14848         'i386_gnu_nat_target::store_registers'.
14849
14850         * config/i386/nm-i386gnu.h: Don't "#include" any files.
14851         * gnu-nat.h (mach_thread_info): New function.
14852         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14853
14854         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14855
14856 2019-02-14  Frederic Konrad  <konrad@adacore.com>
14857
14858         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14859
14860 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
14861
14862         * windows-nat.c (windows_add_thread): Add new parameter
14863         "main_thread_p" with default value set to false.  Update
14864         function documentation as well as all callers.
14865         (windows_delete_thread): Likewise.
14866         (fake_create_process): Update call to windows_add_thread.
14867         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14868         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14869         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14870         call to windows_delete_thread.
14871
14872 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
14873
14874         * MAINTAINERS: Add Andrew Burgess as global maintainer.
14875
14876 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14877
14878         * symfile.c (find_separate_debug_file): Use canonical path of
14879         sysroot with child_path instead of gdb_sysroot if it is valid.
14880
14881 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14882
14883         * symfile.c (find_separate_debug_file): Use child_path to
14884         determine if an object file is under a sysroot.
14885
14886 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14887
14888         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14889         unittests/child-path-selftests.c.
14890         * common/pathstuff.c (child_path): New function.
14891         * common/pathstuff.h (child_path): New prototype.
14892         * unittests/child-path-selftests.c: New file.
14893
14894 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14895
14896         * symfile.c (find_separate_debug_file): Look for separate debug
14897         files in debug directories under the sysroot.
14898
14899 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14900
14901         * symtab.h (struct minimal_symbol data_p): New const method.
14902         (struct minimal_symbol text_p): Likewise.
14903         * symtab.c (output_source_filename): Use file name style
14904         to print file name.
14905         (print_symbol_info): Likewise.
14906         (print_msymbol_info): Use address style to print addresses.
14907         Use function name style to print executable text symbols.
14908         (expand_symtab_containing_pc): Use data_p.
14909         (find_pc_sect_compunit_symtab): Likewise.
14910
14911 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14912
14913         * breakpoint.c (describe_other_breakpoints): Use address style
14914         to print addresses.
14915         (say_where): Likewise.
14916
14917 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14918
14919         * ada-typeprint.c (print_func_type): Print function name
14920         style to print function name.
14921         * c-typeprint.c (c_print_type_1): Likewise.
14922
14923 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
14924
14925         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14926         for execve.
14927
14928 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14929
14930         * c-exp.y (direct_abs_decl): Use emplace_back to record the
14931         type_stack.
14932
14933 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
14934
14935         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14936         TYPE_CODE_REF types.
14937
14938 2019-02-08  Jim Wilson  <jimw@sifive.com>
14939
14940         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14941         (riscv_linux_fregset): New.
14942         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14943
14944 2019-02-07  Tom Tromey  <tom@tromey.com>
14945
14946         * thread.c (thread_cancel_execution_command): Update.
14947         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14948         methods.
14949         (struct thread_fsm_ops): Remove.
14950         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14951         (thread_fsm_should_stop, thread_fsm_return_value)
14952         (thread_fsm_set_finished, thread_fsm_finished_p)
14953         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14954         Don't declare.
14955         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14956         * infrun.c (clear_proceed_status_thread)
14957         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14958         (print_stop_event): Update.
14959         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14960         Add constructor.
14961         (step_command_fsm_ops): Remove.
14962         (new_step_command_fsm): Remove.
14963         (step_1): Update.
14964         (step_command_fsm::should_stop): Rename from
14965         step_command_fsm_should_stop.
14966         (step_command_fsm::clean_up): Rename from
14967         step_command_fsm_clean_up.
14968         (step_command_fsm::do_async_reply_reason): Rename from
14969         step_command_fsm_async_reply_reason.
14970         (struct until_next_fsm): Inherit from thread_fsm.  Add
14971         constructor.
14972         (until_next_fsm_ops): Remove.
14973         (new_until_next_fsm): Remove.
14974         (until_next_fsm::should_stop): Rename from
14975         until_next_fsm_should_stop.
14976         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14977         (until_next_fsm::do_async_reply_reason): Rename from
14978         until_next_fsm_async_reply_reason.
14979         (struct finish_command_fsm): Inherit from thread_fsm.  Add
14980         constructor.  Change type of breakpoint.
14981         (finish_command_fsm_ops): Remove.
14982         (new_finish_command_fsm): Remove.
14983         (finish_command_fsm::should_stop): Rename from
14984         finish_command_fsm_should_stop.
14985         (finish_command_fsm::clean_up): Rename from
14986         finish_command_fsm_clean_up.
14987         (finish_command_fsm::return_value): Rename from
14988         finish_command_fsm_return_value.
14989         (finish_command_fsm::do_async_reply_reason): Rename from
14990         finish_command_fsm_async_reply_reason.
14991         (finish_command): Update.
14992         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14993         Add constructor.
14994         (call_thread_fsm_ops): Remove.
14995         (call_thread_fsm::call_thread_fsm): Rename from
14996         new_call_thread_fsm.
14997         (call_thread_fsm::should_stop): Rename from
14998         call_thread_fsm_should_stop.
14999         (call_thread_fsm::should_notify_stop): Rename from
15000         call_thread_fsm_should_notify_stop.
15001         (run_inferior_call, call_function_by_hand_dummy): Update.
15002         * cli/cli-interp.c (should_print_stop_to_console): Update.
15003         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15004         Add constructor.  Change type of location_breakpoint,
15005         caller_breakpoint.
15006         (until_break_fsm_ops): Remove.
15007         (new_until_break_fsm): Remove.
15008         (until_break_fsm::should_stop): Rename from
15009         until_break_fsm_should_stop.
15010         (until_break_fsm::clean_up): Rename from
15011         until_break_fsm_clean_up.
15012         (until_break_fsm::do_async_reply_reason): Rename from
15013         until_break_fsm_async_reply_reason.
15014         (until_break_command): Update.
15015         * thread-fsm.c: Remove.
15016         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15017
15018 2019-02-07  Tom Tromey  <tom@tromey.com>
15019
15020         * yy-remap.h: Add include guard.
15021         * xtensa-tdep.h: Add include guard.
15022         * xcoffread.h: Rename include guard.
15023         * varobj-iter.h: Add include guard.
15024         * tui/tui.h: Rename include guard.
15025         * tui/tui-winsource.h: Rename include guard.
15026         * tui/tui-wingeneral.h: Rename include guard.
15027         * tui/tui-windata.h: Rename include guard.
15028         * tui/tui-win.h: Rename include guard.
15029         * tui/tui-stack.h: Rename include guard.
15030         * tui/tui-source.h: Rename include guard.
15031         * tui/tui-regs.h: Rename include guard.
15032         * tui/tui-out.h: Rename include guard.
15033         * tui/tui-layout.h: Rename include guard.
15034         * tui/tui-io.h: Rename include guard.
15035         * tui/tui-hooks.h: Rename include guard.
15036         * tui/tui-file.h: Rename include guard.
15037         * tui/tui-disasm.h: Rename include guard.
15038         * tui/tui-data.h: Rename include guard.
15039         * tui/tui-command.h: Rename include guard.
15040         * tic6x-tdep.h: Add include guard.
15041         * target/waitstatus.h: Rename include guard.
15042         * target/wait.h: Rename include guard.
15043         * target/target.h: Rename include guard.
15044         * target/resume.h: Rename include guard.
15045         * target-float.h: Rename include guard.
15046         * stabsread.h: Add include guard.
15047         * rs6000-tdep.h: Add include guard.
15048         * riscv-fbsd-tdep.h: Add include guard.
15049         * regformats/regdef.h: Rename include guard.
15050         * record.h: Rename include guard.
15051         * python/python.h: Rename include guard.
15052         * python/python-internal.h: Rename include guard.
15053         * python/py-stopevent.h: Rename include guard.
15054         * python/py-ref.h: Rename include guard.
15055         * python/py-record.h: Rename include guard.
15056         * python/py-record-full.h: Rename include guard.
15057         * python/py-record-btrace.h: Rename include guard.
15058         * python/py-instruction.h: Rename include guard.
15059         * python/py-events.h: Rename include guard.
15060         * python/py-event.h: Rename include guard.
15061         * procfs.h: Add include guard.
15062         * proc-utils.h: Add include guard.
15063         * p-lang.h: Add include guard.
15064         * or1k-tdep.h: Rename include guard.
15065         * observable.h: Rename include guard.
15066         * nto-tdep.h: Rename include guard.
15067         * nat/x86-linux.h: Rename include guard.
15068         * nat/x86-linux-dregs.h: Rename include guard.
15069         * nat/x86-gcc-cpuid.h: Add include guard.
15070         * nat/x86-dregs.h: Rename include guard.
15071         * nat/x86-cpuid.h: Rename include guard.
15072         * nat/ppc-linux.h: Rename include guard.
15073         * nat/mips-linux-watch.h: Rename include guard.
15074         * nat/linux-waitpid.h: Rename include guard.
15075         * nat/linux-ptrace.h: Rename include guard.
15076         * nat/linux-procfs.h: Rename include guard.
15077         * nat/linux-osdata.h: Rename include guard.
15078         * nat/linux-nat.h: Rename include guard.
15079         * nat/linux-namespaces.h: Rename include guard.
15080         * nat/linux-btrace.h: Rename include guard.
15081         * nat/glibc_thread_db.h: Rename include guard.
15082         * nat/gdb_thread_db.h: Rename include guard.
15083         * nat/gdb_ptrace.h: Rename include guard.
15084         * nat/fork-inferior.h: Rename include guard.
15085         * nat/amd64-linux-siginfo.h: Rename include guard.
15086         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15087         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15088         * nat/aarch64-linux.h: Rename include guard.
15089         * nat/aarch64-linux-hw-point.h: Rename include guard.
15090         * mn10300-tdep.h: Add include guard.
15091         * mips-linux-tdep.h: Add include guard.
15092         * mi/mi-parse.h: Rename include guard.
15093         * mi/mi-out.h: Rename include guard.
15094         * mi/mi-main.h: Rename include guard.
15095         * mi/mi-interp.h: Rename include guard.
15096         * mi/mi-getopt.h: Rename include guard.
15097         * mi/mi-console.h: Rename include guard.
15098         * mi/mi-common.h: Rename include guard.
15099         * mi/mi-cmds.h: Rename include guard.
15100         * mi/mi-cmd-break.h: Rename include guard.
15101         * m2-lang.h: Add include guard.
15102         * location.h: Rename include guard.
15103         * linux-record.h: Rename include guard.
15104         * linux-nat.h: Add include guard.
15105         * linux-fork.h: Add include guard.
15106         * i386-darwin-tdep.h: Rename include guard.
15107         * hppa-linux-offsets.h: Add include guard.
15108         * guile/guile.h: Rename include guard.
15109         * guile/guile-internal.h: Rename include guard.
15110         * gnu-nat.h: Rename include guard.
15111         * gdb-stabs.h: Rename include guard.
15112         * frv-tdep.h: Add include guard.
15113         * f-lang.h: Add include guard.
15114         * event-loop.h: Add include guard.
15115         * darwin-nat.h: Rename include guard.
15116         * cp-abi.h: Rename include guard.
15117         * config/sparc/nm-sol2.h: Rename include guard.
15118         * config/nm-nto.h: Rename include guard.
15119         * config/nm-linux.h: Add include guard.
15120         * config/i386/nm-i386gnu.h: Rename include guard.
15121         * config/djgpp/nl_types.h: Rename include guard.
15122         * config/djgpp/langinfo.h: Rename include guard.
15123         * compile/gcc-cp-plugin.h: Add include guard.
15124         * compile/gcc-c-plugin.h: Add include guard.
15125         * compile/compile.h: Rename include guard.
15126         * compile/compile-object-run.h: Rename include guard.
15127         * compile/compile-object-load.h: Rename include guard.
15128         * compile/compile-internal.h: Rename include guard.
15129         * compile/compile-cplus.h: Rename include guard.
15130         * compile/compile-c.h: Rename include guard.
15131         * common/xml-utils.h: Rename include guard.
15132         * common/x86-xstate.h: Rename include guard.
15133         * common/version.h: Rename include guard.
15134         * common/vec.h: Rename include guard.
15135         * common/tdesc.h: Rename include guard.
15136         * common/selftest.h: Rename include guard.
15137         * common/scoped_restore.h: Rename include guard.
15138         * common/scoped_mmap.h: Rename include guard.
15139         * common/scoped_fd.h: Rename include guard.
15140         * common/safe-iterator.h: Rename include guard.
15141         * common/run-time-clock.h: Rename include guard.
15142         * common/refcounted-object.h: Rename include guard.
15143         * common/queue.h: Rename include guard.
15144         * common/ptid.h: Rename include guard.
15145         * common/print-utils.h: Rename include guard.
15146         * common/preprocessor.h: Rename include guard.
15147         * common/pathstuff.h: Rename include guard.
15148         * common/observable.h: Rename include guard.
15149         * common/netstuff.h: Rename include guard.
15150         * common/job-control.h: Rename include guard.
15151         * common/host-defs.h: Rename include guard.
15152         * common/gdb_wait.h: Rename include guard.
15153         * common/gdb_vecs.h: Rename include guard.
15154         * common/gdb_unlinker.h: Rename include guard.
15155         * common/gdb_unique_ptr.h: Rename include guard.
15156         * common/gdb_tilde_expand.h: Rename include guard.
15157         * common/gdb_sys_time.h: Rename include guard.
15158         * common/gdb_string_view.h: Rename include guard.
15159         * common/gdb_splay_tree.h: Rename include guard.
15160         * common/gdb_setjmp.h: Rename include guard.
15161         * common/gdb_ref_ptr.h: Rename include guard.
15162         * common/gdb_optional.h: Rename include guard.
15163         * common/gdb_locale.h: Rename include guard.
15164         * common/gdb_assert.h: Rename include guard.
15165         * common/filtered-iterator.h: Rename include guard.
15166         * common/filestuff.h: Rename include guard.
15167         * common/fileio.h: Rename include guard.
15168         * common/environ.h: Rename include guard.
15169         * common/common-utils.h: Rename include guard.
15170         * common/common-types.h: Rename include guard.
15171         * common/common-regcache.h: Rename include guard.
15172         * common/common-inferior.h: Rename include guard.
15173         * common/common-gdbthread.h: Rename include guard.
15174         * common/common-exceptions.h: Rename include guard.
15175         * common/common-defs.h: Rename include guard.
15176         * common/common-debug.h: Rename include guard.
15177         * common/cleanups.h: Rename include guard.
15178         * common/buffer.h: Rename include guard.
15179         * common/btrace-common.h: Rename include guard.
15180         * common/break-common.h: Rename include guard.
15181         * cli/cli-utils.h: Rename include guard.
15182         * cli/cli-style.h: Rename include guard.
15183         * cli/cli-setshow.h: Rename include guard.
15184         * cli/cli-script.h: Rename include guard.
15185         * cli/cli-interp.h: Rename include guard.
15186         * cli/cli-decode.h: Rename include guard.
15187         * cli/cli-cmds.h: Rename include guard.
15188         * charset-list.h: Add include guard.
15189         * buildsym-legacy.h: Rename include guard.
15190         * bfin-tdep.h: Add include guard.
15191         * ax.h: Rename include guard.
15192         * arm-linux-tdep.h: Add include guard.
15193         * arm-fbsd-tdep.h: Add include guard.
15194         * arch/xtensa.h: Rename include guard.
15195         * arch/tic6x.h: Add include guard.
15196         * arch/i386.h: Add include guard.
15197         * arch/arm.h: Rename include guard.
15198         * arch/arm-linux.h: Rename include guard.
15199         * arch/arm-get-next-pcs.h: Rename include guard.
15200         * arch/amd64.h: Add include guard.
15201         * arch/aarch64-insn.h: Rename include guard.
15202         * arch-utils.h: Rename include guard.
15203         * annotate.h: Add include guard.
15204         * amd64-darwin-tdep.h: Rename include guard.
15205         * aarch64-linux-tdep.h: Add include guard.
15206         * aarch64-fbsd-tdep.h: Add include guard.
15207         * aarch32-linux-nat.h: Add include guard.
15208
15209 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15210
15211         * macrotab.c (macro_define_internal): New function that
15212         factorizes macro_define_object_internal and macro_define_function
15213         code.
15214         (macro_define_object_internal): Use macro_define_internal.
15215         (macro_define_function): Likewise.
15216
15217 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15218
15219         * macrocmd.c (extract_identifier): Return
15220         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15221         callers.
15222
15223 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
15224
15225         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15226
15227 2019-02-05  Tom Tromey  <tom@tromey.com>
15228
15229         * target.c (target_stack::unpush): Move assertion earlier.
15230
15231 2019-01-30  Tom Tromey  <tom@tromey.com>
15232
15233         PR python/23615:
15234         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15235         (gdbpy_parse_and_eval): Likewise.
15236         * python/python-internal.h (gdbpy_allow_threads): New class.
15237
15238 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
15239
15240         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15241         (aarch64_fbsd_fpregmap): Move earlier.
15242         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15243         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15244         instead of individual calls to trad_frame_set_reg_addr.
15245         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15246         earlier.
15247         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15248         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15249         instead of individual calls to trad_frame_set_reg_addr.
15250
15251 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
15252
15253         * CONTRIBUTE: Replace contribution list with wiki link.
15254
15255 2019-01-25  Tom Tromey  <tom@tromey.com>
15256
15257         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15258
15259 2019-01-25  Tom Tromey  <tom@tromey.com>
15260
15261         * xtensa-linux-nat.c: Fix common/ includes.
15262         * xml-support.h: Fix common/ includes.
15263         * xml-support.c: Fix common/ includes.
15264         * x86-linux-nat.c: Fix common/ includes.
15265         * windows-nat.c: Fix common/ includes.
15266         * varobj.h: Fix common/ includes.
15267         * varobj.c: Fix common/ includes.
15268         * value.c: Fix common/ includes.
15269         * valops.c: Fix common/ includes.
15270         * utils.c: Fix common/ includes.
15271         * unittests/xml-utils-selftests.c: Fix common/ includes.
15272         * unittests/utils-selftests.c: Fix common/ includes.
15273         * unittests/unpack-selftests.c: Fix common/ includes.
15274         * unittests/tracepoint-selftests.c: Fix common/ includes.
15275         * unittests/style-selftests.c: Fix common/ includes.
15276         * unittests/string_view-selftests.c: Fix common/ includes.
15277         * unittests/scoped_restore-selftests.c: Fix common/ includes.
15278         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15279         * unittests/scoped_fd-selftests.c: Fix common/ includes.
15280         * unittests/rsp-low-selftests.c: Fix common/ includes.
15281         * unittests/parse-connection-spec-selftests.c: Fix common/
15282         includes.
15283         * unittests/optional-selftests.c: Fix common/ includes.
15284         * unittests/offset-type-selftests.c: Fix common/ includes.
15285         * unittests/observable-selftests.c: Fix common/ includes.
15286         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15287         * unittests/memrange-selftests.c: Fix common/ includes.
15288         * unittests/memory-map-selftests.c: Fix common/ includes.
15289         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15290         * unittests/function-view-selftests.c: Fix common/ includes.
15291         * unittests/environ-selftests.c: Fix common/ includes.
15292         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15293         * unittests/common-utils-selftests.c: Fix common/ includes.
15294         * unittests/cli-utils-selftests.c: Fix common/ includes.
15295         * unittests/array-view-selftests.c: Fix common/ includes.
15296         * ui-file.c: Fix common/ includes.
15297         * tui/tui-io.c: Fix common/ includes.
15298         * tracepoint.h: Fix common/ includes.
15299         * tracepoint.c: Fix common/ includes.
15300         * tracefile-tfile.c: Fix common/ includes.
15301         * top.h: Fix common/ includes.
15302         * top.c: Fix common/ includes.
15303         * thread.c: Fix common/ includes.
15304         * target/waitstatus.h: Fix common/ includes.
15305         * target/waitstatus.c: Fix common/ includes.
15306         * target.h: Fix common/ includes.
15307         * target.c: Fix common/ includes.
15308         * target-memory.c: Fix common/ includes.
15309         * target-descriptions.c: Fix common/ includes.
15310         * symtab.h: Fix common/ includes.
15311         * symfile.c: Fix common/ includes.
15312         * stap-probe.c: Fix common/ includes.
15313         * spu-linux-nat.c: Fix common/ includes.
15314         * sparc-nat.c: Fix common/ includes.
15315         * source.c: Fix common/ includes.
15316         * solib.c: Fix common/ includes.
15317         * solib-target.c: Fix common/ includes.
15318         * ser-unix.c: Fix common/ includes.
15319         * ser-tcp.c: Fix common/ includes.
15320         * ser-pipe.c: Fix common/ includes.
15321         * ser-base.c: Fix common/ includes.
15322         * selftest-arch.c: Fix common/ includes.
15323         * s12z-tdep.c: Fix common/ includes.
15324         * rust-exp.y: Fix common/ includes.
15325         * rs6000-aix-tdep.c: Fix common/ includes.
15326         * riscv-tdep.c: Fix common/ includes.
15327         * remote.c: Fix common/ includes.
15328         * remote-notif.h: Fix common/ includes.
15329         * remote-fileio.h: Fix common/ includes.
15330         * remote-fileio.c: Fix common/ includes.
15331         * regcache.h: Fix common/ includes.
15332         * regcache.c: Fix common/ includes.
15333         * record-btrace.c: Fix common/ includes.
15334         * python/python.c: Fix common/ includes.
15335         * python/py-type.c: Fix common/ includes.
15336         * python/py-inferior.c: Fix common/ includes.
15337         * progspace.h: Fix common/ includes.
15338         * producer.c: Fix common/ includes.
15339         * procfs.c: Fix common/ includes.
15340         * proc-api.c: Fix common/ includes.
15341         * printcmd.c: Fix common/ includes.
15342         * ppc-linux-nat.c: Fix common/ includes.
15343         * parser-defs.h: Fix common/ includes.
15344         * osdata.c: Fix common/ includes.
15345         * obsd-nat.c: Fix common/ includes.
15346         * nat/x86-linux.c: Fix common/ includes.
15347         * nat/x86-linux-dregs.c: Fix common/ includes.
15348         * nat/x86-dregs.h: Fix common/ includes.
15349         * nat/x86-dregs.c: Fix common/ includes.
15350         * nat/ppc-linux.c: Fix common/ includes.
15351         * nat/mips-linux-watch.h: Fix common/ includes.
15352         * nat/mips-linux-watch.c: Fix common/ includes.
15353         * nat/linux-waitpid.c: Fix common/ includes.
15354         * nat/linux-ptrace.h: Fix common/ includes.
15355         * nat/linux-ptrace.c: Fix common/ includes.
15356         * nat/linux-procfs.c: Fix common/ includes.
15357         * nat/linux-personality.c: Fix common/ includes.
15358         * nat/linux-osdata.c: Fix common/ includes.
15359         * nat/linux-namespaces.c: Fix common/ includes.
15360         * nat/linux-btrace.h: Fix common/ includes.
15361         * nat/linux-btrace.c: Fix common/ includes.
15362         * nat/fork-inferior.c: Fix common/ includes.
15363         * nat/amd64-linux-siginfo.c: Fix common/ includes.
15364         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15365         * nat/aarch64-linux.c: Fix common/ includes.
15366         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15367         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15368         * namespace.h: Fix common/ includes.
15369         * mips-linux-tdep.c: Fix common/ includes.
15370         * minsyms.c: Fix common/ includes.
15371         * mi/mi-parse.h: Fix common/ includes.
15372         * mi/mi-main.c: Fix common/ includes.
15373         * mi/mi-cmd-env.c: Fix common/ includes.
15374         * memrange.h: Fix common/ includes.
15375         * memattr.c: Fix common/ includes.
15376         * maint.h: Fix common/ includes.
15377         * maint.c: Fix common/ includes.
15378         * main.c: Fix common/ includes.
15379         * machoread.c: Fix common/ includes.
15380         * location.c: Fix common/ includes.
15381         * linux-thread-db.c: Fix common/ includes.
15382         * linux-nat.c: Fix common/ includes.
15383         * linux-fork.c: Fix common/ includes.
15384         * inline-frame.c: Fix common/ includes.
15385         * infrun.c: Fix common/ includes.
15386         * inflow.c: Fix common/ includes.
15387         * inferior.h: Fix common/ includes.
15388         * inferior.c: Fix common/ includes.
15389         * infcmd.c: Fix common/ includes.
15390         * inf-ptrace.c: Fix common/ includes.
15391         * inf-child.c: Fix common/ includes.
15392         * ia64-linux-nat.c: Fix common/ includes.
15393         * i387-tdep.c: Fix common/ includes.
15394         * i386-tdep.c: Fix common/ includes.
15395         * i386-linux-tdep.c: Fix common/ includes.
15396         * i386-linux-nat.c: Fix common/ includes.
15397         * i386-go32-tdep.c: Fix common/ includes.
15398         * i386-fbsd-tdep.c: Fix common/ includes.
15399         * i386-fbsd-nat.c: Fix common/ includes.
15400         * guile/scm-type.c: Fix common/ includes.
15401         * guile/guile.c: Fix common/ includes.
15402         * go32-nat.c: Fix common/ includes.
15403         * gnu-nat.c: Fix common/ includes.
15404         * gdbthread.h: Fix common/ includes.
15405         * gdbarch-selftests.c: Fix common/ includes.
15406         * gdb_usleep.c: Fix common/ includes.
15407         * gdb_select.h: Fix common/ includes.
15408         * gdb_bfd.c: Fix common/ includes.
15409         * gcore.c: Fix common/ includes.
15410         * fork-child.c: Fix common/ includes.
15411         * findvar.c: Fix common/ includes.
15412         * fbsd-nat.c: Fix common/ includes.
15413         * event-top.c: Fix common/ includes.
15414         * event-loop.c: Fix common/ includes.
15415         * dwarf2read.c: Fix common/ includes.
15416         * dwarf2loc.c: Fix common/ includes.
15417         * dwarf2-frame.c: Fix common/ includes.
15418         * dwarf-index-cache.c: Fix common/ includes.
15419         * dtrace-probe.c: Fix common/ includes.
15420         * disasm-selftests.c: Fix common/ includes.
15421         * defs.h: Fix common/ includes.
15422         * csky-tdep.c: Fix common/ includes.
15423         * cp-valprint.c: Fix common/ includes.
15424         * cp-support.h: Fix common/ includes.
15425         * cp-support.c: Fix common/ includes.
15426         * corelow.c: Fix common/ includes.
15427         * completer.h: Fix common/ includes.
15428         * completer.c: Fix common/ includes.
15429         * compile/compile.c: Fix common/ includes.
15430         * compile/compile-loc2c.c: Fix common/ includes.
15431         * compile/compile-cplus-types.c: Fix common/ includes.
15432         * compile/compile-cplus-symbols.c: Fix common/ includes.
15433         * command.h: Fix common/ includes.
15434         * cli/cli-dump.c: Fix common/ includes.
15435         * cli/cli-cmds.c: Fix common/ includes.
15436         * charset.c: Fix common/ includes.
15437         * build-id.c: Fix common/ includes.
15438         * btrace.h: Fix common/ includes.
15439         * btrace.c: Fix common/ includes.
15440         * breakpoint.h: Fix common/ includes.
15441         * breakpoint.c: Fix common/ includes.
15442         * ax.h:
15443         (enum agent_op): Fix common/ includes.
15444         * ax-general.c (struct aop_map): Fix common/ includes.
15445         * ax-gdb.c: Fix common/ includes.
15446         * auxv.c: Fix common/ includes.
15447         * auto-load.c: Fix common/ includes.
15448         * arm-tdep.c: Fix common/ includes.
15449         * arch/riscv.c: Fix common/ includes.
15450         * arch/ppc-linux-common.c: Fix common/ includes.
15451         * arch/i386.c: Fix common/ includes.
15452         * arch/arm.c: Fix common/ includes.
15453         * arch/arm-linux.c: Fix common/ includes.
15454         * arch/arm-get-next-pcs.c: Fix common/ includes.
15455         * arch/amd64.c: Fix common/ includes.
15456         * arch/aarch64.c: Fix common/ includes.
15457         * arch/aarch64-insn.c: Fix common/ includes.
15458         * arch-utils.c: Fix common/ includes.
15459         * amd64-windows-tdep.c: Fix common/ includes.
15460         * amd64-tdep.c: Fix common/ includes.
15461         * amd64-sol2-tdep.c: Fix common/ includes.
15462         * amd64-obsd-tdep.c: Fix common/ includes.
15463         * amd64-nbsd-tdep.c: Fix common/ includes.
15464         * amd64-linux-tdep.c: Fix common/ includes.
15465         * amd64-linux-nat.c: Fix common/ includes.
15466         * amd64-fbsd-tdep.c: Fix common/ includes.
15467         * amd64-fbsd-nat.c: Fix common/ includes.
15468         * amd64-dicos-tdep.c: Fix common/ includes.
15469         * amd64-darwin-tdep.c: Fix common/ includes.
15470         * agent.c: Fix common/ includes.
15471         * ada-lang.h: Fix common/ includes.
15472         * ada-lang.c: Fix common/ includes.
15473         * aarch64-tdep.c: Fix common/ includes.
15474
15475 2019-01-25  Tom Tromey  <tom@tromey.com>
15476
15477         * common/create-version.sh: Use common/version.h.
15478
15479 2019-01-24  Pedro Alves  <palves@redhat.com>
15480
15481         * infrun.c (signal_stop, signal_print, signal_program)
15482         (signal_catch, signal_pass): Now arrays instead of pointers.
15483         (update_signals_program_target, do_target_resume)
15484         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15485         * linux-nat.c (linux_nat_target::pass_signals)
15486         (linux_nat_target::create_inferior, linux_nat_target::attach):
15487         Adjust.
15488         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15489         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15490         * procfs.c (procfs_target::pass_signals): Adjust.
15491         * record-full.c (record_full_target::resume): Adjust.
15492         * remote.c (remote_target::pass_signals)
15493         (remote_target::program_signals): Adjust.
15494         * target-debug.h (target_debug_print_signals): Now takes a
15495         gdb::array_view as parameter.  Adjust.
15496         * target.h (target_ops) <pass_signals, program_signals>: Replace
15497         pointer and length parameters with gdb::array_view.
15498         (target_pass_signals, target_program_signals): Likewise.
15499         * target-delegates.c: Regenerate.
15500
15501 2019-01-24  Pedro Alves  <palves@redhat.com>
15502
15503         * common/forward-scope-exit.h
15504         (forward_scope_exit::forward_scope_exit): Pass arguments to
15505         m_bind_function directly, instead of creating a std::bind and
15506         copying that.
15507
15508 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
15509
15510         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15511         for static members.
15512         (pass_in_v_vfp_candidate): Likewise.
15513
15514 2019-01-23  Tom Tromey  <tom@tromey.com>
15515             Pedro Alves  <palves@redhat.com>
15516
15517         * regcache.c (class regcache_invalidator): Remove.
15518         (regcache::raw_write): Use make_scope_exit.
15519
15520 2019-01-23  Tom Tromey  <tom@tromey.com>
15521
15522         * ui-out.h (class ui_out_emit_type): Update comment.
15523
15524 2019-01-23  Tom Tromey  <tom@tromey.com>
15525
15526         * infrun.c (fetch_inferior_event): Update comment.
15527
15528 2019-01-23  Tom Tromey  <tom@tromey.com>
15529             Pedro Alves  <palves@redhat.com>
15530
15531         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15532         parameter.
15533         (fetch_inferior_event): Use SCOPE_EXIT.
15534
15535
15536 2019-01-23  Tom Tromey  <tom@tromey.com>
15537             Pedro Alves  <palves@redhat.com>
15538
15539         * infrun.c (disable_thread_events): Delete.
15540         (stop_all_threads): Use SCOPE_EXIT.
15541
15542 2019-01-23  Tom Tromey  <tom@tromey.com>
15543             Pedro Alves  <palves@redhat.com>
15544
15545         * symfile.c: Include forward-scope-exit.h.
15546         (clear_symtab_users_cleanup): Replace forward declaration with
15547         a FORWARD_SCOPE_EXIT.
15548         (syms_from_objfile_1): Use the forward_scope_exit and
15549         gdb::optional instead of cleanup_function.
15550         (reread_symbols): Use the forward_scope_exit instead of
15551         cleanup_function.
15552         (clear_symtab_users_cleanup): Remove function.
15553
15554 2019-01-23  Tom Tromey  <tom@tromey.com>
15555             Pedro Alves  <palves@redhat.com>
15556
15557         * linux-nat.c: Include scope-exit.h.
15558         (cleanup_target_stop): Remove.
15559         (linux_nat_target::static_tracepoint_markers_by_strid): Use
15560         SCOPE_EXIT.
15561
15562 2019-01-23  Tom Tromey  <tom@tromey.com>
15563             Pedro Alves  <palves@redhat.com>
15564
15565         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15566         (call_function_by_hand_dummy): Use SCOPE_EXIT.
15567
15568 2019-01-23  Tom Tromey  <tom@tromey.com>
15569             Andrew Burgess  <andrew.burgess@embecosm.com>
15570             Pedro Alves  <palves@redhat.com>
15571
15572         * infrun.c (fetch_inferior_event): Use scope_exit.
15573         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15574         * top.c (execute_command): Use scope_exit.
15575         * breakpoint.c (bpstat_do_actions): Use scope_exit.
15576         * utils.c (do_bpstat_clear_actions_cleanup)
15577         (make_bpstat_clear_actions_cleanup): Remove.
15578
15579 2019-01-23  Tom Tromey  <tom@tromey.com>
15580             Pedro Alves  <palves@redhat.com>
15581
15582         * infrun.c: Include "common/scope-exit.h"
15583         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15584         (wait_for_inferior): Use SCOPE_EXIT.
15585         (fetch_inferior_event): Use scope_exit.
15586
15587 2019-01-23  Tom Tromey  <tom@tromey.com>
15588             Pedro Alves  <palves@redhat.com>
15589
15590         * breakpoint.c (create_breakpoint): Remove cleanup.
15591
15592 2019-01-23  Tom Tromey  <tom@tromey.com>
15593             Andrew Burgess  <andrew.burgess@embecosm.com>
15594             Pedro Alves  <palves@redhat.com>
15595
15596 2019-01-23  Pedro Alves  <palves@redhat.com>
15597
15598         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15599
15600 2019-01-23  Pedro Alves  <palves@redhat.com>
15601             Andrew Burgess  <andrew.burgess@embecosm.com>
15602
15603         * gdbthread.h: Include "common/forward-scope-exit.h".
15604         (scoped_finish_thread_state): Redefine custom class in terms of
15605         forward_scope_exit.
15606
15607 2019-01-23  Pedro Alves  <palves@redhat.com>
15608             Andrew Burgess  <andrew.burgess@embecosm.com>
15609
15610         * common/forward-scope-exit.h: New file.
15611
15612 2019-01-23  Pedro Alves  <palves@redhat.com>
15613             Andrew Burgess  <andrew.burgess@embecosm.com>
15614             Tom Tromey  <tom@tromey.com>
15615
15616         * common/scope-exit.h: New file.
15617
15618 2019-01-23  Pedro Alves  <palves@redhat.com>
15619
15620         * common/preprocessor.h (ESC): Rename to ...
15621         (ESC_PARENS): ... this.
15622         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15623         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15624
15625 2019-01-23  Tom Tromey  <tom@tromey.com>
15626
15627         * language.h (class scoped_switch_to_sym_language_if_auto):
15628         Initialize m_lang in both cases.
15629
15630 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
15631
15632         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15633         with XCNEW.
15634
15635 2019-01-22  Tom Tromey  <tom@tromey.com>
15636
15637         * corelow.c: Do not include sys/file.h.
15638
15639 2019-01-22  Tom Tromey  <tom@tromey.com>
15640
15641         * tui/tui-wingeneral.h: Include gdb_curses.h.
15642
15643 2019-01-22  Tom Tromey  <tom@tromey.com>
15644
15645         * source-cache.h (class source_cache) <get_source_lines,
15646         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15647
15648 2019-01-22  Tom Tromey  <tom@tromey.com>
15649
15650         * remote-fileio.h (struct remote_target): Declare.
15651
15652 2019-01-22  Tom Tromey  <tom@tromey.com>
15653
15654         * python/py-arch.c: Do not include py-ref.h.
15655         * python/py-bpevent.c: Do not include py-ref.h.
15656         * python/py-cmd.c: Do not include py-ref.h.
15657         * python/py-continueevent.c: Do not include py-ref.h.
15658         * python/py-event.h: Do not include py-ref.h.
15659         * python/py-evtregistry.c: Do not include py-ref.h.
15660         * python/py-finishbreakpoint.c: Do not include py-ref.h.
15661         * python/py-frame.c: Do not include py-ref.h.
15662         * python/py-framefilter.c: Do not include py-ref.h.
15663         * python/py-function.c: Do not include py-ref.h.
15664         * python/py-infevents.c: Do not include py-ref.h.
15665         * python/py-linetable.c: Do not include py-ref.h.
15666         * python/py-objfile.c: Do not include py-ref.h.
15667         * python/py-param.c: Do not include py-ref.h.
15668         * python/py-prettyprint.c: Do not include py-ref.h.
15669         * python/py-progspace.c: Do not include py-ref.h.
15670         * python/py-symbol.c: Do not include py-ref.h.
15671         * python/py-symtab.c: Do not include py-ref.h.
15672         * python/py-type.c: Do not include py-ref.h.
15673         * python/py-unwind.c: Do not include py-ref.h.
15674         * python/py-utils.c: Do not include py-ref.h.
15675         * python/py-value.c: Do not include py-ref.h.
15676         * python/py-varobj.c: Do not include py-ref.h.
15677         * python/py-xmethods.c: Do not include py-ref.h.
15678         * python/python.c: Do not include py-ref.h.
15679         * varobj.c: Do not include py-ref.h.
15680
15681 2019-01-22  Tom Tromey  <tom@tromey.com>
15682
15683         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15684         keyword for bcache.
15685
15686 2019-01-22  Tom Tromey  <tom@tromey.com>
15687
15688         * compile/compile-cplus-types.c: Remove a comment by #include.
15689
15690 2019-01-22  Tom Tromey  <tom@tromey.com>
15691
15692         * compile/gcc-c-plugin.h: Include compile-internal.h.
15693
15694 2019-01-22  Tom Tromey  <tom@tromey.com>
15695
15696         * stabsread.c (EXTERN): Do not define.
15697         (symnum, next_symbol_text_func, processing_gcc_compilation)
15698         (within_function, global_sym_chain, global_stabs)
15699         (previous_stab_code, this_object_header_files)
15700         (n_this_object_header_files)
15701         (n_allocated_this_object_header_files): Define.
15702         * stabsread.h (EXTERN): Never define.  Use "extern".
15703
15704 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15705
15706         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15707         history_value.
15708
15709 2019-01-21  Tom Tromey  <tom@tromey.com>
15710
15711         * ui-out.c: Fix includes.
15712         * tui/tui-source.c: Fix includes.
15713         * target.c: Fix includes.
15714         * remote.c: Fix includes.
15715         * regcache.c: Fix includes.
15716         * python/py-block.c: Fix includes.
15717         * printcmd.c: Fix includes.
15718         * or1k-tdep.c: Fix includes.
15719         * mi/mi-main.c: Fix includes.
15720         * m32r-tdep.c: Fix includes.
15721         * csky-tdep.c: Fix includes.
15722         * compile/compile-cplus-types.c: Fix includes.
15723         * cli/cli-interp.c: Fix includes.
15724
15725 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
15726
15727         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15728         for padding.
15729
15730 2019-01-16  Tom Tromey  <tom@tromey.com>
15731
15732         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
15733         earlier.
15734         (struct objfile) <msymbols_range>: Move from top level.
15735         <msymbols>: New method.
15736         (class objfile_msymbols): Remove.
15737         * symtab.c (default_collect_symbol_completion_matches_break_on):
15738         Update.
15739         * symmisc.c (dump_msymbols): Update.
15740         * stabsread.c (scan_file_globals): Update.
15741         * objc-lang.c (info_selectors_command, info_classes_command)
15742         (find_methods): Update.
15743         * minsyms.c (find_solib_trampoline_target): Update.
15744         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15745         * coffread.c (coff_symfile_read): Update.
15746         * ada-lang.c (ada_lookup_simple_minsym)
15747         (ada_collect_symbol_completion_matches): Update.
15748
15749 2019-01-16  Tom Tromey  <tom@tromey.com>
15750
15751         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15752         type.  Remove no-argument constructor.
15753         <iterator::operator++>: Simplify.
15754         <begin>: Update.
15755         <end>: Use minimal_symbol_count.
15756
15757 2019-01-16  Tom Tromey  <tom@tromey.com>
15758
15759         * objfiles.h (struct objfile) <psymtabs>: New method.
15760         (class objfile_psymtabs): Remove.
15761         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15762         typedef.
15763         <range>: New method.
15764         (require_partial_symbols): Change return type.
15765         * psymtab.c (require_partial_symbols)
15766         (psym_expand_symtabs_matching): Update.
15767         * mdebugread.c (parse_partial_symbols): Update.
15768         * dbxread.c (dbx_end_psymtab): Update.
15769
15770 2019-01-15  Tom Tromey  <tom@tromey.com>
15771
15772         * symtab.c (lookup_objfile_from_block)
15773         (lookup_symbol_in_objfile_symtabs)
15774         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15775         (find_line_symtab, info_sources_command)
15776         (default_collect_symbol_completion_matches_break_on)
15777         (make_source_files_completion_list): Update.
15778         * symmisc.c (print_objfile_statistics, dump_objfile)
15779         (maintenance_print_symbols, maintenance_info_symtabs)
15780         (maintenance_check_symtabs, maintenance_info_line_tables):
15781         Update.
15782         * source.c (select_source_symtab)
15783         (forget_cached_source_info_for_objfile): Update.
15784         * objfiles.h (class objfile_compunits): Remove.
15785         (struct objfile) <compunits_range>: New typedef.
15786         (compunits): New method.
15787         * objfiles.c (objfile_relocate1): Update.
15788         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15789         * maint.c (count_symtabs_and_blocks): Update.
15790         * linespec.c (iterate_over_all_matching_symtabs): Update.
15791         * cp-support.c (add_symbol_overload_list_qualified): Update.
15792         * coffread.c (coff_symtab_read): Update.
15793         * ada-lang.c (add_nonlocal_symbols)
15794         (ada_collect_symbol_completion_matches)
15795         (ada_add_global_exceptions): Update.
15796
15797 2019-01-15  Tom Tromey  <tom@tromey.com>
15798
15799         * progspace.h (program_space) <objfiles_safe_range>: New
15800         typedef.
15801         <objfiles_safe>: New method.
15802         * objfiles.h (class all_objfiles_safe): Remove.
15803         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15804         * jit.c (jit_inferior_exit_hook): Update.
15805
15806 2019-01-17  Tom Tromey  <tom@tromey.com>
15807
15808         * progspace.h (program_space) <objfiles_range>: New typedef.
15809         <objfiles>: New method.
15810         <objfiles_head>: Rename from objfiles.
15811         (object_files): Update.
15812         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15813         * guile/scm-pretty-print.c
15814         (ppscm_find_pretty_printer_from_objfiles): Update.
15815         * guile/scm-objfile.c (gdbscm_objfiles): Update.
15816         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15817         Update.
15818         * python/py-progspace.c (pspy_get_objfiles): Update.
15819         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15820         Update.
15821         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15822         (objfpy_lookup_objfile_by_build_id): Update.
15823         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15824         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15825         Update.
15826         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15827         (expand_symtab_containing_pc, lookup_objfile_from_block)
15828         (lookup_static_symbol, basic_lookup_transparent_type)
15829         (find_pc_sect_compunit_symtab, find_symbol_at_address)
15830         (find_line_symtab, info_sources_command)
15831         (default_collect_symbol_completion_matches_break_on)
15832         (make_source_files_completion_list, find_main_name): Update.
15833         * symmisc.c (print_symbol_bcache_statistics)
15834         (print_objfile_statistics, maintenance_print_symbols)
15835         (maintenance_print_msymbols, maintenance_print_objfiles)
15836         (maintenance_info_symtabs, maintenance_check_symtabs)
15837         (maintenance_expand_symtabs, maintenance_info_line_tables):
15838         Update.
15839         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15840         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15841         (map_overlay_command, unmap_overlay_command)
15842         (simple_overlay_update, expand_symtabs_matching)
15843         (map_symbol_filenames): Update.
15844         * symfile-debug.c (set_debug_symfile): Update.
15845         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15846         Update.
15847         * source.c (select_source_symtab, forget_cached_source_info):
15848         Update.
15849         * solib.c (solib_read_symbols): Update.
15850         * solib-spu.c (append_ocl_sos): Update.
15851         * psymtab.c (maintenance_print_psymbols)
15852         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15853         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15854         * printcmd.c (info_symbol_command): Update.
15855         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15856         Update.
15857         * objfiles.h (class all_objfiles): Remove.
15858         * objfiles.c (have_partial_symbols, have_full_symbols)
15859         (have_minimal_symbols, qsort_cmp, update_section_map)
15860         (shared_objfile_contains_address_p)
15861         (default_iterate_over_objfiles_in_search_order): Update.
15862         * objc-lang.c (info_selectors_command, info_classes_command)
15863         (find_methods): Update.
15864         * minsyms.c (find_solib_trampoline_target): Update.
15865         * maint.c (maintenance_info_sections)
15866         (maintenance_translate_address, count_symtabs_and_blocks):
15867         Update.
15868         * main.c (captured_main_1): Update.
15869         * linux-thread-db.c (try_thread_db_load_from_pdir)
15870         (has_libpthread): Update.
15871         * linespec.c (iterate_over_all_matching_symtabs)
15872         (search_minsyms_for_name): Update.
15873         * jit.c (jit_find_objf_with_entry_addr): Update.
15874         * hppa-tdep.c (find_unwind_entry)
15875         (hppa_lookup_stub_minimal_symbol): Update.
15876         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15877         Update.
15878         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15879         (elf_gnu_ifunc_resolve_by_got): Update.
15880         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15881         * dwarf-index-write.c (save_gdb_index_command): Update.
15882         * cp-support.c (add_symbol_overload_list_qualified): Update.
15883         * breakpoint.c (create_overlay_event_breakpoint)
15884         (create_longjmp_master_breakpoint)
15885         (create_std_terminate_master_breakpoint)
15886         (create_exception_master_breakpoint): Update.
15887         * blockframe.c (find_pc_partial_function): Update.
15888         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15889         (ada_collect_symbol_completion_matches)
15890         (ada_add_global_exceptions): Update.
15891
15892 2019-01-17  Tom Tromey  <tom@tromey.com>
15893
15894         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
15895         declare VEC.
15896         (solib_target_parse_libraries): Change return type.
15897         (library_list_start_segment, library_list_start_section)
15898         (library_list_end_library, library_list_start_library); Update.
15899         (solib_target_free_library_list): Remove.
15900         (solib_target_parse_libraries): Remove cleanup.  Change return
15901         type.
15902         (solib_target_current_sos): Update.
15903
15904 2019-01-17  Tom Tromey  <tromey@bapiya>
15905
15906         * valprint.c: Replace "the the" with "the".
15907         * symtab.c: Replace "the the" with "the".
15908         * solib.c: Replace "the the" with "the".
15909         * solib-dsbt.c: Replace "the the" with "the".
15910         * linespec.c: Replace "the the" with "the".
15911         * dwarf2loc.h: Replace "the the" with "the".
15912         * amd64-windows-tdep.c: Replace "the the" with "the".
15913         * aarch64-tdep.c: Replace "the the" with "the".
15914
15915 2019-01-16  Keith Seitz  <keiths@redhat.com>
15916
15917         PR gdb/23773
15918         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15919         <builder>: Rename to ..
15920         <m_builder>: ... this and make private.
15921         (dwarf2_cu::get_builder): New method.  Change all users of
15922         `builder' to use this method.
15923         (dwarf2_start_symtab): Move to ...
15924         (dwarf2_cu::start_symtab): ... here.  Update all callers
15925         (setup_type_unit_groups): Move to ...
15926         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
15927         callers.
15928         (dwarf2_cu::reset_builder): New method.
15929         (process_full_compunit, process_full_type_unit): Use
15930         dwarf2_cu::reset_builder.
15931         (follow_die_offset): Record the ancestor CU if it is different
15932         from the followed DIE's CU.
15933         (follow_die_sig_1): Likewise.
15934
15935 2019-01-15  Tom Tromey  <tom@tromey.com>
15936
15937         * remote.c (class remote_state) <buf>: Now a char_vector.
15938         <buf_size>: Remove.
15939         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
15940         parameter.
15941         (remote_target::getpkt_or_notif_sane_1)
15942         (remote_target::getpkt_sane)
15943         (remote_target::getpkt_or_notif_sane): Likewise.
15944         (class remote_target) <putpkt>: New overload.
15945         (remote_target::read_frame): Change type of "buf_p".  Remove
15946         sizeof_p parameter.
15947         (packet_ok): New overload.
15948         (packet_check_result): New overload.
15949         Update all uses.
15950
15951 2019-01-14  Tom Tromey  <tom@tromey.com>
15952
15953         * remote-notif.c (handle_notification, remote_notif_ack)
15954         (remote_notif_parse): Make "buf" const.
15955         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15956         const.
15957         (remote_notif_parse, remote_notif_ack, handle_notification):
15958         Likewise.
15959         * remote.c (remote_notif_stop_parse): Make "buf" const.
15960         (remote_target::remote_parse_stop_reply): Make "buf" const.
15961         (remote_notif_stop_ack): Make "buf" const.
15962
15963 2019-01-14  Tom Tromey  <tom@tromey.com>
15964
15965         * remote.c (remote_console_output): Make parameter const.
15966
15967 2019-01-14  Tom Tromey  <tom@tromey.com>
15968
15969         * target-debug.h (target_debug_print_signals): Constify.
15970         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15971         * procfs.c (procfs_target::pass_signals): Update.
15972         * linux-nat.c (linux_nat_target::pass_signals): Update.
15973         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15974         * target-delegates.c: Rebuild.
15975         * remote.c (remote_target::program_signals): Update.
15976         (remote_target::pass_signals): Update.
15977         * target.c (target_pass_signals): Constify argument.
15978         (target_program_signals): Likewise.
15979         * target.h (struct target_ops) <pass_signals, program_signals>:
15980         Constify argument.
15981         (target_pass_signals, target_program_signals): Constify argument.
15982
15983 2019-01-14  Tom Tromey  <tom@tromey.com>
15984
15985         PR tui/28819:
15986         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15987
15988 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
15989
15990         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15991         field.
15992         * rs6000-tdep.c: Include reggroups.h.
15993         (IS_V_ALIAS_PSEUDOREG): Define.
15994         (rs6000_register_name): Return names for the "vX" aliases.
15995         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15996         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
15997         aliases.  Call default_register_reggroup_p for all other
15998         pseudo-registers.
15999         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16000         New functions.
16001         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16002         Handle "vX" aliases.
16003         (v_alias_pseudo_register_collect): New function.
16004         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16005         (rs6000_gdbarch_init): Initialize "vX" aliases as
16006         pseudo-registers.  Restore registration of
16007         rs6000_pseudo_register_reggroup_p with
16008         set_tdesc_pseudo_register_reggroup_p.
16009
16010 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
16011
16012         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16013         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16014         set_gdbarch_num_pseudo_regs.
16015
16016 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16017
16018         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16019         Remove arg prefixname, add do_set and do_show.
16020         Add member functions set_list and show_list.
16021         * cli/cli-style.c (class cli_style_option): Update accordingly.
16022         (style_set_list): Move to file scope.
16023         (style_show_list): Likewise.
16024         (set_style): Call help_list.
16025         (show_style): Call cmd_show_list.
16026         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16027         Update to use the new macro.
16028
16029 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
16030
16031         * ada-lang.c (_initialize_ada_language): Expand the help text
16032         for the "catch exception" command.
16033
16034 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16035
16036         * symtab.c (matching_obj_sections): Initialize obj,
16037         declare it closer to its usage.
16038
16039 2019-01-10  Tom Tromey  <tom@tromey.com>
16040
16041         * thread-iter.h (inf_threads_iterator): Use next_iterator.
16042         (basic_inf_threads_range): Remove.
16043         (inf_threads_range, inf_non_exited_threads_range)
16044         (safe_inf_threads_range): Use next_adapter.
16045
16046 2019-01-10  Keith Seitz  <keiths@redhat.com>
16047
16048         PR gdb/23712
16049         PR symtab/23010
16050         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16051         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16052
16053 2019-01-10  Keith Seitz  <keiths@redhat.com>
16054
16055         PR gdb/23712
16056         PR symtab/23010
16057         * dictionary.c (pending_to_vector): Remove.
16058         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16059         Remove _1 suffix, replacing functions of the same name.  Update
16060         all callers.
16061         (dict_create_hashed, dict_create_hashed_expandable)
16062         (dict_create_linear, dict_create_linear_expandable, dict_free)
16063         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16064         Make functions static.
16065
16066 2019-01-10  Keith Seitz  <keiths@redhat.com>
16067
16068         PR gdb/23712
16069         PR symtab/23010
16070         * dictionary.h (struct dictionary): Replace declaration with
16071         multidictionary.
16072         (dict_create_hashed, dict_create_hashed_expandable)
16073         (dict_create_linear, dict_create_linear_expandable)
16074         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16075         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16076         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16077         taking multidictionary argument.
16078         [ALL_DICT_SYMBOLS]: Update for multidictionary.
16079         * block.h (struct block) <dict>: Change to multidictionary
16080         and rename `multidict'.
16081         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16082         symmisc.c: Update all dictionary references to multidictionary.
16083
16084 2019-01-10  Keith Seitz  <keiths@redhat.com>
16085
16086         PR gdb/23712
16087         PR symtab/23010
16088         * dictionary.c: Include unordered_map.
16089         (pending_to_vector): New function.
16090         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16091         Rewrite the non-"_1" functions to take vector instead
16092         of linked list.
16093         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16094         "new" _1 versions of the same name.
16095         (multidictionary): Define.
16096         (std::hash<enum language): New definition.
16097         (collate_pending_symbols_by_language, mdict_create_hashed)
16098         (mdict_create_hashed_expandable, mdict_create_linear)
16099         (mdict_create_linear_expandable, mdict_free)
16100         (find_language_dictionary, create_new_language_dictionary)
16101         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16102         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16103         (mdict_size, mdict_empty): New functions.
16104         * dictionary.h (mdict_iterator): Define.
16105
16106 2019-01-10  Pedro Alves  <palves@redhat.com>
16107
16108         * breakpoint.c (read_uploaded_action)
16109         (create_tracepoint_from_upload): Adjust to use
16110         gdb::unique_xmalloc_ptr.
16111         * ctf.c (ctf_write_uploaded_tp):
16112         (SET_ARRAY_FIELD): Use emplace_back.
16113         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16114         * tracefile-tfile.c (tfile_write_uploaded_tp):
16115         * tracepoint.c (parse_tracepoint_definition): Adjust to use
16116         gdb::unique_xmalloc_ptr.
16117         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16118         at_string, cond_string, cmd_strings>: Replace char pointers
16119         with gdb::unique_xmalloc_ptr.
16120
16121 2019-01-10  Pedro Alves  <palves@redhat.com>
16122
16123         * solib-target.c (library_list_start_library): Don't xstrdup name.
16124
16125 2019-01-10  Pedro Alves  <palves@redhat.com>
16126
16127         * mdebugread.c (parse_partial_symbols): Use
16128         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16129
16130 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16131
16132         * linux-fork.c (scoped_switch_fork_info)
16133         <~scoped_switch_fork_info>: Fix incorrect variable name.
16134
16135 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16136
16137         * linux-fork.c (scoped_switch_fork_info)
16138         <scoped_switch_fork_info>: Make explicit.
16139         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16140
16141 2019-01-10  Tom Tromey  <tom@tromey.com>
16142
16143         * objfiles.h (objfile::reset_psymtabs): Update.
16144         * objfiles.c (objfile::objfile): Update.
16145         * psymtab.h (psymtab_storage::obstack): Update.
16146         (psymtab_storage::m_obstack): Use gdb::optional.
16147         (class psymtab_storage): Update comment.  Remove objfile
16148         parameter.
16149         * psymtab.c (psymtab_storage::psymtab_storage): Update.
16150
16151 2019-01-10  Tom Tromey  <tom@tromey.com>
16152
16153         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16154         <free_psymtabs>: Now private.
16155         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16156         (allocate_psymtab): Use new method.
16157
16158 2019-01-10  Tom Tromey  <tom@tromey.com>
16159
16160         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16161         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16162         * mdebugread.c (parse_partial_symbols): Use
16163         allocate_dependencies.
16164         * dwarf2read.c (dwarf2_create_include_psymtab): Use
16165         allocate_dependencies.
16166         (process_psymtab_comp_unit_reader)
16167         (build_type_psymtab_dependencies): Likewise.
16168         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16169
16170 2019-01-10  Tom Tromey  <tom@tromey.com>
16171
16172         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16173         PSYMBOL_SET_LANGUAGE.
16174         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16175
16176 2019-01-10  Tom Tromey  <tom@tromey.com>
16177
16178         * psymtab.h (psymtab_storage::obstack): New method.
16179         <m_obstack>: Rename from obstack; now private.
16180         * psymtab.c (psymtab_storage): Update.
16181         * dwarf2read.c (create_addrmap_from_index)
16182         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16183         Update.
16184
16185 2019-01-10  Tom Tromey  <tom@tromey.com>
16186
16187         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16188         * objfiles.h (objfile::reset_psymtabs): New method.
16189
16190 2019-01-10  Tom Tromey  <tom@tromey.com>
16191
16192         * symmisc.c (print_symbol_bcache_statistics): Update.
16193         (print_objfile_statistics): Update.
16194         * symfile.c (reread_symbols): Update.
16195         * psymtab.h (class psymtab_storage): New.
16196         * psymtab.c (psymtab_storage): New constructor.
16197         (~psymtab_storage): New destructor.
16198         (require_partial_symbols): Update.
16199         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16200         (find_pc_sect_psymtab, find_pc_sect_psymbol)
16201         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16202         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16203         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16204         (start_psymtab_common, end_psymtab_common)
16205         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16206         (allocate_psymtab): Update.
16207         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16208         Update.
16209         (dump_psymtab_addrmap, maintenance_print_psymbols)
16210         (maintenance_check_psymtabs): Update.
16211         (class objfile_psymtabs): Move to objfiles.h.
16212         * psympriv.h (discard_psymtab): Now inline.
16213         (psymtab_discarder::psymtab_discarder): Update.
16214         (psymtab_discarder::~psymtab_discarder): Update.
16215         (ALL_OBJFILE_PSYMTABS): Rewrite.
16216         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16217         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16218         Remove fields.
16219         <partial_symtabs>: New field.
16220         (class objfile_psymtabs): Move from psymtab.h.  Update.
16221         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16222         psymbol_cache.
16223         (objfile::~objfile): Don't destroy psymbol_cache.
16224         * mdebugread.c (parse_partial_symbols): Update.
16225         * dwarf2read.c (create_addrmap_from_index)
16226         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16227         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16228         (add_partial_subprogram, dwarf2_ranges_read): Update.
16229         * dwarf-index-write.c (write_address_map)
16230         (write_one_signatured_type, recursively_write_psymbols)
16231         (class debug_names, class debug_names, write_psymtabs_to_index):
16232         Update.
16233
16234 2019-01-10  Tom Tromey  <tom@tromey.com>
16235
16236         * symtab.h (SYMBOL_SET_NAMES): Update.
16237         (symbol_set_names): Update.
16238         (MSYMBOL_SET_NAMES): Update.
16239         * symtab.c (symbol_set_names): Change argument to be an
16240         objfile_per_bfd_storage.
16241         * psymtab.c (add_psymbol_to_bcache): Update.
16242         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16243
16244 2019-01-10  Tom Tromey  <tom@tromey.com>
16245
16246         * symtab.c (create_demangled_names_hash): Change argument to be an
16247         objfile_per_bfd_storage.
16248         (symbol_set_names): Update.
16249
16250 2019-01-10  Tom Tromey  <tom@tromey.com>
16251
16252         * xcoffread.c (xcoff_initial_scan): Unconditionally call
16253         init_psymbol_list.
16254         * psymtab.c (init_psymbol_list): Do nothing if already called.
16255         * psympriv.h (init_psymbol_list): Add comment.
16256         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16257         init_psymbol_list.
16258         * dbxread.c (dbx_symfile_read): Unconditionally call
16259         init_psymbol_list.
16260
16261 2019-01-10  Tom Tromey  <tom@tromey.com>
16262
16263         * xcoffread.c (scan_xcoff_symtab): Update.
16264         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16265         "where".
16266         * mdebugread.c (parse_partial_symbols)
16267         (handle_psymbol_enumerators): Update.
16268         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16269         * dbxread.c (read_dbx_symtab): Update.
16270         * psympriv.h (psymbol_placement): New enum.
16271         (add_psymbol_to_list): Update.
16272
16273 2019-01-10  Tom Tromey  <tom@tromey.com>
16274
16275         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16276         static_psymbols parameters.
16277         (scan_xcoff_symtab): Update.
16278         * psymtab.c (start_psymtab_common): Remove global_psymbols and
16279         static_psymbols parameters.
16280         * psympriv.h (start_psymtab_common): Update.
16281         * mdebugread.c (parse_partial_symbols): Update.
16282         * dwarf2read.c (create_partial_symtab): Update.
16283         * dbxread.c (read_dbx_symtab): Update.
16284         (start_psymtab): Remove global_psymbols and static_psymbols
16285         parameters.
16286
16287 2019-01-10  Tom Tromey  <tom@tromey.com>
16288
16289         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16290         * psymtab.c (allocate_psymtab): Add comment.
16291         * psympriv.h (allocate_psymtab): Add comment.
16292         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16293         initializations.
16294         * dbxread.c (dbx_end_psymtab): Remove some initializations.
16295
16296 2019-01-10  Tom Tromey  <tom@tromey.com>
16297
16298         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16299         Don't declare.
16300         * mipsread.c: Include mdebugread.h.
16301         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16302         Declare.
16303         * elfread.c: Include mdebugread.h.
16304
16305 2019-01-09  Tom Tromey  <tom@tromey.com>
16306
16307         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16308         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16309         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16310         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16311         (psym_lookup_symbol, psym_find_last_source_symtab)
16312         (psym_forget_cached_source_info, psym_print_stats)
16313         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16314         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16315         (psym_map_matching_symbols, psym_expand_symtabs_matching)
16316         (psym_find_compunit_symtab_by_address)
16317         (maintenance_print_psymbols, maintenance_info_psymtabs)
16318         (maintenance_check_psymtabs): Use ranged for.
16319         * psymtab.h (class objfile_psymtabs): New.
16320         (require_partial_symbols): Return objfile_psymtabs.
16321         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16322
16323 2019-01-09  Tom Tromey  <tom@tromey.com>
16324
16325         * symfile.c (overlay_invalidate_all, find_pc_overlay)
16326         (find_pc_mapped_section, list_overlays_command)
16327         (map_overlay_command, unmap_overlay_command)
16328         (simple_overlay_update): Use all_objfiles.
16329         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16330         * printcmd.c (info_symbol_command): Use all_objfiles.
16331         * objfiles.h (ALL_OBJSECTIONS): Remove.
16332         * maint.c (maintenance_translate_address): Use all_objfiles.
16333         * gcore.c (gcore_create_callback): Use all_objfiles.
16334         (objfile_find_memory_regions): Likewise.
16335
16336 2019-01-09  Tom Tromey  <tom@tromey.com>
16337
16338         * symtab.c (find_line_symtab, info_sources_command)
16339         (make_source_files_completion_list): Use objfile_compunits.
16340         * source.c (select_source_symtab): Use objfile_compunits.
16341         * objfiles.h (struct objfile): Update comment.
16342         (ALL_OBJFILES): Remove.
16343         (ALL_FILETABS): Remove.
16344         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16345         objfile_compunits.
16346
16347 2019-01-09  Tom Tromey  <tom@tromey.com>
16348
16349         * symmisc.c (print_objfile_statistics, dump_objfile)
16350         (maintenance_print_symbols): Use compunit_filetabs.
16351         * source.c (forget_cached_source_info_for_objfile): Use
16352         compunit_filetabs.
16353         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16354         (ALL_FILETABS): Use compunit_filetabs.
16355         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16356         * coffread.c (coff_symtab_read): Use compunit_filetabs.
16357
16358 2019-01-09  Tom Tromey  <tom@tromey.com>
16359
16360         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16361         (compunit_filetabs): New.
16362         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16363         compunit_filetabs.
16364         (info_sources_command, make_source_files_completion_list): Remove
16365         declaration.
16366         * symmisc.c (print_objfile_statistics, dump_objfile)
16367         (maintenance_print_symbols): Remove declaration.
16368         (maintenance_info_symtabs): Use compunit_filetabs.
16369         (maintenance_info_line_tables): Likewise.
16370         * source.c (select_source_symtab): Change local variable name.
16371         (forget_cached_source_info_for_objfile): Remove declaration.
16372         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16373         * objfiles.c (objfile_relocate1): Remove declaration.
16374         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16375         declaration.
16376         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16377         * coffread.c (coff_symtab_read): Remove declaration.
16378         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16379         compunit_filetabs.
16380
16381 2019-01-09  Tom Tromey  <tom@tromey.com>
16382
16383         * symtab.c (lookup_objfile_from_block)
16384         (find_pc_sect_compunit_symtab, search_symbols)
16385         (default_collect_symbol_completion_matches_break_on): Use
16386         objfile_compunits.
16387         * objfiles.h (ALL_COMPUNITS): Remove.
16388         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16389         * cp-support.c (add_symbol_overload_list_qualified): Use
16390         objfile_compunits.
16391         * ada-lang.c (ada_collect_symbol_completion_matches)
16392         (ada_add_global_exceptions): Use objfile_compunits.
16393
16394 2019-01-09  Tom Tromey  <tom@tromey.com>
16395
16396         * source.c (select_source_symtab)
16397         (forget_cached_source_info_for_objfile): Remove declaration.
16398         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16399         declaration.
16400         * maint.c (count_symtabs_and_blocks): Remove declaration.
16401         * cp-support.c (add_symbol_overload_list_qualified): Remove
16402         declaration.
16403         * coffread.c (coff_symtab_read): Remove declaration.
16404         * symtab.c (lookup_symbol_in_objfile_symtabs)
16405         (basic_lookup_transparent_type_1): Use objfile_compunits.
16406         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16407         (info_sources_command, search_symbols)
16408         (default_collect_symbol_completion_matches_break_on)
16409         (make_source_files_completion_list): Remove declaration.
16410         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16411         (ada_collect_symbol_completion_matches)
16412         (ada_add_global_exceptions): Remove declaration.
16413         * linespec.c (iterate_over_all_matching_symtabs): Use
16414         objfile_compunits.
16415         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16416         (class objfile_compunits): New.
16417         (ALL_COMPUNITS): Use objfile_compunits.
16418         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16419         (maintenance_check_symtabs, maintenance_info_line_tables): Use
16420         objfile_compunits.
16421         * objfiles.c (objfile_relocate1): Use objfile_compunits.
16422
16423 2019-01-09  Tom Tromey  <tom@tromey.com>
16424
16425         * symtab.c (search_symbols)
16426         (default_collect_symbol_completion_matches_break_on): Use
16427         objfile_msymbols.
16428         * ada-lang.c (ada_lookup_simple_minsym)
16429         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16430         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16431         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16432         objfile_msymbols.
16433         * coffread.c (coff_symfile_read): Use objfile_msymbols.
16434         * symmisc.c (dump_msymbols): Use objfile_msymbols.
16435         * objc-lang.c (find_methods): Use objfile_msymbols.
16436         (info_selectors_command, info_classes_command): Likewise.
16437         * stabsread.c (scan_file_globals): Use objfile_msymbols.
16438         * objfiles.h (class objfile_msymbols): New.
16439         (ALL_OBJFILE_MSYMBOLS): Remove.
16440         (ALL_MSYMBOLS): Remove.
16441
16442 2019-01-09  Tom Tromey  <tom@tromey.com>
16443
16444         * common/next-iterator.h (next_adapter): Add Iterator template
16445         parameter.
16446         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16447         (class all_objfiles_safe): New.
16448         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16449         * objfiles.c (put_objfile_before): Update comment.
16450         (add_separate_debug_objfile): Likewise.
16451         (free_all_objfiles): Use all_objfiles_safe.
16452         (objfile_purge_solibs): Likewise.
16453
16454 2019-01-09  Tom Tromey  <tom@tromey.com>
16455
16456         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16457         (expand_symtab_containing_pc, lookup_static_symbol)
16458         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16459         (find_symbol_at_address, find_line_symtab, find_main_name): Use
16460         all_objfiles.
16461         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16462         * breakpoint.c (create_overlay_event_breakpoint)
16463         (create_longjmp_master_breakpoint)
16464         (create_std_terminate_master_breakpoint)
16465         (create_exception_master_breakpoint): Use all_objfiles.
16466         * linux-thread-db.c (try_thread_db_load_from_pdir)
16467         (has_libpthread): Use all_objfiles.
16468         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16469         * linespec.c (iterate_over_all_matching_symtabs)
16470         (search_minsyms_for_name): Use all_objfiles.
16471         * maint.c (maintenance_info_sections): Use all_objfiles.
16472         * main.c (captured_main_1): Use all_objfiles.
16473         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16474         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16475         * guile/scm-pretty-print.c
16476         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16477         * solib-spu.c (append_ocl_sos): Use all_objfiles.
16478         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16479         (maintenance_print_msymbols): Use all_objfiles.
16480         * source.c (select_source_symtab): Use all_objfiles.
16481         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16482         * symfile.c (remove_symbol_file_command)
16483         (expand_symtabs_matching, map_symbol_filenames): Use
16484         all_objfiles.
16485         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16486         all_objfiles.
16487         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16488         * objc-lang.c (find_methods): Use all_objfiles.
16489         * objfiles.c (have_partial_symbols, have_full_symbols)
16490         (have_minimal_symbols, qsort_cmp)
16491         (default_iterate_over_objfiles_in_search_order): Use
16492         all_objfiles.
16493         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16494         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16495         (maintenance_check_psymtabs): Use all_objfiles.
16496         (ALL_PSYMTABS): Remove.
16497         * compile/compile-object-run.c (do_module_cleanup): Use
16498         all_objfiles.
16499         * blockframe.c (find_pc_partial_function): Use all_objfiles.
16500         * cp-support.c (add_symbol_overload_list_qualified): Use
16501         all_objfiles.
16502         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16503         Use all_objfiles.
16504         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16505         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16506         all_objfiles.
16507         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16508         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16509         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16510         Uses all_objfiles.
16511         * solib.c (solib_read_symbols): Use all_objfiles
16512
16513 2019-01-09  Tom Tromey  <tom@tromey.com>
16514
16515         * probe.c (parse_probes_in_pspace): Use all_objfiles.
16516         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16517         all_objfiles.
16518         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16519         * symmisc.c (print_symbol_bcache_statistics)
16520         (print_objfile_statistics, maintenance_print_objfiles)
16521         (maintenance_info_symtabs, maintenance_check_symtabs)
16522         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16523         all_objfiles.
16524         * source.c (forget_cached_source_info): Use all_objfiles.
16525         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16526         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16527         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16528         * objfiles.c (update_section_map): Use all_objfiles.
16529         (shared_objfile_contains_address_p): Likewise.
16530         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16531         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16532
16533 2019-01-09  Tom Tromey  <tom@tromey.com>
16534
16535         * common/next-iterator.h: New file.
16536         * objfiles.h (class all_objfiles): New.
16537         (struct objfile_iterator): New.
16538
16539 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16540
16541         * NEWS: Move the description of the changed "frame", "select-frame",
16542          and "info frame" commands to the Changed commands section.
16543
16544 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
16545
16546         * gdbtypes.c (check_stub_method_group): Remove handling of old
16547         mangling schemes.
16548         * linespec.c (find_methods): Likewise.
16549         * stabsread.c (read_member_functions): Likewise.
16550         * valops.c (search_struct_method): Likewise.
16551         (value_struct_elt_for_reference): Likewise.
16552         * NEWS: Mention this change.
16553
16554 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
16555
16556         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16557         print_source_lines.
16558         * source.c (print_source_lines_base): Update line number check.
16559         (print_source_lines): New function.
16560         (source_lines_range::source_lines_range): New function.
16561         * source.h (class source_lines_range): New class.
16562         (print_source_lines): New declaration.
16563
16564 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16565
16566         * linespec.c (linespec_state_destructor): Free self->canonical_names.
16567
16568 2019-01-08  Tom Tromey  <tom@tromey.com>
16569             Simon Marchi  <simon.marchi@ericsson.com>
16570
16571         PR gdb/24060
16572         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16573         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16574         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16575         * f-exp.y (DOLLAR_VARIABLE): Likewise.
16576         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16577         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16578
16579 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16580
16581         * source.c (select_source_symtab): Move header comment to
16582         declaration in source.h.
16583         (forget_cached_source_info_for_objfile): Likewise.
16584         (forget_cached_source_info): Likewise.
16585         (identify_source_line): Likewise.
16586         * source.h (identify_source_line): Move declaration from symtab.h
16587         and add comment from source.c
16588         (print_source_lines): Likewise.
16589         (forget_cached_source_info_for_objfile): Likewise.
16590         (forget_cached_source_info): Likewise.
16591         (select_source_symtab): Likewise.
16592         (enum print_source_lines_flag): Move definition from symtab.h.
16593         * symtab.h (identify_source_line): Move declaration to source.h.
16594         (print_source_lines): Likewise.
16595         (forget_cached_source_info_for_objfile): Likewise.
16596         (forget_cached_source_info): Likewise.
16597         (select_source_symtab): Likewise.
16598         (enum print_source_lines_flag): Move definition to source.h.
16599         * tui/tui-hooks.c: Add 'source.h' include.
16600
16601 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16602
16603         * source.c (print_source_lines_base): Handle requests to print
16604         reverse line number sequences, and guard against empty lines
16605         string.
16606
16607 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16608
16609         * source.c (print_source_lines_base): Fix skip of '\r' if next
16610         character is '\n'.
16611
16612 2019-01-06  Tom Tromey  <tom@tromey.com>
16613
16614         * c-exp.y (struct c_parse_state) <macro_original_text,
16615         expansion_obstack>: New member.
16616         (macro_original_text, expansion_obstack): Remove globals.
16617         (scan_macro_expansion, scanning_macro_expansion)
16618         (finished_macro_expansion): Update.
16619         (scan_macro_cleanup): Remove.
16620         (yylex, c_parse): Update.
16621
16622 2019-01-06  Tom Tromey  <tom@tromey.com>
16623
16624         * c-exp.y (struct c_parse_state) <strings>: New member.
16625         (operator_stoken): Update.
16626
16627 2019-01-06  Tom Tromey  <tom@tromey.com>
16628
16629         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
16630         (union type_stack_elt) <typelist_val>: Now a pointer to
16631         std::vector.
16632         (type_stack_cleanup): Don't declare.
16633         (push_typelist): Update.
16634         * parse.c (pop_typelist): Return a std::vector.
16635         (push_typelist): Take a std::vector.
16636         (follow_types): Update.  Do not free args.
16637         (type_stack_cleanup): Remove.
16638         * c-exp.y (struct c_parse_state): New.
16639         (cpstate): New global.
16640         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16641         (nonempty_typelist): Update.
16642         (func_mod): Create a new vector.
16643         (c_parse): Create a c_parse_state.
16644         (check_parameter_typelist): Do not delete params.
16645         (function_method): Update.  Do not delete type_list.
16646
16647 2019-01-06  Tom Tromey  <tom@tromey.com>
16648
16649         PR gdb/28155:
16650         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16651         check_typedef.
16652         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16653         (print_return_value): Likewise.
16654
16655 2019-01-05  Tom Tromey  <tom@tromey.com>
16656
16657         * contrib/cleanup_check.py: Remove.
16658         * contrib/gcc-with-excheck: Remove.
16659         * contrib/exsummary.py: Remove.
16660         * contrib/excheck.py: Remove.
16661
16662 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
16663
16664         * thread.c (delete_thread_1): Add gdb_assert that THR is not
16665         NULL. Initialize tpprev to NULL instead of assigning it
16666         to NULL on the next statement.
16667         * windows-nat.c (windows_delete_thread): Remove check for
16668         main_thread_id before printing thread exit notifications.
16669         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16670         Remove thread ID check against main_thread_id.
16671         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16672         windows_delete_thread.
16673         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16674
16675 2019-01-04  Tom Tromey  <tom@tromey.com>
16676
16677         * compile/compile.c (_initialize_compile): Use upper case for
16678         metasyntactic variables.
16679         * symmisc.c (_initialize_symmisc): Use upper case for
16680         metasyntactic variables.
16681         * psymtab.c (_initialize_psymtab): Use upper case for
16682         metasyntactic variables.
16683         * demangle.c (demangle_command): Use upper case for metasyntactic
16684         variables.
16685         (_initialize_demangler): Likewise.
16686         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16687         variables.
16688
16689 2019-01-03  Tom Tromey  <tom@tromey.com>
16690
16691         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16692
16693 2019-01-03  Tom Tromey  <tom@tromey.com>
16694
16695         * python/py-symtab.c (salpy_str): Update.
16696         (struct salpy_sal_object) <symtab>: Now a PyObject.
16697         (salpy_dealloc): Update.
16698         (del_objfile_sal): Use gdbpy_ref.
16699
16700 2019-01-03  Tom Tromey  <tom@tromey.com>
16701
16702         * python/py-type.c (convert_field): Use new_reference.  Return
16703         gdbpy_ref.
16704         (make_fielditem): Return gdbpy_ref.
16705         (typy_fields): Update.
16706         (typy_getitem): Update.
16707         (field_name): Return gdbpy_ref.  Use new_reference.
16708         (typy_iterator_iternext): Update.
16709
16710 2019-01-03  Tom Tromey  <tom@tromey.com>
16711
16712         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16713
16714 2019-01-03  Tom Tromey  <tom@tromey.com>
16715
16716         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16717         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16718         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16719         (pspy_set_frame_filters, pspy_set_frame_unwinders)
16720         (pspy_set_type_printers): Likewise.
16721         * python/py-function.c (fnpy_init): Use gdbpy_ref.
16722         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16723         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16724         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16725         (objfpy_set_type_printers): Likewise.
16726
16727 2019-01-03  Tom Tromey  <tom@tromey.com>
16728
16729         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16730         (gdbpy_print_stack): Use gdbpy_err_fetch.
16731         * python/python-internal.h (class gdbpy_err_fetch): New class.
16732         (class gdbpy_enter) <m_error_type, m_error_value,
16733         m_error_traceback>: Remove.
16734         <m_error>: New member.
16735         (gdbpy_exception_to_string): Don't declare.
16736         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16737         * python/py-value.c (convert_value_from_python): Use
16738         gdbpy_err_fetch.
16739         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16740         gdbpy_exception_to_string.
16741         (gdbpy_handle_exception): Use gdbpy_err_fetch.
16742         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16743         gdbpy_err_fetch.
16744
16745 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16746
16747         * linux-nat.c (delete_lwp_cleanup): Delete.
16748         (struct lwp_deleter): New struct.
16749         (lwp_info_up): New typedef.
16750         (linux_nat_target::follow_fork): Delete cleanup, and make use of
16751         lwp_info_up.
16752
16753 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16754
16755         * linux-fork.c (class scoped_switch_fork_info): New class.
16756         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16757
16758 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16759
16760         * valops.c (find_overload_match): Remove use of null_cleanup, and
16761         calls to do_cleanups.
16762
16763 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16764
16765         * compile/compile-cplus-types.c
16766         (compile_cplus_instance::decl_name): Handle changes to
16767         cp_func_name.
16768         * cp-support.c (cp_func_name): Update header comment, update
16769         return type.
16770         * cp-support.h (cp_func_name): Update return type in declaration.
16771         * valops.c (find_overload_match): Move temp_func local to top
16772         level of function and change its type.  Use temp_func to hold and
16773         delete temporary string obtained from cp_func_name.
16774
16775 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16776
16777         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16778         gdb::char_vector, remove cleanup, and update uses of `msg`.
16779
16780 2019-01-03  Jim Wilson  <jimw@sifive.com>
16781
16782         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16783
16784 2019-01-02  Tom Tromey  <tom@tromey.com>
16785
16786         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16787         (tdesc_parse_xml): Remove cleanups.
16788         * target-descriptions.h (make_cleanup_free_target_description):
16789         Don't declare.
16790         (target_desc_deleter): New struct.
16791         (target_desc_up): New typedef.
16792         * target-descriptions.c (target_desc_deleter::operator()): Rename
16793         from free_target_description.
16794         (make_cleanup_free_target_description): Remove.
16795
16796 2019-01-02  Tom Tromey  <tom@tromey.com>
16797
16798         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
16799         constructor, destructor.
16800         (linespec_parser): Remove typedef.
16801         (~linespec_parser): Rename from linespec_parser_delete.
16802         (linespec_lex_to_end, linespec_complete_label)
16803         (linespec_complete): Update.
16804         (decode_line_full): Remove cleanups.
16805         (decode_line_1): Update.
16806
16807 2019-01-02  Tom Tromey  <tom@tromey.com>
16808
16809         * python/python-internal.h (inferior_to_inferior_object): Change
16810         return type.
16811         * python/py-exitedevent.c (create_exited_event_object): Update.
16812         * python/py-inferior.c (inferior_to_inferior_object): Return
16813         gdbpy_ref.
16814         (python_new_inferior, python_inferior_deleted)
16815         (thread_to_thread_object, delete_thread_object)
16816         (build_inferior_list, gdbpy_selected_inferior): Update.
16817         * python/py-infthread.c (create_thread_object): Update.  Also fail
16818         if inferior_to_inferior_object fails.
16819
16820 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
16821
16822         * inferior.h (class inferior) <displaced_step_state>: New field.
16823         * infrun.h (struct displaced_step_state): Move here from
16824         infrun.c.  Initialize fields, add constructor.
16825         <inf>: Remove field.
16826         <reset>: New method.
16827         * infrun.c (struct displaced_step_inferior_state): Move to
16828         infrun.h.
16829         (displaced_step_inferior_states): Remove.
16830         (get_displaced_stepping_state): Adust.
16831         (displaced_step_in_progress_any_inferior): Adjust.
16832         (displaced_step_in_progress_thread): Adjust.
16833         (displaced_step_in_progress): Adjust.
16834         (add_displaced_stepping_state): Remove.
16835         (get_displaced_step_closure_by_addr): Adjust.
16836         (remove_displaced_stepping_state): Remove.
16837         (infrun_inferior_exit): Call displaced_step_state.reset.
16838         (use_displaced_stepping): Don't check for NULL.
16839         (displaced_step_prepare_throw): Call
16840         get_displaced_stepping_state.
16841         (displaced_step_fixup): Don't check for NULL.
16842         (prepare_for_detach): Don't check for NULL.
16843
16844 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16845
16846         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16847          in case of call that did not complete.
16848
16849 2019-01-02  Andrey Utkin  <autkin@undo.io>
16850
16851         * symfile.c (find_separate_debug_file): Fix search of debug files for
16852         remote debuggee.
16853
16854 2019-01-02  Tom Tromey  <tom@tromey.com>
16855
16856         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16857         indentation.
16858         * python/py-frame.c (frapy_older): Remove cast.
16859         (frapy_newer): Likewise.
16860         * python/py-breakpoint.c (local_setattro): Remove cast.
16861         * python/py-arch.c (archpy_name): Remove local variable.
16862         * python/py-type.c (gdbpy_lookup_type): Remove cast.
16863
16864 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
16865
16866         * unittests/basic_string_view/element_access/char/empty.cc:
16867         Fix year range in copyright header.
16868
16869 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
16870
16871         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16872         Delete.
16873         <operator==>: Update with for removed field.
16874         <hash>: Likewise.
16875         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16876         <isa_features>: ...this.
16877         <abi_features>: New field.
16878         (riscv_isa_flen): Update comment.
16879         (riscv_abi_xlen): New declaration.
16880         (riscv_abi_flen): New declaration.
16881         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16882         isa_features.
16883         (riscv_abi_xlen): New function.
16884         (riscv_isa_flen): Update to get answer from isa_features.
16885         (riscv_abi_flen): New function.
16886         (riscv_has_fp_abi): Update to get answer from abi_features.
16887         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16888         xlen and flen.
16889         (riscv_call_info) <xlen, flen>: Update comment.
16890         (riscv_call_arg_struct): Remove invalid assertions
16891         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16892         is removed.
16893         (riscv_gdbarch_init): Gather isa features and abi features
16894         separately, ensure both match on the gdbarch when reusing an old
16895         gdbarch.  Relax an error check to allow 32-bit abi float to run on
16896         a target with 64-bit float hardware.
16897
16898 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16899
16900         * source.c (search_command_helper): Stop reverse search
16901         when line 1 has been searched.
16902
16903 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16904
16905         * record-full.c (record_full_base_target::close): Rewrite
16906         record_full_core_buf_list free logic.
16907
16908 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16909
16910         * break-catch-syscall.c (print_one_catch_syscall): xfree
16911         the last text.
16912
16913 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16914
16915         * top.c (print_gdb_version): Update Copyright year in version
16916         message.
16917
16918 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16919
16920         Update copyright year range in all GDB files.
16921
16922 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
16923
16924         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16925
16926 For older changes see ChangeLog-2018.
16927 \f
16928 Local Variables:
16929 mode: change-log
16930 left-margin: 8
16931 fill-column: 74
16932 version-control: never
16933 coding: utf-8
16934 End:
16935