gdb/ChangeLog

   1 2019-12-20  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui.c (tui_show_source): Update.
   4         * tui/tui-winsource.c (tui_display_main): Update.
   5         * tui/tui-stack.h (tui_update_locator_fullname): Change parameter
   6         to symtab.
   7         * tui/tui-stack.c (tui_update_locator_fullname): Change parameter
   8         to symtab.
   9         * tui/tui-disasm.c (tui_show_disassem_and_update_source): Update.
  10
  11 2019-12-20  Tom Tromey  <tom@tromey.com>
  12
  13         PR tui/23619:
  14         * tui/tui-io.c (tui_rl_saved_prompt): Remove.
  15         (tui_redisplay_readline): Use rl_display_prompt.
  16         (tui_prep_terminal): Update.
  17
  18 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
  19
  20         * configure: Regenerate.
  21         * configure.ac: Quote variable arguments of test.
  22         * gdbsupport/common.m4: Likewise.
  23
  24 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
  25
  26         * score-tdep.c (score7_analyze_prologue): Pass 2.0 instead of
  27         2 to pow ().
  28
  29 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
  30
  31         * tui/tui-source.c (tui_source_window::set_contents): Cast argument of
  32         log10 to double to fix Solaris 11 with gcc 5.5.
  33
  34 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
  35
  36         * fbsd-tdep.c (fbsd_info_proc_files_entry): Rename local var
  37         "sun" to "saddr_un".
  38
  39 2019-12-19  Tom Tromey  <tromey@adacore.com>
  40
  41         * ui-out.h (enum class field_kind): Fix comment.
  42
  43 2019-12-11  Tom Tromey  <tromey@adacore.com>
  44
  45         * xml-support.c (xml_fetch_content_from_file): Use FOPEN_RB.
  46
  47 2019-12-18  Tom Tromey  <tromey@adacore.com>
  48
  49         PR build/25268:
  50         * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
  51         type on macOS.  Add comment.
  52
  53 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
  54
  55         * c-lang.c (c_get_string, asm_language_defn): Remove space
  56         before tab.
  57
  58 2019-12-18  Tom Tromey  <tromey@adacore.com>
  59
  60         PR build/25250:
  61         * ui-out.c (ui_out::vmessage): Update.
  62         * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
  63         Rename.
  64         (string_field): Update.
  65         (signed_field): Update.
  66
  67 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
  68
  69         * top.c (print_gdb_configuration): Adjust indentation.
  70
  71 2019-12-17  Christian Biesinger  <cbiesinger@google.com>
  72
  73         * bsd-kvm.c: Include gdbsupport/pathstuff.h.
  74
  75 2019-12-17  Simon Marchi  <simon.marchi@polymtl.ca>
  76
  77         * tui/tui-layout.h (class tui_layout_base): Add virtual
  78         destructor.
  79
  80 2019-12-16  Bernd Edlinger  <bernd.edlinger@hotmail.de>
  81
  82         * infcmd.c (prepare_one_step): Step over skipped inline functions.
  83         * infrun.c (inline_frame_is_marked_for_skip): New helper function.
  84         (process_event_stop_test): Keep stepping over skipped inline functions.
  85
  86 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  87
  88         * jit.c (struct gdb_block) <next>: Remove field.
  89         (struct gdb_symtab) <~gdb_symtab>: Remove.
  90         <blocks>: Change type to std::forward_list<gdb_block>.
  91         (compare_block): Remove.
  92         (jit_block_open_impl): Adjust to std::forward_list.  Place the new
  93         block at the beginning, don't mind about sorting.
  94         (finalize_symtab): Adjust to std::forward_list, sort the blocks list
  95         before using it.
  96
  97 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  98
  99         * jit.c (struct gdb_block): Add constructor, initialize
 100         real_block and next fields.
 101         <name>: Change type to gdb::unique_xmalloc_ptr.
 102         (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
 103         (jit_block_open_impl): Allocate gdb_block with new.
 104         (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
 105
 106 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 107
 108         * jit.c: Include forward_list.
 109         (struct gdb_symtab) <next>: Remove field.
 110         (struct gdb_object) <symtabs>: Change type to
 111         std::forward_list<gdb_symtab>.
 112         (jit_object_open_impl): Allocate gdb_object with new.
 113         (jit_symtab_open_impl): Adjust to std::forward_list.
 114         (finalize_symtab): Don't delete symtab.
 115         (jit_object_close_impl):  Adjust to std::forward_list.  Free
 116         gdb_object with delete.
 117
 118 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 119
 120         * jit.c (struct gdb_symtab): Add constructor, destructor,
 121         initialize fields.
 122         <linetable>: Change type to unique_xmalloc_ptr.
 123         <file_name>: Change type to std::string.
 124         (jit_symtab_open_impl): Allocate gdb_symtab with new.
 125         (jit_symtab_line_mapping_add_impl): Adjust.
 126         (finalize_symtab): Adjust, call delete on stab.
 127
 128 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 129
 130         * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
 131
 132 2019-12-16  Tom Tromey  <tromey@adacore.com>
 133
 134         * windows-nat.c (windows_nat_target::attach): Update.
 135         * remote.c (extended_remote_target::attach): Update.
 136         * procfs.c (procfs_target::attach): Update.
 137         * nto-procfs.c (nto_procfs_target::attach): Update.
 138         (nto_procfs_target::create_inferior): Update.
 139         * inf-ptrace.c (inf_ptrace_target::attach): Update.
 140         * gnu-nat.c (gnu_nat_target::attach): Update.
 141         (gnu_nat_target::detach): Update.
 142         * darwin-nat.c (darwin_nat_target::attach): Update.
 143         * corefile.c (get_exec_file): Constify result.  Remove extraneous
 144         return.
 145         * bsd-kvm.c (bsd_kvm_target_open): Update.
 146         * gdbsupport/common-inferior.h (get_exec_file): Constify result.
 147
 148 2019-12-16  Christian Biesinger  <cbiesinger@google.com>
 149
 150         * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
 151         (we no longer need to include time.h before pathmax.h)
 152
 153 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 154
 155         * ada-exp.y (write_ambiguous_var): Update.
 156         * coffread.c (process_coff_symbol): Update.
 157         * ctfread.c (ctf_add_enum_member_cb): Update.
 158         (new_symbol): Update.
 159         * dwarf2read.c (fixup_go_packaging): Update.
 160         (new_symbol): Update.
 161         * language.c (language_alloc_type_symbol): Update.
 162         * mdebugread.c (new_symbol): Update.
 163         * minsyms.c (minimal_symbol_reader::record_full): Update.
 164         * psymtab.c (add_psymbol_to_bcache): Update.
 165         * stabsread.c (define_symbol): Update.
 166         (read_enum_type): Update.
 167         * symtab.c (symbol_set_language): Make this a member function...
 168         (general_symbol_info::set_language): ... here.
 169         * symtab.h (struct general_symbol_info) <set_language>: New function.
 170         (SYMBOL_SET_LANGUAGE): Remove.
 171         (symbol_set_language): Remove.
 172
 173 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 174
 175         * ada-lang.c (ada_add_block_symbols): Update.
 176         (ada_collect_symbol_completion_matches): Update.
 177         * ax-gdb.c (gen_expr): Update.
 178         * block.c (block_lookup_symbol): Update.
 179         (block_lookup_symbol_primary): Update.
 180         (block_find_symbol): Update.
 181         * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
 182         * dbxread.c (process_one_symbol): Update.
 183         * dictionary.c (insert_symbol_hashed): Update.
 184         (collate_pending_symbols_by_language): Update.
 185         (mdict_add_symbol): Update.
 186         * dwarf-index-write.c (write_psymbols): Update.
 187         * dwarf2read.c (fixup_go_packaging): Update.
 188         * findvar.c (read_var_value): Update.
 189         * ft32-tdep.c (ft32_skip_prologue): Update.
 190         * go-lang.c (go_symbol_package_name): Update.
 191         * language.h (scoped_switch_to_sym_language_if_auto::
 192         scoped_switch_to_sym_language_if_auto): Update.
 193         * linespec.c (find_method): Update.
 194         (find_label_symbols_in_block): Update.
 195         * mdebugread.c (parse_symbol): Update.
 196         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 197         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 198         (minimal_symbol_reader::install): Update.
 199         * moxie-tdep.c (moxie_skip_prologue): Update.
 200         * parse.c (parse_exp_in_context): Update.
 201         * psymtab.c (psymbol_name_matches): Update.
 202         (match_partial_symbol): Update.
 203         (lookup_partial_symbol): Update.
 204         (psymbol_hash): Update.
 205         (psymbol_compare): Update.
 206         * python/py-framefilter.c (extract_sym): Update.
 207         (py_print_single_arg): Update.
 208         * stabsread.c (define_symbol): Update.
 209         * stack.c (print_frame_arg): Update.
 210         (find_frame_funname): Update.
 211         (info_frame_command_core): Update.
 212         * symfile.c (set_initial_language): Update.
 213         * symtab.c (symbol_set_demangled_name): Update.
 214         (symbol_get_demangled_name): Update.
 215         (symbol_set_language): Update.
 216         (symbol_find_demangled_name): Update.
 217         (symbol_set_names): Update.
 218         (general_symbol_info::natural_name): Update.
 219         (general_symbol_info::demangled_name): Update.
 220         (general_symbol_info::search_name): Update.
 221         (symbol_matches_search_name): Update.
 222         (eq_symbol_entry): Update.
 223         (iterate_over_symbols): Update.
 224         (completion_list_add_symbol): Update.
 225         (completion_list_add_msymbol): Update.
 226         (completion_list_add_fields): Update.
 227         * symtab.h (struct general_symbol_info) <language>: New function.
 228         <language>: Rename to...
 229         <m_language>: ...this.
 230         (SYMBOL_LANGUAGE): Remove.
 231         (MSYMBOL_LANGUAGE): Remove.
 232         (struct symbol) <ctor>: Update.
 233         * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
 234
 235 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 236
 237         * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
 238         set the language of sym.
 239         * language.c (language_alloc_type_symbol): Likewise.
 240
 241 2019-12-14  Sergio Durigan Junior  <sergiodj@redhat.com>
 242
 243         https://bugzilla.redhat.com/show_bug.cgi?id=1728147
 244         PR gdb/23613
 245         * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
 246         * corelow.c: Include 'gdbsupport/pathstuff.h'.
 247         (core_target_open): Use 'gdb_abspath'.
 248         * gdbsupport/pathstuff.c (gdb_abspath): Guard against
 249         'current_directory == NULL' case.
 250         * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
 251         explain what happens when 'current_directory' is NULL.
 252         * go32-nat.c (go32_nat_target::wait): Check if
 253         'current_directory' is NULL before call to 'chdir'.
 254         * source.c (add_path): Use 'gdb_abspath'.
 255         * top.c: Include 'gdbsupport/pathstuff.h'.
 256         (init_history): Use 'gdb_abspath'.
 257         (set_history_filename): Likewise.
 258         * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
 259         (tfile_target_open): Use 'gdb_abspath'.
 260
 261 2019-12-13  Tom Tromey  <tromey@adacore.com>
 262
 263         * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
 264         warning or error.
 265
 266 2019-12-13  Tom Tromey  <tromey@adacore.com>
 267
 268         * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
 269
 270 2019-12-13  Tom Tromey  <tromey@adacore.com>
 271
 272         * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
 273
 274 2019-12-13  Tom Tromey  <tromey@adacore.com>
 275
 276         * contrib/ari/gdb_ari.sh (usage): Use GNU style.
 277
 278 2019-12-13  Tom Tromey  <tromey@adacore.com>
 279
 280         * gdbsupport/common-utils.c (string_printf, string_vprintf)
 281         (string_vappendf): Add ARI comment.
 282
 283 2019-12-13  Tom Tromey  <tromey@adacore.com>
 284
 285         * contrib/ari/gdb_ari.sh: Remove "fix" call for
 286         floatformat_to_double.
 287         * target-float.c (host_float_ops<T>::from_target): Add ARI
 288         comment.
 289
 290 2019-12-13  Tom Tromey  <tromey@adacore.com>
 291
 292         * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
 293         * utils.c (abort_with_message, dump_core, internal_vproblem): Add
 294         ARI marker to abort.
 295         * event-top.c (handle_sigsegv): Add ARI marker to abort.
 296
 297 2019-12-13  Tom Tromey  <tromey@adacore.com>
 298
 299         * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
 300
 301 2019-12-13  Tom Tromey  <tromey@adacore.com>
 302
 303         * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
 304
 305 2019-12-13  Tom Tromey  <tromey@adacore.com>
 306
 307         * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
 308         checks.
 309
 310 2019-12-13  Tom Tromey  <tromey@adacore.com>
 311
 312         * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
 313         end>: No longer "const".
 314
 315 2019-12-13  Simon Marchi  <simon.marchi@polymtl.ca>
 316
 317         * jit.c: Fix indentation, replace spaces with tabs where
 318         applicable.
 319
 320 2019-12-13  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
 321
 322         * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
 323
 324 2019-12-12  Tom Tromey  <tom@tromey.com>
 325
 326         * objfiles.h (struct objfile) <partial_symtabs>: Now a
 327         unique_ptr.
 328
 329 2019-12-12  Tom Tromey  <tom@tromey.com>
 330
 331         * progspace.h (objfile_list): New typedef.
 332         (class unwrapping_objfile_iterator)
 333         (struct unwrapping_objfile_range): Newl
 334         (struct program_space) <objfiles_range>: Change type.
 335         <objfiles>: Change return type.
 336         <add_objfile>: Change type of "objfile" parameter.
 337         <objfiles_list>: Now a list of shared_ptr.
 338         * progspace.c (program_space::add_objfile): Change type of
 339         "objfile".  Update.
 340         (program_space::remove_objfile): Update.
 341         * objfiles.h (struct objfile) <~objfile>: Make public.
 342         * objfiles.c (objfile::make): Update.
 343         (objfile::unlink): Don't call delete.
 344
 345 2019-12-12  Tom Tromey  <tom@tromey.com>
 346
 347         * symfile.c (symbol_file_clear): Update.
 348         * progspace.h (struct program_space) <free_all_objfiles>: Declare
 349         method.
 350         * progspace.c (program_space::free_all_objfiles): New method.
 351         * objfiles.h (free_all_objfiles): Don't declare.
 352         * objfiles.c (free_all_objfiles): Move to program_space.
 353
 354 2019-12-12  Tom Tromey  <tom@tromey.com>
 355
 356         * progspace.c (program_space::add_objfile)
 357         (program_space::remove_objfile): Update.
 358         (program_space::multi_objfile_p): Remove.
 359         * objfiles.h (struct objfile) <next>: Remove.
 360         * objfiles.c (objfile::objfile): Update.
 361         (put_objfile_before): Update.
 362         (unlink_objfile): Update.
 363         * progspace.h (object_files): Remove.
 364         (struct program_space) <objfiles_head>: Remove.
 365         <objfiles_list>: New member.
 366         <objfiles_range, objfiles_safe_range>: Change type.
 367         (objfiles): Change return type.
 368         (objfiles_safe): Update.
 369         (multi_objfile_p): Rewrite and inline.
 370         (object_files): Remove macro.
 371
 372 2019-12-12  Tom Tromey  <tom@tromey.com>
 373
 374         * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify.  Add
 375         second constructor.
 376         (basic_safe_range): New class.
 377
 378 2019-12-12  Tom Tromey  <tom@tromey.com>
 379
 380         * progspace.c (program_space::multi_objfile_p): New method.
 381         * printcmd.c (info_symbol_command): Update.
 382         * maint.c (maintenance_translate_address): Update.
 383         * objfiles.h (MULTI_OBJFILE_P): Remove.
 384         * progspace.h (struct program_space) <multi_objfile_p>: New
 385         method.
 386
 387 2019-12-12  Tom Tromey  <tom@tromey.com>
 388
 389         * progspace.h (struct program_space) <remove_objfile>: Declare.
 390         * progspace.c (program_space::remove_objfile): New method.
 391         * objfiles.c (unlink_objfile): Remove.
 392         (objfile::unlink): Call remove_objfile.
 393         (objfile): Don't call unlink_objfile.
 394
 395 2019-12-12  Tom Tromey  <tom@tromey.com>
 396
 397         * progspace.h (struct program_space) <add_objfile>: Declare
 398         method.
 399         * progspace.c (program_space::add_objfile): New method.
 400         * objfiles.c (~objfile): Don't unlink objfile.
 401         (put_objfile_before): Remove.
 402         (add_separate_debug_objfile): Don't call put_objfile_before.
 403         (objfile::make): Call add_objfile.  Set new_objfiles_available on
 404         the per-program-space data.
 405
 406 2019-12-12  Tom Tromey  <tom@tromey.com>
 407
 408         * symfile.c (syms_from_objfile_1): Use objfile_up.
 409         (syms_from_objfile_1, remove_symbol_file_command): Call unlink
 410         method.
 411         (reread_symbols): Use objfile_up.
 412         * solib.c (update_solib_list, reload_shared_libraries_1): Call
 413         unlink method.
 414         * objfiles.h (struct objfile) <~objfile>: Now private.
 415         <unlink>: New method.
 416         (struct objfile_deleter): New.
 417         (objfile_up): New typedef.
 418         * objfiles.c (objfile::unlink): New method.
 419         (free_objfile_separate_debug, free_all_objfiles)
 420         (objfile_purge_solibs): Use it.
 421         * jit.c (jit_unregister_code): Remove.
 422         (jit_inferior_exit_hook, jit_event_handler): Call unlink on
 423         objfile.
 424         * compile/compile-object-run.c (do_module_cleanup): Call unlink on
 425         objfile.
 426         * compile/compile-object-load.c (compile_object_load): Use
 427         objfile_up.
 428
 429 2019-12-12  Tom Tromey  <tom@tromey.com>
 430
 431         * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
 432         objfile::make.
 433         * objfiles.h (struct objjfile) <make>: No longer inline.
 434         (add_separate_debug_objfile): Don't declare.
 435         * objfiles.c (add_separate_debug_objfile): Now static.
 436         (objfile::make): Move from objfiles.h.  Call
 437         add_separate_debug_objfile.  Add "parent" parameter.
 438
 439 2019-12-12  Tom Tromey  <tom@tromey.com>
 440
 441         * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
 442         * objfiles.h (struct objfile): Make constructor private.
 443         <make>: New static method.
 444         * jit.c (jit_object_close_impl): Update.
 445
 446 2019-12-12  Simon Marchi  <simon.marchi@polymtl.ca>
 447
 448         * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
 449         gdb::byte_vector.
 450
 451 2019-12-12  Tom Tromey  <tromey@adacore.com>
 452
 453         * xml-support.c (xml_fetch_content_from_file): Don't call
 454         malloc_failure.
 455         * utils.h (class gdb_argv): Remove malloc_failure comment.
 456         * utils.c (gdb_argv::reset): Don't call malloc_failure.
 457
 458 2019-12-12  Tom Tromey  <tromey@adacore.com>
 459
 460         * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
 461         (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
 462         (ALLDEPFILES): Add riscv-ravenscar-thread.c.
 463         * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
 464         * riscv-ravenscar-thread.c: New file.
 465         * riscv-ravenscar-thread.h: New file.
 466         * riscv-tdep.c (riscv_gdbarch_init): Call
 467         register_riscv_ravenscar_ops.
 468
 469 2019-12-12  Tom Tromey  <tromey@adacore.com>
 470
 471         * gdbsupport/thread-pool.c (set_thread_name): Use
 472         ATTRIBUTE_UNUSED.
 473
 474 2019-12-12  Luis Machado  <luis.machado@linaro.org>
 475
 476         * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
 477         (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
 478         macros.
 479
 480 2019-12-11  Tom Tromey  <tom@tromey.com>
 481
 482         * tui/tui-win.c (tui_set_win_height_command): Call
 483         tui_adjust_window_height.
 484         (tui_adjust_win_heights, new_height_ok): Remove.
 485         * tui/tui-layout.h (tui_adjust_window_height): Declare.
 486         * tui/tui-layout.c (tui_adjust_window_height): New function.
 487
 488 2019-12-11  Tom Tromey  <tom@tromey.com>
 489
 490         * tui/tui-win.c (tui_resize_all): Remove code, call
 491         tui_apply_current_layout.
 492
 493 2019-12-11  Tom Tromey  <tom@tromey.com>
 494
 495         * tui/tui-layout.h (tui_apply_current_layout): Declare.
 496         * tui/tui-layout.c (standard_layouts, applied_layout): New
 497         globals.
 498         (tui_apply_current_layout): New function.
 499         (show_layout): Set applied_layout.  Call
 500         tui_apply_current_layout.
 501         (show_source_command, show_disasm_command)
 502         (show_source_disasm_command, show_data)
 503         (show_source_or_disasm_and_command): Remove.
 504         (initialize_layouts): New function.
 505         (_initialize_tui_layout): Call initialize_layouts.
 506
 507 2019-12-11  Tom Tromey  <tom@tromey.com>
 508
 509         * tui/tui-layout.h (class tui_layout_base)
 510         (class tui_layout_window, class tui_layout_split): New.
 511         * tui/tui-layout.c (tui_get_window_by_name)
 512         (tui_layout_window::clone, tui_layout_window::apply)
 513         (tui_layout_window::get_sizes, tui_layout_window::add_split)
 514         (tui_layout_split::add_window, tui_layout_split::clone)
 515         (tui_layout_split::get_sizes)
 516         (tui_layout_split::set_weights_from_heights)
 517         (tui_layout_split::adjust_size, tui_layout_split::apply): New
 518         functions.
 519         (tui_layout_split::add_split, tui_layout_split::add_split)
 520         (tui_layout_split::set_weights_from_heights)
 521         (tui_layout_split::set_weights_from_heights): New functions.
 522
 523 2019-12-11  Tom Tromey  <tom@tromey.com>
 524
 525         * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
 526         * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
 527         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 528         * tui/tui-data.h (struct tui_point): Remove.
 529         (struct tui_gen_win_info) <origin>: Remove.
 530         <x, y>: New fields.
 531         * tui/tui-command.c (tui_cmd_window::resize): Update.
 532
 533 2019-12-11  Tom Tromey  <tom@tromey.com>
 534
 535         * tui/tui-stack.h (struct tui_locator_window) <min_height>:
 536         Implement.
 537         * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
 538         Implement.
 539         * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
 540         method.
 541         (struct tui_win_info) <min_height>: Implement.
 542
 543 2019-12-11  Tom Tromey  <tom@tromey.com>
 544
 545         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 546         (struct tui_win_info) <can_box>: Update.
 547
 548 2019-12-11  Tom Tromey  <tom@tromey.com>
 549
 550         * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
 551         method.
 552         * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
 553         method.
 554         * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
 555         method.
 556         (struct tui_win_info) <max_height>: Now override.
 557
 558 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 559
 560         * NEWS: Create a new section for the next release branch.
 561         Rename the section of the current branch, now that it has
 562         been cut.
 563
 564 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 565
 566         GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
 567         * version.in: Bump version to 10.0.50.DATE-git.
 568
 569 2019-12-11  Tom Tromey  <tromey@adacore.com>
 570
 571         PR build/25268:
 572         * gdbsupport/thread-pool.c (set_thread_name): New function.
 573         (thread_pool::set_thread_count): Don't call pthread_setname_np.
 574         (thread_pool::thread_function): Call set_thread_name.
 575
 576 2019-12-11  Tom Tromey  <tromey@adacore.com>
 577
 578         * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
 579         bfd_get_signed_8.
 580
 581 2019-12-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 582
 583         * NEWS: Document -raw-values option and the related setting commands.
 584         * printcmd.c (print_command_parse_format): Do not set opts->raw off,
 585         only set it on when /r is given.
 586         * valprint.c (value_print_option_defs): New element raw-values.
 587         * Makefile.in: Add the new file.
 588
 589 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 590
 591         * gdbsupport/safe-strerror.c: Supress the unused function warning
 592         for select_strerror_r.
 593
 594 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 595
 596         * config.in: Regenerate.
 597         * configure: Regenerate.
 598         * gdbsupport/agent.c (gdb_connect_sync_socket): Call
 599         safe_strerror instead of strerror.
 600         * gdbsupport/common.m4: Don't check for strerror.
 601         * gdbsupport/safe-strerror.c: Support both the glibc version
 602         of strerror_r and the XSI version.
 603
 604 2019-12-10  Tom Tromey  <tromey@adacore.com>
 605
 606         * ada-typeprint.c (print_choices): Use a single "?".
 607         (print_variant_part): Print "?" if the discriminant name
 608         is not known.
 609
 610 2019-12-10  George Barrett  <bob@bob131.so>
 611
 612         Fix scripted probe breakpoints.
 613         * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
 614         declaration forward.
 615         (breakpoint_ops_for_event_location_type)
 616         (breakpoint_ops_for_event_location): Add function definitions.
 617         (break_command_1, trace_command): Use
 618         breakpoint_ops_for_event_location.
 619         * breakpoint.h (breakpoint_ops_for_event_location): Add function
 620         declarations.
 621         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
 622         breakpoint_ops_for_event_location.
 623         * python/py-breakpoint.c (bppy_init): Use
 624         breakpoint_ops_for_event_location.
 625
 626 2019-12-09  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 627
 628         * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
 629         when ranking an lvalue argument for an rvalue parameter.
 630
 631 2019-12-08  Wataru Ashihara  <wataash@wataash.com>
 632
 633         * darwin-nat.c (darwin_nat_target::create_inferior): Fix
 634         template argument for scoped_restore_tmpl from bool to int.
 635
 636 2019-12-07  Keith Seitz  <keiths@redhat.com>
 637
 638         * build-id.c (build_id_bfd_get): Permit bfd_core, too.
 639         (build_id_to_debug_bfd): Make static, rewriting to use
 640         build_id_to_bfd_suffix.
 641         (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
 642         adding `suffix' parameter. Append SUFFIX to file names
 643         when searching for matching files.
 644         (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
 645         (build_id_to_exec_bfd): Likewise.
 646         * build-id.h (build_id_to_debug_bfd): Clarify that function
 647         searches for BFD of debug info file.
 648         (build_id_to_exec_bfd): Declare.
 649         * corelow.c: Include build-id.h.
 650         (locate_exec_from_corefile_build_id): New function.
 651         (core_target_open): If no executable BFD is found,
 652         search for a core file BFD using build-id.
 653
 654 2019-12-06  Christian Biesinger  <cbiesinger@google.com>
 655
 656         * bcache.c: Put in namespace gdb.
 657         * bcache.h: Likewise.
 658         * gdbtypes.c (check_types_worklist): Update.
 659         (types_deeply_equal): Update.
 660         * macrotab.c (struct macro_table) <bcache>: Update.
 661         (new_macro_table): Update.
 662         * macrotab.h (struct bcache): Put this forward declaration
 663         inside namespace gdb.
 664         (new_macro_table): Update.
 665         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
 666         Update.
 667         <macro_cache>: Update.
 668         * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
 669
 670 2019-12-06  Tom de Vries  <tdevries@suse.de>
 671
 672         PR symtab/24971
 673         * block.c (best_symbol, better_symbol): New function.
 674         (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
 675         decl.
 676
 677 2019-12-06  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 678
 679         * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
 680         * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
 681         for ranking see-through reference cases.
 682
 683 2019-12-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 684         * stack.c (faas_command): Check a command is provided.
 685         * thread.c (taas_command, tfaas_command): Likewise.
 686
 687 2019-12-05  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 688         * inferior.c (prune_inferiors):  Only call delete_inferior,
 689         Do not modify the inferior list.
 690
 691 2019-12-05  Simon Marchi  <simon.marchi@polymtl.ca>
 692
 693         * c-exp.y: Update calls to lookup_typename,
 694         lookup_signed_typename and lookup_unsigned_typename.
 695         * c-lang.c (evaluate_subexp_c): Likewise.
 696         * cp-namespace.c (cp_lookup_symbol_imports_or_template):
 697         Likewise.
 698         * eval.c (binop_promote): Likewise.
 699         * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
 700         (lookup_unsigned_typename): Likewise.
 701         (lookup_signed_typename): Likewise.
 702         * gdbtypes.h (lookup_unsigned_typename): Likewise.
 703         (lookup_signed_typename): Likewise.
 704         (lookup_typename): Likewise.
 705         * guile/scm-type.c (tyscm_lookup_typename): Update calls to
 706         lookup_typename, lookup_signed_typename,
 707         lookup_unsigned_typename.
 708         * m2-exp.y: Likewise.
 709         * printcmd.c (printf_wide_c_string): Likewise.
 710         (ui_printf): Likewise.
 711         * python/py-type.c (typy_lookup_typename): Likewise.
 712         * python/py-xmethods.c (python_xmethod_worker::invoke):
 713         Likewise.
 714         * rust-exp.y: Likewise.
 715
 716 2019-12-04  Christian Biesinger  <cbiesinger@google.com>
 717
 718         * configure.nat (obsd64): Add missing files x86-nat.o and
 719         nat/x86-dregs.o.
 720
 721 2019-12-04  Tom Tromey  <tom@tromey.com>
 722
 723         * valprint.c (val_print_string): Use metadata_style.
 724         * go-valprint.c (print_go_string): Use metadata style.
 725         * p-valprint.c (pascal_object_print_static_field): Use metadata
 726         style.
 727         * cp-valprint.c (cp_print_static_field): Use metadata style.
 728
 729 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 730             Chris January  <chris.january@arm.com>
 731
 732         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
 733         tokens.
 734         (typebase): New patterns for complex, single/double precision, and
 735         single/double complex.
 736         (f77_keywords): Change token for complex keyword, and add single,
 737         double, and precision keywords.
 738
 739 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 740
 741         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
 742         "info io_registers".
 743
 744 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 745
 746         * regcache.c (cooked_read_test): Initialize thread list of
 747         mock_inferior.
 748
 749 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 750
 751         * aarch64-linux-tdep.c: Remove includes.
 752
 753 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 754
 755         * aarch64-tdep.c: Remove includes.
 756
 757 2019-12-04  Simon Marchi  <simon.marchi@efficios.com>
 758
 759         * filtered-iterator.h (filtered_iterator) <operator==,
 760         operator!=>: Compare wrapped iterators, not wrapped pointers.
 761         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 762         unittests/filtered_iterator-selftests.c.
 763         * unittests/filtered_iterator-selftests.c: New file.
 764
 765 2019-12-04  Tom Tromey  <tromey@adacore.com>
 766
 767         * gdbtypes.c (create_range_type): Inherit endianity
 768         from base type.
 769
 770 2019-12-04  Tom Tromey  <tromey@adacore.com>
 771
 772         * ada-lang.c (decode_constrained_packed_array)
 773         (ada_value_assign, value_assign_to_component): Update.
 774         * dwarf2loc.c (rw_pieced_value, access_memory)
 775         (dwarf2_compile_expr_to_ax): Update.
 776         * dwarf2read.c (dwarf2_add_field): Update.
 777         * eval.c (evaluate_subexp_standard): Update.
 778         * gdbarch.c, gdbarch.h: Rebuild.
 779         * gdbarch.sh (bits_big_endian): Remove.
 780         * gdbtypes.h (union field_location): Update comment.
 781         * target-descriptions.c (make_gdb_type): Update.
 782         * valarith.c (value_bit_index): Update.
 783         * value.c (struct value) <bitpos>: Update comment.
 784         (unpack_bits_as_long, modify_field): Update.
 785         * value.h (value_bitpos): Update comment.
 786
 787 2019-12-04  Tom Tromey  <tromey@adacore.com>
 788
 789         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
 790         endian-ness.
 791
 792 2019-12-04  Tom Tromey  <tromey@adacore.com>
 793
 794         * dwarf2read.c (dwarf2_init_float_type)
 795         (dwarf2_init_complex_target_type): Add byte_order parameter.
 796         (read_base_type): Compute byte order earlier.
 797         * gdbtypes.c (init_float_type): Add byte_order parameter.
 798         * gdbtypes.h (init_float_type): Add byte_order parameter.
 799
 800 2019-12-04  Tom Tromey  <tromey@adacore.com>
 801
 802         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
 803
 804 2019-12-04  Tom Tromey  <tromey@adacore.com>
 805
 806         * dwarf2read.c (process_structure_scope): Initialize
 807         "discr_offset".
 808
 809 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 810
 811         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
 812         add it into the search spec.
 813         (parse_max_results_option): New function.
 814         (mi_info_functions_or_variables): Parse -max-results flag and pass
 815         it to mi_symbol_info.
 816         (mi_cmd_symbol_info_modules): Likewise.
 817         (mi_cmd_symbol_info_types): Likewise.
 818         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
 819         return type to bool, change result container into a set, and don't
 820         add new results if we have enough already.
 821         (global_symbol_searcher::add_matching_msymbols): Change return
 822         type to bool, and don't add new results if we have enough already.
 823         (sort_search_symbols_remove_dups): Delete.
 824         (global_symbol_searcher::search): Early exit from search loop when
 825         we have enough results.  Use a std::set to collect the results
 826         from calling add_matching_symbols.
 827         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
 828         member function.
 829         (global_symbol_searcher) <m_max_search_results>: New member
 830         variable.
 831         (global_symbol_searcher) <add_matching_symbols>: Update header
 832         comment and change return type to bool.
 833         (global_symbol_searcher) <add_matching_msymbols>: Update header
 834         comment and change return type to bool.
 835
 836 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 837
 838         * symtab.c (symbol_search::compare_search_syms): Update header
 839         comment.
 840         (global_symbol_searcher::is_suitable_msymbol): New function.
 841         (global_symbol_searcher::expand_symtabs): New function.
 842         (global_symbol_searcher::add_matching_symbols): New function.
 843         (global_symbol_searcher::add_matching_msymbols): New function.
 844         (global_symbol_searcher::search): Move most of the content
 845         into the new functions above, and call them as needed.
 846         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
 847         function.
 848         (global_symbol_searcher) <add_matching_symbols>: New member
 849         function.
 850         (global_symbol_searcher) <add_matching_msymbols>: New member
 851         function.
 852         (global_symbol_searcher) <is_suitable_msymbol>: New member
 853         function.
 854
 855 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 856
 857         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
 858         -symbol-info-module-variables entries.
 859         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
 860         (mi_cmd_symbol_info_module_variables): Declare.
 861         * mi/mi-symbol-cmds.c
 862         (module_symbol_search_iterator): New typedef.
 863         (output_module_symbols_in_single_module_and_file): New function.
 864         (output_module_symbols_in_single_module): New function.
 865         (mi_info_module_functions_or_variables): New function.
 866         (mi_cmd_symbol_info_module_functions): New function.
 867         (mi_cmd_symbol_info_module_variables): New function.
 868         * NEWS: Mention new MI command.
 869
 870 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
 871
 872         * bcache.c (hash): Remove.
 873         (hash_continue): Remove.
 874         * bcache.h (hash): Remove.
 875         (hash_continue): Remove.
 876         (struct bcache) <ctor>: Update.
 877         * psymtab.c (psymbol_hash): Update.
 878         * stabsread.c (hashname): Update.
 879         * utils.h (fast_hash): Add an argument for a start value,
 880         defaulting to zero.
 881
 882 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 883         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
 884         (destroy_block_symbol_cache): New function.
 885         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
 886         (resize_symbol_cache): Likewise.
 887
 888 2019-12-02  Tom Tromey  <tom@tromey.com>
 889
 890         * unittests/tui-selftests.c (run_tests): Make conditional.
 891         (_initialize_tui_selftest): Make conditional.
 892
 893 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
 894
 895         * aix-thread.c (debug_aix_thread): Change type to bool.
 896
 897 2019-12-02  Luis Machado  <luis.machado@linaro.org>
 898
 899         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
 900
 901 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 902
 903         * dwarf2read.c (read_tag_string_type): Read the fields required to
 904         make a dynamic string, and possibly create a dynamic range for the
 905         string.
 906         (attr_to_dynamic_prop): Setup is_reference based on the type of
 907         attribute being processed.
 908         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
 909         (resolve_dynamic_array): Rename to...
 910         (resolve_dynamic_array_or_string): ...this, update header comment,
 911         and accept TYPE_CODE_STRING.
 912         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
 913
 914 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 915
 916         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
 917         of its implementation from...
 918         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
 919         the new function.
 920
 921 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 922
 923         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
 924         create a range with stride where appropriate.
 925         * f-valprint.c: Include 'gdbarch.h'.
 926         (f77_print_array_1): Take the stride into account when walking the
 927         array.  Also convert the stride into addressable units.
 928         * gdbtypes.c (create_range_type): Initialise the stride to
 929         constant zero.
 930         (create_range_type_with_stride): New function, initialise the
 931         range as normal, and then setup the stride.
 932         (has_static_range): Include the stride here.  Also change the
 933         return type to bool.
 934         (create_array_type_with_stride): Consider the range stride if the
 935         array isn't given its own stride.
 936         (resolve_dynamic_range): Resolve the stride if needed.
 937         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
 938         (struct range_bounds) <flag_is_byte_stride>: New member variable.
 939         (TYPE_BIT_STRIDE): Define.
 940         (TYPE_ARRAY_BIT_STRIDE): Define.
 941         (create_range_type_with_stride): Declare.
 942         * valarith.c (value_subscripted_rvalue): Take range stride into
 943         account when walking the array.
 944
 945 2019-12-01  Tom Tromey  <tom@tromey.com>
 946
 947         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
 948         specially.
 949
 950 2019-12-01  Tom Tromey  <tom@tromey.com>
 951
 952         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
 953         \0.
 954         * unittests/tui-selftests.c: New file.
 955         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
 956
 957 2019-12-01  Tom Tromey  <tom@tromey.com>
 958
 959         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
 960
 961 2019-12-01  Tom Tromey  <tom@tromey.com>
 962
 963         * NEWS: Document new settings.
 964         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
 965         * tui/tui-win.c (_initialize_tui_win): Add border style
 966         observers.
 967         * tui/tui-io.h (tui_apply_style): Declare.
 968         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
 969         longer static.
 970         (apply_ansi_escape, tui_set_reverse_mode): Update.
 971         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
 972         Add "skip_intensity" parameter.
 973         <changed>: New member.
 974         <do_set_value>: Declare.
 975         (tui_border_style, tui_active_border_style): Declare.
 976         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
 977         globals.
 978         (cli_style_option): Initialize "changed".
 979         (cli_style_option::do_set_value): New function.
 980         (cli_style_option::add_setshow_commands): Add "skip_intensity"
 981         parameter.  Update.
 982         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
 983         (_initialize_cli_style): Update.  Create TUI border style
 984         commands.
 985
 986 2019-12-01  Tom Tromey  <tom@tromey.com>
 987
 988         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
 989         parameter.
 990         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
 991         parameter.
 992         * tui/tui-win.h (compact_source): Declare.
 993         * tui/tui-win.c (compact_source): New global.
 994         (tui_set_compact_source, tui_show_compact_source): New functions.
 995         (_initialize_tui_win): Add "compact-source" setting.
 996         * tui/tui-source.c (tui_source_window::set_contents): Handle
 997         compact_source setting.
 998         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 999         * NEWS: Document new setting.
1000
1001 2019-11-30  Tom Tromey  <tom@tromey.com>
1002
1003         * dwarf2read.c (dwarf2_add_field): Include field offset when
1004         computing variant part length.
1005
1006 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1007         * NEWS:  Mention define-prefix.  Tell that command names can now
1008         contain a . character.
1009
1010 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1011
1012         * command.h (valid_cmd_char_p): Declare.
1013         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
1014         the check of valid command char.
1015         (find_command_name_length, valid_user_defined_cmd_name_p): Use
1016         valid_cmd_char_p.
1017         * cli/cli-script.c (validate_comname): Likewise.
1018         * completer.c (gdb_completer_command_word_break_characters):
1019         Do not remove . from the word break char, update comments.
1020         (complete_line_internal_1): Use valid_cmd_char_p.
1021         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
1022         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
1023
1024 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1025
1026         * cli/cli-script.c (do_define_command): Ensure a redefined
1027         prefix command is kept as a prefix command.
1028         (define_prefix_command): New function.
1029         (show_user_1): Report user defined prefixes.
1030         (_initialize_cli_script):  Create the new 'define-prefix' command.
1031         Add completers for 'define' and 'document'.
1032         * top.c (execute_command):  If command is a user-defined prefix only
1033         command, report the list of commands for this prefix command.
1034
1035 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1036
1037         * valops.c (find_oload_champ): Improve debug output.
1038
1039 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1040
1041         * valops.c (find_oload_champ): Print part of debug messages
1042         before the badness vector is std::move'd.
1043
1044 2019-11-28  Tom Tromey  <tom@tromey.com>
1045
1046         * value.c (creal_internal_fn): Fix comment.
1047
1048 2019-11-28  Tom Tromey  <tom@tromey.com>
1049
1050         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
1051         flag_bound_evaluated>: Now unsigned.
1052
1053 2019-11-28  Tom Tromey  <tom@tromey.com>
1054
1055         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1056         declare.
1057
1058 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
1059
1060         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1061         debug output.
1062         * jit.c (jit_unregister_code): Add debug print to match
1063         `jit_register_code`.
1064
1065 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1066
1067         * NEWS: Mention the new multithreaded symbol loading.
1068
1069 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1070
1071         * maint.c (n_worker_threads): Default to 0.
1072         (worker_threads_disabled): New function.
1073         * maint.h (worker_threads_disabled): New function.
1074         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1075         here if worker_threads_disabled () is true.
1076         (minimal_symbol_reader::install): Skip all threading if
1077         worker_threads_disabled () is true.
1078
1079 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1080
1081         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1082         hash code if possible.
1083         (add_minsym_to_demangled_hash_table): Likewise.
1084         (minimal_symbol_reader::install): Compute the hash codes for msymbol
1085         on the background thread.
1086         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1087         Add these fields.
1088
1089 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1090
1091         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1092         of the mangled name on the background thread.
1093         * symtab.c (symbol_set_names): Allow passing in the hash of the
1094         linkage_name.
1095         * symtab.h (symbol_set_names): Likewise.
1096
1097 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
1098
1099         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1100         physnames are computed for inherited DIEs.
1101
1102 2019-11-27  Tom Tromey  <tromey@adacore.com>
1103
1104         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1105         backslashes.
1106         * cp-support.c: Remove unnecessary backslashes.
1107
1108 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1109
1110         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1111         with sym->set_linkage_name.
1112         * coffread.c (coff_read_enum_type): Likewise.
1113         * mdebugread.c (parse_symbol): Likewise.
1114         * stabsread.c (patch_block_stabs): Likewise.
1115         (define_symbol): Likewise.
1116         (read_enum_type): Likewise.
1117         (common_block_end): Likewise.
1118         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1119         function.
1120         (SYMBOL_SET_LINKAGE_NAME): Remove.
1121         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1122         with sym->set_linkage_name.
1123
1124 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1125
1126         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1127         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1128         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1129         * NEWS: Mention new MI command.
1130
1131 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1132
1133         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1134         '-symbol-info-types', and '-symbol-info-variables'.
1135         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1136         (mi_cmd_symbol_info_types): Declare.
1137         (mi_cmd_symbol_info_variables): Declare.
1138         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1139         (output_debug_symbol): New function.
1140         (output_nondebug_symbol): New function.
1141         (mi_symbol_info): New function.
1142         (mi_info_functions_or_variables): New function.
1143         (mi_cmd_symbol_info_functions): New function.
1144         (mi_cmd_symbol_info_types): New function.
1145         (mi_cmd_symbol_info_variables): New function.
1146         * NEWS: Mention new commands.
1147
1148 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1149
1150         * symtab.c (symbol_to_info_string): New function, most content
1151         moved from print_symbol_info, but updated to return a std::string.
1152         (print_symbol_info): Update to use symbol_to_info_string and print
1153         returned string.
1154         * symtab.h (symbol_to_info_string): Declare new function.
1155
1156 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1157
1158         * python/python.c (gdbpy_rbreak): Convert to using
1159         global_symbol_searcher.
1160         * symtab.c (file_matches): Convert return type to bool, change
1161         file list to std::vector, update header comment.
1162         (search_symbols): Rename to...
1163         (global_symbol_searcher::search): ...this and update now its
1164         a member function of global_symbol_searcher.  Take account of the
1165         changes to file_matches.
1166         (symtab_symbol_info): Convert to using global_symbol_searcher.
1167         (rbreak_command): Likewise.
1168         (search_module_symbols): Likewise.
1169         * symtab.h (enum symbol_search): Update comment.
1170         (search_symbols): Remove declaration.
1171         (class global_symbol_searcher): New class.
1172
1173 2019-11-26  Tom Tromey  <tromey@adacore.com>
1174
1175         * cp-support.c (_initialize_cp_support): Conditionally initialize
1176         gdb_demangle_attempt_core_dump.
1177
1178 2019-11-26  Tom Tromey  <tom@tromey.com>
1179
1180         * python/py-function.c (fnpy_init): Update.
1181         * value.h (add_internal_function): Adjust declaration.
1182         * value.c (function_destroyer): Remove.
1183         (do_add_internal_function): Don't set destroyer or copy name.
1184         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1185         Set name_allocated.
1186         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1187         (cmdpy_init): Set name_allocated.
1188         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1189         member.
1190         (~cmd_list_element): Free "name" if needed.
1191
1192 2019-11-26  Tom Tromey  <tom@tromey.com>
1193
1194         * value.h (add_internal_function): Add new overload.  Move
1195         documentation from value.h.
1196         * value.c (do_add_internal_function): New function.
1197         (add_internal_function): Use it.  Add new overload.
1198         (function_destroyer): Don't free doc.
1199         * python/py-function.c (fnpy_init): Update.
1200
1201 2019-11-26  Tom Tromey  <tom@tromey.com>
1202
1203         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1204         (cmdpy_init): Set "doc_allocated".
1205
1206 2019-11-26  Tom Tromey  <tom@tromey.com>
1207
1208         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1209         name of worker thread.
1210         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1211         pthread_setname_np.
1212         * configure, config.in: Rebuild.
1213
1214 2019-11-26  Tom Tromey  <tom@tromey.com>
1215
1216         * python/python.c (class gdbpy_gil): New.
1217         (struct gdbpy_event): Add constructor, destructor, operator().
1218         (gdbpy_post_event): Use run_on_main_thread.
1219         (gdbpy_initialize_events): Remove.
1220         (do_start_initialization): Update.
1221
1222 2019-11-26  Tom Tromey  <tom@tromey.com>
1223
1224         * NEWS: Add entry.
1225         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1226         commands.  Call update_thread_pool_size.
1227         (update_thread_pool_size, maintenance_set_worker_threads): New
1228         functions.
1229         (n_worker_threads): New global.
1230
1231 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1232             Tom Tromey  <tom@tromey.com>
1233
1234         * minsyms.c (minimal_symbol_reader::install): Use
1235         parallel_for_each.
1236         * gdbsupport/parallel-for.h: New file.
1237         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1238
1239 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1240             Tom Tromey  <tom@tromey.com>
1241
1242         * gdbsupport/thread-pool.h: New file.
1243         * gdbsupport/thread-pool.c: New file.
1244         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1245         (HFILES_NO_SRCDIR): Add thread-pool.h.
1246
1247 2019-11-26  Tom Tromey  <tom@tromey.com>
1248
1249         * event-top.h (thread_local_segv_handler): Declare.
1250         * event-top.c (thread_local_segv_handler): New global.
1251         (install_handle_sigsegv, handle_sigsegv): New functions.
1252         (async_init_signals): Install SIGSEGV handler.
1253         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
1254         thread-local.
1255         (report_failed_demangle): New function.
1256         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
1257         handler-setting code, instead use segv_handler.  Run warning code
1258         on main thread.
1259
1260 2019-11-26  Tom Tromey  <tom@tromey.com>
1261
1262         * run-on-main-thread.c: New file.
1263         * run-on-main-thread.h: New file.
1264         * unittests/main-thread-selftests.c: New file.
1265         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1266         main-thread-selftests.c.
1267         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1268         (COMMON_SFILES): Add run-on-main-thread.c.
1269
1270 2019-11-26  Tom Tromey  <tom@tromey.com>
1271
1272         * main.c (setup_alternate_signal_stack): Remove.
1273         (captured_main_1): Use gdb::alternate_signal_stack.
1274         * gdbsupport/alt-stack.h: New file.
1275
1276 2019-11-26  Tom Tromey  <tom@tromey.com>
1277
1278         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1279         Remove comment.
1280         (save_original_signals_state, restore_original_signals_state): Use
1281         gdb_sigmask.
1282         * linux-nat.c (block_child_signals, restore_child_signals_mask)
1283         (_initialize_linux_nat): Use gdb_sigmask.
1284         * guile/guile.c (_initialize_guile): Use block_signals.
1285         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1286         * gdbsupport/gdb-sigmask.h: New file.
1287         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1288         * cp-support.c (gdb_demangle): Use gdb_sigmask.
1289         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1290         pthread_sigmask.
1291         * configure, config.in: Rebuild.
1292         * gdbsupport/block-signals.h: New file.
1293
1294 2019-11-26  Tom Tromey  <tom@tromey.com>
1295
1296         * acinclude.m4: Include ax_pthread.m4.
1297         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1298         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1299         (CLIBS): Use PTHREAD_LIBS.
1300         (aclocal_m4_deps): Add ax_pthread.m4.
1301         * config.in, configure: Rebuild.
1302         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1303
1304 2019-11-26  Tom Tromey  <tom@tromey.com>
1305
1306         * symtab.h (struct minimal_symbol) <name_set>: New member.
1307         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1308         Don't call symbol_set_names.
1309         (minimal_symbol_reader::install): Call symbol_set_names.
1310
1311 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1312
1313         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1314         restore_active_ext_lang, as GIL is needed for (indirectly)
1315         called PyOS_InterruptOccurred.
1316
1317 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1318
1319         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1320         definition.
1321
1322 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1323
1324         * remote-sim.c (simulator_command): Make static, remove
1325         declaration.
1326
1327 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1328
1329         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1330         static.
1331         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1332         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1333         (main): Likewise.
1334         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1335         (main): Likewise.
1336         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1337         (main): Likewise.
1338         * unittests/basic_string_view/element_access/char/1.cc (test01):
1339         Likewise.
1340         (main): Likewise.
1341         * unittests/basic_string_view/element_access/char/empty.cc (main):
1342         Likewise.
1343         * unittests/basic_string_view/element_access/char/front_back.cc
1344         (test01): Likewise.
1345         (main): Likewise.
1346         * unittests/basic_string_view/inserters/char/2.cc (test05):
1347         Likewise.
1348         (main): Likewise.
1349         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1350         (test01): Likewise.
1351         (main): Likewise.
1352         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1353         (test01): Likewise.
1354         (main): Likewise.
1355         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1356         Likewise.
1357         * unittests/basic_string_view/operations/compare/char/1.cc
1358         (test01): Likewise.
1359         (main): Likewise.
1360         * unittests/basic_string_view/operations/compare/char/13650.cc
1361         (test01): Likewise.
1362         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1363         Likewise.
1364         (main): Likewise.
1365         * unittests/basic_string_view/operations/data/char/1.cc (test01):
1366         Likewise.
1367         (main): Likewise.
1368         * unittests/basic_string_view/operations/find/char/1.cc (test01):
1369         Likewise.
1370         (main): Likewise.
1371         * unittests/basic_string_view/operations/find/char/2.cc (test02):
1372         Likewise.
1373         (main): Likewise.
1374         * unittests/basic_string_view/operations/find/char/3.cc (test03):
1375         Likewise.
1376         (main): Likewise.
1377         * unittests/basic_string_view/operations/find/char/4.cc (main):
1378         Likewise.
1379         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1380         Likewise.
1381         (main): Likewise.
1382         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1383         Likewise.
1384         (main): Likewise.
1385         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1386         Likewise.
1387         (main): Likewise.
1388         * unittests/basic_string_view/operations/substr/char/1.cc
1389         (test01): Likewise.
1390         (main): Likewise.
1391         * unittests/basic_string_view/operators/char/2.cc (main):
1392         Likewise.
1393         * unittests/optional/assignment/1.cc (test): Likewise.
1394         * unittests/optional/assignment/2.cc (test): Likewise.
1395         * unittests/optional/assignment/3.cc (test): Likewise.
1396         * unittests/optional/assignment/4.cc (test): Likewise.
1397         * unittests/optional/assignment/5.cc (test): Likewise.
1398         * unittests/optional/assignment/6.cc (test): Likewise.
1399         * unittests/optional/assignment/7.cc (test): Likewise.
1400         * unittests/optional/cons/copy.cc (test): Likewise.
1401         * unittests/optional/cons/default.cc (test): Likewise.
1402         * unittests/optional/cons/move.cc (test): Likewise.
1403         * unittests/optional/cons/value.cc (test): Likewise.
1404         * unittests/optional/in_place.cc (test): Likewise.
1405         * unittests/optional/observers/1.cc (test): Likewise.
1406         * unittests/optional/observers/2.cc (test): Likewise.
1407
1408 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1409
1410         * tui-win.h (tui_set_var_cmd): Remove.
1411         * tui-win.c (tui_set_var_cmd): Make static.
1412
1413 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1414
1415         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1416         rbreak_command_wrapper): Remove.
1417         * symtab.c (rbreak_command_wrapper): Remove.
1418
1419 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1420
1421         * inferior.h (info_terminal_command): Remove declaration.
1422         * inflow.c (info_terminal_command): Make static.
1423
1424 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1425
1426         * inferior.c (exit_inferior_silent): Remove.
1427
1428 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1429
1430         * dictionary.c (dict_empty, mdict_empty): Remove.
1431         * dictionary.c (mdict_empty): Remove.
1432
1433 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1434
1435          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1436          (arc_insn_get_memory_offset): Likewise.
1437          (arc_insn_dump): Likewise.
1438          * cp-support.c (test_cp_symbol_name_matches): Likewise.
1439          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1440          * dictionary.c (dict_iterator_next): Likewise.
1441          (dict_iter_match_first): Likewise.
1442          (dict_iter_match_next): Likewise.
1443          * f-lang.c (evaluate_subexp_f): Likewise.
1444          * hppa-tdep.c (hppa_read_pc): Likewise.
1445          * i386-tdep.c (i386_floatformat_for_type): Likewise.
1446          * parse.c (write_exp_elt_msym): Likewise.
1447          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1448          * remote.c (remote_packet_size): Likewise.
1449          (remote_notif_stop_parse): Likewise.
1450          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1451          * s12z-tdep.c (s12z_disassemble_info): Likewise.
1452          * source.c (prepare_path_for_appending): Likewise.
1453          * sparc64-linux-tdep.c
1454          (sparc64_linux_handle_segmentation_fault); Likewise.
1455          * stack.c (frame_selection_by_function_completer): Likewise.
1456
1457 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1458
1459         * completer.c (set_gdb_completion_word_break_characters):
1460         Remove.
1461
1462 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1463
1464         * dwarf-index-write.c: Include dwarf-index-write.h.
1465         * mi/mi-interp.c: Include mi/mi-interp.h.
1466
1467 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1468
1469         * aarch32-tdep.c: Include aarch32-tdep.h.
1470         * aarch32-tdep.h: Forward-declare struct target_desc.
1471
1472 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1473
1474         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1475         strerror.
1476         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1477         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1478
1479 2019-11-25  Tom de Vries  <tdevries@suse.de>
1480
1481         * contrib/words.sh: Add -c option.
1482
1483 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
1484
1485         * solib.c (solib_find_1): Change int to bool.
1486         (exec_file_find): Change int to bool.
1487         (solib_find): Change int to bool.
1488         (solib_read_symbols): Change int to bool.
1489         (solib_used): Change int to bool.
1490         (solib_add): Change int to bool.
1491         (info_sharedlibrary_command): Change int to bool.
1492         (solib_contains_address_p): Change int to bool.
1493         (solib_keep_data_in_core): Change int to bool.
1494         (in_solib_dynsym_resolve_code): Change int to bool.
1495         (reload_shared_libraries_1): Change int to bool.
1496         (gdb_sysroot_changed): Change int to bool.
1497         * solib.h (solib_read_symbols): Change int to bool.
1498         (solib_contains_address_p): Change int to bool.
1499         (solib_keep_data_in_core): Change int to bool.
1500         (in_solib_dynsym_resolve_code): Change int to bool.
1501         (libpthread_name_p): Change int to bool.
1502
1503 2019-11-25  Luis Machado  <luis.machado@linaro.org>
1504
1505         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1506         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1507         (remote_packet_max_chars): New static global.
1508         (show_remote_packet_max_chars): New function.
1509         (remote_target::putpkt_binary): Adjust to use new
1510         remote_packet_max_chars option.
1511         (remote_target::getpkt_or_notif_sane_1): Likewise.
1512         (_initialize_remote): Register new remote-packet-max-chars option.
1513
1514 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
1515
1516         * m68k-linux-nat.c: Include gdbarch.h.
1517
1518 2019-11-24  Tom Tromey  <tom@tromey.com>
1519
1520         * symfile.c (read_symbols): Update.
1521         * psymtab.c (require_partial_symbols): Change type of "verbose" to
1522         bool.
1523         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1524         (psym_lookup_symbol, psym_find_last_source_symtab)
1525         (psym_forget_cached_source_info, psym_print_stats)
1526         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1527         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1528         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1529         (psym_find_compunit_symtab_by_address)
1530         (maintenance_print_psymbols, maintenance_info_psymtabs)
1531         (maintenance_check_psymtabs): Update.
1532         * psymtab.h (require_partial_symbols): Change type of "verbose" to
1533         bool.
1534
1535 2019-11-22  Tom Tromey  <tom@tromey.com>
1536
1537         * observable.h: Update comments.
1538
1539 2019-11-22  Tom Tromey  <tromey@adacore.com>
1540
1541         * ada-tasks.c (ada_task_is_alive): Make parameter const.
1542         (print_ada_task_info): Don't try to fetch thread id if task is not
1543         alive.
1544
1545 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1546
1547         * ada-exp.y: Update.
1548         * ada-lang.c (sort_choices): Update.
1549         (ada_print_symbol_signature): Update.
1550         (resolve_subexp): Update.
1551         (ada_parse_renaming): Update.
1552         (ada_read_renaming_var_value): Update.
1553         (lesseq_defined_than): Update.
1554         (remove_extra_symbols): Update.
1555         (remove_irrelevant_renamings): Update.
1556         (ada_add_block_symbols): Update.
1557         (ada_collect_symbol_completion_matches): Update.
1558         (ada_is_renaming_symbol): Update.
1559         (aggregate_assign_from_choices): Update.
1560         (ada_evaluate_subexp): Update.
1561         (ada_has_this_exception_support): Update.
1562         (ada_is_non_standard_exception_sym): Update.
1563         (ada_add_exceptions_from_frame): Update.
1564         (ada_add_global_exceptions): Update.
1565         (ada_print_subexp): Update.
1566         * ax-gdb.c (gen_var_ref): Update.
1567         (gen_maybe_namespace_elt): Update.
1568         (gen_expr_for_cast): Update.
1569         (gen_expr): Update.
1570         * block.h: Update.
1571         * blockframe.c (find_pc_partial_function): Update.
1572         * breakpoint.c (print_breakpoint_location): Update.
1573         (update_static_tracepoint): Update.
1574         * btrace.c (ftrace_print_function_name): Update.
1575         (ftrace_function_switched): Update.
1576         * buildsym.c (find_symbol_in_list): Update.
1577         * c-exp.y: Update.
1578         * c-typeprint.c (c_print_typedef): Update.
1579         (c_type_print_template_args): Update.
1580         * cli/cli-cmds.c (edit_command): Update.
1581         (list_command): Update.
1582         (print_sal_location): Update.
1583         * coffread.c (patch_opaque_types): Update.
1584         (process_coff_symbol): Update.
1585         (coff_read_enum_type): Update.
1586         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1587         (convert_one_symbol): Update.
1588         (hash_symname): Update.
1589         (eq_symname): Update.
1590         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1591         * compile/compile-cplus-types.c (debug_print_scope): Update.
1592         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1593         * compile/compile-object-load.c (get_out_value_type): Update.
1594         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1595         (search_symbol_list): Update.
1596         (cp_lookup_symbol_imports_or_template): Update.
1597         * cp-support.c (overload_list_add_symbol): Update.
1598         * ctfread.c (psymtab_to_symtab): Update.
1599         * dbxread.c (cp_set_block_scope): Update.
1600         * dictionary.c (iter_match_first_hashed): Update.
1601         (iter_match_next_hashed): Update.
1602         (insert_symbol_hashed): Update.
1603         (iter_match_next_linear): Update.
1604         * dictionary.h: Update.
1605         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1606         (locexpr_describe_location_piece): Update.
1607         (locexpr_describe_location_1): Update.
1608         (locexpr_generate_c_location): Update.
1609         (loclist_describe_location): Update.
1610         (loclist_generate_c_location): Update.
1611         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1612         (read_func_scope): Update.
1613         (process_enumeration_scope): Update.
1614         (new_symbol): Update.
1615         (dwarf2_const_value): Update.
1616         (dwarf2_symbol_mark_computed): Update.
1617         * eval.c (evaluate_funcall): Update.
1618         (evaluate_subexp_standard): Update.
1619         * expprint.c (print_subexp_standard): Update.
1620         (dump_subexp_body_standard): Update.
1621         * f-valprint.c (info_common_command_for_block): Update.
1622         * findvar.c (get_hosting_frame): Update.
1623         (default_read_var_value): Update.
1624         * go-lang.c (go_symbol_package_name): Update.
1625         * guile/scm-block.c (bkscm_print_block_smob): Update.
1626         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1627         (gdbscm_symbol_name): Update.
1628         (gdbscm_symbol_linkage_name): Update.
1629         (gdbscm_symbol_print_name): Update.
1630         * infcall.c (get_function_name): Update.
1631         * infcmd.c (jump_command): Update.
1632         (finish_command): Update.
1633         * infrun.c (insert_exception_resume_breakpoint): Update.
1634         * linespec.c (canonicalize_linespec): Update.
1635         (create_sals_line_offset): Update.
1636         (convert_linespec_to_sals): Update.
1637         (complete_label): Update.
1638         (find_label_symbols_in_block): Update.
1639         * m2-typeprint.c (m2_print_typedef): Update.
1640         * mdebugread.c (mdebug_reg_to_regnum): Update.
1641         (parse_symbol): Update.
1642         (mylookup_symbol): Update.
1643         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1644         (list_args_or_locals): Update.
1645         * objc-lang.c (compare_selectors): Update.
1646         (info_selectors_command): Update.
1647         (compare_classes): Update.
1648         (info_classes_command): Update.
1649         (find_imps): Update.
1650         * p-typeprint.c (pascal_print_typedef): Update.
1651         * printcmd.c (build_address_symbolic): Update.
1652         (info_address_command): Update.
1653         (print_variable_and_value): Update.
1654         * python/py-framefilter.c (extract_sym): Update.
1655         (py_print_single_arg): Update.
1656         * python/py-symbol.c (sympy_str): Update.
1657         (sympy_get_name): Update.
1658         (sympy_get_linkage_name): Update.
1659         * python/python.c (gdbpy_rbreak): Update.
1660         * record-btrace.c (btrace_get_bfun_name): Update.
1661         (btrace_call_history): Update.
1662         * rust-lang.c (rust_print_typedef): Update.
1663         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1664         * stabsread.c (stab_reg_to_regnum): Update.
1665         (define_symbol): Update.
1666         (read_enum_type): Update.
1667         (common_block_end): Update.
1668         (cleanup_undefined_types_1): Update.
1669         (scan_file_globals): Update.
1670         * stack.c (print_frame_arg): Update.
1671         (print_frame_args): Update.
1672         (find_frame_funname): Update.
1673         (info_frame_command_core): Update.
1674         (iterate_over_block_locals): Update.
1675         (print_block_frame_labels): Update.
1676         (do_print_variable_and_value): Update.
1677         (iterate_over_block_arg_vars): Update.
1678         (return_command): Update.
1679         * symmisc.c (dump_symtab_1): Update.
1680         (print_symbol): Update.
1681         * symtab.c (eq_symbol_entry): Update.
1682         (symbol_cache_dump): Update.
1683         (lookup_language_this): Update.
1684         (find_pc_sect_line): Update.
1685         (skip_prologue_sal): Update.
1686         (symbol_search::compare_search_syms): Update.
1687         (treg_matches_sym_type_name): Update.
1688         (search_symbols): Update.
1689         (print_symbol_info): Update.
1690         (rbreak_command): Update.
1691         (completion_list_add_symbol): Update.
1692         (find_gnu_ifunc): Update.
1693         (get_symbol_address): Update.
1694         (search_module_symbols): Update.
1695         (info_module_subcommand): Update.
1696         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1697         (SYMBOL_LINKAGE_NAME): Remove.
1698         (SYMBOL_DEMANGLED_NAME): Remove.
1699         (SYMBOL_PRINT_NAME): Remove.
1700         (SYMBOL_SEARCH_NAME): Remove.
1701         * tracepoint.c (set_traceframe_context): Update.
1702         (validate_actionline): Update.
1703         (collection_list::collect_symbol): Update.
1704         (encode_actions_1): Update.
1705         (info_scope_command): Update.
1706         (print_one_static_tracepoint_marker): Update.
1707         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1708         * valops.c (address_of_variable): Update.
1709         (find_overload_match): Update.
1710         (find_oload_champ): Update.
1711
1712 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1713
1714         * ada-lang.c (ada_lookup_simple_minsym): Update.
1715         (ada_collect_symbol_completion_matches): Update.
1716         * ada-tasks.c (read_atcb): Update.
1717         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1718         (amd64_windows_skip_trampoline_code): Update.
1719         * arm-tdep.c (skip_prologue_function): Update.
1720         (arm_skip_stack_protector): Update.
1721         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1722         (arm_wince_skip_main_prologue): Update.
1723         * ax-gdb.c (gen_expr): Update.
1724         * block.c (call_site_for_pc): Update.
1725         * blockframe.c (find_pc_partial_function): Update.
1726         * breakpoint.c (set_breakpoint_location_function): Update.
1727         * btrace.c (ftrace_print_function_name): Update.
1728         (ftrace_function_switched): Update.
1729         * c-valprint.c (print_unpacked_pointer): Update.
1730         * coffread.c (coff_symfile_read): Update.
1731         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1732         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1733         * dwarf-index-write.c (write_psymbols): Update.
1734         * dwarf2loc.c (call_site_to_target_addr): Update.
1735         (func_verify_no_selftailcall): Update.
1736         (tailcall_dump): Update.
1737         (call_site_find_chain_1): Update.
1738         (dwarf_expr_reg_to_entry_parameter): Update.
1739         * elfread.c (elf_gnu_ifunc_record_cache): Update.
1740         * eval.c (evaluate_funcall): Update.
1741         (evaluate_subexp_standard): Update.
1742         (evaluate_subexp_for_sizeof): Update.
1743         * expprint.c (print_subexp_standard): Update.
1744         (dump_subexp_body_standard): Update.
1745         * frame.c (get_prev_frame_always_1): Update.
1746         * frv-tdep.c (frv_skip_main_prologue): Update.
1747         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1748         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1749         (gnuv3_get_typename_from_type_info): Update.
1750         (gnuv3_skip_trampoline): Update.
1751         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1752         * i386-tdep.c (i386_skip_main_prologue): Update.
1753         (i386_pe_skip_trampoline_code): Update.
1754         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1755         * infcall.c (get_function_name): Update.
1756         * linespec.c (minsym_found): Update.
1757         * linux-fork.c (info_checkpoints_command): Update.
1758         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1759         (m32c_m16c_pointer_to_address): Update.
1760         * maint.c (maintenance_translate_address): Update.
1761         * minsyms.c (add_minsym_to_hash_table): Update.
1762         (add_minsym_to_demangled_hash_table): Update.
1763         (lookup_minimal_symbol_mangled): Update.
1764         (lookup_minimal_symbol_demangled): Update.
1765         (lookup_minimal_symbol_linkage): Update.
1766         (lookup_minimal_symbol_text): Update.
1767         (lookup_minimal_symbol_by_pc_name): Update.
1768         (minimal_symbol_is_less_than): Update.
1769         (compact_minimal_symbols): Update.
1770         (build_minimal_symbol_hash_tables): Update.
1771         (find_solib_trampoline_target): Update.
1772         * mips-tdep.c (mips_stub_frame_sniffer): Update.
1773         (mips_skip_pic_trampoline_code): Update.
1774         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1775         * objc-lang.c (info_selectors_command): Update.
1776         (info_classes_command): Update.
1777         (find_methods): Update.
1778         (find_imps): Update.
1779         * p-valprint.c (pascal_val_print): Update.
1780         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1781         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1782         * printcmd.c (build_address_symbolic): Update.
1783         (info_symbol_command): Update.
1784         * psymtab.c (psymbol_name_matches): Update.
1785         (match_partial_symbol): Update.
1786         (lookup_partial_symbol): Update.
1787         (print_partial_symbols): Update.
1788         (sort_pst_symbols): Update.
1789         (maintenance_check_psymtabs): Update.
1790         * python/py-framefilter.c (py_print_frame): Update.
1791         * python/python.c (gdbpy_rbreak): Update.
1792         * record-btrace.c (btrace_get_bfun_name): Update.
1793         (btrace_call_history): Update.
1794         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1795         (rs6000_skip_trampoline_code): Update.
1796         * sol-thread.c (info_cb): Update.
1797         * stabsread.c (scan_file_globals): Update.
1798         * stack.c (find_frame_funname): Update.
1799         (info_frame_command_core): Update.
1800         * symmisc.c (dump_msymbols): Update.
1801         * symtab.c (symbol_natural_name): Rename to..,
1802         (general_symbol_info::natural_name): ...this.
1803         (symbol_demangled_name): Rename to...
1804         (general_symbol_info::demangled_name): ...this.
1805         (symbol_search_name): Rename to...
1806         (general_symbol_info::search_name): ...this.
1807         (symbol_matches_search_name): Update.
1808         (find_pc_sect_line): Update.
1809         (skip_prologue_sal): Update.
1810         (search_symbols): Update.
1811         (print_msymbol_info): Update.
1812         (rbreak_command): Update.
1813         (completion_list_add_msymbol): Update.
1814         (completion_list_objc_symbol): Update.
1815         (get_msymbol_address): Update.
1816         * symtab.h (struct general_symbol_info): Add member functions
1817         natural_name (), linkage_name (), print_name (), demangled_name (),
1818         and search_name ().
1819         (SYMBOL_NATURAL_NAME): Update.
1820         (symbol_natural_name): Move to a member function on general_symbol_info.
1821         (SYMBOL_DEMANGLED_NAME): Update.
1822         (symbol_demangled_name): Move to a member function on
1823         general_symbol_info.
1824         (SYMBOL_SEARCH_NAME): Update.
1825         (symbol_search_name): Move to a member function on general_symbol_info.
1826         (MSYMBOL_NATURAL_NAME): Remove.
1827         (MSYMBOL_LINKAGE_NAME): Remove.
1828         (MSYMBOL_PRINT_NAME): Remove.
1829         (MSYMBOL_DEMANGLED_NAME): Remove.
1830         (MSYMBOL_SEARCH_NAME): Remove.
1831         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1832
1833 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1834
1835         * symtab.c (create_demangled_names_hash): Use per_bfd->
1836         minimal_symbol_count for computing the initial size, if greater
1837         than our default size.
1838
1839 2019-11-22  Tom de Vries  <tdevries@suse.de>
1840
1841         * contrib/words.sh: Improve words extraction.
1842
1843 2019-11-22  Tom de Vries  <tdevries@suse.de>
1844
1845         * contrib/words.sh: Combine sed invocations.
1846
1847 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
1848
1849         * Makefile.in: Update.
1850         * demangle.c: Rename to...
1851         * gdb-demangle.c: ..this.
1852         (is_cplus_marker): Change return type to bool.
1853         (_initialize_demangler): Rename to...
1854         (_initialize_gdb_demangle): ...this.
1855         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1856         * symtab.h (demangle): Remove declaration; instead include
1857         gdb-demangle.h.
1858
1859 2019-11-21  Tom Tromey  <tromey@adacore.com>
1860
1861         * gdbsupport/format.c (format_pieces): Parse %I64d.
1862         * unittests/format_pieces-selftests.c (test_windows_formats): New
1863         function.
1864         (run_tests): Call it.
1865
1866 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
1867
1868         Byte reverse display of variables with DW_END_big, DW_END_little
1869         (DW_AT_endianity) dwarf attributes if different than the native
1870         byte order.
1871         * ada-lang.c (ada_value_binop):
1872         Use type_byte_order instead of gdbarch_byte_order.
1873         * ada-valprint.c (printstr):
1874         (ada_val_print_string):
1875         * ada-lang.c (value_pointer):
1876         (ada_value_binop):
1877         Use type_byte_order instead of gdbarch_byte_order.
1878         * c-lang.c (c_get_string):
1879         Use type_byte_order instead of gdbarch_byte_order.
1880         * c-valprint.c (c_val_print_array):
1881         Use type_byte_order instead of gdbarch_byte_order.
1882         * cp-valprint.c (cp_print_class_member):
1883         Use type_byte_order instead of gdbarch_byte_order.
1884         * dwarf2loc.c (rw_pieced_value):
1885         Use type_byte_order instead of gdbarch_byte_order.
1886         * dwarf2read.c (read_base_type): Handle DW_END_big,
1887         DW_END_little
1888         * f-lang.c (f_get_encoding):
1889         Use type_byte_order instead of gdbarch_byte_order.
1890         * findvar.c (default_read_var_value):
1891         Use type_byte_order instead of gdbarch_byte_order.
1892         * gdbtypes.c (check_types_equal):
1893         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1894         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1895         and TYPE_ENDIANITY_LITTLE if set.
1896         (type_byte_order): new function.
1897         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1898         (struct main_type) <flag_endianity_not_default>:
1899         New field.
1900         (type_byte_order): New function.
1901         * infcmd.c (default_print_one_register_info):
1902         Use type_byte_order instead of gdbarch_byte_order.
1903         * p-lang.c (pascal_printstr):
1904         Use type_byte_order instead of gdbarch_byte_order.
1905         * p-valprint.c (pascal_val_print):
1906         Use type_byte_order instead of gdbarch_byte_order.
1907         * printcmd.c (print_scalar_formatted):
1908         Use type_byte_order instead of gdbarch_byte_order.
1909         * solib-darwin.c (darwin_current_sos):
1910         Use type_byte_order instead of gdbarch_byte_order.
1911         * solib-svr4.c (solib_svr4_r_ldsomap):
1912         Use type_byte_order instead of gdbarch_byte_order.
1913         * stap-probe.c (stap_modify_semaphore):
1914         Use type_byte_order instead of gdbarch_byte_order.
1915         * target-float.c (target_float_same_format_p):
1916         Use type_byte_order instead of gdbarch_byte_order.
1917         * valarith.c (scalar_binop):
1918         (value_bit_index):
1919         Use type_byte_order instead of gdbarch_byte_order.
1920         * valops.c (value_cast):
1921         Use type_byte_order instead of gdbarch_byte_order.
1922         * valprint.c (generic_emit_char):
1923         (generic_printstr):
1924         (val_print_string):
1925         Use type_byte_order instead of gdbarch_byte_order.
1926         * value.c (unpack_long):
1927         (unpack_bits_as_long):
1928         (unpack_value_bitfield):
1929         (modify_field):
1930         (pack_long):
1931         (pack_unsigned_long):
1932         Use type_byte_order instead of gdbarch_byte_order.
1933         * findvar.c (unsigned_pointer_to_address):
1934         (signed_pointer_to_address):
1935         (unsigned_address_to_pointer):
1936         (address_to_signed_pointer):
1937         (default_read_var_value):
1938         (default_value_from_register):
1939         Use type_byte_order instead of gdbarch_byte_order.
1940         * gnu-v3-abi.c (gnuv3_make_method_ptr):
1941         Use type_byte_order instead of gdbarch_byte_order.
1942         * riscv-tdep.c (riscv_print_one_register_info):
1943         Use type_byte_order instead of gdbarch_byte_order.
1944
1945 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
1946
1947         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1948         (current_ui_gdb_stdin_ptr): Likewise.
1949         (current_ui_gdb_stderr_ptr): Likewise.
1950         (current_ui_gdb_stdlog_ptr): Likewise.
1951         (current_ui_current_uiout_ptr): Likewise.
1952         (gen_ret_current_ui_field_ptr): Remove.
1953
1954 2019-11-21  Tom de Vries  <tdevries@suse.de>
1955
1956         PR gdb/24956
1957         * cli/cli-script.c (execute_control_command): Only switch to
1958         INTERP_CONSOLE's ui_out when INTERP_MI is active.
1959
1960 2019-11-19  Tom Tromey  <tom@tromey.com>
1961
1962         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1963         Now static.  Change type of "name".
1964         (tui_set_win_height_command): Don't copy "arg".
1965         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1966         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1967
1968 2019-11-19  Ali Tamur <tamur@google.com>
1969
1970         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1971         "if (attr != nullptr)".
1972         (dwarf2_find_base_address): Likewise.
1973         (dwarf2_build_include_psymtabs): Likewise.
1974         (read_cutu_die_from_dwo): Likewise.
1975         (read_func_scope): Likewise.
1976         (read_call_site_scope): Likewise.
1977         (dwarf2_get_pc_bounds): Likewise.
1978         (dwarf2_record_block_ranges): Likewise.
1979         (dwarf2_add_field): Likewise.
1980         (dwarf2_add_member_fn): Likewise.
1981         (read_structure_type): Likewise.
1982         (read_enumeration_type): Likewise.
1983         (read_array_type): Likewise.
1984         (read_array_order): Likewise.
1985         (read_set_type): Likewise.
1986         (read_common_block): Likewise.
1987         (read_tag_reference_type): Likewise.
1988         (read_tag_string_type): Likewise.
1989         (read_subroutine_type): Likewise.
1990         (read_base_type): Likewise.
1991         (read_subrange_type): Likewise.
1992         (new_symbol): Likewise.
1993         (prepare_one_comp_unit): Likewise.
1994
1995 2019-11-19  Tom Tromey  <tromey@adacore.com>
1996
1997         * windows-nat.c (windows_nat_target::attach): Include GetLastError
1998         result in error when DebugActiveProcess fails.
1999
2000 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
2001             Pedro Alves  <palves@redhat.com>
2002
2003         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
2004         * target.c (target_stack::push): Call 'unpush' if there's a
2005         target on top of the stack.
2006
2007 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2008
2009         * python/py-block.c (blpy_dealloc): Call tp_free.
2010         (blpy_block_syms_dealloc): Likewise.
2011         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
2012         * python/py-inferior.c (infpy_dealloc): Likewise.
2013         * python/py-lazy-string.c (stpy_dealloc): Likewise.
2014         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
2015         * python/py-symbol.c (sympy_dealloc): Likewise.
2016         * python/py-symtab.c (stpy_dealloc): Likewise.
2017         * python/py-type.c (typy_iterator_dealloc): Likewise.
2018
2019 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
2020
2021         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
2022         constructor instead of using a class initializer.
2023
2024 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2025
2026         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
2027         * configure: Regenerate.
2028         * configure.ac: Don't source common.host.
2029         * gdbsupport/common.host: Remove.
2030         * gdbsupport/mingw-strerror.c: Remove.
2031         * gdbsupport/posix-strerror.c: Rename to...
2032         * gdbsupport/safe-strerror.c: ...this.
2033
2034 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2035
2036         * maint.c (scoped_command_stats::print_time): Use localtime_r
2037         instead of localtime (provided through gnulib if necessary).
2038         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
2039         of ctime.
2040
2041 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2042
2043         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
2044         avoid compile errors.
2045
2046 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2047
2048         * config.in: Regenerate.
2049         * configure: Regenerate.
2050         * gdbsupport/common.m4: No longer check for strerror_r.
2051         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2052         POSIX version of strerror_r, now that gnulib provides it if
2053         necessary.
2054
2055 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
2056
2057         * README (`configure' options): Update.
2058
2059 2019-11-14  Tom Tromey  <tromey@adacore.com>
2060
2061         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2062         expected type for the RHS if the LHS is a convenience variable.
2063
2064 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
2065
2066         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2067         Provide explicit default and copy constructor.
2068
2069 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2070
2071         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2072         only call Py_INCREF (newbp) in the bppy_pending_object case.
2073
2074 2019-11-13  Tom Tromey  <tromey@adacore.com>
2075
2076         PR build/25182:
2077         * psympriv.h (partial_symbol): Remove static assert.
2078         * symtab.h (general_symbol_info, symbol): Remove static assert.
2079
2080 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2081
2082         * gdbsupport/format.c (format_pieces::format_pieces): Support
2083         printf 'z' size modifier.
2084         * gdbsupport/format.h (enum argclass): Add size_t_arg.
2085         * printcmd.c (ui_printf):  Handle size_t_arg.
2086         * ui-out.c (ui_out::vmessage): Likewise.
2087         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2088         function.
2089         (run_tests): Call test_format_int_sizes.
2090
2091 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
2092
2093         * ada-exp.y (write_ambiguous_var): Update.
2094         * buildsym.c (add_symbol_to_list): Update.
2095         * dwarf2read.c (read_variable): Update.
2096         (new_symbol): Update.
2097         * jit.c (finalize_symtab): Update.
2098         * language.c (language_alloc_type_symbol): Update.
2099         * symtab.c (fixup_symbol_section): Update.
2100         (initialize_objfile_symbol_1): Move code to...
2101         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2102         (allocate_symbol): Update.
2103         (allocate_template_symbol): Update.
2104         (get_symbol_address): Update.
2105         * symtab.h (struct symbol): Inherit from general_symbol_info instead
2106         of having as a field, and add a constructor.
2107         (SYMBOL_VALUE): Update.
2108         (SYMBOL_VALUE_ADDRESS): Update.
2109         (SET_SYMBOL_VALUE_ADDRESS): Update.
2110         (SYMBOL_VALUE_BYTES): Update.
2111         (SYMBOL_VALUE_COMMON_BLOCK): Update.
2112         (SYMBOL_BLOCK_VALUE): Update.
2113         (SYMBOL_VALUE_CHAIN): Update.
2114         (SYMBOL_LANGUAGE): Update.
2115         (SYMBOL_SECTION): Update.
2116         (SYMBOL_OBJ_SECTION): Update.
2117         (SYMBOL_SET_LANGUAGE): Update.
2118         (SYMBOL_SET_LINKAGE_NAME): Update.
2119         (SYMBOL_SET_NAMES): Update.
2120         (SYMBOL_NATURAL_NAME): Update.
2121         (SYMBOL_LINKAGE_NAME): Update.
2122         (SYMBOL_DEMANGLED_NAME): Update.
2123         (SYMBOL_SEARCH_NAME): Update.
2124         (SYMBOL_MATCHES_SEARCH_NAME): Update.
2125         (struct symbol): Update.
2126         (struct template_symbol): Update.
2127         (struct rust_vtable_symbol): Update.
2128         * xcoffread.c (SYMBOL_DUP): Update.
2129
2130 2019-11-12  Tom Tromey  <tom@tromey.com>
2131
2132         * tui/tui-layout.c (show_layout): Set current_layout.
2133         (show_source_disasm_command, show_data)
2134         (show_source_or_disasm_and_command): Don't set current_layout.
2135
2136 2019-11-12  Tom Tromey  <tom@tromey.com>
2137
2138         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2139
2140 2019-11-12  Tom Tromey  <tom@tromey.com>
2141
2142         * tui/tui-win.c (resize_message): New global.
2143         (show_tui_resize_message): New function.
2144         (tui_async_resize_screen): Print message if requested.
2145         (_initialize_tui_win): Add tui-resize-message setting.
2146         * NEWS: Add entry for new commands.
2147
2148 2019-11-11  Tom Tromey  <tom@tromey.com>
2149
2150         * tui/tui.c (tui_initialize_readline): Add new bindable readline
2151         functions.
2152
2153 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
2154
2155         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2156
2157 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2158
2159         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2160         function.
2161         * python/python-internal.h (gdbpy_lookup_static_symbols):
2162         Declare new function.
2163         * python/python.c (python_GdbMethods): Add
2164         gdb.lookup_static_symbols method.
2165         * NEWS: Mention gdb.lookup_static_symbols.
2166
2167 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2168
2169         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2170         static block of current object file first.  Also fix typo in
2171         header comment.
2172
2173 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2174
2175         * stack.c (set_last_displayed_sal): Delete.
2176         (last_displayed_sal_valid): Delete.
2177         (last_displayed_pspace): Delete.
2178         (last_displayed_addr): Delete.
2179         (last_displayed_symtab): Delete.
2180         (last_displayed_line): Delete.
2181         (class last_displayed_symtab_info_type): New.
2182         (last_displayed_symtab_info): New static global variable.
2183         (print_frame_info): Call methods on last_displayed_symtab_info.
2184         (clear_last_displayed_sal): Update header comment, and make use of
2185         last_displayed_symtab_info.
2186         (last_displayed_sal_is_valid): Likewise.
2187         (get_last_displayed_pspace): Likewise.
2188         (get_last_displayed_addr): Likewise.
2189         (get_last_displayed_symtab): Likewise.
2190         (get_last_displayed_line): Likewise.
2191         (get_last_displayed_sal): Likewise.
2192         * stack.h (clear_last_displayed_sal): Update header comment.
2193         (last_displayed_sal_is_valid): Likewise.
2194         (get_last_displayed_pspace): Likewise.
2195         (get_last_displayed_addr): Likewise.
2196         (get_last_displayed_symtab): Likewise.
2197         (get_last_displayed_line): Likewise.
2198         (get_last_displayed_sal): Likewise.
2199
2200 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2201
2202         * stack.c (frame_show_address): Convert return type to bool.
2203         * stack.h (frame_show_address): Likewise, and update header
2204         comment.
2205
2206 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2207
2208         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2209         * unittests/vec-utils-selftests.c: New file.
2210         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2211
2212 2019-11-10  Tom Tromey  <tom@tromey.com>
2213
2214         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2215         (tui_highlight_win): Likewise.
2216         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2217         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2218         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2219         Don't set can_highlight.
2220
2221 2019-11-10  Tom Tromey  <tom@tromey.com>
2222
2223         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2224         Remove unused declaration.
2225
2226 2019-11-08  Tom Tromey  <tromey@adacore.com>
2227
2228         * top.c (read_command_file): Update.
2229         (command_line_input): Make return type const.
2230         * python/py-gdb-readline.c: Update.
2231         * linespec.c (decode_line_2): Update.
2232         * defs.h (command_line_input): Make return type const.
2233         * cli/cli-script.c (read_next_line): Make return type const.
2234         * ada-lang.c (get_selections): Update.
2235
2236 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
2237
2238         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2239         * mi/mi-main.c (output_cores): Likewise.
2240         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2241         (linux_xfer_osdata_modules): Likewise.
2242         * remote.c (register_remote_support_xml): Likewise.
2243         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2244         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2245
2246 2019-11-06  Tom Tromey  <tom@tromey.com>
2247
2248         * tui/tui-interp.c: Don't include readline.h.
2249         * tui/tui-hooks.c: Don't include readline.h.
2250         * symmisc.c: Include tilde.h, not readline.h.
2251         * symfile.c: Include tilde.h, not readline.h.
2252         * source.c: Include tilde.h, not readline.h.
2253         * solib.c: Include tilde.h, not readline.h.
2254         * psymtab.c: Include tilde.h, not readline.h.
2255         * exec.c: Include tilde.h, not readline.h.
2256         * corelow.c: Include tilde.h, not readline.h.
2257         * cli/cli-dump.c: Include tilde.h, not readline.h.
2258         * cli/cli-cmds.c: Don't include readline.h.
2259
2260 2019-11-05  Tom Tromey  <tom@tromey.com>
2261
2262         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2263         (tui_disassemble): Set addr_size.
2264         (tui_disasm_window::set_contents): Use addr_size.
2265
2266 2019-11-05  Tom Tromey  <tom@tromey.com>
2267
2268         * rust-lang.c (rust_language_defn): Update.
2269         * python/py-value.c (valpy_string): Call c_get_string.
2270         * p-lang.c (pascal_language_defn): Update.
2271         * opencl-lang.c (opencl_language_defn): Update.
2272         * objc-lang.c (objc_language_defn): Update.
2273         * m2-lang.c (m2_language_defn): Update.
2274         * language.c (unknown_language_defn, auto_language_defn): Update.
2275         (default_get_string): Remove.
2276         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2277         * go-lang.c (go_language_defn): Update.
2278         * f-lang.c (f_language_defn): Update.
2279         * d-lang.c (d_language_defn): Update.
2280         * c-lang.c (c_language_defn, cplus_language_defn)
2281         (asm_language_defn, minimal_language_defn): Update.
2282         * ada-lang.c (ada_language_defn): Update.
2283         * language.h (struct language_defn) <la_get_string>: Remove.
2284         (LA_GET_STRING): Remove.
2285         (default_get_string): Don't declare.
2286
2287 2019-11-05  Tom Tromey  <tom@tromey.com>
2288
2289         * tui/tui-source.h (struct tui_source_window): Inline
2290         constructor.  Remove destructor.
2291         <style_changed, m_observable>: Move to superclass.
2292         * tui/tui-winsource.h (tui_copy_source_line): Declare.
2293         (struct tui_source_window_base): Move private members to end.
2294         <style_changed, m_observable>: Move from tui_source_window.
2295         * tui/tui-winsource.c (tui_copy_source_line): Move from
2296         tui-source.c.  Rename from copy_source_line.  Add special handling
2297         for negative line number.
2298         (tui_source_window_base::style_changed): Move from
2299         tui_source_window.
2300         (tui_source_window_base): Register observer.
2301         (~tui_source_window_base): New.
2302         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2303         rename.
2304         (tui_source_window::set_contents): Use tui_copy_source_line.
2305         (tui_source_window::tui_source_window): Move to tui-source.h.
2306         (tui_source_window::~tui_source_window): Remove.
2307         (tui_source_window::style_changed): Move to superclass.
2308         * tui/tui-disasm.c (tui_disassemble): Create string file with
2309         styling, when possible.  Add "addr_size" parameter.
2310         (tui_disasm_window::set_contents): Use tui_copy_source_line.
2311         Don't compute maximum size.
2312         (len_without_escapes): New function
2313
2314 2019-11-05  Tom Tromey  <tom@tromey.com>
2315
2316         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2317         std::string.
2318         * tui/tui-winsource.c (tui_show_source_line): Update.
2319         * tui/tui-source.c (tui_source_window::set_contents): Update.
2320         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2321
2322 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
2323
2324         * symtab.h (gdb_static_assert): Put && operator at the beginning
2325         of the line instead of the end.
2326
2327 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
2328
2329         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2330         and sizeof (symbol).
2331         * symtab.h: Add a static_assert for sizeof (partial_symbol).
2332
2333 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2334
2335         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2336         * configure.host: Mark *-*-solaris2.10* obsolete.
2337         * configure.tgt: Mark Solaris < 11 obsolete.
2338         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2339         Update target triplet.
2340
2341 2019-11-01  Tom Tromey  <tromey@adacore.com>
2342
2343         * utils.c (print_sys_errmsg): Simplify.
2344
2345 2019-11-01  Tom Tromey  <tromey@adacore.com>
2346
2347         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2348
2349 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
2350
2351         * configure: Regenerate.
2352         * configure.ac: Remove check for strerror_r.
2353         * gdbsupport/common.m4: Check for strerror_r.
2354
2355 2019-11-01  Luis Machado  <luis.machado@linaro.org>
2356
2357         PR gdb/25124
2358
2359         * arm-tdep.c (arm_per_objfile): Rename to ...
2360         (arm_per_bfd): ... this.
2361         (arm_objfile_data_key): Rename to ...
2362         (arm_bfd_data_key): ... this.
2363         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2364         data.
2365         (arm_record_special_symbol): Likewise.
2366
2367 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2368
2369         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2370         end.
2371         * c-typeprint.c (c_print_typedef): Likewise.
2372         * f-typeprint.c (f_print_typedef): Likewise.
2373         * m2-typeprint.c (m2_print_typedef): Likewise.
2374         * p-typeprint.c (pascal_print_typedef): Likewise.
2375         * rust-lang.c (rust_print_typedef): Likewise.
2376         * symtab.c (print_symbol_info): Print a newline after calling
2377         typedef_print.
2378
2379 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2380
2381         * symtab.c (info_module_cmdlist): New variable.
2382         (info_module_command): New function.
2383         (search_module_symbols): New function.
2384         (info_module_subcommand): New function.
2385         (struct info_modules_var_func_options): New struct.
2386         (info_modules_var_func_options_defs): New variable.
2387         (make_info_modules_var_func_options_def_group): New function.
2388         (info_module_functions_command): New function.
2389         (info_module_variables_command): New function.
2390         (info_module_var_func_command_completer): New function.
2391         (_initialize_symtab): Register new 'info module functions' and
2392         'info module variables' commands.
2393         * symtab.h (typedef symbol_search_in_module): New typedef.
2394         (search_module_symbols): Declare new function.
2395         * NEWS: Mention new commands.
2396
2397 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2398
2399         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2400         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2401         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2402         MODULES_DOMAIN.
2403         (scan_partial_symbols): Only create partial module symbols for non
2404         declarations.
2405         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2406         and MODULES_DOMAIN.
2407         * symtab.c (search_domain_name): Likewise.
2408         (search_symbols): Likewise.
2409         (print_symbol_info): Likewise.
2410         (symtab_symbol_info): Likewise.
2411         (info_modules_command): New function.
2412         (_initialize_symtab): Register 'info modules' command.
2413         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2414         * NEWS: Mention new 'info modules' command.
2415
2416 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2417
2418         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2419         and $_gdb_maint_setting_str.
2420
2421 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2422
2423         * cli/cli-cmds.c (setting_cmd, value_from_setting)
2424         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2425         (str_value_from_setting, gdb_setting_str_internal_fn)
2426         (gdb_maint_setting_str_internal_fn): New functions.
2427         (_initialize_cli_cmds): Define the new convenience functions.
2428         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2429         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2430
2431 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2432
2433         * agent.c (set_can_use_agent): When the setting is turned on,
2434         look up agent symbols if we don't have them yet.
2435         (agent_new_objfile): Don't look up agent symbols when the agent
2436         setting is off.
2437
2438 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2439
2440         * config.in: Regenerate.
2441
2442 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2443
2444         * configure: Regenerate.
2445         * configure.ac: Check for strerror_r.
2446         * gdbsupport/common-utils.h (safe_strerror): Change return value
2447         to const char * and document that this function is now threadsafe.
2448         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2449         thread_local and call strerror_r, if available.
2450         * utils.c (perror_string): Update.
2451         (print_sys_errmsg): Update.
2452
2453 2019-10-31  Luis Machado  <luis.machado@linaro.org>
2454
2455         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2456         objfile_key.
2457         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2458         objfile to fetch per-bfd data.
2459         (arm_find_exidx_entry): Likewise.
2460
2461 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2462
2463         * gdbsupport/agent.c (debug_agent): Change type to bool.
2464         (use_agent): Likewise.
2465         (all_agent_symbols_look_up): Likewise.
2466         (agent_loaded_p): Change return value to bool.
2467         (agent_look_up_symbols): Update.
2468         (agent_capability_check): Change return value to bool.
2469         * gdbsupport/agent.h (agent_loaded_p): Likewise.
2470         (debug_agent): Change type to bool.
2471         (use_agent): Likewise.
2472         (agent_capability_check): Change return value to bool.
2473
2474 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
2475
2476         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2477         (build_minimal_symbol_hash_tables): Code to clear the table moved
2478         to clear_minimal_symbol_hash_tables.
2479         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2480         when needed.
2481
2482 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2483
2484         * infcmd.c: Remove includes.
2485         * infrun.c: Remove includes.
2486
2487 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2488
2489         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2490         (grow_vect): Remove declaration.
2491         (ada_type_of_array): Remove declaration.
2492         (ada_update_initial_language): Remove declaration.
2493         (ada_fold_name): Remove declaration.
2494         (ada_fill_in_ada_prototype): Remove declaration.
2495         (user_select_syms): Remove declaration.
2496         (get_selections): Remove declaration.
2497         (ada_tag_type): Remove declaration.
2498         (ada_value_tag): Remove declaration.
2499         (ada_is_others_clause): Remove declaration.
2500         (ada_in_variant): Remove declaration.
2501         (ada_value_struct_elt): Remove declaration.
2502         (ada_attribute_name): Remove declaration.
2503         (ada_system_address_type): Remove declaration.
2504         * ada-lang.c (ada_watch_location_expression): Make static.
2505         (GROW_VECT): Move here from ada-lang.h.
2506         (grow_vect): Make static.
2507         (ada_update_initial_language): Make static.
2508         (ada_fold_name): Make static.
2509         (ada_type_of_array): Make static.
2510         (encoded_ordered_before): Move up.
2511         (sort_choices): Move up.
2512         (print_signatures): Move up.
2513         (ada_print_symbol_signature): Move up.
2514         (get_selections): Move up and make static.
2515         (user_select_syms): Move up and make static.
2516         (ada_value_struct_elt): Move up and make static.
2517         (ada_tag_type): Make static.
2518         (ada_value_tag): Make static.
2519         (ada_is_others_clause): Make static.
2520         (ada_in_variant): Make static.
2521         (ada_attribute_name): Make static.
2522
2523 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2524
2525         * ada-lang.c: Remove includes.
2526         * ada-typeprint.c: Remove includes.
2527         * ada-valprint.c: Remove includes.
2528
2529 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
2530
2531         * addrmap.c: Add static assertions of type size, moved from
2532         _initialize_addrmap.
2533         (_initialize_addrmap): Remove.
2534
2535 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2536
2537         * coffread.c (record_minimal_symbol): Update.
2538         (process_coff_symbol): Update.
2539         * dbxread.c (read_dbx_symtab): Update.
2540         * dwarf2read.c (add_partial_symbol): Update.
2541         (fixup_go_packaging): Update.
2542         (load_partial_dies): Update.
2543         (new_symbol): Update.
2544         * elfread.c (record_minimal_symbol): Change signature to use
2545         gdb::string_view instead of name+len.
2546         (elf_symtab_read): Update.
2547         (elf_rel_plt_read): Update.
2548         * mdebugread.c (parse_partial_symbols): Update.
2549         (handle_psymbol_enumerators): Update.
2550         (new_symbol): Update.
2551         * minsyms.c (minimal_symbol_reader::record_full): Change signature
2552         to use gdb::string_view instead of name+len.
2553         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2554         * psympriv.h (add_psymbol_to_list): Likewise.
2555         * psymtab.c (add_psymbol_to_bcache): Likewise.
2556         (add_psymbol_to_list): Likewise.
2557         * stabsread.c (define_symbol): Update.
2558         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2559         * symtab.h (SYMBOL_SET_NAMES): Likewise.
2560         (symbol_set_names): Likewise.
2561         * xcoffread.c (scan_xcoff_symtab): Update.
2562
2563 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2564
2565         * symtab.h (symbol_set_names): Document that copy_name must be
2566         set to true for non-nullterminated strings.
2567         * symtab.c (symbol_set_names): Only make a nullterminated copy of
2568         linkage_name if the entry was not found and we need to demangle.
2569
2570 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2571
2572         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2573         * dwarf2-frame.c (bsearch_fde_cmp): Update.
2574         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2575         * gdbsupport/gdb_binary_search.h: New file.
2576
2577 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2578
2579         * NEWS: Mention new --with-system-gdbinit-dir option.
2580         * config.in: Regenerate.
2581         * configure: Regenerate.
2582         * configure.ac: Add new option --with-system-gdbinit-dir.
2583         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2584         for a ".gdb" suffix.
2585         * main.c (get_init_files): Change system_gdbinit argument to
2586         a vector and return the files in SYSTEM_GDBINIT_DIR in
2587         addition to SYSTEM_GDBINIT.
2588         (captured_main_1): Update.
2589         (print_gdb_help): Update.
2590         * top.c (print_gdb_configuration): Also print the value of
2591         SYSTEM_GDBINIT_DIR.
2592
2593 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
2594
2595         * gdbsupport/common-utils.h (startswith): Add an overloaded version
2596         that takes gdb::string_view arguments.
2597
2598 2019-10-26  Tom de Vries  <tdevries@suse.de>
2599
2600         * aarch64-linux-tdep.c: Fix typos in comments.
2601         * aarch64-tdep.c: Same.
2602         * ada-lang.c: Same.
2603         * amd64-nat.c: Same.
2604         * arc-tdep.c: Same.
2605         * arch/aarch64-insn.c: Same.
2606         * block.c: Same.
2607         * breakpoint.h: Same.
2608         * btrace.h: Same.
2609         * c-varobj.c: Same.
2610         * cli/cli-decode.c: Same.
2611         * cli/cli-script.c: Same.
2612         * cli/cli-utils.h: Same.
2613         * coff-pe-read.c: Same.
2614         * coffread.c: Same.
2615         * compile/compile-cplus-symbols.c: Same.
2616         * compile/compile-object-run.c: Same.
2617         * completer.c: Same.
2618         * corelow.c: Same.
2619         * cp-support.c: Same.
2620         * demangle.c: Same.
2621         * dwarf-index-write.c: Same.
2622         * dwarf2-frame.c: Same.
2623         * dwarf2-frame.h: Same.
2624         * eval.c: Same.
2625         * frame-base.h: Same.
2626         * frame.h: Same.
2627         * gdbcmd.h: Same.
2628         * gdbtypes.h: Same.
2629         * gnu-nat.c: Same.
2630         * guile/scm-objfile.c: Same.
2631         * i386-tdep.c: Same.
2632         * i386-tdep.h: Same.
2633         * infcall.c: Same.
2634         * infcall.h: Same.
2635         * linux-nat.c: Same.
2636         * m68k-tdep.c: Same.
2637         * macroexp.c: Same.
2638         * memattr.c: Same.
2639         * mi/mi-cmd-disas.c: Same.
2640         * mi/mi-getopt.h: Same.
2641         * mi/mi-main.c: Same.
2642         * minsyms.c: Same.
2643         * nat/aarch64-sve-linux-sigcontext.h: Same.
2644         * objfiles.h: Same.
2645         * ppc-linux-nat.c: Same.
2646         * ppc-linux-tdep.c: Same.
2647         * ppc-tdep.h: Same.
2648         * progspace.h: Same.
2649         * prologue-value.h: Same.
2650         * python/py-evtregistry.c: Same.
2651         * python/py-instruction.h: Same.
2652         * record-btrace.c: Same.
2653         * record-full.c: Same.
2654         * remote.c: Same.
2655         * rs6000-tdep.c: Same.
2656         * ser-tcp.c: Same.
2657         * sol-thread.c: Same.
2658         * sparc-sol2-tdep.c: Same.
2659         * sparc64-tdep.c: Same.
2660         * stabsread.c: Same.
2661         * symfile.c: Same.
2662         * symtab.h: Same.
2663         * target.c: Same.
2664         * tracepoint.c: Same.
2665         * tui/tui-data.h: Same.
2666         * tui/tui-io.c: Same.
2667         * tui/tui-win.c: Same.
2668         * tui/tui.c: Same.
2669         * unittests/rsp-low-selftests.c: Same.
2670         * user-regs.h: Same.
2671         * utils.c: Same.
2672         * utils.h: Same.
2673         * valarith.c: Same.
2674         * valops.c: Same.
2675         * valprint.c: Same.
2676         * valprint.h: Same.
2677         * value.c: Same.
2678         * value.h: Same.
2679         * varobj.c: Same.
2680         * x86-nat.h: Same.
2681         * xtensa-tdep.c: Same.
2682
2683 2019-10-25  Ali Tamur <tamur@google.com>
2684
2685         * charset.c (find_charset_names): Reflect API change.
2686
2687 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
2688
2689         * symtab.c (struct demangled_name_entry): Change demangled name
2690         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2691         part of the struct anymore.
2692         (symbol_set_names): No longer obstack allocate + copy the demangled
2693         name, just store the allocated name from bfd.
2694
2695 2019-10-25  Tom Tromey  <tromey@adacore.com>
2696
2697         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2698         (bsearch_cie_cmp, add_cie): Remove.
2699         (find_cie): Reimplement.
2700         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
2701         (dwarf2_build_frame_info): Update.
2702
2703 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
2704
2705         PR gdb/25126
2706         * symfile.c (reread_symbols): Call forget_cached_source_info to
2707         clear the stale source cache.
2708
2709 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2710
2711         * configure: Regenerate.
2712         * configure.ac: Remove code that sets python_has_threads.
2713
2714 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2715
2716         * config.in: Regenerate.
2717         * configure: Regenerate.
2718         * configure.ac: Remove the code that uses sed to get the python
2719         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2720
2721 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2722
2723         * python/py-progspace.c (pspy_block_for_pc): Return None for all
2724         error paths.
2725
2726 2019-10-23  Tom Tromey  <tom@tromey.com>
2727
2728         * arc-tdep.c: Remove ".." from include.
2729         * frv-tdep.c: Remove ".." from include.
2730         * lm32-tdep.c: Remove ".." from include.
2731         * microblaze-tdep.c: Remove ".." from include.
2732         * or1k-tdep.h: Remove ".." from include.
2733         * s12z-tdep.c: Remove ".." from include.
2734         * Makefile.in (OPCODES_CFLAGS): Add comment.
2735         (TOP_CFLAGS): New variable.
2736         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2737
2738 2019-10-23  Tom Tromey  <tom@tromey.com>
2739
2740         * Makefile.in (READLINE_DIR): Update.
2741
2742 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2743
2744         * infcall.c (call_function_by_hand_dummy): Fix the function
2745         comment.  And extract out a code section into...
2746         (reserve_stack_space): ...this new function.
2747
2748 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2749
2750         * infcall.c (value_arg_coerce): Remove an unused parameter.
2751         (call_function_by_hand_dummy): Update the call to
2752         'value_arg_coerce'.
2753
2754 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2755
2756         * infcall.c (call_function_by_hand_dummy): Refactor.
2757
2758 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2759
2760         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2761
2762 2019-10-23  Tom Tromey  <tom@tromey.com>
2763
2764         * configure: Rebuild.
2765         * configure.ac: Don't check for sigprocmask.
2766         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2767
2768 2019-10-23  Tom Tromey  <tom@tromey.com>
2769
2770         * configure: Rebuild.
2771         * acinclude.m4: Use m4_include, not sinclude.
2772
2773 2019-10-23  Tom de Vries  <tdevries@suse.de>
2774
2775         PR breakpoints/24687
2776         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2777
2778 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2779
2780         * symtab.c (struct demangled_name_entry) <language>: Change from
2781         bitfield to regular variable.
2782
2783 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2784
2785         * symtab.c (struct demangled_name_entry): Add a constructor.
2786         (free_demangled_name_entry): New function to call the destructor
2787         for demangled_name_entry.
2788         (create_demangled_names_hash): Pass free_demangled_name_entry to
2789         htab_create_alloc.
2790         (symbol_set_names): Call placement new for demangled_name_entry.
2791         * utils.c: No longer include xxhash.h here, now that fast_hash
2792         is inlined in the header.
2793         * utils.h: Instead, include it here.
2794
2795 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2796
2797         * Makefile.in: Link with libxxhash.
2798         * config.in: Regenerate.
2799         * configure: Regenerate.
2800         * configure.ac: Search for libxxhash.
2801         * utils.c (fast_hash): Use xxhash if present.
2802
2803 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2804
2805         * utils.h (fast_hash): New function.
2806         * symtab.c (hash_demangled_name_entry): Call new function
2807         fast_hash.
2808
2809 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2810
2811         * symtab.c (struct demangled_name_entry): Change type of mangled
2812         to gdb::string_view. Also adds a constructor that takes the
2813         mangled name.
2814         (hash_demangled_name_entry): Update.
2815         (eq_demangled_name_entry): Update.
2816         (free_demangled_name_entry): New function to call the destructor
2817         now that this is not a POD anymore.
2818         (create_demangled_names_hash): Pass free_demangled_name_entry to
2819         htab_create_alloc.
2820         (symbol_set_names): Update.
2821
2822 2019-10-21  Ali Tamur  <tamu@google.com>
2823
2824         * dwarf2read.c (dir_index): Change type.
2825         (file_name_index): Likewise.
2826         (line_header::include_dir_at): Change comment and implementation on
2827         whether it is DWARF 5.
2828         (line_header::is_valid_file_index): New function.
2829         (line_header::file_name_at): Change comment and implementation on
2830         whether it is DWARF 5.
2831         (line_header::file_names): Change to private field renamed as
2832         m_file_names and introduce a new accessor method.
2833         (line_header::file_names_size): New method.
2834         (line_header::include_dirs): Change to private field and rename as
2835         m_include_dirs.
2836         (dw2_get_file_names_reader): Define local var at a smaller scope and
2837         reflect API change.
2838         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2839         (process_structure_scope): Likewise.
2840         (line_header::add_include_dir): Change message and reflect renaming.
2841         (line_header::add_file_name): Likewise.
2842         (read_formatted_entries): Handle DW_FORM_data16.
2843         (dwarf_decode_line_header): Fix line header length calculation.
2844         (psymtab_include_file_name): Change comment and API.
2845         (lnp_state_machine::m_file): Update comment and reflect type change.
2846         (lnp_state_machine::record_line): Reflect type change.
2847         (dwarf_decode_lines): Reflect API change.
2848         (file_file_name): Likewise.
2849         (file_full_name): Likewise.
2850
2851 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2852
2853         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2854
2855 2019-10-21  Tom Tromey  <tom@tromey.com>
2856
2857         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2858
2859 2019-10-21  Tom Tromey  <tom@tromey.com>
2860
2861         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
2862         NM_H.   Use AC_CONFIG_LINKS.
2863         * configure: Rebuild.
2864         * Makefile.in (NM_H): New variable.
2865         (generated_files): Add NM_H.  Remove gcore.
2866         (nm.h, stamp-nmh): New targets.
2867
2868 2019-10-20  Tom Tromey  <tom@tromey.com>
2869
2870         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2871         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
2872         obsolete comment.
2873         (put_objfile_before): Now static.
2874
2875 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
2876
2877         * gdbsupport/common-utils.h (startswith): Change return type to
2878         bool.
2879
2880 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
2881
2882         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2883         * breakpoint.c (bp_locations_compare): Rename to...
2884         (bp_location_is_less_than): ...this, and change to std::sort semantics.
2885         (update_global_location_list): Use std::sort instead of qsort.
2886         * buildsym.c (compare_line_numbers): Rename to...
2887         (lte_is_less_than): ...this, and change to std::sort semantics.
2888         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2889         instead of qsort.
2890         * disasm.c (compare_lines): Rename to...
2891         (line_is_less_than): ...this, and change to std::sort semantics.
2892         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2893         of qsort.
2894         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2895         (fde_is_less_than): ...this, and change to std::sort semantics.
2896         (dwarf2_build_frame_info): Call std::sort instead of qsort.
2897         * mdebugread.c (compare_blocks):
2898         (block_is_less_than): ...this, and change to std::sort semantics.
2899         (sort_blocks): Call std::sort instead of qsort.
2900         * objfiles.c (qsort_cmp): Rename to...
2901         (sort_cmp): ...this, and change to std::sort semantics.
2902         (update_section_map): Call std::sort instead of qsort.
2903         * remote.c (compare_pnums): Remove.
2904         (map_regcache_remote_table): Call std::sort instead of qsort.
2905         * utils.c (compare_positive_ints): Remove.
2906         * utils.h (compare_positive_ints): Remove.
2907         * xcoffread.c (compare_lte): Remove.
2908         (arrange_linetable): Call std::sort instead of qsort.
2909
2910 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
2911
2912         * symfile.c (init_entry_point_info): Fix typo.
2913         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2914
2915 2019-10-18  Tom de Vries  <tdevries@suse.de>
2916
2917         * aarch64-tdep.c: Fix typos in comments.
2918         * ada-lang.c: Same.
2919         * ada-tasks.c: Same.
2920         * alpha-tdep.c: Same.
2921         * alpha-tdep.h: Same.
2922         * amd64-nat.c: Same.
2923         * amd64-windows-tdep.c: Same.
2924         * arc-tdep.c: Same.
2925         * arc-tdep.h: Same.
2926         * arch-utils.c: Same.
2927         * arm-nbsd-tdep.c: Same.
2928         * arm-tdep.c: Same.
2929         * ax-gdb.c: Same.
2930         * blockframe.c: Same.
2931         * btrace.c: Same.
2932         * c-varobj.c: Same.
2933         * coff-pe-read.c: Same.
2934         * coffread.c: Same.
2935         * cris-tdep.c: Same.
2936         * darwin-nat.c: Same.
2937         * dbxread.c: Same.
2938         * dcache.c: Same.
2939         * disasm.c: Same.
2940         * dtrace-probe.c: Same.
2941         * dwarf-index-write.c: Same.
2942         * dwarf2-frame-tailcall.c: Same.
2943         * dwarf2-frame.c: Same.
2944         * dwarf2read.c: Same.
2945         * eval.c: Same.
2946         * exceptions.c: Same.
2947         * fbsd-tdep.c: Same.
2948         * findvar.c: Same.
2949         * frame.c: Same.
2950         * frv-tdep.c: Same.
2951         * gnu-v3-abi.c: Same.
2952         * go32-nat.c: Same.
2953         * h8300-tdep.c: Same.
2954         * hppa-tdep.c: Same.
2955         * i386-linux-tdep.c: Same.
2956         * i386-tdep.c: Same.
2957         * ia64-libunwind-tdep.c: Same.
2958         * ia64-tdep.c: Same.
2959         * infcmd.c: Same.
2960         * infrun.c: Same.
2961         * linespec.c: Same.
2962         * linux-nat.c: Same.
2963         * linux-thread-db.c: Same.
2964         * machoread.c: Same.
2965         * mdebugread.c: Same.
2966         * mep-tdep.c: Same.
2967         * mn10300-tdep.c: Same.
2968         * namespace.c: Same.
2969         * objfiles.c: Same.
2970         * opencl-lang.c: Same.
2971         * or1k-tdep.c: Same.
2972         * osabi.c: Same.
2973         * ppc-linux-nat.c: Same.
2974         * ppc-linux-tdep.c: Same.
2975         * ppc-sysv-tdep.c: Same.
2976         * printcmd.c: Same.
2977         * procfs.c: Same.
2978         * record-btrace.c: Same.
2979         * record-full.c: Same.
2980         * remote-fileio.c: Same.
2981         * remote.c: Same.
2982         * rs6000-tdep.c: Same.
2983         * s12z-tdep.c: Same.
2984         * score-tdep.c: Same.
2985         * ser-base.c: Same.
2986         * ser-go32.c: Same.
2987         * skip.c: Same.
2988         * sol-thread.c: Same.
2989         * solib-svr4.c: Same.
2990         * solib.c: Same.
2991         * source.c: Same.
2992         * sparc-nat.c: Same.
2993         * sparc-sol2-tdep.c: Same.
2994         * sparc-tdep.c: Same.
2995         * sparc64-tdep.c: Same.
2996         * stabsread.c: Same.
2997         * stack.c: Same.
2998         * symfile.c: Same.
2999         * symtab.c: Same.
3000         * target-descriptions.c: Same.
3001         * target-float.c: Same.
3002         * thread.c: Same.
3003         * utils.c: Same.
3004         * valops.c: Same.
3005         * valprint.c: Same.
3006         * value.c: Same.
3007         * varobj.c: Same.
3008         * windows-nat.c: Same.
3009         * xcoffread.c: Same.
3010         * xstormy16-tdep.c: Same.
3011         * xtensa-tdep.c: Same.
3012
3013 2019-10-17  Tom Tromey  <tromey@adacore.com>
3014
3015         * configure: Rebuild.
3016         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
3017         in AC_CONFIG_FILES invocation.
3018         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
3019         new-style config.status invocation.
3020
3021 2019-10-17  Tom de Vries  <tdevries@suse.de>
3022
3023         * arm-nbsd-nat.c: Fix typos in comments.
3024         * arm-tdep.c: Same.
3025         * darwin-nat-info.c: Same.
3026         * dwarf2read.c: Same.
3027         * elfread.c: Same.
3028         * event-top.c: Same.
3029         * findvar.c: Same.
3030         * gdbtypes.c: Same.
3031         * hppa-tdep.c: Same.
3032         * i386-tdep.c: Same.
3033         * jit.c: Same.
3034         * main.c: Same.
3035         * mdebugread.c: Same.
3036         * moxie-tdep.c: Same.
3037         * nto-procfs.c: Same.
3038         * osabi.c: Same.
3039         * ppc-linux-tdep.c: Same.
3040         * remote.c: Same.
3041         * riscv-tdep.c: Same.
3042         * s390-tdep.c: Same.
3043         * sh-tdep.c: Same.
3044         * sparc-linux-tdep.c: Same.
3045         * sparc-nat.c: Same.
3046         * stack.c: Same.
3047         * target-descriptions.c: Same.
3048         * top.c: Same.
3049         * varobj.c: Same.
3050
3051 2019-10-16  Tom Tromey  <tom@tromey.com>
3052
3053         * objfiles.h (struct objfile) <original_name>: Now const.
3054
3055 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3056
3057         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3058         pass on to sigsetjmp's second argument.
3059         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3060
3061 2019-10-16  Keith Seitz  <keiths@redhat.com>
3062
3063         PR gdb/23567
3064         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3065         sections whose size is greater than the file size.
3066
3067 2019-10-16  Jim Wilson  <jimw@sifive.com>
3068
3069         * riscv-tdep.c (riscv_gcc_target_options): New.
3070         (riscv_gnu_triplet_regexp): New.
3071         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3072         set_gdbarch_gnu_triplet_regexp.
3073
3074 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3075
3076         * Makefile.in: Add xml-builtin.h.
3077         * features/feature_to_c.sh: Add an include for xml-builtin.h
3078         to ensure that the compiler checks that the types match.
3079         * xml-builtin.h: New file.
3080         * xml-support.c (fetch_xml_builtin): Add missing const.
3081         * xml-support.h: Remove declaration of xml_builtins.
3082
3083 2019-10-16  Tom de Vries  <tdevries@suse.de>
3084
3085         PR tdep/25096
3086         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3087         (amd64_classify_aggregate): ... here.
3088         (amd64_classify_aggregate_field): Handled fiels of nested structs
3089         recursively.
3090
3091 2019-10-16  Tom de Vries  <tdevries@suse.de>
3092
3093         PR tdep/24104
3094         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3095         that handles 'theclass'.
3096
3097 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3098
3099         * linespec.c (decode_digits_ordinary): Update comment.
3100         * make-target-delegates: No longer need to handle VEC case.
3101         * memrange.c (normalize_mem_ranges): Update comment.
3102         * namespace.c (add_using_directive): Update comment.
3103         * objc-lang.c (uniquify_strings): Update comment.
3104         * ppc-linux-nat.c (struct thread_points): Update comment.
3105         * probe.h (find_probes_in_objfile): Update comment.
3106         * target.h (enum flash_preserve_mode): Update comment.
3107         * varobj.c (varobj_restrict_range): Update comment.
3108         * varobj.h (varobj_list_children): Update comment.
3109
3110 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3111
3112         * Makefile.in: Remove references to vec.h and vec.c.
3113         * aarch64-tdep.c: No longer include vec.h.
3114         * ada-lang.c: Likewise.
3115         * ada-lang.h: Likewise.
3116         * arm-tdep.c: Likewise.
3117         * ax.h: Likewise.
3118         * breakpoint.h: Likewise.
3119         * charset.c: Likewise.
3120         * cp-support.h: Likewise.
3121         * dtrace-probe.c: Likewise.
3122         * dwarf2read.c: Likewise.
3123         * extension.h: Likewise.
3124         * gdb_bfd.c: Likewise.
3125         * gdbsupport/gdb_vecs.h: Likewise.
3126         * gdbsupport/vec.c: Remove.
3127         * gdbsupport/vec.h: Remove.
3128         * gdbthread.h: Likewise.
3129         * guile/scm-type.c: Likewise.
3130         * inline-frame.c: Likewise.
3131         * machoread.c: Likewise.
3132         * memattr.c: Likewise.
3133         * memrange.h: Likewise.
3134         * namespace.h: Likewise.
3135         * nat/linux-btrace.h: Likewise.
3136         * osdata.c: Likewise.
3137         * parser-defs.h: Likewise.
3138         * progspace.h: Likewise.
3139         * python/py-type.c: Likewise.
3140         * record-btrace.c: Likewise.
3141         * rust-exp.y: Likewise.
3142         * solib-target.c: Likewise.
3143         * stap-probe.c: Likewise.
3144         * target-descriptions.c: Likewise.
3145         * target-memory.c: Likewise.
3146         * target.h: Likewise.
3147         * varobj.c: Likewise.
3148         * varobj.h: Likewise.
3149         * xml-support.h: Likewise.
3150
3151 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3152
3153         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3154         Update for new std::vector based implementation.
3155         (process_psymtab_comp_unit_reader): Likewise.
3156         (scan_partial_symbols): Likewise.
3157         (recursively_compute_inclusions): Likewise.
3158         (compute_compunit_symtab_includes): Likewise.
3159         (process_imported_unit_die): Likewise.
3160         (queue_and_load_dwo_tu): Likewise.
3161         (follow_die_sig_1): Likewise.
3162         * gdb/dwarf2read.h: Remove DEF_VEC_P.
3163         (typedef dwarf2_per_cu_ptr): Remove.
3164         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3165         function.
3166         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3167         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3168         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3169         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3170         std::vector.
3171
3172 2019-10-15  Tom Tromey  <tromey@adacore.com>
3173
3174         * windows-nat.c (windows_nat_target::resume): Use %x when logging
3175         TID.
3176
3177 2019-10-15  Tom Tromey  <tromey@adacore.com>
3178
3179         * windows-nat.c (windows_nat_target::fetch_registers)
3180         (windows_nat_target::store_registers): Rename "pid" to "tid".
3181
3182 2019-10-15  Tom Tromey  <tromey@adacore.com>
3183
3184         * gdbarch.h, gdbarch.c: Rebuild.
3185         * gdbarch.sh (gcc_target_options): Change return type to
3186         std::string.
3187         * compile/compile.c (get_args): Update.
3188         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3189         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3190         std::string.
3191         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3192         std::string.
3193         * arch-utils.c (default_gcc_target_options): Return std::string.
3194         * arch-utils.h (default_gcc_target_options): Return std::string.
3195         * s390-tdep.c (s390_gcc_target_options): Return std::string.
3196
3197 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3198
3199         * breakpoint.c (breakpoint_chain): Make static.
3200         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3201         of accessing breakpoint_chain.
3202
3203 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3204
3205         * breakpoint.c (iterate_over_breakpoints): Change function pointer
3206         to a gdb::function_view and return value to bool.
3207         * breakpoint.h (iterate_over_breakpoints): Likewise.
3208         * dummy-frame.c (pop_dummy_frame_bpt): Update.
3209         (pop_dummy_frame): Update.
3210         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3211         (gdbscm_breakpoints): Update.
3212         * python/py-breakpoint.c (build_bp_list): Update.
3213         (gdbpy_breakpoints): Update.
3214         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3215         Update.
3216         (bpfinishpy_handle_stop): Update.
3217         (bpfinishpy_handle_exit): Update.
3218         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3219         (svr4_update_solib_event_breakpoints): Update.
3220
3221 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
3222
3223         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3224         when unwrapping single-field structs.
3225
3226 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
3227
3228         * dwarf2read.c: Remove includes.
3229
3230 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
3231
3232         * ui-out.c (ui_out::call_do_message): Silence
3233         -Wformat-nonliteral warning.
3234
3235 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
3236
3237         * breakpoint.c: Remove some includes: continuations.h, skip.h,
3238         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
3239         include: readline/tilde.h.
3240
3241 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3242
3243         * remote.c (remote_target::get_trace_status): Remove declaration of
3244         trace_regblock_size.
3245
3246 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3247
3248         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3249         (show_user): Remove declaration of cmdlist.
3250         * cli/cli-cmds.h (max_user_call_depth): Declare.
3251         * cli/cli-script.c (execute_user_command): Remove declaration
3252         of max_user_call_depth.
3253
3254 2019-10-11  Jim Wilson  <jimw@sifive.com>
3255
3256         * gdbsupport/print-utils.h (pulongest): Fix comment.
3257         (plongest): Likewise.
3258         (phex): Add missing comment, mention leading zeros.
3259         (phex_nz): Add mention of no leading zeros to comment.
3260
3261         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3262         plongest instead of unsigned long long cast.
3263
3264 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3265
3266         * main.c (captured_main_1): Include gdbtk.h and remove declarations
3267         for external_editor_command and gdbtk_test.
3268
3269 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3270
3271         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3272         * varobj.c (varobjdebug): Move comment to...
3273         * varobj.h (varobjdebug): ...here, and declare.
3274
3275 2019-10-09  Tom Tromey  <tom@tromey.com>
3276
3277         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3278         erase_data_content.
3279
3280 2019-10-09  Tom Tromey  <tom@tromey.com>
3281
3282         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3283         * tui/tui-stack.c (tui_locator_window::rerender): Update.
3284         * tui/tui-command.c (tui_cmd_window::resize)
3285         (tui_refresh_cmd_win): Update.
3286         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3287         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3288         * tui/tui-data.c (~tui_gen_win_info): Remove.
3289         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3290         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3291         (tui_redisplay_readline, tui_mld_flush)
3292         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3293         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3294         (tui_data_window::erase_data_content)
3295         (tui_data_item_window::rerender)
3296         (tui_data_item_window::refresh_window): Update.
3297         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3298         (box_win, tui_gen_win_info::make_window)
3299         (tui_gen_win_info::make_visible): Update.
3300         (tui_delete_win): Remove.
3301         * tui/tui-winsource.c
3302         (tui_source_window_base::do_erase_source_content): Update.
3303         (tui_show_source_line, tui_source_window_base::update_tab_width)
3304         (tui_source_window_base::update_exec_info): Update.
3305         * tui/tui-data.h (struct curses_deleter): New.
3306         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3307         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3308
3309 2019-10-09  Tom Tromey  <tom@tromey.com>
3310
3311         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3312
3313 2019-10-09  Tom Tromey  <tom@tromey.com>
3314
3315         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3316         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3317
3318 2019-10-09  Tom Tromey  <tom@tromey.com>
3319
3320         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3321         window height directly.
3322         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3323         declare.
3324         * tui/tui-layout.c (tui_default_win_height): Remove.
3325         (tui_default_win_viewport_height): Remove.
3326
3327 2019-10-09  Tom Tromey  <tom@tromey.com>
3328
3329         * tui/tui.h: Remove comments.
3330
3331 2019-10-09  Tom de Vries  <tdevries@suse.de>
3332
3333         * python/lib/gdb/printer/bound_registers.py: Use
3334         '^builtin_type_bound128' as regexp argument for
3335         add_builtin_pretty_printer.
3336
3337 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
3338
3339         * guile/guile.c (guile_extension_script_ops): Remove forward
3340         declaration and mark as static.
3341         (guile_script_ops): Likewise.
3342         (extension_language_guile): Move further down in the file so
3343         it can reference the definitions for guile_{extension_,}script_ops.
3344
3345 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
3346
3347         * s390-tdep.c (390_process_record): Handle new arch13 instructions
3348         except SORTL, DFLTCC, and KDSA.
3349
3350 2019-10-08  Tom Tromey  <tromey@adacore.com>
3351
3352         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3353         (struct safe_symbol_file_add_args): Remove.
3354
3355 2019-10-08  Tom Tromey  <tromey@adacore.com>
3356
3357         * windows-nat.c: Don't include buildsym-legacy.h.
3358
3359 2019-10-08  Tom Tromey  <tromey@adacore.com>
3360
3361         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3362
3363 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3364
3365         * gdbtypes.c (overload_debug): Move comment to header.
3366         * gdbtypes.h (overload_debug): Declare.
3367         * valops.c: Remove declaration of overload_debug, instead
3368         include gdbtypes.h.
3369
3370 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3371
3372         * language.c (show_language_command): Pass lang_frame_mismatch_warn
3373         through _().
3374         (lang_frame_mismatch_warn): Make const, mark with N_(), and
3375         move comment...
3376         * language.h (lang_frame_mismatch_warn): ... here. Also add
3377         declaration.
3378         * top.c (lang_frame_mismatch_warn): Remove declaration.
3379         (check_frame_language_change): Pass lang_frame_mismatch_warn
3380         through _().
3381
3382 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3383
3384         * c-lang.h (vtbl_ptr_name): Declare.
3385         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3386         it from the header.
3387         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3388
3389 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3390
3391         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3392         gdb_static_assert.
3393
3394 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3395
3396         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3397         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3398         * ctfread.c: New file.
3399         * ctfread.h: New file.
3400         * elfread.c: Include ctfread.h.
3401         (struct elfinfo text_p): New member ctfsect.
3402         (elf_locate_sections): Mark CTF section.
3403         (elf_symfile_read): Call elfctf_build_psymtabs.
3404         * Makefile.in (LIBCTF): Add.
3405         (CLIBS): Use it.
3406         (CDEPS): Likewise.
3407         (DIST): Add ctfread.c.
3408
3409 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3410
3411         * ctfread.c (struct nextfield): Renamed to ...
3412         (struct ctf_nextfield): ... this.
3413         (struct field_info): Renamed to ...
3414         (strut ctf_field_info): ... this.
3415         (attach_fields_to_type): Update for renamed structures.
3416         (ctf_add_member_cb): Likewise.
3417         (ctf_add_enum_member_cb): Likewise.
3418         (process_struct_members): Likewise.
3419         (process_enum_type): Likewise.
3420
3421 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3422
3423         * tracectf.h: Rename, was ctf.h.
3424         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3425         * tracefile.c: Likewise.
3426         * tracepoint.c: Remove unused include ctf.h.
3427         * mi/mi-main.c: Likewise.
3428         * Makefile.in Replace ctf.c with tracectf.c.
3429
3430 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
3431
3432         * version.in: Change version number to "9.0.50.DATE-git".
3433
3434 2019-10-03  Tom Tromey  <tom@tromey.com>
3435
3436         PR rust/24976:
3437         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3438
3439 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3440
3441         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3442         cp_search_name_hash.
3443         * NEWS: Add entry about nested function support.
3444
3445 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
3446             Andrew Burgess  <andrew.burgess@embecosm.com>
3447
3448         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3449         for nested static variables when searchin VAR_DOMAIN.
3450         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3451         global scope, update comment.
3452         (add_partial_subprogram): Call add_partial_subprogram recursively
3453         for nested subroutines when processinng Fortran.
3454         (load_partial_dies): Process the child entities of a subprogram
3455         when processing Fortran.
3456         (partial_die_parent_scope): Handle building scope
3457         for Fortran nested functions.
3458         (process_die): Record that nested functions have a scope.
3459         (new_symbol): Always record Fortran subprograms on the global
3460         symbol list.
3461         (determine_prefix): How to build the prefix for Fortran
3462         subprograms.
3463
3464 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3465
3466         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3467         have just sent the thread a SIGSTOP and are waiting for it to
3468         arrive.
3469
3470 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3471
3472         * btrace.c (btrace_add_pc): Remove whitespace before the template
3473         parameter in 'std::vector <...>'.
3474         (parse_xml_btrace_block): Likewise.
3475         (btrace_maint_decode_pt): Likewise.
3476         (btrace_maint_update_packets): Likewise.
3477         (btrace_maint_print_packets): Likewise.
3478         * btrace.h (struct btrace_maint_info): Likewise.
3479         * dwarf2read.c (struct type_unit_group): Likewise.
3480         (build_type_psymtabs_reader): Likewise.
3481         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3482         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3483         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3484
3485 2019-10-03  Tom de Vries  <tdevries@suse.de>
3486
3487         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3488         the first line of the help text for set/show style metadata.
3489
3490 2019-10-02  Tom Tromey  <tromey@adacore.com>
3491
3492         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3493         * gdbsupport/common-inferior.c: New file.
3494         * infcmd.c (startup_with_shell): Don't define.
3495         * nat/fork-inferior.h (startup_with_shell): Don't declare.
3496         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3497         * inferior.h (startup_with_shell): Don't declare.
3498
3499 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
3500
3501         * gdbsupport/gdb_assert.h: Include errors.h.
3502         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3503
3504 2019-10-02  Tom Tromey  <tromey@adacore.com>
3505
3506         * NEWS: Add $_ada_exception entry.
3507         * ada-lang.c (struct ada_catchpoint): Add constructor.
3508         <m_kind>: New member.
3509         (allocate_location_exception, re_set_exception): Remove
3510         "ex" parameter.
3511         (should_stop_exception): Compute $_ada_exception.
3512         (check_status_exception, print_it_exception)
3513         (print_one_exception, print_mention_exception): Remove
3514         "ex" parameter.
3515         (allocate_location_catch_exception, re_set_catch_exception)
3516         (check_status_exception, print_it_catch_exception)
3517         (print_one_catch_exception, print_mention_catch_exception)
3518         (print_recreate_catch_exception)
3519         (allocate_location_catch_exception_unhandled)
3520         (re_set_catch_exception_unhandled)
3521         (check_status_exception, print_it_catch_exception_unhandled)
3522         (print_one_catch_exception_unhandled)
3523         (print_mention_catch_exception_unhandled)
3524         (print_recreate_catch_exception_unhandled)
3525         (allocate_location_catch_assert, re_set_catch_assert)
3526         (check_status_assert, print_it_catch_assert)
3527         (print_one_catch_assert, print_mention_catch_assert)
3528         (print_recreate_catch_assert)
3529         (allocate_location_catch_handlers, re_set_catch_handlers)
3530         (check_status_handlers, print_it_catch_handlers)
3531         (print_one_catch_handlers, print_mention_catch_handlers)
3532         (print_recreate_catch_handlers): Remove.
3533         (create_ada_exception_catchpoint): Update.
3534         (initialize_ada_catchpoint_ops): Update.
3535
3536 2019-10-02  Tom Tromey  <tromey@adacore.com>
3537
3538         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3539         (create_excep_cond_exprs): Simplify exception string computation.
3540         (ada_exception_catchpoint_cond_string): Likewise.
3541
3542 2019-10-02  Tom Tromey  <tromey@adacore.com>
3543
3544         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3545         * ada-lang.c (lesseq_defined_than): Handle
3546         LOC_STATIC.
3547         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3548         parameter.
3549         (dwarf2_has_info): Likewise.
3550         (new_symbol): Set maybe_copied on symbol when
3551         appropriate.
3552         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3553         parameter.
3554         <can_copy>: New member.
3555         * elfread.c (record_minimal_symbol): Set maybe_copied
3556         on symbol when appropriate.
3557         (elf_symfile_read): Update call to dwarf2_has_info.
3558         * minsyms.c (lookup_minimal_symbol_linkage): New
3559         function.
3560         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3561         * symtab.c (get_symbol_address, get_msymbol_address):
3562         New functions.
3563         * symtab.h (get_symbol_address, get_msymbol_address):
3564         Declare.
3565         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3566         maybe_copied.
3567         (struct symbol, struct minimal_symbol) <maybe_copied>:
3568         New member.
3569
3570 2019-10-02  Tom Tromey  <tromey@adacore.com>
3571
3572         * source.c (struct current_source_location): New.
3573         (current_source_key): New global.
3574         (current_source_symtab, current_source_line)
3575         (current_source_pspace): Remove.
3576         (get_source_location): New function.
3577         (get_current_source_symtab_and_line)
3578         (set_default_source_symtab_and_line)
3579         (set_current_source_symtab_and_line)
3580         (clear_current_source_symtab_and_line, select_source_symtab)
3581         (info_source_command, print_source_lines_base)
3582         (info_line_command, search_command_helper, _initialize_source):
3583         Update.
3584
3585 2019-10-02  Tom Tromey  <tromey@adacore.com>
3586
3587         * source.c (select_source_symtab): Don't call
3588         decode_line_with_current_source.
3589
3590 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3591
3592         * symtab.c (lookup_global_symbol): Search global block.
3593
3594 2019-10-02  Tom Tromey  <tromey@adacore.com>
3595
3596         * coffread.c (process_coff_symbol): Update.
3597         * dwarf2read.c (var_decode_location, new_symbol): Update.
3598         * mdebugread.c (parse_symbol): Update.
3599         * objfiles.c (relocate_one_symbol): Update.
3600         * stabsread.c (define_symbol, fix_common_block)
3601         (scan_file_globals): Update.
3602         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3603         (SET_SYMBOL_VALUE_ADDRESS): New macro.
3604         * xcoffread.c (process_xcoff_symbol): Update.
3605
3606 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
3607
3608         * MAINTAINERS: Update my email address.
3609
3610 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3611
3612         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3613         std::vector.
3614         (build_type_psymtabs_reader): Update for std::vector.
3615         (build_type_psymtab_dependencies): Likewise.
3616         * dwarf2read.h: Remove use of DEF_VEC_P.
3617         (typedef sig_type_ptr): Delete.
3618
3619 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3620
3621         * btrace.c (btrace_maint_clear): Update to handle change from VEC
3622         to std::vector.
3623         (btrace_maint_decode_pt): Likewise, and move allocation of the
3624         vector outside of the loop.
3625         (btrace_maint_update_packets): Update to handle change from VEC to
3626         std::vector.
3627         (btrace_maint_print_packets): Likewise.
3628         (maint_info_btrace_cmd): Likewise.
3629         * btrace.h: Remove use of DEF_VEC_O.
3630         (typedef btrace_pt_packet_s): Delete.
3631         (struct btrace_maint_info) <packets>: Change fromm VEC to
3632         std::vector.
3633         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3634
3635 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3636
3637         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3638         make accesses into the vector constant references.
3639         (btrace_add_pc): Update for std::vector.
3640         (btrace_stitch_bts): Likewise.
3641         (parse_xml_btrace_block): Likewise.
3642         (btrace_maint_update_packets): Likewise.
3643         (btrace_maint_print_packets): Likewise.
3644         (maint_info_btrace_cmd): Likewise.
3645         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3646         std::vector.
3647         (btrace_data::empty): Likewise.
3648         (btrace_data_append): Likewise.
3649         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3650         (typedef btrace_block_s): Delete.
3651         (struct btrace_block): Add constructor.
3652         (struct btrace_data_bts) <blocks>: Change to std::vector.
3653         * nat/linux-btrace.c (perf_event_read_bts): Update for
3654         std::vector.
3655         (linux_read_bts): Likewise.
3656
3657 2019-10-01  Tom Tromey  <tom@tromey.com>
3658
3659         * cli/cli-logging.c (show_logging_filename): Use styled_string.
3660
3661 2019-10-01  Tom Tromey  <tom@tromey.com>
3662
3663         * stack.c (print_frame, info_frame_command_core): Use
3664         styled_string.
3665         * linux-thread-db.c (try_thread_db_load_1)
3666         (try_thread_db_load_from_pdir_1): Use styled_string.
3667         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3668         (auto_load_section_scripts, info_auto_load_local_gdbinit)
3669         (maybe_print_unsupported_script_warning)
3670         (maybe_print_script_not_found_warning): Use styled_string.
3671         * ada-lang.c (user_select_syms): Use styled_string.
3672
3673 2019-10-01  Tom Tromey  <tom@tromey.com>
3674
3675         * p-lang.c (pascal_printstr): Use metadata style.
3676         * value.c (show_convenience): Use metadata style.
3677         * valprint.c (valprint_check_validity, val_print_optimized_out)
3678         (val_print_not_saved, val_print_unavailable)
3679         (val_print_invalid_address, generic_val_print, val_print)
3680         (value_check_printable, val_print_array_elements): Use metadata
3681         style.
3682         * ui-out.h (class ui_out) <field_fmt>: New overload.
3683         <do_field_fmt>: Add style parameter.
3684         * ui-out.c (ui_out::field_fmt): New overload.
3685         * typeprint.c (type_print_unknown_return_type)
3686         (val_print_not_allocated, val_print_not_associated): Use metadata
3687         style.
3688         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3689         parameter.
3690         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3691         * tracepoint.c (tvariables_info_1): Use metadata style.
3692         * stack.c (print_frame_arg, print_frame_info, print_frame)
3693         (info_frame_command_core): Use metadata style.
3694         * skip.c (info_skip_command): Use metadata style.
3695         * rust-lang.c (rust_print_enum): Use metadata style.
3696         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3697         metadata style.
3698         * python/py-framefilter.c (py_print_single_arg): Use metadata
3699         style.
3700         * printcmd.c (do_one_display, print_variable_and_value): Use
3701         metadata style.
3702         * p-valprint.c (pascal_val_print)
3703         (pascal_object_print_value_fields): Use metadata style.
3704         * p-typeprint.c (pascal_type_print_base): Use metadata style.
3705         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3706         parameter.
3707         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3708         * m2-valprint.c (m2_print_long_set): Use metadata style.
3709         * m2-typeprint.c (m2_print_type): Use metadata style.
3710         * infcmd.c (print_return_value_1): Use metadata style.
3711         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3712         * f-valprint.c (info_common_command_for_block): Use metadata
3713         style.
3714         * f-typeprint.c (f_type_print_base): Use metadata style.
3715         * expprint.c (print_subexp_standard): Use metadata style.
3716         * cp-valprint.c (cp_print_value_fields): Use metadata style.
3717         * cli/cli-style.h (class cli_style_option): Add constructor.
3718         (metadata_style): Declare.
3719         * cli/cli-style.c (metadata_style): New global.
3720         (_initialize_cli_style): Register metadata style.
3721         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3722         parameter.
3723         * cli-out.c (cli_ui_out::do_field_fmt): Update.
3724         * c-typeprint.c (c_type_print_base_struct_union)
3725         (c_type_print_base_1): Use metadata style.
3726         * breakpoint.c (watchpoint_value_print)
3727         (print_one_breakpoint_location): Use metadata style.
3728         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3729         style.
3730         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3731         style.
3732         * ada-valprint.c (val_print_packed_array_elements, printstr)
3733         (print_field_values, ada_val_print_ref, ada_val_print): Use
3734         metadata style.
3735         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3736         style.
3737         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3738         style.
3739         * ada-lang.c (user_select_syms): Use metadata style.
3740
3741 2019-10-01  Tom Tromey  <tom@tromey.com>
3742
3743         * cli/cli-cmds.c (pwd_command): Style output.
3744
3745 2019-10-01  Pedro Alves  <palves@redhat.com>
3746             Tom Tromey  <tom@tromey.com>
3747
3748         * symtab.c (print_symbol_info): Use %ps.
3749         (print_msymbol_info): Use %ps.
3750         * symfile.c (symbol_file_add_with_addrs): Use %ps.
3751         * printcmd.c (print_variable_and_value): Use %ps.
3752         * macrocmd.c (show_pp_source_pos): Use %ps.
3753         * infrun.c (print_exited_reason): Use ui_out::message.
3754         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3755         (describe_other_breakpoints): Use ui_out::message and new
3756         formats.
3757         (say_where): Use new formats.
3758         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3759         and new formats.
3760
3761 2019-10-01  Pedro Alves  <palves@redhat.com>
3762             Tom Tromey  <tom@tromey.com>
3763
3764         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3765         (test_gdb_formats): New function.
3766         (run_tests): Call it.
3767         (test_format_specifier): Update.
3768         * utils.h (fputs_filtered): Update comment.
3769         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3770         (fputs_styled_unfiltered): Declare.
3771         * utils.c (fputs_styled_unfiltered): New function.
3772         (vfprintf_maybe_filtered): Add gdbfmt parameter.
3773         (vfprintf_filtered): Update.
3774         (vfprintf_unfiltered, vprintf_filtered): Update.
3775         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3776         * ui-out.h (enum ui_out_flag) <unfiltered_output,
3777         disallow_ui_out_field>: New constants.
3778         (enum class field_kind): New.
3779         (struct base_field_s, struct signed_field_s): New.
3780         (signed_field): New function.
3781         (struct string_field_s): New.
3782         (string_field): New function.
3783         (struct styled_string_s): New.
3784         (styled_string): New function.
3785         (class ui_out) <message>: Add comment.
3786         <vmessage, call_do_message>: New methods.
3787         <do_message>: Add style parameter.
3788         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3789         methods.
3790         (ui_out::message): Rewrite.
3791         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3792         parameter.
3793         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3794         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3795         gdb_extensions parameter.
3796         (class format_piece): Add parameter to constructor.
3797         (n_int_args): New field.
3798         * gdbsupport/format.c (format_pieces::format_pieces): Add
3799         gdb_extensions parameter.  Handle '*'.
3800         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3801         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
3802         vfprintf_styled_no_gdbfmt.
3803         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3804         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3805         unfiltered output.
3806         * ui-style.h (struct ui_file_style) <ptr>: New method.
3807
3808 2019-10-01  Tom Tromey  <tom@tromey.com>
3809
3810         * unittests/format_pieces-selftests.c: Update.  Add final format.
3811         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3812         empty literal pieces.
3813
3814 2019-10-01  Tom Tromey  <tom@tromey.com>
3815
3816         * ui-out.h (enum class ui_out_style_kind): Remove.
3817         (class ui_out) <field_string, field_stsream, do_field_string>:
3818         Change type of "style".
3819         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3820         (ui_out::field_string): Update.
3821         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3822         of "style".
3823         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3824         * tracepoint.c (print_one_static_tracepoint_marker): Update.
3825         * stack.c (print_frame_arg, print_frame_info, print_frame):
3826         Update.
3827         * source.c (print_source_lines_base): Update.
3828         * solib.c (info_sharedlibrary_command): Update.
3829         * skip.c (info_skip_command): Update.
3830         * record-btrace.c (btrace_call_history_src_line)
3831         (btrace_call_history): Update.
3832         * python/py-framefilter.c (py_print_frame): Update.
3833         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3834         "style".
3835         * mi/mi-out.c (mi_ui_out::do_table_header)
3836         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3837         (mi_ui_out::do_field_string): Update.
3838         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3839         Update.
3840         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3841         "style".
3842         * cli-out.c (cli_ui_out::do_table_header)
3843         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3844         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3845         (cli_ui_out::do_field_fmt): Update.
3846         * breakpoint.c (print_breakpoint_location): Update.
3847         (update_static_tracepoint): Update.
3848
3849 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3850
3851         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3852         conversion of gdb_datadir.
3853         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3854         remove not needed c_str ().
3855
3856 2019-09-30  Ali Tamur <tamur@google.com>
3857
3858         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3859         (dwarf2_string_attr): Likewise.
3860
3861 2019-09-30  Ali Tamur <tamur@google.com>
3862
3863         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3864         (process_full_type_unit): Likewise.
3865         (dump_die_shallow): Likewise.
3866         (cu_debug_loc_section): Likewise.
3867
3868 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
3869
3870         * minsyms.c (compare_minimal_symbols): Rename to...
3871         (minimal_symbol_is_less_than): ...this, and adjust to STL
3872         conventions (return bool, take arguments as references)
3873         (minimal_symbol_reader::install): Call std::sort instead
3874         of qsort.
3875
3876 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
3877
3878         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3879         hash and why.
3880         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3881         msymbol_hash, msymbol_demangled_hash>: Improve comments.
3882
3883 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
3884
3885         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3886         * psympriv.h (add_psymbol_to_list): Move comment here and update
3887         it.
3888
3889 2019-09-29  Tom de Vries  <tdevries@suse.de>
3890
3891         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3892         Use $tmpdir/$(basename "$output_file").dwz instead of
3893         "${output_file}.dwz".
3894
3895 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
3896
3897         PR gdb/25045
3898         * hppa-linux-nat.c: Include gdbarch.h.
3899
3900 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
3901
3902         * blockframe.c (find_pc_partial_function): Change return type to bool.
3903         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3904         * minsyms.c (in_gnu_ifunc_stub): Likewise.
3905         (stub_gnu_ifunc_resolve_name): Likewise.
3906         * symtab.c (compare_filenames_for_search): Likewise.
3907         (compare_glob_filenames_for_search): Likewise.
3908         (matching_obj_sections): Likewise.
3909         (symbol_matches_domain): Likewise.
3910         (find_line_symtab): Change out param EXACT_MATCH to bool *.
3911         (find_line_pc): Change return type to bool.
3912         (find_line_pc_range): Likewise.
3913         (producer_is_realview): Likewise.
3914         * symtab.h (symbol_matches_domain): Likewise.
3915         (find_pc_partial_function): Likewise.
3916         (find_pc_line_pc_range): Likewise.
3917         (in_gnu_ifunc_stub): Likewise.
3918         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3919         (find_line_pc): Likewise.
3920         (find_line_pc_range): Likewise.
3921         (matching_obj_sections): Likewise.
3922         (find_line_symtab): Change out parameter to bool.
3923         (producer_is_realview): Change return type to bool.
3924         (compare_filenames_for_search): Likewise.
3925         (compare_glob_filenames_for_search): Likewise.
3926
3927 2019-09-26  Tom Tromey  <tom@tromey.com>
3928
3929         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3930         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3931         * gdb_usleep.h: Remove.
3932         * gdb_usleep.c: Remove.
3933         * utils.c: Don't include gdb_usleep.h.
3934
3935 2019-09-26  Tom Tromey  <tromey@adacore.com>
3936
3937         * python/py-type.c (type_to_type_object): Call check_typedef
3938         for stub types.
3939
3940 2019-09-26  Tom Tromey  <tom@tromey.com>
3941
3942         * utils.h (initialize_utils): Don't declare.
3943         * top.c (gdb_init): Don't call initialize_utils.
3944         * utils.c (initialize_utils): Remove.  Move contents...
3945         (_initialize_utils): ... here.
3946
3947 2019-09-25  Tom Tromey  <tom@tromey.com>
3948
3949         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3950         * utils.h (make_hex_string): Don't declare.
3951         * utils.c (make_hex_string): Remove.
3952
3953 2019-09-24  Tom de Vries  <tdevries@suse.de>
3954
3955         PR gdb/23815
3956         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3957         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3958
3959 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
3960
3961         * NEWS: Mention new simulator port for PRU.
3962
3963 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
3964
3965         * ada-exp.y (write_object_remaining): Update.
3966         * ada-lang.c (ada_decode): Return a std::string instead of a char*
3967         and eliminate the static buffer.
3968         (ada_decode_symbol): Update.
3969         (ada_la_decode): Update.
3970         (ada_sniff_from_mangled_name): Update.
3971         (is_valid_name_for_wild_match): Update.
3972         (ada_lookup_name_info::matches): Update and simplify.
3973         (name_matches_regex): Update.
3974         (ada_add_global_exceptions): Update.
3975         * ada-lang.h (ada_decode): Update signature.
3976         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3977         * dwarf-index-write.c (debug_names::insert): Update.
3978
3979 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3980
3981         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3982         formatting.
3983
3984 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3985
3986         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3987         Change "nonzero" to "true" in documentation.
3988
3989 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
3990
3991         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3992         (_initialize_darwin_solib): Don't set
3993         darwin_so_ops.lookup_lib_global_symbol.
3994         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3995         set_gdbarch_iterate_over_objfiles_in_search_order.
3996         (elf_lookup_lib_symbol): Rename to...
3997         (svr4_iterate_over_objfiles_in_search_order): this, and update
3998         to iterate semantics.
3999         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
4000         * solib.c (solib_global_lookup): Remove.
4001         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
4002         (solib_global_lookup): Remove.
4003         * symtab.c (lookup_global_or_static_symbol): Remove call to
4004         solib_global_lookup.
4005
4006 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
4007
4008         * NEWS: Move entries about default MI version now being
4009         version 3, and about the GDB/MI fix for multi-location
4010         breakpoints to the "since GDB 8.3" section.
4011
4012 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
4013
4014         GDB 8.3.1 released.
4015
4016 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
4017
4018         * NEWS: Mention that Cell/B.E. debugging support was removed.
4019         * MAINTAINERS: Remove spu target.
4020
4021         * config/djgpp/fnchange.lst: Remove entries for removed files.
4022
4023         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
4024         spu-multiarch.o, and spu-tdep.o.
4025         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
4026         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
4027         spu-multiarch.c, and spu-tdep.c.
4028         * spu-linux-nat.c: Remove file.
4029         * spu-multiarch.c: Remove file.
4030         * spu-tdep.c: Remove file.
4031         * spu-tdep.h: Remove file.
4032         * solib-spu.c: Remove file.
4033         * solib-spu.h: Remove file.
4034
4035         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
4036         * configure.nat (spu-linux): Remove.
4037         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
4038         solib-multiarch.o from gdb_target_obs.
4039         (spu*-*-*): Remove.
4040
4041         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
4042         feature flag.
4043         (ppc_linux_no_features): Update.
4044         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
4045         Cell/B.E. support.
4046         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
4047         (tdesc_powerpc_cell64l): Likewise.
4048         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
4049         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
4050         Cell/B.E. support.
4051         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4052         Do not include "features/rs6000/powerpc-cell32l.c" or
4053         "features/rs6000/powerpc-cell64l.c".
4054         (ppc_linux_spu_section): Remove.
4055         (ppc_linux_core_read_description): Remove Cell/B.E. support.
4056         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4057         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4058         (ppc_linux_spe_context_lookup): Remove.
4059         (ppc_linux_spe_context_inferior_created): Remove.
4060         (ppc_linux_spe_context_solib_loaded): Remove.
4061         (ppc_linux_spe_context_solib_unloaded): Remove.
4062         (ppc_linux_spe_context): Remove.
4063         (struct ppu2spu_cache): Remove.
4064         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4065         (struct ppu2spu_data): Remove.
4066         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4067         ppu2spu_unwind): Remove.
4068         (ppc_linux_init_abi): Remove Cell/B.E. support.
4069         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4070
4071         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4072         (rs6000/powerpc-cell64l-expedite): Likewise
4073         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4074         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4075         rs6000/powerpc-cell64l.xml.
4076         * features/rs6000/powerpc-cell32l.xml: Remove.
4077         * features/rs6000/powerpc-cell64l.xml: Likewise.
4078         * features/rs6000/powerpc-cell32l.c: Remove generated file.
4079         * features/rs6000/powerpc-cell64l.c: Likewise.
4080         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4081         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4082         * regformats/reg-spu.dat: Remove.
4083
4084         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4085         * corelow.c (struct spuid_list): Remove.
4086         (add_to_spuid_list): Remove.
4087         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4088         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4089         (remote_protocol_features): Remove associated entries.
4090         (_initialize_remote): No longer initialize them.
4091         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4092         * linux-nat.c (SPUFS_MAGIC): Remove.
4093         (linux_proc_xfer_spu): Remove.
4094         (spu_enumerate_spu_ids): Remove.
4095         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4096         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4097         (linux_make_corefile_notes): No longer call it.
4098
4099         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4100         (cooked_write_test): Likewise.
4101
4102 2019-09-20  Tom Tromey  <tom@tromey.com>
4103
4104         * NEWS: Mention case-sensitivity of TUI commands.
4105         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4106         (tui_set_win_height_command, parse_scrolling_args): Likewise.
4107         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4108
4109 2019-09-20  Tom Tromey  <tom@tromey.com>
4110
4111         * tui/tui-source.c (tui_source_window::set_contents): Use
4112         make_unique_xstrdup.
4113         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4114         make_unique_xstrdup.
4115
4116 2019-09-20  Tom Tromey  <tom@tromey.com>
4117
4118         * tui/tui-data.c: Remove separator comments.
4119         * tui/tui-layout.c: Remove separator comments.
4120         * tui/tui-win.c: Remove separator comments.
4121         * tui/tui-wingeneral.c: Remove separator comments.
4122
4123 2019-09-20  Tom Tromey  <tom@tromey.com>
4124
4125         * tui/tui.h (strcat_to_buf): Don't declare.
4126         * tui/tui.c (strcat_to_buf): Remove.
4127
4128 2019-09-20  Tom Tromey  <tom@tromey.com>
4129
4130         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4131         from "fullname".
4132         * tui/tui-source.c (tui_source_window::set_contents)
4133         (tui_source_window::location_matches_p)
4134         (tui_source_window::maybe_update): Update.
4135
4136 2019-09-20  Tom Tromey  <tom@tromey.com>
4137
4138         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4139         Update.
4140         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4141         prefix.
4142         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4143         (tui_data_window::line_from_reg_element_no)
4144         (tui_data_window::first_reg_element_no_inline)
4145         (tui_data_window::show_registers)
4146         (tui_data_window::show_register_group)
4147         (tui_data_window::display_registers_from)
4148         (tui_data_window::display_registers_from_line)
4149         (tui_data_window::first_data_item_displayed)
4150         (tui_data_window::delete_data_content_windows)
4151         (tui_data_window::erase_data_content)
4152         (tui_data_window::do_scroll_vertical)
4153         (tui_data_window::refresh_window)
4154         (tui_data_window::check_register_values): Update.
4155
4156 2019-09-20  Tom Tromey  <tom@tromey.com>
4157
4158         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4159         (struct tui_locator_window) <full_name, proc_name>: Now
4160         std::string.
4161         * tui/tui-stack.c (tui_locator_window::make_status_line)
4162         (tui_locator_window::set_locator_fullname)
4163         (tui_locator_window::set_locator_info): Update.
4164         * tui/tui-source.c (tui_source_window::set_contents)
4165         (tui_source_window::showing_source_p): Update.
4166
4167 2019-09-20  Tom Tromey  <tom@tromey.com>
4168
4169         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4170         Don't call tui_locator_win_info_ptr.
4171
4172 2019-09-20  Tom Tromey  <tom@tromey.com>
4173
4174         * tui/tui-win.c (tui_resize_all): Don't call refresh.
4175
4176 2019-09-20  Tom Tromey  <tom@tromey.com>
4177
4178         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4179         height for locator.
4180         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4181         * tui/tui-layout.c (show_source_disasm_command, show_data)
4182         (show_source_or_disasm_and_command): Use 1 as height for locator.
4183
4184 2019-09-20  Tom Tromey  <tom@tromey.com>
4185
4186         * tui/tui.c (tui_enable): Update.
4187         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4188         Update.
4189         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4190         Update.
4191         * tui/tui-data.c (win_resized): Now bool.
4192         (tui_win_resized): Return bool.
4193         (tui_set_win_resized_to): Accept a bool.
4194
4195 2019-09-20  Tom Tromey  <tom@tromey.com>
4196
4197         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4198         Change type of "refresh_values_only".
4199         * tui/tui-regs.c (tui_data_window::show_register_group): Change
4200         type of "refresh_values_only".
4201
4202 2019-09-20  Tom Tromey  <tom@tromey.com>
4203
4204         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4205         std::string.
4206         (tui_disassemble): Add "pos" parameter.
4207         (tui_disasm_window::set_contents): Simplify.
4208
4209 2019-09-20  Tom Tromey  <tom@tromey.com>
4210
4211         * tui/tui-winsource.h (struct tui_source_window_base)
4212         <show_source_content>: Now private.
4213         * tui/tui-winsource.c
4214         (tui_source_window_base::show_source_content): Don't handle empty
4215         content case.
4216
4217 2019-09-20  Tom Tromey  <tom@tromey.com>
4218
4219         * tui/tui-layout.c (show_source_disasm_command)
4220         (show_source_or_disasm_and_command): Don't call
4221         show_source_content.
4222
4223 2019-09-20  Tom Tromey  <tom@tromey.com>
4224
4225         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4226         Declare.
4227         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4228         from tui_make_status_line.
4229         (tui_locator_window::rerender): Update.
4230
4231 2019-09-20  Tom Tromey  <tom@tromey.com>
4232
4233         * tui/tui-stack.c (tui_make_status_line): Return std::string.
4234         (tui_locator_window::rerender): Update.
4235
4236 2019-09-20  Tom Tromey  <tom@tromey.com>
4237
4238         * tui/tui-winsource.h (struct tui_source_window_base)
4239         <~tui_source_window_base>: Don't declare.
4240         <fullname>: Remove.
4241         * tui/tui-winsource.c (~tui_source_window_base): Remove.
4242         * tui/tui-source.h (struct tui_source_window) <fullname>: New
4243         member.
4244         * tui/tui-source.c (tui_source_window::set_contents): Update.
4245         (tui_source_window::location_matches_p)
4246         (tui_source_window::maybe_update): Update.
4247
4248 2019-09-20  Tom Tromey  <tom@tromey.com>
4249
4250         * tui/tui-winsource.h (~tui_source_element): Remove.
4251         (tui_source_element): Update.
4252         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4253         * tui/tui-winsource.c (tui_show_source_line): Update.
4254         * tui/tui-source.c (tui_source_window::set_contents): Update.
4255         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4256
4257 2019-09-20  Tom Tromey  <tom@tromey.com>
4258
4259         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4260         declare.
4261         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4262         tui_clear_source_windows_detail.
4263         * tui/tui-winsource.h (struct tui_source_window_base)
4264         <clear_detail>: Don't declare.
4265         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4266         Remove.
4267         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4268
4269 2019-09-20  Tom Tromey  <tromey@adacore.com>
4270
4271         PR ada/24919:
4272         * block.c (contained_in): Fix final return value.
4273
4274 2019-09-20  Alan Modra  <amodra@gmail.com>
4275
4276         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4277         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4278         (read_indirect_string_from_dwz): Use bfd accessor.
4279         * dwarf2read.h (struct dwz_file <filename>): Likewise.
4280         * machoread.c (macho_symfile_read_all_oso): Likewise.
4281         * solib.c (solib_bfd_open): Likewise.
4282
4283 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4284
4285         * eval.c: Move declaration of overload_resolution to...
4286         * value.h: ...here.
4287
4288 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4289
4290         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4291         * arm-linux-tdep.c: Likewise.
4292         * arm-nbsd-nat.c: Likewise.
4293         * arm-tdep.h: Declare arm_apcs_32.
4294         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4295
4296 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4297
4298         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4299         * dwarf2read.h: Declare dwarf_always_disassemble.
4300
4301 2019-09-19  Tom de Vries  <tdevries@suse.de>
4302
4303         PR gdb/25009
4304         * source-cache.c (source_cache::ensure): Catch exception thrown during
4305         construction of the highlighter.
4306
4307 2019-09-18  Alan Modra  <amodra@gmail.com>
4308
4309         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4310         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4311         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4312         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4313         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4314         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4315         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4316         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4317         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4318         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4319         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4320         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4321         * solib-spu.c, * solib-svr4.c, * solib-target.c,
4322         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4323         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4324         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4325         * mi/mi-interp.c: Update throughout for bfd section macro and
4326         function changes.
4327         * gcore (gcore_create_callback): Use bfd_set_section_lma.
4328         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4329
4330 2019-09-18  Tom Tromey  <tom@tromey.com>
4331
4332         * NEWS: Add entry.
4333         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
4334         call rl_initialize.
4335         (tui_enable): Do not call rl_initialize.
4336
4337 2019-09-18  Christian Groessler  <chris@groessler.org>
4338
4339         * alpha-linux-nat.c: Include gdbarch.h.
4340
4341 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
4342
4343         * ui-file.c: Include cli/cli-style.h.
4344         (term_cli_styling): Remove cli_styling declaration.
4345
4346 2019-09-18  Alan Modra  <amodra@gmail.com>
4347
4348         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4349         to bfd_asymbol_section.
4350
4351 2019-09-18  Alan Modra  <amodra@gmail.com>
4352
4353         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4354         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4355         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4356
4357 2019-09-18  Alan Modra  <amodra@gmail.com>
4358
4359         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4360         * spu-linux-nat.c (spu_bfd_open): Likewise.
4361
4362 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
4363
4364         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4365         to bool to match definition in dwarf2read.c.
4366
4367 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
4368
4369         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4370         (print_signatures): Likewise.
4371         (trust_pad_over_xvs): Likewise.
4372         * arch/aarch64-insn.c (aarch64_debug): Likewise.
4373         * arch/aarch64-insn.h (aarch64_debug): Likewise.
4374         * arm-linux-nat.c (arm_apcs_32): Likewise.
4375         * arm-linux-tdep.c (arm_apcs_32): Likewise.
4376         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4377         * arm-tdep.c (arm_debug): Likewise.
4378         (arm_apcs_32): Likewise.
4379         * auto-load.c (debug_auto_load): Likewise.
4380         (auto_load_gdb_scripts): Likewise.
4381         (global_auto_load): Likewise.
4382         (auto_load_local_gdbinit): Likewise.
4383         (auto_load_local_gdbinit_loaded): Likewise.
4384         * auto-load.h (global_auto_load): Likewise.
4385         (auto_load_local_gdbinit): Likewise.
4386         (auto_load_local_gdbinit_loaded): Likewise.
4387         * breakpoint.c (disconnected_dprintf): Likewise.
4388         (breakpoint_proceeded): Likewise.
4389         (automatic_hardware_breakpoints): Likewise.
4390         (always_inserted_mode): Likewise.
4391         (target_exact_watchpoints): Likewise.
4392         (_initialize_breakpoint): Update.
4393         * breakpoint.h (target_exact_watchpoints): Change to bool.
4394         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4395         * cli/cli-cmds.c (trace_commands): Likewise.
4396         * cli/cli-cmds.h (trace_commands): Likewise.
4397         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4398         to bool*.
4399         * cli/cli-logging.c (logging_overwrite): Change to bool.
4400         (logging_redirect): Likewise.
4401         (debug_redirect): Likewise.
4402         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4403         (struct boolean_option_def) <get_var_address_cb_>: Change return type
4404         to bool.
4405         <boolean_option_def>: Update.
4406         (struct flag_option_def): Change default type of Context to bool
4407         from int.
4408         <flag_option_def>: Change return type of var_address_cb_ to bool*.
4409         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4410         (get_setshow_command_value_string): Likewise.
4411         * cli/cli-style.c (cli_styling): Change to bool.
4412         (source_styling): Likewise.
4413         * cli/cli-style.h (source_styling): Likewise.
4414         (cli_styling): Likewise.
4415         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4416         to bool.
4417         * command.h (var_types): Update comment.
4418         (add_setshow_boolean_cmd): Change int* var argument to bool*.
4419         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4420         bool.
4421         (debug_compile_cplus_scopes): Likewise.
4422         * compile/compile-internal.h (compile_debug): Likewise.
4423         * compile/compile.c (compile_debug): Likewise.
4424         (struct compile_options) <raw>: Likewise.
4425         * cp-support.c (catch_demangler_crashes): Likewise.
4426         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4427         (usr_cmd_cris_dwarf2_cfi): Likewise.
4428         * csky-tdep.c (csky_debug): Likewise.
4429         * darwin-nat.c (enable_mach_exceptions): Likewise.
4430         * dcache.c (dcache_enabled_p): Likewise.
4431         * defs.h (info_verbose): Likewise.
4432         * demangle.c (demangle): Likewise.
4433         (asm_demangle): Likewise.
4434         * dwarf-index-cache.c (debug_index_cache): Likewise.
4435         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4436         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4437         * dwarf2read.c (check_physname): Likewise.
4438         (use_deprecated_index_sections): Likewise.
4439         (dwarf_always_disassemble): Likewise.
4440         * eval.c (overload_resolution): Likewise.
4441         * event-top.c (set_editing_cmd_var): Likewise.
4442         (exec_done_display_p): Likewise.
4443         * event-top.h (set_editing_cmd_var): Likewise.
4444         (exec_done_display_p): Likewise.
4445         * exec.c (write_files): Likewise.
4446         * fbsd-nat.c (debug_fbsd_lwp): Likewise
4447         (debug_fbsd_nat): Likewise.
4448         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4449         Likewise.
4450         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4451         <backtrace_past_entry> Likewise.
4452         * gdb-demangle.h (demangle): Likewise.
4453         (asm_demangle): Likewise.
4454         * gdb_bfd.c (bfd_sharing): Likewise.
4455         * gdbcore.h (write_files): Likewise.
4456         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4457         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4458         * gdbthread.h (print_thread_events): Likewise.
4459         * gdbtypes.c (opaque_type_resolution): Likewise.
4460         (strict_type_checking): Likewise.
4461         * gnu-nat.c (gnu_debug_flag): Likewise.
4462         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4463         * guile/scm-param.c (pascm_variable): Add boolval.
4464         (add_setshow_generic): Update.
4465         (pascm_param_value): Update.
4466         (pascm_set_param_value_x): Update.
4467         * hppa-tdep.c (hppa_debug): Change to bool..
4468         * infcall.c (may_call_functions_p): Likewise.
4469         (coerce_float_to_double_p): Likewise.
4470         (unwind_on_signal_p): Likewise.
4471         (unwind_on_terminating_exception_p): Likewise.
4472         * infcmd.c (startup_with_shell): Likewise.
4473         * inferior.c (print_inferior_events): Likewise.
4474         * inferior.h (startup_with_shell): Likewise.
4475         (print_inferior_events): Likewise.
4476         * infrun.c (step_stop_if_no_debug): Likewise.
4477         (detach_fork): Likewise.
4478         (debug_displaced): Likewise.
4479         (disable_randomization): Likewise.
4480         (non_stop): Likewise.
4481         (non_stop_1): Likewise.
4482         (observer_mode): Likewise.
4483         (observer_mode_1): Likewise.
4484         (set_observer_mode): Update.
4485         (sched_multi): Change to bool.
4486         * infrun.h (debug_displaced): Likewise.
4487         (sched_multi): Likewise.
4488         (step_stop_if_no_debug): Likewise.
4489         (non_stop): Likewise.
4490         (disable_randomization): Likewise.
4491         * linux-tdep.c (use_coredump_filter): Likewise.
4492         (dump_excluded_mappings): Likewise.
4493         * linux-thread-db.c (auto_load_thread_db): Likewise.
4494         (check_thread_db_on_load): Likewise.
4495         * main.c (captured_main_1): Update.
4496         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4497         xx2_opt, boolean_opt>: Change to bool.
4498         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4499         * maint.c (maintenance_profile_p): Likewise.
4500         (per_command_time): Likewise.
4501         (per_command_space): Likewise.
4502         (per_command_symtab): Likewise.
4503         * memattr.c (inaccessible_by_default): Likewise.
4504         * mi/mi-main.c (mi_async): Likewise.
4505         (mi_async_1): Likewise.
4506         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4507         * nat/fork-inferior.h (startup_with_shell): Likewise.
4508         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4509         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4510         * nios2-tdep.c (nios2_debug): Likewise.
4511         * or1k-tdep.c (or1k_debug): Likewise.
4512         * parse.c (parser_debug): Likewise.
4513         * parser-defs.h (parser_debug): Likewise.
4514         * printcmd.c (print_symbol_filename): Likewise.
4515         * proc-api.c (procfs_trace): Likewise.
4516         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4517         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4518         (set_parameter_value): Update.
4519         (add_setshow_generic): Update.
4520         * python/py-value.c (copy_py_bool_obj): Change argument from int*
4521         to bool*.
4522         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4523         int*.
4524         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4525         * record-btrace.c (record_btrace_target::store_registers): Update.
4526         * record-full.c (record_full_memory_query): Change to bool.
4527         (record_full_stop_at_limit): Likewise.
4528         * record-full.h (record_full_memory_query): Likewise.
4529         * remote-notif.c (notif_debug): Likewise.
4530         * remote-notif.h (notif_debug): Likewise.
4531         * remote.c (use_range_stepping): Likewise.
4532         (interrupt_on_connect): Likewise.
4533         (remote_break): Likewise.
4534         * ser-tcp.c (tcp_auto_retry): Likewise.
4535         * ser-unix.c (serial_hwflow): Likewise.
4536         * skip.c (debug_skip): Likewise.
4537         * solib-aix.c (solib_aix_debug): Likewise.
4538         * spu-tdep.c (spu_stop_on_load_p): Likewise.
4539         (spu_auto_flush_cache_p): Likewise.
4540         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4541         Likewise.
4542         (struct info_print_options) <quiet>: Likewise.
4543         * symfile-debug.c (debug_symfile): Likewise.
4544         * symfile.c (auto_solib_add): Likewise.
4545         (separate_debug_file_debug): Likewise.
4546         * symfile.h (auto_solib_add): Likewise.
4547         (separate_debug_file_debug): Likewise.
4548         * symtab.c (basenames_may_differ): Likewise.
4549         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4550         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4551         (struct info_types_options) <quiet>: Likewise.
4552         * symtab.h (demangle): Likewise.
4553         (basenames_may_differ): Likewise.
4554         * target-dcache.c (stack_cache_enabled_1): Likewise.
4555         (code_cache_enabled_1): Likewise.
4556         * target.c (trust_readonly): Likewise.
4557         (may_write_registers): Likewise.
4558         (may_write_memory): Likewise.
4559         (may_insert_breakpoints): Likewise.
4560         (may_insert_tracepoints): Likewise.
4561         (may_insert_fast_tracepoints): Likewise.
4562         (may_stop): Likewise.
4563         (auto_connect_native_target): Likewise.
4564         (target_stop_and_wait): Update.
4565         (target_async_permitted): Change to bool.
4566         (target_async_permitted_1): Likewise.
4567         (may_write_registers_1): Likewise.
4568         (may_write_memory_1): Likewise.
4569         (may_insert_breakpoints_1): Likewise.
4570         (may_insert_tracepoints_1): Likewise.
4571         (may_insert_fast_tracepoints_1): Likewise.
4572         (may_stop_1): Likewise.
4573         * target.h (target_async_permitted): Likewise.
4574         (may_write_registers): Likewise.
4575         (may_write_memory): Likewise.
4576         (may_insert_breakpoints): Likewise.
4577         (may_insert_tracepoints): Likewise.
4578         (may_insert_fast_tracepoints): Likewise.
4579         (may_stop): Likewise.
4580         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4581         (make_thread_apply_all_options_def_group): Change argument from int*
4582         to bool*.
4583         (thread_apply_all_command): Update.
4584         (print_thread_events): Change to bool.
4585         * top.c (confirm): Likewise.
4586         (command_editing_p): Likewise.
4587         (history_expansion_p): Likewise.
4588         (write_history_p): Likewise.
4589         (info_verbose): Likewise.
4590         * top.h (confirm): Likewise.
4591         (history_expansion_p): Likewise.
4592         * tracepoint.c (disconnected_tracing): Likewise.
4593         (circular_trace_buffer): Likewise.
4594         * typeprint.c (print_methods): Likewise.
4595         (print_typedefs): Likewise.
4596         * utils.c (debug_timestamp): Likewise.
4597         (sevenbit_strings): Likewise.
4598         (pagination_enabled): Likewise.
4599         * utils.h (sevenbit_strings): Likewise.
4600         (pagination_enabled): Likewise.
4601         * valops.c (overload_resolution): Likewise.
4602         * valprint.h (struct value_print_options) <prettyformat_arrays,
4603         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4604         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4605         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4606         Likewise.
4607         * windows-nat.c (new_console): Likewise.
4608         (cygwin_exceptions): Likewise.
4609         (new_group): Likewise.
4610         (debug_exec): Likewise.
4611         (debug_events): Likewise.
4612         (debug_memory): Likewise.
4613         (debug_exceptions): Likewise.
4614         (useshell): Likewise.
4615         * windows-tdep.c (maint_display_all_tib): Likewise.
4616         * xml-support.c (debug_xml): Likewise.
4617
4618 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
4619
4620         * source.c (prepare_path_for_appending): New function.
4621         (openp): Make use of new function.
4622         (find_and_open_source): Search for the compilation directory and
4623         source file as a relative path beneath the directory search path.
4624
4625 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4626
4627         * source-cache.c (source_cache::get_line_charpos): Catch
4628         exceptions and return false, this matches the behaviour documented
4629         in the header file.
4630
4631 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
4632
4633         * ada-tasks.c (info_task): Remove quoting of the task's name.
4634
4635 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
4636
4637         * symfile.c (auto_solib_add): Replace comment with a reference
4638         to the header file.
4639
4640 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
4641
4642         * NEWS: Mention that gdb can now be compiled with Python 3
4643         on Windows.
4644
4645 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4646
4647         * maint.c (maint_print_section_data::maint_print_section_data):
4648         Force use of 'float log10 (float)' by casting the argument to
4649         float.
4650
4651 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4652
4653         * maint.c: Add 'cmath' include.
4654         (struct maint_print_section_data): New structure.
4655         (print_section_index): New function.
4656         (print_bfd_section_info): Add header comment, small whitespace
4657         cleanup, and update to call new print_section_index function.
4658         (print_objfile_section_info): Likewise.
4659         (maint_obj_section_from_bfd_section): New function.
4660         (print_bfd_section_info_maybe_relocated): New function.
4661         (maintenance_info_sections): Add header comment, always use
4662         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4663
4664 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4665
4666         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4667         inner scope, add check that the objfile has psymtabs before
4668         checking psymtabs_addrmap.
4669         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4670
4671 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4672
4673         * NEWS: Announce that Ada task names are now shown at more places,
4674         and between quotes (except in info task output).
4675         * gdb/ada-tasks.c (task_to_str): New function.
4676         (display_current_task_id): Call task_to_str.
4677         (task_command_1): Likewise.
4678         (print_ada_task_info): In non-mi mode, Properly align headers and data
4679         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4680
4681 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4682
4683         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4684         prstatus.pr_lwp.pr_info instead of making it up.
4685
4686 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4687
4688         * auto-load.c (auto_load_expand_dir_vars): Update.
4689         * defs.h (gdb_datadir): Change to std::string.
4690         (python_libdir): Likewise.
4691         (relocate_gdb_directory): Change return type to std::string.
4692         * guile/guile.c (gdbscm_data_directory): Update.
4693         (initialize_scheme_side): Update.
4694         * jit.c (jit_reader_dir): Change to std::string.
4695         (jit_reader_load_command): Update.
4696         * main.c (gdb_datadir): Change to std::string.
4697         (python_libdir): Likewise.
4698         (set_gdb_data_directory): Update.
4699         (relocate_path): Change to return std::string.
4700         (relocate_gdb_directory): Change to return std::string.
4701         (relocate_gdbinit_path_maybe_in_datadir): Update.
4702         (captured_main_1): Update.
4703         * python/python.c (do_start_initialization): Update.
4704         * top.c (show_gdb_datadir): Update.
4705         * xml-syscall.c (xml_init_syscalls_info): Update.
4706         (init_syscalls_info): Update.
4707
4708 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4709
4710         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4711         out of get_init_files.
4712         (get_init_files): Update.
4713
4714 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4715
4716         * main.c (get_init_files): Change to use std::string.
4717         (captured_main_1): Update.
4718         (print_gdb_help): Update.
4719
4720 2019-09-11  Ali Tamur  <tamur@google.com>
4721
4722         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4723         implementation.
4724
4725 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4726
4727         * dbxread.c (read_dbx_symtab): Update.
4728         * dwarf2read.c (load_partial_dies): Update.
4729         * mdebugread.c (parse_partial_symbols): Update.
4730         (handle_psymbol_enumerators): Update.
4731         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4732         * psymtab.c (add_psymbol_to_bcache): Likewise.
4733         (add_psymbol_to_list): Likewise.
4734         * symtab.c (symbol_set_names): Likewise.
4735         * symtab.h (symbol_set_names): Likewise.
4736         * xcoffread.c (scan_xcoff_symtab): Update.
4737
4738 2019-09-11  Tom Tromey  <tom@tromey.com>
4739
4740         * symfile-mem.c (symbol_file_add_from_memory): Use
4741         bfd_set_filename.
4742         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4743         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4744
4745 2019-09-10  Tom Tromey  <tromey@adacore.com>
4746
4747         * dwarf-index-write.c (write_psymbols): Extend error message.
4748         (debug_names::insert): Add Ada code.
4749         (debug_names::write_psymbols): Remove Ada check.
4750         (debug_names) <m_string_obstack>: New member.
4751         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4752         (gdb_index_symbol_name_matcher::matches): Remove.
4753         (mapped_index_base::find_name_components_bounds): Add "lang"
4754         parameter.
4755         (mapped_index_base::build_name_components): Also split names
4756         according to Ada syntax.
4757         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
4758         type of "match_callback".
4759         (check_match, check_find_bounds_finds)
4760         (dw2_expand_symtabs_matching): Update.
4761         (dw2_debug_names_iterator): Add new constructor.
4762         (dw2_debug_names_map_matching_symbols): New function.
4763         (dw2_debug_names_expand_symtabs_matching): Update.
4764         (dwarf2_debug_names_functions): Use
4765         dw2_debug_names_map_matching_symbols.
4766
4767 2019-09-10  Tom Tromey  <tromey@adacore.com>
4768
4769         * dwarf2read.c (dw2_get_file_names_reader): Add the
4770         CU's file name to the results.
4771
4772 2019-09-10  Tom Tromey  <tromey@adacore.com>
4773
4774         * ada-lang.c (add_nonlocal_symbols): Combine calls to
4775         map_matching_symbols.  Update.
4776         * dwarf2read.c (dw2_map_matching_symbols): Update.
4777         * psymtab.c (match_partial_symbol): Change type; update.
4778         (psym_map_matching_symbols): Likewise.
4779         * symfile-debug.c (debug_qf_map_matching_symbols): Change
4780         type; update.
4781         * symfile.h (struct quick_symbol_functions)
4782         <map_matching_symbols>: Change "name" to be a lookup_name_info.
4783         Remove "match".
4784
4785 2019-09-10  Tom Tromey  <tromey@adacore.com>
4786
4787         * psymtab.c (map_block): Remove.
4788         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4789         * symtab.c (iterate_over_symbols_terminated): New function.
4790         * symtab.c (iterate_over_symbols_terminated): Declare.
4791
4792 2019-09-10  Tom Tromey  <tromey@adacore.com>
4793
4794         * ada-lang.c (ada_iterate_over_symbols): Return bool.
4795         * language.h (struct language_defn) <la_iterate_over_symbols>:
4796         Return bool.
4797         * symtab.c (iterate_over_symbols): Return bool.
4798         * symtab.h (iterate_over_symbols): Return bool.
4799
4800 2019-09-10  Tom Tromey  <tromey@adacore.com>
4801
4802         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4803         (add_nonlocal_symbols): Update.
4804         * dwarf2read.c (dw2_map_matching_symbols): Change type.
4805         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4806         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4807         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4808         Change type of "callback".  Remove "data".
4809
4810
4811 2019-09-09  Ali Tamur  <tamur@google.com>
4812
4813         * dwarf2read.c (comp_unit_head): Update comment.
4814         (dwarf2_dwo_name): New function declaration.
4815         (dwarf_unit_type_name): New function declaration.
4816         (read_comp_unit_head): Add support for new compilation units,
4817         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4818         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4819         (currently named as "signature") in their header. Also clarify error
4820         messages.
4821         (lookup_dwo_id): New function. Returns the dwo id of the given
4822         compile unit.
4823         (lookup_dwo_unit): Use the new lookup_dwo_id function.
4824         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4825         functions.
4826         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4827         (dwarf2_dwo_name): Get the dwo name if present.
4828         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4829         purposes.
4830
4831 2019-09-09  Tom Tromey  <tom@tromey.com>
4832
4833         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4834
4835 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4836
4837         * python/python.c (do_start_initialization): Make progname_copy static,
4838         to avoid a leak report.
4839
4840 2019-09-08  Tom Tromey  <tom@tromey.com>
4841
4842         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4843
4844 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
4845
4846         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4847         Change type to gdb::optional<block_enum>.
4848         (dw2_symtab_iter_init): Change block_index parameter type
4849         to gdb::optional<block_enum>.
4850         (dw2_lookup_symbol): Change block_index parameter
4851         type to block_enum.c
4852         (dw2_debug_names_lookup_symbol): Likewise.
4853         * psymtab.c (psym_lookup_symbol): Likewise.
4854         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4855         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4856         Likewise.
4857
4858 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
4859
4860         * defs.h (relocate_gdb_directory): Change int to bool in
4861         signature and rename flag to relocatable.
4862         * main.c (relocate_path): Likewise.
4863         (relocate_gdb_directory): Likewise.
4864
4865 2019-09-06  Alan Modra  <amodra@gmail.com>
4866
4867         * coffread.c (coff_symfile_read): Constify filename variable.
4868         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4869         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4870         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4871         * solib.c (reload_shared_libraries_1): Likewise.
4872         * symfile.c (reread_symbols): Likewise.
4873         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4874         * solib-darwin.c (darwin_bfd_open): Likewise.
4875         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4876
4877 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4878
4879         * psymtab.c (print_partial_symbols): Handle missing domain_enum
4880         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4881
4882 2019-09-03  Tom Tromey  <tromey@adacore.com>
4883
4884         * ada-valprint.c (ada_val_print_num): Don't recurse for range
4885         types.
4886         (has_negatives): Unbias a range type bound.
4887         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4888         * gdbtypes.c (operator==): Handle new field.
4889         (create_range_type): Add "bias" parameter.
4890         (create_static_range_type, resolve_dynamic_range): Update.
4891         * gdbtypes.h (struct range_bounds) <bias>: New member.
4892         (create_range_type): Add bias parameter.
4893         * printcmd.c (print_scalar_formatted): Unbias range types.
4894         * value.c (unpack_long): Unbias range types.
4895         (pack_long): Bias range types.
4896
4897 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4898
4899         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4900         probe arguments.
4901
4902 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4903
4904         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4905         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4906         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4907         (compile_probe_arg): Likewise.
4908         * probe.h (get_argument_count): Likewise.
4909         * solib-svr4.c (solib_event_probe_action): Likewise.
4910         * stap-probe.c (stap_probe::get_argument_count): Likewise.
4911
4912 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4913
4914         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4915         code to here...
4916         (svr4_create_solib_event_breakpoints): ...from here.
4917
4918 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
4919
4920         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4921         suffix from warning message.
4922
4923 2019-08-30  Tom Tromey  <tom@tromey.com>
4924
4925         * tui/tui-winsource.h (struct tui_source_window_base)
4926         <refresh_all>: Don't declare.
4927         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4928         Remove.
4929         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4930         tui_show_locator_content.
4931         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4932         declare.
4933         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4934         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4935         declare.
4936
4937 2019-08-30  Tom Tromey  <tom@tromey.com>
4938
4939         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4940
4941 2019-08-30  Tom Tromey  <tom@tromey.com>
4942
4943         * tui/tui-stack.c (_initialize_tui_stack): Move later.
4944         Remove unnecessary forward declarations.
4945
4946 2019-08-30  Tom Tromey  <tom@tromey.com>
4947
4948         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4949         rerender.
4950         (tui_update_locator_fullname, tui_show_frame_info): Don't call
4951         tui_show_locator_content.
4952
4953 2019-08-30  Tom Tromey  <tom@tromey.com>
4954
4955         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
4956         (tui_locator_window::rerender): Rewrite using body of previous
4957         tui_show_locator_content.
4958
4959 2019-08-30  Tom Tromey  <tom@tromey.com>
4960
4961         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4962         set_locator_fullname>: New methods.
4963         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4964         Rename from tui_set_locator_fullname.
4965         (tui_locator_window::set_locator_info): Rename from
4966         tui_set_locator_info.  Return bool.
4967         (tui_update_locator_fullname, tui_show_frame_info): Update.
4968
4969 2019-08-30  Tom Tromey  <tom@tromey.com>
4970
4971         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4972
4973 2019-08-30  Tom Tromey  <tom@tromey.com>
4974
4975         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4976         call touchwin.
4977
4978 2019-08-30  Tom Tromey  <tom@tromey.com>
4979
4980         * tui/tui-wingeneral.c (box_win): Assume win_info and
4981         win_info->handle cannot be NULL.
4982
4983 2019-08-30  Tom Tromey  <tom@tromey.com>
4984
4985         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4986         refresh_window>: Declare.
4987         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4988         resize.
4989         (tui_data_item_window::rerender): Rename from
4990         tui_display_register.
4991         (tui_data_item_window::refresh_window): New method.
4992         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4993         no-op.
4994
4995 2019-08-30  Tom Tromey  <tom@tromey.com>
4996
4997         * tui/tui-regs.h (struct tui_data_window) <regs_content,
4998         regs_column_count, current_group>: Move later.  Now private.
4999         <get_current_group>: New method.
5000         * tui/tui-regs.c (tui_reg_command): Update.
5001         * tui/tui-layout.c (tui_set_layout): Update.
5002
5003 2019-08-30  Tom Tromey  <tom@tromey.com>
5004
5005         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5006         (tui_data_window::rerender): Don't call
5007         check_and_display_highlight_if_needed.
5008         (tui_data_window::refresh_all): Remove call to
5009         erase_data_content.
5010
5011 2019-08-30  Tom Tromey  <tom@tromey.com>
5012
5013         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
5014         (tui_data_window::display_registers_from)
5015         (tui_data_window::display_reg_element_at_line)
5016         (tui_data_window::display_registers_from_line): Remove checks of
5017         "empty".
5018
5019 2019-08-30  Tom Tromey  <tom@tromey.com>
5020
5021         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
5022         Don't declare.
5023         * tui/tui-regs.c (tui_data_window::show_registers): Call
5024         rerender.
5025         (tui_data_window::rerender): Rename from display_all_data.
5026         (tui_data_window::rerender): Remove old implementation.
5027
5028 2019-08-30  Tom Tromey  <tom@tromey.com>
5029
5030         * tui/tui-regs.c (tui_data_window::display_all_data): Change
5031         text.
5032         * tui/tui-data.h (NO_DATA_STRING): Remove define.
5033
5034 2019-08-29  Bernhard Wodok  <barto@gmx.net>
5035             Sergio Durigan Junior  <sergiodj@redhat.com>
5036
5037         PR win32/24284
5038         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
5039
5040 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5041
5042         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
5043         when searching for types.
5044
5045 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5046
5047         * f-lang.c (f_language_defn): Use f_print_typedef.
5048         * f-lang.h (f_print_typedef): Declare.
5049         * f-typeprint.c (f_print_typedef): Define.
5050
5051 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
5052
5053         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5054
5055 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5056
5057         * cli/cli-utils.c (info_print_options_defs): Delete.
5058         (make_info_print_options_def_group): Delete.
5059         (extract_info_print_options): Delete.
5060         (info_print_command_completer): Delete.
5061         (info_print_args_help): Add extra parameter, and optionally
5062         include text about -n flag.
5063         * cli/cli-utils.h (struct info_print_options): Delete.
5064         (extract_info_print_options): Delete declaration.
5065         (info_print_command_completer): Delete declaration.
5066         (info_print_args_help): Add extra parameter, extend header
5067         comment.
5068         * python/python.c (gdbpy_rbreak): Pass additional parameter to
5069         search_symbols.
5070         * stack.c (struct info_print_options): New type.
5071         (info_print_options_defs): New file scoped variable.
5072         (make_info_print_options_def_group): New static function.
5073         (info_print_command_completer): New static function.
5074         (info_locals_command): Update to use new local functions.
5075         (info_args_command): Likewise.
5076         (_initialize_stack): Add extra parameter to calls to
5077         info_print_args_help.
5078         * symtab.c (search_symbols): Add extra parameter, use this to
5079         possibly excluse non-debug symbols.
5080         (symtab_symbol_info): Add extra parameter, which is passed on to
5081         search_symbols.
5082         (struct info_print_options): New type.
5083         (info_print_options_defs): New file scoped variable.
5084         (make_info_print_options_def_group): New static function.
5085         (info_print_command_completer): New static function.
5086         (info_variables_command): Update to use local functions, and pass
5087         extra parameter through to symtab_symbol_info.
5088         (info_functions_command): Likewise.
5089         (info_types_command): Pass additional argument through to
5090         symtab_symbol_info.
5091         (rbreak_command): Pass extra argument to search_symbols.
5092         (_initialize_symtab): Add extra arguments for calls to
5093         info_print_args_help, and update help text for 'info variables',
5094         'whereis', and 'info functions' commands.
5095         * symtab.h (search_symbols): Add extra argument to declaration.
5096         * NEWS: Mention new flags.
5097
5098 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
5099
5100         * symtab.c (lookup_static_symbol): Call the new function (and move
5101         it down to be next to lookup_global_symbol).
5102         (struct global_sym_lookup_data): Add block_enum member and rename to...
5103         (struct global_or_static_sym_lookup_data): ...this.
5104         (lookup_symbol_global_iterator_cb): Pass block_index instead of
5105         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5106         (lookup_symbol_global_or_static_iterator_cb): ...this.
5107         (lookup_global_or_static_symbol): New function.
5108         (lookup_global_symbol): Call new function.
5109
5110 2019-08-26  Tom de Vries  <tdevries@suse.de>
5111
5112         PR c++/24852
5113         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5114         when pc_probe.prob == NULL.
5115
5116 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5117
5118         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5119         variable symbol_linkage to symbol_linkage_.
5120
5121 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5122
5123         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5124         represent whether the symbol is static, dynamic, or we don't
5125         know.
5126
5127 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
5128
5129         * gdb/rx-tdep.c (rx_register_names): New.
5130         (rx_register_name): Delete.
5131         (rx_psw_type): Delete.
5132         (rx_fpsw_type): Delete.
5133         (rx_register_type): Delete.
5134         (rx_gdbarch_init): Convert target-descriptions.
5135         (_initialize_rx_tdep): Add initialize_tdesc_rx.
5136         * gdb/features/Makefile: Add rx.xml.
5137         * gdb/features/rx.xml: New.
5138         * gdb/features/rx.c: Generated.
5139         * gdb/NEWS: Mention target description support.
5140
5141 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5142
5143         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5144         *slot_ptr.
5145
5146 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5147
5148         * configure.ac: Don't check for 'dlfcn.h' (moved to
5149         gdbsupport/common.m4).
5150         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5151         'gdbsupport/'.
5152         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5153         * compile/compile-c-support.c: Include
5154         'gdbsupport/gdb-dlfcn.h'.
5155         * gdbsupport/common.m4: Check for 'dlfcn.h'.
5156         * gdb-dlfcn.c: Move to...
5157         * gdbsupport/gdb-dlfcn.c: ... here.
5158         * gdb-dlfcn.h: Move to...
5159         * gdbsupport/gdb-dlfcn.h: ... here.
5160
5161 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
5162
5163         * nios2-tdep.c (struct reg_value): Improve comments.  Make
5164         the offset field signed.
5165
5166 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5167
5168         * python/lib/gdb/__init__.py (_execute_file): New function.
5169         * python/python.c (python_run_simple_file): Call gdb._execute_file
5170         on Windows.
5171
5172 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5173
5174         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5175         all uses as this was never set to anything but a zero value.
5176
5177 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
5178
5179         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5180
5181 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
5182
5183         * tui/tui-data.h (tui_gen_win_info): Add an =default
5184         move constructor, required by some GCC versions.
5185
5186 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
5187
5188         * go32-nat.c (go32_sysinfo): Add hygon_p.
5189
5190 2019-08-20  Tom Tromey  <tom@tromey.com>
5191
5192         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5193         line_from_reg_element_no, first_reg_element_no_inline,
5194         display_all_data, delete_data_content_windows,
5195         erase_data_content>: Now private.
5196
5197 2019-08-20  Tom Tromey  <tom@tromey.com>
5198
5199         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5200         (tui_unhighlight_win, tui_highlight_win)
5201         (tui_win_info::make_window): Update.
5202         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5203
5204 2019-08-20  Tom Tromey  <tom@tromey.com>
5205
5206         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5207         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5208         (MAX_PID_WIDTH): Move to tui-stack.c.
5209         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5210         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5211         (MAX_PID_WIDTH): Move from tui-data.h.
5212
5213 2019-08-20  Tom Tromey  <tom@tromey.com>
5214
5215         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5216         * tui/tui-wingeneral.c (box_win): Change type of win_info.
5217         (box_win): Update.
5218         (tui_gen_win_info::make_window): Rename from tui_make_window.
5219         (tui_win_info::make_window): New method.
5220         (tui_gen_win_info::make_visible): Update.
5221         * tui/tui-source.c (tui_source_window::set_contents): Update.
5222         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5223         (tui_data_window::display_registers_from): Update.
5224         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5225         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5226         Declare.
5227         <can_box>: Remove.
5228         <title>: Remove.
5229         (struct tui_win_info) <make_window>: Declare.
5230         <can_box>: Now virtual.
5231         <title>: New member.
5232         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5233         * tui/tui-command.c (tui_cmd_window::resize): Update.
5234
5235 2019-08-20  Tom Tromey  <tom@tromey.com>
5236
5237         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5238         * tui/tui-regs.c (tui_data_window::show_registers): Update.
5239         (tui_data_window::check_register_values): Update.
5240
5241 2019-08-20  Tom Tromey  <tom@tromey.com>
5242
5243         * tui/tui-regs.h (struct tui_data_window): Use
5244         DISABLE_COPY_AND_ASSIGN.
5245         <regs_content>: Change type, removing unique_ptr.
5246         <tui_data_window>: Add move constructor.
5247         * tui/tui-regs.c (tui_data_window::show_registers)
5248         (tui_data_window::show_register_group)
5249         (tui_data_window::display_registers_from)
5250         (tui_data_window::display_registers_from)
5251         (tui_data_window::first_data_item_displayed)
5252         (tui_data_window::delete_data_content_windows)
5253         (tui_data_window::rerender, tui_data_window::refresh_window)
5254         (tui_data_window::check_register_values): Update.
5255
5256 2019-08-20  Tom Tromey  <tom@tromey.com>
5257
5258         * tui/tui-regs.h (struct tui_data_window) <show_registers,
5259         show_register_group>: Declare.
5260         (tui_show_register_group): Don't declare.
5261         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5262         tui_show_registers.
5263         (tui_data_window::show_register_group): Rename from
5264         tui_show_register_group.
5265         (tui_data_window::check_register_values, tui_reg_command):
5266         Update.
5267         * tui/tui-layout.c (tui_set_layout): Update.
5268
5269 2019-08-20  Tom Tromey  <tom@tromey.com>
5270
5271         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5272         Declare.
5273         (tui_check_register_values): Don't declare.
5274         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5275         from tui_check_register_values.
5276         * tui/tui-hooks.c (tui_register_changed): Update.
5277
5278 2019-08-20  Tom Tromey  <tom@tromey.com>
5279
5280         * tui/tui-regs.c (tui_reg_layout): Move later.
5281         (tui_show_registers): Don't enable TUI mode or change layout.
5282
5283 2019-08-20  Tom Tromey  <tom@tromey.com>
5284
5285         * tui/tui-regs.h (struct tui_data_item_window)
5286         <~tui_data_item_window>: Remove.
5287         <content>: Now a unique_xmalloc_ptr.
5288         * tui/tui-regs.c (tui_register_format): Return a
5289         unique_xmalloc_ptr.
5290         (tui_get_register): Update.
5291         (~tui_data_item_window): Remove.
5292         (tui_data_window::display_registers_from, tui_display_register):
5293         Update.
5294         * tui/tui-io.h (tui_expand_tabs): Update.
5295         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5296         Remove "col" parameter.
5297
5298 2019-08-20  Tom Tromey  <tom@tromey.com>
5299
5300         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5301         field.
5302         * tui/tui-regs.c (~tui_data_item_window): Update.
5303
5304 2019-08-20  Tom Tromey  <tom@tromey.com>
5305
5306         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5307         earlier.
5308
5309 2019-08-20  Tom Tromey  <tom@tromey.com>
5310
5311         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5312
5313 2019-08-20  Tom Tromey  <tom@tromey.com>
5314
5315         * tui/tui-source.h (struct tui_source_window): Update.
5316         * tui/tui-regs.c (tui_show_registers): Update.
5317         * tui/tui-disasm.h (struct tui_disasm_window): Update.
5318         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5319         (NO_REGS_STRING): Remove defines.
5320
5321 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
5322
5323         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5324         unnecessary thread walk if remote doesn't support the packet.
5325
5326 2019-08-19  Tom Tromey  <tromey@adacore.com>
5327
5328         * python/py-value.c (value_has_field): Fix indentation.
5329
5330 2019-08-19  Tom Tromey  <tromey@adacore.com>
5331
5332         * printcmd.c (do_one_display, info_display_command): Update.
5333         * block.h (contained_in): Return bool.  Add allow_nested
5334         parameter.
5335         * block.c (contained_in): Return bool.  Add allow_nested
5336         parameter.
5337
5338 2019-08-19  Tom Tromey  <tom@tromey.com>
5339
5340         * configure: Rebuild.
5341         * configure.ac: Disallow the combination of -static-libstdc++ and
5342         source highlight.
5343         * source-cache.c (get_language_name): Handle rust.
5344         (source_cache::get_source_lines): Ignore highlighting exceptions.
5345
5346 2019-08-16  Tom Tromey  <tom@tromey.com>
5347
5348         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5349         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5350         (struct tui_source_window_base) <make_visible, refresh_window,
5351         resize>: Remove methods.
5352         <execution_info>: Remove field.
5353         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5354         (tui_show_source_line, tui_source_window_base)
5355         (~tui_source_window_base): Update.
5356         (tui_source_window_base::resize)
5357         (tui_source_window_base::make_visible)
5358         (tui_source_window_base::refresh_window): Remove.
5359         (tui_source_window_base::update_exec_info): Update.
5360         * tui/tui-source.c (tui_source_window::set_contents): Update.
5361         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5362
5363 2019-08-16  Tom Tromey  <tom@tromey.com>
5364
5365         * tui/tui-hooks.c (tui_remove_hooks): Don't set
5366         deprecated_query_hook.
5367
5368 2019-08-16  Tom Tromey  <tom@tromey.com>
5369
5370         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5371         (tui_update_source_windows_with_line): Update.
5372         * tui/tui-source.h (struct tui_source_window)
5373         <show_symtab_source>: Declare.
5374         (tui_show_symtab_source): Don't declare.
5375         * tui/tui-source.c (tui_show_symtab_source): Rename from
5376         tui_show_symtab_source.
5377
5378 2019-08-16  Tom Tromey  <tom@tromey.com>
5379
5380         * tui/tui-winsource.h (struct tui_source_window_base)
5381         <set_contents>: Declare.
5382         * tui/tui-winsource.c
5383         (tui_source_window_base::update_source_window_as_is): Update.
5384         * tui/tui-source.h (struct tui_source_window) <set_contents>:
5385         Declare.
5386         (tui_set_source_content): Don't declare.
5387         * tui/tui-source.c (tui_source_window::set_contents): Rename from
5388         tui_set_source_content.
5389         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5390         Declare.
5391         (tui_set_disassem_content): Don't declare.
5392         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5393         tui_set_disassem_content.
5394
5395 2019-08-16  Tom Tromey  <tom@tromey.com>
5396
5397         * tui/tui-winsource.h (struct tui_source_window_base)
5398         <update_breakpoint_info>: Declare.
5399         (tui_update_breakpoint_info): Don't declare.
5400         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5401         (tui_update_all_breakpoint_info): Update.
5402         (tui_source_window_base::update_breakpoint_info): Rename from
5403         tui_update_breakpoint_info.
5404         (tui_source_window_base::update_exec_info): Update.
5405
5406 2019-08-16  Tom Tromey  <tom@tromey.com>
5407
5408         * tui/tui-winsource.h (struct tui_source_window_base)
5409         <update_source_window>: Declare.
5410         (tui_update_source_window): Don't declare.
5411         * tui/tui-winsource.c
5412         (tui_source_window_base::update_source_window): Rename from
5413         tui_update_source_window.
5414         (tui_source_window_base::rerender): Update.
5415         * tui/tui-source.c (tui_source_window::maybe_update): Update.
5416         * tui/tui-disasm.c (tui_show_disassem)
5417         (tui_show_disassem_and_update_source)
5418         (tui_disasm_window::maybe_update): Update.
5419
5420 2019-08-16  Tom Tromey  <tom@tromey.com>
5421
5422         * tui/tui-winsource.h (struct tui_source_window_base)
5423         <update_source_window_as_is>: Declare.
5424         (tui_update_source_window_as_is): Don't declare.
5425         * tui/tui-winsource.c (tui_update_source_window): Update
5426         (tui_source_window_base::update_source_window_as_is): Rename from
5427         tui_update_source_window_as_is.
5428         (tui_source_window_base::refill): Update.
5429         * tui/tui-source.c (tui_show_symtab_source): Update.
5430         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5431         Update.
5432
5433 2019-08-16  Tom Tromey  <tom@tromey.com>
5434
5435         * tui/tui-winsource.h (tui_update_source_window)
5436         (tui_update_source_window_as_is): Remove "noerror" parameter.
5437         * tui/tui-winsource.c (tui_update_source_window)
5438         (tui_update_source_window_as_is): Remove "noerror" parameter.
5439         (tui_update_source_windows_with_addr)
5440         (tui_update_source_windows_with_line)
5441         (tui_source_window_base::rerender)
5442         (tui_source_window_base::refill): Update.
5443         * tui/tui-source.h (tui_set_source_content)
5444         (tui_show_symtab_source): Remove "noerror" parameter.
5445         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5446         parameter.
5447         (tui_show_symtab_source): Likewise.
5448         (tui_source_window::maybe_update): Update.
5449         * tui/tui-disasm.c (tui_show_disassem)
5450         (tui_show_disassem_and_update_source)
5451         (tui_disasm_window::do_scroll_vertical)
5452         (tui_disasm_window::maybe_update): Update.
5453
5454 2019-08-16  Tom Tromey  <tom@tromey.com>
5455
5456         * tui/tui.c (tui_is_window_visible): Update.
5457         * tui/tui-wingeneral.c (tui_make_window)
5458         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5459         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5460         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5461         (tui_set_win_height_command, parse_scrolling_args): Update.
5462         * tui/tui-source.c (tui_source_window::style_changed): Update.
5463         * tui/tui-regs.c (tui_show_registers)
5464         (tui_data_window::first_data_item_displayed)
5465         (tui_data_window::delete_data_content_windows)
5466         (tui_check_register_values, tui_reg_command): Update.
5467         * tui/tui-disasm.c (tui_show_disassem): Update.
5468         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5469         method.
5470         <is_visible>: Remove field.
5471         * tui/tui-data.c (tui_next_win, tui_prev_win)
5472         (tui_delete_invisible_windows): Update.
5473
5474 2019-08-16  Tom Tromey  <tom@tromey.com>
5475
5476         * tui/tui-winsource.h (struct tui_source_window_base)
5477         <m_has_locator>: Remove.
5478         * tui/tui-layout.c (show_source_disasm_command, show_data)
5479         (show_source_or_disasm_and_command): Update.
5480
5481 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
5482
5483         * NEWS (Other MI changes): New subsection.
5484         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5485         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5486         * arch-utils.c (default_get_pc_address_flags): New function.
5487         * arch-utils.h (default_get_pc_address_flags): New declaration.
5488         * gdbarch.sh: Add get_pc_address_flags.
5489         * gdbarch.c: Regenerate.
5490         * gdbarch.h: Likewise.
5491         * stack.c (print_pc): New function.
5492         (print_frame_info) (print_frame): Call print_pc.
5493
5494 2019-08-16  Tom de Vries  <tdevries@suse.de>
5495
5496         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5497         print_objfile_section_info.
5498
5499 2019-08-15  Tom Tromey  <tom@tromey.com>
5500
5501         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5502         calling update_cmdwin_start_line.
5503         * tui/tui-winsource.h (struct tui_source_window_base)
5504         <do_make_visible_with_new_height, set_new_height>: Don't declare.
5505         <rerender>: Declare.
5506         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5507         Call rerender.
5508         (tui_source_window_base::set_new_height): Remove.
5509         (tui_source_window_base::rerender): Rename from
5510         do_make_visible_with_new_height.
5511         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5512         resize method.
5513         (tui_win_info::make_invisible_and_set_new_height)
5514         (tui_win_info::make_visible_with_new_height): Remove.
5515         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5516         Declare.
5517         * tui/tui-stack.c (tui_locator_window::rerender): New method.
5518         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5519         do_make_visible_with_new_height>: Don't declare.
5520         <rerender>: Declare.
5521         * tui/tui-regs.c (tui_data_window::rerender): Rename from
5522         set_new_height.
5523         (tui_data_window::do_make_visible_with_new_height): Remove.
5524         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5525         call tui_show_locator_content.
5526         (tui_gen_win_info::resize): Call rerender.
5527         (show_source_or_disasm_and_command): Don't call
5528         tui_show_locator_content.
5529         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5530         method.
5531         (struct tui_win_info) <rerender>: Declare.
5532         <set_new_height, make_invisible_and_set_new_height,
5533         make_visible_with_new_height>: Don't declare.
5534         * tui/tui-data.c (tui_win_list::rerender): New method.
5535         * tui/tui-command.h (struct tui_cmd_window)
5536         <do_make_visible_with_new_height>: Don't declare.
5537         * tui/tui-command.c
5538         (tui_cmd_window::do_make_visible_with_new_height): Remove.
5539
5540 2019-08-15  Tom Tromey  <tromey@adacore.com>
5541
5542         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5543         * ada-lang.c (ada_enum_name): Likewise.
5544
5545 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
5546
5547         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5548         leading underscore.
5549         (GdbOutputErrorFile): Likewise.
5550         (global scope): Adjust constructor calls to GdbOutput{,Error}File
5551         accordingly.
5552         (execute_unwinders): Rename to have a leading underscore.
5553         (auto_load_packages): Likewise.
5554         (global scope): Adjust call to auto_load_packages accordingly.
5555         (GdbSetPythonDirectory): Likewise.
5556         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5557         instead of execute_unwinders.
5558
5559 2019-08-15  Tom Tromey  <tom@tromey.com>
5560
5561         * tui/tui-layout.c (show_layout, show_source_disasm_command)
5562         (show_data): Don't change window visibility.
5563         (tui_gen_win_info::resize): Remove special case for command
5564         window.  Use wresize, when available.
5565         (show_source_or_disasm_and_command): Don't change window
5566         visibility.
5567         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5568         <make_visible>: New method.
5569         * tui/tui-command.c (tui_cmd_window::resize): New method.
5570
5571 2019-08-15  Tom Tromey  <tom@tromey.com>
5572
5573         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5574         (struct tui_source_windows): New.
5575         * tui/tui-winsource.c (tui_display_main): Update.
5576         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5577         (new_height_ok, parse_scrolling_args): Update.
5578         * tui/tui-layout.c (show_layout, show_data): Update.
5579         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5580         (tui_add_to_source_windows): Don't declare.
5581         * tui/tui-data.c (source_windows, tui_source_windows)
5582         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5583
5584 2019-08-15  Tom Tromey  <tom@tromey.com>
5585
5586         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5587         Rename from reset.
5588         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5589         * tui/tui-layout.c (show_source_disasm_command, show_data):
5590         Update.
5591         (tui_gen_win_info::resize): Rename.
5592         (show_source_or_disasm_and_command): Update.
5593         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5594         reset.
5595
5596 2019-08-15  Tom Tromey  <tom@tromey.com>
5597
5598         * tui/tui-stack.c (tui_initialize_static_data): Remove.
5599         * tui/tui-interp.c (tui_interp::init): Don't call
5600         tui_initialize_static_data.
5601         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5602
5603 2019-08-15  Tom Tromey  <tom@tromey.com>
5604
5605         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5606         examine tui_win_list.
5607
5608 2019-08-15  Tom Tromey  <tom@tromey.com>
5609
5610         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5611         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5612         tui_clear_source_content.
5613         (tui_clear_source_content): Remove.
5614         (tui_source_window_base::do_erase_source_content): Hoist call to
5615         content.clear().
5616         * tui/tui-stack.c (tui_show_frame_info): Don't call
5617         tui_clear_source_content.
5618
5619 2019-08-15  Tom Tromey  <tom@tromey.com>
5620
5621         * tui/tui-winsource.h (struct tui_source_window_base)
5622         <do_erase_source_content>: New method.
5623         <erase_source_content>: New method.
5624         (tui_erase_source_content): Don't declare.
5625         * tui/tui-winsource.c (tui_clear_source_content): Update.
5626         (tui_source_window_base::do_erase_source_content): Rename from
5627         tui_erase_source_content.
5628         (tui_source_window_base::show_source_content): Update.
5629         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5630         * tui/tui-source.h (struct tui_source_window)
5631         <erase_source_content>: New method.
5632         * tui/tui-disasm.h (struct tui_disasm_window)
5633         <erase_source_content>: New method.
5634
5635 2019-08-15  Tom Tromey  <tom@tromey.com>
5636
5637         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5638         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5639         constructor.
5640         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5641         * tui/tui-source.c (tui_set_source_content): Update.
5642         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5643
5644 2019-08-15  Tom Tromey  <tom@tromey.com>
5645
5646         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5647         * tui/tui-winsource.c (tui_line_is_displayed): Move to
5648         tui-source.c.
5649         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5650         Declare.
5651         * tui/tui-source.c (tui_source_window::line_is_displayed): New
5652         method.
5653         (tui_source_window::maybe_update): Update.
5654
5655 2019-08-15  Tom Tromey  <tom@tromey.com>
5656
5657         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5658         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5659         tui-disasm.c.
5660         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5661         Declare.
5662         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5663         method.
5664         (tui_disasm_window::maybe_update): Update.
5665
5666 2019-08-15  Tom Tromey  <tom@tromey.com>
5667
5668         * tui/tui-winsource.h (struct tui_source_window_base)
5669         <maybe_update>: Declare.
5670         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5671         method.
5672         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5673         Declare.
5674         * tui/tui-source.c (tui_source_window::maybe_update): New method.
5675         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5676         Declare.
5677         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5678
5679 2019-08-15  Tom Tromey  <tom@tromey.com>
5680
5681         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5682
5683 2019-08-15  Tom Tromey  <tom@tromey.com>
5684
5685         * tui/tui-wingeneral.c: Include tui-stack.h.
5686         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5687         (struct tui_locator_window): Move from tui-data.h.
5688         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5689         (tui_initialize_static_data): Move from tui-data.c.
5690         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5691         (struct tui_locator_window): Move to tui-stack.c.
5692         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5693         (tui_initialize_static_data): Move to tui-stack.c.
5694
5695 2019-08-15  Tom Tromey  <tom@tromey.com>
5696
5697         * tui/tui-layout.c (show_source_disasm_command)
5698         (show_source_or_disasm_and_command): Use make_visible method, not
5699         tui_make_window.
5700         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5701         Remove.
5702
5703 2019-08-15  Tom Tromey  <tom@tromey.com>
5704
5705         * tui/tui-wingeneral.h (tui_make_window): Update.
5706         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5707         parameter.
5708         (tui_gen_win_info::make_visible): Update.
5709         * tui/tui-regs.c (tui_data_window::display_registers_from):
5710         Update.
5711         * tui/tui-layout.c (show_source_disasm_command)
5712         (show_source_or_disasm_and_command): Update.
5713         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5714         (enum tui_box): Remove.
5715         (struct tui_win_info) <can_box>: New method.
5716         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5717         method.
5718
5719 2019-08-15  Tom de Vries  <tdevries@suse.de>
5720
5721         * linux-nat-trad.c: Include gdbarch.h.
5722
5723 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
5724
5725         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5726         register sizes.
5727
5728 2019-08-14  Tom Tromey  <tromey@adacore.com>
5729
5730         * darwin-nat.c: Include gdbarch.h.
5731         * darwin-nat-info.c: Include gdbarch.h.
5732
5733 2019-08-13  Tom Tromey  <tom@tromey.com>
5734
5735         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5736         Remove.
5737         * tui/tui-data.c (tui_initialize_static_data): Update.
5738
5739 2019-08-13  Tom Tromey  <tom@tromey.com>
5740
5741         * tui/tui-winsource.h (struct tui_exec_info_window)
5742         <~tui_exec_info_window, maybe_allocate_content, get_content,
5743         m_content>: Remove.
5744         (struct tui_source_window_base) <set_exec_info_content,
5745         show_exec_info_content>: Don't declare.
5746         * tui/tui-winsource.c
5747         (tui_exec_info_window::maybe_allocate_content): Remove.
5748         (tui_source_window_base::update_exec_info): Rename from
5749         set_exec_info_content.
5750         (tui_source_window_base::show_exec_info_content)
5751         (tui_source_window_base::update_exec_info): Remove.
5752
5753 2019-08-13  Tom Tromey  <tom@tromey.com>
5754
5755         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5756         declare.
5757         * tui/tui-winsource.c (tui_update_source_window_as_is)
5758         (tui_update_source_windows_with_addr, tui_erase_source_content):
5759         Update.
5760         (tui_clear_exec_info_content): Remove.
5761
5762 2019-08-13  Tom Tromey  <tom@tromey.com>
5763
5764         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5765         declare.
5766         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5767         call tui_erase_exec_info_content.
5768         (tui_clear_exec_info_content): Rename from
5769         tui_erase_exec_info_content.
5770         (tui_clear_exec_info_content): Delete.
5771
5772 2019-08-13  Tom Tromey  <tom@tromey.com>
5773
5774         * tui/tui-winsource.h (struct tui_source_window_base)
5775         <show_exec_info_content>: Declare.
5776         (tui_show_exec_info_content): Don't declare.
5777         * tui/tui-winsource.c
5778         (tui_source_window_base::show_exec_info_content): Rename from
5779         tui_show_exec_info_content.
5780         (tui_source_window_base::update_exec_info): Update.
5781
5782 2019-08-13  Tom Tromey  <tom@tromey.com>
5783
5784         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5785         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5786         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5787         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5788         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5789         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5790         ... here.
5791
5792 2019-08-13  Tom Tromey  <tom@tromey.com>
5793
5794         * tui/tui-winsource.h (struct tui_source_window_base)
5795         <update_exec_info>: Declare.
5796         (tui_update_exec_info): Don't declare.
5797         * tui/tui-winsource.c (tui_update_source_window_as_is)
5798         (tui_source_window_base::refresh_all)
5799         (tui_update_all_breakpoint_info): Update.
5800         (tui_source_window_base::update_exec_info): Rename from
5801         tui_update_exec_info.
5802         * tui/tui-stack.c (tui_show_frame_info): Update.
5803
5804 2019-08-13  Tom Tromey  <tom@tromey.com>
5805
5806         * tui/tui-winsource.h (struct tui_source_window_base)
5807         <set_exec_info_content>: Declare.
5808         (tui_set_exec_info_content): Don't declare.
5809         * tui/tui-winsource.c
5810         (tui_source_window_base::set_exec_info_content): Rename from
5811         tui_set_exec_info_content.
5812         (tui_update_exec_info): Update.
5813
5814 2019-08-13  Tom Tromey  <tom@tromey.com>
5815
5816         * tui/tui-winsource.h (struct tui_source_window_base)
5817         <show_source_content>: Declare.
5818         (tui_show_source_content): Don't declare.
5819         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5820         (tui_source_window_base::show_source_content): Rename from
5821         tui_show_source_content.
5822         (tui_source_window_base::refresh_all): Update.
5823         * tui/tui-layout.c (show_source_disasm_command)
5824         (show_source_or_disasm_and_command): Update.
5825
5826 2019-08-13  Tom Tromey  <tom@tromey.com>
5827
5828         * tui/tui-winsource.c (tui_erase_source_content)
5829         (tui_show_source_content, tui_source_window_base::refresh_all):
5830         Update.
5831         * tui/tui-wingeneral.h
5832         (tui_check_and_display_highlight_if_needed): Don't declare.
5833         * tui/tui-wingeneral.c
5834         (tui_win_info::check_and_display_highlight_if_needed): Rename from
5835         check_and_display_highlight_if_needed.
5836         * tui/tui-win.c (tui_rehighlight_all)
5837         (tui_win_info::make_visible_with_new_height): Update.
5838         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5839         (tui_data_window::erase_data_content)
5840         (tui_data_window::display_all_data): Update.
5841         * tui/tui-data.h (struct tui_win_info)
5842         <check_and_display_highlight_if_needed>: Declare.
5843
5844 2019-08-13  Tom Tromey  <tom@tromey.com>
5845
5846         * tui/tui-win.c (tui_resize_all): Call
5847         tui_delete_invisible_windows.
5848         * tui/tui-layout.c (show_layout): Call
5849         tui_delete_invisible_windows.
5850         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5851         * tui/tui-data.c (tui_delete_invisible_windows): New function.
5852
5853 2019-08-13  Tom Tromey  <tom@tromey.com>
5854
5855         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
5856         tui_add_win_to_layout.
5857
5858 2019-08-13  Tom Tromey  <tom@tromey.com>
5859
5860         * tui/tui-layout.h (tui_default_win_height): Don't declare.
5861         * tui/tui-layout.c (tui_default_win_height): Now static.
5862
5863 2019-08-13  Tom Tromey  <tom@tromey.com>
5864
5865         * tui/tui-layout.c (show_layout): Unify all layout cases into a
5866         single switch.
5867         (show_source_disasm_command, show_source_or_disasm_and_command):
5868         Don't check current layout.
5869
5870 2019-08-13  Tom Tromey  <tom@tromey.com>
5871
5872         * tui/tui-wingeneral.c (make_all_visible): Remove.
5873         (tui_make_all_invisible): Simplify.
5874         * tui/tui-layout.c (tui_make_all_invisible): Move from
5875         tui-wingeneral.c; simplify.
5876         (show_layout): Hoist call to tui_make_all_invisible.
5877         (show_data): Don't call tui_make_all_invisible.
5878
5879 2019-08-13  Tom Tromey  <tom@tromey.com>
5880
5881         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5882         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5883
5884 2019-08-13  Tom Tromey  <tom@tromey.com>
5885
5886         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5887         tui-data.c.
5888         (show_source_disasm_command, show_data)
5889         (show_source_or_disasm_and_command): Don't use
5890         tui_set_current_layout_to.
5891         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5892         * tui/tui-data.c (current_layout, tui_current_layout): Move to
5893         tui-layout.c.
5894         (tui_set_current_layout_to): Remove.
5895
5896 2019-08-13  Tom Tromey  <tom@tromey.com>
5897
5898         * tui/tui-layout.c (tui_set_layout): Update.
5899         * tui/tui-data.h (struct tui_layout_def): Remove.
5900         (tui_layout_def): Don't declare.
5901         * tui/tui-data.c (layout_def): Remove.
5902         (tui_layout_def): Remove.
5903
5904 2019-08-13  Tom Tromey  <tom@tromey.com>
5905
5906         * tui/tui-winsource.h (struct tui_source_window_base)
5907         <clear_detail>: No longer "override".
5908         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5909         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5910         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5911         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5912         Remove.
5913         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5914
5915 2019-08-13  Tom Tromey  <tromey@adacore.com>
5916
5917         * tracepoint.c: Don't include readline.h or history.h.
5918
5919 2019-08-12  Tom Tromey  <tom@tromey.com>
5920
5921         * configure: Rebuild.
5922         * configure.ac: Check for readline 7.
5923         * NEWS: Mention readline 7 requirement.
5924         * README: Update.
5925
5926 2019-08-12  Tom Tromey  <tom@tromey.com>
5927
5928         * mingw-hdep.c (gdb_select): Remove readline hack.
5929
5930 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5931
5932         * blockframe.c (find_pc_partial_function): Set *block to nullptr
5933         when the function fails.
5934
5935 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
5936
5937         * s390-tdep.c (s390_type_align): New function.
5938         (s390_gdbarch_init): Set it as type_align gdbarch method.
5939
5940 2019-08-09  Tom de Vries  <tdevries@suse.de>
5941
5942         PR gdb/24591
5943         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5944         pc_low with relocation offset.
5945
5946 2019-08-07  Tom Tromey  <tromey@adacore.com>
5947
5948         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5949         (print_frame_args): Update.
5950         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5951         Update.
5952         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5953         * frame.h (struct frame_arg): Add initializers.
5954         <error>: Now a unique_xmalloc_ptr.
5955
5956 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
5957
5958         * NEWS: Expand the Pointer Authentication entry.
5959         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5960         (aarch64_frame_unmask_lr): ... to this.
5961         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5962         Call aarch64_frame_unmask_lr.
5963         * frame.c (struct frame_info): Add "masked" variable.
5964         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5965         (fprint_frame): Check for masked pc.
5966         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5967         declarations.
5968         * python/py-framefilter.c (py_print_frame): Check for masked pc.
5969         * stack.c (print_frame): Check for masked pc.
5970
5971 2019-08-06  Tom Tromey  <tom@tromey.com>
5972
5973         * stabsread.c (patch_block_stabs, read_one_struct_field)
5974         (read_enum_type): Use obstack_strndup.
5975         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5976         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5977         * dwarf2read.c (guess_full_die_structure_name)
5978         (anonymous_struct_prefix): Use obstack_strndup.
5979         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5980         * c-exp.y (yylex): Use obstack_strndup.
5981         * ada-exp.y (write_object_renaming, write_ambiguous_var)
5982         (write_var_or_type): Use obstack_strndup.
5983
5984 2019-08-06  Tom Tromey  <tom@tromey.com>
5985
5986         * symfile.c (reread_symbols): Use obstack_strdup.
5987         * stabsread.c (read_type): Use obstack_strdup.
5988         * gdb_obstack.h (obstack_strdup): New overload.
5989         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5990         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5991         (dwarf2_canonicalize_name): Use obstack_strdup.
5992         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5993         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5994         Use obstack_strdup.
5995
5996 2019-08-06  Tom Tromey  <tom@tromey.com>
5997
5998         * gdb_obstack.h (obstack_strdup): Define.
5999         * gdb_obstack.c (obstack_strdup): Don't define.
6000
6001 2019-08-06  Tom Tromey  <tom@tromey.com>
6002
6003         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
6004         obstack_strdup.
6005         * typeprint.c (typedef_hash_table::find_global_typedef): Use
6006         obstack_strdup.
6007         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
6008         * stabsread.c (common_block_start): Use obstack_strdup.
6009         * objfiles.c (set_objfile_main_name, objfile): Use
6010         obstack_strdup.
6011         * namespace.c (add_using_directive): Use obstack_strdup.
6012         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
6013         * jit.c (finalize_symtab): Use obstack_strdup.
6014         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
6015         (guess_partial_die_structure_name, partial_die_info::fixup)
6016         (dwarf2_name): Use obstack_strdup.
6017         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
6018         obstack_strdup.
6019         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
6020         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6021         obstack_strdup.
6022         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
6023
6024 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6025
6026         * unittests/help-doc-selftests.c: New file.
6027         * Makefile.in: Add the new file.
6028
6029 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6030
6031         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
6032         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
6033         the full first line, except when FOR_VALUE_PREFIX.  In this case,
6034         the trailing '.' is not output, and the first character is uppercased.
6035         (print_help_for_command): Update call to print_doc_line.
6036         (print_doc_of_command): Likewise.
6037         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
6038         * cli/cli-option.c (append_indented_doc): Do not append newline.
6039         (build_help_option): Append newline after first appended_indented_doc
6040         only if a second call is done.
6041         (build_help): Append 2 new lines before each option, except the first
6042         one.
6043         * compile/compile.c (_initialize_compile): Add new lines after
6044         %OPTIONS%, when not at the end of the help.
6045         Change help doc or code
6046         producing the help doc to respect the invariants.
6047         * maint-test-options.c (_initialize_maint_test_options): Likewise.
6048         Also removed the new line after 'Options:', as all other commands
6049         do not put an empty line between 'Options:' and the first option.
6050         * printcmd.c (_initialize_printcmd): Likewise.
6051         * stack.c (_initialize_stack): Likewise.
6052         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6053         incorrectly telling COMMAND is optional.
6054         * ada-lang.c (_initialize_ada_language): Change help doc or code
6055         producing the help doc to respect the invariants.
6056         * ada-tasks.c (_initialize_ada_tasks): Likewise.
6057         * breakpoint.c (_initialize_breakpoint): Likewise.
6058         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6059         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6060         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6061         * cli/cli-style.c (cli_style_option::add_setshow_commands,
6062         _initialize_cli_style): Likewise.
6063         * corelow.c (core_target_info): Likewise.
6064         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6065         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6066         * filesystem.c (_initialize_filesystem): Likewise.
6067         * frame.c (_initialize_frame): Likewise.
6068         * gnu-nat.c (add_task_commands): Likewise.
6069         * infcall.c (_initialize_infcall): Likewise.
6070         * infcmd.c (_initialize_infcmd): Likewise.
6071         * interps.c (_initialize_interpreter): Likewise.
6072         * language.c (_initialize_language): Likewise.
6073         * linux-fork.c (_initialize_linux_fork): Likewise.
6074         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6075         * maint.c (_initialize_maint_cmds): Likewise.
6076         * memattr.c (_initialize_mem): Likewise.
6077         * printcmd.c (_initialize_printcmd): Likewise.
6078         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6079         _RegEx): Likewise.
6080         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6081         * record-btrace.c (_initialize_record_btrace): Likewise.
6082         * record-full.c (_initialize_record_full): Likewise.
6083         * record.c (_initialize_record): Likewise.
6084         * regcache-dump.c (_initialize_regcache_dump): Likewise.
6085         * regcache.c (_initialize_regcache): Likewise.
6086         * remote.c (add_packet_config_cmd, init_remote_threadtests,
6087         _initialize_remote): Likewise.
6088         * ser-tcp.c (_initialize_ser_tcp): Likewise.
6089         * serial.c (_initialize_serial): Likewise.
6090         * skip.c (_initialize_step_skip): Likewise.
6091         * source.c (_initialize_source): Likewise.
6092         * stack.c (_initialize_stack): Likewise.
6093         * symfile.c (_initialize_symfile): Likewise.
6094         * symtab.c (_initialize_symtab): Likewise.
6095         * target-descriptions.c (_initialize_target_descriptions): Likewise.
6096         * top.c (init_main): Likewise.
6097         * tracefile-tfile.c (tfile_target_info): Likewise.
6098         * tracepoint.c (_initialize_tracepoint): Likewise.
6099         * tui/tui-win.c (_initialize_tui_win): Likewise.
6100         * utils.c (add_internal_problem_command): Likewise.
6101         * valprint.c (value_print_option_defs): Likewise.
6102
6103 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
6104
6105         PR build/24886
6106         * configure.ac: Drop enable-libmcheck support.
6107         * configure, config.in: Rebuild.
6108         * libmcheck.m4: Remove.
6109         * acinclude.m4: Don't include it.
6110         * Makefile.in: Don't distribute it.
6111         * top.c (print_gdb_configuration): Don't mention it.
6112
6113 2019-08-06  Tom Tromey  <tom@tromey.com>
6114
6115         * utils.c (set_output_style): Sometimes pass stream to
6116         emit_style_escape.
6117         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6118         * record-btrace.c (btrace_insn_history): Update.
6119         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6120         method.
6121         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6122         Update initializers.
6123         <m_uiout>: New field.
6124         <m_di>: Move lower.
6125         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6126         Remove "uiout" parameter.
6127         (dump_insns): Update.
6128         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6129         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6130
6131 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
6132
6133         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6134         (error_in_psymtab_expansion): Likewise.
6135         (lookup_symbol_via_quick_fns): Likewise.
6136         (basic_lookup_transparent_type_quick): Likewise.
6137         (basic_lookup_transparent_type_1): Likewise.
6138
6139 2019-08-06  Tom Tromey  <tromey@adacore.com>
6140
6141         * source.c (last_source_error): Now bool.
6142         (print_source_lines_base): Make "noprint" bool.  Only open
6143         source file when last_source_visited changes.
6144
6145 2019-08-06  Tom Tromey  <tromey@adacore.com>
6146
6147         * annotate.c (annotate_source_line): Use g_source_cache.
6148         * source-cache.c (source_cache::get_plain_source_lines): Change
6149         parameters.  Populate m_offset_cache.
6150         (source_cache::ensure): New method.
6151         (source_cache::get_line_charpos): New method.
6152         (extract_lines): Move lower.  Change parameters.
6153         (source_cache::get_source_lines): Move lower.
6154         * source-cache.h (class source_cache): Update comment.
6155         <get_line_charpos>: New method.
6156         <get_source_lines>: Update comment.
6157         <clear>: Clear m_offset_cache.
6158         <get_plain_source_lines>: Change parameters.
6159         <ensure>: New method
6160         <m_offset_cache>: New member.
6161         * source.c (forget_cached_source_info_for_objfile): Update.
6162         (info_source_command): Use g_source_cache.
6163         (find_source_lines, open_source_file_with_line_charpos): Remove.
6164         (print_source_lines_base, search_command_helper): Use g_source_cache.
6165         * source.h (open_source_file_with_line_charpos): Don't declare.
6166         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6167         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6168         Use g_source_cache.
6169
6170 2019-08-06  Tom Tromey  <tromey@adacore.com>
6171
6172         * source-cache.c (source_cache::get_plain_source_lines):
6173         Remove "first_line" and "last_line" parameters.
6174         (source_cache::get_source_lines): Cache plain text.
6175         * source-cache.h (class source_cache)
6176         <get_plain_source_lines>: Update.
6177
6178 2019-08-06  Tom Tromey  <tromey@adacore.com>
6179
6180         * source-cache.c (extract_lines): No longer a method.
6181         Changed type of parameter.  Include final newline.
6182         (selftests::extract_lines_test): New function.
6183         (_initialize_source_cache): Likewise.
6184         * source-cache.h (class source_cache)
6185         <extract_lines>: Don't declare.
6186
6187 2019-08-06  Tom Tromey  <tromey@adacore.com>
6188
6189         * breakpoint.c (init_breakpoint_sal): Update.
6190         (breakpoint): Update.
6191         * breakpoint.h (struct breakpoint) <filter>: Now a
6192         unique_xmalloc_ptr.
6193
6194 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6195
6196         * NEWS: Mention dictionary access on blocks.
6197         * python/py-block.c (blpy_getitem): New function.
6198         (block_object_as_mapping): New struct.
6199         (block_object_type): Use new struct for tp_as_mapping field.
6200
6201 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6202
6203         * objfiles.h (objfile): Add a comment describing partial symbols.
6204
6205 2019-08-05  Tom Tromey  <tromey@adacore.com>
6206
6207         * compile/compile.c (_initialize_compile): Use _(), not N_().
6208         * thread.c (_initialize_thread): Use _(), not N_().
6209         * stack.c (_initialize_stack): Use _(), not N_().
6210         * printcmd.c (_initialize_printcmd): Use _(), not N_().
6211
6212 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
6213
6214         * dwarf2read.c (struct dw2_symtab_iterator):
6215         <want_specific_block>: Remove.
6216         <block_index>: Change type to gdb::optional.
6217         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6218         change type of BLOCK_INDEX parameter to gdb::optional.
6219         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6220         (dw2_lookup_symbol): Don't pass argument for
6221         WANT_SPECIFIC_BLOCK.
6222         (dw2_expand_symtabs_for_function): Don't pass argument for
6223         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6224         (class dw2_debug_names_iterator)
6225         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6226         parameter, change BLOCK_INDEX type to gdb::optional.
6227         <m_want_specific_block>: Remove.
6228         <m_block_index>: Change type to gdb::optional.
6229         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6230         gdb::optional.  Re-write in function of gdb::optional.
6231         (dw2_debug_names_lookup_symbol): Don't pass argument for
6232         WANT_SPECIFIC_BLOCK.
6233         (dw2_debug_names_expand_symtabs_for_function): Don't pass
6234         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6235         BLOCK_INDEX.
6236
6237 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6238
6239         * NEWS: Mention changes to "info sources" command.
6240
6241 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6242
6243         * symtab.c (filename_partial_match_opts): New struct type.
6244         (struct output_source_filename_data): New members
6245         regexp, c_regexp, partial_match.
6246         (output_source_filename): Use new members to decide to print file.
6247         (info_sources_option_defs): New variable.
6248         (make_info_sources_options_def_group, print_info_sources_header,
6249         info_sources_command_completer):
6250         New functions.
6251         (info_sources_command): Read new optional arguments.
6252         (_initialize_symtab): Update info sources help.
6253
6254 2019-08-02  Alexandre Oliva <oliva@adacore.com>
6255
6256         * ada-lang.c (exception_support_info_v0): Renamed from...
6257         (default_exception_support_info): ... this.  Create new
6258         definition for v1.
6259         (ada_has_this_exception_support): Look up catch_handlers_sym.
6260         (ada_exception_support_info_sniffer): Try v0 after default.
6261
6262 2019-08-01  Tom Tromey  <tromey@adacore.com>
6263
6264         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6265         gdbarch.h.
6266
6267 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
6268
6269         * s12z-tdep.c: Fix include path for s12z-opc.h.
6270
6271 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
6272
6273         * NEWS: Require GNU make 3.82.
6274
6275 2019-07-16  Tom Tromey  <tom@tromey.com>
6276
6277         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6278         declare.
6279
6280 2019-07-30  Tom Tromey  <tromey@adacore.com>
6281
6282         * block.c (contained_in): Remove BLOCK_FUNCTION check.
6283
6284 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
6285
6286         * printcmd.c (print_address_symbolic): Print negative offsets.
6287         (build_address_symbolic): Force signed arithmetic when computing
6288         offset.
6289
6290 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
6291
6292         PR/24474: Add a function to lookup static variables.
6293         * NEWS: Mention this new function.
6294         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6295         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6296         * python/python.c (python_GdbMethods): Add new function.
6297
6298 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
6299
6300         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6301         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6302         (objfpy_lookup_static_symbol): New function.
6303         (objfile_object_methods): Add new functions.
6304
6305 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6306
6307         * NEWS: Mention 'set|show print frame-info'.  Mention new
6308         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
6309         backtrace argument.  Mention that python frame filtering code
6310         is now consistent with what 'backtrace' command prints.
6311
6312 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6313
6314         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6315         comments.
6316         (print_frame_info_auto, print_frame_info_source_line,
6317         print_frame_info_location, print_frame_info_source_and_location,
6318         print_frame_info_location_and_address, print_frame_info_short_location):
6319         New declarations.
6320         (struct frame_print_options): New member print_frame_info.
6321         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6322         * stack.h (get_user_print_what_frame_info): New declaration.
6323         (frame_show_address): New declaration.
6324         * stack.c (print_frame_arguments_choices): New value 'presence'.
6325         (print_frame_info_auto, print_frame_info_source_line,
6326         print_frame_info_location, print_frame_info_source_and_location,
6327         print_frame_info_location_and_address, print_frame_info_short_location,
6328         print_frame_info_choices, print_frame_info_print_what): New definitions.
6329         (print_frame_args): Only print dots for args if print frame-arguments
6330         is 'presence'.
6331         (frame_print_option_defs): New element for "frame-info".
6332         (get_user_print_what_frame_info): New function.
6333         (frame_show_address): Make non static.  Move comment to stack.h.
6334         (print_frame_info_to_print_what): New function.
6335         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
6336         to decide what to print.
6337         (backtrace_command_1): Handle the new print_frame_arguments_presence
6338         value.
6339         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6340         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6341         (py_print_frame): In non-mi mode, use LOCATION as default for
6342         print_what, similarly to frame information printed directly by
6343         backtrace command. Handle frame-info user option in non MI mode.
6344
6345 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6346
6347         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6348         Add case for debugging 32-bit target on 64-bit host.  Revise
6349         comment.
6350
6351 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6352
6353         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6354         instead of find_function_entry_range_from_pc.
6355
6356 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6357
6358         * stack.c (find_frame_funname): Remove code which preferred
6359         minsym over symtab sym in "certain pathological cases".
6360
6361         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6362         parameter.  Change type of "do_demangle" to bool.
6363         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6364         Pass suitable "prefer_sym_over_minsym" flag to
6365         build_address_symbolic().  Don't output "+" for negative offsets.
6366         * printcmd.c (print_address_symbolic): Update invocation of
6367         build_address_symbolic to include a "prefer_sym_over_minsym"
6368         flag.
6369         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6370         Restrict cases in which use of minimal symbol is preferred to that
6371         of a found symbol.  Update comments.
6372
6373         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6374         for entry pc when entry pc is out of range for that FDE.
6375
6376 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
6377
6378         PR gdb/24839:
6379         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6380         type.
6381
6382 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
6383
6384         * python/py-objfile.c (add_separate_debug_file): Fix comment about
6385         this function's Python signature.
6386
6387
6388 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
6389
6390         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6391         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6392         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6393         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6394         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6395
6396
6397 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
6398
6399         * h8300-tdep.c (h8300_register_name_common): New.
6400         h8300_register_name): Use h8300_register_name_common.
6401         (h8300s_register_name): Likewise.
6402         (h8300sx_register_name): Likewise.
6403         (h8300h_register_nam): New.
6404         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6405
6406
6407 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
6408
6409         * arm-tdep.c (arm_skip_cmse_entry): New function.
6410         (arm_is_sgstubs_section): New function.
6411         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6412
6413 2019-07-22  Tom Tromey  <tom@tromey.com>
6414
6415         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6416         Don't self-assign.
6417
6418 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6419
6420         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6421         type_print.
6422
6423 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6424
6425         * symtab.c (search_symbols): Adjust msymbol matching type arrays
6426         so that GDB doesn't match any msymbols when searching in the
6427         TYPES_DOMAIN.
6428         (print_symbol_info): Print using typedef_print or type_print based
6429         on the type of the symbol.  Add updated FIXME comment moved from...
6430         (_initialize_symtab): ... move and update FIXME comment to above.
6431
6432 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6433
6434         * NEWS: Mention adding -q option to "info types".
6435         * symtab.c (struct info_types_options): New struct.
6436         (info_types_options_defs): New variable.
6437         (make_info_types_options_def_group): New function.
6438         (info_types_command): Use gdb::option framework to parse options.
6439         (info_types_command_completer): New function.
6440         (_initialize_symtab): Extend the help text on "info types" and
6441         register command completer.
6442
6443 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
6444
6445         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6446         (lookup_symbol_in_objfile): Change int to block_enum and add a
6447         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6448
6449 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
6450
6451         * MAINTAINERS (Write After Approval): Add self.
6452
6453 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6454
6455         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6456         instruction to the dummy code region.
6457
6458 2019-07-19  Tom Tromey  <tromey@adacore.com>
6459
6460         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6461         (ARGSUSED, PARAMS, __func__): Remove rules.
6462
6463 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6464
6465         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6466         * features/arm/arm-with-iwmmxt.c: Remove.
6467         * features/arm/arm-with-iwmmxt.xml: Remove.
6468         * features/arm/arm-with-m-fpa-layout.c: Remove.
6469         * features/arm/arm-with-m-fpa-layout.xml: Remove.
6470         * features/arm/arm-with-m-vfp-d16.c: Remove.
6471         * features/arm/arm-with-m-vfp-d16.xml: Remove.
6472         * features/arm/arm-with-m.c: Remove.
6473         * features/arm/arm-with-m.xml: Remove.
6474         * features/arm/arm-with-neon.c: Remove.
6475         * features/arm/arm-with-neon.xml: Remove.
6476         * features/arm/arm-with-vfpv2.c: Remove.
6477         * features/arm/arm-with-vfpv2.xml: Remove.
6478         * features/arm/arm-with-vfpv3.c: Remove.
6479         * features/arm/arm-with-vfpv3.xml: Remove.
6480
6481 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6482
6483         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6484
6485 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6486
6487         * arch/aarch32.c (aarch32_create_target_description): Create
6488         target descriptions using features.
6489         * arch/arm.c (arm_create_target_description)
6490         (arm_create_mprofile_target_description): Likewise.
6491         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6492
6493 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6494
6495         * Makefile.in: Add new files.
6496         * aarch32-tdep.c: New file.
6497         * aarch32-tdep.h: New file.
6498         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6499         Call aarch32_read_description.
6500         * arch/aarch32.c: New file.
6501         * arch/aarch32.h: New file.
6502         * arch/arm.c (arm_create_target_description)
6503         (arm_create_mprofile_target_description): New function.
6504         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6505         (arm_create_target_description)
6506         (arm_create_mprofile_target_description): New declaration.
6507         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6508         read_description functions.
6509         * arm-linux-nat.c (arm_linux_nat_target::read_description):
6510         Likewise.
6511         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6512         * arm-tdep.c (tdesc_arm_list): New variable.
6513         (arm_register_g_packet_guesses): Call create description functions.
6514         (arm_read_description) (arm_read_mprofile_description): New
6515         function.
6516         * arm-tdep.h (arm_read_description)
6517         (arm_read_mprofile_description): Add declaration.
6518         * configure.tgt: Add new files.
6519
6520 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
6521
6522         * top.c (new_ui_command): Open specified terminal just once.
6523
6524 2019-07-18  Tom Tromey  <tromey@adacore.com>
6525
6526         * symtab.c (main_name): Constify return type.
6527         * symfile.c (set_initial_language): Update.
6528         * symtab.h (main_name): Constify return type.
6529
6530 2019-07-17  Tom Tromey  <tom@tromey.com>
6531
6532         * tui/tui-winsource.c (tui_update_source_window)
6533         (tui_update_source_window_as_is)
6534         (tui_update_source_windows_with_line): Remove return.
6535         * tui/tui-disasm.c (tui_show_disassem)
6536         (tui_show_disassem_and_update_source): Remove return.
6537         * tui/tui.c (tui_reset): Remove return.
6538         * tui/tui-wingeneral.c
6539         (tui_check_and_display_highlight_if_needed): Remove return.
6540
6541 2019-07-17  Tom Tromey  <tom@tromey.com>
6542
6543         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6544
6545 2019-07-17  Tom Tromey  <tom@tromey.com>
6546
6547         * tui/tui-winsource.h (struct tui_exec_info_window)
6548         (struct tui_source_window_base): Move from tui-data.h.
6549         * tui/tui-winsource.c: Move many method definitions from
6550         elsewhere.  Remove "structuring" comments.
6551         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6552         (tui_source_window_base::refresh_window): Move to
6553         tui-winsource.c.
6554         * tui/tui-win.c (tui_source_window_base::refresh_all)
6555         (tui_source_window_base::update_tab_width)
6556         (tui_source_window_base::set_new_height)
6557         (tui_source_window_base::do_make_visible_with_new_height): Move to
6558         tui-winsource.c.
6559         * tui/tui-source.h: Update.
6560         * tui/tui-source.c (tui_source_window_base::reset): Move to
6561         tui-winsource.c.
6562         * tui/tui-disasm.h: Update.
6563         * tui/tui-data.h (struct tui_exec_info_window): Move to
6564         tui-winsource.h.
6565         (struct tui_source_window_base): Likewise.
6566         * tui/tui-data.c (tui_source_window_base::clear_detail)
6567         (tui_source_window_base, ~tui_source_window_base): Move to
6568         tui-winsource.c.
6569
6570 2019-07-17  Tom Tromey  <tom@tromey.com>
6571
6572         * tui/tui-win.c (tui_resize_all)
6573         (tui_source_window_base::update_tab_width)
6574         (tui_adjust_win_heights): Update.
6575         (tui_win_info::make_invisible_and_set_new_height): Rename from
6576         make_invisible_and_set_new_height.
6577         * tui/tui-data.h (struct tui_win_info)
6578         <make_invisible_and_set_new_height>: New method.
6579
6580 2019-07-17  Tom Tromey  <tom@tromey.com>
6581
6582         * tui/tui.c: Update.
6583         * tui/tui-source.h (struct tui_source_window): Move from
6584         tui-data.h.
6585         * tui/tui-layout.c: Update.
6586         * tui/tui-disasm.c: Update.
6587         * tui/tui-data.h (struct tui_source_window): Move to
6588         tui-source.h.
6589
6590 2019-07-17  Tom Tromey  <tom@tromey.com>
6591
6592         * tui/tui-disasm.h (struct tui_disasm_window): Move from
6593         tui-data.h.
6594         * tui/tui-data.h (struct tui_disasm_window): Move to
6595         tui-disasm.h.
6596
6597 2019-07-17  Tom Tromey  <tom@tromey.com>
6598
6599         * tui/tui-regs.h (struct tui_data_item_window): Move from
6600         tui-data.h.
6601         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6602         * tui/tui-data.h (struct tui_data_item_window): Move to
6603         tui-regs.h.
6604         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6605
6606 2019-07-17  Tom Tromey  <tom@tromey.com>
6607
6608         * tui/tui.c: Update.
6609         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6610         (tui_cmd_window::max_height): Move to tui-command.c.
6611         * tui/tui-layout.c: Update.
6612         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6613         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6614         tui-command.c.
6615         * tui/tui-command.h (struct tui_cmd_window): Move from
6616         tui-data.h.
6617         * tui/tui-command.c: Remove "structuring" comments.
6618         (tui_cmd_window::clear_detail)
6619         (tui_cmd_window::do_make_visible_with_new_height)
6620         (tui_cmd_window::max_height): Move from elsewhere.
6621
6622 2019-07-17  Tom Tromey  <tom@tromey.com>
6623
6624         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6625         Now static.
6626         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6627         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6628
6629 2019-07-17  Tom Tromey  <tom@tromey.com>
6630
6631         * tui/tui.c: Update.
6632         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6633         tui-regs.c.
6634         * tui/tui-windata.h: Remove file.
6635         * tui/tui-windata.c: Remove file.
6636         * tui/tui-win.c (tui_data_window::set_new_height)
6637         (tui_data_window::do_make_visible_with_new_height): Move to
6638         tui-regs.c.
6639         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6640         * tui/tui-regs.c: Remove "structuring" comments.
6641         (tui_data_window::first_data_item_displayed)
6642         (tui_data_window::delete_data_content_windows)
6643         (tui_data_window::erase_data_content)
6644         (tui_data_window::display_all_data)
6645         (tui_data_window::refresh_all)
6646         (tui_data_window::do_scroll_vertical)
6647         (tui_data_window::clear_detail, tui_data_window::set_new_height)
6648         (tui_data_window::do_make_visible_with_new_height)
6649         (tui_data_window::refresh_window): Move from elsewhere.
6650         (_initialize_tui_regs): Move to end of file.
6651         * tui/tui-layout.c: Update.
6652         * tui/tui-hooks.c: Update.
6653         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6654         * tui/tui-data.c (tui_data_window::clear_detail): Move to
6655         tui-regs.c.
6656         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6657
6658 2019-07-17  Tom Tromey  <tom@tromey.com>
6659
6660         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6661         seen.
6662
6663 2019-07-17  Tom Tromey  <tom@tromey.com>
6664
6665         * tui/tui-win.c (tui_source_window_base::set_new_height)
6666         (tui_source_window_base::do_make_visible_with_new_height): Use
6667         m_has_locator field directly.
6668         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6669         method.
6670         (struct tui_source_window_base) <has_locator>: Likewise.
6671
6672 2019-07-17  Tom Tromey  <tom@tromey.com>
6673
6674         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6675         Don't declare.
6676         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6677         Remove.
6678         * tui/tui-win.c (tui_source_window_base::set_new_height)
6679         (tui_source_window_base::set_new_height)
6680         (make_invisible_and_set_new_height)
6681         (tui_source_window_base::do_make_visible_with_new_height)
6682         (tui_source_window_base::do_make_visible_with_new_height):
6683         Update.
6684         * tui/tui-layout.c (show_source_disasm_command, show_data)
6685         (show_source_or_disasm_and_command): Update.
6686         * tui/tui-layout.c (show_layout): Update.
6687
6688 2019-07-17  Tom Tromey  <tom@tromey.com>
6689
6690         * tui/tui-layout.c (make_data_window): Remove.
6691         (show_data): Unify creation and re-initialization cases.
6692
6693 2019-07-17  Tom Tromey  <tom@tromey.com>
6694
6695         * tui/tui-layout.c (make_source_window, make_disasm_window):
6696         Remove.
6697         (show_data): Unify creation and re-initialization cases.
6698
6699 2019-07-17  Tom Tromey  <tom@tromey.com>
6700
6701         * tui/tui-layout.c (make_command_window): Remove.
6702         (show_source_disasm_command, show_source_or_disasm_and_command):
6703         Unify creation and re-initialization cases.
6704
6705 2019-07-17  Tom Tromey  <tom@tromey.com>
6706
6707         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6708         creation and re-initialization cases.
6709
6710 2019-07-17  Tom Tromey  <tom@tromey.com>
6711
6712         * tui/tui-regs.c (tui_get_register): Return void.
6713
6714 2019-07-17  Tom Tromey  <tom@tromey.com>
6715
6716         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6717         Simplify.
6718
6719 2019-07-17  Tom Tromey  <tom@tromey.com>
6720
6721         * tui/tui-layout.c (show_source_disasm_command): Simplify window
6722         resetting.
6723
6724 2019-07-17  Tom Tromey  <tom@tromey.com>
6725
6726         * tui/tui.h (tui_set_layout_by_name): Don't declare.
6727         * tui/tui-regs.c (tui_reg_layout): New function.
6728         (tui_show_registers, tui_reg_command): Use it.
6729         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6730         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
6731         parameters.
6732         (tui_layout_command): Remove.
6733
6734 2019-07-17  Tom Tromey  <tom@tromey.com>
6735
6736         * tui/tui-layout.h (tui/tui-layout): Return void.
6737         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
6738
6739 2019-07-17  Tom Tromey  <tom@tromey.com>
6740
6741         * tui/tui-layout.c (show_source_disasm_command, show_data):
6742         Update.
6743         (reset_locator): Remove.
6744         (show_source_or_disasm_and_command): Update.
6745
6746 2019-07-17  Tom Tromey  <tom@tromey.com>
6747
6748         * tui/tui-source.c (tui_source_window_base::reset): Remove
6749         win_type parameter.
6750         * tui/tui-layout.c (make_command_window, make_source_window)
6751         (make_disasm_window, make_data_window)
6752         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6753         (reset_locator, show_source_or_disasm_and_command): Update.
6754         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6755         win_type parameter.
6756         (struct tui_source_window_base) <reset>: Likewise.
6757
6758 2019-07-17  Tom Tromey  <tom@tromey.com>
6759
6760         * tui/tui-layout.c (show_source_disasm_command): Use
6761         reset_locator.
6762         (reset_locator): New function.
6763         (init_and_make_win): Remove.
6764         (show_source_or_disasm_and_command): Use reset_locator.
6765
6766 2019-07-17  Tom Tromey  <tom@tromey.com>
6767
6768         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6769         condition.
6770         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6771         Remove condition.
6772         * tui/tui-source.c (tui_source_window_base::reset): New method.
6773         * tui/tui-layout.c (make_command_window): Don't call
6774         init_and_make_win.
6775         (make_source_window, make_disasm_window): Don't call
6776         make_source_or_disasm_window.
6777         (make_data_window): Don't call init_and_make_win.  Change calling
6778         convention.
6779         (show_source_disasm_command, show_data): Simplify.
6780         (make_source_or_disasm_window): Remove.
6781         (show_source_or_disasm_and_command): Simplify.
6782         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6783         (struct tui_source_window_base) <reset>: Likewise.
6784         <execution_info>: Remove initializer.
6785         * tui/tui-data.c (tui_source_window_base): Initialize
6786         execution_info.
6787
6788 2019-07-17  Tom Tromey  <tom@tromey.com>
6789
6790         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6791         variable.
6792
6793 2019-07-17  Tom Tromey  <tom@tromey.com>
6794
6795         * tui/tui.c (tui_rl_other_window): Update.
6796         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6797         superclass method first.  Always iterate over regs_content.
6798         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6799         method.
6800         * tui/tui-win.c (tui_set_focus_command): Update.
6801
6802 2019-07-17  Tom Tromey  <tom@tromey.com>
6803
6804         * tui/tui-win.c (tui_set_focus_command): Rename from
6805         tui_set_focus.  Call tui_enable.
6806         (tui_set_focus_command): Remove.
6807
6808 2019-07-17  Tom Tromey  <tom@tromey.com>
6809
6810         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6811         refresh_window.
6812         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6813         touchwin.
6814         (tui_data_window::refresh_window): Call refresh_window on data
6815         items.  Always call superclass refresh_window.
6816         (tui_win_info::refresh): Remove.
6817         (tui_source_window_base::refresh_window): Update.
6818         (tui_refresh_all): Update.
6819         * tui/tui-layout.c (show_source_disasm_command): Remove call to
6820         refresh_window.
6821         (show_source_or_disasm_and_command): Likewise.
6822         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6823         (struct tui_source_window_base) <refresh>: Likewise.
6824
6825 2019-07-17  Tom Tromey  <tom@tromey.com>
6826
6827         * tui/tui-winsource.c (tui_clear_source_content)
6828         (tui_show_source_content): Update.
6829         * tui/tui-source.c (tui_source_window::showing_source_p): Check
6830         whether content is empty.
6831         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6832         Remove.
6833
6834 2019-07-17  Tom Tromey  <tom@tromey.com>
6835
6836         * tui/tui-winsource.c (tui_erase_source_content): Clear the
6837         window's contents.
6838         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6839         * tui/tui-source.c (tui_set_source_content_nil): Remove.
6840
6841 2019-07-17  Tom Tromey  <tom@tromey.com>
6842
6843         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6844         (struct tui_data_item_window): Update.
6845
6846 2019-07-17  Tom Tromey  <tom@tromey.com>
6847
6848         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6849         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6850         defines.
6851
6852 2019-07-17  Tom Tromey  <tom@tromey.com>
6853
6854         * tui/tui-winsource.h (tui_erase_source_content)
6855         (tui_clear_source_content): Remove "display_prompt" parameter.
6856         * tui/tui-winsource.c (tui_update_source_window_as_is)
6857         (tui_update_source_windows_with_addr): Update.
6858         (tui_clear_source_content): Remove "display_prompt" parameter.
6859         (tui_erase_source_content): Likewise.  Simplify.
6860         (tui_show_source_content): Update.
6861         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6862         * tui/tui-stack.c (tui_show_frame_info): Update.
6863         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6864         Remove defines.
6865
6866 2019-07-17  Tom Tromey  <tom@tromey.com>
6867
6868         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6869         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6870         parameter.
6871         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6872         parameter.
6873
6874 2019-07-17  Tom Tromey  <tom@tromey.com>
6875
6876         * tui/tui-winsource.c (tui_clear_source_content)
6877         (tui_show_source_content, tui_show_exec_info_content)
6878         (tui_clear_exec_info_content): Update.
6879         * tui/tui-stack.c (tui_show_locator_content): Update.
6880         (tui_show_frame_info): Update.
6881         * tui/tui-source.h (tui_source_window): Don't declare.
6882         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6883         from tui_source_is_displayed.
6884         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6885         Remove field.
6886         (struct tui_source_window_base) <content_in_use>: New field.  Now
6887         bool.
6888         (struct tui_source_window) <showing_source_p>: New method.
6889         (TUI_SRC_WIN): Change cast.
6890         * tui/tui-data.c (tui_initialize_static_data): Update.
6891
6892 2019-07-17  Tom Tromey  <tom@tromey.com>
6893
6894         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6895         location_matches_p.
6896         * tui/tui-source.c (tui_source_window::location_matches_p): New
6897         method.
6898         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6899         method.
6900         * tui/tui-data.h (struct tui_source_window_base)
6901         <location_matches_p>: New method.
6902         (struct tui_source_window, struct tui_disasm_window)
6903         <location_matches_p>: Likewise.
6904
6905 2019-07-17  Tom Tromey  <tom@tromey.com>
6906
6907         * tui/tui-win.c (tui_set_win_height_command): Rename from
6908         tui_set_win_height.
6909         (tui_set_win_height_command): Remove.
6910
6911 2019-07-17  Tom Tromey  <tom@tromey.com>
6912
6913         * tui/tui-source.c (tui_source_window): New constructor.  Add
6914         observer.
6915         (~tui_source_window): New destructor.
6916         (tui_source_window::style_changed): New method.
6917         * tui/tui-hooks.c (tui_redisplay_source): Remove.
6918         (tui_attach_detach_observers): Update.
6919         * tui/tui-data.h (struct tui_source_window): Make constructor not
6920         inline.  Add destructor.
6921         (struct tui_source_window) <style_changed>: New method.
6922         <m_observable>: New member.
6923
6924 2019-07-17  Tom Tromey  <tom@tromey.com>
6925
6926         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6927         * tui/tui-win.c (tui_resize_all): Fix typo.
6928
6929 2019-07-17  Tom Tromey  <tom@tromey.com>
6930
6931         * tui/tui-wingeneral.h (tui_refresh_all): Update.
6932         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6933         (tui_refresh_all): Remove "list" parameter.  Use foreach.
6934         * tui/tui-win.c (window_name_completer): Use foreach.
6935         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6936         (update_tab_width): Likewise.
6937         * tui/tui-layout.c (show_layout): Update.
6938         * tui/tui-data.h (class tui_window_iterator): New.
6939         (struct all_tui_windows): New.
6940         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6941
6942 2019-07-17  Tom Tromey  <tom@tromey.com>
6943
6944         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6945         parameter.  Don't reference globals.
6946         (tui_reg_command): Update.
6947
6948 2019-07-17  Tom Tromey  <tom@tromey.com>
6949
6950         * tui/tui-regs.c (tui_show_registers): Simplify.
6951
6952 2019-07-17  Tom Tromey  <tom@tromey.com>
6953
6954         * tui/tui-regs.c (tui_show_registers): Update.
6955         (tui_show_register_group): Add win_info parameter.
6956
6957 2019-07-17  Tom Tromey  <tom@tromey.com>
6958
6959         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6960         Rename from tui_display_reg_element_at_line.
6961         (tui_data_window::display_registers_from_line): Update.
6962         * tui/tui-data.h (struct tui_data_window)
6963         <display_reg_element_at_line>: New method.
6964
6965 2019-07-17  Tom Tromey  <tom@tromey.com>
6966
6967         * tui/tui-regs.h (tui_display_registers_from)
6968         (tui_display_registers_from_line): Don't declare.
6969         * tui/tui-windata.c (tui_data_window::display_all_data)
6970         (tui_data_window::refresh_all)
6971         (tui_data_window::do_scroll_vertical): Update.
6972         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6973         from tui_display_registers_from.
6974         (tui_display_reg_element_at_line): Update.
6975         (tui_data_window::display_registers_from_line): Rename from
6976         tui_display_registers_from_line.
6977         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6978         display_registers_from_line>: New methods.
6979
6980 2019-07-17  Tom Tromey  <tom@tromey.com>
6981
6982         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6983         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6984         from tui_erase_data_content.
6985         (tui_data_window::display_all_data)
6986         (tui_data_window::refresh_all)
6987         (tui_data_window::do_scroll_vertical): Update.
6988         * tui/tui-regs.c (tui_show_registers): Update.
6989         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6990         New method.
6991
6992 2019-07-17  Tom Tromey  <tom@tromey.com>
6993
6994         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6995         declare.
6996         * tui/tui-windata.c
6997         (tui_data_window::delete_data_content_windows): Rename from
6998         tui_delete_data_content_windows.
6999         (tui_data_window::display_all_data)
7000         (tui_data_window::do_scroll_vertical): Update.
7001         * tui/tui-data.h (struct tui_data_window)
7002         <delete_data_content_windows>: New method.
7003
7004 2019-07-17  Tom Tromey  <tom@tromey.com>
7005
7006         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
7007         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
7008
7009 2019-07-17  Tom Tromey  <tom@tromey.com>
7010
7011         * tui/tui-windata.h (tui_display_all_data): Don't declare.
7012         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
7013         from tui_display_all_data.
7014         * tui/tui-win.c
7015         (tui_data_window::do_make_visible_with_new_height): Update.
7016         * tui/tui-regs.c (tui_show_registers): Update.
7017         * tui/tui-layout.c (tui_set_layout): Update.
7018         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
7019         method.
7020
7021 2019-07-17  Tom Tromey  <tom@tromey.com>
7022
7023         * tui/tui-windata.h (tui_display_data_from): Don't declare.
7024         * tui/tui-windata.c (tui_display_data_from): Remove.
7025         (tui_data_window::refresh_all): Update.
7026
7027 2019-07-17  Tom Tromey  <tom@tromey.com>
7028
7029         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
7030         * tui/tui-windata.c (tui_display_data_from_line): Remove.
7031         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
7032         tui_display_registers_from_line.
7033         * tui/tui-regs.h (tui_display_registers_from_line): Update.
7034         * tui/tui-regs.c (tui_display_registers_from_line): Remove
7035         "force_display" parameter.
7036
7037 2019-07-17  Tom Tromey  <tom@tromey.com>
7038
7039         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
7040         declare.
7041         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
7042         Rename from tui_first_reg_element_no_inline.
7043         (tui_display_reg_element_at_line)
7044         (tui_display_registers_from_line): Update.
7045         * tui/tui-data.h (struct tui_data_window)
7046         <first_reg_element_no_inline>: New method.
7047
7048 2019-07-17  Tom Tromey  <tom@tromey.com>
7049
7050         * tui/tui-windata.c (tui_display_data_from)
7051         (tui_data_window::do_scroll_vertical): Update.
7052         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7053         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7054         Rename from tui_line_from_reg_element_no.
7055         (tui_display_registers_from_line): Update.
7056         * tui/tui-data.h (struct tui_data_window)
7057         <line_from_reg_element_no>: New method.
7058
7059 2019-07-17  Tom Tromey  <tom@tromey.com>
7060
7061         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7062         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7063         tui_last_regs_line_no.
7064         (tui_display_reg_element_at_line)
7065         (tui_display_registers_from_line): Update.
7066         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7067         method.
7068
7069 2019-07-17  Tom Tromey  <tom@tromey.com>
7070
7071         PR tui/24722:
7072         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7073         (tui_update_breakpoint_info): Add "being_deleted" parameter.
7074         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7075         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7076         (tui_update_breakpoint_info): Likewise.
7077         * tui/tui-hooks.c (tui_event_create_breakpoint)
7078         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7079         Update.
7080
7081 2019-07-17  Tom Tromey  <tom@tromey.com>
7082
7083         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7084
7085 2019-07-17  Tom Tromey  <tom@tromey.com>
7086
7087         * tui/tui-winsource.c (tui_update_source_window_as_is)
7088         (tui_update_source_windows_with_addr): Update.
7089         * tui/tui-source.h (tui_set_source_content)
7090         (tui_show_symtab_source): Add "win_info" parameter.
7091         * tui/tui-source.c (tui_set_source_content): Add "win_info"
7092         parameter.
7093         (tui_show_symtab_source): Likewise.
7094
7095 2019-07-17  Tom Tromey  <tom@tromey.com>
7096
7097         * tui/tui-wingeneral.c
7098         (tui_check_and_display_highlight_if_needed): Check can_highlight.
7099
7100 2019-07-17  Tom Tromey  <tom@tromey.com>
7101
7102         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7103         (struct tui_cmd_window) <can_scroll>: New method.
7104         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7105         method.
7106
7107 2019-07-17  Tom Tromey  <tromey@adacore.com>
7108
7109         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7110         do_field_signed>: Rename.  Change type of "value".
7111         * ui-out.c (ui_out::field_signed): Rename from field_int.
7112         Change type of "value".
7113         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
7114         type of "value".
7115         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7116         do_field_int.  Change type of "value".
7117         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7118         do_field_int.  Change type of "value".
7119         * tracepoint.c (trace_status_mi, tfind_1)
7120         (print_one_static_tracepoint_marker): Update.
7121         * thread.c (print_thread_info_1, print_selected_thread_frame):
7122         Update.
7123         * stack.c (print_frame, print_frame_info): Update.
7124         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7125         Update.
7126         * source.c (print_source_lines_base): Update.
7127         * skip.c (info_skip_command): Update.
7128         * record-btrace.c (btrace_ui_out_decode_error)
7129         (btrace_call_history_src_line): Update.
7130         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7131         Update.
7132         * progspace.c (print_program_space): Update.
7133         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7134         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7135         do_field_int.  Change type of "value".
7136         * mi/mi-out.c (mi_ui_out::do_table_begin)
7137         (mi_ui_out::do_table_header): Update.
7138         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
7139         type of "value".
7140         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7141         (mi_cmd_data_list_changed_registers, output_register)
7142         (mi_cmd_data_read_memory, mi_load_progress)
7143         (mi_cmd_trace_frame_collected): Update.
7144         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7145         Update.
7146         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7147         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7148         (mi_cmd_var_list_children, varobj_update_one): Update.
7149         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7150         (mi_cmd_stack_list_args, list_arg_or_local): Update.
7151         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7152         * inferior.c (print_inferior): Update.
7153         * gdb_bfd.c (print_one_bfd): Update.
7154         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7155         Update.
7156         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7157         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7158         do_field_int.  Change type of "value".
7159         * cli-out.c (cli_ui_out::do_field_signed): Rename from
7160         do_field_int.  Change type of "value".
7161         * breakpoint.c (watchpoint_check, print_breakpoint_location)
7162         (print_one_breakpoint_location, print_it_catch_fork)
7163         (print_one_catch_fork, print_it_catch_vfork)
7164         (print_one_catch_vfork, print_it_catch_solib)
7165         (print_it_catch_exec, print_it_ranged_breakpoint)
7166         (print_mention_watchpoint, print_mention_masked_watchpoint)
7167         (bkpt_print_it, update_static_tracepoint): Update.
7168         * break-catch-throw.c (print_it_exception_catchpoint): Update.
7169         * break-catch-syscall.c (print_it_catch_syscall): Update.
7170         * ada-tasks.c (print_ada_task_info): Update.
7171         * ada-lang.c (print_it_exception, print_mention_exception):
7172         Update.
7173
7174 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
7175
7176         PR breakpoints/24541
7177         * gdbarch.c: Regenerate.
7178         * gdbarch.h: Regenerate.
7179         * gdbarch.sh: Adjust return type and parameter types for
7180         'stap_adjust_register'.
7181         (i386_stap_adjust_register): Adjust signature and return new
7182         register name.
7183         * stap-probe.c (stap_parse_register_operand): Adjust use of
7184         'gdbarch_stap_adjust_register'.
7185
7186 2019-07-17  Tom Tromey  <tromey@adacore.com>
7187
7188         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
7189         declare VEC.
7190         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7191         std::vector.
7192         (struct s390_process_info): Add initializers.
7193         (s390_add_process): Use new.
7194         (s390_linux_nat_target::low_forget_process): Use delete.
7195         (s390_linux_nat_target::low_new_fork)
7196         (s390_linux_nat_target::stopped_by_watchpoint)
7197         (s390_linux_nat_target::low_prepare_to_resume)
7198         (s390_linux_nat_target::insert_watchpoint)
7199         (s390_linux_nat_target::insert_hw_breakpoint)
7200         (s390_linux_nat_target::remove_watchpoint)
7201         (s390_linux_nat_target::remove_hw_breakpoint): Update.
7202
7203 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7204
7205         * aarch64-fbsd-nat.c: Include regcache.h.
7206         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7207         argument.
7208         (aarch64_fbsd_nat_target::fetch_registers)
7209         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7210         variable.
7211         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7212
7213 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7214
7215         * fbsd-nat.c: Include gdbarch.h.
7216
7217 2019-07-15  Tom Tromey  <tromey@adacore.com>
7218
7219         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7220
7221 2019-07-15  Tom Tromey  <tromey@adacore.com>
7222
7223         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7224         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7225         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7226         * cli-out.c (cli_ui_out::do_field_int): New method.
7227         * ui-out.c (ui_out::field_unsigned): New method.
7228         * symfile.c (generic_load): Use field_unsigned.
7229         (print_transfer_performance): Likewise.
7230         * record-btrace.c (ui_out_field_uint): Remove.
7231         (btrace_call_history_insn_range, btrace_call_history): Use
7232         field_unsigned.
7233         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7234         field_unsigned.
7235         * ui-out.h (class ui_out) <field_unsigned>: New method.
7236         <do_field_unsigned>: Likewise.
7237
7238 2019-07-15  Tom Tromey  <tromey@adacore.com>
7239
7240         * mi/mi-main.c (list_available_thread_groups): Use field_string.
7241         * mi/mi-interp.c (mi_memory_changed): Use field_string.
7242         * target.c (flash_erase_command): Use field_string.
7243         * infrun.c (print_signal_received_reason): Use field_string.
7244         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7245         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7246         field_string.
7247         * ada-tasks.c (print_ada_task_info): Use field_string.
7248
7249 2019-07-15  Tom Tromey  <tromey@adacore.com>
7250
7251         * target.c (flash_erase_command): Use field_core_addr.
7252         * symfile.c (generic_load): Use field_core_addr.
7253         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7254         Use field_core_addr.
7255         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7256         field_core_addr.
7257
7258 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7259
7260         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7261         value if its desired type is smaller than a CORE_ADDR and signed.
7262
7263 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7264
7265         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7266         of changes to field names, and use new is_reference field to
7267         decide if a property is a reference or not.
7268         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7269         field.
7270         (struct dwarf2_property_baton): Update header comment, rename
7271         'referenced_type' to 'property_type' and update comments.
7272         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7273         default property type, store in property baton, update to take
7274         accound of renamed field.
7275         (read_func_scope): Update call to attr_to_dynamic_prop.
7276         (read_array_type): Likewise.
7277         (dwarf2_per_cu_addr_sized_int_type): New function.
7278         (read_subrange_index_type): Move type finding code to
7279         dwarf2_per_cu_addr_sized_int_type.
7280         (read_subrange_type): Update calls to attr_to_dynamic_prop.
7281         (dwarf2_per_cu_addr_type): New function.
7282         (set_die_type): Update calls to attr_to_dynamic_prop.
7283
7284 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7285
7286         * dwarf2read.c (read_subrange_index_type): New function.
7287         (read_subrange_type): Move code into new function and call it.
7288         * gdbtypes.c (create_range_type): Add some asserts.
7289
7290 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7291
7292         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7293         update return statements.
7294         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7295         declaration, and update comment to match.
7296         * gdbtypes.c (resolve_dynamic_array): Update call to
7297         dwarf2_evaluate_property to match new return type.
7298
7299 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7300
7301         * valarith.c (value_subscripted_rvalue): Change lowerbound
7302         parameter type from int to LONGEST.
7303         * value.h (value_subscripted_rvalue): Likewise in declaration.
7304
7305 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7306
7307         * cli/cli-utils.c (info_print_command_completer): New function.
7308         * cli/cli-utils.h: Add 'completer.h' include, and forward
7309         declaration for 'struct cmd_list_element'.
7310         (info_print_command_completer): Declare.
7311         * stack.c (_initialize_stack): Add completer for 'info locals' and
7312         'info args'.
7313         * symtab.c (_initialize_symtab): Add completer for 'info
7314         variables' and 'info functions'.
7315         * NEWS: Mention completion for additional info commands.
7316
7317 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7318
7319         * cli/cli-utils.c (extract_info_print_args): Delete.
7320         (extract_arg_maybe_quoted): Delete.
7321         (info_print_options_defs): New variable.
7322         (make_info_print_options_def_group): New function.
7323         (extract_info_print_options): Define new function.
7324         * cli/cli-utils.h (extract_info_print_args): Delete.
7325         (struct info_print_options): New structure.
7326         (extract_info_print_options): Declare new function.
7327         * stack.c (info_locals_command): Update to use new
7328         extract_info_print_options, also add a header comment.
7329         (info_args_command): Likewise.
7330         * symtab.c (info_variables_command): Likewise.
7331         (info_functions_command): Likewise.
7332
7333 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7334
7335         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7336         to extract string arguments.
7337         * common/common-utils.c (extract_string_maybe_quoted): New function.
7338         * common/common-utils.h (extract_string_maybe_quoted): Declare.
7339
7340 2019-07-11  Tom Tromey  <tromey@adacore.com>
7341
7342         * main.c (get_init_files): Use GDBINIT, not gdbinit.
7343         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7344         * top.h (gdbinit): Don't declare.
7345         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7346         into...
7347         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
7348         * top.c (gdb_init): Don't call init_cli_cmds.
7349         (gdbinit): Remove.
7350         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7351
7352 2019-07-11  Tom Tromey  <tromey@adacore.com>
7353
7354         * python/py-inferior.c (add_thread_object): Don't use thread_obj
7355         after it has been moved.
7356
7357 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7358
7359         * valops.c (value_must_coerce_to_target): Change return type to
7360         bool.
7361         * value.h (value_must_coerce_to_target): Likewise.
7362
7363 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
7364
7365         * breakpoint.c (is_hardware_watchpoint): Remove
7366         forward-declaration.
7367         (is_masked_watchpoint): Change return type to bool.
7368         (is_tracepoint): Likewise.
7369         (is_breakpoint): Likewise.
7370         (is_hardware_watchpoint): Likewise.
7371         (is_watchpoint): Likewise.
7372         (is_no_memory_software_watchpoint): Likewise.
7373         (is_catchpoint): Likewise.
7374         (breakpoint_1): Make FILTER parameter's return type bool.
7375         is_masked_watchpoint): Change return type to bool.
7376         (save_breakpoints): Make FILTER parameter's return type bool.
7377         * breakpoint.h (is_breakpoint): Change return type to bool.
7378         (is_watchpoint): Likewise.
7379         (is_catchpoint): Likewise.
7380         (is_tracepoint): Likewise.
7381
7382 2019-07-10  Tom Tromey  <tom@tromey.com>
7383
7384         * defs.h: Don't include gdbarch.h.
7385         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7386         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7387         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7388         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7389         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7390         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7391         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7392         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7393         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7394         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7395         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7396         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7397         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7398         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7399         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7400         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7401         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7402         record-btrace.c, record.h, regcache-dump.c, regcache.h,
7403         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7404         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7405         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7406         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7407         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7408         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7409         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7410         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7411         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7412
7413 2019-07-10  Tom Tromey  <tromey@adacore.com>
7414
7415         * ada-lang.h (is_ada_exception_catchpoint): Declare.
7416         * breakpoint.c (init_ada_exception_breakpoint): Register as
7417         bp_catchpoint.
7418         (print_one_breakpoint_location, print_one_breakpoint): Use
7419         is_ada_exception_catchpoint.
7420         * ada-lang.c (class ada_catchpoint_location): Pass
7421         bp_loc_software_breakpoint to bp_location constructor.
7422         (is_ada_exception_catchpoint): New function.
7423
7424 2019-07-10  Tom Tromey  <tromey@adacore.com>
7425
7426         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
7427         VEC.
7428         (struct arm_exidx_entry): New method operator<.
7429         (struct arm_exidx_data) <section_maps>: Change type.
7430         (arm_exidx_data_free): Remove.
7431         (arm_exidx_data_key): Change type.  Move lower.
7432         (arm_exidx_new_objfile): Update.
7433         (arm_compare_exidx_entries): Remove.
7434         (arm_find_exidx_entry, _initialize_arm_tdep)
7435
7436 2019-07-10  Tom Tromey  <tromey@adacore.com>
7437
7438         * solib-spu.c (ocl_program_data_key): Change type.
7439         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7440         Update.
7441
7442 2019-07-10  Tom Tromey  <tromey@adacore.com>
7443
7444         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
7445         (struct solib_aix_inferior_data) <library_list>: Change type.
7446         (solib_aix_inferior_data_handle): Change type.
7447         (get_solib_aix_inferior_data): Update.
7448         (solib_aix_free_library_list): Remove.
7449         (library_list_start_library): Update.
7450         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7451         return type.
7452         (solib_aix_get_library_list)
7453         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7454         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7455
7456 2019-07-10  Tom Tromey  <tromey@adacore.com>
7457
7458         * solib-dsbt.c (struct dsbt_info): Add initializers.
7459         (solib_dsbt_pspace_data): Change type.
7460         (dsbt_pspace_data_cleanup): Remove.
7461         (get_dsbt_info, _initialize_dsbt_solib): Update.
7462
7463 2019-07-10  Tom Tromey  <tromey@adacore.com>
7464
7465         * spu-tdep.c (spu_overlay_data): Change type.
7466         (spu_get_overlay_table, spu_overlay_new_objfile)
7467         (_initialize_spu_tdep): Update.
7468
7469 2019-07-10  Tom Tromey  <tromey@adacore.com>
7470
7471         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7472         destructor.
7473         (dbx_objfile_data_key): Change type and declare later.
7474         (DBX_SYMFILE_INFO): Rewrite.
7475         * dbxread.c (dbx_objfile_data_key): Change type.
7476         (dbx_symfile_init): Update.
7477         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
7478         (coffstab_build_psymtabs, elfstab_build_psymtabs)
7479         (stabsect_build_psymtabs, _initialize_dbxread): Update.
7480
7481 2019-07-10  Tom Tromey  <tromey@adacore.com>
7482
7483         * jit.c (jit_program_space_key): Change type.  Move lower.
7484         (get_jit_program_space_data): Update.
7485         (jit_program_space_data_cleanup): Remove.
7486         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7487         Update.
7488         (struct jit_program_space_data): Add initializers.
7489
7490 2019-07-10  Tom Tromey  <tromey@adacore.com>
7491
7492         * solib-darwin.c (struct darwin_info): Add initializers.
7493         (solib_darwin_pspace_data): Change type.
7494         (darwin_pspace_data_cleanup): Remove.
7495         (get_darwin_info, _initialize_darwin_solib): Update.
7496
7497 2019-07-10  Tom Tromey  <tromey@adacore.com>
7498
7499         * remote-sim.c (struct sim_inferior_data): Add initializers,
7500         constructor, and destructor.
7501         (sim_inferior_data_key): Change type.  Move lower.
7502         (check_for_duplicate_sim_descriptor): Update.
7503         (get_sim_inferior_data): Use new.  Update.
7504         (~sim_inferior_data_cleanup): Rename from
7505         sim_inferior_data_cleanup.  Simplify.
7506         (gdbsim_close_inferior, simulator_command)
7507         (sim_command_completer, _initialize_remote_sim): Update.
7508         (next_pid, INITIAL_PID): Move earlier.
7509
7510 2019-07-10  Tom Tromey  <tromey@adacore.com>
7511
7512         * python/python-internal.h (create_thread_object): Return
7513         gdbpy_ref.
7514         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7515         * python/py-inferior.c (struct threadlist_entry): Add
7516         constructor.
7517         <thread_obj>: Now a gdbpy_ref.
7518         (thread_to_thread_object): Update.
7519         (add_thread_object): Use new.
7520         (delete_thread_object): Use delete.
7521         (infpy_threads): Update.
7522         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
7523         GIL.
7524
7525 2019-07-10  Tom Tromey  <tromey@adacore.com>
7526
7527         * valops.c (value_cast): Specialize error message for Ada.
7528
7529 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7530
7531         * breakpoint.c (breakpoint_1): Update doc and parameter names.
7532
7533 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7534
7535         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7536         bpstat_should_step): Return bool, adjust comments.
7537         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7538         bpstat_should_step): Likewise.
7539
7540 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7541
7542         * features/Makefile: Use feature target descriptions for Arm.
7543         * features/arm/arm-core.c: Generate new file.
7544         * features/arm/arm-fpa.c: Likewise.
7545         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7546         * features/arm/arm-m-profile.c: Likewise.
7547         * features/arm/arm-vfpv2.c: Likewise.
7548         * features/arm/arm-vfpv3.c: Likewise.
7549         * features/arm/xscale-iwmmxt.c: Likewise.
7550         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7551
7552 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7553
7554         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7555         ptrace earlier.
7556
7557 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7558
7559         * features/aarch64-pauth.c: Regenerate.
7560
7561 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
7562
7563         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7564         bool.
7565         (bpstat_what): Use false instead of 0.
7566
7567 2019-07-09  Pedro Alves  <palves@redhat.com>
7568
7569         * break-catch-throw.c (is_exception_catchpoint): New.
7570         * breakpoint.c (print_one_breakpoint_location): New parameter
7571         'raw_loc'.  Handle it.  Use
7572         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7573         looking at the breakpoint's type.
7574         (print_one_breakpoint): If handling "maint info breakpoints", also
7575         print locations of exception catchpoints.
7576         * breakpoint.h (is_exception_catchpoint): Declare.
7577
7578 2019-07-09  Pedro Alves  <palves@redhat.com>
7579
7580         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7581         "addr" field.
7582         (allocate_location_exception_catchpoint): New.
7583         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7584         (initialize_throw_catchpoint_ops): Install
7585         allocate_location_exception_catchpoint as allocate_location
7586         method.
7587         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7588         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7589         bp_loc_other.
7590         (breakpoint_address_is_meaningful): Delete.
7591         (bl_address_is_meaningful): New.
7592         (breakpoint_locations_match): Adjust comment.
7593         (bp_location_from_bp_type): New, factored out of...
7594         (bp_location::bp_location(breakpoint *)): ... this.
7595         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7596         factored out of...
7597         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
7598         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7599         breakpoint_address_is_meaningful.
7600         (bp_locations_compare): Adjust comment.
7601         (update_global_location_list): Use bl_address_is_meaningful
7602         instead of breakpoint_address_is_meaningful.
7603         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7604         explicit.
7605         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7606         * python/py-breakpoint.c (bppy_get_location): No longer check
7607         whether location is null.
7608
7609 2019-07-09  Pedro Alves  <palves@redhat.com>
7610
7611         PR c++/15468
7612         * breakpoint.c (print_one_breakpoint_location): Remove
7613         single-location assert.
7614
7615 2019-07-09  Tom Tromey  <tom@tromey.com>
7616
7617         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7618         * configure: Rebuild.
7619         * configure.ac: Change common to gdbsupport.
7620         * gdbsupport: Rename from common.
7621         * acinclude.m4: Change common to gdbsupport.
7622         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7623         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7624         gdbsupport.
7625         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7626         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7627         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7628         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7629         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7630         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7631         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7632         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7633         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7634         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7635         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7636         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7637         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7638         coff-pe-read.c, command.h, compile/compile-c-support.c,
7639         compile/compile-c.h, compile/compile-cplus-symbols.c,
7640         compile/compile-cplus-types.c, compile/compile-cplus.h,
7641         compile/compile-loc2c.c, compile/compile.c, completer.c,
7642         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7643         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7644         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7645         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7646         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7647         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7648         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7649         features/aarch64-core.c, features/aarch64-fpu.c,
7650         features/aarch64-pauth.c, features/aarch64-sve.c,
7651         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7652         features/i386/32bit-core.c, features/i386/32bit-linux.c,
7653         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7654         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7655         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7656         features/i386/64bit-core.c, features/i386/64bit-linux.c,
7657         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7658         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7659         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7660         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7661         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7662         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7663         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7664         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7665         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7666         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7667         go32-nat.c, guile/guile.c, guile/scm-ports.c,
7668         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7669         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7670         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7671         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7672         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7673         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7674         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7675         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7676         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7677         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7678         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7679         minsyms.c, mips-linux-tdep.c, namespace.h,
7680         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7681         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7682         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7683         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7684         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7685         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7686         nat/linux-waitpid.c, nat/mips-linux-watch.c,
7687         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7688         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7689         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7690         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7691         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7692         procfs.c, producer.c, progspace.h, psymtab.h,
7693         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7694         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7695         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7696         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7697         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7698         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7699         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7700         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7701         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7702         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7703         target-memory.c, target.c, target.h, target/waitstatus.c,
7704         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7705         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7706         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7707         unittests/array-view-selftests.c,
7708         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7709         unittests/common-utils-selftests.c,
7710         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7711         unittests/format_pieces-selftests.c,
7712         unittests/function-view-selftests.c,
7713         unittests/lookup_name_info-selftests.c,
7714         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7715         unittests/mkdir-recursive-selftests.c,
7716         unittests/observable-selftests.c,
7717         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7718         unittests/parse-connection-spec-selftests.c,
7719         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7720         unittests/scoped_fd-selftests.c,
7721         unittests/scoped_mmap-selftests.c,
7722         unittests/scoped_restore-selftests.c,
7723         unittests/string_view-selftests.c, unittests/style-selftests.c,
7724         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7725         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7726         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7727         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7728         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7729         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7730
7731 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7732
7733         * linespec.c (decode_digits_list_mode): Set explicit_line to a
7734         bool value.
7735         (decode_digits_ordinary): Set explicit_line field in sal.
7736         * symtab.c (skip_prologue_sal): Don't skip prologue for a
7737         symtab_and_line that was set on an explicit line number in
7738         assembler code.  Do always update the recorded symtab and line if
7739         we do skip the prologue.
7740
7741 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7742
7743         * breakpoint.c (set_breakpoint_location_function): Remove
7744         explicit_loc parameter.
7745         (momentary_breakpoint_from_master): Update call to
7746         set_breakpoint_location_function.
7747         (add_location_to_breakpoint): Likewise.
7748
7749 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7750
7751         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7752         required features based on default bfd type when no specific bfd
7753         is present.
7754
7755 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7756
7757         * NEWS: Mention that GDB printf and eval commands can now print
7758         C-style and Ada-style convenience var strings without
7759         calling the inferior.
7760         * printcmd.c (printf_c_string): Locally print GDB internal var
7761         instead of transiting via the inferior.
7762         (printf_wide_c_string): Likewise.
7763
7764 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7765
7766         PR breakpoints/25011
7767         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7768
7769 2019-07-04  Tom Tromey  <tom@tromey.com>
7770
7771         PR tui/24724:
7772         * tui/tui-winsource.c (tui_clear_source_content): Update.
7773         (tui_source_window_base::set_is_exec_point_at): Fix comment.
7774         (tui_update_breakpoint_info): Update.
7775         (tui_set_exec_info_content): Update.
7776         * tui/tui-source.c (tui_set_source_content_nil): Update.
7777         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7778         has_break.
7779         * tui/tui-data.h (enum tui_bp_flag): New.
7780         (tui_bp_flags): New enum flags type.
7781         (struct tui_source_element) <break_mode>: Change type.  Rename
7782         from has_break.
7783         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7784         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
7785         constants.
7786         * tui/tui-winsource.h: Fix comment.
7787
7788 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7789
7790         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7791         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7792         (store_fpregs_to_thread)
7793         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7794         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7795         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7796         (IWMMXT_REGS_SIZE): Add define.
7797         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7798         (fetch_vfp_regs, store_vfp_regs)
7799         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7800         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7801
7802 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7803
7804         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7805         defines.
7806         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7807         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7808         (ARM_INT_REGISTER_SIZE): ...to this.
7809         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7810         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7811         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7812         (arm_linux_collect_gregset, supply_nwfpe_register)
7813         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7814         defines.
7815         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7816         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7817         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7818         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7819         (arm_return_in_memory, arm_store_return_value)
7820         (arm_get_longjmp_target, arm_register_g_packet_guesses)
7821         (arm_record_ld_st_multiple): Likewise.
7822         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7823         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7824
7825 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7826
7827         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7828         AARCH64_DISPLACED_MODIFIED_INSNS.
7829         * aarch64-tdep.c (struct aarch64_displaced_step_data)
7830         (aarch64_displaced_step_copy_insn): Likewise.
7831         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7832         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7833         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7834         ARM_DISPLACED_MODIFIED_INSNS.
7835         * arm-tdep.c (arm_gdbarch_init): Likewise.
7836         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7837         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7838         (struct arm_displaced_step_closure): Use
7839         ARM_DISPLACED_MODIFIED_INSNS.
7840
7841 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7842
7843         * features/Makefile: Remove unused xml files.
7844         * features/aarch64.xml: Remove.
7845         * features/i386/amd64-avx-avx512-linux.xml: Remove.
7846         * features/i386/amd64-avx-avx512.xml: Remove.
7847         * features/i386/amd64-avx-linux.xml: Remove.
7848         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7849         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7850         * features/i386/amd64-avx-mpx-linux.xml: Remove.
7851         * features/i386/amd64-avx-mpx.xml: Remove.
7852         * features/i386/amd64-avx.xml: Remove.
7853         * features/i386/amd64-linux.xml: Remove.
7854         * features/i386/amd64-mpx-linux.xml: Remove.
7855         * features/i386/amd64-mpx.xml: Remove.
7856         * features/i386/amd64.xml: Remove.
7857         * features/i386/i386-avx-avx512-linux.xml: Remove.
7858         * features/i386/i386-avx-avx512.xml: Remove.
7859         * features/i386/i386-avx-linux.xml: Remove.
7860         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7861         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7862         * features/i386/i386-avx-mpx-linux.xml: Remove.
7863         * features/i386/i386-avx-mpx.xml: Remove.
7864         * features/i386/i386-avx.xml: Remove.
7865         * features/i386/i386-linux.xml: Remove.
7866         * features/i386/i386-mmx-linux.xml: Remove.
7867         * features/i386/i386-mmx.xml: Remove.
7868         * features/i386/i386-mpx-linux.xml: Remove.
7869         * features/i386/i386-mpx.xml: Remove.
7870         * features/i386/i386.xml: Remove.
7871         * features/i386/x32-avx-avx512-linux.xml: Remove.
7872         * features/i386/x32-avx-linux.xml: Remove.
7873         * features/i386/x32-linux.xml: Remove.
7874
7875 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7876
7877         * regformats/aarch64.dat: Remove.
7878         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7879         * regformats/i386/amd64-avx-linux.dat: Remove.
7880         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7881         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7882         * regformats/i386/amd64-linux.dat: Remove.
7883         * regformats/i386/amd64-mpx-linux.dat: Remove.
7884         * regformats/i386/amd64.dat: Remove.
7885         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7886         * regformats/i386/i386-avx-linux.dat: Remove.
7887         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7888         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7889         * regformats/i386/i386-linux.dat: Remove.
7890         * regformats/i386/i386-mmx-linux.dat: Remove.
7891         * regformats/i386/i386-mpx-linux.dat: Remove.
7892         * regformats/i386/i386.dat: Remove.
7893         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7894         * regformats/i386/x32-avx-linux.dat: Remove.
7895         * regformats/i386/x32-linux.dat: Remove.
7896
7897 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7898
7899         * aarch64-tdep.c: Remove xml self tests.
7900         * amd64-linux-tdep.c: Likewise.
7901         * amd64-tdep.c: Likewise.
7902         * i386-linux-tdep.c: Likewise.
7903         * i386-tdep.c: Likewise.
7904
7905 2019-07-03  Pedro Alves  <palves@redhat.com>
7906
7907         PR cli/24732
7908         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7909         (pipe_cmd_option_defs): New.
7910         (make_pipe_cmd_options_def_group): New.
7911         (pipe_command): Use gdb::option::process_options.
7912         (pipe_command_completer): New function.
7913         (_initialize_cli_cmds): Install completer for "pipe" command.
7914
7915 2019-07-03  Pedro Alves  <palves@redhat.com>
7916
7917         * cli/cli-option.c (union option_value) <string>: New field.
7918         (struct option_def_and_value): Add ctor, move ctor, dtor and
7919         use DISABLE_COPY_AND_ASSIGN.
7920         (option_def_and_value::clear_value): New.
7921         (parse_option, save_option_value_in_ctx, get_val_type_str)
7922         (add_setshow_cmds_for_options): Handle var_string.
7923         * cli-option.h (union option_def::var_address) <string>: New
7924         field.
7925         (struct string_option_def): New.
7926         * maint-test-options.c (struct test_options_opts): Add default
7927         ctor and use DISABLE_COPY_AND_ASSIGN.
7928         <string_opt>: New field.
7929         (test_options_opts::~test_options_opts): New.
7930         (test_options_opts::dump): Also dump "-string".
7931         (test_options_option_defs): Install "string.
7932
7933 2019-07-03  Pedro Alves  <palves@redhat.com>
7934
7935         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7936         option_value with a null enumeration.
7937         (complete_options): Save the option values in the context.
7938         (save_option_value_in_ctx): New, factored out from ...
7939         (process_options): ... here.
7940         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7941         of the function.
7942         * maint-test-options.c (test_options_opts::dump): New, factored
7943         out from ...
7944         (maintenance_test_options_command_mode): ... here.
7945         (maintenance_test_options_command_completion_result): Delete.
7946         (maintenance_test_options_command_completion_text): Update
7947         comment.
7948         (maintenance_show_test_options_completion_result): Change
7949         prototype.  Just print
7950         maintenance_test_options_command_completion_text.
7951         (save_completion_result): New.
7952         (maintenance_test_options_completer_mode): Pass options context to
7953         complete_options, and then save a dump.
7954         (_initialize_maint_test_options): Use add_cmd to install "maint
7955         show test-options-completion-result".
7956
7957 2019-07-03  Pedro Alves  <palves@redhat.com>
7958
7959         * NEWS (New commands): Mention "with" and "maint with".
7960         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7961         (with_command, with_command_completer): New.
7962         (pipe_command): Adjust to new repeat_previous
7963         interface.
7964         (_initialize_cli_cmds): Install the "with" command and its "w"
7965         alias.
7966         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7967         declarations.
7968         * cli/cli-setshow.c (parse_cli_var_uinteger)
7969         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7970         argument strings for all var_types.
7971         (get_setshow_command_value_string): New, factored out from ...
7972         (do_show_command): ... this.
7973         * cli/cli-setshow.h: Include <string>.
7974         (get_setshow_command_value_string): Declare.
7975         * command.h (repeat_previous): Now returns const char *.  Adjust
7976         comment.
7977         * maint.c: Include "cli/cli-cmds.h".
7978         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7979         (_initialize_maint_cmds): Register the "maintenance with" command.
7980         * top.c (repeat_previous): Move bits from pipe_command here:
7981         Return the saved command line, if any; error out if there's no
7982         command to relaunch.
7983
7984 2019-07-03  Pedro Alves  <palves@redhat.com>
7985
7986         * NEWS (New commands): Mention "maint set/show test-settings"
7987         instead of "maint test-settings".
7988         * maint-test-settings.c (maintenance_test_settings_list): Delete.
7989         (maintenance_test_settings_set_list): Rename to ...
7990         (maintenance_set_test_settings_list): ... this.
7991         (maintenance_test_settings_show_list): Rename to  ...
7992         (maintenance_show_test_settings_list): ... this.
7993         (maintenance_test_settings_cmd): Delete.
7994         (maintenance_test_settings_set_cmd): ...
7995         (maintenance_set_test_settings_cmd): ... this.
7996         (maintenance_test_settings_show_cmd): ...
7997         (maintenance_show_test_settings_cmd): ... this.
7998         (maintenance_test_settings_show_value_cmd):
7999         (maintenance_show_test_settings_value_cmd): ... this.
8000         (_initialize_maint_test_settings): No longer install the "maint
8001         test-settings" prefix command.  Rename "maint test-settings set"
8002         to "maint set test-settings", and "maint test-settings show" to
8003         "maint show test-settings".  Adjust all subcommands.
8004
8005 2019-07-03  Pedro Alves  <palves@redhat.com>
8006
8007         * maint-test-settings.c: Fix file's intro comment.  Replace all
8008         references to "test-options" with references to "test-settings",
8009         in comments.
8010
8011 2019-07-03  Pedro Alves  <palves@redhat.com>
8012
8013         * maint-test-settings.c (maintenance_test_settings_xxx)
8014         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
8015         New.
8016         (maintenance_test_settings_enums): Use them.
8017         (maintenance_test_settings_enum): Default to
8018         maintenance_test_settings_xxx.
8019         (_initialize_maint_test_settings): Initialize
8020         MAINTENANCE_TEST_SETTINGS_FILENAME.
8021
8022 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8023
8024         * breakpoint.h (remove_breakpoints_inf): Change return type to
8025         void, move function documentation here.
8026         * breakpoint.c (remove_breakpoints_inf): Change return type to
8027         void, move function documentation to header.
8028
8029 2019-07-02  Pedro Alves  <palves@redhat.com>
8030
8031         * NEWS (Completion improvements): Mention "info threads".
8032         * thread.c (struct info_threads_opts, info_threads_option_defs)
8033         (make_info_threads_options_def_group): New.
8034         (info_threads_command): Use gdb::option::process_options.
8035         (info_threads_command_completer): New.
8036         (_initialize_thread): Use gdb::option::build_help to build the
8037         help text for "info threads".
8038
8039 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8040
8041         * defs.h (generic_load): Move from here...
8042         * symfile.h (generic_load): ... to here.  Rename name parameter
8043         to args.
8044         * symfile.c (generic_load): Add comment.
8045
8046 2019-07-01  Tom Tromey  <tromey@adacore.com>
8047
8048         * dwarf2read.c
8049         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
8050         declaration of without_params.  Fix formatting.
8051
8052 2019-07-01  Tom Tromey  <tromey@adacore.com>
8053
8054         * ada-exp.y (find_primitive_type): Update.
8055         * ada-lang.h (ada_lookup_symbol): Update.
8056         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8057         parameter.
8058         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8059
8060 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8061
8062         PR breakpoints/24541
8063         * gdbarch.c: Regenerate.
8064         * gdbarch.h: Regenerate.
8065         * gdbarch.sh: Add 'stap_adjust_register'.
8066         * i386-tdep.c: Include '<unordered_set>'.
8067         (i386_stap_adjust_register): New function.
8068         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8069         * stap-probe.c (stap_parse_register_operand): Call
8070         'gdbarch_stap_adjust_register'.
8071
8072 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8073
8074         PR python/24742
8075         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8076         * python/python.c (do_start_initialization): Use 'xmalloc'
8077         instead of 'PyMem_Malloc'.
8078
8079 2019-06-28  Tom Tromey  <tromey@adacore.com>
8080
8081         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8082         for Ada.
8083
8084 2019-06-27  Tom Tromey  <tromey@adacore.com>
8085
8086         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
8087         objfile_key.
8088         (arm_find_mapping_symbol, arm_record_special_symbol)
8089         (_initialize_arm_tdep): Update.
8090         (arm_objfile_data_free): Remove.
8091
8092 2019-06-27  Tom Tromey  <tromey@adacore.com>
8093
8094         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8095         to cp_print_static_field.
8096
8097 2019-06-26  Tom Tromey  <tromey@adacore.com>
8098
8099         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8100         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8101         declare.
8102
8103 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8104
8105         * features/aarch64-core.c (create_feature_aarch64_core):
8106         Regenerate.
8107         * features/aarch64-core.xml: Add cpsr flags.
8108
8109 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8110
8111         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8112         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8113
8114 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8115
8116         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8117         field.
8118         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8119         use.
8120         (arm_record_special_symbol): Don't insert new symbol in sorted
8121         position, push it at the end.
8122
8123 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8124
8125         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8126         (arm_mapping_symbol_s): Remove.
8127         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8128         (arm_mapping_symbol_vec): New typedef.
8129         (struct arm_per_objfile): Add constructor.
8130         <section_maps>: Change type to
8131         std::unique_ptr<arm_mapping_symbol_vec[]>.
8132         (arm_compare_mapping_symbols): Remove.
8133         (arm_find_mapping_symbol): Adjust to section_maps type change.
8134         (arm_objfile_data_free): Call delete on arm_per_objfile.
8135         (arm_record_special_symbol): Adjust to section_maps type change.
8136         Allocate arm_per_objfile with new.
8137
8138 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8139
8140         * cli/cli-cmds.c (alias_command): Compare the alias prefix
8141         with the command prefix.
8142
8143 2019-06-25  Tom Tromey  <tom@tromey.com>
8144
8145         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8146         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8147
8148 2019-06-25  Tom Tromey  <tom@tromey.com>
8149
8150         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8151         type.
8152         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8153         protected.
8154
8155 2019-06-25  Tom Tromey  <tom@tromey.com>
8156
8157         * tui/tui-winsource.c
8158         (tui_source_window_base::set_is_exec_point_at): Add check against
8159         LOA_ADDRESS.
8160
8161 2019-06-25  Tom Tromey  <tom@tromey.com>
8162
8163         * tui/tui-source.c (tui_set_source_content): Don't check before
8164         xfree.
8165         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8166
8167 2019-06-25  Tom Tromey  <tom@tromey.com>
8168
8169         * tui/tui-winsource.h (tui_update_source_window_as_is)
8170         (tui_alloc_source_buffer, tui_line_is_displayed)
8171         (tui_addr_is_displayed): Change type of win_info.
8172         * tui/tui-winsource.c (tui_update_source_window_as_is)
8173         (tui_clear_source_content, tui_show_source_line)
8174         (tui_show_source_content, tui_source_window_base::refill)
8175         (tui_source_window_base::set_is_exec_point_at)
8176         (tui_source_window_base::set_is_exec_point_at)
8177         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8178         (tui_alloc_source_buffer, tui_line_is_displayed)
8179         (tui_addr_is_displayed): Change type of win_info.  Update.
8180         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8181         (tui_source_window_base::do_make_visible_with_new_height):
8182         Update.
8183         * tui/tui-source.c (tui_set_source_content)
8184         (tui_set_source_content_nil)
8185         (tui_source_window::do_scroll_vertical): Update.
8186         * tui/tui-layout.c (show_layout): Update.
8187         * tui/tui-disasm.c (tui_set_disassem_content)
8188         (tui_disasm_window::do_scroll_vertical): Update.
8189         * tui/tui-data.h (tui_win_content): Remove.
8190         (struct tui_gen_win_info) <content, content_size>: Remove.
8191         (struct tui_source_element): Add initializers and destructor.
8192         (union tui_which_element, struct tui_win_element): Remove.
8193         (struct tui_source_window_base) <content>: New field.
8194         (struct tui_data_window): Remove destructor.
8195         (tui_alloc_content, tui_free_win_content)
8196         (tui_free_all_source_wins_content): Don't declare.
8197         * tui/tui-data.c (tui_initialize_static_data): Update.
8198         (init_content_element, tui_alloc_content): Remove.
8199         (~tui_gen_win_info): Update.
8200         (~tui_data_window, tui_free_all_source_wins_content)
8201         (tui_free_win_content, free_content, free_content_elements):
8202         Remove.
8203
8204 2019-06-25  Tom Tromey  <tom@tromey.com>
8205
8206         * tui/tui-winsource.h (tui_clear_source_content)
8207         (tui_erase_source_content, tui_show_source_content): Change type
8208         of win_info.
8209         * tui/tui-winsource.c (tui_clear_source_content)
8210         (tui_erase_source_content, tui_show_source_content): Change type
8211         of win_info.
8212         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8213         * tui/tui-source.h (tui_set_source_content_nil): Change type of
8214         win_info.
8215         * tui/tui-source.c (tui_set_source_content_nil): Change type of
8216         win_info.
8217         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8218
8219 2019-06-25  Tom Tromey  <tom@tromey.com>
8220
8221         * tui/tui-winsource.c (tui_clear_source_content)
8222         (tui_source_window_base::set_is_exec_point_at): Update.
8223         * tui/tui-source.c (tui_set_source_content_nil): Update.
8224         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8225         a bool.
8226         * tui/tui-data.c (init_content_element): Update.
8227
8228 2019-06-25  Tom Tromey  <tom@tromey.com>
8229
8230         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8231         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8232         * tui/tui-layout.c (init_and_make_win): Update.
8233         * tui/tui.h (enum tui_win_type): Update.
8234         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8235         tui_win_is_auxillary.
8236         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8237         tui_win_is_auxillary.
8238
8239 2019-06-25  Tom Tromey  <tom@tromey.com>
8240
8241         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8242         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8243         (tui_delete_data_content_windows, tui_display_all_data)
8244         (tui_data_window::do_scroll_vertical, tui_display_data_from):
8245         Update.
8246         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8247         * tui/tui-regs.c (tui_last_regs_line_no)
8248         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8249         (tui_show_registers): Update.
8250         (tui_show_register_group): Return void.  Update.
8251         (tui_display_registers_from, tui_display_reg_element_at_line)
8252         (tui_display_registers_from_line, tui_check_register_values):
8253         Update.
8254         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8255         member.
8256         (struct tui_data_window) <regs_content>: Now a std::vector.
8257         <regs_content_count>: Remove.
8258         (tui_add_content_elements, tui_free_data_content): Don't declare.
8259         * tui/tui-data.c (tui_data_window::clear_detail): Update.
8260         (init_content_element): Remove DATA_WIN case.  Add assert.
8261         (tui_add_content_elements): Remove.
8262         (tui_data_window): Update.
8263         (tui_free_data_content): Remove.
8264         (free_content_elements): Remove DATA_WIN case.
8265
8266 2019-06-25  Tom Tromey  <tom@tromey.com>
8267
8268         * tui/tui-data.c (tui_data_item_window): Update.
8269         * tui/tui-windata.h (tui_check_data_values): Don't declare.
8270         * tui/tui-windata.c (tui_display_all_data)
8271         (tui_display_data_from_line): Update.
8272         (tui_check_data_values): Remove.
8273         * tui/tui-regs.c (tui_show_register_group)
8274         (tui_display_reg_element_at_line): Update.
8275         * tui/tui-hooks.c (tui_register_changed)
8276         (tui_refresh_frame_and_register_information): Call
8277         tui_check_register_values.
8278         * tui/tui-data.h (struct tui_data_window) <data_content,
8279         data_content_count, data_type>: Remove.
8280         (enum tui_data_type): Remove.
8281
8282         * tui/tui-data.c (tui_data_window::clear_detail)
8283         (~tui_data_window): Update.
8284
8285 2019-06-25  Tom Tromey  <tom@tromey.com>
8286
8287         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8288         declare.
8289         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8290         Rename from tui_first_data_item_displayed.  Update.
8291         (tui_data_window::refresh_all)
8292         (tui_data_window::do_scroll_vertical): Update.
8293         * tui/tui-data.h (struct tui_data_window)
8294         <first_data_item_displayed>: Declare new method.
8295
8296 2019-06-25  Tom Tromey  <tom@tromey.com>
8297
8298         * tui/tui-data.h (tui_init_generic_part): Don't declare.
8299         * tui/tui-data.c (tui_init_generic_part): Remove, moving
8300         contents...
8301         (tui_initialize_static_data): ...here.
8302
8303 2019-06-25  Tom Tromey  <tom@tromey.com>
8304
8305         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8306         (tui_display_registers_from, tui_check_register_values): Update.
8307         (tui_display_register): Remove win_info parameter; update.
8308         (tui_get_register): Change type of parameters.
8309         * tui/tui-data.h (struct tui_data_element): Remove.
8310         (union tui_which_element) <data>: Remove.
8311         <data_window>: Change type.
8312         (struct tui_data_item_window): New.
8313         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8314         case.  Add assert.
8315         (~tui_data_item_window): New destructor.
8316         (free_content_elements): Remove DATA_ITEM_WIN case.
8317
8318 2019-06-25  Tom Tromey  <tom@tromey.com>
8319
8320         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8321         Remove.
8322
8323 2019-06-25  Tom Tromey  <tom@tromey.com>
8324
8325         * tui/tui-data.h (struct tui_command_element): Remove.
8326         (union tui_which_element) <command>: Remove.
8327         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
8328         assert.
8329         (free_content_elements): Remove CMD_WIN case.
8330
8331 2019-06-25  Tom Tromey  <tom@tromey.com>
8332
8333         * tui/tui-layout.c (tui_set_layout): Update.
8334         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8335         * tui/tui-data.c (layout_def): Update.
8336
8337 2019-06-25  Tom Tromey  <tom@tromey.com>
8338
8339         * tui/tui-wingeneral.c (tui_refresh_all): Update.
8340         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8341         (tui_source_window_base::set_new_height): Update.
8342         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8343         Update.
8344         (tui_set_locator_fullname, tui_set_locator_info)
8345         (tui_show_frame_info): Update.
8346         * tui/tui-source.c (tui_set_source_content)
8347         (tui_source_is_displayed): Update.
8348         * tui/tui-layout.c (show_source_disasm_command, show_data)
8349         (show_source_or_disasm_and_command): Update.
8350         * tui/tui-disasm.c (tui_set_disassem_content)
8351         (tui_get_begin_asm_address): Update.
8352         * tui/tui-data.h (struct tui_locator_element): Remove.
8353         (union tui_which_element) <locator>: Remove.
8354         (struct tui_locator_window): New.
8355         (tui_locator_win_info_ptr): Change return type.
8356         * tui/tui-data.c (_locator): Change type.
8357         (tui_locator_win_info_ptr): Change return type.
8358         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
8359         (tui_alloc_content): Add assert.
8360
8361 2019-06-25  Tom Tromey  <tom@tromey.com>
8362
8363         * tui/tui-winsource.c
8364         (tui_exec_info_window::maybe_allocate_content): New method.
8365         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8366         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8367         (make_source_or_disasm_window): Add cast.
8368         * tui/tui-data.h (union tui_which_element) <simple_string>:
8369         Remove.
8370         (struct tui_source_info): New.
8371         (struct tui_source_window_base) <execution_info>: Change type.
8372         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8373         case, and add assert.
8374         (tui_alloc_content): Add assert.
8375
8376 2019-06-25  Tom Tromey  <tom@tromey.com>
8377
8378         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8379         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8380         * tui/tui-data.c (tui_alloc_win_info): Remove.
8381
8382 2019-06-25  Tom Tromey  <tom@tromey.com>
8383
8384         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8385         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8386         can_highlight.
8387
8388 2019-06-25  Tom Tromey  <tom@tromey.com>
8389
8390         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8391         make_visible_with_new_height method.
8392         (tui_win_info::make_visible_with_new_height): New method.
8393         (tui_source_window_base::do_make_visible_with_new_height)
8394         (tui_data_window::do_make_visible_with_new_height)
8395         (tui_cmd_window::do_make_visible_with_new_height): New methods.
8396         (make_visible_with_new_height): Remove.
8397         (tui_resize_all, tui_adjust_win_heights): Use
8398         make_visible_with_new_height method.
8399         * tui/tui-data.h (struct tui_win_info)
8400         <do_make_visible_with_new_height, make_visible_with_new_height>:
8401         New methods.
8402         (struct tui_source_window_base, struct tui_data_window)
8403         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8404         methods.
8405
8406 2019-06-25  Tom Tromey  <tom@tromey.com>
8407
8408         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8409         method.
8410         (update_tab_width): Call update_tab_width method.
8411         * tui/tui-data.h (struct tui_win_info)
8412         (struct tui_source_window_base) <update_tab_width>: New methods.
8413
8414 2019-06-25  Tom Tromey  <tom@tromey.com>
8415
8416         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8417         parameter.
8418         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8419         parameter.
8420         (tui_gen_win_info::make_visible): Update.
8421         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8422         parameter.
8423         * tui/tui-data.h (enum tui_box): New enum.
8424         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8425
8426 2019-06-25  Tom Tromey  <tom@tromey.com>
8427
8428         * tui/tui-layout.c (make_source_or_disasm_window): Always use
8429         init_and_make_win for EXEC_INFO_WIN.
8430         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8431         longer inline.
8432         (struct tui_win_info) <~tui_win_info>: Inline.
8433         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8434         Don't declare.
8435         * tui/tui-data.c (source_win, disasm_win): Remove globals.
8436         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8437         Remove.
8438         (tui_initialize_static_data): Update.
8439         (~tui_gen_win_info): Handle more cleanup here.
8440         (~tui_source_window_base): Delete "execution_info".
8441         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8442
8443 2019-06-25  Tom Tromey  <tom@tromey.com>
8444
8445         * tui/tui-layout.c (make_command_window): Don't set
8446         can_highlight.
8447         (show_source_disasm_command): Call the reset method.
8448         (show_data): Don't set can_highlight.  Call the reset method.
8449         (tui_gen_win_info::reset): Rename from init_gen_win_info
8450         (init_and_make_win): Simplify.  Return tui_gen_win_info.
8451         (show_source_or_disasm_and_command): Call the reset method.
8452         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8453         (struct tui_cmd_window): Set can_highlight.
8454
8455 2019-06-25  Tom Tromey  <tom@tromey.com>
8456
8457         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8458         from make_visible.
8459         (tui_make_visible, tui_make_invisible): Rewrite.
8460         (tui_win_info::make_visible): Remove.
8461         (tui_source_window_base::make_visible): Update.
8462         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8463         method.  Moved from...
8464         (struct tui_win_info) <make_visible>: ...here.
8465
8466 2019-06-25  Tom Tromey  <tom@tromey.com>
8467
8468         * tui/tui-winsource.c
8469         (tui_source_window_base::do_scroll_horizontal): Remove direction
8470         parameter.
8471         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8472         direction parameter.
8473         * tui/tui-win.c (tui_win_info::forward_scroll)
8474         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8475         (tui_win_info::right_scroll): Update.
8476         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8477         direction parameter.
8478         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8479         direction parameter.
8480         * tui/tui-data.h (enum tui_scroll_direction): Remove.
8481         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8482         Remove direction parameter.
8483         (struct tui_source_window_base, struct tui_source_window)
8484         (struct tui_disasm_window, struct tui_data_window)
8485         (struct tui_cmd_window): Update.
8486
8487 2019-06-25  Tom Tromey  <tom@tromey.com>
8488
8489         * tui/tui-winsource.h (tui_set_exec_info_content)
8490         (tui_show_exec_info_content, tui_erase_exec_info_content)
8491         (tui_clear_exec_info_content, tui_update_exec_info): Change
8492         argument to tui_source_window_base.
8493         * tui/tui-winsource.c (tui_set_exec_info_content)
8494         (tui_show_exec_info_content, tui_erase_exec_info_content)
8495         (tui_clear_exec_info_content, tui_update_exec_info): Change
8496         argument to tui_source_window_base.
8497
8498 2019-06-25  Tom Tromey  <tom@tromey.com>
8499
8500         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8501         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8502
8503 2019-06-25  Tom Tromey  <tom@tromey.com>
8504
8505         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8506         check.
8507
8508 2019-06-25  Tom Tromey  <tom@tromey.com>
8509
8510         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8511         type to void.
8512         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8513         type to void.
8514         * tui/tui-source.c (tui_set_source_content): Update.
8515         * tui/tui-disasm.c (tui_set_disassem_content): Update.
8516
8517 2019-06-25  Tom Tromey  <tom@tromey.com>
8518
8519         * tui/tui-win.c (window_name_completer, tui_set_focus)
8520         (tui_all_windows_info): Use name method.
8521         * tui/tui-data.h (struct tui_gen_win_info)
8522         (struct tui_source_window, struct tui_disasm_window)
8523         (struct tui_data_window, struct tui_cmd_window) <name>: New
8524         method.
8525         (tui_win_name): Don't declare.
8526         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8527         (tui_win_name): Remove.
8528
8529 2019-06-25  Tom Tromey  <tom@tromey.com>
8530
8531         * tui/tui-winsource.h (tui_update_source_window)
8532         (tui_update_source_window_as_is): Change parameter type.
8533         * tui/tui-winsource.c (tui_update_source_window): Change win_info
8534         to be a tui_source_window_base.
8535         (tui_update_source_window_as_is): Likewise.
8536         * tui/tui-win.c (make_visible_with_new_height): Update.
8537
8538 2019-06-25  Tom Tromey  <tom@tromey.com>
8539
8540         * tui/tui-winsource.c (tui_erase_source_content)
8541         (tui_show_source_content, tui_show_exec_info_content)
8542         (tui_erase_exec_info_content): Use refresh_window method.
8543         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8544         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8545         from tui_refresh_win.
8546         (tui_data_window::refresh_window): New method.
8547         (tui_win_info::refresh, tui_source_window_base::refresh)
8548         (tui_refresh_all): Use refresh_window method.
8549         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8550         method.
8551         * tui/tui-regs.c (tui_display_register): Call refresh_window
8552         method.
8553         * tui/tui-layout.c (show_source_disasm_command)
8554         (show_source_or_disasm_and_command): Call refresh_window method.
8555         * tui/tui-data.h (struct tui_gen_win_info)
8556         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8557         New method.
8558
8559 2019-06-25  Tom Tromey  <tom@tromey.com>
8560
8561         * tui/tui.c (tui_rl_other_window, tui_enable)
8562         (tui_is_window_visible, tui_get_command_dimension): Update.
8563         * tui/tui-winsource.c (tui_update_source_window_as_is)
8564         (tui_clear_source_content, tui_erase_source_content)
8565         (tui_show_source_line, tui_source_window_base::refill)
8566         (tui_source_window_base::do_scroll_horizontal)
8567         (tui_source_window_base::set_is_exec_point_at)
8568         (tui_update_breakpoint_info, tui_set_exec_info_content)
8569         (tui_alloc_source_buffer, tui_line_is_displayed)
8570         (tui_addr_is_displayed): Update.
8571         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8572         (tui_check_and_display_highlight_if_needed)
8573         (tui_win_info::make_visible, tui_win_info::refresh)
8574         (tui_refresh_all): Update.
8575         * tui/tui-windata.c (tui_first_data_item_displayed)
8576         (tui_delete_data_content_windows, tui_erase_data_content)
8577         (tui_display_all_data, tui_data_window::refresh_all)
8578         (tui_check_data_values): Update.
8579         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8580         (tui_set_win_focus_to, tui_win_info::forward_scroll)
8581         (tui_win_info::backward_scroll, tui_refresh_all_win)
8582         (tui_resize_all, tui_set_focus, tui_all_windows_info)
8583         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8584         (tui_source_window_base::set_new_height)
8585         (tui_data_window::set_new_height)
8586         (make_invisible_and_set_new_height)
8587         (make_visible_with_new_height, new_height_ok)
8588         (parse_scrolling_args): Update.
8589         * tui/tui-stack.c (tui_show_frame_info): Update.
8590         * tui/tui-source.c (tui_set_source_content)
8591         (tui_set_source_content_nil, tui_source_is_displayed)
8592         (tui_source_window::do_scroll_vertical): Update.
8593         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8594         (tui_display_registers_from, tui_display_reg_element_at_line)
8595         (tui_check_register_values, tui_reg_command): Update.
8596         * tui/tui-layout.c (tui_default_win_height)
8597         (show_source_disasm_command, show_data, init_and_make_win)
8598         (show_source_or_disasm_and_command): Update.
8599         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8600         (tui_redisplay_readline, tui_mld_flush)
8601         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8602         (tui_getc): Update.
8603         * tui/tui-disasm.c (tui_set_disassem_content)
8604         (tui_disasm_window::do_scroll_vertical): Update.
8605         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8606         Now virtual.
8607         (struct tui_win_info): Derive from tui_gen_win_info.
8608         <~tui_win_info>: Mark as override.
8609         <generic>: Remove member.
8610         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8611         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8612         (~tui_data_window, ~tui_win_info)
8613         (tui_free_all_source_wins_content): Update.
8614         * tui/tui-command.c (tui_refresh_cmd_win): Update.
8615
8616 2019-06-25  Tom Tromey  <tom@tromey.com>
8617
8618         * tui/tui-layout.c (init_and_make_win): Use new.
8619         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8620         destructor, initializers.
8621         (tui_alloc_generic_win_info): Don't declare.
8622         * tui/tui-data.c (_locator): Add argument to constructor.
8623         (source_win, disasm_win): New globals.
8624         (exec_info): Remove.
8625         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8626         Update.
8627         (tui_alloc_generic_win_info): Remove.
8628         (init_content_element): Use new.
8629         (tui_win_info::tui_win_info): Update.
8630         (free_content_elements) <case DATA_WIN>: Use delete.
8631
8632 2019-06-25  Tom Tromey  <tom@tromey.com>
8633
8634         * tui/tui-wingeneral.c (tui_refresh_win): Update.
8635         * tui/tui-windata.c (tui_first_data_item_displayed)
8636         (tui_delete_data_content_windows): Update.
8637         * tui/tui-win.c (tui_data_window::set_new_height): Update.
8638         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8639         (tui_display_registers_from, tui_check_register_values): Update.
8640         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8641         pointer.
8642         * tui/tui-data.c (init_content_element): Update.  Allocate the new
8643         window.
8644         (tui_free_data_content): Update.
8645         (free_content_elements) <case DATA_WIN>: Free the window.
8646
8647 2019-06-25  Tom Tromey  <tom@tromey.com>
8648
8649         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8650         Update.
8651         * tui/tui-layout.c (make_command_window)
8652         (show_source_disasm_command, show_data, init_and_make_win)
8653         (show_source_or_disasm_and_command): Update.
8654         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8655         method.
8656         <can_highight, is_highlighted>: Now bool.
8657         (tui_set_win_highlight): Don't declare.
8658         * tui/tui-data.c (tui_set_win_highlight): Remove.
8659
8660 2019-06-25  Tom Tromey  <tom@tromey.com>
8661
8662         * tui/tui-wingeneral.c (make_visible): Remove check of window
8663         type.
8664
8665 2019-06-25  Tom Tromey  <tom@tromey.com>
8666
8667         * tui/tui-win.c (tui_win_info::max_height)
8668         (tui_cmd_window::max_height): New methods.
8669         (new_height_ok): Call max_height.
8670         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8671         <max_height>: New method.
8672
8673 2019-06-25  Tom Tromey  <tom@tromey.com>
8674
8675         * tui/tui-win.c (tui_source_window_base::set_new_height)
8676         (tui_data_window::set_new_height): New methods.
8677         (make_invisible_and_set_new_height): Call set_new_height method.
8678         * tui/tui-data.h (struct tui_win_info)
8679         (struct tui_source_window_base, struct tui_data_window)
8680         <set_new_height>: New method.
8681
8682 2019-06-25  Tom Tromey  <tom@tromey.com>
8683
8684         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8685         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8686         tui_refresh_data_win.
8687         * tui/tui-win.c (tui_source_window_base::refresh_all): New
8688         method.
8689         (tui_refresh_all_win): Call the refresh_all method.
8690         (tui_set_focus): Likewise.
8691         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8692         (struct tui_source_window_base, struct tui_data_window) <refresh>:
8693         Likewise.
8694
8695 2019-06-25  Tom Tromey  <tom@tromey.com>
8696
8697         * tui/tui-winsource.h (tui_refill_source_window)
8698         (tui_set_is_exec_point_at): Don't declare.
8699         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8700         (tui_source_window_base::refill): Rename from
8701         tui_refill_source_window.
8702         (tui_source_window_base::do_scroll_horizontal): Update.
8703         (tui_source_window_base::set_is_exec_point_at): Rename from
8704         tui_set_is_exec_point_at.
8705         (tui_update_all_breakpoint_info): Update.
8706         * tui/tui-stack.c (tui_show_frame_info): Update.
8707         * tui/tui-layout.c (show_data): Add cast.
8708         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8709         * tui/tui-data.h (struct tui_source_window_base) <refill,
8710         set_is_exec_point_at>: New methods.
8711         (tui_source_windows, tui_add_to_source_windows): Update types.
8712         (tui_add_to_source_windows): Remove redundant declaration.
8713         * tui/tui-data.c (source_windows): Store tui_source_window_base.
8714         (tui_source_windows): Change return type.
8715         (tui_clear_source_windows_detail): Update.
8716         (tui_add_to_source_windows): Change type of parameter.
8717         (tui_free_all_source_wins_content): Update.
8718
8719 2019-06-25  Tom Tromey  <tom@tromey.com>
8720
8721         * tui/tui-wingeneral.c (tui_win_info::refresh)
8722         (tui_source_window_base::refresh): New methods.
8723         (tui_refresh_all): Call the refresh method.
8724         * tui/tui-data.h (struct tui_win_info)
8725         (struct tui_source_window_base) <refresh>: New method.
8726
8727 2019-06-25  Tom Tromey  <tom@tromey.com>
8728
8729         * tui/tui.h (tui_is_window_visible): Return bool.
8730         * tui/tui.c (tui_is_window_visible): Return bool.
8731         * tui/tui-wingeneral.c (tui_make_window, make_visible)
8732         (tui_make_visible, tui_make_invisible)
8733         (tui_win_info::make_visible)
8734         (tui_source_window_base::make_visible, make_all_visible)
8735         (tui_make_all_visible, tui_make_all_invisible): Update.
8736         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8737         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8738         bool.
8739         (struct tui_win_info, struct tui_source_window_base)
8740         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8741         * tui/tui-data.c (tui_init_generic_part): Update.
8742
8743 2019-06-25  Tom Tromey  <tom@tromey.com>
8744
8745         * tui/tui-wingeneral.c (tui_win_info::make_visible)
8746         (tui_source_window_base::make_visible): New methods.
8747         (make_all_visible): Make method call.
8748         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8749         (struct tui_source_window_base, struct tui_cmd_window): Override
8750         make_visible.
8751         (tui_win_is_source_type): Don't declare.
8752         * tui/tui-data.c (tui_win_is_source_type): Remove.
8753
8754 2019-06-25  Tom Tromey  <tom@tromey.com>
8755
8756         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8757         NULL check.
8758
8759 2019-06-25  Tom Tromey  <tom@tromey.com>
8760
8761         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8762         Inline constructor.  Add initializers for members.
8763         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8764         constructors; now inline in class.
8765
8766 2019-06-25  Tom Tromey  <tom@tromey.com>
8767
8768         * tui/tui-regs.c (tui_show_registers): Update.
8769         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8770         bool.
8771         * tui/tui-data.c (tui_data_window::clear_detail)
8772         (tui_data_window): Update.
8773
8774 2019-06-25  Tom Tromey  <tom@tromey.com>
8775
8776         * tui/tui-windata.c (tui_display_all_data)
8777         (tui_display_data_from_line, tui_display_data_from)
8778         (tui_check_data_values, tui_data_window::do_scroll_vertical):
8779         Update.
8780         * tui/tui-regs.c (tui_last_regs_line_no)
8781         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8782         (tui_show_registers, tui_show_register_group)
8783         (tui_display_registers_from, tui_display_reg_element_at_line)
8784         (tui_display_registers_from_line, tui_check_register_values)
8785         (tui_reg_next, tui_reg_prev): Update.
8786         * tui/tui-layout.c (tui_set_layout, show_data): Update.
8787         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
8788         tui_data_window.
8789         (struct tui_win_info) <detail>: Remove.  Add new fields from
8790         tui_data_info.
8791         (TUI_DATA_WIN): Add cast.
8792         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8793         (~tui_data_window): Simplify.
8794
8795 2019-06-25  Tom Tromey  <tom@tromey.com>
8796
8797         * tui/tui-layout.c (show_source_disasm_command)
8798         (show_source_or_disasm_and_command): Update.
8799         * tui/tui-io.c (update_cmdwin_start_line)
8800         (tui_redisplay_readline): Update.
8801         * tui/tui-data.h (struct tui_command_info): Remove.
8802         (struct tui_win_info) <detail>: Remove command_info member.
8803         (struct tui_data_window) <start_line>: New member, from
8804         tui_command_info.
8805         (TUI_CMD_WIN): Add casts.
8806
8807 2019-06-25  Tom Tromey  <tom@tromey.com>
8808
8809         * tui/tui-winsource.c (tui_update_source_window)
8810         (tui_refill_source_window)
8811         (tui_source_window_base::do_scroll_horizontal)
8812         (tui_update_breakpoint_info, tui_set_exec_info_content)
8813         (tui_show_exec_info_content, tui_erase_exec_info_content)
8814         (tui_clear_exec_info_content): Update.
8815         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8816         Update.
8817         * tui/tui-win.c (make_invisible_and_set_new_height)
8818         (make_visible_with_new_height): Update.
8819         * tui/tui-source.c (tui_set_source_content)
8820         (tui_show_symtab_source): Update.
8821         * tui/tui-layout.c (extract_display_start_addr)
8822         (show_source_disasm_command, show_data)
8823         (make_source_or_disasm_window)
8824         (show_source_or_disasm_and_command): Update.
8825         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8826         (tui_disasm_window::do_scroll_vertical): Remove shadowing
8827         "gdbarch".
8828         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
8829         to tui_source_window_base.
8830         (struct tui_win_info) <detail>: Remove source_info member.
8831         (struct tui_source_window_base) <has_locator>: Inline.
8832         Move contents from tui_source_info; rename has_locator member to
8833         m_has_locator.
8834         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8835         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8836         header file.
8837         (tui_source_window_base::clear_detail, ~tui_source_window_base):
8838         Simplify.
8839         (tui_free_all_source_wins_content): Cast to
8840         tui_source_window_base.
8841
8842 2019-06-25  Tom Tromey  <tom@tromey.com>
8843
8844         * tui/tui-win.c (make_invisible_and_set_new_height)
8845         (make_visible_with_new_height): Call has_locator method.
8846         * tui/tui-layout.c (show_source_disasm_command, show_data)
8847         (show_source_or_disasm_and_command): Update for bool change.
8848         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8849         (tui_win_info) <has_locator>: New method.
8850         (struct tui_source_window_base) <has_locator>: New method.
8851         (tui_win_has_locator): Don't declare.
8852         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8853         from tui_win_has_locator.
8854         (tui_source_window_base): Use false, not FALSE.
8855
8856 2019-06-25  Tom Tromey  <tom@tromey.com>
8857
8858         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8859         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8860         clear_detail method directly.
8861         (tui_clear_win_detail): Remove.
8862
8863 2019-06-25  Tom Tromey  <tom@tromey.com>
8864
8865         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8866         "this", not TUI_DISASM_WIN.
8867
8868 2019-06-25  Tom Tromey  <tom@tromey.com>
8869
8870         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
8871         declare.
8872         * tui/tui-winsource.c
8873         (tui_source_window_base::do_scroll_horizontal): Rename from
8874         tui_horizontal_source_scroll.
8875         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8876         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8877         from tui_vertical_data_scroll.
8878         * tui/tui-win.h (tui_scroll): Don't declare.
8879         * tui/tui-win.c (tui_win_info::forward_scroll)
8880         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8881         (tui_win_info::right_scroll): Rename and update.
8882         (tui_scroll_forward_command, tui_scroll_backward_command)
8883         (tui_scroll_left_command, tui_scroll_right_command): Update.
8884         (tui_scroll): Remove.
8885         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8886         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8887         from tui_vertical_source_scroll.
8888         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8889         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8890         from tui_vertical_disassem_scroll.
8891         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8892         do_scroll_horizontal>: New methods.
8893         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8894         Likewise.
8895         (struct tui_source_window_base): Add do_scroll_horizontal.
8896         (struct tui_source_window, struct tui_disasm_window): Add
8897         do_scroll_vertical.
8898         (struct tui_data_window, struct tui_cmd_window): Add
8899         do_scroll_horizontal and do_scroll_vertical.
8900         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8901
8902 2019-06-25  Tom Tromey  <tom@tromey.com>
8903
8904         * tui/tui-data.h (struct tui_source_window_base): New struct.
8905         (struct tui_source_window): Derive from tui_source_window_base.
8906         (struct tui_disasm_window): New struct.
8907         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8908         from tui_source_window::clear_detail.
8909         (tui_source_window_base): Rename from tui_source_window.
8910         (~tui_source_window_base): Rename from ~tui_source_window.
8911         (tui_alloc_win_info): Create a tui_disasm_window.
8912
8913 2019-06-25  Tom Tromey  <tom@tromey.com>
8914
8915         * tui/tui-data.h (struct tui_source_window)
8916         (struct tui_data_window): Declare destructors.
8917         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8918         destructors.
8919         (tui_win_info): Simplify.
8920
8921 2019-06-25  Tom Tromey  <tom@tromey.com>
8922
8923         * tui/tui-winsource.c (tui_display_main)
8924         (tui_update_source_windows_with_addr)
8925         (tui_update_all_breakpoint_info): Update.
8926         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8927         (new_height_ok, parse_scrolling_args): Update.
8928         * tui/tui-stack.c (tui_show_frame_info): Update.
8929         * tui/tui-data.h (struct tui_list): Remove.
8930         (tui_source_windows): Return a reference to a std::vector.
8931         * tui/tui-data.c (source_windows): Now a std::vector.
8932         (tui_source_windows): Change return type.
8933         (tui_clear_source_windows): Rewrite.
8934         (tui_clear_source_windows_detail, tui_add_to_source_windows)
8935         (tui_free_all_source_wins_content): Rewrite.
8936
8937 2019-06-25  Tom Tromey  <tom@tromey.com>
8938
8939         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8940         (struct tui_data_window, struct tui_cmd_window): Declare
8941         clear_detail method.
8942         * tui/tui-data.c (tui_source_window::clear_detail)
8943         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8944         methods.
8945         (tui_clear_win_detail): Simplify.
8946
8947 2019-06-25  Tom Tromey  <tom@tromey.com>
8948
8949         * tui/tui-layout.c (make_source_window, make_disasm_window)
8950         (make_source_or_disasm_window): Remove win_info_ptr parameter.
8951         Return the new window.
8952         (show_source_disasm_command, show_data)
8953         (show_source_or_disasm_and_command): Update.
8954
8955 2019-06-25  Tom Tromey  <tom@tromey.com>
8956
8957         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8958         parameter.  Return the new window.
8959         (show_source_disasm_command): Update and remove NULL check.
8960         (show_source_or_disasm_and_command): Update.
8961
8962 2019-06-25  Tom Tromey  <tom@tromey.com>
8963
8964         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8965
8966 2019-06-25  Tom Tromey  <tom@tromey.com>
8967
8968         * tui/tui-data.h (struct tui_win_info): Make constructor
8969         protected.  Make destructor virtual.  Add initializers.
8970         (tui_source_window, tui_data_window, tui_cmd_window): New
8971         classes.
8972         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
8973         constructor.  Add "type" parameter.
8974         (tui_source_window, tui_data_window, tui_cmd_window): New
8975         constructors.
8976         (tui_alloc_win_info): Instantiate the appropriate subclass.
8977
8978 2019-06-25  Tom Tromey  <tom@tromey.com>
8979
8980         * tui/tui-win.c (tui_resize_all): Use delete.
8981         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8982         destructor.
8983         (tui_free_window): Don't declare.
8984         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8985         Update.
8986
8987 2019-06-25  Tom Tromey  <tom@tromey.com>
8988
8989         * tui/tui-data.h (struct tui_win_info): Add constructor.
8990         * tui/tui-data.c (tui_alloc_win_info): Use new.
8991         (tui_free_window): Use delete.
8992
8993 2019-06-22  Tom Tromey  <tom@tromey.com>
8994
8995         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8996         declare.
8997         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8998
8999 2019-06-22  Tom Tromey  <tom@tromey.com>
9000
9001         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
9002         declare.
9003         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
9004
9005 2019-06-22  Tom de Vries  <tdevries@suse.de>
9006
9007         * dwarf2read.c (create_addrmap_from_aranges)
9008         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
9009         instead of '%zu'.
9010
9011 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
9012
9013         * dwarf2read.h (dwarf2_section_info_def): Remove.
9014         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
9015         * dwarf2read.c (struct dwo_sections) <types>: Change type to
9016         std::vector<dwarf2_section_info>.
9017         (struct dwo_file) <~dwo_file>: Remove.
9018         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
9019         types field.
9020         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
9021         (dwarf2_read_debug_names): Likewise.
9022         (create_debug_types_hash_table): Change parameter type to
9023         array_view, adjust code accordingly.
9024         (dwarf2_locate_dwo_sections): Adjust to std::vector.
9025         (partial_die_info::fixup): Likewise.
9026         (determine_prefix): Likewise.
9027         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
9028
9029 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9030
9031         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
9032         gdb_bfd_ref_ptr.
9033         <~dwo_file>: Remove call to gdb_bfd_unref.
9034         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
9035         gdb_bfd_ref_ptr::get.
9036
9037 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9038
9039         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
9040         type to htab_up.
9041         * dwarf2read.c (struct dwo_file): Initialize fields.
9042         <~dwo_file>: New.
9043         (free_dwo_file): Remove, move content to ~dwo_file.
9044         (struct dwo_file_deleter): Remove.
9045         (dwo_file_up>: Remove custom deleter.
9046         (free_dwo_files): Remove.
9047         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
9048         dwo_files.
9049         (process_skeletonless_type_units): Call unique_ptr::get.
9050         (allocate_dwo_file_hash_table): Add deleter to created hash
9051         table.  Change return type to htab_up.
9052         (lookup_dwo_file_slot): Don't memset dwo_file, call
9053         unique_ptr::get.
9054         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9055         (create_dwo_unit_in_dwp_v2): Likewise.
9056         (open_and_init_dwo_file): Likewise.
9057         (free_dwo_file_from_slot): Remove.
9058
9059 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9060
9061         * dwarf2read.h (struct dwarf2_section_info) <readin,
9062         is_virtual>: Change type to bool.
9063         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9064         true instead of 1.
9065
9066 2019-06-19  Tom Tromey  <tom@tromey.com>
9067
9068         * tui/tui-data.h (tui_init_content_element): Don't declare.
9069
9070 2019-06-19  Tom Tromey  <tom@tromey.com>
9071
9072         * tui/tui-data.h (tui_init_win_info): Don't declare.
9073
9074 2019-06-19  Tom de Vries  <tdevries@suse.de>
9075
9076         * dwarf2read.h (abstract_to_concrete): Change type to
9077         std::unordered_map<sect_offset, std::vector<sect_offset>,
9078         gdb::hash_enum<sect_offset>>.
9079
9080 2019-06-19  Tom Tromey  <tromey@adacore.com>
9081
9082         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9083         EVAL_AVOID_SIDE_EFFECTS specially.
9084
9085 2019-06-19  Tom Tromey  <tromey@adacore.com>
9086
9087         * source-cache.c (highlighter): New global.
9088         (source_cache::get_source_lines): Create a highlighter on demand.
9089
9090 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9091
9092         * defs.h (deprecated_interactive_hook): Delete declaration.
9093         * interps.c (clear_interpreter_hooks): Remove use of
9094         deprecated_interactive_hook.
9095         * top.c (deprecated_interactive_hook): Delete definition.
9096         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9097
9098 2019-06-18  Tom de Vries  <tdevries@suse.de>
9099
9100         PR gdb/24515
9101         * dwarf2read.h (abstract_to_concrete): Change type from
9102         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9103         std::unordered_map<sect_offset, std::vector<sect_offset>>.
9104         * dwarf2read.c (read_variable): Update.
9105         (dwarf2_fetch_die_loc_sect_off): Update.
9106
9107 2019-06-17  Tom de Vries  <tdevries@suse.de>
9108
9109         PR gdb/24617
9110         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9111         accessing parent[parent_len - 1].
9112
9113 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
9114
9115         PR gdb/24364
9116         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9117         call dtrace_process_dof with NULL dof.
9118
9119 2019-06-16  Tom de Vries  <tdevries@suse.de>
9120
9121         PR gdb/24445
9122         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9123
9124 2019-06-16  Tom Tromey  <tom@tromey.com>
9125
9126         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9127         (make_all_visible): Use address of member.
9128
9129 2019-06-16  Tom Tromey  <tom@tromey.com>
9130
9131         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9132         (tui_free_window, free_content, free_content_elements): Remove
9133         unnecessary cast.
9134         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9135         cast.
9136         * tui/tui-regs.c (tui_show_register_group)
9137         (tui_display_registers_from, tui_display_reg_element_at_line):
9138         Remove unnecessary cast.
9139
9140 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
9141
9142         * linux-nat.c (normal_mask): Delete.
9143         (_initialize_linux_nat): Don't initialise normal_mask.
9144
9145 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
9146
9147         PR gdb/24445
9148         * dwarf-index-write.h (write_psymtabs_to_index): Add
9149         dwz_basename parameter.
9150         * dwarf-index-write.c (write_gdbindex): Move file writing to
9151         write_gdbindex_1.  Change return type void.
9152         (assert_file_size): Move up, remove filename parameter.
9153         (write_gdbindex_1): New function.
9154         (write_debug_names): Change return type to void, call
9155         assert_file_size.
9156         (struct index_wip_file): New struct.
9157         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
9158         file logic to index_wip_file.  Write index for dwz file if
9159         needed.
9160         (save_gdb_index_command): Pass basename of dwz file, if present.
9161         * dwarf-index-cache.c (index_cache::store): Obtain and pass
9162         build-id of dwz file, if present.
9163         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9164         (dwarf2_get_dwz_file): Likewise.
9165         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9166         (dwarf2_get_dwz_file): Likewise.
9167
9168 2019-06-16  Tom Tromey  <tom@tromey.com>
9169
9170         * coffread.c (process_coff_symbol): Use xstrdup.
9171         * value.c (create_internalvar): Use xstrdup.
9172
9173 2019-06-16  Tom Tromey  <tom@tromey.com>
9174
9175         * valops.c (value_cast, value_slice): Remove unnecessary cast.
9176         * breakpoint.c (stopin_command, stopat_command)
9177         (until_break_command, decode_location_default): Remove unnecessary
9178         cast.
9179         * utils.c (subset_compare): Remove unnecessary cast.
9180         * ada-lang.c (ada_update_initial_language): Remove unnecessary
9181         cast.
9182         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9183         cast.
9184         * infcmd.c (path_command): Remove unnecessary cast.
9185         * coffread.c (decode_type): Remove unnecessary cast.
9186         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9187         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9188         * tui/tui-stack.c (tui_show_locator_content)
9189         (tui_show_frame_info): Remove unnecessary cast.
9190         * tui/tui-win.c (tui_scroll_forward_command)
9191         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9192         (parse_scrolling_args): Remove unnecessary cast.
9193         * tui/tui-data.c (init_win_info, tui_del_window)
9194         (tui_free_window, tui_del_data_windows, tui_free_data_content)
9195         (free_content_elements): Remove unnecessary cast.
9196         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9197         unnecessary cast.
9198         * tui/tui-source.c (tui_set_source_content)
9199         (tui_vertical_source_scroll): Remove unnecessary cast.
9200         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9201         cast.
9202         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9203         * tui/tui-regs.c (tui_display_registers_from)
9204         (tui_display_register): Remove unnecessary cast.
9205         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9206         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9207         (make_visible): Remove unnecessary cast.
9208         * tui/tui-winsource.c (tui_erase_source_content)
9209         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9210         unnecessary cast.
9211         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9212         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9213         * stabsread.c (read_type, read_array_type, read_range_type):
9214         Remove unnecessary cast.
9215         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9216         (parse_symbol, parse_type, upgrade_type, parse_external)
9217         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9218         unnecessary cast.
9219         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9220
9221 2019-06-16  Tom Tromey  <tom@tromey.com>
9222
9223         * tui/tui-data.c (tui_alloc_generic_win_info)
9224         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9225         checks.
9226
9227 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
9228             Andrew Burgess  <andrew.burgess@embecosm.com>
9229
9230         * f-typeprint.c (f_print_type): Don't return early for not
9231         associated or not allocated types.
9232         (f_type_print_varspec_suffix): Add print_rank parameter and print
9233         ranks of array types in case they dangling.
9234         (f_type_print_base): Add print_rank parameter.
9235
9236 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9237
9238         * NEWS: Mention new MI commands.
9239         * break-catch-throw.c (enum exception_event_kind): Move to
9240         breakpoint.h.
9241         (print_mention_exception_catchpoint): Output text as a single
9242         message.
9243         (catch_exception_command_1): Rename to...
9244         (catch_exception_event): ...this, make non-static, update header
9245         command, and change some parameter types.
9246         (catch_catch_command): Update for changes to
9247         catch_exception_command_1.
9248         (catch_throw_command): Likewise.
9249         (catch_rethrow_command): Likewise.
9250         * breakpoint.c (enum exception_event_kind): Delete.
9251         * breakpoint.h (enum exception_event_kind): Moved here from
9252         break-catch-throw.c.
9253         (catch_exception_event): Declare.
9254         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9255         (mi_cmd_catch_throw): New function.
9256         (mi_cmd_catch_rethrow): New function.
9257         (mi_cmd_catch_catch): New function.
9258         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9259         'catch-catch' entries.
9260         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9261         (mi_cmd_catch_rethrow): Declare.
9262         (mi_cmd_catch_catch): Declare.
9263
9264 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9265
9266         * annotate.c (annotate_source_line): Change return type to void,
9267         update implementation to match.
9268         * annotate.h (annotate_source_line): Change return type to void,
9269         update header comment.
9270         * stack.c (print_frame_info): Don't change what frame information
9271         is printed based on whether annotations are on or not.
9272
9273 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9274
9275         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9276         (annotate_source): Make static.
9277         (annotate_source_line): Moved from source.c and renamed from
9278         identify_source_line.  Update the return type.
9279         * annotate.h (annotate_source): Delete declaration.
9280         (annotate_source_line): Declaration moved from source.h, and
9281         renamed from identify_source_line.  Return type updated.
9282         * source.c (identify_source_line): Moved to annotate.c and renamed
9283         to annotate_source_line.
9284         (info_line_command): Remove check of annotation_level.
9285         * source.h (identify_source_line): Move declaration to annotate.h
9286         and rename to annotate_source_line.
9287         * stack.c: Add 'annotate.h' include.
9288         (print_frame_info): Remove check of annotation_level before
9289         calling annotate_source_line.
9290
9291 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9292
9293         * source-cache.c (source_cache::get_plain_source_lines): Use
9294         open_source_file_with_line_charpos instead of just
9295         open_source_file, remove call to find_source_lines.
9296         (source_cache::get_source_lines): Likewise.
9297         * source.c (find_source_lines): Make static.
9298         (get_filename_and_charpos): Renamed into...
9299         (open_source_file_with_line_charpos): ..this along with changes to
9300         return a scoped_fd, and some other minor clean ups.
9301         (identify_source_line): Use open_source_file_with_line_charpos.
9302         (search_command_helper): Use open_source_file_with_line_charpos
9303         instead of just open_source_file, remove call to
9304         find_source_lines.
9305         * source.h (open_source_file_with_line_charpos): Declare new
9306         function.
9307         (find_source_lines): Delete declaration.
9308
9309 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9310
9311         * source.c (get_filename_and_charpos): Remove fullname
9312         parameter.
9313         (identify_source_line): Update call to get_filename_and_charpos.
9314
9315 2019-06-14  Tom Tromey  <tromey@adacore.com>
9316
9317         PR gdb/24502:
9318         * ui-style.h (skip_ansi_escape): Update comment.
9319         * ui-file.h (class no_terminal_escape_file): New class.
9320         * ui-file.c (no_terminal_escape_file::write)
9321         (no_terminal_escape_file::puts): New methods.
9322         * cli/cli-logging.c (handle_redirections): Use
9323         no_terminal_escape_file.
9324
9325 2019-06-14  Tom Tromey  <tromey@adacore.com>
9326
9327         * NEWS: Move convenience variable news above Python news.
9328
9329 2019-06-14  Tom Tromey  <tom@tromey.com>
9330
9331         * gnulib: Move directory to top-level.
9332         * configure.ac: Don't configure gnulib.
9333         * configure: Rebuild.
9334         * common/common-defs.h: Use new path to gnulib.
9335         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9336         (GNULIB_H): Remove.
9337         (INCGNU): Look in new gnulib location.
9338         (HFILES_NO_SRCDIR): Remove gnulib files.
9339         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9340         (generated_files): Remove GNULIB_H.
9341         ($(LIBGNU), all-lib): Remove targets.
9342         (distclean): Don't mention GNULIB_BUILDDIR.
9343         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9344
9345 2019-06-14  Tom Tromey  <tromey@adacore.com>
9346
9347         * symfile.c (add_symbol_file_command): Remove obsolete comment.
9348         Warn if symbol file does not provide any symbols.
9349
9350 2019-06-14  Tom Tromey  <tromey@adacore.com>
9351
9352         * source.c (find_and_open_source): Respect basenames_may_differ.
9353
9354 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
9355
9356         * annotate.c (annotate_breakpoints_invalid): Make use of
9357         scoped_restore_terminal_state.
9358         (annotate_frames_invalid): Likewise.
9359
9360 2019-06-14  Tom Tromey  <tromey@adacore.com>
9361
9362         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9363         allow assignment to an internalvar.
9364
9365 2019-06-14  Tom Tromey  <tromey@adacore.com>
9366
9367         * ada-lex.l: Allow "_" in attribute names.
9368
9369 2019-06-14  Tom Tromey  <tromey@adacore.com>
9370
9371         PR gdb/24653:
9372         * regcache.c (registers_changed): Don't call alloca.
9373         * top.c (execute_command): Don't call alloca.
9374
9375 2019-06-13  Pedro Alves  <palves@redhat.com>
9376
9377         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9378         'expression'.  When parsing an expression, error out if there's
9379         junk after "unlimited".
9380         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9381         (do_set_command): Adjust calls to is_unlimited_literal.
9382
9383 2019-06-13  Pedro Alves  <palves@redhat.com>
9384
9385         * compile/compile.c (make_compile_options_def_group): Add braces
9386         around array_view initializer.
9387         * thread.c (make_thread_apply_all_options_def_group)
9388         (make_thread_apply_all_options_def_group): Likewise.
9389
9390 2019-06-13  Pedro Alves  <palves@redhat.com>
9391
9392         * NEWS (New commands): Mention "maint test-options
9393         require-delimiter", "maint test-options unknown-is-error", "maint
9394         test-options unknown-is-operand" and "maint show
9395         test-options-completion-result".
9396         (New command options, command completion): New section.
9397         (Completion improvements): New section.
9398         Mention that you can abbreviate "unlimited".
9399
9400 2019-06-13  Pedro Alves  <palves@redhat.com>
9401
9402         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9403         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9404         * unittests/cli-utils-selftests.c (test_parse_flags)
9405         (test_parse_flags_qcs): Delete.
9406         (test_cli_utils): Don't call deleted functions.
9407
9408 2019-06-13  Pedro Alves  <palves@redhat.com>
9409
9410         * thread.c: Include "cli/cli-option.h".
9411         (tp_array_compar_ascending): Global.
9412         (tp_array_compar): Delete function.
9413         (tp_array_compar_ascending, tp_array_compar_descending): New
9414         functions.
9415         (ascending_option_def, qcs_flag_option_def)
9416         (thr_qcs_flags_option_defs)
9417         (make_thread_apply_all_options_def_group)
9418         (make_thread_apply_options_def_group): New.
9419         (thread_apply_all_command): Use gdb::option::process_options.
9420         (thread_apply_command_completer)
9421         (thread_apply_all_command_completer): New.
9422         (thread_apply_command): Use gdb::option::process_options.
9423         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9424         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
9425         to generate help text of "thread apply".  Adjust "taas"'s help.
9426         * tid-parse.c (tid_range_parser::in_thread_range): New method.
9427         * tid-parse.h (tid_range_parser::in_thread_range): New method.
9428
9429 2019-06-13  Pedro Alves  <palves@redhat.com>
9430
9431         * thread.c (thread_apply_command): Check for invalid TID with
9432         isdigit instead of !isalpha.
9433
9434 2019-06-13  Pedro Alves  <palves@redhat.com>
9435
9436         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9437         (validate_flags_qcs): New.
9438         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9439         (validate_flags_qcs): Declare.
9440         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9441         (make_frame_apply_options_def_group): New.
9442         (frame_apply_command_count): Process options with
9443         gdb::option::process_options.
9444         (frame_apply_completer): New.
9445         (frame_apply_level_completer, frame_apply_all_completer)
9446         (frame_apply_completer): New.
9447         (_initialize_stack): Update help of "frame apply", "frame apply
9448         level", "frame apply all" and "faas" to mention supported options
9449         and install command completers.
9450         * stack.h (frame_apply_all_completer): Declare.
9451         * thread.c: Include "stack.h".
9452         (tfaas_command): Add "--".
9453         (_initialize_thread): Update help "tfaas" to mention supported
9454         options and install command completer.
9455
9456 2019-06-13  Pedro Alves  <palves@redhat.com>
9457
9458         * completer.c (complete_nested_command_line): New.
9459         (gdb_completion_word_break_characters_throw): Add assertion.
9460         * completer.h (complete_nested_command_line): Declare.
9461
9462 2019-06-13  Pedro Alves  <palves@redhat.com>
9463
9464         * stack.c (parse_backtrace_qualifiers): New.
9465         (backtrace_command): Use it.
9466         (backtrace_command_completer): Complete on qualifiers.
9467
9468 2019-06-13  Pedro Alves  <palves@redhat.com>
9469
9470         * frame.c: Include "cli/cli-option.h.
9471         (user_set_backtrace_options): New.
9472         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9473         Delete.
9474         (get_prev_frame): Adjust.
9475         (boolean_option_def, uinteger_option_def)
9476         (set_backtrace_option_defs): New.
9477         (_initialize_frame): Adjust and use
9478         gdb::option::add_setshow_cmds_for_options to install "set
9479         backtrace past-main" and "set backtrace past-entry".
9480         * frame.h: Include "cli/cli-option.h".
9481         (struct frame_print_options): Forward declare.
9482         (print_frame_arguments_all, print_frame_arguments_scalars)
9483         (print_frame_arguments_none): Declare.
9484         (print_entry_values): Delete declaration.
9485         (struct frame_print_options, user_frame_print_options): New.
9486         (struct set_backtrace_options): New.
9487         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9488         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9489         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9490         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9491         (list_args_or_locals): Add frame_print_options parameter.
9492         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9493         * python/py-framefilter.c (enumerate_args): Pass down
9494         USER_FRAME_PRINT_OPTIONS.
9495         * stack.c: Include "cli/cli-option.h".
9496         (print_frame_arguments_all, print_frame_arguments_scalars)
9497         (print_frame_arguments_none): Declare.
9498         (print_raw_frame_arguments, print_entry_values): Delete.
9499         (user_frame_print_options): New.
9500         (boolean_option_def, enum_option_def, frame_print_option_defs):
9501         New.
9502         (struct backtrace_cmd_options): New.
9503         (bt_flag_option_def): New.
9504         (backtrace_command_option_defs): New.
9505         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9506         (print_frame_arg, read_frame_arg, print_frame_args)
9507         (print_frame_info, print_frame): Add frame_print_options parameter
9508         and use it.
9509         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9510         (backtrace_command_1): Add frame_print_options and
9511         backtrace_cmd_options parameters and use them.
9512         (make_backtrace_options_def_group): New.
9513         (backtrace_command): Process command options with
9514         gdb::option::process_options.
9515         (backtrace_command_completer): New.
9516         (_initialize_stack): Extend "backtrace"'s help to mention
9517         supported options.  Install completer for "backtrace".
9518         Install some settings commands with add_setshow_cmds_for_options.
9519
9520 2019-06-13  Pedro Alves  <palves@redhat.com>
9521
9522         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9523         and that "set/show print raw frame-arguments" are now deprecated.
9524
9525         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9526         command.
9527         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9528         * stack.c (_initialize_stack): Install "set/show print
9529         raw-frame-arguments", and deprecate "set/show print raw
9530         frame-arguments".
9531         * valprint.c (_initialize_valprint): Deprecate "set/show print
9532         raw".
9533
9534 2019-06-13  Pedro Alves  <palves@redhat.com>
9535
9536         * compile/compile.c (struct compile_options): New.
9537         (compile_flag_option_def, compile_command_option_defs)
9538         (make_compile_options_def_group): New.
9539         (compile_file_command): Handle options with
9540         gdb::option::process_options.
9541         (compile_file_command_completer): New function.
9542         (compile_code_command): Handle options with
9543         gdb::option::process_options.
9544         (compile_code_command_completer): New function.
9545         (_initialize_compiler): Install completers for "compile code" and
9546         "compile file".  Mention available options in "compile code" and
9547         "compile code"'s help.
9548         * completer.c (advance_to_completion_word): New, factored out from
9549         ...
9550         (advance_to_expression_complete_word_point): ... this.
9551         (advance_to_filename_complete_word_point): New.
9552         * completer.h (advance_to_filename_complete_word_point): New
9553         declaration.
9554
9555 2019-06-13  Pedro Alves  <palves@redhat.com>
9556
9557         * compile/compile.c: Include "cli/cli-option.h".
9558         (compile_print_value): Scope data pointer is now a
9559         value_print_options pointer; adjust.
9560         (compile_print_command): Process options.  Scope data pointer is
9561         now a value_print_options pointer; adjust.
9562         (_initialize_compile): Update "compile print"'s help to include
9563         supported options.  Install a completer for "compile print".
9564         * cp-valprint.c (show_vtblprint, show_objectprint)
9565         (show_static_field_print): Delete.
9566         (_initialize_cp_valprint): Don't install "set print
9567         static-members", "set print vtbl", "set print object" here.
9568         * printcmd.c: Include "cli/cli-option.h" and
9569         "common/gdb_optional.h".
9570         (print_command_parse_format): Rework to fill in a
9571         value_print_options instead of a format_data.
9572         (print_value): Change parameter type from format_data pointer to
9573         value_print_options reference.  Adjust.
9574         (print_command_1): Process options.  Adjust to pass down a
9575         value_print_options.
9576         (print_command_completer): New.
9577         (_initialize_printcmd): Install print_command_completer as
9578         handle_brkchars completer for the "print" command.  Update
9579         "print"'s help to include supported options.
9580         * valprint.c: Include "cli/cli-option.h".
9581         (show_vtblprint, show_objectprint, show_static_field_print): Moved
9582         here from cp-valprint.c.
9583         (boolean_option_def, uinteger_option_def)
9584         (value_print_option_defs, make_value_print_options_def_group):
9585         New.  Use gdb::option::add_setshow_cmds_for_options to install
9586         "set print elements", "set print null-stop", "set print repeats",
9587         "set print pretty", "set print union", "set print array", "set
9588         print address", "set print symbol", "set print array-indexes".
9589         * valprint.h: Include <string> and "cli/cli-option.h".
9590         (make_value_print_options_def_group): Declare.
9591         (print_value): Change parameter type from format_data pointer to
9592         value_print_options reference.
9593         (print_command_completer): Declare.
9594
9595 2019-06-13  Pedro Alves  <palves@redhat.com>
9596
9597         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9598         (COMMON_SFILES): Add maint-test-settings.c.
9599         * cli/cli-decode.c (boolean_enums): New global, factored out from
9600         ...
9601         (add_setshow_boolean_cmd): ... here.
9602         * cli/cli-decode.h (boolean_enums): Declare.
9603         * cli/cli-option.c: New file.
9604         * cli/cli-option.h: New file.
9605         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9606         factored out from ...
9607         (parse_cli_boolean_value(const char *)): ... this.
9608         (is_unlimited_literal): Change parameter type to pointer to
9609         pointer.  Adjust and advance ARG pointer.
9610         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9611         (parse_cli_var_enum): New, factored out from ...
9612         (do_set_command): ... this.  Adjust.
9613         * cli/cli-setshow.h (parse_cli_boolean_value)
9614         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9615         (parse_cli_var_enum): Declare.
9616         * cli/cli-utils.c: Include "cli/cli-option.h".
9617         (get_ulongest): New.
9618         * cli/cli-utils.h (get_ulongest): Declare.
9619         (check_for_argument): New overloads.
9620         * maint-test-options.c: New file.
9621
9622 2019-06-13  Pedro Alves  <palves@redhat.com>
9623
9624         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9625         parse a range if "-" is at the end of the string.
9626
9627 2019-06-13  Pedro Alves  <palves@redhat.com>
9628
9629         * cli/cli-setshow.c (parse_auto_binary_operation)
9630         (parse_cli_boolean_value): Don't allow "o".
9631
9632 2019-06-13  Pedro Alves  <palves@redhat.com>
9633
9634         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9635         * NEWS: Mention maint test-settings KIND.
9636         * maint-test-settings.c: New file.
9637
9638 2019-06-13  Pedro Alves  <palves@redhat.com>
9639
9640         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9641         completer.
9642         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9643         "set" completers.
9644
9645 2019-06-13  Pedro Alves  <palves@redhat.com>
9646
9647         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9648         after item.
9649
9650 2019-06-13  Pedro Alves  <palves@redhat.com>
9651
9652         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9653
9654 2019-06-13  Pedro Alves <palves@redhat.com>
9655
9656         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9657         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9658         call.
9659         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9660         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9661         calls.
9662         (check_for_argument): Skip spaces after argument.
9663
9664 2019-06-13  Pedro Alves  <palves@redhat.com>
9665
9666         * thread.c (thread_apply_command): Adjust TID parsing.
9667         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9668         detected before end of string.
9669         (tid_is_in_list): Error out if LIST is invalid.
9670
9671 2019-06-13  Pedro Alves  <palves@redhat.com>
9672
9673         * completer.c (complete_line_internal_1): Rewind completion word
9674         point.
9675         (completion_tracker::advance_custom_word_point_by): Change
9676         parameter type to int.
9677         * completer.h (completion_tracker::advance_custom_word_point_by):
9678         Likewise.
9679
9680 2019-06-13  Pedro Alves  <palves@redhat.com>
9681
9682         * completer.c (advance_to_completion_word): Handle delimiters.
9683
9684 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
9685
9686         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9687
9688 2019-06-11  Tom Tromey  <tom@tromey.com>
9689
9690         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9691         (xmalloc_failed): Move to alloc.c.
9692         * alloc.c: New file.
9693         * Makefile.in (COMMON_SFILES): Add alloc.c.
9694
9695 2019-06-11  Tom Tromey  <tom@tromey.com>
9696
9697         * nat/linux-waitpid.c: Don't include server.h.
9698         (linux_debug): Remove.
9699         (my_waitpid): Update.
9700
9701 2019-06-11  Tom Tromey  <tromey@adacore.com>
9702
9703         * infcall.c (_initialize_infcall): Remove trailing newline from
9704         help.
9705         * user-regs.c (_initialize_user_regs): Remove trailing newline
9706         from help.
9707         * typeprint.c (_initialize_typeprint): Remove trailing newline
9708         from help.
9709         * reverse.c (_initialize_reverse): Remove trailing newlines from
9710         help.
9711         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9712         from help.
9713         * language.c (add_set_language_command): Remove trailing newline
9714         from help.
9715         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9716         help.
9717         * disasm.c (_initialize_disasm): Remove trailing newline from
9718         help.
9719         * top.c (init_main): Remove trailing newline from help.
9720         * interps.c (_initialize_interpreter): Remove trailing newline
9721         from help.
9722         * btrace.c (_initialize_btrace): Remove trailing newlines from
9723         help.
9724         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9725         from help.
9726         * python/python.c (_initialize_python): Remove trailing newline
9727         from help.
9728         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9729         help.
9730         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9731         from help.  Reformat some text.
9732         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9733         from help.
9734         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9735         newline from help.
9736
9737 2019-06-11  Tom Tromey  <tromey@adacore.com>
9738
9739         * darwin-nat.c (darwin_decode_exception_message)
9740         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9741
9742 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9743
9744         * valops.c (value_slice): Check for not allocated or not
9745         associated values.
9746
9747 2019-06-10  Tom de Vries  <tdevries@suse.de>
9748
9749         PR gdb/24618
9750         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9751         sure an empty slot (defined by a 32-bit zero pair) is recognized as
9752         invalid.
9753
9754 2019-06-10  Tom de Vries  <tdevries@suse.de>
9755
9756         PR gdb/24611
9757         * linespec.c (linespec_lexer_lex_string): Remove incorrect
9758         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
9759
9760 2019-06-10  Tom de Vries  <tdevries@suse.de>
9761
9762         PR symtab/24545
9763         * symtab.c (struct demangled_name_entry): Add language field.
9764         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
9765         static minimal symbol".  Set and use language field.
9766
9767 2019-06-10  Tom Tromey  <tromey@adacore.com>
9768
9769         * ada-lang.c (_initialize_ada_language): Update help text.
9770
9771 2019-06-10  Tom Tromey  <tromey@adacore.com>
9772
9773         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9774         with a newline.
9775         * guile/guile.c (handle_boot_error): Don't end warning with a
9776         newline.
9777         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9778         warning with a newline.
9779         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9780         newline.
9781         (s12z_frame_cache): Likewise.
9782         * dwarf-index-cache.c (index_cache::store): Don't end warning with
9783         a newline.
9784         * solib-svr4.c (disable_probes_interface): Don't end warning with
9785         a newline.
9786         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9787         newline.
9788         * python/python.c (do_finish_initialization): Don't end warning
9789         with a newline.
9790
9791 2019-06-10  Tom Tromey  <tom@tromey.com>
9792
9793         * python/py-breakpoint.c (gdbpy_breakpoint_created)
9794         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9795         gdbpy_enter.
9796
9797 2019-06-10  Tom Tromey  <tromey@adacore.com>
9798
9799         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9800         data.
9801         (elf_new_init): Don't call stabsread_new_init.
9802         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9803         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
9804         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9805
9806 2019-06-10  Tom de Vries  <tdevries@suse.de>
9807
9808         PR symtab/16264
9809         PR symtab/24517
9810         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9811
9812 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
9813
9814         * source.c (find_and_open_source): Also rewrite relative file
9815         names.
9816
9817 2019-04-26  Amos Bird  <amosbird@gmail.com>
9818
9819         * annotate.c (annotate_thread_exited): Add "thread-exited"
9820         annotation.
9821
9822 2019-06-06  Tom Tromey  <tromey@adacore.com>
9823
9824         * maint.h (class scoped_command_stats): Use
9825         DISABLE_COPY_AND_ASSIGN.
9826         <print_time>: New method.
9827         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9828         print_time.
9829         (scoped_command_stats::print_time): New method.
9830
9831 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
9832
9833         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9834         instructions of lengths 6 or 8 bytes.
9835
9836 2019-06-04  Pedro Alves  <palves@redhat.com>
9837
9838         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9839
9840         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9841         * breakpoint.c (condition_completer): Likewise.
9842         * cli/cli-dump.c (scan_expression): Likewise.
9843         * common/filestuff.c (mkdir_recursive): Likewise.
9844         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9845         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9846         (gdb_abspath): Likewise.
9847         * compile/compile-cplus-types.c
9848         (compile_cplus_instance::decl_name): Likewise.
9849         * completer.c (complete_explicit_location):
9850         (signal_completer, reg_or_group_completer_1): Likewise.
9851         * cp-support.c (cp_remove_params_if_any): Likewise.
9852         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9853         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9854         * infcmd.c (strip_bg_char): Likewise.
9855         * linespec.c (copy_token_string): Likewise.
9856         * mi/mi-main.c (output_cores): Likewise.
9857         * psymtab.c (psymtab_search_name):
9858         * symfile.c (test_set_ext_lang_command): Likewise.
9859         * target.c (target_fileio_read_stralloc): Likewise.
9860         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9861         * value.c (complete_internalvar): Likewise.
9862
9863 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
9864
9865         Add objfile property to gdb.Type.
9866         * NEWS: Mention Python API addition.
9867         * python/py-type.c (typy_get_objfile): New method.
9868
9869 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9870
9871         * NEWS: Mention the new set|show style [title|highlight].
9872         Mention changes to "show style", "help" and "apropos".
9873
9874 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9875
9876         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9877         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
9878         instead of print_help_for_command.
9879         (print_doc_of_command): New function.
9880         (help_list): Add 'apropos -v word' suggestion.
9881         (print_help_for_command): Style the command name using title style.
9882         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9883         (_initialize_cli_cmds): Describe -v in apropos_command help.
9884
9885 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9886
9887         * cli/cli-style.h (cli_style_option): Add name in constructor,
9888         add m_name class member, add constructor with intensity,
9889         add name class function.
9890         (cli_style_option::add_setshow_commands): Remove name argument.
9891         (highlight_style, title_style): New styles.
9892         * cli/cli-style.c (do_show): New function that shows a style
9893         characteristic styling the style name with itself.
9894         (set_style_name): New function.
9895         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9896         Update all callers according to the changes in cli/cli-style.h.
9897         * utils.h (fputs_highlighted): New function.
9898         * utils.c (fputs_highlighted): Likewise.
9899
9900 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9901
9902         * NEWS: Mention new pipe command and new convenience variables.
9903
9904 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9905
9906         * cli/cli-cmds.c (pipe_command): New function.
9907         (_initialize_cli_cmds): Call add_com for pipe_command.
9908         Define | as an alias for pipe.
9909         (exit_status_set_internal_vars): New function.
9910         (shell_escape): Call exit_status_set_internal_vars.
9911         cli/cli-decode.c (find_command_name_length): Recognize | as
9912         a single character command.
9913
9914 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9915
9916         * gdbcmd.h (execute_command_to_ui_file): New declaration.
9917         top.c (execute_command_to_ui_file): New function, mostly a copy
9918         of execute_command_to_string.
9919         (execute_command_to_string): Implement by calling
9920         execute_command_to_ui_file.
9921
9922 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9923
9924         * top.h (saved_command_line): Remove declaration.
9925         * top.c (previous_saved_command_line, previous_repeat_arguments):
9926         New variables.
9927         (saved_command_line): Make static, define together with other
9928         'repeat variables'.
9929         (dont_repeat): Clear repeat_arguments.
9930         (repeat_previous, get_saved_command_line, save_command_line):
9931         New functions.
9932         (gdb_init): Initialize saved_command_line
9933         and previous_saved_command_line.
9934         * main.c (captured_main_1): Remove saved_command_line initialization.
9935         * event-top.c (handle_line_of_input): Update to use
9936         the new 'repeat' related functions instead of direct access to
9937         saved_command_line.
9938         * command.h (repeat_previous, get_saved_command_line,
9939         save_command_line): New declarations.
9940         (dont_repeat): Add comment.
9941
9942 2019-05-30  Tom Tromey  <tromey@adacore.com>
9943
9944         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9945         Fix comment.
9946         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9947
9948 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
9949
9950         PR cli/24587
9951         * completer.c (complete): Initialize variable word.
9952
9953 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
9954
9955         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9956         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9957         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9958         'body' is NULL to the outter 'if', protecting the '!is_define'
9959         situation as well.
9960
9961 2019-05-29  Tom Tromey  <tromey@adacore.com>
9962
9963         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9964         (dwarf_unknown): New function.
9965         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9966         (dwarf_type_encoding_name): Use dwarf_unknown.
9967
9968 2019-05-29  Tom Tromey  <tromey@adacore.com>
9969
9970         PR c++/20020:
9971         * cp-valprint.c (cp_print_value_fields): Call
9972         cp_print_static_field inside "try".
9973
9974 2019-05-29  Tom Tromey  <tromey@adacore.com>
9975
9976         * inflow.c (struct terminal_info): Add default operator=.
9977         * configure: Rebuild.
9978         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9979         -Wdeprecated-copy-dtor, -Wredundant-move.
9980
9981 2019-05-29  Tom Tromey  <tromey@adacore.com>
9982
9983         * NEWS: Add entry.
9984         * infcmd.c (print_return_value_1): Handle finish_print
9985         option.
9986         (show_print_finish): New function.
9987         (_initialize_infcmd): Add "set/show print finish" commands.
9988         * valprint.c (user_print_options): Initialize new member.
9989         * valprint.h (struct value_print_options) <finish_print>: New
9990         member.
9991
9992 2019-05-28  Tom Tromey  <tromey@adacore.com>
9993
9994         * ada-lang.c (ada_remove_Xbn_suffix)
9995         (find_old_style_renaming_symbol)
9996         (parse_old_style_renaming): Remove.
9997         (ada_find_renaming_symbol): Don't call
9998         find_old_style_renaming_symbol.
9999         (ada_is_renaming_symbol): Rename from
10000         ada_find_renaming_symbol.  Remove "block" parameter.  Return
10001         bool.  Now static.
10002         (ada_read_var_value): Update and simplify.
10003         * ada-exp.y (write_var_or_type): Remove old code.
10004
10005 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
10006
10007         PR gdb/25010
10008         * event-top.c: Remove include comment.
10009         * inflow.c (class scoped_ignore_sigttou): Move from here...
10010         * inflow.h (class scoped_ignore_sigttou): ...to here.
10011         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
10012         * top.c:  Remove include comment.
10013
10014 2019-05-27  Tom Tromey  <tom@tromey.com>
10015
10016         * NEWS: Fix typo.
10017
10018 2019-05-22  Tom Tromey  <tromey@adacore.com>
10019
10020         * target.c (target_follow_exec): Constify parameter.
10021         * target-delegates.c: Rebuild.
10022         * remote.c (remote_target::follow_exec): Constify parameter.
10023         * infrun.c (follow_exec): Constify parameter.
10024         * target.h (struct target_ops) <follow_exec>: Constify parameter.
10025         (target_follow_exec): Likewise.
10026
10027 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10028
10029         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
10030         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
10031
10032 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10033
10034         * NEWS: Add debugredirect and testsuite sections.
10035
10036 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
10037
10038         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
10039         target descriptions using exclusively floating point register name
10040         aliases.
10041
10042 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
10043
10044         PR gdb/18644:
10045         * f-lang.c (build_fortran_types): Handle the case where
10046         gdbarch_floatformat_for_type returns a nullptr.
10047
10048 2019-05-21  Tom de Vries  <tdevries@suse.de>
10049
10050         PR cli/24587
10051         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10052
10053 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10054
10055         PR gdb/18644:
10056         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10057         16-byte floats.
10058         * i386-tdep.c (i386_floatformat_for_type): Use
10059         floatformats_ia64_quad for the 16-byte floating point component
10060         within a fortran 32-byte complex number.
10061
10062 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10063
10064         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10065         delete default constructor.
10066         (find_partial_die): Update to return const struct.
10067         (partial_die_parent_scope): Move variable declaration into scope
10068         of its use and change its type to auto.
10069         (guess_partial_die_structure_name): Likewise.
10070         (partial_die_info::fixup): Likewise.
10071
10072 2019-05-17  Tom Tromey  <tromey@adacore.com>
10073
10074         * source.c (find_and_open_source): Remove cast.
10075
10076 2019-05-17  Tom Tromey  <tromey@adacore.com>
10077
10078         * annotate.c (annotate_source): Make "filename" const.
10079         * annotate.h (annotate_source): Use const.
10080
10081 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10082
10083         * disasm.c (set_disassembler_options): Send errors to stderr.
10084
10085 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10086
10087         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10088         (cli_interp_base::set_logging): Check debug_redirect.
10089         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10090         * cli/cli-logging.c (debug_redirect): Add static variable.
10091         (pop_output_files): Add default param.
10092         (handle_redirections): Print debug setting.
10093         (show_logging_command): Likewise.
10094         (_initialize_cli_logging): Add debugredirect command.
10095         * interps.c (current_interp_set_logging): Add debug_redirect
10096         parameter.
10097         * interps.h (set_logging): Add debug_redirect parameter.
10098         (current_interp_set_logging): Likewise.
10099         * mi/mi-common.h: Likewise.
10100         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10101
10102 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10103             Tom Tromey  <tromey@adacore.com>
10104
10105         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10106         directly.
10107         * cli/cli-interp.h (make_logging_output): Remove declaration.
10108         * cli/cli-logging.c (make_logging_output): Remove function.
10109         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10110         directly.
10111         * ui-file.c (tee_file::tee_file): Remove bools.
10112         (tee_file::~tee_file): Remove deletes.
10113         * ui-file.h (tee_file): Remove bools.
10114
10115 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
10116
10117         * mi/mi-cmds.h (mi_cmd_complete): New function.
10118         * mi/mi-main.c (mi_cmd_complete): Likewise.
10119         * mi/mi-cmds.c: Define new MI command -complete.
10120         * NEWS: Mention new -complete command.
10121
10122 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
10123
10124         * completer.h (complete): New function.
10125         * completer.c (complete): Likewise.
10126         * cli/cli-cmds.c: (complete_command): Update to use new complete()
10127         function defined in completer.h.
10128
10129 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
10130
10131         * MAINTAINERS (Write After Approval): Add myself.
10132
10133 2019-05-17  Tom de Vries  <tdevries@suse.de>
10134
10135         PR gdb/24094
10136         * dwarf2read.c (struct cu_partial_die_info): New struct.
10137         (find_partial_die): Return cu_partial_die_info.
10138         (partial_die_parent_scope, guess_partial_die_structure_name)
10139         (partial_die_info::fixup): Handle new return type of find_partial_die.
10140
10141 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10142
10143         PR breakpoints/24541
10144         * stap-probe.c (stap_parse_register_operand): Make "regname" an
10145         "std::string", simplifying the algorithm.
10146
10147 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10148
10149         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10150         (stap_static_probe_ops::get_probes): Likewise.
10151
10152 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10153
10154         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10155         '-')" and "else if".
10156         (stap_parse_single_operand): Join checks for
10157         "gdbarch_stap_parse_special_token_p" and
10158         "gdbarch_stap_parse_special_token" in the same "if" statement.
10159         Invert check when verifying for operation on register
10160         displacement.
10161
10162 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10163
10164         * stap-probe.c (stap_get_opcode): Update comment.
10165         (stap_get_expected_argument_type): Likewise.
10166         (handle_stap_probe): Likewise.
10167
10168 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10169
10170         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10171         return type to 'bool'.  Adjust comment.  Use 'bool' when
10172         appropriate.
10173         (i386_stap_parse_special_token_three_arg_disp): Likewise.
10174         * stap-probe.c (stap_parse_argument_1): Likewise.
10175         (stap_is_operator): Likewise.
10176         (stap_is_generic_prefix): Likewise.
10177         (stap_is_register_prefix): Likewise.
10178         (stap_is_register_indirection_prefix): Likewise.
10179         (stap_is_integer_prefix): Likewise.
10180         (stap_generic_check_suffix): Likewise.
10181         (stap_check_integer_suffix): Likewise.
10182         (stap_check_register_suffix): Likewise.
10183         (stap_check_register_indirection_suffix): Likewise.
10184         (stap_parse_register_operand): Likewise.
10185         (stap_parse_single_operand): Likewise.
10186         (stap_parse_argument_1): Likewise.
10187         (stap_probe::get_argument_count): Likewise.
10188         (stap_is_operator): Likewise.
10189
10190 2019-05-16  Tom Tromey  <tromey@adacore.com>
10191
10192         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10193         keyword to foreach.
10194
10195 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
10196
10197         * linux-thread-db.c (try_thread_db_load_1): Change return type
10198         to bool.
10199         (try_thread_db_load): Likewise.
10200         (try_thread_db_load_from_pdir_1): Likewise.
10201         (try_thread_db_load_from_pdir): Likewise.
10202         (try_thread_db_load_from_sdir): Likewise.
10203         (try_thread_db_load_from_dir): Likewise.
10204         (thread_db_load_search): Likewise.
10205         (has_libpthread): Likewise.
10206         (thread_db_load): Likewise.
10207
10208 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
10209
10210         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10211         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10212         NULL, and complain/return if that's the case.
10213
10214 2019-05-15  John Darrington <john@darrington.wattle.id.au>
10215
10216         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10217         (advance, posn, abstract_read_memory): New functions.
10218         [struct mem_read_abstraction]: New struct.
10219         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10220
10221 2019-05-14  Tom Tromey  <tromey@adacore.com>
10222
10223         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10224         value is not lval_memory.
10225
10226 2019-05-14  Tom Tromey  <tromey@adacore.com>
10227
10228         * solib.c (info_sharedlibrary_command): Style the file name.
10229
10230 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
10231
10232         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10233         (aarch64_vnv_type): Likewise.
10234         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10235         * common/tdesc.c: Likewise.
10236         * common/tdesc.h (enum tdesc_type_kind): Likewise.
10237         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10238         * features/aarch64-fpu.xml: Add ieee half view.
10239         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10240         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10241         * gdbtypes.h (struct builtin_type): Likewise.
10242         (struct objfile_type): Likewise.
10243
10244 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
10245
10246         * language.c (language_sniff_from_mangled_name): Fix "langauge"
10247         typo.
10248         * location.h (string_to_event_location): Likewise.
10249
10250 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
10251
10252         GDB 8.3 released.
10253
10254 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10255
10256         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10257         New variable declaration.
10258         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10259         New variable.
10260         (print_one_breakpoint): Use ui_out::test_flags and new global
10261         variable to compute use_fixed_output.
10262         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10263         Remove.
10264         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10265         (mi_multi_location_breakpoint_output_fixed): Remove.
10266         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10267         new variable.
10268         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10269         fix_multi_location_breakpoint_output flag if version >= 3.
10270         * ui-out.h (enum ui_out_flag)
10271         <fix_multi_location_breakpoint_output>: New enumerator.
10272
10273 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10274
10275         * contrib/cc-with-tweaks.sh: Validate dwz's work.
10276
10277 2019-05-10  Tom Tromey  <tromey@adacore.com>
10278
10279         * ada-lang.c (catch_ada_completer): New function.
10280         (_initialize_ada_language): Use it.
10281
10282 2019-05-10  Tom Tromey  <tromey@adacore.com>
10283
10284         * thread.c (print_thread_info): Make "requested_threads" const.
10285         * gdbthread.h (print_thread_info): Make "requested_threads"
10286         const.
10287         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10288         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10289
10290 2019-05-08  Tom Tromey  <tom@tromey.com>
10291
10292         * gdbtypes.c (objfile_type_data): Change type.
10293         (objfile_type, _initialize_gdbtypes): Update.
10294
10295 2019-05-08  Tom Tromey  <tom@tromey.com>
10296
10297         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10298         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10299         (_initialize_dwarf2_frame): Update.
10300
10301 2019-05-08  Tom Tromey  <tom@tromey.com>
10302
10303         * objc-lang.c (objc_objfile_data): Change type.
10304         (find_methods): Update.
10305         (_initialize_objc_lang): Remove.
10306
10307 2019-05-08  Tom Tromey  <tom@tromey.com>
10308
10309         * stabsread.c (rs6000_builtin_type_data): Change type.
10310         (rs6000_builtin_type, _initialize_stabsread): Update.
10311
10312 2019-05-08  Tom Tromey  <tom@tromey.com>
10313
10314         * mips-tdep.c (mips_pdr_data): Remove.
10315         (_initialize_mips_tdep): Update.
10316
10317 2019-05-08  Tom Tromey  <tom@tromey.com>
10318
10319         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10320         (hppa_init_objfile_priv_data, read_unwind_info)
10321         (find_unwind_entry, _initialize_hppa_tdep): Update.
10322
10323 2019-05-08  Tom Tromey  <tom@tromey.com>
10324
10325         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10326         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
10327         on obstack.
10328         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10329
10330 2019-05-08  Tom Tromey  <tom@tromey.com>
10331
10332         * mdebugread.c (basic_type_data): Change type.
10333         (basic_type, _initialize_mdebugread): Update.
10334
10335 2019-05-08  Tom Tromey  <tom@tromey.com>
10336
10337         * common/gdb_unique_ptr.h (struct noop_deleter): New.
10338
10339 2019-05-08  Tom Tromey  <tom@tromey.com>
10340
10341         * nto-tdep.c (nto_inferior_data_reg): Change type.
10342         (nto_inferior_data): Update.
10343         (nto_inferior_data_cleanup, nto_new_inferior_data)
10344         (_initialize_nto_tdep): Remove.
10345         * nto-tdep.h (struct nto_inferior_data): Add initializers.
10346
10347 2019-05-08  Tom Tromey  <tom@tromey.com>
10348
10349         * ada-lang.c (struct ada_inferior_data): Add initializers.
10350         (ada_inferior_data): Change type.
10351         (ada_inferior_data_cleanup): Remove.
10352         (get_ada_inferior_data, ada_inferior_exit)
10353         (struct ada_pspace_data): Add initializers, destructor.
10354         (ada_pspace_data_handle): Change type.
10355         (get_ada_pspace_data): Update.
10356         (ada_pspace_data_cleanup): Remove.
10357
10358 2019-05-08  Tom Tromey  <tom@tromey.com>
10359
10360         * coffread.c (struct coff_symfile_info): Add initializers.
10361         (coff_objfile_data_key): Move lower.  Change type.
10362         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10363         Update.
10364         (coff_free_info): Remove.
10365
10366 2019-05-08  Tom Tromey  <tom@tromey.com>
10367
10368         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10369         (fbsd_pspace_data_handle): Move lower.  Change type.
10370         (get_fbsd_pspace_data): Update.
10371         (fbsd_pspace_data_cleanup): Remove.
10372         (_initialize_fbsd_tdep): Update.
10373
10374 2019-05-08  Tom Tromey  <tom@tromey.com>
10375
10376         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10377         (get_ada_tasks_pspace_data): Update.
10378         (ada_tasks_pspace_data_cleanup): Remove.
10379         (_initialize_tasks): Update.
10380         (ada_tasks_inferior_data_handle): Change type.
10381         (get_ada_tasks_inferior_data): Update.
10382         (ada_tasks_inferior_data_cleanup): Remove.
10383         (struct ada_tasks_pspace_data): Add initializers.
10384
10385 2019-05-08  Tom Tromey  <tom@tromey.com>
10386
10387         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10388         * symfile-debug.c (debug_sym_get_probes): Change type.
10389         * stap-probe.c (handle_stap_probe):
10390         (stap_static_probe_ops::get_probes): Change type.
10391         * probe.h (class static_probe_ops) <get_probes>: Change type.
10392         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10393         (parse_probes_in_pspace): Update.
10394         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10395         Update.
10396         (any_static_probe_ops::get_probes): Change type.
10397         * elfread.c (elfread_data): New typedef.
10398         (probe_key): Change type.
10399         (elf_get_probes): Likewise.  Update.
10400         (probe_key_free): Remove.
10401         (_initialize_elfread): Update.
10402         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10403         Change type.
10404         (dtrace_process_dof_probe, dtrace_process_dof)
10405         (dtrace_static_probe_ops::get_probe): Change type.
10406
10407 2019-05-08  Tom Tromey  <tom@tromey.com>
10408
10409         * xcoffread.c (struct xcoff_symfile_info): Rename from
10410         coff_symfile_info.  Add initializers.
10411         (xcoff_objfile_data_key): Move lower.  Change type.
10412         (XCOFF_DATA): Rewrite.
10413         (xcoff_free_info): Remove.
10414         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10415         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10416         (xcoff_initial_scan): Update.
10417
10418 2019-05-08  Tom Tromey  <tom@tromey.com>
10419
10420         * solib-svr4.c (struct svr4_info): Add initializers and
10421         destructor.
10422         <probes_table>: Now an htab_up.
10423         (solib_svr4_pspace_data): Change type.
10424         (free_probes_table): Simplify.
10425         (~svr4_info): Rename from svr4_pspace_data_cleanup.
10426         (get_svr4_info, probes_table_htab_remove_objfile_probes)
10427         (probes_table_remove_objfile_probes, register_solib_event_probe)
10428         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10429         (_initialize_svr4_solib): Update.
10430
10431 2019-05-08  Tom Tromey  <tom@tromey.com>
10432
10433         * remote.c (remote_pspace_data): Change type.
10434         (remote_pspace_data_cleanup): Remove.
10435         (get_remote_exec_file, set_pspace_remote_exec_file)
10436         (_initialize_remote): Update.
10437
10438 2019-05-08  Tom Tromey  <tom@tromey.com>
10439
10440         * breakpoint.c (breakpoint_objfile_key): Change type.
10441         (get_breakpoint_objfile_data): Update.
10442         (free_breakpoint_objfile_data): Remove.
10443         (_initialize_breakpoint): Update.
10444
10445 2019-05-08  Tom Tromey  <tom@tromey.com>
10446
10447         * linux-tdep.c (struct linux_info): Add initializers.
10448         (linux_inferior_data): Move.  Change type.
10449         (invalidate_linux_cache_inf): Update.
10450         (linux_inferior_data_cleanup): Remove.
10451         (get_linux_inferior_data, _initialize_linux_tdep): Update.
10452
10453 2019-05-08  Tom Tromey  <tom@tromey.com>
10454
10455         * auxv.c (auxv_inferior_data): Move.  Change type.
10456         (auxv_inferior_data_cleanup): Remove.
10457         (invalidate_auxv_cache_inf): Rewrite.
10458         (get_auxv_inferior_data, _initialize_auxv): Update.
10459
10460 2019-05-08  Tom Tromey  <tom@tromey.com>
10461
10462         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10463         (symfile_debug_objfile_data_key): Change type.
10464         (symfile_debug_installed, debug_qf_has_symbols)
10465         (debug_qf_find_last_source_symtab)
10466         (debug_qf_forget_cached_source_info)
10467         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10468         (debug_qf_print_stats, debug_qf_dump)
10469         (debug_qf_expand_symtabs_for_function)
10470         (debug_qf_expand_all_symtabs)
10471         (debug_qf_expand_symtabs_with_fullname)
10472         (debug_qf_map_matching_symbols)
10473         (debug_qf_expand_symtabs_matching)
10474         (debug_qf_find_pc_sect_compunit_symtab)
10475         (debug_qf_map_symbol_filenames)
10476         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10477         (debug_sym_new_init, debug_sym_init, debug_sym_read)
10478         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10479         (debug_sym_read_linetable, debug_sym_relocate): Update.
10480         (symfile_debug_free_objfile): Remove.
10481         (install_symfile_debug_logging, _initialize_symfile_debug):
10482         Update.
10483
10484 2019-05-08  Tom Tromey  <tom@tromey.com>
10485
10486         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10487         allocate_on_obstack.
10488         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10489         (get_dwarf2_per_objfile): Update.
10490         (set_dwarf2_per_objfile): Remove.
10491         (dwarf2_has_info, dwarf2_get_section_info): Update.
10492         (dwarf2_free_objfile): Remove.
10493         (_initialize_dwarf2_read): Update.
10494
10495 2019-05-08  Tom Tromey  <tom@tromey.com>
10496
10497         * auto-load.c (struct auto_load_pspace_info): Add destructor and
10498         initializers.
10499         <unsupported_script_warning_printed,
10500         script_not_found_warning_printed>: Now bool.
10501         (auto_load_pspace_data): Change type.
10502         (~auto_load_pspace_info): Rename from
10503         auto_load_pspace_data_cleanup.
10504         (get_auto_load_pspace_data, init_loaded_scripts_info)
10505         (clear_section_scripts, maybe_print_unsupported_script_warning)
10506         (maybe_print_script_not_found_warning, _initialize_auto_load):
10507         Update.
10508
10509 2019-05-08  Tom Tromey  <tom@tromey.com>
10510
10511         * objfiles.c (objfile_pspace_info): Add destructor and
10512         initializers.
10513         (objfiles_pspace_data): Change type.
10514         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10515         (get_objfile_pspace_data): Update.
10516         (objfiles_bfd_data): Change type.
10517         (get_objfile_bfd_data): Update.
10518         (objfile_bfd_data_free, _initialize_objfiles): Remove.
10519
10520 2019-05-08  Tom Tromey  <tom@tromey.com>
10521
10522         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10523         Change type.
10524         (get_catch_syscall_inferior_data): Update.
10525         (catch_syscall_inferior_data_cleanup): Remove.
10526         (_initialize_break_catch_syscall): Update.
10527
10528 2019-05-08  Tom Tromey  <tom@tromey.com>
10529
10530         * inflow.c (struct terminal_info): Add destructor and
10531         initializers.
10532         (inflow_inferior_data): Change type.
10533         (~terminal_info): Rename from inflow_inferior_data_cleanup.
10534         (get_inflow_inferior_data, inflow_inferior_exit)
10535         (swap_terminal_info, _initialize_inflow): Update.
10536
10537 2019-05-08  Tom Tromey  <tom@tromey.com>
10538
10539         * target-dcache.c (target_dcache_cleanup): Remove.
10540         (target_dcache_aspace_key): Change type.
10541         (target_dcache_init_p, target_dcache_invalidate)
10542         (target_dcache_get, target_dcache_get_or_init)
10543         (_initialize_target_dcache): Update.
10544         * dcache.h (struct dcache_deleter): New.
10545
10546 2019-05-08  Tom Tromey  <tom@tromey.com>
10547
10548         * symtab.c (struct symbol_cache): Add destructor and
10549         initializers.
10550         (symbol_cache_key): Move.  Change type.
10551         (make_symbol_cache, free_symbol_cache): Remove.
10552         (get_symbol_cache): Update.
10553         (symbol_cache_cleanup): Remove.
10554         (ALL_PSPACES, symbol_cache_flush)
10555         (maintenance_print_symbol_cache)
10556         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10557         Update.
10558
10559 2019-05-08  Tom Tromey  <tom@tromey.com>
10560
10561         * symtab.c (struct main_info): Add destructor and initializers.
10562         (main_progspace_key): Move.  Change type.
10563         (get_main_info): Update.
10564         (main_info_cleanup): Remove.
10565         (_initialize_symtab): Update.
10566
10567 2019-05-08  Tom Tromey  <tom@tromey.com>
10568
10569         * registry.h (DECLARE_REGISTRY): Define the _key class.
10570
10571 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10572
10573         * NEWS: Merge two 'New commands' sections.
10574
10575 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
10576
10577         * ada-valprint.c (ada_val_print_gnat_array): Remove language
10578         parameter and use Ada language definition instead.
10579         (ada_val_print_ptr): Remove unused language parameter.
10580         (ada_val_print_num): Remove language parameter and use Ada language
10581         definition instead.
10582         (ada_val_print_enum, ada_val_print_flt): Remove unused language
10583         parameter.
10584         (ada_val_print_struct_union, ada_val_print_ref): Remove language
10585         parameter and use Ada language definition instead.
10586         (ada_val_print_1): Update all ada_val_print_xxx calls.
10587         Remove language parameter.
10588         (ada_val_print): Update ada_val_print_1 call.
10589
10590 2019-05-08  Tom Tromey  <tromey@adacore.com>
10591
10592         * remote.c (remote_hw_watchpoint_limit)
10593         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10594         Now static.
10595
10596 2019-05-08  Tom Tromey  <tromey@adacore.com>
10597
10598         * maint.c (_initialize_maint_cmds): Move initialization code to
10599         remote.c.
10600         (watchdog, show_watchdog): Move to remote.c.
10601         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
10602         "watchdog" static.
10603         (_initialize_remote): Move initialization code from maint.c.
10604         * defs.h (watchdog): Don't declare.
10605
10606 2019-05-08  Tom Tromey  <tromey@adacore.com>
10607
10608         * tui/tui-interp.c: Include main.h.
10609         * interps.c: Include main.h.
10610         * main.h (interpreter_p): Declare.
10611         * defs.h (interpreter_p): Don't declare.
10612
10613 2019-05-08  Tom Tromey  <tromey@adacore.com>
10614
10615         * dwarf2loc.c: Include dwarf2read.h.
10616         * defs.h (read_unsigned_leb128): Don't declare.
10617         * dwarf2read.h (read_unsigned_leb128): Declare.
10618
10619 2019-05-08  Tom Tromey  <tromey@adacore.com>
10620
10621         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10622         method.
10623
10624 2019-05-08  Tom Tromey  <tromey@adacore.com>
10625
10626         * utils.c (fputs_maybe_filtered): Reset style after paging, even
10627         when no wrap column is set.
10628
10629 2019-05-08  Tom Tromey  <tromey@adacore.com>
10630
10631         * c-lang.c (c_get_string): Handle non-C-style arrays.
10632
10633 2019-05-08  Tom Tromey  <tromey@adacore.com>
10634
10635         * typeprint.c (print_offset_data::update): Print the bit offset,
10636         not the number of bits remaining.
10637
10638 2019-05-08  Tom Tromey  <tromey@adacore.com>
10639
10640         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10641         padding at end of comment.
10642
10643 2019-05-08  Tom Tromey  <tromey@adacore.com>
10644
10645         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10646         Compare main types.
10647
10648 2019-05-06  Tom Tromey  <tom@tromey.com>
10649
10650         * common/scoped_mmap.c: Include common-defs.h.
10651         * common/scoped_mmap.h: Don't include config.h.
10652
10653 2019-05-04  Tom Tromey  <tom@tromey.com>
10654
10655         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10656         (struct aarch64_call_info): Add initializers.
10657         <si>: Now a std::vector.
10658         (pass_on_stack, aarch64_push_dummy_call): Update.
10659
10660 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
10661             Tom Tromey  <tom@tromey.com>
10662
10663         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10664         (ppc_threads): Now a std::vector.  Now static.
10665         (hwdebug_find_thread_points_by_tid)
10666         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10667         Update.
10668
10669 2019-05-04  Tom Tromey  <tom@tromey.com>
10670
10671         * arc-tdep.c (arc_tdesc_init): Return bool.
10672
10673 2019-05-04  Tom Tromey  <tom@tromey.com>
10674
10675         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10676         Use gdb_assert_not_reached.
10677
10678 2019-05-04  Tom Tromey  <tom@tromey.com>
10679
10680         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10681         "false".
10682
10683 2019-05-04  Tom Tromey  <tom@tromey.com>
10684
10685         * arc-tdep.c (arc_tdesc_init): Use bool.
10686
10687 2019-05-04  Tom Tromey  <tom@tromey.com>
10688
10689         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10690
10691 2019-05-04  Tom Tromey  <tom@tromey.com>
10692
10693         * cli/cli-cmds.c (valid_command_p): Return bool.
10694
10695 2019-05-04  Tom Tromey  <tom@tromey.com>
10696
10697         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10698         * command.h (valid_user_defined_cmd_name_p): Channge return type.
10699
10700 2019-05-04  Raul Tambre  <raul@tambre.ee>
10701
10702         * python/lib/gdb/prompt.py (_ExtendedPrompt)
10703         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10704         operator for comparison.
10705
10706 2019-05-04  Tom Tromey  <tom@tromey.com>
10707
10708         * psymtab.c (psymbol_name_matches, match_partial_symbol)
10709         (lookup_partial_symbol, print_partial_symbols)
10710         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10711         (psymbol_compare): Update.
10712         (add_psymbol_to_bcache): Clear the entire psymbol.
10713         (maintenance_check_psymtabs): Update.
10714         * psympriv.h (struct partial_symbol): Don't derive from
10715         general_symbol_info.
10716         <obj_section, unrelocated_address, address,
10717         set_unrelocated_address>: Update.
10718         <ginfo>: New member.
10719         * dwarf-index-write.c (write_psymbols, debug_names::insert)
10720         (debug_names::write_psymbols): Update.
10721
10722 2019-05-04  Tom de Vries  <tdevries@suse.de>
10723
10724         * contrib/cc-with-tweaks.sh: Support -n arg.
10725
10726 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10727
10728         * corelow.c (core_target::detach): Ensure frame cache and
10729         register caches are cleared.
10730         inferior.c (exit_inferior_1): Likewise.
10731
10732 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
10733             Tom Tromey  <tom@tromey.com>
10734
10735         * dictionary.c (collate_pending_symbols_by_language): Remove
10736         "struct" from foreach.
10737         * symtab.c (lookup_global_symbol_from_objfile)
10738         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10739         foreach.
10740         * ser-tcp.c (net_open): Remove "struct" from foreach.
10741         * objfiles.c (objfile_relocate, objfile_rebase)
10742         (objfile_has_symbols): Remove "struct" from foreach.
10743         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10744         from foreach.
10745         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10746         foreach.
10747         * darwin-nat.c (thread_info_from_private_thread_info): Remove
10748         "struct" from foreach.
10749         * ada-lang.c (create_excep_cond_exprs)
10750         (ada_exception_catchpoint_cond_string): Remove "struct" from
10751         foreach.
10752
10753 2019-05-03  Tom Tromey  <tromey@adacore.com>
10754
10755         * ada-exp.y (convert_char_literal): Check suffix of each
10756         enumerator.
10757
10758 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
10759
10760         PR ada/21406:
10761         * ada-exp.y (yywrap): Don't define.
10762         * ada-lex.l (%option): Add noyywrap
10763         (yywrap): Remove.
10764
10765 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
10766
10767         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10768         _WIN32_WINNT to the XP level, unless already defined to a higher
10769         level.
10770
10771         * unittests/parse-connection-spec-selftests.c:
10772         * ser-tcp.c:
10773         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
10774         override.
10775
10776         * symfile.c (find_separate_debug_file): Remove colon from the
10777         drive spec of DOS/Windows file names of the target, so that the
10778         file name produced from DEBUGDIR and the target's directory will
10779         be valid on DOS/Windows systems.
10780
10781 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
10782
10783         * rust-lang.c (val_print_struct): Handle printing structures
10784         containing strings.
10785
10786 2019-05-02  Tom Tromey  <tromey@adacore.com>
10787
10788         * valarith.c (_initialize_valarith): Remove.
10789
10790 2019-05-01  Tom Tromey  <tromey@adacore.com>
10791
10792         * ada-lang.c (ada_value_primitive_field): Treat more fields as
10793         bitfields.
10794
10795 2019-05-01  Tom Tromey  <tromey@adacore.com>
10796
10797         * ada-lang.c (ada_value_assign): Correctly compute starting offset
10798         for big-endian copies.
10799
10800 2019-04-30  Ali Tamur  <tamur@google.com>
10801         * gdb/dwarf2read.c (read_3_bytes): New declaration.
10802         (read_attribute_value): Added DW_FORM_strx1-4 cases.
10803         (read_3_bytes): New function.
10804
10805 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10806
10807         * windows-nat.c (main_thread_id): Delete.
10808         (handle_output_debug_string): Replace main_thread_id by
10809         current_event.dwThreadId.
10810         (fake_create_process): Likewise.
10811         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10812         Do not set main_thread_id.
10813         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10814         current_event.dwThreadId.
10815         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10816
10817 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10818
10819         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10820         Use current_event.dwThreadId instead of main_thread_id.
10821
10822 2019-04-30  Tom Tromey  <tromey@adacore.com>
10823
10824         * ada-lang.c (ada_lookup_simple_minsyms): New function.
10825         (create_excep_cond_exprs): Iterate over program spaces.
10826         (ada_exception_catchpoint_cond_string): Examine all minimal
10827         symbols for exception types.
10828
10829 2019-04-30  Tom Tromey  <tromey@adacore.com>
10830
10831         PR c++/24470:
10832         * dwarf2read.c (process_structure_scope): Handle case where type
10833         has template parameters but no symbol was created.
10834
10835 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10836             Chris January  <chris.january@arm.com>
10837
10838         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10839         qualifier.
10840         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10841
10842 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10843
10844         * f-typeprint.c (f_print_type): Update rules for printing
10845         whitespace.
10846         (f_type_print_varspec_suffix): Likewise.
10847
10848 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10849             Chris January  <chris.january@arm.com>
10850
10851         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10852         function arguments.
10853
10854 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10855
10856         * f-lang.c (build_fortran_types): Change name of void type to
10857         lower case.
10858         * f-typeprint.c (f_type_print_base): Print the name of the void
10859         type, rather than a fixed string.
10860         * f-valprint.c (f_decorations): Use lower case void string.
10861
10862 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10863             Chris January  <chris.january@arm.com>
10864
10865         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10866         types for Fortran.
10867
10868 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10869             Chris January  <chris.january@arm.com>
10870             David Lecomber  <david.lecomber@arm.com>
10871
10872         * f-exp.y (BINOP_INTRINSIC): New token.
10873         (exp): New parser rule handling BINOP_INTRINSIC.
10874         (f77_keywords): Add new builtin procedures.
10875         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10876         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10877         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10878         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10879         (print_unop_subexp_f): New function.
10880         (print_binop_subexp_f): New function.
10881         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10882         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10883         (dump_subexp_body_f): Likewise.
10884         (operator_check_f): Likewise.
10885         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10886         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10887
10888 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10889
10890         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10891         UNOP_KIND.
10892         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10893         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10894         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10895         (operator_length_f): New fuction.
10896         (print_subexp_f): New function.
10897         (op_name_f): New function.
10898         (dump_subexp_body_f): New function.
10899         (operator_check_f): New function.
10900         (exp_descriptor_f): Replace standard expression handling functions
10901         with new functions.
10902         * gdb/fortran-operator.def: New file.
10903         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10904         * gdb/std-operator.def: Remove UNOP_KIND.
10905
10906 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10907
10908         * std-operator.def: Remove unbalanced, stray double quote
10909         character.
10910
10911 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10912             Chris January  <chris.january@arm.com>
10913             Daniel Everett  <daniel.everett@arm.com>
10914             Nick Forrington  <nick.forrington@arm.com>
10915             Richard Bunt  <richard.bunt@arm.com>
10916
10917         * cp-valprint.c (cp_print_value_fields): Allow an additional level
10918         of depth when printing anonymous structs or unions.
10919         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10920         Don't print either the top-level value, or the children if the
10921         max-depth is exceeded.
10922         (ppscm_print_children): When printing the key of a map, allow one
10923         extra level of depth.
10924         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10925         print either the top-level value, or the children if the max-depth
10926         is exceeded.
10927         (print_children): When printing the key of a map, allow one extra
10928         level of depth.
10929         * python/py-value.c (valpy_format_string): Add max_depth keyword.
10930         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10931         (user_print_options): Initialise max_depth field.
10932         (val_print_scalar_or_string_type_p): New function.
10933         (val_print): Check to see if the max depth has been reached.
10934         (val_print_check_max_depth): Define new function.
10935         (show_print_max_depth): New function.
10936         (_initialize_valprint): Add 'print max-depth' option.
10937         * valprint.h (struct value_print_options) <max_depth>: New field.
10938         (val_print_check_max_depth): Declare new function.
10939         * NEWS: Document new feature.
10940
10941 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10942
10943         * ada-lang.c (ada_language_defn): Initialise new field.
10944         * c-lang.c (c_is_string_type_p): New function.
10945         (c_language_defn): Initialise new field.
10946         (cplus_language_defn): Initialise new field.
10947         (asm_language_defn): Initialise new field.
10948         (minimal_language_defn): Initialise new field.
10949         * c-lang.h (c_is_string_type_p): Declare new function.
10950         * d-lang.c (d_language_defn): Initialise new field.
10951         * f-lang.c (f_is_string_type_p): New function.
10952         (f_language_defn): Initialise new field.
10953         * go-lang.c (go_is_string_type_p): New function.
10954         (go_language_defn): Initialise new field.
10955         * language.c (default_is_string_type_p): New function.
10956         (unknown_language_defn): Initialise new field.
10957         (auto_language_defn): Initialise new field.
10958         * language.h (struct language_defn) <la_is_string_type_p>: New
10959         member variable.
10960         (default_is_string_type_p): Declare new function.
10961         * m2-lang.c (m2_language_defn): Initialise new field.
10962         * objc-lang.c (objc_language_defn): Initialise new field.
10963         * opencl-lang.c (opencl_language_defn): Initialise new field.
10964         * p-lang.c (pascal_is_string_type_p): New function.
10965         (pascal_language_defn): Initialise new field.
10966         * rust-lang.c (rust_is_string_type_p): New function.
10967         (rust_language_defn): Initialise new field.
10968
10969 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10970
10971         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10972         New field.
10973         * ada-lang.c (ada_language_defn): Initialise new field.
10974         * c-lang.c (c_language_defn): Likewise.
10975         (cplus_language_defn): Likewise.
10976         (asm_language_defn): Likewise.
10977         (minimal_language_defn): Likewise.
10978         * d-lang.c (d_language_defn): Likewise.
10979         * f-lang.c (f_language_defn): Likewise.
10980         * go-lang.c (go_language_defn): Likewise.
10981         * language.c (unknown_language_defn): Likewise.
10982         (auto_language_defn): Likewise.
10983         * m2-lang.c (m2_language_defn): Likewise.
10984         * objc-lang.c (objc_language_defn): Likewise.
10985         * opencl-lang.c (opencl_language_defn): Likewise.
10986         * p-lang.c (pascal_language_defn): Likewise.
10987         * rust-lang.c (rust_language_defn): Likewise.
10988
10989 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10990
10991         * ada-lang.c (ada_is_character_type): Change return type to bool.
10992         (ada_is_string_type): Likewise.
10993         * ada-lang.h (ada_is_character_type): Update declaration
10994         (ada_is_string_type): Likewise.
10995
10996 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10997
10998         Support style in 'frame|thread apply'
10999
11000         * gdbcmd.h (execute_command_to_string): New term_out parameter.
11001         * record.c (record_start, record_stop): Update callers of
11002         execute_command_to_string with false.
11003         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
11004         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
11005         methods.
11006         (class string_file): New constructor with term_out parameter.
11007         Override methods term_out and can_emit_style_escape.  New member
11008         term_out.
11009         (class stdio_file): Override can_emit_style_escape.
11010         (class tee_file): Override term_out and can_emit_style_escape.
11011         * utils.h (can_emit_style_escape): Remove.
11012         * utils.c (can_emit_style_escape): Likewise.
11013         Update all callers of can_emit_style_escape (SOMESTREAM) to
11014         SOMESTREAM->can_emit_style_escape.
11015         * source-cache.c (source_cache::get_source_lines): Likewise.
11016         * stack.c (frame_apply_command_count): Call execute_command_to_string
11017         passing the term_out characteristic of the current gdb_stdout.
11018         * thread.c (thr_try_catch_cmd): Likewise.
11019         * top.c (execute_command_to_string): pass term_out parameter
11020         to construct the string_file for the command output.
11021         * ui-file.c (term_cli_styling): New function (most code moved
11022         from utils.c can_emit_style_escape).
11023         (string_file::string_file, string_file::can_emit_style_escape,
11024         stdio_file::can_emit_style_escape, tee_file::term_out,
11025         tee_file::can_emit_style_escape): New functions.
11026
11027 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11028
11029         * NEWS: Mention the new set|show may-call-functions.
11030         * infcall.c (may_call_functions_p): New variable.
11031         (show_may_call_functions_p): New function.
11032         (call_function_by_hand_dummy): Throws an error if not
11033         may-call-functions.
11034         (_initialize_infcall): Call add_setshow_boolean_cmd for
11035         may-call-functions.
11036
11037 2019-04-25  Keith Seitz  <keiths@redhat.com>
11038
11039         PR c++/24367
11040         * cp-support.c (inspect_type): Don't attempt substitutions
11041         of symbol with the same name.
11042
11043 2019-04-25  Tom Tromey  <tromey@adacore.com>
11044
11045         PR gdb/24475:
11046         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
11047         static.
11048
11049 2019-04-25  Tom Tromey  <tromey@adacore.com>
11050
11051         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11052         rvalue reference.
11053         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11054         (gdb_xml_parser::parse): Use std::move.
11055         * python/python-internal.h (gdbpy_convert_exception): Take a const
11056         reference.
11057         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11058         std::move.
11059         * python/py-utils.c (gdbpy_convert_exception): Take a const
11060         reference.
11061         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11062         Use std::move.
11063         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11064         Use std::move.
11065         * mi/mi-main.c (mi_print_exception): Take a const reference.
11066         * main.c (handle_command_errors): Take a const reference.
11067         * linespec.c (parse_linespec): Use std::move.
11068         * infcall.c (run_inferior_call): Use std::move.
11069         (call_function_by_hand_dummy): Use std::move.
11070         * exec.c (try_open_exec_file): Use std::move.
11071         * exceptions.h (exception_print, exception_fprintf)
11072         (exception_print_same): Update.
11073         * exceptions.c (print_exception, exception_print)
11074         (exception_fprintf, exception_print_same): Change parameters to
11075         const reference.
11076         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11077         * common/new-op.c: Use std::move.
11078         * common/common-exceptions.h (struct gdb_exception): Add move
11079         constructor.
11080         (struct gdb_exception_error, struct gdb_exception_quit, struct
11081         gdb_quit_bad_alloc): Change constructor to move constructor.
11082         (throw_exception): Change parameter to rvalue reference.
11083         * common/common-exceptions.c (throw_exception): Take rvalue
11084         reference.
11085         * cli/cli-interp.c (safe_execute_command): Use std::move.
11086         * breakpoint.c (insert_bp_location, location_to_sals): Use
11087         std::move.
11088
11089 2019-04-25  Tom Tromey  <tromey@adacore.com>
11090
11091         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11092         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11093         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11094         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11095         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11096         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11097         guile/scm-value.c: Use unpack.
11098         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11099         gdbscm_gdb_exception.
11100         (gdbscm_throw_gdb_exception): Likewise.
11101         (struct gdbscm_gdb_exception): New.
11102         (unpack): New function.
11103         (gdbscm_wrap): Use unpack.
11104
11105 2019-04-25  Tom Tromey  <tromey@adacore.com>
11106
11107         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11108         (gdb_rl_callback_handler): Use std::move.
11109         * common/common-exceptions.h (struct gdb_exception): Add move
11110         assignment operator.
11111         (throw_exception_sjlj): Change "exception" to const reference.
11112         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11113         (throw_exception_sjlj): Change "exception" to const reference.
11114
11115 2019-04-25  Tom Tromey  <tromey@adacore.com>
11116
11117         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11118         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11119         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11120         Update.
11121         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11122         Update.
11123         * mi/mi-interp.c (mi_interp::exec): Update.
11124         * linespec.c (parse_linespec): Update.
11125         * infcall.c (run_inferior_call): Update.
11126         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11127         * guile/scm-symbol.c (gdbscm_lookup_symbol)
11128         (gdbscm_lookup_global_symbol): Update.
11129         * guile/scm-param.c (gdbscm_parameter_value): Update.
11130         * guile/scm-frame.c (gdbscm_frame_read_register)
11131         (gdbscm_frame_read_var): Update.
11132         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11133         * exec.c (try_open_exec_file): Update.
11134         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11135         (gdb_rl_callback_handler): Update.
11136         * common/common-exceptions.h (exception_none): Don't declare.
11137         * common/common-exceptions.c (exception_none): Don't define.
11138         (struct catcher) <exception>: Update.
11139         * cli/cli-interp.c (safe_execute_command): Update.
11140         * breakpoint.c (insert_bp_location, location_to_sals): Update.
11141
11142 2019-04-25  Ali Tamur  <tamur@google.com>
11143
11144         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11145         (read_attribute_value): Likewise.
11146         (dwarf2_read_addr_index): Update comment.
11147         (read_str_index): Add DW_FORM_strx.
11148         (dwarf2_string_attr): Likewise.
11149         (dwarf2_const_value_attr): Likewise.
11150         (dump_die_shallow): Likewise.
11151         (dwarf2_fetch_constant_bytes): Likewise.
11152         (skip_form_bytes): Likewise.
11153         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11154
11155 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
11156
11157         PR corefiles/11608
11158         PR corefiles/18187
11159         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11160         OFFSET.  Verify if current mapping contains an ELF header.
11161         (linux_find_memory_regions_full): Adjust call to
11162         dump_mapping_p.
11163
11164 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
11165             Kang Li <kanglictf@gmail.com>
11166
11167         PR gdb/21600
11168
11169         * dwarf2-frame.c (read_initial_length): Be consistent about using
11170         unsigned representation of length.
11171         (decode_frame_entry_1): Likewise.  Check for wraparound of
11172         end pointer as well as buffer overflow.
11173
11174 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
11175
11176         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11177         "vq".
11178
11179 2019-04-24  Tom Tromey  <tromey@adacore.com>
11180
11181         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11182
11183 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11184
11185         * s12z-tdep.c (s12z_unwind_pc): Delete.
11186         (s12z_unwind_sp): Delete.
11187         (s12z_gdbarch_init): Don't register deleted functions with
11188         gdbarch.
11189
11190 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11191
11192         * rl78-tdep.c (rl78_unwind_sp): Delete.
11193         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11194
11195 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11196
11197         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11198         (xstormy16_unwind_pc): Delete.
11199         (xstormy16_dummy_id): Delete.
11200         (xstormy16_gdbarch_init): Don't register deleted functions with
11201         gdbarch.
11202
11203 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11204
11205         * vax-tdep.c (vax_unwind_pc): Delete.
11206         (vax_gdbarch_init): Don't register deleted function with gdbarch.
11207
11208 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11209
11210         * v850-tdep.c (v850_unwind_sp): Delete.
11211         (v850_unwind_pc): Delete.
11212         (v850_dummy_id): Delete.
11213         (v850_gdbarch_init): Don't register deleted functions with
11214         gdbarch.
11215
11216 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11217
11218         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11219         (tilegx_unwind_pc): Delete.
11220         (tilegx_unwind_dummy_id): Delete.
11221         (tilegx_gdbarch_init): Don't register deleted functions with
11222         gdbarch.
11223
11224 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11225
11226         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11227         (tic6x_dummy_id): Delete.
11228         (tic6x_gdbarch_init): Don't register deleted functions with
11229         gdbarch.
11230
11231 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11232
11233         * sparc-tdep.c (sparc_unwind_pc): Delete.
11234         (sparc32_gdbarch_init): Don't register deleted function with
11235         gdbarch.
11236
11237 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11238
11239         * sh-tdep.c (sh_unwind_sp): Delete.
11240         (sh_unwind_pc): Delete.
11241         (sh_dummy_id): Delete.
11242         (sh_gdbarch_init): Don't register deleted functions with
11243         gdbarch.
11244
11245 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11246
11247         * score-tdep.c (score_unwind_sp): Delete.
11248         (score_unwind_pc): Delete.
11249         (score_dummy_id): Delete.
11250         (score_gdbarch_init): Don't register deleted functions with
11251         gdbarch.
11252
11253 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11254
11255         * rx-tdep.c (rx_unwind_pc): Delete.
11256         (rx_unwind_sp): Delete.
11257         (rx_dummy_id): Delete.
11258         (rx_gdbarch_init): Don't register deleted functions with
11259         gdbarch.  Update comment.
11260
11261 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11262
11263         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11264         (rs6000_dummy_id): Delete.
11265         (rs6000_gdbarch_init): Don't register deleted functions with
11266         gdbarch.
11267
11268 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11269
11270         * or1k-tdep.c (or1k_dummy_id): Delete.
11271         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11272
11273 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11274
11275         * nios2-tdep.c (nios2_dummy_id): Delete.
11276         (nios2_unwind_sp): Delete.
11277         (nios2_gdbarch_init): Don't register deleted functions with
11278         gdbarch.
11279
11280 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11281
11282         * nds32-tdep.c (nds32_dummy_id): Delete.
11283         (nds32_unwind_pc): Delete.
11284         (nds32_unwind_sp): Delete.
11285         (nds32_gdbarch_init): Don't register deleted functions with
11286         gdbarch.
11287
11288 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11289
11290         * msp430-tdep.c (msp430_unwind_pc): Delete.
11291         (msp430_unwind_sp): Delete.
11292         (msp430_dummy_id): Delete.
11293         (msp430_gdbarch_init): Don't register deleted functions with
11294         gdbarch.
11295
11296 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11297
11298         * moxie-tdep.c (moxie_unwind_sp): Delete.
11299         (moxie_unwind_pc): Delete.
11300         (moxie_dummy_id): Delete.
11301         (moxie_gdbarch_init): Don't register deleted functions with
11302         gdbarch.
11303
11304 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11305
11306         * mn10300-tdep.c (mn10300_dummy_id): Delete.
11307         (mn10300_unwind_pc): Delete.
11308         (mn10300_unwind_sp): Delete.
11309         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11310         mn10300_unwind_sp.
11311         (mn10300_frame_unwind_init): Don't register deleted functions with
11312         gdbarch.
11313
11314 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11315
11316         * mep-tdep.c (mep_unwind_pc): Delete.
11317         (mep_unwind_sp): Delete.
11318         (mep_dummy_id): Delete.
11319         (mep_gdbarch_init): Don't register deleted functions with
11320         gdbarch.
11321
11322 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11323
11324         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11325         (m68hc11_unwind_sp): Delete.
11326         (m68hc11_gdbarch_init): Don't register deleted functions with
11327         gdbarch.
11328
11329 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11330
11331         * m32r-tdep.c (m32r_unwind_sp): Delete.
11332         (m32r_unwind_pc): Delete.
11333         (m32r_dummy_id): Delete.
11334         (m32r_gdbarch_init): Don't register deleted functions with
11335         gdbarch.
11336
11337 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11338
11339         * m32c-tdep.c (m32c_unwind_pc): Delete.
11340         (m32c_unwind_sp): Delete.
11341         (m32c_dummy_id): Delete.
11342         (m32c_gdbarch_init): Don't register deleted functions with
11343         gdbarch.
11344
11345 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11346
11347         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11348         (lm32_unwind_pc): Delete.
11349         (lm32_dummy_id): Delete.
11350         (lm32_gdbarch_init): Don't register deleted functions with
11351         gdbarch.
11352
11353 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11354
11355         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11356         (iq2000_unwind_pc): Delete.
11357         (iq2000_dummy_id): Delete.
11358         (iq2000_gdbarch_init): Don't register deleted functions with
11359         gdbarch.
11360
11361 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11362
11363         * nds32-tdep.c (nds32_type_align): Delete.
11364         (nds32_push_dummy_call): Use type_align instead.
11365
11366 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11367
11368         * arm-tdep.c (arm_type_align): Only handle vector override case.
11369         (arm_push_dummy_call): Use type_align.
11370         (arm_gdbarch_init): Register arm_type_align gdbarch function.
11371
11372 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11373
11374         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11375         case.
11376         (pass_on_stack): Use type_align.
11377         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11378         function.
11379
11380 2019-04-23  Tom Tromey  <tromey@adacore.com>
11381
11382         * dwarf2read.c (line_header::file_name_at): Remove unused
11383         overload.
11384
11385 2019-04-23  Tom de Vries  <tdevries@suse.de>
11386
11387         PR gdb/24438
11388         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11389         invocation.
11390
11391
11392 2019-03-27  Ali Tamur  <tamur@google.com>
11393
11394         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11395         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11396         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11397         (dwarf_expr_context::get_addr_index): Likewise
11398         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11399         (symbol_needs_eval_context::get_addr_index): Likewise
11400         (disassemble_dwarf_expression): Add DW_OP_addrx
11401         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11402         (read_cutu_die_from_dwo): Update comment
11403         (skip_one_die): Add DW_FORM_addrx
11404         (read_attribute_value): Likewise
11405         (var_decode_location): Add DW_OP_addrx
11406         (dwarf2_const_value_attr): Add DW_FORM_addrx
11407         (dump_die_shallow): Likewise
11408         (dwarf2_fetch_constant_bytes): Likewise
11409         (decode_locdesc): Add DW_OP_addrx
11410         (skip_form_bytes): Add DW_FORM_addrx
11411
11412 2019-04-22  Ali Tamur  <tamur@google.com>
11413
11414         * MAINTAINERS (Write After Approval): Add self.
11415
11416 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
11417
11418         * solib-svr4.c (get_svr4_info): Add pspace parameter.
11419         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11420         (open_symbol_file_object): Likewise.
11421         (svr4_default_sos): Add info parameter.
11422         (svr4_read_so_list): Likewise.
11423         (svr4_current_sos_direct): Adjust functions calls to pass down
11424         info.
11425         (svr4_current_sos_1): Add info parameter.
11426         (svr4_current_sos): Call get_svr4_info, pass info down to
11427         svr4_current_sos_1.
11428         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11429         get_svr4_info.
11430         (svr4_in_dynsym_resolve_code): Pass current_program_space to
11431         get_svr4_info.
11432         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11433         to get_svr4_info.
11434         (probes_table_remove_objfile_probes): Likewise.
11435         (register_solib_event_probe): Add info parameter.
11436         (solist_update_incremental): Pass info parameter down to
11437         svr4_read_so_list.
11438         (disable_probes_interface): Add info parameter.
11439         (svr4_handle_solib_event): Pass current_program_space to
11440         get_svr4_info.  Adjust disable_probes_interface cleanup.
11441         (svr4_create_probe_breakpoints): Add info parameter, pass it
11442         down to register_solib_event_probe.
11443         (svr4_create_solib_event_breakpoints): Add info parameter,
11444         pass it down to svr4_create_probe_breakpoints.
11445         (enable_break): Pass info down to
11446         svr4_create_solib_event_breakpoints.
11447         (svr4_solib_create_inferior_hook): Pass current_program_space to
11448         get_svr4_info.
11449         (svr4_clear_solib): Likewise.
11450
11451 2019-04-22  Pedro Alves  <palves@redhat.com>
11452
11453         * solib-svr4.c (svr4_free_objfile_observer): New.
11454         (probe_and_action::objfile): New field.
11455         (probes_table_htab_remove_objfile_probes)
11456         (probes_table_remove_objfile_probes): New functions.
11457         (register_solib_event_probe): Add 'objfile' parameter.  Store it
11458         in the new probe_and_action.  Don't store the probe in 'lookup'.
11459         (svr4_create_probe_breakpoints): Pass objfile to
11460         register_solib_event_probe.
11461         (_initialize_svr4_solib): Register a free_objfile observer.
11462
11463 2019-04-19  Tom Tromey  <tom@tromey.com>
11464
11465         * common/queue.h: Remove.
11466
11467 2019-04-19  Tom Tromey  <tom@tromey.com>
11468
11469         * event-loop.c: Don't include "common/queue.h".
11470
11471 2019-04-19  Tom Tromey  <tom@tromey.com>
11472
11473         * remote.c (remote_target): Use delete.
11474         * remote-notif.h: Include <list>, not "common/queue.h".
11475         (notif_client_p): Remove typedef.
11476         (remote_notif_state): Add constructor, destructor, initializer.
11477         <notif_queue>: Now a std::list.
11478         (remote_notif_state_xfree): Don't declare.
11479         * remote-notif.c (remote_notif_process, handle_notification)
11480         (remote_notif_state_allocate): Update.
11481         (~remote_notif_state): Rename from remote_notif_state_xfree.
11482
11483 2019-04-19  Tom Tromey  <tom@tromey.com>
11484
11485         * symfile.c (reread_symbols): Update.
11486         * objfiles.c (objfile_register_static_link)
11487         (objfile_lookup_static_link): Update
11488         (~objfile) Don't delete static_links.
11489         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11490
11491 2019-04-19  Tom Tromey  <tom@tromey.com>
11492
11493         * type-stack.h (struct type_stack) <insert>: Constify string.
11494         * type-stack.c (type_stack::insert): Constify string.
11495         * gdbtypes.h (lookup_template_type): Update.
11496         (address_space_name_to_int): Update.
11497         * gdbtypes.c (address_space_name_to_int): Make space_identifier
11498         const.
11499         (lookup_template_type): Make name const.
11500         * c-exp.y: Update rules.
11501         (lex_one_token, classify_name, classify_inner_name)
11502         (c_print_token): Update.
11503         * p-exp.y: Update rules.
11504         (yylex): Update.
11505         * f-exp.y: Update rules.
11506         (yylex): Update.
11507         * d-exp.y: Update rules.
11508         (lex_one_token, classify_name, classify_inner_name): Update.
11509         * parse.c (write_dollar_variable, copy_name): Return std::string.
11510         * parser-defs.h (copy_name): Change return type.
11511         * m2-exp.y: Update rules.
11512         (yylex): Update.
11513         * go-exp.y (lex_one_token): Update.
11514         Update rules.
11515         (classify_unsafe_function, classify_packaged_name)
11516         (classify_name, yylex): Update.
11517
11518 2019-04-19  Sergei Trofimovich <siarheit@google.com>
11519
11520         * configure.ac: add --enable-source-highlight switch.
11521         * configure: Regenerate.
11522         * top.c (print_gdb_version): plumb --enable-source-highlight
11523         status to "show configuration".
11524
11525 2019-04-19  Tom Tromey  <tromey@adacore.com>
11526
11527         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11528         Check ADA_TYPE_P.
11529         (empty_record, ada_template_to_fixed_record_type_1)
11530         (template_to_static_fixed_type)
11531         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11532         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11533         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11534         macros.
11535
11536 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
11537
11538         PR symtab/24423:
11539         * source.c (print_source_lines_base): Advance "iter" when a
11540         control character is seen.
11541
11542 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11543
11544         * inferior.h (struct infcall_suspend_state_deleter):
11545         Catch exception in destructor to avoid crash.
11546
11547 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11548
11549         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11550         close to the add_com "shell".
11551
11552 2019-04-18  Tom Tromey  <tromey@adacore.com>
11553
11554         * process-stratum-target.h (class process_stratum_target)
11555         <stratum>: Add "final".
11556
11557 2019-04-17  Tom Tromey  <tromey@adacore.com>
11558
11559         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11560         against nullptr before use.
11561
11562 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
11563
11564         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11565
11566 2019-04-17  Jim Wilson  <jimw@sifive.com>
11567             Andrew Burgess  <andrew.burgess@embecosm.com>
11568
11569         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11570         code read might fail, assume 4-byte breakpoint in that case.
11571
11572 2019-04-15  Leszek Swirski  <leszeks@google.com>
11573
11574         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11575         rather than a hand-rolled POD check when checking for forced MEMORY
11576         classification.
11577
11578 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11579
11580         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11581         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11582         function.
11583         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11584         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11585         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11586         declaration.
11587
11588 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11589
11590         * aarch64-linux-nat.c
11591         (aarch64_linux_nat_target::thread_architecture): Add override.
11592         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11593         each VQ.
11594
11595 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11596
11597         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11598
11599 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11600
11601         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11602         target types of size 96-bits, add some additional comments, and
11603         check that the builtin type we found was the correct size.
11604
11605 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
11606
11607         * utils.c (prompt_for_continue): Don't restore the styling at the
11608         end, as applied_style has the wrong value.  This fixes styling in
11609         long lists of file names that are interrupted by the "Continue?"
11610         prompt.
11611
11612 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11613
11614         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11615         * c-lang.c (c_language_defn): Likewise.
11616         (cplus_language_defn): Likewise.
11617         (asm_language_defn): Likewise.
11618         (minimal_language_defn): Likewise.
11619         * d-lang.c (d_language_defn): Likewise.
11620         * f-lang.c (f_language_defn): Likewise.
11621         * go-lang.c (go_language_defn): Likewise.
11622         * language.c (unknown_language_defn): Likewise.
11623         (auto_language_defn): Likewise.
11624         * language.h (struct language_defn): Remove la_magic field.
11625         (LANG_MAGIC): Delete.
11626         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11627         * objc-lang.c (objc_language_defn): Likewise.
11628         * opencl-lang.c (opencl_language_defn): Likewise.
11629         * p-lang.c (pascal_language_defn): Likewise.
11630         * rust-lang.c (rust_language_defn): Likewise.
11631
11632 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11633
11634         * riscv-tdep.c (riscv_type_align): New function.
11635         (riscv_type_alignment): Delete.
11636         (riscv_arg_location): Use 'type_align'.
11637         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11638
11639 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11640
11641         * gdbtypes.c (type_align): A struct with no non-static fields also
11642         has alignment of 1.
11643
11644 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11645
11646         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11647         component to 0.
11648         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11649         member.
11650         (riscv_struct_info::analyse): New implementation using new
11651         analyse_inner member function.
11652         (riscv_struct_info::field_offset): New member function.
11653         (riscv_struct_info::m_offsets): New member variable.
11654         (riscv_struct_info::analyse_inner): New private member function,
11655         takes the old implementation of riscv_struct_info::analyse but
11656         extended to track field offsets.
11657         (riscv_call_arg_struct): Update the struct folding special cases
11658         to handle cases where empty C++ structs, which are non-zero
11659         length, are found.
11660         (riscv_arg_location): Initialise the length of each location, a
11661         non-zero length now indicates the location is in use.
11662         (riscv_push_dummy_call): Allow for the first location having a
11663         non-zero offset when setting up arguments.
11664         (riscv_return_value): Likewise, but for return values.
11665
11666 2019-04-11  Tom Tromey  <tromey@adacore.com>
11667
11668         * utils.c (internal_vproblem): Make "msg" const.
11669
11670 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
11671
11672         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11673         * trad-frame.c (trad_frame_reset_saved_regs): New function.
11674         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11675         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11676
11677 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
11678
11679         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11680         function.
11681         (fill_gregset): Call amd64_linux_collect_native_gregset instead
11682         of amd64_collect_native_gregset.
11683         (amd64_linux_nat_target::store_registers): Likewise.
11684
11685 2019-04-10  Tom Tromey  <tom@tromey.com>
11686
11687         * symtab.c (lookup_global_symbol_from_objfile)
11688         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11689         * objfiles.h (class separate_debug_iterator): New.
11690         (class separate_debug_range): New.
11691         (struct objfile) <separate_debug_objfiles>: New method.
11692         (objfile_separate_debug_iterate): Don't declare.
11693         * objfiles.c (separate_debug_iterator::operator++): Rename from
11694         objfile_separate_debug_iterate.
11695         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11696         iterator.
11697         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11698         iterator.
11699
11700 2019-04-10  Tom Tromey  <tom@tromey.com>
11701
11702         * symfile.c (reread_symbols): Remove old comment.
11703         * objfiles.c (free_all_objfiles): Fix a typo.
11704
11705 2019-04-10  Tom Tromey  <tom@tromey.com>
11706
11707         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11708         * minsyms.c (lookup_minimal_symbol): Use foreach.
11709         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11710         (lookup_minimal_symbol_solib_trampoline): Likewise.
11711         * symfile.c (reread_symbols): Use foreach.
11712
11713 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
11714             Tom Tromey  <tromey@adacore.com>
11715
11716         PR rust/24414:
11717         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11718         (rust_lex_int_test): Change "value" to be LONGEST.
11719         (rust_lex_tests): Add test for long integer literal.
11720
11721 2019-04-09  Tom Tromey  <tromey@adacore.com>
11722
11723         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11724         to bool.
11725         (extended_remote_target::attach): Update.
11726         (remote_target::remote_notice_new_inferior): Update.
11727         (remote_target::add_current_inferior_and_thread): Update.
11728         * inferior.c (exit_inferior_1): Use "false".
11729         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11730
11731 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
11732
11733         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11734         the "start" command.
11735
11736 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11737
11738         * python/py-inferior.c (infpy_thread_from_thread_handle):
11739         Adjust comments to reflect renaming of thread_from_thread_handle
11740         to thread_from_handle.  Adjust keywords.  Fix type error message.
11741         (inferior_object_methods): Add thread_from_handle.  Retain
11742         thread_from_thread_handle, but mark it as deprecated.
11743
11744 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11745
11746         * gdbthread.h (find_thread_by_handle): Revise declaration.
11747         * thread.c (find_thread_by_handle): Likewise.  Adjust
11748         implementation too.
11749         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11750         support for buffer objects as handles.
11751
11752 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11753
11754         * python/py-infthread.c (thpy_thread_handle): New function.
11755         (thread_object_methods): Register thpy_thread_handle.
11756
11757 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11758
11759         * gdbthread.h (thread_to_thread_handle): Declare.
11760         * thread.c (gdbtypes.h): Include.
11761         (thread_to_thread_handle): New function.
11762
11763         * target.h (struct target_ops): Add thread_info_to_thread_handle.
11764         (target_thread_info_to_thread_handle): Declare.
11765         * target.c (target_thread_info_to_thread_handle): New function.
11766         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11767         * target-delegates.c: Regenerate.
11768
11769         * linux-thread-db.c (class thread_db_target): Add method
11770         thread_info_to_thread_handle.
11771         (thread_db_target::thread_info_to_thread_handle): Define.
11772         * remote.c (class remote_target): Add new method
11773         thread_info_to_thread_handle.
11774         (remote_target::thread_info_to_thread_handle): Define.
11775
11776 2019-04-08  Pedro Alves  <palves@redhat.com>
11777
11778         * common/common-exceptions.c (throw_exception): Don't create
11779         named object to throw; throw directly.
11780         (throw_it): Likewise.  Don't initialize gdb_exception::message
11781         here, with new; pass FMT and AP to the ctor instead.
11782         * common/common-exceptions.h: Include <string>.
11783         (gdb_exception::gdb_exception(enum return_reason, enum errors,
11784         const char *, va_list)): New ctor.  Use std::make_shared.
11785         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11786         errors)): Delete.
11787         (gdb_exception_error::gdb_exception_error(enum errors, const char
11788         *, va_list)): New.
11789         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11790         Add assertion.
11791         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11792         errors)): Delete.
11793         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11794         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11795         Add assertion.
11796
11797 2019-04-08  Tom Tromey  <tom@tromey.com>
11798
11799         * valops.c (value_rtti_indirect_type): Replace throw_exception
11800         with throw.
11801         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11802         with throw.
11803         * thread.c (thr_try_catch_cmd): Replace throw_exception with
11804         throw.
11805         * target.c (target_translate_tls_address): Replace throw_exception
11806         with throw.
11807         * stack.c (frame_apply_command_count): Replace throw_exception
11808         with throw.
11809         * solib-spu.c (append_ocl_sos): Replace throw_exception with
11810         throw.
11811         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11812         with throw.
11813         * rs6000-tdep.c (rs6000_frame_cache)
11814         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11815         * remote.c: Replace throw_exception with throw.
11816         * record-full.c (record_full_message, record_full_wait_1)
11817         (record_full_restore): Replace throw_exception with throw.
11818         * record-btrace.c:
11819         (get_thread_current_frame_id, record_btrace_start_replaying)
11820         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11821         (cmd_record_btrace_start): Replace throw_exception with throw.
11822         * parse.c (parse_exp_in_context_1): Replace throw_exception with
11823         throw.
11824         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11825         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11826         * linespec.c:
11827         (find_linespec_symbols): Replace throw_exception with throw.
11828         * infrun.c (displaced_step_prepare, resume): Replace
11829         throw_exception with throw.
11830         * infcmd.c (post_create_inferior): Replace throw_exception with
11831         throw.
11832         * inf-loop.c (inferior_event_handler): Replace throw_exception
11833         with throw.
11834         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11835         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11836         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11837         (get_prev_frame_always, get_frame_pc_if_available)
11838         (get_frame_address_in_block_if_available, get_frame_language):
11839         Replace throw_exception with throw.
11840         * frame-unwind.c (frame_unwind_try_unwinder): Replace
11841         throw_exception with throw.
11842         * eval.c (fetch_subexp_value, evaluate_var_value)
11843         (evaluate_funcall, evaluate_subexp_standard): Replace
11844         throw_exception with throw.
11845         * dwarf2loc.c (call_site_find_chain)
11846         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11847         Replace throw_exception with throw.
11848         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11849         with throw.
11850         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11851         throw.
11852         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11853         * completer.c (complete_line_internal): Replace throw_exception
11854         with throw.
11855         * compile/compile-object-run.c (compile_object_run): Replace
11856         throw_exception with throw.
11857         * cli/cli-script.c (process_next_line): Replace throw_exception
11858         with throw.
11859         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11860         (btrace_enable, btrace_maint_update_pt_packets): Replace
11861         throw_exception with throw.
11862         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11863         throw_exception with throw.
11864         * break-catch-throw.c (re_set_exception_catchpoint): Replace
11865         throw_exception with throw.
11866         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11867         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11868         * aarch64-tdep.c (aarch64_make_prologue_cache)
11869         (aarch64_make_stub_cache): Replace throw_exception with throw.
11870
11871 2019-04-08  Tom Tromey  <tom@tromey.com>
11872
11873         * common/common-exceptions.c (throw_exception): Rename from
11874         throw_exception_cxx.  Remove old copy.  Make argument const.
11875         (throw_it): Create and throw exception objects directly.
11876         * common/common-exceptions.h (throw_exception): Make argument
11877         const.
11878         (struct gdb_exception_error): Add constructor.
11879         (struct gdb_exception_quit): Add constructor.
11880
11881 2019-04-08  Tom Tromey  <tom@tromey.com>
11882
11883         * common/common-exceptions.h (exception_rethrow): Don't declare.
11884         (TRY_SJLJ): Update comment.
11885         (TRY, CATCH, END_CATCH): Remove.
11886         * common/common-exceptions.c (exception_rethrow): Remove.
11887
11888 2019-04-08  Tom Tromey  <tom@tromey.com>
11889
11890         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11891         Remove.
11892         (gdb_exception_error): Rename from
11893         gdb_exception_RETURN_MASK_ERROR.
11894         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11895         (gdb_quit_bad_alloc): Update.
11896         * aarch64-tdep.c: Update.
11897         * ada-lang.c: Update.
11898         * ada-typeprint.c: Update.
11899         * ada-valprint.c: Update.
11900         * amd64-tdep.c: Update.
11901         * arch-utils.c: Update.
11902         * break-catch-throw.c: Update.
11903         * breakpoint.c: Update.
11904         * btrace.c: Update.
11905         * c-varobj.c: Update.
11906         * cli/cli-cmds.c: Update.
11907         * cli/cli-interp.c: Update.
11908         * cli/cli-script.c: Update.
11909         * common/common-exceptions.c: Update.
11910         * common/new-op.c: Update.
11911         * common/selftest.c: Update.
11912         * compile/compile-c-symbols.c: Update.
11913         * compile/compile-cplus-symbols.c: Update.
11914         * compile/compile-object-load.c: Update.
11915         * compile/compile-object-run.c: Update.
11916         * completer.c: Update.
11917         * corelow.c: Update.
11918         * cp-abi.c: Update.
11919         * cp-support.c: Update.
11920         * cp-valprint.c: Update.
11921         * darwin-nat.c: Update.
11922         * disasm-selftests.c: Update.
11923         * dtrace-probe.c: Update.
11924         * dwarf-index-cache.c: Update.
11925         * dwarf-index-write.c: Update.
11926         * dwarf2-frame-tailcall.c: Update.
11927         * dwarf2-frame.c: Update.
11928         * dwarf2loc.c: Update.
11929         * dwarf2read.c: Update.
11930         * eval.c: Update.
11931         * event-loop.c: Update.
11932         * event-top.c: Update.
11933         * exec.c: Update.
11934         * f-valprint.c: Update.
11935         * fbsd-tdep.c: Update.
11936         * frame-unwind.c: Update.
11937         * frame.c: Update.
11938         * gdbtypes.c: Update.
11939         * gnu-v3-abi.c: Update.
11940         * guile/guile-internal.h: Update.
11941         * guile/scm-block.c: Update.
11942         * guile/scm-breakpoint.c: Update.
11943         * guile/scm-cmd.c: Update.
11944         * guile/scm-disasm.c: Update.
11945         * guile/scm-frame.c: Update.
11946         * guile/scm-lazy-string.c: Update.
11947         * guile/scm-math.c: Update.
11948         * guile/scm-param.c: Update.
11949         * guile/scm-ports.c: Update.
11950         * guile/scm-pretty-print.c: Update.
11951         * guile/scm-symbol.c: Update.
11952         * guile/scm-symtab.c: Update.
11953         * guile/scm-type.c: Update.
11954         * guile/scm-value.c: Update.
11955         * i386-linux-tdep.c: Update.
11956         * i386-tdep.c: Update.
11957         * inf-loop.c: Update.
11958         * infcall.c: Update.
11959         * infcmd.c: Update.
11960         * infrun.c: Update.
11961         * jit.c: Update.
11962         * language.c: Update.
11963         * linespec.c: Update.
11964         * linux-fork.c: Update.
11965         * linux-nat.c: Update.
11966         * linux-tdep.c: Update.
11967         * linux-thread-db.c: Update.
11968         * main.c: Update.
11969         * mi/mi-cmd-break.c: Update.
11970         * mi/mi-cmd-stack.c: Update.
11971         * mi/mi-interp.c: Update.
11972         * mi/mi-main.c: Update.
11973         * objc-lang.c: Update.
11974         * p-valprint.c: Update.
11975         * parse.c: Update.
11976         * ppc-linux-tdep.c: Update.
11977         * printcmd.c: Update.
11978         * python/py-arch.c: Update.
11979         * python/py-breakpoint.c: Update.
11980         * python/py-cmd.c: Update.
11981         * python/py-finishbreakpoint.c: Update.
11982         * python/py-frame.c: Update.
11983         * python/py-framefilter.c: Update.
11984         * python/py-gdb-readline.c: Update.
11985         * python/py-inferior.c: Update.
11986         * python/py-infthread.c: Update.
11987         * python/py-lazy-string.c: Update.
11988         * python/py-linetable.c: Update.
11989         * python/py-objfile.c: Update.
11990         * python/py-param.c: Update.
11991         * python/py-prettyprint.c: Update.
11992         * python/py-progspace.c: Update.
11993         * python/py-record-btrace.c: Update.
11994         * python/py-record.c: Update.
11995         * python/py-symbol.c: Update.
11996         * python/py-type.c: Update.
11997         * python/py-unwind.c: Update.
11998         * python/py-utils.c: Update.
11999         * python/py-value.c: Update.
12000         * python/python.c: Update.
12001         * record-btrace.c: Update.
12002         * record-full.c: Update.
12003         * remote-fileio.c: Update.
12004         * remote.c: Update.
12005         * riscv-tdep.c: Update.
12006         * rs6000-aix-tdep.c: Update.
12007         * rs6000-tdep.c: Update.
12008         * rust-exp.y: Update.
12009         * rust-lang.c: Update.
12010         * s390-tdep.c: Update.
12011         * selftest-arch.c: Update.
12012         * solib-dsbt.c: Update.
12013         * solib-frv.c: Update.
12014         * solib-spu.c: Update.
12015         * solib-svr4.c: Update.
12016         * solib.c: Update.
12017         * sparc64-linux-tdep.c: Update.
12018         * stack.c: Update.
12019         * symfile-mem.c: Update.
12020         * symmisc.c: Update.
12021         * target.c: Update.
12022         * thread.c: Update.
12023         * top.c: Update.
12024         * tracefile-tfile.c: Update.
12025         * tui/tui.c: Update.
12026         * typeprint.c: Update.
12027         * unittests/cli-utils-selftests.c: Update.
12028         * unittests/parse-connection-spec-selftests.c: Update.
12029         * valops.c: Update.
12030         * valprint.c: Update.
12031         * value.c: Update.
12032         * varobj.c: Update.
12033         * windows-nat.c: Update.
12034         * x86-linux-nat.c: Update.
12035         * xml-support.c: Update.
12036
12037 2019-04-08  Tom Tromey  <tom@tromey.com>
12038
12039         * xml-support.c: Use C++ exception handling.
12040         * x86-linux-nat.c: Use C++ exception handling.
12041         * windows-nat.c: Use C++ exception handling.
12042         * varobj.c: Use C++ exception handling.
12043         * value.c: Use C++ exception handling.
12044         * valprint.c: Use C++ exception handling.
12045         * valops.c: Use C++ exception handling.
12046         * unittests/parse-connection-spec-selftests.c: Use C++ exception
12047         handling.
12048         * unittests/cli-utils-selftests.c: Use C++ exception handling.
12049         * typeprint.c: Use C++ exception handling.
12050         * tui/tui.c: Use C++ exception handling.
12051         * tracefile-tfile.c: Use C++ exception handling.
12052         * top.c: Use C++ exception handling.
12053         * thread.c: Use C++ exception handling.
12054         * target.c: Use C++ exception handling.
12055         * symmisc.c: Use C++ exception handling.
12056         * symfile-mem.c: Use C++ exception handling.
12057         * stack.c: Use C++ exception handling.
12058         * sparc64-linux-tdep.c: Use C++ exception handling.
12059         * solib.c: Use C++ exception handling.
12060         * solib-svr4.c: Use C++ exception handling.
12061         * solib-spu.c: Use C++ exception handling.
12062         * solib-frv.c: Use C++ exception handling.
12063         * solib-dsbt.c: Use C++ exception handling.
12064         * selftest-arch.c: Use C++ exception handling.
12065         * s390-tdep.c: Use C++ exception handling.
12066         * rust-lang.c: Use C++ exception handling.
12067         * rust-exp.y: Use C++ exception handling.
12068         * rs6000-tdep.c: Use C++ exception handling.
12069         * rs6000-aix-tdep.c: Use C++ exception handling.
12070         * riscv-tdep.c: Use C++ exception handling.
12071         * remote.c: Use C++ exception handling.
12072         * remote-fileio.c: Use C++ exception handling.
12073         * record-full.c: Use C++ exception handling.
12074         * record-btrace.c: Use C++ exception handling.
12075         * python/python.c: Use C++ exception handling.
12076         * python/py-value.c: Use C++ exception handling.
12077         * python/py-utils.c: Use C++ exception handling.
12078         * python/py-unwind.c: Use C++ exception handling.
12079         * python/py-type.c: Use C++ exception handling.
12080         * python/py-symbol.c: Use C++ exception handling.
12081         * python/py-record.c: Use C++ exception handling.
12082         * python/py-record-btrace.c: Use C++ exception handling.
12083         * python/py-progspace.c: Use C++ exception handling.
12084         * python/py-prettyprint.c: Use C++ exception handling.
12085         * python/py-param.c: Use C++ exception handling.
12086         * python/py-objfile.c: Use C++ exception handling.
12087         * python/py-linetable.c: Use C++ exception handling.
12088         * python/py-lazy-string.c: Use C++ exception handling.
12089         * python/py-infthread.c: Use C++ exception handling.
12090         * python/py-inferior.c: Use C++ exception handling.
12091         * python/py-gdb-readline.c: Use C++ exception handling.
12092         * python/py-framefilter.c: Use C++ exception handling.
12093         * python/py-frame.c: Use C++ exception handling.
12094         * python/py-finishbreakpoint.c: Use C++ exception handling.
12095         * python/py-cmd.c: Use C++ exception handling.
12096         * python/py-breakpoint.c: Use C++ exception handling.
12097         * python/py-arch.c: Use C++ exception handling.
12098         * printcmd.c: Use C++ exception handling.
12099         * ppc-linux-tdep.c: Use C++ exception handling.
12100         * parse.c: Use C++ exception handling.
12101         * p-valprint.c: Use C++ exception handling.
12102         * objc-lang.c: Use C++ exception handling.
12103         * mi/mi-main.c: Use C++ exception handling.
12104         * mi/mi-interp.c: Use C++ exception handling.
12105         * mi/mi-cmd-stack.c: Use C++ exception handling.
12106         * mi/mi-cmd-break.c: Use C++ exception handling.
12107         * main.c: Use C++ exception handling.
12108         * linux-thread-db.c: Use C++ exception handling.
12109         * linux-tdep.c: Use C++ exception handling.
12110         * linux-nat.c: Use C++ exception handling.
12111         * linux-fork.c: Use C++ exception handling.
12112         * linespec.c: Use C++ exception handling.
12113         * language.c: Use C++ exception handling.
12114         * jit.c: Use C++ exception handling.
12115         * infrun.c: Use C++ exception handling.
12116         * infcmd.c: Use C++ exception handling.
12117         * infcall.c: Use C++ exception handling.
12118         * inf-loop.c: Use C++ exception handling.
12119         * i386-tdep.c: Use C++ exception handling.
12120         * i386-linux-tdep.c: Use C++ exception handling.
12121         * guile/scm-value.c: Use C++ exception handling.
12122         * guile/scm-type.c: Use C++ exception handling.
12123         * guile/scm-symtab.c: Use C++ exception handling.
12124         * guile/scm-symbol.c: Use C++ exception handling.
12125         * guile/scm-pretty-print.c: Use C++ exception handling.
12126         * guile/scm-ports.c: Use C++ exception handling.
12127         * guile/scm-param.c: Use C++ exception handling.
12128         * guile/scm-math.c: Use C++ exception handling.
12129         * guile/scm-lazy-string.c: Use C++ exception handling.
12130         * guile/scm-frame.c: Use C++ exception handling.
12131         * guile/scm-disasm.c: Use C++ exception handling.
12132         * guile/scm-cmd.c: Use C++ exception handling.
12133         * guile/scm-breakpoint.c: Use C++ exception handling.
12134         * guile/scm-block.c: Use C++ exception handling.
12135         * guile/guile-internal.h: Use C++ exception handling.
12136         * gnu-v3-abi.c: Use C++ exception handling.
12137         * gdbtypes.c: Use C++ exception handling.
12138         * frame.c: Use C++ exception handling.
12139         * frame-unwind.c: Use C++ exception handling.
12140         * fbsd-tdep.c: Use C++ exception handling.
12141         * f-valprint.c: Use C++ exception handling.
12142         * exec.c: Use C++ exception handling.
12143         * event-top.c: Use C++ exception handling.
12144         * event-loop.c: Use C++ exception handling.
12145         * eval.c: Use C++ exception handling.
12146         * dwarf2read.c: Use C++ exception handling.
12147         * dwarf2loc.c: Use C++ exception handling.
12148         * dwarf2-frame.c: Use C++ exception handling.
12149         * dwarf2-frame-tailcall.c: Use C++ exception handling.
12150         * dwarf-index-write.c: Use C++ exception handling.
12151         * dwarf-index-cache.c: Use C++ exception handling.
12152         * dtrace-probe.c: Use C++ exception handling.
12153         * disasm-selftests.c: Use C++ exception handling.
12154         * darwin-nat.c: Use C++ exception handling.
12155         * cp-valprint.c: Use C++ exception handling.
12156         * cp-support.c: Use C++ exception handling.
12157         * cp-abi.c: Use C++ exception handling.
12158         * corelow.c: Use C++ exception handling.
12159         * completer.c: Use C++ exception handling.
12160         * compile/compile-object-run.c: Use C++ exception handling.
12161         * compile/compile-object-load.c: Use C++ exception handling.
12162         * compile/compile-cplus-symbols.c: Use C++ exception handling.
12163         * compile/compile-c-symbols.c: Use C++ exception handling.
12164         * common/selftest.c: Use C++ exception handling.
12165         * common/new-op.c: Use C++ exception handling.
12166         * cli/cli-script.c: Use C++ exception handling.
12167         * cli/cli-interp.c: Use C++ exception handling.
12168         * cli/cli-cmds.c: Use C++ exception handling.
12169         * c-varobj.c: Use C++ exception handling.
12170         * btrace.c: Use C++ exception handling.
12171         * breakpoint.c: Use C++ exception handling.
12172         * break-catch-throw.c: Use C++ exception handling.
12173         * arch-utils.c: Use C++ exception handling.
12174         * amd64-tdep.c: Use C++ exception handling.
12175         * ada-valprint.c: Use C++ exception handling.
12176         * ada-typeprint.c: Use C++ exception handling.
12177         * ada-lang.c: Use C++ exception handling.
12178         * aarch64-tdep.c: Use C++ exception handling.
12179
12180 2019-04-08  Tom Tromey  <tom@tromey.com>
12181
12182         * xml-support.c (gdb_xml_parser::parse): Update.
12183         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12184         * value.c (show_convenience): Update.
12185         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12186         (test_parse_flags_qcs): Update.
12187         * thread.c (thr_try_catch_cmd): Update.
12188         * target.c (target_translate_tls_address): Update.
12189         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12190         (info_frame_command_core, frame_apply_command_count): Update.
12191         * rust-exp.y (rust_lex_exception_test): Update.
12192         * riscv-tdep.c (riscv_print_one_register_info): Update.
12193         * remote.c (remote_target::enable_btrace): Update.
12194         * record-btrace.c (record_btrace_enable_warn): Update.
12195         * python/py-utils.c (gdbpy_convert_exception): Update.
12196         * printcmd.c (do_one_display, print_variable_and_value): Update.
12197         * mi/mi-main.c (mi_print_exception): Update.
12198         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12199         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12200         * linux-nat.c (linux_nat_target::attach): Update.
12201         * linux-fork.c (class scoped_switch_fork_info): Update.
12202         * infrun.c (displaced_step_prepare): Update.
12203         * infcall.c (call_function_by_hand_dummy): Update.
12204         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12205         * gnu-v3-abi.c (print_one_vtable): Update.
12206         * frame.c (get_prev_frame_always): Update.
12207         * f-valprint.c (info_common_command_for_block): Update.
12208         * exec.c (try_open_exec_file): Update.
12209         * exceptions.c (print_exception, exception_print)
12210         (exception_fprintf, exception_print_same): Update.
12211         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12212         * dwarf-index-cache.c (index_cache::store)
12213         (index_cache::lookup_gdb_index): Update.
12214         * darwin-nat.c (maybe_cache_shell): Update.
12215         * cp-valprint.c (cp_print_value_fields): Update.
12216         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12217         (gcc_cplus_symbol_address): Update.
12218         * compile/compile-c-symbols.c (gcc_convert_symbol)
12219         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12220         * common/selftest.c: Update.
12221         * common/common-exceptions.h (struct gdb_exception) <message>: Now
12222         a std::string.
12223         (exception_try_scope_entry, exception_try_scope_exit): Don't
12224         declare.
12225         (struct exception_try_scope): Remove.
12226         (TRY): Don't use exception_try_scope.
12227         (struct gdb_exception): Add constructor, operator=.
12228         <what>: New method.
12229         (struct gdb_exception_RETURN_MASK_ALL)
12230         (struct gdb_exception_RETURN_MASK_ERROR)
12231         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12232         (struct gdb_quit_bad_alloc): Update.
12233         * common/common-exceptions.c (exception_none): Change
12234         initializer.
12235         (struct catcher) <state, exception>: Initialize inline.
12236         <prev>: Remove member.
12237         (current_catcher): Remove.
12238         (catchers): New global.
12239         (exceptions_state_mc_init): Simplify.
12240         (catcher_pop): Remove.
12241         (exceptions_state_mc, exceptions_state_mc_catch): Update.
12242         (try_scope_depth, exception_try_scope_entry)
12243         (exception_try_scope_exit): Remove.
12244         (throw_exception_sjlj): Update.
12245         (exception_messages, exception_messages_size): Remove.
12246         (throw_it): Simplify.
12247         (gdb_exception_sliced_copy): Remove.
12248         (throw_exception_cxx): Update.
12249         * cli/cli-script.c (script_from_file): Update.
12250         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12251         Update.
12252         * ada-valprint.c (ada_val_print): Update.
12253         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12254         (create_excep_cond_exprs): Update.
12255
12256 2019-04-08  Tom Tromey  <tom@tromey.com>
12257
12258         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12259         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12260         (TRY, CATCH, END_CATCH): Remove some definitions.
12261         * common/common-exceptions.c: Don't use GDB_XCPT.
12262         (catcher_list_size): Remove.
12263         (throw_exception, throw_it): Simplify.
12264
12265 2019-04-05  Tom Tromey  <tom@tromey.com>
12266
12267         Revert the header-sorting patch.
12268         * ft32-tdep.c: Revert.
12269         * frv-tdep.c: Revert.
12270         * frv-linux-tdep.c: Revert.
12271         * frame.c: Revert.
12272         * frame-unwind.c: Revert.
12273         * frame-base.c: Revert.
12274         * fork-child.c: Revert.
12275         * findvar.c: Revert.
12276         * findcmd.c: Revert.
12277         * filesystem.c: Revert.
12278         * filename-seen-cache.h: Revert.
12279         * filename-seen-cache.c: Revert.
12280         * fbsd-tdep.c: Revert.
12281         * fbsd-nat.h: Revert.
12282         * fbsd-nat.c: Revert.
12283         * f-valprint.c: Revert.
12284         * f-typeprint.c: Revert.
12285         * f-lang.c: Revert.
12286         * extension.h: Revert.
12287         * extension.c: Revert.
12288         * extension-priv.h: Revert.
12289         * expprint.c: Revert.
12290         * exec.h: Revert.
12291         * exec.c: Revert.
12292         * exceptions.c: Revert.
12293         * event-top.c: Revert.
12294         * event-loop.c: Revert.
12295         * eval.c: Revert.
12296         * elfread.c: Revert.
12297         * dwarf2read.h: Revert.
12298         * dwarf2read.c: Revert.
12299         * dwarf2loc.c: Revert.
12300         * dwarf2expr.h: Revert.
12301         * dwarf2expr.c: Revert.
12302         * dwarf2-frame.c: Revert.
12303         * dwarf2-frame-tailcall.c: Revert.
12304         * dwarf-index-write.h: Revert.
12305         * dwarf-index-write.c: Revert.
12306         * dwarf-index-common.c: Revert.
12307         * dwarf-index-cache.h: Revert.
12308         * dwarf-index-cache.c: Revert.
12309         * dummy-frame.c: Revert.
12310         * dtrace-probe.c: Revert.
12311         * disasm.h: Revert.
12312         * disasm.c: Revert.
12313         * disasm-selftests.c: Revert.
12314         * dictionary.c: Revert.
12315         * dicos-tdep.c: Revert.
12316         * demangle.c: Revert.
12317         * dcache.h: Revert.
12318         * dcache.c: Revert.
12319         * darwin-nat.h: Revert.
12320         * darwin-nat.c: Revert.
12321         * darwin-nat-info.c: Revert.
12322         * d-valprint.c: Revert.
12323         * d-namespace.c: Revert.
12324         * d-lang.c: Revert.
12325         * ctf.c: Revert.
12326         * csky-tdep.c: Revert.
12327         * csky-linux-tdep.c: Revert.
12328         * cris-tdep.c: Revert.
12329         * cris-linux-tdep.c: Revert.
12330         * cp-valprint.c: Revert.
12331         * cp-support.c: Revert.
12332         * cp-namespace.c: Revert.
12333         * cp-abi.c: Revert.
12334         * corelow.c: Revert.
12335         * corefile.c: Revert.
12336         * continuations.c: Revert.
12337         * completer.h: Revert.
12338         * completer.c: Revert.
12339         * complaints.c: Revert.
12340         * coffread.c: Revert.
12341         * coff-pe-read.c: Revert.
12342         * cli-out.h: Revert.
12343         * cli-out.c: Revert.
12344         * charset.c: Revert.
12345         * c-varobj.c: Revert.
12346         * c-valprint.c: Revert.
12347         * c-typeprint.c: Revert.
12348         * c-lang.c: Revert.
12349         * buildsym.c: Revert.
12350         * buildsym-legacy.c: Revert.
12351         * build-id.h: Revert.
12352         * build-id.c: Revert.
12353         * btrace.c: Revert.
12354         * bsd-uthread.c: Revert.
12355         * breakpoint.h: Revert.
12356         * breakpoint.c: Revert.
12357         * break-catch-throw.c: Revert.
12358         * break-catch-syscall.c: Revert.
12359         * break-catch-sig.c: Revert.
12360         * blockframe.c: Revert.
12361         * block.c: Revert.
12362         * bfin-tdep.c: Revert.
12363         * bfin-linux-tdep.c: Revert.
12364         * bfd-target.c: Revert.
12365         * bcache.c: Revert.
12366         * ax-general.c: Revert.
12367         * ax-gdb.h: Revert.
12368         * ax-gdb.c: Revert.
12369         * avr-tdep.c: Revert.
12370         * auxv.c: Revert.
12371         * auto-load.c: Revert.
12372         * arm-wince-tdep.c: Revert.
12373         * arm-tdep.c: Revert.
12374         * arm-symbian-tdep.c: Revert.
12375         * arm-pikeos-tdep.c: Revert.
12376         * arm-obsd-tdep.c: Revert.
12377         * arm-nbsd-tdep.c: Revert.
12378         * arm-nbsd-nat.c: Revert.
12379         * arm-linux-tdep.c: Revert.
12380         * arm-linux-nat.c: Revert.
12381         * arm-fbsd-tdep.c: Revert.
12382         * arm-fbsd-nat.c: Revert.
12383         * arm-bsd-tdep.c: Revert.
12384         * arch-utils.c: Revert.
12385         * arc-tdep.c: Revert.
12386         * arc-newlib-tdep.c: Revert.
12387         * annotate.h: Revert.
12388         * annotate.c: Revert.
12389         * amd64-windows-tdep.c: Revert.
12390         * amd64-windows-nat.c: Revert.
12391         * amd64-tdep.c: Revert.
12392         * amd64-sol2-tdep.c: Revert.
12393         * amd64-obsd-tdep.c: Revert.
12394         * amd64-obsd-nat.c: Revert.
12395         * amd64-nbsd-tdep.c: Revert.
12396         * amd64-nbsd-nat.c: Revert.
12397         * amd64-nat.c: Revert.
12398         * amd64-linux-tdep.c: Revert.
12399         * amd64-linux-nat.c: Revert.
12400         * amd64-fbsd-tdep.c: Revert.
12401         * amd64-fbsd-nat.c: Revert.
12402         * amd64-dicos-tdep.c: Revert.
12403         * amd64-darwin-tdep.c: Revert.
12404         * amd64-bsd-nat.c: Revert.
12405         * alpha-tdep.c: Revert.
12406         * alpha-obsd-tdep.c: Revert.
12407         * alpha-nbsd-tdep.c: Revert.
12408         * alpha-mdebug-tdep.c: Revert.
12409         * alpha-linux-tdep.c: Revert.
12410         * alpha-linux-nat.c: Revert.
12411         * alpha-bsd-tdep.c: Revert.
12412         * alpha-bsd-nat.c: Revert.
12413         * aix-thread.c: Revert.
12414         * agent.c: Revert.
12415         * addrmap.c: Revert.
12416         * ada-varobj.c: Revert.
12417         * ada-valprint.c: Revert.
12418         * ada-typeprint.c: Revert.
12419         * ada-tasks.c: Revert.
12420         * ada-lang.c: Revert.
12421         * aarch64-tdep.c: Revert.
12422         * aarch64-ravenscar-thread.c: Revert.
12423         * aarch64-newlib-tdep.c: Revert.
12424         * aarch64-linux-tdep.c: Revert.
12425         * aarch64-linux-nat.c: Revert.
12426         * aarch64-fbsd-tdep.c: Revert.
12427         * aarch64-fbsd-nat.c: Revert.
12428         * aarch32-linux-nat.c: Revert.
12429
12430 2019-04-05  Tom Tromey  <tom@tromey.com>
12431
12432         * ft32-tdep.c: Sort headers.
12433         * frv-tdep.c: Sort headers.
12434         * frv-linux-tdep.c: Sort headers.
12435         * frame.c: Sort headers.
12436         * frame-unwind.c: Sort headers.
12437         * frame-base.c: Sort headers.
12438         * fork-child.c: Sort headers.
12439         * findvar.c: Sort headers.
12440         * findcmd.c: Sort headers.
12441         * filesystem.c: Sort headers.
12442         * filename-seen-cache.h: Sort headers.
12443         * filename-seen-cache.c: Sort headers.
12444         * fbsd-tdep.c: Sort headers.
12445         * fbsd-nat.h: Sort headers.
12446         * fbsd-nat.c: Sort headers.
12447         * f-valprint.c: Sort headers.
12448         * f-typeprint.c: Sort headers.
12449         * f-lang.c: Sort headers.
12450         * extension.h: Sort headers.
12451         * extension.c: Sort headers.
12452         * extension-priv.h: Sort headers.
12453         * expprint.c: Sort headers.
12454         * exec.h: Sort headers.
12455         * exec.c: Sort headers.
12456         * exceptions.c: Sort headers.
12457         * event-top.c: Sort headers.
12458         * event-loop.c: Sort headers.
12459         * eval.c: Sort headers.
12460         * elfread.c: Sort headers.
12461         * dwarf2read.h: Sort headers.
12462         * dwarf2read.c: Sort headers.
12463         * dwarf2loc.c: Sort headers.
12464         * dwarf2expr.h: Sort headers.
12465         * dwarf2expr.c: Sort headers.
12466         * dwarf2-frame.c: Sort headers.
12467         * dwarf2-frame-tailcall.c: Sort headers.
12468         * dwarf-index-write.h: Sort headers.
12469         * dwarf-index-write.c: Sort headers.
12470         * dwarf-index-common.c: Sort headers.
12471         * dwarf-index-cache.h: Sort headers.
12472         * dwarf-index-cache.c: Sort headers.
12473         * dummy-frame.c: Sort headers.
12474         * dtrace-probe.c: Sort headers.
12475         * disasm.h: Sort headers.
12476         * disasm.c: Sort headers.
12477         * disasm-selftests.c: Sort headers.
12478         * dictionary.c: Sort headers.
12479         * dicos-tdep.c: Sort headers.
12480         * demangle.c: Sort headers.
12481         * dcache.h: Sort headers.
12482         * dcache.c: Sort headers.
12483         * darwin-nat.h: Sort headers.
12484         * darwin-nat.c: Sort headers.
12485         * darwin-nat-info.c: Sort headers.
12486         * d-valprint.c: Sort headers.
12487         * d-namespace.c: Sort headers.
12488         * d-lang.c: Sort headers.
12489         * ctf.c: Sort headers.
12490         * csky-tdep.c: Sort headers.
12491         * csky-linux-tdep.c: Sort headers.
12492         * cris-tdep.c: Sort headers.
12493         * cris-linux-tdep.c: Sort headers.
12494         * cp-valprint.c: Sort headers.
12495         * cp-support.c: Sort headers.
12496         * cp-namespace.c: Sort headers.
12497         * cp-abi.c: Sort headers.
12498         * corelow.c: Sort headers.
12499         * corefile.c: Sort headers.
12500         * continuations.c: Sort headers.
12501         * completer.h: Sort headers.
12502         * completer.c: Sort headers.
12503         * complaints.c: Sort headers.
12504         * coffread.c: Sort headers.
12505         * coff-pe-read.c: Sort headers.
12506         * cli-out.h: Sort headers.
12507         * cli-out.c: Sort headers.
12508         * charset.c: Sort headers.
12509         * c-varobj.c: Sort headers.
12510         * c-valprint.c: Sort headers.
12511         * c-typeprint.c: Sort headers.
12512         * c-lang.c: Sort headers.
12513         * buildsym.c: Sort headers.
12514         * buildsym-legacy.c: Sort headers.
12515         * build-id.h: Sort headers.
12516         * build-id.c: Sort headers.
12517         * btrace.c: Sort headers.
12518         * bsd-uthread.c: Sort headers.
12519         * breakpoint.h: Sort headers.
12520         * breakpoint.c: Sort headers.
12521         * break-catch-throw.c: Sort headers.
12522         * break-catch-syscall.c: Sort headers.
12523         * break-catch-sig.c: Sort headers.
12524         * blockframe.c: Sort headers.
12525         * block.c: Sort headers.
12526         * bfin-tdep.c: Sort headers.
12527         * bfin-linux-tdep.c: Sort headers.
12528         * bfd-target.c: Sort headers.
12529         * bcache.c: Sort headers.
12530         * ax-general.c: Sort headers.
12531         * ax-gdb.h: Sort headers.
12532         * ax-gdb.c: Sort headers.
12533         * avr-tdep.c: Sort headers.
12534         * auxv.c: Sort headers.
12535         * auto-load.c: Sort headers.
12536         * arm-wince-tdep.c: Sort headers.
12537         * arm-tdep.c: Sort headers.
12538         * arm-symbian-tdep.c: Sort headers.
12539         * arm-pikeos-tdep.c: Sort headers.
12540         * arm-obsd-tdep.c: Sort headers.
12541         * arm-nbsd-tdep.c: Sort headers.
12542         * arm-nbsd-nat.c: Sort headers.
12543         * arm-linux-tdep.c: Sort headers.
12544         * arm-linux-nat.c: Sort headers.
12545         * arm-fbsd-tdep.c: Sort headers.
12546         * arm-fbsd-nat.c: Sort headers.
12547         * arm-bsd-tdep.c: Sort headers.
12548         * arch-utils.c: Sort headers.
12549         * arc-tdep.c: Sort headers.
12550         * arc-newlib-tdep.c: Sort headers.
12551         * annotate.h: Sort headers.
12552         * annotate.c: Sort headers.
12553         * amd64-windows-tdep.c: Sort headers.
12554         * amd64-windows-nat.c: Sort headers.
12555         * amd64-tdep.c: Sort headers.
12556         * amd64-sol2-tdep.c: Sort headers.
12557         * amd64-obsd-tdep.c: Sort headers.
12558         * amd64-obsd-nat.c: Sort headers.
12559         * amd64-nbsd-tdep.c: Sort headers.
12560         * amd64-nbsd-nat.c: Sort headers.
12561         * amd64-nat.c: Sort headers.
12562         * amd64-linux-tdep.c: Sort headers.
12563         * amd64-linux-nat.c: Sort headers.
12564         * amd64-fbsd-tdep.c: Sort headers.
12565         * amd64-fbsd-nat.c: Sort headers.
12566         * amd64-dicos-tdep.c: Sort headers.
12567         * amd64-darwin-tdep.c: Sort headers.
12568         * amd64-bsd-nat.c: Sort headers.
12569         * alpha-tdep.c: Sort headers.
12570         * alpha-obsd-tdep.c: Sort headers.
12571         * alpha-nbsd-tdep.c: Sort headers.
12572         * alpha-mdebug-tdep.c: Sort headers.
12573         * alpha-linux-tdep.c: Sort headers.
12574         * alpha-linux-nat.c: Sort headers.
12575         * alpha-bsd-tdep.c: Sort headers.
12576         * alpha-bsd-nat.c: Sort headers.
12577         * aix-thread.c: Sort headers.
12578         * agent.c: Sort headers.
12579         * addrmap.c: Sort headers.
12580         * ada-varobj.c: Sort headers.
12581         * ada-valprint.c: Sort headers.
12582         * ada-typeprint.c: Sort headers.
12583         * ada-tasks.c: Sort headers.
12584         * ada-lang.c: Sort headers.
12585         * aarch64-tdep.c: Sort headers.
12586         * aarch64-ravenscar-thread.c: Sort headers.
12587         * aarch64-newlib-tdep.c: Sort headers.
12588         * aarch64-linux-tdep.c: Sort headers.
12589         * aarch64-linux-nat.c: Sort headers.
12590         * aarch64-fbsd-tdep.c: Sort headers.
12591         * aarch64-fbsd-nat.c: Sort headers.
12592         * aarch32-linux-nat.c: Sort headers.
12593
12594 2019-04-04  Tom Tromey  <tom@tromey.com>
12595
12596         * varobj.c (varobj_create): Update.
12597         * rust-exp.y (struct rust_parser) <update_innermost_block,
12598         lookup_symbol>: New methods.
12599         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12600         Rename.
12601         (rust_parser::rust_lookup_type)
12602         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12603         * printcmd.c (display_command, do_one_display): Update.
12604         * parser-defs.h (struct parser_state) <parser_state>: Add
12605         "tracker" parameter.
12606         (block_tracker): New member.
12607         (class innermost_block_tracker) <innermost_block_tracker>: Add
12608         "types" parameter.
12609         <reset>: Remove method.
12610         (innermost_block): Don't declare.
12611         (null_post_parser): Update.
12612         * parse.c (innermost_block): Remove global.
12613         (write_dollar_variable): Update.
12614         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12615         Remove "tracker_types" parameter.
12616         (parse_expression): Add "tracker" parameter.
12617         (parse_expression_for_completion): Update.
12618         (null_post_parser): Add "tracker" parameter.
12619         * p-exp.y: Update rules.
12620         * m2-exp.y: Update rules.
12621         * language.h (struct language_defn) <la_post_parser>: Add
12622         "tracker" parameter.
12623         * go-exp.y: Update rules.
12624         * f-exp.y: Update rules.
12625         * expression.h (parse_expression, parse_exp_1): Add "tracker"
12626         parameter.
12627         * d-exp.y: Update rules.
12628         * c-exp.y: Update rules.
12629         * breakpoint.c (set_breakpoint_condition): Create an
12630         innermost_block_tracker.
12631         (watch_command_1): Likewise.
12632         * ada-lang.c (resolve): Add "tracker" parameter.
12633         (resolve_subexp): Likewise.
12634         * ada-exp.y (write_var_from_sym): Update.
12635
12636 2019-04-04  Tom Tromey  <tom@tromey.com>
12637
12638         * type-stack.h: New file.
12639         * type-stack.c: New file.
12640         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12641         type-stack.h.
12642         (insert_into_type_stack, insert_type, push_type, push_type_int)
12643         (insert_type_address_space, pop_type, pop_type_int)
12644         (pop_typelist, pop_type_stack, append_type_stack)
12645         (push_type_stack, get_type_stack, push_typelist)
12646         (follow_type_instance_flags, follow_types): Don't declare.
12647         * parse.c (type_stack): Remove global.
12648         (parse_exp_in_context): Update.
12649         (insert_into_type_stack, insert_type, push_type, push_type_int)
12650         (insert_type_address_space, pop_type, pop_type_int)
12651         (pop_typelist, pop_type_stack, append_type_stack)
12652         (push_type_stack, get_type_stack, push_typelist)
12653         (follow_type_instance_flags, follow_types): Remove (moved to
12654         type-stack.c).
12655         * f-exp.y (type_stack): New global.
12656         Update rules.
12657         (push_kind_type, f_parse): Update.
12658         * d-exp.y (type_stack): New global.
12659         Update rules.
12660         (d_parse): Update.
12661         * c-exp.y (struct c_parse_state) <type_stack>: New member.
12662         Update rules.
12663         * Makefile.in (COMMON_SFILES): Add type-stack.c.
12664         (HFILES_NO_SRCDIR): Add type-stack.h.
12665
12666 2019-04-04  Tom Tromey  <tom@tromey.com>
12667
12668         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12669         (rust_parser::convert_ast_to_expression, rust_parse)
12670         (rust_lex_test_completion, rust_lex_tests): Update.
12671         * parser-defs.h (struct expr_completion_state): New.
12672         (struct parser_state) <parser_state>: Add completion parameter.
12673         <mark_struct_expression, mark_completion_tag>: New methods.
12674         <parse_completion, m_completion_state>: New members.
12675         (prefixify_expression, null_post_parser): Update.
12676         (mark_struct_expression, mark_completion_tag): Don't declare.
12677         * parse.c (parse_completion, expout_last_struct)
12678         (expout_tag_completion_type, expout_completion_name): Remove
12679         globals.
12680         (parser_state::mark_struct_expression)
12681         (parser_state::mark_completion_tag): Now methods.
12682         (prefixify_expression): Add last_struct parameter.
12683         (prefixify_subexp): Likewise.
12684         (parse_exp_1): Update.
12685         (parse_exp_in_context): Add cstate parameter.  Update.
12686         (parse_expression_for_completion): Create an
12687         expr_completion_state.
12688         (null_post_parser): Add "completion" parameter.
12689         * p-exp.y: Update rules.
12690         (yylex): Update.
12691         * language.h (struct language_defn) <la_post_parser>: Add
12692         "completing" parameter.
12693         * go-exp.y: Update rules.
12694         (lex_one_token): Update.
12695         * expression.h (parse_completion): Don't declare.
12696         * d-exp.y: Update rules.
12697         (lex_one_token): Update rules.
12698         * c-exp.y: Update rules.
12699         (lex_one_token): Update.
12700         * ada-lang.c (resolve): Add "parse_completion" parameter.
12701         (resolve_subexp): Likewise.
12702         (ada_resolve_function): Likewise.
12703
12704 2019-04-04  Tom Tromey  <tom@tromey.com>
12705
12706         * parser-defs.h (struct parser_state) <start_arglist,
12707         end_arglist>: New methods.
12708         <arglist_len, m_funcall_chain>: New members.
12709         (arglist_len, start_arglist, end_arglist): Don't declare.
12710         * parse.c (arglist_len, funcall_chain): Remove global.
12711         (start_arglist, end_arglist): Remove functions.
12712         (parse_exp_in_context): Update.
12713         * p-exp.y: Update rules.
12714         * m2-exp.y: Update rules.
12715         * go-exp.y: Update rules.
12716         * f-exp.y: Update rules.
12717         * d-exp.y: Update rules.
12718         * c-exp.y: Update rules.
12719
12720 2019-04-04  Tom Tromey  <tom@tromey.com>
12721
12722         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12723         lex_operator, push_back>: New methods.
12724         Update all rules.
12725         (rust_parser::lex_hex, lex_escape): Rename and update.
12726         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12727         (rust_parser::lex_operator): Rename and update.
12728         (rust_parser::lex_number, rustyylex, rustyyerror)
12729         (rust_lex_test_init, rust_lex_test_sequence)
12730         (rust_lex_test_push_back, rust_lex_tests): Update.
12731         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12732         parameter.
12733         <lexptr, prev_lexptr>: New members.
12734         (lexptr, prev_lexptr): Don't declare.
12735         * parse.c (lexptr, prev_lexptr): Remove globals.
12736         (parse_exp_in_context): Update.
12737         * p-exp.y (yylex, yyerror): Update.
12738         * m2-exp.y (parse_number, yylex, yyerror): Update.
12739         * go-exp.y (lex_one_token, yyerror): Update.
12740         * f-exp.y (match_string_literal, yylex, yyerror): Update.
12741         * d-exp.y (lex_one_token, yyerror): Update.
12742         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12743         (lex_one_token, yyerror): Update.
12744         * ada-lex.l (YY_INPUT): Update.
12745         (rewind_to_char): Update.
12746         * ada-exp.y (yyerror): Update.
12747
12748 2019-04-04  Tom Tromey  <tom@tromey.com>
12749
12750         * rust-exp.y (rustyylex, rust_lex_tests): Update.
12751         * parser-defs.h (struct parser_state) <parser_state>: Add new
12752         parameter.
12753         <comma_terminates>: New member.
12754         (comma_terminates): Don't declare global.
12755         * parse.c (comma_terminates): Remove global.
12756         (parse_exp_in_context): Update.
12757         * p-exp.y (yylex): Update.
12758         * m2-exp.y (yylex): Update.
12759         * go-exp.y (lex_one_token): Update.
12760         * f-exp.y (yylex): Update.
12761         * d-exp.y (lex_one_token): Update.
12762         * c-exp.y (lex_one_token): Update.
12763         * ada-lex.l: Update.
12764
12765 2019-04-04  Tom Tromey  <tom@tromey.com>
12766
12767         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12768         (rustyylex, rust_lex_test_init, rust_lex_test_one)
12769         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12770         * parser-defs.h (paren_depth): Don't declare.
12771         * parse.c (paren_depth): Remove global.
12772         (parse_exp_in_context): Update.
12773         * p-exp.y (paren_depth): New global.
12774         (pascal_parse): Initialize it.
12775         * m2-exp.y (paren_depth): New global.
12776         (m2_parse): Initialize it.
12777         * go-exp.y (paren_depth): New global.
12778         (go_parse): Initialize it.
12779         * f-exp.y (paren_depth): New global.
12780         (f_parse): Initialize it.
12781         * d-exp.y (paren_depth): New global.
12782         (d_parse): Initialize it.
12783         * c-exp.y (paren_depth): New global.
12784         (c_parse): Initialize it.
12785         * ada-lex.l (paren_depth): New global.
12786         (lexer_init): Initialize it.
12787
12788 2019-04-04  Tom Tromey  <tom@tromey.com>
12789
12790         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12791         (rust_parser::convert_ast_to_type)
12792         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12793         * parser-defs.h (struct parser_state) <parser_state>: Add
12794         parameters.  Initialize new members.
12795         <expression_context_block, expression_context_pc>: New members.
12796         * parse.c (expression_context_block, expression_context_pc):
12797         Remove globals.
12798         (parse_exp_in_context): Update.
12799         * p-exp.y: Update all rules.
12800         (yylex): Update.
12801         * m2-exp.y: Update all rules.
12802         (yylex): Update.
12803         * go-exp.y (yylex): Update.
12804         * f-exp.y (yylex): Update.
12805         * d-exp.y: Update all rules.
12806         (yylex): Update.
12807         * c-exp.y: Update all rules.
12808         (lex_one_token, classify_name, yylex, c_parse): Update.
12809         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12810
12811 2019-04-04  Tom Tromey  <tom@tromey.com>
12812
12813         * gdbarch.h, gdbarch.c: Rebuild.
12814         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12815         * stap-probe.h:
12816         (struct stap_parse_info): Replace "parser_state" with
12817         "expr_builder".
12818         * parser-defs.h (struct expr_builder): Rename from "parser_state".
12819         (parser_state): New class.
12820         * parse.c (expr_builder): Rename.
12821         (expr_builder::release): Rename.
12822         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12823         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12824         (write_exp_elt_longcst, write_exp_elt_floatcst)
12825         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12826         (write_exp_string_vector, write_exp_bitstring)
12827         (write_exp_msymbol, mark_struct_expression)
12828         (write_dollar_variable)
12829         (insert_type_address_space, increase_expout_size): Replace
12830         "parser_state" with "expr_builder".
12831         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12832         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12833         "parser_state" with "expr_builder".
12834
12835 2019-04-04  Tom Tromey  <tom@tromey.com>
12836
12837         * rust-exp.y: Replace "parse_language" with method call.
12838         * p-exp.y:
12839         (yylex): Replace "parse_language" with method call.
12840         * m2-exp.y:
12841         (yylex): Replace "parse_language" with method call.
12842         * go-exp.y (classify_name): Replace "parse_language" with method
12843         call.
12844         * f-exp.y (yylex): Replace "parse_language" with method call.
12845         * d-exp.y (lex_one_token): Replace "parse_language" with method
12846         call.
12847         * c-exp.y:
12848         (lex_one_token, classify_name, yylex): Replace "parse_language"
12849         with method call.
12850         * ada-exp.y (find_primitive_type, type_char)
12851         (type_system_address): Replace "parse_language" with method call.
12852
12853 2019-04-04  Tom Tromey  <tom@tromey.com>
12854
12855         * rust-exp.y: Replace "parse_gdbarch" with method call.
12856         * parse.c (write_dollar_variable, insert_type_address_space):
12857         Replace "parse_gdbarch" with method call.
12858         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12859         call.
12860         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12861         call.
12862         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12863         "parse_gdbarch" with method call.
12864         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12865         with method call.
12866         * f-exp.y (parse_type, parse_f_type, yylex): Replace
12867         "parse_gdbarch" with method call.
12868         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12869         "parse_gdbarch" with method call.
12870         * c-exp.y (parse_type, parse_number, classify_name): Replace
12871         "parse_gdbarch" with method call.
12872         * ada-lex.l: Replace "parse_gdbarch" with method call.
12873         * ada-exp.y (parse_type, find_primitive_type, type_char)
12874         (type_system_address): Replace "parse_gdbarch" with method call.
12875
12876 2019-04-04  Tom Tromey  <tom@tromey.com>
12877
12878         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12879         * stap-probe.c (stap_parse_argument): Update.
12880         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12881         initial_size parameter.
12882         * rust-exp.y (rust_lex_tests): Update.
12883         * parse.c (parser_state): Update.
12884         (parse_exp_in_context): Update.
12885         * parser-defs.h (struct parser_state) <parser_state>: Remove
12886         "initial_size" parameter.
12887
12888 2019-04-04  Tom Tromey  <tom@tromey.com>
12889
12890         * parser-defs.h (increase_expout_size): Don't declare.
12891         * parse.c (increase_expout_size): Now static.
12892
12893 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
12894
12895         * gnu-nat.c (gnu_nat_target::wait): Fix
12896         target_waitstatus_to_string call.
12897
12898 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12899
12900         * eval.c (evaluate_subexp_standard): Handle internal functions
12901         during Fortran function call handling.
12902
12903 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12904
12905         * NEWS: Mention new internal functions.
12906         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12907         (read_base_type): Use dwarf2_init_complex_target_type.
12908         * value.c (creal_internal_fn): New function.
12909         (cimag_internal_fn): New function.
12910         (_initialize_values): Register new internal functions.
12911
12912 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12913
12914         * infrun.c (stop_all_threads): If debug_infrun, always
12915         trace the wait status after wait_one, using
12916         target_waitstatus_to_string and target_pid_to_str.
12917         (handle_inferior_event): Replace various trace of
12918         wait status kind by a single trace.
12919         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12920         wait status kind image by target_waitstatus_to_string.
12921         * target/waitstatus.c (target_waitstatus_to_string): Fix
12922         obsolete comment.
12923
12924 2019-04-01  Tom Tromey  <tromey@adacore.com>
12925
12926         PR symtab/23331:
12927         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12928
12929 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
12930             Pedro Alves  <palves@redhat.com>
12931
12932         * top.c (quit_force): Call 'finalize_values'.
12933         * value.c (finalize_values): New function.
12934         * value.h (finalize_values): Declare.
12935
12936 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
12937
12938         * NEWS: Announce $_gdb_major and $_gdb_minor.
12939
12940         * top.c (init_gdb_version_vars): New function.
12941         (gdb_init): Call init_gdb_version_vars.
12942
12943 2019-03-29  Tom Tromey  <tromey@adacore.com>
12944
12945         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
12946         help text.  Remove dead code.
12947
12948 2019-03-29  Keith Seitz  <keiths@redhat.com>
12949
12950         From Siddhesh Poyarekar:
12951         * f-lang.h (f77_get_upperbound): Return LONGEST.
12952         (f77_get_lowerbound): Likewise.
12953         * f-typeprint.c (f_type_print_varspec_suffix): Expand
12954         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
12955         print them.
12956         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
12957         plongest to format print it.
12958         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12959         (f77_get_upperbound): Likewise.
12960         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12961         LOWER_BOUND to LONGEST.
12962         (f77_create_arrayprint_offset_tbl): Likewise.
12963
12964 2019-03-29  Keith Seitz  <keiths@redhat.com>
12965
12966         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12967         %s/pulongest for TYPE_LENGTH instead of %d in format
12968         strings.
12969         * ada-typerint.c (ada_print_type): Likewise.
12970         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12971         * compile/compile-c-support.c (generate_register_struct): Likewise.
12972         * gdbtypes.c (recursive_dump_type): Likewise.
12973         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12974         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
12975         instead of %d in format strings.
12976         * riscv-tdep.c (riscv_type_alignment): Cast second argument
12977         to std::min to ULONGEST.
12978         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12979         instead of %d in format strings.
12980         * tracepoint.c (info_scope_command): Likewise.
12981         * typeprint.c (print_offset_data::update)
12982         (print_offset_data::finish): Likewise.
12983         * xtensa-tdep.c (xtensa_store_return_value)
12984         (xtensa_push_dummy_call): Likewise.
12985
12986 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
12987
12988         * windows-nat.c (display_selector): Fixed format specifications
12989         for 64-bit Cygwin.
12990
12991 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12992
12993         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12994
12995 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
12996
12997         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12998         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12999         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
13000         (nios2_linux_init_abi): Install it.
13001
13002 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
13003
13004         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
13005
13006 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
13007
13008         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
13009
13010 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13011             Tom Tromey  <tromey@adacore.com>
13012
13013         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
13014
13015 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
13016
13017         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
13018         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
13019         method to compute the bounds of range types. Also print "[evaluated]"
13020         if the bounds' values come from a dynamic evaluation.
13021
13022 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
13023
13024         * cp-valprint.c (cp_print_value_fields): Don't print trailing
13025         whitespace when pretty printing is on.
13026
13027 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13028
13029         * ppc-linux-nat.c: Add include.
13030
13031 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13032
13033         * NEWS: Mention AArch64 Pointer Authentication.
13034
13035 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13036
13037         * arm-linux-nat.c: Add include.
13038
13039 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
13040
13041         * source-cache.c (source_cache::get_source_lines): Re-read
13042         fullname after calling open_source_file.
13043
13044 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
13045
13046         * NEWS: Mention TLS support for FreeBSD.
13047
13048 2019-03-25  Tom Tromey  <tromey@adacore.com>
13049
13050         * minsyms.c (BUNCH_SIZE): Update comment.
13051         (~minimal_symbol_reader): Remove old comment.
13052         (compact_minimal_symbols): Update comment.
13053         (minimal_symbol_reader::install): Remove old comment.  Update
13054         other comments.
13055
13056 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13057
13058         * s390-linux-nat.c: Add include.
13059
13060 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13061
13062         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13063         Call linux_get_hwcap.
13064         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13065         Likewise.
13066         (aarch64_linux_get_hwcap): Remove function.
13067         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13068         declaration.
13069         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13070         linux_get_hwcap.
13071         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13072         * linux-tdep.c (linux_get_hwcap): Add function.
13073         (linux_get_hwcap2): Likewise.
13074         * linux-tdep.h (linux_get_hwcap): Add declaration.
13075         (linux_get_hwcap2): Likewise.
13076         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13077         (ppc_linux_get_hwcap2): Likewise.
13078         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13079         linux_get_hwcap.
13080         (ppc_linux_nat_target::insert_watchpoint): Likewise.
13081         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13082         (ppc_linux_nat_target::read_description): Likewise.
13083         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13084         * s390-linux-nat.c: Likewise.
13085         * s390-linux-tdep.c (s390_core_read_description): Likewise.
13086
13087 2019-03-24  Tom Tromey  <tom@tromey.com>
13088
13089         * ada-lang.c (standard_lookup): Simplify initialization.
13090         (ada_lookup_symbol_nonlocal): Simplify return.
13091         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13092         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13093         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13094         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13095         initialization.
13096         * solib.c (solib_global_lookup): Simplify.
13097         * symtab.c (null_block_symbol): Remove.
13098         (symbol_cache_lookup): Simplify returns.
13099         (lookup_language_this): Simplify returns.
13100         (lookup_symbol_aux): Simplify return.
13101         (lookup_local_symbol): Simplify returns.
13102         (lookup_global_symbol_from_objfile): Simplify return.
13103         (lookup_symbol_in_objfile_symtabs)
13104         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13105         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13106         (lookup_static_symbol, lookup_global_symbol): Simplify return.
13107         * cp-namespace.c (cp_lookup_bare_symbol)
13108         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13109         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13110         (cp_lookup_nested_symbol): Don't use null_block_symbol.
13111         (cp_lookup_symbol_via_imports): Simplify initialization.
13112         (find_symbol_in_baseclass): Likewise.
13113         * symtab.h (null_block_symbol): Remove.
13114         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13115         (d_lookup_nested_symbol, d_lookup_symbol_imports)
13116         (d_lookup_symbol_module): Likewise.
13117         (find_symbol_in_baseclass): Simplify initialization.
13118
13119 2019-03-24  Tom Tromey  <tom@tromey.com>
13120
13121         * expression.h: Don't include symtab.h.
13122         (struct block): Forward declare.
13123
13124 2019-03-24  Tom Tromey  <tom@tromey.com>
13125
13126         * c-exp.y (typebase): Remove casts.
13127         * gdbtypes.c (lookup_unsigned_typename, )
13128         (lookup_signed_typename): Remove cast.
13129         * eval.c (parse_to_comma_and_eval): Remove cast.
13130         * parse.c (write_dollar_variable): Remove cast.
13131         * block.h (struct block) <superblock>: Now const.
13132         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13133         * psymtab.c (psym_map_matching_symbols): Make "block" const.
13134         (map_block): Make "block" const.
13135         * symfile.h (struct quick_symbol_functions)
13136         <map_matching_symbols>: Constify block argument to "callback".
13137         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13138         const.
13139         (find_pc_sect_compunit_symtab): Make "b" const.
13140         (find_symbol_at_address): Likewise.
13141         (search_symbols): Likewise.
13142         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13143         (dw2_debug_names_lookup_symbol): Likewise.
13144         (dw2_map_matching_symbols): Update.
13145         * p-valprint.c (pascal_val_print): Remove "block".
13146         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13147         (aux_add_nonlocal_symbols): Make "block" const.
13148         (resolve_subexp): Remove cast.
13149         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13150         const.
13151         (iterate_over_file_blocks): Likewise.
13152         * f-exp.y (%union) <bval>: Remove.
13153         * coffread.c (patch_opaque_types): Make "b" const.
13154         * spu-tdep.c (spu_catch_start): Make "block" const.
13155         * c-valprint.c (print_unpacked_pointer): Remove "block".
13156         * symmisc.c (dump_symtab_1): Make "b" const.
13157         (block_depth): Make "block" const.
13158         * d-exp.y (%union) <bval>: Remove.
13159         * cp-support.h (cp_lookup_rtti_type): Update.
13160         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13161         * psymtab.c (psym_lookup_symbol): Make "block" const.
13162         (maintenance_check_psymtabs): Make "b" const.
13163         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13164         (enumerate_locals, enumerate_args): Update.
13165         * python/py-symtab.c (stpy_global_block): Make "block" const.
13166         (stpy_static_block): Likewise.
13167         * inline-frame.c (block_starting_point_at): Make "new_block"
13168         const.
13169         * block.c (find_block_in_blockvector): Make return type const.
13170         (blockvector_for_pc_sect): Make "b" const.
13171         (find_block_in_blockvector): Make "b" const.
13172
13173 2019-03-23  Tom Tromey  <tom@tromey.com>
13174
13175         * varobj.c (varobj_create): Update.
13176         * symfile.c (clear_symtab_users): Don't reset innermost_block.
13177         * printcmd.c (display_command, do_one_display): Don't reset
13178         innermost_block.
13179         * parser-defs.h (enum innermost_block_tracker_type): Move to
13180         expression.h.
13181         (innermost_block): Update comment.
13182         * parse.c (parse_exp_1): Add tracker_types parameter.
13183         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
13184         tracker_types parameter.  Reset innermost_block.
13185         (parse_exp_in_context): Remove.
13186         (parse_expression_for_completion): Update.
13187         * objfiles.c (~objfile): Don't reset expression_context_block or
13188         innermost_block.
13189         * expression.h (enum innermost_block_tracker_type): Move from
13190         parser-defs.h.
13191         (parse_exp_1): Add tracker_types parameter.
13192         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13193         reset innermost_block.
13194
13195 2019-03-23  Tom Tromey  <tom@tromey.com>
13196
13197         * objfiles.h: Include bcache.h.
13198
13199 2019-03-23  Tom Tromey  <tom@tromey.com>
13200
13201         * linespec.c (get_current_search_block): Use
13202         scoped_restore_current_language.
13203         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13204
13205 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13206             Jiong Wang  <jiong.wang@arm.com>
13207
13208         * aarch64-linux-tdep.c
13209         (aarch64_linux_iterate_over_regset_sections): Check for pauth
13210         section.
13211         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13212
13213 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13214             Jiong Wang  <jiong.wang@arm.com>
13215
13216         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13217         instructions.
13218         (aarch64_analyze_prologue_test): Add PACIASP test.
13219         (aarch64_prologue_prev_register): Unmask PC value.
13220
13221 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13222             Jiong Wang  <jiong.wang@arm.com>
13223
13224         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13225         (aarch64_dwarf2_prev_register): Unmask PC value.
13226         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13227         (aarch64_execute_dwarf_cfa_vendor_op): Check for
13228         DW_CFA_AARCH64_negate_ra_state.
13229         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13230
13231 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13232             Jiong Wang  <jiong.wang@arm.com>
13233
13234         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13235         registers.
13236         (aarch64_pseudo_register_name): Likewise.
13237         (aarch64_pseudo_register_type): Likewise.
13238         (aarch64_pseudo_register_reggroup_p): Likewise.
13239         (aarch64_gdbarch_init): Add pauth registers.
13240         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13241         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13242         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13243         (struct gdbarch_tdep): Add regnum for ra_state.
13244
13245 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13246             Jiong Wang  <jiong.wang@arm.com>
13247
13248         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13249
13250 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13251             Jiong Wang  <jiong.wang@arm.com>
13252
13253         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13254         function.
13255         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13256         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13257         (aarch64_gdbarch_init): Add puth registers.
13258         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13259         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13260         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13261
13262 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13263             Jiong Wang  <jiong.wang@arm.com>
13264
13265         * aarch64-linux-nat.c
13266         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13267         * aarch64-linux-tdep.c
13268         (aarch64_linux_core_read_description): Likewise.
13269         (aarch64_linux_get_hwcap): New function.
13270         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13271         (aarch64_linux_get_hwcap): New declaration.
13272
13273 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13274             Jiong Wang  <jiong.wang@arm.com>
13275
13276         * aarch64-linux-nat.c
13277         (aarch64_linux_nat_target::read_description): Add pauth param.
13278         * aarch64-linux-tdep.c
13279         (aarch64_linux_core_read_description): Likewise.
13280         * aarch64-tdep.c (struct target_desc): Add in pauth.
13281         (aarch64_read_description): Add pauth param.
13282         (aarch64_gdbarch_init): Likewise.
13283         * aarch64-tdep.h (aarch64_read_description): Likewise.
13284         * arch/aarch64.c (aarch64_create_target_description): Likewise.
13285         * arch/aarch64.h (aarch64_create_target_description): Likewise.
13286         * features/Makefile: Add new files.
13287         * features/aarch64-pauth.c: New file.
13288         * features/aarch64-pauth.xml: New file.
13289
13290 2019-03-20  Tom Tromey  <tromey@adacore.com>
13291
13292         * infrun.c (handle_inferior_event): Rename from
13293         handle_inferior_event_1.  Create a scoped_value_mark.
13294         (handle_inferior_event): Remove.
13295
13296 2019-03-19  Tom Tromey  <tromey@adacore.com>
13297
13298         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13299         * infrun.h (print_stop_event): Add "displays" parameter.
13300         * infrun.c (print_stop_event): Add "displays" parameter.
13301
13302 2019-03-19  Pedro Alves  <palves@redhat.com>
13303
13304         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13305         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
13306         to -1.  Fix TABs vs spaces.
13307         (tui_ui_out::tui_ui_out): Don't initialize fields here.
13308         * tui/tui-out.h (tui_ui_out) Add intro comments.
13309         <m_line, m_start_of_line>: In-class initialize, and add describing
13310         comment.
13311
13312 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
13313
13314         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13315         variable names.
13316         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13317
13318 2019-03-18  Pedro Alves  <palves@redhat.com>
13319             Eli Zaretskii <eliz@gnu.org>
13320
13321         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13322         m_line and m_start_of_line.
13323
13324 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
13325
13326         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13327         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13328         it returns a newline.  This fixes a regression in TU mode, whereby
13329         the next line is output on the same screen line as the user input.
13330
13331 2019-03-18  Tom Tromey  <tromey@adacore.com>
13332
13333         * minsyms.c (minimal_symbol_reader::install): Remove call to
13334         obstack_blank.
13335
13336 2019-03-18  Pedro Alves  <palves@redhat.com>
13337
13338         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13339         New globals.
13340         (apply_style): New, factored out from ...
13341         (apply_ansi_escape): ... this.  Handle reverse video mode.
13342         (tui_set_reverse_mode): New function.
13343         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13344         * tui/tui-winsource.c (tui_show_source_line): Use
13345         tui_set_reverse_mode instead of setting A_STANDOUT.
13346         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13347         New setter methods.
13348
13349 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
13350
13351         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13352         Handle tabs.
13353
13354 2019-03-18  Tom Tromey  <tromey@adacore.com>
13355
13356         * ada-lang.c (empty_array): Add "high" parameter.
13357         (ada_evaluate_subexp): Update.
13358
13359 2019-03-17  Sergei Trofimovich <siarheit@google.com>
13360
13361         * unittests/string_view-selftests.c: Define
13362         _initialize_string_view_selftests unconditionally.
13363
13364 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13365
13366         PR gdb/24350
13367         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13368
13369 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13370
13371         PR gdb/24351
13372         * windows-nat.c (display_selector): Fix format specifiers.
13373
13374 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
13375
13376         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13377         tui_refill_source_window instead of tui_refresh_win, to update the
13378         current execution line.  This fixes redisplay of the current line
13379         when stepping through the code with "next" or "step".
13380
13381 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13382
13383         * source-cache.c (source_cache::get_source_lines): Call
13384         find_source_lines to initialize s->nlines.  This fixes vertical
13385         scrolling of TUI source window when the DOWN arrow is pressed.
13386
13387 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13388
13389         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13390         linux-thread-db.c (_initialize_thread_db): Likewise.
13391
13392 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13393
13394         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13395         wclrtoeol in tui_show_source_line".  This reverts changes made in
13396         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13397
13398 2019-03-15  Tom Tromey  <tom@tromey.com>
13399
13400         * symtab.h (struct minimal_symbol): Derive from
13401         general_symbol_info.
13402         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13403         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13404         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13405         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13406         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13407         (MSYMBOL_SEARCH_NAME): Update.
13408         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13409         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13410         * minsyms.c (minimal_symbol_reader::record_full): Update.
13411
13412 2019-03-15  Tom Tromey  <tom@tromey.com>
13413
13414         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13415
13416 2019-03-15  Tom Tromey  <tom@tromey.com>
13417
13418         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13419         unique_xmalloc_ptr.
13420         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13421         Update.
13422         * minsyms.c (lookup_minimal_symbol_by_pc_section)
13423         (build_minimal_symbol_hash_tables)
13424         (minimal_symbol_reader::install): Update.
13425
13426 2019-03-15  Tom Tromey  <tom@tromey.com>
13427
13428         * symtab.c (create_demangled_names_hash): Update.
13429         (symbol_set_names): Update.
13430         * objfiles.h (struct objfile_per_bfd_storage)
13431         <demangled_names_hash>: Now an htab_up.
13432         * objfiles.c (objfile_per_bfd_storage): Simplify.
13433
13434 2019-03-15  Tom Tromey  <tom@tromey.com>
13435
13436         * objfiles.h (struct objfile_per_bfd_storage): Declare
13437         destructor.
13438         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13439         New.
13440         (get_objfile_bfd_data): Use new.  Don't initialize
13441         language_of_main.
13442         (free_objfile_per_bfd_storage): Remove.
13443         (objfile_bfd_data_free, objfile::~objfile): Use delete.
13444
13445 2019-03-15  Tom Tromey  <tom@tromey.com>
13446
13447         * symfile.c (reread_symbols): Update.
13448         * objfiles.c (objfile::objfile): Update.
13449         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13450         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13451         comment.
13452         (minimal_symbol_reader::install): Update.
13453         (terminate_minimal_symbol_table): Remove.
13454         * jit.c (jit_object_close_impl): Update.
13455
13456 2019-03-15  Tom Tromey  <tom@tromey.com>
13457
13458         * minsyms.c (minimal_symbol_reader::record_full): Remove some
13459         initializations.
13460
13461 2019-03-15  Tom Tromey  <tom@tromey.com>
13462
13463         * objfiles.h (struct objfile_per_bfd_storage)
13464         <demangled_hash_languages>: Now a bitset.
13465         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13466         (lookup_minimal_symbol): Update.
13467
13468 2019-03-15  Tom Tromey  <tom@tromey.com>
13469
13470         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13471         Don't return the symbol.
13472         * coffread.c (record_minimal_symbol): Use record_full.
13473
13474 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
13475
13476         The MS-Windows port of ncurses fails to switch to a color pair if
13477         one or both of the colors are the implicit default colors.  This
13478         change records the default colors when TUI is initialized, and
13479         then specifies them explicitly when a color pair uses the default
13480         colors.  This allows color styling in TUI mode on MS-Windows.
13481
13482         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
13483         ncurses_norm_attr.
13484         (tui_initialize_io) [__MINGW32__]: Record the default terminal
13485         colors in ncurses_norm_attr.
13486         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13487         "none", replace it with the default color recorded in
13488         ncurses_norm_attr.
13489
13490 2019-03-14  Tom Tromey  <tromey@adacore.com>
13491
13492         * source-cache.h (class source_cache) <get_source_lines>: Return
13493         std::string.
13494         * source-cache.c (source_cache::extract_lines): Handle case where
13495         first_pos==npos.  Return std::string.
13496         (source_cache::get_source_lines): Update.
13497
13498 2019-03-14  Tom Tromey  <tromey@adacore.com>
13499
13500         * NEWS: Add item for "style sources" commands.
13501         * source-cache.c (source_cache::get_source_lines): Check
13502         source_styling.
13503         * cli/cli-style.c (source_styling): New global.
13504         (_initialize_cli_style): Add "style sources" commands.
13505         (show_style_sources): New function.
13506         * cli/cli-style.h (source_styling): Declare.
13507
13508 2019-03-14  Pedro Alves  <palves@redhat.com>
13509             Tom Tromey  <tromey@adacore.com>
13510
13511         * tui/tui-winsource.h (tui_refill_source_window): Declare.
13512         * tui/tui-winsource.c (tui_refill_source_window): New function,
13513         from...
13514         (tui_horizontal_source_scroll): ... here.  Move some logic.
13515         * cli/cli-style.c (set_style_enabled): Notify new observable.
13516         * tui/tui-hooks.c (tui_redisplay_source): New function.
13517         (tui_attach_detach_observers): Attach or detach
13518         tui_redisplay_source.
13519         * observable.h (source_styling_changed): New observable.
13520         * observable.c: Define source_styling_changed observable.
13521
13522 2019-03-13  Tom Tromey  <tromey@adacore.com>
13523
13524         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13525         (i386_gnu_nat_target::store_registers): Update.
13526         * target-debug.h (target_debug_print_std_string): New macro.
13527         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13528         * windows-tdep.c (display_one_tib): Update.
13529         * tui/tui-stack.c (tui_make_status_line): Update.
13530         * top.c (print_inferior_quit_action): Update.
13531         * thread.c (thr_try_catch_cmd): Update.
13532         (add_thread_with_info): Update.
13533         (thread_target_id_str): Update.
13534         (thr_try_catch_cmd): Update.
13535         (thread_command): Update.
13536         (thread_find_command): Update.
13537         * record-btrace.c (record_btrace_target::info_record)
13538         (record_btrace_resume_thread, record_btrace_target::resume)
13539         (record_btrace_cancel_resume, record_btrace_step_thread)
13540         (record_btrace_target::wait, record_btrace_target::wait)
13541         (record_btrace_target::wait, record_btrace_target::stop): Update.
13542         * progspace.c (print_program_space): Update.
13543         * process-stratum-target.c
13544         (process_stratum_target::thread_address_space): Update.
13545         * linux-fork.c (linux_fork_mourn_inferior)
13546         (detach_checkpoint_command, info_checkpoints_command)
13547         (linux_fork_context): Update.
13548         (linux_fork_detach): Update.
13549         (class scoped_switch_fork_info): Update.
13550         (delete_checkpoint_command): Update.
13551         * infrun.c (follow_fork_inferior): Update.
13552         (follow_fork_inferior): Update.
13553         (proceed_after_vfork_done): Update.
13554         (handle_vfork_child_exec_or_exit): Update.
13555         (follow_exec): Update.
13556         (displaced_step_prepare_throw): Update.
13557         (displaced_step_restore): Update.
13558         (start_step_over): Update.
13559         (resume_1): Update.
13560         (clear_proceed_status_thread): Update.
13561         (proceed): Update.
13562         (print_target_wait_results): Update.
13563         (do_target_wait): Update.
13564         (context_switch): Update.
13565         (stop_all_threads): Update.
13566         (restart_threads): Update.
13567         (finish_step_over): Update.
13568         (handle_signal_stop): Update.
13569         (switch_back_to_stepped_thread): Update.
13570         (keep_going_pass_signal): Update.
13571         (print_exited_reason): Update.
13572         (normal_stop): Update.
13573         * inferior.c (inferior_pid_to_str): Change return type.
13574         (print_selected_inferior): Update.
13575         (add_inferior): Update.
13576         (detach_inferior): Update.
13577         * dummy-frame.c (fprint_dummy_frames): Update.
13578         * dcache.c (dcache_info_1): Update.
13579         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13580         (btrace_fetch, btrace_clear): Update.
13581         * linux-tdep.c (linux_core_pid_to_str): Change return type.
13582         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13583         type.
13584         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13585         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13586         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13587         * gdbarch.c, gdbarch.h: Rebuild.
13588         * gdbarch.sh (core_pid_to_str): Change return type.
13589         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13590         return type.
13591         (windows_nat_target::pid_to_str): Change return type.
13592         (windows_delete_thread): Update.
13593         (windows_nat_target::attach): Update.
13594         (windows_nat_target::files_info): Update.
13595         * target-delegates.c: Rebuild.
13596         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13597         return type.
13598         (sol_thread_target::pid_to_str): Change return type.
13599         * remote.c (class remote_target) <pid_to_str>: Change return
13600         type.
13601         (remote_target::pid_to_str): Change return type.
13602         (extended_remote_target::attach, remote_target::remote_stop_ns)
13603         (remote_target::remote_notif_remove_queued_reply)
13604         (remote_target::push_stop_reply, remote_target::disable_btrace):
13605         Update.
13606         (extended_remote_target::attach): Update.
13607         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13608         type.
13609         (gdbsim_target::pid_to_str): Change return type.
13610         * ravenscar-thread.c (struct ravenscar_thread_target)
13611         <pid_to_str>: Change return type.
13612         (ravenscar_thread_target::pid_to_str): Change return type.
13613         * procfs.c (class procfs_target) <pid_to_str>: Change return
13614         type.
13615         (procfs_target::pid_to_str): Change return type.
13616         (procfs_target::attach): Update.
13617         (procfs_target::detach): Update.
13618         (procfs_target::fetch_registers): Update.
13619         (procfs_target::store_registers): Update.
13620         (procfs_target::wait): Update.
13621         (procfs_target::files_info): Update.
13622         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13623         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13624         return type.
13625         (nto_procfs_target::pid_to_str): Change return type.
13626         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13627         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13628         return type.
13629         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13630         (exit_lwp): Update.
13631         (attach_proc_task_lwp_callback, get_detach_signal)
13632         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13633         (linux_nat_target::resume, wait_lwp, stop_callback)
13634         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13635         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13636         (linux_nat_wait_1, resume_stopped_resumed_lwps)
13637         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13638         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13639         type.
13640         (inf_ptrace_target::attach): Update.
13641         (inf_ptrace_target::files_info): Update.
13642         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13643         type.
13644         (go32_nat_target::pid_to_str): Change return type.
13645         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13646         (gnu_nat_target::wait): Update.
13647         (gnu_nat_target::wait): Update.
13648         (gnu_nat_target::resume): Update.
13649         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13650         (fbsd_nat_target::wait): Update.
13651         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13652         type.
13653         (darwin_nat_target::attach): Update.
13654         * corelow.c (class core_target) <pid_to_str>: Change return type.
13655         (core_target::pid_to_str): Change return type.
13656         * target.c (normal_pid_to_str): Change return type.
13657         (default_pid_to_str): Likewise.
13658         (target_pid_to_str): Change return type.
13659         (target_translate_tls_address): Update.
13660         (target_announce_detach): Update.
13661         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13662         return type.
13663         (bsd_uthread_target::pid_to_str): Change return type.
13664         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13665         type.
13666         (bsd_kvm_target::pid_to_str): Change return type.
13667         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13668         return type.
13669         (aix_thread_target::pid_to_str): Change return type.
13670         * target.h (struct target_ops) <pid_to_str>: Change return type.
13671         (target_pid_to_str, normal_pid_to_str): Likewise.
13672         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13673         type.
13674         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13675         type.
13676         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13677         return type.
13678         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13679         type.
13680         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13681         type.
13682         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13683         return type.
13684
13685 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
13686
13687         * NEWS: Mention that the new default MI version is 3.  Mention
13688         changes to the output of commands and events that deal with
13689         multi-location breakpoints.
13690         * breakpoint.c: Include "mi/mi-out.h".
13691         (print_one_breakpoint): Change output syntax if using MI version
13692         >= 3.
13693         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13694         New.
13695         (mi_multi_location_breakpoint_output_fixed): New.
13696         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13697         (mi_cmd_fix_multi_location_breakpoint_output): New.
13698         (mi_multi_location_breakpoint_output_fixed): New.
13699         * mi/mi-cmds.c (mi_cmds): Register command
13700         -fix-multi-location-breakpoint-output.
13701         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13702         interpreter "mi".
13703
13704 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
13705
13706         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13707         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13708         instantiate mi_ui_out based on interpreter name.
13709         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13710         * mi/mi-main.c (mi_load_progress): Likewise.
13711
13712 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13713
13714         * NEWS: Combine separate "New targets" sections for 8.3.
13715
13716 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13717
13718         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13719         (ppcfbsd_init_abi): Install gdbarch
13720         "fetch_tls_load_module_address" and "get_thread_local_address"
13721         methods.
13722
13723 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13724
13725         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13726         (riscv_fbsd_init_abi): Install gdbarch
13727         "fetch_tls_load_module_address" and "get_thread_local_address"
13728         methods.
13729
13730 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13731
13732         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13733         (i386fbsd_init_abi): Install gdbarch
13734         "fetch_tls_load_module_address" and "get_thread_local_address"
13735         methods.
13736
13737 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13738
13739         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13740         (amd64fbsd_init_abi): Install gdbarch
13741         "fetch_tls_load_module_address" and "get_thread_local_address"
13742         methods.
13743
13744 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13745
13746         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13747         (struct fbsd_pspace_data): New type.
13748         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13749         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13750         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13751         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13752         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13753
13754 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13755
13756         * gdbtypes.c (lookup_struct_elt): New function.
13757         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13758         * gdbtypes.h (struct struct_elt): New type.
13759         (lookup_struct_elt): New prototype.
13760
13761 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13762
13763         * gdbtypes.c (lookup_struct_elt_type): Update comment and
13764         remove disabled code block.
13765
13766 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13767
13768         * gdbarch.sh (get_thread_local_address): New method.
13769         * gdbarch.h, gdbarch.c: Regenerate.
13770         * target.c (target_translate_tls_address): Use
13771         gdbarch_get_thread_local_address if present instead of
13772         target::get_thread_local_address.
13773
13774 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13775
13776         * target.h (target::get_thread_local_address): Update comment.
13777
13778 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13779
13780         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13781         objfile->separate_debug_objfile_backlink if not NULL.
13782
13783 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13784
13785         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13786         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13787         (amd64bsd_store_inferior_registers): Likewise.
13788         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13789         Enable segment base registers.
13790         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13791         PT_GETFSBASE and PT_GETGSBASE.
13792         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13793         PT_SETGSBASE.
13794         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13795         segment base registers.
13796         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13797
13798 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13799
13800         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13801         Update calls to i386_target_description to add 'segments'
13802         parameter.
13803         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
13804         add segment base registers.
13805         * arch/i386.c (i386_create_target_description): Add 'segments'
13806         parameter to enable segment base registers.
13807         * arch/i386.h (i386_create_target_description): Likewise.
13808         * features/i386/32bit-segments.xml: New file.
13809         * features/i386/32bit-segments.c: Generate.
13810         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13811         call to i386_target_description to add 'segments' parameter.
13812         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13813         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13814         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13815         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13816         if feature is present.
13817         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13818         Add 'segments' parameter to call to i386_target_description.
13819         (i386_target_description): Add 'segments' parameter to enable
13820         segment base registers.
13821         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13822         to call to i386_target_description.
13823         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13824         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13825         Define I386_NUM_REGS.
13826         (i386_target_description): Add 'segments' parameter to enable
13827         segment base registers.
13828
13829 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
13830
13831         PR/24325
13832         * source-cache.c: #undef open and close, to avoid unresolved
13833         externals during linking.
13834
13835 2019-03-12  Tom Tromey  <tromey@adacore.com>
13836
13837         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13838         const.  Add initializers.
13839         (_initialize_remote): Don't initialize ptid globals.
13840
13841 2019-03-12  Pedro Alves  <palves@redhat.com>
13842
13843         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13844
13845 2019-03-12  Pedro Alves  <palves@redhat.com>
13846
13847         * cp-name-parser.y (main): Remove unused 'len' variable.
13848
13849 2019-03-12  Tom Tromey  <tromey@adacore.com>
13850
13851         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13852         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13853
13854 2019-03-12  Tom Tromey  <tromey@adacore.com>
13855
13856         * linux-nat.c (iterate_over_lwps): Update.
13857         (stop_callback): Remove parameter.
13858         (stop_wait_callback, detach_callback, resume_set_callback)
13859         (select_singlestep_lwp_callback, set_ignore_sigint)
13860         (status_callback, resumed_callback, resume_clear_callback)
13861         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13862         data parameter.
13863         (linux_nat_target::detach, linux_nat_target::resume)
13864         (linux_stop_and_wait_all_lwps, select_event_lwp)
13865         (linux_nat_filter_event, linux_nat_wait_1)
13866         (linux_nat_target::kill, linux_nat_target::stop)
13867         (linux_nat_target::stop): Update.
13868         (linux_nat_resume_callback): Change type.
13869         (resume_stopped_resumed_lwps, count_events_callback)
13870         (select_event_lwp_callback): Likewise.
13871         (linux_stop_lwp, linux_nat_stop_lwp): Update.
13872         * arm-linux-nat.c (struct update_registers_data): Remove.
13873         (update_registers_callback): Change type.
13874         (arm_linux_insert_hw_breakpoint1): Update.
13875         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13876         parameter.
13877         (x86_linux_dr_set_addr): Update.
13878         (x86_linux_dr_set_control): Update.
13879         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13880         (iterate_over_lwps): Use gdb::function_view.
13881         * nat/aarch64-linux-hw-point.c (struct
13882         aarch64_dr_update_callback_param): Remove.
13883         (debug_reg_change_callback): Change type.
13884         (aarch64_notify_debug_reg_change): Update.
13885         * s390-linux-nat.c (s390_refresh_per_info): Update.
13886
13887 2019-03-11  Tom Tromey  <tromey@adacore.com>
13888
13889         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13890         redundant assignment to "this_cu".
13891
13892 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13893
13894         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13895
13896 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13897
13898         * gdbtypes.c (rank_one_type_parm_set): New function extracted
13899         from...
13900         (rank_one_type): ... this.
13901
13902 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13903
13904         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13905         from...
13906         (rank_one_type): ... this.
13907
13908 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13909
13910         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13911         from...
13912         (rank_one_type): ... this.
13913
13914 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13915
13916         * gdbtypes.c (rank_one_type_parm_float): New function extracted
13917         from...
13918         (rank_one_type): ... this.
13919
13920 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13921
13922         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13923         from...
13924         (rank_one_type): ... this.
13925
13926 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13927
13928         * gdbtypes.c (rank_one_type_parm_range): New function extracted
13929         from...
13930         (rank_one_type): ... this.
13931
13932 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13933
13934         * gdbtypes.c (rank_one_type_parm_char): New function extracted
13935         from...
13936         (rank_one_type): ... this.
13937
13938 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13939
13940         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13941         from...
13942         (rank_one_type): ... this.
13943
13944 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13945
13946         * gdbtypes.c (rank_one_type_parm_int): New function extracted
13947         from...
13948         (rank_one_type): ... this.
13949
13950 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13951
13952         * gdbtypes.c (rank_one_type_parm_func): New function extracted
13953         from...
13954         (rank_one_type): ... this.
13955
13956 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13957
13958         * gdbtypes.c (rank_one_type_parm_array): New function extracted
13959         from...
13960         (rank_one_type): ... this.
13961
13962 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13963
13964         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13965         from...
13966         (rank_one_type): ... this.
13967
13968 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13969
13970         * inferior.c (initialize_inferiors): Ensure 'help set/show print
13971         inferior-events' shows the example events.
13972
13973 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
13974
13975         Support styling on native MS-Windows console
13976
13977         PR/24315
13978         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13979         on MS-Windows if $TERM is not defined.
13980
13981         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13982
13983         * posix-hdep.c (gdb_console_fputs):
13984         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13985         functions.
13986         * ui-file.h (gdb_console_fputs): Add prototype.
13987
13988         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13989         back to fputs only if the former returns zero.
13990
13991 2019-03-07  Tom Tromey  <tom@tromey.com>
13992
13993         * symmisc.c (print_symbol_bcache_statistics): Update.
13994         (print_objfile_statistics): Update.
13995         * symfile.c (allocate_symtab): Update.
13996         * stabsread.c: Don't include bcache.h.
13997         * psymtab.h (struct psymbol_bcache): Don't declare.
13998         (class psymtab_storage) <psymbol_cache>: Now a bcache.
13999         (psymbol_bcache_init, psymbol_bcache_free)
14000         (psymbol_bcache_get_bcache): Don't declare.
14001         * psymtab.c (struct psymbol_bcache): Remove.
14002         (psymtab_storage::psymtab_storage): Update.
14003         (psymtab_storage::~psymtab_storage): Update.
14004         (psymbol_bcache_init, psymbol_bcache_free)
14005         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
14006         (add_psymbol_to_bcache): Update.
14007         (allocate_psymtab): Update.
14008         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
14009         macro_cache>: No longer pointers.
14010         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
14011         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
14012         * macrotab.c (macro_bcache): Update.
14013         * macroexp.c: Don't include bcache.h.
14014         * gdbtypes.c (check_types_worklist): Update.
14015         (types_deeply_equal): Remove TRY/CATCH.  Update.
14016         * elfread.c (elf_symtab_read): Update.
14017         * dwarf2read.c: Don't include bcache.h.
14018         * buildsym.c (buildsym_compunit::get_macro_table): Update.
14019         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
14020         (print_bcache_statistics, bcache_memory_used): Don't declare.
14021         (struct bcache): Move from bcache.c.  Add constructor, destructor,
14022         methods.  Rename all data members.
14023         * bcache.c (struct bcache): Move to bcache.h.
14024         (bcache::expand_hash_table): Rename from expand_hash_table.
14025         (bcache): Remove.
14026         (bcache::insert): Rename from bcache_full.
14027         (bcache::compare): Rename from bcache_compare.
14028         (bcache_xmalloc): Remove.
14029         (bcache::~bcache): Rename from bcache_xfree.
14030         (bcache::print_statistics): Rename from print_bcache_statistics.
14031         (bcache::memory_used): Rename from bcache_memory_used.
14032
14033 2019-03-07  Pedro Alves  <palves@redhat.com>
14034
14035         * infrun.c (normal_stop): Also check for
14036         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
14037
14038 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
14039
14040         * f-lang.c (value_from_host_double): Moved to...
14041         * value.c (value_from_host_double): ...here.
14042         * value.h (value_from_host_double): Declare.
14043         * guile/scm-math.c (vlscm_convert_typed_number): Use
14044         value_from_host_double.
14045         (vlscm_convert_number): Likewise.
14046         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
14047         * python/py-value.c (convert_value_from_python): Likewise.
14048
14049 2019-03-06  Tom Tromey  <tom@tromey.com>
14050
14051         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14052
14053 2019-03-06  Tom Tromey  <tom@tromey.com>
14054
14055         * utils.h (free_current_contents): Don't declare.
14056         * utils.c (free_current_contents): Remove.
14057
14058 2019-03-06  Tom Tromey  <tom@tromey.com>
14059
14060         * top.c (quit_force): Update.
14061         * main.c (captured_command_loop): Update.
14062         * common/new-op.c (operator new): Update.
14063         * common/common-exceptions.c (struct catcher)
14064         <save_cleanup_chain>: Remove member.
14065         (exceptions_state_mc_init): Update.
14066         (exception_try_scope_entry): Return nullptr.
14067         (exception_try_scope_exit, exception_rethrow)
14068         (throw_exception_sjlj, throw_exception_cxx): Update.
14069         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14070         (all_cleanups, do_cleanups, discard_cleanups)
14071         (discard_final_cleanups, save_cleanups, save_final_cleanups)
14072         (restore_cleanups, restore_final_cleanups): Don't declare.
14073         (do_final_cleanups): Remove parameter.
14074         * common/cleanups.c (cleanup_chain, make_cleanup)
14075         (make_cleanup_dtor, all_cleanups, do_cleanups)
14076         (discard_my_cleanups, discard_cleanups)
14077         (discard_final_cleanups, save_my_cleanups, save_cleanups)
14078         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14079         (null_cleanup): Remove.
14080         (do_final_cleanups): Remove parameter.
14081
14082 2019-03-06  Tom Tromey  <tom@tromey.com>
14083
14084         * remote.c (remote_target::remote_parse_stop_reply): Use
14085         unique_xmalloc_ptr.
14086
14087 2019-03-06  Tom Tromey  <tom@tromey.com>
14088
14089         * stabsread.c (struct stabs_field_info): Rename from field_info.
14090         <list, fnlist>: Add initializers.
14091         <obstack>: New member.
14092         (read_member_functions, read_struct_fields, read_baseclasses):
14093         Allocate on obstack.  Don't use cleanups.
14094         (read_one_struct_field, read_member_functions, read_struct_fields)
14095         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14096         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14097         (read_struct_type): Update.
14098
14099 2019-03-06  Tom Tromey  <tom@tromey.com>
14100
14101         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14102         * common/filestuff.h (make_cleanup_close): Don't declare.
14103         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14104         Remove.
14105
14106 2019-03-06  Tom Tromey  <tom@tromey.com>
14107
14108         * solib-aix.c: Use make_scope_exit.
14109
14110 2019-03-06  Tom Tromey  <tom@tromey.com>
14111
14112         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14113         Use make_scope_exit.
14114
14115 2019-03-06  Tom Tromey  <tom@tromey.com>
14116
14117         * solib-svr4.c (disable_probes_interface): Remove parameter.
14118         (svr4_handle_solib_event): Use make_scope_exit.
14119
14120 2019-03-06  Tom Tromey  <tom@tromey.com>
14121
14122         * remote.c (struct stop_reply_deleter): Remove.
14123         (stop_reply_up): Update.
14124         (struct stop_reply): Derive from notif_event.  Don't typedef.
14125         <regcache>: Now a std::vector.
14126         (stop_reply_xfree): Remove.
14127         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14128         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
14129         (remote_target::discard_pending_stop_replies): Use delete.
14130         (remote_target::remote_parse_stop_reply): Update.
14131         (remote_target::process_stop_reply): Update.
14132         * remote-notif.h (struct notif_event): Add virtual destructor.
14133         Remove "dtr" member.
14134         (struct notif_client) <alloc_event>: Return a unique_ptr.
14135         (notif_event_xfree): Don't declare.
14136         (notif_event_up): New typedef.
14137         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14138         (notif_event_xfree, do_notif_event_xfree): Remove.
14139         (remote_notif_state_xfree): Update.
14140
14141 2019-03-06  Tom Tromey  <tom@tromey.com>
14142
14143         * infrun.c (displaced_step_clear_cleanup): Now a
14144         forward_scope_exit type.
14145         (displaced_step_prepare_throw): Update.
14146         (displaced_step_fixup): Update.
14147
14148 2019-03-06  Tom Tromey  <tom@tromey.com>
14149
14150         * inferior.h (class inferior): Update comment.
14151         * gdbthread.h (class thread_info): Update comment.
14152
14153 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
14154             Tom Tromey  <tom@tromey.com>
14155
14156         * stabsread.h (struct stab_section_list): Remove.
14157         (coffstab_build_psymtabs): Update.
14158         * dbxread.c (symbuf_sections): Now a std::vector.
14159         (sect_idx): New global.
14160         (fill_symbuf): Update.
14161         (coffstab_build_psymtabs): Change type of stabsects parameter.
14162         Update.
14163         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14164         std::vector.
14165         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14166         (coff_locate_sections): Update.
14167         (coff_symfile_read): Remove cleanups.  Update.
14168         (init_stringtab): Add storage parameter.
14169         (free_stringtab, free_stringtab_cleanup): Remove.
14170         (init_lineno): Add storage parameter.
14171         (free_linetab, free_linetab_cleanup): Remove.
14172
14173 2019-03-06  Pedro Alves  <palves@redhat.com>
14174
14175         * linux-fork.c (fork_info::clobber_regs): Delete.
14176         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14177         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
14178         comment.  Adjust.
14179         (scoped_switch_fork_info::scoped_switch_fork_info)
14180         (checkpoint_command, linux_fork_context): Adjust
14181         fork_save_infrun_state calls.
14182
14183 2019-03-06  Pedro Alves  <palves@redhat.com>
14184
14185         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14186         (inf_has_multiple_threads): Return 'bool' and rewrite using
14187         inferior_info::threads().
14188
14189 2019-03-06  Pedro Alves  <palves@redhat.com>
14190
14191         * linux-fork.c: Include <list>.
14192         (fork_list): Now a std::list instance.
14193         (fork_info): Add ctor, dtor, and in-class initialize all fields.
14194         (forks_exist_p, find_last_fork): Adjust.
14195         (new_fork): Delete.
14196         (one_fork_p): New.
14197         (add_fork): Adjust.
14198         (free_fork): Delete, folded into fork_info::~fork_info().
14199         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14200         Adjust.
14201         (init_fork_list): Delete.
14202         (linux_fork_killall, linux_fork_mourn_inferior)
14203         (linux_fork_detach, info_checkpoints_command): Adjust.
14204         (_initialize_linux_fork): No longer call init_fork_list.
14205
14206 2019-03-06  Pedro Alves  <palves@redhat.com>
14207
14208         * linux-fork.c (new_fork): New, split out of ...
14209         (add_fork): ... this.  Return void.  Move "first fork" special
14210         case from here, to ...
14211         (checkpoint_command): ... here.
14212         * linux-linux.h (add_fork): Return void.
14213
14214 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14215
14216         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14217
14218 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14219             Chris January  <chris.january@arm.com>
14220             David Lecomber  <david.lecomber@arm.com>
14221
14222         * f-exp.y: New token, UNOP_INTRINSIC.
14223         (exp): New pattern using UNOP_INTRINSIC token.
14224         (f77_keywords): Add 'abs' keyword.
14225         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14226         (value_from_host_double): New function.
14227         (evaluate_subexp_f): Support UNOP_ABS.
14228
14229 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14230
14231         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14232         types.
14233
14234 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14235
14236         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14237         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14238         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14239
14240 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14241
14242         * f-exp.y (convert_to_kind_type): Handle more type kinds.
14243
14244 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14245             Chris January  <chris.january@arm.com>
14246
14247         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14248         * f-exp.y: Define 'KIND' token.
14249         (exp): New pattern for KIND expressions.
14250         (ptype): Handle types with a kind extension.
14251         (direct_abs_decl): Extend to spot kind extensions.
14252         (f77_keywords): Add 'kind' to the list.
14253         (push_kind_type): New function.
14254         (convert_to_kind_type): New function.
14255         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14256         * parse.c (operator_length_standard): Likewise.
14257         * parser-defs.h (enum type_pieces): Add tp_kind.
14258         * std-operator.def: Add UNOP_KIND.
14259
14260 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14261
14262         * f-exp.y (f_parse): Set yydebug.
14263
14264 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14265
14266         * f-lang.c (evaluate_subexp_f): New function.
14267         (exp_descriptor_f): New global.
14268         (f_language_defn): Use exp_descriptor_f instead of
14269         exp_descriptor_standard.
14270
14271 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14272
14273         * f-exp.y (struct token): Add comments.
14274         (dot_ops): Remove uppercase versions and the end marker.
14275         (f77_keywords): Likewise.
14276         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14277         entries in the dot_ops array are case insensitive, and use
14278         strncasecmp to compare strings.  Also some whitespace cleanup in
14279         this area.  Similar for the f77_keywords array, except entries in
14280         this list might be case sensitive.
14281
14282 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14283
14284         * f-exp.y (struct f77_boolean_val): Add comments.
14285         (boolean_values): Remove uppercase versions, and end marker.
14286         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14287         and use strncasecmp to achieve case insensitivity.  Additionally,
14288         perform whitespace cleanup around this code.
14289
14290 2019-03-06  Tom Tromey  <tromey@adacore.com>
14291
14292         * remote-sim.c (gdbsim_target_open): Use result of
14293         gdb_argv::release.
14294
14295 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
14296         Dirk Schubert  <dirk.schubert@arm.com>
14297         Chris January  <chris.january@arm.com>
14298
14299         * eval.c (evaluate_subexp_standard): Call Fortran argument
14300         wrapping logic.
14301         * f-lang.c (struct value): A value which can be passed into a
14302         Fortran function call.
14303         (fortran_argument_convert): Wrap Fortran arguments in a pointer
14304         where appropriate.
14305         (struct type): Value ready for a Fortran function call.
14306         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14307         is needed.
14308         * f-lang.h (fortran_argument_convert): Declaration.
14309         (fortran_preserve_arg_pointer): Declaration.
14310         * infcall.c (value_arg_coerce): Call Fortran argument logic.
14311
14312 2019-03-05  Tom Tromey  <tromey@adacore.com>
14313
14314         * python/py-prettyprint.c (print_string_repr): Remove #if.
14315         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14316
14317 2019-03-05  Tom Tromey  <tromey@adacore.com>
14318
14319         * target.c (the_dummy_target): Move later.  Change type to
14320         "dummy_target".
14321         (initialize_targets): Don't initialize the_dummy_target.
14322
14323 2019-03-05  Tom Tromey  <tromey@adacore.com>
14324
14325         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14326         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14327
14328 2019-03-05  Tom Tromey  <tromey@adacore.com>
14329
14330         * windows-nat.c (windows_nat_target::attach)
14331         (windows_nat_target::detach): Don't call gdb_flush.
14332         * valprint.c (generic_val_print, val_print, val_print_string):
14333         Don't call gdb_flush.
14334         * utils.c (defaulted_query): Don't call gdb_flush.
14335         * typeprint.c (print_type_scalar): Don't call gdb_flush.
14336         * target.c (target_announce_detach): Don't call gdb_flush.
14337         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14338         * remote.c (extended_remote_target::attach): Don't call
14339         gdb_flush.
14340         * procfs.c (procfs_target::detach): Don't call gdb_flush.
14341         * printcmd.c (do_examine): Don't call gdb_flush.
14342         (info_display_command): Don't call gdb_flush.
14343         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14344         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14345         * memattr.c (info_mem_command): Don't call gdb_flush.
14346         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14347         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14348         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14349         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14350         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14351         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14352         (gnu_nat_target::detach): Don't call gdb_flush.
14353         * f-valprint.c (f_val_print): Don't call gdb_flush.
14354         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14355         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14356         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14357         gdb_flush.
14358         * c-valprint.c (c_val_print): Don't call gdb_flush.
14359         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14360
14361 2019-03-05  Tom Tromey  <tromey@adacore.com>
14362
14363         * varobj.c (update_dynamic_varobj_children): Update.
14364         (install_default_visualizer): Use reset, not release.
14365         * value.c (set_internalvar): Update.
14366         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14367         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14368         ATTRIBUTE_UNUSED_RESULT.
14369
14370 2019-03-05  Tom Tromey  <tromey@adacore.com>
14371
14372         * remote.c (class scoped_remote_fd) <release>: Add
14373         ATTRIBUTE_UNUSED_RESULT.
14374
14375 2019-03-05  Tom Tromey  <tromey@adacore.com>
14376
14377         * macroexp.c (struct macro_buffer) <release>: Add
14378         ATTRIBUTE_UNUSED_RESULT.
14379
14380 2019-03-05  Tom Tromey  <tromey@adacore.com>
14381
14382         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14383         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14384         ATTRIBUTE_UNUSED_RESULT.
14385
14386 2019-03-05  Tom Tromey  <tromey@adacore.com>
14387
14388         * common/scoped_fd.h (class scoped_fd) <release>: Add
14389         ATTRIBUTE_UNUSED_RESULT.
14390
14391 2019-03-05  Tom Tromey  <tromey@adacore.com>
14392
14393         * parser-defs.h (struct parser_state) <release>: Add
14394         ATTRIBUTE_UNUSED_RESULT.
14395
14396 2019-03-05  Tom Tromey  <tromey@adacore.com>
14397
14398         * utils.h (class gdb_argv) <release>: Add
14399         ATTRIBUTE_UNUSED_RESULT.
14400         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14401
14402 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
14403
14404         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14405         for-loop range, to avoid compiler warnings.
14406
14407         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14408         avoid compiler warnings about unused variables.
14409
14410         * NEWS: Mention end of support for native debugging on MS-Windows
14411         before XP.
14412
14413         PR gdb/24292
14414         * common/netstuff.c:
14415         * gdbserver/gdbreplay.c
14416         * gdbserver/remote-utils.c:
14417         * ser-tcp.c:
14418         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14419         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
14420         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14421         'getaddrinfo' and 'freeaddrinfo' were not available before
14422         Windows XP, and mingw.org's MinGW headers by default define
14423         _WIN32_WINNT to 0x500.
14424
14425 2019-03-01  Gary Benson <gbenson@redhat.com>
14426
14427         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14428
14429 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
14430             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
14431
14432         PR gdb/8527
14433         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14434         set_sigint_trap, clear_sigint_trap.
14435
14436 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14437
14438         * target.c (target_detach): Clear the regcache and the
14439         frame cache.
14440
14441 2019-02-27  Pedro Alves  <palves@redhat.com>
14442
14443         * utils.c (set_screen_size): When we cap the height/width sizes,
14444         tweak the corresponding command variable to show "unlimited":
14445
14446 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
14447             Pedro Alves  <palves@redhat.com>
14448
14449         * utils.c (set_screen_size): Reduce "infinite" rows and columns
14450         before calling rl_set_screen_size.
14451
14452 2019-02-27  Tom Tromey  <tromey@adacore.com>
14453
14454         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14455         define.
14456         * python/py-value.c: Remove Python 2.4 workaround.
14457         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14458         workaround.
14459         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14460         Python 2.4 workaround.
14461         * python/python-internal.h: Remove Python 2.4 comment.
14462         (Py_ssize_t): Don't define.
14463         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14464         (gdb_Py_DECREF): Remove Python 2.4 workaround.
14465         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14466         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14467         * python/python.c (do_start_initialization): Remove Python 2.4
14468         workaround.
14469         * python/py-prettyprint.c (class dummy_python_frame): Remove.
14470         (print_children): Remove Python 2.4 workaround.
14471         * python/py-inferior.c (buffer_procs): Remove Python 2.4
14472         workaround.
14473         (CHARBUFFERPROC_NAME): Remove.
14474         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14475         Python 2.4 workaround.
14476
14477 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14478
14479         * NEWS: Note minimum Python version.
14480
14481 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14482
14483         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14484         code from these functions.  Remove corresponding ifdefs.  Use
14485         Py_buffer_up instead of explicit calls to PyBuffer_Release.
14486         Remove gotos and target of gotos.
14487         (infpy_search_memory): Likewise.
14488
14489 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14490
14491         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14492         (hppa_gdbarch_init): Don't register deleted functions with
14493         gdbarch.
14494
14495 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14496
14497         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14498         (h8300_unwind_sp): Delete.
14499         (h8300_dummy_id): Delete.
14500         (h8300_gdbarch_init): Don't register deleted functions with
14501         gdbarch.
14502
14503 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14504
14505         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14506         (ft32_unwind_pc): Delete.
14507         (ft32_unwind_sp): Delete.
14508         (ft32_gdbarch_init): Don't register deleted functions with
14509         gdbarch.
14510
14511 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14512
14513         * gdb/frv-tdep.c (frv_dummy_id): Delete.
14514         (frv_unwind_pc): Delete.
14515         (frv_unwind_sp): Delete.
14516         (frv_gdbarch_init): Don't register deleted functions with
14517         gdbarch.
14518
14519 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14520
14521         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14522         (riscv_unwind_pc): Delete.
14523         (riscv_unwind_sp): Delete.
14524         (riscv_gdbarch_init): Don't register deleted functions with
14525         gdbarch.
14526
14527 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14528
14529         * gdb/csky-tdep.c (csky_dummy_id): Delete.
14530         (csky_unwind_pc): Delete.
14531         (csky_unwind_sp): Delete.
14532         (csky_gdbarch_init): Don't register deleted functions with
14533         gdbarch.
14534
14535 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14536
14537         * gdb/cris-tdep.c (cris_dummy_id): Delete.
14538         (cris_unwind_pc): Delete.
14539         (cris_unwind_sp): Delete.
14540         (cris_gdbarch_init): Don't register deleted functions with
14541         gdbarch.
14542
14543 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14544
14545         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14546         (bfin_unwind_pc): Delete.
14547         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14548
14549 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14550
14551         * gdb/arm-tdep.c (arm_dummy_id): Delete.
14552         (arm_unwind_pc): Delete.
14553         (arm_unwind_sp): Delete.
14554         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14555
14556 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14557
14558         * gdb/arc-tdep.c (arc_dummy_id): Delete.
14559         (arc_unwind_pc): Delete.
14560         (arc_unwind_sp): Delete.
14561         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14562
14563 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14564
14565         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14566         (alpha_unwind_pc): Delete.
14567         (alpha_gdbarch_init): Don't register deleted functions with
14568         gdbarch.
14569
14570 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14571
14572         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14573         (aarch64_unwind_pc): Delete.
14574         (aarch64_unwind_sp): Delete.
14575         (aarch64_gdbarch_init): Don't register deleted functions with
14576         gdbarch.
14577
14578 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14579
14580         * gdbtypes.c (type_align): Don't consider static members when
14581         computing structure alignment.
14582
14583 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14584
14585         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14586         return 0 for other types.
14587         * arch-utils.c (default_type_align): Always return 0.
14588         * gdbarch.h: Regenerate.
14589         * gdbarch.sh (type_align): Extend comment.
14590         * gdbtypes.c (type_align): Add additional comments, always call
14591         gdbarch_type_align before applying the default rules.
14592         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14593         generic code will then apply a suitable default.
14594         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14595         types, return 0 for other types.
14596
14597 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14598
14599         * NEWS: Create a new section for the next release branch.
14600         Rename the section of the current branch, now that it has
14601         been cut.
14602
14603 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14604
14605         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14606         * version.in: Bump version to 8.3.50.DATE-git.
14607
14608 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
14609
14610         * aix-thread.c (ptid_cmp): Remove unused variable.
14611         (get_signaled_thread): Likewise.
14612         (store_regs_user_thread): Likewise.
14613         (store_regs_kernel_thread): Likewise.
14614         (fetch_regs_kernel_thread): Remove shadowed variable.
14615
14616 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
14617
14618         * features/riscv/32bit-cpu.xml: Add register numbers.
14619         * features/riscv/32bit-fpu.c: Regenerate.
14620         * features/riscv/32bit-fpu.xml: Add register numbers.
14621         * features/riscv/64bit-cpu.xml: Add register numbers.
14622         * features/riscv/64bit-fpu.c: Regenerate.
14623         * features/riscv/64bit-fpu.xml: Add register numbers.
14624
14625 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
14626
14627         * NEWS: Mention two argument form of gdb.Value constructor.
14628         * python/py-value.c (convert_buffer_and_type_to_value): New
14629         function.
14630         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14631         Add support for handling an optional second argument.  Call
14632         convert_buffer_and_type_to_value as appropriate.
14633         * python/python-internal.h (Py_buffer_deleter): New struct.
14634         (Py_buffer_up): New typedef.
14635
14636 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
14637
14638         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14639         instead of releasing ownership.
14640
14641 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
14642
14643         * dwarf2read.c (open_and_init_dwp_file): Call
14644         elf_numsections instead of bfd_count_sections to initialize
14645         dwp_file->num_sections.
14646
14647 2019-02-25  Tom Tromey  <tromey@adacore.com>
14648
14649         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14650
14651 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
14652
14653         * gcore.in: Add '--readnever' option when invoking GDB.
14654
14655 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14656
14657         * MAINTAINERS: Update my email address.
14658
14659 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14660
14661         * build-id.c (build_id_to_debug_bfd_1): New function.
14662         (build_id_to_debug_bfd): Look for separate debug file in
14663         sysroot.
14664
14665 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
14666
14667         * gdbarch.sh: Update the copyright year range that is placed into
14668         generated files.
14669
14670 2019-02-22  Keith Seitz  <keiths@redhat.com>
14671
14672         PR symtab/23853
14673         * linespec.c (create_sals_line_offset): Search for the default
14674         symtab's filename instead of its fullname.
14675
14676 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14677
14678         * NEWS: Update style defaults.
14679
14680 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14681
14682         * main.c (captured_main_1): Disable styling in batch mode.
14683
14684 2019-02-20  Tom Tromey  <tom@tromey.com>
14685
14686         * symtab.c (symtab_symbol_info): Fix typos.
14687
14688 2019-02-20  Tom Tromey  <tromey@adacore.com>
14689
14690         * findcmd.c (_initialize_mem_search): Use upper case for
14691         metasyntactic variables.
14692
14693 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
14694
14695         * aarch64-tdep.c (aarch64_add_reggroups): New function.
14696         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14697
14698 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
14699
14700         * top.h (source_file_name): Change to std::string.
14701         * top.c (source_file_name): Likewise.
14702         (command_line_input): Adjust.
14703         * cli/cli-script.c (script_from_file): Adjust.
14704
14705 2019-02-19  Tom Tromey  <tromey@adacore.com>
14706
14707         * ravenscar-thread.c
14708         (ravenscar_thread_target::update_thread_list): Don't call
14709         ada_build_task_list.
14710         * ada-lang.h (ada_build_task_list): Don't declare.
14711         * ada-tasks.c (struct ada_tasks_inferior_data)
14712         <task_list_valid_p>: Now bool.
14713         (read_known_tasks, ada_task_list_changed)
14714         (ada_tasks_invalidate_inferior_data): Update.
14715         (read_known_tasks_array): Return bool.
14716         (read_known_tasks_list): Likewise.
14717         (read_known_tasks): Return void.
14718         (ada_build_task_list): Now static.
14719
14720 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
14721
14722         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14723         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14724
14725 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14726
14727         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14728         variant for ada_tasks_pspace_data_handle and
14729         ada_tasks_inferior_data_handle.
14730         (ada_tasks_pspace_data_cleanup): New function.
14731         (ada_tasks_inferior_data_cleanup): New function.
14732
14733 2019-02-17  Tom Tromey  <tom@tromey.com>
14734
14735         * macrotab.h (macro_source_fullname): Return a std::string.
14736         * macrotab.c (macro_include, check_for_redefinition)
14737         (macro_undef, macro_lookup_definition, foreach_macro)
14738         (foreach_macro_in_scope): Update.
14739         (macro_source_fullname): Return a std::string.
14740         * macrocmd.c (show_pp_source_pos): Update.
14741
14742 2019-02-17  Tom Tromey  <tom@tromey.com>
14743
14744         * macrocmd.c (show_pp_source_pos): Style the file names.
14745
14746 2019-02-17  Tom Tromey  <tom@tromey.com>
14747
14748         PR tui/24197:
14749         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14750
14751 2019-02-17  Tom Tromey  <tom@tromey.com>
14752
14753         * ada-lang.c (user_select_syms): Use filtered printing.
14754         * utils.c (wrap_style): New global.
14755         (desired_style): Remove.
14756         (emit_style_escape): Add stream parameter.
14757         (set_output_style, reset_terminal_style, prompt_for_continue):
14758         Update.
14759         (flush_wrap_buffer): Only flush gdb_stdout.
14760         (wrap_here): Set wrap_style.
14761         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
14762         treat escape sequences as a character.  Change when wrap buffer is
14763         flushed.
14764         (fputs_styled): Do not set the output style when the default is
14765         requested.
14766         * ui-style.h (struct ui_file_style) <is_default>: New method.
14767         * source.c (print_source_lines_base): Emit escape sequences in one
14768         piece.
14769
14770 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14771
14772         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14773         integers and enumeration types.
14774
14775 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14776
14777         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14778         instead of lookup_symbol_in_language
14779         (do_exact_match): New function.
14780         (ada_get_symbol_name_matcher): Return do_exact_match when
14781         doing a verbatim match.
14782
14783 2019-02-15  Tom Tromey  <tromey@adacore.com>
14784
14785         * ravenscar-thread.c (ravenscar_thread_target::resume)
14786         (ravenscar_thread_target::wait): Special case wildcard requests.
14787
14788 2019-02-15  Tom Tromey  <tromey@adacore.com>
14789
14790         * ravenscar-thread.c (base_ptid): Remove.
14791         (struct ravenscar_thread_target) <close>: New method.
14792         <m_base_ptid>: New member.
14793         <update_inferior_ptid, active_task, task_is_currently_active,
14794         runtime_initialized>: Declare methods.
14795         <ravenscar_thread_target>: Add constructor.
14796         (ravenscar_thread_target::task_is_currently_active)
14797         (ravenscar_thread_target::update_inferior_ptid)
14798         (ravenscar_runtime_initialized): Rename.  Now methods.
14799         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14800         (ravenscar_thread_target::update_thread_list): Update.
14801         (ravenscar_thread_target::active_task): Now method.
14802         (ravenscar_thread_target::store_registers)
14803         (ravenscar_thread_target::prepare_to_store)
14804         (ravenscar_thread_target::prepare_to_store)
14805         (ravenscar_thread_target::mourn_inferior): Update.
14806         (ravenscar_inferior_created): Use "new" to create target.
14807         (ravenscar_thread_target::get_ada_task_ptid): Update.
14808         (_initialize_ravenscar): Don't initialize base_ptid.
14809         (ravenscar_ops): Remove global.
14810
14811 2019-02-15  Tom Tromey  <tromey@adacore.com>
14812
14813         * target.h (push_target): Declare new overload.
14814         * target.c (push_target): New overload, taking an rvalue reference.
14815         * remote.c (remote_target::open_1): Use push_target overload.
14816         * corelow.c (core_target_open): Use push_target overload.
14817
14818 2019-02-15  Tom Tromey  <tromey@adacore.com>
14819
14820         * ravenscar-thread.c (is_ravenscar_task)
14821         (ravenscar_task_is_currently_active): Return bool.
14822         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14823         (_initialize_ravenscar): Remove "(void)".
14824         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14825         Return bool.
14826
14827 2019-02-15  Tom Tromey  <tromey@adacore.com>
14828
14829         * ravenscar-thread.c (ravenscar_runtime_initializer)
14830         (has_ravenscar_runtime, get_running_thread_id)
14831         (ravenscar_thread_target::resume): Fix indentation.
14832
14833 2019-02-15  Tom Tromey  <tromey@adacore.com>
14834
14835         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14836         from ravenscar_arch_ops.
14837         (sparc_ravenscar_ops::fetch_registers)
14838         (sparc_ravenscar_ops::store_registers): Now methods.
14839         (sparc_ravenscar_prepare_to_store): Remove.
14840         (sparc_ravenscar_ops): Redefine.
14841         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14842         methods and destructor.  Remove members.
14843         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14844         (ravenscar_thread_target::store_registers)
14845         (ravenscar_thread_target::prepare_to_store): Update.
14846         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14847         Remove.
14848         (struct ppc_ravenscar_powerpc_ops): Derive from
14849         ravenscar_arch_ops.
14850         (ppc_ravenscar_powerpc_ops::fetch_registers)
14851         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14852         (ppc_ravenscar_powerpc_ops): Redefine.
14853         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14854         (ppc_ravenscar_e500_ops::fetch_registers)
14855         (ppc_ravenscar_e500_ops::store_registers): Now methods.
14856         (ppc_ravenscar_e500_ops): Redefine.
14857         * aarch64-ravenscar-thread.c
14858         (aarch64_ravenscar_generic_prepare_to_store): Remove.
14859         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14860         (aarch64_ravenscar_fetch_registers)
14861         (aarch64_ravenscar_store_registers): Now methods.
14862         (aarch64_ravenscar_ops): Redefine.
14863
14864 2019-02-15  Tom Tromey  <tromey@adacore.com>
14865
14866         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14867         (ravenscar_thread_target::stopped_by_hw_breakpoint)
14868         (ravenscar_thread_target::stopped_by_watchpoint)
14869         (ravenscar_thread_target::stopped_data_address)
14870         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14871
14872 2019-02-15  Tom Tromey  <tromey@adacore.com>
14873
14874         * ravenscar-thread.c: Fix some typos.
14875
14876 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14877             Tom Tromey  <tromey@adacore.com>
14878
14879         * ada-lang.c (ada_exception_sal): Change addr_string to a
14880         std::string.
14881         (create_ada_exception_catchpoint): Update.
14882
14883 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14884             Tom Tromey  <tromey@adacore.com>
14885
14886         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14887         (bp_location_ops): Remove.
14888         (base_breakpoint_allocate_location): Update.
14889         (free_bp_location): Update.
14890         * ada-lang.c (class ada_catchpoint_location)
14891         <ada_catchpoint_location>: Remove ops parameter.
14892         (ada_catchpoint_location_dtor): Remove.
14893         (ada_catchpoint_location_ops): Remove.
14894         (allocate_location_exception): Update.
14895         * breakpoint.h (struct bp_location_ops): Remove.
14896         (class bp_location) <bp_location>: Remove bp_location_ops
14897         parameter.
14898         <~bp_location>: Add destructor.
14899         <ops>: Remove.
14900
14901 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14902             Pedro Alves  <palves@redhat.com>
14903
14904         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14905         'PATH_MAX'.
14906
14907 2019-02-14  David Michael  <fedora.dm0@gmail.com>
14908             Samuel Thibault  <samuel.thibault@gnu.org>
14909             Thomas Schwinge  <thomas@codesourcery.com>
14910
14911         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14912         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14913
14914 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14915
14916         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14917         (check_empty): Use "const char *".
14918
14919         * gnu-nat.c (gnu_nat_target::detach): Instead of
14920         'detach_inferior (pid)' call
14921         'detach_inferior (find_inferior_pid (pid))'.
14922
14923         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14924         'nat/fork-inferior.o'.
14925         * gnu-nat.c: #include "nat/fork-inferior.h".
14926
14927         * gnu-nat.c (gnu_nat_target::detach): Instead of
14928         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14929         * gnu-nat.h: #include "inf-child.h".
14930         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14931         'i386_gnu_nat_target::fetch_registers'.
14932         (gnu_store_registers): Rename/move to
14933         'i386_gnu_nat_target::store_registers'.
14934
14935         * config/i386/nm-i386gnu.h: Don't "#include" any files.
14936         * gnu-nat.h (mach_thread_info): New function.
14937         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14938
14939         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14940
14941 2019-02-14  Frederic Konrad  <konrad@adacore.com>
14942
14943         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14944
14945 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
14946
14947         * windows-nat.c (windows_add_thread): Add new parameter
14948         "main_thread_p" with default value set to false.  Update
14949         function documentation as well as all callers.
14950         (windows_delete_thread): Likewise.
14951         (fake_create_process): Update call to windows_add_thread.
14952         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14953         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14954         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14955         call to windows_delete_thread.
14956
14957 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
14958
14959         * MAINTAINERS: Add Andrew Burgess as global maintainer.
14960
14961 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14962
14963         * symfile.c (find_separate_debug_file): Use canonical path of
14964         sysroot with child_path instead of gdb_sysroot if it is valid.
14965
14966 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14967
14968         * symfile.c (find_separate_debug_file): Use child_path to
14969         determine if an object file is under a sysroot.
14970
14971 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14972
14973         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14974         unittests/child-path-selftests.c.
14975         * common/pathstuff.c (child_path): New function.
14976         * common/pathstuff.h (child_path): New prototype.
14977         * unittests/child-path-selftests.c: New file.
14978
14979 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14980
14981         * symfile.c (find_separate_debug_file): Look for separate debug
14982         files in debug directories under the sysroot.
14983
14984 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14985
14986         * symtab.h (struct minimal_symbol data_p): New const method.
14987         (struct minimal_symbol text_p): Likewise.
14988         * symtab.c (output_source_filename): Use file name style
14989         to print file name.
14990         (print_symbol_info): Likewise.
14991         (print_msymbol_info): Use address style to print addresses.
14992         Use function name style to print executable text symbols.
14993         (expand_symtab_containing_pc): Use data_p.
14994         (find_pc_sect_compunit_symtab): Likewise.
14995
14996 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14997
14998         * breakpoint.c (describe_other_breakpoints): Use address style
14999         to print addresses.
15000         (say_where): Likewise.
15001
15002 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15003
15004         * ada-typeprint.c (print_func_type): Print function name
15005         style to print function name.
15006         * c-typeprint.c (c_print_type_1): Likewise.
15007
15008 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
15009
15010         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
15011         for execve.
15012
15013 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15014
15015         * c-exp.y (direct_abs_decl): Use emplace_back to record the
15016         type_stack.
15017
15018 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
15019
15020         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
15021         TYPE_CODE_REF types.
15022
15023 2019-02-08  Jim Wilson  <jimw@sifive.com>
15024
15025         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
15026         (riscv_linux_fregset): New.
15027         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
15028
15029 2019-02-07  Tom Tromey  <tom@tromey.com>
15030
15031         * thread.c (thread_cancel_execution_command): Update.
15032         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
15033         methods.
15034         (struct thread_fsm_ops): Remove.
15035         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
15036         (thread_fsm_should_stop, thread_fsm_return_value)
15037         (thread_fsm_set_finished, thread_fsm_finished_p)
15038         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
15039         Don't declare.
15040         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
15041         * infrun.c (clear_proceed_status_thread)
15042         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
15043         (print_stop_event): Update.
15044         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
15045         Add constructor.
15046         (step_command_fsm_ops): Remove.
15047         (new_step_command_fsm): Remove.
15048         (step_1): Update.
15049         (step_command_fsm::should_stop): Rename from
15050         step_command_fsm_should_stop.
15051         (step_command_fsm::clean_up): Rename from
15052         step_command_fsm_clean_up.
15053         (step_command_fsm::do_async_reply_reason): Rename from
15054         step_command_fsm_async_reply_reason.
15055         (struct until_next_fsm): Inherit from thread_fsm.  Add
15056         constructor.
15057         (until_next_fsm_ops): Remove.
15058         (new_until_next_fsm): Remove.
15059         (until_next_fsm::should_stop): Rename from
15060         until_next_fsm_should_stop.
15061         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15062         (until_next_fsm::do_async_reply_reason): Rename from
15063         until_next_fsm_async_reply_reason.
15064         (struct finish_command_fsm): Inherit from thread_fsm.  Add
15065         constructor.  Change type of breakpoint.
15066         (finish_command_fsm_ops): Remove.
15067         (new_finish_command_fsm): Remove.
15068         (finish_command_fsm::should_stop): Rename from
15069         finish_command_fsm_should_stop.
15070         (finish_command_fsm::clean_up): Rename from
15071         finish_command_fsm_clean_up.
15072         (finish_command_fsm::return_value): Rename from
15073         finish_command_fsm_return_value.
15074         (finish_command_fsm::do_async_reply_reason): Rename from
15075         finish_command_fsm_async_reply_reason.
15076         (finish_command): Update.
15077         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15078         Add constructor.
15079         (call_thread_fsm_ops): Remove.
15080         (call_thread_fsm::call_thread_fsm): Rename from
15081         new_call_thread_fsm.
15082         (call_thread_fsm::should_stop): Rename from
15083         call_thread_fsm_should_stop.
15084         (call_thread_fsm::should_notify_stop): Rename from
15085         call_thread_fsm_should_notify_stop.
15086         (run_inferior_call, call_function_by_hand_dummy): Update.
15087         * cli/cli-interp.c (should_print_stop_to_console): Update.
15088         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15089         Add constructor.  Change type of location_breakpoint,
15090         caller_breakpoint.
15091         (until_break_fsm_ops): Remove.
15092         (new_until_break_fsm): Remove.
15093         (until_break_fsm::should_stop): Rename from
15094         until_break_fsm_should_stop.
15095         (until_break_fsm::clean_up): Rename from
15096         until_break_fsm_clean_up.
15097         (until_break_fsm::do_async_reply_reason): Rename from
15098         until_break_fsm_async_reply_reason.
15099         (until_break_command): Update.
15100         * thread-fsm.c: Remove.
15101         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15102
15103 2019-02-07  Tom Tromey  <tom@tromey.com>
15104
15105         * yy-remap.h: Add include guard.
15106         * xtensa-tdep.h: Add include guard.
15107         * xcoffread.h: Rename include guard.
15108         * varobj-iter.h: Add include guard.
15109         * tui/tui.h: Rename include guard.
15110         * tui/tui-winsource.h: Rename include guard.
15111         * tui/tui-wingeneral.h: Rename include guard.
15112         * tui/tui-windata.h: Rename include guard.
15113         * tui/tui-win.h: Rename include guard.
15114         * tui/tui-stack.h: Rename include guard.
15115         * tui/tui-source.h: Rename include guard.
15116         * tui/tui-regs.h: Rename include guard.
15117         * tui/tui-out.h: Rename include guard.
15118         * tui/tui-layout.h: Rename include guard.
15119         * tui/tui-io.h: Rename include guard.
15120         * tui/tui-hooks.h: Rename include guard.
15121         * tui/tui-file.h: Rename include guard.
15122         * tui/tui-disasm.h: Rename include guard.
15123         * tui/tui-data.h: Rename include guard.
15124         * tui/tui-command.h: Rename include guard.
15125         * tic6x-tdep.h: Add include guard.
15126         * target/waitstatus.h: Rename include guard.
15127         * target/wait.h: Rename include guard.
15128         * target/target.h: Rename include guard.
15129         * target/resume.h: Rename include guard.
15130         * target-float.h: Rename include guard.
15131         * stabsread.h: Add include guard.
15132         * rs6000-tdep.h: Add include guard.
15133         * riscv-fbsd-tdep.h: Add include guard.
15134         * regformats/regdef.h: Rename include guard.
15135         * record.h: Rename include guard.
15136         * python/python.h: Rename include guard.
15137         * python/python-internal.h: Rename include guard.
15138         * python/py-stopevent.h: Rename include guard.
15139         * python/py-ref.h: Rename include guard.
15140         * python/py-record.h: Rename include guard.
15141         * python/py-record-full.h: Rename include guard.
15142         * python/py-record-btrace.h: Rename include guard.
15143         * python/py-instruction.h: Rename include guard.
15144         * python/py-events.h: Rename include guard.
15145         * python/py-event.h: Rename include guard.
15146         * procfs.h: Add include guard.
15147         * proc-utils.h: Add include guard.
15148         * p-lang.h: Add include guard.
15149         * or1k-tdep.h: Rename include guard.
15150         * observable.h: Rename include guard.
15151         * nto-tdep.h: Rename include guard.
15152         * nat/x86-linux.h: Rename include guard.
15153         * nat/x86-linux-dregs.h: Rename include guard.
15154         * nat/x86-gcc-cpuid.h: Add include guard.
15155         * nat/x86-dregs.h: Rename include guard.
15156         * nat/x86-cpuid.h: Rename include guard.
15157         * nat/ppc-linux.h: Rename include guard.
15158         * nat/mips-linux-watch.h: Rename include guard.
15159         * nat/linux-waitpid.h: Rename include guard.
15160         * nat/linux-ptrace.h: Rename include guard.
15161         * nat/linux-procfs.h: Rename include guard.
15162         * nat/linux-osdata.h: Rename include guard.
15163         * nat/linux-nat.h: Rename include guard.
15164         * nat/linux-namespaces.h: Rename include guard.
15165         * nat/linux-btrace.h: Rename include guard.
15166         * nat/glibc_thread_db.h: Rename include guard.
15167         * nat/gdb_thread_db.h: Rename include guard.
15168         * nat/gdb_ptrace.h: Rename include guard.
15169         * nat/fork-inferior.h: Rename include guard.
15170         * nat/amd64-linux-siginfo.h: Rename include guard.
15171         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15172         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15173         * nat/aarch64-linux.h: Rename include guard.
15174         * nat/aarch64-linux-hw-point.h: Rename include guard.
15175         * mn10300-tdep.h: Add include guard.
15176         * mips-linux-tdep.h: Add include guard.
15177         * mi/mi-parse.h: Rename include guard.
15178         * mi/mi-out.h: Rename include guard.
15179         * mi/mi-main.h: Rename include guard.
15180         * mi/mi-interp.h: Rename include guard.
15181         * mi/mi-getopt.h: Rename include guard.
15182         * mi/mi-console.h: Rename include guard.
15183         * mi/mi-common.h: Rename include guard.
15184         * mi/mi-cmds.h: Rename include guard.
15185         * mi/mi-cmd-break.h: Rename include guard.
15186         * m2-lang.h: Add include guard.
15187         * location.h: Rename include guard.
15188         * linux-record.h: Rename include guard.
15189         * linux-nat.h: Add include guard.
15190         * linux-fork.h: Add include guard.
15191         * i386-darwin-tdep.h: Rename include guard.
15192         * hppa-linux-offsets.h: Add include guard.
15193         * guile/guile.h: Rename include guard.
15194         * guile/guile-internal.h: Rename include guard.
15195         * gnu-nat.h: Rename include guard.
15196         * gdb-stabs.h: Rename include guard.
15197         * frv-tdep.h: Add include guard.
15198         * f-lang.h: Add include guard.
15199         * event-loop.h: Add include guard.
15200         * darwin-nat.h: Rename include guard.
15201         * cp-abi.h: Rename include guard.
15202         * config/sparc/nm-sol2.h: Rename include guard.
15203         * config/nm-nto.h: Rename include guard.
15204         * config/nm-linux.h: Add include guard.
15205         * config/i386/nm-i386gnu.h: Rename include guard.
15206         * config/djgpp/nl_types.h: Rename include guard.
15207         * config/djgpp/langinfo.h: Rename include guard.
15208         * compile/gcc-cp-plugin.h: Add include guard.
15209         * compile/gcc-c-plugin.h: Add include guard.
15210         * compile/compile.h: Rename include guard.
15211         * compile/compile-object-run.h: Rename include guard.
15212         * compile/compile-object-load.h: Rename include guard.
15213         * compile/compile-internal.h: Rename include guard.
15214         * compile/compile-cplus.h: Rename include guard.
15215         * compile/compile-c.h: Rename include guard.
15216         * common/xml-utils.h: Rename include guard.
15217         * common/x86-xstate.h: Rename include guard.
15218         * common/version.h: Rename include guard.
15219         * common/vec.h: Rename include guard.
15220         * common/tdesc.h: Rename include guard.
15221         * common/selftest.h: Rename include guard.
15222         * common/scoped_restore.h: Rename include guard.
15223         * common/scoped_mmap.h: Rename include guard.
15224         * common/scoped_fd.h: Rename include guard.
15225         * common/safe-iterator.h: Rename include guard.
15226         * common/run-time-clock.h: Rename include guard.
15227         * common/refcounted-object.h: Rename include guard.
15228         * common/queue.h: Rename include guard.
15229         * common/ptid.h: Rename include guard.
15230         * common/print-utils.h: Rename include guard.
15231         * common/preprocessor.h: Rename include guard.
15232         * common/pathstuff.h: Rename include guard.
15233         * common/observable.h: Rename include guard.
15234         * common/netstuff.h: Rename include guard.
15235         * common/job-control.h: Rename include guard.
15236         * common/host-defs.h: Rename include guard.
15237         * common/gdb_wait.h: Rename include guard.
15238         * common/gdb_vecs.h: Rename include guard.
15239         * common/gdb_unlinker.h: Rename include guard.
15240         * common/gdb_unique_ptr.h: Rename include guard.
15241         * common/gdb_tilde_expand.h: Rename include guard.
15242         * common/gdb_sys_time.h: Rename include guard.
15243         * common/gdb_string_view.h: Rename include guard.
15244         * common/gdb_splay_tree.h: Rename include guard.
15245         * common/gdb_setjmp.h: Rename include guard.
15246         * common/gdb_ref_ptr.h: Rename include guard.
15247         * common/gdb_optional.h: Rename include guard.
15248         * common/gdb_locale.h: Rename include guard.
15249         * common/gdb_assert.h: Rename include guard.
15250         * common/filtered-iterator.h: Rename include guard.
15251         * common/filestuff.h: Rename include guard.
15252         * common/fileio.h: Rename include guard.
15253         * common/environ.h: Rename include guard.
15254         * common/common-utils.h: Rename include guard.
15255         * common/common-types.h: Rename include guard.
15256         * common/common-regcache.h: Rename include guard.
15257         * common/common-inferior.h: Rename include guard.
15258         * common/common-gdbthread.h: Rename include guard.
15259         * common/common-exceptions.h: Rename include guard.
15260         * common/common-defs.h: Rename include guard.
15261         * common/common-debug.h: Rename include guard.
15262         * common/cleanups.h: Rename include guard.
15263         * common/buffer.h: Rename include guard.
15264         * common/btrace-common.h: Rename include guard.
15265         * common/break-common.h: Rename include guard.
15266         * cli/cli-utils.h: Rename include guard.
15267         * cli/cli-style.h: Rename include guard.
15268         * cli/cli-setshow.h: Rename include guard.
15269         * cli/cli-script.h: Rename include guard.
15270         * cli/cli-interp.h: Rename include guard.
15271         * cli/cli-decode.h: Rename include guard.
15272         * cli/cli-cmds.h: Rename include guard.
15273         * charset-list.h: Add include guard.
15274         * buildsym-legacy.h: Rename include guard.
15275         * bfin-tdep.h: Add include guard.
15276         * ax.h: Rename include guard.
15277         * arm-linux-tdep.h: Add include guard.
15278         * arm-fbsd-tdep.h: Add include guard.
15279         * arch/xtensa.h: Rename include guard.
15280         * arch/tic6x.h: Add include guard.
15281         * arch/i386.h: Add include guard.
15282         * arch/arm.h: Rename include guard.
15283         * arch/arm-linux.h: Rename include guard.
15284         * arch/arm-get-next-pcs.h: Rename include guard.
15285         * arch/amd64.h: Add include guard.
15286         * arch/aarch64-insn.h: Rename include guard.
15287         * arch-utils.h: Rename include guard.
15288         * annotate.h: Add include guard.
15289         * amd64-darwin-tdep.h: Rename include guard.
15290         * aarch64-linux-tdep.h: Add include guard.
15291         * aarch64-fbsd-tdep.h: Add include guard.
15292         * aarch32-linux-nat.h: Add include guard.
15293
15294 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15295
15296         * macrotab.c (macro_define_internal): New function that
15297         factorizes macro_define_object_internal and macro_define_function
15298         code.
15299         (macro_define_object_internal): Use macro_define_internal.
15300         (macro_define_function): Likewise.
15301
15302 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15303
15304         * macrocmd.c (extract_identifier): Return
15305         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15306         callers.
15307
15308 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
15309
15310         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15311
15312 2019-02-05  Tom Tromey  <tom@tromey.com>
15313
15314         * target.c (target_stack::unpush): Move assertion earlier.
15315
15316 2019-01-30  Tom Tromey  <tom@tromey.com>
15317
15318         PR python/23615:
15319         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15320         (gdbpy_parse_and_eval): Likewise.
15321         * python/python-internal.h (gdbpy_allow_threads): New class.
15322
15323 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
15324
15325         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15326         (aarch64_fbsd_fpregmap): Move earlier.
15327         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15328         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15329         instead of individual calls to trad_frame_set_reg_addr.
15330         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15331         earlier.
15332         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15333         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15334         instead of individual calls to trad_frame_set_reg_addr.
15335
15336 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
15337
15338         * CONTRIBUTE: Replace contribution list with wiki link.
15339
15340 2019-01-25  Tom Tromey  <tom@tromey.com>
15341
15342         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15343
15344 2019-01-25  Tom Tromey  <tom@tromey.com>
15345
15346         * xtensa-linux-nat.c: Fix common/ includes.
15347         * xml-support.h: Fix common/ includes.
15348         * xml-support.c: Fix common/ includes.
15349         * x86-linux-nat.c: Fix common/ includes.
15350         * windows-nat.c: Fix common/ includes.
15351         * varobj.h: Fix common/ includes.
15352         * varobj.c: Fix common/ includes.
15353         * value.c: Fix common/ includes.
15354         * valops.c: Fix common/ includes.
15355         * utils.c: Fix common/ includes.
15356         * unittests/xml-utils-selftests.c: Fix common/ includes.
15357         * unittests/utils-selftests.c: Fix common/ includes.
15358         * unittests/unpack-selftests.c: Fix common/ includes.
15359         * unittests/tracepoint-selftests.c: Fix common/ includes.
15360         * unittests/style-selftests.c: Fix common/ includes.
15361         * unittests/string_view-selftests.c: Fix common/ includes.
15362         * unittests/scoped_restore-selftests.c: Fix common/ includes.
15363         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15364         * unittests/scoped_fd-selftests.c: Fix common/ includes.
15365         * unittests/rsp-low-selftests.c: Fix common/ includes.
15366         * unittests/parse-connection-spec-selftests.c: Fix common/
15367         includes.
15368         * unittests/optional-selftests.c: Fix common/ includes.
15369         * unittests/offset-type-selftests.c: Fix common/ includes.
15370         * unittests/observable-selftests.c: Fix common/ includes.
15371         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15372         * unittests/memrange-selftests.c: Fix common/ includes.
15373         * unittests/memory-map-selftests.c: Fix common/ includes.
15374         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15375         * unittests/function-view-selftests.c: Fix common/ includes.
15376         * unittests/environ-selftests.c: Fix common/ includes.
15377         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15378         * unittests/common-utils-selftests.c: Fix common/ includes.
15379         * unittests/cli-utils-selftests.c: Fix common/ includes.
15380         * unittests/array-view-selftests.c: Fix common/ includes.
15381         * ui-file.c: Fix common/ includes.
15382         * tui/tui-io.c: Fix common/ includes.
15383         * tracepoint.h: Fix common/ includes.
15384         * tracepoint.c: Fix common/ includes.
15385         * tracefile-tfile.c: Fix common/ includes.
15386         * top.h: Fix common/ includes.
15387         * top.c: Fix common/ includes.
15388         * thread.c: Fix common/ includes.
15389         * target/waitstatus.h: Fix common/ includes.
15390         * target/waitstatus.c: Fix common/ includes.
15391         * target.h: Fix common/ includes.
15392         * target.c: Fix common/ includes.
15393         * target-memory.c: Fix common/ includes.
15394         * target-descriptions.c: Fix common/ includes.
15395         * symtab.h: Fix common/ includes.
15396         * symfile.c: Fix common/ includes.
15397         * stap-probe.c: Fix common/ includes.
15398         * spu-linux-nat.c: Fix common/ includes.
15399         * sparc-nat.c: Fix common/ includes.
15400         * source.c: Fix common/ includes.
15401         * solib.c: Fix common/ includes.
15402         * solib-target.c: Fix common/ includes.
15403         * ser-unix.c: Fix common/ includes.
15404         * ser-tcp.c: Fix common/ includes.
15405         * ser-pipe.c: Fix common/ includes.
15406         * ser-base.c: Fix common/ includes.
15407         * selftest-arch.c: Fix common/ includes.
15408         * s12z-tdep.c: Fix common/ includes.
15409         * rust-exp.y: Fix common/ includes.
15410         * rs6000-aix-tdep.c: Fix common/ includes.
15411         * riscv-tdep.c: Fix common/ includes.
15412         * remote.c: Fix common/ includes.
15413         * remote-notif.h: Fix common/ includes.
15414         * remote-fileio.h: Fix common/ includes.
15415         * remote-fileio.c: Fix common/ includes.
15416         * regcache.h: Fix common/ includes.
15417         * regcache.c: Fix common/ includes.
15418         * record-btrace.c: Fix common/ includes.
15419         * python/python.c: Fix common/ includes.
15420         * python/py-type.c: Fix common/ includes.
15421         * python/py-inferior.c: Fix common/ includes.
15422         * progspace.h: Fix common/ includes.
15423         * producer.c: Fix common/ includes.
15424         * procfs.c: Fix common/ includes.
15425         * proc-api.c: Fix common/ includes.
15426         * printcmd.c: Fix common/ includes.
15427         * ppc-linux-nat.c: Fix common/ includes.
15428         * parser-defs.h: Fix common/ includes.
15429         * osdata.c: Fix common/ includes.
15430         * obsd-nat.c: Fix common/ includes.
15431         * nat/x86-linux.c: Fix common/ includes.
15432         * nat/x86-linux-dregs.c: Fix common/ includes.
15433         * nat/x86-dregs.h: Fix common/ includes.
15434         * nat/x86-dregs.c: Fix common/ includes.
15435         * nat/ppc-linux.c: Fix common/ includes.
15436         * nat/mips-linux-watch.h: Fix common/ includes.
15437         * nat/mips-linux-watch.c: Fix common/ includes.
15438         * nat/linux-waitpid.c: Fix common/ includes.
15439         * nat/linux-ptrace.h: Fix common/ includes.
15440         * nat/linux-ptrace.c: Fix common/ includes.
15441         * nat/linux-procfs.c: Fix common/ includes.
15442         * nat/linux-personality.c: Fix common/ includes.
15443         * nat/linux-osdata.c: Fix common/ includes.
15444         * nat/linux-namespaces.c: Fix common/ includes.
15445         * nat/linux-btrace.h: Fix common/ includes.
15446         * nat/linux-btrace.c: Fix common/ includes.
15447         * nat/fork-inferior.c: Fix common/ includes.
15448         * nat/amd64-linux-siginfo.c: Fix common/ includes.
15449         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15450         * nat/aarch64-linux.c: Fix common/ includes.
15451         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15452         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15453         * namespace.h: Fix common/ includes.
15454         * mips-linux-tdep.c: Fix common/ includes.
15455         * minsyms.c: Fix common/ includes.
15456         * mi/mi-parse.h: Fix common/ includes.
15457         * mi/mi-main.c: Fix common/ includes.
15458         * mi/mi-cmd-env.c: Fix common/ includes.
15459         * memrange.h: Fix common/ includes.
15460         * memattr.c: Fix common/ includes.
15461         * maint.h: Fix common/ includes.
15462         * maint.c: Fix common/ includes.
15463         * main.c: Fix common/ includes.
15464         * machoread.c: Fix common/ includes.
15465         * location.c: Fix common/ includes.
15466         * linux-thread-db.c: Fix common/ includes.
15467         * linux-nat.c: Fix common/ includes.
15468         * linux-fork.c: Fix common/ includes.
15469         * inline-frame.c: Fix common/ includes.
15470         * infrun.c: Fix common/ includes.
15471         * inflow.c: Fix common/ includes.
15472         * inferior.h: Fix common/ includes.
15473         * inferior.c: Fix common/ includes.
15474         * infcmd.c: Fix common/ includes.
15475         * inf-ptrace.c: Fix common/ includes.
15476         * inf-child.c: Fix common/ includes.
15477         * ia64-linux-nat.c: Fix common/ includes.
15478         * i387-tdep.c: Fix common/ includes.
15479         * i386-tdep.c: Fix common/ includes.
15480         * i386-linux-tdep.c: Fix common/ includes.
15481         * i386-linux-nat.c: Fix common/ includes.
15482         * i386-go32-tdep.c: Fix common/ includes.
15483         * i386-fbsd-tdep.c: Fix common/ includes.
15484         * i386-fbsd-nat.c: Fix common/ includes.
15485         * guile/scm-type.c: Fix common/ includes.
15486         * guile/guile.c: Fix common/ includes.
15487         * go32-nat.c: Fix common/ includes.
15488         * gnu-nat.c: Fix common/ includes.
15489         * gdbthread.h: Fix common/ includes.
15490         * gdbarch-selftests.c: Fix common/ includes.
15491         * gdb_usleep.c: Fix common/ includes.
15492         * gdb_select.h: Fix common/ includes.
15493         * gdb_bfd.c: Fix common/ includes.
15494         * gcore.c: Fix common/ includes.
15495         * fork-child.c: Fix common/ includes.
15496         * findvar.c: Fix common/ includes.
15497         * fbsd-nat.c: Fix common/ includes.
15498         * event-top.c: Fix common/ includes.
15499         * event-loop.c: Fix common/ includes.
15500         * dwarf2read.c: Fix common/ includes.
15501         * dwarf2loc.c: Fix common/ includes.
15502         * dwarf2-frame.c: Fix common/ includes.
15503         * dwarf-index-cache.c: Fix common/ includes.
15504         * dtrace-probe.c: Fix common/ includes.
15505         * disasm-selftests.c: Fix common/ includes.
15506         * defs.h: Fix common/ includes.
15507         * csky-tdep.c: Fix common/ includes.
15508         * cp-valprint.c: Fix common/ includes.
15509         * cp-support.h: Fix common/ includes.
15510         * cp-support.c: Fix common/ includes.
15511         * corelow.c: Fix common/ includes.
15512         * completer.h: Fix common/ includes.
15513         * completer.c: Fix common/ includes.
15514         * compile/compile.c: Fix common/ includes.
15515         * compile/compile-loc2c.c: Fix common/ includes.
15516         * compile/compile-cplus-types.c: Fix common/ includes.
15517         * compile/compile-cplus-symbols.c: Fix common/ includes.
15518         * command.h: Fix common/ includes.
15519         * cli/cli-dump.c: Fix common/ includes.
15520         * cli/cli-cmds.c: Fix common/ includes.
15521         * charset.c: Fix common/ includes.
15522         * build-id.c: Fix common/ includes.
15523         * btrace.h: Fix common/ includes.
15524         * btrace.c: Fix common/ includes.
15525         * breakpoint.h: Fix common/ includes.
15526         * breakpoint.c: Fix common/ includes.
15527         * ax.h:
15528         (enum agent_op): Fix common/ includes.
15529         * ax-general.c (struct aop_map): Fix common/ includes.
15530         * ax-gdb.c: Fix common/ includes.
15531         * auxv.c: Fix common/ includes.
15532         * auto-load.c: Fix common/ includes.
15533         * arm-tdep.c: Fix common/ includes.
15534         * arch/riscv.c: Fix common/ includes.
15535         * arch/ppc-linux-common.c: Fix common/ includes.
15536         * arch/i386.c: Fix common/ includes.
15537         * arch/arm.c: Fix common/ includes.
15538         * arch/arm-linux.c: Fix common/ includes.
15539         * arch/arm-get-next-pcs.c: Fix common/ includes.
15540         * arch/amd64.c: Fix common/ includes.
15541         * arch/aarch64.c: Fix common/ includes.
15542         * arch/aarch64-insn.c: Fix common/ includes.
15543         * arch-utils.c: Fix common/ includes.
15544         * amd64-windows-tdep.c: Fix common/ includes.
15545         * amd64-tdep.c: Fix common/ includes.
15546         * amd64-sol2-tdep.c: Fix common/ includes.
15547         * amd64-obsd-tdep.c: Fix common/ includes.
15548         * amd64-nbsd-tdep.c: Fix common/ includes.
15549         * amd64-linux-tdep.c: Fix common/ includes.
15550         * amd64-linux-nat.c: Fix common/ includes.
15551         * amd64-fbsd-tdep.c: Fix common/ includes.
15552         * amd64-fbsd-nat.c: Fix common/ includes.
15553         * amd64-dicos-tdep.c: Fix common/ includes.
15554         * amd64-darwin-tdep.c: Fix common/ includes.
15555         * agent.c: Fix common/ includes.
15556         * ada-lang.h: Fix common/ includes.
15557         * ada-lang.c: Fix common/ includes.
15558         * aarch64-tdep.c: Fix common/ includes.
15559
15560 2019-01-25  Tom Tromey  <tom@tromey.com>
15561
15562         * common/create-version.sh: Use common/version.h.
15563
15564 2019-01-24  Pedro Alves  <palves@redhat.com>
15565
15566         * infrun.c (signal_stop, signal_print, signal_program)
15567         (signal_catch, signal_pass): Now arrays instead of pointers.
15568         (update_signals_program_target, do_target_resume)
15569         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15570         * linux-nat.c (linux_nat_target::pass_signals)
15571         (linux_nat_target::create_inferior, linux_nat_target::attach):
15572         Adjust.
15573         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15574         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15575         * procfs.c (procfs_target::pass_signals): Adjust.
15576         * record-full.c (record_full_target::resume): Adjust.
15577         * remote.c (remote_target::pass_signals)
15578         (remote_target::program_signals): Adjust.
15579         * target-debug.h (target_debug_print_signals): Now takes a
15580         gdb::array_view as parameter.  Adjust.
15581         * target.h (target_ops) <pass_signals, program_signals>: Replace
15582         pointer and length parameters with gdb::array_view.
15583         (target_pass_signals, target_program_signals): Likewise.
15584         * target-delegates.c: Regenerate.
15585
15586 2019-01-24  Pedro Alves  <palves@redhat.com>
15587
15588         * common/forward-scope-exit.h
15589         (forward_scope_exit::forward_scope_exit): Pass arguments to
15590         m_bind_function directly, instead of creating a std::bind and
15591         copying that.
15592
15593 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
15594
15595         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15596         for static members.
15597         (pass_in_v_vfp_candidate): Likewise.
15598
15599 2019-01-23  Tom Tromey  <tom@tromey.com>
15600             Pedro Alves  <palves@redhat.com>
15601
15602         * regcache.c (class regcache_invalidator): Remove.
15603         (regcache::raw_write): Use make_scope_exit.
15604
15605 2019-01-23  Tom Tromey  <tom@tromey.com>
15606
15607         * ui-out.h (class ui_out_emit_type): Update comment.
15608
15609 2019-01-23  Tom Tromey  <tom@tromey.com>
15610
15611         * infrun.c (fetch_inferior_event): Update comment.
15612
15613 2019-01-23  Tom Tromey  <tom@tromey.com>
15614             Pedro Alves  <palves@redhat.com>
15615
15616         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15617         parameter.
15618         (fetch_inferior_event): Use SCOPE_EXIT.
15619
15620
15621 2019-01-23  Tom Tromey  <tom@tromey.com>
15622             Pedro Alves  <palves@redhat.com>
15623
15624         * infrun.c (disable_thread_events): Delete.
15625         (stop_all_threads): Use SCOPE_EXIT.
15626
15627 2019-01-23  Tom Tromey  <tom@tromey.com>
15628             Pedro Alves  <palves@redhat.com>
15629
15630         * symfile.c: Include forward-scope-exit.h.
15631         (clear_symtab_users_cleanup): Replace forward declaration with
15632         a FORWARD_SCOPE_EXIT.
15633         (syms_from_objfile_1): Use the forward_scope_exit and
15634         gdb::optional instead of cleanup_function.
15635         (reread_symbols): Use the forward_scope_exit instead of
15636         cleanup_function.
15637         (clear_symtab_users_cleanup): Remove function.
15638
15639 2019-01-23  Tom Tromey  <tom@tromey.com>
15640             Pedro Alves  <palves@redhat.com>
15641
15642         * linux-nat.c: Include scope-exit.h.
15643         (cleanup_target_stop): Remove.
15644         (linux_nat_target::static_tracepoint_markers_by_strid): Use
15645         SCOPE_EXIT.
15646
15647 2019-01-23  Tom Tromey  <tom@tromey.com>
15648             Pedro Alves  <palves@redhat.com>
15649
15650         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15651         (call_function_by_hand_dummy): Use SCOPE_EXIT.
15652
15653 2019-01-23  Tom Tromey  <tom@tromey.com>
15654             Andrew Burgess  <andrew.burgess@embecosm.com>
15655             Pedro Alves  <palves@redhat.com>
15656
15657         * infrun.c (fetch_inferior_event): Use scope_exit.
15658         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15659         * top.c (execute_command): Use scope_exit.
15660         * breakpoint.c (bpstat_do_actions): Use scope_exit.
15661         * utils.c (do_bpstat_clear_actions_cleanup)
15662         (make_bpstat_clear_actions_cleanup): Remove.
15663
15664 2019-01-23  Tom Tromey  <tom@tromey.com>
15665             Pedro Alves  <palves@redhat.com>
15666
15667         * infrun.c: Include "common/scope-exit.h"
15668         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15669         (wait_for_inferior): Use SCOPE_EXIT.
15670         (fetch_inferior_event): Use scope_exit.
15671
15672 2019-01-23  Tom Tromey  <tom@tromey.com>
15673             Pedro Alves  <palves@redhat.com>
15674
15675         * breakpoint.c (create_breakpoint): Remove cleanup.
15676
15677 2019-01-23  Tom Tromey  <tom@tromey.com>
15678             Andrew Burgess  <andrew.burgess@embecosm.com>
15679             Pedro Alves  <palves@redhat.com>
15680
15681 2019-01-23  Pedro Alves  <palves@redhat.com>
15682
15683         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15684
15685 2019-01-23  Pedro Alves  <palves@redhat.com>
15686             Andrew Burgess  <andrew.burgess@embecosm.com>
15687
15688         * gdbthread.h: Include "common/forward-scope-exit.h".
15689         (scoped_finish_thread_state): Redefine custom class in terms of
15690         forward_scope_exit.
15691
15692 2019-01-23  Pedro Alves  <palves@redhat.com>
15693             Andrew Burgess  <andrew.burgess@embecosm.com>
15694
15695         * common/forward-scope-exit.h: New file.
15696
15697 2019-01-23  Pedro Alves  <palves@redhat.com>
15698             Andrew Burgess  <andrew.burgess@embecosm.com>
15699             Tom Tromey  <tom@tromey.com>
15700
15701         * common/scope-exit.h: New file.
15702
15703 2019-01-23  Pedro Alves  <palves@redhat.com>
15704
15705         * common/preprocessor.h (ESC): Rename to ...
15706         (ESC_PARENS): ... this.
15707         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15708         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15709
15710 2019-01-23  Tom Tromey  <tom@tromey.com>
15711
15712         * language.h (class scoped_switch_to_sym_language_if_auto):
15713         Initialize m_lang in both cases.
15714
15715 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
15716
15717         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15718         with XCNEW.
15719
15720 2019-01-22  Tom Tromey  <tom@tromey.com>
15721
15722         * corelow.c: Do not include sys/file.h.
15723
15724 2019-01-22  Tom Tromey  <tom@tromey.com>
15725
15726         * tui/tui-wingeneral.h: Include gdb_curses.h.
15727
15728 2019-01-22  Tom Tromey  <tom@tromey.com>
15729
15730         * source-cache.h (class source_cache) <get_source_lines,
15731         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15732
15733 2019-01-22  Tom Tromey  <tom@tromey.com>
15734
15735         * remote-fileio.h (struct remote_target): Declare.
15736
15737 2019-01-22  Tom Tromey  <tom@tromey.com>
15738
15739         * python/py-arch.c: Do not include py-ref.h.
15740         * python/py-bpevent.c: Do not include py-ref.h.
15741         * python/py-cmd.c: Do not include py-ref.h.
15742         * python/py-continueevent.c: Do not include py-ref.h.
15743         * python/py-event.h: Do not include py-ref.h.
15744         * python/py-evtregistry.c: Do not include py-ref.h.
15745         * python/py-finishbreakpoint.c: Do not include py-ref.h.
15746         * python/py-frame.c: Do not include py-ref.h.
15747         * python/py-framefilter.c: Do not include py-ref.h.
15748         * python/py-function.c: Do not include py-ref.h.
15749         * python/py-infevents.c: Do not include py-ref.h.
15750         * python/py-linetable.c: Do not include py-ref.h.
15751         * python/py-objfile.c: Do not include py-ref.h.
15752         * python/py-param.c: Do not include py-ref.h.
15753         * python/py-prettyprint.c: Do not include py-ref.h.
15754         * python/py-progspace.c: Do not include py-ref.h.
15755         * python/py-symbol.c: Do not include py-ref.h.
15756         * python/py-symtab.c: Do not include py-ref.h.
15757         * python/py-type.c: Do not include py-ref.h.
15758         * python/py-unwind.c: Do not include py-ref.h.
15759         * python/py-utils.c: Do not include py-ref.h.
15760         * python/py-value.c: Do not include py-ref.h.
15761         * python/py-varobj.c: Do not include py-ref.h.
15762         * python/py-xmethods.c: Do not include py-ref.h.
15763         * python/python.c: Do not include py-ref.h.
15764         * varobj.c: Do not include py-ref.h.
15765
15766 2019-01-22  Tom Tromey  <tom@tromey.com>
15767
15768         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15769         keyword for bcache.
15770
15771 2019-01-22  Tom Tromey  <tom@tromey.com>
15772
15773         * compile/compile-cplus-types.c: Remove a comment by #include.
15774
15775 2019-01-22  Tom Tromey  <tom@tromey.com>
15776
15777         * compile/gcc-c-plugin.h: Include compile-internal.h.
15778
15779 2019-01-22  Tom Tromey  <tom@tromey.com>
15780
15781         * stabsread.c (EXTERN): Do not define.
15782         (symnum, next_symbol_text_func, processing_gcc_compilation)
15783         (within_function, global_sym_chain, global_stabs)
15784         (previous_stab_code, this_object_header_files)
15785         (n_this_object_header_files)
15786         (n_allocated_this_object_header_files): Define.
15787         * stabsread.h (EXTERN): Never define.  Use "extern".
15788
15789 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15790
15791         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15792         history_value.
15793
15794 2019-01-21  Tom Tromey  <tom@tromey.com>
15795
15796         * ui-out.c: Fix includes.
15797         * tui/tui-source.c: Fix includes.
15798         * target.c: Fix includes.
15799         * remote.c: Fix includes.
15800         * regcache.c: Fix includes.
15801         * python/py-block.c: Fix includes.
15802         * printcmd.c: Fix includes.
15803         * or1k-tdep.c: Fix includes.
15804         * mi/mi-main.c: Fix includes.
15805         * m32r-tdep.c: Fix includes.
15806         * csky-tdep.c: Fix includes.
15807         * compile/compile-cplus-types.c: Fix includes.
15808         * cli/cli-interp.c: Fix includes.
15809
15810 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
15811
15812         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15813         for padding.
15814
15815 2019-01-16  Tom Tromey  <tom@tromey.com>
15816
15817         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
15818         earlier.
15819         (struct objfile) <msymbols_range>: Move from top level.
15820         <msymbols>: New method.
15821         (class objfile_msymbols): Remove.
15822         * symtab.c (default_collect_symbol_completion_matches_break_on):
15823         Update.
15824         * symmisc.c (dump_msymbols): Update.
15825         * stabsread.c (scan_file_globals): Update.
15826         * objc-lang.c (info_selectors_command, info_classes_command)
15827         (find_methods): Update.
15828         * minsyms.c (find_solib_trampoline_target): Update.
15829         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15830         * coffread.c (coff_symfile_read): Update.
15831         * ada-lang.c (ada_lookup_simple_minsym)
15832         (ada_collect_symbol_completion_matches): Update.
15833
15834 2019-01-16  Tom Tromey  <tom@tromey.com>
15835
15836         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15837         type.  Remove no-argument constructor.
15838         <iterator::operator++>: Simplify.
15839         <begin>: Update.
15840         <end>: Use minimal_symbol_count.
15841
15842 2019-01-16  Tom Tromey  <tom@tromey.com>
15843
15844         * objfiles.h (struct objfile) <psymtabs>: New method.
15845         (class objfile_psymtabs): Remove.
15846         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15847         typedef.
15848         <range>: New method.
15849         (require_partial_symbols): Change return type.
15850         * psymtab.c (require_partial_symbols)
15851         (psym_expand_symtabs_matching): Update.
15852         * mdebugread.c (parse_partial_symbols): Update.
15853         * dbxread.c (dbx_end_psymtab): Update.
15854
15855 2019-01-15  Tom Tromey  <tom@tromey.com>
15856
15857         * symtab.c (lookup_objfile_from_block)
15858         (lookup_symbol_in_objfile_symtabs)
15859         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15860         (find_line_symtab, info_sources_command)
15861         (default_collect_symbol_completion_matches_break_on)
15862         (make_source_files_completion_list): Update.
15863         * symmisc.c (print_objfile_statistics, dump_objfile)
15864         (maintenance_print_symbols, maintenance_info_symtabs)
15865         (maintenance_check_symtabs, maintenance_info_line_tables):
15866         Update.
15867         * source.c (select_source_symtab)
15868         (forget_cached_source_info_for_objfile): Update.
15869         * objfiles.h (class objfile_compunits): Remove.
15870         (struct objfile) <compunits_range>: New typedef.
15871         (compunits): New method.
15872         * objfiles.c (objfile_relocate1): Update.
15873         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15874         * maint.c (count_symtabs_and_blocks): Update.
15875         * linespec.c (iterate_over_all_matching_symtabs): Update.
15876         * cp-support.c (add_symbol_overload_list_qualified): Update.
15877         * coffread.c (coff_symtab_read): Update.
15878         * ada-lang.c (add_nonlocal_symbols)
15879         (ada_collect_symbol_completion_matches)
15880         (ada_add_global_exceptions): Update.
15881
15882 2019-01-15  Tom Tromey  <tom@tromey.com>
15883
15884         * progspace.h (program_space) <objfiles_safe_range>: New
15885         typedef.
15886         <objfiles_safe>: New method.
15887         * objfiles.h (class all_objfiles_safe): Remove.
15888         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15889         * jit.c (jit_inferior_exit_hook): Update.
15890
15891 2019-01-17  Tom Tromey  <tom@tromey.com>
15892
15893         * progspace.h (program_space) <objfiles_range>: New typedef.
15894         <objfiles>: New method.
15895         <objfiles_head>: Rename from objfiles.
15896         (object_files): Update.
15897         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15898         * guile/scm-pretty-print.c
15899         (ppscm_find_pretty_printer_from_objfiles): Update.
15900         * guile/scm-objfile.c (gdbscm_objfiles): Update.
15901         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15902         Update.
15903         * python/py-progspace.c (pspy_get_objfiles): Update.
15904         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15905         Update.
15906         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15907         (objfpy_lookup_objfile_by_build_id): Update.
15908         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15909         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15910         Update.
15911         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15912         (expand_symtab_containing_pc, lookup_objfile_from_block)
15913         (lookup_static_symbol, basic_lookup_transparent_type)
15914         (find_pc_sect_compunit_symtab, find_symbol_at_address)
15915         (find_line_symtab, info_sources_command)
15916         (default_collect_symbol_completion_matches_break_on)
15917         (make_source_files_completion_list, find_main_name): Update.
15918         * symmisc.c (print_symbol_bcache_statistics)
15919         (print_objfile_statistics, maintenance_print_symbols)
15920         (maintenance_print_msymbols, maintenance_print_objfiles)
15921         (maintenance_info_symtabs, maintenance_check_symtabs)
15922         (maintenance_expand_symtabs, maintenance_info_line_tables):
15923         Update.
15924         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15925         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15926         (map_overlay_command, unmap_overlay_command)
15927         (simple_overlay_update, expand_symtabs_matching)
15928         (map_symbol_filenames): Update.
15929         * symfile-debug.c (set_debug_symfile): Update.
15930         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15931         Update.
15932         * source.c (select_source_symtab, forget_cached_source_info):
15933         Update.
15934         * solib.c (solib_read_symbols): Update.
15935         * solib-spu.c (append_ocl_sos): Update.
15936         * psymtab.c (maintenance_print_psymbols)
15937         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15938         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15939         * printcmd.c (info_symbol_command): Update.
15940         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15941         Update.
15942         * objfiles.h (class all_objfiles): Remove.
15943         * objfiles.c (have_partial_symbols, have_full_symbols)
15944         (have_minimal_symbols, qsort_cmp, update_section_map)
15945         (shared_objfile_contains_address_p)
15946         (default_iterate_over_objfiles_in_search_order): Update.
15947         * objc-lang.c (info_selectors_command, info_classes_command)
15948         (find_methods): Update.
15949         * minsyms.c (find_solib_trampoline_target): Update.
15950         * maint.c (maintenance_info_sections)
15951         (maintenance_translate_address, count_symtabs_and_blocks):
15952         Update.
15953         * main.c (captured_main_1): Update.
15954         * linux-thread-db.c (try_thread_db_load_from_pdir)
15955         (has_libpthread): Update.
15956         * linespec.c (iterate_over_all_matching_symtabs)
15957         (search_minsyms_for_name): Update.
15958         * jit.c (jit_find_objf_with_entry_addr): Update.
15959         * hppa-tdep.c (find_unwind_entry)
15960         (hppa_lookup_stub_minimal_symbol): Update.
15961         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15962         Update.
15963         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15964         (elf_gnu_ifunc_resolve_by_got): Update.
15965         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15966         * dwarf-index-write.c (save_gdb_index_command): Update.
15967         * cp-support.c (add_symbol_overload_list_qualified): Update.
15968         * breakpoint.c (create_overlay_event_breakpoint)
15969         (create_longjmp_master_breakpoint)
15970         (create_std_terminate_master_breakpoint)
15971         (create_exception_master_breakpoint): Update.
15972         * blockframe.c (find_pc_partial_function): Update.
15973         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15974         (ada_collect_symbol_completion_matches)
15975         (ada_add_global_exceptions): Update.
15976
15977 2019-01-17  Tom Tromey  <tom@tromey.com>
15978
15979         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
15980         declare VEC.
15981         (solib_target_parse_libraries): Change return type.
15982         (library_list_start_segment, library_list_start_section)
15983         (library_list_end_library, library_list_start_library); Update.
15984         (solib_target_free_library_list): Remove.
15985         (solib_target_parse_libraries): Remove cleanup.  Change return
15986         type.
15987         (solib_target_current_sos): Update.
15988
15989 2019-01-17  Tom Tromey  <tromey@bapiya>
15990
15991         * valprint.c: Replace "the the" with "the".
15992         * symtab.c: Replace "the the" with "the".
15993         * solib.c: Replace "the the" with "the".
15994         * solib-dsbt.c: Replace "the the" with "the".
15995         * linespec.c: Replace "the the" with "the".
15996         * dwarf2loc.h: Replace "the the" with "the".
15997         * amd64-windows-tdep.c: Replace "the the" with "the".
15998         * aarch64-tdep.c: Replace "the the" with "the".
15999
16000 2019-01-16  Keith Seitz  <keiths@redhat.com>
16001
16002         PR gdb/23773
16003         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
16004         <builder>: Rename to ..
16005         <m_builder>: ... this and make private.
16006         (dwarf2_cu::get_builder): New method.  Change all users of
16007         `builder' to use this method.
16008         (dwarf2_start_symtab): Move to ...
16009         (dwarf2_cu::start_symtab): ... here.  Update all callers
16010         (setup_type_unit_groups): Move to ...
16011         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
16012         callers.
16013         (dwarf2_cu::reset_builder): New method.
16014         (process_full_compunit, process_full_type_unit): Use
16015         dwarf2_cu::reset_builder.
16016         (follow_die_offset): Record the ancestor CU if it is different
16017         from the followed DIE's CU.
16018         (follow_die_sig_1): Likewise.
16019
16020 2019-01-15  Tom Tromey  <tom@tromey.com>
16021
16022         * remote.c (class remote_state) <buf>: Now a char_vector.
16023         <buf_size>: Remove.
16024         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
16025         parameter.
16026         (remote_target::getpkt_or_notif_sane_1)
16027         (remote_target::getpkt_sane)
16028         (remote_target::getpkt_or_notif_sane): Likewise.
16029         (class remote_target) <putpkt>: New overload.
16030         (remote_target::read_frame): Change type of "buf_p".  Remove
16031         sizeof_p parameter.
16032         (packet_ok): New overload.
16033         (packet_check_result): New overload.
16034         Update all uses.
16035
16036 2019-01-14  Tom Tromey  <tom@tromey.com>
16037
16038         * remote-notif.c (handle_notification, remote_notif_ack)
16039         (remote_notif_parse): Make "buf" const.
16040         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
16041         const.
16042         (remote_notif_parse, remote_notif_ack, handle_notification):
16043         Likewise.
16044         * remote.c (remote_notif_stop_parse): Make "buf" const.
16045         (remote_target::remote_parse_stop_reply): Make "buf" const.
16046         (remote_notif_stop_ack): Make "buf" const.
16047
16048 2019-01-14  Tom Tromey  <tom@tromey.com>
16049
16050         * remote.c (remote_console_output): Make parameter const.
16051
16052 2019-01-14  Tom Tromey  <tom@tromey.com>
16053
16054         * target-debug.h (target_debug_print_signals): Constify.
16055         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16056         * procfs.c (procfs_target::pass_signals): Update.
16057         * linux-nat.c (linux_nat_target::pass_signals): Update.
16058         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16059         * target-delegates.c: Rebuild.
16060         * remote.c (remote_target::program_signals): Update.
16061         (remote_target::pass_signals): Update.
16062         * target.c (target_pass_signals): Constify argument.
16063         (target_program_signals): Likewise.
16064         * target.h (struct target_ops) <pass_signals, program_signals>:
16065         Constify argument.
16066         (target_pass_signals, target_program_signals): Constify argument.
16067
16068 2019-01-14  Tom Tromey  <tom@tromey.com>
16069
16070         PR tui/28819:
16071         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16072
16073 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
16074
16075         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16076         field.
16077         * rs6000-tdep.c: Include reggroups.h.
16078         (IS_V_ALIAS_PSEUDOREG): Define.
16079         (rs6000_register_name): Return names for the "vX" aliases.
16080         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16081         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
16082         aliases.  Call default_register_reggroup_p for all other
16083         pseudo-registers.
16084         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16085         New functions.
16086         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16087         Handle "vX" aliases.
16088         (v_alias_pseudo_register_collect): New function.
16089         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16090         (rs6000_gdbarch_init): Initialize "vX" aliases as
16091         pseudo-registers.  Restore registration of
16092         rs6000_pseudo_register_reggroup_p with
16093         set_tdesc_pseudo_register_reggroup_p.
16094
16095 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
16096
16097         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16098         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16099         set_gdbarch_num_pseudo_regs.
16100
16101 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16102
16103         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16104         Remove arg prefixname, add do_set and do_show.
16105         Add member functions set_list and show_list.
16106         * cli/cli-style.c (class cli_style_option): Update accordingly.
16107         (style_set_list): Move to file scope.
16108         (style_show_list): Likewise.
16109         (set_style): Call help_list.
16110         (show_style): Call cmd_show_list.
16111         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16112         Update to use the new macro.
16113
16114 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
16115
16116         * ada-lang.c (_initialize_ada_language): Expand the help text
16117         for the "catch exception" command.
16118
16119 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16120
16121         * symtab.c (matching_obj_sections): Initialize obj,
16122         declare it closer to its usage.
16123
16124 2019-01-10  Tom Tromey  <tom@tromey.com>
16125
16126         * thread-iter.h (inf_threads_iterator): Use next_iterator.
16127         (basic_inf_threads_range): Remove.
16128         (inf_threads_range, inf_non_exited_threads_range)
16129         (safe_inf_threads_range): Use next_adapter.
16130
16131 2019-01-10  Keith Seitz  <keiths@redhat.com>
16132
16133         PR gdb/23712
16134         PR symtab/23010
16135         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16136         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16137
16138 2019-01-10  Keith Seitz  <keiths@redhat.com>
16139
16140         PR gdb/23712
16141         PR symtab/23010
16142         * dictionary.c (pending_to_vector): Remove.
16143         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16144         Remove _1 suffix, replacing functions of the same name.  Update
16145         all callers.
16146         (dict_create_hashed, dict_create_hashed_expandable)
16147         (dict_create_linear, dict_create_linear_expandable, dict_free)
16148         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16149         Make functions static.
16150
16151 2019-01-10  Keith Seitz  <keiths@redhat.com>
16152
16153         PR gdb/23712
16154         PR symtab/23010
16155         * dictionary.h (struct dictionary): Replace declaration with
16156         multidictionary.
16157         (dict_create_hashed, dict_create_hashed_expandable)
16158         (dict_create_linear, dict_create_linear_expandable)
16159         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16160         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16161         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16162         taking multidictionary argument.
16163         [ALL_DICT_SYMBOLS]: Update for multidictionary.
16164         * block.h (struct block) <dict>: Change to multidictionary
16165         and rename `multidict'.
16166         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16167         symmisc.c: Update all dictionary references to multidictionary.
16168
16169 2019-01-10  Keith Seitz  <keiths@redhat.com>
16170
16171         PR gdb/23712
16172         PR symtab/23010
16173         * dictionary.c: Include unordered_map.
16174         (pending_to_vector): New function.
16175         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16176         Rewrite the non-"_1" functions to take vector instead
16177         of linked list.
16178         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16179         "new" _1 versions of the same name.
16180         (multidictionary): Define.
16181         (std::hash<enum language): New definition.
16182         (collate_pending_symbols_by_language, mdict_create_hashed)
16183         (mdict_create_hashed_expandable, mdict_create_linear)
16184         (mdict_create_linear_expandable, mdict_free)
16185         (find_language_dictionary, create_new_language_dictionary)
16186         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16187         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16188         (mdict_size, mdict_empty): New functions.
16189         * dictionary.h (mdict_iterator): Define.
16190
16191 2019-01-10  Pedro Alves  <palves@redhat.com>
16192
16193         * breakpoint.c (read_uploaded_action)
16194         (create_tracepoint_from_upload): Adjust to use
16195         gdb::unique_xmalloc_ptr.
16196         * ctf.c (ctf_write_uploaded_tp):
16197         (SET_ARRAY_FIELD): Use emplace_back.
16198         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16199         * tracefile-tfile.c (tfile_write_uploaded_tp):
16200         * tracepoint.c (parse_tracepoint_definition): Adjust to use
16201         gdb::unique_xmalloc_ptr.
16202         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16203         at_string, cond_string, cmd_strings>: Replace char pointers
16204         with gdb::unique_xmalloc_ptr.
16205
16206 2019-01-10  Pedro Alves  <palves@redhat.com>
16207
16208         * solib-target.c (library_list_start_library): Don't xstrdup name.
16209
16210 2019-01-10  Pedro Alves  <palves@redhat.com>
16211
16212         * mdebugread.c (parse_partial_symbols): Use
16213         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16214
16215 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16216
16217         * linux-fork.c (scoped_switch_fork_info)
16218         <~scoped_switch_fork_info>: Fix incorrect variable name.
16219
16220 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16221
16222         * linux-fork.c (scoped_switch_fork_info)
16223         <scoped_switch_fork_info>: Make explicit.
16224         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16225
16226 2019-01-10  Tom Tromey  <tom@tromey.com>
16227
16228         * objfiles.h (objfile::reset_psymtabs): Update.
16229         * objfiles.c (objfile::objfile): Update.
16230         * psymtab.h (psymtab_storage::obstack): Update.
16231         (psymtab_storage::m_obstack): Use gdb::optional.
16232         (class psymtab_storage): Update comment.  Remove objfile
16233         parameter.
16234         * psymtab.c (psymtab_storage::psymtab_storage): Update.
16235
16236 2019-01-10  Tom Tromey  <tom@tromey.com>
16237
16238         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16239         <free_psymtabs>: Now private.
16240         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16241         (allocate_psymtab): Use new method.
16242
16243 2019-01-10  Tom Tromey  <tom@tromey.com>
16244
16245         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16246         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16247         * mdebugread.c (parse_partial_symbols): Use
16248         allocate_dependencies.
16249         * dwarf2read.c (dwarf2_create_include_psymtab): Use
16250         allocate_dependencies.
16251         (process_psymtab_comp_unit_reader)
16252         (build_type_psymtab_dependencies): Likewise.
16253         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16254
16255 2019-01-10  Tom Tromey  <tom@tromey.com>
16256
16257         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16258         PSYMBOL_SET_LANGUAGE.
16259         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16260
16261 2019-01-10  Tom Tromey  <tom@tromey.com>
16262
16263         * psymtab.h (psymtab_storage::obstack): New method.
16264         <m_obstack>: Rename from obstack; now private.
16265         * psymtab.c (psymtab_storage): Update.
16266         * dwarf2read.c (create_addrmap_from_index)
16267         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16268         Update.
16269
16270 2019-01-10  Tom Tromey  <tom@tromey.com>
16271
16272         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16273         * objfiles.h (objfile::reset_psymtabs): New method.
16274
16275 2019-01-10  Tom Tromey  <tom@tromey.com>
16276
16277         * symmisc.c (print_symbol_bcache_statistics): Update.
16278         (print_objfile_statistics): Update.
16279         * symfile.c (reread_symbols): Update.
16280         * psymtab.h (class psymtab_storage): New.
16281         * psymtab.c (psymtab_storage): New constructor.
16282         (~psymtab_storage): New destructor.
16283         (require_partial_symbols): Update.
16284         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16285         (find_pc_sect_psymtab, find_pc_sect_psymbol)
16286         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16287         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16288         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16289         (start_psymtab_common, end_psymtab_common)
16290         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16291         (allocate_psymtab): Update.
16292         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16293         Update.
16294         (dump_psymtab_addrmap, maintenance_print_psymbols)
16295         (maintenance_check_psymtabs): Update.
16296         (class objfile_psymtabs): Move to objfiles.h.
16297         * psympriv.h (discard_psymtab): Now inline.
16298         (psymtab_discarder::psymtab_discarder): Update.
16299         (psymtab_discarder::~psymtab_discarder): Update.
16300         (ALL_OBJFILE_PSYMTABS): Rewrite.
16301         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16302         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16303         Remove fields.
16304         <partial_symtabs>: New field.
16305         (class objfile_psymtabs): Move from psymtab.h.  Update.
16306         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16307         psymbol_cache.
16308         (objfile::~objfile): Don't destroy psymbol_cache.
16309         * mdebugread.c (parse_partial_symbols): Update.
16310         * dwarf2read.c (create_addrmap_from_index)
16311         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16312         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16313         (add_partial_subprogram, dwarf2_ranges_read): Update.
16314         * dwarf-index-write.c (write_address_map)
16315         (write_one_signatured_type, recursively_write_psymbols)
16316         (class debug_names, class debug_names, write_psymtabs_to_index):
16317         Update.
16318
16319 2019-01-10  Tom Tromey  <tom@tromey.com>
16320
16321         * symtab.h (SYMBOL_SET_NAMES): Update.
16322         (symbol_set_names): Update.
16323         (MSYMBOL_SET_NAMES): Update.
16324         * symtab.c (symbol_set_names): Change argument to be an
16325         objfile_per_bfd_storage.
16326         * psymtab.c (add_psymbol_to_bcache): Update.
16327         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16328
16329 2019-01-10  Tom Tromey  <tom@tromey.com>
16330
16331         * symtab.c (create_demangled_names_hash): Change argument to be an
16332         objfile_per_bfd_storage.
16333         (symbol_set_names): Update.
16334
16335 2019-01-10  Tom Tromey  <tom@tromey.com>
16336
16337         * xcoffread.c (xcoff_initial_scan): Unconditionally call
16338         init_psymbol_list.
16339         * psymtab.c (init_psymbol_list): Do nothing if already called.
16340         * psympriv.h (init_psymbol_list): Add comment.
16341         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16342         init_psymbol_list.
16343         * dbxread.c (dbx_symfile_read): Unconditionally call
16344         init_psymbol_list.
16345
16346 2019-01-10  Tom Tromey  <tom@tromey.com>
16347
16348         * xcoffread.c (scan_xcoff_symtab): Update.
16349         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16350         "where".
16351         * mdebugread.c (parse_partial_symbols)
16352         (handle_psymbol_enumerators): Update.
16353         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16354         * dbxread.c (read_dbx_symtab): Update.
16355         * psympriv.h (psymbol_placement): New enum.
16356         (add_psymbol_to_list): Update.
16357
16358 2019-01-10  Tom Tromey  <tom@tromey.com>
16359
16360         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16361         static_psymbols parameters.
16362         (scan_xcoff_symtab): Update.
16363         * psymtab.c (start_psymtab_common): Remove global_psymbols and
16364         static_psymbols parameters.
16365         * psympriv.h (start_psymtab_common): Update.
16366         * mdebugread.c (parse_partial_symbols): Update.
16367         * dwarf2read.c (create_partial_symtab): Update.
16368         * dbxread.c (read_dbx_symtab): Update.
16369         (start_psymtab): Remove global_psymbols and static_psymbols
16370         parameters.
16371
16372 2019-01-10  Tom Tromey  <tom@tromey.com>
16373
16374         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16375         * psymtab.c (allocate_psymtab): Add comment.
16376         * psympriv.h (allocate_psymtab): Add comment.
16377         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16378         initializations.
16379         * dbxread.c (dbx_end_psymtab): Remove some initializations.
16380
16381 2019-01-10  Tom Tromey  <tom@tromey.com>
16382
16383         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16384         Don't declare.
16385         * mipsread.c: Include mdebugread.h.
16386         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16387         Declare.
16388         * elfread.c: Include mdebugread.h.
16389
16390 2019-01-09  Tom Tromey  <tom@tromey.com>
16391
16392         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16393         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16394         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16395         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16396         (psym_lookup_symbol, psym_find_last_source_symtab)
16397         (psym_forget_cached_source_info, psym_print_stats)
16398         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16399         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16400         (psym_map_matching_symbols, psym_expand_symtabs_matching)
16401         (psym_find_compunit_symtab_by_address)
16402         (maintenance_print_psymbols, maintenance_info_psymtabs)
16403         (maintenance_check_psymtabs): Use ranged for.
16404         * psymtab.h (class objfile_psymtabs): New.
16405         (require_partial_symbols): Return objfile_psymtabs.
16406         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16407
16408 2019-01-09  Tom Tromey  <tom@tromey.com>
16409
16410         * symfile.c (overlay_invalidate_all, find_pc_overlay)
16411         (find_pc_mapped_section, list_overlays_command)
16412         (map_overlay_command, unmap_overlay_command)
16413         (simple_overlay_update): Use all_objfiles.
16414         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16415         * printcmd.c (info_symbol_command): Use all_objfiles.
16416         * objfiles.h (ALL_OBJSECTIONS): Remove.
16417         * maint.c (maintenance_translate_address): Use all_objfiles.
16418         * gcore.c (gcore_create_callback): Use all_objfiles.
16419         (objfile_find_memory_regions): Likewise.
16420
16421 2019-01-09  Tom Tromey  <tom@tromey.com>
16422
16423         * symtab.c (find_line_symtab, info_sources_command)
16424         (make_source_files_completion_list): Use objfile_compunits.
16425         * source.c (select_source_symtab): Use objfile_compunits.
16426         * objfiles.h (struct objfile): Update comment.
16427         (ALL_OBJFILES): Remove.
16428         (ALL_FILETABS): Remove.
16429         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16430         objfile_compunits.
16431
16432 2019-01-09  Tom Tromey  <tom@tromey.com>
16433
16434         * symmisc.c (print_objfile_statistics, dump_objfile)
16435         (maintenance_print_symbols): Use compunit_filetabs.
16436         * source.c (forget_cached_source_info_for_objfile): Use
16437         compunit_filetabs.
16438         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16439         (ALL_FILETABS): Use compunit_filetabs.
16440         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16441         * coffread.c (coff_symtab_read): Use compunit_filetabs.
16442
16443 2019-01-09  Tom Tromey  <tom@tromey.com>
16444
16445         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16446         (compunit_filetabs): New.
16447         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16448         compunit_filetabs.
16449         (info_sources_command, make_source_files_completion_list): Remove
16450         declaration.
16451         * symmisc.c (print_objfile_statistics, dump_objfile)
16452         (maintenance_print_symbols): Remove declaration.
16453         (maintenance_info_symtabs): Use compunit_filetabs.
16454         (maintenance_info_line_tables): Likewise.
16455         * source.c (select_source_symtab): Change local variable name.
16456         (forget_cached_source_info_for_objfile): Remove declaration.
16457         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16458         * objfiles.c (objfile_relocate1): Remove declaration.
16459         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16460         declaration.
16461         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16462         * coffread.c (coff_symtab_read): Remove declaration.
16463         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16464         compunit_filetabs.
16465
16466 2019-01-09  Tom Tromey  <tom@tromey.com>
16467
16468         * symtab.c (lookup_objfile_from_block)
16469         (find_pc_sect_compunit_symtab, search_symbols)
16470         (default_collect_symbol_completion_matches_break_on): Use
16471         objfile_compunits.
16472         * objfiles.h (ALL_COMPUNITS): Remove.
16473         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16474         * cp-support.c (add_symbol_overload_list_qualified): Use
16475         objfile_compunits.
16476         * ada-lang.c (ada_collect_symbol_completion_matches)
16477         (ada_add_global_exceptions): Use objfile_compunits.
16478
16479 2019-01-09  Tom Tromey  <tom@tromey.com>
16480
16481         * source.c (select_source_symtab)
16482         (forget_cached_source_info_for_objfile): Remove declaration.
16483         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16484         declaration.
16485         * maint.c (count_symtabs_and_blocks): Remove declaration.
16486         * cp-support.c (add_symbol_overload_list_qualified): Remove
16487         declaration.
16488         * coffread.c (coff_symtab_read): Remove declaration.
16489         * symtab.c (lookup_symbol_in_objfile_symtabs)
16490         (basic_lookup_transparent_type_1): Use objfile_compunits.
16491         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16492         (info_sources_command, search_symbols)
16493         (default_collect_symbol_completion_matches_break_on)
16494         (make_source_files_completion_list): Remove declaration.
16495         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16496         (ada_collect_symbol_completion_matches)
16497         (ada_add_global_exceptions): Remove declaration.
16498         * linespec.c (iterate_over_all_matching_symtabs): Use
16499         objfile_compunits.
16500         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16501         (class objfile_compunits): New.
16502         (ALL_COMPUNITS): Use objfile_compunits.
16503         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16504         (maintenance_check_symtabs, maintenance_info_line_tables): Use
16505         objfile_compunits.
16506         * objfiles.c (objfile_relocate1): Use objfile_compunits.
16507
16508 2019-01-09  Tom Tromey  <tom@tromey.com>
16509
16510         * symtab.c (search_symbols)
16511         (default_collect_symbol_completion_matches_break_on): Use
16512         objfile_msymbols.
16513         * ada-lang.c (ada_lookup_simple_minsym)
16514         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16515         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16516         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16517         objfile_msymbols.
16518         * coffread.c (coff_symfile_read): Use objfile_msymbols.
16519         * symmisc.c (dump_msymbols): Use objfile_msymbols.
16520         * objc-lang.c (find_methods): Use objfile_msymbols.
16521         (info_selectors_command, info_classes_command): Likewise.
16522         * stabsread.c (scan_file_globals): Use objfile_msymbols.
16523         * objfiles.h (class objfile_msymbols): New.
16524         (ALL_OBJFILE_MSYMBOLS): Remove.
16525         (ALL_MSYMBOLS): Remove.
16526
16527 2019-01-09  Tom Tromey  <tom@tromey.com>
16528
16529         * common/next-iterator.h (next_adapter): Add Iterator template
16530         parameter.
16531         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16532         (class all_objfiles_safe): New.
16533         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16534         * objfiles.c (put_objfile_before): Update comment.
16535         (add_separate_debug_objfile): Likewise.
16536         (free_all_objfiles): Use all_objfiles_safe.
16537         (objfile_purge_solibs): Likewise.
16538
16539 2019-01-09  Tom Tromey  <tom@tromey.com>
16540
16541         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16542         (expand_symtab_containing_pc, lookup_static_symbol)
16543         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16544         (find_symbol_at_address, find_line_symtab, find_main_name): Use
16545         all_objfiles.
16546         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16547         * breakpoint.c (create_overlay_event_breakpoint)
16548         (create_longjmp_master_breakpoint)
16549         (create_std_terminate_master_breakpoint)
16550         (create_exception_master_breakpoint): Use all_objfiles.
16551         * linux-thread-db.c (try_thread_db_load_from_pdir)
16552         (has_libpthread): Use all_objfiles.
16553         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16554         * linespec.c (iterate_over_all_matching_symtabs)
16555         (search_minsyms_for_name): Use all_objfiles.
16556         * maint.c (maintenance_info_sections): Use all_objfiles.
16557         * main.c (captured_main_1): Use all_objfiles.
16558         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16559         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16560         * guile/scm-pretty-print.c
16561         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16562         * solib-spu.c (append_ocl_sos): Use all_objfiles.
16563         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16564         (maintenance_print_msymbols): Use all_objfiles.
16565         * source.c (select_source_symtab): Use all_objfiles.
16566         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16567         * symfile.c (remove_symbol_file_command)
16568         (expand_symtabs_matching, map_symbol_filenames): Use
16569         all_objfiles.
16570         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16571         all_objfiles.
16572         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16573         * objc-lang.c (find_methods): Use all_objfiles.
16574         * objfiles.c (have_partial_symbols, have_full_symbols)
16575         (have_minimal_symbols, qsort_cmp)
16576         (default_iterate_over_objfiles_in_search_order): Use
16577         all_objfiles.
16578         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16579         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16580         (maintenance_check_psymtabs): Use all_objfiles.
16581         (ALL_PSYMTABS): Remove.
16582         * compile/compile-object-run.c (do_module_cleanup): Use
16583         all_objfiles.
16584         * blockframe.c (find_pc_partial_function): Use all_objfiles.
16585         * cp-support.c (add_symbol_overload_list_qualified): Use
16586         all_objfiles.
16587         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16588         Use all_objfiles.
16589         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16590         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16591         all_objfiles.
16592         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16593         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16594         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16595         Uses all_objfiles.
16596         * solib.c (solib_read_symbols): Use all_objfiles
16597
16598 2019-01-09  Tom Tromey  <tom@tromey.com>
16599
16600         * probe.c (parse_probes_in_pspace): Use all_objfiles.
16601         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16602         all_objfiles.
16603         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16604         * symmisc.c (print_symbol_bcache_statistics)
16605         (print_objfile_statistics, maintenance_print_objfiles)
16606         (maintenance_info_symtabs, maintenance_check_symtabs)
16607         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16608         all_objfiles.
16609         * source.c (forget_cached_source_info): Use all_objfiles.
16610         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16611         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16612         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16613         * objfiles.c (update_section_map): Use all_objfiles.
16614         (shared_objfile_contains_address_p): Likewise.
16615         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16616         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16617
16618 2019-01-09  Tom Tromey  <tom@tromey.com>
16619
16620         * common/next-iterator.h: New file.
16621         * objfiles.h (class all_objfiles): New.
16622         (struct objfile_iterator): New.
16623
16624 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16625
16626         * NEWS: Move the description of the changed "frame", "select-frame",
16627          and "info frame" commands to the Changed commands section.
16628
16629 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
16630
16631         * gdbtypes.c (check_stub_method_group): Remove handling of old
16632         mangling schemes.
16633         * linespec.c (find_methods): Likewise.
16634         * stabsread.c (read_member_functions): Likewise.
16635         * valops.c (search_struct_method): Likewise.
16636         (value_struct_elt_for_reference): Likewise.
16637         * NEWS: Mention this change.
16638
16639 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
16640
16641         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16642         print_source_lines.
16643         * source.c (print_source_lines_base): Update line number check.
16644         (print_source_lines): New function.
16645         (source_lines_range::source_lines_range): New function.
16646         * source.h (class source_lines_range): New class.
16647         (print_source_lines): New declaration.
16648
16649 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16650
16651         * linespec.c (linespec_state_destructor): Free self->canonical_names.
16652
16653 2019-01-08  Tom Tromey  <tom@tromey.com>
16654             Simon Marchi  <simon.marchi@ericsson.com>
16655
16656         PR gdb/24060
16657         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16658         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16659         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16660         * f-exp.y (DOLLAR_VARIABLE): Likewise.
16661         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16662         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16663
16664 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16665
16666         * source.c (select_source_symtab): Move header comment to
16667         declaration in source.h.
16668         (forget_cached_source_info_for_objfile): Likewise.
16669         (forget_cached_source_info): Likewise.
16670         (identify_source_line): Likewise.
16671         * source.h (identify_source_line): Move declaration from symtab.h
16672         and add comment from source.c
16673         (print_source_lines): Likewise.
16674         (forget_cached_source_info_for_objfile): Likewise.
16675         (forget_cached_source_info): Likewise.
16676         (select_source_symtab): Likewise.
16677         (enum print_source_lines_flag): Move definition from symtab.h.
16678         * symtab.h (identify_source_line): Move declaration to source.h.
16679         (print_source_lines): Likewise.
16680         (forget_cached_source_info_for_objfile): Likewise.
16681         (forget_cached_source_info): Likewise.
16682         (select_source_symtab): Likewise.
16683         (enum print_source_lines_flag): Move definition to source.h.
16684         * tui/tui-hooks.c: Add 'source.h' include.
16685
16686 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16687
16688         * source.c (print_source_lines_base): Handle requests to print
16689         reverse line number sequences, and guard against empty lines
16690         string.
16691
16692 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16693
16694         * source.c (print_source_lines_base): Fix skip of '\r' if next
16695         character is '\n'.
16696
16697 2019-01-06  Tom Tromey  <tom@tromey.com>
16698
16699         * c-exp.y (struct c_parse_state) <macro_original_text,
16700         expansion_obstack>: New member.
16701         (macro_original_text, expansion_obstack): Remove globals.
16702         (scan_macro_expansion, scanning_macro_expansion)
16703         (finished_macro_expansion): Update.
16704         (scan_macro_cleanup): Remove.
16705         (yylex, c_parse): Update.
16706
16707 2019-01-06  Tom Tromey  <tom@tromey.com>
16708
16709         * c-exp.y (struct c_parse_state) <strings>: New member.
16710         (operator_stoken): Update.
16711
16712 2019-01-06  Tom Tromey  <tom@tromey.com>
16713
16714         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
16715         (union type_stack_elt) <typelist_val>: Now a pointer to
16716         std::vector.
16717         (type_stack_cleanup): Don't declare.
16718         (push_typelist): Update.
16719         * parse.c (pop_typelist): Return a std::vector.
16720         (push_typelist): Take a std::vector.
16721         (follow_types): Update.  Do not free args.
16722         (type_stack_cleanup): Remove.
16723         * c-exp.y (struct c_parse_state): New.
16724         (cpstate): New global.
16725         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16726         (nonempty_typelist): Update.
16727         (func_mod): Create a new vector.
16728         (c_parse): Create a c_parse_state.
16729         (check_parameter_typelist): Do not delete params.
16730         (function_method): Update.  Do not delete type_list.
16731
16732 2019-01-06  Tom Tromey  <tom@tromey.com>
16733
16734         PR gdb/28155:
16735         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16736         check_typedef.
16737         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16738         (print_return_value): Likewise.
16739
16740 2019-01-05  Tom Tromey  <tom@tromey.com>
16741
16742         * contrib/cleanup_check.py: Remove.
16743         * contrib/gcc-with-excheck: Remove.
16744         * contrib/exsummary.py: Remove.
16745         * contrib/excheck.py: Remove.
16746
16747 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
16748
16749         * thread.c (delete_thread_1): Add gdb_assert that THR is not
16750         NULL. Initialize tpprev to NULL instead of assigning it
16751         to NULL on the next statement.
16752         * windows-nat.c (windows_delete_thread): Remove check for
16753         main_thread_id before printing thread exit notifications.
16754         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16755         Remove thread ID check against main_thread_id.
16756         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16757         windows_delete_thread.
16758         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16759
16760 2019-01-04  Tom Tromey  <tom@tromey.com>
16761
16762         * compile/compile.c (_initialize_compile): Use upper case for
16763         metasyntactic variables.
16764         * symmisc.c (_initialize_symmisc): Use upper case for
16765         metasyntactic variables.
16766         * psymtab.c (_initialize_psymtab): Use upper case for
16767         metasyntactic variables.
16768         * demangle.c (demangle_command): Use upper case for metasyntactic
16769         variables.
16770         (_initialize_demangler): Likewise.
16771         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16772         variables.
16773
16774 2019-01-03  Tom Tromey  <tom@tromey.com>
16775
16776         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16777
16778 2019-01-03  Tom Tromey  <tom@tromey.com>
16779
16780         * python/py-symtab.c (salpy_str): Update.
16781         (struct salpy_sal_object) <symtab>: Now a PyObject.
16782         (salpy_dealloc): Update.
16783         (del_objfile_sal): Use gdbpy_ref.
16784
16785 2019-01-03  Tom Tromey  <tom@tromey.com>
16786
16787         * python/py-type.c (convert_field): Use new_reference.  Return
16788         gdbpy_ref.
16789         (make_fielditem): Return gdbpy_ref.
16790         (typy_fields): Update.
16791         (typy_getitem): Update.
16792         (field_name): Return gdbpy_ref.  Use new_reference.
16793         (typy_iterator_iternext): Update.
16794
16795 2019-01-03  Tom Tromey  <tom@tromey.com>
16796
16797         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16798
16799 2019-01-03  Tom Tromey  <tom@tromey.com>
16800
16801         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16802         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16803         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16804         (pspy_set_frame_filters, pspy_set_frame_unwinders)
16805         (pspy_set_type_printers): Likewise.
16806         * python/py-function.c (fnpy_init): Use gdbpy_ref.
16807         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16808         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16809         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16810         (objfpy_set_type_printers): Likewise.
16811
16812 2019-01-03  Tom Tromey  <tom@tromey.com>
16813
16814         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16815         (gdbpy_print_stack): Use gdbpy_err_fetch.
16816         * python/python-internal.h (class gdbpy_err_fetch): New class.
16817         (class gdbpy_enter) <m_error_type, m_error_value,
16818         m_error_traceback>: Remove.
16819         <m_error>: New member.
16820         (gdbpy_exception_to_string): Don't declare.
16821         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16822         * python/py-value.c (convert_value_from_python): Use
16823         gdbpy_err_fetch.
16824         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16825         gdbpy_exception_to_string.
16826         (gdbpy_handle_exception): Use gdbpy_err_fetch.
16827         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16828         gdbpy_err_fetch.
16829
16830 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16831
16832         * linux-nat.c (delete_lwp_cleanup): Delete.
16833         (struct lwp_deleter): New struct.
16834         (lwp_info_up): New typedef.
16835         (linux_nat_target::follow_fork): Delete cleanup, and make use of
16836         lwp_info_up.
16837
16838 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16839
16840         * linux-fork.c (class scoped_switch_fork_info): New class.
16841         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16842
16843 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16844
16845         * valops.c (find_overload_match): Remove use of null_cleanup, and
16846         calls to do_cleanups.
16847
16848 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16849
16850         * compile/compile-cplus-types.c
16851         (compile_cplus_instance::decl_name): Handle changes to
16852         cp_func_name.
16853         * cp-support.c (cp_func_name): Update header comment, update
16854         return type.
16855         * cp-support.h (cp_func_name): Update return type in declaration.
16856         * valops.c (find_overload_match): Move temp_func local to top
16857         level of function and change its type.  Use temp_func to hold and
16858         delete temporary string obtained from cp_func_name.
16859
16860 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16861
16862         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16863         gdb::char_vector, remove cleanup, and update uses of `msg`.
16864
16865 2019-01-03  Jim Wilson  <jimw@sifive.com>
16866
16867         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16868
16869 2019-01-02  Tom Tromey  <tom@tromey.com>
16870
16871         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16872         (tdesc_parse_xml): Remove cleanups.
16873         * target-descriptions.h (make_cleanup_free_target_description):
16874         Don't declare.
16875         (target_desc_deleter): New struct.
16876         (target_desc_up): New typedef.
16877         * target-descriptions.c (target_desc_deleter::operator()): Rename
16878         from free_target_description.
16879         (make_cleanup_free_target_description): Remove.
16880
16881 2019-01-02  Tom Tromey  <tom@tromey.com>
16882
16883         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
16884         constructor, destructor.
16885         (linespec_parser): Remove typedef.
16886         (~linespec_parser): Rename from linespec_parser_delete.
16887         (linespec_lex_to_end, linespec_complete_label)
16888         (linespec_complete): Update.
16889         (decode_line_full): Remove cleanups.
16890         (decode_line_1): Update.
16891
16892 2019-01-02  Tom Tromey  <tom@tromey.com>
16893
16894         * python/python-internal.h (inferior_to_inferior_object): Change
16895         return type.
16896         * python/py-exitedevent.c (create_exited_event_object): Update.
16897         * python/py-inferior.c (inferior_to_inferior_object): Return
16898         gdbpy_ref.
16899         (python_new_inferior, python_inferior_deleted)
16900         (thread_to_thread_object, delete_thread_object)
16901         (build_inferior_list, gdbpy_selected_inferior): Update.
16902         * python/py-infthread.c (create_thread_object): Update.  Also fail
16903         if inferior_to_inferior_object fails.
16904
16905 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
16906
16907         * inferior.h (class inferior) <displaced_step_state>: New field.
16908         * infrun.h (struct displaced_step_state): Move here from
16909         infrun.c.  Initialize fields, add constructor.
16910         <inf>: Remove field.
16911         <reset>: New method.
16912         * infrun.c (struct displaced_step_inferior_state): Move to
16913         infrun.h.
16914         (displaced_step_inferior_states): Remove.
16915         (get_displaced_stepping_state): Adust.
16916         (displaced_step_in_progress_any_inferior): Adjust.
16917         (displaced_step_in_progress_thread): Adjust.
16918         (displaced_step_in_progress): Adjust.
16919         (add_displaced_stepping_state): Remove.
16920         (get_displaced_step_closure_by_addr): Adjust.
16921         (remove_displaced_stepping_state): Remove.
16922         (infrun_inferior_exit): Call displaced_step_state.reset.
16923         (use_displaced_stepping): Don't check for NULL.
16924         (displaced_step_prepare_throw): Call
16925         get_displaced_stepping_state.
16926         (displaced_step_fixup): Don't check for NULL.
16927         (prepare_for_detach): Don't check for NULL.
16928
16929 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16930
16931         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16932          in case of call that did not complete.
16933
16934 2019-01-02  Andrey Utkin  <autkin@undo.io>
16935
16936         * symfile.c (find_separate_debug_file): Fix search of debug files for
16937         remote debuggee.
16938
16939 2019-01-02  Tom Tromey  <tom@tromey.com>
16940
16941         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16942         indentation.
16943         * python/py-frame.c (frapy_older): Remove cast.
16944         (frapy_newer): Likewise.
16945         * python/py-breakpoint.c (local_setattro): Remove cast.
16946         * python/py-arch.c (archpy_name): Remove local variable.
16947         * python/py-type.c (gdbpy_lookup_type): Remove cast.
16948
16949 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
16950
16951         * unittests/basic_string_view/element_access/char/empty.cc:
16952         Fix year range in copyright header.
16953
16954 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
16955
16956         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16957         Delete.
16958         <operator==>: Update with for removed field.
16959         <hash>: Likewise.
16960         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16961         <isa_features>: ...this.
16962         <abi_features>: New field.
16963         (riscv_isa_flen): Update comment.
16964         (riscv_abi_xlen): New declaration.
16965         (riscv_abi_flen): New declaration.
16966         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16967         isa_features.
16968         (riscv_abi_xlen): New function.
16969         (riscv_isa_flen): Update to get answer from isa_features.
16970         (riscv_abi_flen): New function.
16971         (riscv_has_fp_abi): Update to get answer from abi_features.
16972         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16973         xlen and flen.
16974         (riscv_call_info) <xlen, flen>: Update comment.
16975         (riscv_call_arg_struct): Remove invalid assertions
16976         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16977         is removed.
16978         (riscv_gdbarch_init): Gather isa features and abi features
16979         separately, ensure both match on the gdbarch when reusing an old
16980         gdbarch.  Relax an error check to allow 32-bit abi float to run on
16981         a target with 64-bit float hardware.
16982
16983 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16984
16985         * source.c (search_command_helper): Stop reverse search
16986         when line 1 has been searched.
16987
16988 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16989
16990         * record-full.c (record_full_base_target::close): Rewrite
16991         record_full_core_buf_list free logic.
16992
16993 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16994
16995         * break-catch-syscall.c (print_one_catch_syscall): xfree
16996         the last text.
16997
16998 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16999
17000         * top.c (print_gdb_version): Update Copyright year in version
17001         message.
17002
17003 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
17004
17005         Update copyright year range in all GDB files.
17006
17007 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
17008
17009         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
17010
17011 For older changes see ChangeLog-2018.
17012 \f
17013 Local Variables:
17014 mode: change-log
17015 left-margin: 8
17016 fill-column: 74
17017 version-control: never
17018 coding: utf-8
17019 End:
17020