gdb/contrib/ari/gdb_ari.sh

   1 #!/bin/sh
   2
   3 # GDB script to list of problems using awk.
   4 #
   5 # Copyright (C) 2002-2019 Free Software Foundation, Inc.
   6 #
   7 # This file is part of GDB.
   8 #
   9 # This program is free software; you can redistribute it and/or modify
  10 # it under the terms of the GNU General Public License as published by
  11 # the Free Software Foundation; either version 3 of the License, or
  12 # (at your option) any later version.
  13 #
  14 # This program is distributed in the hope that it will be useful,
  15 # but WITHOUT ANY WARRANTY; without even the implied warranty of
  16 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  17 # GNU General Public License for more details.
  18 #
  19 # You should have received a copy of the GNU General Public License
  20 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
  21
  22 # Make certain that the script is not running in an internationalized
  23 # environment.
  24
  25 LANG=C ; export LANG
  26 LC_ALL=C ; export LC_ALL
  27
  28 # Permanent checks take the form:
  29
  30 #     Do not use XXXX, C++11 implies YYYY
  31 #     Do not use XXXX, instead use YYYY''.
  32
  33 # and should never be removed.
  34
  35 # Temporary checks take the form:
  36
  37 #     Replace XXXX with YYYY
  38
  39 # and once they reach zero, can be eliminated.
  40
  41 # FIXME: It should be able to override this on the command line
  42 error="regression"
  43 warning="regression"
  44 ari="regression eol code comment deprecated legacy obsolete gettext"
  45 all="regression eol code comment deprecated legacy obsolete gettext deprecate internal gdbarch macro"
  46 print_doc=0
  47 print_idx=0
  48
  49 usage ()
  50 {
  51     cat <<EOF 1>&2
  52 Error: $1
  53
  54 Usage:
  55     $0 --print-doc --print-idx -Wall -Werror -W<category> <file> ...
  56 Options:
  57   --print-doc    Print a list of all potential problems, then exit.
  58   --print-idx    Include the problems IDX (index or key) in every message.
  59   --src=file     Write source lines to file.
  60   -Werror        Treat all problems as errors.
  61   -Wall          Report all problems.
  62   -Wari          Report problems that should be fixed in new code.
  63   -W<category>   Report problems in the specifed category.  Valid categories
  64                  are: ${all}
  65 EOF
  66     exit 1
  67 }
  68
  69
  70 # Parse the various options
  71 Woptions=
  72 srclines=""
  73 while test $# -gt 0
  74 do
  75     case "$1" in
  76     -Wall ) Woptions="${all}" ;;
  77     -Wari ) Woptions="${ari}" ;;
  78     -Werror ) Werror=1 ;;
  79     -W* ) Woptions="${Woptions} `echo x$1 | sed -e 's/x-W//'`" ;;
  80     --print-doc ) print_doc=1 ;;
  81     --print-idx ) print_idx=1 ;;
  82     --src=* ) srclines="`echo $1 | sed -e 's/--src=/srclines=\"/'`\"" ;;
  83     -- ) shift ; break ;;
  84     - ) break ;;
  85     -* ) usage "$1: unknown option" ;;
  86     * ) break ;;
  87     esac
  88     shift
  89 done
  90 if test -n "$Woptions" ; then
  91     warning="$Woptions"
  92     error=
  93 fi
  94
  95
  96 # -Werror implies treating all warnings as errors.
  97 if test -n "${Werror}" ; then
  98     error="${error} ${warning}"
  99 fi
 100
 101
 102 # Validate all errors and warnings.
 103 for w in ${warning} ${error}
 104 do
 105     case " ${all} " in
 106     *" ${w} "* ) ;;
 107     * ) usage "Unknown option -W${w}" ;;
 108     esac
 109 done
 110
 111
 112 # make certain that there is at least one file.
 113 if test $# -eq 0 -a ${print_doc} = 0
 114 then
 115     usage "Missing file."
 116 fi
 117
 118
 119 # Convert the errors/warnings into corresponding array entries.
 120 for a in ${all}
 121 do
 122     aris="${aris} ari_${a} = \"${a}\";"
 123 done
 124 for w in ${warning}
 125 do
 126     warnings="${warnings} warning[ari_${w}] = 1;"
 127 done
 128 for e in ${error}
 129 do
 130     errors="${errors} error[ari_${e}]  = 1;"
 131 done
 132
 133 if [ "$AWK" = "" ] ; then
 134   AWK=awk
 135 fi
 136
 137 ${AWK} -- '
 138 BEGIN {
 139     # NOTE, for a per-file begin use "FNR == 1".
 140     '"${aris}"'
 141     '"${errors}"'
 142     '"${warnings}"'
 143     '"${srclines}"'
 144     print_doc =  '$print_doc'
 145     print_idx =  '$print_idx'
 146     PWD = "'`pwd`'"
 147 }
 148
 149 # Print the error message for BUG.  Append SUPLEMENT if non-empty.
 150 function print_bug(file,line,prefix,category,bug,doc,supplement, suffix,idx) {
 151     if (print_idx) {
 152         idx = bug ": "
 153     } else {
 154         idx = ""
 155     }
 156     if (supplement) {
 157         suffix = " (" supplement ")"
 158     } else {
 159         suffix = ""
 160     }
 161     # ari.*.bug: <FILE>:<LINE>: <CATEGORY>: <BUG>: <DOC>
 162     print file ":" line ": " prefix category ": " idx doc suffix
 163     if (srclines != "") {
 164         print file ":" line ":" $0 >> srclines
 165     }
 166 }
 167
 168 function fix(bug,file,count) {
 169     skip[bug, file] = count
 170     skipped[bug, file] = 0
 171 }
 172
 173 function fail(bug,supplement) {
 174     if (doc[bug] == "") {
 175         print_bug("", 0, "internal: ", "internal", "internal", "Missing doc for bug " bug)
 176         exit
 177     }
 178     if (category[bug] == "") {
 179         print_bug("", 0, "internal: ", "internal", "internal", "Missing category for bug " bug)
 180         exit
 181     }
 182
 183     if (ARI_OK == bug) {
 184         return
 185     }
 186     # Trim the filename down to just DIRECTORY/FILE so that it can be
 187     # robustly used by the FIX code.
 188
 189     if (FILENAME ~ /^\//) {
 190         canonicalname = FILENAME
 191     } else {
 192         canonicalname = PWD "/" FILENAME
 193     }
 194     shortname = gensub (/^.*\/([^\\]*\/[^\\]*)$/, "\\1", 1, canonicalname)
 195
 196     skipped[bug, shortname]++
 197     if (skip[bug, shortname] >= skipped[bug, shortname]) {
 198         # print FILENAME, FNR, skip[bug, FILENAME], skipped[bug, FILENAME], bug
 199         # Do nothing
 200     } else if (error[category[bug]]) {
 201         # ari.*.bug: <FILE>:<LINE>: <CATEGORY>: <BUG>: <DOC>
 202         print_bug(FILENAME, FNR, "", category[bug], bug, doc[bug], supplement)
 203     } else if (warning[category[bug]]) {
 204         # ari.*.bug: <FILE>:<LINE>: <CATEGORY>: <BUG>: <DOC>
 205         print_bug(FILENAME, FNR, "warning: ", category[bug], bug, doc[bug], supplement)
 206     }
 207 }
 208
 209 FNR == 1 {
 210     seen[FILENAME] = 1
 211     if (match(FILENAME, "\\.[ly]$")) {
 212       # FILENAME is a lex or yacc source
 213       is_yacc_or_lex = 1
 214     }
 215     else {
 216       is_yacc_or_lex = 0
 217     }
 218 }
 219 END {
 220     if (print_idx) {
 221         idx = bug ": "
 222     } else {
 223         idx = ""
 224     }
 225     # Did we do only a partial skip?
 226     for (bug_n_file in skip) {
 227         split (bug_n_file, a, SUBSEP)
 228         bug = a[1]
 229         file = a[2]
 230         if (seen[file] && (skipped[bug_n_file] < skip[bug_n_file])) {
 231             # ari.*.bug: <FILE>:<LINE>: <CATEGORY>: <BUG>: <DOC>
 232             b = file " missing " bug
 233             print_bug(file, 0, "", "internal", file " missing " bug, "Expecting " skip[bug_n_file] " occurances of bug " bug " in file " file ", only found " skipped[bug_n_file])
 234         }
 235     }
 236 }
 237
 238
 239 # Skip OBSOLETE lines
 240 /(^|[^_[:alnum:]])OBSOLETE([^_[:alnum:]]|$)/ { next; }
 241
 242 # Skip ARI lines
 243
 244 BEGIN {
 245     ARI_OK = ""
 246 }
 247
 248 /\/\* ARI:[[:space:]]*(.*)[[:space:]]*\*\// {
 249     ARI_OK = gensub(/^.*\/\* ARI:[[:space:]]*(.*[^[:space:]])[[:space:]]*\*\/.*$/, "\\1", 1, $0)
 250     # print "ARI line found \"" $0 "\""
 251     # print "ARI_OK \"" ARI_OK "\""
 252 }
 253 ! /\/\* ARI:[[:space:]]*(.*)[[:space:]]*\*\// {
 254     ARI_OK = ""
 255 }
 256
 257
 258 # SNIP - Strip out comments - SNIP
 259
 260 FNR == 1 {
 261     comment_p = 0
 262 }
 263 comment_p && /\*\// { gsub (/^([^\*]|\*+[^\/\*])*\*+\//, " "); comment_p = 0; }
 264 comment_p { next; }
 265 !comment_p { gsub (/\/\*([^\*]|\*+[^\/\*])*\*+\//, " "); }
 266 !comment_p && /(^|[^"])\/\*/ { gsub (/\/\*.*$/, " "); comment_p = 1; }
 267
 268
 269 BEGIN { doc["_ markup"] = "\
 270 All messages should be marked up with _."
 271     category["_ markup"] = ari_gettext
 272 }
 273 /^[^"]*[[:space:]](warning|error|error_no_arg|query|perror_with_name)[[:space:]]*\([^_\(a-z]/ {
 274     if (! /\("%s"/) {
 275         fail("_ markup")
 276     }
 277 }
 278
 279 BEGIN { doc["trailing new line"] = "\
 280 A message should not have a trailing new line"
 281     category["trailing new line"] = ari_gettext
 282 }
 283 /(^|[^_[:alnum:]])(warning|error)[[:space:]]*\(_\(".*\\n"\)[\),]/ {
 284     fail("trailing new line")
 285 }
 286
 287 # Include files for which GDB has a custom version.
 288
 289 BEGIN { doc["assert.h"] = "\
 290 Do not include assert.h, instead include \"gdb_assert.h\"";
 291     category["assert.h"] = ari_regression
 292     fix("assert.h", "gdb/gdb_assert.h", 0) # it does not use it
 293 }
 294 /^#[[:space:]]*include[[:space:]]+.assert\.h./ {
 295     fail("assert.h")
 296 }
 297
 298 BEGIN { doc["regex.h"] = "\
 299 Do not include regex.h, instead include gdb_regex.h"
 300     category["regex.h"] = ari_regression
 301     fix("regex.h", "gdb/gdb_regex.h", 1)
 302 }
 303 /^#[[:space:]]*include[[:space:]]*.regex\.h./ {
 304     fail("regex.h")
 305 }
 306
 307 BEGIN { doc["xregex.h"] = "\
 308 Do not include xregex.h, instead include gdb_regex.h"
 309     category["xregex.h"] = ari_regression
 310     fix("xregex.h", "gdb/gdb_regex.h", 1)
 311 }
 312 /^#[[:space:]]*include[[:space:]]*.xregex\.h./ {
 313     fail("xregex.h")
 314 }
 315
 316 BEGIN { doc["gnu-regex.h"] = "\
 317 Do not include gnu-regex.h, instead include gdb_regex.h"
 318     category["gnu-regex.h"] = ari_regression
 319 }
 320 /^#[[:space:]]*include[[:space:]]*.gnu-regex\.h./ {
 321     fail("gnu regex.h")
 322 }
 323
 324 BEGIN { doc["wait.h"] = "\
 325 Do not include wait.h or sys/wait.h, instead include gdb_wait.h"
 326     fix("wait.h", "gdbsupport/gdb_wait.h", 2);
 327     category["wait.h"] = ari_regression
 328 }
 329 /^#[[:space:]]*include[[:space:]]*.wait\.h./ \
 330 || /^#[[:space:]]*include[[:space:]]*.sys\/wait\.h./ {
 331     fail("wait.h")
 332 }
 333
 334 BEGIN { doc["vfork.h"] = "\
 335 Do not include vfork.h, instead include gdb_vfork.h"
 336     fix("vfork.h", "gdb/gdb_vfork.h", 1);
 337     category["vfork.h"] = ari_regression
 338 }
 339 /^#[[:space:]]*include[[:space:]]*.vfork\.h./ {
 340     fail("vfork.h")
 341 }
 342
 343 BEGIN { doc["error not internal-warning"] = "\
 344 Do not use error(\"internal-warning\"), instead use internal_warning"
 345     category["error not internal-warning"] = ari_regression
 346 }
 347 /error.*\"[Ii]nternal.warning/ {
 348     fail("error not internal-warning")
 349 }
 350
 351 BEGIN { doc["%p"] = "\
 352 Do not use printf(\"%p\"), instead use printf(\"%s\",paddr()) to dump a \
 353 target address, or host_address_to_string() for a host address"
 354     category["%p"] = ari_code
 355 }
 356 # Allow gdb %p extensions, but not other uses of %p.
 357 /%p[^[\]sF]/ && !/%prec/ {
 358     fail("%p")
 359 }
 360
 361 BEGIN { doc["%ll"] = "\
 362 Do not use printf(\"%ll\"), instead use printf(\"%s\",phex()) to dump a \
 363 `long long'\'' value"
 364     category["%ll"] = ari_code
 365 }
 366 # Allow %ll in scanf
 367 /%[0-9]*ll/ && !/scanf \(.*%[0-9]*ll/ {
 368     fail("%ll")
 369 }
 370
 371
 372 # SNIP - Strip out strings - SNIP
 373
 374 # Test on top.c, scm-valprint.c, remote-rdi.c, ada-lang.c
 375 FNR == 1 {
 376     string_p = 0
 377     trace_string = 0
 378 }
 379 # Strip escaped characters.
 380 { gsub(/\\./, "."); }
 381 # Strip quoted quotes.
 382 { gsub(/'\''.'\''/, "'\''.'\''"); }
 383 # End of multi-line string
 384 string_p && /\"/ {
 385     if (trace_string) print "EOS:" FNR, $0;
 386     gsub (/^[^\"]*\"/, "'\''");
 387     string_p = 0;
 388 }
 389 # Middle of multi-line string, discard line.
 390 string_p {
 391     if (trace_string) print "MOS:" FNR, $0;
 392     $0 = ""
 393 }
 394 # Strip complete strings from the middle of the line
 395 !string_p && /\"[^\"]*\"/ {
 396     if (trace_string) print "COS:" FNR, $0;
 397     gsub (/\"[^\"]*\"/, "'\''");
 398 }
 399 # Start of multi-line string
 400 BEGIN { doc["multi-line string"] = "\
 401 Multi-line string must have the newline escaped"
 402     category["multi-line string"] = ari_regression
 403 }
 404 !string_p && /\"/ {
 405     if (trace_string) print "SOS:" FNR, $0;
 406     if (/[^\\]$/) {
 407         fail("multi-line string")
 408     }
 409     gsub (/\"[^\"]*$/, "'\''");
 410     string_p = 1;
 411 }
 412 # { print }
 413
 414 # Multi-line string
 415 string_p &&
 416
 417 # Accumulate continuation lines
 418 FNR == 1 {
 419     cont_p = 0
 420 }
 421 !cont_p { full_line = ""; }
 422 /[^\\]\\$/ { gsub (/\\$/, ""); full_line = full_line $0; cont_p = 1; next; }
 423 cont_p { $0 = full_line $0; cont_p = 0; full_line = ""; }
 424
 425
 426 BEGIN { doc["__FUNCTION__"] = "\
 427 Do not use __FUNCTION__, C++11 does not support this macro"
 428     category["__FUNCTION__"] = ari_regression
 429 }
 430 /(^|[^_[:alnum:]])__FUNCTION__([^_[:alnum:]]|$)/ {
 431     fail("__FUNCTION__")
 432 }
 433
 434 BEGIN { doc["__CYGWIN32__"] = "\
 435 Do not use __CYGWIN32__, instead use __CYGWIN__ or, better, an explicit \
 436 autoconf tests"
 437     category["__CYGWIN32__"] = ari_regression
 438 }
 439 /(^|[^_[:alnum:]])__CYGWIN32__([^_[:alnum:]]|$)/ {
 440     fail("__CYGWIN32__")
 441 }
 442
 443 BEGIN { doc["PTR"] = "\
 444 Do not use PTR, C++11 implies `void *'\''"
 445     category["PTR"] = ari_regression
 446     #fix("PTR", "gdb/utils.c", 6)
 447 }
 448 /(^|[^_[:alnum:]])PTR([^_[:alnum:]]|$)/ {
 449     fail("PTR")
 450 }
 451
 452 BEGIN { doc["UCASE function"] = "\
 453 Function name is uppercase."
 454     category["UCASE function"] = ari_code
 455     possible_UCASE = 0
 456     UCASE_full_line = ""
 457 }
 458 (possible_UCASE) {
 459     if (ARI_OK == "UCASE function") {
 460         possible_UCASE = 0
 461     }
 462     # Closing brace found?
 463     else if (UCASE_full_line ~ \
 464         /^[A-Z][[:alnum:]_]*[[:space:]]*\([^()]*\).*$/) {
 465         if ((UCASE_full_line ~ \
 466             /^[A-Z][[:alnum:]_]*[[:space:]]*\([^()]*\)[[:space:]]*$/) \
 467             && ($0 ~ /^\{/) && (is_yacc_or_lex == 0)) {
 468             store_FNR = FNR
 469             FNR = possible_FNR
 470             store_0 = $0;
 471             $0 = UCASE_full_line;
 472             fail("UCASE function")
 473             FNR = store_FNR
 474             $0 = store_0;
 475         }
 476         possible_UCASE = 0
 477         UCASE_full_line = ""
 478     } else {
 479         UCASE_full_line = UCASE_full_line $0;
 480     }
 481 }
 482 /^[A-Z][[:alnum:]_]*[[:space:]]*\([^()]*(|\))[[:space:]]*$/ {
 483     possible_UCASE = 1
 484     if (ARI_OK == "UCASE function") {
 485         possible_UCASE = 0
 486     }
 487     possible_FNR = FNR
 488     UCASE_full_line = $0
 489 }
 490
 491
 492 BEGIN { doc["editCase function"] = "\
 493 Function name starts lower case but has uppercased letters."
 494     category["editCase function"] = ari_code
 495     possible_editCase = 0
 496     editCase_full_line = ""
 497 }
 498 (possible_editCase) {
 499     if (ARI_OK == "editCase function") {
 500         possible_editCase = 0
 501     }
 502     # Closing brace found?
 503     else if (editCase_full_line ~ \
 504 /^[a-z][a-z0-9_]*[A-Z][a-z0-9A-Z_]*[[:space:]]*\([^()]*\).*$/) {
 505         if ((editCase_full_line ~ \
 506 /^[a-z][a-z0-9_]*[A-Z][a-z0-9A-Z_]*[[:space:]]*\([^()]*\)[[:space:]]*$/) \
 507             && ($0 ~ /^\{/) && (is_yacc_or_lex == 0)) {
 508             store_FNR = FNR
 509             FNR = possible_FNR
 510             store_0 = $0;
 511             $0 = editCase_full_line;
 512             fail("editCase function")
 513             FNR = store_FNR
 514             $0 = store_0;
 515         }
 516         possible_editCase = 0
 517         editCase_full_line = ""
 518     } else {
 519         editCase_full_line = editCase_full_line $0;
 520     }
 521 }
 522 /^[a-z][a-z0-9_]*[A-Z][a-z0-9A-Z_]*[[:space:]]*\([^()]*(|\))[[:space:]]*$/ {
 523     possible_editCase = 1
 524     if (ARI_OK == "editCase function") {
 525         possible_editCase = 0
 526     }
 527     possible_FNR = FNR
 528     editCase_full_line = $0
 529 }
 530
 531 # Only function implementation should be on first column
 532 BEGIN { doc["function call in first column"] = "\
 533 Function name in first column should be restricted to function implementation"
 534     category["function call in first column"] = ari_code
 535 }
 536 /^[a-z][a-z0-9_]*[[:space:]]*\((|[^*][^()]*)\)[[:space:]]*[^ \t]+/ {
 537     fail("function call in first column")
 538 }
 539
 540
 541 BEGIN { doc["hash"] = "\
 542 Do not use ` #...'\'', instead use `#...'\''(some compilers only correctly \
 543 parse a C preprocessor directive when `#'\'' is the first character on \
 544 the line)"
 545     category["hash"] = ari_regression
 546 }
 547 /^[[:space:]]+#/ {
 548     fail("hash")
 549 }
 550
 551 BEGIN { doc["OP eol"] = "\
 552 Do not use &&, or || at the end of a line"
 553     category["OP eol"] = ari_code
 554 }
 555 # * operator needs a special treatment as it can be a
 556 # valid end of line for a pointer type definition
 557 # Only catch case where an assignment or an opening brace is present
 558 /(\|\||\&\&|==|!=|[[:space:]][+\-\/])[[:space:]]*$/ \
 559 || /(\(|=)[[:space:]].*[[:space:]]\*[[:space:]]*$/ {
 560     fail("OP eol")
 561 }
 562
 563 BEGIN { doc["strerror"] = "\
 564 Do not use strerror(), instead use safe_strerror()"
 565     category["strerror"] = ari_regression
 566     fix("strerror", "gdb/gdb_string.h", 1)
 567     fix("strerror", "gdb/gdbsupport/mingw-strerror.c", 1)
 568     fix("strerror", "gdb/gdbsupport/posix-strerror.c", 1)
 569 }
 570 /(^|[^_[:alnum:]])strerror[[:space:]]*\(/ {
 571     fail("strerror")
 572 }
 573
 574 BEGIN { doc["long long"] = "\
 575 Do not use `long long'\'', instead use LONGEST"
 576     category["long long"] = ari_code
 577     # defs.h needs two such patterns for LONGEST and ULONGEST definitions
 578     fix("long long", "gdb/defs.h", 2)
 579 }
 580 /(^|[^_[:alnum:]])long[[:space:]]+long([^_[:alnum:]]|$)/ {
 581     fail("long long")
 582 }
 583
 584 BEGIN { doc["ATTRIBUTE_UNUSED"] = "\
 585 Do not use ATTRIBUTE_UNUSED, do not bother (GDB is compiled with -Werror and, \
 586 consequently, is not able to tolerate false warnings.  Since -Wunused-param \
 587 produces such warnings, neither that warning flag nor ATTRIBUTE_UNUSED \
 588 are used by GDB"
 589     category["ATTRIBUTE_UNUSED"] = ari_regression
 590 }
 591 /(^|[^_[:alnum:]])ATTRIBUTE_UNUSED([^_[:alnum:]]|$)/ {
 592     fail("ATTRIBUTE_UNUSED")
 593 }
 594
 595 BEGIN { doc["ATTR_FORMAT"] = "\
 596 Do not use ATTR_FORMAT, use ATTRIBUTE_PRINTF instead"
 597     category["ATTR_FORMAT"] = ari_regression
 598 }
 599 /(^|[^_[:alnum:]])ATTR_FORMAT([^_[:alnum:]]|$)/ {
 600     fail("ATTR_FORMAT")
 601 }
 602
 603 BEGIN { doc["ATTR_NORETURN"] = "\
 604 Do not use ATTR_NORETURN, use ATTRIBUTE_NORETURN instead"
 605     category["ATTR_NORETURN"] = ari_regression
 606 }
 607 /(^|[^_[:alnum:]])ATTR_NORETURN([^_[:alnum:]]|$)/ {
 608     fail("ATTR_NORETURN")
 609 }
 610
 611 BEGIN { doc["NORETURN"] = "\
 612 Do not use NORETURN, use ATTRIBUTE_NORETURN instead"
 613     category["NORETURN"] = ari_regression
 614 }
 615 /(^|[^_[:alnum:]])NORETURN([^_[:alnum:]]|$)/ {
 616     fail("NORETURN")
 617 }
 618
 619
 620 # General problems
 621
 622 BEGIN { doc["multiple messages"] = "\
 623 Do not use multiple calls to warning or error, instead use a single call"
 624     category["multiple messages"] = ari_gettext
 625 }
 626 FNR == 1 {
 627     warning_fnr = -1
 628 }
 629 /(^|[^_[:alnum:]])(warning|error)[[:space:]]*\(/ {
 630     if (FNR == warning_fnr + 1) {
 631         fail("multiple messages")
 632     } else {
 633         warning_fnr = FNR
 634     }
 635 }
 636
 637 # Commented out, but left inside sources, just in case.
 638 # BEGIN { doc["inline"] = "\
 639 # Do not use the inline attribute; \
 640 # since the compiler generally ignores this, better algorithm selection \
 641 # is needed to improved performance"
 642 #    category["inline"] = ari_code
 643 # }
 644 # /(^|[^_[:alnum:]])inline([^_[:alnum:]]|$)/ {
 645 #     fail("inline")
 646 # }
 647
 648 # This test is obsolete as this type
 649 # has been deprecated and finally suppressed from GDB sources
 650 #BEGIN { doc["obj_private"] = "\
 651 #Replace obj_private with objfile_data"
 652 #    category["obj_private"] = ari_obsolete
 653 #}
 654 #/(^|[^_[:alnum:]])obj_private([^_[:alnum:]]|$)/ {
 655 #    fail("obj_private")
 656 #}
 657
 658 BEGIN { doc["abort"] = "\
 659 Do not use abort, instead use internal_error; GDB should never abort"
 660     category["abort"] = ari_regression
 661     fix("abort", "gdb/utils.c", 3)
 662 }
 663 /(^|[^_[:alnum:]])abort[[:space:]]*\(/ {
 664     fail("abort")
 665 }
 666
 667 BEGIN { doc["basename"] = "\
 668 Do not use basename, instead use lbasename"
 669     category["basename"] = ari_regression
 670 }
 671 /(^|[^_[:alnum:]])basename[[:space:]]*\(/ {
 672     fail("basename")
 673 }
 674
 675 BEGIN { doc["assert"] = "\
 676 Do not use assert, instead use gdb_assert or internal_error; assert \
 677 calls abort and GDB should never call abort"
 678     category["assert"] = ari_regression
 679 }
 680 /(^|[^_[:alnum:]])assert[[:space:]]*\(/ {
 681     fail("assert")
 682 }
 683
 684 BEGIN { doc["TARGET_HAS_HARDWARE_WATCHPOINTS"] = "\
 685 Replace TARGET_HAS_HARDWARE_WATCHPOINTS with nothing, not needed"
 686     category["TARGET_HAS_HARDWARE_WATCHPOINTS"] = ari_regression
 687 }
 688 /(^|[^_[:alnum:]])TARGET_HAS_HARDWARE_WATCHPOINTS([^_[:alnum:]]|$)/ {
 689     fail("TARGET_HAS_HARDWARE_WATCHPOINTS")
 690 }
 691
 692 BEGIN { doc["ADD_SHARED_SYMBOL_FILES"] = "\
 693 Replace ADD_SHARED_SYMBOL_FILES with nothing, not needed?"
 694     category["ADD_SHARED_SYMBOL_FILES"] = ari_regression
 695 }
 696 /(^|[^_[:alnum:]])ADD_SHARED_SYMBOL_FILES([^_[:alnum:]]|$)/ {
 697     fail("ADD_SHARED_SYMBOL_FILES")
 698 }
 699
 700 BEGIN { doc["SOLIB_ADD"] = "\
 701 Replace SOLIB_ADD with nothing, not needed?"
 702     category["SOLIB_ADD"] = ari_regression
 703 }
 704 /(^|[^_[:alnum:]])SOLIB_ADD([^_[:alnum:]]|$)/ {
 705     fail("SOLIB_ADD")
 706 }
 707
 708 BEGIN { doc["SOLIB_CREATE_INFERIOR_HOOK"] = "\
 709 Replace SOLIB_CREATE_INFERIOR_HOOK with nothing, not needed?"
 710     category["SOLIB_CREATE_INFERIOR_HOOK"] = ari_regression
 711 }
 712 /(^|[^_[:alnum:]])SOLIB_CREATE_INFERIOR_HOOK([^_[:alnum:]]|$)/ {
 713     fail("SOLIB_CREATE_INFERIOR_HOOK")
 714 }
 715
 716 BEGIN { doc["SOLIB_LOADED_LIBRARY_PATHNAME"] = "\
 717 Replace SOLIB_LOADED_LIBRARY_PATHNAME with nothing, not needed?"
 718     category["SOLIB_LOADED_LIBRARY_PATHNAME"] = ari_regression
 719 }
 720 /(^|[^_[:alnum:]])SOLIB_LOADED_LIBRARY_PATHNAME([^_[:alnum:]]|$)/ {
 721     fail("SOLIB_LOADED_LIBRARY_PATHNAME")
 722 }
 723
 724 BEGIN { doc["REGISTER_U_ADDR"] = "\
 725 Replace REGISTER_U_ADDR with nothing, not needed?"
 726     category["REGISTER_U_ADDR"] = ari_regression
 727 }
 728 /(^|[^_[:alnum:]])REGISTER_U_ADDR([^_[:alnum:]]|$)/ {
 729     fail("REGISTER_U_ADDR")
 730 }
 731
 732 BEGIN { doc["PROCESS_LINENUMBER_HOOK"] = "\
 733 Replace PROCESS_LINENUMBER_HOOK with nothing, not needed?"
 734     category["PROCESS_LINENUMBER_HOOK"] = ari_regression
 735 }
 736 /(^|[^_[:alnum:]])PROCESS_LINENUMBER_HOOK([^_[:alnum:]]|$)/ {
 737     fail("PROCESS_LINENUMBER_HOOK")
 738 }
 739
 740 BEGIN { doc["PC_SOLIB"] = "\
 741 Replace PC_SOLIB with nothing, not needed?"
 742     category["PC_SOLIB"] = ari_regression
 743 }
 744 /(^|[^_[:alnum:]])PC_SOLIB([^_[:alnum:]]|$)/ {
 745     fail("PC_SOLIB")
 746 }
 747
 748 BEGIN { doc["IN_SOLIB_DYNSYM_RESOLVE_CODE"] = "\
 749 Replace IN_SOLIB_DYNSYM_RESOLVE_CODE with nothing, not needed?"
 750     category["IN_SOLIB_DYNSYM_RESOLVE_CODE"] = ari_regression
 751 }
 752 /(^|[^_[:alnum:]])IN_SOLIB_DYNSYM_RESOLVE_CODE([^_[:alnum:]]|$)/ {
 753     fail("IN_SOLIB_DYNSYM_RESOLVE_CODE")
 754 }
 755
 756 BEGIN { doc["GCC_COMPILED_FLAG_SYMBOL"] = "\
 757 Replace GCC_COMPILED_FLAG_SYMBOL with nothing, not needed?"
 758     category["GCC_COMPILED_FLAG_SYMBOL"] = ari_deprecate
 759 }
 760 /(^|[^_[:alnum:]])GCC_COMPILED_FLAG_SYMBOL([^_[:alnum:]]|$)/ {
 761     fail("GCC_COMPILED_FLAG_SYMBOL")
 762 }
 763
 764 BEGIN { doc["GCC2_COMPILED_FLAG_SYMBOL"] = "\
 765 Replace GCC2_COMPILED_FLAG_SYMBOL with nothing, not needed?"
 766     category["GCC2_COMPILED_FLAG_SYMBOL"] = ari_deprecate
 767 }
 768 /(^|[^_[:alnum:]])GCC2_COMPILED_FLAG_SYMBOL([^_[:alnum:]]|$)/ {
 769     fail("GCC2_COMPILED_FLAG_SYMBOL")
 770 }
 771
 772 BEGIN { doc["FUNCTION_EPILOGUE_SIZE"] = "\
 773 Replace FUNCTION_EPILOGUE_SIZE with nothing, not needed?"
 774     category["FUNCTION_EPILOGUE_SIZE"] = ari_regression
 775 }
 776 /(^|[^_[:alnum:]])FUNCTION_EPILOGUE_SIZE([^_[:alnum:]]|$)/ {
 777     fail("FUNCTION_EPILOGUE_SIZE")
 778 }
 779
 780 BEGIN { doc["HAVE_VFORK"] = "\
 781 Do not use HAVE_VFORK, instead include \"gdb_vfork.h\" and call vfork() \
 782 unconditionally"
 783     category["HAVE_VFORK"] = ari_regression
 784 }
 785 /(^|[^_[:alnum:]])HAVE_VFORK([^_[:alnum:]]|$)/ {
 786     fail("HAVE_VFORK")
 787 }
 788
 789 BEGIN { doc["bcmp"] = "\
 790 Do not use bcmp(), C++11 implies memcmp()"
 791     category["bcmp"] = ari_regression
 792 }
 793 /(^|[^_[:alnum:]])bcmp[[:space:]]*\(/ {
 794     fail("bcmp")
 795 }
 796
 797 BEGIN { doc["setlinebuf"] = "\
 798 Do not use setlinebuf(), C++11 implies setvbuf()"
 799     category["setlinebuf"] = ari_regression
 800 }
 801 /(^|[^_[:alnum:]])setlinebuf[[:space:]]*\(/ {
 802     fail("setlinebuf")
 803 }
 804
 805 BEGIN { doc["bcopy"] = "\
 806 Do not use bcopy(), C++11 implies memcpy() and memmove()"
 807     category["bcopy"] = ari_regression
 808 }
 809 /(^|[^_[:alnum:]])bcopy[[:space:]]*\(/ {
 810     fail("bcopy")
 811 }
 812
 813 BEGIN { doc["get_frame_base"] = "\
 814 Replace get_frame_base with get_frame_id, get_frame_base_address, \
 815 get_frame_locals_address, or get_frame_args_address."
 816     category["get_frame_base"] = ari_obsolete
 817 }
 818 /(^|[^_[:alnum:]])get_frame_base([^_[:alnum:]]|$)/ {
 819     fail("get_frame_base")
 820 }
 821
 822 BEGIN { doc["floatformat_to_double"] = "\
 823 Do not use floatformat_to_double() from libierty, \
 824 instead use floatformat_to_doublest()"
 825     fix("floatformat_to_double", "gdb/doublest.c", 1)
 826     category["floatformat_to_double"] = ari_regression
 827 }
 828 /(^|[^_[:alnum:]])floatformat_to_double[[:space:]]*\(/ {
 829     fail("floatformat_to_double")
 830 }
 831
 832 BEGIN { doc["floatformat_from_double"] = "\
 833 Do not use floatformat_from_double() from libierty, \
 834 instead use floatformat_from_doublest()"
 835     category["floatformat_from_double"] = ari_regression
 836 }
 837 /(^|[^_[:alnum:]])floatformat_from_double[[:space:]]*\(/ {
 838     fail("floatformat_from_double")
 839 }
 840
 841 BEGIN { doc["BIG_ENDIAN"] = "\
 842 Do not use BIG_ENDIAN, instead use BFD_ENDIAN_BIG"
 843     category["BIG_ENDIAN"] = ari_regression
 844 }
 845 /(^|[^_[:alnum:]])BIG_ENDIAN([^_[:alnum:]]|$)/ {
 846     fail("BIG_ENDIAN")
 847 }
 848
 849 BEGIN { doc["LITTLE_ENDIAN"] = "\
 850 Do not use LITTLE_ENDIAN, instead use BFD_ENDIAN_LITTLE";
 851     category["LITTLE_ENDIAN"] = ari_regression
 852 }
 853 /(^|[^_[:alnum:]])LITTLE_ENDIAN([^_[:alnum:]]|$)/ {
 854     fail("LITTLE_ENDIAN")
 855 }
 856
 857 BEGIN { doc["BIG_ENDIAN"] = "\
 858 Do not use BIG_ENDIAN, instead use BFD_ENDIAN_BIG"
 859     category["BIG_ENDIAN"] = ari_regression
 860 }
 861 /(^|[^_[:alnum:]])BIG_ENDIAN([^_[:alnum:]]|$)/ {
 862     fail("BIG_ENDIAN")
 863 }
 864
 865 BEGIN { doc["sec_ptr"] = "\
 866 Instead of sec_ptr, use struct bfd_section";
 867     category["sec_ptr"] = ari_regression
 868 }
 869 /(^|[^_[:alnum:]])sec_ptr([^_[:alnum:]]|$)/ {
 870     fail("sec_ptr")
 871 }
 872
 873 BEGIN { doc["frame_unwind_unsigned_register"] = "\
 874 Replace frame_unwind_unsigned_register with frame_unwind_register_unsigned"
 875     category["frame_unwind_unsigned_register"] = ari_regression
 876 }
 877 /(^|[^_[:alnum:]])frame_unwind_unsigned_register([^_[:alnum:]]|$)/ {
 878     fail("frame_unwind_unsigned_register")
 879 }
 880
 881 BEGIN { doc["frame_register_read"] = "\
 882 Replace frame_register_read() with get_frame_register(), or \
 883 possibly introduce a new method safe_get_frame_register()"
 884     category["frame_register_read"] = ari_obsolete
 885 }
 886 /(^|[^_[:alnum:]])frame_register_read([^_[:alnum:]]|$)/ {
 887     fail("frame_register_read")
 888 }
 889
 890 BEGIN { doc["read_register"] = "\
 891 Replace read_register() with regcache_read() et.al."
 892     category["read_register"] = ari_regression
 893 }
 894 /(^|[^_[:alnum:]])read_register([^_[:alnum:]]|$)/ {
 895     fail("read_register")
 896 }
 897
 898 BEGIN { doc["write_register"] = "\
 899 Replace write_register() with regcache_read() et.al."
 900     category["write_register"] = ari_regression
 901 }
 902 /(^|[^_[:alnum:]])write_register([^_[:alnum:]]|$)/ {
 903     fail("write_register")
 904 }
 905
 906 function report(name) {
 907     # Drop any trailing _P.
 908     name = gensub(/(_P|_p)$/, "", 1, name)
 909     # Convert to lower case
 910     name = tolower(name)
 911     # Split into category and bug
 912     cat = gensub(/^([[:alpha:]]+)_([_[:alnum:]]*)$/, "\\1", 1, name)
 913     bug = gensub(/^([[:alpha:]]+)_([_[:alnum:]]*)$/, "\\2", 1, name)
 914     # Report it
 915     name = cat " " bug
 916     doc[name] = "Do not use " cat " " bug ", see declaration for details"
 917     category[name] = cat
 918     fail(name)
 919 }
 920
 921 /(^|[^_[:alnum:]])(DEPRECATED|deprecated|set_gdbarch_deprecated|LEGACY|legacy|set_gdbarch_legacy)_/ {
 922     line = $0
 923     # print "0 =", $0
 924     while (1) {
 925         name = gensub(/^(|.*[^_[:alnum:]])((DEPRECATED|deprecated|LEGACY|legacy)_[_[:alnum:]]*)(.*)$/, "\\2", 1, line)
 926         line = gensub(/^(|.*[^_[:alnum:]])((DEPRECATED|deprecated|LEGACY|legacy)_[_[:alnum:]]*)(.*)$/, "\\1 \\4", 1, line)
 927         # print "name =", name, "line =", line
 928         if (name == line) break;
 929         report(name)
 930     }
 931 }
 932
 933 # Count the number of times each architecture method is set
 934 /(^|[^_[:alnum:]])set_gdbarch_[_[:alnum:]]*([^_[:alnum:]]|$)/ {
 935     name = gensub(/^.*set_gdbarch_([_[:alnum:]]*).*$/, "\\1", 1, $0)
 936     doc["set " name] = "\
 937 Call to set_gdbarch_" name
 938     category["set " name] = ari_gdbarch
 939     fail("set " name)
 940 }
 941
 942 # Count the number of times each tm/xm/nm macro is defined or undefined
 943 /^#[[:space:]]*(undef|define)[[:space:]]+[[:alnum:]_]+.*$/ \
 944 && !/^#[[:space:]]*(undef|define)[[:space:]]+[[:alnum:]_]+_H($|[[:space:]])/ \
 945 && FILENAME ~ /(^|\/)config\/(|[^\/]*\/)(tm-|xm-|nm-).*\.h$/ {
 946     basename = gensub(/(^|.*\/)([^\/]*)$/, "\\2", 1, FILENAME)
 947     type = gensub(/^(tm|xm|nm)-.*\.h$/, "\\1", 1, basename)
 948     name = gensub(/^#[[:space:]]*(undef|define)[[:space:]]+([[:alnum:]_]+).*$/, "\\2", 1, $0)
 949     if (type == basename) {
 950         type = "macro"
 951     }
 952     doc[type " " name] = "\
 953 Do not define macros such as " name " in a tm, nm or xm file, \
 954 in fact do not provide a tm, nm or xm file"
 955     category[type " " name] = ari_macro
 956     fail(type " " name)
 957 }
 958
 959 BEGIN { doc["deprecated_registers"] = "\
 960 Replace deprecated_registers with nothing, they have reached \
 961 end-of-life"
 962     category["deprecated_registers"] = ari_eol
 963 }
 964 /(^|[^_[:alnum:]])deprecated_registers([^_[:alnum:]]|$)/ {
 965     fail("deprecated_registers")
 966 }
 967
 968 BEGIN { doc["read_pc"] = "\
 969 Replace READ_PC() with frame_pc_unwind; \
 970 at present the inferior function call code still uses this"
 971     category["read_pc"] = ari_deprecate
 972 }
 973 /(^|[^_[:alnum:]])read_pc[[:space:]]*\(/ || \
 974 /(^|[^_[:alnum:]])set_gdbarch_read_pc[[:space:]]*\(/ || \
 975 /(^|[^_[:alnum:]])TARGET_READ_PC[[:space:]]*\(/ {
 976     fail("read_pc")
 977 }
 978
 979 BEGIN { doc["write_pc"] = "\
 980 Replace write_pc() with get_frame_base_address or get_frame_id; \
 981 at present the inferior function call code still uses this when doing \
 982 a DECR_PC_AFTER_BREAK"
 983     category["write_pc"] = ari_deprecate
 984 }
 985 /(^|[^_[:alnum:]])write_pc[[:space:]]*\(/ || \
 986 /(^|[^_[:alnum:]])TARGET_WRITE_PC[[:space:]]*\(/ {
 987     fail("write_pc")
 988 }
 989
 990 BEGIN { doc["generic_target_write_pc"] = "\
 991 Replace generic_target_write_pc with a per-architecture implementation, \
 992 this relies on PC_REGNUM which is being eliminated"
 993     category["generic_target_write_pc"] = ari_regression
 994 }
 995 /(^|[^_[:alnum:]])generic_target_write_pc([^_[:alnum:]]|$)/ {
 996     fail("generic_target_write_pc")
 997 }
 998
 999 BEGIN { doc["read_sp"] = "\
1000 Replace read_sp() with frame_sp_unwind"
1001     category["read_sp"] = ari_regression
1002 }
1003 /(^|[^_[:alnum:]])read_sp[[:space:]]*\(/ || \
1004 /(^|[^_[:alnum:]])set_gdbarch_read_sp[[:space:]]*\(/ || \
1005 /(^|[^_[:alnum:]])TARGET_READ_SP[[:space:]]*\(/ {
1006     fail("read_sp")
1007 }
1008
1009 BEGIN { doc["register_cached"] = "\
1010 Replace register_cached() with nothing, does not have a regcache parameter"
1011     category["register_cached"] = ari_regression
1012 }
1013 /(^|[^_[:alnum:]])register_cached[[:space:]]*\(/ {
1014     fail("register_cached")
1015 }
1016
1017 BEGIN { doc["set_register_cached"] = "\
1018 Replace set_register_cached() with nothing, does not have a regcache parameter"
1019     category["set_register_cached"] = ari_regression
1020 }
1021 /(^|[^_[:alnum:]])set_register_cached[[:space:]]*\(/ {
1022     fail("set_register_cached")
1023 }
1024
1025 # Print functions: Use versions that either check for buffer overflow
1026 # or safely allocate a fresh buffer.
1027
1028 BEGIN { doc["sprintf"] = "\
1029 Do not use sprintf, instead use xsnprintf or xstrprintf"
1030     category["sprintf"] = ari_code
1031 }
1032 /(^|[^_[:alnum:]])sprintf[[:space:]]*\(/ {
1033     fail("sprintf")
1034 }
1035
1036 BEGIN { doc["vsprintf"] = "\
1037 Do not use vsprintf(), instead use xstrvprintf"
1038     category["vsprintf"] = ari_regression
1039 }
1040 /(^|[^_[:alnum:]])vsprintf[[:space:]]*\(/ {
1041     fail("vsprintf")
1042 }
1043
1044 BEGIN { doc["asprintf"] = "\
1045 Do not use asprintf(), instead use xstrprintf()"
1046     category["asprintf"] = ari_regression
1047 }
1048 /(^|[^_[:alnum:]])asprintf[[:space:]]*\(/ {
1049     fail("asprintf")
1050 }
1051
1052 BEGIN { doc["vasprintf"] = "\
1053 Do not use vasprintf(), instead use xstrvprintf"
1054     fix("vasprintf", "gdbsupport/common-utils.c", 1)
1055     category["vasprintf"] = ari_regression
1056 }
1057 /(^|[^_[:alnum:]])vasprintf[[:space:]]*\(/ {
1058     fail("vasprintf")
1059 }
1060
1061 BEGIN { doc["printf_vma"] = "\
1062 Do not use printf_vma, instead use paddress or phex_nz"
1063     category["printf_vma"] = ari_code
1064 }
1065 /(^|[^_[:alnum:]])printf_vma[[:space:]]*\(/ {
1066     fail("printf_vma")
1067 }
1068
1069 BEGIN { doc["sprintf_vma"] = "\
1070 Do not use sprintf_vma, instead use paddress or phex_nz"
1071     category["sprintf_vma"] = ari_code
1072 }
1073 /(^|[^_[:alnum:]])sprintf_vma[[:space:]]*\(/ {
1074     fail("sprintf_vma")
1075 }
1076
1077 # More generic memory operations
1078
1079 BEGIN { doc["bzero"] = "\
1080 Do not use bzero(), instead use memset()"
1081     category["bzero"] = ari_regression
1082 }
1083 /(^|[^_[:alnum:]])bzero[[:space:]]*\(/ {
1084     fail("bzero")
1085 }
1086
1087 BEGIN { doc["strdup"] = "\
1088 Do not use strdup(), instead use xstrdup()";
1089     category["strdup"] = ari_regression
1090 }
1091 /(^|[^_[:alnum:]])strdup[[:space:]]*\(/ {
1092     fail("strdup")
1093 }
1094
1095 BEGIN { doc["strsave"] = "\
1096 Do not use strsave(), instead use xstrdup() et.al."
1097     category["strsave"] = ari_regression
1098 }
1099 /(^|[^_[:alnum:]])strsave[[:space:]]*\(/ {
1100     fail("strsave")
1101 }
1102
1103 # String compare functions
1104
1105 BEGIN { doc["strnicmp"] = "\
1106 Do not use strnicmp(), instead use strncasecmp()"
1107     category["strnicmp"] = ari_regression
1108 }
1109 /(^|[^_[:alnum:]])strnicmp[[:space:]]*\(/ {
1110     fail("strnicmp")
1111 }
1112
1113 # Typedefs that are either redundant or can be reduced to `struct
1114 # type *''.
1115 # Must be placed before if assignment otherwise ARI exceptions
1116 # are not handled correctly.
1117
1118 BEGIN { doc["d_namelen"] = "\
1119 Do not use dirent.d_namelen, instead use NAMELEN"
1120     category["d_namelen"] = ari_regression
1121 }
1122 /(^|[^_[:alnum:]])d_namelen([^_[:alnum:]]|$)/ {
1123     fail("d_namelen")
1124 }
1125
1126 BEGIN { doc["strlen d_name"] = "\
1127 Do not use strlen dirent.d_name, instead use NAMELEN"
1128     category["strlen d_name"] = ari_regression
1129 }
1130 /(^|[^_[:alnum:]])strlen[[:space:]]*\(.*[^_[:alnum:]]d_name([^_[:alnum:]]|$)/ {
1131     fail("strlen d_name")
1132 }
1133
1134 BEGIN { doc["generic_use_struct_convention"] = "\
1135 Replace generic_use_struct_convention with nothing, \
1136 EXTRACT_STRUCT_VALUE_ADDRESS is a predicate"
1137     category["generic_use_struct_convention"] = ari_regression
1138 }
1139 /(^|[^_[:alnum:]])generic_use_struct_convention([^_[:alnum:]]|$)/ {
1140     fail("generic_use_struct_convention")
1141 }
1142
1143 BEGIN { doc["if assignment"] = "\
1144 An IF statement'\''s expression contains an assignment (the GNU coding \
1145 standard discourages this)"
1146     category["if assignment"] = ari_code
1147 }
1148 BEGIN { doc["if clause more than 50 lines"] = "\
1149 An IF statement'\''s expression expands over 50 lines"
1150     category["if clause more than 50 lines"] = ari_code
1151 }
1152 #
1153 # Accumulate continuation lines
1154 FNR == 1 {
1155     in_if = 0
1156 }
1157
1158 /(^|[^_[:alnum:]])if / {
1159     in_if = 1;
1160     if_brace_level = 0;
1161     if_cont_p = 0;
1162     if_count = 0;
1163     if_brace_end_pos = 0;
1164     if_full_line = "";
1165 }
1166 (in_if)  {
1167     # We want everything up to closing brace of same level
1168     if_count++;
1169     if (if_count > 50) {
1170         print "multiline if: " if_full_line $0
1171         fail("if clause more than 50 lines")
1172         if_brace_level = 0;
1173         if_full_line = "";
1174     } else {
1175         if (if_count == 1) {
1176             i = index($0,"if ");
1177         } else {
1178             i = 1;
1179         }
1180         for (i=i; i <= length($0); i++) {
1181             char = substr($0,i,1);
1182             if (char == "(") { if_brace_level++; }
1183             if (char == ")") {
1184                 if_brace_level--;
1185                 if (!if_brace_level) {
1186                     if_brace_end_pos = i;
1187                     after_if = substr($0,i+1,length($0));
1188                     # Do not parse what is following
1189                     break;
1190                 }
1191             }
1192         }
1193         if (if_brace_level == 0) {
1194             $0 = substr($0,1,i);
1195             in_if = 0;
1196         } else {
1197             if_full_line = if_full_line $0;
1198             if_cont_p = 1;
1199             next;
1200         }
1201     }
1202 }
1203 # if we arrive here, we need to concatenate, but we are at brace level 0
1204
1205 (if_brace_end_pos) {
1206     $0 = if_full_line substr($0,1,if_brace_end_pos);
1207     if (if_count > 1) {
1208         # print "IF: multi line " if_count " found at " FILENAME ":" FNR " \"" $0 "\""
1209     }
1210     if_cont_p = 0;
1211     if_full_line = "";
1212 }
1213 /(^|[^_[:alnum:]])if .* = / {
1214     # print "fail in if " $0
1215     fail("if assignment")
1216 }
1217 (if_brace_end_pos) {
1218     $0 = $0 after_if;
1219     if_brace_end_pos = 0;
1220     in_if = 0;
1221 }
1222
1223 # Printout of all found bug
1224
1225 BEGIN {
1226     if (print_doc) {
1227         for (bug in doc) {
1228             fail(bug)
1229         }
1230         exit
1231     }
1232 }' "$@"
1233