libctf: create: non-root-visible types should not appear in name tables
[deliverable/binutils-gdb.git] / libctf / ChangeLog
1 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
2
3 * ctf-open.c (init_types): Only intern root-visible types.
4 * ctf-create.c (ctf_dtd_insert): Likewise.
5 (ctf_dtd_delete): Only remove root-visible types.
6 (ctf_rollback): Likewise.
7 (ctf_add_generic): Adjust.
8 (ctf_add_struct_sized): Adjust comment.
9 (ctf_add_union_sized): Likewise.
10 (ctf_add_enum): Likewise.
11 * ctf-impl.h (ctf_dtd_insert): Adjust prototype.
12
13 2020-03-11 John Baldwin <jhb@FreeBSD.org>
14
15 * swap.h (bswap_identity_64): Make static.
16
17 2020-01-18 Nick Clifton <nickc@redhat.com>
18
19 Binutils 2.34 branch created.
20
21 2020-01-05 Joel Brobecker <brobecker@adacore.com>
22
23 PR binutils/25155:
24 * configure.ac: Add AC_CHECK_DECLS([asprintf]).
25 * configure, config.h.in: Regenerate.
26
27 2020-01-01 Alan Modra <amodra@gmail.com>
28
29 Update year range in copyright notice of all files.
30
31 2019-10-16 Simon Marchi <simon.marchi@polymtl.ca>
32
33 * swap.h (bswap_16, bswap_32, bswap_64): Make static.
34
35 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
36
37 * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
38 * ctf-types.c (ctf_type_lname): Likewise.
39
40 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
41
42 * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
43 ctf_import after the first for a given file.
44
45 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
46
47 * ctf-impl.h (ctf_str_append_noerr): Declare.
48 * ctf-util.c (ctf_str_append_noerr): Define in terms of
49 ctf_str_append.
50 * ctf-dump.c (str_append): New, call it.
51 (ctf_dump_format_type): Use str_append, not ctf_str_append.
52 (ctf_dump_label): Likewise.
53 (ctf_dump_objts): Likewise.
54 (ctf_dump_funcs): Likewise.
55 (ctf_dump_var): Likewise.
56 (ctf_dump_member): Likewise.
57 (ctf_dump_type): Likewise.
58 (ctf_dump): Likewise.
59
60 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
61
62 * ctf-impl.h (ctf_alloc): Remove.
63 (ctf_free): Likewise.
64 (ctf_strdup): Likewise.
65 * ctf-subr.c (ctf_alloc): Remove.
66 (ctf_free): Likewise.
67 * ctf-util.c (ctf_strdup): Remove.
68
69 * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
70 ctf_free; strdup, not ctf_strdup.
71 (ctf_dtd_delete): Likewise.
72 (ctf_dvd_delete): Likewise.
73 (ctf_add_generic): Likewise.
74 (ctf_add_function): Likewise.
75 (ctf_add_enumerator): Likewise.
76 (ctf_add_member_offset): Likewise.
77 (ctf_add_variable): Likewise.
78 (membadd): Likewise.
79 (ctf_compress_write): Likewise.
80 (ctf_write_mem): Likewise.
81 * ctf-decl.c (ctf_decl_push): Likewise.
82 (ctf_decl_fini): Likewise.
83 (ctf_decl_sprintf): Likewise. Check for OOM.
84 * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
85 ctf_free; strdup, not ctf_strdup.
86 (ctf_dump_free): Likewise.
87 (ctf_dump): Likewise.
88 * ctf-open.c (upgrade_types_v1): Likewise.
89 (init_types): Likewise.
90 (ctf_file_close): Likewise.
91 (ctf_bufopen_internal): Likewise. Check for OOM.
92 (ctf_parent_name_set): Likewise: report the OOM to the caller.
93 (ctf_cuname_set): Likewise.
94 (ctf_import): Likewise.
95 * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
96 free, not ctf_free; strdup, not ctf_strdup.
97 (ctf_str_free_atom): Likewise.
98 (ctf_str_create_atoms): Likewise.
99 (ctf_str_add_ref_internal): Likewise.
100 (ctf_str_remove_ref): Likewise.
101 (ctf_str_write_strtab): Likewise.
102
103 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
104
105 * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
106 work right for non-int/fps.
107
108 2019-08-08 Nick Alcock <nick.alcock@oracle.com>
109
110 * ctf-types.c (ctf_type_name): Don't strlen a potentially-
111 null pointer.
112
113 2019-08-07 Nick Alcock <nick.alcock@oracle.com>
114
115 * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
116 * ctf-open.c (ctf_file_close): Free it.
117 * ctf-create.c (ctf_serialize): Adjust.
118 (membcmp): When reporting a conflict due to an error, report the
119 error.
120 (ctf_add_type): Turn into a ctf_add_processing wrapper. Rename to...
121 (ctf_add_type_internal): ... this. Hand back types we are already
122 in the middle of adding immediately. Hand back structs/unions with
123 the same number of members immediately. Do not walk the dynamic
124 list. Call ctf_add_type_internal, not ctf_add_type. Handle
125 forwards promoted to other types and the inverse case identically.
126 Add structs to the mapping as soon as we intern them, before they
127 gain any members.
128
129 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
130
131 * ctf-impl.h (ctf_names_t): New.
132 (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
133 (ctf_file_t) <ctf_structs>: Likewise.
134 <ctf_unions>: Likewise.
135 <ctf_enums>: Likewise.
136 <ctf_names>: Likewise.
137 <ctf_lookups>: Improve comment.
138 <ctf_ptrtab_len>: New.
139 <ctf_prov_strtab>: New.
140 <ctf_str_prov_offset>: New.
141 <ctf_dtbyname>: Remove, redundant to the names hashes.
142 <ctf_dtnextid>: Remove, redundant to ctf_typemax.
143 (ctf_dtdef_t) <dtd_name>: Remove.
144 <dtd_data>: Note that the ctt_name is now populated.
145 (ctf_str_atom_t) <csa_offset>: This is now the strtab
146 offset for internal strings too.
147 <csa_external_offset>: New, the external strtab offset.
148 (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
149 (ctf_name_table): New declaration.
150 (ctf_lookup_by_rawname): Likewise.
151 (ctf_lookup_by_rawhash): Likewise.
152 (ctf_set_ctl_hashes): Likewise.
153 (ctf_serialize): Likewise.
154 (ctf_dtd_insert): Adjust.
155 (ctf_simple_open_internal): Likewise.
156 (ctf_bufopen_internal): Likewise.
157 (ctf_list_empty_p): Likewise.
158 (ctf_str_remove_ref): Likewise.
159 (ctf_str_add): Returns uint32_t now.
160 (ctf_str_add_ref): Likewise.
161 (ctf_str_add_external): Now returns a boolean (int).
162 * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
163 for strings in the appropriate range.
164 (ctf_str_create_atoms): Create the ctf_prov_strtab. Detect OOM
165 when adding the null string to the new strtab.
166 (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
167 (ctf_str_add_ref_internal): Add make_provisional argument. If
168 make_provisional, populate the offset and fill in the
169 ctf_prov_strtab accordingly.
170 (ctf_str_add): Return the offset, not the string.
171 (ctf_str_add_ref): Likewise.
172 (ctf_str_add_external): Return a success integer.
173 (ctf_str_remove_ref): New, remove a single ref.
174 (ctf_str_count_strtab): Do not count the initial null string's
175 length or the existence or length of any unreferenced internal
176 atoms.
177 (ctf_str_populate_sorttab): Skip atoms with no refs.
178 (ctf_str_write_strtab): Populate the nullstr earlier. Add one
179 to the cts_len for the null string, since it is no longer done
180 in ctf_str_count_strtab. Adjust for csa_external_offset rename.
181 Populate the csa_offset for both internal and external cases.
182 Flush the ctf_prov_strtab afterwards, and reset the
183 ctf_str_prov_offset.
184 * ctf-create.c (ctf_grow_ptrtab): New.
185 (ctf_create): Call it. Initialize new fields rather than old
186 ones. Tell ctf_bufopen_internal that this is a writable dictionary.
187 Set the ctl hashes and data model.
188 (ctf_update): Rename to...
189 (ctf_serialize): ... this. Leave a compatibility function behind.
190 Tell ctf_simple_open_internal that this is a writable dictionary.
191 Pass the new fields along from the old dictionary. Drop
192 ctf_dtnextid and ctf_dtbyname. Use ctf_strraw, not dtd_name.
193 Do not zero out the DTD's ctt_name.
194 (ctf_prefixed_name): Rename to...
195 (ctf_name_table): ... this. No longer return a prefixed name: return
196 the applicable name table instead.
197 (ctf_dtd_insert): Use it, and use the right name table. Pass in the
198 kind we're adding. Migrate away from dtd_name.
199 (ctf_dtd_delete): Adjust similarly. Remove the ref to the
200 deleted ctt_name.
201 (ctf_dtd_lookup_type_by_name): Remove.
202 (ctf_dynamic_type): Always return NULL on read-only dictionaries.
203 No longer check ctf_dtnextid: check ctf_typemax instead.
204 (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
205 (ctf_rollback): Likewise. No longer fail with ECTF_OVERROLLBACK. Use
206 ctf_name_table and the right name table, and migrate away from
207 dtd_name as in ctf_dtd_delete.
208 (ctf_add_generic): Pass in the kind explicitly and pass it to
209 ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid. Migrate away
210 from dtd_name to using ctf_str_add_ref to populate the ctt_name.
211 Grow the ptrtab if needed.
212 (ctf_add_encoded): Pass in the kind.
213 (ctf_add_slice): Likewise.
214 (ctf_add_array): Likewise.
215 (ctf_add_function): Likewise.
216 (ctf_add_typedef): Likewise.
217 (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
218 ctt_name rather than dtd_name.
219 (ctf_add_struct_sized): Pass in the kind. Use
220 ctf_lookup_by_rawname, not ctf_hash_lookup_type /
221 ctf_dtd_lookup_type_by_name.
222 (ctf_add_union_sized): Likewise.
223 (ctf_add_enum): Likewise.
224 (ctf_add_enum_encoded): Likewise.
225 (ctf_add_forward): Likewise.
226 (ctf_add_type): Likewise.
227 (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
228 being initialized until after the call.
229 (ctf_write_mem): Likewise.
230 (ctf_write): Likewise.
231 * ctf-archive.c (arc_write_one_ctf): Likewise.
232 * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
233 ctf_hash_lookup_type.
234 (ctf_lookup_by_id): No longer check the readonly types if the
235 dictionary is writable.
236 * ctf-open.c (init_types): Assert that this dictionary is not
237 writable. Adjust to use the new name hashes, ctf_name_table,
238 and ctf_ptrtab_len. GNU style fix for the final ptrtab scan.
239 (ctf_bufopen_internal): New 'writable' parameter. Flip on LCTF_RDWR
240 if set. Drop out early when dictionary is writable. Split the
241 ctf_lookups initialization into...
242 (ctf_set_cth_hashes): ... this new function.
243 (ctf_simple_open_internal): Adjust. New 'writable' parameter.
244 (ctf_simple_open): Adjust accordingly.
245 (ctf_bufopen): Likewise.
246 (ctf_file_close): Destroy the appropriate name hashes. No longer
247 destroy ctf_dtbyname, which is gone.
248 (ctf_getdatasect): Remove spurious "extern".
249 * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
250 specified name table, given a kind.
251 (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
252 (ctf_member_iter): Add support for iterating over the
253 dynamic type list.
254 (ctf_enum_iter): Likewise.
255 (ctf_variable_iter): Likewise.
256 (ctf_type_rvisit): Likewise.
257 (ctf_member_info): Add support for types in the dynamic type list.
258 (ctf_enum_name): Likewise.
259 (ctf_enum_value): Likewise.
260 (ctf_func_type_info): Likewise.
261 (ctf_func_type_args): Likewise.
262 * ctf-link.c (ctf_accumulate_archive_names): No longer call
263 ctf_update.
264 (ctf_link_write): Likewise.
265 (ctf_link_intern_extern_string): Adjust for new
266 ctf_str_add_external return value.
267 (ctf_link_add_strtab): Likewise.
268 * ctf-util.c (ctf_list_empty_p): New.
269
270 2019-08-05 Nick Alcock <nick.alcock@oracle.com>
271
272 * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
273 type zero.
274 * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
275 members and types.
276 (ctf_add_variable): Likewise for variables pointing to them.
277 * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
278 type link failure, but do warn for others.
279 * ctf-dump.c (ctf_dump_format_type): Likewise. Do not assume all
280 errors to be ENOMEM.
281 (ctf_dump_member): Likewise.
282 (ctf_dump_type): Likewise.
283 (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
284 (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
285 (ctf_dump_header): Likewise.
286 (ctf_dump_label): likewise.
287 (ctf_dump_objts): likewise.
288 (ctf_dump_funcs): likewise.
289 (ctf_dump_var): likewise.
290 (ctf_dump_str): Likewise.
291
292 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
293
294 * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
295 (LT_INIT): Likewise.
296 (AM_INSTALL_LIBBFD): Likewise.
297 (dlopen): Note why this is necessary in a comment.
298 (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
299 opcodes/.
300 (SHARED_LDFLAGS): Likewise.
301 (BFD_LIBADD): Likewise, for libbfd.
302 (BFD_DEPENDENCIES): Likewise.
303 (VERSION_FLAGS): Initialize, using a version script if ld supports
304 one, or libtool -export-symbols-regex otherwise.
305 (AC_CONFIG_MACRO_DIR): Add ../BFD.
306 * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
307 (INCDIR): New.
308 (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
309 (noinst_LIBRARIES): Replace with...
310 [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
311 [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
312 libctf-nobfd.la as well.
313 [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
314 [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
315 (libctf_a_SOURCES): Rename to...
316 (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
317 ctf-open-bfd.c.
318 (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
319 with ctf-open-bfd.c added.
320 (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
321 (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
322 (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
323 * Makefile.am [INSTALL_LIBCTF]: Use it.
324 * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
325 libtool macros.
326 * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
327 the unstable components).
328 * Makefile.in: Regenerated.
329 * config.h.in: Likewise.
330 * configure: Likewise.
331
332 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
333
334 * configure.ac (INSTALL_LIBCTF): New, controlled by
335 --enable-install-libctf.
336 [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
337 * Makefile.in: Regenerated.
338 * configure: Regenerated.
339
340 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
341
342 * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
343 * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
344
345 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
346
347 * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
348
349 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
350
351 * ctf-impl.h (includes): Include <sys/param.h> here.
352
353 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
354
355 * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
356 (flip_objts): Likewise.
357 (flip_vars): Likewise.
358 (flip_types): Likewise.
359
360 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
361
362 * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
363 freeing functions: if set, free the key and value if the slot
364 already exists. Always reassign the key.
365 (ctf_dynhash_insert): Adjust call appropriately.
366 (ctf_hash_insert_type): Likewise.
367
368 2019-08-03 Nick Alcock <nick.alcock@oracle.com>
369
370 * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
371 type kind. Allow forwards to unify with pre-existing structs/
372 unions/enums.
373
374 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
375
376 * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
377 <ctf_link_memb_name_changer>: Likewise.
378 <ctf_link_memb_name_changer_arg>: Likewise.
379 * ctf-create.c (ctf_update): Update accordingly.
380 * ctf-open.c (ctf_file_close): Likewise.
381 * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
382 (ctf_link_add_cu_mapping): New.
383 (ctf_link_set_memb_name_changer): Likewise.
384 (ctf_change_parent_name): New.
385 (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
386 allocated by the caller's ctf_link_memb_name_changer.
387 <ndynames>: Likewise.
388 (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
389 (ctf_link_write): Likewise (for _CTF_SECTION only): also call
390 ctf_change_parent_name. Free any resulting names.
391
392 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
393
394 * ctf-link.c (ctf_create_per_cu): New, refactored out of...
395 (ctf_link_one_type): ... here, with parent-name setting added.
396 (check_variable): New.
397 (ctf_link_one_variable): Likewise.
398 (ctf_link_one_input_archive_member): Call it.
399 * ctf-error.c (_ctf_errlist): Updated with new errors.
400
401 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
402
403 * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
404 (struct ctf_link_type_mapping_key): New.
405 (ctf_hash_type_mapping_key): Likewise.
406 (ctf_hash_eq_type_mapping_key): Likewise.
407 (ctf_add_type_mapping): Likewise.
408 (ctf_type_mapping): Likewise.
409 (ctf_dynhash_empty): Likewise.
410 * ctf-open.c (ctf_file_close): Update accordingly.
411 * ctf-create.c (ctf_update): Likewise.
412 (ctf_add_type): Populate the mapping.
413 * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
414 (ctf_hash_eq_type_mapping_key): Check the key for equality.
415 (ctf_dynhash_insert): Fix comment typo.
416 (ctf_dynhash_empty): New.
417 * ctf-link.c (ctf_add_type_mapping): New.
418 (ctf_type_mapping): Likewise.
419 (empty_link_type_mapping): New.
420 (ctf_link_one_input_archive): Call it.
421
422 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
423
424 * ctf-link.c: New file, linking of the string and type sections.
425 * Makefile.am (libctf_a_SOURCES): Add it.
426 * Makefile.in: Regenerate.
427
428 * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
429 ctf_link_outputs.
430 * ctf-create.c (ctf_update): Update accordingly.
431 * ctf-open.c (ctf_file_close): Likewise.
432 * ctf-error.c (_ctf_errlist): Updated with new errors.
433
434 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
435
436 * ctf-dump.c (ctf_dump_funcs): Check the right error value.
437
438 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
439
440 * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
441 ctf_type_iter.
442 (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
443 (ctf_dump_format_type): Add non-root-type { } notation.
444 Add root flag to prototype.
445 (ctf_dump_label): Adjust accordingly.
446 (ctf_dump_objts): Likewise.
447 (ctf_dump_var): Likewise.
448
449 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
450
451 * ctf-create.c (ctf_compress_write): Fix double-free.
452
453 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
454
455 * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
456 of...
457 (ctf_arc_write_fd): ... this new function.
458 * ctf-create.c (ctf_write_mem): New.
459
460 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
461
462 * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
463 (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
464 (ctf_str_add_ref): Name the last arg.
465 (ctf_str_add_external) New.
466 (ctf_str_add_strraw_explicit): Likewise.
467 (ctf_simple_open_internal): Likewise.
468 (ctf_bufopen_internal): Likewise.
469
470 * ctf-string.c (ctf_strraw_explicit): Split from...
471 (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
472 (ctf_str_add_ref_internal): Return the atom, not the
473 string.
474 (ctf_str_add): Adjust accordingly.
475 (ctf_str_add_ref): Likewise. Move up in the file.
476 (ctf_str_add_external): New: update the csa_offset.
477 (ctf_str_count_strtab): Only account for strings with no csa_offset
478 in the internal strtab length.
479 (ctf_str_write_strtab): If the csa_offset is set, update the
480 string's refs without writing the string out, and update the
481 ctf_syn_ext_strtab. Make OOM handling less ugly.
482 * ctf-create.c (struct ctf_sort_var_arg_cb): New.
483 (ctf_update): Handle failure to populate the strtab. Pass in the
484 new ctf_sort_var arg. Adjust for ctf_syn_ext_strtab addition.
485 Call ctf_simple_open_internal, not ctf_simple_open.
486 (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
487 strings by hand.
488 * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
489 ctf_strraw). Adjust to diagnose ECTF_STRTAB nonetheless.
490 * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
491 (ctf_file_close): Destroy the ctf_syn_ext_strtab.
492 (ctf_simple_open): Rename to, and reimplement as a wrapper around...
493 (ctf_simple_open_internal): ... this new function, which calls
494 ctf_bufopen_internal.
495 (ctf_bufopen): Rename to, and reimplement as a wrapper around...
496 (ctf_bufopen_internal): ... this new function, which sets
497 ctf_syn_ext_strtab.
498
499 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
500
501 * ctf_types.c (ctf_type_iter_all): New.
502
503 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
504
505 * ctf-open.c (init_symtab): Check for overflow against the right
506 section.
507 (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
508 (upgrade_types_v1): Note that these sections are not checked.
509 (flip_header): Endian-swap the header fields.
510 (flip_ctf): Endian-swap the sections.
511 (flip_objts): Update comment.
512 (ctf_bufopen): Check header offsets and alignment for validity.
513
514 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
515
516 * ctf-open-bfd.c: Add <assert.h>.
517 (ctf_bfdopen_ctfsect): Open string and symbol tables using
518 techniques borrowed from bfd_elf_sym_name.
519 (ctf_new_archive_internal): Improve comment.
520 * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
521 * ctf-open.c (ctf_bufopen): Allow opening with a string section but
522 no symbol section, but not vice versa.
523
524 2019-07-08 Nick Alcock <nick.alcock@oracle.com>
525
526 * ctf-impl.h (ctf_file_t): New field ctf_openflags.
527 * ctf-open.c (ctf_bufopen): Set it. No longer dump header offsets.
528 * ctf-dump.c (dump_header): New function, dump the CTF header.
529 (ctf_dump): Call it.
530 (ctf_dump_header_strfield): New function.
531 (ctf_dump_header_sectfield): Likewise.
532
533 2019-07-06 Nick Alcock <nick.alcock@oracle.com>
534
535 * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
536 ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
537 * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
538 ctf_base: do not assume that it is always sizeof (ctf_header_t).
539 Print out ctf_cuname: only print out ctf_parname if set.
540 (ctf_free_base): Removed, ctf_base is no longer freed: free
541 ctf_dynbase instead.
542 (ctf_set_version): Fix spacing.
543 (upgrade_header): New, in-place header upgrading.
544 (upgrade_types): Rename to...
545 (upgrade_types_v1): ... this. Free ctf_dynbase, not ctf_base. No
546 longer track old and new headers separately. No longer allow for
547 header sizes explicitly: squeeze the headers out on upgrade (they
548 are preserved in fp->ctf_header). Set ctf_dynbase, ctf_base and
549 ctf_buf explicitly. Use ctf_free, not ctf_free_base.
550 (upgrade_types): New, also handle ctf_parmax updating.
551 (flip_header): Flip ctf_cuname.
552 (flip_types): Flip BUF explicitly rather than deriving BUF from
553 BASE.
554 (ctf_bufopen): Store the header in fp->ctf_header. Correct minimum
555 required alignment of objtoff and funcoff. No longer store it in
556 the ctf_buf unless that buf is derived unmodified from the input.
557 Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
558 that duplicate fields in ctf_file: move allocation of ctf_file
559 further up instead. Call upgrade_header as needed. Move
560 version-specific ctf_parmax initialization into upgrade_types. More
561 concise error handling.
562 (ctf_file_close): No longer test for null pointers before freeing.
563 Free ctf_dyncuname, ctf_dynbase, and ctf_header. Do not call
564 ctf_free_base.
565 (ctf_cuname): New.
566 (ctf_cuname_set): New.
567 * ctf-create.c (ctf_update): Populate ctf_cuname.
568 (ctf_gzwrite): Write out the header explicitly. Remove obsolescent
569 comment.
570 (ctf_write): Likewise.
571 (ctf_compress_write): Get the header from ctf_header, not ctf_base.
572 Fix the compression length: fp->ctf_size never counted the CTF
573 header. Simplify the compress call accordingly.
574
575 2019-07-11 Hans-Peter Nilsson <hp@bitrange.com>
576
577 * ctf-endian.h: Don't assume htole64 and le64toh are always
578 present if HAVE_ENDIAN_H; also check if htole64 is defined.
579 [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
580 not bswap_identity_64.
581
582 2019-09-18 Alan Modra <amodra@gmail.com>
583
584 * ctf-open-bfd.c: Update throughout for bfd section macro changes.
585
586 2019-09-09 Phil Blundell <pb@pbcl.net>
587
588 binutils 2.33 branch created.
589
590 2019-07-18 Nick Alcock <nick.alcock@oracle.com>
591
592 * ctf-types.c (ctf_type_aname_raw): New.
593 (ctf_func_type_info): Likewise.
594 (ctf_func_type_args): Likewise.
595 * ctf-error.c (_ctf_errlist): Fix description.
596 * ctf-lookup.c: Fix file description.
597
598 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
599
600 * ctf-create.c (ctf_create): Fix off-by-one error.
601
602 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
603
604 * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
605 struct ctf_strs.
606 (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
607 (struct ctf_str_atom): New, disambiguated single string.
608 (struct ctf_str_atom_ref): New, points to some other location that
609 references this string's offset.
610 (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
611 Remove member ctf_dtvstrlen: we no longer track the total strlen
612 as we add strings.
613 (ctf_str_create_atoms): Declare new function in ctf-string.c.
614 (ctf_str_free_atoms): Likewise.
615 (ctf_str_add): Likewise.
616 (ctf_str_add_ref): Likewise.
617 (ctf_str_rollback): Likewise.
618 (ctf_str_purge_refs): Likewise.
619 (ctf_str_write_strtab): Likewise.
620 (ctf_realloc): Declare new function in ctf-util.c.
621
622 * ctf-open.c (ctf_bufopen): Create the atoms table.
623 (ctf_file_close): Destroy it.
624 * ctf-create.c (ctf_update): Copy-and-free it on update. No longer
625 special-case the position of the parname string. Construct the
626 strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
627 rest of each buffer element is constructed, not via open-coding:
628 realloc the CTF buffer and append the strtab to it. No longer
629 maintain ctf_dtvstrlen. Sort the variable entry table later, after
630 strtab construction.
631 (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
632 (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
633 after buffer element construction instead.
634 (ctf_copy_lmembers): Likewise.
635 (ctf_copy_emembers): Likewise.
636 (ctf_create): No longer maintain the ctf_dtvstrlen.
637 (ctf_dtd_delete): Likewise.
638 (ctf_dvd_delete): Likewise.
639 (ctf_add_generic): Likewise.
640 (ctf_add_enumerator): Likewise.
641 (ctf_add_member_offset): Likewise.
642 (ctf_add_variable): Likewise.
643 (membadd): Likewise.
644 * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
645 if there are active ctf_str_num_refs.
646 (ctf_strraw): Move to ctf-string.c.
647 (ctf_strptr): Likewise.
648 * ctf-string.c: New file, strtab manipulation.
649
650 * Makefile.am (libctf_a_SOURCES): Add it.
651 * Makefile.in: Regenerate.
652
653 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
654
655 * ctf-impl.h (ctf_hash_iter_f): New.
656 (ctf_dynhash_iter): New declaration.
657 (ctf_dynhash_iter_remove): New declaration.
658 * ctf-hash.c (ctf_dynhash_iter): Define.
659 (ctf_dynhash_iter_remove): Likewise.
660 (ctf_hashtab_traverse): New.
661 (ctf_hashtab_traverse_remove): Likewise.
662 (struct ctf_traverse_cb_arg): Likewise.
663 (struct ctf_traverse_remove_cb_arg): Likewise.
664
665 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
666
667 * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
668
669 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
670
671 * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
672 (ctf_dump_funcs): Likewise.
673
674 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
675
676 * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
677 (ctf_fdopen): Check for endian-swapped raw CTF magic, and
678 little-endian CTF archive magic. Do not check the CTF version:
679 ctf_simple_open does that in endian-safe ways. Do not dereference
680 null pointers on open failure.
681
682 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
683
684 * ctf-open.c (get_vbytes_common): Return the new slice size.
685 (ctf_bufopen): Flip the endianness of the CTF-section header copy.
686 Remember to copy in the CTF data when opening an uncompressed
687 foreign-endian CTF file. Prune useless variable manipulation.
688
689 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
690
691 * ctf-open.c (ctf_types): Fail when unidentified type kinds are
692 seen.
693
694 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
695
696 * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
697 output.
698
699 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
700
701 * ctf-subr.c (_PAGESIZE): Remove.
702 (ctf_data_alloc): Likewise.
703 (ctf_data_free): Likewise.
704 (ctf_data_protect): Likewise.
705 * ctf-impl.h: Remove declarations.
706 * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
707 ctf_free, not ctf_data_free.
708 (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc. Free
709 the buffer again on compression error.
710 * ctf-open.c (ctf_set_base): No longer track the size: call
711 ctf_free, not ctf_data_free.
712 (upgrade_types): Likewise. Call ctf_alloc, not ctf_data_alloc.
713 (ctf_bufopen): Likewise. No longer call ctf_data_protect.
714
715 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
716
717 * ctf-create.c (ctf_dtd_insert): Pass on error returns from
718 ctf_dynhash_insert.
719 (ctf_dvd_insert): Likewise.
720 (ctf_add_generic): Likewise.
721 (ctf_add_variable): Likewise.
722 * ctf-impl.h: Adjust declarations.
723
724 2019-06-14 Alan Modra <amodra@gmail.com>
725
726 * configure: Regenerate.
727
728 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
729
730 * ctf-decls.h: Include <libiberty.h>.
731 * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
732
733 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
734
735 * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
736 (ctf_dump_objts): Likewise.
737 (ctf_dump_funcs): Likewise.
738 (ctf_dump_member): Likewise.
739 (ctf_dump_str): Likewise.
740
741 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
742
743 * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
744 * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
745
746 2019-06-05 Nick Alcock <nick.alcock@oracle.com>
747
748 * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
749 (ctf_arc_open_by_offset): Likewise.
750 * ctf-create.c (ctf_add_type): Likewise.
751
752 2019-06-04 Tom Tromey <tromey@adacore.com>
753
754 * ctf-create.c (ctf_add_encoded, ctf_add_slice)
755 (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
756
757 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
758
759 * configure.ac: Check for O_CLOEXEC.
760 * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
761 * config.h.in: Regenerate.
762 * configure: Likewise.
763
764 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
765
766 * qsort_r.c: Rename to...
767 * ctf-qsort_r.c: ... this.
768 (_quicksort): Define to ctf_qsort_r.
769 * ctf-decls.h (qsort_r): Remove.
770 (ctf_qsort_r): Add.
771 (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
772 (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
773 * Makefile.am (libctf_a_LIBADD): Remove.
774 (libctf_a_SOURCES): New, add ctf-qsort_r.c.
775 * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
776 * ctf-create.c (ctf_update): Likewise.
777 * configure.ac: Check for BSD versus GNU qsort_r signature.
778 * Makefile.in: Regenerate.
779 * config.h.in: Likewise.
780 * configure: Likewise.
781
782 2019-06-03 Nick Alcock <nick.alcock@oracle.com>
783
784 * ctf-dump.c (ctf_dump_funcs): Free in the right place.
785
786 2019-05-29 Nick Alcock <nick.alcock@oracle.com>
787
788 * Makefile.am (ZLIB): New.
789 (ZLIBINC): Likewise.
790 (AM_CFLAGS): Use them.
791 (libctf_a_LIBADD): New, for LIBOBJS.
792 * configure.ac: Check for zlib, endian.h, and qsort_r.
793 * ctf-endian.h: New, providing htole64 and le64toh.
794 * swap.h: Code style fixes.
795 (bswap_identity_64): New.
796 * qsort_r.c: New, from gnulib (with one added #include).
797 * ctf-decls.h: New, providing a conditional qsort_r declaration,
798 and unconditional definitions of MIN and MAX.
799 * ctf-impl.h: Use it. Do not use <sys/errno.h>.
800 (ctf_set_errno): Now returns unsigned long.
801 * ctf-util.c (ctf_set_errno): Adjust here too.
802 * ctf-archive.c: Use ctf-endian.h.
803 (ctf_arc_open_by_offset): Use memset, not bzero. Drop cts_type,
804 cts_flags and cts_offset.
805 (ctf_arc_write): Drop debugging dependent on the size of off_t.
806 * ctf-create.c: Provide a definition of roundup if not defined.
807 (ctf_create): Drop cts_type, cts_flags and cts_offset.
808 (ctf_add_reftype): Do not check if type IDs are below zero.
809 (ctf_add_slice): Likewise.
810 (ctf_add_typedef): Likewise.
811 (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
812 when known error-free. Drop CTF_ERR usage for functions returning
813 int.
814 (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
815 int.
816 (ctf_add_variable): Likewise.
817 (enumcmp): Likewise.
818 (enumadd): Likewise.
819 (membcmp): Likewise.
820 (ctf_add_type): Likewise. Cast error-returning ssize_t's to size_t
821 when known error-free.
822 * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
823 returning int: use CTF_ERR for functions returning ctf_type_id.
824 (ctf_dump_label): Likewise.
825 (ctf_dump_objts): Likewise.
826 * ctf-labels.c (ctf_label_topmost): Likewise.
827 (ctf_label_iter): Likewise.
828 (ctf_label_info): Likewise.
829 * ctf-lookup.c (ctf_func_args): Likewise.
830 * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
831 (ctf_bufopen): Likewise. Use zlib types as needed.
832 * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
833 returning int.
834 (ctf_enum_iter): Likewise.
835 (ctf_type_size): Likewise.
836 (ctf_type_align): Likewise. Cast to size_t where appropriate.
837 (ctf_type_kind_unsliced): Likewise.
838 (ctf_type_kind): Likewise.
839 (ctf_type_encoding): Likewise.
840 (ctf_member_info): Likewise.
841 (ctf_array_info): Likewise.
842 (ctf_enum_value): Likewise.
843 (ctf_type_rvisit): Likewise.
844 * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
845 cts_offset.
846 (ctf_simple_open): Likewise.
847 (ctf_bfdopen_ctfsect): Likewise. Set cts_size properly.
848 * Makefile.in: Regenerate.
849 * aclocal.m4: Likewise.
850 * config.h: Likewise.
851 * configure: Likewise.
852
853 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
854
855 * configure.in: Check for bfd_section_from_elf_index.
856 * configure: Regenerate.
857 * config.h.in [HAVE_BFD_ELF]: Likewise.
858 * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
859 abfd is potentially unused now.
860
861 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
862
863 * Makefile.am: New.
864 * Makefile.in: Regenerated.
865 * config.h.in: Likewise.
866 * aclocal.m4: Likewise.
867 * configure: Likewise.
868
869 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
870
871 * ctf-dump.c: New.
872
873 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
874
875 * ctf-labels.c: New.
876
877 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
878
879 * ctf-impl.h (_libctf_version): New declaration.
880 * ctf-subr.c (_libctf_version): Define it.
881 (ctf_version): New.
882
883 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
884
885 * ctf-create.c (enumcmp): New.
886 (enumadd): Likewise.
887 (membcmp): Likewise.
888 (membadd): Likewise.
889 (ctf_add_type): Likewise.
890
891 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
892
893 * ctf-lookup.c (isqualifier): New.
894 (ctf_lookup_by_name): Likewise.
895 (struct ctf_lookup_var_key): Likewise.
896 (ctf_lookup_var): Likewise.
897 (ctf_lookup_variable): Likewise.
898 (ctf_lookup_symbol_name): Likewise.
899 (ctf_lookup_by_symbol): Likewise.
900 (ctf_func_info): Likewise.
901 (ctf_func_args): Likewise.
902
903 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
904
905 * ctf-decl.c: New file.
906 * ctf-types.c: Likewise.
907 * ctf-impl.h: New declarations.
908
909 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
910
911 * ctf-open-bfd.c: New file.
912 * ctf-open.c (ctf_close): New.
913 * ctf-impl.h: Include bfd.h.
914 (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
915 (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
916 ctfi_bfd_close.
917 (ctf_bfdopen_ctfsect): New declaration.
918 (_CTF_SECTION): likewise.
919
920 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
921
922 * ctf-archive.c: New.
923 * ctf-impl.h (ctf_archive_internal): New type.
924 (ctf_arc_open_internal): New declaration.
925 (ctf_arc_bufopen): Likewise.
926 (ctf_arc_close_internal): Likewise.
927
928 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
929
930 * ctf-open.c: New file.
931 * swap.h: Likewise.
932
933 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
934
935 * ctf-create.c: New file.
936 * ctf-lookup.c: New file.
937
938 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
939
940 * ctf-impl.h: New definitions and declarations for type creation
941 and lookup.
942
943 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
944
945 * ctf-hash.c: New file.
946 * ctf-impl.h: New declarations.
947
948 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
949
950 * ctf-error.c: New file.
951
952 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
953
954 * ctf-util.c: New file.
955 * elf.h: Likewise.
956 * ctf-impl.h: Include it, and add declarations.
957
958 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
959
960 * ctf-impl.h: New file.
961 * ctf-subr.c: New file.
962
963 \f
964 Local Variables:
965 mode: change-log
966 left-margin: 8
967 fill-column: 76
968 version-control: never
969 End:
This page took 0.048816 seconds and 4 git commands to generate.