1 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
3 * aclocal.m4: Add config/gettext-sister.m4: Shuffle into
5 * configure.ac: Add ZW_GNU_GETTEXT_SISTER_DIR.
6 * config.h.in: Regenerated.
7 * Makefile.in: Likewise.
10 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
12 * ctf-create.c: Include <unistd.h>.
13 * ctf-open-bfd.c: Likewise.
15 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
18 * configure.ac: Check for bswap_16, bswap_32, and bswap_64 decls.
19 * swap.h (bswap_16): Do not assume that presence of <byteswap.h>
20 means this is declared.
23 (bswap_identity_64): Remove, unused.
24 * configure: Regenerated.
25 * config.h.in: Likewise.
27 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
30 * ctf-impl.h (_libctf_printflike_): Add non-GNU-C fallback.
31 (_libctf_unlikely_): Likewise.
32 (_libctf_unused): Likewise.
33 (_libctf_malloc_): Likewise.
35 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
38 * ctf-archive.c (search_nametbl): No longer global: declare...
39 (ctf_arc_open_by_name_internal): ... here. Use bsearch_r.
40 (search_modent_by_name): Take and use ARG for the nametbl.
42 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
44 * ctf-impl.h (ctf_new_archive_internal): Declare.
45 (ctf_arc_bufopen): Remove.
46 (ctf_archive_internal) <ctfi_free_symsect>: New.
47 * ctf-archive.c (ctf_arc_close): Use it.
48 (ctf_arc_bufopen): Fuse into...
49 (ctf_new_archive_internal): ... this, moved across from...
50 * ctf-open-bfd.c: ... here.
51 (ctf_bfdopen_ctfsect): Use ctf_arc_bufopen.
54 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
56 * ctf-create.c (ctf_add_forward): Intern in the right namespace.
57 (ctf_dtd_delete): Remove correspondingly.
58 (ctf_rollback): Likewise.
60 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
62 * ctf-create.c (ctf_add_type_internal): Hand back existing types
65 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
67 * ctf-create.c (ctf_add_forward): Don't add forwards to
68 types that already exist.
70 2020-06-26 Nick Alcock <nick.alcock@oracle.com>
72 * ctf-open.c (init_types): Only intern root-visible types.
73 * ctf-create.c (ctf_dtd_insert): Likewise.
74 (ctf_dtd_delete): Only remove root-visible types.
75 (ctf_rollback): Likewise.
76 (ctf_add_generic): Adjust.
77 (ctf_add_struct_sized): Adjust comment.
78 (ctf_add_union_sized): Likewise.
79 (ctf_add_enum): Likewise.
80 * ctf-impl.h (ctf_dtd_insert): Adjust prototype.
82 2020-03-11 John Baldwin <jhb@FreeBSD.org>
84 * swap.h (bswap_identity_64): Make static.
86 2020-01-18 Nick Clifton <nickc@redhat.com>
88 Binutils 2.34 branch created.
90 2020-01-05 Joel Brobecker <brobecker@adacore.com>
93 * configure.ac: Add AC_CHECK_DECLS([asprintf]).
94 * configure, config.h.in: Regenerate.
96 2020-01-01 Alan Modra <amodra@gmail.com>
98 Update year range in copyright notice of all files.
100 2019-10-16 Simon Marchi <simon.marchi@polymtl.ca>
102 * swap.h (bswap_16, bswap_32, bswap_64): Make static.
104 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
106 * ctf-open.c (ctf_bufopen_internal): Fix tabdamage.
107 * ctf-types.c (ctf_type_lname): Likewise.
109 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
111 * ctf-open.c (ctf_import): Do not leak a ctf_file_t ref on every
112 ctf_import after the first for a given file.
114 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
116 * ctf-impl.h (ctf_str_append_noerr): Declare.
117 * ctf-util.c (ctf_str_append_noerr): Define in terms of
119 * ctf-dump.c (str_append): New, call it.
120 (ctf_dump_format_type): Use str_append, not ctf_str_append.
121 (ctf_dump_label): Likewise.
122 (ctf_dump_objts): Likewise.
123 (ctf_dump_funcs): Likewise.
124 (ctf_dump_var): Likewise.
125 (ctf_dump_member): Likewise.
126 (ctf_dump_type): Likewise.
127 (ctf_dump): Likewise.
129 2019-09-23 Nick Alcock <nick.alcock@oracle.com>
131 * ctf-impl.h (ctf_alloc): Remove.
132 (ctf_free): Likewise.
133 (ctf_strdup): Likewise.
134 * ctf-subr.c (ctf_alloc): Remove.
135 (ctf_free): Likewise.
136 * ctf-util.c (ctf_strdup): Remove.
138 * ctf-create.c (ctf_serialize): Use malloc, not ctf_alloc; free, not
139 ctf_free; strdup, not ctf_strdup.
140 (ctf_dtd_delete): Likewise.
141 (ctf_dvd_delete): Likewise.
142 (ctf_add_generic): Likewise.
143 (ctf_add_function): Likewise.
144 (ctf_add_enumerator): Likewise.
145 (ctf_add_member_offset): Likewise.
146 (ctf_add_variable): Likewise.
148 (ctf_compress_write): Likewise.
149 (ctf_write_mem): Likewise.
150 * ctf-decl.c (ctf_decl_push): Likewise.
151 (ctf_decl_fini): Likewise.
152 (ctf_decl_sprintf): Likewise. Check for OOM.
153 * ctf-dump.c (ctf_dump_append): Use malloc, not ctf_alloc; free, not
154 ctf_free; strdup, not ctf_strdup.
155 (ctf_dump_free): Likewise.
156 (ctf_dump): Likewise.
157 * ctf-open.c (upgrade_types_v1): Likewise.
158 (init_types): Likewise.
159 (ctf_file_close): Likewise.
160 (ctf_bufopen_internal): Likewise. Check for OOM.
161 (ctf_parent_name_set): Likewise: report the OOM to the caller.
162 (ctf_cuname_set): Likewise.
163 (ctf_import): Likewise.
164 * ctf-string.c (ctf_str_purge_atom_refs): Use malloc, not ctf_alloc;
165 free, not ctf_free; strdup, not ctf_strdup.
166 (ctf_str_free_atom): Likewise.
167 (ctf_str_create_atoms): Likewise.
168 (ctf_str_add_ref_internal): Likewise.
169 (ctf_str_remove_ref): Likewise.
170 (ctf_str_write_strtab): Likewise.
172 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
174 * ctf-types.c (ctf_type_encoding): Fix the dynamic case to
175 work right for non-int/fps.
177 2019-08-08 Nick Alcock <nick.alcock@oracle.com>
179 * ctf-types.c (ctf_type_name): Don't strlen a potentially-
182 2019-08-07 Nick Alcock <nick.alcock@oracle.com>
184 * ctf-impl.h (ctf_file_t) <ctf_add_processing>: New.
185 * ctf-open.c (ctf_file_close): Free it.
186 * ctf-create.c (ctf_serialize): Adjust.
187 (membcmp): When reporting a conflict due to an error, report the
189 (ctf_add_type): Turn into a ctf_add_processing wrapper. Rename to...
190 (ctf_add_type_internal): ... this. Hand back types we are already
191 in the middle of adding immediately. Hand back structs/unions with
192 the same number of members immediately. Do not walk the dynamic
193 list. Call ctf_add_type_internal, not ctf_add_type. Handle
194 forwards promoted to other types and the inverse case identically.
195 Add structs to the mapping as soon as we intern them, before they
198 2019-08-09 Nick Alcock <nick.alcock@oracle.com>
200 * ctf-impl.h (ctf_names_t): New.
201 (ctf_lookup_t) <ctf_hash>: Now a ctf_names_t, not a ctf_hash_t.
202 (ctf_file_t) <ctf_structs>: Likewise.
203 <ctf_unions>: Likewise.
204 <ctf_enums>: Likewise.
205 <ctf_names>: Likewise.
206 <ctf_lookups>: Improve comment.
207 <ctf_ptrtab_len>: New.
208 <ctf_prov_strtab>: New.
209 <ctf_str_prov_offset>: New.
210 <ctf_dtbyname>: Remove, redundant to the names hashes.
211 <ctf_dtnextid>: Remove, redundant to ctf_typemax.
212 (ctf_dtdef_t) <dtd_name>: Remove.
213 <dtd_data>: Note that the ctt_name is now populated.
214 (ctf_str_atom_t) <csa_offset>: This is now the strtab
215 offset for internal strings too.
216 <csa_external_offset>: New, the external strtab offset.
217 (CTF_INDEX_TO_TYPEPTR): Handle the LCTF_RDWR case.
218 (ctf_name_table): New declaration.
219 (ctf_lookup_by_rawname): Likewise.
220 (ctf_lookup_by_rawhash): Likewise.
221 (ctf_set_ctl_hashes): Likewise.
222 (ctf_serialize): Likewise.
223 (ctf_dtd_insert): Adjust.
224 (ctf_simple_open_internal): Likewise.
225 (ctf_bufopen_internal): Likewise.
226 (ctf_list_empty_p): Likewise.
227 (ctf_str_remove_ref): Likewise.
228 (ctf_str_add): Returns uint32_t now.
229 (ctf_str_add_ref): Likewise.
230 (ctf_str_add_external): Now returns a boolean (int).
231 * ctf-string.c (ctf_strraw_explicit): Check the ctf_prov_strtab
232 for strings in the appropriate range.
233 (ctf_str_create_atoms): Create the ctf_prov_strtab. Detect OOM
234 when adding the null string to the new strtab.
235 (ctf_str_free_atoms): Destroy the ctf_prov_strtab.
236 (ctf_str_add_ref_internal): Add make_provisional argument. If
237 make_provisional, populate the offset and fill in the
238 ctf_prov_strtab accordingly.
239 (ctf_str_add): Return the offset, not the string.
240 (ctf_str_add_ref): Likewise.
241 (ctf_str_add_external): Return a success integer.
242 (ctf_str_remove_ref): New, remove a single ref.
243 (ctf_str_count_strtab): Do not count the initial null string's
244 length or the existence or length of any unreferenced internal
246 (ctf_str_populate_sorttab): Skip atoms with no refs.
247 (ctf_str_write_strtab): Populate the nullstr earlier. Add one
248 to the cts_len for the null string, since it is no longer done
249 in ctf_str_count_strtab. Adjust for csa_external_offset rename.
250 Populate the csa_offset for both internal and external cases.
251 Flush the ctf_prov_strtab afterwards, and reset the
253 * ctf-create.c (ctf_grow_ptrtab): New.
254 (ctf_create): Call it. Initialize new fields rather than old
255 ones. Tell ctf_bufopen_internal that this is a writable dictionary.
256 Set the ctl hashes and data model.
257 (ctf_update): Rename to...
258 (ctf_serialize): ... this. Leave a compatibility function behind.
259 Tell ctf_simple_open_internal that this is a writable dictionary.
260 Pass the new fields along from the old dictionary. Drop
261 ctf_dtnextid and ctf_dtbyname. Use ctf_strraw, not dtd_name.
262 Do not zero out the DTD's ctt_name.
263 (ctf_prefixed_name): Rename to...
264 (ctf_name_table): ... this. No longer return a prefixed name: return
265 the applicable name table instead.
266 (ctf_dtd_insert): Use it, and use the right name table. Pass in the
267 kind we're adding. Migrate away from dtd_name.
268 (ctf_dtd_delete): Adjust similarly. Remove the ref to the
270 (ctf_dtd_lookup_type_by_name): Remove.
271 (ctf_dynamic_type): Always return NULL on read-only dictionaries.
272 No longer check ctf_dtnextid: check ctf_typemax instead.
273 (ctf_snapshot): No longer use ctf_dtnextid: use ctf_typemax instead.
274 (ctf_rollback): Likewise. No longer fail with ECTF_OVERROLLBACK. Use
275 ctf_name_table and the right name table, and migrate away from
276 dtd_name as in ctf_dtd_delete.
277 (ctf_add_generic): Pass in the kind explicitly and pass it to
278 ctf_dtd_insert. Use ctf_typemax, not ctf_dtnextid. Migrate away
279 from dtd_name to using ctf_str_add_ref to populate the ctt_name.
280 Grow the ptrtab if needed.
281 (ctf_add_encoded): Pass in the kind.
282 (ctf_add_slice): Likewise.
283 (ctf_add_array): Likewise.
284 (ctf_add_function): Likewise.
285 (ctf_add_typedef): Likewise.
286 (ctf_add_reftype): Likewise. Initialize the ctf_ptrtab, checking
287 ctt_name rather than dtd_name.
288 (ctf_add_struct_sized): Pass in the kind. Use
289 ctf_lookup_by_rawname, not ctf_hash_lookup_type /
290 ctf_dtd_lookup_type_by_name.
291 (ctf_add_union_sized): Likewise.
292 (ctf_add_enum): Likewise.
293 (ctf_add_enum_encoded): Likewise.
294 (ctf_add_forward): Likewise.
295 (ctf_add_type): Likewise.
296 (ctf_compress_write): Call ctf_serialize: adjust for ctf_size not
297 being initialized until after the call.
298 (ctf_write_mem): Likewise.
299 (ctf_write): Likewise.
300 * ctf-archive.c (arc_write_one_ctf): Likewise.
301 * ctf-lookup.c (ctf_lookup_by_name): Use ctf_lookuup_by_rawhash, not
302 ctf_hash_lookup_type.
303 (ctf_lookup_by_id): No longer check the readonly types if the
304 dictionary is writable.
305 * ctf-open.c (init_types): Assert that this dictionary is not
306 writable. Adjust to use the new name hashes, ctf_name_table,
307 and ctf_ptrtab_len. GNU style fix for the final ptrtab scan.
308 (ctf_bufopen_internal): New 'writable' parameter. Flip on LCTF_RDWR
309 if set. Drop out early when dictionary is writable. Split the
310 ctf_lookups initialization into...
311 (ctf_set_cth_hashes): ... this new function.
312 (ctf_simple_open_internal): Adjust. New 'writable' parameter.
313 (ctf_simple_open): Adjust accordingly.
314 (ctf_bufopen): Likewise.
315 (ctf_file_close): Destroy the appropriate name hashes. No longer
316 destroy ctf_dtbyname, which is gone.
317 (ctf_getdatasect): Remove spurious "extern".
318 * ctf-types.c (ctf_lookup_by_rawname): New, look up types in the
319 specified name table, given a kind.
320 (ctf_lookup_by_rawhash): Likewise, given a ctf_names_t *.
321 (ctf_member_iter): Add support for iterating over the
323 (ctf_enum_iter): Likewise.
324 (ctf_variable_iter): Likewise.
325 (ctf_type_rvisit): Likewise.
326 (ctf_member_info): Add support for types in the dynamic type list.
327 (ctf_enum_name): Likewise.
328 (ctf_enum_value): Likewise.
329 (ctf_func_type_info): Likewise.
330 (ctf_func_type_args): Likewise.
331 * ctf-link.c (ctf_accumulate_archive_names): No longer call
333 (ctf_link_write): Likewise.
334 (ctf_link_intern_extern_string): Adjust for new
335 ctf_str_add_external return value.
336 (ctf_link_add_strtab): Likewise.
337 * ctf-util.c (ctf_list_empty_p): New.
339 2019-08-05 Nick Alcock <nick.alcock@oracle.com>
341 * ctf-types.c (ctf_type_resolve): Return ECTF_NONREPRESENTABLE on
343 * ctf-create.c (ctf_add_type): Detect and skip nonrepresentable
345 (ctf_add_variable): Likewise for variables pointing to them.
346 * ctf-link.c (ctf_link_one_type): Do not warn for nonrepresentable
347 type link failure, but do warn for others.
348 * ctf-dump.c (ctf_dump_format_type): Likewise. Do not assume all
350 (ctf_dump_member): Likewise.
351 (ctf_dump_type): Likewise.
352 (ctf_dump_header_strfield): Do not assume all errors to be ENOMEM.
353 (ctf_dump_header_sectfield): Do not assume all errors to be ENOMEM.
354 (ctf_dump_header): Likewise.
355 (ctf_dump_label): likewise.
356 (ctf_dump_objts): likewise.
357 (ctf_dump_funcs): likewise.
358 (ctf_dump_var): likewise.
359 (ctf_dump_str): Likewise.
361 2019-09-30 Nick Alcock <nick.alcock@oracle.com>
363 * configure.ac (AC_DISABLE_SHARED): New, like opcodes/.
365 (AM_INSTALL_LIBBFD): Likewise.
366 (dlopen): Note why this is necessary in a comment.
367 (SHARED_LIBADD): Initialize for possibly-PIC libiberty: derived from
369 (SHARED_LDFLAGS): Likewise.
370 (BFD_LIBADD): Likewise, for libbfd.
371 (BFD_DEPENDENCIES): Likewise.
372 (VERSION_FLAGS): Initialize, using a version script if ld supports
373 one, or libtool -export-symbols-regex otherwise.
374 (AC_CONFIG_MACRO_DIR): Add ../BFD.
375 * Makefile.am (ACLOCAL_AMFLAGS): Likewise.
377 (AM_CPPFLAGS): Use $(srcdir), not $(top_srcdir).
378 (noinst_LIBRARIES): Replace with...
379 [INSTALL_LIBBFD] (lib_LTLIBRARIES): This, or...
380 [!INSTALL_LIBBFD] (noinst_LTLIBRARIES): ... this, mentioning new
381 libctf-nobfd.la as well.
382 [INSTALL_LIBCTF] (include_HEADERS): Add the CTF headers.
383 [!INSTALL_LIBCTF] (include_HEADERS): New, empty.
384 (libctf_a_SOURCES): Rename to...
385 (libctf_nobfd_la_SOURCES): ... this, all of libctf other than
387 (libctf_la_SOURCES): Now derived from libctf_nobfd_la_SOURCES,
388 with ctf-open-bfd.c added.
389 (libctf_nobfd_la_LIBADD): New, using @SHARED_LIBADD@.
390 (libctf_la_LIBADD): New, using @BFD_LIBADD@ as well.
391 (libctf_la_DEPENDENCIES): New, using @BFD_DEPENDENCIES@.
392 * Makefile.am [INSTALL_LIBCTF]: Use it.
393 * aclocal.m4: Add ../bfd/acinclude.m4, ../config/acx.m4, and the
395 * libctf.ver: New, everything is version LIBCTF_1.0 currently (even
396 the unstable components).
397 * Makefile.in: Regenerated.
398 * config.h.in: Likewise.
399 * configure: Likewise.
401 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
403 * configure.ac (INSTALL_LIBCTF): New, controlled by
404 --enable-install-libctf.
405 [INSTALL_LIBCTF] (lib_LIBRARIES): Add libctf.a.
406 * Makefile.in: Regenerated.
407 * configure: Regenerated.
409 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
411 * ctf-archive.c (ctf_arc_close): Call ctfi_bfd_close if set.
412 * ctf-open-bfd.c (ctf_bfdclose): Fix comment.
414 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
416 * ctf-open-bfd.c (ctf_fdopen): Call bfd_set_cacheable.
418 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
420 * ctf-impl.h (includes): Include <sys/param.h> here.
422 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
424 * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.
425 (flip_objts): Likewise.
426 (flip_vars): Likewise.
427 (flip_types): Likewise.
429 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
431 * ctf-hash.c (ctf_hashtab_insert): Pass in the key and value
432 freeing functions: if set, free the key and value if the slot
433 already exists. Always reassign the key.
434 (ctf_dynhash_insert): Adjust call appropriately.
435 (ctf_hash_insert_type): Likewise.
437 2019-08-03 Nick Alcock <nick.alcock@oracle.com>
439 * ctf-create.c (ctf_add_type): Look up and use the forwarded-to
440 type kind. Allow forwards to unify with pre-existing structs/
443 2019-07-30 Nick Alcock <nick.alcock@oracle.com>
445 * ctf-impl.h (ctf_file_t) <ctf_link_cu_mappping>: New.
446 <ctf_link_memb_name_changer>: Likewise.
447 <ctf_link_memb_name_changer_arg>: Likewise.
448 * ctf-create.c (ctf_update): Update accordingly.
449 * ctf-open.c (ctf_file_close): Likewise.
450 * ctf-link.c (ctf_create_per_cu): Apply the cu mapping.
451 (ctf_link_add_cu_mapping): New.
452 (ctf_link_set_memb_name_changer): Likewise.
453 (ctf_change_parent_name): New.
454 (ctf_name_list_accum_cb_arg_t) <dynames>: New, storage for names
455 allocated by the caller's ctf_link_memb_name_changer.
456 <ndynames>: Likewise.
457 (ctf_accumulate_archive_names): Call the ctf_link_memb_name_changer.
458 (ctf_link_write): Likewise (for _CTF_SECTION only): also call
459 ctf_change_parent_name. Free any resulting names.
461 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
463 * ctf-link.c (ctf_create_per_cu): New, refactored out of...
464 (ctf_link_one_type): ... here, with parent-name setting added.
465 (check_variable): New.
466 (ctf_link_one_variable): Likewise.
467 (ctf_link_one_input_archive_member): Call it.
468 * ctf-error.c (_ctf_errlist): Updated with new errors.
470 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
472 * ctf-impl.h (ctf_file_t): New field ctf_link_type_mapping.
473 (struct ctf_link_type_mapping_key): New.
474 (ctf_hash_type_mapping_key): Likewise.
475 (ctf_hash_eq_type_mapping_key): Likewise.
476 (ctf_add_type_mapping): Likewise.
477 (ctf_type_mapping): Likewise.
478 (ctf_dynhash_empty): Likewise.
479 * ctf-open.c (ctf_file_close): Update accordingly.
480 * ctf-create.c (ctf_update): Likewise.
481 (ctf_add_type): Populate the mapping.
482 * ctf-hash.c (ctf_hash_type_mapping_key): Hash a type mapping key.
483 (ctf_hash_eq_type_mapping_key): Check the key for equality.
484 (ctf_dynhash_insert): Fix comment typo.
485 (ctf_dynhash_empty): New.
486 * ctf-link.c (ctf_add_type_mapping): New.
487 (ctf_type_mapping): Likewise.
488 (empty_link_type_mapping): New.
489 (ctf_link_one_input_archive): Call it.
491 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
493 * ctf-link.c: New file, linking of the string and type sections.
494 * Makefile.am (libctf_a_SOURCES): Add it.
495 * Makefile.in: Regenerate.
497 * ctf-impl.h (ctf_file_t): New fields ctf_link_inputs,
499 * ctf-create.c (ctf_update): Update accordingly.
500 * ctf-open.c (ctf_file_close): Likewise.
501 * ctf-error.c (_ctf_errlist): Updated with new errors.
503 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
505 * ctf-dump.c (ctf_dump_funcs): Check the right error value.
507 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
509 * ctf-dump.c (ctf_dump): Use ctf_type_iter_all to dump types, not
511 (ctf_dump_type): Pass down the flag from ctf_type_iter_all.
512 (ctf_dump_format_type): Add non-root-type { } notation.
513 Add root flag to prototype.
514 (ctf_dump_label): Adjust accordingly.
515 (ctf_dump_objts): Likewise.
516 (ctf_dump_var): Likewise.
518 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
520 * ctf-create.c (ctf_compress_write): Fix double-free.
522 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
524 * ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
526 (ctf_arc_write_fd): ... this new function.
527 * ctf-create.c (ctf_write_mem): New.
529 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
531 * ctf-impl.h (ctf_str_atom_t) <csa_offset>: New field.
532 (ctf_file_t) <ctf_syn_ext_strtab>: Likewise.
533 (ctf_str_add_ref): Name the last arg.
534 (ctf_str_add_external) New.
535 (ctf_str_add_strraw_explicit): Likewise.
536 (ctf_simple_open_internal): Likewise.
537 (ctf_bufopen_internal): Likewise.
539 * ctf-string.c (ctf_strraw_explicit): Split from...
540 (ctf_strraw): ... here, with new support for ctf_syn_ext_strtab.
541 (ctf_str_add_ref_internal): Return the atom, not the
543 (ctf_str_add): Adjust accordingly.
544 (ctf_str_add_ref): Likewise. Move up in the file.
545 (ctf_str_add_external): New: update the csa_offset.
546 (ctf_str_count_strtab): Only account for strings with no csa_offset
547 in the internal strtab length.
548 (ctf_str_write_strtab): If the csa_offset is set, update the
549 string's refs without writing the string out, and update the
550 ctf_syn_ext_strtab. Make OOM handling less ugly.
551 * ctf-create.c (struct ctf_sort_var_arg_cb): New.
552 (ctf_update): Handle failure to populate the strtab. Pass in the
553 new ctf_sort_var arg. Adjust for ctf_syn_ext_strtab addition.
554 Call ctf_simple_open_internal, not ctf_simple_open.
555 (ctf_sort_var): Call ctf_strraw_explicit rather than looking up
557 * ctf-hash.c (ctf_hash_insert_type): Likewise (but using
558 ctf_strraw). Adjust to diagnose ECTF_STRTAB nonetheless.
559 * ctf-open.c (init_types): No longer filter out ECTF_STRTAB.
560 (ctf_file_close): Destroy the ctf_syn_ext_strtab.
561 (ctf_simple_open): Rename to, and reimplement as a wrapper around...
562 (ctf_simple_open_internal): ... this new function, which calls
563 ctf_bufopen_internal.
564 (ctf_bufopen): Rename to, and reimplement as a wrapper around...
565 (ctf_bufopen_internal): ... this new function, which sets
568 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
570 * ctf_types.c (ctf_type_iter_all): New.
572 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
574 * ctf-open.c (init_symtab): Check for overflow against the right
576 (upgrade_header): Set cth_objtidxoff, cth_funcidxoff to zero-length.
577 (upgrade_types_v1): Note that these sections are not checked.
578 (flip_header): Endian-swap the header fields.
579 (flip_ctf): Endian-swap the sections.
580 (flip_objts): Update comment.
581 (ctf_bufopen): Check header offsets and alignment for validity.
583 2019-07-13 Nick Alcock <nick.alcock@oracle.com>
585 * ctf-open-bfd.c: Add <assert.h>.
586 (ctf_bfdopen_ctfsect): Open string and symbol tables using
587 techniques borrowed from bfd_elf_sym_name.
588 (ctf_new_archive_internal): Improve comment.
589 * ctf-archive.c (ctf_arc_close): Do not free the ctfi_strsect.
590 * ctf-open.c (ctf_bufopen): Allow opening with a string section but
591 no symbol section, but not vice versa.
593 2019-07-08 Nick Alcock <nick.alcock@oracle.com>
595 * ctf-impl.h (ctf_file_t): New field ctf_openflags.
596 * ctf-open.c (ctf_bufopen): Set it. No longer dump header offsets.
597 * ctf-dump.c (dump_header): New function, dump the CTF header.
599 (ctf_dump_header_strfield): New function.
600 (ctf_dump_header_sectfield): Likewise.
602 2019-07-06 Nick Alcock <nick.alcock@oracle.com>
604 * ctf-impl.h (ctf_file_t): New fields ctf_header, ctf_dynbase,
605 ctf_cuname, ctf_dyncuname: ctf_base and ctf_buf are no longer const.
606 * ctf-open.c (ctf_set_base): Preserve the gap between ctf_buf and
607 ctf_base: do not assume that it is always sizeof (ctf_header_t).
608 Print out ctf_cuname: only print out ctf_parname if set.
609 (ctf_free_base): Removed, ctf_base is no longer freed: free
611 (ctf_set_version): Fix spacing.
612 (upgrade_header): New, in-place header upgrading.
613 (upgrade_types): Rename to...
614 (upgrade_types_v1): ... this. Free ctf_dynbase, not ctf_base. No
615 longer track old and new headers separately. No longer allow for
616 header sizes explicitly: squeeze the headers out on upgrade (they
617 are preserved in fp->ctf_header). Set ctf_dynbase, ctf_base and
618 ctf_buf explicitly. Use ctf_free, not ctf_free_base.
619 (upgrade_types): New, also handle ctf_parmax updating.
620 (flip_header): Flip ctf_cuname.
621 (flip_types): Flip BUF explicitly rather than deriving BUF from
623 (ctf_bufopen): Store the header in fp->ctf_header. Correct minimum
624 required alignment of objtoff and funcoff. No longer store it in
625 the ctf_buf unless that buf is derived unmodified from the input.
626 Set ctf_dynbase where ctf_base is dynamically allocated. Drop locals
627 that duplicate fields in ctf_file: move allocation of ctf_file
628 further up instead. Call upgrade_header as needed. Move
629 version-specific ctf_parmax initialization into upgrade_types. More
630 concise error handling.
631 (ctf_file_close): No longer test for null pointers before freeing.
632 Free ctf_dyncuname, ctf_dynbase, and ctf_header. Do not call
635 (ctf_cuname_set): New.
636 * ctf-create.c (ctf_update): Populate ctf_cuname.
637 (ctf_gzwrite): Write out the header explicitly. Remove obsolescent
639 (ctf_write): Likewise.
640 (ctf_compress_write): Get the header from ctf_header, not ctf_base.
641 Fix the compression length: fp->ctf_size never counted the CTF
642 header. Simplify the compress call accordingly.
644 2019-07-11 Hans-Peter Nilsson <hp@bitrange.com>
646 * ctf-endian.h: Don't assume htole64 and le64toh are always
647 present if HAVE_ENDIAN_H; also check if htole64 is defined.
648 [!WORDS_BIGENDIAN] (htole64, le64toh): Define as identity,
649 not bswap_identity_64.
651 2019-09-18 Alan Modra <amodra@gmail.com>
653 * ctf-open-bfd.c: Update throughout for bfd section macro changes.
655 2019-09-09 Phil Blundell <pb@pbcl.net>
657 binutils 2.33 branch created.
659 2019-07-18 Nick Alcock <nick.alcock@oracle.com>
661 * ctf-types.c (ctf_type_aname_raw): New.
662 (ctf_func_type_info): Likewise.
663 (ctf_func_type_args): Likewise.
664 * ctf-error.c (_ctf_errlist): Fix description.
665 * ctf-lookup.c: Fix file description.
667 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
669 * ctf-create.c (ctf_create): Fix off-by-one error.
671 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
673 * ctf-impl.h: (struct ctf_strs_writable): New, non-const version of
675 (struct ctf_dtdef): Note that dtd_data.ctt_name is unpopulated.
676 (struct ctf_str_atom): New, disambiguated single string.
677 (struct ctf_str_atom_ref): New, points to some other location that
678 references this string's offset.
679 (struct ctf_file): New members ctf_str_atoms and ctf_str_num_refs.
680 Remove member ctf_dtvstrlen: we no longer track the total strlen
682 (ctf_str_create_atoms): Declare new function in ctf-string.c.
683 (ctf_str_free_atoms): Likewise.
684 (ctf_str_add): Likewise.
685 (ctf_str_add_ref): Likewise.
686 (ctf_str_rollback): Likewise.
687 (ctf_str_purge_refs): Likewise.
688 (ctf_str_write_strtab): Likewise.
689 (ctf_realloc): Declare new function in ctf-util.c.
691 * ctf-open.c (ctf_bufopen): Create the atoms table.
692 (ctf_file_close): Destroy it.
693 * ctf-create.c (ctf_update): Copy-and-free it on update. No longer
694 special-case the position of the parname string. Construct the
695 strtab by calling ctf_str_add_ref and ctf_str_write_strtab after the
696 rest of each buffer element is constructed, not via open-coding:
697 realloc the CTF buffer and append the strtab to it. No longer
698 maintain ctf_dtvstrlen. Sort the variable entry table later, after
700 (ctf_copy_membnames): Remove: integrated into ctf_copy_{s,l,e}members.
701 (ctf_copy_smembers): Drop the string offset: call ctf_str_add_ref
702 after buffer element construction instead.
703 (ctf_copy_lmembers): Likewise.
704 (ctf_copy_emembers): Likewise.
705 (ctf_create): No longer maintain the ctf_dtvstrlen.
706 (ctf_dtd_delete): Likewise.
707 (ctf_dvd_delete): Likewise.
708 (ctf_add_generic): Likewise.
709 (ctf_add_enumerator): Likewise.
710 (ctf_add_member_offset): Likewise.
711 (ctf_add_variable): Likewise.
713 * ctf-util.c (ctf_realloc): New, wrapper around realloc that aborts
714 if there are active ctf_str_num_refs.
715 (ctf_strraw): Move to ctf-string.c.
716 (ctf_strptr): Likewise.
717 * ctf-string.c: New file, strtab manipulation.
719 * Makefile.am (libctf_a_SOURCES): Add it.
720 * Makefile.in: Regenerate.
722 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
724 * ctf-impl.h (ctf_hash_iter_f): New.
725 (ctf_dynhash_iter): New declaration.
726 (ctf_dynhash_iter_remove): New declaration.
727 * ctf-hash.c (ctf_dynhash_iter): Define.
728 (ctf_dynhash_iter_remove): Likewise.
729 (ctf_hashtab_traverse): New.
730 (ctf_hashtab_traverse_remove): Likewise.
731 (struct ctf_traverse_cb_arg): Likewise.
732 (struct ctf_traverse_remove_cb_arg): Likewise.
734 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
736 * ctf-hash.c (ctf_dynhash_remove): Call with a mocked-up element.
738 2019-06-28 Nick Alcock <nick.alcock@oracle.com>
740 * ctf-dump.c (ctf_dump_format_type): Prefix hex strings with 0x.
741 (ctf_dump_funcs): Likewise.
743 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
745 * ctf-open-bfd.c: Add swap.h and ctf-endian.h.
746 (ctf_fdopen): Check for endian-swapped raw CTF magic, and
747 little-endian CTF archive magic. Do not check the CTF version:
748 ctf_simple_open does that in endian-safe ways. Do not dereference
749 null pointers on open failure.
751 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
753 * ctf-open.c (get_vbytes_common): Return the new slice size.
754 (ctf_bufopen): Flip the endianness of the CTF-section header copy.
755 Remember to copy in the CTF data when opening an uncompressed
756 foreign-endian CTF file. Prune useless variable manipulation.
758 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
760 * ctf-open.c (ctf_types): Fail when unidentified type kinds are
763 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
765 * ctf-open.c (ctf_bufopen): Dump header offsets into the debugging
768 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
770 * ctf-subr.c (_PAGESIZE): Remove.
771 (ctf_data_alloc): Likewise.
772 (ctf_data_free): Likewise.
773 (ctf_data_protect): Likewise.
774 * ctf-impl.h: Remove declarations.
775 * ctf-create.c (ctf_update): No longer call ctf_data_protect: use
776 ctf_free, not ctf_data_free.
777 (ctf_compress_write): Use ctf_data_alloc, not ctf_alloc. Free
778 the buffer again on compression error.
779 * ctf-open.c (ctf_set_base): No longer track the size: call
780 ctf_free, not ctf_data_free.
781 (upgrade_types): Likewise. Call ctf_alloc, not ctf_data_alloc.
782 (ctf_bufopen): Likewise. No longer call ctf_data_protect.
784 2019-06-19 Nick Alcock <nick.alcock@oracle.com>
786 * ctf-create.c (ctf_dtd_insert): Pass on error returns from
788 (ctf_dvd_insert): Likewise.
789 (ctf_add_generic): Likewise.
790 (ctf_add_variable): Likewise.
791 * ctf-impl.h: Adjust declarations.
793 2019-06-14 Alan Modra <amodra@gmail.com>
795 * configure: Regenerate.
797 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
799 * ctf-decls.h: Include <libiberty.h>.
800 * ctf-lookup.c (ctf_lookup_by_name): Call xstrndup(), not strndup().
802 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
804 * ctf-dump.c (ctf_dump_format_type): Cast size_t's used in printf()s.
805 (ctf_dump_objts): Likewise.
806 (ctf_dump_funcs): Likewise.
807 (ctf_dump_member): Likewise.
808 (ctf_dump_str): Likewise.
810 2019-06-06 Nick Alcock <nick.alcock@oracle.com>
812 * ctf-archive.c (arc_mmap_header): Mark fd as potentially unused.
813 * ctf-subr.c (ctf_data_protect): Mark both args as potentially unused.
815 2019-06-05 Nick Alcock <nick.alcock@oracle.com>
817 * ctf-archive.c (ctf_arc_write): Eschew %zi format specifier.
818 (ctf_arc_open_by_offset): Likewise.
819 * ctf-create.c (ctf_add_type): Likewise.
821 2019-06-04 Tom Tromey <tromey@adacore.com>
823 * ctf-create.c (ctf_add_encoded, ctf_add_slice)
824 (ctf_add_member_offset): Use CHAR_BIT, not NBBY.
826 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
828 * configure.ac: Check for O_CLOEXEC.
829 * ctf-decls.h (O_CLOEXEC): Define (to 0), if need be.
830 * config.h.in: Regenerate.
831 * configure: Likewise.
833 2019-06-04 Nick Alcock <nick.alcock@oracle.com>
835 * qsort_r.c: Rename to...
836 * ctf-qsort_r.c: ... this.
837 (_quicksort): Define to ctf_qsort_r.
838 * ctf-decls.h (qsort_r): Remove.
840 (struct ctf_qsort_arg): New, transport the real ARG and COMPAR.
841 (ctf_qsort_compar_thunk): Rearrange the arguments to COMPAR.
842 * Makefile.am (libctf_a_LIBADD): Remove.
843 (libctf_a_SOURCES): New, add ctf-qsort_r.c.
844 * ctf-archive.c (ctf_arc_write): Call ctf_qsort_r, not qsort_r.
845 * ctf-create.c (ctf_update): Likewise.
846 * configure.ac: Check for BSD versus GNU qsort_r signature.
847 * Makefile.in: Regenerate.
848 * config.h.in: Likewise.
849 * configure: Likewise.
851 2019-06-03 Nick Alcock <nick.alcock@oracle.com>
853 * ctf-dump.c (ctf_dump_funcs): Free in the right place.
855 2019-05-29 Nick Alcock <nick.alcock@oracle.com>
857 * Makefile.am (ZLIB): New.
859 (AM_CFLAGS): Use them.
860 (libctf_a_LIBADD): New, for LIBOBJS.
861 * configure.ac: Check for zlib, endian.h, and qsort_r.
862 * ctf-endian.h: New, providing htole64 and le64toh.
863 * swap.h: Code style fixes.
864 (bswap_identity_64): New.
865 * qsort_r.c: New, from gnulib (with one added #include).
866 * ctf-decls.h: New, providing a conditional qsort_r declaration,
867 and unconditional definitions of MIN and MAX.
868 * ctf-impl.h: Use it. Do not use <sys/errno.h>.
869 (ctf_set_errno): Now returns unsigned long.
870 * ctf-util.c (ctf_set_errno): Adjust here too.
871 * ctf-archive.c: Use ctf-endian.h.
872 (ctf_arc_open_by_offset): Use memset, not bzero. Drop cts_type,
873 cts_flags and cts_offset.
874 (ctf_arc_write): Drop debugging dependent on the size of off_t.
875 * ctf-create.c: Provide a definition of roundup if not defined.
876 (ctf_create): Drop cts_type, cts_flags and cts_offset.
877 (ctf_add_reftype): Do not check if type IDs are below zero.
878 (ctf_add_slice): Likewise.
879 (ctf_add_typedef): Likewise.
880 (ctf_add_member_offset): Cast error-returning ssize_t's to size_t
881 when known error-free. Drop CTF_ERR usage for functions returning
883 (ctf_add_member_encoded): Drop CTF_ERR usage for functions returning
885 (ctf_add_variable): Likewise.
889 (ctf_add_type): Likewise. Cast error-returning ssize_t's to size_t
890 when known error-free.
891 * ctf-dump.c (ctf_is_slice): Drop CTF_ERR usage for functions
892 returning int: use CTF_ERR for functions returning ctf_type_id.
893 (ctf_dump_label): Likewise.
894 (ctf_dump_objts): Likewise.
895 * ctf-labels.c (ctf_label_topmost): Likewise.
896 (ctf_label_iter): Likewise.
897 (ctf_label_info): Likewise.
898 * ctf-lookup.c (ctf_func_args): Likewise.
899 * ctf-open.c (upgrade_types): Cast to size_t where appropriate.
900 (ctf_bufopen): Likewise. Use zlib types as needed.
901 * ctf-types.c (ctf_member_iter): Drop CTF_ERR usage for functions
903 (ctf_enum_iter): Likewise.
904 (ctf_type_size): Likewise.
905 (ctf_type_align): Likewise. Cast to size_t where appropriate.
906 (ctf_type_kind_unsliced): Likewise.
907 (ctf_type_kind): Likewise.
908 (ctf_type_encoding): Likewise.
909 (ctf_member_info): Likewise.
910 (ctf_array_info): Likewise.
911 (ctf_enum_value): Likewise.
912 (ctf_type_rvisit): Likewise.
913 * ctf-open-bfd.c (ctf_bfdopen): Drop cts_type, cts_flags and
915 (ctf_simple_open): Likewise.
916 (ctf_bfdopen_ctfsect): Likewise. Set cts_size properly.
917 * Makefile.in: Regenerate.
918 * aclocal.m4: Likewise.
919 * config.h: Likewise.
920 * configure: Likewise.
922 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
924 * configure.in: Check for bfd_section_from_elf_index.
925 * configure: Regenerate.
926 * config.h.in [HAVE_BFD_ELF]: Likewise.
927 * libctf/ctf_open_bfd (ctf_bfdopen_ctfsect): Use it.
928 abfd is potentially unused now.
930 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
933 * Makefile.in: Regenerated.
934 * config.h.in: Likewise.
935 * aclocal.m4: Likewise.
936 * configure: Likewise.
938 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
942 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
946 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
948 * ctf-impl.h (_libctf_version): New declaration.
949 * ctf-subr.c (_libctf_version): Define it.
952 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
954 * ctf-create.c (enumcmp): New.
958 (ctf_add_type): Likewise.
960 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
962 * ctf-lookup.c (isqualifier): New.
963 (ctf_lookup_by_name): Likewise.
964 (struct ctf_lookup_var_key): Likewise.
965 (ctf_lookup_var): Likewise.
966 (ctf_lookup_variable): Likewise.
967 (ctf_lookup_symbol_name): Likewise.
968 (ctf_lookup_by_symbol): Likewise.
969 (ctf_func_info): Likewise.
970 (ctf_func_args): Likewise.
972 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
974 * ctf-decl.c: New file.
975 * ctf-types.c: Likewise.
976 * ctf-impl.h: New declarations.
978 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
980 * ctf-open-bfd.c: New file.
981 * ctf-open.c (ctf_close): New.
982 * ctf-impl.h: Include bfd.h.
983 (ctf_file): New members ctf_data_mmapped, ctf_data_mmapped_len.
984 (ctf_archive_internal): New members ctfi_abfd, ctfi_data,
986 (ctf_bfdopen_ctfsect): New declaration.
987 (_CTF_SECTION): likewise.
989 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
991 * ctf-archive.c: New.
992 * ctf-impl.h (ctf_archive_internal): New type.
993 (ctf_arc_open_internal): New declaration.
994 (ctf_arc_bufopen): Likewise.
995 (ctf_arc_close_internal): Likewise.
997 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
999 * ctf-open.c: New file.
1002 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1004 * ctf-create.c: New file.
1005 * ctf-lookup.c: New file.
1007 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1009 * ctf-impl.h: New definitions and declarations for type creation
1012 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1014 * ctf-hash.c: New file.
1015 * ctf-impl.h: New declarations.
1017 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1019 * ctf-error.c: New file.
1021 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1023 * ctf-util.c: New file.
1025 * ctf-impl.h: Include it, and add declarations.
1027 2019-05-28 Nick Alcock <nick.alcock@oracle.com>
1029 * ctf-impl.h: New file.
1030 * ctf-subr.c: New file.
1037 version-control: never