Introduce program_space::add_objfile
authorTom Tromey <tom@tromey.com>
Fri, 1 Nov 2019 22:31:28 +0000 (16:31 -0600)
committerTom Tromey <tom@tromey.com>
Thu, 12 Dec 2019 22:50:52 +0000 (15:50 -0700)
commit7cac64af7bc6a7f7a86f90a1465f7c3d2b6f07e8
tree0ecbee9d6d1b2c03b4a49bc551ae11ade6b1c1b0
parent268e4f09144c48e02f01d82ab3aab359457df214
Introduce program_space::add_objfile

This introduces a new method, program_space::add_objfile, that adds an
objfile to the program space's list of objfiles.  It also changes the
obfile's constructor so that linking an objfile into this list is not
done here.

The former is an improvement because it makes more sense to treat the
program space as a container holding objfiles -- so manipulation of
the list belongs there.

The latter is not strictly needed, but seemed better both because it
is removing a global side effect from a constructor, and for symmetry
reasons, as a subsequent patch will remove unlinking from the
destructor.

gdb/ChangeLog
2019-12-12  Tom Tromey  <tom@tromey.com>

* progspace.h (struct program_space) <add_objfile>: Declare
method.
* progspace.c (program_space::add_objfile): New method.
* objfiles.c (~objfile): Don't unlink objfile.
(put_objfile_before): Remove.
(add_separate_debug_objfile): Don't call put_objfile_before.
(objfile::make): Call add_objfile.  Set new_objfiles_available on
the per-program-space data.

Change-Id: I93e8525dda631cb89dcc2046a5c51c7c9f34ccfd
gdb/ChangeLog
gdb/objfiles.c
gdb/progspace.c
gdb/progspace.h
This page took 0.024549 seconds and 4 git commands to generate.