Skip tests that use cd for remote hosts
authorLuis Machado <lgustavo@codesourcery.com>
Thu, 30 Oct 2014 11:48:10 +0000 (09:48 -0200)
committerLuis Machado <lgustavo@codesourcery.com>
Thu, 30 Oct 2014 11:48:10 +0000 (09:48 -0200)
Several GDB tests change directory before compiling the test program
in order to test source file names that include directories.  This
doesn't work on a remote host because default_target_compile in
DejaGnu's target.exp copies each source file with
"[remote_download host $x]" which uses "[file tail $file] to strip
off the directory of each file.  If the source directory is remote
mounted on the host, this also leaves copied files in the source
directory.

A similar skip is already used in gdb.test/fullname.exp:

    # We rely on being able to copy things around.

    if { [is_remote host] } {
untested "setting breakpoints by full path"
return -1
    }

This patch causes three GDB tests that use "cd" to be skipped for a
remote host.  For gdb.base/fullpath-expand.exp this eliminates two
failures and prevents the test from leaving files fullpath-expand.c
and fullpath-expand-func.c in gdb/testsuite.  For
gdb.base/realname-expand.exp it eliminates two failures.  For
gdb.linespec/macro-relative.exp it prevents file macro-relative.c
from being left in gdb/testsuite/gdb.linespec/base/two.

gdb/testsuite/

* gdb.base/fullpath-expand.exp: Skip for a remote host.
* gdb.base/realname-expand.exp: Likewise.
* gdb.linespec/macro-relative.exp: Likewise.

gdb/testsuite/ChangeLog
gdb/testsuite/gdb.base/fullpath-expand.exp
gdb/testsuite/gdb.base/realname-expand.exp
gdb/testsuite/gdb.linespec/macro-relative.exp

index e4a2bf62b5968b3459338a518d5f7311ff260de4..0139f4c0b1019105a549bf6db546ac0e53741db5 100644 (file)
@@ -1,3 +1,9 @@
+2014-10-30  Janis Johnson  <janisjo@codesourcery.com>
+
+       * gdb.base/fullpath-expand.exp: Skip for a remote host.
+       * gdb.base/realname-expand.exp: Likewise.
+       * gdb.linespec/macro-relative.exp: Likewise.
+
 2014-10-29  Pedro Alves  <palves@redhat.com>
 
        PR gdb/17408
index 949f3fc8937fbb03791f221997162ba4eb45906c..213b4c5127de999fa013a48c2247524446289f95 100644 (file)
 
 standard_testfile .c fullpath-expand-func.c
 
+if [is_remote host] {
+    unsupported "Compiling on a remote host does not support a filename with directory."
+    return 0
+}
+
 if { [file pathtype $objdir] != "absolute" } {
     untested "objdir $objdir is not absolute"
     return -1
index 52c37b07b16cec6ecd10188f9081c334bd9d72e1..7fd66f442fea7b6ce66e77498f3c9fd54d023bca 100644 (file)
 
 standard_testfile .c realname-expand-real.c
 
+if [is_remote host] {
+    unsupported "Compiling on a remote host does not support a filename with directory."
+    return 0
+}
+
 set srcdirabs [file join [pwd] $srcdir]
 set srcfilelink [standard_output_file realname-expand-link.c]
 
index c160877177e1669895d3c5a5e8d36e964c5c8b78..c1506a9ade775f89bca6e12f3426e98ce1bba8f7 100644 (file)
@@ -21,6 +21,11 @@ if [using_fission] {
     return -1
 }
 
+if [is_remote host] {
+    unsupported "Compiling on a remote host does not support a filename with directory."
+    return 0
+}
+
 set opts {debug additional_flags=-I.}
 
 get_compiler_info
This page took 0.03135 seconds and 4 git commands to generate.