gdbserver: simply copy the pointer in 'set_target_ops'

The 'set_target_ops' function takes a target op vector and creates a
clone of it via XNEW and memcpy.  This is not necessary.  'the_target'
is a singleton, and the argument that is passed to 'set_target_ops' is
always the address of a global, static object.  Therefore, update the
implementation to simply copy the pointer.

gdbserver/ChangeLog:
2020-02-20  Pedro Alves  <palves@redhat.com>

	* target.cc (set_target_ops): Simply copy the given target pointer
	instead of creating a copy of the pointed object.

diff --git a/gdbserver/ChangeLog b/gdbserver/ChangeLog
index 1cd9c91a8d32b29ef38577360969207cee5124e6..50528153c545971ebf7b5b801459f9dbd8ddd031 100644 (file)
--- a/gdbserver/ChangeLog
+++ b/gdbserver/ChangeLog
@@ -1,3 +1,8 @@
+2020-02-20  Pedro Alves  <palves@redhat.com>
+
+       * target.cc (set_target_ops): Simply copy the given target pointer
+       instead of creating a copy of the pointed object.
+
 2020-02-20  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 
        Turn process_stratum_target's get_ipa_tdesc_idx op into a method

diff --git a/gdbserver/target.cc b/gdbserver/target.cc
index 4df1f9d4bd8cd3bd2a3471e5eb729a9d6bcdd971..d0a7d36c86822959b4a4fd7a49297602bedb1aad 100644 (file)
--- a/gdbserver/target.cc
+++ b/gdbserver/target.cc
@@ -270,8 +270,7 @@ target_supports_multi_process (void)
 void
 set_target_ops (process_stratum_target *target)
 {
-  the_target = XNEW (process_stratum_target);
-  memcpy (the_target, target, sizeof (*the_target));
+  the_target = target;
 }
 
 /* Convert pid to printable format.  */