exceptions.c:print_flush: Remove obsolete check

Commit 20f0d60db4fb ("Avoid crash when calling warning too early"),
added a "current_top_target () != NULL" check to
target_supports_terminal_ours, so this check in exceptions.c is now
obsolete.

gdb/ChangeLog:
2020-01-10  Pedro Alves  <palves@redhat.com>

	* exceptions.c (print_flush): Remove current_top_target() check.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index af46e69fb305d768d59050aa716724290b7e1257..1100e421414d7719d9e0e7f6ce4588d245705914 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2020-01-10  Pedro Alves  <palves@redhat.com>
+
+       * exceptions.c (print_flush): Remove current_top_target() check.
+
 2020-01-10  Pedro Alves  <palves@redhat.com>
 
        * remote.c (show_remote_exec_file): Show the current inferior's

diff --git a/gdb/exceptions.c b/gdb/exceptions.c
index 587988ac803f501d4c8d89b2228a9cf4d7ea15b8..52cee4e2f6d73ecdfadde9db9c44f7cc1da26b2a 100644 (file)
--- a/gdb/exceptions.c
+++ b/gdb/exceptions.c
@@ -39,11 +39,7 @@ print_flush (void)
     deprecated_error_begin_hook ();
 
   gdb::optional<target_terminal::scoped_restore_terminal_state> term_state;
-  /* While normally there's always something pushed on the target
-     stack, the NULL check is needed here because we can get here very
-     early during startup, before the target stack is first
-     initialized.  */
-  if (current_top_target () != NULL && target_supports_terminal_ours ())
+  if (target_supports_terminal_ours ())
     {
       term_state.emplace ();
       target_terminal::ours_for_output ();