Usage of unitialized heap in tic4x_print_cond

	PR 25319
	* tic4x-dis.c (tic4x_print_cond): Init all of condtable.

diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog
index 9a1512304270b09c101b564c2ce7d2e89d544569..5187fb2176927e2172ccd87d3682de415525f5de 100644 (file)
--- a/opcodes/ChangeLog
+++ b/opcodes/ChangeLog
@@ -1,3 +1,8 @@
+2019-12-29  Alan Modra  <amodra@gmail.com>
+
+       PR 25319
+       * tic4x-dis.c (tic4x_print_cond): Init all of condtable.
+
 2019-12-27  Jan Beulich  <jbeulich@suse.com>
 
        * i386-dis.c (Jdqw): Define.

diff --git a/opcodes/tic4x-dis.c b/opcodes/tic4x-dis.c
index d9f95c94106a5ccb98431c43de8f4db09dbd6717..01cfa1e060ff8258a079c55b2aab00ee585f12ad 100644 (file)
--- a/opcodes/tic4x-dis.c
+++ b/opcodes/tic4x-dis.c
@@ -277,7 +277,7 @@ tic4x_print_cond (struct disassemble_info *info, unsigned int cond)
 
   if (condtable == NULL)
     {
-      condtable = xmalloc (sizeof (tic4x_cond_t *) * 32);
+      condtable = xcalloc (sizeof (tic4x_cond_t *), 32);
       for (i = 0; i < tic4x_num_conds; i++)
        condtable[tic4x_conds[i].cond] = (tic4x_cond_t *)(tic4x_conds + i);
     }