aarch64 disassembler infinite loop

Assembling this to an object and trying to disassemble results in
objdump -d looping forever.

 .inst 0x45205120

	PR 25270
	* aarch64-dis.c (aarch64_decode_variant_using_iclass): Return
	false when field is zero for sve_size_tsz_bhs.

diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog
index de76accd54238dcbb49b742f68273ba956af21f2..3460b3e2d605e7a8eceabe44afb4c4beecf046b5 100644 (file)
--- a/opcodes/ChangeLog
+++ b/opcodes/ChangeLog
@@ -1,3 +1,9 @@
+2019-12-11  Alan Modra  <amodra@gmail.com>
+
+       PR 25270
+       * aarch64-dis.c (aarch64_decode_variant_using_iclass): Return
+       false when field is zero for sve_size_tsz_bhs.
+
 2019-12-11  Alan Modra  <amodra@gmail.com>
 
        * epiphany-ibld.c: Regenerate.

diff --git a/opcodes/aarch64-dis.c b/opcodes/aarch64-dis.c
index 930056981385987d0428eed2b3022cf65bdde6b7..8b32097a5fa116d728e7e70b15be11534740c843 100644 (file)
--- a/opcodes/aarch64-dis.c
+++ b/opcodes/aarch64-dis.c
@@ -2843,6 +2843,8 @@ aarch64_decode_variant_using_iclass (aarch64_inst *inst)
 
     case sve_size_tsz_bhs:
       i = extract_fields (inst->value, 0, 2, FLD_SVE_sz, FLD_SVE_tszl_19);
+      if (i == 0)
+       return FALSE;
       while (i != 1)
        {
          if (i & 1)