Fix leftover remote test failures from PR binutils/19020

As pointed out in PR binutils/19020, those tests were still failing when doing
remote testing. This is because the binary files weren't being copied over to
the remote host for testing.

FAIL: binutils-all/pr19020a
FAIL: binutils-all/pr19020b

This small patch fixes this up to make things pass.

binutils/ChangeLog:
2016-10-14  Luis Machado  <lgustavo@codesourcery.com>

	* testsuite/lib/utils-lib.exp (run_dump_test): Call remote_download
	to copy file to remote host.

diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index a4cbad68c3ea9fd4b8593a9c2203fe129435ab7e..6bd65d7749b8dac3698a8611c5ab664998e77b5f 100644 (file)
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,8 @@
+2016-10-14  Luis Machado  <lgustavo@codesourcery.com>
+
+       * testsuite/lib/utils-lib.exp (run_dump_test): Call remote_download
+       to copy file to remote host.
+
 2016-10-11  Nick Clifton  <nickc@redhat.com>
 
        * objdump.c (is_significant_symbol_name): New function.

diff --git a/binutils/testsuite/lib/utils-lib.exp b/binutils/testsuite/lib/utils-lib.exp
index 6d2de5daef0bbbe15f8c82ffda99eafd94ebd794..b93da51702a1c1801b1587dbef8a3bd7fffd25cf 100644 (file)
--- a/binutils/testsuite/lib/utils-lib.exp
+++ b/binutils/testsuite/lib/utils-lib.exp
@@ -464,7 +464,8 @@ proc run_dump_test { name {extra_options {}} } {
            }
            set srcfile $newfile
        }
-       file copy -force ${srcfile} $tempfile
+       # Make sure we copy the file if we are doing remote host testing.
+       remote_download host ${srcfile} $tempfile
     } else {
        set exec_output [binutils_assemble_flags ${srcfile} $tempfile $opts(as)]
        if [string match "" $exec_output] then {