[media] v4l2-mc: remove the unused sensor var
authorMauro Carvalho Chehab <mchehab@osg.samsung.com>
Fri, 12 Feb 2016 10:07:59 +0000 (08:07 -0200)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Tue, 16 Feb 2016 10:55:58 +0000 (08:55 -0200)
This fixes this warning:

v4l2-mc.c: In function 'v4l2_mc_create_media_graph':
v4l2-mc.c:60:69: warning: variable 'sensor' set but not used [-Wunused-but-set-variable]

We could solve it the other way: don't do the second loop for
webcams. However, that would fail if a chip would have two sensors
plugged. This is not the current case, but it doesn't hurt to be
future-safe here, specially since this code runs only once during
device probe. So, performance is not an issue here.

Reported-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/v4l2-core/v4l2-mc.c

index 97b2e1e64d2eb008a1340cba0b0fbb8580abfa15..9d79d599d97931f1a95439d13c56cff273223a69 100644 (file)
@@ -96,7 +96,7 @@ int v4l2_mc_create_media_graph(struct media_device *mdev)
 
 {
        struct media_entity *entity;
-       struct media_entity *if_vid = NULL, *if_aud = NULL, *sensor = NULL;
+       struct media_entity *if_vid = NULL, *if_aud = NULL;
        struct media_entity *tuner = NULL, *decoder = NULL;
        struct media_entity *io_v4l = NULL, *io_vbi = NULL, *io_swradio = NULL;
        bool is_webcam = false;
@@ -130,7 +130,6 @@ int v4l2_mc_create_media_graph(struct media_device *mdev)
                        io_swradio = entity;
                        break;
                case MEDIA_ENT_F_CAM_SENSOR:
-                       sensor = entity;
                        is_webcam = true;
                        break;
                }
This page took 0.026069 seconds and 5 git commands to generate.