drm: i915: Explicitly apply PWM config extracted from pwm_args
authorBoris Brezillon <boris.brezillon@free-electrons.com>
Thu, 14 Apr 2016 19:17:35 +0000 (21:17 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Tue, 17 May 2016 12:45:07 +0000 (14:45 +0200)
Call pwm_apply_args() just after requesting the PWM device so that the
polarity and period are initialized according to the information
provided in pwm_args.

This is an intermediate state, and pwm_apply_args() should be dropped as
soon as the atomic PWM infrastructure is in place and the driver makes
use of it.

Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/gpu/drm/i915/intel_panel.c

index 21ee6477bf98d1fe7974f90e76369adb57cbcc83..dc3a2e4f74c2bc27b7f0a4debd3a15fbd39d3ea9 100644 (file)
@@ -1640,6 +1640,12 @@ static int pwm_setup_backlight(struct intel_connector *connector,
                return -ENODEV;
        }
 
+       /*
+        * FIXME: pwm_apply_args() should be removed when switching to
+        * the atomic PWM API.
+        */
+       pwm_apply_args(panel->backlight.pwm);
+
        retval = pwm_config(panel->backlight.pwm, CRC_PMIC_PWM_PERIOD_NS,
                            CRC_PMIC_PWM_PERIOD_NS);
        if (retval < 0) {
This page took 0.025338 seconds and 5 git commands to generate.