[media] pt3: fix device identification
authorMauro Carvalho Chehab <mchehab@osg.samsung.com>
Sat, 27 Feb 2016 10:51:11 +0000 (07:51 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Tue, 1 Mar 2016 15:01:45 +0000 (12:01 -0300)
As warned by smatch:
drivers/media/pci/pt3/pt3.c:398 pt3_attach_fe() error: strncmp() '"tc90522sat"' too small (11 vs 20)

Clearly, the logic is doing the wrong thing, as it is not comparing the strings
on the right way.

Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/pci/pt3/pt3.c

index 0d2e2b21712124ad832b48cff515b7339b43db11..eff5e9f51ace3d0d8a94df94d5bcce592fff81bf 100644 (file)
@@ -395,7 +395,8 @@ static int pt3_attach_fe(struct pt3_board *pt3, int i)
        if (!try_module_get(cl->dev.driver->owner))
                goto err_demod_i2c_unregister_device;
 
-       if (!strncmp(cl->name, TC90522_I2C_DEV_SAT, sizeof(cl->name))) {
+       if (!strncmp(cl->name, TC90522_I2C_DEV_SAT,
+                    strlen(TC90522_I2C_DEV_SAT))) {
                struct qm1d1c0042_config tcfg;
 
                tcfg = adap_conf[i].tuner_cfg.qm1d1c0042;
This page took 0.026059 seconds and 5 git commands to generate.