xen-blkback: advertise indirect segment support earlier
authorJan Beulich <JBeulich@suse.com>
Wed, 10 Feb 2016 11:18:10 +0000 (04:18 -0700)
committerJens Axboe <axboe@fb.com>
Thu, 3 Mar 2016 21:45:53 +0000 (14:45 -0700)
There's no reason to defer this until the connect phase, and in fact
there are frontend implementations expecting this to be available
earlier. Move it into the probe function.

Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Cc: Bob Liu <bob.liu@oracle.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
drivers/block/xen-blkback/xenbus.c

index 876763f7f13e1a77f8f64738de967c1f21815440..16e28ee880a40aa7ef904d34dd7e0a0f96ae17b6 100644 (file)
@@ -618,6 +618,14 @@ static int xen_blkbk_probe(struct xenbus_device *dev,
                goto fail;
        }
 
+       err = xenbus_printf(XBT_NIL, dev->nodename,
+                           "feature-max-indirect-segments", "%u",
+                           MAX_INDIRECT_SEGMENTS);
+       if (err)
+               dev_warn(&dev->dev,
+                        "writing %s/feature-max-indirect-segments (%d)",
+                        dev->nodename, err);
+
        /* Multi-queue: advertise how many queues are supported by us.*/
        err = xenbus_printf(XBT_NIL, dev->nodename,
                            "multi-queue-max-queues", "%u", xenblk_max_queues);
@@ -849,11 +857,6 @@ again:
                                 dev->nodename);
                goto abort;
        }
-       err = xenbus_printf(xbt, dev->nodename, "feature-max-indirect-segments", "%u",
-                           MAX_INDIRECT_SEGMENTS);
-       if (err)
-               dev_warn(&dev->dev, "writing %s/feature-max-indirect-segments (%d)",
-                        dev->nodename, err);
 
        err = xenbus_printf(xbt, dev->nodename, "sectors", "%llu",
                            (unsigned long long)vbd_sz(&be->blkif->vbd));
This page took 0.02598 seconds and 5 git commands to generate.