gpio: mpc8xxx: Do not use gpiochip_get_data() in mpc8xxx_gpio_save_regs()
authorGuenter Roeck <linux@roeck-us.net>
Thu, 7 Jan 2016 16:25:24 +0000 (08:25 -0800)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 13 Jan 2016 09:22:23 +0000 (10:22 +0100)
Commit 709d71a17c33 ("gpio: mpc8xxx: use gpiochip data pointer") replaces
the use of container_of() with gpiochip_get_data(). However, the data
pointer is not yet set by the time the save_regs function is called.

Fixes: 709d71a17c33 ("gpio: mpc8xxx: use gpiochip data pointer")
Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: Alexander Stein <alexander.stein@systec-electronic.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-mpc8xxx.c

index 21eff0e1df873f6b2c8219d1d2a331bb02598c3b..9d40787e66c02970783e87f046f30846d789e58d 100644 (file)
@@ -51,7 +51,8 @@ static inline u32 mpc8xxx_gpio2mask(unsigned int gpio)
 
 static void mpc8xxx_gpio_save_regs(struct of_mm_gpio_chip *mm)
 {
-       struct mpc8xxx_gpio_chip *mpc8xxx_gc = gpiochip_get_data(&mm->gc);
+       struct mpc8xxx_gpio_chip *mpc8xxx_gc =
+               container_of(mm, struct mpc8xxx_gpio_chip, mm_gc);
 
        mpc8xxx_gc->data = in_be32(mm->regs + GPIO_DAT);
 }
This page took 0.026458 seconds and 5 git commands to generate.