efi: Update stale locking comment for struct efivars
authorMatt Fleming <matt.fleming@intel.com>
Tue, 8 Jul 2014 11:28:33 +0000 (12:28 +0100)
committerMatt Fleming <matt.fleming@intel.com>
Fri, 18 Jul 2014 20:24:00 +0000 (21:24 +0100)
The comment describing how struct efivars->lock is used hasn't been
updated in sync with the code. Fix it.

Reported-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Mike Waychison <mikew@google.com>
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
include/linux/efi.h

index 59c8acfebca79710b11ee35b28bee5cfc60119dc..efc681fd58956a33a4590e13b60de3dd242a24c3 100644 (file)
@@ -1040,12 +1040,8 @@ struct efivar_operations {
 struct efivars {
        /*
         * ->lock protects two things:
-        * 1) ->list - adds, removals, reads, writes
-        * 2) ops.[gs]et_variable() calls.
-        * It must not be held when creating sysfs entries or calling kmalloc.
-        * ops.get_next_variable() is only called from register_efivars()
-        * or efivar_update_sysfs_entries(),
-        * which is protected by the BKL, so that path is safe.
+        * 1) efivarfs_list and efivars_sysfs_list
+        * 2) ->ops calls
         */
        spinlock_t lock;
        struct kset *kset;
This page took 0.02708 seconds and 5 git commands to generate.