x86/microcode: Remove unnecessary paravirt_enabled check
authorBoris Ostrovsky <boris.ostrovsky@oracle.com>
Tue, 16 Feb 2016 08:43:19 +0000 (09:43 +0100)
committerIngo Molnar <mingo@kernel.org>
Wed, 17 Feb 2016 07:46:07 +0000 (08:46 +0100)
Commit:

  a18a0f6850d4 ("x86, microcode: Don't initialize microcode code on paravirt")

added a paravirt test in microcode_init(), primarily to avoid making
mc_bp_resume()->load_ucode_ap()->check_loader_disabled_ap() calls
because on 32-bit kernels this callchain ends up using __pa_nodebug()
macro which is invalid for Xen PV guests.

A subsequent commit:

  fbae4ba8c4a3 ("x86, microcode: Reload microcode on resume")

eliminated this callchain thus making a18a0f6850d4 unnecessary.

Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: david.vrabel@citrix.com
Cc: konrad.wilk@oracle.com
Cc: xen-devel@lists.xenproject.org
Link: http://lkml.kernel.org/r/1455612202-14414-2-git-send-email-bp@alien8.de
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/kernel/cpu/microcode/core.c

index cea8552e2b3abf2ec2040379886c5e33ec19b32f..ac360bfbbdb6d98af9ffbee6fb6a751d936a5da1 100644 (file)
@@ -623,7 +623,7 @@ int __init microcode_init(void)
        struct cpuinfo_x86 *c = &boot_cpu_data;
        int error;
 
-       if (paravirt_enabled() || dis_ucode_ldr)
+       if (dis_ucode_ldr)
                return -EINVAL;
 
        if (c->x86_vendor == X86_VENDOR_INTEL)
This page took 0.0281 seconds and 5 git commands to generate.