net: mediatek: check device_reset return code
authorArnd Bergmann <arnd@arndb.de>
Mon, 14 Mar 2016 14:07:12 +0000 (15:07 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 14 Mar 2016 17:06:27 +0000 (13:06 -0400)
The device_reset() function may fail, so we have to check
its return value, e.g. to make deferred probing work correctly.
gcc warns about it because of the warn_unused_result attribute:

drivers/net/ethernet/mediatek/mtk_eth_soc.c: In function 'mtk_probe':
drivers/net/ethernet/mediatek/mtk_eth_soc.c:1679:2: error: ignoring return value of 'device_reset', declared with attribute warn_unused_result [-Werror=unused-result]

This adds the trivial error check to propagate the return value
to the generic platform device probe code.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mediatek/mtk_eth_soc.c

index 87f417712da02bfd1a14548f6048d742bceeb794..1e6c5498bba9fcafce0cc6acf8b9c157f64d5aa9 100644 (file)
@@ -1676,7 +1676,9 @@ static int mtk_probe(struct platform_device *pdev)
        struct mtk_eth *eth;
        int err;
 
-       device_reset(&pdev->dev);
+       err = device_reset(&pdev->dev);
+       if (err)
+               return err;
 
        match = of_match_device(of_mtk_match, &pdev->dev);
        soc = (struct mtk_soc_data *)match->data;
This page took 0.024827 seconds and 5 git commands to generate.