mic: remove unused function arg
authorArnd Bergmann <arnd@arndb.de>
Thu, 16 Jun 2016 11:38:24 +0000 (13:38 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 30 Aug 2016 12:45:50 +0000 (14:45 +0200)
When building with W=1, the __scif_rma_destroy_tcw function
causes a harmless warning about an argument variable that is
modified but not used:

drivers/misc/mic/scif/scif_dma.c: In function ‘__scif_rma_destroy_tcw’:
drivers/misc/mic/scif/scif_dma.c:118:27: error: parameter ‘ep’ set but not used [-Werror=unused-but-set-parameter]

In this case, we can just remove the argument, since all callers
are in the same file.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/mic/scif/scif_dma.c

index cd01a0efda6b9a4f8710ab3ad94a24f060a9fba1..64d5760d069ab3887682e5358f009c9a4767b374 100644 (file)
@@ -115,7 +115,6 @@ int scif_reserve_dma_chan(struct scif_endpt *ep)
  */
 static
 void __scif_rma_destroy_tcw(struct scif_mmu_notif *mmn,
-                           struct scif_endpt *ep,
                            u64 start, u64 len)
 {
        struct list_head *item, *tmp;
@@ -128,7 +127,6 @@ void __scif_rma_destroy_tcw(struct scif_mmu_notif *mmn,
 
        list_for_each_safe(item, tmp, &mmn->tc_reg_list) {
                window = list_entry(item, struct scif_window, list);
-               ep = (struct scif_endpt *)window->ep;
                if (!len)
                        break;
                start_va = window->va_for_temp;
@@ -146,7 +144,7 @@ static void scif_rma_destroy_tcw(struct scif_mmu_notif *mmn, u64 start, u64 len)
        struct scif_endpt *ep = mmn->ep;
 
        spin_lock(&ep->rma_info.tc_lock);
-       __scif_rma_destroy_tcw(mmn, ep, start, len);
+       __scif_rma_destroy_tcw(mmn, start, len);
        spin_unlock(&ep->rma_info.tc_lock);
 }
 
@@ -169,7 +167,7 @@ static void __scif_rma_destroy_tcw_ep(struct scif_endpt *ep)
        spin_lock(&ep->rma_info.tc_lock);
        list_for_each_safe(item, tmp, &ep->rma_info.mmn_list) {
                mmn = list_entry(item, struct scif_mmu_notif, list);
-               __scif_rma_destroy_tcw(mmn, ep, 0, ULONG_MAX);
+               __scif_rma_destroy_tcw(mmn, 0, ULONG_MAX);
        }
        spin_unlock(&ep->rma_info.tc_lock);
 }
This page took 0.027397 seconds and 5 git commands to generate.