powerpc/rtas: Replace magic values with defines
authorThomas Huth <thuth@redhat.com>
Wed, 22 Jul 2015 16:56:47 +0000 (18:56 +0200)
committerMichael Ellerman <mpe@ellerman.id.au>
Thu, 23 Jul 2015 06:27:05 +0000 (16:27 +1000)
rtas.h already has some nice #defines for RTAS return status
codes - let's use them instead of hard-coded "magic" values!

Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/kernel/rtas.c

index 7a488c108410b730f1e4c1fdcb397d513b6b68d9..10fb4024a0ce9aca99f89b2f6ed36c1e9351a41f 100644 (file)
@@ -478,8 +478,9 @@ unsigned int rtas_busy_delay_time(int status)
 
        if (status == RTAS_BUSY) {
                ms = 1;
-       } else if (status >= 9900 && status <= 9905) {
-               order = status - 9900;
+       } else if (status >= RTAS_EXTENDED_DELAY_MIN &&
+                  status <= RTAS_EXTENDED_DELAY_MAX) {
+               order = status - RTAS_EXTENDED_DELAY_MIN;
                for (ms = 1; order > 0; order--)
                        ms *= 10;
        }
@@ -641,7 +642,8 @@ int rtas_set_indicator_fast(int indicator, int index, int new_value)
 
        rc = rtas_call(token, 3, 1, NULL, indicator, index, new_value);
 
-       WARN_ON(rc == -2 || (rc >= 9900 && rc <= 9905));
+       WARN_ON(rc == RTAS_BUSY || (rc >= RTAS_EXTENDED_DELAY_MIN &&
+                                   rc <= RTAS_EXTENDED_DELAY_MAX));
 
        if (rc < 0)
                return rtas_error_rc(rc);
This page took 0.02678 seconds and 5 git commands to generate.