[media] touptek: don't DMA at the stack
authorMauro Carvalho Chehab <mchehab@osg.samsung.com>
Sun, 6 Mar 2016 13:12:32 +0000 (10:12 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Thu, 10 Mar 2016 16:37:45 +0000 (13:37 -0300)
As warned by smatch:
drivers/media/usb/gspca/touptek.c:220 reg_w() error: doing dma on the stack (buff)
drivers/media/usb/gspca/touptek.c:458 configure() error: doing dma on the stack (buff)

This can fail, as the stack may not be in a memory that would
allod DMA. So, use the usb_buf instead.

Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/usb/gspca/touptek.c

index 7bac6bc96063f2eea5fd18159a512541a439dfca..8063b8e45ee595a1d351d03e76797b3dee7697b7 100644 (file)
@@ -211,7 +211,7 @@ static int val_reply(struct gspca_dev *gspca_dev, const char *reply, int rc)
 
 static void reg_w(struct gspca_dev *gspca_dev, u16 value, u16 index)
 {
-       char buff[1];
+       char *buff = gspca_dev->usb_buf;
        int rc;
 
        PDEBUG(D_USBO,
@@ -438,7 +438,7 @@ static void configure_encrypted(struct gspca_dev *gspca_dev)
 static int configure(struct gspca_dev *gspca_dev)
 {
        int rc;
-       uint8_t buff[4];
+       char *buff = gspca_dev->usb_buf;
 
        PDEBUG(D_STREAM, "configure()\n");
 
This page took 0.026321 seconds and 5 git commands to generate.