perf/x86/intel: Handle new arch perfmon v4 status bits
authorAndi Kleen <ak@linux.intel.com>
Sun, 10 May 2015 19:22:45 +0000 (12:22 -0700)
committerIngo Molnar <mingo@kernel.org>
Tue, 4 Aug 2015 08:16:57 +0000 (10:16 +0200)
ArchPerfmon v4 has some new status bits in GLOBAL_STATUS.

These need to be ignored when deciding whether a NMI
was an NMI, to avoid eating all NMIs when they
stay set, see:

    b292d7a10487 ("perf/x86/intel: ignore CondChgd bit to avoid false NMI handling")

This patch ignores the new ASIF bit, which indicates
that SGX interfered with the PMU, and also the new
LBR freezing bits, which are set when the LBRs get
frozen, plus the existing CondChange (set by JTAG
debuggers and some buggy BIOSes)

Signed-off-by: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: eranian@google.com
Link: http://lkml.kernel.org/r/1431285767-27027-8-git-send-email-andi@firstfloor.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/kernel/cpu/perf_event_intel.c

index cb112bffcf7027fb8ebd64f112ecc550f96103a9..52c9ded70f6c77e5f65ddd7e242cdfca4cf0ea7f 100644 (file)
@@ -1611,13 +1611,14 @@ again:
        intel_pmu_lbr_read();
 
        /*
-        * CondChgd bit 63 doesn't mean any overflow status. Ignore
-        * and clear the bit.
+        * Ignore a range of extra bits in status that do not indicate
+        * overflow by themselves.
         */
-       if (__test_and_clear_bit(63, (unsigned long *)&status)) {
-               if (!status)
-                       goto done;
-       }
+       status &= ~(GLOBAL_STATUS_COND_CHG |
+                   GLOBAL_STATUS_ASIF |
+                   GLOBAL_STATUS_LBRS_FROZEN);
+       if (!status)
+               goto done;
 
        /*
         * PEBS overflow sets bit 62 in the global status register
This page took 0.028598 seconds and 5 git commands to generate.