spi: bitbang: remove unneeded check
authorHeiner Kallweit <hkallweit1@gmail.com>
Tue, 29 Sep 2015 21:09:33 +0000 (23:09 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 5 Oct 2015 13:55:55 +0000 (14:55 +0100)
Remove an unneeded check. The SPI core (__spi_validate) takes care
that these fields are always populated.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-bitbang.c

index ef43ef507c9a4e6859c8c1ffd9797eff8b54027f..ad3168dc45e7abe3c2aa045bdba5b939368c09c4 100644 (file)
@@ -272,7 +272,6 @@ static int spi_bitbang_transfer_one(struct spi_master *master,
        struct spi_transfer     *t = NULL;
        unsigned                cs_change;
        int                     status;
-       int                     do_setup = -1;
        struct spi_device       *spi = m->spi;
 
        bitbang = spi_master_get_devdata(master);
@@ -288,19 +287,10 @@ static int spi_bitbang_transfer_one(struct spi_master *master,
 
        list_for_each_entry(t, &m->transfers, transfer_list) {
 
-               /* override speed or wordsize? */
-               if (t->speed_hz || t->bits_per_word)
-                       do_setup = 1;
-
-               /* init (-1) or override (1) transfer params */
-               if (do_setup != 0) {
-                       if (bitbang->setup_transfer) {
-                               status = bitbang->setup_transfer(spi, t);
-                               if (status < 0)
-                                       break;
-                       }
-                       if (do_setup == -1)
-                               do_setup = 0;
+               if (bitbang->setup_transfer) {
+                       status = bitbang->setup_transfer(spi, t);
+                       if (status < 0)
+                               break;
                }
 
                /* set up default clock polarity, and activate chip;
This page took 0.026616 seconds and 5 git commands to generate.