relayd: Don't bypass the fd tracker when closing file descriptors
authorJérémie Galarneau <jeremie.galarneau@efficios.com>
Tue, 19 Jun 2018 16:22:31 +0000 (12:22 -0400)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Tue, 3 Jul 2018 14:40:58 +0000 (10:40 -0400)
There is no reason to close all file descriptors at this point in
the relay daemon as we know for a fact that the only open fds
are stdin, stdout, and stderr. If the relayd was to depend on a
library that opens other file descriptors, it would be unadvisable
to perform this kind of bulk closing of all possible file descriptors.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
src/bin/lttng-relayd/main.c

index c568c2e3fb1d50508484b39a417c294488806873..ab7d914563cd0a8e7a3b016ecb2f7e278ec9ebfc 100644 (file)
@@ -3992,23 +3992,12 @@ int main(int argc, char **argv)
 
        /* Daemonize */
        if (opt_daemon || opt_background) {
-               int i;
-
                ret = lttng_daemonize(&child_ppid, &recv_child_signal,
                        !opt_background);
                if (ret < 0) {
                        retval = -1;
                        goto exit_options;
                }
-
-               /*
-                * We are in the child. Make sure all other file
-                * descriptors are closed, in case we are called with
-                * more opened file descriptors than the standard ones.
-                */
-               for (i = 3; i < sysconf(_SC_OPEN_MAX); i++) {
-                       (void) close(i);
-               }
        }
 
        /*
This page took 0.03001 seconds and 5 git commands to generate.