common.core: annotate String#substring

String.substring always returns a new String or "this".

Change-Id: Id37b8a20489f07b6bfe8a225064d5be1cd4fc7aa
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/69196
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

diff --git a/common/org.eclipse.tracecompass.common.core/annotations/java/lang/String.eea b/common/org.eclipse.tracecompass.common.core/annotations/java/lang/String.eea
index 73b41b1f8a9527d3131e9479d031ca9fd6ca70c1..195acf950f8b37d50ca59250faafee08acf0085b 100644 (file)
--- a/common/org.eclipse.tracecompass.common.core/annotations/java/lang/String.eea
+++ b/common/org.eclipse.tracecompass.common.core/annotations/java/lang/String.eea
@@ -20,6 +20,9 @@ split
 split
  (Ljava/lang/String;I)[Ljava/lang/String;
  (L1java/lang/String;I)[1L1java/lang/String;
+substring
+ (I)Ljava/lang/String;
+ (I)L1java/lang/String;
 substring
  (II)Ljava/lang/String;
  (II)L1java/lang/String;

diff --git a/ctf/org.eclipse.tracecompass.tmf.ctf.core/src/org/eclipse/tracecompass/tmf/ctf/core/event/CtfTmfEventField.java b/ctf/org.eclipse.tracecompass.tmf.ctf.core/src/org/eclipse/tracecompass/tmf/ctf/core/event/CtfTmfEventField.java
index c64c28de1b64594263226b51eb3b0079f20a0a03..f7ebb56ec82adbcf8f88476287ac39a68689c391 100644 (file)
--- a/ctf/org.eclipse.tracecompass.tmf.ctf.core/src/org/eclipse/tracecompass/tmf/ctf/core/event/CtfTmfEventField.java
+++ b/ctf/org.eclipse.tracecompass.tmf.ctf.core/src/org/eclipse/tracecompass/tmf/ctf/core/event/CtfTmfEventField.java
@@ -67,7 +67,7 @@ public abstract class CtfTmfEventField extends TmfEventField {
      */
     protected CtfTmfEventField(@NonNull String name, Object value, ITmfEventField[] fields) {
         super(/* Strip the underscore from the field name if there is one */
-                name.startsWith("_") ? checkNotNull(name.substring(1)) : name, //$NON-NLS-1$
+                name.startsWith("_") ? name.substring(1) : name, //$NON-NLS-1$
                 value,
                 fields);
     }