tmf: Replace Array Loops to copy arrays with System.ArrayCopy

This yields a performance improvement as well as an increase
in legibility.

Change-Id: Ia7be6a54476a8263d8b5e99f203d7fc3cf374a1d
Signed-off-by: Sonia Farrah <sonia.farrah@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/71939
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

diff --git a/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/internal/tmf/ui/project/wizards/importtrace/ImportTraceWizardPage.java b/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/internal/tmf/ui/project/wizards/importtrace/ImportTraceWizardPage.java
index 4bb30025280a62dbc5016d77a0b90d4601e028af..85ebfeb72bcb841e66cc2ac05948d69f7b0b175a 100644 (file)
--- a/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/internal/tmf/ui/project/wizards/importtrace/ImportTraceWizardPage.java
+++ b/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/internal/tmf/ui/project/wizards/importtrace/ImportTraceWizardPage.java
@@ -834,9 +834,7 @@ public class ImportTraceWizardPage extends WizardResourceImportPage {
         String[] availableTraceTypes = TmfTraceType.getAvailableTraceTypes();
         String[] traceTypeList = new String[availableTraceTypes.length + 1];
         traceTypeList[0] = TRACE_TYPE_AUTO_DETECT;
-        for (int i = 0; i < availableTraceTypes.length; i++) {
-            traceTypeList[i + 1] = availableTraceTypes[i];
-        }
+        System.arraycopy(availableTraceTypes, 0, traceTypeList, 1, availableTraceTypes.length);
         fTraceTypes.setItems(traceTypeList);
         fTraceTypes.addSelectionListener(new SelectionAdapter() {
             @Override

diff --git a/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/project/model/TmfTraceElement.java b/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/project/model/TmfTraceElement.java
index 1579dca6f86165d729b754a5891ee23ea7cf57de..68170634a7ee3fd72e326a325860c4995d8dc7b2 100644 (file)
--- a/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/project/model/TmfTraceElement.java
+++ b/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/project/model/TmfTraceElement.java
@@ -478,10 +478,7 @@ public class TmfTraceElement extends TmfCommonProjectElement implements IActionF
                 propertyDescriptorArray[index] = descriptor;
                 index++;
             }
-            for (int i = 0; i < sfDescriptors.length; i++) {
-                propertyDescriptorArray[index] = sfDescriptors[i];
-                index++;
-            }
+            System.arraycopy(sfDescriptors, 0, propertyDescriptorArray, index, sfDescriptors.length);
             return propertyDescriptorArray;
         }
         return Arrays.copyOf(sfDescriptors, sfDescriptors.length);