tmf : use of StringBuilder.append() instead of operator + for strings

Change-Id: Ia0156a18fb2e81db4a375d8c36d34e3ced09d55b
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60536
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

diff --git a/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/internal/tmf/ui/project/handlers/SynchronizeTracesHandler.java b/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/internal/tmf/ui/project/handlers/SynchronizeTracesHandler.java
index dc707f9a2e6e4f5fee69dfcce14c0bb5088a73b7..6cd37a42bc94eee6b05a3c649de54f1ba1da22fc 100644 (file)
--- a/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/internal/tmf/ui/project/handlers/SynchronizeTracesHandler.java
+++ b/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/internal/tmf/ui/project/handlers/SynchronizeTracesHandler.java
@@ -193,19 +193,19 @@ public class SynchronizeTracesHandler extends AbstractHandler {
                                  * Make sure a trace with the new name does not
                                  * exist
                                  */
-                                String newname = traceel.getName();
+                                StringBuilder newname = new StringBuilder(traceel.getName());
                                 IContainer parentFolder = origtrace.getResource().getParent();
                                 boolean traceexists;
                                 do {
                                     traceexists = false;
-                                    newname += "_"; //$NON-NLS-1$
-                                    if (parentFolder.findMember(newname) != null) {
+                                    newname.append('_');
+                                    if (parentFolder.findMember(newname.toString()) != null) {
                                         traceexists = true;
                                     }
                                 } while (traceexists);
 
                                 /* Copy the original trace */
-                                TmfTraceElement newtrace = origtrace.copy(newname);
+                                TmfTraceElement newtrace = origtrace.copy(newname.toString());
                                 if (newtrace == null) {
                                     TraceUtils.displayErrorMsg(Messages.SynchronizeTracesHandler_Title,
                                             Messages.SynchronizeTracesHandler_Error + CR + CR + String.format(Messages.SynchronizeTracesHandler_CopyProblem, origtrace.getName()));