common: Annotate some methods in String

All variants of:

copyValueOf()
format()
intern()
toString()*
valueOf()

return a non-null value, so can be marked as such.

* Do not confound with Object.toString()! That one has no nullness
  guarantees.

Change-Id: Ia739dab7ab294e0c32156bd3b756f4241e97a4a1
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/59163
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI

diff --git a/common/org.eclipse.tracecompass.common.core/annotations/java/lang/String.eea b/common/org.eclipse.tracecompass.common.core/annotations/java/lang/String.eea
new file mode 100644 (file)
index 0000000..328ef38
--- /dev/null
+++ b/common/org.eclipse.tracecompass.common.core/annotations/java/lang/String.eea
@@ -0,0 +1,43 @@
+class java/lang/String
+copyValueOf
+ ([C)Ljava/lang/String;
+ ([C)L1java/lang/String;
+copyValueOf
+ ([CII)Ljava/lang/String;
+ ([CII)L1java/lang/String;
+format
+ (Ljava/lang/String;[Ljava/lang/Object;)Ljava/lang/String;
+ (Ljava/lang/String;[Ljava/lang/Object;)L1java/lang/String;
+format
+ (Ljava/util/Locale;Ljava/lang/String;[Ljava/lang/Object;)Ljava/lang/String;
+ (Ljava/util/Locale;Ljava/lang/String;[Ljava/lang/Object;)L1java/lang/String;
+intern
+ ()Ljava/lang/String;
+ ()L1java/lang/String;
+toString
+ ()Ljava/lang/String;
+ ()L1java/lang/String;
+valueOf
+ (C)Ljava/lang/String;
+ (C)L1java/lang/String;
+valueOf
+ (D)Ljava/lang/String;
+ (D)L1java/lang/String;
+valueOf
+ (F)Ljava/lang/String;
+ (F)L1java/lang/String;
+valueOf
+ (I)Ljava/lang/String;
+ (I)L1java/lang/String;
+valueOf
+ (J)Ljava/lang/String;
+ (J)L1java/lang/String;
+valueOf
+ (Ljava/lang/Object;)Ljava/lang/String;
+ (Ljava/lang/Object;)L1java/lang/String;
+valueOf
+ (Z)Ljava/lang/String;
+ (Z)L1java/lang/String;
+valueOf
+ ([C)Ljava/lang/String;
+ ([C)L1java/lang/String;

diff --git a/ctf/org.eclipse.tracecompass.ctf.parser.tests/build.properties b/ctf/org.eclipse.tracecompass.ctf.parser.tests/build.properties
index 8b5684598317e85be1458b9609fdcc393b07bd32..02aa8e3fb573af2cd7e03feafee7b9829780e1eb 100644 (file)
--- a/ctf/org.eclipse.tracecompass.ctf.parser.tests/build.properties
+++ b/ctf/org.eclipse.tracecompass.ctf.parser.tests/build.properties
@@ -17,3 +17,5 @@ bin.includes = META-INF/,\
                plugin.properties,\
                about.html
 src.includes = about.html
+additional.bundles = org.eclipse.jdt.annotation
+jars.extra.classpath = platform:/plugin/org.eclipse.jdt.annotation
\ No newline at end of file

diff --git a/ctf/org.eclipse.tracecompass.ctf.parser/build.properties b/ctf/org.eclipse.tracecompass.ctf.parser/build.properties
index 0526a214fb71116ec850ceb5710c60c41d1b1c7c..b4e72d66358223c235cce1b3523c6c4c0ff359c4 100644 (file)
--- a/ctf/org.eclipse.tracecompass.ctf.parser/build.properties
+++ b/ctf/org.eclipse.tracecompass.ctf.parser/build.properties
@@ -19,3 +19,5 @@ bin.includes = META-INF/,\
                .
 jars.compile.order = .
 src.includes = about.html
+additional.bundles = org.eclipse.jdt.annotation
+jars.extra.classpath = platform:/plugin/org.eclipse.jdt.annotation
\ No newline at end of file

diff --git a/gdbtrace/org.eclipse.tracecompass.gdbtrace.core.tests/build.properties b/gdbtrace/org.eclipse.tracecompass.gdbtrace.core.tests/build.properties
index 978a8de6ba3d467db42bfdee2726fbbd661048bb..a3374f63f3f9970a7da0275939578abf0a91c033 100644 (file)
--- a/gdbtrace/org.eclipse.tracecompass.gdbtrace.core.tests/build.properties
+++ b/gdbtrace/org.eclipse.tracecompass.gdbtrace.core.tests/build.properties
@@ -17,3 +17,5 @@ bin.includes = META-INF/,\
                plugin.properties,\
                about.html
 src.includes = about.html
+additional.bundles = org.eclipse.jdt.annotation
+jars.extra.classpath = platform:/plugin/org.eclipse.jdt.annotation
\ No newline at end of file

diff --git a/gdbtrace/org.eclipse.tracecompass.gdbtrace.ui.tests/build.properties b/gdbtrace/org.eclipse.tracecompass.gdbtrace.ui.tests/build.properties
index 978a8de6ba3d467db42bfdee2726fbbd661048bb..a3374f63f3f9970a7da0275939578abf0a91c033 100644 (file)
--- a/gdbtrace/org.eclipse.tracecompass.gdbtrace.ui.tests/build.properties
+++ b/gdbtrace/org.eclipse.tracecompass.gdbtrace.ui.tests/build.properties
@@ -17,3 +17,5 @@ bin.includes = META-INF/,\
                plugin.properties,\
                about.html
 src.includes = about.html
+additional.bundles = org.eclipse.jdt.annotation
+jars.extra.classpath = platform:/plugin/org.eclipse.jdt.annotation
\ No newline at end of file

diff --git a/lttng/org.eclipse.tracecompass.lttng2.control.core.tests/build.properties b/lttng/org.eclipse.tracecompass.lttng2.control.core.tests/build.properties
index 978a8de6ba3d467db42bfdee2726fbbd661048bb..a3374f63f3f9970a7da0275939578abf0a91c033 100644 (file)
--- a/lttng/org.eclipse.tracecompass.lttng2.control.core.tests/build.properties
+++ b/lttng/org.eclipse.tracecompass.lttng2.control.core.tests/build.properties
@@ -17,3 +17,5 @@ bin.includes = META-INF/,\
                plugin.properties,\
                about.html
 src.includes = about.html
+additional.bundles = org.eclipse.jdt.annotation
+jars.extra.classpath = platform:/plugin/org.eclipse.jdt.annotation
\ No newline at end of file

diff --git a/lttng/org.eclipse.tracecompass.lttng2.ust.ui.tests/build.properties b/lttng/org.eclipse.tracecompass.lttng2.ust.ui.tests/build.properties
index 978a8de6ba3d467db42bfdee2726fbbd661048bb..a3374f63f3f9970a7da0275939578abf0a91c033 100644 (file)
--- a/lttng/org.eclipse.tracecompass.lttng2.ust.ui.tests/build.properties
+++ b/lttng/org.eclipse.tracecompass.lttng2.ust.ui.tests/build.properties
@@ -17,3 +17,5 @@ bin.includes = META-INF/,\
                plugin.properties,\
                about.html
 src.includes = about.html
+additional.bundles = org.eclipse.jdt.annotation
+jars.extra.classpath = platform:/plugin/org.eclipse.jdt.annotation
\ No newline at end of file