tmf: Fix leaking static Histogram instances
authorPatrick Tasse <patrick.tasse@gmail.com>
Tue, 5 Apr 2016 22:24:24 +0000 (18:24 -0400)
committerPatrick Tasse <patrick.tasse@gmail.com>
Fri, 8 Apr 2016 21:11:39 +0000 (17:11 -0400)
The two Histogram instances in HistogramView are static and therefore
are retained by the class in the ClassLoader with references to the last
histogram data model, even after the view is closed.

Change-Id: I7853628e99a7bd8f3815253060bf891eed217cae
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/70058
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/views/histogram/HistogramView.java

index ab16edadaeddde97a44b8fec7b5b422e6bd3c576..748e32ec83308a731d5c2fc89c9e169349533018 100644 (file)
@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2009, 2015 Ericsson
+ * Copyright (c) 2009, 2016 Ericsson
  *
  * All rights reserved. This program and the accompanying materials are
  * made available under the terms of the Eclipse Public License v1.0 which
@@ -137,11 +137,11 @@ public class HistogramView extends TmfView implements ITmfTimeAligned {
     private boolean fLinkState;
 
     // Histogram/request for the full trace range
-    private static FullTraceHistogram fFullTraceHistogram;
+    private FullTraceHistogram fFullTraceHistogram;
     private HistogramRequest fFullTraceRequest;
 
     // Histogram/request for the selected time range
-    private static TimeRangeHistogram fTimeRangeHistogram;
+    private TimeRangeHistogram fTimeRangeHistogram;
     private HistogramRequest fTimeRangeRequest;
 
     // Legend area
This page took 0.026512 seconds and 5 git commands to generate.