analysis.lami: Do not validate extra arguments (anything is valid)

Change-Id: I744eb779d246e778fdb7a1f59ea07babf05c354c
Signed-off-by: Philippe Proulx <pproulx@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74336
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>

diff --git a/analysis/org.eclipse.tracecompass.analysis.lami.ui/src/org/eclipse/tracecompass/internal/provisional/analysis/lami/ui/handler/RunAnalysisHandler.java b/analysis/org.eclipse.tracecompass.analysis.lami.ui/src/org/eclipse/tracecompass/internal/provisional/analysis/lami/ui/handler/RunAnalysisHandler.java
index 14d19edc4bc3222f71f68c23ebc2846a8ccb2476..47549d3307cdbdb99bd3082911732d2d8c32baff 100644 (file)
--- a/analysis/org.eclipse.tracecompass.analysis.lami.ui/src/org/eclipse/tracecompass/internal/provisional/analysis/lami/ui/handler/RunAnalysisHandler.java
+++ b/analysis/org.eclipse.tracecompass.analysis.lami.ui/src/org/eclipse/tracecompass/internal/provisional/analysis/lami/ui/handler/RunAnalysisHandler.java
@@ -24,7 +24,6 @@ import org.eclipse.core.runtime.Status;
 import org.eclipse.core.runtime.jobs.Job;
 import org.eclipse.jdt.annotation.Nullable;
 import org.eclipse.jface.dialogs.ErrorDialog;
-import org.eclipse.jface.dialogs.IInputValidator;
 import org.eclipse.jface.viewers.ISelection;
 import org.eclipse.jface.viewers.IStructuredSelection;
 import org.eclipse.jface.window.Window;
@@ -108,8 +107,7 @@ public class RunAnalysisHandler extends AbstractHandler {
         Shell shell = PlatformUI.getWorkbench().getActiveWorkbenchWindow().getShell();
         ParameterDialog dialog = new ParameterDialog(shell, Messages.ParameterDialog_ExternalParameters,
                 Messages.ParameterDialog_ExternalParametersDescription,
-                        baseCommand,
-                PARAM_STRING_VALIDATOR);
+                baseCommand, null);
         if (dialog.open() != Window.OK) {
             /* User clicked Cancel, don't run */
             return null;
@@ -176,13 +174,6 @@ public class RunAnalysisHandler extends AbstractHandler {
         return null;
     }
 
-    private static final IInputValidator PARAM_STRING_VALIDATOR = text -> {
-        if (text.isEmpty() || text.matches("[a-zA-Z0-9\\,\\-\\s]+")) { //$NON-NLS-1$
-            return null;
-        }
-        return Messages.ParameterDialog_StringValidatorMessage;
-    };
-
     /**
      * Register a new report
      *