This adds default implementation in the interface for
ISegmentStoreDensityViewerDataListener so that implementations do not
have to override deprecated methods.
Change-Id: I54ddb3c13c62a3ae554d48636d01995da7f3d3f7
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/97590
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.TimeUnit;
private static final String CALLGRAPHDENSITY_ID = CallGraphDensityView.ID;
private final @NonNull ISegmentStoreDensityViewerDataListener fSyncListener = new ISegmentStoreDensityViewerDataListener() {
private static final String CALLGRAPHDENSITY_ID = CallGraphDensityView.ID;
private final @NonNull ISegmentStoreDensityViewerDataListener fSyncListener = new ISegmentStoreDensityViewerDataListener() {
- @Deprecated
- @Override
- public void dataChanged(List<ISegment> newData) {
- fLatch.countDown();
- }
-
- @Deprecated
- @Override
- public void dataSelectionChanged(@Nullable List<@NonNull ISegment> newSelectionData) {
- // do nothing
- }
@Override
public void viewDataChanged(@NonNull Iterable<? extends @NonNull ISegment> newData) {
@Override
public void viewDataChanged(@NonNull Iterable<? extends @NonNull ISegment> newData) {
package org.eclipse.tracecompass.analysis.timing.ui.views.segmentstore.density;
package org.eclipse.tracecompass.analysis.timing.ui.views.segmentstore.density;
-import java.util.List;
-
import org.eclipse.jdt.annotation.NonNull;
import org.eclipse.jdt.annotation.Nullable;
import org.eclipse.jface.action.Action;
import org.eclipse.jdt.annotation.NonNull;
import org.eclipse.jdt.annotation.Nullable;
import org.eclipse.jface.action.Action;
* Used to keep the table in sync with the density viewer.
*/
private final class DataChangedListener implements ISegmentStoreDensityViewerDataListener {
* Used to keep the table in sync with the density viewer.
*/
private final class DataChangedListener implements ISegmentStoreDensityViewerDataListener {
- @Deprecated
- @Override
- public void dataChanged(List<ISegment> data) {
- updateTableModel(data);
- }
-
- private void updateTableModel(@Nullable List<ISegment> data) {
- final AbstractSegmentStoreTableViewer viewer = fTableViewer;
- if (viewer != null && data != null) {
- viewer.updateModel(data);
- }
- }
private void updateTableModel(@Nullable Iterable<? extends ISegment> data) {
final AbstractSegmentStoreTableViewer viewer = fTableViewer;
private void updateTableModel(@Nullable Iterable<? extends ISegment> data) {
final AbstractSegmentStoreTableViewer viewer = fTableViewer;
- @Deprecated
- @Override
- public void dataSelectionChanged(@Nullable List<ISegment> data) {
- updateTableModel(data);
- }
-
@Override
public void viewDataChanged(@NonNull Iterable<? extends @NonNull ISegment> newData) {
updateTableModel(newData);
@Override
public void viewDataChanged(@NonNull Iterable<? extends @NonNull ISegment> newData) {
updateTableModel(newData);
* @deprecated Use {@link #viewDataChanged(Iterable)} instead
*/
@Deprecated
* @deprecated Use {@link #viewDataChanged(Iterable)} instead
*/
@Deprecated
- void dataChanged(List<ISegment> newData);
+ default void dataChanged(List<ISegment> newData) {
+ // do nothing
+ }
/**
* Notification that the selection of the data changed in the viewer.
/**
* Notification that the selection of the data changed in the viewer.
* @deprecated Use {@link #selectedDataChanged(Iterable)} instead
*/
@Deprecated
* @deprecated Use {@link #selectedDataChanged(Iterable)} instead
*/
@Deprecated
- void dataSelectionChanged(@Nullable List<ISegment> newSelectionData);
+ default void dataSelectionChanged(@Nullable List<ISegment> newSelectionData) {
+ // do nothing
+ }
/**
* Notification that the data changed in the viewer.
/**
* Notification that the data changed in the viewer.