tmf: log error before displaying message

Otherwise the error is logged only after the dialog is closed.
This is not a problem for normal use but for automated tests it can be
tricky since we can stop the test before closing the dialog and still look for
errors.

Change-Id: I1579fa166af2fbe5cd55fdb82b92d976171deaf6
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Reviewed-on: https://git.eclipse.org/r/61066
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

diff --git a/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/project/model/TraceUtils.java b/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/project/model/TraceUtils.java
index 893713fea632e4682734843cc01e54a43b024a79..23484f460ce9b341ec9eb14befdc01a1c76f7452 100644 (file)
--- a/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/project/model/TraceUtils.java
+++ b/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/project/model/TraceUtils.java
@@ -50,8 +50,8 @@ public class TraceUtils {
             @Override
             public void run() {
                 final Shell shell = PlatformUI.getWorkbench().getActiveWorkbenchWindow().getShell();
-                MessageDialog.openError(shell, boxTitle, errorMsg);
                 Activator.getDefault().logError(errorMsg);
+                MessageDialog.openError(shell, boxTitle, errorMsg);
             }
         });
     }