tmf: Bug 494810: SelectionEvent not sent after using vertical slider

The vertical slider used by the TmfVirtualTable is created with the
SWT.NO_FOCUS style. In Linux-GTK, this hint is not respected and the
slider can gain focus. When this happens, give back the focus to the
table.

This allows the SelectionEvent to be sent when extending a selection
using Shift+Click in the event table after using the vertical slider.

Change-Id: I9a8d7083300a5c515c24110d5572d30b6bd9d7d6
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74119
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

xml: bug 493954: Allow string states to be displayed in time graph views

If a string state value is to be displayed in the time graph, it will add
a new state to the presentation provider with color. This state will be re-used
when the same string is displayed again. This is ideal for time graphs of state
system where there is a fixed number of strings as value, yet impossible to
define with definedValues because specific to a trace.

Change-Id: I2d1fa041e578e0a7dbccc3138153db3fd4684c62
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/71970
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

doc: Bug 495211 Update XML XY view documentation

The kernel analysis was moved.

Change-Id: Ibaf3843b43e15d7fe742e1e9b05b6e40250f5fec
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74326
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

doc: Bug 495211 Update CTF documentation

Change-Id: Iafeacbf118de123d96d54e422e718a0d2a7fff37
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74325
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

segstore.core: Synchronize isEmpty

This avoids race conditions

Change-Id: Ifb252a4011aed88118b2db8abd6c49be49c0d175
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73744
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Hudson CI

tmf.xml: Delete existing supplementary files when importing xml analysis

Previously, if we import a file that was previously loaded once, traces
won't be notified that the file changed.
Now, if the file already exist, the supplementary files for the analysis
are deleted and the related traces are closed.

Change-Id: I62ce6e6f4295db5f0c82e4c77ae73b4e5a4c1b85
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73648
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>

doc : Introduce the data driven XML pattern documentation

Change-Id: Ib00876610f4b93000a3968b20487077fdebe47a1
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72304
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

linux.swtbot: Add basic critical flow view test.

This tests runs a true integration test with the control flow view.
It signals the critical path view from a right click on the cfv.

Change-Id: Icc04e03de0b745eb966bb711494eab749b8b08c6
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72360
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

analysis.lami: remove unused font height for error labels

The method setHeight() does not modify the reciever. Thus,
the size of the error label didn't change.

Change-Id: I1cb656429d5a45dff310c8f6fe94aa99760b92fa
Signed-off-by: Gabriel-Andrew Pollo-Guilbert <gabrielpolloguilbert@gmail.com>
Reviewed-on: https://git.eclipse.org/r/73981
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

pcap.core: making some classes final

This patch is to make some classes final in pcap.core component.
It should be final to improve readability and since you should never extend
it. It also allows the jvm to inline methods and improve performance.

Change-Id: I7288b25324cb343a33cf6536b80cdaae3619211f
Signed-off-by: Wassim <wassim.nasrallah.36@gmail.com>
Reviewed-on: https://git.eclipse.org/r/73671
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

ctf.core: making some classes final

This patch is to make some classes final in ctf.core component.
It should be final to improve readability and since you should never
extend it. It also allows the jvm to inline methods and improve performance.

Change-Id: I6e9bef701898716978c6e7b4b20254eabc8cd6c8
Signed-off-by: Wassim <wassim.nasrallah.36@gmail.com>
Reviewed-on: https://git.eclipse.org/r/73771
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

ust.core: making some classes final

This patch is to make some classes final in ust.core component.
It should be final to improve readability and since you should never
extend it. It also allows the jvm to inline methods and improve
performance.

Change-Id: Ifa5d1e667efb3e18f5cd4a9037082469574c16c6
Signed-off-by: Wassim <wassim.nasrallah.36@gmail.com>
Reviewed-on: https://git.eclipse.org/r/73972
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

analysis.lami: correctly handle Number (double, long etc.) type graphing

LTTng analysis return mostly long values either for the time stamps or
actual measurements. SWTChart, on the other hand, deals only with
"double" numerical values. Casting long to double causes a loss of
precision for big long value (e.g time stamps).

E.g: Loss of precision occurs when time ranges with a big minimal value
(2^62) but with little delta (1 ns) between events exist. Graphs
generated from such time ranges as an axis would result in a single dot
which is a clear problem.

The presented solution uses linear mapping to preserve resolution and
precision when possible.

The linear mapping requires two ranges: the internal range and the
external range.

Each graph is responsible to provide an internal LamiGraphRange. This
range is the internal representation in double in which all raw
(external) value are to be mapped. For now the default internal range is
0 to 1.

The external range [raw values range] is generated by finding the
minimal value and maximal values of aspects to be plotted.

Each point is then mapped to a corresponding value from the internal
range:

eV = external value
eR = external range
iV = internal value
iR = internal range

iV = (( eV - eR.minimum ) * ( iR.delta / eR.delta )) + iR.minimum

Since the default internal range is from 0 to 1 all raw values are
mapped to a value from 0 to 1.

On graph tick generation axis formatter transforms internal
representation to external representation and formats the result.

Other change:
- Aspects now return their numerical values via resolveNumber to ensure
  no casting is done.
- Move axis formatter to ui plugin.

Bug: 493941

Change-Id: I289180e10a7f1cbf6ecdd1beba93549b8fbe4c23
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/73239
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

tmf: Bug 495054: Importing or exporting custom parsers fails silently

When importing custom parsers from a file that does not contain any
custom parser definition, a message dialog is shown to the user.

When exporting a custom parser to an existing file that is not a valid
custom parser definition file, a message is logged to the Error Log.

Change-Id: I2f0bb781d9d43d8bbaf05da2b7ec06c2a65d47d3
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74094
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf.ui: [bug 494974] Fix left panel click handling in timegraph in Linux

Clicking on the left panel in Linux currently deselects the
entry. This behavior is particularly egregious in the case of
UI unit tests.

Change-Id: I18fbe001c6b7325c6618e46c22f13ad976357abe
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73998
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Bug 494767: Events in selection not updated in Statistics view

- Make sure the time range created from TmfSelectionRangeUpdatedSignal
always has the earliest time as start time.

- If the events per type map is empty for a time range stats update,
reset all time range event counts.

Change-Id: I2c860bdd0dd9e033933c690f230aaf79e6f60b5e
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/73973
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Bug 494790: Time Chart view does not update when adding bookmarks

The Time Chart view now properly shows the bookmark decorations.

Change-Id: I5e25171f61afea79fdd0e2206ef3254731ecb497
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/73956
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Bug 494589: Event table loses focus when pressing Ctrl+Enter or Esc

This gives back focus to the table after pressing Ctrl+Enter or Esc from
a header row cell editor.

Change-Id: I85fe91739a0b4422de3168dd9ea2fbb197853a6b
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/73953
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

critical path: bug 495020 fix statistics when reopening a trace

Change-Id: Ie67aec3a9ea5c114dd7005817da76daf9b764d5e
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/74043
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI

critical path: bug 490086 Set start/end time for the trace

Previously, the start and end times of the critical path were set when building
the entries list for each critical path. Each worker had different start/end
times, different from the trace's and when getting a previously calculated
critical path, it would not reset the start/end time so the results were not
displayed correctly.

This patch sets the start and end time of the critical path view with the data
from the main execution graph, not the current worker's critical path.

It also gets the previously computed statistics in the content provider instead
of the analysis start.

Change-Id: I7c08f7776b375b033575bc56c51d1cff36b72068
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/73513
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI

critical path: bug 494196 reset selection when trace selected

This resets the selection in the parameter provider so that if a thread is
selected again in the control flow view, the selection change is triggered
again.

Change-Id: I92f4203d0181f996efcbc2618c32d35311761003
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/73318
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

critical path: bug 490085 Always start critical path from head vertex

Previously, the critical path was calculated starting at the start of the
window range, but that behavior was not intuitive to the user and it was not
possible to change that window range once it is calculated.

Now the critical path is calculated for the whole of the worker's lifetime.

Change-Id: Id76192eec04dff6d3c45c1bd1314248d4ea991fb
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/73515
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Bug 494689: fix failing name conflict handling in trace import

This patch also adds test cases for RENAME_ALL and OVERWRITE_ALL in
the corresponding SWTBot test class.

It also fixes the test cases when overwriting existing resources
without confirmation.

Change-Id: I7b4a7779091d824502ea15a18573f162304d143b
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73759
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Add getDocumentFromFile() to XmlUtils

Change-Id: I318607d8043e6b1925734fff51642d2274b88336
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/71783
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

tmf: Remove toString on string objects

Change-Id: I87bfd0f41dc50cde994e5d5bed1cf221a6477c05
Signed-off-by: Sonia Farrah <sonia.farrah@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72086
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: add sorter to put analysis in a more user-friendly order

fixes bug 494923

Change-Id: I484a731662143591a6e2bddd31c400ea6d0244b7
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73940
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

timing.core: Make ArrayList use the array of segments if possible

Bulk load arrays if possible to speed up the serialized segment store.

Change-Id: I55a389419b7fe3182ee3d0fae90c16d9c6bab5a2
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73061
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Bug 494077: Closing AbstractTimeGraphView should cancel its threads

Change-Id: I6eafdb015e1d5f03def8b692964032b1ce00255f
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/73234
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI

xml: Replace a checkNotNull by a message when state undefined

An error in the XML where the next state defined by the user was undefined
would throw a NullPointerException and make the analysis fail ungracefully.
This logs a message to the user (we still need a way to have debug data on the
XML)

This is one step in solving bug 493155

Change-Id: I53edc74c6e9abcf531df07d17d7fa488c52e9155
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/72080
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

critical path: bug 489360 Build the critical path in a separate thread

The critical path content provider was waiting for the analysis to be completed
but this often happens in the main thread and the first time, it is the whole
graph that needs to be computed and that can block the main thread for a while.

This patch uses a separate build thread when the input is changed so it does
not block anymore.

Change-Id: I9cb99c0d93524961c5f8b45ada59d8a02db49bb0
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/72759
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: bug 493661 Return analyses who apply to experiment

When the requested traceclass is TmfExperiment, the analysis who have
appliesExperiment set to true will be returned.

Change-Id: Icfc3201029d8b04237287c693f8cbe1708827b56
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/72984
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

linux.ui: make Kernel Memory view handle out of range requests

This is a common use case with experiments that have multiple nodes

Change-Id: I3a2bcd583473cb9bd9fa6f5a2d69eecb9e4fb291
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/71105
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

linux.ui: make CPU usage view support experiments with kernels.

Time queries now clamped to the range of the state system.

Change-Id: Ifa4750bbfe57d5e2df34cc418553644d3891c377
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72855
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

lami: add NLS to Exception message

Change-Id: I8bc41b9590d9955eb87f4f36417c0ff317b07f1e
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73687
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

tmf: fix bug 489217. Use of ArrayListStore instead of TreeMapStore

Use of ArrayListStore instead of TreeMapStore for the pattern analysis

Change-Id: Ie247297936a4cf89b8bdf7b53b48625ce3cf34cd
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73306
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

linux.core: Intern SystemCall name string

This patch makes SystemCall mutable.

This is a tricky situation. This object is serializable.
In order to internalize the string (name) the object needs
to have a custom readObject().

This means we need to either make the name field mutable or
use reflexion to make the field modifyable. If we are using
reflexion, the point of making an object immutable is moot.

Here are the main reasons for an immutable object:

* immutable objects are simpler to construct, test, and use
* truly immutable objects are always thread-safe
* they help to avoid temporal coupling
* their usage is side-effect free (no defensive copies)
* identity mutability problem is avoided
* they always have failure atomicity
* they are much easier to cache
* they prevent NULL references, which are bad

As SystemCall has no setters, and the class is now final,
its fields are in practice immutable.

This begs the question though, would having no "final" keyword
on a field affect performance. Unfortunately no. Final classes
can be inlined, but final fields yield no advantage other than
code clarity.

We should still strive to have final fields whenever it is
possible, but this should not cause ideological objections,
as it breaks clean serialization.

This partially addresses bug 489217

Change-Id: I80a99128dffebe1fb3c0561ab76beabea2cc7775
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72995
Reviewed-by: Hudson CI

releng: Update targets for Neon RC2

Change-Id: I5050420978f8b3e69e55a6ad7cb7f4586eae00c2
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73581
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

analysis: add Latency Statistics UI test

This tests the total, the number of distinct syscalls
and tests some random nodes.

Change-Id: Ied0aab3958b75de20eb2368d0beafb1c123c6987
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62555
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Bug 494197: Empty event list for CallStackEntry when no process

The three-level deep loop to populate the event list from the build
thread did not reach the third level if a trace did not have processes
or threads. The loops are replaced with a recursive consumer.

Change-Id: Ie7eebb57f562bad0c6620ae08fcde8b585c52ca9
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/72916
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ctf: Add test for 8-byte integer sign extension bug

The added test highlights bug 491382.

Change-Id: I1e9c1f458ef64145e4f4a6dc9d9b6c0521b1065d
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/70312
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ctf: fix bug 491382. Properly display bytefields

Display byte arrays as signed or unsigned and
thus properly sign extend them.

Note: the order or precendence for Integer Arrays is:
* Strings
* Byte Arrays
* Other Ints

Change-Id: I6d9537f4866648094f20419de87a64478c17e2c9
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72672
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

analysis.lami: Replace OnDemandAnalysisException with CoreException

We may want to pass additional information to the exceptions thrown
when a LAMI analysis does not complete succesfully, like what
type of error should be displayed.

CoreException and IStatus are made exactly for that, and they hook
nicely into ErrorMessage to display, for example, a command-line
stderr output as additional Details in the dialog.

That way, a message like "no results returned" won't look like
a scary error.

Bug: 493941

Change-Id: Id3e6711ac410c3d993b4928a350dc1bdbcf89f5a
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/72242
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Revert "TMF: Fix behavior of XML time graph views with experiments"

This reverts commit 836d7c77cd2daccf7107d52e6e4bb78891a6ecb3.

The code was no longer needed as the experiments now give their
children's analyses.

Bug 494052

Change-Id: Id4c1d6757733938c67a5dd65827a6e09f30dbdc2
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73090
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

analysis.lami: Correctly set axis name if it is defined by one aspect

Bug: 493941

Change-Id: Idc91ef8ff923b1e569ff7e4823ef84c1f94f38b1
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Reviewed-on: https://git.eclipse.org/r/72246
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

analysis.lami: Fix timestamp label not showing on Y axis

The fix is the same as the custom label since it is the same
problem. Put tick angle to 1.

Bug: 493941

Change-Id: I8b302a24474d47dd3c899d0e05e452cec5663cba
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Reviewed-on: https://git.eclipse.org/r/72245
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

linux.core: fix break in build.

Syscall analysis was internalized before the patch was approved.

Change-Id: I254660d5fa28354d4e5f58c84fea39364077c047
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73225
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

releng: Update targets for Neon RC1

launchbar doesn't have a RC1, only M7.

Change-Id: I8d96a17195439797ffad96bf2c822e7d9ca2b39e
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73098
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

analysis: Introduce syscall statistics analysis test

This extracts the kernelCtfTraceStub to allow both tests to use it.

Change-Id: I8cbd51e691d9e9f3ae2d51e2f64e74a9ec6c6176
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62546
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

analysis: test System call analysis

This tests the system call latency analysis without the UI.

Change-Id: I15b409a89de59cce4fc03596ab62790387dfea75
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62323
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

rcp: Sign the RCP on Mac

The mac signing has to happen between materialize-products and
archive-products goals. Because we only want to do it when the
signing profile is enabled (eclipse.org server), we have to duplicate
some xml to fit the macsigner between the two. I did extract some
variables in order to make the duplication less error prone.

Bug: 488873
Change-Id: I65168e010dc866ef48b643f6aaf30aa94aedefda
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72976
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

analysis.lami: Add toolbar to custom charts

For now only a close button action is present. This will
allow removing a single chart, and not all of them.

Bug: 493941

Change-Id: I24c8ee2d64bc9e8da93788f34f380bda4e7a88b8
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Reviewed-on: https://git.eclipse.org/r/72244
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

analysis.lami: Add tests for the LAMI JSON protocol parsing

Some classes and methods were made more public so that they
can be accessed by the test plugin.

Bug: 493941

Change-Id: Ida5567a1257cb643962bf357250325eca200b296
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Reviewed-on: https://git.eclipse.org/r/72102
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>

releng: Use non-composite repository for Derby

This speeds up the build time by having to do less http requests.
The improvement is even greater when contacting the server gets
occasionally very slow when building on eclipse.org slave.

Change-Id: Idfda43ade332bc61fad11df30810c948391f6407
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73122
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ss: Replace AttributeNotFoundException with IOOBE for quark parameters

Methods that take a quark integer as parameter are changed to throw a
runtime IndexOutOfBoundsException instead of a checked
AttributeNotFoundException.

This makes those methods consistent with other methods that already
throw IOOBE when the quark is out of range.

Many occurrences were already swallowing the exception or re-throwing a
runtime exception.

Change-Id: I943b407e07bbc226c6b7c03306cd6d00f783bca2
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/72198
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Hudson CI

lttng: Add System Call Analysis benchmarks

This benchmarks the build time and memory usage of system call latency analysis
on some lttng kernel traces

Change-Id: Ib88063a1468c21b7856f12c00a4d12ce70b6958c
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/72974
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

timing.core: add ArrayListStore implementing ISegmentStore

This store is made for a corner case where we want a slightly more
memory efficient datastore.

This is used by the timing analysis to save a bit of memory at the
expense of intersection times.

This partially addresses bug 489217

Change-Id: I364d498526ac46d357d9788714cea25816efd536
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72968
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

timing.core: Bug 493897 show correct system call columns in density view

Change-Id: Ic98ba2723bb3c2136dfc2adffc36c1f67f38f2b7
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73045
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

tmf.xml: Fix condition ordering to avoid IndexOutOfBoundsException in FSM

If a scenario is not set as initial scenario, then no scenario is created and
the isNewScenarioAllowed method throws a IndexOutOfBoundsException. This patch
reorders the condition so it is first verified that the scenario count is more
than 0

Change-Id: I034e049ce6e1655fccbf6caf03978515285e9b73
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/72035
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

linux.core: optimize system calls for memory usage

Drop the arguments and return value and internalize the
Strings.

Change-Id: Id8ab76df2679917e1bcd3e76457ee8f6632bb5b0
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72939
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

segStore: Add a close method to ISegmentStore

This method will close the segment store backend at the end of the analysis or
delete the files that were created if the analysis did not create correctly.

This method will be useful when there is multiple segment store backends, so
that each one can take care of its own saving actions and cleanup.

Change-Id: I7c2bd4c21b9141b0b4f0f3eed2495895299d3dc8
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/72931
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

analysis.lami: Show one view per report

Multiple tables in a report will be shown as multiple tabs
in the view. Each tab will have its own graphs. This will
allow naming the views with the report names, so it will be
easier to match a given view to its report.

Change-Id: Ieeef337079d385dfd79f3cc26a3574b800e7754c
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/72243
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

analysis.lami: Add support for user-defined LAMI analyses

This patch adds support for adding user-defined LAMI analyses,
as well as removing them, through the UI (project explorer).

A .properties file is created in the workspace for each added
user-defined analysis.

To add a new external analysis, right-click the External Analyses
item in the Project Explorer View, and click Add External Analysis.

To remove an external analysis, right-click the item to remove,
and click Remove External Analysis.

Change-Id: I067f0faf679d2384121a32845864d886ee64e241
Signed-off-by: Philippe Proulx <pproulx@efficios.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/72103
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

Adjust @since tags to 1.2 release

Some tags were set to 2.0 temporarily but the API was really added
in 1.2.

Change-Id: I5e2768741bb2f65e5479aac79a035dac59d76074
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72866
Reviewed-by: Hudson CI

doc: Update documentation for Resources view for execution context

Now the Resources view show IRQs under CPUs and CPUs under IRQs.

https://git.eclipse.org/r/#/c/65609/

Change-Id: I36fe7156e66fdb6dec2c580be024c27a1c67ba74
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72581
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

linux.core: internalize System Call Analysis

This analysis is an implementation of the segment store, it should be
internal

Change-Id: Ifc246608b65c5f09ae11ac2386ee31d462bce825
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72938
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Bug 433518: Add support for unit of seconds in TmfTimestampFormat

The T pattern can be augmented with a suffix to indicate the unit of
seconds to be used by the format. The following patterns are supported:
T (sec), Td (deci), Tc (centi), Tm (milli), Tu (micro), Tn (nano).

The S pattern is modified to represent fractions of this unit.

Change-Id: I81014132b7579093da7761861babe0447fd30b0b
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/72840
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: Add configuration files to call LTTng-Analyses scripts

This patch implements configuration files to offer calling
LTTng-Analyses scripts [1] from Trace Compass.

The `index.properties` file contains a single property, `analyses`,
which is a whitespace-separated list of names of configuration files,
without the extension, to load in order to create as many LAMI
analyses.

Each configuration file contains two properties:

  * `name`: Display name of the analysis.
  * `command`: Full command to run. This string supports
    double-quoted arguments to allow arguments with whitespaces,
    or empty arguments. The `\` and `"` characters must be
    escaped with `\`.

Both properties are mandatory.

LTTng-Analyses 0.4 is supported, however 0.5 and up are recommended
since these will offer a proper progress bar and cancellation
mechanism.

[1] https://github.com/lttng/lttng-analyses

Change-Id: I3e3f7c0e8b29f1714df1f2e3acd685fc23b51e7d
Signed-off-by: Philippe Proulx <pproulx@efficios.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/72101
Reviewed-by: Hudson CI

ss: Add support for custom state values

This patch allows users to register their own state types and
they will be written to intervals.

Change-Id: If3228f4819039689f6aa3b18b8959c42a2ab7d87
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/69253
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

ss: Introduce a safe byte buffer wrapper for use by custom state values

This byte buffer wrapper safely wraps a ByteBuffer inside a class that does not
allow to pass the limit or change the position so that custom state values can
safely write directly to it, without passing by byte arrays.

Change-Id: I428ee4406aa2a913d91ebc2c075bc92861286b3f
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/72359
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

analysis.lami: Implementation of LAMI plugins

If pre-defined scripts are present on the user's system (and on the
$PATH), options under the "External Analyses" trace sub-tree element
become available. Right-clicking on those allows running the specified
analysis, and will import the results as Reports in Trace Compass.

Reports are opened automatically when created, and will initially
display a table of the results returned by the external analysis.
The toolbar menu can then be used to generate charts from this data,
either Histograms or XY scatter plots.

Clicking on chart elemnents highlights the corresponding column in the
table, and vice versa. Also, if the data table rows contain a time
range or timestamp, integration via standard time selection signal
is done.

To not commit to final APIs yet, we've used the "internal.provisional"
naming, as described in [1].

Full user documentation and additional unit tests will follow.

Current limitations:
- The RunAnalysisHandler and others are specific to LAMI analyses,
  which means other types of OnDemandAnalyses would have to define
  their own way of being started (which may not even be through
  a right-click menu option).

[1] https://wiki.eclipse.org/Provisional_API_Guidelines

Change-Id: I188116fa2c0c9a485aabd89d49cae0d6e73136b8
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Philippe Proulx <pproulx@efficios.com>
Reviewed-on: https://git.eclipse.org/r/71565
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI

tmf: Make process and thread names optional in call stack state provider

- Update call stack state provider to allow the optional specification
of the process name for an event.

- Make the specification of the thread name for an event optional.

- Use the process id (or UKNOWN) as attribute name if the process name
is unspecified.

- Use the thread id as attribute name if the thread name is unspecified.

- Store the process id as int state value of the process attribute in
the default state provider implementation.

- Update call stack view to use the process attribute's int state value
for the process id if available, otherwise try to use the attribute name
parsed as an int.

- Use the thread attribute's long state value for the thread id if
available, otherwise try to use the attribute name parsed as a long.

Change-Id: I91fc5d3eaebaaeed6f44009a1e2185a0bfe6a878
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/71824
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

lttng.ui: Add ID to LTTngCallStackAnalysis

Having the ID string makes it easier to call it up programatically.

Change-Id: I5ceb36e570a9002d3153e28154c3fbd87800e257
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72841
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

tmf: make checkpoint indexer return a failed status if the request fails.

Trace compass uses the TmfIndexingJob for every trace, propagating errors
in the trace reading could be done here. Before this patch, running the
job would always return Status#OK_STATUS. Now, if there is an error that
occured (the request fails) it will propagate the error instead of
swallowing it.

Change-Id: I7247de99af4c32c6747f0100d1c07275783264fd
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67918
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI

tmf: Make processes and threads optional in Call Stack view

- Update call stack analysis module to support possibly empty processes
pattern and threads pattern.

- Update call stack view tree structure to make process entries and
thread entries optional.

- Add icon for process entries.

- Incorporate update of call stack entry selection into
synchingToTime().

- Update synchingToTime() to use a recursive Consumer and to use cached
full states.

Change-Id: I1f850186e04f2470c8e4889c6396217373e7f923
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/71823
Reviewed-by: Hudson CI

lttng2: Move the arrows to the right of the Advanced button

Change-Id: I2198e6ec29b66070c80b9821b4940d2fecbb52cd
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72518
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

doc: Updating the image for creating a session in Snapshot Mode

Change-Id: I31bc64935caa584cd5d0e8e33deef7ed098ae52b
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72549
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

doc: Update documentation of keyboard shortcuts for expand/collapse

Some keyboard shortcuts were added for expanding and collapsing
entries so we need to update the documentation.

See https://git.eclipse.org/r/#/c/70583/

Change-Id: I8ffdf4654e5dd7c6cbfd6bc9f95405a5495b9a49
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72566
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

tmf.ui: make State System Explorer manually get analyses.

SSE already gets all analyses for every child, this patch eschews
using helper functions. Using them would actually make things more
complicated.

Change-Id: I6b72a10c38f4404d112fa88ed86e06752a39ec4d
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72572
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>

analysis: Add root trace entries to Control Flow view

- Trace entries are added as root entries in the time graph tree, and
all control flow entries are now under their respective trace entry (in
hierarchical or flat presentation)

- Remove the Trace column

- Remove the trace column comparator

- The root trace entries can be sorted by name or birth time (ascending
or descending) but when sorting by TID or PTID the trace entries are
always sorted by ascending birth time.

- Remove the trace name from the ControlFlowEntry pattern matcher

- Add method to remove child from TimeGraphEntry

Change-Id: I6717855f3da727d4ca8f0ac834b2153edbb12c5c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/72424
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI

pcap: allow pcap StreamListView to work with experiments

Change-Id: I93e96a5f1bc5ffff00f75d790ea3b8b13c0062d9
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/71101
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Remove unused local variable

Change-Id: I67c9c4406c1f1cb56114ee783109df71dbb0a7e9
Signed-off-by: Sonia Farrah <sonia.farrah@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72091
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

remote: remove useless String.toString()

This makes the code more efficient and also makes it clear that we are
dealing with a string.

Change-Id: Ifd88e285a4696d1fff8197ec6475665091f3de67
Signed-off-by: Sonia Farrah <sonia.farrah@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72744
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf.core: make Analyses with experiments add children analyses when available.

This is a feature that allows experiments to use the analyses of their children.
The analyses are in a list so that the parent trace is always the first one.

Change-Id: I0f6ba6d38fecb49e4575bd0a4dd1d8602970f4d6
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/71100
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

tmf.core: add exception logging to event requests

This is the first step towards being able to properly show errors
that occur during a trace read. The TmfEventThread already logs all
Exceptions, now the request will get the said exception.

It can then be accessed by "Request#getFailCause()" and the results
can either be handled accordingly or displayed.

Change-Id: I99242dbf6eed25c4138239dd465c16fee62bb752
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67774
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ss: Improve getQuarks() functionality

Add support for getQuarks() relative to a starting node quark.

Add support for multiple wildcards "*" in pattern.

Add support for parent ".." in pattern.

Change-Id: Ie8d389f7f22fc74912303e1a8bd50c5d8cdfa284
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/71822
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

lttng: Remove lttng2.control from required plugins of kernel.core

Change-Id: Ida90534d8a107a75410712f1780f4998f00d3db9
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/69091
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

linux.core: Add messages to IllegalStateExceptions

Analysis modules now declare why they fail.

Change-Id: Idf4ec5ac0a0c7b96317512432ca8d9ab0ee4c61c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68875
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

tmf: Add SWTBot test for the pattern latency density view

Change-Id: Iedd414c71f6511cf2fdf41da1aa2756fc9e8a049
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72552
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add SWTBot test for the pattern latency scatter chart

Change-Id: I5e73bc68a5ddf5e3cd30c0feb580338b27df4439
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72551
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add SWTBot test for the pattern latency table

Change-Id: I2573eb2add87409f40bec309ef4eb5ac386f3089
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72545
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add test suite for pattern analysis module

Change-Id: I2ae1eb7276b626c0623cdb322ddd47f7efd72c75
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72373
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf : Add test suite for XML pattern analysis providers

Change-Id: Ic6a5cc85897e657296446bfdc86eb69cc365f2e7
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72326
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf : Update the XML valid pattern test file

Change-Id: I5b4bd363f4ac47423e5799ed33cdd3b1981f9d08
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72325
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

common.core: No longer swallow exceptions in bbq

IllegalStateExceptions now propagate the parent exceptions.

Change-Id: I0cfb47c19d4462a04b9a009e72b1df372736cc6f
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68874
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

ctf: Better explain IllegalStateException

Show a reason for the illegal state exception.

Change-Id: Ibf99b1bc6b3bc94c20fab6307b62d35d21e12096
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68873
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

analysis: internalize segment store stats messages

Change-Id: I62d9de2df0f0b24ce41485bf31d96a2b62ee47c1
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72496
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

tmf: Fix possible overflows in TmfXmlTimestampCondition

Change-Id: I64754ecb61a8026a711d705ccf7855280aaa400a
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

analysis: add menu to go to min or max from the segment start stats

Change-Id: Ia8d66fdc69a60f93c6e87d417e4798b415a31884
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>

requirements: Implement all level for event names and fields

All requirement priority levels are implemented for the 2 built-in types of
requirement: TmfAnalysisEventRequirement and TmfAnalysisEventFieldRequirement

Change-Id: I513f9a767ac32c23d8fa27702834271008a65d51
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>

requirements: make TmfAnalysisRequirement abstract

Change-Id: I87d7e2d1da00fb1ac023fdeb4b38734e10aa6807
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>