This patch is to make some classes final in pcap.core component.
It should be final to improve readability and since you should never extend
it. It also allows the jvm to inline methods and improve performance.
Change-Id: I7288b25324cb343a33cf6536b80cdaae3619211f
Signed-off-by: Wassim <wassim.nasrallah.36@gmail.com>
Reviewed-on: https://git.eclipse.org/r/73671
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
*
* @author Alexandre Montplaisir
*/
-public class PcapDestinationAspect implements ITmfEventAspect<String> {
+public final class PcapDestinationAspect implements ITmfEventAspect<String> {
/** Singleton instance */
public static final PcapDestinationAspect INSTANCE = new PcapDestinationAspect();
*
* @author Alexandre Montplaisir
*/
-public class PcapProtocolAspect implements ITmfEventAspect<String> {
+public final class PcapProtocolAspect implements ITmfEventAspect<String> {
/** Singleton instance */
public static final PcapProtocolAspect INSTANCE = new PcapProtocolAspect();
*
* @author Alexandre Montplaisir
*/
-public class PcapReferenceAspect implements ITmfEventAspect<String> {
+public final class PcapReferenceAspect implements ITmfEventAspect<String> {
/** Singleton instance */
public static final PcapReferenceAspect INSTANCE = new PcapReferenceAspect();
*
* @author Alexandre Montplaisir
*/
-public class PcapSourceAspect implements ITmfEventAspect<String> {
+public final class PcapSourceAspect implements ITmfEventAspect<String> {
/** Singleton instance */
public static final PcapSourceAspect INSTANCE = new PcapSourceAspect();
*
* @author Vincent Perot
*/
-public class PcapEventFactory {
+public final class PcapEventFactory {
private static final String EMPTY_STRING = ""; //$NON-NLS-1$
projects / deliverable / tracecompass.git / commitdiff
