deliverable/tracecompass.git
8 years agotmf: change printStackTrace() to Activator.logError()
Sonia Farrah [Mon, 2 May 2016 19:58:41 +0000 (15:58 -0400)] 
tmf: change printStackTrace() to Activator.logError()

Change-Id: Ia940e255c5eb903c392fb794422fbf463972323f
Signed-off-by: Sonia Farrah <sonia.farrah@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/71827
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agotmf.core: Changed printStackTrace() for logError()
Bruno Roy [Mon, 2 May 2016 20:17:30 +0000 (16:17 -0400)] 
tmf.core: Changed printStackTrace() for logError()

Change-Id: I2a82e9488fc598dc4c2f2211141e5b42070d5007
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/71829
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agotmf.xml: Move all .core and .ui packages to internal
Geneviève Bastien [Wed, 20 Apr 2016 00:51:44 +0000 (20:51 -0400)] 
tmf.xml: Move all .core and .ui packages to internal

and remove the @since tags from the files.

Change-Id: I087db7e4f275e042ce6fa36809aeb1b4a9a8a712
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/71022
Reviewed-by: Hudson CI
8 years agolttng.ust: Add the build-ID to the key of cache of addr2line calls
Alexandre Montplaisir [Wed, 6 Apr 2016 22:40:54 +0000 (18:40 -0400)] 
lttng.ust: Add the build-ID to the key of cache of addr2line calls

Before calling addr2line, we should also verify that the buildId
we got from the trace matches the file on disk we are about to
look at.

This buildId is already present in the UstDebugInfoBinaryFile
objects returned by the analysis, it is just a matter of
passing it down to the FileOffsetMapper call.

This way we can use it as part of the key for the cache of
calls, so that eventually calling it on different binaries
yields separate calls.

The actual verification is not done at the moment, as this
would require calling a separate process (like "eu-readelf").
There is not much gain in doing it yet anyway, because we only
look for one possible file (the one at the expected path). If
eventually the analysis is extended to look through several
different files for a given path - using separate debug symbol
files for examples - then the surrounding code won't have to
be modified.

Change-Id: I11f42a4295c88f66ad4a685198e30181daf0a1ba
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/70306
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agotmf: Put analyses under their own node in the Project View
Alexandre Montplaisir [Tue, 23 Feb 2016 02:00:19 +0000 (21:00 -0500)] 
tmf: Put analyses under their own node in the Project View

Moves all the analysis/views element under a trace to a new
sub-tree called "Views".

First part of implementing Proposal #2 at
https://wiki.eclipse.org/Trace_Compass/Design_Documents/Project_View#Proposal_2

Change-Id: Icfe0f779b61db1c0a84845b87273d33b8d9cf9dc
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/69071
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
8 years agoanalysis: Fix storing of fields of system call latency analysis
Bernd Hufmann [Fri, 29 Apr 2016 14:13:53 +0000 (10:13 -0400)] 
analysis: Fix storing of fields of system call latency analysis

Right now all fields stored as map fieldName -> field value using
the toString() method on the field value (field.getValue().toString)
However, this cause a problem when the type the value is an object
other than string or a primitive type (e.g. long[]). This patches
changes this to uses field.toString() which creates a formatted string
of the value.

Change-Id: I6ff61eb70d7a7bb958b77797c3271c61cc430eef
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/71698
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agoxml analysis: internalize strings.
Matthew Khouzam [Mon, 18 Apr 2016 20:37:29 +0000 (16:37 -0400)] 
xml analysis: internalize strings.

Stings are currently taking a major amount of memory. This patch reduces
the memory usage by making the strings internal (cached) so duplicates
are no longer copied in memory.

Change-Id: Id686ea8c0648ddf2a7d041b6975ffbab6607167c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70908
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
8 years agotmf.core: null type safety (added type annotation)
Florian Moesch [Sat, 30 Apr 2016 23:36:41 +0000 (01:36 +0200)] 
tmf.core: null type safety (added type annotation)

Change-Id: I85a2851e6f68ef4a1e9904de41ab6b03f7b932e6
Signed-off-by: Florian Moesch <florian@moesch.org>
Reviewed-on: https://git.eclipse.org/r/71753
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
8 years agoSkip irrelevant modules when using Sonarqube 5.x
Marc-Andre Laperle [Fri, 22 Apr 2016 21:33:09 +0000 (17:33 -0400)] 
Skip irrelevant modules when using Sonarqube 5.x

sonar.skippedModules is depracated and will not work in more recent
versions of Sonarqube. We can define sonar.skip in respective modules
instead. Both properties can be defined without problem. To preserve
the pom-less build, a new profile is activated in the presence of the
sonar.skip.properties file. So each module we do not want to analyse
with maven have to contain this file.

Change-Id: I6bf8115540744e48a9431f63ba96c504917f35e3
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/71270
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agoAdjust code to latest JDT changes
Alexandre Montplaisir [Tue, 26 Apr 2016 19:51:50 +0000 (15:51 -0400)] 
Adjust code to latest JDT changes

Disable @NNBD on methods extending ITmfTrace.initTrace due to
unconstrained Class<> parameter in base class. See bug 485988.

Change-Id: I6bee371dec7c53063a2a619bda8c22117fe756de
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/71471
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agotmf: Fix TmfProjectModelElement.equals()
Patrick Tasse [Thu, 28 Apr 2016 17:47:27 +0000 (13:47 -0400)] 
tmf: Fix TmfProjectModelElement.equals()

Elements of different types but with equal path should not be considered
equal. This avoids clashes between trace names and 'virtual' resource
name used by some elements, such as module id for an analysis element.

Change-Id: Id2238a9e8fe4ba9b8daede86b3a2b54d0de3b815
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/71628
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
8 years agolttng.ust: Implement a symbol provider for LTTng-UST traces
Alexandre Montplaisir [Wed, 23 Mar 2016 01:37:36 +0000 (21:37 -0400)] 
lttng.ust: Implement a symbol provider for LTTng-UST traces

This new symbol provider will make use of the "Debug Info"
analysis, which means it will only be available for traces
taken with LTTng-UST >= 2.8.

It will call into the existing BinaryCallsite and SourceCallsite
aspects to get the function name of a given address.

The provider's configuration page will allow specifying the
"root directory" of a target image. This is useful in cases
where a trace is taken on a remote target, and an image of that
target is available locally.

Since paths are found directly in the trace, this means that a
trace with the proper information taken on the same system
should show the function names in the Callstack View without
the need for the user to configure anything!

Possible future improvements:
- Split the symbol provider extension point in core and ui parts
- Merge the FileOffsetMapper logic with the core parts of the
  symbol provider.
- Move the "current path prefix" configuration from the trace
  object to the core symbol provider.

References bug 484042

Change-Id: Ia346c1eab2b54a54ddf672c7ffafd0655a47ee34
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/69973
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agolttng.ust: Introduce a cache of the calls to addr2line
Alexandre Montplaisir [Tue, 5 Apr 2016 23:02:11 +0000 (19:02 -0400)] 
lttng.ust: Introduce a cache of the calls to addr2line

Since calling an external process is relatively costly, we can
cache the results of the calls so future lookups can reuse the
information.

Change-Id: I5d84be78d45b893ea5942bdd5d2459faf4574af5
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/69972
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agolttng : Add SWTBot test for TimeGraphFindDialog
Jean-Christian Kouame [Wed, 13 Apr 2016 19:00:36 +0000 (15:00 -0400)] 
lttng : Add SWTBot test for TimeGraphFindDialog

The find dialog is tested on both Resources View and Control Flow View

Change-Id: Ic26c9c986cdc9422d9a69015472c3edad4cacda4
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70602
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
8 years agotmf: Fix selectAndReveal() in timegraphViewer
Jean-Christian Kouame [Tue, 26 Apr 2016 21:44:36 +0000 (17:44 -0400)] 
tmf: Fix selectAndReveal() in timegraphViewer

This fix handles the selectAndReveal() as if it came from an internal
source (triggered by the user) since the method is called from the
FindDialog. The selection should not be ignored when a pending selection
change is awaiting to be notified.

Change-Id: I1be75843b3fcb463eefa2c7587226205424b9c62
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/71484
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
8 years agodoc: Update LTTng-UST Callstack documentation
Alexandre Montplaisir [Wed, 6 Apr 2016 20:39:34 +0000 (16:39 -0400)] 
doc: Update LTTng-UST Callstack documentation

* Document that the 'vpid' context should now be enabled (it is not
  mandatory, but it's ideal to have it).
* Mention both the "Import Binary" and "Import Mapping File" methods
* Mention that the import step is only necessary for traces taken
  with UST < 2.8.

Change-Id: I2fd76ba41ffd166a76c20ce7929a7b7769974b29
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/70081
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
8 years agotmf: Make Callstack View pass timestamps and PIDs to symbol provider
Alexandre Montplaisir [Tue, 5 Apr 2016 19:34:31 +0000 (15:34 -0400)] 
tmf: Make Callstack View pass timestamps and PIDs to symbol provider

Now that the Callstack analysis and view track the PIDs of each
function entry/exit, it can pass them along with the timesteamps
to the symbol providers, so that provider implementations making
use of the new methods can resolve symbols in the view too.

Also add proper comparison logic for ProcessEntries, they can use
numerical comparaison of the PID they now carry.

Change-Id: I7404ab4b893878dbdd8e526a646014739cfbe228
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/69970
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
8 years agotmf: Introduce the notion of PID to the Callstack analysis
Alexandre Montplaisir [Tue, 19 Apr 2016 23:43:27 +0000 (19:43 -0400)] 
tmf: Introduce the notion of PID to the Callstack analysis

The current Callstack View/Analysis does not handle PIDs (process IDs)
only TIDs (thread IDs).

This works fine with the basic use case of a trace with only one,
single-threaded process. But since callstacks are per thread, but
symbol resolution is per-process, the callstack analysis should be
augmented to know about both concepts.

Change-Id: I6a6ad5f92e18c3c161390237b8dea513dc9ce8cf
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/69870
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
8 years agolttng: cleanup callstack requirement test
Francis Giraldeau [Wed, 27 Apr 2016 16:30:25 +0000 (12:30 -0400)] 
lttng: cleanup callstack requirement test

Reduce code duplication using static enum data. The file is 200 lines
shorter and new test are easier to add.

Change-Id: I8a67470d7fab53ca1a46b052bee3aa1354a906fe
Signed-off-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Reviewed-on: https://git.eclipse.org/r/71537
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
8 years agoanalysis: change the SHT file name for the kernel analysis
Cédric Biancheri [Mon, 25 Apr 2016 21:20:23 +0000 (17:20 -0400)] 
analysis: change the SHT file name for the kernel analysis

The name of the file was not explicit. It is now the ID of the analysis.

Change-Id: I0fac8475c4d459389ff1b9c718b82d4381655dce
Signed-off-by: Cédric Biancheri <cdc.biancheri@gmail.com>
Reviewed-on: https://git.eclipse.org/r/71375
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
8 years agolttng: Update SWTBot tests to use MI 3.0 (LTTng 2.8)
Marc-Andre Laperle [Tue, 26 Apr 2016 22:12:33 +0000 (18:12 -0400)] 
lttng: Update SWTBot tests to use MI 3.0 (LTTng 2.8)

In addition to being more up to date, it will solve an issue encountered
when the tests run in a workspace with a long path.

Change-Id: Ie0e02e09454fb9b9ee95b4c35d9f0da041182205
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/71485
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
8 years agolttng: Add ControlService tests for LTTng MI 3.0
Marc-Andre Laperle [Mon, 25 Apr 2016 22:24:44 +0000 (18:24 -0400)] 
lttng: Add ControlService tests for LTTng MI 3.0

The MI 3.0 schema was added but no tests were using it yet.
This patch adds tests to make use of this new protocol.

Change-Id: If31665a4bc94fd0392accda1a6eaf2382c944d47
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/71380
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
8 years agolttng: Add schema for LTTng MI 3.0 (LTTng 2.8)
Marc-Andre Laperle [Fri, 8 Apr 2016 03:45:48 +0000 (23:45 -0400)] 
lttng: Add schema for LTTng MI 3.0 (LTTng 2.8)

This makes it possible to use the LTTng Control view with schema
validation enabled and LTTng 2.8. The MI service is modified to be able
to handle a different schema depending on the LTTng version.

Change-Id: I85ec15edc3f0ce942d8df8637eadba3968fef1ca
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70188
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
8 years agotmf: Add a method to verify if analysis is ready at timestamp
Geneviève Bastien [Fri, 1 Apr 2016 20:29:00 +0000 (16:29 -0400)] 
tmf: Add a method to verify if analysis is ready at timestamp

First step to resolve bug 488757. This new method will return whether an
analysis is ready to be queried at a given timestamp.

Change-Id: I2a1f597d503fe74664df95d0bb5c4c16952b6376
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/69753
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
8 years agotmf.core.tests: Add method to simplify XML Trace stub setup
Geneviève Bastien [Mon, 4 Apr 2016 19:58:40 +0000 (15:58 -0400)] 
tmf.core.tests: Add method to simplify XML Trace stub setup

Change-Id: I7c59f26d0bf89b85aa648a452641d3b3edae59b2
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/70034
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
8 years agotmf.core: Internalize timestamp types
Matthew Khouzam [Tue, 19 Apr 2016 03:12:23 +0000 (23:12 -0400)] 
tmf.core: Internalize timestamp types

Move timestamp implementations to an internal package.

Change-Id: I2705c11a4a2cf91204854e726c798c37b30bec6a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70246
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
8 years agotmf.core: simplify timestamp implementations
Matthew Khouzam [Fri, 8 Apr 2016 14:25:19 +0000 (10:25 -0400)] 
tmf.core: simplify timestamp implementations

This patch makes BIG_BANG and BIG_CRUNCH and ZERO special singleton
objects. They now normalize to themselves. Big bang and big crunch are
always the largest or smallest values.

It also internalizes TmfRealTimestamp inside TmfTimestamp as
TmfTimestamp$Impl.

The timestamp comparison is very streamlined. The performance
should be similar though.

One bug found that will never occur in the real world:
additions with -Long.MIN_VALUE gave errors as -Long.MIN_VALUE ==
LONG.MIN_VALUE.

Change-Id: I284ed1b8f0dd1f6d5299e172dd07128d53ac5945
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70245
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
8 years agotmf: Bug 491714: Fix population of XmlTimeGraphView for experiments
Bernd Hufmann [Thu, 14 Apr 2016 15:45:27 +0000 (11:45 -0400)] 
tmf: Bug 491714: Fix population of XmlTimeGraphView for experiments

With this patch the XmlTimeGraphView is populated with the content of
all traces part of an experiment.

When rebuilding the event list the view cache (event list, filters,
view context) is cleared. This is important because right now
there is only one instance of XmlTimeGraphView per trace even if there
are more than one XML analyses and views defined.

Change-Id: I535cace0089147bea4584c5af8b7a0c57157bd36
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70681
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
8 years agolttng: Fix not being able to get available context with LTTng 2.8
Marc-Andre Laperle [Mon, 18 Apr 2016 17:43:41 +0000 (13:43 -0400)] 
lttng: Fix not being able to get available context with LTTng 2.8

'lttng add-context -h' was replaced with 'lttng add-context --list' in LTTng 2.8

Bug: 491933
Change-Id: If277b86410a5d19cfa53531b03dfb5b7350c4c5b
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70894
Reviewed-by: Hudson CI
8 years agotmf: Add/update '-', '+' and '*' key handling in TimeGraphViewer
Bernd Hufmann [Wed, 13 Apr 2016 01:40:10 +0000 (21:40 -0400)] 
tmf: Add/update '-', '+' and '*' key handling in TimeGraphViewer

The handling of '-'and '+' key have been updated when the mouse is over
the namespace. Before they were used for time zooming regardless of the
mouse position. The handling of '*' key has been added when the mouse
is over the namespace.

When the mouse is over the namespace, pressing the
- key '-' will collapse recursively selected entry
- key '+' will expand selected entry
- key '*' will expand selected entry to the level with at least one
  collapsed entry

This patch is to align the keystroke handling to the TimeGraphCombo.

Change-Id: I964168bd1aa388430775055a39f625beaffb5985
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70583
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
8 years agotmf: fix conflicting find handler message in time graph views
Bernd Hufmann [Mon, 18 Apr 2016 17:59:52 +0000 (13:59 -0400)] 
tmf: fix conflicting find handler message in time graph views

Change-Id: Icf6ff1772acad9b86278e507b0cf987fba859857
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70896
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
8 years agolttng: Fix filters not shown with LTTng 2.8
Marc-Andre Laperle [Mon, 18 Apr 2016 19:37:06 +0000 (15:37 -0400)] 
lttng: Fix filters not shown with LTTng 2.8

In LTTng 2.8, a new MI field was added, filter_expression.
This needs to be handled by Trace Compass.

Bug: 491941
Change-Id: If1e796ca24d5542422f61f63c91cb4c37d702edd
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70905
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
8 years agolttng: Make schema validation optional
Marc-Andre Laperle [Fri, 8 Apr 2016 03:21:29 +0000 (23:21 -0400)] 
lttng: Make schema validation optional

With this change, the schema validation is disabled by default except
for tests. The validation can be enabled easily as a Tracing option
in the launch configuration. To be able to enable this by default for
tests, it is also exposed in a system variable which could also be
used on the command-line.

Change-Id: I492f2877a7e066e14176a209159da17cea83c3f1
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70199
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
8 years agotmf: Update setting of minimum size of dialog box
Bernd Hufmann [Thu, 14 Apr 2016 01:46:05 +0000 (21:46 -0400)] 
tmf: Update setting of minimum size of dialog box

Change-Id: I6a5e722c5a435ea8d34eafe8312a429c710f0503
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70606
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
8 years agolttng.ust: Retrieve the function name when calling addr2line
Alexandre Montplaisir [Tue, 5 Apr 2016 22:19:51 +0000 (18:19 -0400)] 
lttng.ust: Retrieve the function name when calling addr2line

Add the -f flag to also query function/symbol names. This will
allow us to populate the "function name" field of the generated
callsite objects, which in turn will populate the Callstack View
appropriately.

Also pass the -C flag, which demangles C++ function names, without
apparantly affecting native names.

Change-Id: Ife6e8581347ab2f94558e258dc350a4c1b04c3fa
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/69971
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
8 years agotmf: Update BasicSymbolPrefPage dialog description
Alexandre Montplaisir [Sat, 9 Apr 2016 22:36:32 +0000 (18:36 -0400)] 
tmf: Update BasicSymbolPrefPage dialog description

"provider" is an internal implementation concept the user
won't know about.

Change-Id: I3be1167f32183f4ad78d4e2135fda50466d3a024
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/70315
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
8 years agotmf: Rework TmfTraceUtils#resolveIntEventAspectOfClassForEvent
Alexandre Montplaisir [Mon, 4 Apr 2016 19:49:43 +0000 (15:49 -0400)] 
tmf: Rework TmfTraceUtils#resolveIntEventAspectOfClassForEvent

The generic type bound now ensures the aspect class passsed to
resolveIntEventAspectOfClassForEvent() really resolves to an
Integer, which means we can skip the check.

Also rework both aspect-finding methods to use flat Stream operations.

Change-Id: I8a341021699a69ac21b7a147c9ea91d58619fa99
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/69856
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
8 years agoUpgrade to Tycho 0.25.0
Marc-Andre Laperle [Fri, 8 Apr 2016 20:40:04 +0000 (16:40 -0400)] 
Upgrade to Tycho 0.25.0

See https://wiki.eclipse.org/Tycho/Release_Notes/0.25

Change-Id: I309392787e2f1c8b041e4c83648b4a096e8032e4
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70296
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
8 years agotmf.core: Introduce TmfTimestamp factory methods
Matthew Khouzam [Sun, 28 Feb 2016 14:59:03 +0000 (09:59 -0500)] 
tmf.core: Introduce TmfTimestamp factory methods

Often times, a TmfTimestamp will be created using a scale of -9 or 0.
The result is a less efficient timestamp that takes more memory than
the nano or simple timestamp and is slower to compare. This patch makes
timestamps created always return the more efficient type.

At the moment, the factory will either create a new TmfNanoTimestamp if the
scale is NANOSECOND_SCALE, TmfSecondTimestamp if the scale is SECOND_SCALE,
or a plain old TmfTimestamp (TmfRealTimestamp).

This patch adds the following helper methods:
* create(value, scale) - create a timestamp with an arbitrary scale and value
* fromNanos(value) - create a nanosecond based timestamp (more efficient)
* fromMicros(value) - create a microsecond based timestamp
* fromMillis(value) - create a millisecond based timestamp
* fromSeconds(value) - create a second based timestamp (more efficient)

Also, TmfTimestamp is converted to an abstract class with "getScale()" and
"getValue()" needing to be implemented. This allows a timestamp like
TmfNanoTimestamp or TmfSecondTimestamp to not store an extra integer and
save 33% of their sizes.

Change-Id: I0996c9b4f626a70436b58e82446ed69d2e50af98
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65312
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
8 years agoanalysis: Add count column to latency statistics view
Jean-Christian Kouame [Fri, 15 Apr 2016 17:45:57 +0000 (13:45 -0400)] 
analysis: Add count column to latency statistics view

Change-Id: Id2db373022a6c1b78ddac2a6c7b580459c189f3a
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70895
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
8 years agotmf.ui: callstack - replaced multiple single SS queries by full query
Loïc Prieur-Drevon [Mon, 18 Apr 2016 12:10:33 +0000 (08:10 -0400)] 
tmf.ui: callstack - replaced multiple single SS queries by full query

CallStackView would do a single query for every thread,
at the start of the statesystem, or at the end of the
statesystem.
This patch replaces all single queries in buildEntryList
by two full queries and reads to the result of those queries

Change-Id: Id59b355fd84bfc0b8e30ef3f3f375f8ca0dbe634
Signed-off-by: Loïc Prieur-Drevon <loic.prieurdrevon@gmail.com>
Reviewed-on: https://git.eclipse.org/r/70854
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
8 years agotmf : Add pattern analysis behavior
Jean-Christian Kouame [Wed, 9 Mar 2016 19:25:39 +0000 (14:25 -0500)] 
tmf : Add pattern analysis behavior

This patch defines the behavior of the pattern analysis state provider
and defines all the models needed.

Change-Id: I6561feb02b06627ef5059d777a25a8bde56a70be
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65751
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
8 years agoanalysis: Bug 489573: Internalize Control Flow view implementation
Bernd Hufmann [Tue, 22 Mar 2016 11:12:48 +0000 (07:12 -0400)] 
analysis: Bug 489573: Internalize Control Flow view implementation

Change-Id: I92e81e1b158cb5dbf1910f9d25b880482fdb3355
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/69007
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agolttng: Add analysis requirements for LTTng UST Call Stack analysis
Bernd Hufmann [Fri, 11 Mar 2016 18:31:07 +0000 (13:31 -0500)] 
lttng: Add analysis requirements for LTTng UST Call Stack analysis

With this the user gets notified when the call stack analysis cannot be
executed. The help text will give some details about this.

Change-Id: Ib3628606a74ae5e83b60fde81720f7035d7eae86
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68235
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
8 years agotmf: add events field analysis requirement class and test
Bernd Hufmann [Fri, 11 Mar 2016 18:27:04 +0000 (13:27 -0500)] 
tmf: add events field analysis requirement class and test

This class allows to specify required events fields for one given event
type.

This class is useful for CTF, where optional event contexts are provided
as event fields.

Moreover, this will be useful for custom txt and xml trace types, where
for each event the event type is the same but the event fields might
be different.

Change-Id: I445976ea7b93ee95be887504bc223912c2cab298
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68233
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
8 years agotmf: Add generics to ITmfEventAspect
Alexandre Montplaisir [Wed, 30 Mar 2016 23:31:45 +0000 (19:31 -0400)] 
tmf: Add generics to ITmfEventAspect

The generic type can allow us to define the type of
the resolve() method's return value.

Change-Id: Id9bb9ddaf143fa6b3ed09bf32eab98e1718e7ee3
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/69569
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
8 years agoanalysis.os: Add layouted requirements to the CPU analysis
Geneviève Bastien [Tue, 8 Mar 2016 20:41:40 +0000 (15:41 -0500)] 
analysis.os: Add layouted requirements to the CPU analysis

That patch attempts to bring back the concept of requirements to linux kernel
analyses. The requirements were disabled since the event layouts appeared.

Change-Id: I12b4befa69c94ca7205ea0db7670ee126788dc42
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/68015
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
8 years agoanalysis.linux.ui: Make disk io display read before write
Matthew Khouzam [Fri, 15 Apr 2016 17:27:23 +0000 (13:27 -0400)] 
analysis.linux.ui: Make disk io display read before write

This is more inline with the typical views of hard disk usage.

An added bonus is that reads are blue and writes are red. It is better
to avoid red/green for accessibility reasons, and typically red == write.

Change-Id: I7397fdd72539646ba2fbe79f8258580bb45908d0
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70779
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
8 years agolttng.ui: move UST memory legend to left
Matthew Khouzam [Fri, 15 Apr 2016 17:18:57 +0000 (13:18 -0400)] 
lttng.ui: move UST memory legend to left

This maximizes readability.

Change-Id: I36c08a5f16477e1c60752a2efd7b2c4698dc5589
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70778
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
8 years agotmf.ui: make CommonXLineChartViewer hide the X axis label by default.
Matthew Khouzam [Fri, 15 Apr 2016 17:06:23 +0000 (13:06 -0400)] 
tmf.ui: make CommonXLineChartViewer hide the X axis label by default.

The X axis label is always "Time" for the common line chart viewer, this
patch saves some vertical space by not displaying it.

The legend is moved by default to the bottom, this saves a lot of space
due to time alignment.

Change-Id: I965290de363d2196140e03e60f3abe69fe35efb0
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70776
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
8 years agotmf: Fix NPE in XmlPresentationProvider for undefined states
Bernd Hufmann [Wed, 9 Mar 2016 16:18:16 +0000 (11:18 -0500)] 
tmf: Fix NPE in XmlPresentationProvider for undefined states

A NullPointerException was caused when creating a state tooltip for
state values that are not defined in the XML definition.

This patch avoids the NPE in this case. The state tooltip won't be
shown when this happens.

Change-Id: I07ca75d7bb39d3479c225b4b144e1acc119eae3b
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68072
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agoos.linux.ui: Remove redundant query in ResourcesPresentationProvider
Loïc Prieur-Drevon [Fri, 15 Apr 2016 14:41:05 +0000 (10:41 -0400)] 
os.linux.ui: Remove redundant query in ResourcesPresentationProvider

getEventHoverToolTipInfo would do a full state query then
a single query for each CPU/IRQ.
This patch replaces the single query by reading the full
state results.

Change-Id: I10959152e094674b8276608dddb2fe03368f1d96
Signed-off-by: Loïc Prieur-Drevon <loic.prieurdrevon@gmail.com>
Reviewed-on: https://git.eclipse.org/r/70765
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
8 years agoreleng: Fix Mylyn update site in targets
Marc-Andre Laperle [Mon, 18 Apr 2016 03:56:58 +0000 (23:56 -0400)] 
releng: Fix Mylyn update site in targets

Mylyn 3.19 was release and no new milestones has been produced so
we can use that release until (if) there is a new one for Neon.

Change-Id: I150eb050bcbb576ac2deda102451e02575c78e66
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70830
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Hudson CI
8 years agotmf: Make Analysis Requirements implement Predicates
Matthew Khouzam [Wed, 6 Apr 2016 18:05:07 +0000 (14:05 -0400)] 
tmf: Make Analysis Requirements implement Predicates

This allows us to use requirements as filters.

Change-Id: Ib103e7fec613455e140d5c63c24e7d2f53248d9c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70049
Reviewed-by: Hudson CI
8 years agotmf.common: Fix boundaries in data size formatter
Michael Jeanson [Thu, 14 Apr 2016 19:11:37 +0000 (15:11 -0400)] 
tmf.common: Fix boundaries in data size formatter

This patch fixes the display of units on boundaries,for example
"1024" will be displayed as "1 KB" instead of "1024 B".

Change-Id: I3464d1d54e05254f3133d76faf2b75890690b766
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Reviewed-on: https://git.eclipse.org/r/70698
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
8 years agotmf: Add an event names requirement
Geneviève Bastien [Tue, 8 Mar 2016 20:40:10 +0000 (15:40 -0500)] 
tmf: Add an event names requirement

It is preferable to use inheritance instead of String-typed values.

Change-Id: I62eaa0f7a01ac459ed06c471379f8f20bcd9b4ef
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/68014
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agoenable new performance benchmarks.
Matthew Khouzam [Wed, 13 Apr 2016 18:25:18 +0000 (14:25 -0400)] 
enable new performance benchmarks.

Change-Id: Iae2f6ec13f60fd5a203c08c1eeed63866a0ac74f
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70584
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
8 years agolinux: tid analysis benchmark
Matthew Khouzam [Wed, 13 Apr 2016 16:36:36 +0000 (12:36 -0400)] 
linux: tid analysis benchmark

This benchmark is nearly identical to the kernel usage benchmark, but it uses
the tid analysis. It should be interesting to compare and contrast the two.

Change-Id: I6db6ce5142c518e2d79959a4724db56ee1401348
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70578
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
8 years agoanalysis.os: Benchmark some typical usages of Kernel Analysis
Geneviève Bastien [Thu, 25 Feb 2016 03:48:44 +0000 (22:48 -0500)] 
analysis.os: Benchmark some typical usages of Kernel Analysis

This adds benchmark of getting the thread running on a CPU from a kernel
analysis and making full queries on that analysis.

It paves the way to adding some more of those benchmarks.

Change-Id: I853a350a7647973b87e49dabaf2ac14b09cd0136
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/67444
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agoRevert "ss: Add serialization logic to state values"
Alexandre Montplaisir [Thu, 14 Apr 2016 21:24:57 +0000 (17:24 -0400)] 
Revert "ss: Add serialization logic to state values"

This reverts commit ce148788289534e20b56d0790a8ad93ce2e6473d.

Change-Id: I81e3a1f3557ef8edceaf930ba9b8d8cb3b23f200
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/70711
Reviewed-by: Hudson CI
8 years agoRemove MaxPermSize from all launchers
Michael Jeanson [Thu, 14 Apr 2016 19:29:44 +0000 (15:29 -0400)] 
Remove MaxPermSize from all launchers

The Permanent Generation space was completely removed from Java 8,
using the MaxPermSize parameter only prints a warning and has no
effect on the JVM.

Change-Id: I1d378c0c09a9d8a2861e0d39bfe3bbdf37df0bad
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Reviewed-on: https://git.eclipse.org/r/70700
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agotmf : Move preconditions at the same level as states in the XML file
Jean-Christian Kouame [Fri, 8 Apr 2016 19:20:45 +0000 (15:20 -0400)] 
tmf : Move preconditions at the same level as states in the XML file

Change-Id: Ib4a6c59d841831d4b91298970cda039272149e04
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70292
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agoos.linux: Bump KernelStateProvider version number
Raphaël Beamonte [Thu, 14 Apr 2016 16:27:23 +0000 (12:27 -0400)] 
os.linux: Bump KernelStateProvider version number

Previous commits changed the content generated by the
KernelStateProvider for process' priorities and exec
names. Bumping the version number allows to take advantage
of those changes without manually removing the history
tree.

Change-Id: Iad483b0f3c51fb53242264948f52e98709ebb1bc
Signed-off-by: Raphaël Beamonte <raphael.beamonte@gmail.com>
Reviewed-on: https://git.eclipse.org/r/70688
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Hudson CI
8 years agodoc : Add user guide for time graph Find dialog
Jean-Christian Kouame [Mon, 11 Apr 2016 17:37:11 +0000 (13:37 -0400)] 
doc : Add user guide for time graph Find dialog

Change-Id: I27f17a27373270ccbe7af302dd85308d14a8f8f5
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70409
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agoSchedSwitchHandler: rename private methods
Raphaël Beamonte [Tue, 12 Apr 2016 20:34:44 +0000 (16:34 -0400)] 
SchedSwitchHandler: rename private methods

The setNewProcessPrio and setNewProcessExecName methods
were respectively renamed setProcessPrio and
setProcessExecName as the 'New' part of the name can be
confusing with the 'next process' when handling a
sched_switch event. The parameters of those methods have
been renamed accordingly.

Change-Id: Id1c0f00f165e2d906cb7650d511b1bebc20d4b1e
Signed-off-by: Raphaël Beamonte <raphael.beamonte@gmail.com>
Reviewed-on: https://git.eclipse.org/r/70514
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
8 years agoSchedSwitchHandler: update the exec name of the former process
Raphaël Beamonte [Tue, 12 Apr 2016 20:32:53 +0000 (16:32 -0400)] 
SchedSwitchHandler: update the exec name of the former process

Update the SchedSwitchHandler class to update the exec name of
the former process as well as the one of the new one. This
allows to keep a 'sort of' up to date exec name in the absence
of other events updating it.

Change-Id: Ie0a1ebc5b64214150edb0b41b62ccaab4447b041
Signed-off-by: Raphaël Beamonte <raphael.beamonte@gmail.com>
Reviewed-on: https://git.eclipse.org/r/70513
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
8 years agoSchedSwitchHandler: update the priority of the former process
Raphaël Beamonte [Tue, 12 Apr 2016 17:48:33 +0000 (13:48 -0400)] 
SchedSwitchHandler: update the priority of the former process

Update the SchedSwitchHandler class to update the priority of
the former process as well as the one of the new one. This
allows to keep a 'sort of' up to date priority in the absence
of other events updating it.

Change-Id: Ie0da99274b9c932a0784dbd737d3279f2cfa6165
Signed-off-by: Raphaël Beamonte <raphael.beamonte@gmail.com>
Reviewed-on: https://git.eclipse.org/r/70504
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
8 years agoanalysis: Bug 489573: Internalize Resources view implementation
Bernd Hufmann [Tue, 22 Mar 2016 11:29:09 +0000 (07:29 -0400)] 
analysis: Bug 489573: Internalize Resources view implementation

Change-Id: I35fc6e359b2727b19ad77e5788bb9e7c0f1dfb51
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/69008
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agoanalysis: Bug 489573: Internalize CPU Usage view implementation
Bernd Hufmann [Tue, 22 Mar 2016 11:37:39 +0000 (07:37 -0400)] 
analysis: Bug 489573: Internalize CPU Usage view implementation

Change-Id: I45e930b51b718f0fd469096f968b8484965b0971
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/69009
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
8 years agotmf: Bug 491548: Do not incrementally build full time graph event list
Patrick Tasse [Tue, 12 Apr 2016 21:42:22 +0000 (17:42 -0400)] 
tmf: Bug 491548: Do not incrementally build full time graph event list

The full event list should be recomputed for the full range at every
iteration of the build thread. If built incrementally it can create too
many events in the full event list.

The build thread should not insert NullTimeEvent in the full event list.

Change-Id: I2523291197b2d93267b2aa799e6126ea74eea0f9
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/70519
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agotmf: Update AbstractTimeGraphView and TimeGraphEntry API
Patrick Tasse [Thu, 7 Apr 2016 22:13:55 +0000 (18:13 -0400)] 
tmf: Update AbstractTimeGraphView and TimeGraphEntry API

AbstractTimeGraphView.buildEventList() is renamed to buildEntryList()
which is more representative of its implementation. The Javadoc of this
method and getEventList() is improved to better explain their use.

TimeGraphEntry methods setParent(), getParent(), getChildren() and
addChild(...) are changed to restrict the entries to TimeGraphEntry.
This avoids instanceof checks in AbstractTimeGraphView implementations,
and avoids unexpected behavior in case a child or parent entry is not of
type TimeGraphEntry.

Change-Id: Ibf1c3f3fad467ab7ff215fd2552bb3350f00ef7e
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/70185
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agotmf.test: Use SWTBotJunit4ClassRunner in every SWTBot test
Marc-Andre Laperle [Wed, 13 Apr 2016 16:58:27 +0000 (12:58 -0400)] 
tmf.test: Use SWTBotJunit4ClassRunner in every SWTBot test

Using the runner will produce screenshots if a test fails.

Change-Id: I6460bf1eb230ea2b3fe8cfd86ee8bc01399cb24f
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70579
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
8 years agolttng: Make ZoomThread more thread-safe (also helps ResourcesViewTest)
Marc-Andre Laperle [Tue, 12 Apr 2016 19:38:02 +0000 (15:38 -0400)] 
lttng: Make ZoomThread more thread-safe (also helps ResourcesViewTest)

In AbstractTimeGraphView and extenders, when a ZoomThread applies its
results (links, markers), there is no guarantee of the order in the
presence of multiple ZoomThreads.
For example, in the case where a new ZoomThread is started and an old
one is still executing, the old one might be canceled so late that it
will still apply its results and do so *after* the new ZoomThread
completes. This change introduces some synchronization to make sure the
results are applied only in the case of the last ZoomThread spawned.

To reproduce this issue, go to AbstractTimeGraphView.getTraceMarkerList
and add a Thread.sleep(5000); before and after the isCanceled() check.
Because the test takes much longer, you need to increase the timeout in
ResourcesViewTest.timeGraphIsReadyCondition. Then you can run
ResourcesViewTest in a loop using SWTBotStressTests and after a few
iterations, it should fail.

Change-Id: If41f7b264676c04538cdc39c5c9bb40507b7e521
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70510
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agotmf: Increase timeout for indexing in TestRefreshTextTrace
Marc-Andre Laperle [Wed, 13 Apr 2016 17:31:02 +0000 (13:31 -0400)] 
tmf: Increase timeout for indexing in TestRefreshTextTrace

The additional output added recently to this test confirmed that
during the test, the trace is being slowly indexed without being
stuck and ends up timing out. This change significantly increases
the timeout (20 secs to 5 mins) in order to allow more indexing
time when the machine running the test is under heavy load.

Change-Id: I8e76ced07a5a09b6bd14a7b11d12c925c1ce3df2
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70581
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agotmf : Add search dialog to timegraph views
Jean-Christian Kouame [Tue, 22 Mar 2016 19:15:40 +0000 (15:15 -0400)] 
tmf : Add search dialog to timegraph views

The search dialog is based on the Eclipse FindReplaceDialog
implementation.

Change-Id: Id0758fc7e709d1d66778e0fc33d9f848b626cc70
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/69484
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agoIKernelAnalysisEventLayout: add fieldPrevPrio() method
Raphaël Beamonte [Tue, 12 Apr 2016 17:46:32 +0000 (13:46 -0400)] 
IKernelAnalysisEventLayout: add fieldPrevPrio() method

Adds a fieldPrevPrio() method in the layout to access the
priority of the previous process. Up to now, we could access
the previous process' name, but its priority can be useful.

Change-Id: I52c9ae1f3ba377139702e8cd4a6aad75cac7757c
Signed-off-by: Raphaël Beamonte <raphael.beamonte@gmail.com>
Reviewed-on: https://git.eclipse.org/r/70503
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
8 years agoswtbot: Add SWTBot tests for time graph marker axis
Patrick Tasse [Thu, 17 Mar 2016 15:18:57 +0000 (11:18 -0400)] 
swtbot: Add SWTBot tests for time graph marker axis

Change-Id: I885d3b880bd875012b2b4f2a3b13b9f7e3a4553a
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/68682
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agoUpgrade jboss repository-utils to 0.23.3
Marc-Andre Laperle [Mon, 11 Apr 2016 14:11:31 +0000 (10:11 -0400)] 
Upgrade jboss repository-utils to 0.23.3

This is the latest release.

Change-Id: Iad05716cb3a4c3da07cba1a8022c54cbf3828e10
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70367
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
8 years agotmf: Bug 491346: fix time pinning of CallStackView for window ranges
Bernd Hufmann [Fri, 8 Apr 2016 17:44:20 +0000 (13:44 -0400)] 
tmf: Bug 491346: fix time pinning of CallStackView for window ranges

Change-Id: If7668535ca2cf26f0bf1a499ca3a606f31527eaa
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70281
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agotmf.ui: Add Lambdas to TimeGraphCombo
Matthew Khouzam [Mon, 11 Apr 2016 15:07:26 +0000 (11:07 -0400)] 
tmf.ui: Add Lambdas to TimeGraphCombo

Change-Id: Ic8e5ee349256bbc6a523b3453dddb49128323d2d
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70389
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agoos.linux: Move buildThreadAttributeName() methods to Attributes interface
Alexandre Montplaisir [Fri, 8 Apr 2016 21:41:23 +0000 (17:41 -0400)] 
os.linux: Move buildThreadAttributeName() methods to Attributes interface

The method buildThreadAttributeName() and its counterpart
parseThreadAttributeName() are related to attributes tree
walking, and not to the event handlers themselves. Move them
to the Attributes interface.

Change-Id: Ide7b7154cfff0e12f74eda7a64f3545114b93e80
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/70298

8 years agoos.linux: Move Attributes class to internal package
Alexandre Montplaisir [Mon, 11 Apr 2016 21:06:24 +0000 (17:06 -0400)] 
os.linux: Move Attributes class to internal package

The os.linux.kernel analysis should eventually encapsulate all
its state system accesses, which means clients should not call
the Attributes class directly. Move Attributes class to the
analysis's internal package so it gets removed from the API.

We can make some known users x-friends for now, but eventually
they should be moved to using the real API.

Change-Id: I0b78c8ff88b039311d89d6313d40c2e9381c29af
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/70424

8 years agoFix typo in method name: setNewProcessPio -> setNewProcessPrio
Raphaël Beamonte [Tue, 12 Apr 2016 17:37:45 +0000 (13:37 -0400)] 
Fix typo in method name: setNewProcessPio -> setNewProcessPrio

An obvious typo was introduced in that method whose function is to
update the new process priority.

Change-Id: Id0600f339426c147fb75f0f157769298c3b6dfe7
Signed-off-by: Raphaël Beamonte <raphael.beamonte@gmail.com>
Reviewed-on: https://git.eclipse.org/r/70502
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
8 years agotmf: add support for enter to expand/collapse tree TimeGraphCombo
Bernd Hufmann [Fri, 8 Apr 2016 15:13:24 +0000 (11:13 -0400)] 
tmf: add support for enter to expand/collapse tree TimeGraphCombo

This aligns the behavior of the TimeGraphViewer.

Change-Id: I211d69d72353622b380bbef88802d2745407b10f
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70257
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
8 years agotmf: Fix CopyToClipboardTest
Marc-Andre Laperle [Tue, 12 Apr 2016 14:13:36 +0000 (10:13 -0400)] 
tmf: Fix CopyToClipboardTest

The contextMenu method in SWTBot now throws (properly) a
WidgetNotFoundException instead of a TimeoutException

Change-Id: I9e7b8e469134ed7836923bbdd2d59ae9cf3eff59
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70478
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
8 years agotmf: Support for context-sensitive menu in Time Graph viewers
Bernd Hufmann [Thu, 7 Apr 2016 13:06:55 +0000 (09:06 -0400)] 
tmf: Support for context-sensitive menu in Time Graph viewers

Up to now, there was a specific context-sensitive menu in the
Resources Flow view using the right mouse button on the namespace.

This commit adds a generic support for context-sensitive menus to the
AbstractTimeGraph views when using Time Graph viewers alone. It allows
extending classes to add both programmatically and declaratively
(using the plug-in.xml) menu entries to the context-sensitive menu.

The implementation of the Resources view have been adjusted to use this
new API

Change-Id: Ic9f3ff08fda27ffabc91d6054fe460b8fc764835
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70140
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agotmf: Fix ISelectionProvider implementation of TimeGraphControl
Bernd Hufmann [Thu, 7 Apr 2016 12:34:21 +0000 (08:34 -0400)] 
tmf: Fix ISelectionProvider implementation of TimeGraphControl

The TimeGraphControl class implements ISelectionProvider interface
put never notifies the registered as ISelectionChangedListener.

Change-Id: I71ebc17c215a5e1e487f9488bb0727ebef898d31
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70139
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
8 years agotmf: Fix mouse detect handling in TimeGraphControl
Bernd Hufmann [Thu, 7 Apr 2016 12:42:38 +0000 (08:42 -0400)] 
tmf: Fix mouse detect handling in TimeGraphControl

Prevent the menu be shown before mouse up event is received. Otherwise
the zoom won't work. This is because the mouse up event will be received
by the menu pop-up and not by the TimeGraphControl instance.

Change-Id: Iaa905d39205a4a45abb8fd5cfeaac81664561820
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70138
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
8 years agotmf: Support right mouse button selection of time graph entries
Bernd Hufmann [Thu, 7 Apr 2016 12:25:23 +0000 (08:25 -0400)] 
tmf: Support right mouse button selection of time graph entries

when clicking on the entry in the namespace.

Change-Id: I4561c4d5398300a8206348c4939f49cecd9c1c32
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70137
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agoss: Add serialization logic to state values
Alexandre Montplaisir [Sun, 10 Apr 2016 22:06:37 +0000 (18:06 -0400)] 
ss: Add serialization logic to state values

Right now the HTInterval object takes care of state value
serialization. This is a bad separation of responsibilities,
the state value itself should be the master of its destiny.

Implement state value serialization to and from byte arrays.
In a second step, the HT can be moved to use that logic instead
of its own.

Change-Id: I1d3379e0a4d7d82816164ae214838462ab28c5fd
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/70337
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
8 years agolttng: Bump Bundle-Version in lttng.ust.ui
Matthew Khouzam [Mon, 11 Apr 2016 20:24:55 +0000 (16:24 -0400)] 
lttng: Bump Bundle-Version in lttng.ust.ui

This fixes api errors introduced in  https://git.eclipse.org/r/#/c/68013/

Change-Id: Ib254fff53c06a6bee38b0a72274c551a68b3e81a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70419
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
8 years agotmf: Support for context-sensitive menu in Time Graph combos
Bernd Hufmann [Thu, 7 Apr 2016 12:10:47 +0000 (08:10 -0400)] 
tmf: Support for context-sensitive menu in Time Graph combos

Up to now, there were specific context-sensitive menus in Call Stack
and Control Flow view using the right mouse button on the tree.

This commit adds a generic support for context-sensitive menus to the
AbstractTimeGaph views when using Time Graph combos. It allows
extending classes to add both programmatically and declaratively
(using the plug-in.xml) menu entries to the context-sensitive menu.

The implementation of the Call Stack view and Control Flow view have
been adjusted to use this new API.

Change-Id: Ic0f0971ac32767446d0f555315f6ecbf0aeba09a
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70136
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
8 years agotmf.ui: Use the Y formatter to format tooltip values of XY charts
Geneviève Bastien [Fri, 8 Apr 2016 18:14:42 +0000 (14:14 -0400)] 
tmf.ui: Use the Y formatter to format tooltip values of XY charts

The XY viewers with a formatter defined for the Y axis will now use this
formatter for the tooltip.

Change-Id: Ibd2987199f8af50297b1a3c00b6f41e4c333316f
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/70286
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agolttng.ust: Use the data size formatter for UST memory view
Geneviève Bastien [Fri, 8 Apr 2016 19:00:03 +0000 (15:00 -0400)] 
lttng.ust: Use the data size formatter for UST memory view

Change-Id: Ie904826b7261b65671bff054b57f0764569f5087
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/70289
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agotmf: Bug 490400: Leaking widgets due to incorrect cleanup in dispose()
Patrick Tasse [Mon, 4 Apr 2016 22:38:02 +0000 (18:38 -0400)] 
tmf: Bug 490400: Leaking widgets due to incorrect cleanup in dispose()

Subclasses of Widget now perform their cleanup in a DisposeListener.

Disposing any child Control of a Composite is handled by the platform
and is therefore removed from the cleanup handling.

Subclasses of TmfComponent that are associated with a Control now
dispose their Control when TmfComponent.dispose() is called, and perform
their cleanup in a DisposeListener, including calling super.dispose().
The DisposeListener is attached to the Control.

Change-Id: Ie6bf7b18b8fad6a0fc0a683209a92fa39bbc8907
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/70057
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
8 years agotmf.ui: Lambda some handlers in CustomXmlParserInputWizardPage
Matthew Khouzam [Fri, 8 Apr 2016 21:30:05 +0000 (17:30 -0400)] 
tmf.ui: Lambda some handlers in CustomXmlParserInputWizardPage

This should make the code lighterweight.

Change-Id: I1f8034b31365c5c6e87341b7ba2186e30107992e
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70368
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agotmf: Fix opening symbol config dialog for experiments
Alexandre Montplaisir [Sat, 9 Apr 2016 22:27:11 +0000 (18:27 -0400)] 
tmf: Fix opening symbol config dialog for experiments

An ArrayIndexOutOfBounds exception could be thrown when opening
the symbol mapping configuration dialog in the context of a
multi-trace experiment. Index "-1" would be passed to
updateMessage(int).

When the window is first opened, the selection index is at -1,
simply skip the updateMessage() in this case.

Change-Id: I43b384016ec7dfff1b16b272b34155579bc101cc
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/70314
Reviewed-by: Hudson CI
Reviewed-by: Robert Kiss <robert.kiss@gmail.com>
8 years agocommon: Annotate ByteBuffer.array()
Alexandre Montplaisir [Sun, 10 Apr 2016 22:20:16 +0000 (18:20 -0400)] 
common: Annotate ByteBuffer.array()

to make it return a "byte @NonNull []", which means that
the array reference cannot be null.

It returns the buffer's internal array, and the implementation
first checks if it is null, and throws a
UnsupportedOperationException if it is.

Change-Id: I91d8a90d11dbe30ba0895103fadba78ed4b35ecf
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/70336
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agoctf: Add comments to CTFClock
Matthew Khouzam [Mon, 11 Apr 2016 14:11:32 +0000 (10:11 -0400)] 
ctf: Add comments to CTFClock

I was asked, is it deliberate that CTFClock's constructor is empty and
what is a clock, how does it work. This patch attempts to answer some of
the frequently asked questions.

Change-Id: I42dd8254f73df2d92d5e2497600b0b6ffc3682c4
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70369
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
8 years agoanalysis.io: Introduce an I/O Activity view
Houssem Daoud [Tue, 29 Mar 2016 18:39:43 +0000 (14:39 -0400)] 
analysis.io: Introduce an I/O Activity view

This view is linked to the Input/Output Analysis Module.

Change-Id: I4647540aee7ee9e78f949da9a1de0e01385e21cc
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Houssem Daoud <houssemmh@gmail.com>
Reviewed-on: https://git.eclipse.org/r/69670
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
This page took 0.050683 seconds and 5 git commands to generate.