Fix: sessiond: use of null session when session is not found
authorJérémie Galarneau <jeremie.galarneau@efficios.com>
Wed, 26 Jan 2022 01:16:59 +0000 (20:16 -0500)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Wed, 26 Jan 2022 21:40:21 +0000 (16:40 -0500)
A bad backport introduced this use of `session` even when it is
NULL.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: If7d540229ef3a2a50e1e58d4f408cb61252ed45d

src/bin/lttng-sessiond/rotation-thread.c

index 7ca9142cec5f5d97d66c868513132697ef46195a..5e6042e85671b88ad0b12dd5ea848b51b84529c2 100644 (file)
@@ -587,8 +587,7 @@ int handle_job_queue(struct rotation_thread_handle *handle,
                session_lock_list();
                session = job->session;
                if (!session) {
-                       DBG("[rotation-thread] Session \"%s\" not found",
-                                       session->name);
+                       DBG("[rotation-thread] Session not found");
                        /*
                         * This is a non-fatal error, and we cannot report it to
                         * the user (timer), so just print the error and
@@ -600,7 +599,6 @@ int handle_job_queue(struct rotation_thread_handle *handle,
                         * already been queued before it was destroyed.
                         */
                        free(job);
-                       session_put(session);
                        session_unlock_list();
                        continue;
                }
This page took 0.0263 seconds and 5 git commands to generate.