bt2: make _create_event_message's parent parameter mandatory
authorSimon Marchi <simon.marchi@efficios.com>
Sat, 17 Aug 2019 05:24:46 +0000 (01:24 -0400)
committerSimon Marchi <simon.marchi@efficios.com>
Mon, 26 Aug 2019 17:54:45 +0000 (13:54 -0400)
The `parent` parameter of _create_event_message currently has the None
default value.  However, None is never a valid value, as parent must
either be a Stream or a Packet.  Having a None default value makes it
look like the parameter is optional, but is actually always required.

Therefore, remove the None default value from the parameter.

Change-Id: Id0f8d64006ca25281529fc6bb3b9912365799f44
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed-on: https://review.lttng.org/c/babeltrace/+/1962
Tested-by: jenkins <jenkins@lttng.org>
Reviewed-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Reviewed-by: Philippe Proulx <eeppeliteloop@gmail.com>
src/bindings/python/bt2/bt2/message_iterator.py

index 23d6fbd5d0b28d4063b7fb7e325709560bd33267..5895b23735b2a30f343b22bdb3c3ec1fa0754710 100644 (file)
@@ -184,9 +184,7 @@ class _UserMessageIterator(_MessageIterator):
 
         return _UserComponentInputPortMessageIterator(msg_iter_ptr)
 
-    def _create_event_message(
-        self, event_class, parent=None, default_clock_snapshot=None
-    ):
+    def _create_event_message(self, event_class, parent, default_clock_snapshot=None):
         utils._check_type(event_class, bt2_event_class._EventClass)
 
         if event_class.stream_class.supports_packets:
This page took 0.024736 seconds and 4 git commands to generate.