Local variables are always visible to child functions, when they are
declared readonly and the same variable name is reused this results in
an error with bash 4.4.
As a workaround, rename the affected variables to fix the following
errors:
./tests/utils/utils.sh: line 222: args: readonly variable
./tests/utils/utils.sh: line 303: extra_details_args: readonly variable
Change-Id: I7321a9940a2e69bede363acddbd5f0465a3b1433
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Reviewed-on: https://review.lttng.org/c/babeltrace/+/12000
Reviewed-by: Philippe Proulx <eeppeliteloop@gmail.com>
Tested-by: jenkins <jenkins@lttng.org>
+ local -a bt_cli_args=("$@")
- echo "Running: \`$BT_TESTS_BT2_BIN ${args[*]}\`" >&2
- bt_run_in_py_env "$BT_TESTS_BT2_BIN" "${args[@]}" 1>"$stdout_file" 2>"$stderr_file"
+ echo "Running: \`$BT_TESTS_BT2_BIN ${bt_cli_args[*]}\`" >&2
+ bt_run_in_py_env "$BT_TESTS_BT2_BIN" "${bt_cli_args[@]}" 1>"$stdout_file" 2>"$stderr_file"
}
# Checks the differences between:
}
# Checks the differences between:
- local -r extra_details_args=("$@")
+ local -r gen_extra_details_args=("$@")
local -r temp_trace_dir=$(mktemp -d)
# Run the CTF trace generator program to get a CTF trace
local -r temp_trace_dir=$(mktemp -d)
# Run the CTF trace generator program to get a CTF trace
# Compare using the CLI with `sink.text.details`
bt_diff_details_ctf_single "$expected_stdout_file" "$temp_trace_dir" \
# Compare using the CLI with `sink.text.details`
bt_diff_details_ctf_single "$expected_stdout_file" "$temp_trace_dir" \
- "${extra_details_args[@]+${extra_details_args[@]}}"
+ "${gen_extra_details_args[@]+${gen_extra_details_args[@]}}"