ctf-writer: fix linter defects

Coverity found the following defects:

** CID 1124098: Unchecked return value (CHECKED_RETURN)
/formats/ctf/writer/event-types.c: 200

** CID 1124097: Unchecked return value (CHECKED_RETURN)
/formats/ctf/writer/writer.c: 376

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

diff --git a/formats/ctf/writer/event-types.c b/formats/ctf/writer/event-types.c
index 9b74b6e169954c23d244e1f2fe67fb53e4138588..091b3209eff8261d4526de6042ce08f8b933086e 100644 (file)
--- a/formats/ctf/writer/event-types.c
+++ b/formats/ctf/writer/event-types.c
@@ -190,6 +190,7 @@ static
 void bt_ctf_field_type_init(struct bt_ctf_field_type *type)
 {
        enum ctf_type_id type_id = type->declaration->id;
+       int ret;
 
        assert(type && (type_id > CTF_TYPE_UNKNOWN) &&
                (type_id < NR_CTF_TYPES));
@@ -197,7 +198,8 @@ void bt_ctf_field_type_init(struct bt_ctf_field_type *type)
        bt_ctf_ref_init(&type->ref_count);
        type->freeze = type_freeze_funcs[type_id];
        type->serialize = type_serialize_funcs[type_id];
-       bt_ctf_field_type_set_byte_order(type, BT_CTF_BYTE_ORDER_NATIVE);
+       ret = bt_ctf_field_type_set_byte_order(type, BT_CTF_BYTE_ORDER_NATIVE);
+       assert(!ret);
        type->declaration->alignment = 1;
 }
 

diff --git a/formats/ctf/writer/writer.c b/formats/ctf/writer/writer.c
index d0fad8fbb0ab5d3fde5b0753b1f419839ade0418..8529a1e31a4d07f6c0bb9d5d7c3fa4483124e548 100644 (file)
--- a/formats/ctf/writer/writer.c
+++ b/formats/ctf/writer/writer.c
@@ -356,6 +356,7 @@ void append_trace_metadata(struct bt_ctf_writer *writer,
                struct metadata_context *context)
 {
        unsigned char *uuid = writer->uuid;
+       int ret;
 
        g_string_append(context->string, "trace {\n");
 
@@ -374,7 +375,9 @@ void append_trace_metadata(struct bt_ctf_writer *writer,
        g_string_append(context->string, "\tpacket.header := ");
        context->current_indentation_level++;
        g_string_assign(context->field_name, "");
-       bt_ctf_field_type_serialize(writer->trace_packet_header_type, context);
+       ret = bt_ctf_field_type_serialize(writer->trace_packet_header_type,
+               context);
+       assert(!ret);
        context->current_indentation_level--;
 
        g_string_append(context->string, ";\n};\n\n");