Do not put a period at the end of the errno string: this gives the
opportunity to the user to follow the errno string with a colon, a
space, and fields, e.g.:
BT_LOGE_ERRNO("Cannot write to file", ": filename=\"%s\"", filename);
which would print this message, for example:
Cannot write to file: No space left on device: filename="/tmp/my-file"
You can also terminate a field-less message with a period manually:
BT_LOGE_ERRNO("Cannot close file", ".");
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
* - BT_LOGF("format string", args, ...)
*
* Message and error string (errno) logging macros:
* - BT_LOGF("format string", args, ...)
*
* Message and error string (errno) logging macros:
- * - BT_LOGV_ERRNO("format string", args, ...)
- * - BT_LOGD_ERRNO("format string", args, ...)
- * - BT_LOGI_ERRNO("format string", args, ...)
- * - BT_LOGW_ERRNO("format string", args, ...)
- * - BT_LOGE_ERRNO("format string", args, ...)
- * - BT_LOGF_ERRNO("format string", args, ...)
+ * - BT_LOGV_ERRNO("initial message", "format string", args, ...)
+ * - BT_LOGD_ERRNO("initial message", "format string", args, ...)
+ * - BT_LOGI_ERRNO("initial message", "format string", args, ...)
+ * - BT_LOGW_ERRNO("initial message", "format string", args, ...)
+ * - BT_LOGE_ERRNO("initial message", "format string", args, ...)
+ * - BT_LOGF_ERRNO("initial message", "format string", args, ...)
*
* Memory logging macros:
* - BT_LOGV_MEM(data_ptr, data_sz, "format string", args, ...)
*
* Memory logging macros:
* - BT_LOGV_MEM(data_ptr, data_sz, "format string", args, ...)
char error_str[BUFSIZ]; \
memset(error_str, 0, sizeof(error_str)); \
(void) strerror_r(errno, error_str, sizeof(error_str)); \
char error_str[BUFSIZ]; \
memset(error_str, 0, sizeof(error_str)); \
(void) strerror_r(errno, error_str, sizeof(error_str)); \
- BT_LOG_WRITE(lvl, tag, _msg ": %s. " _fmt, error_str, ## args); \
+ BT_LOG_WRITE(lvl, tag, _msg ": %s" _fmt, error_str, ## args); \
} _BT_LOG_ONCE
#else
/* GNU version of strerror_r(). */
} _BT_LOG_ONCE
#else
/* GNU version of strerror_r(). */
char error_str_buf[BUFSIZ]; \
char *error_str; \
error_str = strerror_r(errno, error_str_buf, sizeof(error_str_buf)); \
char error_str_buf[BUFSIZ]; \
char *error_str; \
error_str = strerror_r(errno, error_str_buf, sizeof(error_str_buf)); \
- BT_LOG_WRITE(lvl, tag, _msg ": %s. " _fmt, error_str, ## args); \
+ BT_LOG_WRITE(lvl, tag, _msg ": %s" _fmt, error_str, ## args); \