analysis: Bug 489573: Internalize Resources view implementation

Change-Id: I35fc6e359b2727b19ad77e5788bb9e7c0f1dfb51
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/69008
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

analysis: Bug 489573: Internalize CPU Usage view implementation

Change-Id: I45e930b51b718f0fd469096f968b8484965b0971
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/69009
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

tmf: Bug 491548: Do not incrementally build full time graph event list

The full event list should be recomputed for the full range at every
iteration of the build thread. If built incrementally it can create too
many events in the full event list.

The build thread should not insert NullTimeEvent in the full event list.

Change-Id: I2523291197b2d93267b2aa799e6126ea74eea0f9
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/70519
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Update AbstractTimeGraphView and TimeGraphEntry API

AbstractTimeGraphView.buildEventList() is renamed to buildEntryList()
which is more representative of its implementation. The Javadoc of this
method and getEventList() is improved to better explain their use.

TimeGraphEntry methods setParent(), getParent(), getChildren() and
addChild(...) are changed to restrict the entries to TimeGraphEntry.
This avoids instanceof checks in AbstractTimeGraphView implementations,
and avoids unexpected behavior in case a child or parent entry is not of
type TimeGraphEntry.

Change-Id: Ibf1c3f3fad467ab7ff215fd2552bb3350f00ef7e
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/70185
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf.test: Use SWTBotJunit4ClassRunner in every SWTBot test

Using the runner will produce screenshots if a test fails.

Change-Id: I6460bf1eb230ea2b3fe8cfd86ee8bc01399cb24f
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70579
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

lttng: Make ZoomThread more thread-safe (also helps ResourcesViewTest)

In AbstractTimeGraphView and extenders, when a ZoomThread applies its
results (links, markers), there is no guarantee of the order in the
presence of multiple ZoomThreads.
For example, in the case where a new ZoomThread is started and an old
one is still executing, the old one might be canceled so late that it
will still apply its results and do so *after* the new ZoomThread
completes. This change introduces some synchronization to make sure the
results are applied only in the case of the last ZoomThread spawned.

To reproduce this issue, go to AbstractTimeGraphView.getTraceMarkerList
and add a Thread.sleep(5000); before and after the isCanceled() check.
Because the test takes much longer, you need to increase the timeout in
ResourcesViewTest.timeGraphIsReadyCondition. Then you can run
ResourcesViewTest in a loop using SWTBotStressTests and after a few
iterations, it should fail.

Change-Id: If41f7b264676c04538cdc39c5c9bb40507b7e521
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70510
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Increase timeout for indexing in TestRefreshTextTrace

The additional output added recently to this test confirmed that
during the test, the trace is being slowly indexed without being
stuck and ends up timing out. This change significantly increases
the timeout (20 secs to 5 mins) in order to allow more indexing
time when the machine running the test is under heavy load.

Change-Id: I8e76ced07a5a09b6bd14a7b11d12c925c1ce3df2
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70581
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf : Add search dialog to timegraph views

The search dialog is based on the Eclipse FindReplaceDialog
implementation.

Change-Id: Id0758fc7e709d1d66778e0fc33d9f848b626cc70
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/69484
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

IKernelAnalysisEventLayout: add fieldPrevPrio() method

Adds a fieldPrevPrio() method in the layout to access the
priority of the previous process. Up to now, we could access
the previous process' name, but its priority can be useful.

Change-Id: I52c9ae1f3ba377139702e8cd4a6aad75cac7757c
Signed-off-by: Raphaël Beamonte <raphael.beamonte@gmail.com>
Reviewed-on: https://git.eclipse.org/r/70503
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

swtbot: Add SWTBot tests for time graph marker axis

Change-Id: I885d3b880bd875012b2b4f2a3b13b9f7e3a4553a
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/68682
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Upgrade jboss repository-utils to 0.23.3

This is the latest release.

Change-Id: Iad05716cb3a4c3da07cba1a8022c54cbf3828e10
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70367
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

tmf: Bug 491346: fix time pinning of CallStackView for window ranges

Change-Id: If7668535ca2cf26f0bf1a499ca3a606f31527eaa
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70281
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf.ui: Add Lambdas to TimeGraphCombo

Change-Id: Ic8e5ee349256bbc6a523b3453dddb49128323d2d
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70389
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

os.linux: Move buildThreadAttributeName() methods to Attributes interface

The method buildThreadAttributeName() and its counterpart
parseThreadAttributeName() are related to attributes tree
walking, and not to the event handlers themselves. Move them
to the Attributes interface.

Change-Id: Ide7b7154cfff0e12f74eda7a64f3545114b93e80
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/70298

os.linux: Move Attributes class to internal package

The os.linux.kernel analysis should eventually encapsulate all
its state system accesses, which means clients should not call
the Attributes class directly. Move Attributes class to the
analysis's internal package so it gets removed from the API.

We can make some known users x-friends for now, but eventually
they should be moved to using the real API.

Change-Id: I0b78c8ff88b039311d89d6313d40c2e9381c29af
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/70424

Fix typo in method name: setNewProcessPio -> setNewProcessPrio

An obvious typo was introduced in that method whose function is to
update the new process priority.

Change-Id: Id0600f339426c147fb75f0f157769298c3b6dfe7
Signed-off-by: Raphaël Beamonte <raphael.beamonte@gmail.com>
Reviewed-on: https://git.eclipse.org/r/70502
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>

tmf: add support for enter to expand/collapse tree TimeGraphCombo

This aligns the behavior of the TimeGraphViewer.

Change-Id: I211d69d72353622b380bbef88802d2745407b10f
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70257
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

tmf: Fix CopyToClipboardTest

The contextMenu method in SWTBot now throws (properly) a
WidgetNotFoundException instead of a TimeoutException

Change-Id: I9e7b8e469134ed7836923bbdd2d59ae9cf3eff59
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70478
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

tmf: Support for context-sensitive menu in Time Graph viewers

Up to now, there was a specific context-sensitive menu in the
Resources Flow view using the right mouse button on the namespace.

This commit adds a generic support for context-sensitive menus to the
AbstractTimeGraph views when using Time Graph viewers alone. It allows
extending classes to add both programmatically and declaratively
(using the plug-in.xml) menu entries to the context-sensitive menu.

The implementation of the Resources view have been adjusted to use this
new API

Change-Id: Ic9f3ff08fda27ffabc91d6054fe460b8fc764835
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70140
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Fix ISelectionProvider implementation of TimeGraphControl

The TimeGraphControl class implements ISelectionProvider interface
put never notifies the registered as ISelectionChangedListener.

Change-Id: I71ebc17c215a5e1e487f9488bb0727ebef898d31
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70139
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

tmf: Fix mouse detect handling in TimeGraphControl

Prevent the menu be shown before mouse up event is received. Otherwise
the zoom won't work. This is because the mouse up event will be received
by the menu pop-up and not by the TimeGraphControl instance.

Change-Id: Iaa905d39205a4a45abb8fd5cfeaac81664561820
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70138
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Support right mouse button selection of time graph entries

when clicking on the entry in the namespace.

Change-Id: I4561c4d5398300a8206348c4939f49cecd9c1c32
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70137
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ss: Add serialization logic to state values

Right now the HTInterval object takes care of state value
serialization. This is a bad separation of responsibilities,
the state value itself should be the master of its destiny.

Implement state value serialization to and from byte arrays.
In a second step, the HT can be moved to use that logic instead
of its own.

Change-Id: I1d3379e0a4d7d82816164ae214838462ab28c5fd
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/70337
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

lttng: Bump Bundle-Version in lttng.ust.ui

This fixes api errors introduced in  https://git.eclipse.org/r/#/c/68013/

Change-Id: Ib254fff53c06a6bee38b0a72274c551a68b3e81a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70419
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI

tmf: Support for context-sensitive menu in Time Graph combos

Up to now, there were specific context-sensitive menus in Call Stack
and Control Flow view using the right mouse button on the tree.

This commit adds a generic support for context-sensitive menus to the
AbstractTimeGaph views when using Time Graph combos. It allows
extending classes to add both programmatically and declaratively
(using the plug-in.xml) menu entries to the context-sensitive menu.

The implementation of the Call Stack view and Control Flow view have
been adjusted to use this new API.

Change-Id: Ic0f0971ac32767446d0f555315f6ecbf0aeba09a
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70136
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

tmf.ui: Use the Y formatter to format tooltip values of XY charts

The XY viewers with a formatter defined for the Y axis will now use this
formatter for the tooltip.

Change-Id: Ibd2987199f8af50297b1a3c00b6f41e4c333316f
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/70286
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

lttng.ust: Use the data size formatter for UST memory view

Change-Id: Ie904826b7261b65671bff054b57f0764569f5087
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/70289
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Bug 490400: Leaking widgets due to incorrect cleanup in dispose()

Subclasses of Widget now perform their cleanup in a DisposeListener.

Disposing any child Control of a Composite is handled by the platform
and is therefore removed from the cleanup handling.

Subclasses of TmfComponent that are associated with a Control now
dispose their Control when TmfComponent.dispose() is called, and perform
their cleanup in a DisposeListener, including calling super.dispose().
The DisposeListener is attached to the Control.

Change-Id: Ie6bf7b18b8fad6a0fc0a683209a92fa39bbc8907
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/70057
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

tmf.ui: Lambda some handlers in CustomXmlParserInputWizardPage

This should make the code lighterweight.

Change-Id: I1f8034b31365c5c6e87341b7ba2186e30107992e
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70368
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Fix opening symbol config dialog for experiments

An ArrayIndexOutOfBounds exception could be thrown when opening
the symbol mapping configuration dialog in the context of a
multi-trace experiment. Index "-1" would be passed to
updateMessage(int).

When the window is first opened, the selection index is at -1,
simply skip the updateMessage() in this case.

Change-Id: I43b384016ec7dfff1b16b272b34155579bc101cc
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/70314
Reviewed-by: Hudson CI
Reviewed-by: Robert Kiss <robert.kiss@gmail.com>

common: Annotate ByteBuffer.array()

to make it return a "byte @NonNull []", which means that
the array reference cannot be null.

It returns the buffer's internal array, and the implementation
first checks if it is null, and throws a
UnsupportedOperationException if it is.

Change-Id: I91d8a90d11dbe30ba0895103fadba78ed4b35ecf
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/70336
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ctf: Add comments to CTFClock

I was asked, is it deliberate that CTFClock's constructor is empty and
what is a clock, how does it work. This patch attempts to answer some of
the frequently asked questions.

Change-Id: I42dd8254f73df2d92d5e2497600b0b6ffc3682c4
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70369
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

analysis.io: Introduce an I/O Activity view

This view is linked to the Input/Output Analysis Module.

Change-Id: I4647540aee7ee9e78f949da9a1de0e01385e21cc
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Houssem Daoud <houssemmh@gmail.com>
Reviewed-on: https://git.eclipse.org/r/69670
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Workaround for leaking views

As a workaround for Bug 490400, clear the actions bars of views that
contribute to the tool bar manager so that their actions don't retain
references to the view when it is closed.

Change-Id: I3af262aad4416e40edf587f1313c8480517541b0
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/70059
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Add some debug output to TestRefreshTextTrace

This test has been failing intermittently but my suspicion is that
it fails when the server is under heavy load and the trace fails to
index in 20 seconds. To verify this, this change adds some output
as the wait condition is evaluated. This test didn't already log the
SWTBot output so this means that even with this change, it's not too
verbose.

Change-Id: Ic6da7b19c45faa5345b2118c902101db6e18276b
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70329
Reviewed-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf.common: Add a data size and speed formatter

This allows to format numbers representing sizes and speeds in bytes[/s] to
the closest thousand with 3 decimals. Format also includes the units.

This patch updates the kernel memory usage view to use this formatter.

Change-Id: I637f9e408d75f6a3948169d6fde5e8da596b17ce
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/70287
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf.ui: Return minimal number of X values in XY viewer

When the number of time steps is lower than the requested number of X values,
only those steps will be returned.

Change-Id: I94c877906083584546d4921e2bd90d82b5e72c49
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/69546
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

analysis.ui: Add follow cpu context menu to resources view

This generates a TmfCpuSelectectedSignal that can be used by views listening in.

Change-Id: Ib7a19b600dfd6be8510b07b4b48cc60e05722833
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66651
Reviewed-by: Hudson CI

linux.ui: Add support to show CPU usage per-cpu

This adds support to the CpuUsageView to make it update when a
TmfCpuSelectedSignal is received.

The title updates to show which cpus are selected.

Change-Id: Ia315159b4746b8f33f747da6b2f6327065a32995
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65423
Reviewed-by: Hudson CI

tmf: Move the analysis requirements to their own package

The o.e.t.tmf.core.analysis package is getting crowded.

Change-Id: I2b8cc1cd9719733b260117787fa2865e03633c60
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/68013
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>

rcptt: Hard-code RCPTT runner to specific milestone release

So that it doesn't redownload all the time (every day).
This version (2.1.0-M7_rc1) seems to support Neon correctly so this
should be good enough for a while until we need to consume other
fixes.

Change-Id: I0900b12706390510931d9caf62e7a3f095e9bf60
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70175
Reviewed-by: Hudson CI

linux: make priority aspect work with tid == 0

Change-Id: I57353c2bef4e1ec0911e8d9d5c97cc954262ff1a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70176
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

Increase timeouts for tests that have low values

Some tests have short timeouts (20 secs) that would usually not be
a problem on an performant machine but when build servers are under
load, especially in I/O, this can lead to intermittent failures.
This changes increases those 20 secs timeouts to 1 minute to help
in those situations.

Change-Id: I38b56c65d3981c4cf6490724f97aa26de7b0f736
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70330
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>

tmf: Add the notions of timestamp and PID to ISymbolProvider

To support completely generic symbol resolution, the methods in
ISymbolProvider needs to consider two new concepts: the timestamp
of the query, and the process ID.

Process ID:
  One trace can contain events from multiple processes. Even if
  they all execute the same executable, the memory addresses, being
  virtual, are specific to each process. The provider may need to know
  the query is for which process in particular.

Timestamp:
  Since libraries can be loaded and unloaded at runtime, with calls to
  dlopen() and dlclose() for example, one address may refer to
  different libraries at different moments in a trace. The provider
  then needs to know the timestamp of the query, so it can refer to the
  correct library if needed.

To ease the transition, we can introduce the new method as default
methods that will ignore the new parameters by default.

Change-Id: I6ec8aa5d97c690d84a9864af15f99a3ec9f4aa3d
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/69969
Reviewed-by: Hudson CI

releng: Add SWTBot Generator feature to target definition files

This allows developers to use the SWTBot Generator by adding its
plug-ins from the target platform in their launch configuration.

The SWTBot Generator can then be launched with File -> New -> Other...
-> Run Test Recorder.

Change-Id: I845377851f442babd9cb108a0bebac61d6b06eca
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/70279
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

analysis: Remove zoomed event list handling from Critical Path View

The Critical Path View does not use a zoomed event list so there is no
need to fake it. Its event list is built by the HorizontalLinksVisitor,
and contains all time events regardless of the resolution.

The zoomed event list was built only once for the full entry range and
was therefore strictly equal to the full event list. It was not more
detailed (since the full event list is already at the most detailed
level) and it was not a subset of the event list for the current time
range, since the zoom thread never updated it, due to the
CriticalPathBaseEntry having no child entries, preventing any recursion
into the deeper entries.

Change-Id: I469ef9314dcbcc835a5ef03c93d9ca11c5f7eb70
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/70184
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Francis Giraldeau <francis.giraldeau@gmail.com>

tmf: Fix leaking static Histogram instances

The two Histogram instances in HistogramView are static and therefore
are retained by the class in the ClassLoader with references to the last
histogram data model, even after the view is closed.

Change-Id: I7853628e99a7bd8f3815253060bf891eed217cae
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/70058
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

linux: make TID analysis handle no TID more gracefully - Bug 491275

This stops AttributNotFoundExceptions from being thrown in the beginning
of a trace.

Change-Id: I917fa81b3882ce3c98f23f782a87a6f7f8947b10
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70170
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

analysis.io: Provide information from the IO model

This extracts a base Disk class from the DiskWriteModel, that can be used
by outputs and views to get data from the analysis.

It also adds an Information Provider for the input output analysis module

It comes with its units tests

Change-Id: Iffb8428eb161bbd5cfcb834deebfa55d812f4d00
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/69669
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

linux: use DefaultEventLayout.getInstance() in TidAnalysis

Make the newly merged TidAnalsysis use the layout in the proper way.

Change-Id: Iff7d882946de3783dc23586c0aa1a468c61c17f5
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70166
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Hudson CI

linux.core: Introduce TID analysis

This analysis calculates a subset of what the kernel
state system has: which tid is running on which cpu.

This will allow these aspects to be available much faster
during state construction and in the reading after.

The new state system is typically 1% of the size of the kernel
state system. Therefore the seeks, even though they are log(n)
will accelerate. As getTid is something MANY analyses do often
this patch should improve performance accross the board.

In one corner case example, (System call analysis), where each state
required a TID, performance passed from 3000 to 140000 events per seconds.

On average, searches on the TID column should reduce in time by 5-10%
depending on the trace configuration (how many contexts etc...).

Change-Id: Icf7921c49232481129b9c021170556c9d06d5ca4
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68878
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI

os.linux: Do not define the default kernel layout in the interface

Instead point users directry to DefaultEventLayout.

This avoids a circular reference from IKernelEventLayout layout
to one of its own implementations.

Change-Id: I3c87767df4285c18b9216209942b069fef4d34cf
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/70080
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

os.linux: Do not rely on static initialisation order for layouts

Expose DefaultLayout#getInstance() instead of DefaultLayout#INSTANCE

This solves a weird problem where the layout could be null.

To reproduce this problem, define and run the following test suite:
@RunWith(Suite.class)
@Suite.SuiteClasses({
VirtualMachineAnalysisTest.class,
LttngKernelAnalysisTest.class,
PartialStateSystemTest.class,
StateSystemInMemoryTest.class,
StateSystemFullHistoryTest.class
})
public class TestSuite { }

Change-Id: I772ee0944334283d4b36118001a858322921d98a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/69864
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Hudson CI

lttng: Use long values for integer fields in the Graph test trace

Since state providers expect all integer fields to be Long objects
(as ctf.tmf does), test traces should also supply long values.

"cpu" should remain an int however.

Change-Id: Icee091a56710cd4a3c16d4f00ab00ca792b13d1e
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/69866
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

graph: add messages to IllegalStateExceptions

Change-Id: If8efc90b6e55395448abbf3ced6695678dc8b496
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68876
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI

analysis.io: Unit tests for the I/O analysis

It uses a few XML kernel stub traces to cover the various cases and events
of the IO analysis, then the content of the state system is verified at certain
times and for certain attributes.

Change-Id: I33f8deb62d9df6958fe88012ada3db5f077d0c09
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/69668
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

analysis.io: Introduce the input/output linux analysis

This analysis uses the block_* events to track the requests to the disks
and the number of sectors read and written. It also stores the reads and
writes by process from the syscalls.

Change-Id: I6e1b00d53eb3a217b01a906d4d1fd566e53481ef
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Houssem Daoud <houssemmh@gmail.com>
Reviewed-on: https://git.eclipse.org/r/69667
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

linux.core: Simplify KernelThreadInformationProvider

This makes KernelthreadInformationProvider only check pertinent state
values. The logic should be 100% equivalent, but the code should be
much more legible.

Change-Id: I96a962c6f2fa80b2a57d753a324c60c394dae349
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/69975
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI

ctf: mini bitbuffer optimisation

Change-Id: I10806685649ae1f46d679189e6d4f022a060060e
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65415
Reviewed-by: Hudson CI
Reviewed-by: Francis Giraldeau <francis.giraldeau@gmail.com>

tmf : Add parameters to XML core methods

Add ScenarioInfo as parameters to XML core module methods. This will
help to get the active scenario details (quark, scenarioName,
scenarioState, ...) and use them when necessary during a pattern
analysis. If there is no scenario, the value is set to null.

Change-Id: I17f65b73cb236e81221c355a3cb2fce9800d4fe5
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68090
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

tmf : Add latency statistics view for the pattern analysis

Change-Id: Ie4fe7e7e68e8e3b074ddb5f0b3ec97a554652166
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67842
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Move the symbol provider messages to their own package

Message classes should be package-specific as much as possible.

Change-Id: I7eeae05c357799e4794af908fc53d376ab7cc28a
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/69559
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ctf: Explicitly create a Long object for Integer fields

Just in case, and to be more clear, explicitly box the primitive
into its expected Long object.

Change-Id: I8cd2cbee034479ca7e6361b02e7ef1b74b51e178
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/69865
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Bug 490372: Hide PieCharts when trace has only 1 event type

Change-Id: Ie5a2587fd45ccc004910421fd2ca0e23911eac7f
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/69247
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Add an attribute pool for state system analyses

This new class allows to reuse attribute quarks in a state system. It can
typically be used by analyses who want to save data in the state system
for short intervals of time. Instead of creating a number of attributes with
lots of empty space before and after, they can reuse the same. It makes for
more compact time graph views as well.

Change-Id: Ie7f32eccb02096ef62df4c479a8e2bcfcd043af6
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67263
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

ctf: Replace StructDeclaration map with an array

This will cause a 10% performance improvement while reading a trace

The LinkedHashMap of fields in a struct declaration is much slower
to iterate through than a regular array. This patch replaces the map
with an array. This yields a performance gain of approx 10%.

The patch also changes some methods behavior.

* getMaximumSize() clamps to Integer#MAX_VALUE instead of overflowing
* addField no longer overwrites a value already in the declaration.

As addField has been modified, extra attention has to be put on
the parser in the case of degenerate test cases to maintain the
current behavior.

Change-Id: Id76b3432b2c973a1e2cbecba5a9b22ad76a68162
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66168
Reviewed-by: Hudson CI

xml.core: test double valued xml fields

This test also tests the forcedType tag

Change-Id: I84249aa8a1c06bad80def9aba959fd368a06121c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/69664
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Support type double in XML analysis and XML XY views

Change-Id: Ic15969624191fba35ec4b5b7b90394e3253a7e61
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/69372
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

common.core: annotate String#substring

String.substring always returns a new String or "this".

Change-Id: Id37b8a20489f07b6bfe8a225064d5be1cd4fc7aa
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/69196
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

analysis.io: Add I/O events and fields to the event layout

And update it for LTTng event layout

Change-Id: Idabcd30fb321e03ef29e65b936b2832f96bc42a5
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/69146
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

common: Add documentation to the view KernelMemoryUsage

I add the description and the functionalities of the new
kernel Memory Usage view.

Change-Id: I457372fd1d99c262ca35d768f83e2d53b130c4cb
Signed-off-by: Julien Daoust <julien_daoust@hotmail.com>
Reviewed-on: https://git.eclipse.org/r/69335
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

analysis.os: New kernel memory usage view with Unit tests

This view keeps track of page allocation/deallocation events in the kernel.
It consists of a plot and a menu for thread selection. For a given time range,
the menu only lists threads in which there was activity. Values in the plot
are relative to the beginning of the selected trace.

Change-Id: Ie5605b7211828fd01accb920a5a735500fcae4b2
Signed-off-by: Najib Arbaoui <arbaouinajib@gmail.com>
Signed-off-by: Samuel Gagnon <samuel.gagnon92@gmail.com>
Reviewed-on: https://git.eclipse.org/r/65957
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

perf: Fix scenario names that should not contain %

The Scenario constructor in the o.e.test.performance contains this line of
code:

Assert.assertFalse(scenario.indexOf('%') >= 0);

This constructor does not appear to be called at insert, or it would fail, but
it is when reading the scenario data, which explains the performance tests job
failures when retrieving the data to display on
http://istmffastyet.dorsal.polymtl.ca.

Also changes the short names, that are limited to 40 characters in the database

Change-Id: If2a259e92595377a9a1872b008576a4564390038
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/69750
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

lttng: Add a common plugin for LTTng

This plugin will contain common stuff for both kernel and UST, such as
contexts, requirements, etc.

Change-Id: Ie1546e17436621e7473e0bfccad34897039779c5
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/68937
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf.core.tests: Allow TmfXmlTraceStub to have additional aspects

These aspects can be added individually for each unit test as required.

Change-Id: Ib8a6894239958593f88d91c4d8bcd91d3b7b845a
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/68947
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

Add timeout exception when waiting for jobs

It can happen that jobs never finish and tests calling waitForJobs
will run forever (or time out if a Jenkins/Hudson job is set to
timeout). Normally it would be possible to set a timeout on individual
JUnit tests but this doesn't seem to play well with SWTBot (to be
investigated).

To reproduce the issue before this patch, add this line to the
beginning of SWTBotUtils.waitForJobs method:
new Job("Foo") {@Override protected IStatus run(IProgressMonitor monitor) {while(true){}}}.schedule();

This simulates a never finishing job. Then run OpenTraceStressTest.
The test should never time out.

With this patch, waitForJobs will timeout after 5 mins (300000ms) by
default. When it does timeout, it will print each job, its state and
stack trace.

To reproduce the timeout added with this patch, apply the line as
mentioned above, reduce MAX_JOBS_WAIT_TIME to a smaller value (5000ms)
then run OpenTraceStressTest.

Change-Id: I0cdbaa10c87b93aa2ac6c7f146f7a6e008983fbd
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68850
Reviewed-by: Hudson CI

rcp: add o.e.remote.jsch.core/ui plugins to the RCP feature

Change-Id: Ice402afafdd96d2a4061a47774a34af44bbddcb0
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/69622
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

lttng: Fix use of deprecated SWTBot API

Also bump the target sequence numbers to that people get the latest
SWTBot.

Change-Id: Ia615d6642849a97c3e18f49a29ec134b0e11151e
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/69638
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

swtbot: Add SWTBot tests for collapsible event table header bar

Change-Id: I53e6d536b8995ed02190c22a4b9fa7d1eb59a32b
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/68583
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Update javadoc for TmfTestHelper#executeAnalysis

Change-Id: I015e918b56a8c4607ba0606ba3c768fecc7f433f
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/69092
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Remove "Analysis" from localized analysis names

As discussed in the March 18th project meeting, localized
analysis names should be aligned and not end with "Analysis".

Change-Id: I726dba212ef8bc50be49c5c5d52ad3ede580369c
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/69070
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ss: Mark ITmfStateSystem#queryOngoingState as @NonNull

Just like querySingleState, an ongoing state cannot be null
if the passed attribute is valid. At worst the value can be a
NullStateValue.

Change-Id: I138ce6d0d62a0cb45706117fd4d0e4bdf8e8fc58
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/68815
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

common: Add a new StreamUtils class

We often use Iterable in our APIs, due its minimal behavior
exposition. Unfortunately, there is no Iterable.stream() method,
the official way is done using StreamSupport and the corresponding
spliterator.

Since this is a very commonly used pattern, we can introduce a
small utility method that will make it less verbose.

At the same time, we can move the StreamFlattener into the new
utils class.

Change-Id: Ia4fed4f8a5da56f08ac133eb10efae970004e511
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/68563
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

os.linux: Move ThreadPriorityAspect to the event.aspect package

Also move the related logic from KernelThreadInformationProvider
to the aspect itself.

Change-Id: I9dbf5854e3b8057fc5cb5dd147040e4b1a63cf68
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/68561
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Disable live tracing feature

The Live Tracing feature is quite limited and error prone. Some
of the shortcomings are documented in bug 486728. Since there are no
short term plans to improve this in Neon, perhaps it is better to
disable this for now.

Change-Id: Iaf6cab29ce55fde58296aab9935d220eee29a297
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/69285
Reviewed-by: Hudson CI
Reviewed-by: Jonathan Rajotte Julien <jonathan.rajotte-julien@efficios.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

swtbot: Stabilize FilterColorEditorTest

A condition is added that waits for the image at the specified bounds
to have changed when compared to a specified current image. This ensures
that the cell has painted with required changes following user input.

ImageHelper now implements hashCode() and equals().

Change-Id: I444ab78f074ebd5c28f8b4aea4927b1c01558486
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/69076
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf.ui: Make TmfEventsTable#PackColumns return a value

This allows extending classes to know whether the pack actually happened
or if it was fast returned. The quick return shows that the columns have
already been packed. If the method does pack the columns, we know that it
was done the first time (on a new trace open) or after. This can allow
extending classes to have a hook to a location where the columns have
been initialized as they are not yet in the consutructor or in "init".

Change-Id: Ia4f3ab76e144d937bb5a8eb5e7597c9e99b3114f
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/69469
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

os.linux: Add per cpu thread 0 modeling

The current model handle thread 0 as a normal thread which is incorrect
since it is the idle or swapper thread and can be active concurently on
multiple CPUs.

This commit adds this concept to the state system and the control flow
view by using a special thread attribute name of "0_X" where X is the
CPU number.

Change-Id: I476927be378482751ee523fac77bbf4d260da54a
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Reviewed-on: https://git.eclipse.org/r/69089
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

os.linux: Fix CPU state when Softirq is interrupted

This patch makes the cpu the aggregate of the PROCESS, all SOFTIRQs
and all IRQs. The process now does a rigourous check of every state
in the CPU. This can be later replaced with a virtual or aggregate entry
if deemed necessary.

This patch fixes bug 481855.

Change-Id: I1fd368362daf269c12cc4f12f459c5a1e404e420
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/68002
Reviewed-by: Hudson CI

Add Trace Compass 1.2.1 API baseline

Change-Id: I62d2c5471ffdae199013ea016d0d10d79bfe2152
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/69455
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Skip CopyToClipboardTest tests when running GTK3 and Eclipse 4.5

These tests will never work in Eclipse 4.5.x because there was a bug
in SWT that only got fixed in 4.6.0. See bug 486302.

Change-Id: I78d9b95970bf3b99b07108e98d046f8d6dd58b94
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/69395
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

swtbot: Stabilize use of SWTBotUtils.maximizeTable()

When Ctrl+M is pressed, the resize and layout of the workbench part does
not necessarily occur immediately. For tests that depend on the part
being maximized, the method should block until the resize has occurred.

So far, this issue was only seen when SWTKeyboardStrategy is used.
SWT strategy posts events to SWT and this differs from the AWT strategy.
But the solution in this patch offers an additional safety that is
beneficial to all keyboard strategies.

Change-Id: I3afac9314a82c319064accca1fce00c1dbeb893e
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/69075
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Fix SWTException in TimeGraphMarkerAxis

The zoom thread can call setMarkers() while the view containing the time
graph has been closed in the meantime, causing a SWTException: Widget is
disposed.

Change-Id: I586b3835fdee958e5e7c558f000954a3de5db616
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/69282
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Fix task state unknown with Linux >= 4.1

The control flow view displays the task state as WAIT_UNKNOWN with
newer kernels. This is caused by a new task state value. The mask is
adjusted to fit this new value.

The fix is backward compatible.

Change-Id: I568dd51cd597ab64819cc6a83a3c6f06ec859489
Signed-off-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67377
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>

Fix new null warnings

Recent 4.6 JDT emits null warnings in a few more places.
Some un-annotated generic types are now implied to be nullable.

Change-Id: I37349ba28ce6d88a60cb44c5df7d4f8f5d7c439c
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68227
Reviewed-by: Hudson CI

releng: Use org.eclipse.remote plugins instead of the feature

The top-level feature now includes the doc.isv plugin, which
in turn depends on all org.eclipse.remote features (serial,
telnet, etc.) which we don't need.

Depend directly on the plugins instead.

Change-Id: Iac7eb44d75b0db46549cdc6d3cfe027e504a95bc
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/69298
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI

Add missing eclipse.ui.trace dependency

We used to get this dependency through o.e.remote.ui but
they don't depend on it anymore so we don't get it.

Change-Id: I9b2f4b7df5b571871b6757fb8afdd8855082ab65
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/69284

Add git-review configuration to repository

Add .gitreview to enable the use of the git-review plugin to interact
with Gerrit. Documentation on this plugin can be found at:

  https://github.com/openstack-infra/git-review

Change-Id: I8240a5baf7e1171b932896a6615131453b55adad
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Reviewed-on: https://git.eclipse.org/r/69173
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Jonathan Rajotte Julien <jonathan.rajotte-julien@efficios.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>

Update version numbers to at least the versions in stable-1.2

Change-Id: Ibd2898b5f67bcddb0ecafd44e43344ad7884c4a7
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/69215
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: Delete project at the end of ControlViewTest

So that the test can run twice in a row.

Change-Id: I4382c991c3add7f8fe53fae14963f65ce446e15a
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68860
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>