Cleanup: packet-context-field.c: logically dead code
authorFrancis Deslauriers <francis.deslauriers@efficios.com>
Mon, 16 Sep 2019 15:40:23 +0000 (11:40 -0400)
committerFrancis Deslauriers <francis.deslauriers@efficios.com>
Thu, 19 Sep 2019 18:40:54 +0000 (14:40 -0400)
Coverity reported the following:
  CID 1401199 (#1 of 1): Logically dead code (DEADCODE)dead_error_begin:
  Execution cannot reach this statement: bt_field_wrapper_destroy

Reported-by: Coverity - 1401199 Logically dead code (DEADCODE)
Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Change-Id: Ia53f46f998bcfb3a88f2d8a93343aa4c199a12ff
Reviewed-on: https://review.lttng.org/c/babeltrace/+/2052
Tested-by: jenkins <jenkins@lttng.org>
Reviewed-by: Simon Marchi <simon.marchi@efficios.com>
src/lib/trace-ir/packet-context-field.c

index 9f648e24a221404caa37ed9dc70b745063841a70..786cbdf6a76aa24b12f8a93a39abf11d3a28d30b 100644 (file)
@@ -76,18 +76,11 @@ struct bt_packet_context_field *bt_packet_context_field_create(
                BT_LIB_LOGE_APPEND_CAUSE(
                        "Cannot allocate one packet context field from stream class: "
                        "%![sc-]+S", stream_class);
-               goto error;
+               goto end;
        }
 
        BT_ASSERT(field_wrapper->field);
        bt_stream_class_freeze(stream_class);
-       goto end;
-
-error:
-       if (field_wrapper) {
-               bt_field_wrapper_destroy(field_wrapper);
-               field_wrapper = NULL;
-       }
 
 end:
        return (void *) field_wrapper;
This page took 0.025687 seconds and 4 git commands to generate.