Fix: dmesg.c: deference before `NULL` check
authorPhilippe Proulx <eeppeliteloop@gmail.com>
Fri, 9 Aug 2019 19:00:35 +0000 (15:00 -0400)
committerPhilippe Proulx <eeppeliteloop@gmail.com>
Fri, 9 Aug 2019 19:28:34 +0000 (15:28 -0400)
Found by Coverity Scan.

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Change-Id: I841e1434341037ddf482445464c3fd428f08edd7

src/plugins/text/dmesg/dmesg.c

index e8317d47a50bc5e3a29409f388e6b7f9e3230a1d..7fa50720e4588e9ff333d5d7d170d1de0b878720 100644 (file)
@@ -634,12 +634,14 @@ end:
 static
 void destroy_dmesg_msg_iter(struct dmesg_msg_iter *dmesg_msg_iter)
 {
-       struct dmesg_component *dmesg_comp = dmesg_msg_iter->dmesg_comp;
+       struct dmesg_component *dmesg_comp;
 
        if (!dmesg_msg_iter) {
                return;
        }
 
+       dmesg_comp = dmesg_msg_iter->dmesg_comp;
+
        if (dmesg_msg_iter->fp && dmesg_msg_iter->fp != stdin) {
                if (fclose(dmesg_msg_iter->fp)) {
                        BT_COMP_LOGE_ERRNO("Cannot close input file", ".");
This page took 0.031971 seconds and 4 git commands to generate.