MSP430: Relax target glob for configuring GDB
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
b3f4b80f
JL
12019-12-13 Jozef Lawrynowicz <jozef.l@mittosystems.com>
2
3 * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
4
e671856c
TT
52019-12-12 Tom Tromey <tom@tromey.com>
6
7 * objfiles.h (struct objfile) <partial_symtabs>: Now a
8 unique_ptr.
9
7d7167ce
TT
102019-12-12 Tom Tromey <tom@tromey.com>
11
12 * progspace.h (objfile_list): New typedef.
13 (class unwrapping_objfile_iterator)
14 (struct unwrapping_objfile_range): Newl
15 (struct program_space) <objfiles_range>: Change type.
16 <objfiles>: Change return type.
17 <add_objfile>: Change type of "objfile" parameter.
18 <objfiles_list>: Now a list of shared_ptr.
19 * progspace.c (program_space::add_objfile): Change type of
20 "objfile". Update.
21 (program_space::remove_objfile): Update.
22 * objfiles.h (struct objfile) <~objfile>: Make public.
23 * objfiles.c (objfile::make): Update.
24 (objfile::unlink): Don't call delete.
25
343cc952
TT
262019-12-12 Tom Tromey <tom@tromey.com>
27
28 * symfile.c (symbol_file_clear): Update.
29 * progspace.h (struct program_space) <free_all_objfiles>: Declare
30 method.
31 * progspace.c (program_space::free_all_objfiles): New method.
32 * objfiles.h (free_all_objfiles): Don't declare.
33 * objfiles.c (free_all_objfiles): Move to program_space.
34
d0801dd8
TT
352019-12-12 Tom Tromey <tom@tromey.com>
36
37 * progspace.c (program_space::add_objfile)
38 (program_space::remove_objfile): Update.
39 (program_space::multi_objfile_p): Remove.
40 * objfiles.h (struct objfile) <next>: Remove.
41 * objfiles.c (objfile::objfile): Update.
42 (put_objfile_before): Update.
43 (unlink_objfile): Update.
44 * progspace.h (object_files): Remove.
45 (struct program_space) <objfiles_head>: Remove.
46 <objfiles_list>: New member.
47 <objfiles_range, objfiles_safe_range>: Change type.
48 (objfiles): Change return type.
49 (objfiles_safe): Update.
50 (multi_objfile_p): Rewrite and inline.
51 (object_files): Remove macro.
52
13bff726
TT
532019-12-12 Tom Tromey <tom@tromey.com>
54
55 * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify. Add
56 second constructor.
57 (basic_safe_range): New class.
58
deeafabb
TT
592019-12-12 Tom Tromey <tom@tromey.com>
60
61 * progspace.c (program_space::multi_objfile_p): New method.
62 * printcmd.c (info_symbol_command): Update.
63 * maint.c (maintenance_translate_address): Update.
64 * objfiles.h (MULTI_OBJFILE_P): Remove.
65 * progspace.h (struct program_space) <multi_objfile_p>: New
66 method.
67
23452926
TT
682019-12-12 Tom Tromey <tom@tromey.com>
69
70 * progspace.h (struct program_space) <remove_objfile>: Declare.
71 * progspace.c (program_space::remove_objfile): New method.
72 * objfiles.c (unlink_objfile): Remove.
73 (objfile::unlink): Call remove_objfile.
74 (objfile): Don't call unlink_objfile.
75
7cac64af
TT
762019-12-12 Tom Tromey <tom@tromey.com>
77
78 * progspace.h (struct program_space) <add_objfile>: Declare
79 method.
80 * progspace.c (program_space::add_objfile): New method.
81 * objfiles.c (~objfile): Don't unlink objfile.
82 (put_objfile_before): Remove.
83 (add_separate_debug_objfile): Don't call put_objfile_before.
84 (objfile::make): Call add_objfile. Set new_objfiles_available on
85 the per-program-space data.
86
268e4f09
TT
872019-12-12 Tom Tromey <tom@tromey.com>
88
89 * symfile.c (syms_from_objfile_1): Use objfile_up.
90 (syms_from_objfile_1, remove_symbol_file_command): Call unlink
91 method.
92 (reread_symbols): Use objfile_up.
93 * solib.c (update_solib_list, reload_shared_libraries_1): Call
94 unlink method.
95 * objfiles.h (struct objfile) <~objfile>: Now private.
96 <unlink>: New method.
97 (struct objfile_deleter): New.
98 (objfile_up): New typedef.
99 * objfiles.c (objfile::unlink): New method.
100 (free_objfile_separate_debug, free_all_objfiles)
101 (objfile_purge_solibs): Use it.
102 * jit.c (jit_unregister_code): Remove.
103 (jit_inferior_exit_hook, jit_event_handler): Call unlink on
104 objfile.
105 * compile/compile-object-run.c (do_module_cleanup): Call unlink on
106 objfile.
107 * compile/compile-object-load.c (compile_object_load): Use
108 objfile_up.
109
f65fe570
TT
1102019-12-12 Tom Tromey <tom@tromey.com>
111
112 * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
113 objfile::make.
114 * objfiles.h (struct objjfile) <make>: No longer inline.
115 (add_separate_debug_objfile): Don't declare.
116 * objfiles.c (add_separate_debug_objfile): Now static.
117 (objfile::make): Move from objfiles.h. Call
118 add_separate_debug_objfile. Add "parent" parameter.
119
bda13cdc
TT
1202019-12-12 Tom Tromey <tom@tromey.com>
121
122 * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
123 * objfiles.h (struct objfile): Make constructor private.
124 <make>: New static method.
125 * jit.c (jit_object_close_impl): Update.
126
7190276c
SM
1272019-12-12 Simon Marchi <simon.marchi@polymtl.ca>
128
129 * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
130 gdb::byte_vector.
131
d61df897
TT
1322019-12-12 Tom Tromey <tromey@adacore.com>
133
134 * xml-support.c (xml_fetch_content_from_file): Don't call
135 malloc_failure.
136 * utils.h (class gdb_argv): Remove malloc_failure comment.
137 * utils.c (gdb_argv::reset): Don't call malloc_failure.
138
db3ad2f0
TT
1392019-12-12 Tom Tromey <tromey@adacore.com>
140
141 * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
142 (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
143 (ALLDEPFILES): Add riscv-ravenscar-thread.c.
144 * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
145 * riscv-ravenscar-thread.c: New file.
146 * riscv-ravenscar-thread.h: New file.
147 * riscv-tdep.c (riscv_gdbarch_init): Call
148 register_riscv_ravenscar_ops.
149
2ffe5b9c
TT
1502019-12-12 Tom Tromey <tromey@adacore.com>
151
152 * gdbsupport/thread-pool.c (set_thread_name): Use
153 ATTRIBUTE_UNUSED.
154
39f34d7b
LM
1552019-12-12 Luis Machado <luis.machado@linaro.org>
156
157 * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
158 (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
159 macros.
160
d4eeccfe
TT
1612019-12-11 Tom Tromey <tom@tromey.com>
162
163 * tui/tui-win.c (tui_set_win_height_command): Call
164 tui_adjust_window_height.
165 (tui_adjust_win_heights, new_height_ok): Remove.
166 * tui/tui-layout.h (tui_adjust_window_height): Declare.
167 * tui/tui-layout.c (tui_adjust_window_height): New function.
168
3d979945
TT
1692019-12-11 Tom Tromey <tom@tromey.com>
170
171 * tui/tui-win.c (tui_resize_all): Remove code, call
172 tui_apply_current_layout.
173
2192a9d3
TT
1742019-12-11 Tom Tromey <tom@tromey.com>
175
176 * tui/tui-layout.h (tui_apply_current_layout): Declare.
177 * tui/tui-layout.c (standard_layouts, applied_layout): New
178 globals.
179 (tui_apply_current_layout): New function.
180 (show_layout): Set applied_layout. Call
181 tui_apply_current_layout.
182 (show_source_command, show_disasm_command)
183 (show_source_disasm_command, show_data)
184 (show_source_or_disasm_and_command): Remove.
185 (initialize_layouts): New function.
186 (_initialize_tui_layout): Call initialize_layouts.
187
389e7ddb
TT
1882019-12-11 Tom Tromey <tom@tromey.com>
189
190 * tui/tui-layout.h (class tui_layout_base)
191 (class tui_layout_window, class tui_layout_split): New.
192 * tui/tui-layout.c (tui_get_window_by_name)
193 (tui_layout_window::clone, tui_layout_window::apply)
194 (tui_layout_window::get_sizes, tui_layout_window::add_split)
195 (tui_layout_split::add_window, tui_layout_split::clone)
196 (tui_layout_split::get_sizes)
197 (tui_layout_split::set_weights_from_heights)
198 (tui_layout_split::adjust_size, tui_layout_split::apply): New
199 functions.
200 (tui_layout_split::add_split, tui_layout_split::add_split)
201 (tui_layout_split::set_weights_from_heights)
202 (tui_layout_split::set_weights_from_heights): New functions.
203
fb3184d8
TT
2042019-12-11 Tom Tromey <tom@tromey.com>
205
206 * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
207 * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
208 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
209 * tui/tui-data.h (struct tui_point): Remove.
210 (struct tui_gen_win_info) <origin>: Remove.
211 <x, y>: New fields.
212 * tui/tui-command.c (tui_cmd_window::resize): Update.
213
dc7ff8a6
TT
2142019-12-11 Tom Tromey <tom@tromey.com>
215
216 * tui/tui-stack.h (struct tui_locator_window) <min_height>:
217 Implement.
218 * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
219 Implement.
220 * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
221 method.
222 (struct tui_win_info) <min_height>: Implement.
223
1431937b
TT
2242019-12-11 Tom Tromey <tom@tromey.com>
225
226 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
227 (struct tui_win_info) <can_box>: Update.
228
c8ec2f43
TT
2292019-12-11 Tom Tromey <tom@tromey.com>
230
231 * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
232 method.
233 * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
234 method.
235 * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
236 method.
237 (struct tui_win_info) <max_height>: Now override.
238
4decd62b
JB
2392019-12-11 Joel Brobecker <brobecker@adacore.com>
240
241 * NEWS: Create a new section for the next release branch.
242 Rename the section of the current branch, now that it has
243 been cut.
244
d746744e
JB
2452019-12-11 Joel Brobecker <brobecker@adacore.com>
246
247 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
248 * version.in: Bump version to 10.0.50.DATE-git.
249
2e744276
TT
2502019-12-11 Tom Tromey <tromey@adacore.com>
251
252 PR build/25268:
253 * gdbsupport/thread-pool.c (set_thread_name): New function.
254 (thread_pool::set_thread_count): Don't call pthread_setname_np.
255 (thread_pool::thread_function): Call set_thread_name.
256
aac4760f
TT
2572019-12-11 Tom Tromey <tromey@adacore.com>
258
259 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
260 bfd_get_signed_8.
261
d8edc8b7
PW
2622019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
263
264 * NEWS: Document -raw-values option and the related setting commands.
265 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
266 only set it on when /r is given.
267 * valprint.c (value_print_option_defs): New element raw-values.
268 * Makefile.in: Add the new file.
269
cb511130
CB
2702019-12-10 Christian Biesinger <cbiesinger@google.com>
271
272 * gdbsupport/safe-strerror.c: Supress the unused function warning
273 for select_strerror_r.
274
ab7d13f0
CB
2752019-12-10 Christian Biesinger <cbiesinger@google.com>
276
277 * config.in: Regenerate.
278 * configure: Regenerate.
279 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
280 safe_strerror instead of strerror.
281 * gdbsupport/common.m4: Don't check for strerror.
282 * gdbsupport/safe-strerror.c: Support both the glibc version
283 of strerror_r and the XSI version.
284
6c71eb7d
TT
2852019-12-10 Tom Tromey <tromey@adacore.com>
286
287 * ada-typeprint.c (print_choices): Use a single "?".
288 (print_variant_part): Print "?" if the discriminant name
289 is not known.
290
bac7c5cf
GB
2912019-12-10 George Barrett <bob@bob131.so>
292
293 Fix scripted probe breakpoints.
294 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
295 declaration forward.
296 (breakpoint_ops_for_event_location_type)
297 (breakpoint_ops_for_event_location): Add function definitions.
298 (break_command_1, trace_command): Use
299 breakpoint_ops_for_event_location.
300 * breakpoint.h (breakpoint_ops_for_event_location): Add function
301 declarations.
302 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
303 breakpoint_ops_for_event_location.
304 * python/py-breakpoint.c (bppy_init): Use
305 breakpoint_ops_for_event_location.
306
330f1d38
TBA
3072019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
308
309 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
310 when ranking an lvalue argument for an rvalue parameter.
311
b1f0c0b9
WA
3122019-12-08 Wataru Ashihara <wataash@wataash.com>
313
314 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
315 template argument for scoped_restore_tmpl from bool to int.
316
aa2d5a42
KS
3172019-12-07 Keith Seitz <keiths@redhat.com>
318
319 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
320 (build_id_to_debug_bfd): Make static, rewriting to use
321 build_id_to_bfd_suffix.
322 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
323 adding `suffix' parameter. Append SUFFIX to file names
324 when searching for matching files.
325 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
326 (build_id_to_exec_bfd): Likewise.
327 * build-id.h (build_id_to_debug_bfd): Clarify that function
328 searches for BFD of debug info file.
329 (build_id_to_exec_bfd): Declare.
330 * corelow.c: Include build-id.h.
331 (locate_exec_from_corefile_build_id): New function.
332 (core_target_open): If no executable BFD is found,
333 search for a core file BFD using build-id.
334
dfb65191
CB
3352019-12-06 Christian Biesinger <cbiesinger@google.com>
336
337 * bcache.c: Put in namespace gdb.
338 * bcache.h: Likewise.
339 * gdbtypes.c (check_types_worklist): Update.
340 (types_deeply_equal): Update.
341 * macrotab.c (struct macro_table) <bcache>: Update.
342 (new_macro_table): Update.
343 * macrotab.h (struct bcache): Put this forward declaration
344 inside namespace gdb.
345 (new_macro_table): Update.
346 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
347 Update.
348 <macro_cache>: Update.
349 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
350
93e55f0a
TV
3512019-12-06 Tom de Vries <tdevries@suse.de>
352
353 PR symtab/24971
354 * block.c (best_symbol, better_symbol): New function.
355 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
356 decl.
357
06acc08f
TBA
3582019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
359
360 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
361 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
362 for ranking see-through reference cases.
363
e0fad1ea
PW
3642019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
365 * stack.c (faas_command): Check a command is provided.
366 * thread.c (taas_command, tfaas_command): Likewise.
367
908641f5
PW
3682019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
369 * inferior.c (prune_inferiors): Only call delete_inferior,
370 Do not modify the inferior list.
371
b858499d
SM
3722019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
373
374 * c-exp.y: Update calls to lookup_typename,
375 lookup_signed_typename and lookup_unsigned_typename.
376 * c-lang.c (evaluate_subexp_c): Likewise.
377 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
378 Likewise.
379 * eval.c (binop_promote): Likewise.
380 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
381 (lookup_unsigned_typename): Likewise.
382 (lookup_signed_typename): Likewise.
383 * gdbtypes.h (lookup_unsigned_typename): Likewise.
384 (lookup_signed_typename): Likewise.
385 (lookup_typename): Likewise.
386 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
387 lookup_typename, lookup_signed_typename,
388 lookup_unsigned_typename.
389 * m2-exp.y: Likewise.
390 * printcmd.c (printf_wide_c_string): Likewise.
391 (ui_printf): Likewise.
392 * python/py-type.c (typy_lookup_typename): Likewise.
393 * python/py-xmethods.c (python_xmethod_worker::invoke):
394 Likewise.
395 * rust-exp.y: Likewise.
396
3a8fa228
CB
3972019-12-04 Christian Biesinger <cbiesinger@google.com>
398
399 * configure.nat (obsd64): Add missing files x86-nat.o and
400 nat/x86-dregs.o.
401
2dbc041e
TT
4022019-12-04 Tom Tromey <tom@tromey.com>
403
404 * valprint.c (val_print_string): Use metadata_style.
405 * go-valprint.c (print_go_string): Use metadata style.
406 * p-valprint.c (pascal_object_print_static_field): Use metadata
407 style.
408 * cp-valprint.c (cp_print_static_field): Use metadata style.
409
36c8fb93
AB
4102019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
411 Chris January <chris.january@arm.com>
412
413 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
414 tokens.
415 (typebase): New patterns for complex, single/double precision, and
416 single/double complex.
417 (f77_keywords): Change token for complex keyword, and add single,
418 double, and precision keywords.
419
c6170c2c
SM
4202019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
421
422 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
423 "info io_registers".
424
894ecaf4
SM
4252019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
426
427 * regcache.c (cooked_read_test): Initialize thread list of
428 mock_inferior.
429
be155ebb
SM
4302019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
431
432 * aarch64-linux-tdep.c: Remove includes.
433
c577cdd7
SM
4342019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
435
436 * aarch64-tdep.c: Remove includes.
437
610cfd61
SM
4382019-12-04 Simon Marchi <simon.marchi@efficios.com>
439
440 * filtered-iterator.h (filtered_iterator) <operator==,
441 operator!=>: Compare wrapped iterators, not wrapped pointers.
442 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
443 unittests/filtered_iterator-selftests.c.
444 * unittests/filtered_iterator-selftests.c: New file.
445
a05cf17a
TT
4462019-12-04 Tom Tromey <tromey@adacore.com>
447
448 * gdbtypes.c (create_range_type): Inherit endianity
449 from base type.
450
d5a22e77
TT
4512019-12-04 Tom Tromey <tromey@adacore.com>
452
453 * ada-lang.c (decode_constrained_packed_array)
454 (ada_value_assign, value_assign_to_component): Update.
455 * dwarf2loc.c (rw_pieced_value, access_memory)
456 (dwarf2_compile_expr_to_ax): Update.
457 * dwarf2read.c (dwarf2_add_field): Update.
458 * eval.c (evaluate_subexp_standard): Update.
459 * gdbarch.c, gdbarch.h: Rebuild.
460 * gdbarch.sh (bits_big_endian): Remove.
461 * gdbtypes.h (union field_location): Update comment.
462 * target-descriptions.c (make_gdb_type): Update.
463 * valarith.c (value_bit_index): Update.
464 * value.c (struct value) <bitpos>: Update comment.
465 (unpack_bits_as_long, modify_field): Update.
466 * value.h (value_bitpos): Update comment.
467
7ab4a236
TT
4682019-12-04 Tom Tromey <tromey@adacore.com>
469
470 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
471 endian-ness.
472
103a685e
TT
4732019-12-04 Tom Tromey <tromey@adacore.com>
474
475 * dwarf2read.c (dwarf2_init_float_type)
476 (dwarf2_init_complex_target_type): Add byte_order parameter.
477 (read_base_type): Compute byte order earlier.
478 * gdbtypes.c (init_float_type): Add byte_order parameter.
479 * gdbtypes.h (init_float_type): Add byte_order parameter.
480
7a9e9f9f
TT
4812019-12-04 Tom Tromey <tromey@adacore.com>
482
483 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
484
feee869b
TT
4852019-12-04 Tom Tromey <tromey@adacore.com>
486
487 * dwarf2read.c (process_structure_scope): Initialize
488 "discr_offset".
489
c2512106
AB
4902019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
491
492 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
493 add it into the search spec.
494 (parse_max_results_option): New function.
495 (mi_info_functions_or_variables): Parse -max-results flag and pass
496 it to mi_symbol_info.
497 (mi_cmd_symbol_info_modules): Likewise.
498 (mi_cmd_symbol_info_types): Likewise.
499 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
500 return type to bool, change result container into a set, and don't
501 add new results if we have enough already.
502 (global_symbol_searcher::add_matching_msymbols): Change return
503 type to bool, and don't add new results if we have enough already.
504 (sort_search_symbols_remove_dups): Delete.
505 (global_symbol_searcher::search): Early exit from search loop when
506 we have enough results. Use a std::set to collect the results
507 from calling add_matching_symbols.
508 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
509 member function.
510 (global_symbol_searcher) <m_max_search_results>: New member
511 variable.
512 (global_symbol_searcher) <add_matching_symbols>: Update header
513 comment and change return type to bool.
514 (global_symbol_searcher) <add_matching_msymbols>: Update header
515 comment and change return type to bool.
516
f97a63c5
AB
5172019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
518
519 * symtab.c (symbol_search::compare_search_syms): Update header
520 comment.
521 (global_symbol_searcher::is_suitable_msymbol): New function.
522 (global_symbol_searcher::expand_symtabs): New function.
523 (global_symbol_searcher::add_matching_symbols): New function.
524 (global_symbol_searcher::add_matching_msymbols): New function.
525 (global_symbol_searcher::search): Move most of the content
526 into the new functions above, and call them as needed.
527 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
528 function.
529 (global_symbol_searcher) <add_matching_symbols>: New member
530 function.
531 (global_symbol_searcher) <add_matching_msymbols>: New member
532 function.
533 (global_symbol_searcher) <is_suitable_msymbol>: New member
534 function.
535
293b38d6
AB
5362019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
537
538 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
539 -symbol-info-module-variables entries.
540 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
541 (mi_cmd_symbol_info_module_variables): Declare.
542 * mi/mi-symbol-cmds.c
543 (module_symbol_search_iterator): New typedef.
544 (output_module_symbols_in_single_module_and_file): New function.
545 (output_module_symbols_in_single_module): New function.
546 (mi_info_module_functions_or_variables): New function.
547 (mi_cmd_symbol_info_module_functions): New function.
548 (mi_cmd_symbol_info_module_variables): New function.
549 * NEWS: Mention new MI command.
550
4cbd39b2
CB
5512019-12-03 Christian Biesinger <cbiesinger@google.com>
552
553 * bcache.c (hash): Remove.
554 (hash_continue): Remove.
555 * bcache.h (hash): Remove.
556 (hash_continue): Remove.
557 (struct bcache) <ctor>: Update.
558 * psymtab.c (psymbol_hash): Update.
559 * stabsread.c (hashname): Update.
560 * utils.h (fast_hash): Add an argument for a start value,
561 defaulting to zero.
562
82f910ea
PW
5632019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
564 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
565 (destroy_block_symbol_cache): New function.
566 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
567 (resize_symbol_cache): Likewise.
568
de2396d0
TT
5692019-12-02 Tom Tromey <tom@tromey.com>
570
571 * unittests/tui-selftests.c (run_tests): Make conditional.
572 (_initialize_tui_selftest): Make conditional.
573
638d85bc
CB
5742019-12-02 Christian Biesinger <cbiesinger@google.com>
575
576 * aix-thread.c (debug_aix_thread): Change type to bool.
577
7532a164
LM
5782019-12-02 Luis Machado <luis.machado@linaro.org>
579
580 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
581
216a7e6b
AB
5822019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
583
584 * dwarf2read.c (read_tag_string_type): Read the fields required to
585 make a dynamic string, and possibly create a dynamic range for the
586 string.
587 (attr_to_dynamic_prop): Setup is_reference based on the type of
588 attribute being processed.
589 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
590 (resolve_dynamic_array): Rename to...
591 (resolve_dynamic_array_or_string): ...this, update header comment,
592 and accept TYPE_CODE_STRING.
593 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
594
11a8b164
AB
5952019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
596
597 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
598 of its implementation from...
599 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
600 the new function.
601
5bbd8269
AB
6022019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
603
604 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
605 create a range with stride where appropriate.
606 * f-valprint.c: Include 'gdbarch.h'.
607 (f77_print_array_1): Take the stride into account when walking the
608 array. Also convert the stride into addressable units.
609 * gdbtypes.c (create_range_type): Initialise the stride to
610 constant zero.
611 (create_range_type_with_stride): New function, initialise the
612 range as normal, and then setup the stride.
613 (has_static_range): Include the stride here. Also change the
614 return type to bool.
615 (create_array_type_with_stride): Consider the range stride if the
616 array isn't given its own stride.
617 (resolve_dynamic_range): Resolve the stride if needed.
618 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
619 (struct range_bounds) <flag_is_byte_stride>: New member variable.
620 (TYPE_BIT_STRIDE): Define.
621 (TYPE_ARRAY_BIT_STRIDE): Define.
622 (create_range_type_with_stride): Declare.
623 * valarith.c (value_subscripted_rvalue): Take range stride into
624 account when walking the array.
625
82e3b564
TT
6262019-12-01 Tom Tromey <tom@tromey.com>
627
628 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
629 specially.
630
517d261d
TT
6312019-12-01 Tom Tromey <tom@tromey.com>
632
633 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
634 \0.
635 * unittests/tui-selftests.c: New file.
636 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
637
484c9b64
TT
6382019-12-01 Tom Tromey <tom@tromey.com>
639
640 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
641
a2a7af0c
TT
6422019-12-01 Tom Tromey <tom@tromey.com>
643
644 * NEWS: Document new settings.
645 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
646 * tui/tui-win.c (_initialize_tui_win): Add border style
647 observers.
648 * tui/tui-io.h (tui_apply_style): Declare.
649 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
650 longer static.
651 (apply_ansi_escape, tui_set_reverse_mode): Update.
652 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
653 Add "skip_intensity" parameter.
654 <changed>: New member.
655 <do_set_value>: Declare.
656 (tui_border_style, tui_active_border_style): Declare.
657 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
658 globals.
659 (cli_style_option): Initialize "changed".
660 (cli_style_option::do_set_value): New function.
661 (cli_style_option::add_setshow_commands): Add "skip_intensity"
662 parameter. Update.
663 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
664 (_initialize_cli_style): Update. Create TUI border style
665 commands.
666
d1da6b01
TT
6672019-12-01 Tom Tromey <tom@tromey.com>
668
669 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
670 parameter.
671 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
672 parameter.
673 * tui/tui-win.h (compact_source): Declare.
674 * tui/tui-win.c (compact_source): New global.
675 (tui_set_compact_source, tui_show_compact_source): New functions.
676 (_initialize_tui_win): Add "compact-source" setting.
677 * tui/tui-source.c (tui_source_window::set_contents): Handle
678 compact_source setting.
679 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
680 * NEWS: Document new setting.
681
489dbda6
TT
6822019-11-30 Tom Tromey <tom@tromey.com>
683
684 * dwarf2read.c (dwarf2_add_field): Include field offset when
685 computing variant part length.
686
bf498525
PW
6872019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
688 * NEWS: Mention define-prefix. Tell that command names can now
689 contain a . character.
690
be09caf1
PW
6912019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
692
693 * command.h (valid_cmd_char_p): Declare.
694 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
695 the check of valid command char.
696 (find_command_name_length, valid_user_defined_cmd_name_p): Use
697 valid_cmd_char_p.
698 * cli/cli-script.c (validate_comname): Likewise.
699 * completer.c (gdb_completer_command_word_break_characters):
700 Do not remove . from the word break char, update comments.
701 (complete_line_internal_1): Use valid_cmd_char_p.
702 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
703 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
704
c6ac7fc9
PW
7052019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
706
707 * cli/cli-script.c (do_define_command): Ensure a redefined
708 prefix command is kept as a prefix command.
709 (define_prefix_command): New function.
710 (show_user_1): Report user defined prefixes.
711 (_initialize_cli_script): Create the new 'define-prefix' command.
712 Add completers for 'define' and 'document'.
713 * top.c (execute_command): If command is a user-defined prefix only
714 command, report the list of commands for this prefix command.
715
a992a3b0
TBA
7162019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
717
718 * valops.c (find_oload_champ): Improve debug output.
719
e9194a1a
TBA
7202019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
721
722 * valops.c (find_oload_champ): Print part of debug messages
723 before the badness vector is std::move'd.
724
53a008a6
TT
7252019-11-28 Tom Tromey <tom@tromey.com>
726
727 * value.c (creal_internal_fn): Fix comment.
728
bab05c83
TT
7292019-11-28 Tom Tromey <tom@tromey.com>
730
731 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
732 flag_bound_evaluated>: Now unsigned.
733
2522f049
TT
7342019-11-28 Tom Tromey <tom@tromey.com>
735
736 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
737 declare.
738
38b49e22
MS
7392019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
740
741 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
742 debug output.
743 * jit.c (jit_unregister_code): Add debug print to match
744 `jit_register_code`.
745
35125921
CB
7462019-11-27 Christian Biesinger <cbiesinger@google.com>
747
748 * NEWS: Mention the new multithreaded symbol loading.
749
62e77f56
CB
7502019-11-27 Christian Biesinger <cbiesinger@google.com>
751
752 * maint.c (n_worker_threads): Default to 0.
753 (worker_threads_disabled): New function.
754 * maint.h (worker_threads_disabled): New function.
755 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
756 here if worker_threads_disabled () is true.
757 (minimal_symbol_reader::install): Skip all threading if
758 worker_threads_disabled () is true.
759
f29d7f6b
CB
7602019-11-27 Christian Biesinger <cbiesinger@google.com>
761
762 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
763 hash code if possible.
764 (add_minsym_to_demangled_hash_table): Likewise.
765 (minimal_symbol_reader::install): Compute the hash codes for msymbol
766 on the background thread.
767 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
768 Add these fields.
769
e76b2246
CB
7702019-11-27 Christian Biesinger <cbiesinger@google.com>
771
772 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
773 of the mangled name on the background thread.
774 * symtab.c (symbol_set_names): Allow passing in the hash of the
775 linkage_name.
776 * symtab.h (symbol_set_names): Likewise.
777
8d9a2568
KB
7782019-11-27 Kevin Buettner <kevinb@redhat.com>
779
780 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
781 physnames are computed for inherited DIEs.
782
fad03f6e
TT
7832019-11-27 Tom Tromey <tromey@adacore.com>
784
785 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
786 backslashes.
787 * cp-support.c: Remove unnecessary backslashes.
788
43678b0a
CB
7892019-11-27 Christian Biesinger <cbiesinger@google.com>
790
791 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
792 with sym->set_linkage_name.
793 * coffread.c (coff_read_enum_type): Likewise.
794 * mdebugread.c (parse_symbol): Likewise.
795 * stabsread.c (patch_block_stabs): Likewise.
796 (define_symbol): Likewise.
797 (read_enum_type): Likewise.
798 (common_block_end): Likewise.
799 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
800 function.
801 (SYMBOL_SET_LINKAGE_NAME): Remove.
802 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
803 with sym->set_linkage_name.
804
db5960b4
AB
8052019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
806
807 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
808 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
809 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
810 * NEWS: Mention new MI command.
811
7dc42066
AB
8122019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
813
814 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
815 '-symbol-info-types', and '-symbol-info-variables'.
816 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
817 (mi_cmd_symbol_info_types): Declare.
818 (mi_cmd_symbol_info_variables): Declare.
819 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
820 (output_debug_symbol): New function.
821 (output_nondebug_symbol): New function.
822 (mi_symbol_info): New function.
823 (mi_info_functions_or_variables): New function.
824 (mi_cmd_symbol_info_functions): New function.
825 (mi_cmd_symbol_info_types): New function.
826 (mi_cmd_symbol_info_variables): New function.
827 * NEWS: Mention new commands.
828
5f512a7d
AB
8292019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
830
831 * symtab.c (symbol_to_info_string): New function, most content
832 moved from print_symbol_info, but updated to return a std::string.
833 (print_symbol_info): Update to use symbol_to_info_string and print
834 returned string.
835 * symtab.h (symbol_to_info_string): Declare new function.
836
470c0b1c
AB
8372019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
838
839 * python/python.c (gdbpy_rbreak): Convert to using
840 global_symbol_searcher.
841 * symtab.c (file_matches): Convert return type to bool, change
842 file list to std::vector, update header comment.
843 (search_symbols): Rename to...
844 (global_symbol_searcher::search): ...this and update now its
845 a member function of global_symbol_searcher. Take account of the
846 changes to file_matches.
847 (symtab_symbol_info): Convert to using global_symbol_searcher.
848 (rbreak_command): Likewise.
849 (search_module_symbols): Likewise.
850 * symtab.h (enum symbol_search): Update comment.
851 (search_symbols): Remove declaration.
852 (class global_symbol_searcher): New class.
853
57357d9d
TT
8542019-11-26 Tom Tromey <tromey@adacore.com>
855
856 * cp-support.c (_initialize_cp_support): Conditionally initialize
857 gdb_demangle_attempt_core_dump.
858
3ea16160
TT
8592019-11-26 Tom Tromey <tom@tromey.com>
860
861 * python/py-function.c (fnpy_init): Update.
862 * value.h (add_internal_function): Adjust declaration.
863 * value.c (function_destroyer): Remove.
864 (do_add_internal_function): Don't set destroyer or copy name.
865 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
866 Set name_allocated.
867 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
868 (cmdpy_init): Set name_allocated.
869 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
870 member.
871 (~cmd_list_element): Free "name" if needed.
872
1a6d41c6
TT
8732019-11-26 Tom Tromey <tom@tromey.com>
874
875 * value.h (add_internal_function): Add new overload. Move
876 documentation from value.h.
877 * value.c (do_add_internal_function): New function.
878 (add_internal_function): Use it. Add new overload.
879 (function_destroyer): Don't free doc.
880 * python/py-function.c (fnpy_init): Update.
881
8318f3c3
TT
8822019-11-26 Tom Tromey <tom@tromey.com>
883
884 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
885 (cmdpy_init): Set "doc_allocated".
886
4da8c3a8
TT
8872019-11-26 Tom Tromey <tom@tromey.com>
888
889 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
890 name of worker thread.
891 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
892 pthread_setname_np.
893 * configure, config.in: Rebuild.
894
971db5e2
TT
8952019-11-26 Tom Tromey <tom@tromey.com>
896
897 * python/python.c (class gdbpy_gil): New.
898 (struct gdbpy_event): Add constructor, destructor, operator().
899 (gdbpy_post_event): Use run_on_main_thread.
900 (gdbpy_initialize_events): Remove.
901 (do_start_initialization): Update.
902
22138db6
TT
9032019-11-26 Tom Tromey <tom@tromey.com>
904
905 * NEWS: Add entry.
906 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
907 commands. Call update_thread_pool_size.
908 (update_thread_pool_size, maintenance_set_worker_threads): New
909 functions.
910 (n_worker_threads): New global.
911
d55c9a68
TT
9122019-11-26 Christian Biesinger <cbiesinger@google.com>
913 Tom Tromey <tom@tromey.com>
914
915 * minsyms.c (minimal_symbol_reader::install): Use
916 parallel_for_each.
917 * gdbsupport/parallel-for.h: New file.
918 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
919
a0b57563
CB
9202019-11-26 Christian Biesinger <cbiesinger@google.com>
921 Tom Tromey <tom@tromey.com>
922
923 * gdbsupport/thread-pool.h: New file.
924 * gdbsupport/thread-pool.c: New file.
925 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
926 (HFILES_NO_SRCDIR): Add thread-pool.h.
927
3b3978bc
TT
9282019-11-26 Tom Tromey <tom@tromey.com>
929
930 * event-top.h (thread_local_segv_handler): Declare.
931 * event-top.c (thread_local_segv_handler): New global.
932 (install_handle_sigsegv, handle_sigsegv): New functions.
933 (async_init_signals): Install SIGSEGV handler.
934 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
935 thread-local.
936 (report_failed_demangle): New function.
937 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
938 handler-setting code, instead use segv_handler. Run warning code
939 on main thread.
940
9411c49e
TT
9412019-11-26 Tom Tromey <tom@tromey.com>
942
943 * run-on-main-thread.c: New file.
944 * run-on-main-thread.h: New file.
945 * unittests/main-thread-selftests.c: New file.
946 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
947 main-thread-selftests.c.
948 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
949 (COMMON_SFILES): Add run-on-main-thread.c.
950
c3efb965
TT
9512019-11-26 Tom Tromey <tom@tromey.com>
952
953 * main.c (setup_alternate_signal_stack): Remove.
954 (captured_main_1): Use gdb::alternate_signal_stack.
955 * gdbsupport/alt-stack.h: New file.
956
21987b9c
TT
9572019-11-26 Tom Tromey <tom@tromey.com>
958
959 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
960 Remove comment.
961 (save_original_signals_state, restore_original_signals_state): Use
962 gdb_sigmask.
963 * linux-nat.c (block_child_signals, restore_child_signals_mask)
964 (_initialize_linux_nat): Use gdb_sigmask.
965 * guile/guile.c (_initialize_guile): Use block_signals.
966 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
967 * gdbsupport/gdb-sigmask.h: New file.
968 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
969 * cp-support.c (gdb_demangle): Use gdb_sigmask.
970 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
971 pthread_sigmask.
972 * configure, config.in: Rebuild.
973 * gdbsupport/block-signals.h: New file.
974
5e030278
TT
9752019-11-26 Tom Tromey <tom@tromey.com>
976
977 * acinclude.m4: Include ax_pthread.m4.
978 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
979 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
980 (CLIBS): Use PTHREAD_LIBS.
981 (aclocal_m4_deps): Add ax_pthread.m4.
982 * config.in, configure: Rebuild.
983 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
984
5a79c107
TT
9852019-11-26 Tom Tromey <tom@tromey.com>
986
987 * symtab.h (struct minimal_symbol) <name_set>: New member.
988 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
989 Don't call symbol_set_names.
990 (minimal_symbol_reader::install): Call symbol_set_names.
991
aa369509
PW
9922019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
993
994 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
995 restore_active_ext_lang, as GIL is needed for (indirectly)
996 called PyOS_InterruptOccurred.
997
cadc9cb8
SM
9982019-11-26 Simon Marchi <simon.marchi@efficios.com>
999
1000 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1001 definition.
1002
d04afd58
SM
10032019-11-26 Simon Marchi <simon.marchi@efficios.com>
1004
1005 * remote-sim.c (simulator_command): Make static, remove
1006 declaration.
1007
dd694d77
SM
10082019-11-26 Simon Marchi <simon.marchi@efficios.com>
1009
1010 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1011 static.
1012 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1013 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1014 (main): Likewise.
1015 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1016 (main): Likewise.
1017 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1018 (main): Likewise.
1019 * unittests/basic_string_view/element_access/char/1.cc (test01):
1020 Likewise.
1021 (main): Likewise.
1022 * unittests/basic_string_view/element_access/char/empty.cc (main):
1023 Likewise.
1024 * unittests/basic_string_view/element_access/char/front_back.cc
1025 (test01): Likewise.
1026 (main): Likewise.
1027 * unittests/basic_string_view/inserters/char/2.cc (test05):
1028 Likewise.
1029 (main): Likewise.
1030 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1031 (test01): Likewise.
1032 (main): Likewise.
1033 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1034 (test01): Likewise.
1035 (main): Likewise.
1036 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1037 Likewise.
1038 * unittests/basic_string_view/operations/compare/char/1.cc
1039 (test01): Likewise.
1040 (main): Likewise.
1041 * unittests/basic_string_view/operations/compare/char/13650.cc
1042 (test01): Likewise.
1043 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1044 Likewise.
1045 (main): Likewise.
1046 * unittests/basic_string_view/operations/data/char/1.cc (test01):
1047 Likewise.
1048 (main): Likewise.
1049 * unittests/basic_string_view/operations/find/char/1.cc (test01):
1050 Likewise.
1051 (main): Likewise.
1052 * unittests/basic_string_view/operations/find/char/2.cc (test02):
1053 Likewise.
1054 (main): Likewise.
1055 * unittests/basic_string_view/operations/find/char/3.cc (test03):
1056 Likewise.
1057 (main): Likewise.
1058 * unittests/basic_string_view/operations/find/char/4.cc (main):
1059 Likewise.
1060 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1061 Likewise.
1062 (main): Likewise.
1063 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1064 Likewise.
1065 (main): Likewise.
1066 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1067 Likewise.
1068 (main): Likewise.
1069 * unittests/basic_string_view/operations/substr/char/1.cc
1070 (test01): Likewise.
1071 (main): Likewise.
1072 * unittests/basic_string_view/operators/char/2.cc (main):
1073 Likewise.
1074 * unittests/optional/assignment/1.cc (test): Likewise.
1075 * unittests/optional/assignment/2.cc (test): Likewise.
1076 * unittests/optional/assignment/3.cc (test): Likewise.
1077 * unittests/optional/assignment/4.cc (test): Likewise.
1078 * unittests/optional/assignment/5.cc (test): Likewise.
1079 * unittests/optional/assignment/6.cc (test): Likewise.
1080 * unittests/optional/assignment/7.cc (test): Likewise.
1081 * unittests/optional/cons/copy.cc (test): Likewise.
1082 * unittests/optional/cons/default.cc (test): Likewise.
1083 * unittests/optional/cons/move.cc (test): Likewise.
1084 * unittests/optional/cons/value.cc (test): Likewise.
1085 * unittests/optional/in_place.cc (test): Likewise.
1086 * unittests/optional/observers/1.cc (test): Likewise.
1087 * unittests/optional/observers/2.cc (test): Likewise.
1088
3b5c1d49
SM
10892019-11-26 Simon Marchi <simon.marchi@efficios.com>
1090
1091 * tui-win.h (tui_set_var_cmd): Remove.
1092 * tui-win.c (tui_set_var_cmd): Make static.
1093
adce99fe
SM
10942019-11-26 Simon Marchi <simon.marchi@efficios.com>
1095
1096 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1097 rbreak_command_wrapper): Remove.
1098 * symtab.c (rbreak_command_wrapper): Remove.
1099
fe3adccf
SM
11002019-11-26 Simon Marchi <simon.marchi@efficios.com>
1101
1102 * inferior.h (info_terminal_command): Remove declaration.
1103 * inflow.c (info_terminal_command): Make static.
1104
b926335f
SM
11052019-11-26 Simon Marchi <simon.marchi@efficios.com>
1106
1107 * inferior.c (exit_inferior_silent): Remove.
1108
b62f6f54
SM
11092019-11-26 Simon Marchi <simon.marchi@efficios.com>
1110
1111 * dictionary.c (dict_empty, mdict_empty): Remove.
1112 * dictionary.c (mdict_empty): Remove.
1113
cb8c24b6
SM
11142019-11-26 Simon Marchi <simon.marchi@efficios.com>
1115
1116 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1117 (arc_insn_get_memory_offset): Likewise.
1118 (arc_insn_dump): Likewise.
1119 * cp-support.c (test_cp_symbol_name_matches): Likewise.
1120 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1121 * dictionary.c (dict_iterator_next): Likewise.
1122 (dict_iter_match_first): Likewise.
1123 (dict_iter_match_next): Likewise.
1124 * f-lang.c (evaluate_subexp_f): Likewise.
1125 * hppa-tdep.c (hppa_read_pc): Likewise.
1126 * i386-tdep.c (i386_floatformat_for_type): Likewise.
1127 * parse.c (write_exp_elt_msym): Likewise.
1128 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1129 * remote.c (remote_packet_size): Likewise.
1130 (remote_notif_stop_parse): Likewise.
1131 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1132 * s12z-tdep.c (s12z_disassemble_info): Likewise.
1133 * source.c (prepare_path_for_appending): Likewise.
1134 * sparc64-linux-tdep.c
1135 (sparc64_linux_handle_segmentation_fault); Likewise.
1136 * stack.c (frame_selection_by_function_completer): Likewise.
1137
781597ff
SM
11382019-11-26 Simon Marchi <simon.marchi@efficios.com>
1139
1140 * completer.c (set_gdb_completion_word_break_characters):
1141 Remove.
1142
23baa4cc
SM
11432019-11-26 Simon Marchi <simon.marchi@efficios.com>
1144
1145 * dwarf-index-write.c: Include dwarf-index-write.h.
1146 * mi/mi-interp.c: Include mi/mi-interp.h.
1147
23767560
SM
11482019-11-26 Simon Marchi <simon.marchi@efficios.com>
1149
1150 * aarch32-tdep.c: Include aarch32-tdep.h.
1151 * aarch32-tdep.h: Forward-declare struct target_desc.
1152
6d91ce9a
CB
11532019-11-26 Christian Biesinger <cbiesinger@google.com>
1154
1155 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1156 strerror.
1157 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1158 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1159
3cf2f237
TV
11602019-11-25 Tom de Vries <tdevries@suse.de>
1161
1162 * contrib/words.sh: Add -c option.
1163
5b89c67a
CB
11642019-11-25 Christian Biesinger <cbiesinger@google.com>
1165
1166 * solib.c (solib_find_1): Change int to bool.
1167 (exec_file_find): Change int to bool.
1168 (solib_find): Change int to bool.
1169 (solib_read_symbols): Change int to bool.
1170 (solib_used): Change int to bool.
1171 (solib_add): Change int to bool.
1172 (info_sharedlibrary_command): Change int to bool.
1173 (solib_contains_address_p): Change int to bool.
1174 (solib_keep_data_in_core): Change int to bool.
1175 (in_solib_dynsym_resolve_code): Change int to bool.
1176 (reload_shared_libraries_1): Change int to bool.
1177 (gdb_sysroot_changed): Change int to bool.
1178 * solib.h (solib_read_symbols): Change int to bool.
1179 (solib_contains_address_p): Change int to bool.
1180 (solib_keep_data_in_core): Change int to bool.
1181 (in_solib_dynsym_resolve_code): Change int to bool.
1182 (libpthread_name_p): Change int to bool.
1183
6cc8564b
LM
11842019-11-25 Luis Machado <luis.machado@linaro.org>
1185
1186 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1187 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1188 (remote_packet_max_chars): New static global.
1189 (show_remote_packet_max_chars): New function.
1190 (remote_target::putpkt_binary): Adjust to use new
1191 remote_packet_max_chars option.
1192 (remote_target::getpkt_or_notif_sane_1): Likewise.
1193 (_initialize_remote): Register new remote-packet-max-chars option.
1194
a7cdaa91
SM
11952019-11-24 Simon Marchi <simon.marchi@efficios.com>
1196
1197 * m68k-linux-nat.c: Include gdbarch.h.
1198
26abc753
TT
11992019-11-24 Tom Tromey <tom@tromey.com>
1200
1201 * symfile.c (read_symbols): Update.
1202 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1203 bool.
1204 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1205 (psym_lookup_symbol, psym_find_last_source_symtab)
1206 (psym_forget_cached_source_info, psym_print_stats)
1207 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1208 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1209 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1210 (psym_find_compunit_symtab_by_address)
1211 (maintenance_print_psymbols, maintenance_info_psymtabs)
1212 (maintenance_check_psymtabs): Update.
1213 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1214 bool.
1215
012fc909
TT
12162019-11-22 Tom Tromey <tom@tromey.com>
1217
1218 * observable.h: Update comments.
1219
c83d8d32
TT
12202019-11-22 Tom Tromey <tromey@adacore.com>
1221
1222 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1223 (print_ada_task_info): Don't try to fetch thread id if task is not
1224 alive.
1225
987012b8
CB
12262019-11-22 Christian Biesinger <cbiesinger@google.com>
1227
1228 * ada-exp.y: Update.
1229 * ada-lang.c (sort_choices): Update.
1230 (ada_print_symbol_signature): Update.
1231 (resolve_subexp): Update.
1232 (ada_parse_renaming): Update.
1233 (ada_read_renaming_var_value): Update.
1234 (lesseq_defined_than): Update.
1235 (remove_extra_symbols): Update.
1236 (remove_irrelevant_renamings): Update.
1237 (ada_add_block_symbols): Update.
1238 (ada_collect_symbol_completion_matches): Update.
1239 (ada_is_renaming_symbol): Update.
1240 (aggregate_assign_from_choices): Update.
1241 (ada_evaluate_subexp): Update.
1242 (ada_has_this_exception_support): Update.
1243 (ada_is_non_standard_exception_sym): Update.
1244 (ada_add_exceptions_from_frame): Update.
1245 (ada_add_global_exceptions): Update.
1246 (ada_print_subexp): Update.
1247 * ax-gdb.c (gen_var_ref): Update.
1248 (gen_maybe_namespace_elt): Update.
1249 (gen_expr_for_cast): Update.
1250 (gen_expr): Update.
1251 * block.h: Update.
1252 * blockframe.c (find_pc_partial_function): Update.
1253 * breakpoint.c (print_breakpoint_location): Update.
1254 (update_static_tracepoint): Update.
1255 * btrace.c (ftrace_print_function_name): Update.
1256 (ftrace_function_switched): Update.
1257 * buildsym.c (find_symbol_in_list): Update.
1258 * c-exp.y: Update.
1259 * c-typeprint.c (c_print_typedef): Update.
1260 (c_type_print_template_args): Update.
1261 * cli/cli-cmds.c (edit_command): Update.
1262 (list_command): Update.
1263 (print_sal_location): Update.
1264 * coffread.c (patch_opaque_types): Update.
1265 (process_coff_symbol): Update.
1266 (coff_read_enum_type): Update.
1267 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1268 (convert_one_symbol): Update.
1269 (hash_symname): Update.
1270 (eq_symname): Update.
1271 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1272 * compile/compile-cplus-types.c (debug_print_scope): Update.
1273 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1274 * compile/compile-object-load.c (get_out_value_type): Update.
1275 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1276 (search_symbol_list): Update.
1277 (cp_lookup_symbol_imports_or_template): Update.
1278 * cp-support.c (overload_list_add_symbol): Update.
1279 * ctfread.c (psymtab_to_symtab): Update.
1280 * dbxread.c (cp_set_block_scope): Update.
1281 * dictionary.c (iter_match_first_hashed): Update.
1282 (iter_match_next_hashed): Update.
1283 (insert_symbol_hashed): Update.
1284 (iter_match_next_linear): Update.
1285 * dictionary.h: Update.
1286 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1287 (locexpr_describe_location_piece): Update.
1288 (locexpr_describe_location_1): Update.
1289 (locexpr_generate_c_location): Update.
1290 (loclist_describe_location): Update.
1291 (loclist_generate_c_location): Update.
1292 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1293 (read_func_scope): Update.
1294 (process_enumeration_scope): Update.
1295 (new_symbol): Update.
1296 (dwarf2_const_value): Update.
1297 (dwarf2_symbol_mark_computed): Update.
1298 * eval.c (evaluate_funcall): Update.
1299 (evaluate_subexp_standard): Update.
1300 * expprint.c (print_subexp_standard): Update.
1301 (dump_subexp_body_standard): Update.
1302 * f-valprint.c (info_common_command_for_block): Update.
1303 * findvar.c (get_hosting_frame): Update.
1304 (default_read_var_value): Update.
1305 * go-lang.c (go_symbol_package_name): Update.
1306 * guile/scm-block.c (bkscm_print_block_smob): Update.
1307 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1308 (gdbscm_symbol_name): Update.
1309 (gdbscm_symbol_linkage_name): Update.
1310 (gdbscm_symbol_print_name): Update.
1311 * infcall.c (get_function_name): Update.
1312 * infcmd.c (jump_command): Update.
1313 (finish_command): Update.
1314 * infrun.c (insert_exception_resume_breakpoint): Update.
1315 * linespec.c (canonicalize_linespec): Update.
1316 (create_sals_line_offset): Update.
1317 (convert_linespec_to_sals): Update.
1318 (complete_label): Update.
1319 (find_label_symbols_in_block): Update.
1320 * m2-typeprint.c (m2_print_typedef): Update.
1321 * mdebugread.c (mdebug_reg_to_regnum): Update.
1322 (parse_symbol): Update.
1323 (mylookup_symbol): Update.
1324 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1325 (list_args_or_locals): Update.
1326 * objc-lang.c (compare_selectors): Update.
1327 (info_selectors_command): Update.
1328 (compare_classes): Update.
1329 (info_classes_command): Update.
1330 (find_imps): Update.
1331 * p-typeprint.c (pascal_print_typedef): Update.
1332 * printcmd.c (build_address_symbolic): Update.
1333 (info_address_command): Update.
1334 (print_variable_and_value): Update.
1335 * python/py-framefilter.c (extract_sym): Update.
1336 (py_print_single_arg): Update.
1337 * python/py-symbol.c (sympy_str): Update.
1338 (sympy_get_name): Update.
1339 (sympy_get_linkage_name): Update.
1340 * python/python.c (gdbpy_rbreak): Update.
1341 * record-btrace.c (btrace_get_bfun_name): Update.
1342 (btrace_call_history): Update.
1343 * rust-lang.c (rust_print_typedef): Update.
1344 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1345 * stabsread.c (stab_reg_to_regnum): Update.
1346 (define_symbol): Update.
1347 (read_enum_type): Update.
1348 (common_block_end): Update.
1349 (cleanup_undefined_types_1): Update.
1350 (scan_file_globals): Update.
1351 * stack.c (print_frame_arg): Update.
1352 (print_frame_args): Update.
1353 (find_frame_funname): Update.
1354 (info_frame_command_core): Update.
1355 (iterate_over_block_locals): Update.
1356 (print_block_frame_labels): Update.
1357 (do_print_variable_and_value): Update.
1358 (iterate_over_block_arg_vars): Update.
1359 (return_command): Update.
1360 * symmisc.c (dump_symtab_1): Update.
1361 (print_symbol): Update.
1362 * symtab.c (eq_symbol_entry): Update.
1363 (symbol_cache_dump): Update.
1364 (lookup_language_this): Update.
1365 (find_pc_sect_line): Update.
1366 (skip_prologue_sal): Update.
1367 (symbol_search::compare_search_syms): Update.
1368 (treg_matches_sym_type_name): Update.
1369 (search_symbols): Update.
1370 (print_symbol_info): Update.
1371 (rbreak_command): Update.
1372 (completion_list_add_symbol): Update.
1373 (find_gnu_ifunc): Update.
1374 (get_symbol_address): Update.
1375 (search_module_symbols): Update.
1376 (info_module_subcommand): Update.
1377 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1378 (SYMBOL_LINKAGE_NAME): Remove.
1379 (SYMBOL_DEMANGLED_NAME): Remove.
1380 (SYMBOL_PRINT_NAME): Remove.
1381 (SYMBOL_SEARCH_NAME): Remove.
1382 * tracepoint.c (set_traceframe_context): Update.
1383 (validate_actionline): Update.
1384 (collection_list::collect_symbol): Update.
1385 (encode_actions_1): Update.
1386 (info_scope_command): Update.
1387 (print_one_static_tracepoint_marker): Update.
1388 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1389 * valops.c (address_of_variable): Update.
1390 (find_overload_match): Update.
1391 (find_oload_champ): Update.
1392
c9d95fa3
CB
13932019-11-22 Christian Biesinger <cbiesinger@google.com>
1394
1395 * ada-lang.c (ada_lookup_simple_minsym): Update.
1396 (ada_collect_symbol_completion_matches): Update.
1397 * ada-tasks.c (read_atcb): Update.
1398 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1399 (amd64_windows_skip_trampoline_code): Update.
1400 * arm-tdep.c (skip_prologue_function): Update.
1401 (arm_skip_stack_protector): Update.
1402 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1403 (arm_wince_skip_main_prologue): Update.
1404 * ax-gdb.c (gen_expr): Update.
1405 * block.c (call_site_for_pc): Update.
1406 * blockframe.c (find_pc_partial_function): Update.
1407 * breakpoint.c (set_breakpoint_location_function): Update.
1408 * btrace.c (ftrace_print_function_name): Update.
1409 (ftrace_function_switched): Update.
1410 * c-valprint.c (print_unpacked_pointer): Update.
1411 * coffread.c (coff_symfile_read): Update.
1412 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1413 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1414 * dwarf-index-write.c (write_psymbols): Update.
1415 * dwarf2loc.c (call_site_to_target_addr): Update.
1416 (func_verify_no_selftailcall): Update.
1417 (tailcall_dump): Update.
1418 (call_site_find_chain_1): Update.
1419 (dwarf_expr_reg_to_entry_parameter): Update.
1420 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1421 * eval.c (evaluate_funcall): Update.
1422 (evaluate_subexp_standard): Update.
1423 (evaluate_subexp_for_sizeof): Update.
1424 * expprint.c (print_subexp_standard): Update.
1425 (dump_subexp_body_standard): Update.
1426 * frame.c (get_prev_frame_always_1): Update.
1427 * frv-tdep.c (frv_skip_main_prologue): Update.
1428 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1429 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1430 (gnuv3_get_typename_from_type_info): Update.
1431 (gnuv3_skip_trampoline): Update.
1432 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1433 * i386-tdep.c (i386_skip_main_prologue): Update.
1434 (i386_pe_skip_trampoline_code): Update.
1435 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1436 * infcall.c (get_function_name): Update.
1437 * linespec.c (minsym_found): Update.
1438 * linux-fork.c (info_checkpoints_command): Update.
1439 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1440 (m32c_m16c_pointer_to_address): Update.
1441 * maint.c (maintenance_translate_address): Update.
1442 * minsyms.c (add_minsym_to_hash_table): Update.
1443 (add_minsym_to_demangled_hash_table): Update.
1444 (lookup_minimal_symbol_mangled): Update.
1445 (lookup_minimal_symbol_demangled): Update.
1446 (lookup_minimal_symbol_linkage): Update.
1447 (lookup_minimal_symbol_text): Update.
1448 (lookup_minimal_symbol_by_pc_name): Update.
1449 (minimal_symbol_is_less_than): Update.
1450 (compact_minimal_symbols): Update.
1451 (build_minimal_symbol_hash_tables): Update.
1452 (find_solib_trampoline_target): Update.
1453 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1454 (mips_skip_pic_trampoline_code): Update.
1455 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1456 * objc-lang.c (info_selectors_command): Update.
1457 (info_classes_command): Update.
1458 (find_methods): Update.
1459 (find_imps): Update.
1460 * p-valprint.c (pascal_val_print): Update.
1461 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1462 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1463 * printcmd.c (build_address_symbolic): Update.
1464 (info_symbol_command): Update.
1465 * psymtab.c (psymbol_name_matches): Update.
1466 (match_partial_symbol): Update.
1467 (lookup_partial_symbol): Update.
1468 (print_partial_symbols): Update.
1469 (sort_pst_symbols): Update.
1470 (maintenance_check_psymtabs): Update.
1471 * python/py-framefilter.c (py_print_frame): Update.
1472 * python/python.c (gdbpy_rbreak): Update.
1473 * record-btrace.c (btrace_get_bfun_name): Update.
1474 (btrace_call_history): Update.
1475 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1476 (rs6000_skip_trampoline_code): Update.
1477 * sol-thread.c (info_cb): Update.
1478 * stabsread.c (scan_file_globals): Update.
1479 * stack.c (find_frame_funname): Update.
1480 (info_frame_command_core): Update.
1481 * symmisc.c (dump_msymbols): Update.
1482 * symtab.c (symbol_natural_name): Rename to..,
1483 (general_symbol_info::natural_name): ...this.
1484 (symbol_demangled_name): Rename to...
1485 (general_symbol_info::demangled_name): ...this.
1486 (symbol_search_name): Rename to...
1487 (general_symbol_info::search_name): ...this.
1488 (symbol_matches_search_name): Update.
1489 (find_pc_sect_line): Update.
1490 (skip_prologue_sal): Update.
1491 (search_symbols): Update.
1492 (print_msymbol_info): Update.
1493 (rbreak_command): Update.
1494 (completion_list_add_msymbol): Update.
1495 (completion_list_objc_symbol): Update.
1496 (get_msymbol_address): Update.
1497 * symtab.h (struct general_symbol_info): Add member functions
1498 natural_name (), linkage_name (), print_name (), demangled_name (),
1499 and search_name ().
1500 (SYMBOL_NATURAL_NAME): Update.
1501 (symbol_natural_name): Move to a member function on general_symbol_info.
1502 (SYMBOL_DEMANGLED_NAME): Update.
1503 (symbol_demangled_name): Move to a member function on
1504 general_symbol_info.
1505 (SYMBOL_SEARCH_NAME): Update.
1506 (symbol_search_name): Move to a member function on general_symbol_info.
1507 (MSYMBOL_NATURAL_NAME): Remove.
1508 (MSYMBOL_LINKAGE_NAME): Remove.
1509 (MSYMBOL_PRINT_NAME): Remove.
1510 (MSYMBOL_DEMANGLED_NAME): Remove.
1511 (MSYMBOL_SEARCH_NAME): Remove.
1512 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1513
f8bab2d6
CB
15142019-11-22 Christian Biesinger <cbiesinger@google.com>
1515
1516 * symtab.c (create_demangled_names_hash): Use per_bfd->
1517 minimal_symbol_count for computing the initial size, if greater
1518 than our default size.
1519
85e7588d
TV
15202019-11-22 Tom de Vries <tdevries@suse.de>
1521
1522 * contrib/words.sh: Improve words extraction.
1523
f6180073
TV
15242019-11-22 Tom de Vries <tdevries@suse.de>
1525
1526 * contrib/words.sh: Combine sed invocations.
1527
f10ffa41
CB
15282019-11-21 Christian Biesinger <cbiesinger@google.com>
1529
1530 * Makefile.in: Update.
1531 * demangle.c: Rename to...
1532 * gdb-demangle.c: ..this.
1533 (is_cplus_marker): Change return type to bool.
1534 (_initialize_demangler): Rename to...
1535 (_initialize_gdb_demangle): ...this.
1536 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1537 * symtab.h (demangle): Remove declaration; instead include
1538 gdb-demangle.h.
1539
6ba18521
TT
15402019-11-21 Tom Tromey <tromey@adacore.com>
1541
1542 * gdbsupport/format.c (format_pieces): Parse %I64d.
1543 * unittests/format_pieces-selftests.c (test_windows_formats): New
1544 function.
1545 (run_tests): Call it.
1546
34877895
PJ
15472019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1548
1549 Byte reverse display of variables with DW_END_big, DW_END_little
1550 (DW_AT_endianity) dwarf attributes if different than the native
1551 byte order.
1552 * ada-lang.c (ada_value_binop):
1553 Use type_byte_order instead of gdbarch_byte_order.
1554 * ada-valprint.c (printstr):
1555 (ada_val_print_string):
1556 * ada-lang.c (value_pointer):
1557 (ada_value_binop):
1558 Use type_byte_order instead of gdbarch_byte_order.
1559 * c-lang.c (c_get_string):
1560 Use type_byte_order instead of gdbarch_byte_order.
1561 * c-valprint.c (c_val_print_array):
1562 Use type_byte_order instead of gdbarch_byte_order.
1563 * cp-valprint.c (cp_print_class_member):
1564 Use type_byte_order instead of gdbarch_byte_order.
1565 * dwarf2loc.c (rw_pieced_value):
1566 Use type_byte_order instead of gdbarch_byte_order.
1567 * dwarf2read.c (read_base_type): Handle DW_END_big,
1568 DW_END_little
1569 * f-lang.c (f_get_encoding):
1570 Use type_byte_order instead of gdbarch_byte_order.
1571 * findvar.c (default_read_var_value):
1572 Use type_byte_order instead of gdbarch_byte_order.
1573 * gdbtypes.c (check_types_equal):
1574 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1575 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1576 and TYPE_ENDIANITY_LITTLE if set.
1577 (type_byte_order): new function.
1578 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1579 (struct main_type) <flag_endianity_not_default>:
1580 New field.
1581 (type_byte_order): New function.
1582 * infcmd.c (default_print_one_register_info):
1583 Use type_byte_order instead of gdbarch_byte_order.
1584 * p-lang.c (pascal_printstr):
1585 Use type_byte_order instead of gdbarch_byte_order.
1586 * p-valprint.c (pascal_val_print):
1587 Use type_byte_order instead of gdbarch_byte_order.
1588 * printcmd.c (print_scalar_formatted):
1589 Use type_byte_order instead of gdbarch_byte_order.
1590 * solib-darwin.c (darwin_current_sos):
1591 Use type_byte_order instead of gdbarch_byte_order.
1592 * solib-svr4.c (solib_svr4_r_ldsomap):
1593 Use type_byte_order instead of gdbarch_byte_order.
1594 * stap-probe.c (stap_modify_semaphore):
1595 Use type_byte_order instead of gdbarch_byte_order.
1596 * target-float.c (target_float_same_format_p):
1597 Use type_byte_order instead of gdbarch_byte_order.
1598 * valarith.c (scalar_binop):
1599 (value_bit_index):
1600 Use type_byte_order instead of gdbarch_byte_order.
1601 * valops.c (value_cast):
1602 Use type_byte_order instead of gdbarch_byte_order.
1603 * valprint.c (generic_emit_char):
1604 (generic_printstr):
1605 (val_print_string):
1606 Use type_byte_order instead of gdbarch_byte_order.
1607 * value.c (unpack_long):
1608 (unpack_bits_as_long):
1609 (unpack_value_bitfield):
1610 (modify_field):
1611 (pack_long):
1612 (pack_unsigned_long):
1613 Use type_byte_order instead of gdbarch_byte_order.
1614 * findvar.c (unsigned_pointer_to_address):
1615 (signed_pointer_to_address):
1616 (unsigned_address_to_pointer):
1617 (address_to_signed_pointer):
1618 (default_read_var_value):
1619 (default_value_from_register):
1620 Use type_byte_order instead of gdbarch_byte_order.
1621 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1622 Use type_byte_order instead of gdbarch_byte_order.
1623 * riscv-tdep.c (riscv_print_one_register_info):
1624 Use type_byte_order instead of gdbarch_byte_order.
1625
87fb00ea
SM
16262019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1627
1628 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1629 (current_ui_gdb_stdin_ptr): Likewise.
1630 (current_ui_gdb_stderr_ptr): Likewise.
1631 (current_ui_gdb_stdlog_ptr): Likewise.
1632 (current_ui_current_uiout_ptr): Likewise.
1633 (gen_ret_current_ui_field_ptr): Remove.
1634
65d1cd5f
TV
16352019-11-21 Tom de Vries <tdevries@suse.de>
1636
1637 PR gdb/24956
1638 * cli/cli-script.c (execute_control_command): Only switch to
1639 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1640
9f6ad286
TT
16412019-11-19 Tom Tromey <tom@tromey.com>
1642
1643 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1644 Now static. Change type of "name".
1645 (tui_set_win_height_command): Don't copy "arg".
1646 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1647 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1648
435d3d88
AT
16492019-11-19 Ali Tamur <tamur@google.com>
1650
1651 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1652 "if (attr != nullptr)".
1653 (dwarf2_find_base_address): Likewise.
1654 (dwarf2_build_include_psymtabs): Likewise.
1655 (read_cutu_die_from_dwo): Likewise.
1656 (read_func_scope): Likewise.
1657 (read_call_site_scope): Likewise.
1658 (dwarf2_get_pc_bounds): Likewise.
1659 (dwarf2_record_block_ranges): Likewise.
1660 (dwarf2_add_field): Likewise.
1661 (dwarf2_add_member_fn): Likewise.
1662 (read_structure_type): Likewise.
1663 (read_enumeration_type): Likewise.
1664 (read_array_type): Likewise.
1665 (read_array_order): Likewise.
1666 (read_set_type): Likewise.
1667 (read_common_block): Likewise.
1668 (read_tag_reference_type): Likewise.
1669 (read_tag_string_type): Likewise.
1670 (read_subroutine_type): Likewise.
1671 (read_base_type): Likewise.
1672 (read_subrange_type): Likewise.
1673 (new_symbol): Likewise.
1674 (prepare_one_comp_unit): Likewise.
1675
c9739b6a
TT
16762019-11-19 Tom Tromey <tromey@adacore.com>
1677
1678 * windows-nat.c (windows_nat_target::attach): Include GetLastError
1679 result in error when DebugActiveProcess fails.
1680
494409bb
SDJ
16812019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
1682 Pedro Alves <palves@redhat.com>
1683
1684 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1685 * target.c (target_stack::push): Call 'unpush' if there's a
1686 target on top of the stack.
1687
2e953aca
PW
16882019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1689
1690 * python/py-block.c (blpy_dealloc): Call tp_free.
1691 (blpy_block_syms_dealloc): Likewise.
1692 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1693 * python/py-inferior.c (infpy_dealloc): Likewise.
1694 * python/py-lazy-string.c (stpy_dealloc): Likewise.
1695 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1696 * python/py-symbol.c (sympy_dealloc): Likewise.
1697 * python/py-symtab.c (stpy_dealloc): Likewise.
1698 * python/py-type.c (typy_iterator_dealloc): Likewise.
1699
6edc43ec
CB
17002019-11-18 Christian Biesinger <cbiesinger@google.com>
1701
1702 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1703 constructor instead of using a class initializer.
1704
cd850b40
CB
17052019-11-15 Christian Biesinger <cbiesinger@google.com>
1706
1707 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1708 * configure: Regenerate.
1709 * configure.ac: Don't source common.host.
1710 * gdbsupport/common.host: Remove.
1711 * gdbsupport/mingw-strerror.c: Remove.
1712 * gdbsupport/posix-strerror.c: Rename to...
1713 * gdbsupport/safe-strerror.c: ...this.
1714
53fea9c7
CB
17152019-11-15 Christian Biesinger <cbiesinger@google.com>
1716
1717 * maint.c (scoped_command_stats::print_time): Use localtime_r
1718 instead of localtime (provided through gnulib if necessary).
1719 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1720 of ctime.
1721
f8e27d88
CB
17222019-11-15 Christian Biesinger <cbiesinger@google.com>
1723
1724 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1725 avoid compile errors.
1726
5abebf3c
CB
17272019-11-15 Christian Biesinger <cbiesinger@google.com>
1728
1729 * config.in: Regenerate.
1730 * configure: Regenerate.
1731 * gdbsupport/common.m4: No longer check for strerror_r.
1732 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1733 POSIX version of strerror_r, now that gnulib provides it if
1734 necessary.
1735
9a351667
CB
17362019-11-14 Christian Biesinger <cbiesinger@google.com>
1737
1738 * README (`configure' options): Update.
1739
55708e99
TT
17402019-11-14 Tom Tromey <tromey@adacore.com>
1741
1742 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1743 expected type for the RHS if the LHS is a convenience variable.
1744
4b09bb2e
SM
17452019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
1746
1747 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1748 Provide explicit default and copy constructor.
1749
bd454f8b
PW
17502019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1751
1752 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1753 only call Py_INCREF (newbp) in the bppy_pending_object case.
1754
d1aa3cf0
TT
17552019-11-13 Tom Tromey <tromey@adacore.com>
1756
1757 PR build/25182:
1758 * psympriv.h (partial_symbol): Remove static assert.
1759 * symtab.h (general_symbol_info, symbol): Remove static assert.
1760
e06f3d6e
AB
17612019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
1762
1763 * gdbsupport/format.c (format_pieces::format_pieces): Support
1764 printf 'z' size modifier.
1765 * gdbsupport/format.h (enum argclass): Add size_t_arg.
1766 * printcmd.c (ui_printf): Handle size_t_arg.
1767 * ui-out.c (ui_out::vmessage): Likewise.
1768 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1769 function.
1770 (run_tests): Call test_format_int_sizes.
1771
468c0cbb
CB
17722019-11-12 Christian Biesinger <cbiesinger@google.com>
1773
1774 * ada-exp.y (write_ambiguous_var): Update.
1775 * buildsym.c (add_symbol_to_list): Update.
1776 * dwarf2read.c (read_variable): Update.
1777 (new_symbol): Update.
1778 * jit.c (finalize_symtab): Update.
1779 * language.c (language_alloc_type_symbol): Update.
1780 * symtab.c (fixup_symbol_section): Update.
1781 (initialize_objfile_symbol_1): Move code to...
1782 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1783 (allocate_symbol): Update.
1784 (allocate_template_symbol): Update.
1785 (get_symbol_address): Update.
1786 * symtab.h (struct symbol): Inherit from general_symbol_info instead
1787 of having as a field, and add a constructor.
1788 (SYMBOL_VALUE): Update.
1789 (SYMBOL_VALUE_ADDRESS): Update.
1790 (SET_SYMBOL_VALUE_ADDRESS): Update.
1791 (SYMBOL_VALUE_BYTES): Update.
1792 (SYMBOL_VALUE_COMMON_BLOCK): Update.
1793 (SYMBOL_BLOCK_VALUE): Update.
1794 (SYMBOL_VALUE_CHAIN): Update.
1795 (SYMBOL_LANGUAGE): Update.
1796 (SYMBOL_SECTION): Update.
1797 (SYMBOL_OBJ_SECTION): Update.
1798 (SYMBOL_SET_LANGUAGE): Update.
1799 (SYMBOL_SET_LINKAGE_NAME): Update.
1800 (SYMBOL_SET_NAMES): Update.
1801 (SYMBOL_NATURAL_NAME): Update.
1802 (SYMBOL_LINKAGE_NAME): Update.
1803 (SYMBOL_DEMANGLED_NAME): Update.
1804 (SYMBOL_SEARCH_NAME): Update.
1805 (SYMBOL_MATCHES_SEARCH_NAME): Update.
1806 (struct symbol): Update.
1807 (struct template_symbol): Update.
1808 (struct rust_vtable_symbol): Update.
1809 * xcoffread.c (SYMBOL_DUP): Update.
1810
ed2c82c3
TT
18112019-11-12 Tom Tromey <tom@tromey.com>
1812
1813 * tui/tui-layout.c (show_layout): Set current_layout.
1814 (show_source_disasm_command, show_data)
1815 (show_source_or_disasm_and_command): Don't set current_layout.
1816
d9fcefd5
TT
18172019-11-12 Tom Tromey <tom@tromey.com>
1818
1819 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1820
45e42163
TT
18212019-11-12 Tom Tromey <tom@tromey.com>
1822
1823 * tui/tui-win.c (resize_message): New global.
1824 (show_tui_resize_message): New function.
1825 (tui_async_resize_screen): Print message if requested.
1826 (_initialize_tui_win): Add tui-resize-message setting.
1827 * NEWS: Add entry for new commands.
1828
c86d74cc
TT
18292019-11-11 Tom Tromey <tom@tromey.com>
1830
1831 * tui/tui.c (tui_initialize_readline): Add new bindable readline
1832 functions.
1833
7b7b9424
CB
18342019-11-11 Christian Biesinger <cbiesinger@google.com>
1835
1836 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1837
086baaf1
AB
18382019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1839
1840 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1841 function.
1842 * python/python-internal.h (gdbpy_lookup_static_symbols):
1843 Declare new function.
1844 * python/python.c (python_GdbMethods): Add
1845 gdb.lookup_static_symbols method.
1846 * NEWS: Mention gdb.lookup_static_symbols.
1847
09ff83af
AB
18482019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1849
1850 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1851 static block of current object file first. Also fix typo in
1852 header comment.
1853
eb2dd8df
AB
18542019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1855
1856 * stack.c (set_last_displayed_sal): Delete.
1857 (last_displayed_sal_valid): Delete.
1858 (last_displayed_pspace): Delete.
1859 (last_displayed_addr): Delete.
1860 (last_displayed_symtab): Delete.
1861 (last_displayed_line): Delete.
1862 (class last_displayed_symtab_info_type): New.
1863 (last_displayed_symtab_info): New static global variable.
1864 (print_frame_info): Call methods on last_displayed_symtab_info.
1865 (clear_last_displayed_sal): Update header comment, and make use of
1866 last_displayed_symtab_info.
1867 (last_displayed_sal_is_valid): Likewise.
1868 (get_last_displayed_pspace): Likewise.
1869 (get_last_displayed_addr): Likewise.
1870 (get_last_displayed_symtab): Likewise.
1871 (get_last_displayed_line): Likewise.
1872 (get_last_displayed_sal): Likewise.
1873 * stack.h (clear_last_displayed_sal): Update header comment.
1874 (last_displayed_sal_is_valid): Likewise.
1875 (get_last_displayed_pspace): Likewise.
1876 (get_last_displayed_addr): Likewise.
1877 (get_last_displayed_symtab): Likewise.
1878 (get_last_displayed_line): Likewise.
1879 (get_last_displayed_sal): Likewise.
1880
62137775
AB
18812019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1882
1883 * stack.c (frame_show_address): Convert return type to bool.
1884 * stack.h (frame_show_address): Likewise, and update header
1885 comment.
1886
cf57ad6d
AB
18872019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1888
1889 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1890 * unittests/vec-utils-selftests.c: New file.
1891 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1892
0b026263
TT
18932019-11-10 Tom Tromey <tom@tromey.com>
1894
1895 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1896 (tui_highlight_win): Likewise.
1897 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1898 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1899 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1900 Don't set can_highlight.
1901
b049ce2d
TT
19022019-11-10 Tom Tromey <tom@tromey.com>
1903
1904 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1905 Remove unused declaration.
1906
992a7040
TT
19072019-11-08 Tom Tromey <tromey@adacore.com>
1908
1909 * top.c (read_command_file): Update.
1910 (command_line_input): Make return type const.
1911 * python/py-gdb-readline.c: Update.
1912 * linespec.c (decode_line_2): Update.
1913 * defs.h (command_line_input): Make return type const.
1914 * cli/cli-script.c (read_next_line): Make return type const.
1915 * ada-lang.c (get_selections): Update.
1916
ca3a04f6
CB
19172019-11-06 Christian Biesinger <cbiesinger@google.com>
1918
1919 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1920 * mi/mi-main.c (output_cores): Likewise.
1921 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1922 (linux_xfer_osdata_modules): Likewise.
1923 * remote.c (register_remote_support_xml): Likewise.
1924 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1925 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1926
e0eac551
TT
19272019-11-06 Tom Tromey <tom@tromey.com>
1928
1929 * tui/tui-interp.c: Don't include readline.h.
1930 * tui/tui-hooks.c: Don't include readline.h.
1931 * symmisc.c: Include tilde.h, not readline.h.
1932 * symfile.c: Include tilde.h, not readline.h.
1933 * source.c: Include tilde.h, not readline.h.
1934 * solib.c: Include tilde.h, not readline.h.
1935 * psymtab.c: Include tilde.h, not readline.h.
1936 * exec.c: Include tilde.h, not readline.h.
1937 * corelow.c: Include tilde.h, not readline.h.
1938 * cli/cli-dump.c: Include tilde.h, not readline.h.
1939 * cli/cli-cmds.c: Don't include readline.h.
1940
825165c5
TT
19412019-11-05 Tom Tromey <tom@tromey.com>
1942
1943 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1944 (tui_disassemble): Set addr_size.
1945 (tui_disasm_window::set_contents): Use addr_size.
1946
91ae903f
TT
19472019-11-05 Tom Tromey <tom@tromey.com>
1948
1949 * rust-lang.c (rust_language_defn): Update.
1950 * python/py-value.c (valpy_string): Call c_get_string.
1951 * p-lang.c (pascal_language_defn): Update.
1952 * opencl-lang.c (opencl_language_defn): Update.
1953 * objc-lang.c (objc_language_defn): Update.
1954 * m2-lang.c (m2_language_defn): Update.
1955 * language.c (unknown_language_defn, auto_language_defn): Update.
1956 (default_get_string): Remove.
1957 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1958 * go-lang.c (go_language_defn): Update.
1959 * f-lang.c (f_language_defn): Update.
1960 * d-lang.c (d_language_defn): Update.
1961 * c-lang.c (c_language_defn, cplus_language_defn)
1962 (asm_language_defn, minimal_language_defn): Update.
1963 * ada-lang.c (ada_language_defn): Update.
1964 * language.h (struct language_defn) <la_get_string>: Remove.
1965 (LA_GET_STRING): Remove.
1966 (default_get_string): Don't declare.
1967
1df2f9ef
TT
19682019-11-05 Tom Tromey <tom@tromey.com>
1969
1970 * tui/tui-source.h (struct tui_source_window): Inline
1971 constructor. Remove destructor.
1972 <style_changed, m_observable>: Move to superclass.
1973 * tui/tui-winsource.h (tui_copy_source_line): Declare.
1974 (struct tui_source_window_base): Move private members to end.
1975 <style_changed, m_observable>: Move from tui_source_window.
1976 * tui/tui-winsource.c (tui_copy_source_line): Move from
1977 tui-source.c. Rename from copy_source_line. Add special handling
1978 for negative line number.
1979 (tui_source_window_base::style_changed): Move from
1980 tui_source_window.
1981 (tui_source_window_base): Register observer.
1982 (~tui_source_window_base): New.
1983 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1984 rename.
1985 (tui_source_window::set_contents): Use tui_copy_source_line.
1986 (tui_source_window::tui_source_window): Move to tui-source.h.
1987 (tui_source_window::~tui_source_window): Remove.
1988 (tui_source_window::style_changed): Move to superclass.
1989 * tui/tui-disasm.c (tui_disassemble): Create string file with
1990 styling, when possible. Add "addr_size" parameter.
1991 (tui_disasm_window::set_contents): Use tui_copy_source_line.
1992 Don't compute maximum size.
1993 (len_without_escapes): New function
1994
5d051055
TT
19952019-11-05 Tom Tromey <tom@tromey.com>
1996
1997 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1998 std::string.
1999 * tui/tui-winsource.c (tui_show_source_line): Update.
2000 * tui/tui-source.c (tui_source_window::set_contents): Update.
2001 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2002
ade7beea
CB
20032019-11-05 Christian Biesinger <cbiesinger@google.com>
2004
2005 * symtab.h (gdb_static_assert): Put && operator at the beginning
2006 of the line instead of the end.
2007
3573abe1
CB
20082019-11-04 Christian Biesinger <cbiesinger@google.com>
2009
2010 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2011 and sizeof (symbol).
2012 * symtab.h: Add a static_assert for sizeof (partial_symbol).
2013
dae8b3eb
RO
20142019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
2015
2016 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2017 * configure.host: Mark *-*-solaris2.10* obsolete.
2018 * configure.tgt: Mark Solaris < 11 obsolete.
2019 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2020 Update target triplet.
2021
5df96a4e
TT
20222019-11-01 Tom Tromey <tromey@adacore.com>
2023
2024 * utils.c (print_sys_errmsg): Simplify.
2025
b7481649
TT
20262019-11-01 Tom Tromey <tromey@adacore.com>
2027
2028 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2029
e48f6033
CB
20302019-11-01 Christian Biesinger <cbiesinger@google.com>
2031
2032 * configure: Regenerate.
2033 * configure.ac: Remove check for strerror_r.
2034 * gdbsupport/common.m4: Check for strerror_r.
2035
bd5766ec
LM
20362019-11-01 Luis Machado <luis.machado@linaro.org>
2037
2038 PR gdb/25124
2039
2040 * arm-tdep.c (arm_per_objfile): Rename to ...
2041 (arm_per_bfd): ... this.
2042 (arm_objfile_data_key): Rename to ...
2043 (arm_bfd_data_key): ... this.
2044 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2045 data.
2046 (arm_record_special_symbol): Likewise.
2047
e1709896
AB
20482019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2049
2050 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2051 end.
2052 * c-typeprint.c (c_print_typedef): Likewise.
2053 * f-typeprint.c (f_print_typedef): Likewise.
2054 * m2-typeprint.c (m2_print_typedef): Likewise.
2055 * p-typeprint.c (pascal_print_typedef): Likewise.
2056 * rust-lang.c (rust_print_typedef): Likewise.
2057 * symtab.c (print_symbol_info): Print a newline after calling
2058 typedef_print.
2059
165f8965
AB
20602019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2061
2062 * symtab.c (info_module_cmdlist): New variable.
2063 (info_module_command): New function.
2064 (search_module_symbols): New function.
2065 (info_module_subcommand): New function.
2066 (struct info_modules_var_func_options): New struct.
2067 (info_modules_var_func_options_defs): New variable.
2068 (make_info_modules_var_func_options_def_group): New function.
2069 (info_module_functions_command): New function.
2070 (info_module_variables_command): New function.
2071 (info_module_var_func_command_completer): New function.
2072 (_initialize_symtab): Register new 'info module functions' and
2073 'info module variables' commands.
2074 * symtab.h (typedef symbol_search_in_module): New typedef.
2075 (search_module_symbols): Declare new function.
2076 * NEWS: Mention new commands.
2077
59c35742
AB
20782019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2079
2080 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2081 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2082 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2083 MODULES_DOMAIN.
2084 (scan_partial_symbols): Only create partial module symbols for non
2085 declarations.
2086 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2087 and MODULES_DOMAIN.
2088 * symtab.c (search_domain_name): Likewise.
2089 (search_symbols): Likewise.
2090 (print_symbol_info): Likewise.
2091 (symtab_symbol_info): Likewise.
2092 (info_modules_command): New function.
2093 (_initialize_symtab): Register 'info modules' command.
2094 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2095 * NEWS: Mention new 'info modules' command.
2096
aed61d02
PW
20972019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2098
2099 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2100 and $_gdb_maint_setting_str.
2101
9ad9b77d
PW
21022019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2103
2104 * cli/cli-cmds.c (setting_cmd, value_from_setting)
2105 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2106 (str_value_from_setting, gdb_setting_str_internal_fn)
2107 (gdb_maint_setting_str_internal_fn): New functions.
2108 (_initialize_cli_cmds): Define the new convenience functions.
2109 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2110 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2111
8d6efaa2
CB
21122019-10-31 Christian Biesinger <cbiesinger@google.com>
2113
2114 * agent.c (set_can_use_agent): When the setting is turned on,
2115 look up agent symbols if we don't have them yet.
2116 (agent_new_objfile): Don't look up agent symbols when the agent
2117 setting is off.
2118
33cb1647
CB
21192019-10-31 Christian Biesinger <cbiesinger@google.com>
2120
2121 * config.in: Regenerate.
2122
b231e86a
CB
21232019-10-31 Christian Biesinger <cbiesinger@google.com>
2124
2125 * configure: Regenerate.
2126 * configure.ac: Check for strerror_r.
2127 * gdbsupport/common-utils.h (safe_strerror): Change return value
2128 to const char * and document that this function is now threadsafe.
2129 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2130 thread_local and call strerror_r, if available.
2131 * utils.c (perror_string): Update.
2132 (print_sys_errmsg): Update.
2133
a2726d4f
LM
21342019-10-31 Luis Machado <luis.machado@linaro.org>
2135
2136 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2137 objfile_key.
2138 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2139 objfile to fetch per-bfd data.
2140 (arm_find_exidx_entry): Likewise.
2141
75cafaa6
CB
21422019-10-31 Christian Biesinger <cbiesinger@google.com>
2143
2144 * gdbsupport/agent.c (debug_agent): Change type to bool.
2145 (use_agent): Likewise.
2146 (all_agent_symbols_look_up): Likewise.
2147 (agent_loaded_p): Change return value to bool.
2148 (agent_look_up_symbols): Update.
2149 (agent_capability_check): Change return value to bool.
2150 * gdbsupport/agent.h (agent_loaded_p): Likewise.
2151 (debug_agent): Change type to bool.
2152 (use_agent): Likewise.
2153 (agent_capability_check): Change return value to bool.
2154
808590ec
CB
21552019-10-30 Christian Biesinger <cbiesinger@google.com>
2156
2157 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2158 (build_minimal_symbol_hash_tables): Code to clear the table moved
2159 to clear_minimal_symbol_hash_tables.
2160 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2161 when needed.
2162
f18ad8a1
SM
21632019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2164
2165 * infcmd.c: Remove includes.
2166 * infrun.c: Remove includes.
2167
de93309a
SM
21682019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2169
2170 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2171 (grow_vect): Remove declaration.
2172 (ada_type_of_array): Remove declaration.
2173 (ada_update_initial_language): Remove declaration.
2174 (ada_fold_name): Remove declaration.
2175 (ada_fill_in_ada_prototype): Remove declaration.
2176 (user_select_syms): Remove declaration.
2177 (get_selections): Remove declaration.
2178 (ada_tag_type): Remove declaration.
2179 (ada_value_tag): Remove declaration.
2180 (ada_is_others_clause): Remove declaration.
2181 (ada_in_variant): Remove declaration.
2182 (ada_value_struct_elt): Remove declaration.
2183 (ada_attribute_name): Remove declaration.
2184 (ada_system_address_type): Remove declaration.
2185 * ada-lang.c (ada_watch_location_expression): Make static.
2186 (GROW_VECT): Move here from ada-lang.h.
2187 (grow_vect): Make static.
2188 (ada_update_initial_language): Make static.
2189 (ada_fold_name): Make static.
2190 (ada_type_of_array): Make static.
2191 (encoded_ordered_before): Move up.
2192 (sort_choices): Move up.
2193 (print_signatures): Move up.
2194 (ada_print_symbol_signature): Move up.
2195 (get_selections): Move up and make static.
2196 (user_select_syms): Move up and make static.
2197 (ada_value_struct_elt): Move up and make static.
2198 (ada_tag_type): Make static.
2199 (ada_value_tag): Make static.
2200 (ada_is_others_clause): Make static.
2201 (ada_in_variant): Make static.
2202 (ada_attribute_name): Make static.
2203
cdc46a9f
SM
22042019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2205
2206 * ada-lang.c: Remove includes.
2207 * ada-typeprint.c: Remove includes.
2208 * ada-valprint.c: Remove includes.
2209
90421c56
SM
22102019-10-29 Simon Marchi <simon.marchi@efficios.com>
2211
2212 * addrmap.c: Add static assertions of type size, moved from
2213 _initialize_addrmap.
2214 (_initialize_addrmap): Remove.
2215
31edb802
CB
22162019-10-29 Christian Biesinger <cbiesinger@google.com>
2217
2218 * coffread.c (record_minimal_symbol): Update.
2219 (process_coff_symbol): Update.
2220 * dbxread.c (read_dbx_symtab): Update.
2221 * dwarf2read.c (add_partial_symbol): Update.
2222 (fixup_go_packaging): Update.
2223 (load_partial_dies): Update.
2224 (new_symbol): Update.
2225 * elfread.c (record_minimal_symbol): Change signature to use
2226 gdb::string_view instead of name+len.
2227 (elf_symtab_read): Update.
2228 (elf_rel_plt_read): Update.
2229 * mdebugread.c (parse_partial_symbols): Update.
2230 (handle_psymbol_enumerators): Update.
2231 (new_symbol): Update.
2232 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2233 to use gdb::string_view instead of name+len.
2234 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2235 * psympriv.h (add_psymbol_to_list): Likewise.
2236 * psymtab.c (add_psymbol_to_bcache): Likewise.
2237 (add_psymbol_to_list): Likewise.
2238 * stabsread.c (define_symbol): Update.
2239 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2240 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2241 (symbol_set_names): Likewise.
2242 * xcoffread.c (scan_xcoff_symtab): Update.
2243
0c921b21
CB
22442019-10-29 Christian Biesinger <cbiesinger@google.com>
2245
2246 * symtab.h (symbol_set_names): Document that copy_name must be
2247 set to true for non-nullterminated strings.
2248 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2249 linkage_name if the entry was not found and we need to demangle.
2250
35e65c49
CB
22512019-10-29 Christian Biesinger <cbiesinger@google.com>
2252
2253 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2254 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2255 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2256 * gdbsupport/gdb_binary_search.h: New file.
2257
ed2a2229
CB
22582019-10-29 Christian Biesinger <cbiesinger@google.com>
2259
2260 * NEWS: Mention new --with-system-gdbinit-dir option.
2261 * config.in: Regenerate.
2262 * configure: Regenerate.
2263 * configure.ac: Add new option --with-system-gdbinit-dir.
2264 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2265 for a ".gdb" suffix.
2266 * main.c (get_init_files): Change system_gdbinit argument to
2267 a vector and return the files in SYSTEM_GDBINIT_DIR in
2268 addition to SYSTEM_GDBINIT.
2269 (captured_main_1): Update.
2270 (print_gdb_help): Update.
2271 * top.c (print_gdb_configuration): Also print the value of
2272 SYSTEM_GDBINIT_DIR.
2273
87f34879
CB
22742019-10-28 Christian Biesinger <cbiesinger@google.com>
2275
2276 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2277 that takes gdb::string_view arguments.
2278
30baf67b
TV
22792019-10-26 Tom de Vries <tdevries@suse.de>
2280
2281 * aarch64-linux-tdep.c: Fix typos in comments.
2282 * aarch64-tdep.c: Same.
2283 * ada-lang.c: Same.
2284 * amd64-nat.c: Same.
2285 * arc-tdep.c: Same.
2286 * arch/aarch64-insn.c: Same.
2287 * block.c: Same.
2288 * breakpoint.h: Same.
2289 * btrace.h: Same.
2290 * c-varobj.c: Same.
2291 * cli/cli-decode.c: Same.
2292 * cli/cli-script.c: Same.
2293 * cli/cli-utils.h: Same.
2294 * coff-pe-read.c: Same.
2295 * coffread.c: Same.
2296 * compile/compile-cplus-symbols.c: Same.
2297 * compile/compile-object-run.c: Same.
2298 * completer.c: Same.
2299 * corelow.c: Same.
2300 * cp-support.c: Same.
2301 * demangle.c: Same.
2302 * dwarf-index-write.c: Same.
2303 * dwarf2-frame.c: Same.
2304 * dwarf2-frame.h: Same.
2305 * eval.c: Same.
2306 * frame-base.h: Same.
2307 * frame.h: Same.
2308 * gdbcmd.h: Same.
2309 * gdbtypes.h: Same.
2310 * gnu-nat.c: Same.
2311 * guile/scm-objfile.c: Same.
2312 * i386-tdep.c: Same.
2313 * i386-tdep.h: Same.
2314 * infcall.c: Same.
2315 * infcall.h: Same.
2316 * linux-nat.c: Same.
2317 * m68k-tdep.c: Same.
2318 * macroexp.c: Same.
2319 * memattr.c: Same.
2320 * mi/mi-cmd-disas.c: Same.
2321 * mi/mi-getopt.h: Same.
2322 * mi/mi-main.c: Same.
2323 * minsyms.c: Same.
2324 * nat/aarch64-sve-linux-sigcontext.h: Same.
2325 * objfiles.h: Same.
2326 * ppc-linux-nat.c: Same.
2327 * ppc-linux-tdep.c: Same.
2328 * ppc-tdep.h: Same.
2329 * progspace.h: Same.
2330 * prologue-value.h: Same.
2331 * python/py-evtregistry.c: Same.
2332 * python/py-instruction.h: Same.
2333 * record-btrace.c: Same.
2334 * record-full.c: Same.
2335 * remote.c: Same.
2336 * rs6000-tdep.c: Same.
2337 * ser-tcp.c: Same.
2338 * sol-thread.c: Same.
2339 * sparc-sol2-tdep.c: Same.
2340 * sparc64-tdep.c: Same.
2341 * stabsread.c: Same.
2342 * symfile.c: Same.
2343 * symtab.h: Same.
2344 * target.c: Same.
2345 * tracepoint.c: Same.
2346 * tui/tui-data.h: Same.
2347 * tui/tui-io.c: Same.
2348 * tui/tui-win.c: Same.
2349 * tui/tui.c: Same.
2350 * unittests/rsp-low-selftests.c: Same.
2351 * user-regs.h: Same.
2352 * utils.c: Same.
2353 * utils.h: Same.
2354 * valarith.c: Same.
2355 * valops.c: Same.
2356 * valprint.c: Same.
2357 * valprint.h: Same.
2358 * value.c: Same.
2359 * value.h: Same.
2360 * varobj.c: Same.
2361 * x86-nat.h: Same.
2362 * xtensa-tdep.c: Same.
2363
1834d45f
AT
23642019-10-25 Ali Tamur <tamur@google.com>
2365
2366 * charset.c (find_charset_names): Reflect API change.
2367
5396ae17
CB
23682019-10-25 Christian Biesinger <cbiesinger@google.com>
2369
2370 * symtab.c (struct demangled_name_entry): Change demangled name
2371 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2372 part of the struct anymore.
2373 (symbol_set_names): No longer obstack allocate + copy the demangled
2374 name, just store the allocated name from bfd.
2375
93878f47
TT
23762019-10-25 Tom Tromey <tromey@adacore.com>
2377
2378 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2379 (bsearch_cie_cmp, add_cie): Remove.
2380 (find_cie): Reimplement.
2381 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2382 (dwarf2_build_frame_info): Update.
2383
7b71fc97
L
23842019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2385
2386 PR gdb/25126
2387 * symfile.c (reread_symbols): Call forget_cached_source_info to
2388 clear the stale source cache.
2389
cbb5a2ea
CB
23902019-10-24 Christian Biesinger <cbiesinger@google.com>
2391
2392 * configure: Regenerate.
2393 * configure.ac: Remove code that sets python_has_threads.
2394
71737c43
CB
23952019-10-24 Christian Biesinger <cbiesinger@google.com>
2396
2397 * config.in: Regenerate.
2398 * configure: Regenerate.
2399 * configure.ac: Remove the code that uses sed to get the python
2400 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2401
33d569b7
AB
24022019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2403
2404 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2405 error paths.
2406
f16f7b7c
TT
24072019-10-23 Tom Tromey <tom@tromey.com>
2408
2409 * arc-tdep.c: Remove ".." from include.
2410 * frv-tdep.c: Remove ".." from include.
2411 * lm32-tdep.c: Remove ".." from include.
2412 * microblaze-tdep.c: Remove ".." from include.
2413 * or1k-tdep.h: Remove ".." from include.
2414 * s12z-tdep.c: Remove ".." from include.
2415 * Makefile.in (OPCODES_CFLAGS): Add comment.
2416 (TOP_CFLAGS): New variable.
2417 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2418
6999161a
TT
24192019-10-23 Tom Tromey <tom@tromey.com>
2420
2421 * Makefile.in (READLINE_DIR): Update.
2422
12e7c35e
TBA
24232019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2424
2425 * infcall.c (call_function_by_hand_dummy): Fix the function
2426 comment. And extract out a code section into...
2427 (reserve_stack_space): ...this new function.
2428
37055cad
TBA
24292019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2430
2431 * infcall.c (value_arg_coerce): Remove an unused parameter.
2432 (call_function_by_hand_dummy): Update the call to
2433 'value_arg_coerce'.
2434
39bcc47c
TBA
24352019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2436
2437 * infcall.c (call_function_by_hand_dummy): Refactor.
2438
bd888c0f
TBA
24392019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2440
2441 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2442
c12d372d
TT
24432019-10-23 Tom Tromey <tom@tromey.com>
2444
2445 * configure: Rebuild.
2446 * configure.ac: Don't check for sigprocmask.
2447 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2448
4d0b984b
TT
24492019-10-23 Tom Tromey <tom@tromey.com>
2450
2451 * configure: Rebuild.
2452 * acinclude.m4: Use m4_include, not sinclude.
2453
7e785608
TV
24542019-10-23 Tom de Vries <tdevries@suse.de>
2455
2456 PR breakpoints/24687
2457 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2458
403772ef
CB
24592019-10-22 Christian Biesinger <cbiesinger@google.com>
2460
2461 * symtab.c (struct demangled_name_entry) <language>: Change from
2462 bitfield to regular variable.
2463
3a494279
CB
24642019-10-22 Christian Biesinger <cbiesinger@google.com>
2465
2466 * symtab.c (struct demangled_name_entry): Add a constructor.
2467 (free_demangled_name_entry): New function to call the destructor
2468 for demangled_name_entry.
2469 (create_demangled_names_hash): Pass free_demangled_name_entry to
2470 htab_create_alloc.
2471 (symbol_set_names): Call placement new for demangled_name_entry.
2472 * utils.c: No longer include xxhash.h here, now that fast_hash
2473 is inlined in the header.
2474 * utils.h: Instead, include it here.
2475
ccb1ba62
CB
24762019-10-22 Christian Biesinger <cbiesinger@google.com>
2477
2478 * Makefile.in: Link with libxxhash.
2479 * config.in: Regenerate.
2480 * configure: Regenerate.
2481 * configure.ac: Search for libxxhash.
2482 * utils.c (fast_hash): Use xxhash if present.
2483
1a6ff1a9
CB
24842019-10-22 Christian Biesinger <cbiesinger@google.com>
2485
2486 * utils.h (fast_hash): New function.
2487 * symtab.c (hash_demangled_name_entry): Call new function
2488 fast_hash.
2489
7bb43059
CB
24902019-10-22 Christian Biesinger <cbiesinger@google.com>
2491
2492 * symtab.c (struct demangled_name_entry): Change type of mangled
2493 to gdb::string_view. Also adds a constructor that takes the
2494 mangled name.
2495 (hash_demangled_name_entry): Update.
2496 (eq_demangled_name_entry): Update.
2497 (free_demangled_name_entry): New function to call the destructor
2498 now that this is not a POD anymore.
2499 (create_demangled_names_hash): Pass free_demangled_name_entry to
2500 htab_create_alloc.
2501 (symbol_set_names): Update.
2502
7ba99d21
AT
25032019-10-21 Ali Tamur <tamu@google.com>
2504
2505 * dwarf2read.c (dir_index): Change type.
2506 (file_name_index): Likewise.
2507 (line_header::include_dir_at): Change comment and implementation on
2508 whether it is DWARF 5.
2509 (line_header::is_valid_file_index): New function.
2510 (line_header::file_name_at): Change comment and implementation on
2511 whether it is DWARF 5.
2512 (line_header::file_names): Change to private field renamed as
2513 m_file_names and introduce a new accessor method.
2514 (line_header::file_names_size): New method.
2515 (line_header::include_dirs): Change to private field and rename as
2516 m_include_dirs.
2517 (dw2_get_file_names_reader): Define local var at a smaller scope and
2518 reflect API change.
2519 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2520 (process_structure_scope): Likewise.
2521 (line_header::add_include_dir): Change message and reflect renaming.
2522 (line_header::add_file_name): Likewise.
2523 (read_formatted_entries): Handle DW_FORM_data16.
2524 (dwarf_decode_line_header): Fix line header length calculation.
2525 (psymtab_include_file_name): Change comment and API.
2526 (lnp_state_machine::m_file): Update comment and reflect type change.
2527 (lnp_state_machine::record_line): Reflect type change.
2528 (dwarf_decode_lines): Reflect API change.
2529 (file_file_name): Likewise.
2530 (file_full_name): Likewise.
2531
45f47c3a
AB
25322019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2533
2534 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2535
e5f3c0e3
TT
25362019-10-21 Tom Tromey <tom@tromey.com>
2537
2538 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2539
a0a461e5
TT
25402019-10-21 Tom Tromey <tom@tromey.com>
2541
2542 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2543 NM_H. Use AC_CONFIG_LINKS.
2544 * configure: Rebuild.
2545 * Makefile.in (NM_H): New variable.
2546 (generated_files): Add NM_H. Remove gcore.
2547 (nm.h, stamp-nmh): New targets.
2548
54d83b8d
TT
25492019-10-20 Tom Tromey <tom@tromey.com>
2550
2551 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2552 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2553 obsolete comment.
2554 (put_objfile_before): Now static.
2555
23771117
SM
25562019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2557
2558 * gdbsupport/common-utils.h (startswith): Change return type to
2559 bool.
2560
39ef2f62
CB
25612019-10-19 Christian Biesinger <cbiesinger@google.com>
2562
2563 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2564 * breakpoint.c (bp_locations_compare): Rename to...
2565 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2566 (update_global_location_list): Use std::sort instead of qsort.
2567 * buildsym.c (compare_line_numbers): Rename to...
2568 (lte_is_less_than): ...this, and change to std::sort semantics.
2569 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2570 instead of qsort.
2571 * disasm.c (compare_lines): Rename to...
2572 (line_is_less_than): ...this, and change to std::sort semantics.
2573 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2574 of qsort.
2575 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2576 (fde_is_less_than): ...this, and change to std::sort semantics.
2577 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2578 * mdebugread.c (compare_blocks):
2579 (block_is_less_than): ...this, and change to std::sort semantics.
2580 (sort_blocks): Call std::sort instead of qsort.
2581 * objfiles.c (qsort_cmp): Rename to...
2582 (sort_cmp): ...this, and change to std::sort semantics.
2583 (update_section_map): Call std::sort instead of qsort.
2584 * remote.c (compare_pnums): Remove.
2585 (map_regcache_remote_table): Call std::sort instead of qsort.
2586 * utils.c (compare_positive_ints): Remove.
2587 * utils.h (compare_positive_ints): Remove.
2588 * xcoffread.c (compare_lte): Remove.
2589 (arrange_linetable): Call std::sort instead of qsort.
2590
f71433ee
SDJ
25912019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2592
2593 * symfile.c (init_entry_point_info): Fix typo.
2594 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2595
85102364
TV
25962019-10-18 Tom de Vries <tdevries@suse.de>
2597
2598 * aarch64-tdep.c: Fix typos in comments.
2599 * ada-lang.c: Same.
2600 * ada-tasks.c: Same.
2601 * alpha-tdep.c: Same.
2602 * alpha-tdep.h: Same.
2603 * amd64-nat.c: Same.
2604 * amd64-windows-tdep.c: Same.
2605 * arc-tdep.c: Same.
2606 * arc-tdep.h: Same.
2607 * arch-utils.c: Same.
2608 * arm-nbsd-tdep.c: Same.
2609 * arm-tdep.c: Same.
2610 * ax-gdb.c: Same.
2611 * blockframe.c: Same.
2612 * btrace.c: Same.
2613 * c-varobj.c: Same.
2614 * coff-pe-read.c: Same.
2615 * coffread.c: Same.
2616 * cris-tdep.c: Same.
2617 * darwin-nat.c: Same.
2618 * dbxread.c: Same.
2619 * dcache.c: Same.
2620 * disasm.c: Same.
2621 * dtrace-probe.c: Same.
2622 * dwarf-index-write.c: Same.
2623 * dwarf2-frame-tailcall.c: Same.
2624 * dwarf2-frame.c: Same.
2625 * dwarf2read.c: Same.
2626 * eval.c: Same.
2627 * exceptions.c: Same.
2628 * fbsd-tdep.c: Same.
2629 * findvar.c: Same.
2630 * frame.c: Same.
2631 * frv-tdep.c: Same.
2632 * gnu-v3-abi.c: Same.
2633 * go32-nat.c: Same.
2634 * h8300-tdep.c: Same.
2635 * hppa-tdep.c: Same.
2636 * i386-linux-tdep.c: Same.
2637 * i386-tdep.c: Same.
2638 * ia64-libunwind-tdep.c: Same.
2639 * ia64-tdep.c: Same.
2640 * infcmd.c: Same.
2641 * infrun.c: Same.
2642 * linespec.c: Same.
2643 * linux-nat.c: Same.
2644 * linux-thread-db.c: Same.
2645 * machoread.c: Same.
2646 * mdebugread.c: Same.
2647 * mep-tdep.c: Same.
2648 * mn10300-tdep.c: Same.
2649 * namespace.c: Same.
2650 * objfiles.c: Same.
2651 * opencl-lang.c: Same.
2652 * or1k-tdep.c: Same.
2653 * osabi.c: Same.
2654 * ppc-linux-nat.c: Same.
2655 * ppc-linux-tdep.c: Same.
2656 * ppc-sysv-tdep.c: Same.
2657 * printcmd.c: Same.
2658 * procfs.c: Same.
2659 * record-btrace.c: Same.
2660 * record-full.c: Same.
2661 * remote-fileio.c: Same.
2662 * remote.c: Same.
2663 * rs6000-tdep.c: Same.
2664 * s12z-tdep.c: Same.
2665 * score-tdep.c: Same.
2666 * ser-base.c: Same.
2667 * ser-go32.c: Same.
2668 * skip.c: Same.
2669 * sol-thread.c: Same.
2670 * solib-svr4.c: Same.
2671 * solib.c: Same.
2672 * source.c: Same.
2673 * sparc-nat.c: Same.
2674 * sparc-sol2-tdep.c: Same.
2675 * sparc-tdep.c: Same.
2676 * sparc64-tdep.c: Same.
2677 * stabsread.c: Same.
2678 * stack.c: Same.
2679 * symfile.c: Same.
2680 * symtab.c: Same.
2681 * target-descriptions.c: Same.
2682 * target-float.c: Same.
2683 * thread.c: Same.
2684 * utils.c: Same.
2685 * valops.c: Same.
2686 * valprint.c: Same.
2687 * value.c: Same.
2688 * varobj.c: Same.
2689 * windows-nat.c: Same.
2690 * xcoffread.c: Same.
2691 * xstormy16-tdep.c: Same.
2692 * xtensa-tdep.c: Same.
2693
c5adaa19
TT
26942019-10-17 Tom Tromey <tromey@adacore.com>
2695
2696 * configure: Rebuild.
2697 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
2698 in AC_CONFIG_FILES invocation.
2699 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2700 new-style config.status invocation.
2701
405feb71
TV
27022019-10-17 Tom de Vries <tdevries@suse.de>
2703
2704 * arm-nbsd-nat.c: Fix typos in comments.
2705 * arm-tdep.c: Same.
2706 * darwin-nat-info.c: Same.
2707 * dwarf2read.c: Same.
2708 * elfread.c: Same.
2709 * event-top.c: Same.
2710 * findvar.c: Same.
2711 * gdbtypes.c: Same.
2712 * hppa-tdep.c: Same.
2713 * i386-tdep.c: Same.
2714 * jit.c: Same.
2715 * main.c: Same.
2716 * mdebugread.c: Same.
2717 * moxie-tdep.c: Same.
2718 * nto-procfs.c: Same.
2719 * osabi.c: Same.
2720 * ppc-linux-tdep.c: Same.
2721 * remote.c: Same.
2722 * riscv-tdep.c: Same.
2723 * s390-tdep.c: Same.
2724 * sh-tdep.c: Same.
2725 * sparc-linux-tdep.c: Same.
2726 * sparc-nat.c: Same.
2727 * stack.c: Same.
2728 * target-descriptions.c: Same.
2729 * top.c: Same.
2730 * varobj.c: Same.
2731
befcd486
TT
27322019-10-16 Tom Tromey <tom@tromey.com>
2733
2734 * objfiles.h (struct objfile) <original_name>: Now const.
2735
17bfe554
CB
27362019-10-16 Christian Biesinger <cbiesinger@google.com>
2737
2738 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2739 pass on to sigsetjmp's second argument.
2740 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2741
950b7495
KS
27422019-10-16 Keith Seitz <keiths@redhat.com>
2743
2744 PR gdb/23567
2745 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2746 sections whose size is greater than the file size.
2747
ff371ec9
JW
27482019-10-16 Jim Wilson <jimw@sifive.com>
2749
2750 * riscv-tdep.c (riscv_gcc_target_options): New.
2751 (riscv_gnu_triplet_regexp): New.
2752 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2753 set_gdbarch_gnu_triplet_regexp.
2754
fec4e896
CB
27552019-10-16 Christian Biesinger <cbiesinger@google.com>
2756
2757 * Makefile.in: Add xml-builtin.h.
2758 * features/feature_to_c.sh: Add an include for xml-builtin.h
2759 to ensure that the compiler checks that the types match.
2760 * xml-builtin.h: New file.
2761 * xml-support.c (fetch_xml_builtin): Add missing const.
2762 * xml-support.h: Remove declaration of xml_builtins.
2763
d10eccaa
TV
27642019-10-16 Tom de Vries <tdevries@suse.de>
2765
2766 PR tdep/25096
2767 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2768 (amd64_classify_aggregate): ... here.
2769 (amd64_classify_aggregate_field): Handled fiels of nested structs
2770 recursively.
2771
745ff14e
TV
27722019-10-16 Tom de Vries <tdevries@suse.de>
2773
2774 PR tdep/24104
2775 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2776 that handles 'theclass'.
2777
791b7405
AB
27782019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2779
2780 * linespec.c (decode_digits_ordinary): Update comment.
2781 * make-target-delegates: No longer need to handle VEC case.
2782 * memrange.c (normalize_mem_ranges): Update comment.
2783 * namespace.c (add_using_directive): Update comment.
2784 * objc-lang.c (uniquify_strings): Update comment.
2785 * ppc-linux-nat.c (struct thread_points): Update comment.
2786 * probe.h (find_probes_in_objfile): Update comment.
2787 * target.h (enum flash_preserve_mode): Update comment.
2788 * varobj.c (varobj_restrict_range): Update comment.
2789 * varobj.h (varobj_list_children): Update comment.
2790
0dc32745
AB
27912019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2792
2793 * Makefile.in: Remove references to vec.h and vec.c.
2794 * aarch64-tdep.c: No longer include vec.h.
2795 * ada-lang.c: Likewise.
2796 * ada-lang.h: Likewise.
2797 * arm-tdep.c: Likewise.
2798 * ax.h: Likewise.
2799 * breakpoint.h: Likewise.
2800 * charset.c: Likewise.
2801 * cp-support.h: Likewise.
2802 * dtrace-probe.c: Likewise.
2803 * dwarf2read.c: Likewise.
2804 * extension.h: Likewise.
2805 * gdb_bfd.c: Likewise.
2806 * gdbsupport/gdb_vecs.h: Likewise.
2807 * gdbsupport/vec.c: Remove.
2808 * gdbsupport/vec.h: Remove.
2809 * gdbthread.h: Likewise.
2810 * guile/scm-type.c: Likewise.
2811 * inline-frame.c: Likewise.
2812 * machoread.c: Likewise.
2813 * memattr.c: Likewise.
2814 * memrange.h: Likewise.
2815 * namespace.h: Likewise.
2816 * nat/linux-btrace.h: Likewise.
2817 * osdata.c: Likewise.
2818 * parser-defs.h: Likewise.
2819 * progspace.h: Likewise.
2820 * python/py-type.c: Likewise.
2821 * record-btrace.c: Likewise.
2822 * rust-exp.y: Likewise.
2823 * solib-target.c: Likewise.
2824 * stap-probe.c: Likewise.
2825 * target-descriptions.c: Likewise.
2826 * target-memory.c: Likewise.
2827 * target.h: Likewise.
2828 * varobj.c: Likewise.
2829 * varobj.h: Likewise.
2830 * xml-support.h: Likewise.
2831
ae640021
AB
28322019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2833
2834 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2835 Update for new std::vector based implementation.
2836 (process_psymtab_comp_unit_reader): Likewise.
2837 (scan_partial_symbols): Likewise.
2838 (recursively_compute_inclusions): Likewise.
2839 (compute_compunit_symtab_includes): Likewise.
2840 (process_imported_unit_die): Likewise.
2841 (queue_and_load_dwo_tu): Likewise.
2842 (follow_die_sig_1): Likewise.
2843 * gdb/dwarf2read.h: Remove DEF_VEC_P.
2844 (typedef dwarf2_per_cu_ptr): Remove.
2845 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2846 function.
2847 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2848 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2849 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2850 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2851 std::vector.
2852
55dfc88f
TT
28532019-10-15 Tom Tromey <tromey@adacore.com>
2854
2855 * windows-nat.c (windows_nat_target::resume): Use %x when logging
2856 TID.
2857
96b49c5e
TT
28582019-10-15 Tom Tromey <tromey@adacore.com>
2859
2860 * windows-nat.c (windows_nat_target::fetch_registers)
2861 (windows_nat_target::store_registers): Rename "pid" to "tid".
2862
953cff56
TT
28632019-10-15 Tom Tromey <tromey@adacore.com>
2864
2865 * gdbarch.h, gdbarch.c: Rebuild.
2866 * gdbarch.sh (gcc_target_options): Change return type to
2867 std::string.
2868 * compile/compile.c (get_args): Update.
2869 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2870 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2871 std::string.
2872 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2873 std::string.
2874 * arch-utils.c (default_gcc_target_options): Return std::string.
2875 * arch-utils.h (default_gcc_target_options): Return std::string.
2876 * s390-tdep.c (s390_gcc_target_options): Return std::string.
2877
81e6b8eb
CB
28782019-10-15 Christian Biesinger <cbiesinger@google.com>
2879
2880 * breakpoint.c (breakpoint_chain): Make static.
2881 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2882 of accessing breakpoint_chain.
2883
95da600f
CB
28842019-10-15 Christian Biesinger <cbiesinger@google.com>
2885
2886 * breakpoint.c (iterate_over_breakpoints): Change function pointer
2887 to a gdb::function_view and return value to bool.
2888 * breakpoint.h (iterate_over_breakpoints): Likewise.
2889 * dummy-frame.c (pop_dummy_frame_bpt): Update.
2890 (pop_dummy_frame): Update.
2891 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2892 (gdbscm_breakpoints): Update.
2893 * python/py-breakpoint.c (build_bp_list): Update.
2894 (gdbpy_breakpoints): Update.
2895 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2896 Update.
2897 (bpfinishpy_handle_stop): Update.
2898 (bpfinishpy_handle_exit): Update.
2899 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2900 (svr4_update_solib_event_breakpoints): Update.
2901
ba18312d
AA
29022019-10-15 Andreas Arnez <arnez@linux.ibm.com>
2903
2904 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2905 when unwrapping single-field structs.
2906
6acc1a0b
SM
29072019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
2908
2909 * dwarf2read.c: Remove includes.
2910
284782de
SM
29112019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
2912
2913 * ui-out.c (ui_out::call_do_message): Silence
2914 -Wformat-nonliteral warning.
2915
073bbbb0
SM
29162019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
2917
2918 * breakpoint.c: Remove some includes: continuations.h, skip.h,
2919 mi/mi-main.h, readline/readline.h, readline/history.h. Add
2920 include: readline/tilde.h.
2921
7b9a15e1
CB
29222019-10-12 Christian Biesinger <cbiesinger@google.com>
2923
2924 * remote.c (remote_target::get_trace_status): Remove declaration of
2925 trace_regblock_size.
2926
cc8dee1f
CB
29272019-10-12 Christian Biesinger <cbiesinger@google.com>
2928
2929 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2930 (show_user): Remove declaration of cmdlist.
2931 * cli/cli-cmds.h (max_user_call_depth): Declare.
2932 * cli/cli-script.c (execute_user_command): Remove declaration
2933 of max_user_call_depth.
2934
a83d4ef6
JW
29352019-10-11 Jim Wilson <jimw@sifive.com>
2936
5f93c5a6
JW
2937 * gdbsupport/print-utils.h (pulongest): Fix comment.
2938 (plongest): Likewise.
2939 (phex): Add missing comment, mention leading zeros.
2940 (phex_nz): Add mention of no leading zeros to comment.
2941
a83d4ef6
JW
2942 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2943 plongest instead of unsigned long long cast.
2944
26344e0c
CB
29452019-10-10 Christian Biesinger <cbiesinger@google.com>
2946
2947 * main.c (captured_main_1): Include gdbtk.h and remove declarations
2948 for external_editor_command and gdbtk_test.
2949
c2c440a9
CB
29502019-10-10 Christian Biesinger <cbiesinger@google.com>
2951
2952 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2953 * varobj.c (varobjdebug): Move comment to...
2954 * varobj.h (varobjdebug): ...here, and declare.
2955
a31bff9d
TT
29562019-10-09 Tom Tromey <tom@tromey.com>
2957
2958 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2959 erase_data_content.
2960
7523da63
TT
29612019-10-09 Tom Tromey <tom@tromey.com>
2962
2963 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2964 * tui/tui-stack.c (tui_locator_window::rerender): Update.
2965 * tui/tui-command.c (tui_cmd_window::resize)
2966 (tui_refresh_cmd_win): Update.
2967 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2968 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2969 * tui/tui-data.c (~tui_gen_win_info): Remove.
2970 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2971 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2972 (tui_redisplay_readline, tui_mld_flush)
2973 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2974 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2975 (tui_data_window::erase_data_content)
2976 (tui_data_item_window::rerender)
2977 (tui_data_item_window::refresh_window): Update.
2978 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2979 (box_win, tui_gen_win_info::make_window)
2980 (tui_gen_win_info::make_visible): Update.
2981 (tui_delete_win): Remove.
2982 * tui/tui-winsource.c
2983 (tui_source_window_base::do_erase_source_content): Update.
2984 (tui_show_source_line, tui_source_window_base::update_tab_width)
2985 (tui_source_window_base::update_exec_info): Update.
2986 * tui/tui-data.h (struct curses_deleter): New.
2987 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2988 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2989
a7798e7f
TT
29902019-10-09 Tom Tromey <tom@tromey.com>
2991
2992 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2993
5c45899e
TT
29942019-10-09 Tom Tromey <tom@tromey.com>
2995
2996 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2997 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2998
6d7fd9aa
TT
29992019-10-09 Tom Tromey <tom@tromey.com>
3000
3001 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3002 window height directly.
3003 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3004 declare.
3005 * tui/tui-layout.c (tui_default_win_height): Remove.
3006 (tui_default_win_viewport_height): Remove.
3007
d2dd1084
TT
30082019-10-09 Tom Tromey <tom@tromey.com>
3009
3010 * tui/tui.h: Remove comments.
3011
cff32449
TV
30122019-10-09 Tom de Vries <tdevries@suse.de>
3013
3014 * python/lib/gdb/printer/bound_registers.py: Use
3015 '^builtin_type_bound128' as regexp argument for
3016 add_builtin_pretty_printer.
3017
6a25e8a2
CB
30182019-10-09 Christian Biesinger <cbiesinger@google.com>
3019
3020 * guile/guile.c (guile_extension_script_ops): Remove forward
3021 declaration and mark as static.
3022 (guile_script_ops): Likewise.
3023 (extension_language_guile): Move further down in the file so
3024 it can reference the definitions for guile_{extension_,}script_ops.
3025
6d9d6da4
AA
30262019-10-09 Andreas Arnez <arnez@linux.ibm.com>
3027
3028 * s390-tdep.c (390_process_record): Handle new arch13 instructions
3029 except SORTL, DFLTCC, and KDSA.
3030
3abea05d
TT
30312019-10-08 Tom Tromey <tromey@adacore.com>
3032
3033 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3034 (struct safe_symbol_file_add_args): Remove.
3035
dde996e2
TT
30362019-10-08 Tom Tromey <tromey@adacore.com>
3037
3038 * windows-nat.c: Don't include buildsym-legacy.h.
3039
cd6fdaa1
TT
30402019-10-08 Tom Tromey <tromey@adacore.com>
3041
3042 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3043
79bb1944
CB
30442019-10-08 Christian Biesinger <cbiesinger@google.com>
3045
3046 * gdbtypes.c (overload_debug): Move comment to header.
3047 * gdbtypes.h (overload_debug): Declare.
3048 * valops.c: Remove declaration of overload_debug, instead
3049 include gdbtypes.h.
3050
34916edc
CB
30512019-10-08 Christian Biesinger <cbiesinger@google.com>
3052
3053 * language.c (show_language_command): Pass lang_frame_mismatch_warn
3054 through _().
3055 (lang_frame_mismatch_warn): Make const, mark with N_(), and
3056 move comment...
3057 * language.h (lang_frame_mismatch_warn): ... here. Also add
3058 declaration.
3059 * top.c (lang_frame_mismatch_warn): Remove declaration.
3060 (check_frame_language_change): Pass lang_frame_mismatch_warn
3061 through _().
3062
bad5c026
CB
30632019-10-07 Christian Biesinger <cbiesinger@google.com>
3064
3065 * c-lang.h (vtbl_ptr_name): Declare.
3066 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3067 it from the header.
3068 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3069
51f1fdc3
CB
30702019-10-07 Christian Biesinger <cbiesinger@google.com>
3071
3072 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3073 gdb_static_assert.
3074
30d1f018
WP
30752019-10-07 Weimin Pan <weimin.pan@oracle.com>
3076
606813d5
WP
3077 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3078 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
30d1f018
WP
3079 * ctfread.c: New file.
3080 * ctfread.h: New file.
3081 * elfread.c: Include ctfread.h.
3082 (struct elfinfo text_p): New member ctfsect.
3083 (elf_locate_sections): Mark CTF section.
3084 (elf_symfile_read): Call elfctf_build_psymtabs.
3085 * Makefile.in (LIBCTF): Add.
3086 (CLIBS): Use it.
3087 (CDEPS): Likewise.
3088 (DIST): Add ctfread.c.
606813d5
WP
3089
30902019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
3091
3092 * ctfread.c (struct nextfield): Renamed to ...
3093 (struct ctf_nextfield): ... this.
3094 (struct field_info): Renamed to ...
3095 (strut ctf_field_info): ... this.
3096 (attach_fields_to_type): Update for renamed structures.
3097 (ctf_add_member_cb): Likewise.
3098 (ctf_add_enum_member_cb): Likewise.
3099 (process_struct_members): Likewise.
3100 (process_enum_type): Likewise.
30d1f018 3101
518fe38c
WP
31022019-10-07 Weimin Pan <weimin.pan@oracle.com>
3103
3104 * tracectf.h: Rename, was ctf.h.
3105 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3106 * tracefile.c: Likewise.
3107 * tracepoint.c: Remove unused include ctf.h.
3108 * mi/mi-main.c: Likewise.
3109 * Makefile.in Replace ctf.c with tracectf.c.
3110
225f296a
JB
31112019-10-06 Joel Brobecker <brobecker@adacore.com>
3112
3113 * version.in: Change version number to "9.0.50.DATE-git".
3114
77c2dba3
TT
31152019-10-03 Tom Tromey <tom@tromey.com>
3116
3117 PR rust/24976:
3118 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3119
179aed7f
AB
31202019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3121
3122 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3123 cp_search_name_hash.
3124 * NEWS: Add entry about nested function support.
3125
0a4b0913
AB
31262019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
3127 Andrew Burgess <andrew.burgess@embecosm.com>
3128
3129 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3130 for nested static variables when searchin VAR_DOMAIN.
3131 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3132 global scope, update comment.
3133 (add_partial_subprogram): Call add_partial_subprogram recursively
3134 for nested subroutines when processinng Fortran.
3135 (load_partial_dies): Process the child entities of a subprogram
3136 when processing Fortran.
3137 (partial_die_parent_scope): Handle building scope
3138 for Fortran nested functions.
3139 (process_die): Record that nested functions have a scope.
3140 (new_symbol): Always record Fortran subprograms on the global
3141 symbol list.
3142 (determine_prefix): How to build the prefix for Fortran
3143 subprograms.
3144
d8c06f22
AB
31452019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3146
3147 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3148 have just sent the thread a SIGSTOP and are waiting for it to
3149 arrive.
3150
a8b3b8e9
AB
31512019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3152
3153 * btrace.c (btrace_add_pc): Remove whitespace before the template
3154 parameter in 'std::vector <...>'.
3155 (parse_xml_btrace_block): Likewise.
3156 (btrace_maint_decode_pt): Likewise.
3157 (btrace_maint_update_packets): Likewise.
3158 (btrace_maint_print_packets): Likewise.
3159 * btrace.h (struct btrace_maint_info): Likewise.
3160 * dwarf2read.c (struct type_unit_group): Likewise.
3161 (build_type_psymtabs_reader): Likewise.
3162 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3163 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3164 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3165
4d825eab
TV
31662019-10-03 Tom de Vries <tdevries@suse.de>
3167
3168 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3169 the first line of the help text for set/show style metadata.
3170
80fd2826
TT
31712019-10-02 Tom Tromey <tromey@adacore.com>
3172
3173 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3174 * gdbsupport/common-inferior.c: New file.
3175 * infcmd.c (startup_with_shell): Don't define.
3176 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3177 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3178 * inferior.h (startup_with_shell): Don't declare.
3179
70054538
CB
31802019-10-02 Christian Biesinger <cbiesinger@google.com>
3181
3182 * gdbsupport/gdb_assert.h: Include errors.h.
3183 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3184
37f6a7f4
TT
31852019-10-02 Tom Tromey <tromey@adacore.com>
3186
3187 * NEWS: Add $_ada_exception entry.
3188 * ada-lang.c (struct ada_catchpoint): Add constructor.
3189 <m_kind>: New member.
3190 (allocate_location_exception, re_set_exception): Remove
3191 "ex" parameter.
3192 (should_stop_exception): Compute $_ada_exception.
3193 (check_status_exception, print_it_exception)
3194 (print_one_exception, print_mention_exception): Remove
3195 "ex" parameter.
3196 (allocate_location_catch_exception, re_set_catch_exception)
3197 (check_status_exception, print_it_catch_exception)
3198 (print_one_catch_exception, print_mention_catch_exception)
3199 (print_recreate_catch_exception)
3200 (allocate_location_catch_exception_unhandled)
3201 (re_set_catch_exception_unhandled)
3202 (check_status_exception, print_it_catch_exception_unhandled)
3203 (print_one_catch_exception_unhandled)
3204 (print_mention_catch_exception_unhandled)
3205 (print_recreate_catch_exception_unhandled)
3206 (allocate_location_catch_assert, re_set_catch_assert)
3207 (check_status_assert, print_it_catch_assert)
3208 (print_one_catch_assert, print_mention_catch_assert)
3209 (print_recreate_catch_assert)
3210 (allocate_location_catch_handlers, re_set_catch_handlers)
3211 (check_status_handlers, print_it_catch_handlers)
3212 (print_one_catch_handlers, print_mention_catch_handlers)
3213 (print_recreate_catch_handlers): Remove.
3214 (create_ada_exception_catchpoint): Update.
3215 (initialize_ada_catchpoint_ops): Update.
3216
fccf9de1
TT
32172019-10-02 Tom Tromey <tromey@adacore.com>
3218
3219 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3220 (create_excep_cond_exprs): Simplify exception string computation.
3221 (ada_exception_catchpoint_cond_string): Likewise.
3222
4b610737
TT
32232019-10-02 Tom Tromey <tromey@adacore.com>
3224
3225 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3226 * ada-lang.c (lesseq_defined_than): Handle
3227 LOC_STATIC.
3228 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3229 parameter.
3230 (dwarf2_has_info): Likewise.
3231 (new_symbol): Set maybe_copied on symbol when
3232 appropriate.
3233 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3234 parameter.
3235 <can_copy>: New member.
3236 * elfread.c (record_minimal_symbol): Set maybe_copied
3237 on symbol when appropriate.
3238 (elf_symfile_read): Update call to dwarf2_has_info.
3239 * minsyms.c (lookup_minimal_symbol_linkage): New
3240 function.
3241 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3242 * symtab.c (get_symbol_address, get_msymbol_address):
3243 New functions.
3244 * symtab.h (get_symbol_address, get_msymbol_address):
3245 Declare.
3246 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3247 maybe_copied.
3248 (struct symbol, struct minimal_symbol) <maybe_copied>:
3249 New member.
3250
1dd58850
TT
32512019-10-02 Tom Tromey <tromey@adacore.com>
3252
3253 * source.c (struct current_source_location): New.
3254 (current_source_key): New global.
3255 (current_source_symtab, current_source_line)
3256 (current_source_pspace): Remove.
3257 (get_source_location): New function.
3258 (get_current_source_symtab_and_line)
3259 (set_default_source_symtab_and_line)
3260 (set_current_source_symtab_and_line)
3261 (clear_current_source_symtab_and_line, select_source_symtab)
3262 (info_source_command, print_source_lines_base)
3263 (info_line_command, search_command_helper, _initialize_source):
3264 Update.
3265
5c281dbb
TT
32662019-10-02 Tom Tromey <tromey@adacore.com>
3267
3268 * source.c (select_source_symtab): Don't call
3269 decode_line_with_current_source.
3270
d3d32391
AB
32712019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3272
3273 * symtab.c (lookup_global_symbol): Search global block.
3274
38583298
TT
32752019-10-02 Tom Tromey <tromey@adacore.com>
3276
3277 * coffread.c (process_coff_symbol): Update.
3278 * dwarf2read.c (var_decode_location, new_symbol): Update.
3279 * mdebugread.c (parse_symbol): Update.
3280 * objfiles.c (relocate_one_symbol): Update.
3281 * stabsread.c (define_symbol, fix_common_block)
3282 (scan_file_globals): Update.
3283 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3284 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3285 * xcoffread.c (process_xcoff_symbol): Update.
3286
9344c18f
AA
32872019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3288
3289 * MAINTAINERS: Update my email address.
3290
df07e2c7
AB
32912019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3292
3293 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3294 std::vector.
3295 (build_type_psymtabs_reader): Update for std::vector.
3296 (build_type_psymtab_dependencies): Likewise.
3297 * dwarf2read.h: Remove use of DEF_VEC_P.
3298 (typedef sig_type_ptr): Delete.
3299
554ac434
AB
33002019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3301
3302 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3303 to std::vector.
3304 (btrace_maint_decode_pt): Likewise, and move allocation of the
3305 vector outside of the loop.
3306 (btrace_maint_update_packets): Update to handle change from VEC to
3307 std::vector.
3308 (btrace_maint_print_packets): Likewise.
3309 (maint_info_btrace_cmd): Likewise.
3310 * btrace.h: Remove use of DEF_VEC_O.
3311 (typedef btrace_pt_packet_s): Delete.
3312 (struct btrace_maint_info) <packets>: Change fromm VEC to
3313 std::vector.
3314 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3315
46f29a9a
AB
33162019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3317
3318 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3319 make accesses into the vector constant references.
3320 (btrace_add_pc): Update for std::vector.
3321 (btrace_stitch_bts): Likewise.
3322 (parse_xml_btrace_block): Likewise.
3323 (btrace_maint_update_packets): Likewise.
3324 (btrace_maint_print_packets): Likewise.
3325 (maint_info_btrace_cmd): Likewise.
3326 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3327 std::vector.
3328 (btrace_data::empty): Likewise.
3329 (btrace_data_append): Likewise.
3330 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3331 (typedef btrace_block_s): Delete.
3332 (struct btrace_block): Add constructor.
3333 (struct btrace_data_bts) <blocks>: Change to std::vector.
3334 * nat/linux-btrace.c (perf_event_read_bts): Update for
3335 std::vector.
3336 (linux_read_bts): Likewise.
3337
d770d56f
TT
33382019-10-01 Tom Tromey <tom@tromey.com>
3339
3340 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3341
9d636d67
TT
33422019-10-01 Tom Tromey <tom@tromey.com>
3343
3344 * stack.c (print_frame, info_frame_command_core): Use
3345 styled_string.
3346 * linux-thread-db.c (try_thread_db_load_1)
3347 (try_thread_db_load_from_pdir_1): Use styled_string.
3348 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3349 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3350 (maybe_print_unsupported_script_warning)
3351 (maybe_print_script_not_found_warning): Use styled_string.
3352 * ada-lang.c (user_select_syms): Use styled_string.
3353
7f6aba03
TT
33542019-10-01 Tom Tromey <tom@tromey.com>
3355
3356 * p-lang.c (pascal_printstr): Use metadata style.
3357 * value.c (show_convenience): Use metadata style.
3358 * valprint.c (valprint_check_validity, val_print_optimized_out)
3359 (val_print_not_saved, val_print_unavailable)
3360 (val_print_invalid_address, generic_val_print, val_print)
3361 (value_check_printable, val_print_array_elements): Use metadata
3362 style.
3363 * ui-out.h (class ui_out) <field_fmt>: New overload.
3364 <do_field_fmt>: Add style parameter.
3365 * ui-out.c (ui_out::field_fmt): New overload.
3366 * typeprint.c (type_print_unknown_return_type)
3367 (val_print_not_allocated, val_print_not_associated): Use metadata
3368 style.
3369 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3370 parameter.
3371 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3372 * tracepoint.c (tvariables_info_1): Use metadata style.
3373 * stack.c (print_frame_arg, print_frame_info, print_frame)
3374 (info_frame_command_core): Use metadata style.
3375 * skip.c (info_skip_command): Use metadata style.
3376 * rust-lang.c (rust_print_enum): Use metadata style.
3377 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3378 metadata style.
3379 * python/py-framefilter.c (py_print_single_arg): Use metadata
3380 style.
3381 * printcmd.c (do_one_display, print_variable_and_value): Use
3382 metadata style.
3383 * p-valprint.c (pascal_val_print)
3384 (pascal_object_print_value_fields): Use metadata style.
3385 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3386 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3387 parameter.
3388 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3389 * m2-valprint.c (m2_print_long_set): Use metadata style.
3390 * m2-typeprint.c (m2_print_type): Use metadata style.
3391 * infcmd.c (print_return_value_1): Use metadata style.
3392 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3393 * f-valprint.c (info_common_command_for_block): Use metadata
3394 style.
3395 * f-typeprint.c (f_type_print_base): Use metadata style.
3396 * expprint.c (print_subexp_standard): Use metadata style.
3397 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3398 * cli/cli-style.h (class cli_style_option): Add constructor.
3399 (metadata_style): Declare.
3400 * cli/cli-style.c (metadata_style): New global.
3401 (_initialize_cli_style): Register metadata style.
3402 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3403 parameter.
3404 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3405 * c-typeprint.c (c_type_print_base_struct_union)
3406 (c_type_print_base_1): Use metadata style.
3407 * breakpoint.c (watchpoint_value_print)
3408 (print_one_breakpoint_location): Use metadata style.
3409 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3410 style.
3411 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3412 style.
3413 * ada-valprint.c (val_print_packed_array_elements, printstr)
3414 (print_field_values, ada_val_print_ref, ada_val_print): Use
3415 metadata style.
3416 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3417 style.
3418 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3419 style.
3420 * ada-lang.c (user_select_syms): Use metadata style.
3421
14309bb6
TT
34222019-10-01 Tom Tromey <tom@tromey.com>
3423
3424 * cli/cli-cmds.c (pwd_command): Style output.
3425
6a831f06
PA
34262019-10-01 Pedro Alves <palves@redhat.com>
3427 Tom Tromey <tom@tromey.com>
3428
3429 * symtab.c (print_symbol_info): Use %ps.
3430 (print_msymbol_info): Use %ps.
3431 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3432 * printcmd.c (print_variable_and_value): Use %ps.
3433 * macrocmd.c (show_pp_source_pos): Use %ps.
3434 * infrun.c (print_exited_reason): Use ui_out::message.
3435 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3436 (describe_other_breakpoints): Use ui_out::message and new
3437 formats.
3438 (say_where): Use new formats.
3439 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3440 and new formats.
3441
2a3c1174
PA
34422019-10-01 Pedro Alves <palves@redhat.com>
3443 Tom Tromey <tom@tromey.com>
3444
3445 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3446 (test_gdb_formats): New function.
3447 (run_tests): Call it.
3448 (test_format_specifier): Update.
3449 * utils.h (fputs_filtered): Update comment.
3450 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3451 (fputs_styled_unfiltered): Declare.
3452 * utils.c (fputs_styled_unfiltered): New function.
3453 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3454 (vfprintf_filtered): Update.
3455 (vfprintf_unfiltered, vprintf_filtered): Update.
3456 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3457 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3458 disallow_ui_out_field>: New constants.
3459 (enum class field_kind): New.
3460 (struct base_field_s, struct signed_field_s): New.
3461 (signed_field): New function.
3462 (struct string_field_s): New.
3463 (string_field): New function.
3464 (struct styled_string_s): New.
3465 (styled_string): New function.
3466 (class ui_out) <message>: Add comment.
3467 <vmessage, call_do_message>: New methods.
3468 <do_message>: Add style parameter.
3469 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3470 methods.
3471 (ui_out::message): Rewrite.
3472 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3473 parameter.
3474 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3475 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3476 gdb_extensions parameter.
3477 (class format_piece): Add parameter to constructor.
3478 (n_int_args): New field.
3479 * gdbsupport/format.c (format_pieces::format_pieces): Add
3480 gdb_extensions parameter. Handle '*'.
3481 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3482 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3483 vfprintf_styled_no_gdbfmt.
3484 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3485 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3486 unfiltered output.
3487 * ui-style.h (struct ui_file_style) <ptr>: New method.
3488
0dfe5bfb
TT
34892019-10-01 Tom Tromey <tom@tromey.com>
3490
3491 * unittests/format_pieces-selftests.c: Update. Add final format.
3492 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3493 empty literal pieces.
3494
e43b10e1
TT
34952019-10-01 Tom Tromey <tom@tromey.com>
3496
3497 * ui-out.h (enum class ui_out_style_kind): Remove.
3498 (class ui_out) <field_string, field_stsream, do_field_string>:
3499 Change type of "style".
3500 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3501 (ui_out::field_string): Update.
3502 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3503 of "style".
3504 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3505 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3506 * stack.c (print_frame_arg, print_frame_info, print_frame):
3507 Update.
3508 * source.c (print_source_lines_base): Update.
3509 * solib.c (info_sharedlibrary_command): Update.
3510 * skip.c (info_skip_command): Update.
3511 * record-btrace.c (btrace_call_history_src_line)
3512 (btrace_call_history): Update.
3513 * python/py-framefilter.c (py_print_frame): Update.
3514 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3515 "style".
3516 * mi/mi-out.c (mi_ui_out::do_table_header)
3517 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3518 (mi_ui_out::do_field_string): Update.
3519 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3520 Update.
3521 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3522 "style".
3523 * cli-out.c (cli_ui_out::do_table_header)
3524 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3525 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3526 (cli_ui_out::do_field_fmt): Update.
3527 * breakpoint.c (print_breakpoint_location): Update.
3528 (update_static_tracepoint): Update.
3529
cd7c32c3
PW
35302019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3531
3532 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3533 conversion of gdb_datadir.
3534 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3535 remove not needed c_str ().
3536
8fe0f950
AT
35372019-09-30 Ali Tamur <tamur@google.com>
3538
3539 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3540 (dwarf2_string_attr): Likewise.
3541
5f48f8f3
AT
35422019-09-30 Ali Tamur <tamur@google.com>
3543
3544 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3545 (process_full_type_unit): Likewise.
3546 (dump_die_shallow): Likewise.
3547 (cu_debug_loc_section): Likewise.
3548
6fb08628
CB
35492019-09-28 Christian Biesinger <cbiesinger@google.com>
3550
3551 * minsyms.c (compare_minimal_symbols): Rename to...
3552 (minimal_symbol_is_less_than): ...this, and adjust to STL
3553 conventions (return bool, take arguments as references)
3554 (minimal_symbol_reader::install): Call std::sort instead
3555 of qsort.
3556
c7ee338a
CB
35572019-09-29 Christian Biesinger <cbiesinger@google.com>
3558
3559 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3560 hash and why.
3561 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3562 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3563
703a86c2
SM
35642019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3565
3566 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3567 * psympriv.h (add_psymbol_to_list): Move comment here and update
3568 it.
3569
0df0352a
TV
35702019-09-29 Tom de Vries <tdevries@suse.de>
3571
3572 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3573 Use $tmpdir/$(basename "$output_file").dwz instead of
3574 "${output_file}.dwz".
3575
ad75efa6
SM
35762019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3577
3578 PR gdb/25045
3579 * hppa-linux-nat.c: Include gdbarch.h.
3580
ececd218
CB
35812019-09-26 Christian Biesinger <cbiesinger@google.com>
3582
3583 * blockframe.c (find_pc_partial_function): Change return type to bool.
3584 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3585 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3586 (stub_gnu_ifunc_resolve_name): Likewise.
3587 * symtab.c (compare_filenames_for_search): Likewise.
3588 (compare_glob_filenames_for_search): Likewise.
3589 (matching_obj_sections): Likewise.
3590 (symbol_matches_domain): Likewise.
3591 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3592 (find_line_pc): Change return type to bool.
3593 (find_line_pc_range): Likewise.
3594 (producer_is_realview): Likewise.
3595 * symtab.h (symbol_matches_domain): Likewise.
3596 (find_pc_partial_function): Likewise.
3597 (find_pc_line_pc_range): Likewise.
3598 (in_gnu_ifunc_stub): Likewise.
3599 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3600 (find_line_pc): Likewise.
3601 (find_line_pc_range): Likewise.
3602 (matching_obj_sections): Likewise.
3603 (find_line_symtab): Change out parameter to bool.
3604 (producer_is_realview): Change return type to bool.
3605 (compare_filenames_for_search): Likewise.
3606 (compare_glob_filenames_for_search): Likewise.
3607
27a900b8
TT
36082019-09-26 Tom Tromey <tom@tromey.com>
3609
3610 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3611 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3612 * gdb_usleep.h: Remove.
3613 * gdb_usleep.c: Remove.
3614 * utils.c: Don't include gdb_usleep.h.
3615
5d63b30a
TT
36162019-09-26 Tom Tromey <tromey@adacore.com>
3617
3618 * python/py-type.c (type_to_type_object): Call check_typedef
3619 for stub types.
3620
12904d37
TT
36212019-09-26 Tom Tromey <tom@tromey.com>
3622
3623 * utils.h (initialize_utils): Don't declare.
3624 * top.c (gdb_init): Don't call initialize_utils.
3625 * utils.c (initialize_utils): Remove. Move contents...
3626 (_initialize_utils): ... here.
3627
858f25f0
TT
36282019-09-25 Tom Tromey <tom@tromey.com>
3629
3630 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3631 * utils.h (make_hex_string): Don't declare.
3632 * utils.c (make_hex_string): Remove.
3633
3d435220
TV
36342019-09-24 Tom de Vries <tdevries@suse.de>
3635
3636 PR gdb/23815
3637 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3638 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3639
ddd44b70
DD
36402019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3641
3642 * NEWS: Mention new simulator port for PRU.
3643
f945dedf
CB
36442019-09-23 Christian Biesinger <cbiesinger@google.com>
3645
3646 * ada-exp.y (write_object_remaining): Update.
3647 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3648 and eliminate the static buffer.
3649 (ada_decode_symbol): Update.
3650 (ada_la_decode): Update.
3651 (ada_sniff_from_mangled_name): Update.
3652 (is_valid_name_for_wild_match): Update.
3653 (ada_lookup_name_info::matches): Update and simplify.
3654 (name_matches_regex): Update.
3655 (ada_add_global_exceptions): Update.
3656 * ada-lang.h (ada_decode): Update signature.
3657 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3658 * dwarf-index-write.c (debug_names::insert): Update.
3659
7ab78ccb
SM
36602019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3661
3662 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3663 formatting.
3664
9252448b
SM
36652019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3666
3667 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3668 Change "nonzero" to "true" in documentation.
3669
626ca2c0
CB
36702019-09-20 Christian Biesinger <cbiesinger@google.com>
3671
3672 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3673 (_initialize_darwin_solib): Don't set
3674 darwin_so_ops.lookup_lib_global_symbol.
3675 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3676 set_gdbarch_iterate_over_objfiles_in_search_order.
3677 (elf_lookup_lib_symbol): Rename to...
3678 (svr4_iterate_over_objfiles_in_search_order): this, and update
3679 to iterate semantics.
3680 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3681 * solib.c (solib_global_lookup): Remove.
3682 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3683 (solib_global_lookup): Remove.
3684 * symtab.c (lookup_global_or_static_symbol): Remove call to
3685 solib_global_lookup.
3686
5a3a0d63
JB
36872019-09-20 Joel Brobecker <brobecker@adacore.com>
3688
3689 * NEWS: Move entries about default MI version now being
3690 version 3, and about the GDB/MI fix for multi-location
3691 breakpoints to the "since GDB 8.3" section.
3692
ffea1427
JB
36932019-09-20 Joel Brobecker <brobecker@adacore.com>
3694
3695 GDB 8.3.1 released.
3696
abf516c6
UW
36972019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
3698
3699 * NEWS: Mention that Cell/B.E. debugging support was removed.
3700 * MAINTAINERS: Remove spu target.
3701
3702 * config/djgpp/fnchange.lst: Remove entries for removed files.
3703
3704 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3705 spu-multiarch.o, and spu-tdep.o.
3706 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3707 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3708 spu-multiarch.c, and spu-tdep.c.
3709 * spu-linux-nat.c: Remove file.
3710 * spu-multiarch.c: Remove file.
3711 * spu-tdep.c: Remove file.
3712 * spu-tdep.h: Remove file.
3713 * solib-spu.c: Remove file.
3714 * solib-spu.h: Remove file.
3715
3716 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3717 * configure.nat (spu-linux): Remove.
3718 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3719 solib-multiarch.o from gdb_target_obs.
3720 (spu*-*-*): Remove.
3721
3722 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3723 feature flag.
3724 (ppc_linux_no_features): Update.
3725 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3726 Cell/B.E. support.
3727 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3728 (tdesc_powerpc_cell64l): Likewise.
3729 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3730 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3731 Cell/B.E. support.
3732 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3733 Do not include "features/rs6000/powerpc-cell32l.c" or
3734 "features/rs6000/powerpc-cell64l.c".
3735 (ppc_linux_spu_section): Remove.
3736 (ppc_linux_core_read_description): Remove Cell/B.E. support.
3737 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3738 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3739 (ppc_linux_spe_context_lookup): Remove.
3740 (ppc_linux_spe_context_inferior_created): Remove.
3741 (ppc_linux_spe_context_solib_loaded): Remove.
3742 (ppc_linux_spe_context_solib_unloaded): Remove.
3743 (ppc_linux_spe_context): Remove.
3744 (struct ppu2spu_cache): Remove.
3745 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3746 (struct ppu2spu_data): Remove.
3747 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3748 ppu2spu_unwind): Remove.
3749 (ppc_linux_init_abi): Remove Cell/B.E. support.
3750 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3751
3752 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3753 (rs6000/powerpc-cell64l-expedite): Likewise
3754 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3755 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3756 rs6000/powerpc-cell64l.xml.
3757 * features/rs6000/powerpc-cell32l.xml: Remove.
3758 * features/rs6000/powerpc-cell64l.xml: Likewise.
3759 * features/rs6000/powerpc-cell32l.c: Remove generated file.
3760 * features/rs6000/powerpc-cell64l.c: Likewise.
3761 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3762 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3763 * regformats/reg-spu.dat: Remove.
3764
3765 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3766 * corelow.c (struct spuid_list): Remove.
3767 (add_to_spuid_list): Remove.
3768 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3769 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3770 (remote_protocol_features): Remove associated entries.
3771 (_initialize_remote): No longer initialize them.
3772 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3773 * linux-nat.c (SPUFS_MAGIC): Remove.
3774 (linux_proc_xfer_spu): Remove.
3775 (spu_enumerate_spu_ids): Remove.
3776 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3777 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3778 (linux_make_corefile_notes): No longer call it.
3779
3780 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3781 (cooked_write_test): Likewise.
3782
78e8cb91
TT
37832019-09-20 Tom Tromey <tom@tromey.com>
3784
3785 * NEWS: Mention case-sensitivity of TUI commands.
3786 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3787 (tui_set_win_height_command, parse_scrolling_args): Likewise.
3788 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3789
f074b67e
TT
37902019-09-20 Tom Tromey <tom@tromey.com>
3791
3792 * tui/tui-source.c (tui_source_window::set_contents): Use
3793 make_unique_xstrdup.
3794 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3795 make_unique_xstrdup.
3796
63c4bf19
TT
37972019-09-20 Tom Tromey <tom@tromey.com>
3798
3799 * tui/tui-data.c: Remove separator comments.
3800 * tui/tui-layout.c: Remove separator comments.
3801 * tui/tui-win.c: Remove separator comments.
3802 * tui/tui-wingeneral.c: Remove separator comments.
3803
43df9b2f
TT
38042019-09-20 Tom Tromey <tom@tromey.com>
3805
3806 * tui/tui.h (strcat_to_buf): Don't declare.
3807 * tui/tui.c (strcat_to_buf): Remove.
3808
7226433c
TT
38092019-09-20 Tom Tromey <tom@tromey.com>
3810
3811 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3812 from "fullname".
3813 * tui/tui-source.c (tui_source_window::set_contents)
3814 (tui_source_window::location_matches_p)
3815 (tui_source_window::maybe_update): Update.
3816
80df3337
TT
38172019-09-20 Tom Tromey <tom@tromey.com>
3818
3819 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3820 Update.
3821 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3822 prefix.
3823 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3824 (tui_data_window::line_from_reg_element_no)
3825 (tui_data_window::first_reg_element_no_inline)
3826 (tui_data_window::show_registers)
3827 (tui_data_window::show_register_group)
3828 (tui_data_window::display_registers_from)
3829 (tui_data_window::display_registers_from_line)
3830 (tui_data_window::first_data_item_displayed)
3831 (tui_data_window::delete_data_content_windows)
3832 (tui_data_window::erase_data_content)
3833 (tui_data_window::do_scroll_vertical)
3834 (tui_data_window::refresh_window)
3835 (tui_data_window::check_register_values): Update.
3836
9923f347
TT
38372019-09-20 Tom Tromey <tom@tromey.com>
3838
3839 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3840 (struct tui_locator_window) <full_name, proc_name>: Now
3841 std::string.
3842 * tui/tui-stack.c (tui_locator_window::make_status_line)
3843 (tui_locator_window::set_locator_fullname)
3844 (tui_locator_window::set_locator_info): Update.
3845 * tui/tui-source.c (tui_source_window::set_contents)
3846 (tui_source_window::showing_source_p): Update.
3847
b76251ab
TT
38482019-09-20 Tom Tromey <tom@tromey.com>
3849
3850 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3851 Don't call tui_locator_win_info_ptr.
3852
0891be08
TT
38532019-09-20 Tom Tromey <tom@tromey.com>
3854
3855 * tui/tui-win.c (tui_resize_all): Don't call refresh.
3856
1b935acf
TT
38572019-09-20 Tom Tromey <tom@tromey.com>
3858
3859 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3860 height for locator.
3861 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3862 * tui/tui-layout.c (show_source_disasm_command, show_data)
3863 (show_source_or_disasm_and_command): Use 1 as height for locator.
3864
9abd8a65
TT
38652019-09-20 Tom Tromey <tom@tromey.com>
3866
3867 * tui/tui.c (tui_enable): Update.
3868 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3869 Update.
3870 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3871 Update.
3872 * tui/tui-data.c (win_resized): Now bool.
3873 (tui_win_resized): Return bool.
3874 (tui_set_win_resized_to): Accept a bool.
3875
b5457826
TT
38762019-09-20 Tom Tromey <tom@tromey.com>
3877
3878 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3879 Change type of "refresh_values_only".
3880 * tui/tui-regs.c (tui_data_window::show_register_group): Change
3881 type of "refresh_values_only".
3882
6b915f7d
TT
38832019-09-20 Tom Tromey <tom@tromey.com>
3884
3885 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3886 std::string.
3887 (tui_disassemble): Add "pos" parameter.
3888 (tui_disasm_window::set_contents): Simplify.
3889
2ad52f6f
TT
38902019-09-20 Tom Tromey <tom@tromey.com>
3891
3892 * tui/tui-winsource.h (struct tui_source_window_base)
3893 <show_source_content>: Now private.
3894 * tui/tui-winsource.c
3895 (tui_source_window_base::show_source_content): Don't handle empty
3896 content case.
3897
b3b1bde6
TT
38982019-09-20 Tom Tromey <tom@tromey.com>
3899
3900 * tui/tui-layout.c (show_source_disasm_command)
3901 (show_source_or_disasm_and_command): Don't call
3902 show_source_content.
3903
71a25ed2
TT
39042019-09-20 Tom Tromey <tom@tromey.com>
3905
3906 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3907 Declare.
3908 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3909 from tui_make_status_line.
3910 (tui_locator_window::rerender): Update.
3911
f8532154
TT
39122019-09-20 Tom Tromey <tom@tromey.com>
3913
3914 * tui/tui-stack.c (tui_make_status_line): Return std::string.
3915 (tui_locator_window::rerender): Update.
3916
2d81b349
TT
39172019-09-20 Tom Tromey <tom@tromey.com>
3918
3919 * tui/tui-winsource.h (struct tui_source_window_base)
3920 <~tui_source_window_base>: Don't declare.
3921 <fullname>: Remove.
3922 * tui/tui-winsource.c (~tui_source_window_base): Remove.
3923 * tui/tui-source.h (struct tui_source_window) <fullname>: New
3924 member.
3925 * tui/tui-source.c (tui_source_window::set_contents): Update.
3926 (tui_source_window::location_matches_p)
3927 (tui_source_window::maybe_update): Update.
3928
f14bec58
TT
39292019-09-20 Tom Tromey <tom@tromey.com>
3930
3931 * tui/tui-winsource.h (~tui_source_element): Remove.
3932 (tui_source_element): Update.
3933 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3934 * tui/tui-winsource.c (tui_show_source_line): Update.
3935 * tui/tui-source.c (tui_source_window::set_contents): Update.
3936 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3937
78d5933a
TT
39382019-09-20 Tom Tromey <tom@tromey.com>
3939
3940 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3941 declare.
3942 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3943 tui_clear_source_windows_detail.
3944 * tui/tui-winsource.h (struct tui_source_window_base)
3945 <clear_detail>: Don't declare.
3946 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3947 Remove.
3948 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3949
d4207696
TT
39502019-09-20 Tom Tromey <tromey@adacore.com>
3951
3952 PR ada/24919:
3953 * block.c (contained_in): Fix final return value.
3954
00f93c44
AM
39552019-09-20 Alan Modra <amodra@gmail.com>
3956
3957 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3958 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3959 (read_indirect_string_from_dwz): Use bfd accessor.
3960 * dwarf2read.h (struct dwz_file <filename>): Likewise.
3961 * machoread.c (macho_symfile_read_all_oso): Likewise.
3962 * solib.c (solib_bfd_open): Likewise.
3963
e4153ae6
CB
39642019-09-19 Christian Biesinger <cbiesinger@google.com>
3965
3966 * eval.c: Move declaration of overload_resolution to...
3967 * value.h: ...here.
3968
c7ae7675
CB
39692019-09-19 Christian Biesinger <cbiesinger@google.com>
3970
3971 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3972 * arm-linux-tdep.c: Likewise.
3973 * arm-nbsd-nat.c: Likewise.
3974 * arm-tdep.h: Declare arm_apcs_32.
3975 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3976
e86f08d2
CB
39772019-09-19 Christian Biesinger <cbiesinger@google.com>
3978
3979 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3980 * dwarf2read.h: Declare dwarf_always_disassemble.
3981
f64e2f40
TV
39822019-09-19 Tom de Vries <tdevries@suse.de>
3983
3984 PR gdb/25009
3985 * source-cache.c (source_cache::ensure): Catch exception thrown during
3986 construction of the highlighter.
3987
fd361982
AM
39882019-09-18 Alan Modra <amodra@gmail.com>
3989
3990 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3991 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3992 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3993 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3994 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3995 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3996 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3997 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3998 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3999 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4000 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4001 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4002 * solib-spu.c, * solib-svr4.c, * solib-target.c,
4003 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4004 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4005 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4006 * mi/mi-interp.c: Update throughout for bfd section macro and
4007 function changes.
4008 * gcore (gcore_create_callback): Use bfd_set_section_lma.
4009 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4010
11061048
TT
40112019-09-18 Tom Tromey <tom@tromey.com>
4012
4013 * NEWS: Add entry.
4014 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
4015 call rl_initialize.
4016 (tui_enable): Do not call rl_initialize.
4017
7a27b85f
CG
40182019-09-18 Christian Groessler <chris@groessler.org>
4019
4020 * alpha-linux-nat.c: Include gdbarch.h.
4021
f64eea3a
SM
40222019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
4023
4024 * ui-file.c: Include cli/cli-style.h.
4025 (term_cli_styling): Remove cli_styling declaration.
4026
e6f7f6d1
AM
40272019-09-18 Alan Modra <amodra@gmail.com>
4028
4029 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4030 to bfd_asymbol_section.
4031
1d38e9d1
AM
40322019-09-18 Alan Modra <amodra@gmail.com>
4033
4034 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4035 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4036 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4037
90d92a63
AM
40382019-09-18 Alan Modra <amodra@gmail.com>
4039
4040 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4041 * spu-linux-nat.c (spu_bfd_open): Likewise.
4042
a3d181d2
CB
40432019-09-18 Christian Biesinger <cbiesinger@google.com>
4044
4045 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4046 to bool to match definition in dwarf2read.c.
4047
491144b5
CB
40482019-09-17 Christian Biesinger <cbiesinger@google.com>
4049
4050 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4051 (print_signatures): Likewise.
4052 (trust_pad_over_xvs): Likewise.
4053 * arch/aarch64-insn.c (aarch64_debug): Likewise.
4054 * arch/aarch64-insn.h (aarch64_debug): Likewise.
4055 * arm-linux-nat.c (arm_apcs_32): Likewise.
4056 * arm-linux-tdep.c (arm_apcs_32): Likewise.
4057 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4058 * arm-tdep.c (arm_debug): Likewise.
4059 (arm_apcs_32): Likewise.
4060 * auto-load.c (debug_auto_load): Likewise.
4061 (auto_load_gdb_scripts): Likewise.
4062 (global_auto_load): Likewise.
4063 (auto_load_local_gdbinit): Likewise.
4064 (auto_load_local_gdbinit_loaded): Likewise.
4065 * auto-load.h (global_auto_load): Likewise.
4066 (auto_load_local_gdbinit): Likewise.
4067 (auto_load_local_gdbinit_loaded): Likewise.
4068 * breakpoint.c (disconnected_dprintf): Likewise.
4069 (breakpoint_proceeded): Likewise.
4070 (automatic_hardware_breakpoints): Likewise.
4071 (always_inserted_mode): Likewise.
4072 (target_exact_watchpoints): Likewise.
4073 (_initialize_breakpoint): Update.
4074 * breakpoint.h (target_exact_watchpoints): Change to bool.
4075 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4076 * cli/cli-cmds.c (trace_commands): Likewise.
4077 * cli/cli-cmds.h (trace_commands): Likewise.
4078 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4079 to bool*.
4080 * cli/cli-logging.c (logging_overwrite): Change to bool.
4081 (logging_redirect): Likewise.
4082 (debug_redirect): Likewise.
4083 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4084 (struct boolean_option_def) <get_var_address_cb_>: Change return type
4085 to bool.
4086 <boolean_option_def>: Update.
4087 (struct flag_option_def): Change default type of Context to bool
4088 from int.
4089 <flag_option_def>: Change return type of var_address_cb_ to bool*.
4090 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4091 (get_setshow_command_value_string): Likewise.
4092 * cli/cli-style.c (cli_styling): Change to bool.
4093 (source_styling): Likewise.
4094 * cli/cli-style.h (source_styling): Likewise.
4095 (cli_styling): Likewise.
4096 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4097 to bool.
4098 * command.h (var_types): Update comment.
4099 (add_setshow_boolean_cmd): Change int* var argument to bool*.
4100 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4101 bool.
4102 (debug_compile_cplus_scopes): Likewise.
4103 * compile/compile-internal.h (compile_debug): Likewise.
4104 * compile/compile.c (compile_debug): Likewise.
4105 (struct compile_options) <raw>: Likewise.
4106 * cp-support.c (catch_demangler_crashes): Likewise.
4107 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4108 (usr_cmd_cris_dwarf2_cfi): Likewise.
4109 * csky-tdep.c (csky_debug): Likewise.
4110 * darwin-nat.c (enable_mach_exceptions): Likewise.
4111 * dcache.c (dcache_enabled_p): Likewise.
4112 * defs.h (info_verbose): Likewise.
4113 * demangle.c (demangle): Likewise.
4114 (asm_demangle): Likewise.
4115 * dwarf-index-cache.c (debug_index_cache): Likewise.
4116 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4117 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4118 * dwarf2read.c (check_physname): Likewise.
4119 (use_deprecated_index_sections): Likewise.
4120 (dwarf_always_disassemble): Likewise.
4121 * eval.c (overload_resolution): Likewise.
4122 * event-top.c (set_editing_cmd_var): Likewise.
4123 (exec_done_display_p): Likewise.
4124 * event-top.h (set_editing_cmd_var): Likewise.
4125 (exec_done_display_p): Likewise.
4126 * exec.c (write_files): Likewise.
4127 * fbsd-nat.c (debug_fbsd_lwp): Likewise
4128 (debug_fbsd_nat): Likewise.
4129 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4130 Likewise.
4131 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4132 <backtrace_past_entry> Likewise.
4133 * gdb-demangle.h (demangle): Likewise.
4134 (asm_demangle): Likewise.
4135 * gdb_bfd.c (bfd_sharing): Likewise.
4136 * gdbcore.h (write_files): Likewise.
4137 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4138 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4139 * gdbthread.h (print_thread_events): Likewise.
4140 * gdbtypes.c (opaque_type_resolution): Likewise.
4141 (strict_type_checking): Likewise.
4142 * gnu-nat.c (gnu_debug_flag): Likewise.
4143 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4144 * guile/scm-param.c (pascm_variable): Add boolval.
4145 (add_setshow_generic): Update.
4146 (pascm_param_value): Update.
4147 (pascm_set_param_value_x): Update.
4148 * hppa-tdep.c (hppa_debug): Change to bool..
4149 * infcall.c (may_call_functions_p): Likewise.
4150 (coerce_float_to_double_p): Likewise.
4151 (unwind_on_signal_p): Likewise.
4152 (unwind_on_terminating_exception_p): Likewise.
4153 * infcmd.c (startup_with_shell): Likewise.
4154 * inferior.c (print_inferior_events): Likewise.
4155 * inferior.h (startup_with_shell): Likewise.
4156 (print_inferior_events): Likewise.
4157 * infrun.c (step_stop_if_no_debug): Likewise.
4158 (detach_fork): Likewise.
4159 (debug_displaced): Likewise.
4160 (disable_randomization): Likewise.
4161 (non_stop): Likewise.
4162 (non_stop_1): Likewise.
4163 (observer_mode): Likewise.
4164 (observer_mode_1): Likewise.
4165 (set_observer_mode): Update.
4166 (sched_multi): Change to bool.
4167 * infrun.h (debug_displaced): Likewise.
4168 (sched_multi): Likewise.
4169 (step_stop_if_no_debug): Likewise.
4170 (non_stop): Likewise.
4171 (disable_randomization): Likewise.
4172 * linux-tdep.c (use_coredump_filter): Likewise.
4173 (dump_excluded_mappings): Likewise.
4174 * linux-thread-db.c (auto_load_thread_db): Likewise.
4175 (check_thread_db_on_load): Likewise.
4176 * main.c (captured_main_1): Update.
4177 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4178 xx2_opt, boolean_opt>: Change to bool.
4179 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4180 * maint.c (maintenance_profile_p): Likewise.
4181 (per_command_time): Likewise.
4182 (per_command_space): Likewise.
4183 (per_command_symtab): Likewise.
4184 * memattr.c (inaccessible_by_default): Likewise.
4185 * mi/mi-main.c (mi_async): Likewise.
4186 (mi_async_1): Likewise.
4187 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4188 * nat/fork-inferior.h (startup_with_shell): Likewise.
4189 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4190 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4191 * nios2-tdep.c (nios2_debug): Likewise.
4192 * or1k-tdep.c (or1k_debug): Likewise.
4193 * parse.c (parser_debug): Likewise.
4194 * parser-defs.h (parser_debug): Likewise.
4195 * printcmd.c (print_symbol_filename): Likewise.
4196 * proc-api.c (procfs_trace): Likewise.
4197 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4198 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4199 (set_parameter_value): Update.
4200 (add_setshow_generic): Update.
4201 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4202 to bool*.
4203 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4204 int*.
4205 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4206 * record-btrace.c (record_btrace_target::store_registers): Update.
4207 * record-full.c (record_full_memory_query): Change to bool.
4208 (record_full_stop_at_limit): Likewise.
4209 * record-full.h (record_full_memory_query): Likewise.
4210 * remote-notif.c (notif_debug): Likewise.
4211 * remote-notif.h (notif_debug): Likewise.
4212 * remote.c (use_range_stepping): Likewise.
4213 (interrupt_on_connect): Likewise.
4214 (remote_break): Likewise.
4215 * ser-tcp.c (tcp_auto_retry): Likewise.
4216 * ser-unix.c (serial_hwflow): Likewise.
4217 * skip.c (debug_skip): Likewise.
4218 * solib-aix.c (solib_aix_debug): Likewise.
4219 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4220 (spu_auto_flush_cache_p): Likewise.
4221 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4222 Likewise.
4223 (struct info_print_options) <quiet>: Likewise.
4224 * symfile-debug.c (debug_symfile): Likewise.
4225 * symfile.c (auto_solib_add): Likewise.
4226 (separate_debug_file_debug): Likewise.
4227 * symfile.h (auto_solib_add): Likewise.
4228 (separate_debug_file_debug): Likewise.
4229 * symtab.c (basenames_may_differ): Likewise.
4230 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4231 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4232 (struct info_types_options) <quiet>: Likewise.
4233 * symtab.h (demangle): Likewise.
4234 (basenames_may_differ): Likewise.
4235 * target-dcache.c (stack_cache_enabled_1): Likewise.
4236 (code_cache_enabled_1): Likewise.
4237 * target.c (trust_readonly): Likewise.
4238 (may_write_registers): Likewise.
4239 (may_write_memory): Likewise.
4240 (may_insert_breakpoints): Likewise.
4241 (may_insert_tracepoints): Likewise.
4242 (may_insert_fast_tracepoints): Likewise.
4243 (may_stop): Likewise.
4244 (auto_connect_native_target): Likewise.
4245 (target_stop_and_wait): Update.
4246 (target_async_permitted): Change to bool.
4247 (target_async_permitted_1): Likewise.
4248 (may_write_registers_1): Likewise.
4249 (may_write_memory_1): Likewise.
4250 (may_insert_breakpoints_1): Likewise.
4251 (may_insert_tracepoints_1): Likewise.
4252 (may_insert_fast_tracepoints_1): Likewise.
4253 (may_stop_1): Likewise.
4254 * target.h (target_async_permitted): Likewise.
4255 (may_write_registers): Likewise.
4256 (may_write_memory): Likewise.
4257 (may_insert_breakpoints): Likewise.
4258 (may_insert_tracepoints): Likewise.
4259 (may_insert_fast_tracepoints): Likewise.
4260 (may_stop): Likewise.
4261 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4262 (make_thread_apply_all_options_def_group): Change argument from int*
4263 to bool*.
4264 (thread_apply_all_command): Update.
4265 (print_thread_events): Change to bool.
4266 * top.c (confirm): Likewise.
4267 (command_editing_p): Likewise.
4268 (history_expansion_p): Likewise.
4269 (write_history_p): Likewise.
4270 (info_verbose): Likewise.
4271 * top.h (confirm): Likewise.
4272 (history_expansion_p): Likewise.
4273 * tracepoint.c (disconnected_tracing): Likewise.
4274 (circular_trace_buffer): Likewise.
4275 * typeprint.c (print_methods): Likewise.
4276 (print_typedefs): Likewise.
4277 * utils.c (debug_timestamp): Likewise.
4278 (sevenbit_strings): Likewise.
4279 (pagination_enabled): Likewise.
4280 * utils.h (sevenbit_strings): Likewise.
4281 (pagination_enabled): Likewise.
4282 * valops.c (overload_resolution): Likewise.
4283 * valprint.h (struct value_print_options) <prettyformat_arrays,
4284 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4285 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4286 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4287 Likewise.
4288 * windows-nat.c (new_console): Likewise.
4289 (cygwin_exceptions): Likewise.
4290 (new_group): Likewise.
4291 (debug_exec): Likewise.
4292 (debug_events): Likewise.
4293 (debug_memory): Likewise.
4294 (debug_exceptions): Likewise.
4295 (useshell): Likewise.
4296 * windows-tdep.c (maint_display_all_tib): Likewise.
4297 * xml-support.c (debug_xml): Likewise.
4298
f1b620e9
MG
42992019-09-17 Mike Gulick <mgulick@mathworks.com>
4300
4301 * source.c (prepare_path_for_appending): New function.
4302 (openp): Make use of new function.
4303 (find_and_open_source): Search for the compilation directory and
4304 source file as a relative path beneath the directory search path.
4305
67f3ed6a
AB
43062019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4307
4308 * source-cache.c (source_cache::get_line_charpos): Catch
4309 exceptions and return false, this matches the behaviour documented
4310 in the header file.
4311
74332189
JB
43122019-09-17 Joel Brobecker <brobecker@adacore.com>
4313
4314 * ada-tasks.c (info_task): Remove quoting of the task's name.
4315
f2f24aa9
CB
43162019-09-16 Christian Biesinger <cbiesinger@google.com>
4317
4318 * symfile.c (auto_solib_add): Replace comment with a reference
4319 to the header file.
4320
6a062a93
CB
43212019-09-14 Christian Biesinger <cbiesinger@google.com>
4322
4323 * NEWS: Mention that gdb can now be compiled with Python 3
4324 on Windows.
4325
ec6c8338
AB
43262019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4327
4328 * maint.c (maint_print_section_data::maint_print_section_data):
4329 Force use of 'float log10 (float)' by casting the argument to
4330 float.
4331
aa17805f
AB
43322019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4333
4334 * maint.c: Add 'cmath' include.
4335 (struct maint_print_section_data): New structure.
4336 (print_section_index): New function.
4337 (print_bfd_section_info): Add header comment, small whitespace
4338 cleanup, and update to call new print_section_index function.
4339 (print_objfile_section_info): Likewise.
4340 (maint_obj_section_from_bfd_section): New function.
4341 (print_bfd_section_info_maybe_relocated): New function.
4342 (maintenance_info_sections): Add header comment, always use
4343 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4344
3dd9bb46
AB
43452019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4346
4347 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4348 inner scope, add check that the objfile has psymtabs before
4349 checking psymtabs_addrmap.
4350 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4351
4993045d
PW
43522019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4353
4354 * NEWS: Announce that Ada task names are now shown at more places,
4355 and between quotes (except in info task output).
4356 * gdb/ada-tasks.c (task_to_str): New function.
4357 (display_current_task_id): Call task_to_str.
4358 (task_command_1): Likewise.
4359 (print_ada_task_info): In non-mi mode, Properly align headers and data
4360 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4361
7a289707
RO
43622019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4363
4364 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4365 prstatus.pr_lwp.pr_info instead of making it up.
4366
f2aec7f6
CB
43672019-09-11 Christian Biesinger <cbiesinger@google.com>
4368
4369 * auto-load.c (auto_load_expand_dir_vars): Update.
4370 * defs.h (gdb_datadir): Change to std::string.
4371 (python_libdir): Likewise.
4372 (relocate_gdb_directory): Change return type to std::string.
4373 * guile/guile.c (gdbscm_data_directory): Update.
4374 (initialize_scheme_side): Update.
4375 * jit.c (jit_reader_dir): Change to std::string.
4376 (jit_reader_load_command): Update.
4377 * main.c (gdb_datadir): Change to std::string.
4378 (python_libdir): Likewise.
4379 (set_gdb_data_directory): Update.
4380 (relocate_path): Change to return std::string.
4381 (relocate_gdb_directory): Change to return std::string.
4382 (relocate_gdbinit_path_maybe_in_datadir): Update.
4383 (captured_main_1): Update.
4384 * python/python.c (do_start_initialization): Update.
4385 * top.c (show_gdb_datadir): Update.
4386 * xml-syscall.c (xml_init_syscalls_info): Update.
4387 (init_syscalls_info): Update.
4388
9224a013
CB
43892019-09-11 Christian Biesinger <cbiesinger@google.com>
4390
4391 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4392 out of get_init_files.
4393 (get_init_files): Update.
4394
f48cd836
CB
43952019-09-11 Christian Biesinger <cbiesinger@google.com>
4396
4397 * main.c (get_init_files): Change to use std::string.
4398 (captured_main_1): Update.
4399 (print_gdb_help): Update.
4400
9cab7ecd
AT
44012019-09-11 Ali Tamur <tamur@google.com>
4402
4403 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4404 implementation.
4405
67547d89
CB
44062019-09-11 Christian Biesinger <cbiesinger@google.com>
4407
4408 * dbxread.c (read_dbx_symtab): Update.
4409 * dwarf2read.c (load_partial_dies): Update.
4410 * mdebugread.c (parse_partial_symbols): Update.
4411 (handle_psymbol_enumerators): Update.
4412 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4413 * psymtab.c (add_psymbol_to_bcache): Likewise.
4414 (add_psymbol_to_list): Likewise.
4415 * symtab.c (symbol_set_names): Likewise.
4416 * symtab.h (symbol_set_names): Likewise.
4417 * xcoffread.c (scan_xcoff_symtab): Update.
4418
64b2d4a0
TT
44192019-09-11 Tom Tromey <tom@tromey.com>
4420
4421 * symfile-mem.c (symbol_file_add_from_memory): Use
4422 bfd_set_filename.
4423 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4424 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4425
3b00ef10
TT
44262019-09-10 Tom Tromey <tromey@adacore.com>
4427
4428 * dwarf-index-write.c (write_psymbols): Extend error message.
4429 (debug_names::insert): Add Ada code.
4430 (debug_names::write_psymbols): Remove Ada check.
4431 (debug_names) <m_string_obstack>: New member.
4432 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4433 (gdb_index_symbol_name_matcher::matches): Remove.
4434 (mapped_index_base::find_name_components_bounds): Add "lang"
4435 parameter.
4436 (mapped_index_base::build_name_components): Also split names
4437 according to Ada syntax.
4438 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4439 type of "match_callback".
4440 (check_match, check_find_bounds_finds)
4441 (dw2_expand_symtabs_matching): Update.
4442 (dw2_debug_names_iterator): Add new constructor.
4443 (dw2_debug_names_map_matching_symbols): New function.
4444 (dw2_debug_names_expand_symtabs_matching): Update.
4445 (dwarf2_debug_names_functions): Use
4446 dw2_debug_names_map_matching_symbols.
4447
aa391654
TT
44482019-09-10 Tom Tromey <tromey@adacore.com>
4449
4450 * dwarf2read.c (dw2_get_file_names_reader): Add the
4451 CU's file name to the results.
4452
b054970d
TT
44532019-09-10 Tom Tromey <tromey@adacore.com>
4454
4455 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4456 map_matching_symbols. Update.
4457 * dwarf2read.c (dw2_map_matching_symbols): Update.
4458 * psymtab.c (match_partial_symbol): Change type; update.
4459 (psym_map_matching_symbols): Likewise.
4460 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4461 type; update.
4462 * symfile.h (struct quick_symbol_functions)
4463 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4464 Remove "match".
4465
6a3dbf1b
TT
44662019-09-10 Tom Tromey <tromey@adacore.com>
4467
4468 * psymtab.c (map_block): Remove.
4469 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4470 * symtab.c (iterate_over_symbols_terminated): New function.
4471 * symtab.c (iterate_over_symbols_terminated): Declare.
4472
6969f124
TT
44732019-09-10 Tom Tromey <tromey@adacore.com>
4474
4475 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4476 * language.h (struct language_defn) <la_iterate_over_symbols>:
4477 Return bool.
4478 * symtab.c (iterate_over_symbols): Return bool.
4479 * symtab.h (iterate_over_symbols): Return bool.
4480
199b4314
TT
44812019-09-10 Tom Tromey <tromey@adacore.com>
4482
4483 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4484 (add_nonlocal_symbols): Update.
4485 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4486 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4487 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4488 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4489 Change type of "callback". Remove "data".
4490
a084a2a6
AT
4491
44922019-09-09 Ali Tamur <tamur@google.com>
4493
4494 * dwarf2read.c (comp_unit_head): Update comment.
4495 (dwarf2_dwo_name): New function declaration.
4496 (dwarf_unit_type_name): New function declaration.
4497 (read_comp_unit_head): Add support for new compilation units,
4498 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4499 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4500 (currently named as "signature") in their header. Also clarify error
4501 messages.
4502 (lookup_dwo_id): New function. Returns the dwo id of the given
4503 compile unit.
4504 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4505 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4506 functions.
4507 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4508 (dwarf2_dwo_name): Get the dwo name if present.
4509 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4510 purposes.
4511
25a2915e
TT
45122019-09-09 Tom Tromey <tom@tromey.com>
4513
4514 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4515
e4df0874
PW
45162019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4517
4518 * python/python.c (do_start_initialization): Make progname_copy static,
4519 to avoid a leak report.
4520
8634b462
TT
45212019-09-08 Tom Tromey <tom@tromey.com>
4522
4523 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4524
c7f839cb
SM
45252019-09-07 Simon Marchi <simon.marchi@efficios.com>
4526
4527 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4528 Change type to gdb::optional<block_enum>.
4529 (dw2_symtab_iter_init): Change block_index parameter type
4530 to gdb::optional<block_enum>.
4531 (dw2_lookup_symbol): Change block_index parameter
4532 type to block_enum.c
4533 (dw2_debug_names_lookup_symbol): Likewise.
4534 * psymtab.c (psym_lookup_symbol): Likewise.
4535 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4536 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4537 Likewise.
4538
ead0e69a
CB
45392019-09-06 Christian Biesinger <cbiesinger@google.com>
4540
4541 * defs.h (relocate_gdb_directory): Change int to bool in
4542 signature and rename flag to relocatable.
4543 * main.c (relocate_path): Likewise.
4544 (relocate_gdb_directory): Likewise.
4545
b16c44de
AM
45462019-09-06 Alan Modra <amodra@gmail.com>
4547
4548 * coffread.c (coff_symfile_read): Constify filename variable.
4549 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4550 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4551 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4552 * solib.c (reload_shared_libraries_1): Likewise.
4553 * symfile.c (reread_symbols): Likewise.
4554 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4555 * solib-darwin.c (darwin_bfd_open): Likewise.
4556 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4557
06ff036e
AB
45582019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4559
4560 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4561 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4562
4e962e74
TT
45632019-09-03 Tom Tromey <tromey@adacore.com>
4564
4565 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4566 types.
4567 (has_negatives): Unbias a range type bound.
4568 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4569 * gdbtypes.c (operator==): Handle new field.
4570 (create_range_type): Add "bias" parameter.
4571 (create_static_range_type, resolve_dynamic_range): Update.
4572 * gdbtypes.h (struct range_bounds) <bias>: New member.
4573 (create_range_type): Add bias parameter.
4574 * printcmd.c (print_scalar_formatted): Unbias range types.
4575 * value.c (unpack_long): Unbias range types.
4576 (pack_long): Bias range types.
4577
d90b8f26
AH
45782019-09-02 Alan Hayward <alan.hayward@arm.com>
4579
4580 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4581 probe arguments.
4582
fe01123e
AH
45832019-09-02 Alan Hayward <alan.hayward@arm.com>
4584
4585 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4586 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4587 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4588 (compile_probe_arg): Likewise.
4589 * probe.h (get_argument_count): Likewise.
4590 * solib-svr4.c (solib_event_probe_action): Likewise.
4591 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4592
e661ef01
AH
45932019-09-02 Alan Hayward <alan.hayward@arm.com>
4594
4595 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4596 code to here...
4597 (svr4_create_solib_event_breakpoints): ...from here.
4598
47a536d9
SDJ
45992019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4600
4601 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4602 suffix from warning message.
4603
d6a00eba
TT
46042019-08-30 Tom Tromey <tom@tromey.com>
4605
4606 * tui/tui-winsource.h (struct tui_source_window_base)
4607 <refresh_all>: Don't declare.
4608 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4609 Remove.
4610 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4611 tui_show_locator_content.
4612 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4613 declare.
4614 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4615 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4616 declare.
4617
55b2657b
TT
46182019-08-30 Tom Tromey <tom@tromey.com>
4619
4620 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4621
12a8555a
TT
46222019-08-30 Tom Tromey <tom@tromey.com>
4623
4624 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4625 Remove unnecessary forward declarations.
4626
900ac242
TT
46272019-08-30 Tom Tromey <tom@tromey.com>
4628
4629 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4630 rerender.
4631 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4632 tui_show_locator_content.
4633
99ab33fb
TT
46342019-08-30 Tom Tromey <tom@tromey.com>
4635
4636 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4637 (tui_locator_window::rerender): Rewrite using body of previous
4638 tui_show_locator_content.
4639
e594a5d1
TT
46402019-08-30 Tom Tromey <tom@tromey.com>
4641
4642 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4643 set_locator_fullname>: New methods.
4644 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4645 Rename from tui_set_locator_fullname.
4646 (tui_locator_window::set_locator_info): Rename from
4647 tui_set_locator_info. Return bool.
4648 (tui_update_locator_fullname, tui_show_frame_info): Update.
4649
715bb467
TT
46502019-08-30 Tom Tromey <tom@tromey.com>
4651
4652 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4653
772f3f03
TT
46542019-08-30 Tom Tromey <tom@tromey.com>
4655
4656 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4657 call touchwin.
4658
108e13ab
TT
46592019-08-30 Tom Tromey <tom@tromey.com>
4660
4661 * tui/tui-wingeneral.c (box_win): Assume win_info and
4662 win_info->handle cannot be NULL.
4663
cdaa6eb4
TT
46642019-08-30 Tom Tromey <tom@tromey.com>
4665
4666 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4667 refresh_window>: Declare.
4668 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4669 resize.
4670 (tui_data_item_window::rerender): Rename from
4671 tui_display_register.
4672 (tui_data_item_window::refresh_window): New method.
4673 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4674 no-op.
4675
89df7f90
TT
46762019-08-30 Tom Tromey <tom@tromey.com>
4677
4678 * tui/tui-regs.h (struct tui_data_window) <regs_content,
4679 regs_column_count, current_group>: Move later. Now private.
4680 <get_current_group>: New method.
4681 * tui/tui-regs.c (tui_reg_command): Update.
4682 * tui/tui-layout.c (tui_set_layout): Update.
4683
1bf2866a
TT
46842019-08-30 Tom Tromey <tom@tromey.com>
4685
4686 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4687 (tui_data_window::rerender): Don't call
4688 check_and_display_highlight_if_needed.
4689 (tui_data_window::refresh_all): Remove call to
4690 erase_data_content.
4691
0670413d
TT
46922019-08-30 Tom Tromey <tom@tromey.com>
4693
4694 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4695 (tui_data_window::display_registers_from)
4696 (tui_data_window::display_reg_element_at_line)
4697 (tui_data_window::display_registers_from_line): Remove checks of
4698 "empty".
4699
18bb55c7
TT
47002019-08-30 Tom Tromey <tom@tromey.com>
4701
4702 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4703 Don't declare.
4704 * tui/tui-regs.c (tui_data_window::show_registers): Call
4705 rerender.
4706 (tui_data_window::rerender): Rename from display_all_data.
4707 (tui_data_window::rerender): Remove old implementation.
4708
1f6d2f10
TT
47092019-08-30 Tom Tromey <tom@tromey.com>
4710
4711 * tui/tui-regs.c (tui_data_window::display_all_data): Change
4712 text.
4713 * tui/tui-data.h (NO_DATA_STRING): Remove define.
4714
16d01f9c
BW
47152019-08-29 Bernhard Wodok <barto@gmx.net>
4716 Sergio Durigan Junior <sergiodj@redhat.com>
4717
4718 PR win32/24284
4719 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4720
d8f27c60
AB
47212019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4722
4723 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4724 when searching for types.
4725
1f20c35e
AB
47262019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4727
4728 * f-lang.c (f_language_defn): Use f_print_typedef.
4729 * f-lang.h (f_print_typedef): Declare.
4730 * f-typeprint.c (f_print_typedef): Define.
4731
550105b7
CB
47322019-08-27 Christian Biesinger <cbiesinger@google.com>
4733
4734 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4735
4acfdd20
AB
47362019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
4737
4738 * cli/cli-utils.c (info_print_options_defs): Delete.
4739 (make_info_print_options_def_group): Delete.
4740 (extract_info_print_options): Delete.
4741 (info_print_command_completer): Delete.
4742 (info_print_args_help): Add extra parameter, and optionally
4743 include text about -n flag.
4744 * cli/cli-utils.h (struct info_print_options): Delete.
4745 (extract_info_print_options): Delete declaration.
4746 (info_print_command_completer): Delete declaration.
4747 (info_print_args_help): Add extra parameter, extend header
4748 comment.
4749 * python/python.c (gdbpy_rbreak): Pass additional parameter to
4750 search_symbols.
4751 * stack.c (struct info_print_options): New type.
4752 (info_print_options_defs): New file scoped variable.
4753 (make_info_print_options_def_group): New static function.
4754 (info_print_command_completer): New static function.
4755 (info_locals_command): Update to use new local functions.
4756 (info_args_command): Likewise.
4757 (_initialize_stack): Add extra parameter to calls to
4758 info_print_args_help.
4759 * symtab.c (search_symbols): Add extra parameter, use this to
4760 possibly excluse non-debug symbols.
4761 (symtab_symbol_info): Add extra parameter, which is passed on to
4762 search_symbols.
4763 (struct info_print_options): New type.
4764 (info_print_options_defs): New file scoped variable.
4765 (make_info_print_options_def_group): New static function.
4766 (info_print_command_completer): New static function.
4767 (info_variables_command): Update to use local functions, and pass
4768 extra parameter through to symtab_symbol_info.
4769 (info_functions_command): Likewise.
4770 (info_types_command): Pass additional argument through to
4771 symtab_symbol_info.
4772 (rbreak_command): Pass extra argument to search_symbols.
4773 (_initialize_symtab): Add extra arguments for calls to
4774 info_print_args_help, and update help text for 'info variables',
4775 'whereis', and 'info functions' commands.
4776 * symtab.h (search_symbols): Add extra argument to declaration.
4777 * NEWS: Mention new flags.
4778
9aa55206
CB
47792019-08-26 Christian Biesinger <cbiesinger@google.com>
4780
4781 * symtab.c (lookup_static_symbol): Call the new function (and move
4782 it down to be next to lookup_global_symbol).
4783 (struct global_sym_lookup_data): Add block_enum member and rename to...
4784 (struct global_or_static_sym_lookup_data): ...this.
4785 (lookup_symbol_global_iterator_cb): Pass block_index instead of
4786 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4787 (lookup_symbol_global_or_static_iterator_cb): ...this.
4788 (lookup_global_or_static_symbol): New function.
4789 (lookup_global_symbol): Call new function.
4790
5c31b358
TV
47912019-08-26 Tom de Vries <tdevries@suse.de>
4792
4793 PR c++/24852
4794 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4795 when pc_probe.prob == NULL.
4796
23c13d42
SM
47972019-08-25 Simon Marchi <simon.marchi@efficios.com>
4798
4799 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4800 variable symbol_linkage to symbol_linkage_.
4801
beadd3e8
SM
48022019-08-25 Simon Marchi <simon.marchi@efficios.com>
4803
4804 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4805 represent whether the symbol is static, dynamic, or we don't
4806 know.
4807
e3ec872f
YS
48082019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
4809
4810 * gdb/rx-tdep.c (rx_register_names): New.
4811 (rx_register_name): Delete.
4812 (rx_psw_type): Delete.
4813 (rx_fpsw_type): Delete.
4814 (rx_register_type): Delete.
4815 (rx_gdbarch_init): Convert target-descriptions.
4816 (_initialize_rx_tdep): Add initialize_tdesc_rx.
4817 * gdb/features/Makefile: Add rx.xml.
4818 * gdb/features/rx.xml: New.
4819 * gdb/features/rx.c: Generated.
4820 * gdb/NEWS: Mention target description support.
4821
d0509ba4
CB
48222019-08-22 Christian Biesinger <cbiesinger@google.com>
4823
4824 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4825 *slot_ptr.
4826
2d41fa11
SDJ
48272019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
4828
4829 * configure.ac: Don't check for 'dlfcn.h' (moved to
4830 gdbsupport/common.m4).
4831 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4832 'gdbsupport/'.
4833 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4834 * compile/compile-c-support.c: Include
4835 'gdbsupport/gdb-dlfcn.h'.
4836 * gdbsupport/common.m4: Check for 'dlfcn.h'.
4837 * gdb-dlfcn.c: Move to...
4838 * gdbsupport/gdb-dlfcn.c: ... here.
4839 * gdb-dlfcn.h: Move to...
4840 * gdbsupport/gdb-dlfcn.h: ... here.
4841
de8af808
SL
48422019-08-23 Sandra Loosemore <sandra@codesourcery.com>
4843
4844 * nios2-tdep.c (struct reg_value): Improve comments. Make
4845 the offset field signed.
4846
27204489
CB
48472019-08-22 Christian Biesinger <cbiesinger@google.com>
4848
4849 * python/lib/gdb/__init__.py (_execute_file): New function.
4850 * python/python.c (python_run_simple_file): Call gdb._execute_file
4851 on Windows.
4852
43771869
AB
48532019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
4854
4855 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4856 all uses as this was never set to anything but a zero value.
4857
26c957f1
PA
48582019-08-21 Bogdan Harjoc <harjoc@gmail.com>
4859
4860 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4861
c07aae6e
CB
48622019-08-21 Christian Biesinger <cbiesinger@google.com>
4863
4864 * tui/tui-data.h (tui_gen_win_info): Add an =default
4865 move constructor, required by some GCC versions.
4866
3960cb7a
JF
48672019-08-21 Jinke Fan <fanjinke51@yeah.net>
4868
4869 * go32-nat.c (go32_sysinfo): Add hygon_p.
4870
04c72a68
TT
48712019-08-20 Tom Tromey <tom@tromey.com>
4872
4873 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4874 line_from_reg_element_no, first_reg_element_no_inline,
4875 display_all_data, delete_data_content_windows,
4876 erase_data_content>: Now private.
4877
072272ce
TT
48782019-08-20 Tom Tromey <tom@tromey.com>
4879
4880 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4881 (tui_unhighlight_win, tui_highlight_win)
4882 (tui_win_info::make_window): Update.
4883 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4884
973961bd
TT
48852019-08-20 Tom Tromey <tom@tromey.com>
4886
4887 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4888 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4889 (MAX_PID_WIDTH): Move to tui-stack.c.
4890 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4891 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4892 (MAX_PID_WIDTH): Move from tui-data.h.
4893
ab0e1f1a
TT
48942019-08-20 Tom Tromey <tom@tromey.com>
4895
4896 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4897 * tui/tui-wingeneral.c (box_win): Change type of win_info.
4898 (box_win): Update.
4899 (tui_gen_win_info::make_window): Rename from tui_make_window.
4900 (tui_win_info::make_window): New method.
4901 (tui_gen_win_info::make_visible): Update.
4902 * tui/tui-source.c (tui_source_window::set_contents): Update.
4903 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4904 (tui_data_window::display_registers_from): Update.
4905 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4906 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4907 Declare.
4908 <can_box>: Remove.
4909 <title>: Remove.
4910 (struct tui_win_info) <make_window>: Declare.
4911 <can_box>: Now virtual.
4912 <title>: New member.
4913 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4914 * tui/tui-command.c (tui_cmd_window::resize): Update.
4915
100c2bf3
TT
49162019-08-20 Tom Tromey <tom@tromey.com>
4917
4918 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4919 * tui/tui-regs.c (tui_data_window::show_registers): Update.
4920 (tui_data_window::check_register_values): Update.
4921
fa4dc567
TT
49222019-08-20 Tom Tromey <tom@tromey.com>
4923
4924 * tui/tui-regs.h (struct tui_data_window): Use
4925 DISABLE_COPY_AND_ASSIGN.
4926 <regs_content>: Change type, removing unique_ptr.
4927 <tui_data_window>: Add move constructor.
4928 * tui/tui-regs.c (tui_data_window::show_registers)
4929 (tui_data_window::show_register_group)
4930 (tui_data_window::display_registers_from)
4931 (tui_data_window::display_registers_from)
4932 (tui_data_window::first_data_item_displayed)
4933 (tui_data_window::delete_data_content_windows)
4934 (tui_data_window::rerender, tui_data_window::refresh_window)
4935 (tui_data_window::check_register_values): Update.
4936
ca02d7c8
TT
49372019-08-20 Tom Tromey <tom@tromey.com>
4938
4939 * tui/tui-regs.h (struct tui_data_window) <show_registers,
4940 show_register_group>: Declare.
4941 (tui_show_register_group): Don't declare.
4942 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4943 tui_show_registers.
4944 (tui_data_window::show_register_group): Rename from
4945 tui_show_register_group.
4946 (tui_data_window::check_register_values, tui_reg_command):
4947 Update.
4948 * tui/tui-layout.c (tui_set_layout): Update.
4949
63356bfd
TT
49502019-08-20 Tom Tromey <tom@tromey.com>
4951
4952 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4953 Declare.
4954 (tui_check_register_values): Don't declare.
4955 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4956 from tui_check_register_values.
4957 * tui/tui-hooks.c (tui_register_changed): Update.
4958
42cc14a7
TT
49592019-08-20 Tom Tromey <tom@tromey.com>
4960
4961 * tui/tui-regs.c (tui_reg_layout): Move later.
4962 (tui_show_registers): Don't enable TUI mode or change layout.
4963
b9ad3686
TT
49642019-08-20 Tom Tromey <tom@tromey.com>
4965
4966 * tui/tui-regs.h (struct tui_data_item_window)
4967 <~tui_data_item_window>: Remove.
4968 <content>: Now a unique_xmalloc_ptr.
4969 * tui/tui-regs.c (tui_register_format): Return a
4970 unique_xmalloc_ptr.
4971 (tui_get_register): Update.
4972 (~tui_data_item_window): Remove.
4973 (tui_data_window::display_registers_from, tui_display_register):
4974 Update.
4975 * tui/tui-io.h (tui_expand_tabs): Update.
4976 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4977 Remove "col" parameter.
4978
8e114aab
TT
49792019-08-20 Tom Tromey <tom@tromey.com>
4980
4981 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4982 field.
4983 * tui/tui-regs.c (~tui_data_item_window): Update.
4984
1a4f81dd
TT
49852019-08-20 Tom Tromey <tom@tromey.com>
4986
4987 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4988 earlier.
4989
0f8d8876
TT
49902019-08-20 Tom Tromey <tom@tromey.com>
4991
4992 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4993
605dc2c2
TT
49942019-08-20 Tom Tromey <tom@tromey.com>
4995
4996 * tui/tui-source.h (struct tui_source_window): Update.
4997 * tui/tui-regs.c (tui_show_registers): Update.
4998 * tui/tui-disasm.h (struct tui_disasm_window): Update.
4999 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5000 (NO_REGS_STRING): Remove defines.
5001
aedbe3bb
CM
50022019-08-20 Conrad Meyer <cem@FreeBSD.org>
5003
5004 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5005 unnecessary thread walk if remote doesn't support the packet.
5006
7ce8f214
TT
50072019-08-19 Tom Tromey <tromey@adacore.com>
5008
5009 * python/py-value.c (value_has_field): Fix indentation.
5010
f21c2bd7
TT
50112019-08-19 Tom Tromey <tromey@adacore.com>
5012
5013 * printcmd.c (do_one_display, info_display_command): Update.
5014 * block.h (contained_in): Return bool. Add allow_nested
5015 parameter.
5016 * block.c (contained_in): Return bool. Add allow_nested
5017 parameter.
5018
d806ea2d
TT
50192019-08-19 Tom Tromey <tom@tromey.com>
5020
5021 * configure: Rebuild.
5022 * configure.ac: Disallow the combination of -static-libstdc++ and
5023 source highlight.
5024 * source-cache.c (get_language_name): Handle rust.
5025 (source_cache::get_source_lines): Ignore highlighting exceptions.
5026
398fdd60
TT
50272019-08-16 Tom Tromey <tom@tromey.com>
5028
5029 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5030 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5031 (struct tui_source_window_base) <make_visible, refresh_window,
5032 resize>: Remove methods.
5033 <execution_info>: Remove field.
5034 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5035 (tui_show_source_line, tui_source_window_base)
5036 (~tui_source_window_base): Update.
5037 (tui_source_window_base::resize)
5038 (tui_source_window_base::make_visible)
5039 (tui_source_window_base::refresh_window): Remove.
5040 (tui_source_window_base::update_exec_info): Update.
5041 * tui/tui-source.c (tui_source_window::set_contents): Update.
5042 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5043
e699d331
TT
50442019-08-16 Tom Tromey <tom@tromey.com>
5045
5046 * tui/tui-hooks.c (tui_remove_hooks): Don't set
5047 deprecated_query_hook.
5048
bb01dbfc
TT
50492019-08-16 Tom Tromey <tom@tromey.com>
5050
5051 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5052 (tui_update_source_windows_with_line): Update.
5053 * tui/tui-source.h (struct tui_source_window)
5054 <show_symtab_source>: Declare.
5055 (tui_show_symtab_source): Don't declare.
5056 * tui/tui-source.c (tui_show_symtab_source): Rename from
5057 tui_show_symtab_source.
5058
81c82c4b
TT
50592019-08-16 Tom Tromey <tom@tromey.com>
5060
5061 * tui/tui-winsource.h (struct tui_source_window_base)
5062 <set_contents>: Declare.
5063 * tui/tui-winsource.c
5064 (tui_source_window_base::update_source_window_as_is): Update.
5065 * tui/tui-source.h (struct tui_source_window) <set_contents>:
5066 Declare.
5067 (tui_set_source_content): Don't declare.
5068 * tui/tui-source.c (tui_source_window::set_contents): Rename from
5069 tui_set_source_content.
5070 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5071 Declare.
5072 (tui_set_disassem_content): Don't declare.
5073 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5074 tui_set_disassem_content.
5075
2ddaf614
TT
50762019-08-16 Tom Tromey <tom@tromey.com>
5077
5078 * tui/tui-winsource.h (struct tui_source_window_base)
5079 <update_breakpoint_info>: Declare.
5080 (tui_update_breakpoint_info): Don't declare.
5081 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5082 (tui_update_all_breakpoint_info): Update.
5083 (tui_source_window_base::update_breakpoint_info): Rename from
5084 tui_update_breakpoint_info.
5085 (tui_source_window_base::update_exec_info): Update.
5086
017f9828
TT
50872019-08-16 Tom Tromey <tom@tromey.com>
5088
5089 * tui/tui-winsource.h (struct tui_source_window_base)
5090 <update_source_window>: Declare.
5091 (tui_update_source_window): Don't declare.
5092 * tui/tui-winsource.c
5093 (tui_source_window_base::update_source_window): Rename from
5094 tui_update_source_window.
5095 (tui_source_window_base::rerender): Update.
5096 * tui/tui-source.c (tui_source_window::maybe_update): Update.
5097 * tui/tui-disasm.c (tui_show_disassem)
5098 (tui_show_disassem_and_update_source)
5099 (tui_disasm_window::maybe_update): Update.
5100
ed8358e9
TT
51012019-08-16 Tom Tromey <tom@tromey.com>
5102
5103 * tui/tui-winsource.h (struct tui_source_window_base)
5104 <update_source_window_as_is>: Declare.
5105 (tui_update_source_window_as_is): Don't declare.
5106 * tui/tui-winsource.c (tui_update_source_window): Update
5107 (tui_source_window_base::update_source_window_as_is): Rename from
5108 tui_update_source_window_as_is.
5109 (tui_source_window_base::refill): Update.
5110 * tui/tui-source.c (tui_show_symtab_source): Update.
5111 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5112 Update.
5113
20149b6b
TT
51142019-08-16 Tom Tromey <tom@tromey.com>
5115
5116 * tui/tui-winsource.h (tui_update_source_window)
5117 (tui_update_source_window_as_is): Remove "noerror" parameter.
5118 * tui/tui-winsource.c (tui_update_source_window)
5119 (tui_update_source_window_as_is): Remove "noerror" parameter.
5120 (tui_update_source_windows_with_addr)
5121 (tui_update_source_windows_with_line)
5122 (tui_source_window_base::rerender)
5123 (tui_source_window_base::refill): Update.
5124 * tui/tui-source.h (tui_set_source_content)
5125 (tui_show_symtab_source): Remove "noerror" parameter.
5126 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5127 parameter.
5128 (tui_show_symtab_source): Likewise.
5129 (tui_source_window::maybe_update): Update.
5130 * tui/tui-disasm.c (tui_show_disassem)
5131 (tui_show_disassem_and_update_source)
5132 (tui_disasm_window::do_scroll_vertical)
5133 (tui_disasm_window::maybe_update): Update.
5134
2d83e710
TT
51352019-08-16 Tom Tromey <tom@tromey.com>
5136
5137 * tui/tui.c (tui_is_window_visible): Update.
5138 * tui/tui-wingeneral.c (tui_make_window)
5139 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5140 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5141 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5142 (tui_set_win_height_command, parse_scrolling_args): Update.
5143 * tui/tui-source.c (tui_source_window::style_changed): Update.
5144 * tui/tui-regs.c (tui_show_registers)
5145 (tui_data_window::first_data_item_displayed)
5146 (tui_data_window::delete_data_content_windows)
5147 (tui_check_register_values, tui_reg_command): Update.
5148 * tui/tui-disasm.c (tui_show_disassem): Update.
5149 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5150 method.
5151 <is_visible>: Remove field.
5152 * tui/tui-data.c (tui_next_win, tui_prev_win)
5153 (tui_delete_invisible_windows): Update.
5154
d4ab829a
TT
51552019-08-16 Tom Tromey <tom@tromey.com>
5156
5157 * tui/tui-winsource.h (struct tui_source_window_base)
5158 <m_has_locator>: Remove.
5159 * tui/tui-layout.c (show_source_disasm_command, show_data)
5160 (show_source_or_disasm_and_command): Update.
5161
aa7ca1bb
AH
51622019-08-16 Alan Hayward <alan.hayward@arm.com>
5163
5164 * NEWS (Other MI changes): New subsection.
5165 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5166 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5167 * arch-utils.c (default_get_pc_address_flags): New function.
5168 * arch-utils.h (default_get_pc_address_flags): New declaration.
5169 * gdbarch.sh: Add get_pc_address_flags.
5170 * gdbarch.c: Regenerate.
5171 * gdbarch.h: Likewise.
5172 * stack.c (print_pc): New function.
5173 (print_frame_info) (print_frame): Call print_pc.
5174
6eac171f
TV
51752019-08-16 Tom de Vries <tdevries@suse.de>
5176
5177 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5178 print_objfile_section_info.
5179
3df505f6
TT
51802019-08-15 Tom Tromey <tom@tromey.com>
5181
5182 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5183 calling update_cmdwin_start_line.
5184 * tui/tui-winsource.h (struct tui_source_window_base)
5185 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5186 <rerender>: Declare.
5187 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5188 Call rerender.
5189 (tui_source_window_base::set_new_height): Remove.
5190 (tui_source_window_base::rerender): Rename from
5191 do_make_visible_with_new_height.
5192 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5193 resize method.
5194 (tui_win_info::make_invisible_and_set_new_height)
5195 (tui_win_info::make_visible_with_new_height): Remove.
5196 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5197 Declare.
5198 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5199 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5200 do_make_visible_with_new_height>: Don't declare.
5201 <rerender>: Declare.
5202 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5203 set_new_height.
5204 (tui_data_window::do_make_visible_with_new_height): Remove.
5205 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5206 call tui_show_locator_content.
5207 (tui_gen_win_info::resize): Call rerender.
5208 (show_source_or_disasm_and_command): Don't call
5209 tui_show_locator_content.
5210 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5211 method.
5212 (struct tui_win_info) <rerender>: Declare.
5213 <set_new_height, make_invisible_and_set_new_height,
5214 make_visible_with_new_height>: Don't declare.
5215 * tui/tui-data.c (tui_win_list::rerender): New method.
5216 * tui/tui-command.h (struct tui_cmd_window)
5217 <do_make_visible_with_new_height>: Don't declare.
5218 * tui/tui-command.c
5219 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5220
272560b5
TT
52212019-08-15 Tom Tromey <tromey@adacore.com>
5222
5223 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5224 * ada-lang.c (ada_enum_name): Likewise.
5225
08235187
CB
52262019-08-15 Christian Biesinger <cbiesinger@google.com>
5227
5228 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5229 leading underscore.
5230 (GdbOutputErrorFile): Likewise.
5231 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5232 accordingly.
5233 (execute_unwinders): Rename to have a leading underscore.
5234 (auto_load_packages): Likewise.
5235 (global scope): Adjust call to auto_load_packages accordingly.
5236 (GdbSetPythonDirectory): Likewise.
5237 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5238 instead of execute_unwinders.
5239
db502012
TT
52402019-08-15 Tom Tromey <tom@tromey.com>
5241
5242 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5243 (show_data): Don't change window visibility.
5244 (tui_gen_win_info::resize): Remove special case for command
5245 window. Use wresize, when available.
5246 (show_source_or_disasm_and_command): Don't change window
5247 visibility.
5248 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5249 <make_visible>: New method.
5250 * tui/tui-command.c (tui_cmd_window::resize): New method.
5251
3891b65e
TT
52522019-08-15 Tom Tromey <tom@tromey.com>
5253
5254 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5255 (struct tui_source_windows): New.
5256 * tui/tui-winsource.c (tui_display_main): Update.
5257 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5258 (new_height_ok, parse_scrolling_args): Update.
5259 * tui/tui-layout.c (show_layout, show_data): Update.
5260 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5261 (tui_add_to_source_windows): Don't declare.
5262 * tui/tui-data.c (source_windows, tui_source_windows)
5263 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5264
ee556432
TT
52652019-08-15 Tom Tromey <tom@tromey.com>
5266
5267 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5268 Rename from reset.
5269 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5270 * tui/tui-layout.c (show_source_disasm_command, show_data):
5271 Update.
5272 (tui_gen_win_info::resize): Rename.
5273 (show_source_or_disasm_and_command): Update.
5274 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5275 reset.
5276
46f438e3
TT
52772019-08-15 Tom Tromey <tom@tromey.com>
5278
5279 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5280 * tui/tui-interp.c (tui_interp::init): Don't call
5281 tui_initialize_static_data.
5282 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5283
f4ce562c
TT
52842019-08-15 Tom Tromey <tom@tromey.com>
5285
5286 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5287 examine tui_win_list.
5288
c398c3d0
TT
52892019-08-15 Tom Tromey <tom@tromey.com>
5290
5291 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5292 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5293 tui_clear_source_content.
5294 (tui_clear_source_content): Remove.
5295 (tui_source_window_base::do_erase_source_content): Hoist call to
5296 content.clear().
5297 * tui/tui-stack.c (tui_show_frame_info): Don't call
5298 tui_clear_source_content.
5299
e25d2004
TT
53002019-08-15 Tom Tromey <tom@tromey.com>
5301
5302 * tui/tui-winsource.h (struct tui_source_window_base)
5303 <do_erase_source_content>: New method.
5304 <erase_source_content>: New method.
5305 (tui_erase_source_content): Don't declare.
5306 * tui/tui-winsource.c (tui_clear_source_content): Update.
5307 (tui_source_window_base::do_erase_source_content): Rename from
5308 tui_erase_source_content.
5309 (tui_source_window_base::show_source_content): Update.
5310 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5311 * tui/tui-source.h (struct tui_source_window)
5312 <erase_source_content>: New method.
5313 * tui/tui-disasm.h (struct tui_disasm_window)
5314 <erase_source_content>: New method.
5315
002f15c2
TT
53162019-08-15 Tom Tromey <tom@tromey.com>
5317
5318 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5319 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5320 constructor.
5321 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5322 * tui/tui-source.c (tui_set_source_content): Update.
5323 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5324
c9033fe8
TT
53252019-08-15 Tom Tromey <tom@tromey.com>
5326
5327 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5328 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5329 tui-source.c.
5330 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5331 Declare.
5332 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5333 method.
5334 (tui_source_window::maybe_update): Update.
5335
088f37dd
TT
53362019-08-15 Tom Tromey <tom@tromey.com>
5337
5338 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5339 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5340 tui-disasm.c.
5341 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5342 Declare.
5343 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5344 method.
5345 (tui_disasm_window::maybe_update): Update.
5346
a54700c6
TT
53472019-08-15 Tom Tromey <tom@tromey.com>
5348
5349 * tui/tui-winsource.h (struct tui_source_window_base)
5350 <maybe_update>: Declare.
5351 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5352 method.
5353 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5354 Declare.
5355 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5356 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5357 Declare.
5358 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5359
e2a678a5
TT
53602019-08-15 Tom Tromey <tom@tromey.com>
5361
5362 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5363
f2dda477
TT
53642019-08-15 Tom Tromey <tom@tromey.com>
5365
5366 * tui/tui-wingeneral.c: Include tui-stack.h.
5367 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5368 (struct tui_locator_window): Move from tui-data.h.
5369 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5370 (tui_initialize_static_data): Move from tui-data.c.
5371 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5372 (struct tui_locator_window): Move to tui-stack.c.
5373 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5374 (tui_initialize_static_data): Move to tui-stack.c.
5375
ed4a1084
TT
53762019-08-15 Tom Tromey <tom@tromey.com>
5377
5378 * tui/tui-layout.c (show_source_disasm_command)
5379 (show_source_or_disasm_and_command): Use make_visible method, not
5380 tui_make_window.
5381 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5382 Remove.
5383
65962b20
TT
53842019-08-15 Tom Tromey <tom@tromey.com>
5385
5386 * tui/tui-wingeneral.h (tui_make_window): Update.
5387 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5388 parameter.
5389 (tui_gen_win_info::make_visible): Update.
5390 * tui/tui-regs.c (tui_data_window::display_registers_from):
5391 Update.
5392 * tui/tui-layout.c (show_source_disasm_command)
5393 (show_source_or_disasm_and_command): Update.
5394 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5395 (enum tui_box): Remove.
5396 (struct tui_win_info) <can_box>: New method.
5397 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5398 method.
5399
2208ee91
TV
54002019-08-15 Tom de Vries <tdevries@suse.de>
5401
5402 * linux-nat-trad.c: Include gdbarch.h.
5403
75faf5c4
AH
54042019-08-14 Alan Hayward <alan.hayward@arm.com>
5405
5406 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5407 register sizes.
5408
b1c896b3
TT
54092019-08-14 Tom Tromey <tromey@adacore.com>
5410
5411 * darwin-nat.c: Include gdbarch.h.
5412 * darwin-nat-info.c: Include gdbarch.h.
5413
6405cd73
TT
54142019-08-13 Tom Tromey <tom@tromey.com>
5415
5416 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5417 Remove.
5418 * tui/tui-data.c (tui_initialize_static_data): Update.
5419
5216580d
TT
54202019-08-13 Tom Tromey <tom@tromey.com>
5421
5422 * tui/tui-winsource.h (struct tui_exec_info_window)
5423 <~tui_exec_info_window, maybe_allocate_content, get_content,
5424 m_content>: Remove.
5425 (struct tui_source_window_base) <set_exec_info_content,
5426 show_exec_info_content>: Don't declare.
5427 * tui/tui-winsource.c
5428 (tui_exec_info_window::maybe_allocate_content): Remove.
5429 (tui_source_window_base::update_exec_info): Rename from
5430 set_exec_info_content.
5431 (tui_source_window_base::show_exec_info_content)
5432 (tui_source_window_base::update_exec_info): Remove.
5433
93858ad3
TT
54342019-08-13 Tom Tromey <tom@tromey.com>
5435
5436 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5437 declare.
5438 * tui/tui-winsource.c (tui_update_source_window_as_is)
5439 (tui_update_source_windows_with_addr, tui_erase_source_content):
5440 Update.
5441 (tui_clear_exec_info_content): Remove.
5442
e321e7ce
TT
54432019-08-13 Tom Tromey <tom@tromey.com>
5444
5445 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5446 declare.
5447 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5448 call tui_erase_exec_info_content.
5449 (tui_clear_exec_info_content): Rename from
5450 tui_erase_exec_info_content.
5451 (tui_clear_exec_info_content): Delete.
5452
8270ac62
TT
54532019-08-13 Tom Tromey <tom@tromey.com>
5454
5455 * tui/tui-winsource.h (struct tui_source_window_base)
5456 <show_exec_info_content>: Declare.
5457 (tui_show_exec_info_content): Don't declare.
5458 * tui/tui-winsource.c
5459 (tui_source_window_base::show_exec_info_content): Rename from
5460 tui_show_exec_info_content.
5461 (tui_source_window_base::update_exec_info): Update.
5462
7b56485d
TT
54632019-08-13 Tom Tromey <tom@tromey.com>
5464
5465 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5466 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5467 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5468 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5469 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5470 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5471 ... here.
5472
7ba913dc
TT
54732019-08-13 Tom Tromey <tom@tromey.com>
5474
5475 * tui/tui-winsource.h (struct tui_source_window_base)
5476 <update_exec_info>: Declare.
5477 (tui_update_exec_info): Don't declare.
5478 * tui/tui-winsource.c (tui_update_source_window_as_is)
5479 (tui_source_window_base::refresh_all)
5480 (tui_update_all_breakpoint_info): Update.
5481 (tui_source_window_base::update_exec_info): Rename from
5482 tui_update_exec_info.
5483 * tui/tui-stack.c (tui_show_frame_info): Update.
5484
37a4a131
TT
54852019-08-13 Tom Tromey <tom@tromey.com>
5486
5487 * tui/tui-winsource.h (struct tui_source_window_base)
5488 <set_exec_info_content>: Declare.
5489 (tui_set_exec_info_content): Don't declare.
5490 * tui/tui-winsource.c
5491 (tui_source_window_base::set_exec_info_content): Rename from
5492 tui_set_exec_info_content.
5493 (tui_update_exec_info): Update.
5494
0bd27e07
TT
54952019-08-13 Tom Tromey <tom@tromey.com>
5496
5497 * tui/tui-winsource.h (struct tui_source_window_base)
5498 <show_source_content>: Declare.
5499 (tui_show_source_content): Don't declare.
5500 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5501 (tui_source_window_base::show_source_content): Rename from
5502 tui_show_source_content.
5503 (tui_source_window_base::refresh_all): Update.
5504 * tui/tui-layout.c (show_source_disasm_command)
5505 (show_source_or_disasm_and_command): Update.
5506
b4ef5aeb
TT
55072019-08-13 Tom Tromey <tom@tromey.com>
5508
5509 * tui/tui-winsource.c (tui_erase_source_content)
5510 (tui_show_source_content, tui_source_window_base::refresh_all):
5511 Update.
5512 * tui/tui-wingeneral.h
5513 (tui_check_and_display_highlight_if_needed): Don't declare.
5514 * tui/tui-wingeneral.c
5515 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5516 check_and_display_highlight_if_needed.
5517 * tui/tui-win.c (tui_rehighlight_all)
5518 (tui_win_info::make_visible_with_new_height): Update.
5519 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5520 (tui_data_window::erase_data_content)
5521 (tui_data_window::display_all_data): Update.
5522 * tui/tui-data.h (struct tui_win_info)
5523 <check_and_display_highlight_if_needed>: Declare.
5524
fede5273
TT
55252019-08-13 Tom Tromey <tom@tromey.com>
5526
5527 * tui/tui-win.c (tui_resize_all): Call
5528 tui_delete_invisible_windows.
5529 * tui/tui-layout.c (show_layout): Call
5530 tui_delete_invisible_windows.
5531 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5532 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5533
22c3f490
TT
55342019-08-13 Tom Tromey <tom@tromey.com>
5535
5536 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5537 tui_add_win_to_layout.
5538
16cb7910
TT
55392019-08-13 Tom Tromey <tom@tromey.com>
5540
5541 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5542 * tui/tui-layout.c (tui_default_win_height): Now static.
5543
cc0c3ffb
TT
55442019-08-13 Tom Tromey <tom@tromey.com>
5545
5546 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5547 single switch.
5548 (show_source_disasm_command, show_source_or_disasm_and_command):
5549 Don't check current layout.
5550
3f3ffe54
TT
55512019-08-13 Tom Tromey <tom@tromey.com>
5552
5553 * tui/tui-wingeneral.c (make_all_visible): Remove.
5554 (tui_make_all_invisible): Simplify.
5555 * tui/tui-layout.c (tui_make_all_invisible): Move from
5556 tui-wingeneral.c; simplify.
5557 (show_layout): Hoist call to tui_make_all_invisible.
5558 (show_data): Don't call tui_make_all_invisible.
5559
69258091
TT
55602019-08-13 Tom Tromey <tom@tromey.com>
5561
5562 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5563 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5564
62cf57fe
TT
55652019-08-13 Tom Tromey <tom@tromey.com>
5566
5567 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5568 tui-data.c.
5569 (show_source_disasm_command, show_data)
5570 (show_source_or_disasm_and_command): Don't use
5571 tui_set_current_layout_to.
5572 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5573 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5574 tui-layout.c.
5575 (tui_set_current_layout_to): Remove.
5576
2afade5d
TT
55772019-08-13 Tom Tromey <tom@tromey.com>
5578
5579 * tui/tui-layout.c (tui_set_layout): Update.
5580 * tui/tui-data.h (struct tui_layout_def): Remove.
5581 (tui_layout_def): Don't declare.
5582 * tui/tui-data.c (layout_def): Remove.
5583 (tui_layout_def): Remove.
5584
a3504e96
TT
55852019-08-13 Tom Tromey <tom@tromey.com>
5586
5587 * tui/tui-winsource.h (struct tui_source_window_base)
5588 <clear_detail>: No longer "override".
5589 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5590 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5591 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5592 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5593 Remove.
5594 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5595
29c92911
TT
55962019-08-13 Tom Tromey <tromey@adacore.com>
5597
5598 * tracepoint.c: Don't include readline.h or history.h.
5599
86c6b807
TT
56002019-08-12 Tom Tromey <tom@tromey.com>
5601
5602 * configure: Rebuild.
5603 * configure.ac: Check for readline 7.
5604 * NEWS: Mention readline 7 requirement.
5605 * README: Update.
5606
5db2718c
TT
56072019-08-12 Tom Tromey <tom@tromey.com>
5608
5609 * mingw-hdep.c (gdb_select): Remove readline hack.
5610
dac36daf
PFC
56112019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5612
5613 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5614 when the function fails.
5615
1022c627
AA
56162019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5617
5618 * s390-tdep.c (s390_type_align): New function.
5619 (s390_gdbarch_init): Set it as type_align gdbarch method.
5620
eba4caf2
TV
56212019-08-09 Tom de Vries <tdevries@suse.de>
5622
5623 PR gdb/24591
5624 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5625 pc_low with relocation offset.
5626
123cd851
TT
56272019-08-07 Tom Tromey <tromey@adacore.com>
5628
5629 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5630 (print_frame_args): Update.
5631 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5632 Update.
5633 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5634 * frame.h (struct frame_arg): Add initializers.
5635 <error>: Now a unique_xmalloc_ptr.
5636
3d31bc39
AH
56372019-08-07 Alan Hayward <alan.hayward@arm.com>
5638
5639 * NEWS: Expand the Pointer Authentication entry.
5640 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5641 (aarch64_frame_unmask_lr): ... to this.
5642 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5643 Call aarch64_frame_unmask_lr.
5644 * frame.c (struct frame_info): Add "masked" variable.
5645 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5646 (fprint_frame): Check for masked pc.
5647 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5648 declarations.
5649 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5650 * stack.c (print_frame): Check for masked pc.
5651
0cf9feb9
TT
56522019-08-06 Tom Tromey <tom@tromey.com>
5653
5654 * stabsread.c (patch_block_stabs, read_one_struct_field)
5655 (read_enum_type): Use obstack_strndup.
5656 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5657 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5658 * dwarf2read.c (guess_full_die_structure_name)
5659 (anonymous_struct_prefix): Use obstack_strndup.
5660 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5661 * c-exp.y (yylex): Use obstack_strndup.
5662 * ada-exp.y (write_object_renaming, write_ambiguous_var)
5663 (write_var_or_type): Use obstack_strndup.
5664
efba19b0
TT
56652019-08-06 Tom Tromey <tom@tromey.com>
5666
5667 * symfile.c (reread_symbols): Use obstack_strdup.
5668 * stabsread.c (read_type): Use obstack_strdup.
5669 * gdb_obstack.h (obstack_strdup): New overload.
5670 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5671 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5672 (dwarf2_canonicalize_name): Use obstack_strdup.
5673 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5674 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5675 Use obstack_strdup.
5676
f25102f7
TT
56772019-08-06 Tom Tromey <tom@tromey.com>
5678
5679 * gdb_obstack.h (obstack_strdup): Define.
5680 * gdb_obstack.c (obstack_strdup): Don't define.
5681
021887d8
TT
56822019-08-06 Tom Tromey <tom@tromey.com>
5683
5684 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5685 obstack_strdup.
5686 * typeprint.c (typedef_hash_table::find_global_typedef): Use
5687 obstack_strdup.
5688 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5689 * stabsread.c (common_block_start): Use obstack_strdup.
5690 * objfiles.c (set_objfile_main_name, objfile): Use
5691 obstack_strdup.
5692 * namespace.c (add_using_directive): Use obstack_strdup.
5693 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5694 * jit.c (finalize_symtab): Use obstack_strdup.
5695 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5696 (guess_partial_die_structure_name, partial_die_info::fixup)
5697 (dwarf2_name): Use obstack_strdup.
5698 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5699 obstack_strdup.
5700 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5701 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5702 obstack_strdup.
5703 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5704
d2834edc
PW
57052019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5706
5707 * unittests/help-doc-selftests.c: New file.
5708 * Makefile.in: Add the new file.
5709
590042fc
PW
57102019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5711
5712 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5713 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
5714 the full first line, except when FOR_VALUE_PREFIX. In this case,
5715 the trailing '.' is not output, and the first character is uppercased.
5716 (print_help_for_command): Update call to print_doc_line.
5717 (print_doc_of_command): Likewise.
5718 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5719 * cli/cli-option.c (append_indented_doc): Do not append newline.
5720 (build_help_option): Append newline after first appended_indented_doc
5721 only if a second call is done.
5722 (build_help): Append 2 new lines before each option, except the first
5723 one.
5724 * compile/compile.c (_initialize_compile): Add new lines after
5725 %OPTIONS%, when not at the end of the help.
5726 Change help doc or code
5727 producing the help doc to respect the invariants.
5728 * maint-test-options.c (_initialize_maint_test_options): Likewise.
5729 Also removed the new line after 'Options:', as all other commands
5730 do not put an empty line between 'Options:' and the first option.
5731 * printcmd.c (_initialize_printcmd): Likewise.
5732 * stack.c (_initialize_stack): Likewise.
5733 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5734 incorrectly telling COMMAND is optional.
5735 * ada-lang.c (_initialize_ada_language): Change help doc or code
5736 producing the help doc to respect the invariants.
5737 * ada-tasks.c (_initialize_ada_tasks): Likewise.
5738 * breakpoint.c (_initialize_breakpoint): Likewise.
5739 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5740 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5741 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5742 * cli/cli-style.c (cli_style_option::add_setshow_commands,
5743 _initialize_cli_style): Likewise.
5744 * corelow.c (core_target_info): Likewise.
5745 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5746 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5747 * filesystem.c (_initialize_filesystem): Likewise.
5748 * frame.c (_initialize_frame): Likewise.
5749 * gnu-nat.c (add_task_commands): Likewise.
5750 * infcall.c (_initialize_infcall): Likewise.
5751 * infcmd.c (_initialize_infcmd): Likewise.
5752 * interps.c (_initialize_interpreter): Likewise.
5753 * language.c (_initialize_language): Likewise.
5754 * linux-fork.c (_initialize_linux_fork): Likewise.
5755 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5756 * maint.c (_initialize_maint_cmds): Likewise.
5757 * memattr.c (_initialize_mem): Likewise.
5758 * printcmd.c (_initialize_printcmd): Likewise.
5759 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5760 _RegEx): Likewise.
5761 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5762 * record-btrace.c (_initialize_record_btrace): Likewise.
5763 * record-full.c (_initialize_record_full): Likewise.
5764 * record.c (_initialize_record): Likewise.
5765 * regcache-dump.c (_initialize_regcache_dump): Likewise.
5766 * regcache.c (_initialize_regcache): Likewise.
5767 * remote.c (add_packet_config_cmd, init_remote_threadtests,
5768 _initialize_remote): Likewise.
5769 * ser-tcp.c (_initialize_ser_tcp): Likewise.
5770 * serial.c (_initialize_serial): Likewise.
5771 * skip.c (_initialize_step_skip): Likewise.
5772 * source.c (_initialize_source): Likewise.
5773 * stack.c (_initialize_stack): Likewise.
5774 * symfile.c (_initialize_symfile): Likewise.
5775 * symtab.c (_initialize_symtab): Likewise.
5776 * target-descriptions.c (_initialize_target_descriptions): Likewise.
5777 * top.c (init_main): Likewise.
5778 * tracefile-tfile.c (tfile_target_info): Likewise.
5779 * tracepoint.c (_initialize_tracepoint): Likewise.
5780 * tui/tui-win.c (_initialize_tui_win): Likewise.
5781 * utils.c (add_internal_problem_command): Likewise.
5782 * valprint.c (value_print_option_defs): Likewise.
5783
404f2902
FCE
57842019-08-06 Frank Ch. Eigler <fche@redhat.com>
5785
5786 PR build/24886
5787 * configure.ac: Drop enable-libmcheck support.
5788 * configure, config.in: Rebuild.
5789 * libmcheck.m4: Remove.
5790 * acinclude.m4: Don't include it.
5791 * Makefile.in: Don't distribute it.
5792 * top.c (print_gdb_configuration): Don't mention it.
5793
046bebe1
TT
57942019-08-06 Tom Tromey <tom@tromey.com>
5795
5796 * utils.c (set_output_style): Sometimes pass stream to
5797 emit_style_escape.
5798 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5799 * record-btrace.c (btrace_insn_history): Update.
5800 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5801 method.
5802 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5803 Update initializers.
5804 <m_uiout>: New field.
5805 <m_di>: Move lower.
5806 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5807 Remove "uiout" parameter.
5808 (dump_insns): Update.
5809 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5810 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5811
ddbcedf5
CB
58122019-08-06 Christian Biesinger <cbiesinger@google.com>
5813
5814 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5815 (error_in_psymtab_expansion): Likewise.
5816 (lookup_symbol_via_quick_fns): Likewise.
5817 (basic_lookup_transparent_type_quick): Likewise.
5818 (basic_lookup_transparent_type_1): Likewise.
5819
b08b16c8
TT
58202019-08-06 Tom Tromey <tromey@adacore.com>
5821
5822 * source.c (last_source_error): Now bool.
5823 (print_source_lines_base): Make "noprint" bool. Only open
5824 source file when last_source_visited changes.
5825
cb44333d
TT
58262019-08-06 Tom Tromey <tromey@adacore.com>
5827
5828 * annotate.c (annotate_source_line): Use g_source_cache.
5829 * source-cache.c (source_cache::get_plain_source_lines): Change
5830 parameters. Populate m_offset_cache.
5831 (source_cache::ensure): New method.
5832 (source_cache::get_line_charpos): New method.
5833 (extract_lines): Move lower. Change parameters.
5834 (source_cache::get_source_lines): Move lower.
5835 * source-cache.h (class source_cache): Update comment.
5836 <get_line_charpos>: New method.
5837 <get_source_lines>: Update comment.
5838 <clear>: Clear m_offset_cache.
5839 <get_plain_source_lines>: Change parameters.
5840 <ensure>: New method
5841 <m_offset_cache>: New member.
5842 * source.c (forget_cached_source_info_for_objfile): Update.
5843 (info_source_command): Use g_source_cache.
5844 (find_source_lines, open_source_file_with_line_charpos): Remove.
5845 (print_source_lines_base, search_command_helper): Use g_source_cache.
5846 * source.h (open_source_file_with_line_charpos): Don't declare.
5847 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5848 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5849 Use g_source_cache.
5850
872dceaa
TT
58512019-08-06 Tom Tromey <tromey@adacore.com>
5852
5853 * source-cache.c (source_cache::get_plain_source_lines):
5854 Remove "first_line" and "last_line" parameters.
5855 (source_cache::get_source_lines): Cache plain text.
5856 * source-cache.h (class source_cache)
5857 <get_plain_source_lines>: Update.
5858
269249d9
TT
58592019-08-06 Tom Tromey <tromey@adacore.com>
5860
5861 * source-cache.c (extract_lines): No longer a method.
5862 Changed type of parameter. Include final newline.
5863 (selftests::extract_lines_test): New function.
5864 (_initialize_source_cache): Likewise.
5865 * source-cache.h (class source_cache)
5866 <extract_lines>: Don't declare.
5867
c0e8dcd8
TT
58682019-08-06 Tom Tromey <tromey@adacore.com>
5869
5870 * breakpoint.c (init_breakpoint_sal): Update.
5871 (breakpoint): Update.
5872 * breakpoint.h (struct breakpoint) <filter>: Now a
5873 unique_xmalloc_ptr.
5874
0b27c27d
CB
58752019-08-05 Christian Biesinger <cbiesinger@google.com>
5876
5877 * NEWS: Mention dictionary access on blocks.
5878 * python/py-block.c (blpy_getitem): New function.
5879 (block_object_as_mapping): New struct.
5880 (block_object_type): Use new struct for tp_as_mapping field.
5881
4ee94178
CB
58822019-08-05 Christian Biesinger <cbiesinger@google.com>
5883
5884 * objfiles.h (objfile): Add a comment describing partial symbols.
5885
8abfcabc
TT
58862019-08-05 Tom Tromey <tromey@adacore.com>
5887
5888 * compile/compile.c (_initialize_compile): Use _(), not N_().
5889 * thread.c (_initialize_thread): Use _(), not N_().
5890 * stack.c (_initialize_stack): Use _(), not N_().
5891 * printcmd.c (_initialize_printcmd): Use _(), not N_().
5892
2b79f376
SM
58932019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
5894
5895 * dwarf2read.c (struct dw2_symtab_iterator):
5896 <want_specific_block>: Remove.
5897 <block_index>: Change type to gdb::optional.
5898 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5899 change type of BLOCK_INDEX parameter to gdb::optional.
5900 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5901 (dw2_lookup_symbol): Don't pass argument for
5902 WANT_SPECIFIC_BLOCK.
5903 (dw2_expand_symtabs_for_function): Don't pass argument for
5904 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5905 (class dw2_debug_names_iterator)
5906 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5907 parameter, change BLOCK_INDEX type to gdb::optional.
5908 <m_want_specific_block>: Remove.
5909 <m_block_index>: Change type to gdb::optional.
5910 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5911 gdb::optional. Re-write in function of gdb::optional.
5912 (dw2_debug_names_lookup_symbol): Don't pass argument for
5913 WANT_SPECIFIC_BLOCK.
5914 (dw2_debug_names_expand_symtabs_for_function): Don't pass
5915 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5916 BLOCK_INDEX.
5917
ae60f04e
PW
59182019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5919
5920 * NEWS: Mention changes to "info sources" command.
5921
28cd9371
PW
59222019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5923
5924 * symtab.c (filename_partial_match_opts): New struct type.
5925 (struct output_source_filename_data): New members
5926 regexp, c_regexp, partial_match.
5927 (output_source_filename): Use new members to decide to print file.
5928 (info_sources_option_defs): New variable.
5929 (make_info_sources_options_def_group, print_info_sources_header,
5930 info_sources_command_completer):
5931 New functions.
5932 (info_sources_command): Read new optional arguments.
5933 (_initialize_symtab): Update info sources help.
5934
ca683e3a
AO
59352019-08-02 Alexandre Oliva <oliva@adacore.com>
5936
5937 * ada-lang.c (exception_support_info_v0): Renamed from...
5938 (default_exception_support_info): ... this. Create new
5939 definition for v1.
5940 (ada_has_this_exception_support): Look up catch_handlers_sym.
5941 (ada_exception_support_info_sniffer): Try v0 after default.
5942
f1264162
TT
59432019-08-01 Tom Tromey <tromey@adacore.com>
5944
5945 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5946 gdbarch.h.
5947
0a7b2485
CB
59482019-08-01 Christian Biesinger <cbiesinger@google.com>
5949
5950 * s12z-tdep.c: Fix include path for s12z-opc.h.
5951
c6bdbeb7
AH
59522019-08-01 Alan Hayward <alan.hayward@arm.com>
5953
5954 * NEWS: Require GNU make 3.82.
5955
a2bd7b82
TT
59562019-07-16 Tom Tromey <tom@tromey.com>
5957
5958 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5959 declare.
5960
aa3b6533
TT
59612019-07-30 Tom Tromey <tromey@adacore.com>
5962
5963 * block.c (contained_in): Remove BLOCK_FUNCTION check.
5964
a1530dc7
KB
59652019-07-30 Kevin Buettner <kevinb@redhat.com>
5966
5967 * printcmd.c (print_address_symbolic): Print negative offsets.
5968 (build_address_symbolic): Force signed arithmetic when computing
5969 offset.
5970
2906593f
CB
59712019-07-30 Christian Biesinger <cbiesinger@google.com>
5972
5973 PR/24474: Add a function to lookup static variables.
5974 * NEWS: Mention this new function.
5975 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5976 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5977 * python/python.c (python_GdbMethods): Add new function.
5978
c620ed88
CB
59792019-07-29 Christian Biesinger <cbiesinger@google.com>
5980
5981 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5982 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5983 (objfpy_lookup_static_symbol): New function.
5984 (objfile_object_methods): Add new functions.
5985
bc4268a5
PW
59862019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5987
5988 * NEWS: Mention 'set|show print frame-info'. Mention new
5989 'presence' value for 'frame-arguments'. Mention new '-frame-info'
5990 backtrace argument. Mention that python frame filtering code
5991 is now consistent with what 'backtrace' command prints.
5992
4b5e8d19
PW
59932019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5994
5995 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5996 comments.
5997 (print_frame_info_auto, print_frame_info_source_line,
5998 print_frame_info_location, print_frame_info_source_and_location,
5999 print_frame_info_location_and_address, print_frame_info_short_location):
6000 New declarations.
6001 (struct frame_print_options): New member print_frame_info.
6002 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6003 * stack.h (get_user_print_what_frame_info): New declaration.
6004 (frame_show_address): New declaration.
6005 * stack.c (print_frame_arguments_choices): New value 'presence'.
6006 (print_frame_info_auto, print_frame_info_source_line,
6007 print_frame_info_location, print_frame_info_source_and_location,
6008 print_frame_info_location_and_address, print_frame_info_short_location,
6009 print_frame_info_choices, print_frame_info_print_what): New definitions.
6010 (print_frame_args): Only print dots for args if print frame-arguments
6011 is 'presence'.
6012 (frame_print_option_defs): New element for "frame-info".
6013 (get_user_print_what_frame_info): New function.
6014 (frame_show_address): Make non static. Move comment to stack.h.
6015 (print_frame_info_to_print_what): New function.
6016 (print_frame_info): Update comment. Use fp_opts.print_frame_info
6017 to decide what to print.
6018 (backtrace_command_1): Handle the new print_frame_arguments_presence
6019 value.
6020 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6021 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6022 (py_print_frame): In non-mi mode, use LOCATION as default for
6023 print_what, similarly to frame information printed directly by
6024 backtrace command. Handle frame-info user option in non MI mode.
6025
6bdfee81
KB
60262019-07-27 Kevin Buettner <kevinb@redhat.com>
6027
6028 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6029 Add case for debugging 32-bit target on 64-bit host. Revise
6030 comment.
6031
98a617f8
KB
60322019-07-27 Kevin Buettner <kevinb@redhat.com>
6033
6034 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6035 instead of find_function_entry_range_from_pc.
6036
567238c9
KB
60372019-07-27 Kevin Buettner <kevinb@redhat.com>
6038
6039 * stack.c (find_frame_funname): Remove code which preferred
6040 minsym over symtab sym in "certain pathological cases".
6041
2dc80cf8
KB
6042 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6043 parameter. Change type of "do_demangle" to bool.
6044 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6045 Pass suitable "prefer_sym_over_minsym" flag to
6046 build_address_symbolic(). Don't output "+" for negative offsets.
6047 * printcmd.c (print_address_symbolic): Update invocation of
6048 build_address_symbolic to include a "prefer_sym_over_minsym"
6049 flag.
6050 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6051 Restrict cases in which use of minimal symbol is preferred to that
6052 of a found symbol. Update comments.
6053
1aff7173
KB
6054 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6055 for entry pc when entry pc is out of range for that FDE.
6056
89b085ac
BC
60572019-07-26 Brian Callahan <bcallah@openbsd.org>
6058
6059 PR gdb/24839:
6060 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6061 type.
6062
f32feb4a
CB
60632019-07-25 Christian Biesinger <cbiesinger@google.com>
6064
6065 * python/py-objfile.c (add_separate_debug_file): Fix comment about
6066 this function's Python signature.
6067
6068
60692019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
6070
6071 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6072 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6073 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6074 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6075 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6076
6077
c54e4253
YS
60782019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
6079
6080 * h8300-tdep.c (h8300_register_name_common): New.
6081 h8300_register_name): Use h8300_register_name_common.
6082 (h8300s_register_name): Likewise.
6083 (h8300sx_register_name): Likewise.
6084 (h8300h_register_nam): New.
6085 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6086
6087
40eadf04
SP
60882019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
6089
6090 * arm-tdep.c (arm_skip_cmse_entry): New function.
6091 (arm_is_sgstubs_section): New function.
6092 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6093
bfa2a36d
TT
60942019-07-22 Tom Tromey <tom@tromey.com>
6095
6096 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6097 Don't self-assign.
6098
a8e9d247
AB
60992019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6100
6101 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6102 type_print.
6103
eb86c5e2
AB
61042019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6105
6106 * symtab.c (search_symbols): Adjust msymbol matching type arrays
6107 so that GDB doesn't match any msymbols when searching in the
6108 TYPES_DOMAIN.
6109 (print_symbol_info): Print using typedef_print or type_print based
6110 on the type of the symbol. Add updated FIXME comment moved from...
6111 (_initialize_symtab): ... move and update FIXME comment to above.
6112
a8eab7c6
AB
61132019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6114
6115 * NEWS: Mention adding -q option to "info types".
6116 * symtab.c (struct info_types_options): New struct.
6117 (info_types_options_defs): New variable.
6118 (make_info_types_options_def_group): New function.
6119 (info_types_command): Use gdb::option framework to parse options.
6120 (info_types_command_completer): New function.
6121 (_initialize_symtab): Extend the help text on "info types" and
6122 register command completer.
6123
b4603c34
CB
61242019-07-21 Christian Biesinger <cbiesinger@google.com>
6125
6126 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6127 (lookup_symbol_in_objfile): Change int to block_enum and add a
6128 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6129
c8cdc1e0
CB
61302019-07-20 Christian Biesinger <cbiesinger@google.com>
6131
6132 * MAINTAINERS (Write After Approval): Add self.
6133
01e175fe
AB
61342019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
6135
6136 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6137 instruction to the dummy code region.
6138
56f79b63
TT
61392019-07-19 Tom Tromey <tromey@adacore.com>
6140
6141 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6142 (ARGSUSED, PARAMS, __func__): Remove rules.
6143
4c5aa8e0
AH
61442019-07-19 Alan Hayward <alan.hayward@arm.com>
6145
6146 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6147 * features/arm/arm-with-iwmmxt.c: Remove.
6148 * features/arm/arm-with-iwmmxt.xml: Remove.
6149 * features/arm/arm-with-m-fpa-layout.c: Remove.
6150 * features/arm/arm-with-m-fpa-layout.xml: Remove.
6151 * features/arm/arm-with-m-vfp-d16.c: Remove.
6152 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6153 * features/arm/arm-with-m.c: Remove.
6154 * features/arm/arm-with-m.xml: Remove.
6155 * features/arm/arm-with-neon.c: Remove.
6156 * features/arm/arm-with-neon.xml: Remove.
6157 * features/arm/arm-with-vfpv2.c: Remove.
6158 * features/arm/arm-with-vfpv2.xml: Remove.
6159 * features/arm/arm-with-vfpv3.c: Remove.
6160 * features/arm/arm-with-vfpv3.xml: Remove.
6161
f42b2617
AH
61622019-07-19 Alan Hayward <alan.hayward@arm.com>
6163
6164 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6165
f29ec966
AH
61662019-07-19 Alan Hayward <alan.hayward@arm.com>
6167
6168 * arch/aarch32.c (aarch32_create_target_description): Create
6169 target descriptions using features.
6170 * arch/arm.c (arm_create_target_description)
6171 (arm_create_mprofile_target_description): Likewise.
6172 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6173
d105cce5
AH
61742019-07-19 Alan Hayward <alan.hayward@arm.com>
6175
6176 * Makefile.in: Add new files.
6177 * aarch32-tdep.c: New file.
6178 * aarch32-tdep.h: New file.
6179 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6180 Call aarch32_read_description.
6181 * arch/aarch32.c: New file.
6182 * arch/aarch32.h: New file.
6183 * arch/arm.c (arm_create_target_description)
6184 (arm_create_mprofile_target_description): New function.
6185 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6186 (arm_create_target_description)
6187 (arm_create_mprofile_target_description): New declaration.
6188 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6189 read_description functions.
6190 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6191 Likewise.
6192 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6193 * arm-tdep.c (tdesc_arm_list): New variable.
6194 (arm_register_g_packet_guesses): Call create description functions.
6195 (arm_read_description) (arm_read_mprofile_description): New
6196 function.
6197 * arm-tdep.h (arm_read_description)
6198 (arm_read_mprofile_description): Add declaration.
6199 * configure.tgt: Add new files.
6200
afe09f0b
GL
62012019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6202
6203 * top.c (new_ui_command): Open specified terminal just once.
6204
cd215b2e
TT
62052019-07-18 Tom Tromey <tromey@adacore.com>
6206
6207 * symtab.c (main_name): Constify return type.
6208 * symfile.c (set_initial_language): Update.
6209 * symtab.h (main_name): Constify return type.
6210
d8f68fcb
TT
62112019-07-17 Tom Tromey <tom@tromey.com>
6212
6213 * tui/tui-winsource.c (tui_update_source_window)
6214 (tui_update_source_window_as_is)
6215 (tui_update_source_windows_with_line): Remove return.
6216 * tui/tui-disasm.c (tui_show_disassem)
6217 (tui_show_disassem_and_update_source): Remove return.
6218 * tui/tui.c (tui_reset): Remove return.
6219 * tui/tui-wingeneral.c
6220 (tui_check_and_display_highlight_if_needed): Remove return.
6221
ca5af91e
TT
62222019-07-17 Tom Tromey <tom@tromey.com>
6223
6224 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6225
5104fe36
TT
62262019-07-17 Tom Tromey <tom@tromey.com>
6227
6228 * tui/tui-winsource.h (struct tui_exec_info_window)
6229 (struct tui_source_window_base): Move from tui-data.h.
6230 * tui/tui-winsource.c: Move many method definitions from
6231 elsewhere. Remove "structuring" comments.
6232 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6233 (tui_source_window_base::refresh_window): Move to
6234 tui-winsource.c.
6235 * tui/tui-win.c (tui_source_window_base::refresh_all)
6236 (tui_source_window_base::update_tab_width)
6237 (tui_source_window_base::set_new_height)
6238 (tui_source_window_base::do_make_visible_with_new_height): Move to
6239 tui-winsource.c.
6240 * tui/tui-source.h: Update.
6241 * tui/tui-source.c (tui_source_window_base::reset): Move to
6242 tui-winsource.c.
6243 * tui/tui-disasm.h: Update.
6244 * tui/tui-data.h (struct tui_exec_info_window): Move to
6245 tui-winsource.h.
6246 (struct tui_source_window_base): Likewise.
6247 * tui/tui-data.c (tui_source_window_base::clear_detail)
6248 (tui_source_window_base, ~tui_source_window_base): Move to
6249 tui-winsource.c.
6250
daa15dde
TT
62512019-07-17 Tom Tromey <tom@tromey.com>
6252
6253 * tui/tui-win.c (tui_resize_all)
6254 (tui_source_window_base::update_tab_width)
6255 (tui_adjust_win_heights): Update.
6256 (tui_win_info::make_invisible_and_set_new_height): Rename from
6257 make_invisible_and_set_new_height.
6258 * tui/tui-data.h (struct tui_win_info)
6259 <make_invisible_and_set_new_height>: New method.
6260
bfad4537
TT
62612019-07-17 Tom Tromey <tom@tromey.com>
6262
6263 * tui/tui.c: Update.
6264 * tui/tui-source.h (struct tui_source_window): Move from
6265 tui-data.h.
6266 * tui/tui-layout.c: Update.
6267 * tui/tui-disasm.c: Update.
6268 * tui/tui-data.h (struct tui_source_window): Move to
6269 tui-source.h.
6270
88f7e873
TT
62712019-07-17 Tom Tromey <tom@tromey.com>
6272
6273 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6274 tui-data.h.
6275 * tui/tui-data.h (struct tui_disasm_window): Move to
6276 tui-disasm.h.
6277
96bd6233
TT
62782019-07-17 Tom Tromey <tom@tromey.com>
6279
6280 * tui/tui-regs.h (struct tui_data_item_window): Move from
6281 tui-data.h.
6282 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6283 * tui/tui-data.h (struct tui_data_item_window): Move to
6284 tui-regs.h.
6285 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6286
ce38393b
TT
62872019-07-17 Tom Tromey <tom@tromey.com>
6288
6289 * tui/tui.c: Update.
6290 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6291 (tui_cmd_window::max_height): Move to tui-command.c.
6292 * tui/tui-layout.c: Update.
6293 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6294 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6295 tui-command.c.
6296 * tui/tui-command.h (struct tui_cmd_window): Move from
6297 tui-data.h.
6298 * tui/tui-command.c: Remove "structuring" comments.
6299 (tui_cmd_window::clear_detail)
6300 (tui_cmd_window::do_make_visible_with_new_height)
6301 (tui_cmd_window::max_height): Move from elsewhere.
6302
2d8b51cb
TT
63032019-07-17 Tom Tromey <tom@tromey.com>
6304
6305 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6306 Now static.
6307 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6308 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6309
18ab23af
TT
63102019-07-17 Tom Tromey <tom@tromey.com>
6311
6312 * tui/tui.c: Update.
6313 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6314 tui-regs.c.
6315 * tui/tui-windata.h: Remove file.
6316 * tui/tui-windata.c: Remove file.
6317 * tui/tui-win.c (tui_data_window::set_new_height)
6318 (tui_data_window::do_make_visible_with_new_height): Move to
6319 tui-regs.c.
6320 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6321 * tui/tui-regs.c: Remove "structuring" comments.
6322 (tui_data_window::first_data_item_displayed)
6323 (tui_data_window::delete_data_content_windows)
6324 (tui_data_window::erase_data_content)
6325 (tui_data_window::display_all_data)
6326 (tui_data_window::refresh_all)
6327 (tui_data_window::do_scroll_vertical)
6328 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6329 (tui_data_window::do_make_visible_with_new_height)
6330 (tui_data_window::refresh_window): Move from elsewhere.
6331 (_initialize_tui_regs): Move to end of file.
6332 * tui/tui-layout.c: Update.
6333 * tui/tui-hooks.c: Update.
6334 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6335 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6336 tui-regs.c.
6337 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6338
88b7e7cc
TT
63392019-07-17 Tom Tromey <tom@tromey.com>
6340
6341 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6342 seen.
6343
0fcd3711
TT
63442019-07-17 Tom Tromey <tom@tromey.com>
6345
6346 * tui/tui-win.c (tui_source_window_base::set_new_height)
6347 (tui_source_window_base::do_make_visible_with_new_height): Use
6348 m_has_locator field directly.
6349 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6350 method.
6351 (struct tui_source_window_base) <has_locator>: Likewise.
6352
4a38112d
TT
63532019-07-17 Tom Tromey <tom@tromey.com>
6354
6355 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6356 Don't declare.
6357 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6358 Remove.
6359 * tui/tui-win.c (tui_source_window_base::set_new_height)
6360 (tui_source_window_base::set_new_height)
6361 (make_invisible_and_set_new_height)
6362 (tui_source_window_base::do_make_visible_with_new_height)
6363 (tui_source_window_base::do_make_visible_with_new_height):
6364 Update.
6365 * tui/tui-layout.c (show_source_disasm_command, show_data)
6366 (show_source_or_disasm_and_command): Update.
6367 * tui/tui-layout.c (show_layout): Update.
6368
09129226
TT
63692019-07-17 Tom Tromey <tom@tromey.com>
6370
6371 * tui/tui-layout.c (make_data_window): Remove.
6372 (show_data): Unify creation and re-initialization cases.
6373
4a8a5e84
TT
63742019-07-17 Tom Tromey <tom@tromey.com>
6375
6376 * tui/tui-layout.c (make_source_window, make_disasm_window):
6377 Remove.
6378 (show_data): Unify creation and re-initialization cases.
6379
76d2be8e
TT
63802019-07-17 Tom Tromey <tom@tromey.com>
6381
6382 * tui/tui-layout.c (make_command_window): Remove.
6383 (show_source_disasm_command, show_source_or_disasm_and_command):
6384 Unify creation and re-initialization cases.
6385
890b8bde
TT
63862019-07-17 Tom Tromey <tom@tromey.com>
6387
6388 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6389 creation and re-initialization cases.
6390
2cdfa113
TT
63912019-07-17 Tom Tromey <tom@tromey.com>
6392
6393 * tui/tui-regs.c (tui_get_register): Return void.
6394
8e3cfd09
TT
63952019-07-17 Tom Tromey <tom@tromey.com>
6396
6397 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6398 Simplify.
6399
f4e04977
TT
64002019-07-17 Tom Tromey <tom@tromey.com>
6401
6402 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6403 resetting.
6404
0379b883
TT
64052019-07-17 Tom Tromey <tom@tromey.com>
6406
6407 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6408 * tui/tui-regs.c (tui_reg_layout): New function.
6409 (tui_show_registers, tui_reg_command): Use it.
6410 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6411 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6412 parameters.
6413 (tui_layout_command): Remove.
6414
b7fbad91
TT
64152019-07-17 Tom Tromey <tom@tromey.com>
6416
6417 * tui/tui-layout.h (tui/tui-layout): Return void.
6418 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6419
4e1e56b9
TT
64202019-07-17 Tom Tromey <tom@tromey.com>
6421
6422 * tui/tui-layout.c (show_source_disasm_command, show_data):
6423 Update.
6424 (reset_locator): Remove.
6425 (show_source_or_disasm_and_command): Update.
6426
1e0c09ba
TT
64272019-07-17 Tom Tromey <tom@tromey.com>
6428
6429 * tui/tui-source.c (tui_source_window_base::reset): Remove
6430 win_type parameter.
6431 * tui/tui-layout.c (make_command_window, make_source_window)
6432 (make_disasm_window, make_data_window)
6433 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6434 (reset_locator, show_source_or_disasm_and_command): Update.
6435 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6436 win_type parameter.
6437 (struct tui_source_window_base) <reset>: Likewise.
6438
1bf605de
TT
64392019-07-17 Tom Tromey <tom@tromey.com>
6440
6441 * tui/tui-layout.c (show_source_disasm_command): Use
6442 reset_locator.
6443 (reset_locator): New function.
6444 (init_and_make_win): Remove.
6445 (show_source_or_disasm_and_command): Use reset_locator.
6446
098f9ed4
TT
64472019-07-17 Tom Tromey <tom@tromey.com>
6448
6449 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6450 condition.
6451 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6452 Remove condition.
6453 * tui/tui-source.c (tui_source_window_base::reset): New method.
6454 * tui/tui-layout.c (make_command_window): Don't call
6455 init_and_make_win.
6456 (make_source_window, make_disasm_window): Don't call
6457 make_source_or_disasm_window.
6458 (make_data_window): Don't call init_and_make_win. Change calling
6459 convention.
6460 (show_source_disasm_command, show_data): Simplify.
6461 (make_source_or_disasm_window): Remove.
6462 (show_source_or_disasm_and_command): Simplify.
6463 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6464 (struct tui_source_window_base) <reset>: Likewise.
6465 <execution_info>: Remove initializer.
6466 * tui/tui-data.c (tui_source_window_base): Initialize
6467 execution_info.
6468
80110957
TT
64692019-07-17 Tom Tromey <tom@tromey.com>
6470
6471 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6472 variable.
6473
cf82af05
TT
64742019-07-17 Tom Tromey <tom@tromey.com>
6475
6476 * tui/tui.c (tui_rl_other_window): Update.
6477 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6478 superclass method first. Always iterate over regs_content.
6479 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6480 method.
6481 * tui/tui-win.c (tui_set_focus_command): Update.
6482
01aeb396
TT
64832019-07-17 Tom Tromey <tom@tromey.com>
6484
6485 * tui/tui-win.c (tui_set_focus_command): Rename from
6486 tui_set_focus. Call tui_enable.
6487 (tui_set_focus_command): Remove.
6488
fd6c75ee
TT
64892019-07-17 Tom Tromey <tom@tromey.com>
6490
6491 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6492 refresh_window.
6493 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6494 touchwin.
6495 (tui_data_window::refresh_window): Call refresh_window on data
6496 items. Always call superclass refresh_window.
6497 (tui_win_info::refresh): Remove.
6498 (tui_source_window_base::refresh_window): Update.
6499 (tui_refresh_all): Update.
6500 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6501 refresh_window.
6502 (show_source_or_disasm_and_command): Likewise.
6503 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6504 (struct tui_source_window_base) <refresh>: Likewise.
6505
f6cc34a9
TT
65062019-07-17 Tom Tromey <tom@tromey.com>
6507
6508 * tui/tui-winsource.c (tui_clear_source_content)
6509 (tui_show_source_content): Update.
6510 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6511 whether content is empty.
6512 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6513 Remove.
6514
f31ec9af
TT
65152019-07-17 Tom Tromey <tom@tromey.com>
6516
6517 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6518 window's contents.
6519 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6520 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6521
d1b6f1e5
TT
65222019-07-17 Tom Tromey <tom@tromey.com>
6523
6524 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6525 (struct tui_data_item_window): Update.
6526
d9743a13
TT
65272019-07-17 Tom Tromey <tom@tromey.com>
6528
6529 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6530 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6531 defines.
6532
caf0bc4e
TT
65332019-07-17 Tom Tromey <tom@tromey.com>
6534
6535 * tui/tui-winsource.h (tui_erase_source_content)
6536 (tui_clear_source_content): Remove "display_prompt" parameter.
6537 * tui/tui-winsource.c (tui_update_source_window_as_is)
6538 (tui_update_source_windows_with_addr): Update.
6539 (tui_clear_source_content): Remove "display_prompt" parameter.
6540 (tui_erase_source_content): Likewise. Simplify.
6541 (tui_show_source_content): Update.
6542 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6543 * tui/tui-stack.c (tui_show_frame_info): Update.
6544 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6545 Remove defines.
6546
9d391078
TT
65472019-07-17 Tom Tromey <tom@tromey.com>
6548
6549 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6550 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6551 parameter.
6552 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6553 parameter.
6554
a38da35d
TT
65552019-07-17 Tom Tromey <tom@tromey.com>
6556
6557 * tui/tui-winsource.c (tui_clear_source_content)
6558 (tui_show_source_content, tui_show_exec_info_content)
6559 (tui_clear_exec_info_content): Update.
6560 * tui/tui-stack.c (tui_show_locator_content): Update.
6561 (tui_show_frame_info): Update.
6562 * tui/tui-source.h (tui_source_window): Don't declare.
6563 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6564 from tui_source_is_displayed.
6565 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6566 Remove field.
6567 (struct tui_source_window_base) <content_in_use>: New field. Now
6568 bool.
6569 (struct tui_source_window) <showing_source_p>: New method.
6570 (TUI_SRC_WIN): Change cast.
6571 * tui/tui-data.c (tui_initialize_static_data): Update.
6572
c2cd8994
TT
65732019-07-17 Tom Tromey <tom@tromey.com>
6574
6575 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6576 location_matches_p.
6577 * tui/tui-source.c (tui_source_window::location_matches_p): New
6578 method.
6579 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6580 method.
6581 * tui/tui-data.h (struct tui_source_window_base)
6582 <location_matches_p>: New method.
6583 (struct tui_source_window, struct tui_disasm_window)
6584 <location_matches_p>: Likewise.
6585
4dde7b34
TT
65862019-07-17 Tom Tromey <tom@tromey.com>
6587
6588 * tui/tui-win.c (tui_set_win_height_command): Rename from
6589 tui_set_win_height.
6590 (tui_set_win_height_command): Remove.
6591
b73dd877
TT
65922019-07-17 Tom Tromey <tom@tromey.com>
6593
6594 * tui/tui-source.c (tui_source_window): New constructor. Add
6595 observer.
6596 (~tui_source_window): New destructor.
6597 (tui_source_window::style_changed): New method.
6598 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6599 (tui_attach_detach_observers): Update.
6600 * tui/tui-data.h (struct tui_source_window): Make constructor not
6601 inline. Add destructor.
6602 (struct tui_source_window) <style_changed>: New method.
6603 <m_observable>: New member.
6604
ae2b5380
TT
66052019-07-17 Tom Tromey <tom@tromey.com>
6606
6607 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6608 * tui/tui-win.c (tui_resize_all): Fix typo.
6609
1ce3e844
TT
66102019-07-17 Tom Tromey <tom@tromey.com>
6611
6612 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6613 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6614 (tui_refresh_all): Remove "list" parameter. Use foreach.
6615 * tui/tui-win.c (window_name_completer): Use foreach.
6616 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6617 (update_tab_width): Likewise.
6618 * tui/tui-layout.c (show_layout): Update.
6619 * tui/tui-data.h (class tui_window_iterator): New.
6620 (struct all_tui_windows): New.
6621 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6622
fe3eaf1c
TT
66232019-07-17 Tom Tromey <tom@tromey.com>
6624
6625 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6626 parameter. Don't reference globals.
6627 (tui_reg_command): Update.
6628
368c1354
TT
66292019-07-17 Tom Tromey <tom@tromey.com>
6630
6631 * tui/tui-regs.c (tui_show_registers): Simplify.
6632
e80cd204
TT
66332019-07-17 Tom Tromey <tom@tromey.com>
6634
6635 * tui/tui-regs.c (tui_show_registers): Update.
6636 (tui_show_register_group): Add win_info parameter.
6637
aca2dd16
TT
66382019-07-17 Tom Tromey <tom@tromey.com>
6639
6640 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6641 Rename from tui_display_reg_element_at_line.
6642 (tui_data_window::display_registers_from_line): Update.
6643 * tui/tui-data.h (struct tui_data_window)
6644 <display_reg_element_at_line>: New method.
6645
517e9505
TT
66462019-07-17 Tom Tromey <tom@tromey.com>
6647
6648 * tui/tui-regs.h (tui_display_registers_from)
6649 (tui_display_registers_from_line): Don't declare.
6650 * tui/tui-windata.c (tui_data_window::display_all_data)
6651 (tui_data_window::refresh_all)
6652 (tui_data_window::do_scroll_vertical): Update.
6653 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6654 from tui_display_registers_from.
6655 (tui_display_reg_element_at_line): Update.
6656 (tui_data_window::display_registers_from_line): Rename from
6657 tui_display_registers_from_line.
6658 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6659 display_registers_from_line>: New methods.
6660
f76d8b19
TT
66612019-07-17 Tom Tromey <tom@tromey.com>
6662
6663 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6664 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6665 from tui_erase_data_content.
6666 (tui_data_window::display_all_data)
6667 (tui_data_window::refresh_all)
6668 (tui_data_window::do_scroll_vertical): Update.
6669 * tui/tui-regs.c (tui_show_registers): Update.
6670 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6671 New method.
6672
b4094625
TT
66732019-07-17 Tom Tromey <tom@tromey.com>
6674
6675 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6676 declare.
6677 * tui/tui-windata.c
6678 (tui_data_window::delete_data_content_windows): Rename from
6679 tui_delete_data_content_windows.
6680 (tui_data_window::display_all_data)
6681 (tui_data_window::do_scroll_vertical): Update.
6682 * tui/tui-data.h (struct tui_data_window)
6683 <delete_data_content_windows>: New method.
6684
c223a729
TT
66852019-07-17 Tom Tromey <tom@tromey.com>
6686
6687 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6688 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6689
50daf268
TT
66902019-07-17 Tom Tromey <tom@tromey.com>
6691
6692 * tui/tui-windata.h (tui_display_all_data): Don't declare.
6693 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6694 from tui_display_all_data.
6695 * tui/tui-win.c
6696 (tui_data_window::do_make_visible_with_new_height): Update.
6697 * tui/tui-regs.c (tui_show_registers): Update.
6698 * tui/tui-layout.c (tui_set_layout): Update.
6699 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6700 method.
6701
df5f8cab
TT
67022019-07-17 Tom Tromey <tom@tromey.com>
6703
6704 * tui/tui-windata.h (tui_display_data_from): Don't declare.
6705 * tui/tui-windata.c (tui_display_data_from): Remove.
6706 (tui_data_window::refresh_all): Update.
6707
80cb6c27
TT
67082019-07-17 Tom Tromey <tom@tromey.com>
6709
6710 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6711 * tui/tui-windata.c (tui_display_data_from_line): Remove.
6712 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6713 tui_display_registers_from_line.
6714 * tui/tui-regs.h (tui_display_registers_from_line): Update.
6715 * tui/tui-regs.c (tui_display_registers_from_line): Remove
6716 "force_display" parameter.
6717
baff0c28
TT
67182019-07-17 Tom Tromey <tom@tromey.com>
6719
6720 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6721 declare.
6722 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6723 Rename from tui_first_reg_element_no_inline.
6724 (tui_display_reg_element_at_line)
6725 (tui_display_registers_from_line): Update.
6726 * tui/tui-data.h (struct tui_data_window)
6727 <first_reg_element_no_inline>: New method.
6728
3b23c5f2
TT
67292019-07-17 Tom Tromey <tom@tromey.com>
6730
6731 * tui/tui-windata.c (tui_display_data_from)
6732 (tui_data_window::do_scroll_vertical): Update.
6733 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6734 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6735 Rename from tui_line_from_reg_element_no.
6736 (tui_display_registers_from_line): Update.
6737 * tui/tui-data.h (struct tui_data_window)
6738 <line_from_reg_element_no>: New method.
6739
0b5ec218
TT
67402019-07-17 Tom Tromey <tom@tromey.com>
6741
6742 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6743 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6744 tui_last_regs_line_no.
6745 (tui_display_reg_element_at_line)
6746 (tui_display_registers_from_line): Update.
6747 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6748 method.
6749
0807ab7b
TT
67502019-07-17 Tom Tromey <tom@tromey.com>
6751
6752 PR tui/24722:
6753 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6754 (tui_update_breakpoint_info): Add "being_deleted" parameter.
6755 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6756 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6757 (tui_update_breakpoint_info): Likewise.
6758 * tui/tui-hooks.c (tui_event_create_breakpoint)
6759 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6760 Update.
6761
9ad7fdef
TT
67622019-07-17 Tom Tromey <tom@tromey.com>
6763
6764 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6765
5813316f
TT
67662019-07-17 Tom Tromey <tom@tromey.com>
6767
6768 * tui/tui-winsource.c (tui_update_source_window_as_is)
6769 (tui_update_source_windows_with_addr): Update.
6770 * tui/tui-source.h (tui_set_source_content)
6771 (tui_show_symtab_source): Add "win_info" parameter.
6772 * tui/tui-source.c (tui_set_source_content): Add "win_info"
6773 parameter.
6774 (tui_show_symtab_source): Likewise.
6775
00e264e7
TT
67762019-07-17 Tom Tromey <tom@tromey.com>
6777
6778 * tui/tui-wingeneral.c
6779 (tui_check_and_display_highlight_if_needed): Check can_highlight.
6780
06210ce4
TT
67812019-07-17 Tom Tromey <tom@tromey.com>
6782
6783 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6784 (struct tui_cmd_window) <can_scroll>: New method.
6785 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6786 method.
6787
381befee
TT
67882019-07-17 Tom Tromey <tromey@adacore.com>
6789
6790 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6791 do_field_signed>: Rename. Change type of "value".
6792 * ui-out.c (ui_out::field_signed): Rename from field_int.
6793 Change type of "value".
6794 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
6795 type of "value".
6796 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6797 do_field_int. Change type of "value".
6798 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6799 do_field_int. Change type of "value".
6800 * tracepoint.c (trace_status_mi, tfind_1)
6801 (print_one_static_tracepoint_marker): Update.
6802 * thread.c (print_thread_info_1, print_selected_thread_frame):
6803 Update.
6804 * stack.c (print_frame, print_frame_info): Update.
6805 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6806 Update.
6807 * source.c (print_source_lines_base): Update.
6808 * skip.c (info_skip_command): Update.
6809 * record-btrace.c (btrace_ui_out_decode_error)
6810 (btrace_call_history_src_line): Update.
6811 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6812 Update.
6813 * progspace.c (print_program_space): Update.
6814 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6815 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6816 do_field_int. Change type of "value".
6817 * mi/mi-out.c (mi_ui_out::do_table_begin)
6818 (mi_ui_out::do_table_header): Update.
6819 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
6820 type of "value".
6821 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6822 (mi_cmd_data_list_changed_registers, output_register)
6823 (mi_cmd_data_read_memory, mi_load_progress)
6824 (mi_cmd_trace_frame_collected): Update.
6825 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6826 Update.
6827 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6828 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6829 (mi_cmd_var_list_children, varobj_update_one): Update.
6830 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6831 (mi_cmd_stack_list_args, list_arg_or_local): Update.
6832 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6833 * inferior.c (print_inferior): Update.
6834 * gdb_bfd.c (print_one_bfd): Update.
6835 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6836 Update.
6837 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6838 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6839 do_field_int. Change type of "value".
6840 * cli-out.c (cli_ui_out::do_field_signed): Rename from
6841 do_field_int. Change type of "value".
6842 * breakpoint.c (watchpoint_check, print_breakpoint_location)
6843 (print_one_breakpoint_location, print_it_catch_fork)
6844 (print_one_catch_fork, print_it_catch_vfork)
6845 (print_one_catch_vfork, print_it_catch_solib)
6846 (print_it_catch_exec, print_it_ranged_breakpoint)
6847 (print_mention_watchpoint, print_mention_masked_watchpoint)
6848 (bkpt_print_it, update_static_tracepoint): Update.
6849 * break-catch-throw.c (print_it_exception_catchpoint): Update.
6850 * break-catch-syscall.c (print_it_catch_syscall): Update.
6851 * ada-tasks.c (print_ada_task_info): Update.
6852 * ada-lang.c (print_it_exception, print_mention_exception):
6853 Update.
6854
6b78c3f8
AB
68552019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
6856
6857 PR breakpoints/24541
6858 * gdbarch.c: Regenerate.
6859 * gdbarch.h: Regenerate.
6860 * gdbarch.sh: Adjust return type and parameter types for
6861 'stap_adjust_register'.
6862 (i386_stap_adjust_register): Adjust signature and return new
6863 register name.
6864 * stap-probe.c (stap_parse_register_operand): Adjust use of
6865 'gdbarch_stap_adjust_register'.
6866
d72a9b85
TT
68672019-07-17 Tom Tromey <tromey@adacore.com>
6868
6869 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
6870 declare VEC.
6871 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6872 std::vector.
6873 (struct s390_process_info): Add initializers.
6874 (s390_add_process): Use new.
6875 (s390_linux_nat_target::low_forget_process): Use delete.
6876 (s390_linux_nat_target::low_new_fork)
6877 (s390_linux_nat_target::stopped_by_watchpoint)
6878 (s390_linux_nat_target::low_prepare_to_resume)
6879 (s390_linux_nat_target::insert_watchpoint)
6880 (s390_linux_nat_target::insert_hw_breakpoint)
6881 (s390_linux_nat_target::remove_watchpoint)
6882 (s390_linux_nat_target::remove_hw_breakpoint): Update.
6883
206e6c58
JB
68842019-07-16 John Baldwin <jhb@FreeBSD.org>
6885
6886 * aarch64-fbsd-nat.c: Include regcache.h.
6887 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6888 argument.
6889 (aarch64_fbsd_nat_target::fetch_registers)
6890 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6891 variable.
6892 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6893
cbde90f2
JB
68942019-07-16 John Baldwin <jhb@FreeBSD.org>
6895
6896 * fbsd-nat.c: Include gdbarch.h.
6897
07128006
TT
68982019-07-15 Tom Tromey <tromey@adacore.com>
6899
6900 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6901
1f77b012
TT
69022019-07-15 Tom Tromey <tromey@adacore.com>
6903
6904 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6905 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6906 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6907 * cli-out.c (cli_ui_out::do_field_int): New method.
6908 * ui-out.c (ui_out::field_unsigned): New method.
6909 * symfile.c (generic_load): Use field_unsigned.
6910 (print_transfer_performance): Likewise.
6911 * record-btrace.c (ui_out_field_uint): Remove.
6912 (btrace_call_history_insn_range, btrace_call_history): Use
6913 field_unsigned.
6914 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6915 field_unsigned.
6916 * ui-out.h (class ui_out) <field_unsigned>: New method.
6917 <do_field_unsigned>: Likewise.
6918
33eca680
TT
69192019-07-15 Tom Tromey <tromey@adacore.com>
6920
6921 * mi/mi-main.c (list_available_thread_groups): Use field_string.
6922 * mi/mi-interp.c (mi_memory_changed): Use field_string.
6923 * target.c (flash_erase_command): Use field_string.
6924 * infrun.c (print_signal_received_reason): Use field_string.
6925 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6926 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6927 field_string.
6928 * ada-tasks.c (print_ada_task_info): Use field_string.
6929
ca8d69be
TT
69302019-07-15 Tom Tromey <tromey@adacore.com>
6931
6932 * target.c (flash_erase_command): Use field_core_addr.
6933 * symfile.c (generic_load): Use field_core_addr.
6934 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6935 Use field_core_addr.
6936 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6937 field_core_addr.
6938
0d4e84ed
AB
69392019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6940
6941 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6942 value if its desired type is smaller than a CORE_ADDR and signed.
6943
9a49df9d
AB
69442019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6945
6946 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6947 of changes to field names, and use new is_reference field to
6948 decide if a property is a reference or not.
6949 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6950 field.
6951 (struct dwarf2_property_baton): Update header comment, rename
6952 'referenced_type' to 'property_type' and update comments.
6953 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6954 default property type, store in property baton, update to take
6955 accound of renamed field.
6956 (read_func_scope): Update call to attr_to_dynamic_prop.
6957 (read_array_type): Likewise.
6958 (dwarf2_per_cu_addr_sized_int_type): New function.
6959 (read_subrange_index_type): Move type finding code to
6960 dwarf2_per_cu_addr_sized_int_type.
6961 (read_subrange_type): Update calls to attr_to_dynamic_prop.
6962 (dwarf2_per_cu_addr_type): New function.
6963 (set_die_type): Update calls to attr_to_dynamic_prop.
6964
b86352cf
AB
69652019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6966
6967 * dwarf2read.c (read_subrange_index_type): New function.
6968 (read_subrange_type): Move code into new function and call it.
6969 * gdbtypes.c (create_range_type): Add some asserts.
6970
603490bf
AB
69712019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6972
6973 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6974 update return statements.
6975 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6976 declaration, and update comment to match.
6977 * gdbtypes.c (resolve_dynamic_array): Update call to
6978 dwarf2_evaluate_property to match new return type.
6979
592f9d27
AB
69802019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6981
6982 * valarith.c (value_subscripted_rvalue): Change lowerbound
6983 parameter type from int to LONGEST.
6984 * value.h (value_subscripted_rvalue): Likewise in declaration.
6985
60cfcb20
AB
69862019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6987
6988 * cli/cli-utils.c (info_print_command_completer): New function.
6989 * cli/cli-utils.h: Add 'completer.h' include, and forward
6990 declaration for 'struct cmd_list_element'.
6991 (info_print_command_completer): Declare.
6992 * stack.c (_initialize_stack): Add completer for 'info locals' and
6993 'info args'.
6994 * symtab.c (_initialize_symtab): Add completer for 'info
6995 variables' and 'info functions'.
6996 * NEWS: Mention completion for additional info commands.
6997
b16507e0
AB
69982019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6999
7000 * cli/cli-utils.c (extract_info_print_args): Delete.
7001 (extract_arg_maybe_quoted): Delete.
7002 (info_print_options_defs): New variable.
7003 (make_info_print_options_def_group): New function.
7004 (extract_info_print_options): Define new function.
7005 * cli/cli-utils.h (extract_info_print_args): Delete.
7006 (struct info_print_options): New structure.
7007 (extract_info_print_options): Declare new function.
7008 * stack.c (info_locals_command): Update to use new
7009 extract_info_print_options, also add a header comment.
7010 (info_args_command): Likewise.
7011 * symtab.c (info_variables_command): Likewise.
7012 (info_functions_command): Likewise.
7013
021d8588
AB
70142019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7015
7016 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7017 to extract string arguments.
7018 * common/common-utils.c (extract_string_maybe_quoted): New function.
7019 * common/common-utils.h (extract_string_maybe_quoted): Declare.
7020
b777eb6d
TT
70212019-07-11 Tom Tromey <tromey@adacore.com>
7022
7023 * main.c (get_init_files): Use GDBINIT, not gdbinit.
7024 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7025 * top.h (gdbinit): Don't declare.
7026 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7027 into...
7028 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
7029 * top.c (gdb_init): Don't call init_cli_cmds.
7030 (gdbinit): Remove.
7031 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7032
72ee03ff
TT
70332019-07-11 Tom Tromey <tromey@adacore.com>
7034
7035 * python/py-inferior.c (add_thread_object): Don't use thread_obj
7036 after it has been moved.
7037
00db9531
SM
70382019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7039
7040 * valops.c (value_must_coerce_to_target): Change return type to
7041 bool.
7042 * value.h (value_must_coerce_to_target): Likewise.
7043
f2478a7e
SM
70442019-07-10 Simon Marchi <simon.marchi@efficios.com>
7045
7046 * breakpoint.c (is_hardware_watchpoint): Remove
7047 forward-declaration.
7048 (is_masked_watchpoint): Change return type to bool.
7049 (is_tracepoint): Likewise.
7050 (is_breakpoint): Likewise.
7051 (is_hardware_watchpoint): Likewise.
7052 (is_watchpoint): Likewise.
7053 (is_no_memory_software_watchpoint): Likewise.
7054 (is_catchpoint): Likewise.
7055 (breakpoint_1): Make FILTER parameter's return type bool.
7056 is_masked_watchpoint): Change return type to bool.
7057 (save_breakpoints): Make FILTER parameter's return type bool.
7058 * breakpoint.h (is_breakpoint): Change return type to bool.
7059 (is_watchpoint): Likewise.
7060 (is_catchpoint): Likewise.
7061 (is_tracepoint): Likewise.
7062
0d12e84c
TT
70632019-07-10 Tom Tromey <tom@tromey.com>
7064
7065 * defs.h: Don't include gdbarch.h.
7066 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7067 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7068 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7069 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7070 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7071 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7072 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7073 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7074 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7075 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7076 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7077 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7078 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7079 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7080 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7081 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7082 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7083 record-btrace.c, record.h, regcache-dump.c, regcache.h,
7084 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7085 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7086 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7087 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7088 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7089 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7090 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7091 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7092 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7093
f06f1252
TT
70942019-07-10 Tom Tromey <tromey@adacore.com>
7095
7096 * ada-lang.h (is_ada_exception_catchpoint): Declare.
7097 * breakpoint.c (init_ada_exception_breakpoint): Register as
7098 bp_catchpoint.
7099 (print_one_breakpoint_location, print_one_breakpoint): Use
7100 is_ada_exception_catchpoint.
7101 * ada-lang.c (class ada_catchpoint_location): Pass
7102 bp_loc_software_breakpoint to bp_location constructor.
7103 (is_ada_exception_catchpoint): New function.
7104
7a5d944b
TT
71052019-07-10 Tom Tromey <tromey@adacore.com>
7106
7107 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
7108 VEC.
7109 (struct arm_exidx_entry): New method operator<.
7110 (struct arm_exidx_data) <section_maps>: Change type.
7111 (arm_exidx_data_free): Remove.
7112 (arm_exidx_data_key): Change type. Move lower.
7113 (arm_exidx_new_objfile): Update.
7114 (arm_compare_exidx_entries): Remove.
7115 (arm_find_exidx_entry, _initialize_arm_tdep)
7116
48c66e1d
TT
71172019-07-10 Tom Tromey <tromey@adacore.com>
7118
7119 * solib-spu.c (ocl_program_data_key): Change type.
7120 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7121 Update.
7122
a269fbf1
TT
71232019-07-10 Tom Tromey <tromey@adacore.com>
7124
7125 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
7126 (struct solib_aix_inferior_data) <library_list>: Change type.
7127 (solib_aix_inferior_data_handle): Change type.
7128 (get_solib_aix_inferior_data): Update.
7129 (solib_aix_free_library_list): Remove.
7130 (library_list_start_library): Update.
7131 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7132 return type.
7133 (solib_aix_get_library_list)
7134 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7135 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7136
c294730c
TT
71372019-07-10 Tom Tromey <tromey@adacore.com>
7138
7139 * solib-dsbt.c (struct dsbt_info): Add initializers.
7140 (solib_dsbt_pspace_data): Change type.
7141 (dsbt_pspace_data_cleanup): Remove.
7142 (get_dsbt_info, _initialize_dsbt_solib): Update.
7143
9d52077d
TT
71442019-07-10 Tom Tromey <tromey@adacore.com>
7145
7146 * spu-tdep.c (spu_overlay_data): Change type.
7147 (spu_get_overlay_table, spu_overlay_new_objfile)
7148 (_initialize_spu_tdep): Update.
7149
22a20dca
TT
71502019-07-10 Tom Tromey <tromey@adacore.com>
7151
7152 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7153 destructor.
7154 (dbx_objfile_data_key): Change type and declare later.
7155 (DBX_SYMFILE_INFO): Rewrite.
7156 * dbxread.c (dbx_objfile_data_key): Change type.
7157 (dbx_symfile_init): Update.
7158 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7159 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7160 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7161
cb60f420
TT
71622019-07-10 Tom Tromey <tromey@adacore.com>
7163
7164 * jit.c (jit_program_space_key): Change type. Move lower.
7165 (get_jit_program_space_data): Update.
7166 (jit_program_space_data_cleanup): Remove.
7167 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7168 Update.
7169 (struct jit_program_space_data): Add initializers.
7170
51df2ae3
TT
71712019-07-10 Tom Tromey <tromey@adacore.com>
7172
7173 * solib-darwin.c (struct darwin_info): Add initializers.
7174 (solib_darwin_pspace_data): Change type.
7175 (darwin_pspace_data_cleanup): Remove.
7176 (get_darwin_info, _initialize_darwin_solib): Update.
7177
18101a35
TT
71782019-07-10 Tom Tromey <tromey@adacore.com>
7179
7180 * remote-sim.c (struct sim_inferior_data): Add initializers,
7181 constructor, and destructor.
7182 (sim_inferior_data_key): Change type. Move lower.
7183 (check_for_duplicate_sim_descriptor): Update.
7184 (get_sim_inferior_data): Use new. Update.
7185 (~sim_inferior_data_cleanup): Rename from
7186 sim_inferior_data_cleanup. Simplify.
7187 (gdbsim_close_inferior, simulator_command)
7188 (sim_command_completer, _initialize_remote_sim): Update.
7189 (next_pid, INITIAL_PID): Move earlier.
7190
05b08ac1
TT
71912019-07-10 Tom Tromey <tromey@adacore.com>
7192
7193 * python/python-internal.h (create_thread_object): Return
7194 gdbpy_ref.
7195 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7196 * python/py-inferior.c (struct threadlist_entry): Add
7197 constructor.
7198 <thread_obj>: Now a gdbpy_ref.
7199 (thread_to_thread_object): Update.
7200 (add_thread_object): Use new.
7201 (delete_thread_object): Use delete.
7202 (infpy_threads): Update.
7203 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7204 GIL.
7205
32372d80
TT
72062019-07-10 Tom Tromey <tromey@adacore.com>
7207
7208 * valops.c (value_cast): Specialize error message for Ada.
7209
5c458ae8
SM
72102019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7211
7212 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7213
4c462cb0
SM
72142019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7215
7216 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7217 bpstat_should_step): Return bool, adjust comments.
7218 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7219 bpstat_should_step): Likewise.
7220
89abbcc2
AH
72212019-07-10 Alan Hayward <alan.hayward@arm.com>
7222
7223 * features/Makefile: Use feature target descriptions for Arm.
7224 * features/arm/arm-core.c: Generate new file.
7225 * features/arm/arm-fpa.c: Likewise.
7226 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7227 * features/arm/arm-m-profile.c: Likewise.
7228 * features/arm/arm-vfpv2.c: Likewise.
7229 * features/arm/arm-vfpv3.c: Likewise.
7230 * features/arm/xscale-iwmmxt.c: Likewise.
7231 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7232
166a82be
AH
72332019-07-10 Alan Hayward <alan.hayward@arm.com>
7234
7235 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7236 ptrace earlier.
7237
9fb4c7e9
AH
72382019-07-10 Alan Hayward <alan.hayward@arm.com>
7239
7240 * features/aarch64-pauth.c: Regenerate.
7241
e2d0f980
SM
72422019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7243
7244 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7245 bool.
7246 (bpstat_what): Use false instead of 0.
7247
a38118e5
PA
72482019-07-09 Pedro Alves <palves@redhat.com>
7249
7250 * break-catch-throw.c (is_exception_catchpoint): New.
7251 * breakpoint.c (print_one_breakpoint_location): New parameter
7252 'raw_loc'. Handle it. Use
7253 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7254 looking at the breakpoint's type.
7255 (print_one_breakpoint): If handling "maint info breakpoints", also
7256 print locations of exception catchpoints.
7257 * breakpoint.h (is_exception_catchpoint): Declare.
7258
cb1e4e32
PA
72592019-07-09 Pedro Alves <palves@redhat.com>
7260
7261 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7262 "addr" field.
7263 (allocate_location_exception_catchpoint): New.
7264 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7265 (initialize_throw_catchpoint_ops): Install
7266 allocate_location_exception_catchpoint as allocate_location
7267 method.
7268 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7269 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7270 bp_loc_other.
7271 (breakpoint_address_is_meaningful): Delete.
7272 (bl_address_is_meaningful): New.
7273 (breakpoint_locations_match): Adjust comment.
7274 (bp_location_from_bp_type): New, factored out of...
7275 (bp_location::bp_location(breakpoint *)): ... this.
7276 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7277 factored out of...
7278 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7279 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7280 breakpoint_address_is_meaningful.
7281 (bp_locations_compare): Adjust comment.
7282 (update_global_location_list): Use bl_address_is_meaningful
7283 instead of breakpoint_address_is_meaningful.
7284 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7285 explicit.
7286 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7287 * python/py-breakpoint.c (bppy_get_location): No longer check
7288 whether location is null.
7289
b58a68fe
PA
72902019-07-09 Pedro Alves <palves@redhat.com>
7291
7292 PR c++/15468
7293 * breakpoint.c (print_one_breakpoint_location): Remove
7294 single-location assert.
7295
268a13a5
TT
72962019-07-09 Tom Tromey <tom@tromey.com>
7297
7298 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7299 * configure: Rebuild.
7300 * configure.ac: Change common to gdbsupport.
7301 * gdbsupport: Rename from common.
7302 * acinclude.m4: Change common to gdbsupport.
7303 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7304 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7305 gdbsupport.
7306 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7307 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7308 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7309 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7310 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7311 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7312 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7313 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7314 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7315 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7316 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7317 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7318 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7319 coff-pe-read.c, command.h, compile/compile-c-support.c,
7320 compile/compile-c.h, compile/compile-cplus-symbols.c,
7321 compile/compile-cplus-types.c, compile/compile-cplus.h,
7322 compile/compile-loc2c.c, compile/compile.c, completer.c,
7323 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7324 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7325 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7326 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7327 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7328 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7329 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7330 features/aarch64-core.c, features/aarch64-fpu.c,
7331 features/aarch64-pauth.c, features/aarch64-sve.c,
7332 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7333 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7334 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7335 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7336 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7337 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7338 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7339 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7340 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7341 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7342 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7343 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7344 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7345 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7346 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7347 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7348 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7349 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7350 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7351 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7352 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7353 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7354 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7355 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7356 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7357 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7358 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7359 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7360 minsyms.c, mips-linux-tdep.c, namespace.h,
7361 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7362 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7363 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7364 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7365 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7366 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7367 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7368 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7369 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7370 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7371 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7372 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7373 procfs.c, producer.c, progspace.h, psymtab.h,
7374 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7375 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7376 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7377 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7378 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7379 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7380 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7381 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7382 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7383 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7384 target-memory.c, target.c, target.h, target/waitstatus.c,
7385 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7386 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7387 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7388 unittests/array-view-selftests.c,
7389 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7390 unittests/common-utils-selftests.c,
7391 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7392 unittests/format_pieces-selftests.c,
7393 unittests/function-view-selftests.c,
7394 unittests/lookup_name_info-selftests.c,
7395 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7396 unittests/mkdir-recursive-selftests.c,
7397 unittests/observable-selftests.c,
7398 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7399 unittests/parse-connection-spec-selftests.c,
7400 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7401 unittests/scoped_fd-selftests.c,
7402 unittests/scoped_mmap-selftests.c,
7403 unittests/scoped_restore-selftests.c,
7404 unittests/string_view-selftests.c, unittests/style-selftests.c,
7405 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7406 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7407 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7408 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7409 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7410 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7411
5b0e2db4
AB
74122019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7413
7414 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7415 bool value.
7416 (decode_digits_ordinary): Set explicit_line field in sal.
7417 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7418 symtab_and_line that was set on an explicit line number in
7419 assembler code. Do always update the recorded symtab and line if
7420 we do skip the prologue.
7421
0ba852ab
AB
74222019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7423
7424 * breakpoint.c (set_breakpoint_location_function): Remove
7425 explicit_loc parameter.
7426 (momentary_breakpoint_from_master): Update call to
7427 set_breakpoint_location_function.
7428 (add_location_to_breakpoint): Likewise.
7429
b3a7d171
AB
74302019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7431
7432 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7433 required features based on default bfd type when no specific bfd
7434 is present.
7435
1f6f6e21
PW
74362019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7437
7438 * NEWS: Mention that GDB printf and eval commands can now print
7439 C-style and Ada-style convenience var strings without
7440 calling the inferior.
7441 * printcmd.c (printf_c_string): Locally print GDB internal var
7442 instead of transiting via the inferior.
7443 (printf_wide_c_string): Likewise.
7444
74452019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf 7446
5862c886 7447 PR breakpoints/25011
ea142fbf
AH
7448 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7449
0598af48
TT
74502019-07-04 Tom Tromey <tom@tromey.com>
7451
7452 PR tui/24724:
7453 * tui/tui-winsource.c (tui_clear_source_content): Update.
7454 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7455 (tui_update_breakpoint_info): Update.
7456 (tui_set_exec_info_content): Update.
7457 * tui/tui-source.c (tui_set_source_content_nil): Update.
7458 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7459 has_break.
7460 * tui/tui-data.h (enum tui_bp_flag): New.
7461 (tui_bp_flags): New enum flags type.
7462 (struct tui_source_element) <break_mode>: Change type. Rename
7463 from has_break.
7464 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7465 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7466 constants.
7467 * tui/tui-winsource.h: Fix comment.
7468
350fab54
AH
74692019-07-04 Alan Hayward <alan.hayward@arm.com>
7470
7471 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7472 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7473 (store_fpregs_to_thread)
7474 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7475 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7476 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7477 (IWMMXT_REGS_SIZE): Add define.
7478 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7479 (fetch_vfp_regs, store_vfp_regs)
7480 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7481 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7482
f0452268
AH
74832019-07-04 Alan Hayward <alan.hayward@arm.com>
7484
7485 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7486 defines.
7487 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7488 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7489 (ARM_INT_REGISTER_SIZE): ...to this.
7490 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7491 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7492 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7493 (arm_linux_collect_gregset, supply_nwfpe_register)
7494 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7495 defines.
7496 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7497 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7498 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7499 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7500 (arm_return_in_memory, arm_store_return_value)
7501 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7502 (arm_record_ld_st_multiple): Likewise.
7503 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7504 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7505
e935475c
AH
75062019-07-04 Alan Hayward <alan.hayward@arm.com>
7507
7508 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7509 AARCH64_DISPLACED_MODIFIED_INSNS.
7510 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7511 (aarch64_displaced_step_copy_insn): Likewise.
7512 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7513 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7514 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7515 ARM_DISPLACED_MODIFIED_INSNS.
7516 * arm-tdep.c (arm_gdbarch_init): Likewise.
7517 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7518 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7519 (struct arm_displaced_step_closure): Use
7520 ARM_DISPLACED_MODIFIED_INSNS.
7521
df0bb381
AH
75222019-07-04 Alan Hayward <alan.hayward@arm.com>
7523
7524 * features/Makefile: Remove unused xml files.
7525 * features/aarch64.xml: Remove.
7526 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7527 * features/i386/amd64-avx-avx512.xml: Remove.
7528 * features/i386/amd64-avx-linux.xml: Remove.
7529 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7530 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7531 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7532 * features/i386/amd64-avx-mpx.xml: Remove.
7533 * features/i386/amd64-avx.xml: Remove.
7534 * features/i386/amd64-linux.xml: Remove.
7535 * features/i386/amd64-mpx-linux.xml: Remove.
7536 * features/i386/amd64-mpx.xml: Remove.
7537 * features/i386/amd64.xml: Remove.
7538 * features/i386/i386-avx-avx512-linux.xml: Remove.
7539 * features/i386/i386-avx-avx512.xml: Remove.
7540 * features/i386/i386-avx-linux.xml: Remove.
7541 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7542 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7543 * features/i386/i386-avx-mpx-linux.xml: Remove.
7544 * features/i386/i386-avx-mpx.xml: Remove.
7545 * features/i386/i386-avx.xml: Remove.
7546 * features/i386/i386-linux.xml: Remove.
7547 * features/i386/i386-mmx-linux.xml: Remove.
7548 * features/i386/i386-mmx.xml: Remove.
7549 * features/i386/i386-mpx-linux.xml: Remove.
7550 * features/i386/i386-mpx.xml: Remove.
7551 * features/i386/i386.xml: Remove.
7552 * features/i386/x32-avx-avx512-linux.xml: Remove.
7553 * features/i386/x32-avx-linux.xml: Remove.
7554 * features/i386/x32-linux.xml: Remove.
7555
edd6266a
AH
75562019-07-04 Alan Hayward <alan.hayward@arm.com>
7557
7558 * regformats/aarch64.dat: Remove.
7559 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7560 * regformats/i386/amd64-avx-linux.dat: Remove.
7561 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7562 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7563 * regformats/i386/amd64-linux.dat: Remove.
7564 * regformats/i386/amd64-mpx-linux.dat: Remove.
7565 * regformats/i386/amd64.dat: Remove.
7566 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7567 * regformats/i386/i386-avx-linux.dat: Remove.
7568 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7569 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7570 * regformats/i386/i386-linux.dat: Remove.
7571 * regformats/i386/i386-mmx-linux.dat: Remove.
7572 * regformats/i386/i386-mpx-linux.dat: Remove.
7573 * regformats/i386/i386.dat: Remove.
7574 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7575 * regformats/i386/x32-avx-linux.dat: Remove.
7576 * regformats/i386/x32-linux.dat: Remove.
7577
2b40fda7
AH
75782019-07-04 Alan Hayward <alan.hayward@arm.com>
7579
7580 * aarch64-tdep.c: Remove xml self tests.
7581 * amd64-linux-tdep.c: Likewise.
7582 * amd64-tdep.c: Likewise.
7583 * i386-linux-tdep.c: Likewise.
7584 * i386-tdep.c: Likewise.
7585
5f4ba3e7
PA
75862019-07-03 Pedro Alves <palves@redhat.com>
7587
7588 PR cli/24732
7589 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7590 (pipe_cmd_option_defs): New.
7591 (make_pipe_cmd_options_def_group): New.
7592 (pipe_command): Use gdb::option::process_options.
7593 (pipe_command_completer): New function.
7594 (_initialize_cli_cmds): Install completer for "pipe" command.
7595
3d9be6f5
PA
75962019-07-03 Pedro Alves <palves@redhat.com>
7597
7598 * cli/cli-option.c (union option_value) <string>: New field.
7599 (struct option_def_and_value): Add ctor, move ctor, dtor and
7600 use DISABLE_COPY_AND_ASSIGN.
7601 (option_def_and_value::clear_value): New.
7602 (parse_option, save_option_value_in_ctx, get_val_type_str)
7603 (add_setshow_cmds_for_options): Handle var_string.
7604 * cli-option.h (union option_def::var_address) <string>: New
7605 field.
7606 (struct string_option_def): New.
7607 * maint-test-options.c (struct test_options_opts): Add default
7608 ctor and use DISABLE_COPY_AND_ASSIGN.
7609 <string_opt>: New field.
7610 (test_options_opts::~test_options_opts): New.
7611 (test_options_opts::dump): Also dump "-string".
7612 (test_options_option_defs): Install "string.
7613
41fc454c
PA
76142019-07-03 Pedro Alves <palves@redhat.com>
7615
7616 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7617 option_value with a null enumeration.
7618 (complete_options): Save the option values in the context.
7619 (save_option_value_in_ctx): New, factored out from ...
7620 (process_options): ... here.
7621 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7622 of the function.
7623 * maint-test-options.c (test_options_opts::dump): New, factored
7624 out from ...
7625 (maintenance_test_options_command_mode): ... here.
7626 (maintenance_test_options_command_completion_result): Delete.
7627 (maintenance_test_options_command_completion_text): Update
7628 comment.
7629 (maintenance_show_test_options_completion_result): Change
7630 prototype. Just print
7631 maintenance_test_options_command_completion_text.
7632 (save_completion_result): New.
7633 (maintenance_test_options_completer_mode): Pass options context to
7634 complete_options, and then save a dump.
7635 (_initialize_maint_test_options): Use add_cmd to install "maint
7636 show test-options-completion-result".
7637
fdbc9870
PA
76382019-07-03 Pedro Alves <palves@redhat.com>
7639
7640 * NEWS (New commands): Mention "with" and "maint with".
7641 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7642 (with_command, with_command_completer): New.
7643 (pipe_command): Adjust to new repeat_previous
7644 interface.
7645 (_initialize_cli_cmds): Install the "with" command and its "w"
7646 alias.
7647 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7648 declarations.
7649 * cli/cli-setshow.c (parse_cli_var_uinteger)
7650 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7651 argument strings for all var_types.
7652 (get_setshow_command_value_string): New, factored out from ...
7653 (do_show_command): ... this.
7654 * cli/cli-setshow.h: Include <string>.
7655 (get_setshow_command_value_string): Declare.
7656 * command.h (repeat_previous): Now returns const char *. Adjust
7657 comment.
7658 * maint.c: Include "cli/cli-cmds.h".
7659 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7660 (_initialize_maint_cmds): Register the "maintenance with" command.
7661 * top.c (repeat_previous): Move bits from pipe_command here:
7662 Return the saved command line, if any; error out if there's no
7663 command to relaunch.
7664
c6ac8931
PA
76652019-07-03 Pedro Alves <palves@redhat.com>
7666
7667 * NEWS (New commands): Mention "maint set/show test-settings"
7668 instead of "maint test-settings".
7669 * maint-test-settings.c (maintenance_test_settings_list): Delete.
7670 (maintenance_test_settings_set_list): Rename to ...
7671 (maintenance_set_test_settings_list): ... this.
7672 (maintenance_test_settings_show_list): Rename to ...
7673 (maintenance_show_test_settings_list): ... this.
7674 (maintenance_test_settings_cmd): Delete.
7675 (maintenance_test_settings_set_cmd): ...
7676 (maintenance_set_test_settings_cmd): ... this.
7677 (maintenance_test_settings_show_cmd): ...
7678 (maintenance_show_test_settings_cmd): ... this.
7679 (maintenance_test_settings_show_value_cmd):
7680 (maintenance_show_test_settings_value_cmd): ... this.
7681 (_initialize_maint_test_settings): No longer install the "maint
7682 test-settings" prefix command. Rename "maint test-settings set"
7683 to "maint set test-settings", and "maint test-settings show" to
7684 "maint show test-settings". Adjust all subcommands.
7685
d1fcf2fd
PA
76862019-07-03 Pedro Alves <palves@redhat.com>
7687
7688 * maint-test-settings.c: Fix file's intro comment. Replace all
7689 references to "test-options" with references to "test-settings",
7690 in comments.
7691
970f9d09
PA
76922019-07-03 Pedro Alves <palves@redhat.com>
7693
7694 * maint-test-settings.c (maintenance_test_settings_xxx)
7695 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7696 New.
7697 (maintenance_test_settings_enums): Use them.
7698 (maintenance_test_settings_enum): Default to
7699 maintenance_test_settings_xxx.
7700 (_initialize_maint_test_settings): Initialize
7701 MAINTENANCE_TEST_SETTINGS_FILENAME.
7702
f3869b1a
SM
77032019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7704
7705 * breakpoint.h (remove_breakpoints_inf): Change return type to
7706 void, move function documentation here.
7707 * breakpoint.c (remove_breakpoints_inf): Change return type to
7708 void, move function documentation to header.
7709
54d66006
PA
77102019-07-02 Pedro Alves <palves@redhat.com>
7711
7712 * NEWS (Completion improvements): Mention "info threads".
7713 * thread.c (struct info_threads_opts, info_threads_option_defs)
7714 (make_info_threads_options_def_group): New.
7715 (info_threads_command): Use gdb::option::process_options.
7716 (info_threads_command_completer): New.
7717 (_initialize_thread): Use gdb::option::build_help to build the
7718 help text for "info threads".
7719
854f6088
SM
77202019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7721
7722 * defs.h (generic_load): Move from here...
7723 * symfile.h (generic_load): ... to here. Rename name parameter
7724 to args.
7725 * symfile.c (generic_load): Add comment.
7726
54ee4252
TT
77272019-07-01 Tom Tromey <tromey@adacore.com>
7728
7729 * dwarf2read.c
7730 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7731 declaration of without_params. Fix formatting.
7732
65392b3e
TT
77332019-07-01 Tom Tromey <tromey@adacore.com>
7734
7735 * ada-exp.y (find_primitive_type): Update.
7736 * ada-lang.h (ada_lookup_symbol): Update.
7737 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7738 parameter.
7739 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7740
7d7571f0
SDJ
77412019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7742
7743 PR breakpoints/24541
7744 * gdbarch.c: Regenerate.
7745 * gdbarch.h: Regenerate.
7746 * gdbarch.sh: Add 'stap_adjust_register'.
7747 * i386-tdep.c: Include '<unordered_set>'.
7748 (i386_stap_adjust_register): New function.
7749 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7750 * stap-probe.c (stap_parse_register_operand): Call
7751 'gdbarch_stap_adjust_register'.
7752
5af5392a
SDJ
77532019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7754
7755 PR python/24742
7756 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7757 * python/python.c (do_start_initialization): Use 'xmalloc'
7758 instead of 'PyMem_Malloc'.
7759
10d06d82
TT
77602019-06-28 Tom Tromey <tromey@adacore.com>
7761
7762 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7763 for Ada.
7764
1b7f24cd
TT
77652019-06-27 Tom Tromey <tromey@adacore.com>
7766
7767 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
7768 objfile_key.
7769 (arm_find_mapping_symbol, arm_record_special_symbol)
7770 (_initialize_arm_tdep): Update.
7771 (arm_objfile_data_free): Remove.
7772
3d507ff2
TT
77732019-06-27 Tom Tromey <tromey@adacore.com>
7774
7775 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7776 to cp_print_static_field.
7777
762c164d
TT
77782019-06-26 Tom Tromey <tromey@adacore.com>
7779
7780 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7781 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7782 declare.
7783
aa2f9bcf
AH
77842019-06-26 Alan Hayward <alan.hayward@arm.com>
7785
7786 * features/aarch64-core.c (create_feature_aarch64_core):
7787 Regenerate.
7788 * features/aarch64-core.xml: Add cpsr flags.
7789
3426ae57
AH
77902019-06-26 Alan Hayward <alan.hayward@arm.com>
7791
7792 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7793 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7794
4838e44c
SM
77952019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7796
7797 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7798 field.
7799 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7800 use.
7801 (arm_record_special_symbol): Don't insert new symbol in sorted
7802 position, push it at the end.
7803
54cc7474
SM
78042019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7805
7806 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7807 (arm_mapping_symbol_s): Remove.
7808 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7809 (arm_mapping_symbol_vec): New typedef.
7810 (struct arm_per_objfile): Add constructor.
7811 <section_maps>: Change type to
7812 std::unique_ptr<arm_mapping_symbol_vec[]>.
7813 (arm_compare_mapping_symbols): Remove.
7814 (arm_find_mapping_symbol): Adjust to section_maps type change.
7815 (arm_objfile_data_free): Call delete on arm_per_objfile.
7816 (arm_record_special_symbol): Adjust to section_maps type change.
7817 Allocate arm_per_objfile with new.
7818
b65b566c
PW
78192019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7820
7821 * cli/cli-cmds.c (alias_command): Compare the alias prefix
7822 with the command prefix.
7823
c2fc64f5
TT
78242019-06-25 Tom Tromey <tom@tromey.com>
7825
7826 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7827 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7828
fb54fa76
TT
78292019-06-25 Tom Tromey <tom@tromey.com>
7830
7831 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7832 type.
7833 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7834 protected.
7835
f7952c57
TT
78362019-06-25 Tom Tromey <tom@tromey.com>
7837
7838 * tui/tui-winsource.c
7839 (tui_source_window_base::set_is_exec_point_at): Add check against
7840 LOA_ADDRESS.
7841
17568d78
TT
78422019-06-25 Tom Tromey <tom@tromey.com>
7843
7844 * tui/tui-source.c (tui_set_source_content): Don't check before
7845 xfree.
7846 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7847
53e7cdba
TT
78482019-06-25 Tom Tromey <tom@tromey.com>
7849
7850 * tui/tui-winsource.h (tui_update_source_window_as_is)
7851 (tui_alloc_source_buffer, tui_line_is_displayed)
7852 (tui_addr_is_displayed): Change type of win_info.
7853 * tui/tui-winsource.c (tui_update_source_window_as_is)
7854 (tui_clear_source_content, tui_show_source_line)
7855 (tui_show_source_content, tui_source_window_base::refill)
7856 (tui_source_window_base::set_is_exec_point_at)
7857 (tui_source_window_base::set_is_exec_point_at)
7858 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7859 (tui_alloc_source_buffer, tui_line_is_displayed)
7860 (tui_addr_is_displayed): Change type of win_info. Update.
7861 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7862 (tui_source_window_base::do_make_visible_with_new_height):
7863 Update.
7864 * tui/tui-source.c (tui_set_source_content)
7865 (tui_set_source_content_nil)
7866 (tui_source_window::do_scroll_vertical): Update.
7867 * tui/tui-layout.c (show_layout): Update.
7868 * tui/tui-disasm.c (tui_set_disassem_content)
7869 (tui_disasm_window::do_scroll_vertical): Update.
7870 * tui/tui-data.h (tui_win_content): Remove.
7871 (struct tui_gen_win_info) <content, content_size>: Remove.
7872 (struct tui_source_element): Add initializers and destructor.
7873 (union tui_which_element, struct tui_win_element): Remove.
7874 (struct tui_source_window_base) <content>: New field.
7875 (struct tui_data_window): Remove destructor.
7876 (tui_alloc_content, tui_free_win_content)
7877 (tui_free_all_source_wins_content): Don't declare.
7878 * tui/tui-data.c (tui_initialize_static_data): Update.
7879 (init_content_element, tui_alloc_content): Remove.
7880 (~tui_gen_win_info): Update.
7881 (~tui_data_window, tui_free_all_source_wins_content)
7882 (tui_free_win_content, free_content, free_content_elements):
7883 Remove.
7884
7908abbf
TT
78852019-06-25 Tom Tromey <tom@tromey.com>
7886
7887 * tui/tui-winsource.h (tui_clear_source_content)
7888 (tui_erase_source_content, tui_show_source_content): Change type
7889 of win_info.
7890 * tui/tui-winsource.c (tui_clear_source_content)
7891 (tui_erase_source_content, tui_show_source_content): Change type
7892 of win_info.
7893 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7894 * tui/tui-source.h (tui_set_source_content_nil): Change type of
7895 win_info.
7896 * tui/tui-source.c (tui_set_source_content_nil): Change type of
7897 win_info.
7898 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7899
02c28df0
TT
79002019-06-25 Tom Tromey <tom@tromey.com>
7901
7902 * tui/tui-winsource.c (tui_clear_source_content)
7903 (tui_source_window_base::set_is_exec_point_at): Update.
7904 * tui/tui-source.c (tui_set_source_content_nil): Update.
7905 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7906 a bool.
7907 * tui/tui-data.c (init_content_element): Update.
7908
6658b1bf
TT
79092019-06-25 Tom Tromey <tom@tromey.com>
7910
7911 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7912 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7913 * tui/tui-layout.c (init_and_make_win): Update.
7914 * tui/tui.h (enum tui_win_type): Update.
7915 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7916 tui_win_is_auxillary.
7917 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7918 tui_win_is_auxillary.
7919
21e1c91e
TT
79202019-06-25 Tom Tromey <tom@tromey.com>
7921
7922 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7923 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7924 (tui_delete_data_content_windows, tui_display_all_data)
7925 (tui_data_window::do_scroll_vertical, tui_display_data_from):
7926 Update.
7927 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7928 * tui/tui-regs.c (tui_last_regs_line_no)
7929 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7930 (tui_show_registers): Update.
7931 (tui_show_register_group): Return void. Update.
7932 (tui_display_registers_from, tui_display_reg_element_at_line)
7933 (tui_display_registers_from_line, tui_check_register_values):
7934 Update.
7935 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7936 member.
7937 (struct tui_data_window) <regs_content>: Now a std::vector.
7938 <regs_content_count>: Remove.
7939 (tui_add_content_elements, tui_free_data_content): Don't declare.
7940 * tui/tui-data.c (tui_data_window::clear_detail): Update.
7941 (init_content_element): Remove DATA_WIN case. Add assert.
7942 (tui_add_content_elements): Remove.
7943 (tui_data_window): Update.
7944 (tui_free_data_content): Remove.
7945 (free_content_elements): Remove DATA_WIN case.
7946
115ac53b
TT
79472019-06-25 Tom Tromey <tom@tromey.com>
7948
7949 * tui/tui-data.c (tui_data_item_window): Update.
7950 * tui/tui-windata.h (tui_check_data_values): Don't declare.
7951 * tui/tui-windata.c (tui_display_all_data)
7952 (tui_display_data_from_line): Update.
7953 (tui_check_data_values): Remove.
7954 * tui/tui-regs.c (tui_show_register_group)
7955 (tui_display_reg_element_at_line): Update.
7956 * tui/tui-hooks.c (tui_register_changed)
7957 (tui_refresh_frame_and_register_information): Call
7958 tui_check_register_values.
7959 * tui/tui-data.h (struct tui_data_window) <data_content,
7960 data_content_count, data_type>: Remove.
7961 (enum tui_data_type): Remove.
7962
7963 * tui/tui-data.c (tui_data_window::clear_detail)
7964 (~tui_data_window): Update.
7965
eaf9738b
TT
79662019-06-25 Tom Tromey <tom@tromey.com>
7967
7968 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7969 declare.
7970 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7971 Rename from tui_first_data_item_displayed. Update.
7972 (tui_data_window::refresh_all)
7973 (tui_data_window::do_scroll_vertical): Update.
7974 * tui/tui-data.h (struct tui_data_window)
7975 <first_data_item_displayed>: Declare new method.
7976
31ca4723
TT
79772019-06-25 Tom Tromey <tom@tromey.com>
7978
7979 * tui/tui-data.h (tui_init_generic_part): Don't declare.
7980 * tui/tui-data.c (tui_init_generic_part): Remove, moving
7981 contents...
7982 (tui_initialize_static_data): ...here.
7983
41bcff7f
TT
79842019-06-25 Tom Tromey <tom@tromey.com>
7985
7986 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7987 (tui_display_registers_from, tui_check_register_values): Update.
7988 (tui_display_register): Remove win_info parameter; update.
7989 (tui_get_register): Change type of parameters.
7990 * tui/tui-data.h (struct tui_data_element): Remove.
7991 (union tui_which_element) <data>: Remove.
7992 <data_window>: Change type.
7993 (struct tui_data_item_window): New.
7994 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7995 case. Add assert.
7996 (~tui_data_item_window): New destructor.
7997 (free_content_elements): Remove DATA_ITEM_WIN case.
7998
d2802c33
TT
79992019-06-25 Tom Tromey <tom@tromey.com>
8000
8001 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8002 Remove.
8003
dd835f8b
TT
80042019-06-25 Tom Tromey <tom@tromey.com>
8005
8006 * tui/tui-data.h (struct tui_command_element): Remove.
8007 (union tui_which_element) <command>: Remove.
8008 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
8009 assert.
8010 (free_content_elements): Remove CMD_WIN case.
8011
bd7db367
TT
80122019-06-25 Tom Tromey <tom@tromey.com>
8013
8014 * tui/tui-layout.c (tui_set_layout): Update.
8015 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8016 * tui/tui-data.c (layout_def): Update.
8017
3add462f
TT
80182019-06-25 Tom Tromey <tom@tromey.com>
8019
8020 * tui/tui-wingeneral.c (tui_refresh_all): Update.
8021 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8022 (tui_source_window_base::set_new_height): Update.
8023 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8024 Update.
8025 (tui_set_locator_fullname, tui_set_locator_info)
8026 (tui_show_frame_info): Update.
8027 * tui/tui-source.c (tui_set_source_content)
8028 (tui_source_is_displayed): Update.
8029 * tui/tui-layout.c (show_source_disasm_command, show_data)
8030 (show_source_or_disasm_and_command): Update.
8031 * tui/tui-disasm.c (tui_set_disassem_content)
8032 (tui_get_begin_asm_address): Update.
8033 * tui/tui-data.h (struct tui_locator_element): Remove.
8034 (union tui_which_element) <locator>: Remove.
8035 (struct tui_locator_window): New.
8036 (tui_locator_win_info_ptr): Change return type.
8037 * tui/tui-data.c (_locator): Change type.
8038 (tui_locator_win_info_ptr): Change return type.
8039 (init_content_element): Remove LOCATOR_WIN case. Add assert.
8040 (tui_alloc_content): Add assert.
8041
489e9d8b
TT
80422019-06-25 Tom Tromey <tom@tromey.com>
8043
8044 * tui/tui-winsource.c
8045 (tui_exec_info_window::maybe_allocate_content): New method.
8046 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8047 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8048 (make_source_or_disasm_window): Add cast.
8049 * tui/tui-data.h (union tui_which_element) <simple_string>:
8050 Remove.
8051 (struct tui_source_info): New.
8052 (struct tui_source_window_base) <execution_info>: Change type.
8053 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8054 case, and add assert.
8055 (tui_alloc_content): Add assert.
8056
c3fabb7d
TT
80572019-06-25 Tom Tromey <tom@tromey.com>
8058
8059 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8060 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8061 * tui/tui-data.c (tui_alloc_win_info): Remove.
8062
bbc228ee
TT
80632019-06-25 Tom Tromey <tom@tromey.com>
8064
8065 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8066 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8067 can_highlight.
8068
5fcee43a
TT
80692019-06-25 Tom Tromey <tom@tromey.com>
8070
8071 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8072 make_visible_with_new_height method.
8073 (tui_win_info::make_visible_with_new_height): New method.
8074 (tui_source_window_base::do_make_visible_with_new_height)
8075 (tui_data_window::do_make_visible_with_new_height)
8076 (tui_cmd_window::do_make_visible_with_new_height): New methods.
8077 (make_visible_with_new_height): Remove.
8078 (tui_resize_all, tui_adjust_win_heights): Use
8079 make_visible_with_new_height method.
8080 * tui/tui-data.h (struct tui_win_info)
8081 <do_make_visible_with_new_height, make_visible_with_new_height>:
8082 New methods.
8083 (struct tui_source_window_base, struct tui_data_window)
8084 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8085 methods.
8086
d83f1fe6
TT
80872019-06-25 Tom Tromey <tom@tromey.com>
8088
8089 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8090 method.
8091 (update_tab_width): Call update_tab_width method.
8092 * tui/tui-data.h (struct tui_win_info)
8093 (struct tui_source_window_base) <update_tab_width>: New methods.
8094
17374de4
TT
80952019-06-25 Tom Tromey <tom@tromey.com>
8096
8097 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8098 parameter.
8099 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8100 parameter.
8101 (tui_gen_win_info::make_visible): Update.
8102 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8103 parameter.
8104 * tui/tui-data.h (enum tui_box): New enum.
8105 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8106
f936bca2
TT
81072019-06-25 Tom Tromey <tom@tromey.com>
8108
8109 * tui/tui-layout.c (make_source_or_disasm_window): Always use
8110 init_and_make_win for EXEC_INFO_WIN.
8111 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8112 longer inline.
8113 (struct tui_win_info) <~tui_win_info>: Inline.
8114 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8115 Don't declare.
8116 * tui/tui-data.c (source_win, disasm_win): Remove globals.
8117 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8118 Remove.
8119 (tui_initialize_static_data): Update.
8120 (~tui_gen_win_info): Handle more cleanup here.
8121 (~tui_source_window_base): Delete "execution_info".
8122 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8123
d6ba6a11
TT
81242019-06-25 Tom Tromey <tom@tromey.com>
8125
8126 * tui/tui-layout.c (make_command_window): Don't set
8127 can_highlight.
8128 (show_source_disasm_command): Call the reset method.
8129 (show_data): Don't set can_highlight. Call the reset method.
8130 (tui_gen_win_info::reset): Rename from init_gen_win_info
8131 (init_and_make_win): Simplify. Return tui_gen_win_info.
8132 (show_source_or_disasm_and_command): Call the reset method.
8133 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8134 (struct tui_cmd_window): Set can_highlight.
8135
48a3bd16
TT
81362019-06-25 Tom Tromey <tom@tromey.com>
8137
8138 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8139 from make_visible.
8140 (tui_make_visible, tui_make_invisible): Rewrite.
8141 (tui_win_info::make_visible): Remove.
8142 (tui_source_window_base::make_visible): Update.
8143 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8144 method. Moved from...
8145 (struct tui_win_info) <make_visible>: ...here.
8146
c3bd716f
TT
81472019-06-25 Tom Tromey <tom@tromey.com>
8148
8149 * tui/tui-winsource.c
8150 (tui_source_window_base::do_scroll_horizontal): Remove direction
8151 parameter.
8152 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8153 direction parameter.
8154 * tui/tui-win.c (tui_win_info::forward_scroll)
8155 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8156 (tui_win_info::right_scroll): Update.
8157 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8158 direction parameter.
8159 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8160 direction parameter.
8161 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8162 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8163 Remove direction parameter.
8164 (struct tui_source_window_base, struct tui_source_window)
8165 (struct tui_disasm_window, struct tui_data_window)
8166 (struct tui_cmd_window): Update.
8167
21c32dca
TT
81682019-06-25 Tom Tromey <tom@tromey.com>
8169
8170 * tui/tui-winsource.h (tui_set_exec_info_content)
8171 (tui_show_exec_info_content, tui_erase_exec_info_content)
8172 (tui_clear_exec_info_content, tui_update_exec_info): Change
8173 argument to tui_source_window_base.
8174 * tui/tui-winsource.c (tui_set_exec_info_content)
8175 (tui_show_exec_info_content, tui_erase_exec_info_content)
8176 (tui_clear_exec_info_content, tui_update_exec_info): Change
8177 argument to tui_source_window_base.
8178
73fbdc65
TT
81792019-06-25 Tom Tromey <tom@tromey.com>
8180
8181 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8182 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8183
33325343
TT
81842019-06-25 Tom Tromey <tom@tromey.com>
8185
8186 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8187 check.
8188
29d2c474
TT
81892019-06-25 Tom Tromey <tom@tromey.com>
8190
8191 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8192 type to void.
8193 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8194 type to void.
8195 * tui/tui-source.c (tui_set_source_content): Update.
8196 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8197
152f3f4b
TT
81982019-06-25 Tom Tromey <tom@tromey.com>
8199
8200 * tui/tui-win.c (window_name_completer, tui_set_focus)
8201 (tui_all_windows_info): Use name method.
8202 * tui/tui-data.h (struct tui_gen_win_info)
8203 (struct tui_source_window, struct tui_disasm_window)
8204 (struct tui_data_window, struct tui_cmd_window) <name>: New
8205 method.
8206 (tui_win_name): Don't declare.
8207 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8208 (tui_win_name): Remove.
8209
be4da588
TT
82102019-06-25 Tom Tromey <tom@tromey.com>
8211
8212 * tui/tui-winsource.h (tui_update_source_window)
8213 (tui_update_source_window_as_is): Change parameter type.
8214 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8215 to be a tui_source_window_base.
8216 (tui_update_source_window_as_is): Likewise.
8217 * tui/tui-win.c (make_visible_with_new_height): Update.
8218
5b81daba
TT
82192019-06-25 Tom Tromey <tom@tromey.com>
8220
8221 * tui/tui-winsource.c (tui_erase_source_content)
8222 (tui_show_source_content, tui_show_exec_info_content)
8223 (tui_erase_exec_info_content): Use refresh_window method.
8224 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8225 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8226 from tui_refresh_win.
8227 (tui_data_window::refresh_window): New method.
8228 (tui_win_info::refresh, tui_source_window_base::refresh)
8229 (tui_refresh_all): Use refresh_window method.
8230 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8231 method.
8232 * tui/tui-regs.c (tui_display_register): Call refresh_window
8233 method.
8234 * tui/tui-layout.c (show_source_disasm_command)
8235 (show_source_or_disasm_and_command): Call refresh_window method.
8236 * tui/tui-data.h (struct tui_gen_win_info)
8237 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8238 New method.
8239
cb2ce893
TT
82402019-06-25 Tom Tromey <tom@tromey.com>
8241
8242 * tui/tui.c (tui_rl_other_window, tui_enable)
8243 (tui_is_window_visible, tui_get_command_dimension): Update.
8244 * tui/tui-winsource.c (tui_update_source_window_as_is)
8245 (tui_clear_source_content, tui_erase_source_content)
8246 (tui_show_source_line, tui_source_window_base::refill)
8247 (tui_source_window_base::do_scroll_horizontal)
8248 (tui_source_window_base::set_is_exec_point_at)
8249 (tui_update_breakpoint_info, tui_set_exec_info_content)
8250 (tui_alloc_source_buffer, tui_line_is_displayed)
8251 (tui_addr_is_displayed): Update.
8252 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8253 (tui_check_and_display_highlight_if_needed)
8254 (tui_win_info::make_visible, tui_win_info::refresh)
8255 (tui_refresh_all): Update.
8256 * tui/tui-windata.c (tui_first_data_item_displayed)
8257 (tui_delete_data_content_windows, tui_erase_data_content)
8258 (tui_display_all_data, tui_data_window::refresh_all)
8259 (tui_check_data_values): Update.
8260 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8261 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8262 (tui_win_info::backward_scroll, tui_refresh_all_win)
8263 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8264 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8265 (tui_source_window_base::set_new_height)
8266 (tui_data_window::set_new_height)
8267 (make_invisible_and_set_new_height)
8268 (make_visible_with_new_height, new_height_ok)
8269 (parse_scrolling_args): Update.
8270 * tui/tui-stack.c (tui_show_frame_info): Update.
8271 * tui/tui-source.c (tui_set_source_content)
8272 (tui_set_source_content_nil, tui_source_is_displayed)
8273 (tui_source_window::do_scroll_vertical): Update.
8274 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8275 (tui_display_registers_from, tui_display_reg_element_at_line)
8276 (tui_check_register_values, tui_reg_command): Update.
8277 * tui/tui-layout.c (tui_default_win_height)
8278 (show_source_disasm_command, show_data, init_and_make_win)
8279 (show_source_or_disasm_and_command): Update.
8280 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8281 (tui_redisplay_readline, tui_mld_flush)
8282 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8283 (tui_getc): Update.
8284 * tui/tui-disasm.c (tui_set_disassem_content)
8285 (tui_disasm_window::do_scroll_vertical): Update.
8286 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8287 Now virtual.
8288 (struct tui_win_info): Derive from tui_gen_win_info.
8289 <~tui_win_info>: Mark as override.
8290 <generic>: Remove member.
8291 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8292 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8293 (~tui_data_window, ~tui_win_info)
8294 (tui_free_all_source_wins_content): Update.
8295 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8296
ab313b35
TT
82972019-06-25 Tom Tromey <tom@tromey.com>
8298
8299 * tui/tui-layout.c (init_and_make_win): Use new.
8300 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8301 destructor, initializers.
8302 (tui_alloc_generic_win_info): Don't declare.
8303 * tui/tui-data.c (_locator): Add argument to constructor.
8304 (source_win, disasm_win): New globals.
8305 (exec_info): Remove.
8306 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8307 Update.
8308 (tui_alloc_generic_win_info): Remove.
8309 (init_content_element): Use new.
8310 (tui_win_info::tui_win_info): Update.
8311 (free_content_elements) <case DATA_WIN>: Use delete.
8312
dc2c33e4
TT
83132019-06-25 Tom Tromey <tom@tromey.com>
8314
8315 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8316 * tui/tui-windata.c (tui_first_data_item_displayed)
8317 (tui_delete_data_content_windows): Update.
8318 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8319 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8320 (tui_display_registers_from, tui_check_register_values): Update.
8321 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8322 pointer.
8323 * tui/tui-data.c (init_content_element): Update. Allocate the new
8324 window.
8325 (tui_free_data_content): Update.
8326 (free_content_elements) <case DATA_WIN>: Free the window.
8327
214a5cbe
TT
83282019-06-25 Tom Tromey <tom@tromey.com>
8329
8330 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8331 Update.
8332 * tui/tui-layout.c (make_command_window)
8333 (show_source_disasm_command, show_data, init_and_make_win)
8334 (show_source_or_disasm_and_command): Update.
8335 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8336 method.
8337 <can_highight, is_highlighted>: Now bool.
8338 (tui_set_win_highlight): Don't declare.
8339 * tui/tui-data.c (tui_set_win_highlight): Remove.
8340
8e2daf15
TT
83412019-06-25 Tom Tromey <tom@tromey.com>
8342
8343 * tui/tui-wingeneral.c (make_visible): Remove check of window
8344 type.
8345
8903bd8a
TT
83462019-06-25 Tom Tromey <tom@tromey.com>
8347
8348 * tui/tui-win.c (tui_win_info::max_height)
8349 (tui_cmd_window::max_height): New methods.
8350 (new_height_ok): Call max_height.
8351 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8352 <max_height>: New method.
8353
3f02ce1e
TT
83542019-06-25 Tom Tromey <tom@tromey.com>
8355
8356 * tui/tui-win.c (tui_source_window_base::set_new_height)
8357 (tui_data_window::set_new_height): New methods.
8358 (make_invisible_and_set_new_height): Call set_new_height method.
8359 * tui/tui-data.h (struct tui_win_info)
8360 (struct tui_source_window_base, struct tui_data_window)
8361 <set_new_height>: New method.
8362
1825f487
TT
83632019-06-25 Tom Tromey <tom@tromey.com>
8364
8365 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8366 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8367 tui_refresh_data_win.
8368 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8369 method.
8370 (tui_refresh_all_win): Call the refresh_all method.
8371 (tui_set_focus): Likewise.
8372 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8373 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8374 Likewise.
8375
ad54d15b
TT
83762019-06-25 Tom Tromey <tom@tromey.com>
8377
8378 * tui/tui-winsource.h (tui_refill_source_window)
8379 (tui_set_is_exec_point_at): Don't declare.
8380 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8381 (tui_source_window_base::refill): Rename from
8382 tui_refill_source_window.
8383 (tui_source_window_base::do_scroll_horizontal): Update.
8384 (tui_source_window_base::set_is_exec_point_at): Rename from
8385 tui_set_is_exec_point_at.
8386 (tui_update_all_breakpoint_info): Update.
8387 * tui/tui-stack.c (tui_show_frame_info): Update.
8388 * tui/tui-layout.c (show_data): Add cast.
8389 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8390 * tui/tui-data.h (struct tui_source_window_base) <refill,
8391 set_is_exec_point_at>: New methods.
8392 (tui_source_windows, tui_add_to_source_windows): Update types.
8393 (tui_add_to_source_windows): Remove redundant declaration.
8394 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8395 (tui_source_windows): Change return type.
8396 (tui_clear_source_windows_detail): Update.
8397 (tui_add_to_source_windows): Change type of parameter.
8398 (tui_free_all_source_wins_content): Update.
8399
2042b506
TT
84002019-06-25 Tom Tromey <tom@tromey.com>
8401
8402 * tui/tui-wingeneral.c (tui_win_info::refresh)
8403 (tui_source_window_base::refresh): New methods.
8404 (tui_refresh_all): Call the refresh method.
8405 * tui/tui-data.h (struct tui_win_info)
8406 (struct tui_source_window_base) <refresh>: New method.
8407
56122977
TT
84082019-06-25 Tom Tromey <tom@tromey.com>
8409
8410 * tui/tui.h (tui_is_window_visible): Return bool.
8411 * tui/tui.c (tui_is_window_visible): Return bool.
8412 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8413 (tui_make_visible, tui_make_invisible)
8414 (tui_win_info::make_visible)
8415 (tui_source_window_base::make_visible, make_all_visible)
8416 (tui_make_all_visible, tui_make_all_invisible): Update.
8417 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8418 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8419 bool.
8420 (struct tui_win_info, struct tui_source_window_base)
8421 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8422 * tui/tui-data.c (tui_init_generic_part): Update.
8423
cda37efb
TT
84242019-06-25 Tom Tromey <tom@tromey.com>
8425
8426 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8427 (tui_source_window_base::make_visible): New methods.
8428 (make_all_visible): Make method call.
8429 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8430 (struct tui_source_window_base, struct tui_cmd_window): Override
8431 make_visible.
8432 (tui_win_is_source_type): Don't declare.
8433 * tui/tui-data.c (tui_win_is_source_type): Remove.
8434
6a0ee02c
TT
84352019-06-25 Tom Tromey <tom@tromey.com>
8436
8437 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8438 NULL check.
8439
63901aec
TT
84402019-06-25 Tom Tromey <tom@tromey.com>
8441
8442 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8443 Inline constructor. Add initializers for members.
8444 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8445 constructors; now inline in class.
8446
ceb13a13
TT
84472019-06-25 Tom Tromey <tom@tromey.com>
8448
8449 * tui/tui-regs.c (tui_show_registers): Update.
8450 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8451 bool.
8452 * tui/tui-data.c (tui_data_window::clear_detail)
8453 (tui_data_window): Update.
8454
238eb706
TT
84552019-06-25 Tom Tromey <tom@tromey.com>
8456
8457 * tui/tui-windata.c (tui_display_all_data)
8458 (tui_display_data_from_line, tui_display_data_from)
8459 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8460 Update.
8461 * tui/tui-regs.c (tui_last_regs_line_no)
8462 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8463 (tui_show_registers, tui_show_register_group)
8464 (tui_display_registers_from, tui_display_reg_element_at_line)
8465 (tui_display_registers_from_line, tui_check_register_values)
8466 (tui_reg_next, tui_reg_prev): Update.
8467 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8468 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8469 tui_data_window.
8470 (struct tui_win_info) <detail>: Remove. Add new fields from
8471 tui_data_info.
8472 (TUI_DATA_WIN): Add cast.
8473 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8474 (~tui_data_window): Simplify.
8475
81491aa0
TT
84762019-06-25 Tom Tromey <tom@tromey.com>
8477
8478 * tui/tui-layout.c (show_source_disasm_command)
8479 (show_source_or_disasm_and_command): Update.
8480 * tui/tui-io.c (update_cmdwin_start_line)
8481 (tui_redisplay_readline): Update.
8482 * tui/tui-data.h (struct tui_command_info): Remove.
8483 (struct tui_win_info) <detail>: Remove command_info member.
8484 (struct tui_data_window) <start_line>: New member, from
8485 tui_command_info.
8486 (TUI_CMD_WIN): Add casts.
8487
e6e41501
TT
84882019-06-25 Tom Tromey <tom@tromey.com>
8489
8490 * tui/tui-winsource.c (tui_update_source_window)
8491 (tui_refill_source_window)
8492 (tui_source_window_base::do_scroll_horizontal)
8493 (tui_update_breakpoint_info, tui_set_exec_info_content)
8494 (tui_show_exec_info_content, tui_erase_exec_info_content)
8495 (tui_clear_exec_info_content): Update.
8496 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8497 Update.
8498 * tui/tui-win.c (make_invisible_and_set_new_height)
8499 (make_visible_with_new_height): Update.
8500 * tui/tui-source.c (tui_set_source_content)
8501 (tui_show_symtab_source): Update.
8502 * tui/tui-layout.c (extract_display_start_addr)
8503 (show_source_disasm_command, show_data)
8504 (make_source_or_disasm_window)
8505 (show_source_or_disasm_and_command): Update.
8506 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8507 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8508 "gdbarch".
8509 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8510 to tui_source_window_base.
8511 (struct tui_win_info) <detail>: Remove source_info member.
8512 (struct tui_source_window_base) <has_locator>: Inline.
8513 Move contents from tui_source_info; rename has_locator member to
8514 m_has_locator.
8515 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8516 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8517 header file.
8518 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8519 Simplify.
8520 (tui_free_all_source_wins_content): Cast to
8521 tui_source_window_base.
8522
44f0e208
TT
85232019-06-25 Tom Tromey <tom@tromey.com>
8524
8525 * tui/tui-win.c (make_invisible_and_set_new_height)
8526 (make_visible_with_new_height): Call has_locator method.
8527 * tui/tui-layout.c (show_source_disasm_command, show_data)
8528 (show_source_or_disasm_and_command): Update for bool change.
8529 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8530 (tui_win_info) <has_locator>: New method.
8531 (struct tui_source_window_base) <has_locator>: New method.
8532 (tui_win_has_locator): Don't declare.
8533 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8534 from tui_win_has_locator.
8535 (tui_source_window_base): Use false, not FALSE.
8536
7778b912
TT
85372019-06-25 Tom Tromey <tom@tromey.com>
8538
8539 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8540 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8541 clear_detail method directly.
8542 (tui_clear_win_detail): Remove.
8543
f83d391c
TT
85442019-06-25 Tom Tromey <tom@tromey.com>
8545
8546 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8547 "this", not TUI_DISASM_WIN.
8548
13446e05
TT
85492019-06-25 Tom Tromey <tom@tromey.com>
8550
8551 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8552 declare.
8553 * tui/tui-winsource.c
8554 (tui_source_window_base::do_scroll_horizontal): Rename from
8555 tui_horizontal_source_scroll.
8556 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8557 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8558 from tui_vertical_data_scroll.
8559 * tui/tui-win.h (tui_scroll): Don't declare.
8560 * tui/tui-win.c (tui_win_info::forward_scroll)
8561 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8562 (tui_win_info::right_scroll): Rename and update.
8563 (tui_scroll_forward_command, tui_scroll_backward_command)
8564 (tui_scroll_left_command, tui_scroll_right_command): Update.
8565 (tui_scroll): Remove.
8566 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8567 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8568 from tui_vertical_source_scroll.
8569 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8570 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8571 from tui_vertical_disassem_scroll.
8572 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8573 do_scroll_horizontal>: New methods.
8574 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8575 Likewise.
8576 (struct tui_source_window_base): Add do_scroll_horizontal.
8577 (struct tui_source_window, struct tui_disasm_window): Add
8578 do_scroll_vertical.
8579 (struct tui_data_window, struct tui_cmd_window): Add
8580 do_scroll_horizontal and do_scroll_vertical.
8581 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8582
5cf82909
TT
85832019-06-25 Tom Tromey <tom@tromey.com>
8584
8585 * tui/tui-data.h (struct tui_source_window_base): New struct.
8586 (struct tui_source_window): Derive from tui_source_window_base.
8587 (struct tui_disasm_window): New struct.
8588 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8589 from tui_source_window::clear_detail.
8590 (tui_source_window_base): Rename from tui_source_window.
8591 (~tui_source_window_base): Rename from ~tui_source_window.
8592 (tui_alloc_win_info): Create a tui_disasm_window.
8593
ee1d42d6
TT
85942019-06-25 Tom Tromey <tom@tromey.com>
8595
8596 * tui/tui-data.h (struct tui_source_window)
8597 (struct tui_data_window): Declare destructors.
8598 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8599 destructors.
8600 (tui_win_info): Simplify.
8601
b4eb2452
TT
86022019-06-25 Tom Tromey <tom@tromey.com>
8603
8604 * tui/tui-winsource.c (tui_display_main)
8605 (tui_update_source_windows_with_addr)
8606 (tui_update_all_breakpoint_info): Update.
8607 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8608 (new_height_ok, parse_scrolling_args): Update.
8609 * tui/tui-stack.c (tui_show_frame_info): Update.
8610 * tui/tui-data.h (struct tui_list): Remove.
8611 (tui_source_windows): Return a reference to a std::vector.
8612 * tui/tui-data.c (source_windows): Now a std::vector.
8613 (tui_source_windows): Change return type.
8614 (tui_clear_source_windows): Rewrite.
8615 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8616 (tui_free_all_source_wins_content): Rewrite.
8617
8761a91b
TT
86182019-06-25 Tom Tromey <tom@tromey.com>
8619
8620 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8621 (struct tui_data_window, struct tui_cmd_window): Declare
8622 clear_detail method.
8623 * tui/tui-data.c (tui_source_window::clear_detail)
8624 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8625 methods.
8626 (tui_clear_win_detail): Simplify.
8627
0ed69eda
TT
86282019-06-25 Tom Tromey <tom@tromey.com>
8629
8630 * tui/tui-layout.c (make_source_window, make_disasm_window)
8631 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8632 Return the new window.
8633 (show_source_disasm_command, show_data)
8634 (show_source_or_disasm_and_command): Update.
8635
82432e10
TT
86362019-06-25 Tom Tromey <tom@tromey.com>
8637
8638 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8639 parameter. Return the new window.
8640 (show_source_disasm_command): Update and remove NULL check.
8641 (show_source_or_disasm_and_command): Update.
8642
ec328aa5
TT
86432019-06-25 Tom Tromey <tom@tromey.com>
8644
8645 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8646
33b906ab
TT
86472019-06-25 Tom Tromey <tom@tromey.com>
8648
8649 * tui/tui-data.h (struct tui_win_info): Make constructor
8650 protected. Make destructor virtual. Add initializers.
8651 (tui_source_window, tui_data_window, tui_cmd_window): New
8652 classes.
8653 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8654 constructor. Add "type" parameter.
8655 (tui_source_window, tui_data_window, tui_cmd_window): New
8656 constructors.
8657 (tui_alloc_win_info): Instantiate the appropriate subclass.
8658
e7e11af4
TT
86592019-06-25 Tom Tromey <tom@tromey.com>
8660
8661 * tui/tui-win.c (tui_resize_all): Use delete.
8662 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8663 destructor.
8664 (tui_free_window): Don't declare.
8665 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8666 Update.
8667
6792b55e
TT
86682019-06-25 Tom Tromey <tom@tromey.com>
8669
8670 * tui/tui-data.h (struct tui_win_info): Add constructor.
8671 * tui/tui-data.c (tui_alloc_win_info): Use new.
8672 (tui_free_window): Use delete.
8673
f95675e1
TT
86742019-06-22 Tom Tromey <tom@tromey.com>
8675
8676 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8677 declare.
8678 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8679
5bff081c
TT
86802019-06-22 Tom Tromey <tom@tromey.com>
8681
8682 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8683 declare.
8684 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8685
47e3f474
TV
86862019-06-22 Tom de Vries <tdevries@suse.de>
8687
8688 * dwarf2read.c (create_addrmap_from_aranges)
8689 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8690 instead of '%zu'.
8691
fd5866f6
SM
86922019-06-21 Simon Marchi <simon.marchi@efficios.com>
8693
8694 * dwarf2read.h (dwarf2_section_info_def): Remove.
8695 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8696 * dwarf2read.c (struct dwo_sections) <types>: Change type to
8697 std::vector<dwarf2_section_info>.
8698 (struct dwo_file) <~dwo_file>: Remove.
8699 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8700 types field.
8701 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8702 (dwarf2_read_debug_names): Likewise.
8703 (create_debug_types_hash_table): Change parameter type to
8704 array_view, adjust code accordingly.
8705 (dwarf2_locate_dwo_sections): Adjust to std::vector.
8706 (partial_die_info::fixup): Likewise.
8707 (determine_prefix): Likewise.
8708 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8709
fb1eb2f9
SM
87102019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8711
8712 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8713 gdb_bfd_ref_ptr.
8714 <~dwo_file>: Remove call to gdb_bfd_unref.
8715 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8716 gdb_bfd_ref_ptr::get.
8717
51ac9db5
SM
87182019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8719
8720 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8721 type to htab_up.
8722 * dwarf2read.c (struct dwo_file): Initialize fields.
8723 <~dwo_file>: New.
8724 (free_dwo_file): Remove, move content to ~dwo_file.
8725 (struct dwo_file_deleter): Remove.
8726 (dwo_file_up>: Remove custom deleter.
8727 (free_dwo_files): Remove.
8728 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8729 dwo_files.
8730 (process_skeletonless_type_units): Call unique_ptr::get.
8731 (allocate_dwo_file_hash_table): Add deleter to created hash
8732 table. Change return type to htab_up.
8733 (lookup_dwo_file_slot): Don't memset dwo_file, call
8734 unique_ptr::get.
8735 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8736 (create_dwo_unit_in_dwp_v2): Likewise.
8737 (open_and_init_dwo_file): Likewise.
8738 (free_dwo_file_from_slot): Remove.
8739
dc4ccb6f
SM
87402019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8741
8742 * dwarf2read.h (struct dwarf2_section_info) <readin,
8743 is_virtual>: Change type to bool.
8744 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8745 true instead of 1.
8746
e6a1c5cb
TT
87472019-06-19 Tom Tromey <tom@tromey.com>
8748
8749 * tui/tui-data.h (tui_init_content_element): Don't declare.
8750
6f6ffbeb
TT
87512019-06-19 Tom Tromey <tom@tromey.com>
8752
8753 * tui/tui-data.h (tui_init_win_info): Don't declare.
8754
f23f598e
TV
87552019-06-19 Tom de Vries <tdevries@suse.de>
8756
8757 * dwarf2read.h (abstract_to_concrete): Change type to
8758 std::unordered_map<sect_offset, std::vector<sect_offset>,
8759 gdb::hash_enum<sect_offset>>.
8760
680e1bee
TT
87612019-06-19 Tom Tromey <tromey@adacore.com>
8762
8763 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8764 EVAL_AVOID_SIDE_EFFECTS specially.
8765
dcf37923
TT
87662019-06-19 Tom Tromey <tromey@adacore.com>
8767
8768 * source-cache.c (highlighter): New global.
8769 (source_cache::get_source_lines): Create a highlighter on demand.
8770
494986d5
AB
87712019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
8772
8773 * defs.h (deprecated_interactive_hook): Delete declaration.
8774 * interps.c (clear_interpreter_hooks): Remove use of
8775 deprecated_interactive_hook.
8776 * top.c (deprecated_interactive_hook): Delete definition.
8777 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8778
3360b6e7
TV
87792019-06-18 Tom de Vries <tdevries@suse.de>
8780
8781 PR gdb/24515
8782 * dwarf2read.h (abstract_to_concrete): Change type from
8783 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8784 std::unordered_map<sect_offset, std::vector<sect_offset>>.
8785 * dwarf2read.c (read_variable): Update.
8786 (dwarf2_fetch_die_loc_sect_off): Update.
8787
310b3441
TV
87882019-06-17 Tom de Vries <tdevries@suse.de>
8789
8790 PR gdb/24617
8791 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8792 accessing parent[parent_len - 1].
8793
ba9777be
PP
87942019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
8795
8796 PR gdb/24364
8797 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8798 call dtrace_process_dof with NULL dof.
8799
2b9f6e89
TV
88002019-06-16 Tom de Vries <tdevries@suse.de>
8801
8802 PR gdb/24445
8803 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8804
431b3ead
TT
88052019-06-16 Tom Tromey <tom@tromey.com>
8806
8807 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8808 (make_all_visible): Use address of member.
8809
d04b44a1
TT
88102019-06-16 Tom Tromey <tom@tromey.com>
8811
8812 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8813 (tui_free_window, free_content, free_content_elements): Remove
8814 unnecessary cast.
8815 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8816 cast.
8817 * tui/tui-regs.c (tui_show_register_group)
8818 (tui_display_registers_from, tui_display_reg_element_at_line):
8819 Remove unnecessary cast.
8820
bf5142e7
AB
88212019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
8822
8823 * linux-nat.c (normal_mask): Delete.
8824 (_initialize_linux_nat): Don't initialise normal_mask.
8825
c4973306
SM
88262019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
8827
8828 PR gdb/24445
8829 * dwarf-index-write.h (write_psymtabs_to_index): Add
8830 dwz_basename parameter.
8831 * dwarf-index-write.c (write_gdbindex): Move file writing to
8832 write_gdbindex_1. Change return type void.
8833 (assert_file_size): Move up, remove filename parameter.
8834 (write_gdbindex_1): New function.
8835 (write_debug_names): Change return type to void, call
8836 assert_file_size.
8837 (struct index_wip_file): New struct.
8838 (write_psymtabs_to_index): Add dwz_basename parameter. Move
8839 file logic to index_wip_file. Write index for dwz file if
8840 needed.
8841 (save_gdb_index_command): Pass basename of dwz file, if present.
8842 * dwarf-index-cache.c (index_cache::store): Obtain and pass
8843 build-id of dwz file, if present.
8844 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8845 (dwarf2_get_dwz_file): Likewise.
8846 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8847 (dwarf2_get_dwz_file): Likewise.
8848
395f9c91
TT
88492019-06-16 Tom Tromey <tom@tromey.com>
8850
8851 * coffread.c (process_coff_symbol): Use xstrdup.
8852 * value.c (create_internalvar): Use xstrdup.
8853
cafb3438
TT
88542019-06-16 Tom Tromey <tom@tromey.com>
8855
8856 * valops.c (value_cast, value_slice): Remove unnecessary cast.
8857 * breakpoint.c (stopin_command, stopat_command)
8858 (until_break_command, decode_location_default): Remove unnecessary
8859 cast.
8860 * utils.c (subset_compare): Remove unnecessary cast.
8861 * ada-lang.c (ada_update_initial_language): Remove unnecessary
8862 cast.
8863 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8864 cast.
8865 * infcmd.c (path_command): Remove unnecessary cast.
8866 * coffread.c (decode_type): Remove unnecessary cast.
8867 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8868 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8869 * tui/tui-stack.c (tui_show_locator_content)
8870 (tui_show_frame_info): Remove unnecessary cast.
8871 * tui/tui-win.c (tui_scroll_forward_command)
8872 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8873 (parse_scrolling_args): Remove unnecessary cast.
8874 * tui/tui-data.c (init_win_info, tui_del_window)
8875 (tui_free_window, tui_del_data_windows, tui_free_data_content)
8876 (free_content_elements): Remove unnecessary cast.
8877 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8878 unnecessary cast.
8879 * tui/tui-source.c (tui_set_source_content)
8880 (tui_vertical_source_scroll): Remove unnecessary cast.
8881 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8882 cast.
8883 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8884 * tui/tui-regs.c (tui_display_registers_from)
8885 (tui_display_register): Remove unnecessary cast.
8886 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8887 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8888 (make_visible): Remove unnecessary cast.
8889 * tui/tui-winsource.c (tui_erase_source_content)
8890 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8891 unnecessary cast.
8892 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8893 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8894 * stabsread.c (read_type, read_array_type, read_range_type):
8895 Remove unnecessary cast.
8896 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8897 (parse_symbol, parse_type, upgrade_type, parse_external)
8898 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8899 unnecessary cast.
8900 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8901
730ead81
TT
89022019-06-16 Tom Tromey <tom@tromey.com>
8903
8904 * tui/tui-data.c (tui_alloc_generic_win_info)
8905 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8906 checks.
8907
584a927c
AB
89082019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
8909 Andrew Burgess <andrew.burgess@embecosm.com>
8910
8911 * f-typeprint.c (f_print_type): Don't return early for not
8912 associated or not allocated types.
8913 (f_type_print_varspec_suffix): Add print_rank parameter and print
8914 ranks of array types in case they dangling.
8915 (f_type_print_base): Add print_rank parameter.
8916
30056ea0
AB
89172019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8918
8919 * NEWS: Mention new MI commands.
8920 * break-catch-throw.c (enum exception_event_kind): Move to
8921 breakpoint.h.
8922 (print_mention_exception_catchpoint): Output text as a single
8923 message.
8924 (catch_exception_command_1): Rename to...
8925 (catch_exception_event): ...this, make non-static, update header
8926 command, and change some parameter types.
8927 (catch_catch_command): Update for changes to
8928 catch_exception_command_1.
8929 (catch_throw_command): Likewise.
8930 (catch_rethrow_command): Likewise.
8931 * breakpoint.c (enum exception_event_kind): Delete.
8932 * breakpoint.h (enum exception_event_kind): Moved here from
8933 break-catch-throw.c.
8934 (catch_exception_event): Declare.
8935 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8936 (mi_cmd_catch_throw): New function.
8937 (mi_cmd_catch_rethrow): New function.
8938 (mi_cmd_catch_catch): New function.
8939 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8940 'catch-catch' entries.
8941 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8942 (mi_cmd_catch_rethrow): Declare.
8943 (mi_cmd_catch_catch): Declare.
8944
ec8e2b6d
AB
89452019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8946
8947 * annotate.c (annotate_source_line): Change return type to void,
8948 update implementation to match.
8949 * annotate.h (annotate_source_line): Change return type to void,
8950 update header comment.
8951 * stack.c (print_frame_info): Don't change what frame information
8952 is printed based on whether annotations are on or not.
8953
0d3abd8c
AB
89542019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8955
8956 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8957 (annotate_source): Make static.
8958 (annotate_source_line): Moved from source.c and renamed from
8959 identify_source_line. Update the return type.
8960 * annotate.h (annotate_source): Delete declaration.
8961 (annotate_source_line): Declaration moved from source.h, and
8962 renamed from identify_source_line. Return type updated.
8963 * source.c (identify_source_line): Moved to annotate.c and renamed
8964 to annotate_source_line.
8965 (info_line_command): Remove check of annotation_level.
8966 * source.h (identify_source_line): Move declaration to annotate.h
8967 and rename to annotate_source_line.
8968 * stack.c: Add 'annotate.h' include.
8969 (print_frame_info): Remove check of annotation_level before
8970 calling annotate_source_line.
8971
00df30ae
AB
89722019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8973
8974 * source-cache.c (source_cache::get_plain_source_lines): Use
8975 open_source_file_with_line_charpos instead of just
8976 open_source_file, remove call to find_source_lines.
8977 (source_cache::get_source_lines): Likewise.
8978 * source.c (find_source_lines): Make static.
8979 (get_filename_and_charpos): Renamed into...
8980 (open_source_file_with_line_charpos): ..this along with changes to
8981 return a scoped_fd, and some other minor clean ups.
8982 (identify_source_line): Use open_source_file_with_line_charpos.
8983 (search_command_helper): Use open_source_file_with_line_charpos
8984 instead of just open_source_file, remove call to
8985 find_source_lines.
8986 * source.h (open_source_file_with_line_charpos): Declare new
8987 function.
8988 (find_source_lines): Delete declaration.
8989
afda45a2
AB
89902019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8991
8992 * source.c (get_filename_and_charpos): Remove fullname
8993 parameter.
8994 (identify_source_line): Update call to get_filename_and_charpos.
8995
0735b091
TT
89962019-06-14 Tom Tromey <tromey@adacore.com>
8997
8998 PR gdb/24502:
8999 * ui-style.h (skip_ansi_escape): Update comment.
9000 * ui-file.h (class no_terminal_escape_file): New class.
9001 * ui-file.c (no_terminal_escape_file::write)
9002 (no_terminal_escape_file::puts): New methods.
9003 * cli/cli-logging.c (handle_redirections): Use
9004 no_terminal_escape_file.
9005
52ce35e2
TT
90062019-06-14 Tom Tromey <tromey@adacore.com>
9007
9008 * NEWS: Move convenience variable news above Python news.
9009
73cc7272
TT
90102019-06-14 Tom Tromey <tom@tromey.com>
9011
9012 * gnulib: Move directory to top-level.
9013 * configure.ac: Don't configure gnulib.
9014 * configure: Rebuild.
9015 * common/common-defs.h: Use new path to gnulib.
9016 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9017 (GNULIB_H): Remove.
9018 (INCGNU): Look in new gnulib location.
9019 (HFILES_NO_SRCDIR): Remove gnulib files.
9020 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9021 (generated_files): Remove GNULIB_H.
9022 ($(LIBGNU), all-lib): Remove targets.
9023 (distclean): Don't mention GNULIB_BUILDDIR.
9024 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9025
f5686554
TT
90262019-06-14 Tom Tromey <tromey@adacore.com>
9027
9028 * symfile.c (add_symbol_file_command): Remove obsolete comment.
9029 Warn if symbol file does not provide any symbols.
9030
a0c1ffed
TT
90312019-06-14 Tom Tromey <tromey@adacore.com>
9032
9033 * source.c (find_and_open_source): Respect basenames_may_differ.
9034
7c39e397
AB
90352019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
9036
9037 * annotate.c (annotate_breakpoints_invalid): Make use of
9038 scoped_restore_terminal_state.
9039 (annotate_frames_invalid): Likewise.
9040
f411722c
TT
90412019-06-14 Tom Tromey <tromey@adacore.com>
9042
9043 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9044 allow assignment to an internalvar.
9045
4268ec18
TT
90462019-06-14 Tom Tromey <tromey@adacore.com>
9047
9048 * ada-lex.l: Allow "_" in attribute names.
9049
abdb711e
TT
90502019-06-14 Tom Tromey <tromey@adacore.com>
9051
9052 PR gdb/24653:
9053 * regcache.c (registers_changed): Don't call alloca.
9054 * top.c (execute_command): Don't call alloca.
9055
4c048731
PA
90562019-06-13 Pedro Alves <palves@redhat.com>
9057
9058 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9059 'expression'. When parsing an expression, error out if there's
9060 junk after "unlimited".
9061 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9062 (do_set_command): Adjust calls to is_unlimited_literal.
9063
66eb1ed3
PA
90642019-06-13 Pedro Alves <palves@redhat.com>
9065
9066 * compile/compile.c (make_compile_options_def_group): Add braces
9067 around array_view initializer.
9068 * thread.c (make_thread_apply_all_options_def_group)
9069 (make_thread_apply_all_options_def_group): Likewise.
9070
3345721a
PA
90712019-06-13 Pedro Alves <palves@redhat.com>
9072
9073 * NEWS (New commands): Mention "maint test-options
9074 require-delimiter", "maint test-options unknown-is-error", "maint
9075 test-options unknown-is-operand" and "maint show
9076 test-options-completion-result".
9077 (New command options, command completion): New section.
9078 (Completion improvements): New section.
9079 Mention that you can abbreviate "unlimited".
9080
6206060d
PA
90812019-06-13 Pedro Alves <palves@redhat.com>
9082
9083 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9084 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9085 * unittests/cli-utils-selftests.c (test_parse_flags)
9086 (test_parse_flags_qcs): Delete.
9087 (test_cli_utils): Don't call deleted functions.
9088
6665660a
PA
90892019-06-13 Pedro Alves <palves@redhat.com>
9090
9091 * thread.c: Include "cli/cli-option.h".
9092 (tp_array_compar_ascending): Global.
9093 (tp_array_compar): Delete function.
9094 (tp_array_compar_ascending, tp_array_compar_descending): New
9095 functions.
9096 (ascending_option_def, qcs_flag_option_def)
9097 (thr_qcs_flags_option_defs)
9098 (make_thread_apply_all_options_def_group)
9099 (make_thread_apply_options_def_group): New.
9100 (thread_apply_all_command): Use gdb::option::process_options.
9101 (thread_apply_command_completer)
9102 (thread_apply_all_command_completer): New.
9103 (thread_apply_command): Use gdb::option::process_options.
9104 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9105 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
9106 to generate help text of "thread apply". Adjust "taas"'s help.
9107 * tid-parse.c (tid_range_parser::in_thread_range): New method.
9108 * tid-parse.h (tid_range_parser::in_thread_range): New method.
9109
f7e13587
PA
91102019-06-13 Pedro Alves <palves@redhat.com>
9111
9112 * thread.c (thread_apply_command): Check for invalid TID with
9113 isdigit instead of !isalpha.
9114
5d707134
PA
91152019-06-13 Pedro Alves <palves@redhat.com>
9116
9117 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9118 (validate_flags_qcs): New.
9119 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9120 (validate_flags_qcs): Declare.
9121 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9122 (make_frame_apply_options_def_group): New.
9123 (frame_apply_command_count): Process options with
9124 gdb::option::process_options.
9125 (frame_apply_completer): New.
9126 (frame_apply_level_completer, frame_apply_all_completer)
9127 (frame_apply_completer): New.
9128 (_initialize_stack): Update help of "frame apply", "frame apply
9129 level", "frame apply all" and "faas" to mention supported options
9130 and install command completers.
9131 * stack.h (frame_apply_all_completer): Declare.
9132 * thread.c: Include "stack.h".
9133 (tfaas_command): Add "--".
9134 (_initialize_thread): Update help "tfaas" to mention supported
9135 options and install command completer.
9136
272d4594
PA
91372019-06-13 Pedro Alves <palves@redhat.com>
9138
9139 * completer.c (complete_nested_command_line): New.
9140 (gdb_completion_word_break_characters_throw): Add assertion.
9141 * completer.h (complete_nested_command_line): Declare.
9142
90a1ef87
PA
91432019-06-13 Pedro Alves <palves@redhat.com>
9144
9145 * stack.c (parse_backtrace_qualifiers): New.
9146 (backtrace_command): Use it.
9147 (backtrace_command_completer): Complete on qualifiers.
9148
d4c16835
PA
91492019-06-13 Pedro Alves <palves@redhat.com>
9150
9151 * frame.c: Include "cli/cli-option.h.
9152 (user_set_backtrace_options): New.
9153 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9154 Delete.
9155 (get_prev_frame): Adjust.
9156 (boolean_option_def, uinteger_option_def)
9157 (set_backtrace_option_defs): New.
9158 (_initialize_frame): Adjust and use
9159 gdb::option::add_setshow_cmds_for_options to install "set
9160 backtrace past-main" and "set backtrace past-entry".
9161 * frame.h: Include "cli/cli-option.h".
9162 (struct frame_print_options): Forward declare.
9163 (print_frame_arguments_all, print_frame_arguments_scalars)
9164 (print_frame_arguments_none): Declare.
9165 (print_entry_values): Delete declaration.
9166 (struct frame_print_options, user_frame_print_options): New.
9167 (struct set_backtrace_options): New.
9168 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9169 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9170 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9171 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9172 (list_args_or_locals): Add frame_print_options parameter.
9173 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9174 * python/py-framefilter.c (enumerate_args): Pass down
9175 USER_FRAME_PRINT_OPTIONS.
9176 * stack.c: Include "cli/cli-option.h".
9177 (print_frame_arguments_all, print_frame_arguments_scalars)
9178 (print_frame_arguments_none): Declare.
9179 (print_raw_frame_arguments, print_entry_values): Delete.
9180 (user_frame_print_options): New.
9181 (boolean_option_def, enum_option_def, frame_print_option_defs):
9182 New.
9183 (struct backtrace_cmd_options): New.
9184 (bt_flag_option_def): New.
9185 (backtrace_command_option_defs): New.
9186 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9187 (print_frame_arg, read_frame_arg, print_frame_args)
9188 (print_frame_info, print_frame): Add frame_print_options parameter
9189 and use it.
9190 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9191 (backtrace_command_1): Add frame_print_options and
9192 backtrace_cmd_options parameters and use them.
9193 (make_backtrace_options_def_group): New.
9194 (backtrace_command): Process command options with
9195 gdb::option::process_options.
9196 (backtrace_command_completer): New.
9197 (_initialize_stack): Extend "backtrace"'s help to mention
9198 supported options. Install completer for "backtrace".
9199 Install some settings commands with add_setshow_cmds_for_options.
9200
2daf894e
PA
92012019-06-13 Pedro Alves <palves@redhat.com>
9202
9203 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9204 and that "set/show print raw frame-arguments" are now deprecated.
9205
9206 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9207 command.
9208 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9209 * stack.c (_initialize_stack): Install "set/show print
9210 raw-frame-arguments", and deprecate "set/show print raw
9211 frame-arguments".
9212 * valprint.c (_initialize_valprint): Deprecate "set/show print
9213 raw".
9214
e6ed716c
PA
92152019-06-13 Pedro Alves <palves@redhat.com>
9216
9217 * compile/compile.c (struct compile_options): New.
9218 (compile_flag_option_def, compile_command_option_defs)
9219 (make_compile_options_def_group): New.
9220 (compile_file_command): Handle options with
9221 gdb::option::process_options.
9222 (compile_file_command_completer): New function.
9223 (compile_code_command): Handle options with
9224 gdb::option::process_options.
9225 (compile_code_command_completer): New function.
9226 (_initialize_compiler): Install completers for "compile code" and
9227 "compile file". Mention available options in "compile code" and
9228 "compile code"'s help.
9229 * completer.c (advance_to_completion_word): New, factored out from
9230 ...
9231 (advance_to_expression_complete_word_point): ... this.
9232 (advance_to_filename_complete_word_point): New.
9233 * completer.h (advance_to_filename_complete_word_point): New
9234 declaration.
9235
7d8062de
PA
92362019-06-13 Pedro Alves <palves@redhat.com>
9237
9238 * compile/compile.c: Include "cli/cli-option.h".
9239 (compile_print_value): Scope data pointer is now a
9240 value_print_options pointer; adjust.
9241 (compile_print_command): Process options. Scope data pointer is
9242 now a value_print_options pointer; adjust.
9243 (_initialize_compile): Update "compile print"'s help to include
9244 supported options. Install a completer for "compile print".
9245 * cp-valprint.c (show_vtblprint, show_objectprint)
9246 (show_static_field_print): Delete.
9247 (_initialize_cp_valprint): Don't install "set print
9248 static-members", "set print vtbl", "set print object" here.
9249 * printcmd.c: Include "cli/cli-option.h" and
9250 "common/gdb_optional.h".
9251 (print_command_parse_format): Rework to fill in a
9252 value_print_options instead of a format_data.
9253 (print_value): Change parameter type from format_data pointer to
9254 value_print_options reference. Adjust.
9255 (print_command_1): Process options. Adjust to pass down a
9256 value_print_options.
9257 (print_command_completer): New.
9258 (_initialize_printcmd): Install print_command_completer as
9259 handle_brkchars completer for the "print" command. Update
9260 "print"'s help to include supported options.
9261 * valprint.c: Include "cli/cli-option.h".
9262 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9263 here from cp-valprint.c.
9264 (boolean_option_def, uinteger_option_def)
9265 (value_print_option_defs, make_value_print_options_def_group):
9266 New. Use gdb::option::add_setshow_cmds_for_options to install
9267 "set print elements", "set print null-stop", "set print repeats",
9268 "set print pretty", "set print union", "set print array", "set
9269 print address", "set print symbol", "set print array-indexes".
9270 * valprint.h: Include <string> and "cli/cli-option.h".
9271 (make_value_print_options_def_group): Declare.
9272 (print_value): Change parameter type from format_data pointer to
9273 value_print_options reference.
9274 (print_command_completer): Declare.
9275
9d0faba9
PA
92762019-06-13 Pedro Alves <palves@redhat.com>
9277
9278 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9279 (COMMON_SFILES): Add maint-test-settings.c.
9280 * cli/cli-decode.c (boolean_enums): New global, factored out from
9281 ...
9282 (add_setshow_boolean_cmd): ... here.
9283 * cli/cli-decode.h (boolean_enums): Declare.
9284 * cli/cli-option.c: New file.
9285 * cli/cli-option.h: New file.
9286 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9287 factored out from ...
9288 (parse_cli_boolean_value(const char *)): ... this.
9289 (is_unlimited_literal): Change parameter type to pointer to
9290 pointer. Adjust and advance ARG pointer.
9291 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9292 (parse_cli_var_enum): New, factored out from ...
9293 (do_set_command): ... this. Adjust.
9294 * cli/cli-setshow.h (parse_cli_boolean_value)
9295 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9296 (parse_cli_var_enum): Declare.
9297 * cli/cli-utils.c: Include "cli/cli-option.h".
9298 (get_ulongest): New.
9299 * cli/cli-utils.h (get_ulongest): Declare.
9300 (check_for_argument): New overloads.
9301 * maint-test-options.c: New file.
9302
2c722807
PA
93032019-06-13 Pedro Alves <palves@redhat.com>
9304
9305 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9306 parse a range if "-" is at the end of the string.
9307
dee7b4c8
PA
93082019-06-13 Pedro Alves <palves@redhat.com>
9309
9310 * cli/cli-setshow.c (parse_auto_binary_operation)
9311 (parse_cli_boolean_value): Don't allow "o".
9312
dca0f6c0
PA
93132019-06-13 Pedro Alves <palves@redhat.com>
9314
9315 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9316 * NEWS: Mention maint test-settings KIND.
9317 * maint-test-settings.c: New file.
9318
597bf39d
PA
93192019-06-13 Pedro Alves <palves@redhat.com>
9320
9321 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9322 completer.
9323 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9324 "set" completers.
9325
48c410fb
PA
93262019-06-13 Pedro Alves <palves@redhat.com>
9327
9328 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9329 after item.
9330
93bcb043
PA
93312019-06-13 Pedro Alves <palves@redhat.com>
9332
9333 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9334
cbba3ecd
PA
93352019-06-13 Pedro Alves <palves@redhat.com>
9336
9337 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9338 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9339 call.
9340 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9341 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9342 calls.
9343 (check_for_argument): Skip spaces after argument.
9344
b9a3f842
PA
93452019-06-13 Pedro Alves <palves@redhat.com>
9346
9347 * thread.c (thread_apply_command): Adjust TID parsing.
9348 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9349 detected before end of string.
9350 (tid_is_in_list): Error out if LIST is invalid.
9351
3844e605
PA
93522019-06-13 Pedro Alves <palves@redhat.com>
9353
9354 * completer.c (complete_line_internal_1): Rewind completion word
9355 point.
9356 (completion_tracker::advance_custom_word_point_by): Change
9357 parameter type to int.
9358 * completer.h (completion_tracker::advance_custom_word_point_by):
9359 Likewise.
9360
00b56dbe
PA
93612019-06-13 Pedro Alves <palves@redhat.com>
9362
9363 * completer.c (advance_to_completion_word): Handle delimiters.
9364
d106773e
PA
93652019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9366
9367 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9368
08f10e02
TT
93692019-06-11 Tom Tromey <tom@tromey.com>
9370
9371 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9372 (xmalloc_failed): Move to alloc.c.
9373 * alloc.c: New file.
9374 * Makefile.in (COMMON_SFILES): Add alloc.c.
9375
1c7fe951
TT
93762019-06-11 Tom Tromey <tom@tromey.com>
9377
9378 * nat/linux-waitpid.c: Don't include server.h.
9379 (linux_debug): Remove.
9380 (my_waitpid): Update.
9381
89549d7f
TT
93822019-06-11 Tom Tromey <tromey@adacore.com>
9383
9384 * infcall.c (_initialize_infcall): Remove trailing newline from
9385 help.
9386 * user-regs.c (_initialize_user_regs): Remove trailing newline
9387 from help.
9388 * typeprint.c (_initialize_typeprint): Remove trailing newline
9389 from help.
9390 * reverse.c (_initialize_reverse): Remove trailing newlines from
9391 help.
9392 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9393 from help.
9394 * language.c (add_set_language_command): Remove trailing newline
9395 from help.
9396 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9397 help.
9398 * disasm.c (_initialize_disasm): Remove trailing newline from
9399 help.
9400 * top.c (init_main): Remove trailing newline from help.
9401 * interps.c (_initialize_interpreter): Remove trailing newline
9402 from help.
9403 * btrace.c (_initialize_btrace): Remove trailing newlines from
9404 help.
9405 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9406 from help.
9407 * python/python.c (_initialize_python): Remove trailing newline
9408 from help.
9409 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9410 help.
9411 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9412 from help. Reformat some text.
9413 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9414 from help.
9415 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9416 newline from help.
9417
86108c13
TT
94182019-06-11 Tom Tromey <tromey@adacore.com>
9419
9420 * darwin-nat.c (darwin_decode_exception_message)
9421 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9422
a7067863
AB
94232019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9424
9425 * valops.c (value_slice): Check for not allocated or not
9426 associated values.
9427
9ab08412
TV
94282019-06-10 Tom de Vries <tdevries@suse.de>
9429
9430 PR gdb/24618
9431 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9432 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9433 invalid.
9434
f19e22e9
TV
94352019-06-10 Tom de Vries <tdevries@suse.de>
9436
9437 PR gdb/24611
9438 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9439 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9440
e99f9db0
TV
94412019-06-10 Tom de Vries <tdevries@suse.de>
9442
9443 PR symtab/24545
9444 * symtab.c (struct demangled_name_entry): Add language field.
9445 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9446 static minimal symbol". Set and use language field.
9447
9bf7038b
TT
94482019-06-10 Tom Tromey <tromey@adacore.com>
9449
9450 * ada-lang.c (_initialize_ada_language): Update help text.
9451
422186a9
TT
94522019-06-10 Tom Tromey <tromey@adacore.com>
9453
9454 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9455 with a newline.
9456 * guile/guile.c (handle_boot_error): Don't end warning with a
9457 newline.
9458 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9459 warning with a newline.
9460 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9461 newline.
9462 (s12z_frame_cache): Likewise.
9463 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9464 a newline.
9465 * solib-svr4.c (disable_probes_interface): Don't end warning with
9466 a newline.
9467 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9468 newline.
9469 * python/python.c (do_finish_initialization): Don't end warning
9470 with a newline.
9471
25ce02ee
TT
94722019-06-10 Tom Tromey <tom@tromey.com>
9473
9474 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9475 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9476 gdbpy_enter.
9477
caa429d8
TT
94782019-06-10 Tom Tromey <tromey@adacore.com>
9479
9480 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9481 data.
9482 (elf_new_init): Don't call stabsread_new_init.
9483 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9484 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9485 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9486
81873cc8
TV
94872019-06-10 Tom de Vries <tdevries@suse.de>
9488
9489 PR symtab/16264
9490 PR symtab/24517
9491 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9492
4fa0265e
РИ
94932019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9494
9495 * source.c (find_and_open_source): Also rewrite relative file
9496 names.
9497
1a3da2cd
AB
94982019-04-26 Amos Bird <amosbird@gmail.com>
9499
9500 * annotate.c (annotate_thread_exited): Add "thread-exited"
9501 annotation.
9502
3847a7bf
TT
95032019-06-06 Tom Tromey <tromey@adacore.com>
9504
9505 * maint.h (class scoped_command_stats): Use
9506 DISABLE_COPY_AND_ASSIGN.
9507 <print_time>: New method.
9508 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9509 print_time.
9510 (scoped_command_stats::print_time): New method.
9511
312617a3
AB
95122019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9513
9514 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9515 instructions of lengths 6 or 8 bytes.
9516
b02f78f9
PA
95172019-06-04 Pedro Alves <palves@redhat.com>
9518
9519 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9520
9521 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9522 * breakpoint.c (condition_completer): Likewise.
9523 * cli/cli-dump.c (scan_expression): Likewise.
9524 * common/filestuff.c (mkdir_recursive): Likewise.
9525 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9526 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9527 (gdb_abspath): Likewise.
9528 * compile/compile-cplus-types.c
9529 (compile_cplus_instance::decl_name): Likewise.
9530 * completer.c (complete_explicit_location):
9531 (signal_completer, reg_or_group_completer_1): Likewise.
9532 * cp-support.c (cp_remove_params_if_any): Likewise.
9533 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9534 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9535 * infcmd.c (strip_bg_char): Likewise.
9536 * linespec.c (copy_token_string): Likewise.
9537 * mi/mi-main.c (output_cores): Likewise.
9538 * psymtab.c (psymtab_search_name):
9539 * symfile.c (test_set_ext_lang_command): Likewise.
9540 * target.c (target_fileio_read_stralloc): Likewise.
9541 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9542 * value.c (complete_internalvar): Likewise.
9543
e1f2e1a2
CB
95442019-06-04 Christian Biesinger <cbiesinger@google.com>
9545
9546 Add objfile property to gdb.Type.
d3238f7d
PA
9547 * NEWS: Mention Python API addition.
9548 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 9549
e664d728
PW
95502019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9551
9552 * NEWS: Mention the new set|show style [title|highlight].
9553 Mention changes to "show style", "help" and "apropos".
9554
66d8c862
PW
95552019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9556
9557 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9558 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9559 instead of print_help_for_command.
9560 (print_doc_of_command): New function.
9561 (help_list): Add 'apropos -v word' suggestion.
9562 (print_help_for_command): Style the command name using title style.
9563 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9564 (_initialize_cli_cmds): Describe -v in apropos_command help.
9565
9303eb2f
PW
95662019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9567
9568 * cli/cli-style.h (cli_style_option): Add name in constructor,
9569 add m_name class member, add constructor with intensity,
9570 add name class function.
9571 (cli_style_option::add_setshow_commands): Remove name argument.
9572 (highlight_style, title_style): New styles.
9573 * cli/cli-style.c (do_show): New function that shows a style
9574 characteristic styling the style name with itself.
9575 (set_style_name): New function.
9576 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9577 Update all callers according to the changes in cli/cli-style.h.
9578 * utils.h (fputs_highlighted): New function.
9579 * utils.c (fputs_highlighted): Likewise.
9580
e2c52041
PW
95812019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9582
9583 * NEWS: Mention new pipe command and new convenience variables.
9584
947d3946
PW
95852019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9586
9587 * cli/cli-cmds.c (pipe_command): New function.
9588 (_initialize_cli_cmds): Call add_com for pipe_command.
9589 Define | as an alias for pipe.
9590 (exit_status_set_internal_vars): New function.
9591 (shell_escape): Call exit_status_set_internal_vars.
9592 cli/cli-decode.c (find_command_name_length): Recognize | as
9593 a single character command.
9594
b8fd0918
PW
95952019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9596
9597 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9598 top.c (execute_command_to_ui_file): New function, mostly a copy
9599 of execute_command_to_string.
9600 (execute_command_to_string): Implement by calling
9601 execute_command_to_ui_file.
9602
68bb5386
PW
96032019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9604
9605 * top.h (saved_command_line): Remove declaration.
9606 * top.c (previous_saved_command_line, previous_repeat_arguments):
9607 New variables.
9608 (saved_command_line): Make static, define together with other
9609 'repeat variables'.
9610 (dont_repeat): Clear repeat_arguments.
9611 (repeat_previous, get_saved_command_line, save_command_line):
9612 New functions.
9613 (gdb_init): Initialize saved_command_line
9614 and previous_saved_command_line.
9615 * main.c (captured_main_1): Remove saved_command_line initialization.
9616 * event-top.c (handle_line_of_input): Update to use
9617 the new 'repeat' related functions instead of direct access to
9618 saved_command_line.
9619 * command.h (repeat_previous, get_saved_command_line,
9620 save_command_line): New declarations.
9621 (dont_repeat): Add comment.
9622
bfcdb852
TT
96232019-05-30 Tom Tromey <tromey@adacore.com>
9624
9625 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9626 Fix comment.
9627 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9628
0ef209f2
JV
96292019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9630
9631 PR cli/24587
9632 * completer.c (complete): Initialize variable word.
9633
955b06fa
SDJ
96342019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9635
9636 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9637 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9638 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9639 'body' is NULL to the outter 'if', protecting the '!is_define'
9640 situation as well.
9641
fa9c3fa0
TT
96422019-05-29 Tom Tromey <tromey@adacore.com>
9643
9644 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9645 (dwarf_unknown): New function.
9646 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9647 (dwarf_type_encoding_name): Use dwarf_unknown.
9648
4330d61d
TT
96492019-05-29 Tom Tromey <tromey@adacore.com>
9650
9651 PR c++/20020:
9652 * cp-valprint.c (cp_print_value_fields): Call
9653 cp_print_static_field inside "try".
9654
33a6bc35
TT
96552019-05-29 Tom Tromey <tromey@adacore.com>
9656
9657 * inflow.c (struct terminal_info): Add default operator=.
9658 * configure: Rebuild.
9659 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9660 -Wdeprecated-copy-dtor, -Wredundant-move.
9661
000439d5
TT
96622019-05-29 Tom Tromey <tromey@adacore.com>
9663
9664 * NEWS: Add entry.
9665 * infcmd.c (print_return_value_1): Handle finish_print
9666 option.
9667 (show_print_finish): New function.
9668 (_initialize_infcmd): Add "set/show print finish" commands.
9669 * valprint.c (user_print_options): Initialize new member.
9670 * valprint.h (struct value_print_options) <finish_print>: New
9671 member.
9672
c0e70c62
TT
96732019-05-28 Tom Tromey <tromey@adacore.com>
9674
9675 * ada-lang.c (ada_remove_Xbn_suffix)
9676 (find_old_style_renaming_symbol)
9677 (parse_old_style_renaming): Remove.
9678 (ada_find_renaming_symbol): Don't call
9679 find_old_style_renaming_symbol.
9680 (ada_is_renaming_symbol): Rename from
9681 ada_find_renaming_symbol. Remove "block" parameter. Return
9682 bool. Now static.
9683 (ada_read_var_value): Update and simplify.
9684 * ada-exp.y (write_var_or_type): Remove old code.
9685
766f8836
AH
96862019-05-28 Alan Hayward <alan.hayward@arm.com>
9687
68255adc 9688 PR gdb/25010
766f8836
AH
9689 * event-top.c: Remove include comment.
9690 * inflow.c (class scoped_ignore_sigttou): Move from here...
9691 * inflow.h (class scoped_ignore_sigttou): ...to here.
9692 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9693 * top.c: Remove include comment.
9694
eb41253a
TT
96952019-05-27 Tom Tromey <tom@tromey.com>
9696
9697 * NEWS: Fix typo.
9698
4ca51187
TT
96992019-05-22 Tom Tromey <tromey@adacore.com>
9700
9701 * target.c (target_follow_exec): Constify parameter.
9702 * target-delegates.c: Rebuild.
9703 * remote.c (remote_target::follow_exec): Constify parameter.
9704 * infrun.c (follow_exec): Constify parameter.
9705 * target.h (struct target_ops) <follow_exec>: Constify parameter.
9706 (target_follow_exec): Likewise.
9707
8fca4da0
AH
97082019-05-22 Alan Hayward <alan.hayward@arm.com>
9709
9710 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9711 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9712
b7060614
AH
97132019-05-22 Alan Hayward <alan.hayward@arm.com>
9714
9715 * NEWS: Add debugredirect and testsuite sections.
9716
0a5954bd
SC
97172019-05-22 Simon Cook <simon.cook@embecosm.com>
9718
9719 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9720 target descriptions using exclusively floating point register name
9721 aliases.
9722
dc42e902
AB
97232019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
9724
9725 PR gdb/18644:
9726 * f-lang.c (build_fortran_types): Handle the case where
9727 gdbarch_floatformat_for_type returns a nullptr.
9728
fb7806c7
TV
97292019-05-21 Tom de Vries <tdevries@suse.de>
9730
9731 PR cli/24587
9732 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9733
34d11c68
AB
97342019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9735
9736 PR gdb/18644:
9737 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9738 16-byte floats.
9739 * i386-tdep.c (i386_floatformat_for_type): Use
9740 floatformats_ia64_quad for the 16-byte floating point component
9741 within a fortran 32-byte complex number.
9742
122cf0f2
AB
97432019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9744
9745 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9746 delete default constructor.
9747 (find_partial_die): Update to return const struct.
9748 (partial_die_parent_scope): Move variable declaration into scope
9749 of its use and change its type to auto.
9750 (guess_partial_die_structure_name): Likewise.
9751 (partial_die_info::fixup): Likewise.
9752
33d0e35a
TT
97532019-05-17 Tom Tromey <tromey@adacore.com>
9754
9755 * source.c (find_and_open_source): Remove cast.
9756
a45575b0
TT
97572019-05-17 Tom Tromey <tromey@adacore.com>
9758
9759 * annotate.c (annotate_source): Make "filename" const.
9760 * annotate.h (annotate_source): Use const.
9761
81f47ac2
AH
97622019-05-17 Alan Hayward <alan.hayward@arm.com>
9763
9764 * disasm.c (set_disassembler_options): Send errors to stderr.
9765
ca1285d1
AH
97662019-05-17 Alan Hayward <alan.hayward@arm.com>
9767
9768 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9769 (cli_interp_base::set_logging): Check debug_redirect.
9770 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9771 * cli/cli-logging.c (debug_redirect): Add static variable.
9772 (pop_output_files): Add default param.
9773 (handle_redirections): Print debug setting.
9774 (show_logging_command): Likewise.
9775 (_initialize_cli_logging): Add debugredirect command.
9776 * interps.c (current_interp_set_logging): Add debug_redirect
9777 parameter.
9778 * interps.h (set_logging): Add debug_redirect parameter.
9779 (current_interp_set_logging): Likewise.
9780 * mi/mi-common.h: Likewise.
9781 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9782
97832019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
9784 Tom Tromey <tromey@adacore.com>
9785
9786 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9787 directly.
9788 * cli/cli-interp.h (make_logging_output): Remove declaration.
9789 * cli/cli-logging.c (make_logging_output): Remove function.
9790 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9791 directly.
9792 * ui-file.c (tee_file::tee_file): Remove bools.
9793 (tee_file::~tee_file): Remove deletes.
9794 * ui-file.h (tee_file): Remove bools.
9795
26648588
JV
97962019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
9797
9798 * mi/mi-cmds.h (mi_cmd_complete): New function.
9799 * mi/mi-main.c (mi_cmd_complete): Likewise.
9800 * mi/mi-cmds.c: Define new MI command -complete.
9801 * NEWS: Mention new -complete command.
9802
6e035501
JV
98032019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
9804
9805 * completer.h (complete): New function.
9806 * completer.c (complete): Likewise.
9807 * cli/cli-cmds.c: (complete_command): Update to use new complete()
9808 function defined in completer.h.
9809
7d0e2ece
JV
98102019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
9811
e79be6e5 9812 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 9813
fb816e8b
TV
98142019-05-17 Tom de Vries <tdevries@suse.de>
9815
9816 PR gdb/24094
9817 * dwarf2read.c (struct cu_partial_die_info): New struct.
9818 (find_partial_die): Return cu_partial_die_info.
9819 (partial_die_parent_scope, guess_partial_die_structure_name)
9820 (partial_die_info::fixup): Handle new return type of find_partial_die.
9821
677052f2
SDJ
98222019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9823
a1726c38 9824 PR breakpoints/24541
677052f2
SDJ
9825 * stap-probe.c (stap_parse_register_operand): Make "regname" an
9826 "std::string", simplifying the algorithm.
9827
f3da9116
SDJ
98282019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9829
9830 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9831 (stap_static_probe_ops::get_probes): Likewise.
9832
f1bb75ab
SDJ
98332019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9834
9835 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9836 '-')" and "else if".
9837 (stap_parse_single_operand): Join checks for
9838 "gdbarch_stap_parse_special_token_p" and
9839 "gdbarch_stap_parse_special_token" in the same "if" statement.
9840 Invert check when verifying for operation on register
9841 displacement.
9842
3ca58cde
SDJ
98432019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9844
9845 * stap-probe.c (stap_get_opcode): Update comment.
9846 (stap_get_expected_argument_type): Likewise.
9847 (handle_stap_probe): Likewise.
9848
af2d9bee
SDJ
98492019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9850
9851 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9852 return type to 'bool'. Adjust comment. Use 'bool' when
9853 appropriate.
9854 (i386_stap_parse_special_token_three_arg_disp): Likewise.
9855 * stap-probe.c (stap_parse_argument_1): Likewise.
9856 (stap_is_operator): Likewise.
9857 (stap_is_generic_prefix): Likewise.
9858 (stap_is_register_prefix): Likewise.
9859 (stap_is_register_indirection_prefix): Likewise.
9860 (stap_is_integer_prefix): Likewise.
9861 (stap_generic_check_suffix): Likewise.
9862 (stap_check_integer_suffix): Likewise.
9863 (stap_check_register_suffix): Likewise.
9864 (stap_check_register_indirection_suffix): Likewise.
9865 (stap_parse_register_operand): Likewise.
9866 (stap_parse_single_operand): Likewise.
9867 (stap_parse_argument_1): Likewise.
9868 (stap_probe::get_argument_count): Likewise.
9869 (stap_is_operator): Likewise.
9870
61c9c421
TT
98712019-05-16 Tom Tromey <tromey@adacore.com>
9872
9873 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9874 keyword to foreach.
9875
9ddc1af1
SM
98762019-05-15 Simon Marchi <simon.marchi@efficios.com>
9877
9878 * linux-thread-db.c (try_thread_db_load_1): Change return type
9879 to bool.
9880 (try_thread_db_load): Likewise.
9881 (try_thread_db_load_from_pdir_1): Likewise.
9882 (try_thread_db_load_from_pdir): Likewise.
9883 (try_thread_db_load_from_sdir): Likewise.
9884 (try_thread_db_load_from_dir): Likewise.
9885 (thread_db_load_search): Likewise.
9886 (has_libpthread): Likewise.
9887 (thread_db_load): Likewise.
9888
7bede828
SDJ
98892019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
9890
9891 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9892 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9893 NULL, and complain/return if that's the case.
9894
c5358db4
JD
98952019-05-15 John Darrington <john@darrington.wattle.id.au>
9896
9897 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9898 (advance, posn, abstract_read_memory): New functions.
9899 [struct mem_read_abstraction]: New struct.
9900 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9901
c408a94f
TT
99022019-05-14 Tom Tromey <tromey@adacore.com>
9903
9904 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9905 value is not lval_memory.
9906
e7bd7fba
TT
99072019-05-14 Tom Tromey <tromey@adacore.com>
9908
9909 * solib.c (info_sharedlibrary_command): Style the file name.
9910
a6d0f249
AH
99112019-05-14 Alan Hayward <alan.hayward@arm.com>
9912
9913 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9914 (aarch64_vnv_type): Likewise.
9915 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9916 * common/tdesc.c: Likewise.
9917 * common/tdesc.h (enum tdesc_type_kind): Likewise.
9918 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9919 * features/aarch64-fpu.xml: Add ieee half view.
9920 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9921 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9922 * gdbtypes.h (struct builtin_type): Likewise.
9923 (struct objfile_type): Likewise.
9924
66b8bb74
SM
99252019-05-12 Paul Naert <paul.naert@polymtl.ca>
9926
9927 * language.c (language_sniff_from_mangled_name): Fix "langauge"
9928 typo.
9929 * location.h (string_to_event_location): Likewise.
9930
21c219fd
JB
99312019-05-11 Joel Brobecker <brobecker@adacore.com>
9932
9933 GDB 8.3 released.
9934
13674803
SM
99352019-05-10 Simon Marchi <simon.marchi@efficios.com>
9936
9937 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9938 New variable declaration.
9939 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9940 New variable.
9941 (print_one_breakpoint): Use ui_out::test_flags and new global
9942 variable to compute use_fixed_output.
9943 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9944 Remove.
9945 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9946 (mi_multi_location_breakpoint_output_fixed): Remove.
9947 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9948 new variable.
9949 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9950 fix_multi_location_breakpoint_output flag if version >= 3.
9951 * ui-out.h (enum ui_out_flag)
9952 <fix_multi_location_breakpoint_output>: New enumerator.
9953
a9eac7f9
SM
99542019-05-10 Simon Marchi <simon.marchi@efficios.com>
9955
9956 * contrib/cc-with-tweaks.sh: Validate dwz's work.
9957
71bed2db
TT
99582019-05-10 Tom Tromey <tromey@adacore.com>
9959
9960 * ada-lang.c (catch_ada_completer): New function.
9961 (_initialize_ada_language): Use it.
9962
24c54127
TT
99632019-05-10 Tom Tromey <tromey@adacore.com>
9964
9965 * thread.c (print_thread_info): Make "requested_threads" const.
9966 * gdbthread.h (print_thread_info): Make "requested_threads"
9967 const.
9968 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9969 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9970
7a102139
TT
99712019-05-08 Tom Tromey <tom@tromey.com>
9972
9973 * gdbtypes.c (objfile_type_data): Change type.
9974 (objfile_type, _initialize_gdbtypes): Update.
9975
924d79e2
TT
99762019-05-08 Tom Tromey <tom@tromey.com>
9977
9978 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9979 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9980 (_initialize_dwarf2_frame): Update.
9981
4c58e337
TT
99822019-05-08 Tom Tromey <tom@tromey.com>
9983
9984 * objc-lang.c (objc_objfile_data): Change type.
9985 (find_methods): Update.
9986 (_initialize_objc_lang): Remove.
9987
d772d2ab
TT
99882019-05-08 Tom Tromey <tom@tromey.com>
9989
9990 * stabsread.c (rs6000_builtin_type_data): Change type.
9991 (rs6000_builtin_type, _initialize_stabsread): Update.
9992
d11d83f4
TT
99932019-05-08 Tom Tromey <tom@tromey.com>
9994
9995 * mips-tdep.c (mips_pdr_data): Remove.
9996 (_initialize_mips_tdep): Update.
9997
9a73f0ad
TT
99982019-05-08 Tom Tromey <tom@tromey.com>
9999
10000 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10001 (hppa_init_objfile_priv_data, read_unwind_info)
10002 (find_unwind_entry, _initialize_hppa_tdep): Update.
10003
8127a2fa
TT
100042019-05-08 Tom Tromey <tom@tromey.com>
10005
10006 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10007 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
10008 on obstack.
10009 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10010
91d3055d
TT
100112019-05-08 Tom Tromey <tom@tromey.com>
10012
10013 * mdebugread.c (basic_type_data): Change type.
10014 (basic_type, _initialize_mdebugread): Update.
10015
31930bd3
TT
100162019-05-08 Tom Tromey <tom@tromey.com>
10017
10018 * common/gdb_unique_ptr.h (struct noop_deleter): New.
10019
bdb3ed9e
TT
100202019-05-08 Tom Tromey <tom@tromey.com>
10021
10022 * nto-tdep.c (nto_inferior_data_reg): Change type.
10023 (nto_inferior_data): Update.
10024 (nto_inferior_data_cleanup, nto_new_inferior_data)
10025 (_initialize_nto_tdep): Remove.
10026 * nto-tdep.h (struct nto_inferior_data): Add initializers.
10027
f37b313d
TT
100282019-05-08 Tom Tromey <tom@tromey.com>
10029
10030 * ada-lang.c (struct ada_inferior_data): Add initializers.
10031 (ada_inferior_data): Change type.
10032 (ada_inferior_data_cleanup): Remove.
10033 (get_ada_inferior_data, ada_inferior_exit)
10034 (struct ada_pspace_data): Add initializers, destructor.
10035 (ada_pspace_data_handle): Change type.
10036 (get_ada_pspace_data): Update.
10037 (ada_pspace_data_cleanup): Remove.
10038
24699405
TT
100392019-05-08 Tom Tromey <tom@tromey.com>
10040
10041 * coffread.c (struct coff_symfile_info): Add initializers.
10042 (coff_objfile_data_key): Move lower. Change type.
10043 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10044 Update.
10045 (coff_free_info): Remove.
10046
d4e05d2f
TT
100472019-05-08 Tom Tromey <tom@tromey.com>
10048
10049 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10050 (fbsd_pspace_data_handle): Move lower. Change type.
10051 (get_fbsd_pspace_data): Update.
10052 (fbsd_pspace_data_cleanup): Remove.
10053 (_initialize_fbsd_tdep): Update.
10054
14ef6690
TT
100552019-05-08 Tom Tromey <tom@tromey.com>
10056
10057 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10058 (get_ada_tasks_pspace_data): Update.
10059 (ada_tasks_pspace_data_cleanup): Remove.
10060 (_initialize_tasks): Update.
10061 (ada_tasks_inferior_data_handle): Change type.
10062 (get_ada_tasks_inferior_data): Update.
10063 (ada_tasks_inferior_data_cleanup): Remove.
10064 (struct ada_tasks_pspace_data): Add initializers.
10065
814cf43a
TT
100662019-05-08 Tom Tromey <tom@tromey.com>
10067
10068 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10069 * symfile-debug.c (debug_sym_get_probes): Change type.
10070 * stap-probe.c (handle_stap_probe):
10071 (stap_static_probe_ops::get_probes): Change type.
10072 * probe.h (class static_probe_ops) <get_probes>: Change type.
10073 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10074 (parse_probes_in_pspace): Update.
10075 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10076 Update.
10077 (any_static_probe_ops::get_probes): Change type.
10078 * elfread.c (elfread_data): New typedef.
10079 (probe_key): Change type.
10080 (elf_get_probes): Likewise. Update.
10081 (probe_key_free): Remove.
10082 (_initialize_elfread): Update.
10083 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10084 Change type.
10085 (dtrace_process_dof_probe, dtrace_process_dof)
10086 (dtrace_static_probe_ops::get_probe): Change type.
10087
02dc647e
TT
100882019-05-08 Tom Tromey <tom@tromey.com>
10089
10090 * xcoffread.c (struct xcoff_symfile_info): Rename from
10091 coff_symfile_info. Add initializers.
10092 (xcoff_objfile_data_key): Move lower. Change type.
10093 (XCOFF_DATA): Rewrite.
10094 (xcoff_free_info): Remove.
10095 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10096 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10097 (xcoff_initial_scan): Update.
10098
09232438
TT
100992019-05-08 Tom Tromey <tom@tromey.com>
10100
10101 * solib-svr4.c (struct svr4_info): Add initializers and
10102 destructor.
10103 <probes_table>: Now an htab_up.
10104 (solib_svr4_pspace_data): Change type.
10105 (free_probes_table): Simplify.
10106 (~svr4_info): Rename from svr4_pspace_data_cleanup.
10107 (get_svr4_info, probes_table_htab_remove_objfile_probes)
10108 (probes_table_remove_objfile_probes, register_solib_event_probe)
10109 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10110 (_initialize_svr4_solib): Update.
10111
7b4a314f
TT
101122019-05-08 Tom Tromey <tom@tromey.com>
10113
10114 * remote.c (remote_pspace_data): Change type.
10115 (remote_pspace_data_cleanup): Remove.
10116 (get_remote_exec_file, set_pspace_remote_exec_file)
10117 (_initialize_remote): Update.
10118
51d3063a
TT
101192019-05-08 Tom Tromey <tom@tromey.com>
10120
10121 * breakpoint.c (breakpoint_objfile_key): Change type.
10122 (get_breakpoint_objfile_data): Update.
10123 (free_breakpoint_objfile_data): Remove.
10124 (_initialize_breakpoint): Update.
10125
89fb8848
TT
101262019-05-08 Tom Tromey <tom@tromey.com>
10127
10128 * linux-tdep.c (struct linux_info): Add initializers.
10129 (linux_inferior_data): Move. Change type.
10130 (invalidate_linux_cache_inf): Update.
10131 (linux_inferior_data_cleanup): Remove.
10132 (get_linux_inferior_data, _initialize_linux_tdep): Update.
10133
e9b89e2d
TT
101342019-05-08 Tom Tromey <tom@tromey.com>
10135
10136 * auxv.c (auxv_inferior_data): Move. Change type.
10137 (auxv_inferior_data_cleanup): Remove.
10138 (invalidate_auxv_cache_inf): Rewrite.
10139 (get_auxv_inferior_data, _initialize_auxv): Update.
10140
8c42777c
TT
101412019-05-08 Tom Tromey <tom@tromey.com>
10142
10143 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10144 (symfile_debug_objfile_data_key): Change type.
10145 (symfile_debug_installed, debug_qf_has_symbols)
10146 (debug_qf_find_last_source_symtab)
10147 (debug_qf_forget_cached_source_info)
10148 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10149 (debug_qf_print_stats, debug_qf_dump)
10150 (debug_qf_expand_symtabs_for_function)
10151 (debug_qf_expand_all_symtabs)
10152 (debug_qf_expand_symtabs_with_fullname)
10153 (debug_qf_map_matching_symbols)
10154 (debug_qf_expand_symtabs_matching)
10155 (debug_qf_find_pc_sect_compunit_symtab)
10156 (debug_qf_map_symbol_filenames)
10157 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10158 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10159 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10160 (debug_sym_read_linetable, debug_sym_relocate): Update.
10161 (symfile_debug_free_objfile): Remove.
10162 (install_symfile_debug_logging, _initialize_symfile_debug):
10163 Update.
10164
5bfd760d
TT
101652019-05-08 Tom Tromey <tom@tromey.com>
10166
10167 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10168 allocate_on_obstack.
10169 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10170 (get_dwarf2_per_objfile): Update.
10171 (set_dwarf2_per_objfile): Remove.
10172 (dwarf2_has_info, dwarf2_get_section_info): Update.
10173 (dwarf2_free_objfile): Remove.
10174 (_initialize_dwarf2_read): Update.
10175
e85e19b4
TT
101762019-05-08 Tom Tromey <tom@tromey.com>
10177
10178 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10179 initializers.
10180 <unsupported_script_warning_printed,
10181 script_not_found_warning_printed>: Now bool.
10182 (auto_load_pspace_data): Change type.
10183 (~auto_load_pspace_info): Rename from
10184 auto_load_pspace_data_cleanup.
10185 (get_auto_load_pspace_data, init_loaded_scripts_info)
10186 (clear_section_scripts, maybe_print_unsupported_script_warning)
10187 (maybe_print_script_not_found_warning, _initialize_auto_load):
10188 Update.
10189
f6aa7436
TT
101902019-05-08 Tom Tromey <tom@tromey.com>
10191
10192 * objfiles.c (objfile_pspace_info): Add destructor and
10193 initializers.
10194 (objfiles_pspace_data): Change type.
10195 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10196 (get_objfile_pspace_data): Update.
10197 (objfiles_bfd_data): Change type.
10198 (get_objfile_bfd_data): Update.
10199 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10200
6ae614f6
TT
102012019-05-08 Tom Tromey <tom@tromey.com>
10202
10203 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10204 Change type.
10205 (get_catch_syscall_inferior_data): Update.
10206 (catch_syscall_inferior_data_cleanup): Remove.
10207 (_initialize_break_catch_syscall): Update.
10208
6509b8eb
TT
102092019-05-08 Tom Tromey <tom@tromey.com>
10210
10211 * inflow.c (struct terminal_info): Add destructor and
10212 initializers.
10213 (inflow_inferior_data): Change type.
10214 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10215 (get_inflow_inferior_data, inflow_inferior_exit)
10216 (swap_terminal_info, _initialize_inflow): Update.
10217
35632941
TT
102182019-05-08 Tom Tromey <tom@tromey.com>
10219
10220 * target-dcache.c (target_dcache_cleanup): Remove.
10221 (target_dcache_aspace_key): Change type.
10222 (target_dcache_init_p, target_dcache_invalidate)
10223 (target_dcache_get, target_dcache_get_or_init)
10224 (_initialize_target_dcache): Update.
10225 * dcache.h (struct dcache_deleter): New.
10226
3017b94d
TT
102272019-05-08 Tom Tromey <tom@tromey.com>
10228
10229 * symtab.c (struct symbol_cache): Add destructor and
10230 initializers.
10231 (symbol_cache_key): Move. Change type.
10232 (make_symbol_cache, free_symbol_cache): Remove.
10233 (get_symbol_cache): Update.
10234 (symbol_cache_cleanup): Remove.
10235 (ALL_PSPACES, symbol_cache_flush)
10236 (maintenance_print_symbol_cache)
10237 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10238 Update.
10239
a32ad8c5
TT
102402019-05-08 Tom Tromey <tom@tromey.com>
10241
10242 * symtab.c (struct main_info): Add destructor and initializers.
10243 (main_progspace_key): Move. Change type.
10244 (get_main_info): Update.
10245 (main_info_cleanup): Remove.
10246 (_initialize_symtab): Update.
10247
5f6e90a0
TT
102482019-05-08 Tom Tromey <tom@tromey.com>
10249
10250 * registry.h (DECLARE_REGISTRY): Define the _key class.
10251
1bd0c6e4
AB
102522019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10253
10254 * NEWS: Merge two 'New commands' sections.
10255
2228ef77
XR
102562019-05-08 Joel Brobecker <brobecker@adacore.com>
10257
10258 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10259 parameter and use Ada language definition instead.
10260 (ada_val_print_ptr): Remove unused language parameter.
10261 (ada_val_print_num): Remove language parameter and use Ada language
10262 definition instead.
10263 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10264 parameter.
10265 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10266 parameter and use Ada language definition instead.
10267 (ada_val_print_1): Update all ada_val_print_xxx calls.
10268 Remove language parameter.
10269 (ada_val_print): Update ada_val_print_1 call.
10270
60fcc1c3
TT
102712019-05-08 Tom Tromey <tromey@adacore.com>
10272
10273 * remote.c (remote_hw_watchpoint_limit)
10274 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10275 Now static.
10276
ed2b7c17
TT
102772019-05-08 Tom Tromey <tromey@adacore.com>
10278
10279 * maint.c (_initialize_maint_cmds): Move initialization code to
10280 remote.c.
10281 (watchdog, show_watchdog): Move to remote.c.
10282 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10283 "watchdog" static.
10284 (_initialize_remote): Move initialization code from maint.c.
10285 * defs.h (watchdog): Don't declare.
10286
b0be6c91
TT
102872019-05-08 Tom Tromey <tromey@adacore.com>
10288
10289 * tui/tui-interp.c: Include main.h.
10290 * interps.c: Include main.h.
10291 * main.h (interpreter_p): Declare.
10292 * defs.h (interpreter_p): Don't declare.
10293
587ee17b
TT
102942019-05-08 Tom Tromey <tromey@adacore.com>
10295
10296 * dwarf2loc.c: Include dwarf2read.h.
10297 * defs.h (read_unsigned_leb128): Don't declare.
10298 * dwarf2read.h (read_unsigned_leb128): Declare.
10299
ca1df239
TT
103002019-05-08 Tom Tromey <tromey@adacore.com>
10301
10302 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10303 method.
10304
99f20f08
TT
103052019-05-08 Tom Tromey <tromey@adacore.com>
10306
10307 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10308 when no wrap column is set.
10309
80e55b13
TT
103102019-05-08 Tom Tromey <tromey@adacore.com>
10311
10312 * c-lang.c (c_get_string): Handle non-C-style arrays.
10313
9d3421af
TT
103142019-05-08 Tom Tromey <tromey@adacore.com>
10315
10316 * typeprint.c (print_offset_data::update): Print the bit offset,
10317 not the number of bits remaining.
10318
844333e2
TT
103192019-05-08 Tom Tromey <tromey@adacore.com>
10320
10321 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10322 padding at end of comment.
10323
988915ee
TT
103242019-05-08 Tom Tromey <tromey@adacore.com>
10325
10326 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10327 Compare main types.
10328
26bfd823
TT
103292019-05-06 Tom Tromey <tom@tromey.com>
10330
10331 * common/scoped_mmap.c: Include common-defs.h.
10332 * common/scoped_mmap.h: Don't include config.h.
10333
89055eaa
TT
103342019-05-04 Tom Tromey <tom@tromey.com>
10335
10336 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10337 (struct aarch64_call_info): Add initializers.
10338 <si>: Now a std::vector.
10339 (pass_on_stack, aarch64_push_dummy_call): Update.
10340
5da01df5
TT
103412019-05-04 Simon Marchi <simon.marchi@efficios.com>
10342 Tom Tromey <tom@tromey.com>
10343
10344 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10345 (ppc_threads): Now a std::vector. Now static.
10346 (hwdebug_find_thread_points_by_tid)
10347 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10348 Update.
10349
fbdf05a1
TT
103502019-05-04 Tom Tromey <tom@tromey.com>
10351
10352 * arc-tdep.c (arc_tdesc_init): Return bool.
10353
06d16ec9
TT
103542019-05-04 Tom Tromey <tom@tromey.com>
10355
10356 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10357 Use gdb_assert_not_reached.
10358
9c056022
TT
103592019-05-04 Tom Tromey <tom@tromey.com>
10360
10361 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10362 "false".
10363
fa9c2a59
TT
103642019-05-04 Tom Tromey <tom@tromey.com>
10365
10366 * arc-tdep.c (arc_tdesc_init): Use bool.
10367
e2eb806a
TT
103682019-05-04 Tom Tromey <tom@tromey.com>
10369
10370 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10371
6fe87677
TT
103722019-05-04 Tom Tromey <tom@tromey.com>
10373
10374 * cli/cli-cmds.c (valid_command_p): Return bool.
10375
7f008c9e
TT
103762019-05-04 Tom Tromey <tom@tromey.com>
10377
10378 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10379 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10380
b6484282
RT
103812019-05-04 Raul Tambre <raul@tambre.ee>
10382
10383 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10384 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10385 operator for comparison.
10386
af97b416
TT
103872019-05-04 Tom Tromey <tom@tromey.com>
10388
10389 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10390 (lookup_partial_symbol, print_partial_symbols)
10391 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10392 (psymbol_compare): Update.
10393 (add_psymbol_to_bcache): Clear the entire psymbol.
10394 (maintenance_check_psymtabs): Update.
10395 * psympriv.h (struct partial_symbol): Don't derive from
10396 general_symbol_info.
10397 <obj_section, unrelocated_address, address,
10398 set_unrelocated_address>: Update.
10399 <ginfo>: New member.
10400 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10401 (debug_names::write_psymbols): Update.
10402
9d6d4be8
TV
104032019-05-04 Tom de Vries <tdevries@suse.de>
10404
10405 * contrib/cc-with-tweaks.sh: Support -n arg.
10406
66452beb
PW
104072019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10408
10409 * corelow.c (core_target::detach): Ensure frame cache and
10410 register caches are cleared.
10411 inferior.c (exit_inferior_1): Likewise.
10412
bde09ab7
TT
104132019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10414 Tom Tromey <tom@tromey.com>
10415
10416 * dictionary.c (collate_pending_symbols_by_language): Remove
10417 "struct" from foreach.
10418 * symtab.c (lookup_global_symbol_from_objfile)
10419 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10420 foreach.
10421 * ser-tcp.c (net_open): Remove "struct" from foreach.
10422 * objfiles.c (objfile_relocate, objfile_rebase)
10423 (objfile_has_symbols): Remove "struct" from foreach.
10424 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10425 from foreach.
10426 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10427 foreach.
10428 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10429 "struct" from foreach.
10430 * ada-lang.c (create_excep_cond_exprs)
10431 (ada_exception_catchpoint_cond_string): Remove "struct" from
10432 foreach.
10433
222a8d25
TT
104342019-05-03 Tom Tromey <tromey@adacore.com>
10435
10436 * ada-exp.y (convert_char_literal): Check suffix of each
10437 enumerator.
10438
fcd60b84
DP
104392019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10440
10441 PR ada/21406:
10442 * ada-exp.y (yywrap): Don't define.
10443 * ada-lex.l (%option): Add noyywrap
10444 (yywrap): Remove.
10445
5f2459c2
EZ
104462019-05-03 Eli Zaretskii <eliz@gnu.org>
10447
353ea2d1
EZ
10448 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10449 _WIN32_WINNT to the XP level, unless already defined to a higher
10450 level.
10451
10452 * unittests/parse-connection-spec-selftests.c:
10453 * ser-tcp.c:
10454 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10455 override.
10456
5f2459c2
EZ
10457 * symfile.c (find_separate_debug_file): Remove colon from the
10458 drive spec of DOS/Windows file names of the target, so that the
10459 file name produced from DEBUGDIR and the target's directory will
10460 be valid on DOS/Windows systems.
10461
80062eb9
AB
104622019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10463
10464 * rust-lang.c (val_print_struct): Handle printing structures
10465 containing strings.
10466
b8c05e85
TT
104672019-05-02 Tom Tromey <tromey@adacore.com>
10468
10469 * valarith.c (_initialize_valarith): Remove.
10470
4504bbde
TT
104712019-05-01 Tom Tromey <tromey@adacore.com>
10472
10473 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10474 bitfields.
10475
d48e62f4
TT
104762019-05-01 Tom Tromey <tromey@adacore.com>
10477
10478 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10479 for big-endian copies.
10480
15f18d14
AT
104812019-04-30 Ali Tamur <tamur@google.com>
10482 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10483 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10484 (read_3_bytes): New function.
10485
ab4ee614
JB
104862019-04-30 Joel Brobecker <brobecker@adacore.com>
10487
10488 * windows-nat.c (main_thread_id): Delete.
10489 (handle_output_debug_string): Replace main_thread_id by
10490 current_event.dwThreadId.
10491 (fake_create_process): Likewise.
10492 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10493 Do not set main_thread_id.
10494 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10495 current_event.dwThreadId.
10496 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10497
8ed5b76e
JB
104982019-04-30 Joel Brobecker <brobecker@adacore.com>
10499
10500 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10501 Use current_event.dwThreadId instead of main_thread_id.
10502
2ff0a947
TT
105032019-04-30 Tom Tromey <tromey@adacore.com>
10504
10505 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10506 (create_excep_cond_exprs): Iterate over program spaces.
10507 (ada_exception_catchpoint_cond_string): Examine all minimal
10508 symbols for exception types.
10509
a776957c
TT
105102019-04-30 Tom Tromey <tromey@adacore.com>
10511
10512 PR c++/24470:
10513 * dwarf2read.c (process_structure_scope): Handle case where type
10514 has template parameters but no symbol was created.
10515
bc68014d
AB
105162019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10517 Chris January <chris.january@arm.com>
10518
10519 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10520 qualifier.
10521 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10522
f1fdc960
AB
105232019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10524
10525 * f-typeprint.c (f_print_type): Update rules for printing
10526 whitespace.
10527 (f_type_print_varspec_suffix): Likewise.
10528
bf7a4de1
AB
105292019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10530 Chris January <chris.january@arm.com>
10531
10532 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10533 function arguments.
10534
bbe75b9d
AB
105352019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10536
10537 * f-lang.c (build_fortran_types): Change name of void type to
10538 lower case.
10539 * f-typeprint.c (f_type_print_base): Print the name of the void
10540 type, rather than a fixed string.
10541 * f-valprint.c (f_decorations): Use lower case void string.
10542
1db455a7
AB
105432019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10544 Chris January <chris.january@arm.com>
10545
10546 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10547 types for Fortran.
10548
b6d03bb2
AB
105492019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10550 Chris January <chris.january@arm.com>
10551 David Lecomber <david.lecomber@arm.com>
10552
10553 * f-exp.y (BINOP_INTRINSIC): New token.
10554 (exp): New parser rule handling BINOP_INTRINSIC.
10555 (f77_keywords): Add new builtin procedures.
10556 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10557 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10558 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10559 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10560 (print_unop_subexp_f): New function.
10561 (print_binop_subexp_f): New function.
10562 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10563 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10564 (dump_subexp_body_f): Likewise.
10565 (operator_check_f): Likewise.
10566 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10567 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10568
83228e93
AB
105692019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10570
10571 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10572 UNOP_KIND.
10573 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10574 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10575 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10576 (operator_length_f): New fuction.
10577 (print_subexp_f): New function.
10578 (op_name_f): New function.
10579 (dump_subexp_body_f): New function.
10580 (operator_check_f): New function.
10581 (exp_descriptor_f): Replace standard expression handling functions
10582 with new functions.
10583 * gdb/fortran-operator.def: New file.
10584 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10585 * gdb/std-operator.def: Remove UNOP_KIND.
10586
6fdcd7cc
AB
105872019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10588
10589 * std-operator.def: Remove unbalanced, stray double quote
10590 character.
10591
2e62ab40
AB
105922019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10593 Chris January <chris.january@arm.com>
10594 Daniel Everett <daniel.everett@arm.com>
10595 Nick Forrington <nick.forrington@arm.com>
10596 Richard Bunt <richard.bunt@arm.com>
10597
10598 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10599 of depth when printing anonymous structs or unions.
10600 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10601 Don't print either the top-level value, or the children if the
10602 max-depth is exceeded.
10603 (ppscm_print_children): When printing the key of a map, allow one
10604 extra level of depth.
10605 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10606 print either the top-level value, or the children if the max-depth
10607 is exceeded.
10608 (print_children): When printing the key of a map, allow one extra
10609 level of depth.
10610 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10611 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10612 (user_print_options): Initialise max_depth field.
10613 (val_print_scalar_or_string_type_p): New function.
10614 (val_print): Check to see if the max depth has been reached.
10615 (val_print_check_max_depth): Define new function.
10616 (show_print_max_depth): New function.
10617 (_initialize_valprint): Add 'print max-depth' option.
10618 * valprint.h (struct value_print_options) <max_depth>: New field.
10619 (val_print_check_max_depth): Declare new function.
10620 * NEWS: Document new feature.
10621
4be290b2
AB
106222019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10623
10624 * ada-lang.c (ada_language_defn): Initialise new field.
10625 * c-lang.c (c_is_string_type_p): New function.
10626 (c_language_defn): Initialise new field.
10627 (cplus_language_defn): Initialise new field.
10628 (asm_language_defn): Initialise new field.
10629 (minimal_language_defn): Initialise new field.
10630 * c-lang.h (c_is_string_type_p): Declare new function.
10631 * d-lang.c (d_language_defn): Initialise new field.
10632 * f-lang.c (f_is_string_type_p): New function.
10633 (f_language_defn): Initialise new field.
10634 * go-lang.c (go_is_string_type_p): New function.
10635 (go_language_defn): Initialise new field.
10636 * language.c (default_is_string_type_p): New function.
10637 (unknown_language_defn): Initialise new field.
10638 (auto_language_defn): Initialise new field.
10639 * language.h (struct language_defn) <la_is_string_type_p>: New
10640 member variable.
10641 (default_is_string_type_p): Declare new function.
10642 * m2-lang.c (m2_language_defn): Initialise new field.
10643 * objc-lang.c (objc_language_defn): Initialise new field.
10644 * opencl-lang.c (opencl_language_defn): Initialise new field.
10645 * p-lang.c (pascal_is_string_type_p): New function.
10646 (pascal_language_defn): Initialise new field.
10647 * rust-lang.c (rust_is_string_type_p): New function.
10648 (rust_language_defn): Initialise new field.
10649
721b08c6
AB
106502019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10651
10652 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10653 New field.
10654 * ada-lang.c (ada_language_defn): Initialise new field.
10655 * c-lang.c (c_language_defn): Likewise.
10656 (cplus_language_defn): Likewise.
10657 (asm_language_defn): Likewise.
10658 (minimal_language_defn): Likewise.
10659 * d-lang.c (d_language_defn): Likewise.
10660 * f-lang.c (f_language_defn): Likewise.
10661 * go-lang.c (go_language_defn): Likewise.
10662 * language.c (unknown_language_defn): Likewise.
10663 (auto_language_defn): Likewise.
10664 * m2-lang.c (m2_language_defn): Likewise.
10665 * objc-lang.c (objc_language_defn): Likewise.
10666 * opencl-lang.c (opencl_language_defn): Likewise.
10667 * p-lang.c (pascal_language_defn): Likewise.
10668 * rust-lang.c (rust_language_defn): Likewise.
10669
fc913e53
AB
106702019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10671
10672 * ada-lang.c (ada_is_character_type): Change return type to bool.
10673 (ada_is_string_type): Likewise.
10674 * ada-lang.h (ada_is_character_type): Update declaration
10675 (ada_is_string_type): Likewise.
10676
fa731fa0
PW
106772019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10678
10679 Support style in 'frame|thread apply'
10680
10681 * gdbcmd.h (execute_command_to_string): New term_out parameter.
10682 * record.c (record_start, record_stop): Update callers of
10683 execute_command_to_string with false.
10684 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10685 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10686 methods.
10687 (class string_file): New constructor with term_out parameter.
10688 Override methods term_out and can_emit_style_escape. New member
10689 term_out.
10690 (class stdio_file): Override can_emit_style_escape.
10691 (class tee_file): Override term_out and can_emit_style_escape.
10692 * utils.h (can_emit_style_escape): Remove.
10693 * utils.c (can_emit_style_escape): Likewise.
10694 Update all callers of can_emit_style_escape (SOMESTREAM) to
10695 SOMESTREAM->can_emit_style_escape.
10696 * source-cache.c (source_cache::get_source_lines): Likewise.
10697 * stack.c (frame_apply_command_count): Call execute_command_to_string
10698 passing the term_out characteristic of the current gdb_stdout.
10699 * thread.c (thr_try_catch_cmd): Likewise.
10700 * top.c (execute_command_to_string): pass term_out parameter
10701 to construct the string_file for the command output.
10702 * ui-file.c (term_cli_styling): New function (most code moved
10703 from utils.c can_emit_style_escape).
10704 (string_file::string_file, string_file::can_emit_style_escape,
10705 stdio_file::can_emit_style_escape, tee_file::term_out,
10706 tee_file::can_emit_style_escape): New functions.
10707
136afab8
PW
107082019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10709
10710 * NEWS: Mention the new set|show may-call-functions.
10711 * infcall.c (may_call_functions_p): New variable.
10712 (show_may_call_functions_p): New function.
10713 (call_function_by_hand_dummy): Throws an error if not
10714 may-call-functions.
10715 (_initialize_infcall): Call add_setshow_boolean_cmd for
10716 may-call-functions.
10717
725cbb63
KS
107182019-04-25 Keith Seitz <keiths@redhat.com>
10719
10720 PR c++/24367
10721 * cp-support.c (inspect_type): Don't attempt substitutions
10722 of symbol with the same name.
10723
3d1cbb78
TT
107242019-04-25 Tom Tromey <tromey@adacore.com>
10725
10726 PR gdb/24475:
10727 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10728 static.
10729
94aeb44b
TT
107302019-04-25 Tom Tromey <tromey@adacore.com>
10731
10732 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10733 rvalue reference.
10734 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10735 (gdb_xml_parser::parse): Use std::move.
10736 * python/python-internal.h (gdbpy_convert_exception): Take a const
10737 reference.
10738 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10739 std::move.
10740 * python/py-utils.c (gdbpy_convert_exception): Take a const
10741 reference.
10742 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10743 Use std::move.
10744 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10745 Use std::move.
10746 * mi/mi-main.c (mi_print_exception): Take a const reference.
10747 * main.c (handle_command_errors): Take a const reference.
10748 * linespec.c (parse_linespec): Use std::move.
10749 * infcall.c (run_inferior_call): Use std::move.
10750 (call_function_by_hand_dummy): Use std::move.
10751 * exec.c (try_open_exec_file): Use std::move.
10752 * exceptions.h (exception_print, exception_fprintf)
10753 (exception_print_same): Update.
10754 * exceptions.c (print_exception, exception_print)
10755 (exception_fprintf, exception_print_same): Change parameters to
10756 const reference.
10757 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10758 * common/new-op.c: Use std::move.
10759 * common/common-exceptions.h (struct gdb_exception): Add move
10760 constructor.
10761 (struct gdb_exception_error, struct gdb_exception_quit, struct
10762 gdb_quit_bad_alloc): Change constructor to move constructor.
10763 (throw_exception): Change parameter to rvalue reference.
10764 * common/common-exceptions.c (throw_exception): Take rvalue
10765 reference.
10766 * cli/cli-interp.c (safe_execute_command): Use std::move.
10767 * breakpoint.c (insert_bp_location, location_to_sals): Use
10768 std::move.
10769
680d7fd5
TT
107702019-04-25 Tom Tromey <tromey@adacore.com>
10771
10772 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10773 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10774 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10775 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10776 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10777 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10778 guile/scm-value.c: Use unpack.
10779 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10780 gdbscm_gdb_exception.
10781 (gdbscm_throw_gdb_exception): Likewise.
10782 (struct gdbscm_gdb_exception): New.
10783 (unpack): New function.
10784 (gdbscm_wrap): Use unpack.
10785
c6fdd8b2
TT
107862019-04-25 Tom Tromey <tromey@adacore.com>
10787
10788 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10789 (gdb_rl_callback_handler): Use std::move.
10790 * common/common-exceptions.h (struct gdb_exception): Add move
10791 assignment operator.
10792 (throw_exception_sjlj): Change "exception" to const reference.
10793 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10794 (throw_exception_sjlj): Change "exception" to const reference.
10795
cc06b668
TT
107962019-04-25 Tom Tromey <tromey@adacore.com>
10797
10798 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10799 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10800 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10801 Update.
10802 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10803 Update.
10804 * mi/mi-interp.c (mi_interp::exec): Update.
10805 * linespec.c (parse_linespec): Update.
10806 * infcall.c (run_inferior_call): Update.
10807 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10808 * guile/scm-symbol.c (gdbscm_lookup_symbol)
10809 (gdbscm_lookup_global_symbol): Update.
10810 * guile/scm-param.c (gdbscm_parameter_value): Update.
10811 * guile/scm-frame.c (gdbscm_frame_read_register)
10812 (gdbscm_frame_read_var): Update.
10813 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10814 * exec.c (try_open_exec_file): Update.
10815 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10816 (gdb_rl_callback_handler): Update.
10817 * common/common-exceptions.h (exception_none): Don't declare.
10818 * common/common-exceptions.c (exception_none): Don't define.
10819 (struct catcher) <exception>: Update.
10820 * cli/cli-interp.c (safe_execute_command): Update.
10821 * breakpoint.c (insert_bp_location, location_to_sals): Update.
10822
cf532bd1
AT
108232019-04-25 Ali Tamur <tamur@google.com>
10824
10825 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10826 (read_attribute_value): Likewise.
10827 (dwarf2_read_addr_index): Update comment.
10828 (read_str_index): Add DW_FORM_strx.
10829 (dwarf2_string_attr): Likewise.
10830 (dwarf2_const_value_attr): Likewise.
10831 (dump_die_shallow): Likewise.
10832 (dwarf2_fetch_constant_bytes): Likewise.
10833 (skip_form_bytes): Likewise.
10834 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10835
82433e3e
SDJ
108362019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
10837
10838 PR corefiles/11608
10839 PR corefiles/18187
10840 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10841 OFFSET. Verify if current mapping contains an ELF header.
10842 (linux_find_memory_regions_full): Adjust call to
10843 dump_mapping_p.
10844
723adb65
SL
108452019-04-25 Sandra Loosemore <sandra@codesourcery.com>
10846 Kang Li <kanglictf@gmail.com>
10847
10848 PR gdb/21600
10849
10850 * dwarf2-frame.c (read_initial_length): Be consistent about using
10851 unsigned representation of length.
10852 (decode_frame_entry_1): Likewise. Check for wraparound of
10853 end pointer as well as buffer overflow.
10854
596179f7
SDJ
108552019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
10856
10857 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10858 "vq".
10859
a59240a4
TT
108602019-04-24 Tom Tromey <tromey@adacore.com>
10861
10862 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10863
f872fdbb
AB
108642019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10865
10866 * s12z-tdep.c (s12z_unwind_pc): Delete.
10867 (s12z_unwind_sp): Delete.
10868 (s12z_gdbarch_init): Don't register deleted functions with
10869 gdbarch.
10870
b614e6f3
AB
108712019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10872
10873 * rl78-tdep.c (rl78_unwind_sp): Delete.
10874 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10875
14faed38
AB
108762019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10877
10878 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10879 (xstormy16_unwind_pc): Delete.
10880 (xstormy16_dummy_id): Delete.
10881 (xstormy16_gdbarch_init): Don't register deleted functions with
10882 gdbarch.
10883
541aad8a
AB
108842019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10885
10886 * vax-tdep.c (vax_unwind_pc): Delete.
10887 (vax_gdbarch_init): Don't register deleted function with gdbarch.
10888
29222070
AB
108892019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10890
10891 * v850-tdep.c (v850_unwind_sp): Delete.
10892 (v850_unwind_pc): Delete.
10893 (v850_dummy_id): Delete.
10894 (v850_gdbarch_init): Don't register deleted functions with
10895 gdbarch.
10896
0f534d76
AB
108972019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10898
10899 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10900 (tilegx_unwind_pc): Delete.
10901 (tilegx_unwind_dummy_id): Delete.
10902 (tilegx_gdbarch_init): Don't register deleted functions with
10903 gdbarch.
10904
1ba7b7f9
AB
109052019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10906
10907 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10908 (tic6x_dummy_id): Delete.
10909 (tic6x_gdbarch_init): Don't register deleted functions with
10910 gdbarch.
10911
d31f262c
AB
109122019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10913
10914 * sparc-tdep.c (sparc_unwind_pc): Delete.
10915 (sparc32_gdbarch_init): Don't register deleted function with
10916 gdbarch.
10917
6d14d64d
AB
109182019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10919
10920 * sh-tdep.c (sh_unwind_sp): Delete.
10921 (sh_unwind_pc): Delete.
10922 (sh_dummy_id): Delete.
10923 (sh_gdbarch_init): Don't register deleted functions with
10924 gdbarch.
10925
a40dde9d
AB
109262019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10927
10928 * score-tdep.c (score_unwind_sp): Delete.
10929 (score_unwind_pc): Delete.
10930 (score_dummy_id): Delete.
10931 (score_gdbarch_init): Don't register deleted functions with
10932 gdbarch.
10933
47c47d69
AB
109342019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10935
10936 * rx-tdep.c (rx_unwind_pc): Delete.
10937 (rx_unwind_sp): Delete.
10938 (rx_dummy_id): Delete.
10939 (rx_gdbarch_init): Don't register deleted functions with
10940 gdbarch. Update comment.
10941
833a4480
AB
109422019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10943
10944 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10945 (rs6000_dummy_id): Delete.
10946 (rs6000_gdbarch_init): Don't register deleted functions with
10947 gdbarch.
10948
3f2cef49
AB
109492019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10950
10951 * or1k-tdep.c (or1k_dummy_id): Delete.
10952 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10953
96acf884
AB
109542019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10955
10956 * nios2-tdep.c (nios2_dummy_id): Delete.
10957 (nios2_unwind_sp): Delete.
10958 (nios2_gdbarch_init): Don't register deleted functions with
10959 gdbarch.
10960
ca0ab0aa
AB
109612019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10962
10963 * nds32-tdep.c (nds32_dummy_id): Delete.
10964 (nds32_unwind_pc): Delete.
10965 (nds32_unwind_sp): Delete.
10966 (nds32_gdbarch_init): Don't register deleted functions with
10967 gdbarch.
10968
c8259044
AB
109692019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10970
10971 * msp430-tdep.c (msp430_unwind_pc): Delete.
10972 (msp430_unwind_sp): Delete.
10973 (msp430_dummy_id): Delete.
10974 (msp430_gdbarch_init): Don't register deleted functions with
10975 gdbarch.
10976
27f113c8
AB
109772019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10978
10979 * moxie-tdep.c (moxie_unwind_sp): Delete.
10980 (moxie_unwind_pc): Delete.
10981 (moxie_dummy_id): Delete.
10982 (moxie_gdbarch_init): Don't register deleted functions with
10983 gdbarch.
10984
aee6c3cd
AB
109852019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10986
10987 * mn10300-tdep.c (mn10300_dummy_id): Delete.
10988 (mn10300_unwind_pc): Delete.
10989 (mn10300_unwind_sp): Delete.
10990 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10991 mn10300_unwind_sp.
10992 (mn10300_frame_unwind_init): Don't register deleted functions with
10993 gdbarch.
10994
8e2b5aea
AB
109952019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10996
10997 * mep-tdep.c (mep_unwind_pc): Delete.
10998 (mep_unwind_sp): Delete.
10999 (mep_dummy_id): Delete.
11000 (mep_gdbarch_init): Don't register deleted functions with
11001 gdbarch.
11002
43cf3ede
AB
110032019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11004
11005 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11006 (m68hc11_unwind_sp): Delete.
11007 (m68hc11_gdbarch_init): Don't register deleted functions with
11008 gdbarch.
11009
5e79b7bb
AB
110102019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11011
11012 * m32r-tdep.c (m32r_unwind_sp): Delete.
11013 (m32r_unwind_pc): Delete.
11014 (m32r_dummy_id): Delete.
11015 (m32r_gdbarch_init): Don't register deleted functions with
11016 gdbarch.
11017
89b268d8
AB
110182019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11019
11020 * m32c-tdep.c (m32c_unwind_pc): Delete.
11021 (m32c_unwind_sp): Delete.
11022 (m32c_dummy_id): Delete.
11023 (m32c_gdbarch_init): Don't register deleted functions with
11024 gdbarch.
11025
946c28d2
AB
110262019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11027
11028 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11029 (lm32_unwind_pc): Delete.
11030 (lm32_dummy_id): Delete.
11031 (lm32_gdbarch_init): Don't register deleted functions with
11032 gdbarch.
11033
bf12844a
AB
110342019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11035
11036 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11037 (iq2000_unwind_pc): Delete.
11038 (iq2000_dummy_id): Delete.
11039 (iq2000_gdbarch_init): Don't register deleted functions with
11040 gdbarch.
11041
ecbc06d2
AB
110422019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11043
11044 * nds32-tdep.c (nds32_type_align): Delete.
11045 (nds32_push_dummy_call): Use type_align instead.
11046
030197b4
AB
110472019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11048
11049 * arm-tdep.c (arm_type_align): Only handle vector override case.
11050 (arm_push_dummy_call): Use type_align.
11051 (arm_gdbarch_init): Register arm_type_align gdbarch function.
11052
b907456c
AB
110532019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11054
11055 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11056 case.
11057 (pass_on_stack): Use type_align.
11058 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11059 function.
11060
9e97ba43
TT
110612019-04-23 Tom Tromey <tromey@adacore.com>
11062
11063 * dwarf2read.c (line_header::file_name_at): Remove unused
11064 overload.
11065
6892f601
TV
110662019-04-23 Tom de Vries <tdevries@suse.de>
11067
11068 PR gdb/24438
11069 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11070 invocation.
11071
336d760d
AT
11072
110732019-03-27 Ali Tamur <tamur@google.com>
11074
11075 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11076 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11077 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11078 (dwarf_expr_context::get_addr_index): Likewise
11079 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11080 (symbol_needs_eval_context::get_addr_index): Likewise
11081 (disassemble_dwarf_expression): Add DW_OP_addrx
11082 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11083 (read_cutu_die_from_dwo): Update comment
11084 (skip_one_die): Add DW_FORM_addrx
11085 (read_attribute_value): Likewise
11086 (var_decode_location): Add DW_OP_addrx
11087 (dwarf2_const_value_attr): Add DW_FORM_addrx
11088 (dump_die_shallow): Likewise
11089 (dwarf2_fetch_constant_bytes): Likewise
11090 (decode_locdesc): Add DW_OP_addrx
11091 (skip_form_bytes): Add DW_FORM_addrx
11092
ad9d13f8
AT
110932019-04-22 Ali Tamur <tamur@google.com>
11094
11095 * MAINTAINERS (Write After Approval): Add self.
11096
d70cc3ba
SM
110972019-04-22 Simon Marchi <simon.marchi@efficios.com>
11098
11099 * solib-svr4.c (get_svr4_info): Add pspace parameter.
11100 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11101 (open_symbol_file_object): Likewise.
11102 (svr4_default_sos): Add info parameter.
11103 (svr4_read_so_list): Likewise.
11104 (svr4_current_sos_direct): Adjust functions calls to pass down
11105 info.
11106 (svr4_current_sos_1): Add info parameter.
11107 (svr4_current_sos): Call get_svr4_info, pass info down to
11108 svr4_current_sos_1.
11109 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11110 get_svr4_info.
11111 (svr4_in_dynsym_resolve_code): Pass current_program_space to
11112 get_svr4_info.
11113 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11114 to get_svr4_info.
11115 (probes_table_remove_objfile_probes): Likewise.
11116 (register_solib_event_probe): Add info parameter.
11117 (solist_update_incremental): Pass info parameter down to
11118 svr4_read_so_list.
11119 (disable_probes_interface): Add info parameter.
11120 (svr4_handle_solib_event): Pass current_program_space to
11121 get_svr4_info. Adjust disable_probes_interface cleanup.
11122 (svr4_create_probe_breakpoints): Add info parameter, pass it
11123 down to register_solib_event_probe.
11124 (svr4_create_solib_event_breakpoints): Add info parameter,
11125 pass it down to svr4_create_probe_breakpoints.
11126 (enable_break): Pass info down to
11127 svr4_create_solib_event_breakpoints.
11128 (svr4_solib_create_inferior_hook): Pass current_program_space to
11129 get_svr4_info.
11130 (svr4_clear_solib): Likewise.
11131
7905fc35
PA
111322019-04-22 Pedro Alves <palves@redhat.com>
11133
11134 * solib-svr4.c (svr4_free_objfile_observer): New.
11135 (probe_and_action::objfile): New field.
11136 (probes_table_htab_remove_objfile_probes)
11137 (probes_table_remove_objfile_probes): New functions.
11138 (register_solib_event_probe): Add 'objfile' parameter. Store it
11139 in the new probe_and_action. Don't store the probe in 'lookup'.
11140 (svr4_create_probe_breakpoints): Pass objfile to
11141 register_solib_event_probe.
11142 (_initialize_svr4_solib): Register a free_objfile observer.
11143
fb881986
TT
111442019-04-19 Tom Tromey <tom@tromey.com>
11145
11146 * common/queue.h: Remove.
11147
8732db6c
TT
111482019-04-19 Tom Tromey <tom@tromey.com>
11149
11150 * event-loop.c: Don't include "common/queue.h".
11151
97dfbadd
TT
111522019-04-19 Tom Tromey <tom@tromey.com>
11153
11154 * remote.c (remote_target): Use delete.
11155 * remote-notif.h: Include <list>, not "common/queue.h".
11156 (notif_client_p): Remove typedef.
11157 (remote_notif_state): Add constructor, destructor, initializer.
11158 <notif_queue>: Now a std::list.
11159 (remote_notif_state_xfree): Don't declare.
11160 * remote-notif.c (remote_notif_process, handle_notification)
11161 (remote_notif_state_allocate): Update.
11162 (~remote_notif_state): Rename from remote_notif_state_xfree.
11163
cf250e36
TT
111642019-04-19 Tom Tromey <tom@tromey.com>
11165
11166 * symfile.c (reread_symbols): Update.
11167 * objfiles.c (objfile_register_static_link)
11168 (objfile_lookup_static_link): Update
11169 (~objfile) Don't delete static_links.
11170 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11171
61f4b350
TT
111722019-04-19 Tom Tromey <tom@tromey.com>
11173
11174 * type-stack.h (struct type_stack) <insert>: Constify string.
11175 * type-stack.c (type_stack::insert): Constify string.
11176 * gdbtypes.h (lookup_template_type): Update.
11177 (address_space_name_to_int): Update.
11178 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11179 const.
11180 (lookup_template_type): Make name const.
11181 * c-exp.y: Update rules.
11182 (lex_one_token, classify_name, classify_inner_name)
11183 (c_print_token): Update.
11184 * p-exp.y: Update rules.
11185 (yylex): Update.
11186 * f-exp.y: Update rules.
11187 (yylex): Update.
11188 * d-exp.y: Update rules.
11189 (lex_one_token, classify_name, classify_inner_name): Update.
11190 * parse.c (write_dollar_variable, copy_name): Return std::string.
11191 * parser-defs.h (copy_name): Change return type.
11192 * m2-exp.y: Update rules.
11193 (yylex): Update.
11194 * go-exp.y (lex_one_token): Update.
11195 Update rules.
11196 (classify_unsafe_function, classify_packaged_name)
11197 (classify_name, yylex): Update.
11198
189b8c2e
ST
111992019-04-19 Sergei Trofimovich <siarheit@google.com>
11200
11201 * configure.ac: add --enable-source-highlight switch.
11202 * configure: Regenerate.
11203 * top.c (print_gdb_version): plumb --enable-source-highlight
11204 status to "show configuration".
11205
8ecb59f8
TT
112062019-04-19 Tom Tromey <tromey@adacore.com>
11207
11208 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11209 Check ADA_TYPE_P.
11210 (empty_record, ada_template_to_fixed_record_type_1)
11211 (template_to_static_fixed_type)
11212 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11213 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11214 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11215 macros.
11216
62160ec9
TT
112172019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11218
11219 PR symtab/24423:
11220 * source.c (print_source_lines_base): Advance "iter" when a
11221 control character is seen.
11222
f2ae8bc8
PW
112232019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11224
11225 * inferior.h (struct infcall_suspend_state_deleter):
11226 Catch exception in destructor to avoid crash.
11227
d563b953
PW
112282019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11229
11230 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11231 close to the add_com "shell".
11232
dc34c897
TT
112332019-04-18 Tom Tromey <tromey@adacore.com>
11234
11235 * process-stratum-target.h (class process_stratum_target)
11236 <stratum>: Add "final".
11237
a12e5744
TT
112382019-04-17 Tom Tromey <tromey@adacore.com>
11239
11240 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11241 against nullptr before use.
11242
a7e559cc
AH
112432019-04-17 Alan Hayward <alan.hayward@arm.com>
11244
11245 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11246
c01660c6
AB
112472019-04-17 Jim Wilson <jimw@sifive.com>
11248 Andrew Burgess <andrew.burgess@embecosm.com>
11249
11250 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11251 code read might fail, assume 4-byte breakpoint in that case.
11252
4aa866af
LS
112532019-04-15 Leszek Swirski <leszeks@google.com>
11254
11255 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11256 rather than a hand-rolled POD check when checking for forced MEMORY
11257 classification.
11258
48574d91
AH
112592019-04-15 Alan Hayward <alan.hayward@arm.com>
11260
11261 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11262 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11263 function.
11264 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11265 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11266 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11267 declaration.
11268
4da037ef
AH
112692019-04-15 Alan Hayward <alan.hayward@arm.com>
11270
11271 * aarch64-linux-nat.c
11272 (aarch64_linux_nat_target::thread_architecture): Add override.
11273 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11274 each VQ.
11275
ccb8d7e8
AH
112762019-04-15 Alan Hayward <alan.hayward@arm.com>
11277
11278 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11279
35add35e
AB
112802019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11281
11282 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11283 target types of size 96-bits, add some additional comments, and
11284 check that the builtin type we found was the correct size.
11285
51196bbc
EZ
112862019-04-12 Eli Zaretskii <eliz@gnu.org>
11287
11288 * utils.c (prompt_for_continue): Don't restore the styling at the
11289 end, as applied_style has the wrong value. This fixes styling in
11290 long lists of file names that are interrupted by the "Continue?"
11291 prompt.
11292
62253a61
AB
112932019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11294
11295 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11296 * c-lang.c (c_language_defn): Likewise.
11297 (cplus_language_defn): Likewise.
11298 (asm_language_defn): Likewise.
11299 (minimal_language_defn): Likewise.
11300 * d-lang.c (d_language_defn): Likewise.
11301 * f-lang.c (f_language_defn): Likewise.
11302 * go-lang.c (go_language_defn): Likewise.
11303 * language.c (unknown_language_defn): Likewise.
11304 (auto_language_defn): Likewise.
11305 * language.h (struct language_defn): Remove la_magic field.
11306 (LANG_MAGIC): Delete.
11307 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11308 * objc-lang.c (objc_language_defn): Likewise.
11309 * opencl-lang.c (opencl_language_defn): Likewise.
11310 * p-lang.c (pascal_language_defn): Likewise.
11311 * rust-lang.c (rust_language_defn): Likewise.
11312
a9158a86
AB
113132019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11314
11315 * riscv-tdep.c (riscv_type_align): New function.
11316 (riscv_type_alignment): Delete.
11317 (riscv_arg_location): Use 'type_align'.
11318 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11319
41077b66
AB
113202019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11321
11322 * gdbtypes.c (type_align): A struct with no non-static fields also
11323 has alignment of 1.
11324
9f0272f8
AB
113252019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11326
11327 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11328 component to 0.
11329 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11330 member.
11331 (riscv_struct_info::analyse): New implementation using new
11332 analyse_inner member function.
11333 (riscv_struct_info::field_offset): New member function.
11334 (riscv_struct_info::m_offsets): New member variable.
11335 (riscv_struct_info::analyse_inner): New private member function,
11336 takes the old implementation of riscv_struct_info::analyse but
11337 extended to track field offsets.
11338 (riscv_call_arg_struct): Update the struct folding special cases
11339 to handle cases where empty C++ structs, which are non-zero
11340 length, are found.
11341 (riscv_arg_location): Initialise the length of each location, a
11342 non-zero length now indicates the location is in use.
11343 (riscv_push_dummy_call): Allow for the first location having a
11344 non-zero offset when setting up arguments.
11345 (riscv_return_value): Likewise, but for return values.
11346
02cf60c7
TT
113472019-04-11 Tom Tromey <tromey@adacore.com>
11348
11349 * utils.c (internal_vproblem): Make "msg" const.
11350
68811f8f
AH
113512019-04-11 Alan Hayward <alan.hayward@arm.com>
11352
11353 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11354 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11355 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11356 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11357
3f52fdbc
KB
113582019-04-10 Kevin Buettner <kevinb@redhat.com>
11359
11360 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11361 function.
11362 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11363 of amd64_collect_native_gregset.
11364 (amd64_linux_nat_target::store_registers): Likewise.
11365
e9ad22ee
TT
113662019-04-10 Tom Tromey <tom@tromey.com>
11367
11368 * symtab.c (lookup_global_symbol_from_objfile)
11369 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11370 * objfiles.h (class separate_debug_iterator): New.
11371 (class separate_debug_range): New.
11372 (struct objfile) <separate_debug_objfiles>: New method.
11373 (objfile_separate_debug_iterate): Don't declare.
11374 * objfiles.c (separate_debug_iterator::operator++): Rename from
11375 objfile_separate_debug_iterate.
11376 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11377 iterator.
11378 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11379 iterator.
11380
ee371134
TT
113812019-04-10 Tom Tromey <tom@tromey.com>
11382
11383 * symfile.c (reread_symbols): Remove old comment.
11384 * objfiles.c (free_all_objfiles): Fix a typo.
11385
bf227d61
TT
113862019-04-10 Tom Tromey <tom@tromey.com>
11387
11388 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11389 * minsyms.c (lookup_minimal_symbol): Use foreach.
11390 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11391 (lookup_minimal_symbol_solib_trampoline): Likewise.
11392 * symfile.c (reread_symbols): Use foreach.
11393
8dc433a0
TT
113942019-04-09 Ivan Begert <ivanbegert@gmail.com>
11395 Tom Tromey <tromey@adacore.com>
11396
11397 PR rust/24414:
11398 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11399 (rust_lex_int_test): Change "value" to be LONGEST.
11400 (rust_lex_tests): Add test for long integer literal.
11401
9ab8741a
TT
114022019-04-09 Tom Tromey <tromey@adacore.com>
11403
11404 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11405 to bool.
11406 (extended_remote_target::attach): Update.
11407 (remote_target::remote_notice_new_inferior): Update.
11408 (remote_target::add_current_inferior_and_thread): Update.
11409 * inferior.c (exit_inferior_1): Use "false".
11410 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11411
e242fd12
SM
114122019-04-09 Simon Marchi <simon.marchi@efficios.com>
11413
9ca1957f 11414 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
11415 the "start" command.
11416
2b0c8b01
KB
114172019-04-08 Kevin Buettner <kevinb@redhat.com>
11418
11419 * python/py-inferior.c (infpy_thread_from_thread_handle):
11420 Adjust comments to reflect renaming of thread_from_thread_handle
11421 to thread_from_handle. Adjust keywords. Fix type error message.
11422 (inferior_object_methods): Add thread_from_handle. Retain
11423 thread_from_thread_handle, but mark it as deprecated.
11424
50a82723
KB
114252019-04-08 Kevin Buettner <kevinb@redhat.com>
11426
11427 * gdbthread.h (find_thread_by_handle): Revise declaration.
11428 * thread.c (find_thread_by_handle): Likewise. Adjust
11429 implementation too.
11430 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11431 support for buffer objects as handles.
11432
cf63b016
KB
114332019-04-08 Kevin Buettner <kevinb@redhat.com>
11434
11435 * python/py-infthread.c (thpy_thread_handle): New function.
11436 (thread_object_methods): Register thpy_thread_handle.
11437
3d6c6204
KB
114382019-04-08 Kevin Buettner <kevinb@redhat.com>
11439
11440 * gdbthread.h (thread_to_thread_handle): Declare.
11441 * thread.c (gdbtypes.h): Include.
11442 (thread_to_thread_handle): New function.
11443
11444 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11445 (target_thread_info_to_thread_handle): Declare.
11446 * target.c (target_thread_info_to_thread_handle): New function.
11447 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11448 * target-delegates.c: Regenerate.
11449
11450 * linux-thread-db.c (class thread_db_target): Add method
11451 thread_info_to_thread_handle.
11452 (thread_db_target::thread_info_to_thread_handle): Define.
11453 * remote.c (class remote_target): Add new method
11454 thread_info_to_thread_handle.
11455 (remote_target::thread_info_to_thread_handle): Define.
11456
56be6ea8
PA
114572019-04-08 Pedro Alves <palves@redhat.com>
11458
11459 * common/common-exceptions.c (throw_exception): Don't create
11460 named object to throw; throw directly.
11461 (throw_it): Likewise. Don't initialize gdb_exception::message
11462 here, with new; pass FMT and AP to the ctor instead.
11463 * common/common-exceptions.h: Include <string>.
11464 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11465 const char *, va_list)): New ctor. Use std::make_shared.
11466 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11467 errors)): Delete.
11468 (gdb_exception_error::gdb_exception_error(enum errors, const char
11469 *, va_list)): New.
11470 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11471 Add assertion.
11472 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11473 errors)): Delete.
11474 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11475 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11476 Add assertion.
11477
eedc3f4f
TT
114782019-04-08 Tom Tromey <tom@tromey.com>
11479
11480 * valops.c (value_rtti_indirect_type): Replace throw_exception
11481 with throw.
11482 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11483 with throw.
11484 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11485 throw.
11486 * target.c (target_translate_tls_address): Replace throw_exception
11487 with throw.
11488 * stack.c (frame_apply_command_count): Replace throw_exception
11489 with throw.
11490 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11491 throw.
11492 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11493 with throw.
11494 * rs6000-tdep.c (rs6000_frame_cache)
11495 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11496 * remote.c: Replace throw_exception with throw.
11497 * record-full.c (record_full_message, record_full_wait_1)
11498 (record_full_restore): Replace throw_exception with throw.
11499 * record-btrace.c:
11500 (get_thread_current_frame_id, record_btrace_start_replaying)
11501 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11502 (cmd_record_btrace_start): Replace throw_exception with throw.
11503 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11504 throw.
11505 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11506 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11507 * linespec.c:
11508 (find_linespec_symbols): Replace throw_exception with throw.
11509 * infrun.c (displaced_step_prepare, resume): Replace
11510 throw_exception with throw.
11511 * infcmd.c (post_create_inferior): Replace throw_exception with
11512 throw.
11513 * inf-loop.c (inferior_event_handler): Replace throw_exception
11514 with throw.
11515 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11516 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11517 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11518 (get_prev_frame_always, get_frame_pc_if_available)
11519 (get_frame_address_in_block_if_available, get_frame_language):
11520 Replace throw_exception with throw.
11521 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11522 throw_exception with throw.
11523 * eval.c (fetch_subexp_value, evaluate_var_value)
11524 (evaluate_funcall, evaluate_subexp_standard): Replace
11525 throw_exception with throw.
11526 * dwarf2loc.c (call_site_find_chain)
11527 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11528 Replace throw_exception with throw.
11529 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11530 with throw.
11531 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11532 throw.
11533 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11534 * completer.c (complete_line_internal): Replace throw_exception
11535 with throw.
11536 * compile/compile-object-run.c (compile_object_run): Replace
11537 throw_exception with throw.
11538 * cli/cli-script.c (process_next_line): Replace throw_exception
11539 with throw.
11540 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11541 (btrace_enable, btrace_maint_update_pt_packets): Replace
11542 throw_exception with throw.
11543 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11544 throw_exception with throw.
11545 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11546 throw_exception with throw.
11547 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11548 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11549 * aarch64-tdep.c (aarch64_make_prologue_cache)
11550 (aarch64_make_stub_cache): Replace throw_exception with throw.
11551
26003a20
TT
115522019-04-08 Tom Tromey <tom@tromey.com>
11553
11554 * common/common-exceptions.c (throw_exception): Rename from
11555 throw_exception_cxx. Remove old copy. Make argument const.
11556 (throw_it): Create and throw exception objects directly.
11557 * common/common-exceptions.h (throw_exception): Make argument
11558 const.
11559 (struct gdb_exception_error): Add constructor.
11560 (struct gdb_exception_quit): Add constructor.
11561
d272eb37
TT
115622019-04-08 Tom Tromey <tom@tromey.com>
11563
11564 * common/common-exceptions.h (exception_rethrow): Don't declare.
11565 (TRY_SJLJ): Update comment.
11566 (TRY, CATCH, END_CATCH): Remove.
11567 * common/common-exceptions.c (exception_rethrow): Remove.
11568
230d2906
TT
115692019-04-08 Tom Tromey <tom@tromey.com>
11570
11571 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11572 Remove.
11573 (gdb_exception_error): Rename from
11574 gdb_exception_RETURN_MASK_ERROR.
11575 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11576 (gdb_quit_bad_alloc): Update.
11577 * aarch64-tdep.c: Update.
11578 * ada-lang.c: Update.
11579 * ada-typeprint.c: Update.
11580 * ada-valprint.c: Update.
11581 * amd64-tdep.c: Update.
11582 * arch-utils.c: Update.
11583 * break-catch-throw.c: Update.
11584 * breakpoint.c: Update.
11585 * btrace.c: Update.
11586 * c-varobj.c: Update.
11587 * cli/cli-cmds.c: Update.
11588 * cli/cli-interp.c: Update.
11589 * cli/cli-script.c: Update.
11590 * common/common-exceptions.c: Update.
11591 * common/new-op.c: Update.
11592 * common/selftest.c: Update.
11593 * compile/compile-c-symbols.c: Update.
11594 * compile/compile-cplus-symbols.c: Update.
11595 * compile/compile-object-load.c: Update.
11596 * compile/compile-object-run.c: Update.
11597 * completer.c: Update.
11598 * corelow.c: Update.
11599 * cp-abi.c: Update.
11600 * cp-support.c: Update.
11601 * cp-valprint.c: Update.
11602 * darwin-nat.c: Update.
11603 * disasm-selftests.c: Update.
11604 * dtrace-probe.c: Update.
11605 * dwarf-index-cache.c: Update.
11606 * dwarf-index-write.c: Update.
11607 * dwarf2-frame-tailcall.c: Update.
11608 * dwarf2-frame.c: Update.
11609 * dwarf2loc.c: Update.
11610 * dwarf2read.c: Update.
11611 * eval.c: Update.
11612 * event-loop.c: Update.
11613 * event-top.c: Update.
11614 * exec.c: Update.
11615 * f-valprint.c: Update.
11616 * fbsd-tdep.c: Update.
11617 * frame-unwind.c: Update.
11618 * frame.c: Update.
11619 * gdbtypes.c: Update.
11620 * gnu-v3-abi.c: Update.
11621 * guile/guile-internal.h: Update.
11622 * guile/scm-block.c: Update.
11623 * guile/scm-breakpoint.c: Update.
11624 * guile/scm-cmd.c: Update.
11625 * guile/scm-disasm.c: Update.
11626 * guile/scm-frame.c: Update.
11627 * guile/scm-lazy-string.c: Update.
11628 * guile/scm-math.c: Update.
11629 * guile/scm-param.c: Update.
11630 * guile/scm-ports.c: Update.
11631 * guile/scm-pretty-print.c: Update.
11632 * guile/scm-symbol.c: Update.
11633 * guile/scm-symtab.c: Update.
11634 * guile/scm-type.c: Update.
11635 * guile/scm-value.c: Update.
11636 * i386-linux-tdep.c: Update.
11637 * i386-tdep.c: Update.
11638 * inf-loop.c: Update.
11639 * infcall.c: Update.
11640 * infcmd.c: Update.
11641 * infrun.c: Update.
11642 * jit.c: Update.
11643 * language.c: Update.
11644 * linespec.c: Update.
11645 * linux-fork.c: Update.
11646 * linux-nat.c: Update.
11647 * linux-tdep.c: Update.
11648 * linux-thread-db.c: Update.
11649 * main.c: Update.
11650 * mi/mi-cmd-break.c: Update.
11651 * mi/mi-cmd-stack.c: Update.
11652 * mi/mi-interp.c: Update.
11653 * mi/mi-main.c: Update.
11654 * objc-lang.c: Update.
11655 * p-valprint.c: Update.
11656 * parse.c: Update.
11657 * ppc-linux-tdep.c: Update.
11658 * printcmd.c: Update.
11659 * python/py-arch.c: Update.
11660 * python/py-breakpoint.c: Update.
11661 * python/py-cmd.c: Update.
11662 * python/py-finishbreakpoint.c: Update.
11663 * python/py-frame.c: Update.
11664 * python/py-framefilter.c: Update.
11665 * python/py-gdb-readline.c: Update.
11666 * python/py-inferior.c: Update.
11667 * python/py-infthread.c: Update.
11668 * python/py-lazy-string.c: Update.
11669 * python/py-linetable.c: Update.
11670 * python/py-objfile.c: Update.
11671 * python/py-param.c: Update.
11672 * python/py-prettyprint.c: Update.
11673 * python/py-progspace.c: Update.
11674 * python/py-record-btrace.c: Update.
11675 * python/py-record.c: Update.
11676 * python/py-symbol.c: Update.
11677 * python/py-type.c: Update.
11678 * python/py-unwind.c: Update.
11679 * python/py-utils.c: Update.
11680 * python/py-value.c: Update.
11681 * python/python.c: Update.
11682 * record-btrace.c: Update.
11683 * record-full.c: Update.
11684 * remote-fileio.c: Update.
11685 * remote.c: Update.
11686 * riscv-tdep.c: Update.
11687 * rs6000-aix-tdep.c: Update.
11688 * rs6000-tdep.c: Update.
11689 * rust-exp.y: Update.
11690 * rust-lang.c: Update.
11691 * s390-tdep.c: Update.
11692 * selftest-arch.c: Update.
11693 * solib-dsbt.c: Update.
11694 * solib-frv.c: Update.
11695 * solib-spu.c: Update.
11696 * solib-svr4.c: Update.
11697 * solib.c: Update.
11698 * sparc64-linux-tdep.c: Update.
11699 * stack.c: Update.
11700 * symfile-mem.c: Update.
11701 * symmisc.c: Update.
11702 * target.c: Update.
11703 * thread.c: Update.
11704 * top.c: Update.
11705 * tracefile-tfile.c: Update.
11706 * tui/tui.c: Update.
11707 * typeprint.c: Update.
11708 * unittests/cli-utils-selftests.c: Update.
11709 * unittests/parse-connection-spec-selftests.c: Update.
11710 * valops.c: Update.
11711 * valprint.c: Update.
11712 * value.c: Update.
11713 * varobj.c: Update.
11714 * windows-nat.c: Update.
11715 * x86-linux-nat.c: Update.
11716 * xml-support.c: Update.
11717
a70b8144
TT
117182019-04-08 Tom Tromey <tom@tromey.com>
11719
11720 * xml-support.c: Use C++ exception handling.
11721 * x86-linux-nat.c: Use C++ exception handling.
11722 * windows-nat.c: Use C++ exception handling.
11723 * varobj.c: Use C++ exception handling.
11724 * value.c: Use C++ exception handling.
11725 * valprint.c: Use C++ exception handling.
11726 * valops.c: Use C++ exception handling.
11727 * unittests/parse-connection-spec-selftests.c: Use C++ exception
11728 handling.
11729 * unittests/cli-utils-selftests.c: Use C++ exception handling.
11730 * typeprint.c: Use C++ exception handling.
11731 * tui/tui.c: Use C++ exception handling.
11732 * tracefile-tfile.c: Use C++ exception handling.
11733 * top.c: Use C++ exception handling.
11734 * thread.c: Use C++ exception handling.
11735 * target.c: Use C++ exception handling.
11736 * symmisc.c: Use C++ exception handling.
11737 * symfile-mem.c: Use C++ exception handling.
11738 * stack.c: Use C++ exception handling.
11739 * sparc64-linux-tdep.c: Use C++ exception handling.
11740 * solib.c: Use C++ exception handling.
11741 * solib-svr4.c: Use C++ exception handling.
11742 * solib-spu.c: Use C++ exception handling.
11743 * solib-frv.c: Use C++ exception handling.
11744 * solib-dsbt.c: Use C++ exception handling.
11745 * selftest-arch.c: Use C++ exception handling.
11746 * s390-tdep.c: Use C++ exception handling.
11747 * rust-lang.c: Use C++ exception handling.
11748 * rust-exp.y: Use C++ exception handling.
11749 * rs6000-tdep.c: Use C++ exception handling.
11750 * rs6000-aix-tdep.c: Use C++ exception handling.
11751 * riscv-tdep.c: Use C++ exception handling.
11752 * remote.c: Use C++ exception handling.
11753 * remote-fileio.c: Use C++ exception handling.
11754 * record-full.c: Use C++ exception handling.
11755 * record-btrace.c: Use C++ exception handling.
11756 * python/python.c: Use C++ exception handling.
11757 * python/py-value.c: Use C++ exception handling.
11758 * python/py-utils.c: Use C++ exception handling.
11759 * python/py-unwind.c: Use C++ exception handling.
11760 * python/py-type.c: Use C++ exception handling.
11761 * python/py-symbol.c: Use C++ exception handling.
11762 * python/py-record.c: Use C++ exception handling.
11763 * python/py-record-btrace.c: Use C++ exception handling.
11764 * python/py-progspace.c: Use C++ exception handling.
11765 * python/py-prettyprint.c: Use C++ exception handling.
11766 * python/py-param.c: Use C++ exception handling.
11767 * python/py-objfile.c: Use C++ exception handling.
11768 * python/py-linetable.c: Use C++ exception handling.
11769 * python/py-lazy-string.c: Use C++ exception handling.
11770 * python/py-infthread.c: Use C++ exception handling.
11771 * python/py-inferior.c: Use C++ exception handling.
11772 * python/py-gdb-readline.c: Use C++ exception handling.
11773 * python/py-framefilter.c: Use C++ exception handling.
11774 * python/py-frame.c: Use C++ exception handling.
11775 * python/py-finishbreakpoint.c: Use C++ exception handling.
11776 * python/py-cmd.c: Use C++ exception handling.
11777 * python/py-breakpoint.c: Use C++ exception handling.
11778 * python/py-arch.c: Use C++ exception handling.
11779 * printcmd.c: Use C++ exception handling.
11780 * ppc-linux-tdep.c: Use C++ exception handling.
11781 * parse.c: Use C++ exception handling.
11782 * p-valprint.c: Use C++ exception handling.
11783 * objc-lang.c: Use C++ exception handling.
11784 * mi/mi-main.c: Use C++ exception handling.
11785 * mi/mi-interp.c: Use C++ exception handling.
11786 * mi/mi-cmd-stack.c: Use C++ exception handling.
11787 * mi/mi-cmd-break.c: Use C++ exception handling.
11788 * main.c: Use C++ exception handling.
11789 * linux-thread-db.c: Use C++ exception handling.
11790 * linux-tdep.c: Use C++ exception handling.
11791 * linux-nat.c: Use C++ exception handling.
11792 * linux-fork.c: Use C++ exception handling.
11793 * linespec.c: Use C++ exception handling.
11794 * language.c: Use C++ exception handling.
11795 * jit.c: Use C++ exception handling.
11796 * infrun.c: Use C++ exception handling.
11797 * infcmd.c: Use C++ exception handling.
11798 * infcall.c: Use C++ exception handling.
11799 * inf-loop.c: Use C++ exception handling.
11800 * i386-tdep.c: Use C++ exception handling.
11801 * i386-linux-tdep.c: Use C++ exception handling.
11802 * guile/scm-value.c: Use C++ exception handling.
11803 * guile/scm-type.c: Use C++ exception handling.
11804 * guile/scm-symtab.c: Use C++ exception handling.
11805 * guile/scm-symbol.c: Use C++ exception handling.
11806 * guile/scm-pretty-print.c: Use C++ exception handling.
11807 * guile/scm-ports.c: Use C++ exception handling.
11808 * guile/scm-param.c: Use C++ exception handling.
11809 * guile/scm-math.c: Use C++ exception handling.
11810 * guile/scm-lazy-string.c: Use C++ exception handling.
11811 * guile/scm-frame.c: Use C++ exception handling.
11812 * guile/scm-disasm.c: Use C++ exception handling.
11813 * guile/scm-cmd.c: Use C++ exception handling.
11814 * guile/scm-breakpoint.c: Use C++ exception handling.
11815 * guile/scm-block.c: Use C++ exception handling.
11816 * guile/guile-internal.h: Use C++ exception handling.
11817 * gnu-v3-abi.c: Use C++ exception handling.
11818 * gdbtypes.c: Use C++ exception handling.
11819 * frame.c: Use C++ exception handling.
11820 * frame-unwind.c: Use C++ exception handling.
11821 * fbsd-tdep.c: Use C++ exception handling.
11822 * f-valprint.c: Use C++ exception handling.
11823 * exec.c: Use C++ exception handling.
11824 * event-top.c: Use C++ exception handling.
11825 * event-loop.c: Use C++ exception handling.
11826 * eval.c: Use C++ exception handling.
11827 * dwarf2read.c: Use C++ exception handling.
11828 * dwarf2loc.c: Use C++ exception handling.
11829 * dwarf2-frame.c: Use C++ exception handling.
11830 * dwarf2-frame-tailcall.c: Use C++ exception handling.
11831 * dwarf-index-write.c: Use C++ exception handling.
11832 * dwarf-index-cache.c: Use C++ exception handling.
11833 * dtrace-probe.c: Use C++ exception handling.
11834 * disasm-selftests.c: Use C++ exception handling.
11835 * darwin-nat.c: Use C++ exception handling.
11836 * cp-valprint.c: Use C++ exception handling.
11837 * cp-support.c: Use C++ exception handling.
11838 * cp-abi.c: Use C++ exception handling.
11839 * corelow.c: Use C++ exception handling.
11840 * completer.c: Use C++ exception handling.
11841 * compile/compile-object-run.c: Use C++ exception handling.
11842 * compile/compile-object-load.c: Use C++ exception handling.
11843 * compile/compile-cplus-symbols.c: Use C++ exception handling.
11844 * compile/compile-c-symbols.c: Use C++ exception handling.
11845 * common/selftest.c: Use C++ exception handling.
11846 * common/new-op.c: Use C++ exception handling.
11847 * cli/cli-script.c: Use C++ exception handling.
11848 * cli/cli-interp.c: Use C++ exception handling.
11849 * cli/cli-cmds.c: Use C++ exception handling.
11850 * c-varobj.c: Use C++ exception handling.
11851 * btrace.c: Use C++ exception handling.
11852 * breakpoint.c: Use C++ exception handling.
11853 * break-catch-throw.c: Use C++ exception handling.
11854 * arch-utils.c: Use C++ exception handling.
11855 * amd64-tdep.c: Use C++ exception handling.
11856 * ada-valprint.c: Use C++ exception handling.
11857 * ada-typeprint.c: Use C++ exception handling.
11858 * ada-lang.c: Use C++ exception handling.
11859 * aarch64-tdep.c: Use C++ exception handling.
11860
3d6e9d23
TT
118612019-04-08 Tom Tromey <tom@tromey.com>
11862
11863 * xml-support.c (gdb_xml_parser::parse): Update.
11864 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11865 * value.c (show_convenience): Update.
11866 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11867 (test_parse_flags_qcs): Update.
11868 * thread.c (thr_try_catch_cmd): Update.
11869 * target.c (target_translate_tls_address): Update.
11870 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11871 (info_frame_command_core, frame_apply_command_count): Update.
11872 * rust-exp.y (rust_lex_exception_test): Update.
11873 * riscv-tdep.c (riscv_print_one_register_info): Update.
11874 * remote.c (remote_target::enable_btrace): Update.
11875 * record-btrace.c (record_btrace_enable_warn): Update.
11876 * python/py-utils.c (gdbpy_convert_exception): Update.
11877 * printcmd.c (do_one_display, print_variable_and_value): Update.
11878 * mi/mi-main.c (mi_print_exception): Update.
11879 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11880 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11881 * linux-nat.c (linux_nat_target::attach): Update.
11882 * linux-fork.c (class scoped_switch_fork_info): Update.
11883 * infrun.c (displaced_step_prepare): Update.
11884 * infcall.c (call_function_by_hand_dummy): Update.
11885 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11886 * gnu-v3-abi.c (print_one_vtable): Update.
11887 * frame.c (get_prev_frame_always): Update.
11888 * f-valprint.c (info_common_command_for_block): Update.
11889 * exec.c (try_open_exec_file): Update.
11890 * exceptions.c (print_exception, exception_print)
11891 (exception_fprintf, exception_print_same): Update.
11892 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11893 * dwarf-index-cache.c (index_cache::store)
11894 (index_cache::lookup_gdb_index): Update.
11895 * darwin-nat.c (maybe_cache_shell): Update.
11896 * cp-valprint.c (cp_print_value_fields): Update.
11897 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11898 (gcc_cplus_symbol_address): Update.
11899 * compile/compile-c-symbols.c (gcc_convert_symbol)
11900 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11901 * common/selftest.c: Update.
11902 * common/common-exceptions.h (struct gdb_exception) <message>: Now
11903 a std::string.
11904 (exception_try_scope_entry, exception_try_scope_exit): Don't
11905 declare.
11906 (struct exception_try_scope): Remove.
11907 (TRY): Don't use exception_try_scope.
11908 (struct gdb_exception): Add constructor, operator=.
11909 <what>: New method.
11910 (struct gdb_exception_RETURN_MASK_ALL)
11911 (struct gdb_exception_RETURN_MASK_ERROR)
11912 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11913 (struct gdb_quit_bad_alloc): Update.
11914 * common/common-exceptions.c (exception_none): Change
11915 initializer.
11916 (struct catcher) <state, exception>: Initialize inline.
11917 <prev>: Remove member.
11918 (current_catcher): Remove.
11919 (catchers): New global.
11920 (exceptions_state_mc_init): Simplify.
11921 (catcher_pop): Remove.
11922 (exceptions_state_mc, exceptions_state_mc_catch): Update.
11923 (try_scope_depth, exception_try_scope_entry)
11924 (exception_try_scope_exit): Remove.
11925 (throw_exception_sjlj): Update.
11926 (exception_messages, exception_messages_size): Remove.
11927 (throw_it): Simplify.
11928 (gdb_exception_sliced_copy): Remove.
11929 (throw_exception_cxx): Update.
11930 * cli/cli-script.c (script_from_file): Update.
11931 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11932 Update.
11933 * ada-valprint.c (ada_val_print): Update.
11934 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11935 (create_excep_cond_exprs): Update.
11936
c5c10118
TT
119372019-04-08 Tom Tromey <tom@tromey.com>
11938
11939 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11940 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11941 (TRY, CATCH, END_CATCH): Remove some definitions.
11942 * common/common-exceptions.c: Don't use GDB_XCPT.
11943 (catcher_list_size): Remove.
11944 (throw_exception, throw_it): Simplify.
11945
4de283e4
TT
119462019-04-05 Tom Tromey <tom@tromey.com>
11947
11948 Revert the header-sorting patch.
11949 * ft32-tdep.c: Revert.
11950 * frv-tdep.c: Revert.
11951 * frv-linux-tdep.c: Revert.
11952 * frame.c: Revert.
11953 * frame-unwind.c: Revert.
11954 * frame-base.c: Revert.
11955 * fork-child.c: Revert.
11956 * findvar.c: Revert.
11957 * findcmd.c: Revert.
11958 * filesystem.c: Revert.
11959 * filename-seen-cache.h: Revert.
11960 * filename-seen-cache.c: Revert.
11961 * fbsd-tdep.c: Revert.
11962 * fbsd-nat.h: Revert.
11963 * fbsd-nat.c: Revert.
11964 * f-valprint.c: Revert.
11965 * f-typeprint.c: Revert.
11966 * f-lang.c: Revert.
11967 * extension.h: Revert.
11968 * extension.c: Revert.
11969 * extension-priv.h: Revert.
11970 * expprint.c: Revert.
11971 * exec.h: Revert.
11972 * exec.c: Revert.
11973 * exceptions.c: Revert.
11974 * event-top.c: Revert.
11975 * event-loop.c: Revert.
11976 * eval.c: Revert.
11977 * elfread.c: Revert.
11978 * dwarf2read.h: Revert.
11979 * dwarf2read.c: Revert.
11980 * dwarf2loc.c: Revert.
11981 * dwarf2expr.h: Revert.
11982 * dwarf2expr.c: Revert.
11983 * dwarf2-frame.c: Revert.
11984 * dwarf2-frame-tailcall.c: Revert.
11985 * dwarf-index-write.h: Revert.
11986 * dwarf-index-write.c: Revert.
11987 * dwarf-index-common.c: Revert.
11988 * dwarf-index-cache.h: Revert.
11989 * dwarf-index-cache.c: Revert.
11990 * dummy-frame.c: Revert.
11991 * dtrace-probe.c: Revert.
11992 * disasm.h: Revert.
11993 * disasm.c: Revert.
11994 * disasm-selftests.c: Revert.
11995 * dictionary.c: Revert.
11996 * dicos-tdep.c: Revert.
11997 * demangle.c: Revert.
11998 * dcache.h: Revert.
11999 * dcache.c: Revert.
12000 * darwin-nat.h: Revert.
12001 * darwin-nat.c: Revert.
12002 * darwin-nat-info.c: Revert.
12003 * d-valprint.c: Revert.
12004 * d-namespace.c: Revert.
12005 * d-lang.c: Revert.
12006 * ctf.c: Revert.
12007 * csky-tdep.c: Revert.
12008 * csky-linux-tdep.c: Revert.
12009 * cris-tdep.c: Revert.
12010 * cris-linux-tdep.c: Revert.
12011 * cp-valprint.c: Revert.
12012 * cp-support.c: Revert.
12013 * cp-namespace.c: Revert.
12014 * cp-abi.c: Revert.
12015 * corelow.c: Revert.
12016 * corefile.c: Revert.
12017 * continuations.c: Revert.
12018 * completer.h: Revert.
12019 * completer.c: Revert.
12020 * complaints.c: Revert.
12021 * coffread.c: Revert.
12022 * coff-pe-read.c: Revert.
12023 * cli-out.h: Revert.
12024 * cli-out.c: Revert.
12025 * charset.c: Revert.
12026 * c-varobj.c: Revert.
12027 * c-valprint.c: Revert.
12028 * c-typeprint.c: Revert.
12029 * c-lang.c: Revert.
12030 * buildsym.c: Revert.
12031 * buildsym-legacy.c: Revert.
12032 * build-id.h: Revert.
12033 * build-id.c: Revert.
12034 * btrace.c: Revert.
12035 * bsd-uthread.c: Revert.
12036 * breakpoint.h: Revert.
12037 * breakpoint.c: Revert.
12038 * break-catch-throw.c: Revert.
12039 * break-catch-syscall.c: Revert.
12040 * break-catch-sig.c: Revert.
12041 * blockframe.c: Revert.
12042 * block.c: Revert.
12043 * bfin-tdep.c: Revert.
12044 * bfin-linux-tdep.c: Revert.
12045 * bfd-target.c: Revert.
12046 * bcache.c: Revert.
12047 * ax-general.c: Revert.
12048 * ax-gdb.h: Revert.
12049 * ax-gdb.c: Revert.
12050 * avr-tdep.c: Revert.
12051 * auxv.c: Revert.
12052 * auto-load.c: Revert.
12053 * arm-wince-tdep.c: Revert.
12054 * arm-tdep.c: Revert.
12055 * arm-symbian-tdep.c: Revert.
12056 * arm-pikeos-tdep.c: Revert.
12057 * arm-obsd-tdep.c: Revert.
12058 * arm-nbsd-tdep.c: Revert.
12059 * arm-nbsd-nat.c: Revert.
12060 * arm-linux-tdep.c: Revert.
12061 * arm-linux-nat.c: Revert.
12062 * arm-fbsd-tdep.c: Revert.
12063 * arm-fbsd-nat.c: Revert.
12064 * arm-bsd-tdep.c: Revert.
12065 * arch-utils.c: Revert.
12066 * arc-tdep.c: Revert.
12067 * arc-newlib-tdep.c: Revert.
12068 * annotate.h: Revert.
12069 * annotate.c: Revert.
12070 * amd64-windows-tdep.c: Revert.
12071 * amd64-windows-nat.c: Revert.
12072 * amd64-tdep.c: Revert.
12073 * amd64-sol2-tdep.c: Revert.
12074 * amd64-obsd-tdep.c: Revert.
12075 * amd64-obsd-nat.c: Revert.
12076 * amd64-nbsd-tdep.c: Revert.
12077 * amd64-nbsd-nat.c: Revert.
12078 * amd64-nat.c: Revert.
12079 * amd64-linux-tdep.c: Revert.
12080 * amd64-linux-nat.c: Revert.
12081 * amd64-fbsd-tdep.c: Revert.
12082 * amd64-fbsd-nat.c: Revert.
12083 * amd64-dicos-tdep.c: Revert.
12084 * amd64-darwin-tdep.c: Revert.
12085 * amd64-bsd-nat.c: Revert.
12086 * alpha-tdep.c: Revert.
12087 * alpha-obsd-tdep.c: Revert.
12088 * alpha-nbsd-tdep.c: Revert.
12089 * alpha-mdebug-tdep.c: Revert.
12090 * alpha-linux-tdep.c: Revert.
12091 * alpha-linux-nat.c: Revert.
12092 * alpha-bsd-tdep.c: Revert.
12093 * alpha-bsd-nat.c: Revert.
12094 * aix-thread.c: Revert.
12095 * agent.c: Revert.
12096 * addrmap.c: Revert.
12097 * ada-varobj.c: Revert.
12098 * ada-valprint.c: Revert.
12099 * ada-typeprint.c: Revert.
12100 * ada-tasks.c: Revert.
12101 * ada-lang.c: Revert.
12102 * aarch64-tdep.c: Revert.
12103 * aarch64-ravenscar-thread.c: Revert.
12104 * aarch64-newlib-tdep.c: Revert.
12105 * aarch64-linux-tdep.c: Revert.
12106 * aarch64-linux-nat.c: Revert.
12107 * aarch64-fbsd-tdep.c: Revert.
12108 * aarch64-fbsd-nat.c: Revert.
12109 * aarch32-linux-nat.c: Revert.
12110
d55e5aa6
TT
121112019-04-05 Tom Tromey <tom@tromey.com>
12112
12113 * ft32-tdep.c: Sort headers.
12114 * frv-tdep.c: Sort headers.
12115 * frv-linux-tdep.c: Sort headers.
12116 * frame.c: Sort headers.
12117 * frame-unwind.c: Sort headers.
12118 * frame-base.c: Sort headers.
12119 * fork-child.c: Sort headers.
12120 * findvar.c: Sort headers.
12121 * findcmd.c: Sort headers.
12122 * filesystem.c: Sort headers.
12123 * filename-seen-cache.h: Sort headers.
12124 * filename-seen-cache.c: Sort headers.
12125 * fbsd-tdep.c: Sort headers.
12126 * fbsd-nat.h: Sort headers.
12127 * fbsd-nat.c: Sort headers.
12128 * f-valprint.c: Sort headers.
12129 * f-typeprint.c: Sort headers.
12130 * f-lang.c: Sort headers.
12131 * extension.h: Sort headers.
12132 * extension.c: Sort headers.
12133 * extension-priv.h: Sort headers.
12134 * expprint.c: Sort headers.
12135 * exec.h: Sort headers.
12136 * exec.c: Sort headers.
12137 * exceptions.c: Sort headers.
12138 * event-top.c: Sort headers.
12139 * event-loop.c: Sort headers.
12140 * eval.c: Sort headers.
12141 * elfread.c: Sort headers.
12142 * dwarf2read.h: Sort headers.
12143 * dwarf2read.c: Sort headers.
12144 * dwarf2loc.c: Sort headers.
12145 * dwarf2expr.h: Sort headers.
12146 * dwarf2expr.c: Sort headers.
12147 * dwarf2-frame.c: Sort headers.
12148 * dwarf2-frame-tailcall.c: Sort headers.
12149 * dwarf-index-write.h: Sort headers.
12150 * dwarf-index-write.c: Sort headers.
12151 * dwarf-index-common.c: Sort headers.
12152 * dwarf-index-cache.h: Sort headers.
12153 * dwarf-index-cache.c: Sort headers.
12154 * dummy-frame.c: Sort headers.
12155 * dtrace-probe.c: Sort headers.
12156 * disasm.h: Sort headers.
12157 * disasm.c: Sort headers.
12158 * disasm-selftests.c: Sort headers.
12159 * dictionary.c: Sort headers.
12160 * dicos-tdep.c: Sort headers.
12161 * demangle.c: Sort headers.
12162 * dcache.h: Sort headers.
12163 * dcache.c: Sort headers.
12164 * darwin-nat.h: Sort headers.
12165 * darwin-nat.c: Sort headers.
12166 * darwin-nat-info.c: Sort headers.
12167 * d-valprint.c: Sort headers.
12168 * d-namespace.c: Sort headers.
12169 * d-lang.c: Sort headers.
12170 * ctf.c: Sort headers.
12171 * csky-tdep.c: Sort headers.
12172 * csky-linux-tdep.c: Sort headers.
12173 * cris-tdep.c: Sort headers.
12174 * cris-linux-tdep.c: Sort headers.
12175 * cp-valprint.c: Sort headers.
12176 * cp-support.c: Sort headers.
12177 * cp-namespace.c: Sort headers.
12178 * cp-abi.c: Sort headers.
12179 * corelow.c: Sort headers.
12180 * corefile.c: Sort headers.
12181 * continuations.c: Sort headers.
12182 * completer.h: Sort headers.
12183 * completer.c: Sort headers.
12184 * complaints.c: Sort headers.
12185 * coffread.c: Sort headers.
12186 * coff-pe-read.c: Sort headers.
12187 * cli-out.h: Sort headers.
12188 * cli-out.c: Sort headers.
12189 * charset.c: Sort headers.
12190 * c-varobj.c: Sort headers.
12191 * c-valprint.c: Sort headers.
12192 * c-typeprint.c: Sort headers.
12193 * c-lang.c: Sort headers.
12194 * buildsym.c: Sort headers.
12195 * buildsym-legacy.c: Sort headers.
12196 * build-id.h: Sort headers.
12197 * build-id.c: Sort headers.
12198 * btrace.c: Sort headers.
12199 * bsd-uthread.c: Sort headers.
12200 * breakpoint.h: Sort headers.
12201 * breakpoint.c: Sort headers.
12202 * break-catch-throw.c: Sort headers.
12203 * break-catch-syscall.c: Sort headers.
12204 * break-catch-sig.c: Sort headers.
12205 * blockframe.c: Sort headers.
12206 * block.c: Sort headers.
12207 * bfin-tdep.c: Sort headers.
12208 * bfin-linux-tdep.c: Sort headers.
12209 * bfd-target.c: Sort headers.
12210 * bcache.c: Sort headers.
12211 * ax-general.c: Sort headers.
12212 * ax-gdb.h: Sort headers.
12213 * ax-gdb.c: Sort headers.
12214 * avr-tdep.c: Sort headers.
12215 * auxv.c: Sort headers.
12216 * auto-load.c: Sort headers.
12217 * arm-wince-tdep.c: Sort headers.
12218 * arm-tdep.c: Sort headers.
12219 * arm-symbian-tdep.c: Sort headers.
12220 * arm-pikeos-tdep.c: Sort headers.
12221 * arm-obsd-tdep.c: Sort headers.
12222 * arm-nbsd-tdep.c: Sort headers.
12223 * arm-nbsd-nat.c: Sort headers.
12224 * arm-linux-tdep.c: Sort headers.
12225 * arm-linux-nat.c: Sort headers.
12226 * arm-fbsd-tdep.c: Sort headers.
12227 * arm-fbsd-nat.c: Sort headers.
12228 * arm-bsd-tdep.c: Sort headers.
12229 * arch-utils.c: Sort headers.
12230 * arc-tdep.c: Sort headers.
12231 * arc-newlib-tdep.c: Sort headers.
12232 * annotate.h: Sort headers.
12233 * annotate.c: Sort headers.
12234 * amd64-windows-tdep.c: Sort headers.
12235 * amd64-windows-nat.c: Sort headers.
12236 * amd64-tdep.c: Sort headers.
12237 * amd64-sol2-tdep.c: Sort headers.
12238 * amd64-obsd-tdep.c: Sort headers.
12239 * amd64-obsd-nat.c: Sort headers.
12240 * amd64-nbsd-tdep.c: Sort headers.
12241 * amd64-nbsd-nat.c: Sort headers.
12242 * amd64-nat.c: Sort headers.
12243 * amd64-linux-tdep.c: Sort headers.
12244 * amd64-linux-nat.c: Sort headers.
12245 * amd64-fbsd-tdep.c: Sort headers.
12246 * amd64-fbsd-nat.c: Sort headers.
12247 * amd64-dicos-tdep.c: Sort headers.
12248 * amd64-darwin-tdep.c: Sort headers.
12249 * amd64-bsd-nat.c: Sort headers.
12250 * alpha-tdep.c: Sort headers.
12251 * alpha-obsd-tdep.c: Sort headers.
12252 * alpha-nbsd-tdep.c: Sort headers.
12253 * alpha-mdebug-tdep.c: Sort headers.
12254 * alpha-linux-tdep.c: Sort headers.
12255 * alpha-linux-nat.c: Sort headers.
12256 * alpha-bsd-tdep.c: Sort headers.
12257 * alpha-bsd-nat.c: Sort headers.
12258 * aix-thread.c: Sort headers.
12259 * agent.c: Sort headers.
12260 * addrmap.c: Sort headers.
12261 * ada-varobj.c: Sort headers.
12262 * ada-valprint.c: Sort headers.
12263 * ada-typeprint.c: Sort headers.
12264 * ada-tasks.c: Sort headers.
12265 * ada-lang.c: Sort headers.
12266 * aarch64-tdep.c: Sort headers.
12267 * aarch64-ravenscar-thread.c: Sort headers.
12268 * aarch64-newlib-tdep.c: Sort headers.
12269 * aarch64-linux-tdep.c: Sort headers.
12270 * aarch64-linux-nat.c: Sort headers.
12271 * aarch64-fbsd-tdep.c: Sort headers.
12272 * aarch64-fbsd-nat.c: Sort headers.
12273 * aarch32-linux-nat.c: Sort headers.
12274
699bd4cf
TT
122752019-04-04 Tom Tromey <tom@tromey.com>
12276
12277 * varobj.c (varobj_create): Update.
12278 * rust-exp.y (struct rust_parser) <update_innermost_block,
12279 lookup_symbol>: New methods.
12280 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12281 Rename.
12282 (rust_parser::rust_lookup_type)
12283 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12284 * printcmd.c (display_command, do_one_display): Update.
12285 * parser-defs.h (struct parser_state) <parser_state>: Add
12286 "tracker" parameter.
12287 (block_tracker): New member.
12288 (class innermost_block_tracker) <innermost_block_tracker>: Add
12289 "types" parameter.
12290 <reset>: Remove method.
12291 (innermost_block): Don't declare.
12292 (null_post_parser): Update.
12293 * parse.c (innermost_block): Remove global.
12294 (write_dollar_variable): Update.
12295 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12296 Remove "tracker_types" parameter.
12297 (parse_expression): Add "tracker" parameter.
12298 (parse_expression_for_completion): Update.
12299 (null_post_parser): Add "tracker" parameter.
12300 * p-exp.y: Update rules.
12301 * m2-exp.y: Update rules.
12302 * language.h (struct language_defn) <la_post_parser>: Add
12303 "tracker" parameter.
12304 * go-exp.y: Update rules.
12305 * f-exp.y: Update rules.
12306 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12307 parameter.
12308 * d-exp.y: Update rules.
12309 * c-exp.y: Update rules.
12310 * breakpoint.c (set_breakpoint_condition): Create an
12311 innermost_block_tracker.
12312 (watch_command_1): Likewise.
12313 * ada-lang.c (resolve): Add "tracker" parameter.
12314 (resolve_subexp): Likewise.
12315 * ada-exp.y (write_var_from_sym): Update.
12316
dac43e32
TT
123172019-04-04 Tom Tromey <tom@tromey.com>
12318
12319 * type-stack.h: New file.
12320 * type-stack.c: New file.
12321 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12322 type-stack.h.
12323 (insert_into_type_stack, insert_type, push_type, push_type_int)
12324 (insert_type_address_space, pop_type, pop_type_int)
12325 (pop_typelist, pop_type_stack, append_type_stack)
12326 (push_type_stack, get_type_stack, push_typelist)
12327 (follow_type_instance_flags, follow_types): Don't declare.
12328 * parse.c (type_stack): Remove global.
12329 (parse_exp_in_context): Update.
12330 (insert_into_type_stack, insert_type, push_type, push_type_int)
12331 (insert_type_address_space, pop_type, pop_type_int)
12332 (pop_typelist, pop_type_stack, append_type_stack)
12333 (push_type_stack, get_type_stack, push_typelist)
12334 (follow_type_instance_flags, follow_types): Remove (moved to
12335 type-stack.c).
12336 * f-exp.y (type_stack): New global.
12337 Update rules.
12338 (push_kind_type, f_parse): Update.
12339 * d-exp.y (type_stack): New global.
12340 Update rules.
12341 (d_parse): Update.
12342 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12343 Update rules.
12344 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12345 (HFILES_NO_SRCDIR): Add type-stack.h.
12346
2a612529
TT
123472019-04-04 Tom Tromey <tom@tromey.com>
12348
12349 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12350 (rust_parser::convert_ast_to_expression, rust_parse)
12351 (rust_lex_test_completion, rust_lex_tests): Update.
12352 * parser-defs.h (struct expr_completion_state): New.
12353 (struct parser_state) <parser_state>: Add completion parameter.
12354 <mark_struct_expression, mark_completion_tag>: New methods.
12355 <parse_completion, m_completion_state>: New members.
12356 (prefixify_expression, null_post_parser): Update.
12357 (mark_struct_expression, mark_completion_tag): Don't declare.
12358 * parse.c (parse_completion, expout_last_struct)
12359 (expout_tag_completion_type, expout_completion_name): Remove
12360 globals.
12361 (parser_state::mark_struct_expression)
12362 (parser_state::mark_completion_tag): Now methods.
12363 (prefixify_expression): Add last_struct parameter.
12364 (prefixify_subexp): Likewise.
12365 (parse_exp_1): Update.
12366 (parse_exp_in_context): Add cstate parameter. Update.
12367 (parse_expression_for_completion): Create an
12368 expr_completion_state.
12369 (null_post_parser): Add "completion" parameter.
12370 * p-exp.y: Update rules.
12371 (yylex): Update.
12372 * language.h (struct language_defn) <la_post_parser>: Add
12373 "completing" parameter.
12374 * go-exp.y: Update rules.
12375 (lex_one_token): Update.
12376 * expression.h (parse_completion): Don't declare.
12377 * d-exp.y: Update rules.
12378 (lex_one_token): Update rules.
12379 * c-exp.y: Update rules.
12380 (lex_one_token): Update.
12381 * ada-lang.c (resolve): Add "parse_completion" parameter.
12382 (resolve_subexp): Likewise.
12383 (ada_resolve_function): Likewise.
12384
43476f0b
TT
123852019-04-04 Tom Tromey <tom@tromey.com>
12386
12387 * parser-defs.h (struct parser_state) <start_arglist,
12388 end_arglist>: New methods.
12389 <arglist_len, m_funcall_chain>: New members.
12390 (arglist_len, start_arglist, end_arglist): Don't declare.
12391 * parse.c (arglist_len, funcall_chain): Remove global.
12392 (start_arglist, end_arglist): Remove functions.
12393 (parse_exp_in_context): Update.
12394 * p-exp.y: Update rules.
12395 * m2-exp.y: Update rules.
12396 * go-exp.y: Update rules.
12397 * f-exp.y: Update rules.
12398 * d-exp.y: Update rules.
12399 * c-exp.y: Update rules.
12400
5776fca3
TT
124012019-04-04 Tom Tromey <tom@tromey.com>
12402
12403 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12404 lex_operator, push_back>: New methods.
12405 Update all rules.
12406 (rust_parser::lex_hex, lex_escape): Rename and update.
12407 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12408 (rust_parser::lex_operator): Rename and update.
12409 (rust_parser::lex_number, rustyylex, rustyyerror)
12410 (rust_lex_test_init, rust_lex_test_sequence)
12411 (rust_lex_test_push_back, rust_lex_tests): Update.
12412 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12413 parameter.
12414 <lexptr, prev_lexptr>: New members.
12415 (lexptr, prev_lexptr): Don't declare.
12416 * parse.c (lexptr, prev_lexptr): Remove globals.
12417 (parse_exp_in_context): Update.
12418 * p-exp.y (yylex, yyerror): Update.
12419 * m2-exp.y (parse_number, yylex, yyerror): Update.
12420 * go-exp.y (lex_one_token, yyerror): Update.
12421 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12422 * d-exp.y (lex_one_token, yyerror): Update.
12423 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12424 (lex_one_token, yyerror): Update.
12425 * ada-lex.l (YY_INPUT): Update.
12426 (rewind_to_char): Update.
12427 * ada-exp.y (yyerror): Update.
12428
8621b685
TT
124292019-04-04 Tom Tromey <tom@tromey.com>
12430
12431 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12432 * parser-defs.h (struct parser_state) <parser_state>: Add new
12433 parameter.
12434 <comma_terminates>: New member.
12435 (comma_terminates): Don't declare global.
12436 * parse.c (comma_terminates): Remove global.
12437 (parse_exp_in_context): Update.
12438 * p-exp.y (yylex): Update.
12439 * m2-exp.y (yylex): Update.
12440 * go-exp.y (lex_one_token): Update.
12441 * f-exp.y (yylex): Update.
12442 * d-exp.y (lex_one_token): Update.
12443 * c-exp.y (lex_one_token): Update.
12444 * ada-lex.l: Update.
12445
28aaf3fd
TT
124462019-04-04 Tom Tromey <tom@tromey.com>
12447
12448 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12449 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12450 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12451 * parser-defs.h (paren_depth): Don't declare.
12452 * parse.c (paren_depth): Remove global.
12453 (parse_exp_in_context): Update.
12454 * p-exp.y (paren_depth): New global.
12455 (pascal_parse): Initialize it.
12456 * m2-exp.y (paren_depth): New global.
12457 (m2_parse): Initialize it.
12458 * go-exp.y (paren_depth): New global.
12459 (go_parse): Initialize it.
12460 * f-exp.y (paren_depth): New global.
12461 (f_parse): Initialize it.
12462 * d-exp.y (paren_depth): New global.
12463 (d_parse): Initialize it.
12464 * c-exp.y (paren_depth): New global.
12465 (c_parse): Initialize it.
12466 * ada-lex.l (paren_depth): New global.
12467 (lexer_init): Initialize it.
12468
1e58a4a4
TT
124692019-04-04 Tom Tromey <tom@tromey.com>
12470
12471 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12472 (rust_parser::convert_ast_to_type)
12473 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12474 * parser-defs.h (struct parser_state) <parser_state>: Add
12475 parameters. Initialize new members.
12476 <expression_context_block, expression_context_pc>: New members.
12477 * parse.c (expression_context_block, expression_context_pc):
12478 Remove globals.
12479 (parse_exp_in_context): Update.
12480 * p-exp.y: Update all rules.
12481 (yylex): Update.
12482 * m2-exp.y: Update all rules.
12483 (yylex): Update.
12484 * go-exp.y (yylex): Update.
12485 * f-exp.y (yylex): Update.
12486 * d-exp.y: Update all rules.
12487 (yylex): Update.
12488 * c-exp.y: Update all rules.
12489 (lex_one_token, classify_name, yylex, c_parse): Update.
12490 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12491
37eedb39
TT
124922019-04-04 Tom Tromey <tom@tromey.com>
12493
12494 * gdbarch.h, gdbarch.c: Rebuild.
12495 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12496 * stap-probe.h:
12497 (struct stap_parse_info): Replace "parser_state" with
12498 "expr_builder".
12499 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12500 (parser_state): New class.
12501 * parse.c (expr_builder): Rename.
12502 (expr_builder::release): Rename.
12503 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12504 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12505 (write_exp_elt_longcst, write_exp_elt_floatcst)
12506 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12507 (write_exp_string_vector, write_exp_bitstring)
12508 (write_exp_msymbol, mark_struct_expression)
12509 (write_dollar_variable)
12510 (insert_type_address_space, increase_expout_size): Replace
12511 "parser_state" with "expr_builder".
12512 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12513 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12514 "parser_state" with "expr_builder".
12515
73923d7e
TT
125162019-04-04 Tom Tromey <tom@tromey.com>
12517
12518 * rust-exp.y: Replace "parse_language" with method call.
12519 * p-exp.y:
12520 (yylex): Replace "parse_language" with method call.
12521 * m2-exp.y:
12522 (yylex): Replace "parse_language" with method call.
12523 * go-exp.y (classify_name): Replace "parse_language" with method
12524 call.
12525 * f-exp.y (yylex): Replace "parse_language" with method call.
12526 * d-exp.y (lex_one_token): Replace "parse_language" with method
12527 call.
12528 * c-exp.y:
12529 (lex_one_token, classify_name, yylex): Replace "parse_language"
12530 with method call.
12531 * ada-exp.y (find_primitive_type, type_char)
12532 (type_system_address): Replace "parse_language" with method call.
12533
fa9f5be6
TT
125342019-04-04 Tom Tromey <tom@tromey.com>
12535
12536 * rust-exp.y: Replace "parse_gdbarch" with method call.
12537 * parse.c (write_dollar_variable, insert_type_address_space):
12538 Replace "parse_gdbarch" with method call.
12539 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12540 call.
12541 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12542 call.
12543 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12544 "parse_gdbarch" with method call.
12545 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12546 with method call.
12547 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12548 "parse_gdbarch" with method call.
12549 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12550 "parse_gdbarch" with method call.
12551 * c-exp.y (parse_type, parse_number, classify_name): Replace
12552 "parse_gdbarch" with method call.
12553 * ada-lex.l: Replace "parse_gdbarch" with method call.
12554 * ada-exp.y (parse_type, find_primitive_type, type_char)
12555 (type_system_address): Replace "parse_gdbarch" with method call.
12556
1201a264
TT
125572019-04-04 Tom Tromey <tom@tromey.com>
12558
12559 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12560 * stap-probe.c (stap_parse_argument): Update.
12561 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12562 initial_size parameter.
12563 * rust-exp.y (rust_lex_tests): Update.
12564 * parse.c (parser_state): Update.
12565 (parse_exp_in_context): Update.
12566 * parser-defs.h (struct parser_state) <parser_state>: Remove
12567 "initial_size" parameter.
12568
e3980ce2
TT
125692019-04-04 Tom Tromey <tom@tromey.com>
12570
12571 * parser-defs.h (increase_expout_size): Don't declare.
12572 * parse.c (increase_expout_size): Now static.
12573
e9f8e3f1
TS
125742019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12575
12576 * gnu-nat.c (gnu_nat_target::wait): Fix
12577 target_waitstatus_to_string call.
12578
d7df6549
AB
125792019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12580
12581 * eval.c (evaluate_subexp_standard): Handle internal functions
12582 during Fortran function call handling.
12583
8bdc1658
AB
125842019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12585
12586 * NEWS: Mention new internal functions.
12587 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12588 (read_base_type): Use dwarf2_init_complex_target_type.
12589 * value.c (creal_internal_fn): New function.
12590 (cimag_internal_fn): New function.
12591 (_initialize_values): Register new internal functions.
12592
c29705b7
PW
125932019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12594
12595 * infrun.c (stop_all_threads): If debug_infrun, always
12596 trace the wait status after wait_one, using
12597 target_waitstatus_to_string and target_pid_to_str.
12598 (handle_inferior_event): Replace various trace of
12599 wait status kind by a single trace.
12600 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12601 wait status kind image by target_waitstatus_to_string.
12602 * target/waitstatus.c (target_waitstatus_to_string): Fix
12603 obsolete comment.
12604
05caa1d2
TT
126052019-04-01 Tom Tromey <tromey@adacore.com>
12606
12607 PR symtab/23331:
12608 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12609
9d1447e0
SDJ
126102019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12611 Pedro Alves <palves@redhat.com>
12612
12613 * top.c (quit_force): Call 'finalize_values'.
12614 * value.c (finalize_values): New function.
12615 * value.h (finalize_values): Declare.
12616
7734102d
EZ
126172019-03-30 Eli Zaretskii <eliz@gnu.org>
12618
12619 * NEWS: Announce $_gdb_major and $_gdb_minor.
12620
12621 * top.c (init_gdb_version_vars): New function.
12622 (gdb_init): Call init_gdb_version_vars.
12623
188e1fa9
TT
126242019-03-29 Tom Tromey <tromey@adacore.com>
12625
12626 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12627 help text. Remove dead code.
12628
2880242d
KS
126292019-03-29 Keith Seitz <keiths@redhat.com>
12630
12631 From Siddhesh Poyarekar:
12632 * f-lang.h (f77_get_upperbound): Return LONGEST.
12633 (f77_get_lowerbound): Likewise.
12634 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12635 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12636 print them.
12637 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12638 plongest to format print it.
12639 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12640 (f77_get_upperbound): Likewise.
12641 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12642 LOWER_BOUND to LONGEST.
12643 (f77_create_arrayprint_offset_tbl): Likewise.
12644
cc1defb1
KS
126452019-03-29 Keith Seitz <keiths@redhat.com>
12646
12647 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12648 %s/pulongest for TYPE_LENGTH instead of %d in format
12649 strings.
12650 * ada-typerint.c (ada_print_type): Likewise.
12651 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12652 * compile/compile-c-support.c (generate_register_struct): Likewise.
12653 * gdbtypes.c (recursive_dump_type): Likewise.
12654 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12655 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12656 instead of %d in format strings.
12657 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12658 to std::min to ULONGEST.
12659 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12660 instead of %d in format strings.
12661 * tracepoint.c (info_scope_command): Likewise.
12662 * typeprint.c (print_offset_data::update)
12663 (print_offset_data::finish): Likewise.
12664 * xtensa-tdep.c (xtensa_store_return_value)
12665 (xtensa_push_dummy_call): Likewise.
12666
e432ccf1
JT
126672019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
12668
12669 * windows-nat.c (display_selector): Fixed format specifications
12670 for 64-bit Cygwin.
12671
65d2b333
PW
126722019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12673
12674 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12675
f489207e
SL
126762019-03-28 Sandra Loosemore <sandra@codesourcery.com>
12677
12678 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12679 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12680 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12681 (nios2_linux_init_abi): Install it.
12682
bffa1015
AH
126832019-03-28 Alan Hayward <alan.hayward@arm.com>
12684
12685 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12686
fc96163a
AH
126872019-03-28 Alan Hayward <alan.hayward@arm.com>
12688
12689 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12690
20dc7e9b
PW
126912019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12692 Tom Tromey <tromey@adacore.com>
12693
12694 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12695
7f5331a8
JB
126962019-03-26 Joel Brobecker <brobecker@adacore.com>
12697
12698 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12699 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12700 method to compute the bounds of range types. Also print "[evaluated]"
12701 if the bounds' values come from a dynamic evaluation.
12702
18c77628
AB
127032019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
12704
12705 * cp-valprint.c (cp_print_value_fields): Don't print trailing
12706 whitespace when pretty printing is on.
12707
53c973f2
AH
127082019-03-26 Alan Hayward <alan.hayward@arm.com>
12709
e79be6e5 12710 * ppc-linux-nat.c: Add include.
53c973f2 12711
d851aa71
AH
127122019-03-26 Alan Hayward <alan.hayward@arm.com>
12713
e79be6e5 12714 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 12715
2fe7bab7
AH
127162019-03-26 Alan Hayward <alan.hayward@arm.com>
12717
e79be6e5 12718 * arm-linux-nat.c: Add include.
2fe7bab7 12719
068ef30e
SM
127202019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
12721
12722 * source-cache.c (source_cache::get_source_lines): Re-read
12723 fullname after calling open_source_file.
12724
81a24d04
JB
127252019-03-25 John Baldwin <jhb@FreeBSD.org>
12726
12727 * NEWS: Mention TLS support for FreeBSD.
12728
79e7ae11
TT
127292019-03-25 Tom Tromey <tromey@adacore.com>
12730
12731 * minsyms.c (BUNCH_SIZE): Update comment.
12732 (~minimal_symbol_reader): Remove old comment.
12733 (compact_minimal_symbols): Update comment.
12734 (minimal_symbol_reader::install): Remove old comment. Update
12735 other comments.
12736
d45963c2
AH
127372019-03-25 Alan Hayward <alan.hayward@arm.com>
12738
12739 * s390-linux-nat.c: Add include.
12740
0f83012e
AH
127412019-03-25 Alan Hayward <alan.hayward@arm.com>
12742
12743 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12744 Call linux_get_hwcap.
12745 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12746 Likewise.
12747 (aarch64_linux_get_hwcap): Remove function.
12748 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12749 declaration.
12750 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12751 linux_get_hwcap.
12752 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12753 * linux-tdep.c (linux_get_hwcap): Add function.
12754 (linux_get_hwcap2): Likewise.
12755 * linux-tdep.h (linux_get_hwcap): Add declaration.
12756 (linux_get_hwcap2): Likewise.
12757 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12758 (ppc_linux_get_hwcap2): Likewise.
12759 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12760 linux_get_hwcap.
12761 (ppc_linux_nat_target::insert_watchpoint): Likewise.
12762 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12763 (ppc_linux_nat_target::read_description): Likewise.
12764 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12765 * s390-linux-nat.c: Likewise.
12766 * s390-linux-tdep.c (s390_core_read_description): Likewise.
12767
6640a367
TT
127682019-03-24 Tom Tromey <tom@tromey.com>
12769
12770 * ada-lang.c (standard_lookup): Simplify initialization.
12771 (ada_lookup_symbol_nonlocal): Simplify return.
12772 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12773 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12774 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12775 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12776 initialization.
12777 * solib.c (solib_global_lookup): Simplify.
12778 * symtab.c (null_block_symbol): Remove.
12779 (symbol_cache_lookup): Simplify returns.
12780 (lookup_language_this): Simplify returns.
12781 (lookup_symbol_aux): Simplify return.
12782 (lookup_local_symbol): Simplify returns.
12783 (lookup_global_symbol_from_objfile): Simplify return.
12784 (lookup_symbol_in_objfile_symtabs)
12785 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12786 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12787 (lookup_static_symbol, lookup_global_symbol): Simplify return.
12788 * cp-namespace.c (cp_lookup_bare_symbol)
12789 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12790 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12791 (cp_lookup_nested_symbol): Don't use null_block_symbol.
12792 (cp_lookup_symbol_via_imports): Simplify initialization.
12793 (find_symbol_in_baseclass): Likewise.
12794 * symtab.h (null_block_symbol): Remove.
12795 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12796 (d_lookup_nested_symbol, d_lookup_symbol_imports)
12797 (d_lookup_symbol_module): Likewise.
12798 (find_symbol_in_baseclass): Simplify initialization.
12799
a930ebcd
TT
128002019-03-24 Tom Tromey <tom@tromey.com>
12801
12802 * expression.h: Don't include symtab.h.
12803 (struct block): Forward declare.
12804
582942f4
TT
128052019-03-24 Tom Tromey <tom@tromey.com>
12806
12807 * c-exp.y (typebase): Remove casts.
12808 * gdbtypes.c (lookup_unsigned_typename, )
12809 (lookup_signed_typename): Remove cast.
12810 * eval.c (parse_to_comma_and_eval): Remove cast.
12811 * parse.c (write_dollar_variable): Remove cast.
12812 * block.h (struct block) <superblock>: Now const.
12813 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12814 * psymtab.c (psym_map_matching_symbols): Make "block" const.
12815 (map_block): Make "block" const.
12816 * symfile.h (struct quick_symbol_functions)
12817 <map_matching_symbols>: Constify block argument to "callback".
12818 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12819 const.
12820 (find_pc_sect_compunit_symtab): Make "b" const.
12821 (find_symbol_at_address): Likewise.
12822 (search_symbols): Likewise.
12823 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12824 (dw2_debug_names_lookup_symbol): Likewise.
12825 (dw2_map_matching_symbols): Update.
12826 * p-valprint.c (pascal_val_print): Remove "block".
12827 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12828 (aux_add_nonlocal_symbols): Make "block" const.
12829 (resolve_subexp): Remove cast.
12830 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12831 const.
12832 (iterate_over_file_blocks): Likewise.
12833 * f-exp.y (%union) <bval>: Remove.
12834 * coffread.c (patch_opaque_types): Make "b" const.
12835 * spu-tdep.c (spu_catch_start): Make "block" const.
12836 * c-valprint.c (print_unpacked_pointer): Remove "block".
12837 * symmisc.c (dump_symtab_1): Make "b" const.
12838 (block_depth): Make "block" const.
12839 * d-exp.y (%union) <bval>: Remove.
12840 * cp-support.h (cp_lookup_rtti_type): Update.
12841 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12842 * psymtab.c (psym_lookup_symbol): Make "block" const.
12843 (maintenance_check_psymtabs): Make "b" const.
12844 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12845 (enumerate_locals, enumerate_args): Update.
12846 * python/py-symtab.c (stpy_global_block): Make "block" const.
12847 (stpy_static_block): Likewise.
12848 * inline-frame.c (block_starting_point_at): Make "new_block"
12849 const.
12850 * block.c (find_block_in_blockvector): Make return type const.
12851 (blockvector_for_pc_sect): Make "b" const.
12852 (find_block_in_blockvector): Make "b" const.
12853
7ad417dd
TT
128542019-03-23 Tom Tromey <tom@tromey.com>
12855
12856 * varobj.c (varobj_create): Update.
12857 * symfile.c (clear_symtab_users): Don't reset innermost_block.
12858 * printcmd.c (display_command, do_one_display): Don't reset
12859 innermost_block.
12860 * parser-defs.h (enum innermost_block_tracker_type): Move to
12861 expression.h.
12862 (innermost_block): Update comment.
12863 * parse.c (parse_exp_1): Add tracker_types parameter.
12864 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
12865 tracker_types parameter. Reset innermost_block.
12866 (parse_exp_in_context): Remove.
12867 (parse_expression_for_completion): Update.
12868 * objfiles.c (~objfile): Don't reset expression_context_block or
12869 innermost_block.
12870 * expression.h (enum innermost_block_tracker_type): Move from
12871 parser-defs.h.
12872 (parse_exp_1): Add tracker_types parameter.
12873 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12874 reset innermost_block.
12875
b366c208
TT
128762019-03-23 Tom Tromey <tom@tromey.com>
12877
12878 * objfiles.h: Include bcache.h.
12879
9bb9b2f9
TT
128802019-03-23 Tom Tromey <tom@tromey.com>
12881
12882 * linespec.c (get_current_search_block): Use
12883 scoped_restore_current_language.
12884 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12885
59c28372
AH
128862019-03-22 Alan Hayward <alan.hayward@arm.com>
12887 Jiong Wang <jiong.wang@arm.com>
12888
12889 * aarch64-linux-tdep.c
12890 (aarch64_linux_iterate_over_regset_sections): Check for pauth
12891 section.
12892 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12893
17e116a7
AH
128942019-03-22 Alan Hayward <alan.hayward@arm.com>
12895 Jiong Wang <jiong.wang@arm.com>
12896
12897 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12898 instructions.
12899 (aarch64_analyze_prologue_test): Add PACIASP test.
12900 (aarch64_prologue_prev_register): Unmask PC value.
12901
11e1b75f
AH
129022019-03-22 Alan Hayward <alan.hayward@arm.com>
12903 Jiong Wang <jiong.wang@arm.com>
12904
12905 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12906 (aarch64_dwarf2_prev_register): Unmask PC value.
12907 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12908 (aarch64_execute_dwarf_cfa_vendor_op): Check for
12909 DW_CFA_AARCH64_negate_ra_state.
12910 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12911
34dcc7cf
AH
129122019-03-22 Alan Hayward <alan.hayward@arm.com>
12913 Jiong Wang <jiong.wang@arm.com>
12914
12915 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12916 registers.
12917 (aarch64_pseudo_register_name): Likewise.
12918 (aarch64_pseudo_register_type): Likewise.
12919 (aarch64_pseudo_register_reggroup_p): Likewise.
12920 (aarch64_gdbarch_init): Add pauth registers.
12921 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12922 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12923 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12924 (struct gdbarch_tdep): Add regnum for ra_state.
12925
1ef53e6b
AH
129262019-03-22 Alan Hayward <alan.hayward@arm.com>
12927 Jiong Wang <jiong.wang@arm.com>
12928
12929 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12930
76bed0fd
AH
129312019-03-22 Alan Hayward <alan.hayward@arm.com>
12932 Jiong Wang <jiong.wang@arm.com>
12933
12934 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12935 function.
12936 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12937 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12938 (aarch64_gdbarch_init): Add puth registers.
12939 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12940 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12941 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12942
ee4fbcfa
AH
129432019-03-22 Alan Hayward <alan.hayward@arm.com>
12944 Jiong Wang <jiong.wang@arm.com>
12945
12946 * aarch64-linux-nat.c
12947 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12948 * aarch64-linux-tdep.c
12949 (aarch64_linux_core_read_description): Likewise.
12950 (aarch64_linux_get_hwcap): New function.
12951 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12952 (aarch64_linux_get_hwcap): New declaration.
12953
6dc0ebde
AH
129542019-03-22 Alan Hayward <alan.hayward@arm.com>
12955 Jiong Wang <jiong.wang@arm.com>
12956
12957 * aarch64-linux-nat.c
12958 (aarch64_linux_nat_target::read_description): Add pauth param.
12959 * aarch64-linux-tdep.c
12960 (aarch64_linux_core_read_description): Likewise.
12961 * aarch64-tdep.c (struct target_desc): Add in pauth.
12962 (aarch64_read_description): Add pauth param.
12963 (aarch64_gdbarch_init): Likewise.
12964 * aarch64-tdep.h (aarch64_read_description): Likewise.
12965 * arch/aarch64.c (aarch64_create_target_description): Likewise.
12966 * arch/aarch64.h (aarch64_create_target_description): Likewise.
12967 * features/Makefile: Add new files.
12968 * features/aarch64-pauth.c: New file.
12969 * features/aarch64-pauth.xml: New file.
12970
595915c1
TT
129712019-03-20 Tom Tromey <tromey@adacore.com>
12972
12973 * infrun.c (handle_inferior_event): Rename from
12974 handle_inferior_event_1. Create a scoped_value_mark.
12975 (handle_inferior_event): Remove.
12976
4c7d57e7
TT
129772019-03-19 Tom Tromey <tromey@adacore.com>
12978
12979 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12980 * infrun.h (print_stop_event): Add "displays" parameter.
12981 * infrun.c (print_stop_event): Add "displays" parameter.
12982
cb246234
PA
129832019-03-19 Pedro Alves <palves@redhat.com>
12984
12985 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12986 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
12987 to -1. Fix TABs vs spaces.
12988 (tui_ui_out::tui_ui_out): Don't initialize fields here.
12989 * tui/tui-out.h (tui_ui_out) Add intro comments.
12990 <m_line, m_start_of_line>: In-class initialize, and add describing
12991 comment.
12992
3a0e45b2
AH
129932019-03-18 Alan Hayward <alan.hayward@arm.com>
12994
12995 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12996 variable names.
12997 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12998
5371b850
PA
129992019-03-18 Pedro Alves <palves@redhat.com>
13000 Eli Zaretskii <eliz@gnu.org>
13001
13002 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13003 m_line and m_start_of_line.
13004
b17c4cd0
EZ
130052019-03-18 Eli Zaretskii <eliz@gnu.org>
13006
13007 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13008 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13009 it returns a newline. This fixes a regression in TU mode, whereby
13010 the next line is output on the same screen line as the user input.
13011
4bd56d18
TT
130122019-03-18 Tom Tromey <tromey@adacore.com>
13013
13014 * minsyms.c (minimal_symbol_reader::install): Remove call to
13015 obstack_blank.
13016
55c10aca
PA
130172019-03-18 Pedro Alves <palves@redhat.com>
13018
13019 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13020 New globals.
13021 (apply_style): New, factored out from ...
13022 (apply_ansi_escape): ... this. Handle reverse video mode.
13023 (tui_set_reverse_mode): New function.
13024 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13025 * tui/tui-winsource.c (tui_show_source_line): Use
13026 tui_set_reverse_mode instead of setting A_STANDOUT.
13027 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13028 New setter methods.
13029
647bb750
HD
130302019-03-18 Hannes Domani <ssbssa@yahoo.de>
13031
13032 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13033 Handle tabs.
13034
bff8c71f
TT
130352019-03-18 Tom Tromey <tromey@adacore.com>
13036
13037 * ada-lang.c (empty_array): Add "high" parameter.
13038 (ada_evaluate_subexp): Update.
13039
58785d98
ST
130402019-03-17 Sergei Trofimovich <siarheit@google.com>
13041
13042 * unittests/string_view-selftests.c: Define
13043 _initialize_string_view_selftests unconditionally.
13044
d4cbef22
ВМ
130452019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13046
13047 PR gdb/24350
13048 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13049
fce4c071
ВМ
130502019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13051
13052 PR gdb/24351
13053 * windows-nat.c (display_selector): Fix format specifiers.
13054
f7f0a123
EZ
130552019-03-17 Eli Zaretskii <eliz@gnu.org>
13056
13057 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13058 tui_refill_source_window instead of tui_refresh_win, to update the
13059 current execution line. This fixes redisplay of the current line
13060 when stepping through the code with "next" or "step".
13061
ab42892f
EZ
130622019-03-16 Eli Zaretskii <eliz@gnu.org>
13063
13064 * source-cache.c (source_cache::get_source_lines): Call
13065 find_source_lines to initialize s->nlines. This fixes vertical
13066 scrolling of TUI source window when the DOWN arrow is pressed.
13067
8d8c087f
PW
130682019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13069
13070 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13071 linux-thread-db.c (_initialize_thread_db): Likewise.
13072
798e1c30
EZ
130732019-03-16 Eli Zaretskii <eliz@gnu.org>
13074
13075 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13076 wclrtoeol in tui_show_source_line". This reverts changes made in
13077 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13078
eefba3da
TT
130792019-03-15 Tom Tromey <tom@tromey.com>
13080
13081 * symtab.h (struct minimal_symbol): Derive from
13082 general_symbol_info.
13083 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13084 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13085 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13086 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13087 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13088 (MSYMBOL_SEARCH_NAME): Update.
13089 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13090 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13091 * minsyms.c (minimal_symbol_reader::record_full): Update.
13092
0de2420c
TT
130932019-03-15 Tom Tromey <tom@tromey.com>
13094
13095 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13096
042d75e4
TT
130972019-03-15 Tom Tromey <tom@tromey.com>
13098
13099 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13100 unique_xmalloc_ptr.
13101 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13102 Update.
13103 * minsyms.c (lookup_minimal_symbol_by_pc_section)
13104 (build_minimal_symbol_hash_tables)
13105 (minimal_symbol_reader::install): Update.
13106
db92718b
TT
131072019-03-15 Tom Tromey <tom@tromey.com>
13108
13109 * symtab.c (create_demangled_names_hash): Update.
13110 (symbol_set_names): Update.
13111 * objfiles.h (struct objfile_per_bfd_storage)
13112 <demangled_names_hash>: Now an htab_up.
13113 * objfiles.c (objfile_per_bfd_storage): Simplify.
13114
d6797f46
TT
131152019-03-15 Tom Tromey <tom@tromey.com>
13116
13117 * objfiles.h (struct objfile_per_bfd_storage): Declare
13118 destructor.
13119 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13120 New.
13121 (get_objfile_bfd_data): Use new. Don't initialize
13122 language_of_main.
13123 (free_objfile_per_bfd_storage): Remove.
13124 (objfile_bfd_data_free, objfile::~objfile): Use delete.
13125
741d7538
TT
131262019-03-15 Tom Tromey <tom@tromey.com>
13127
13128 * symfile.c (reread_symbols): Update.
13129 * objfiles.c (objfile::objfile): Update.
13130 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13131 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13132 comment.
13133 (minimal_symbol_reader::install): Update.
13134 (terminate_minimal_symbol_table): Remove.
13135 * jit.c (jit_object_close_impl): Update.
13136
788c80d1
TT
131372019-03-15 Tom Tromey <tom@tromey.com>
13138
13139 * minsyms.c (minimal_symbol_reader::record_full): Remove some
13140 initializations.
13141
1b7a07cb
TT
131422019-03-15 Tom Tromey <tom@tromey.com>
13143
13144 * objfiles.h (struct objfile_per_bfd_storage)
13145 <demangled_hash_languages>: Now a bitset.
13146 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13147 (lookup_minimal_symbol): Update.
13148
3db066bc
TT
131492019-03-15 Tom Tromey <tom@tromey.com>
13150
13151 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13152 Don't return the symbol.
13153 * coffread.c (record_minimal_symbol): Use record_full.
13154
3fff2c37
EZ
131552019-03-14 Eli Zaretskii <eliz@gnu.org>
13156
13157 The MS-Windows port of ncurses fails to switch to a color pair if
13158 one or both of the colors are the implicit default colors. This
13159 change records the default colors when TUI is initialized, and
13160 then specifies them explicitly when a color pair uses the default
13161 colors. This allows color styling in TUI mode on MS-Windows.
13162
13163 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13164 ncurses_norm_attr.
13165 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13166 colors in ncurses_norm_attr.
13167 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13168 "none", replace it with the default color recorded in
13169 ncurses_norm_attr.
13170
3b336828
TT
131712019-03-14 Tom Tromey <tromey@adacore.com>
13172
13173 * source-cache.h (class source_cache) <get_source_lines>: Return
13174 std::string.
13175 * source-cache.c (source_cache::extract_lines): Handle case where
13176 first_pos==npos. Return std::string.
13177 (source_cache::get_source_lines): Update.
13178
d085f989
TT
131792019-03-14 Tom Tromey <tromey@adacore.com>
13180
13181 * NEWS: Add item for "style sources" commands.
13182 * source-cache.c (source_cache::get_source_lines): Check
13183 source_styling.
13184 * cli/cli-style.c (source_styling): New global.
13185 (_initialize_cli_style): Add "style sources" commands.
13186 (show_style_sources): New function.
13187 * cli/cli-style.h (source_styling): Declare.
13188
6f11e682
TT
131892019-03-14 Pedro Alves <palves@redhat.com>
13190 Tom Tromey <tromey@adacore.com>
13191
13192 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13193 * tui/tui-winsource.c (tui_refill_source_window): New function,
13194 from...
13195 (tui_horizontal_source_scroll): ... here. Move some logic.
13196 * cli/cli-style.c (set_style_enabled): Notify new observable.
13197 * tui/tui-hooks.c (tui_redisplay_source): New function.
13198 (tui_attach_detach_observers): Attach or detach
13199 tui_redisplay_source.
13200 * observable.h (source_styling_changed): New observable.
13201 * observable.c: Define source_styling_changed observable.
13202
a068643d
TT
132032019-03-13 Tom Tromey <tromey@adacore.com>
13204
13205 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13206 (i386_gnu_nat_target::store_registers): Update.
13207 * target-debug.h (target_debug_print_std_string): New macro.
13208 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13209 * windows-tdep.c (display_one_tib): Update.
13210 * tui/tui-stack.c (tui_make_status_line): Update.
13211 * top.c (print_inferior_quit_action): Update.
13212 * thread.c (thr_try_catch_cmd): Update.
13213 (add_thread_with_info): Update.
13214 (thread_target_id_str): Update.
13215 (thr_try_catch_cmd): Update.
13216 (thread_command): Update.
13217 (thread_find_command): Update.
13218 * record-btrace.c (record_btrace_target::info_record)
13219 (record_btrace_resume_thread, record_btrace_target::resume)
13220 (record_btrace_cancel_resume, record_btrace_step_thread)
13221 (record_btrace_target::wait, record_btrace_target::wait)
13222 (record_btrace_target::wait, record_btrace_target::stop): Update.
13223 * progspace.c (print_program_space): Update.
13224 * process-stratum-target.c
13225 (process_stratum_target::thread_address_space): Update.
13226 * linux-fork.c (linux_fork_mourn_inferior)
13227 (detach_checkpoint_command, info_checkpoints_command)
13228 (linux_fork_context): Update.
13229 (linux_fork_detach): Update.
13230 (class scoped_switch_fork_info): Update.
13231 (delete_checkpoint_command): Update.
13232 * infrun.c (follow_fork_inferior): Update.
13233 (follow_fork_inferior): Update.
13234 (proceed_after_vfork_done): Update.
13235 (handle_vfork_child_exec_or_exit): Update.
13236 (follow_exec): Update.
13237 (displaced_step_prepare_throw): Update.
13238 (displaced_step_restore): Update.
13239 (start_step_over): Update.
13240 (resume_1): Update.
13241 (clear_proceed_status_thread): Update.
13242 (proceed): Update.
13243 (print_target_wait_results): Update.
13244 (do_target_wait): Update.
13245 (context_switch): Update.
13246 (stop_all_threads): Update.
13247 (restart_threads): Update.
13248 (finish_step_over): Update.
13249 (handle_signal_stop): Update.
13250 (switch_back_to_stepped_thread): Update.
13251 (keep_going_pass_signal): Update.
13252 (print_exited_reason): Update.
13253 (normal_stop): Update.
13254 * inferior.c (inferior_pid_to_str): Change return type.
13255 (print_selected_inferior): Update.
13256 (add_inferior): Update.
13257 (detach_inferior): Update.
13258 * dummy-frame.c (fprint_dummy_frames): Update.
13259 * dcache.c (dcache_info_1): Update.
13260 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13261 (btrace_fetch, btrace_clear): Update.
13262 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13263 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13264 type.
13265 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13266 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13267 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13268 * gdbarch.c, gdbarch.h: Rebuild.
13269 * gdbarch.sh (core_pid_to_str): Change return type.
13270 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13271 return type.
13272 (windows_nat_target::pid_to_str): Change return type.
13273 (windows_delete_thread): Update.
13274 (windows_nat_target::attach): Update.
13275 (windows_nat_target::files_info): Update.
13276 * target-delegates.c: Rebuild.
13277 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13278 return type.
13279 (sol_thread_target::pid_to_str): Change return type.
13280 * remote.c (class remote_target) <pid_to_str>: Change return
13281 type.
13282 (remote_target::pid_to_str): Change return type.
13283 (extended_remote_target::attach, remote_target::remote_stop_ns)
13284 (remote_target::remote_notif_remove_queued_reply)
13285 (remote_target::push_stop_reply, remote_target::disable_btrace):
13286 Update.
13287 (extended_remote_target::attach): Update.
13288 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13289 type.
13290 (gdbsim_target::pid_to_str): Change return type.
13291 * ravenscar-thread.c (struct ravenscar_thread_target)
13292 <pid_to_str>: Change return type.
13293 (ravenscar_thread_target::pid_to_str): Change return type.
13294 * procfs.c (class procfs_target) <pid_to_str>: Change return
13295 type.
13296 (procfs_target::pid_to_str): Change return type.
13297 (procfs_target::attach): Update.
13298 (procfs_target::detach): Update.
13299 (procfs_target::fetch_registers): Update.
13300 (procfs_target::store_registers): Update.
13301 (procfs_target::wait): Update.
13302 (procfs_target::files_info): Update.
13303 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13304 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13305 return type.
13306 (nto_procfs_target::pid_to_str): Change return type.
13307 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13308 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13309 return type.
13310 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13311 (exit_lwp): Update.
13312 (attach_proc_task_lwp_callback, get_detach_signal)
13313 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13314 (linux_nat_target::resume, wait_lwp, stop_callback)
13315 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13316 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13317 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13318 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13319 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13320 type.
13321 (inf_ptrace_target::attach): Update.
13322 (inf_ptrace_target::files_info): Update.
13323 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13324 type.
13325 (go32_nat_target::pid_to_str): Change return type.
13326 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13327 (gnu_nat_target::wait): Update.
13328 (gnu_nat_target::wait): Update.
13329 (gnu_nat_target::resume): Update.
13330 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13331 (fbsd_nat_target::wait): Update.
13332 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13333 type.
13334 (darwin_nat_target::attach): Update.
13335 * corelow.c (class core_target) <pid_to_str>: Change return type.
13336 (core_target::pid_to_str): Change return type.
13337 * target.c (normal_pid_to_str): Change return type.
13338 (default_pid_to_str): Likewise.
13339 (target_pid_to_str): Change return type.
13340 (target_translate_tls_address): Update.
13341 (target_announce_detach): Update.
13342 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13343 return type.
13344 (bsd_uthread_target::pid_to_str): Change return type.
13345 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13346 type.
13347 (bsd_kvm_target::pid_to_str): Change return type.
13348 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13349 return type.
13350 (aix_thread_target::pid_to_str): Change return type.
13351 * target.h (struct target_ops) <pid_to_str>: Change return type.
13352 (target_pid_to_str, normal_pid_to_str): Likewise.
13353 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13354 type.
13355 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13356 type.
13357 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13358 return type.
13359 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13360 type.
13361 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13362 type.
13363 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13364 return type.
13365
b4be1b06
SM
133662019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13367
13368 * NEWS: Mention that the new default MI version is 3. Mention
13369 changes to the output of commands and events that deal with
13370 multi-location breakpoints.
13371 * breakpoint.c: Include "mi/mi-out.h".
13372 (print_one_breakpoint): Change output syntax if using MI version
13373 >= 3.
13374 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13375 New.
13376 (mi_multi_location_breakpoint_output_fixed): New.
13377 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13378 (mi_cmd_fix_multi_location_breakpoint_output): New.
13379 (mi_multi_location_breakpoint_output_fixed): New.
13380 * mi/mi-cmds.c (mi_cmds): Register command
13381 -fix-multi-location-breakpoint-output.
13382 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13383 interpreter "mi".
13384
8e5e5494
SM
133852019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13386
13387 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13388 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13389 instantiate mi_ui_out based on interpreter name.
13390 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13391 * mi/mi-main.c (mi_load_progress): Likewise.
13392
197df35e
JB
133932019-03-12 John Baldwin <jhb@FreeBSD.org>
13394
13395 * NEWS: Combine separate "New targets" sections for 8.3.
13396
8399425f
JB
133972019-03-12 John Baldwin <jhb@FreeBSD.org>
13398
13399 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13400 (ppcfbsd_init_abi): Install gdbarch
13401 "fetch_tls_load_module_address" and "get_thread_local_address"
13402 methods.
13403
b0f87ed0
JB
134042019-03-12 John Baldwin <jhb@FreeBSD.org>
13405
13406 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13407 (riscv_fbsd_init_abi): Install gdbarch
13408 "fetch_tls_load_module_address" and "get_thread_local_address"
13409 methods.
13410
ce25aa57
JB
134112019-03-12 John Baldwin <jhb@FreeBSD.org>
13412
13413 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13414 (i386fbsd_init_abi): Install gdbarch
13415 "fetch_tls_load_module_address" and "get_thread_local_address"
13416 methods.
13417
f5424cfa
JB
134182019-03-12 John Baldwin <jhb@FreeBSD.org>
13419
13420 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13421 (amd64fbsd_init_abi): Install gdbarch
13422 "fetch_tls_load_module_address" and "get_thread_local_address"
13423 methods.
13424
945f3901
JB
134252019-03-12 John Baldwin <jhb@FreeBSD.org>
13426
13427 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13428 (struct fbsd_pspace_data): New type.
13429 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13430 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13431 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13432 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13433 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13434
ef0bd204
JB
134352019-03-12 John Baldwin <jhb@FreeBSD.org>
13436
13437 * gdbtypes.c (lookup_struct_elt): New function.
13438 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13439 * gdbtypes.h (struct struct_elt): New type.
13440 (lookup_struct_elt): New prototype.
13441
36c53a02
JB
134422019-03-12 John Baldwin <jhb@FreeBSD.org>
13443
13444 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13445 remove disabled code block.
13446
6e056c81
JB
134472019-03-12 John Baldwin <jhb@FreeBSD.org>
13448
13449 * gdbarch.sh (get_thread_local_address): New method.
13450 * gdbarch.h, gdbarch.c: Regenerate.
13451 * target.c (target_translate_tls_address): Use
13452 gdbarch_get_thread_local_address if present instead of
13453 target::get_thread_local_address.
13454
cd250a18
JB
134552019-03-12 John Baldwin <jhb@FreeBSD.org>
13456
13457 * target.h (target::get_thread_local_address): Update comment.
13458
df22c1e5
JB
134592019-03-12 John Baldwin <jhb@FreeBSD.org>
13460
13461 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13462 objfile->separate_debug_objfile_backlink if not NULL.
13463
dd6876c9
JB
134642019-03-12 John Baldwin <jhb@FreeBSD.org>
13465
13466 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13467 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13468 (amd64bsd_store_inferior_registers): Likewise.
13469 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13470 Enable segment base registers.
13471 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13472 PT_GETFSBASE and PT_GETGSBASE.
13473 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13474 PT_SETGSBASE.
13475 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13476 segment base registers.
13477 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13478
1163a4b7
JB
134792019-03-12 John Baldwin <jhb@FreeBSD.org>
13480
13481 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13482 Update calls to i386_target_description to add 'segments'
13483 parameter.
13484 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13485 add segment base registers.
13486 * arch/i386.c (i386_create_target_description): Add 'segments'
13487 parameter to enable segment base registers.
13488 * arch/i386.h (i386_create_target_description): Likewise.
13489 * features/i386/32bit-segments.xml: New file.
13490 * features/i386/32bit-segments.c: Generate.
13491 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13492 call to i386_target_description to add 'segments' parameter.
13493 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13494 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13495 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13496 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13497 if feature is present.
13498 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13499 Add 'segments' parameter to call to i386_target_description.
13500 (i386_target_description): Add 'segments' parameter to enable
13501 segment base registers.
13502 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13503 to call to i386_target_description.
13504 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13505 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13506 Define I386_NUM_REGS.
13507 (i386_target_description): Add 'segments' parameter to enable
13508 segment base registers.
13509
3a350822
EZ
135102019-03-12 Eli Zaretskii <eliz@gnu.org>
13511
13512 PR/24325
13513 * source-cache.c: #undef open and close, to avoid unresolved
13514 externals during linking.
13515
ffdd69cf
TT
135162019-03-12 Tom Tromey <tromey@adacore.com>
13517
13518 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13519 const. Add initializers.
13520 (_initialize_remote): Don't initialize ptid globals.
13521
ec148c57
PA
135222019-03-12 Pedro Alves <palves@redhat.com>
13523
13524 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13525
32764270
PA
135262019-03-12 Pedro Alves <palves@redhat.com>
13527
13528 * cp-name-parser.y (main): Remove unused 'len' variable.
13529
17547186
TT
135302019-03-12 Tom Tromey <tromey@adacore.com>
13531
13532 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13533 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13534
d3a70e03
TT
135352019-03-12 Tom Tromey <tromey@adacore.com>
13536
13537 * linux-nat.c (iterate_over_lwps): Update.
13538 (stop_callback): Remove parameter.
13539 (stop_wait_callback, detach_callback, resume_set_callback)
13540 (select_singlestep_lwp_callback, set_ignore_sigint)
13541 (status_callback, resumed_callback, resume_clear_callback)
13542 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13543 data parameter.
13544 (linux_nat_target::detach, linux_nat_target::resume)
13545 (linux_stop_and_wait_all_lwps, select_event_lwp)
13546 (linux_nat_filter_event, linux_nat_wait_1)
13547 (linux_nat_target::kill, linux_nat_target::stop)
13548 (linux_nat_target::stop): Update.
13549 (linux_nat_resume_callback): Change type.
13550 (resume_stopped_resumed_lwps, count_events_callback)
13551 (select_event_lwp_callback): Likewise.
13552 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13553 * arm-linux-nat.c (struct update_registers_data): Remove.
13554 (update_registers_callback): Change type.
13555 (arm_linux_insert_hw_breakpoint1): Update.
13556 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13557 parameter.
13558 (x86_linux_dr_set_addr): Update.
13559 (x86_linux_dr_set_control): Update.
13560 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13561 (iterate_over_lwps): Use gdb::function_view.
13562 * nat/aarch64-linux-hw-point.c (struct
13563 aarch64_dr_update_callback_param): Remove.
13564 (debug_reg_change_callback): Change type.
13565 (aarch64_notify_debug_reg_change): Update.
13566 * s390-linux-nat.c (s390_refresh_per_info): Update.
13567
82cb27ff
TT
135682019-03-11 Tom Tromey <tromey@adacore.com>
13569
13570 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13571 redundant assignment to "this_cu".
13572
568c0683
SM
135732019-03-08 Simon Marchi <simon.marchi@efficios.com>
13574
13575 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13576
f09ce22d
SM
135772019-03-08 Simon Marchi <simon.marchi@efficios.com>
13578
13579 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13580 from...
13581 (rank_one_type): ... this.
13582
595f96a9
SM
135832019-03-08 Simon Marchi <simon.marchi@efficios.com>
13584
13585 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13586 from...
13587 (rank_one_type): ... this.
13588
2598a94b
SM
135892019-03-08 Simon Marchi <simon.marchi@efficios.com>
13590
13591 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13592 from...
13593 (rank_one_type): ... this.
13594
7f17b20d
SM
135952019-03-08 Simon Marchi <simon.marchi@efficios.com>
13596
13597 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13598 from...
13599 (rank_one_type): ... this.
13600
2c509035
SM
136012019-03-08 Simon Marchi <simon.marchi@efficios.com>
13602
13603 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13604 from...
13605 (rank_one_type): ... this.
13606
0dd322dc
SM
136072019-03-08 Simon Marchi <simon.marchi@efficios.com>
13608
13609 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13610 from...
13611 (rank_one_type): ... this.
13612
41ea4728
SM
136132019-03-08 Simon Marchi <simon.marchi@efficios.com>
13614
13615 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13616 from...
13617 (rank_one_type): ... this.
13618
793cd1d2
SM
136192019-03-08 Simon Marchi <simon.marchi@efficios.com>
13620
13621 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13622 from...
13623 (rank_one_type): ... this.
13624
34910087
SM
136252019-03-08 Simon Marchi <simon.marchi@efficios.com>
13626
13627 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13628 from...
13629 (rank_one_type): ... this.
13630
f1f832d6
SM
136312019-03-08 Simon Marchi <simon.marchi@efficios.com>
13632
13633 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13634 from...
13635 (rank_one_type): ... this.
13636
b9f4512f
SM
136372019-03-08 Simon Marchi <simon.marchi@efficios.com>
13638
13639 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13640 from...
13641 (rank_one_type): ... this.
13642
9293fc63
SM
136432019-03-08 Simon Marchi <simon.marchi@efficios.com>
13644
13645 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13646 from...
13647 (rank_one_type): ... this.
13648
e3abbe7e
PW
136492019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13650
13651 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13652 inferior-events' shows the example events.
13653
e4adb939
EZ
136542019-03-08 Eli Zaretskii <eliz@gnu.org>
13655
13656 Support styling on native MS-Windows console
13657
13658 PR/24315
13659 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13660 on MS-Windows if $TERM is not defined.
13661
13662 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13663
13664 * posix-hdep.c (gdb_console_fputs):
13665 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13666 functions.
13667 * ui-file.h (gdb_console_fputs): Add prototype.
13668
13669 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13670 back to fputs only if the former returns zero.
13671
25629dfd
TT
136722019-03-07 Tom Tromey <tom@tromey.com>
13673
13674 * symmisc.c (print_symbol_bcache_statistics): Update.
13675 (print_objfile_statistics): Update.
13676 * symfile.c (allocate_symtab): Update.
13677 * stabsread.c: Don't include bcache.h.
13678 * psymtab.h (struct psymbol_bcache): Don't declare.
13679 (class psymtab_storage) <psymbol_cache>: Now a bcache.
13680 (psymbol_bcache_init, psymbol_bcache_free)
13681 (psymbol_bcache_get_bcache): Don't declare.
13682 * psymtab.c (struct psymbol_bcache): Remove.
13683 (psymtab_storage::psymtab_storage): Update.
13684 (psymtab_storage::~psymtab_storage): Update.
13685 (psymbol_bcache_init, psymbol_bcache_free)
13686 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13687 (add_psymbol_to_bcache): Update.
13688 (allocate_psymtab): Update.
13689 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13690 macro_cache>: No longer pointers.
13691 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13692 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13693 * macrotab.c (macro_bcache): Update.
13694 * macroexp.c: Don't include bcache.h.
13695 * gdbtypes.c (check_types_worklist): Update.
13696 (types_deeply_equal): Remove TRY/CATCH. Update.
13697 * elfread.c (elf_symtab_read): Update.
13698 * dwarf2read.c: Don't include bcache.h.
13699 * buildsym.c (buildsym_compunit::get_macro_table): Update.
13700 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13701 (print_bcache_statistics, bcache_memory_used): Don't declare.
13702 (struct bcache): Move from bcache.c. Add constructor, destructor,
13703 methods. Rename all data members.
13704 * bcache.c (struct bcache): Move to bcache.h.
13705 (bcache::expand_hash_table): Rename from expand_hash_table.
13706 (bcache): Remove.
13707 (bcache::insert): Rename from bcache_full.
13708 (bcache::compare): Rename from bcache_compare.
13709 (bcache_xmalloc): Remove.
13710 (bcache::~bcache): Rename from bcache_xfree.
13711 (bcache::print_statistics): Rename from print_bcache_statistics.
13712 (bcache::memory_used): Rename from bcache_memory_used.
13713
fe726667
PA
137142019-03-07 Pedro Alves <palves@redhat.com>
13715
13716 * infrun.c (normal_stop): Also check for
13717 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13718
7584bb30
AB
137192019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
13720
13721 * f-lang.c (value_from_host_double): Moved to...
13722 * value.c (value_from_host_double): ...here.
13723 * value.h (value_from_host_double): Declare.
13724 * guile/scm-math.c (vlscm_convert_typed_number): Use
13725 value_from_host_double.
13726 (vlscm_convert_number): Likewise.
13727 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13728 * python/py-value.c (convert_value_from_python): Likewise.
13729
a7b1986e
TT
137302019-03-06 Tom Tromey <tom@tromey.com>
13731
13732 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13733
0ccf4211
TT
137342019-03-06 Tom Tromey <tom@tromey.com>
13735
13736 * utils.h (free_current_contents): Don't declare.
13737 * utils.c (free_current_contents): Remove.
13738
fe7b42e5
TT
137392019-03-06 Tom Tromey <tom@tromey.com>
13740
13741 * top.c (quit_force): Update.
13742 * main.c (captured_command_loop): Update.
13743 * common/new-op.c (operator new): Update.
13744 * common/common-exceptions.c (struct catcher)
13745 <save_cleanup_chain>: Remove member.
13746 (exceptions_state_mc_init): Update.
13747 (exception_try_scope_entry): Return nullptr.
13748 (exception_try_scope_exit, exception_rethrow)
13749 (throw_exception_sjlj, throw_exception_cxx): Update.
13750 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13751 (all_cleanups, do_cleanups, discard_cleanups)
13752 (discard_final_cleanups, save_cleanups, save_final_cleanups)
13753 (restore_cleanups, restore_final_cleanups): Don't declare.
13754 (do_final_cleanups): Remove parameter.
13755 * common/cleanups.c (cleanup_chain, make_cleanup)
13756 (make_cleanup_dtor, all_cleanups, do_cleanups)
13757 (discard_my_cleanups, discard_cleanups)
13758 (discard_final_cleanups, save_my_cleanups, save_cleanups)
13759 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13760 (null_cleanup): Remove.
13761 (do_final_cleanups): Remove parameter.
13762
c6321f19
TT
137632019-03-06 Tom Tromey <tom@tromey.com>
13764
13765 * remote.c (remote_target::remote_parse_stop_reply): Use
13766 unique_xmalloc_ptr.
13767
61b30099
TT
137682019-03-06 Tom Tromey <tom@tromey.com>
13769
13770 * stabsread.c (struct stabs_field_info): Rename from field_info.
13771 <list, fnlist>: Add initializers.
13772 <obstack>: New member.
13773 (read_member_functions, read_struct_fields, read_baseclasses):
13774 Allocate on obstack. Don't use cleanups.
13775 (read_one_struct_field, read_member_functions, read_struct_fields)
13776 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13777 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13778 (read_struct_type): Update.
13779
6cceac94
TT
137802019-03-06 Tom Tromey <tom@tromey.com>
13781
13782 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13783 * common/filestuff.h (make_cleanup_close): Don't declare.
13784 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13785 Remove.
13786
72412762
TT
137872019-03-06 Tom Tromey <tom@tromey.com>
13788
13789 * solib-aix.c: Use make_scope_exit.
13790
2b6ff1c0
TT
137912019-03-06 Tom Tromey <tom@tromey.com>
13792
13793 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13794 Use make_scope_exit.
13795
d01c5877
TT
137962019-03-06 Tom Tromey <tom@tromey.com>
13797
13798 * solib-svr4.c (disable_probes_interface): Remove parameter.
13799 (svr4_handle_solib_event): Use make_scope_exit.
13800
32603266
TT
138012019-03-06 Tom Tromey <tom@tromey.com>
13802
13803 * remote.c (struct stop_reply_deleter): Remove.
13804 (stop_reply_up): Update.
13805 (struct stop_reply): Derive from notif_event. Don't typedef.
13806 <regcache>: Now a std::vector.
13807 (stop_reply_xfree): Remove.
13808 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13809 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
13810 (remote_target::discard_pending_stop_replies): Use delete.
13811 (remote_target::remote_parse_stop_reply): Update.
13812 (remote_target::process_stop_reply): Update.
13813 * remote-notif.h (struct notif_event): Add virtual destructor.
13814 Remove "dtr" member.
13815 (struct notif_client) <alloc_event>: Return a unique_ptr.
13816 (notif_event_xfree): Don't declare.
13817 (notif_event_up): New typedef.
13818 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13819 (notif_event_xfree, do_notif_event_xfree): Remove.
13820 (remote_notif_state_xfree): Update.
13821
9799571e
TT
138222019-03-06 Tom Tromey <tom@tromey.com>
13823
13824 * infrun.c (displaced_step_clear_cleanup): Now a
13825 forward_scope_exit type.
13826 (displaced_step_prepare_throw): Update.
13827 (displaced_step_fixup): Update.
13828
09e3c4ca
TT
138292019-03-06 Tom Tromey <tom@tromey.com>
13830
13831 * inferior.h (class inferior): Update comment.
13832 * gdbthread.h (class thread_info): Update comment.
13833
e2a03548
TT
138342019-03-06 Joel Brobecker <brobecker@adacore.com>
13835 Tom Tromey <tom@tromey.com>
13836
13837 * stabsread.h (struct stab_section_list): Remove.
13838 (coffstab_build_psymtabs): Update.
13839 * dbxread.c (symbuf_sections): Now a std::vector.
13840 (sect_idx): New global.
13841 (fill_symbuf): Update.
13842 (coffstab_build_psymtabs): Change type of stabsects parameter.
13843 Update.
13844 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13845 std::vector.
13846 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13847 (coff_locate_sections): Update.
13848 (coff_symfile_read): Remove cleanups. Update.
13849 (init_stringtab): Add storage parameter.
13850 (free_stringtab, free_stringtab_cleanup): Remove.
13851 (init_lineno): Add storage parameter.
13852 (free_linetab, free_linetab_cleanup): Remove.
13853
b7e60d85
PA
138542019-03-06 Pedro Alves <palves@redhat.com>
13855
13856 * linux-fork.c (fork_info::clobber_regs): Delete.
13857 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13858 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
13859 comment. Adjust.
13860 (scoped_switch_fork_info::scoped_switch_fork_info)
13861 (checkpoint_command, linux_fork_context): Adjust
13862 fork_save_infrun_state calls.
13863
e52c971f
PA
138642019-03-06 Pedro Alves <palves@redhat.com>
13865
13866 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13867 (inf_has_multiple_threads): Return 'bool' and rewrite using
13868 inferior_info::threads().
13869
06974e6c
PA
138702019-03-06 Pedro Alves <palves@redhat.com>
13871
13872 * linux-fork.c: Include <list>.
13873 (fork_list): Now a std::list instance.
13874 (fork_info): Add ctor, dtor, and in-class initialize all fields.
13875 (forks_exist_p, find_last_fork): Adjust.
13876 (new_fork): Delete.
13877 (one_fork_p): New.
13878 (add_fork): Adjust.
13879 (free_fork): Delete, folded into fork_info::~fork_info().
13880 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13881 Adjust.
13882 (init_fork_list): Delete.
13883 (linux_fork_killall, linux_fork_mourn_inferior)
13884 (linux_fork_detach, info_checkpoints_command): Adjust.
13885 (_initialize_linux_fork): No longer call init_fork_list.
13886
72f31aea
PA
138872019-03-06 Pedro Alves <palves@redhat.com>
13888
13889 * linux-fork.c (new_fork): New, split out of ...
13890 (add_fork): ... this. Return void. Move "first fork" special
13891 case from here, to ...
13892 (checkpoint_command): ... here.
13893 * linux-linux.h (add_fork): Return void.
13894
efbecbc1
AB
138952019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13896
13897 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13898
0841c79a
AB
138992019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13900 Chris January <chris.january@arm.com>
13901 David Lecomber <david.lecomber@arm.com>
13902
13903 * f-exp.y: New token, UNOP_INTRINSIC.
13904 (exp): New pattern using UNOP_INTRINSIC token.
13905 (f77_keywords): Add 'abs' keyword.
13906 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13907 (value_from_host_double): New function.
13908 (evaluate_subexp_f): Support UNOP_ABS.
13909
4a270568
AB
139102019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13911
13912 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13913 types.
13914
067630bd
AB
139152019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13916
13917 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13918 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13919 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13920
3be47f7a
AB
139212019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13922
13923 * f-exp.y (convert_to_kind_type): Handle more type kinds.
13924
4d00f5d8
AB
139252019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13926 Chris January <chris.january@arm.com>
13927
13928 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13929 * f-exp.y: Define 'KIND' token.
13930 (exp): New pattern for KIND expressions.
13931 (ptype): Handle types with a kind extension.
13932 (direct_abs_decl): Extend to spot kind extensions.
13933 (f77_keywords): Add 'kind' to the list.
13934 (push_kind_type): New function.
13935 (convert_to_kind_type): New function.
13936 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13937 * parse.c (operator_length_standard): Likewise.
13938 * parser-defs.h (enum type_pieces): Add tp_kind.
13939 * std-operator.def: Add UNOP_KIND.
13940
e454224f
AB
139412019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13942
13943 * f-exp.y (f_parse): Set yydebug.
13944
9dad4a58
AB
139452019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13946
13947 * f-lang.c (evaluate_subexp_f): New function.
13948 (exp_descriptor_f): New global.
13949 (f_language_defn): Use exp_descriptor_f instead of
13950 exp_descriptor_standard.
13951
c8f91604
AB
139522019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13953
13954 * f-exp.y (struct token): Add comments.
13955 (dot_ops): Remove uppercase versions and the end marker.
13956 (f77_keywords): Likewise.
13957 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13958 entries in the dot_ops array are case insensitive, and use
13959 strncasecmp to compare strings. Also some whitespace cleanup in
13960 this area. Similar for the f77_keywords array, except entries in
13961 this list might be case sensitive.
13962
dd9f2c76
AB
139632019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13964
13965 * f-exp.y (struct f77_boolean_val): Add comments.
13966 (boolean_values): Remove uppercase versions, and end marker.
13967 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13968 and use strncasecmp to achieve case insensitivity. Additionally,
13969 perform whitespace cleanup around this code.
13970
67a3048c
TT
139712019-03-06 Tom Tromey <tromey@adacore.com>
13972
13973 * remote-sim.c (gdbsim_target_open): Use result of
13974 gdb_argv::release.
13975
aa3cfbda
RB
139762019-03-06 Richard Bunt <richard.bunt@arm.com>
13977 Dirk Schubert <dirk.schubert@arm.com>
13978 Chris January <chris.january@arm.com>
13979
13980 * eval.c (evaluate_subexp_standard): Call Fortran argument
13981 wrapping logic.
13982 * f-lang.c (struct value): A value which can be passed into a
13983 Fortran function call.
13984 (fortran_argument_convert): Wrap Fortran arguments in a pointer
13985 where appropriate.
13986 (struct type): Value ready for a Fortran function call.
13987 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13988 is needed.
13989 * f-lang.h (fortran_argument_convert): Declaration.
13990 (fortran_preserve_arg_pointer): Declaration.
13991 * infcall.c (value_arg_coerce): Call Fortran argument logic.
13992
ea38e5df
TT
139932019-03-05 Tom Tromey <tromey@adacore.com>
13994
13995 * python/py-prettyprint.c (print_string_repr): Remove #if.
13996 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13997
06b5b831
TT
139982019-03-05 Tom Tromey <tromey@adacore.com>
13999
14000 * target.c (the_dummy_target): Move later. Change type to
14001 "dummy_target".
14002 (initialize_targets): Don't initialize the_dummy_target.
14003
edbd9e45
TT
140042019-03-05 Tom Tromey <tromey@adacore.com>
14005
14006 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14007 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14008
c119e040
TT
140092019-03-05 Tom Tromey <tromey@adacore.com>
14010
14011 * windows-nat.c (windows_nat_target::attach)
14012 (windows_nat_target::detach): Don't call gdb_flush.
14013 * valprint.c (generic_val_print, val_print, val_print_string):
14014 Don't call gdb_flush.
14015 * utils.c (defaulted_query): Don't call gdb_flush.
14016 * typeprint.c (print_type_scalar): Don't call gdb_flush.
14017 * target.c (target_announce_detach): Don't call gdb_flush.
14018 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14019 * remote.c (extended_remote_target::attach): Don't call
14020 gdb_flush.
14021 * procfs.c (procfs_target::detach): Don't call gdb_flush.
14022 * printcmd.c (do_examine): Don't call gdb_flush.
14023 (info_display_command): Don't call gdb_flush.
14024 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14025 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14026 * memattr.c (info_mem_command): Don't call gdb_flush.
14027 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14028 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14029 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14030 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14031 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14032 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14033 (gnu_nat_target::detach): Don't call gdb_flush.
14034 * f-valprint.c (f_val_print): Don't call gdb_flush.
14035 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14036 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14037 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14038 gdb_flush.
14039 * c-valprint.c (c_val_print): Don't call gdb_flush.
14040 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14041
895dafa6
TT
140422019-03-05 Tom Tromey <tromey@adacore.com>
14043
14044 * varobj.c (update_dynamic_varobj_children): Update.
14045 (install_default_visualizer): Use reset, not release.
14046 * value.c (set_internalvar): Update.
14047 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14048 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14049 ATTRIBUTE_UNUSED_RESULT.
14050
88a774b9
TT
140512019-03-05 Tom Tromey <tromey@adacore.com>
14052
14053 * remote.c (class scoped_remote_fd) <release>: Add
14054 ATTRIBUTE_UNUSED_RESULT.
14055
4e4a8b93
TT
140562019-03-05 Tom Tromey <tromey@adacore.com>
14057
14058 * macroexp.c (struct macro_buffer) <release>: Add
14059 ATTRIBUTE_UNUSED_RESULT.
14060
083eef1f
TT
140612019-03-05 Tom Tromey <tromey@adacore.com>
14062
14063 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14064 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14065 ATTRIBUTE_UNUSED_RESULT.
14066
3cabd438
TT
140672019-03-05 Tom Tromey <tromey@adacore.com>
14068
14069 * common/scoped_fd.h (class scoped_fd) <release>: Add
14070 ATTRIBUTE_UNUSED_RESULT.
14071
41e3300a
TT
140722019-03-05 Tom Tromey <tromey@adacore.com>
14073
14074 * parser-defs.h (struct parser_state) <release>: Add
14075 ATTRIBUTE_UNUSED_RESULT.
14076
18cb7c9f
TT
140772019-03-05 Tom Tromey <tromey@adacore.com>
14078
14079 * utils.h (class gdb_argv) <release>: Add
14080 ATTRIBUTE_UNUSED_RESULT.
14081 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14082
41fa577f
EZ
140832019-03-02 Eli Zaretskii <eliz@gnu.org>
14084
a6a4b2c6
EZ
14085 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14086 for-loop range, to avoid compiler warnings.
14087
14088 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14089 avoid compiler warnings about unused variables.
14090
742a7df5
EZ
14091 * NEWS: Mention end of support for native debugging on MS-Windows
14092 before XP.
14093
41fa577f
EZ
14094 PR gdb/24292
14095 * common/netstuff.c:
14096 * gdbserver/gdbreplay.c
14097 * gdbserver/remote-utils.c:
14098 * ser-tcp.c:
14099 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14100 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
14101 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14102 'getaddrinfo' and 'freeaddrinfo' were not available before
14103 Windows XP, and mingw.org's MinGW headers by default define
14104 _WIN32_WINNT to 0x500.
14105
827f438f
GB
141062019-03-01 Gary Benson <gbenson@redhat.com>
14107
14108 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14109
92137da0
RO
141102019-02-28 Brian Vandenberg <phantall@gmail.com>
14111 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
14112
14113 PR gdb/8527
14114 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14115 set_sigint_trap, clear_sigint_trap.
14116
799efbe8
PW
141172019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14118
14119 * target.c (target_detach): Clear the regcache and the
14120 frame cache.
14121
8ed25214
PA
141222019-02-27 Pedro Alves <palves@redhat.com>
14123
14124 * utils.c (set_screen_size): When we cap the height/width sizes,
14125 tweak the corresponding command variable to show "unlimited":
14126
23031e31
SJ
141272019-02-27 Saagar Jha <saagar@saagarjha.com>
14128 Pedro Alves <palves@redhat.com>
14129
14130 * utils.c (set_screen_size): Reduce "infinite" rows and columns
14131 before calling rl_set_screen_size.
14132
6c28e44a
TT
141332019-02-27 Tom Tromey <tromey@adacore.com>
14134
14135 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14136 define.
14137 * python/py-value.c: Remove Python 2.4 workaround.
14138 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14139 workaround.
14140 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14141 Python 2.4 workaround.
14142 * python/python-internal.h: Remove Python 2.4 comment.
14143 (Py_ssize_t): Don't define.
14144 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14145 (gdb_Py_DECREF): Remove Python 2.4 workaround.
14146 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14147 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14148 * python/python.c (do_start_initialization): Remove Python 2.4
14149 workaround.
14150 * python/py-prettyprint.c (class dummy_python_frame): Remove.
14151 (print_children): Remove Python 2.4 workaround.
14152 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14153 workaround.
14154 (CHARBUFFERPROC_NAME): Remove.
14155 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14156 Python 2.4 workaround.
14157
2c3fc25d 141582019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 14159
2c3fc25d
KB
14160 * NEWS: Note minimum Python version.
14161
6ca62222
KB
141622019-02-27 Kevin Buettner <kevinb@redhat.com>
14163
14164 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14165 code from these functions. Remove corresponding ifdefs. Use
14166 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14167 Remove gotos and target of gotos.
14168 (infpy_search_memory): Likewise.
14169
f4bc7d2c
AB
141702019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14171
14172 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14173 (hppa_gdbarch_init): Don't register deleted functions with
14174 gdbarch.
14175
9734a586
AB
141762019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14177
14178 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14179 (h8300_unwind_sp): Delete.
14180 (h8300_dummy_id): Delete.
14181 (h8300_gdbarch_init): Don't register deleted functions with
14182 gdbarch.
14183
68b867f3
AB
141842019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14185
14186 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14187 (ft32_unwind_pc): Delete.
14188 (ft32_unwind_sp): Delete.
14189 (ft32_gdbarch_init): Don't register deleted functions with
14190 gdbarch.
14191
2fbe7ad0
AB
141922019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14193
14194 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14195 (frv_unwind_pc): Delete.
14196 (frv_unwind_sp): Delete.
14197 (frv_gdbarch_init): Don't register deleted functions with
14198 gdbarch.
14199
76055cbe
AB
142002019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14201
14202 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14203 (riscv_unwind_pc): Delete.
14204 (riscv_unwind_sp): Delete.
14205 (riscv_gdbarch_init): Don't register deleted functions with
14206 gdbarch.
14207
4133e5a1
AB
142082019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14209
14210 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14211 (csky_unwind_pc): Delete.
14212 (csky_unwind_sp): Delete.
14213 (csky_gdbarch_init): Don't register deleted functions with
14214 gdbarch.
14215
8010f576
AB
142162019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14217
14218 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14219 (cris_unwind_pc): Delete.
14220 (cris_unwind_sp): Delete.
14221 (cris_gdbarch_init): Don't register deleted functions with
14222 gdbarch.
14223
b56bf084
AB
142242019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14225
14226 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14227 (bfin_unwind_pc): Delete.
14228 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14229
a19a650f
AB
142302019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14231
14232 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14233 (arm_unwind_pc): Delete.
14234 (arm_unwind_sp): Delete.
14235 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14236
f8278c3c
AB
142372019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14238
14239 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14240 (arc_unwind_pc): Delete.
14241 (arc_unwind_sp): Delete.
14242 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14243
480e46cf
AB
142442019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14245
14246 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14247 (alpha_unwind_pc): Delete.
14248 (alpha_gdbarch_init): Don't register deleted functions with
14249 gdbarch.
14250
7a995095
AB
142512019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14252
14253 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14254 (aarch64_unwind_pc): Delete.
14255 (aarch64_unwind_sp): Delete.
14256 (aarch64_gdbarch_init): Don't register deleted functions with
14257 gdbarch.
14258
bf9a735e
AB
142592019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14260
14261 * gdbtypes.c (type_align): Don't consider static members when
14262 computing structure alignment.
14263
5561fc30
AB
142642019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14265
14266 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14267 return 0 for other types.
14268 * arch-utils.c (default_type_align): Always return 0.
14269 * gdbarch.h: Regenerate.
14270 * gdbarch.sh (type_align): Extend comment.
14271 * gdbtypes.c (type_align): Add additional comments, always call
14272 gdbarch_type_align before applying the default rules.
14273 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14274 generic code will then apply a suitable default.
14275 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14276 types, return 0 for other types.
14277
9335e75a
JB
142782019-02-27 Joel Brobecker <brobecker@adacore.com>
14279
14280 * NEWS: Create a new section for the next release branch.
14281 Rename the section of the current branch, now that it has
14282 been cut.
14283
3d34d8de
JB
142842019-02-27 Joel Brobecker <brobecker@adacore.com>
14285
14286 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14287 * version.in: Bump version to 8.3.50.DATE-git.
14288
143420fb
SM
142892019-02-26 Simon Marchi <simon.marchi@efficios.com>
14290
14291 * aix-thread.c (ptid_cmp): Remove unused variable.
14292 (get_signaled_thread): Likewise.
14293 (store_regs_user_thread): Likewise.
14294 (store_regs_kernel_thread): Likewise.
14295 (fetch_regs_kernel_thread): Remove shadowed variable.
14296
172fb711
AB
142972019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14298
14299 * features/riscv/32bit-cpu.xml: Add register numbers.
14300 * features/riscv/32bit-fpu.c: Regenerate.
14301 * features/riscv/32bit-fpu.xml: Add register numbers.
14302 * features/riscv/64bit-cpu.xml: Add register numbers.
14303 * features/riscv/64bit-fpu.c: Regenerate.
14304 * features/riscv/64bit-fpu.xml: Add register numbers.
14305
26c89782
KB
143062019-02-26 Kevin Buettner <kevinb@redhat.com>
14307
af54ade9 14308 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
14309 * python/py-value.c (convert_buffer_and_type_to_value): New
14310 function.
14311 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14312 Add support for handling an optional second argument. Call
14313 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
14314 * python/python-internal.h (Py_buffer_deleter): New struct.
14315 (Py_buffer_up): New typedef.
14316
0f58c9e8
JB
143172019-02-25 John Baldwin <jhb@FreeBSD.org>
14318
14319 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14320 instead of releasing ownership.
14321
0a0f4c01
JR
143222019-02-25 Jordan Rupprecht <rupprecht@google.com>
14323
14324 * dwarf2read.c (open_and_init_dwp_file): Call
14325 elf_numsections instead of bfd_count_sections to initialize
14326 dwp_file->num_sections.
14327
cd5a152c
TT
143282019-02-25 Tom Tromey <tromey@adacore.com>
14329
14330 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14331
8a6a8513
SDJ
143322019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14333
14334 * gcore.in: Add '--readnever' option when invoking GDB.
14335
04dcda9c
SM
143362019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14337
14338 * MAINTAINERS: Update my email address.
14339
07bc701d
SM
143402019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14341
14342 * build-id.c (build_id_to_debug_bfd_1): New function.
14343 (build_id_to_debug_bfd): Look for separate debug file in
14344 sysroot.
14345
c6f4a5d0
AB
143462019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14347
14348 * gdbarch.sh: Update the copyright year range that is placed into
14349 generated files.
14350
9600246d
KS
143512019-02-22 Keith Seitz <keiths@redhat.com>
14352
14353 PR symtab/23853
14354 * linespec.c (create_sals_line_offset): Search for the default
14355 symtab's filename instead of its fullname.
14356
7557a514
AH
143572019-02-21 Alan Hayward <alan.hayward@arm.com>
14358
14359 * NEWS: Update style defaults.
14360
ee2bcb0c
AH
143612019-02-21 Alan Hayward <alan.hayward@arm.com>
14362
14363 * main.c (captured_main_1): Disable styling in batch mode.
14364
0c95f9ed
TT
143652019-02-20 Tom Tromey <tom@tromey.com>
14366
14367 * symtab.c (symtab_symbol_info): Fix typos.
14368
c763b894
TT
143692019-02-20 Tom Tromey <tromey@adacore.com>
14370
14371 * findcmd.c (_initialize_mem_search): Use upper case for
14372 metasyntactic variables.
14373
0ef8a082
AH
143742019-02-20 Alan Hayward <alan.hayward@arm.com>
14375
14376 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14377 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14378
6caa91b6
SM
143792019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14380
14381 * top.h (source_file_name): Change to std::string.
14382 * top.c (source_file_name): Likewise.
14383 (command_line_input): Adjust.
14384 * cli/cli-script.c (script_from_file): Adjust.
14385
98814c6c
TT
143862019-02-19 Tom Tromey <tromey@adacore.com>
14387
14388 * ravenscar-thread.c
14389 (ravenscar_thread_target::update_thread_list): Don't call
14390 ada_build_task_list.
14391 * ada-lang.h (ada_build_task_list): Don't declare.
14392 * ada-tasks.c (struct ada_tasks_inferior_data)
14393 <task_list_valid_p>: Now bool.
14394 (read_known_tasks, ada_task_list_changed)
14395 (ada_tasks_invalidate_inferior_data): Update.
14396 (read_known_tasks_array): Return bool.
14397 (read_known_tasks_list): Likewise.
14398 (read_known_tasks): Return void.
14399 (ada_build_task_list): Now static.
14400
70cd633e
AB
144012019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14402
14403 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14404 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14405
040b3e95
PW
144062019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14407
14408 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14409 variant for ada_tasks_pspace_data_handle and
14410 ada_tasks_inferior_data_handle.
14411 (ada_tasks_pspace_data_cleanup): New function.
14412 (ada_tasks_inferior_data_cleanup): New function.
14413
9409233b
TT
144142019-02-17 Tom Tromey <tom@tromey.com>
14415
14416 * macrotab.h (macro_source_fullname): Return a std::string.
14417 * macrotab.c (macro_include, check_for_redefinition)
14418 (macro_undef, macro_lookup_definition, foreach_macro)
14419 (foreach_macro_in_scope): Update.
14420 (macro_source_fullname): Return a std::string.
14421 * macrocmd.c (show_pp_source_pos): Update.
14422
6506371f
TT
144232019-02-17 Tom Tromey <tom@tromey.com>
14424
14425 * macrocmd.c (show_pp_source_pos): Style the file names.
14426
0c820d67
TT
144272019-02-17 Tom Tromey <tom@tromey.com>
14428
14429 PR tui/24197:
14430 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14431
a0087920
TT
144322019-02-17 Tom Tromey <tom@tromey.com>
14433
14434 * ada-lang.c (user_select_syms): Use filtered printing.
14435 * utils.c (wrap_style): New global.
14436 (desired_style): Remove.
14437 (emit_style_escape): Add stream parameter.
14438 (set_output_style, reset_terminal_style, prompt_for_continue):
14439 Update.
14440 (flush_wrap_buffer): Only flush gdb_stdout.
14441 (wrap_here): Set wrap_style.
14442 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14443 treat escape sequences as a character. Change when wrap buffer is
14444 flushed.
14445 (fputs_styled): Do not set the output style when the default is
14446 requested.
14447 * ui-style.h (struct ui_file_style) <is_default>: New method.
14448 * source.c (print_source_lines_base): Emit escape sequences in one
14449 piece.
14450
75ba10dc
JB
144512019-02-17 Joel Brobecker <brobecker@adacore.com>
14452
14453 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14454 integers and enumeration types.
14455
a2cd4f14
JB
144562019-02-17 Joel Brobecker <brobecker@adacore.com>
14457
14458 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14459 instead of lookup_symbol_in_language
14460 (do_exact_match): New function.
14461 (ada_get_symbol_name_matcher): Return do_exact_match when
14462 doing a verbatim match.
14463
485b851b
TT
144642019-02-15 Tom Tromey <tromey@adacore.com>
14465
14466 * ravenscar-thread.c (ravenscar_thread_target::resume)
14467 (ravenscar_thread_target::wait): Special case wildcard requests.
14468
0b790b1e
TT
144692019-02-15 Tom Tromey <tromey@adacore.com>
14470
14471 * ravenscar-thread.c (base_ptid): Remove.
14472 (struct ravenscar_thread_target) <close>: New method.
14473 <m_base_ptid>: New member.
14474 <update_inferior_ptid, active_task, task_is_currently_active,
14475 runtime_initialized>: Declare methods.
14476 <ravenscar_thread_target>: Add constructor.
14477 (ravenscar_thread_target::task_is_currently_active)
14478 (ravenscar_thread_target::update_inferior_ptid)
14479 (ravenscar_runtime_initialized): Rename. Now methods.
14480 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14481 (ravenscar_thread_target::update_thread_list): Update.
14482 (ravenscar_thread_target::active_task): Now method.
14483 (ravenscar_thread_target::store_registers)
14484 (ravenscar_thread_target::prepare_to_store)
14485 (ravenscar_thread_target::prepare_to_store)
14486 (ravenscar_thread_target::mourn_inferior): Update.
14487 (ravenscar_inferior_created): Use "new" to create target.
14488 (ravenscar_thread_target::get_ada_task_ptid): Update.
14489 (_initialize_ravenscar): Don't initialize base_ptid.
14490 (ravenscar_ops): Remove global.
14491
dea57a62
TT
144922019-02-15 Tom Tromey <tromey@adacore.com>
14493
14494 * target.h (push_target): Declare new overload.
14495 * target.c (push_target): New overload, taking an rvalue reference.
14496 * remote.c (remote_target::open_1): Use push_target overload.
14497 * corelow.c (core_target_open): Use push_target overload.
14498
989f3c58
TT
144992019-02-15 Tom Tromey <tromey@adacore.com>
14500
14501 * ravenscar-thread.c (is_ravenscar_task)
14502 (ravenscar_task_is_currently_active): Return bool.
14503 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14504 (_initialize_ravenscar): Remove "(void)".
14505 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14506 Return bool.
14507
6cbcc006
TT
145082019-02-15 Tom Tromey <tromey@adacore.com>
14509
14510 * ravenscar-thread.c (ravenscar_runtime_initializer)
14511 (has_ravenscar_runtime, get_running_thread_id)
14512 (ravenscar_thread_target::resume): Fix indentation.
14513
7657f14d
TT
145142019-02-15 Tom Tromey <tromey@adacore.com>
14515
14516 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14517 from ravenscar_arch_ops.
14518 (sparc_ravenscar_ops::fetch_registers)
14519 (sparc_ravenscar_ops::store_registers): Now methods.
14520 (sparc_ravenscar_prepare_to_store): Remove.
14521 (sparc_ravenscar_ops): Redefine.
14522 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14523 methods and destructor. Remove members.
14524 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14525 (ravenscar_thread_target::store_registers)
14526 (ravenscar_thread_target::prepare_to_store): Update.
14527 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14528 Remove.
14529 (struct ppc_ravenscar_powerpc_ops): Derive from
14530 ravenscar_arch_ops.
14531 (ppc_ravenscar_powerpc_ops::fetch_registers)
14532 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14533 (ppc_ravenscar_powerpc_ops): Redefine.
14534 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14535 (ppc_ravenscar_e500_ops::fetch_registers)
14536 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14537 (ppc_ravenscar_e500_ops): Redefine.
14538 * aarch64-ravenscar-thread.c
14539 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14540 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14541 (aarch64_ravenscar_fetch_registers)
14542 (aarch64_ravenscar_store_registers): Now methods.
14543 (aarch64_ravenscar_ops): Redefine.
14544
5b6ea500
TT
145452019-02-15 Tom Tromey <tromey@adacore.com>
14546
14547 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14548 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14549 (ravenscar_thread_target::stopped_by_watchpoint)
14550 (ravenscar_thread_target::stopped_data_address)
14551 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14552
e397fd39
TT
145532019-02-15 Tom Tromey <tromey@adacore.com>
14554
14555 * ravenscar-thread.c: Fix some typos.
14556
cc12f4a8
TT
145572019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14558 Tom Tromey <tromey@adacore.com>
14559
14560 * ada-lang.c (ada_exception_sal): Change addr_string to a
14561 std::string.
14562 (create_ada_exception_catchpoint): Update.
14563
5f486660
TT
145642019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14565 Tom Tromey <tromey@adacore.com>
14566
14567 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14568 (bp_location_ops): Remove.
14569 (base_breakpoint_allocate_location): Update.
14570 (free_bp_location): Update.
14571 * ada-lang.c (class ada_catchpoint_location)
14572 <ada_catchpoint_location>: Remove ops parameter.
14573 (ada_catchpoint_location_dtor): Remove.
14574 (ada_catchpoint_location_ops): Remove.
14575 (allocate_location_exception): Update.
14576 * breakpoint.h (struct bp_location_ops): Remove.
14577 (class bp_location) <bp_location>: Remove bp_location_ops
14578 parameter.
14579 <~bp_location>: Add destructor.
14580 <ops>: Remove.
14581
b671c7fb
TS
145822019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14583 Pedro Alves <palves@redhat.com>
14584
14585 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14586 'PATH_MAX'.
14587
8071c5ce
DM
145882019-02-14 David Michael <fedora.dm0@gmail.com>
14589 Samuel Thibault <samuel.thibault@gnu.org>
14590 Thomas Schwinge <thomas@codesourcery.com>
14591
14592 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14593 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14594
b1041ae0
TS
145952019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14596
924514e1
TS
14597 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14598 (check_empty): Use "const char *".
14599
c29ee8d4
TS
14600 * gnu-nat.c (gnu_nat_target::detach): Instead of
14601 'detach_inferior (pid)' call
14602 'detach_inferior (find_inferior_pid (pid))'.
14603
6c6ef69f
TS
14604 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14605 'nat/fork-inferior.o'.
14606 * gnu-nat.c: #include "nat/fork-inferior.h".
14607
2d0a338c
TS
14608 * gnu-nat.c (gnu_nat_target::detach): Instead of
14609 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14610 * gnu-nat.h: #include "inf-child.h".
14611 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14612 'i386_gnu_nat_target::fetch_registers'.
14613 (gnu_store_registers): Rename/move to
14614 'i386_gnu_nat_target::store_registers'.
14615
cabb5f06
TS
14616 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14617 * gnu-nat.h (mach_thread_info): New function.
14618 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14619
b1041ae0
TS
14620 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14621
2988d01e
KF
146222019-02-14 Frederic Konrad <konrad@adacore.com>
14623
14624 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14625
c559d709
JB
146262019-02-14 Joel Brobecker <brobecker@adacore.com>
14627
14628 * windows-nat.c (windows_add_thread): Add new parameter
14629 "main_thread_p" with default value set to false. Update
14630 function documentation as well as all callers.
14631 (windows_delete_thread): Likewise.
14632 (fake_create_process): Update call to windows_add_thread.
14633 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14634 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14635 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14636 call to windows_delete_thread.
14637
007024cc
SM
146382019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14639
14640 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14641
f62318e9
JB
146422019-02-12 John Baldwin <jhb@FreeBSD.org>
14643
14644 * symfile.c (find_separate_debug_file): Use canonical path of
14645 sysroot with child_path instead of gdb_sysroot if it is valid.
14646
cd4b7848
JB
146472019-02-12 John Baldwin <jhb@FreeBSD.org>
14648
14649 * symfile.c (find_separate_debug_file): Use child_path to
14650 determine if an object file is under a sysroot.
14651
efac4bfe
JB
146522019-02-12 John Baldwin <jhb@FreeBSD.org>
14653
14654 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14655 unittests/child-path-selftests.c.
14656 * common/pathstuff.c (child_path): New function.
14657 * common/pathstuff.h (child_path): New prototype.
14658 * unittests/child-path-selftests.c: New file.
14659
402d2bfe
JB
146602019-02-12 John Baldwin <jhb@FreeBSD.org>
14661
14662 * symfile.c (find_separate_debug_file): Look for separate debug
14663 files in debug directories under the sysroot.
14664
1ed9f74e
PW
146652019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14666
14667 * symtab.h (struct minimal_symbol data_p): New const method.
14668 (struct minimal_symbol text_p): Likewise.
14669 * symtab.c (output_source_filename): Use file name style
14670 to print file name.
14671 (print_symbol_info): Likewise.
14672 (print_msymbol_info): Use address style to print addresses.
14673 Use function name style to print executable text symbols.
14674 (expand_symtab_containing_pc): Use data_p.
14675 (find_pc_sect_compunit_symtab): Likewise.
14676
2636d81d
PW
146772019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14678
14679 * breakpoint.c (describe_other_breakpoints): Use address style
14680 to print addresses.
14681 (say_where): Likewise.
14682
ac8c53cc
PW
146832019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14684
14685 * ada-typeprint.c (print_func_type): Print function name
14686 style to print function name.
14687 * c-typeprint.c (c_print_type_1): Likewise.
14688
ea638c43
AH
146892019-02-11 Alan Hayward <alan.hayward@arm.com>
14690
14691 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14692 for execve.
14693
ab759ca8
PW
146942019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14695
14696 * c-exp.y (direct_abs_decl): Use emplace_back to record the
14697 type_stack.
14698
aff29d1c
JB
146992019-02-10 Joel Brobecker <brobecker@adacore.com>
14700
14701 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14702 TYPE_CODE_REF types.
14703
617126bc
JW
147042019-02-08 Jim Wilson <jimw@sifive.com>
14705
14706 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14707 (riscv_linux_fregset): New.
14708 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14709
46e3ed7f
TT
147102019-02-07 Tom Tromey <tom@tromey.com>
14711
14712 * thread.c (thread_cancel_execution_command): Update.
14713 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14714 methods.
14715 (struct thread_fsm_ops): Remove.
14716 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14717 (thread_fsm_should_stop, thread_fsm_return_value)
14718 (thread_fsm_set_finished, thread_fsm_finished_p)
14719 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14720 Don't declare.
14721 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14722 * infrun.c (clear_proceed_status_thread)
14723 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14724 (print_stop_event): Update.
14725 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14726 Add constructor.
14727 (step_command_fsm_ops): Remove.
14728 (new_step_command_fsm): Remove.
14729 (step_1): Update.
14730 (step_command_fsm::should_stop): Rename from
14731 step_command_fsm_should_stop.
14732 (step_command_fsm::clean_up): Rename from
14733 step_command_fsm_clean_up.
14734 (step_command_fsm::do_async_reply_reason): Rename from
14735 step_command_fsm_async_reply_reason.
14736 (struct until_next_fsm): Inherit from thread_fsm. Add
14737 constructor.
14738 (until_next_fsm_ops): Remove.
14739 (new_until_next_fsm): Remove.
14740 (until_next_fsm::should_stop): Rename from
14741 until_next_fsm_should_stop.
14742 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14743 (until_next_fsm::do_async_reply_reason): Rename from
14744 until_next_fsm_async_reply_reason.
14745 (struct finish_command_fsm): Inherit from thread_fsm. Add
14746 constructor. Change type of breakpoint.
14747 (finish_command_fsm_ops): Remove.
14748 (new_finish_command_fsm): Remove.
14749 (finish_command_fsm::should_stop): Rename from
14750 finish_command_fsm_should_stop.
14751 (finish_command_fsm::clean_up): Rename from
14752 finish_command_fsm_clean_up.
14753 (finish_command_fsm::return_value): Rename from
14754 finish_command_fsm_return_value.
14755 (finish_command_fsm::do_async_reply_reason): Rename from
14756 finish_command_fsm_async_reply_reason.
14757 (finish_command): Update.
14758 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14759 Add constructor.
14760 (call_thread_fsm_ops): Remove.
14761 (call_thread_fsm::call_thread_fsm): Rename from
14762 new_call_thread_fsm.
14763 (call_thread_fsm::should_stop): Rename from
14764 call_thread_fsm_should_stop.
14765 (call_thread_fsm::should_notify_stop): Rename from
14766 call_thread_fsm_should_notify_stop.
14767 (run_inferior_call, call_function_by_hand_dummy): Update.
14768 * cli/cli-interp.c (should_print_stop_to_console): Update.
14769 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14770 Add constructor. Change type of location_breakpoint,
14771 caller_breakpoint.
14772 (until_break_fsm_ops): Remove.
14773 (new_until_break_fsm): Remove.
14774 (until_break_fsm::should_stop): Rename from
14775 until_break_fsm_should_stop.
14776 (until_break_fsm::clean_up): Rename from
14777 until_break_fsm_clean_up.
14778 (until_break_fsm::do_async_reply_reason): Rename from
14779 until_break_fsm_async_reply_reason.
14780 (until_break_command): Update.
14781 * thread-fsm.c: Remove.
14782 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14783
1a5c2598
TT
147842019-02-07 Tom Tromey <tom@tromey.com>
14785
14786 * yy-remap.h: Add include guard.
14787 * xtensa-tdep.h: Add include guard.
14788 * xcoffread.h: Rename include guard.
14789 * varobj-iter.h: Add include guard.
14790 * tui/tui.h: Rename include guard.
14791 * tui/tui-winsource.h: Rename include guard.
14792 * tui/tui-wingeneral.h: Rename include guard.
14793 * tui/tui-windata.h: Rename include guard.
14794 * tui/tui-win.h: Rename include guard.
14795 * tui/tui-stack.h: Rename include guard.
14796 * tui/tui-source.h: Rename include guard.
14797 * tui/tui-regs.h: Rename include guard.
14798 * tui/tui-out.h: Rename include guard.
14799 * tui/tui-layout.h: Rename include guard.
14800 * tui/tui-io.h: Rename include guard.
14801 * tui/tui-hooks.h: Rename include guard.
14802 * tui/tui-file.h: Rename include guard.
14803 * tui/tui-disasm.h: Rename include guard.
14804 * tui/tui-data.h: Rename include guard.
14805 * tui/tui-command.h: Rename include guard.
14806 * tic6x-tdep.h: Add include guard.
14807 * target/waitstatus.h: Rename include guard.
14808 * target/wait.h: Rename include guard.
14809 * target/target.h: Rename include guard.
14810 * target/resume.h: Rename include guard.
14811 * target-float.h: Rename include guard.
14812 * stabsread.h: Add include guard.
14813 * rs6000-tdep.h: Add include guard.
14814 * riscv-fbsd-tdep.h: Add include guard.
14815 * regformats/regdef.h: Rename include guard.
14816 * record.h: Rename include guard.
14817 * python/python.h: Rename include guard.
14818 * python/python-internal.h: Rename include guard.
14819 * python/py-stopevent.h: Rename include guard.
14820 * python/py-ref.h: Rename include guard.
14821 * python/py-record.h: Rename include guard.
14822 * python/py-record-full.h: Rename include guard.
14823 * python/py-record-btrace.h: Rename include guard.
14824 * python/py-instruction.h: Rename include guard.
14825 * python/py-events.h: Rename include guard.
14826 * python/py-event.h: Rename include guard.
14827 * procfs.h: Add include guard.
14828 * proc-utils.h: Add include guard.
14829 * p-lang.h: Add include guard.
14830 * or1k-tdep.h: Rename include guard.
14831 * observable.h: Rename include guard.
14832 * nto-tdep.h: Rename include guard.
14833 * nat/x86-linux.h: Rename include guard.
14834 * nat/x86-linux-dregs.h: Rename include guard.
14835 * nat/x86-gcc-cpuid.h: Add include guard.
14836 * nat/x86-dregs.h: Rename include guard.
14837 * nat/x86-cpuid.h: Rename include guard.
14838 * nat/ppc-linux.h: Rename include guard.
14839 * nat/mips-linux-watch.h: Rename include guard.
14840 * nat/linux-waitpid.h: Rename include guard.
14841 * nat/linux-ptrace.h: Rename include guard.
14842 * nat/linux-procfs.h: Rename include guard.
14843 * nat/linux-osdata.h: Rename include guard.
14844 * nat/linux-nat.h: Rename include guard.
14845 * nat/linux-namespaces.h: Rename include guard.
14846 * nat/linux-btrace.h: Rename include guard.
14847 * nat/glibc_thread_db.h: Rename include guard.
14848 * nat/gdb_thread_db.h: Rename include guard.
14849 * nat/gdb_ptrace.h: Rename include guard.
14850 * nat/fork-inferior.h: Rename include guard.
14851 * nat/amd64-linux-siginfo.h: Rename include guard.
14852 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14853 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14854 * nat/aarch64-linux.h: Rename include guard.
14855 * nat/aarch64-linux-hw-point.h: Rename include guard.
14856 * mn10300-tdep.h: Add include guard.
14857 * mips-linux-tdep.h: Add include guard.
14858 * mi/mi-parse.h: Rename include guard.
14859 * mi/mi-out.h: Rename include guard.
14860 * mi/mi-main.h: Rename include guard.
14861 * mi/mi-interp.h: Rename include guard.
14862 * mi/mi-getopt.h: Rename include guard.
14863 * mi/mi-console.h: Rename include guard.
14864 * mi/mi-common.h: Rename include guard.
14865 * mi/mi-cmds.h: Rename include guard.
14866 * mi/mi-cmd-break.h: Rename include guard.
14867 * m2-lang.h: Add include guard.
14868 * location.h: Rename include guard.
14869 * linux-record.h: Rename include guard.
14870 * linux-nat.h: Add include guard.
14871 * linux-fork.h: Add include guard.
14872 * i386-darwin-tdep.h: Rename include guard.
14873 * hppa-linux-offsets.h: Add include guard.
14874 * guile/guile.h: Rename include guard.
14875 * guile/guile-internal.h: Rename include guard.
14876 * gnu-nat.h: Rename include guard.
14877 * gdb-stabs.h: Rename include guard.
14878 * frv-tdep.h: Add include guard.
14879 * f-lang.h: Add include guard.
14880 * event-loop.h: Add include guard.
14881 * darwin-nat.h: Rename include guard.
14882 * cp-abi.h: Rename include guard.
14883 * config/sparc/nm-sol2.h: Rename include guard.
14884 * config/nm-nto.h: Rename include guard.
14885 * config/nm-linux.h: Add include guard.
14886 * config/i386/nm-i386gnu.h: Rename include guard.
14887 * config/djgpp/nl_types.h: Rename include guard.
14888 * config/djgpp/langinfo.h: Rename include guard.
14889 * compile/gcc-cp-plugin.h: Add include guard.
14890 * compile/gcc-c-plugin.h: Add include guard.
14891 * compile/compile.h: Rename include guard.
14892 * compile/compile-object-run.h: Rename include guard.
14893 * compile/compile-object-load.h: Rename include guard.
14894 * compile/compile-internal.h: Rename include guard.
14895 * compile/compile-cplus.h: Rename include guard.
14896 * compile/compile-c.h: Rename include guard.
14897 * common/xml-utils.h: Rename include guard.
14898 * common/x86-xstate.h: Rename include guard.
14899 * common/version.h: Rename include guard.
14900 * common/vec.h: Rename include guard.
14901 * common/tdesc.h: Rename include guard.
14902 * common/selftest.h: Rename include guard.
14903 * common/scoped_restore.h: Rename include guard.
14904 * common/scoped_mmap.h: Rename include guard.
14905 * common/scoped_fd.h: Rename include guard.
14906 * common/safe-iterator.h: Rename include guard.
14907 * common/run-time-clock.h: Rename include guard.
14908 * common/refcounted-object.h: Rename include guard.
14909 * common/queue.h: Rename include guard.
14910 * common/ptid.h: Rename include guard.
14911 * common/print-utils.h: Rename include guard.
14912 * common/preprocessor.h: Rename include guard.
14913 * common/pathstuff.h: Rename include guard.
14914 * common/observable.h: Rename include guard.
14915 * common/netstuff.h: Rename include guard.
14916 * common/job-control.h: Rename include guard.
14917 * common/host-defs.h: Rename include guard.
14918 * common/gdb_wait.h: Rename include guard.
14919 * common/gdb_vecs.h: Rename include guard.
14920 * common/gdb_unlinker.h: Rename include guard.
14921 * common/gdb_unique_ptr.h: Rename include guard.
14922 * common/gdb_tilde_expand.h: Rename include guard.
14923 * common/gdb_sys_time.h: Rename include guard.
14924 * common/gdb_string_view.h: Rename include guard.
14925 * common/gdb_splay_tree.h: Rename include guard.
14926 * common/gdb_setjmp.h: Rename include guard.
14927 * common/gdb_ref_ptr.h: Rename include guard.
14928 * common/gdb_optional.h: Rename include guard.
14929 * common/gdb_locale.h: Rename include guard.
14930 * common/gdb_assert.h: Rename include guard.
14931 * common/filtered-iterator.h: Rename include guard.
14932 * common/filestuff.h: Rename include guard.
14933 * common/fileio.h: Rename include guard.
14934 * common/environ.h: Rename include guard.
14935 * common/common-utils.h: Rename include guard.
14936 * common/common-types.h: Rename include guard.
14937 * common/common-regcache.h: Rename include guard.
14938 * common/common-inferior.h: Rename include guard.
14939 * common/common-gdbthread.h: Rename include guard.
14940 * common/common-exceptions.h: Rename include guard.
14941 * common/common-defs.h: Rename include guard.
14942 * common/common-debug.h: Rename include guard.
14943 * common/cleanups.h: Rename include guard.
14944 * common/buffer.h: Rename include guard.
14945 * common/btrace-common.h: Rename include guard.
14946 * common/break-common.h: Rename include guard.
14947 * cli/cli-utils.h: Rename include guard.
14948 * cli/cli-style.h: Rename include guard.
14949 * cli/cli-setshow.h: Rename include guard.
14950 * cli/cli-script.h: Rename include guard.
14951 * cli/cli-interp.h: Rename include guard.
14952 * cli/cli-decode.h: Rename include guard.
14953 * cli/cli-cmds.h: Rename include guard.
14954 * charset-list.h: Add include guard.
14955 * buildsym-legacy.h: Rename include guard.
14956 * bfin-tdep.h: Add include guard.
14957 * ax.h: Rename include guard.
14958 * arm-linux-tdep.h: Add include guard.
14959 * arm-fbsd-tdep.h: Add include guard.
14960 * arch/xtensa.h: Rename include guard.
14961 * arch/tic6x.h: Add include guard.
14962 * arch/i386.h: Add include guard.
14963 * arch/arm.h: Rename include guard.
14964 * arch/arm-linux.h: Rename include guard.
14965 * arch/arm-get-next-pcs.h: Rename include guard.
14966 * arch/amd64.h: Add include guard.
14967 * arch/aarch64-insn.h: Rename include guard.
14968 * arch-utils.h: Rename include guard.
14969 * annotate.h: Add include guard.
14970 * amd64-darwin-tdep.h: Rename include guard.
14971 * aarch64-linux-tdep.h: Add include guard.
14972 * aarch64-fbsd-tdep.h: Add include guard.
14973 * aarch32-linux-nat.h: Add include guard.
14974
ab9268d2
PW
149752019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14976
14977 * macrotab.c (macro_define_internal): New function that
14978 factorizes macro_define_object_internal and macro_define_function
14979 code.
14980 (macro_define_object_internal): Use macro_define_internal.
14981 (macro_define_function): Likewise.
14982
bb0da2b4
PW
149832019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14984
14985 * macrocmd.c (extract_identifier): Return
14986 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14987 callers.
14988
424eb552
JB
149892019-02-06 John Baldwin <jhb@FreeBSD.org>
14990
14991 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14992
1688cb29
TT
149932019-02-05 Tom Tromey <tom@tromey.com>
14994
14995 * target.c (target_stack::unpush): Move assertion earlier.
14996
b5eba2d8
TT
149972019-01-30 Tom Tromey <tom@tromey.com>
14998
14999 PR python/23615:
15000 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15001 (gdbpy_parse_and_eval): Likewise.
15002 * python/python-internal.h (gdbpy_allow_threads): New class.
15003
7054e2ff
JB
150042019-01-28 John Baldwin <jhb@FreeBSD.org>
15005
15006 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15007 (aarch64_fbsd_fpregmap): Move earlier.
15008 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15009 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15010 instead of individual calls to trad_frame_set_reg_addr.
15011 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15012 earlier.
15013 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15014 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15015 instead of individual calls to trad_frame_set_reg_addr.
15016
36c25ffa
AH
150172019-01-28 Alan Hayward <alan.hayward@arm.com>
15018
15019 * CONTRIBUTE: Replace contribution list with wiki link.
15020
a0707f3c
TT
150212019-01-25 Tom Tromey <tom@tromey.com>
15022
15023 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15024
0747795c
TT
150252019-01-25 Tom Tromey <tom@tromey.com>
15026
15027 * xtensa-linux-nat.c: Fix common/ includes.
15028 * xml-support.h: Fix common/ includes.
15029 * xml-support.c: Fix common/ includes.
15030 * x86-linux-nat.c: Fix common/ includes.
15031 * windows-nat.c: Fix common/ includes.
15032 * varobj.h: Fix common/ includes.
15033 * varobj.c: Fix common/ includes.
15034 * value.c: Fix common/ includes.
15035 * valops.c: Fix common/ includes.
15036 * utils.c: Fix common/ includes.
15037 * unittests/xml-utils-selftests.c: Fix common/ includes.
15038 * unittests/utils-selftests.c: Fix common/ includes.
15039 * unittests/unpack-selftests.c: Fix common/ includes.
15040 * unittests/tracepoint-selftests.c: Fix common/ includes.
15041 * unittests/style-selftests.c: Fix common/ includes.
15042 * unittests/string_view-selftests.c: Fix common/ includes.
15043 * unittests/scoped_restore-selftests.c: Fix common/ includes.
15044 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15045 * unittests/scoped_fd-selftests.c: Fix common/ includes.
15046 * unittests/rsp-low-selftests.c: Fix common/ includes.
15047 * unittests/parse-connection-spec-selftests.c: Fix common/
15048 includes.
15049 * unittests/optional-selftests.c: Fix common/ includes.
15050 * unittests/offset-type-selftests.c: Fix common/ includes.
15051 * unittests/observable-selftests.c: Fix common/ includes.
15052 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15053 * unittests/memrange-selftests.c: Fix common/ includes.
15054 * unittests/memory-map-selftests.c: Fix common/ includes.
15055 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15056 * unittests/function-view-selftests.c: Fix common/ includes.
15057 * unittests/environ-selftests.c: Fix common/ includes.
15058 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15059 * unittests/common-utils-selftests.c: Fix common/ includes.
15060 * unittests/cli-utils-selftests.c: Fix common/ includes.
15061 * unittests/array-view-selftests.c: Fix common/ includes.
15062 * ui-file.c: Fix common/ includes.
15063 * tui/tui-io.c: Fix common/ includes.
15064 * tracepoint.h: Fix common/ includes.
15065 * tracepoint.c: Fix common/ includes.
15066 * tracefile-tfile.c: Fix common/ includes.
15067 * top.h: Fix common/ includes.
15068 * top.c: Fix common/ includes.
15069 * thread.c: Fix common/ includes.
15070 * target/waitstatus.h: Fix common/ includes.
15071 * target/waitstatus.c: Fix common/ includes.
15072 * target.h: Fix common/ includes.
15073 * target.c: Fix common/ includes.
15074 * target-memory.c: Fix common/ includes.
15075 * target-descriptions.c: Fix common/ includes.
15076 * symtab.h: Fix common/ includes.
15077 * symfile.c: Fix common/ includes.
15078 * stap-probe.c: Fix common/ includes.
15079 * spu-linux-nat.c: Fix common/ includes.
15080 * sparc-nat.c: Fix common/ includes.
15081 * source.c: Fix common/ includes.
15082 * solib.c: Fix common/ includes.
15083 * solib-target.c: Fix common/ includes.
15084 * ser-unix.c: Fix common/ includes.
15085 * ser-tcp.c: Fix common/ includes.
15086 * ser-pipe.c: Fix common/ includes.
15087 * ser-base.c: Fix common/ includes.
15088 * selftest-arch.c: Fix common/ includes.
15089 * s12z-tdep.c: Fix common/ includes.
15090 * rust-exp.y: Fix common/ includes.
15091 * rs6000-aix-tdep.c: Fix common/ includes.
15092 * riscv-tdep.c: Fix common/ includes.
15093 * remote.c: Fix common/ includes.
15094 * remote-notif.h: Fix common/ includes.
15095 * remote-fileio.h: Fix common/ includes.
15096 * remote-fileio.c: Fix common/ includes.
15097 * regcache.h: Fix common/ includes.
15098 * regcache.c: Fix common/ includes.
15099 * record-btrace.c: Fix common/ includes.
15100 * python/python.c: Fix common/ includes.
15101 * python/py-type.c: Fix common/ includes.
15102 * python/py-inferior.c: Fix common/ includes.
15103 * progspace.h: Fix common/ includes.
15104 * producer.c: Fix common/ includes.
15105 * procfs.c: Fix common/ includes.
15106 * proc-api.c: Fix common/ includes.
15107 * printcmd.c: Fix common/ includes.
15108 * ppc-linux-nat.c: Fix common/ includes.
15109 * parser-defs.h: Fix common/ includes.
15110 * osdata.c: Fix common/ includes.
15111 * obsd-nat.c: Fix common/ includes.
15112 * nat/x86-linux.c: Fix common/ includes.
15113 * nat/x86-linux-dregs.c: Fix common/ includes.
15114 * nat/x86-dregs.h: Fix common/ includes.
15115 * nat/x86-dregs.c: Fix common/ includes.
15116 * nat/ppc-linux.c: Fix common/ includes.
15117 * nat/mips-linux-watch.h: Fix common/ includes.
15118 * nat/mips-linux-watch.c: Fix common/ includes.
15119 * nat/linux-waitpid.c: Fix common/ includes.
15120 * nat/linux-ptrace.h: Fix common/ includes.
15121 * nat/linux-ptrace.c: Fix common/ includes.
15122 * nat/linux-procfs.c: Fix common/ includes.
15123 * nat/linux-personality.c: Fix common/ includes.
15124 * nat/linux-osdata.c: Fix common/ includes.
15125 * nat/linux-namespaces.c: Fix common/ includes.
15126 * nat/linux-btrace.h: Fix common/ includes.
15127 * nat/linux-btrace.c: Fix common/ includes.
15128 * nat/fork-inferior.c: Fix common/ includes.
15129 * nat/amd64-linux-siginfo.c: Fix common/ includes.
15130 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15131 * nat/aarch64-linux.c: Fix common/ includes.
15132 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15133 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15134 * namespace.h: Fix common/ includes.
15135 * mips-linux-tdep.c: Fix common/ includes.
15136 * minsyms.c: Fix common/ includes.
15137 * mi/mi-parse.h: Fix common/ includes.
15138 * mi/mi-main.c: Fix common/ includes.
15139 * mi/mi-cmd-env.c: Fix common/ includes.
15140 * memrange.h: Fix common/ includes.
15141 * memattr.c: Fix common/ includes.
15142 * maint.h: Fix common/ includes.
15143 * maint.c: Fix common/ includes.
15144 * main.c: Fix common/ includes.
15145 * machoread.c: Fix common/ includes.
15146 * location.c: Fix common/ includes.
15147 * linux-thread-db.c: Fix common/ includes.
15148 * linux-nat.c: Fix common/ includes.
15149 * linux-fork.c: Fix common/ includes.
15150 * inline-frame.c: Fix common/ includes.
15151 * infrun.c: Fix common/ includes.
15152 * inflow.c: Fix common/ includes.
15153 * inferior.h: Fix common/ includes.
15154 * inferior.c: Fix common/ includes.
15155 * infcmd.c: Fix common/ includes.
15156 * inf-ptrace.c: Fix common/ includes.
15157 * inf-child.c: Fix common/ includes.
15158 * ia64-linux-nat.c: Fix common/ includes.
15159 * i387-tdep.c: Fix common/ includes.
15160 * i386-tdep.c: Fix common/ includes.
15161 * i386-linux-tdep.c: Fix common/ includes.
15162 * i386-linux-nat.c: Fix common/ includes.
15163 * i386-go32-tdep.c: Fix common/ includes.
15164 * i386-fbsd-tdep.c: Fix common/ includes.
15165 * i386-fbsd-nat.c: Fix common/ includes.
15166 * guile/scm-type.c: Fix common/ includes.
15167 * guile/guile.c: Fix common/ includes.
15168 * go32-nat.c: Fix common/ includes.
15169 * gnu-nat.c: Fix common/ includes.
15170 * gdbthread.h: Fix common/ includes.
15171 * gdbarch-selftests.c: Fix common/ includes.
15172 * gdb_usleep.c: Fix common/ includes.
15173 * gdb_select.h: Fix common/ includes.
15174 * gdb_bfd.c: Fix common/ includes.
15175 * gcore.c: Fix common/ includes.
15176 * fork-child.c: Fix common/ includes.
15177 * findvar.c: Fix common/ includes.
15178 * fbsd-nat.c: Fix common/ includes.
15179 * event-top.c: Fix common/ includes.
15180 * event-loop.c: Fix common/ includes.
15181 * dwarf2read.c: Fix common/ includes.
15182 * dwarf2loc.c: Fix common/ includes.
15183 * dwarf2-frame.c: Fix common/ includes.
15184 * dwarf-index-cache.c: Fix common/ includes.
15185 * dtrace-probe.c: Fix common/ includes.
15186 * disasm-selftests.c: Fix common/ includes.
15187 * defs.h: Fix common/ includes.
15188 * csky-tdep.c: Fix common/ includes.
15189 * cp-valprint.c: Fix common/ includes.
15190 * cp-support.h: Fix common/ includes.
15191 * cp-support.c: Fix common/ includes.
15192 * corelow.c: Fix common/ includes.
15193 * completer.h: Fix common/ includes.
15194 * completer.c: Fix common/ includes.
15195 * compile/compile.c: Fix common/ includes.
15196 * compile/compile-loc2c.c: Fix common/ includes.
15197 * compile/compile-cplus-types.c: Fix common/ includes.
15198 * compile/compile-cplus-symbols.c: Fix common/ includes.
15199 * command.h: Fix common/ includes.
15200 * cli/cli-dump.c: Fix common/ includes.
15201 * cli/cli-cmds.c: Fix common/ includes.
15202 * charset.c: Fix common/ includes.
15203 * build-id.c: Fix common/ includes.
15204 * btrace.h: Fix common/ includes.
15205 * btrace.c: Fix common/ includes.
15206 * breakpoint.h: Fix common/ includes.
15207 * breakpoint.c: Fix common/ includes.
15208 * ax.h:
15209 (enum agent_op): Fix common/ includes.
15210 * ax-general.c (struct aop_map): Fix common/ includes.
15211 * ax-gdb.c: Fix common/ includes.
15212 * auxv.c: Fix common/ includes.
15213 * auto-load.c: Fix common/ includes.
15214 * arm-tdep.c: Fix common/ includes.
15215 * arch/riscv.c: Fix common/ includes.
15216 * arch/ppc-linux-common.c: Fix common/ includes.
15217 * arch/i386.c: Fix common/ includes.
15218 * arch/arm.c: Fix common/ includes.
15219 * arch/arm-linux.c: Fix common/ includes.
15220 * arch/arm-get-next-pcs.c: Fix common/ includes.
15221 * arch/amd64.c: Fix common/ includes.
15222 * arch/aarch64.c: Fix common/ includes.
15223 * arch/aarch64-insn.c: Fix common/ includes.
15224 * arch-utils.c: Fix common/ includes.
15225 * amd64-windows-tdep.c: Fix common/ includes.
15226 * amd64-tdep.c: Fix common/ includes.
15227 * amd64-sol2-tdep.c: Fix common/ includes.
15228 * amd64-obsd-tdep.c: Fix common/ includes.
15229 * amd64-nbsd-tdep.c: Fix common/ includes.
15230 * amd64-linux-tdep.c: Fix common/ includes.
15231 * amd64-linux-nat.c: Fix common/ includes.
15232 * amd64-fbsd-tdep.c: Fix common/ includes.
15233 * amd64-fbsd-nat.c: Fix common/ includes.
15234 * amd64-dicos-tdep.c: Fix common/ includes.
15235 * amd64-darwin-tdep.c: Fix common/ includes.
15236 * agent.c: Fix common/ includes.
15237 * ada-lang.h: Fix common/ includes.
15238 * ada-lang.c: Fix common/ includes.
15239 * aarch64-tdep.c: Fix common/ includes.
15240
2f5c153e
TT
152412019-01-25 Tom Tromey <tom@tromey.com>
15242
15243 * common/create-version.sh: Use common/version.h.
15244
adc6a863
PA
152452019-01-24 Pedro Alves <palves@redhat.com>
15246
15247 * infrun.c (signal_stop, signal_print, signal_program)
15248 (signal_catch, signal_pass): Now arrays instead of pointers.
15249 (update_signals_program_target, do_target_resume)
15250 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15251 * linux-nat.c (linux_nat_target::pass_signals)
15252 (linux_nat_target::create_inferior, linux_nat_target::attach):
15253 Adjust.
15254 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15255 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15256 * procfs.c (procfs_target::pass_signals): Adjust.
15257 * record-full.c (record_full_target::resume): Adjust.
15258 * remote.c (remote_target::pass_signals)
15259 (remote_target::program_signals): Adjust.
15260 * target-debug.h (target_debug_print_signals): Now takes a
15261 gdb::array_view as parameter. Adjust.
15262 * target.h (target_ops) <pass_signals, program_signals>: Replace
15263 pointer and length parameters with gdb::array_view.
15264 (target_pass_signals, target_program_signals): Likewise.
15265 * target-delegates.c: Regenerate.
15266
3046d67a
PA
152672019-01-24 Pedro Alves <palves@redhat.com>
15268
15269 * common/forward-scope-exit.h
15270 (forward_scope_exit::forward_scope_exit): Pass arguments to
15271 m_bind_function directly, instead of creating a std::bind and
15272 copying that.
15273
353229bf
AH
152742019-01-24 Alan Hayward <alan.hayward@arm.com>
15275
15276 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15277 for static members.
15278 (pass_in_v_vfp_candidate): Likewise.
15279
311dc83a
TT
152802019-01-23 Tom Tromey <tom@tromey.com>
15281 Pedro Alves <palves@redhat.com>
15282
15283 * regcache.c (class regcache_invalidator): Remove.
15284 (regcache::raw_write): Use make_scope_exit.
15285
296bd123
TT
152862019-01-23 Tom Tromey <tom@tromey.com>
15287
15288 * ui-out.h (class ui_out_emit_type): Update comment.
15289
979a0d13
TT
152902019-01-23 Tom Tromey <tom@tromey.com>
15291
15292 * infrun.c (fetch_inferior_event): Update comment.
15293
d238133d
TT
152942019-01-23 Tom Tromey <tom@tromey.com>
15295 Pedro Alves <palves@redhat.com>
15296
15297 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15298 parameter.
15299 (fetch_inferior_event): Use SCOPE_EXIT.
15300
15301
9885e6bb
TT
153022019-01-23 Tom Tromey <tom@tromey.com>
15303 Pedro Alves <palves@redhat.com>
15304
15305 * infrun.c (disable_thread_events): Delete.
15306 (stop_all_threads): Use SCOPE_EXIT.
15307
286526c1
TT
153082019-01-23 Tom Tromey <tom@tromey.com>
15309 Pedro Alves <palves@redhat.com>
15310
15311 * symfile.c: Include forward-scope-exit.h.
15312 (clear_symtab_users_cleanup): Replace forward declaration with
15313 a FORWARD_SCOPE_EXIT.
15314 (syms_from_objfile_1): Use the forward_scope_exit and
15315 gdb::optional instead of cleanup_function.
15316 (reread_symbols): Use the forward_scope_exit instead of
15317 cleanup_function.
15318 (clear_symtab_users_cleanup): Remove function.
15319
1db93f14
TT
153202019-01-23 Tom Tromey <tom@tromey.com>
15321 Pedro Alves <palves@redhat.com>
15322
15323 * linux-nat.c: Include scope-exit.h.
15324 (cleanup_target_stop): Remove.
15325 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15326 SCOPE_EXIT.
15327
2cc83d1e
TT
153282019-01-23 Tom Tromey <tom@tromey.com>
15329 Pedro Alves <palves@redhat.com>
15330
15331 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15332 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15333
694c6bf5
TT
153342019-01-23 Tom Tromey <tom@tromey.com>
15335 Andrew Burgess <andrew.burgess@embecosm.com>
15336 Pedro Alves <palves@redhat.com>
15337
15338 * infrun.c (fetch_inferior_event): Use scope_exit.
15339 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15340 * top.c (execute_command): Use scope_exit.
15341 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15342 * utils.c (do_bpstat_clear_actions_cleanup)
15343 (make_bpstat_clear_actions_cleanup): Remove.
15344
4c41382a
TT
153452019-01-23 Tom Tromey <tom@tromey.com>
15346 Pedro Alves <palves@redhat.com>
15347
15348 * infrun.c: Include "common/scope-exit.h"
15349 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15350 (wait_for_inferior): Use SCOPE_EXIT.
15351 (fetch_inferior_event): Use scope_exit.
15352
89f8fb50
TT
153532019-01-23 Tom Tromey <tom@tromey.com>
15354 Pedro Alves <palves@redhat.com>
15355
15356 * breakpoint.c (create_breakpoint): Remove cleanup.
15357
5419bdae
TT
153582019-01-23 Tom Tromey <tom@tromey.com>
15359 Andrew Burgess <andrew.burgess@embecosm.com>
15360 Pedro Alves <palves@redhat.com>
15361
e587ef42
PA
153622019-01-23 Pedro Alves <palves@redhat.com>
15363
15364 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15365
77f0e74c
PA
153662019-01-23 Pedro Alves <palves@redhat.com>
15367 Andrew Burgess <andrew.burgess@embecosm.com>
15368
15369 * gdbthread.h: Include "common/forward-scope-exit.h".
15370 (scoped_finish_thread_state): Redefine custom class in terms of
15371 forward_scope_exit.
15372
5b9b3e53
PA
153732019-01-23 Pedro Alves <palves@redhat.com>
15374 Andrew Burgess <andrew.burgess@embecosm.com>
15375
15376 * common/forward-scope-exit.h: New file.
15377
54b65c9b
PA
153782019-01-23 Pedro Alves <palves@redhat.com>
15379 Andrew Burgess <andrew.burgess@embecosm.com>
15380 Tom Tromey <tom@tromey.com>
15381
15382 * common/scope-exit.h: New file.
15383
cf08fb29
PA
153842019-01-23 Pedro Alves <palves@redhat.com>
15385
15386 * common/preprocessor.h (ESC): Rename to ...
15387 (ESC_PARENS): ... this.
15388 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15389 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15390
ae73e2e2
TT
153912019-01-23 Tom Tromey <tom@tromey.com>
15392
15393 * language.h (class scoped_switch_to_sym_language_if_auto):
15394 Initialize m_lang in both cases.
15395
6594e122
AH
153962019-01-23 Alan Hayward <alan.hayward@arm.com>
15397
15398 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15399 with XCNEW.
15400
a7c9855d
TT
154012019-01-22 Tom Tromey <tom@tromey.com>
15402
15403 * corelow.c: Do not include sys/file.h.
15404
93cc1d53
TT
154052019-01-22 Tom Tromey <tom@tromey.com>
15406
15407 * tui/tui-wingeneral.h: Include gdb_curses.h.
15408
38561778
TT
154092019-01-22 Tom Tromey <tom@tromey.com>
15410
15411 * source-cache.h (class source_cache) <get_source_lines,
15412 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15413
37b3ab5b
TT
154142019-01-22 Tom Tromey <tom@tromey.com>
15415
15416 * remote-fileio.h (struct remote_target): Declare.
15417
3fabc016
TT
154182019-01-22 Tom Tromey <tom@tromey.com>
15419
15420 * python/py-arch.c: Do not include py-ref.h.
15421 * python/py-bpevent.c: Do not include py-ref.h.
15422 * python/py-cmd.c: Do not include py-ref.h.
15423 * python/py-continueevent.c: Do not include py-ref.h.
15424 * python/py-event.h: Do not include py-ref.h.
15425 * python/py-evtregistry.c: Do not include py-ref.h.
15426 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15427 * python/py-frame.c: Do not include py-ref.h.
15428 * python/py-framefilter.c: Do not include py-ref.h.
15429 * python/py-function.c: Do not include py-ref.h.
15430 * python/py-infevents.c: Do not include py-ref.h.
15431 * python/py-linetable.c: Do not include py-ref.h.
15432 * python/py-objfile.c: Do not include py-ref.h.
15433 * python/py-param.c: Do not include py-ref.h.
15434 * python/py-prettyprint.c: Do not include py-ref.h.
15435 * python/py-progspace.c: Do not include py-ref.h.
15436 * python/py-symbol.c: Do not include py-ref.h.
15437 * python/py-symtab.c: Do not include py-ref.h.
15438 * python/py-type.c: Do not include py-ref.h.
15439 * python/py-unwind.c: Do not include py-ref.h.
15440 * python/py-utils.c: Do not include py-ref.h.
15441 * python/py-value.c: Do not include py-ref.h.
15442 * python/py-varobj.c: Do not include py-ref.h.
15443 * python/py-xmethods.c: Do not include py-ref.h.
15444 * python/python.c: Do not include py-ref.h.
15445 * varobj.c: Do not include py-ref.h.
15446
6b4d7774
TT
154472019-01-22 Tom Tromey <tom@tromey.com>
15448
15449 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15450 keyword for bcache.
15451
7af7e9b5
TT
154522019-01-22 Tom Tromey <tom@tromey.com>
15453
15454 * compile/compile-cplus-types.c: Remove a comment by #include.
15455
951d1049
TT
154562019-01-22 Tom Tromey <tom@tromey.com>
15457
15458 * compile/gcc-c-plugin.h: Include compile-internal.h.
15459
d65d5705
TT
154602019-01-22 Tom Tromey <tom@tromey.com>
15461
15462 * stabsread.c (EXTERN): Do not define.
15463 (symnum, next_symbol_text_func, processing_gcc_compilation)
15464 (within_function, global_sym_chain, global_stabs)
15465 (previous_stab_code, this_object_header_files)
15466 (n_this_object_header_files)
15467 (n_allocated_this_object_header_files): Define.
15468 * stabsread.h (EXTERN): Never define. Use "extern".
15469
b6fb1ee5
PW
154702019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15471
15472 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15473 history_value.
15474
be6d4f74
TT
154752019-01-21 Tom Tromey <tom@tromey.com>
15476
15477 * ui-out.c: Fix includes.
15478 * tui/tui-source.c: Fix includes.
15479 * target.c: Fix includes.
15480 * remote.c: Fix includes.
15481 * regcache.c: Fix includes.
15482 * python/py-block.c: Fix includes.
15483 * printcmd.c: Fix includes.
15484 * or1k-tdep.c: Fix includes.
15485 * mi/mi-main.c: Fix includes.
15486 * m32r-tdep.c: Fix includes.
15487 * csky-tdep.c: Fix includes.
15488 * compile/compile-cplus-types.c: Fix includes.
15489 * cli/cli-interp.c: Fix includes.
15490
73021deb
AH
154912019-01-21 Alan Hayward <alan.hayward@arm.com>
15492
15493 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15494 for padding.
15495
7932255d
TT
154962019-01-16 Tom Tromey <tom@tromey.com>
15497
15498 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15499 earlier.
15500 (struct objfile) <msymbols_range>: Move from top level.
15501 <msymbols>: New method.
15502 (class objfile_msymbols): Remove.
15503 * symtab.c (default_collect_symbol_completion_matches_break_on):
15504 Update.
15505 * symmisc.c (dump_msymbols): Update.
15506 * stabsread.c (scan_file_globals): Update.
15507 * objc-lang.c (info_selectors_command, info_classes_command)
15508 (find_methods): Update.
15509 * minsyms.c (find_solib_trampoline_target): Update.
15510 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15511 * coffread.c (coff_symfile_read): Update.
15512 * ada-lang.c (ada_lookup_simple_minsym)
15513 (ada_collect_symbol_completion_matches): Update.
15514
604b1bfb
TT
155152019-01-16 Tom Tromey <tom@tromey.com>
15516
15517 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15518 type. Remove no-argument constructor.
15519 <iterator::operator++>: Simplify.
15520 <begin>: Update.
15521 <end>: Use minimal_symbol_count.
15522
f252c6d5
TT
155232019-01-16 Tom Tromey <tom@tromey.com>
15524
15525 * objfiles.h (struct objfile) <psymtabs>: New method.
15526 (class objfile_psymtabs): Remove.
15527 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15528 typedef.
15529 <range>: New method.
15530 (require_partial_symbols): Change return type.
15531 * psymtab.c (require_partial_symbols)
15532 (psym_expand_symtabs_matching): Update.
15533 * mdebugread.c (parse_partial_symbols): Update.
15534 * dbxread.c (dbx_end_psymtab): Update.
15535
b669c953
TT
155362019-01-15 Tom Tromey <tom@tromey.com>
15537
15538 * symtab.c (lookup_objfile_from_block)
15539 (lookup_symbol_in_objfile_symtabs)
15540 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15541 (find_line_symtab, info_sources_command)
15542 (default_collect_symbol_completion_matches_break_on)
15543 (make_source_files_completion_list): Update.
15544 * symmisc.c (print_objfile_statistics, dump_objfile)
15545 (maintenance_print_symbols, maintenance_info_symtabs)
15546 (maintenance_check_symtabs, maintenance_info_line_tables):
15547 Update.
15548 * source.c (select_source_symtab)
15549 (forget_cached_source_info_for_objfile): Update.
15550 * objfiles.h (class objfile_compunits): Remove.
15551 (struct objfile) <compunits_range>: New typedef.
15552 (compunits): New method.
15553 * objfiles.c (objfile_relocate1): Update.
15554 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15555 * maint.c (count_symtabs_and_blocks): Update.
15556 * linespec.c (iterate_over_all_matching_symtabs): Update.
15557 * cp-support.c (add_symbol_overload_list_qualified): Update.
15558 * coffread.c (coff_symtab_read): Update.
15559 * ada-lang.c (add_nonlocal_symbols)
15560 (ada_collect_symbol_completion_matches)
15561 (ada_add_global_exceptions): Update.
15562
7e955d83
TT
155632019-01-15 Tom Tromey <tom@tromey.com>
15564
15565 * progspace.h (program_space) <objfiles_safe_range>: New
15566 typedef.
15567 <objfiles_safe>: New method.
15568 * objfiles.h (class all_objfiles_safe): Remove.
15569 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15570 * jit.c (jit_inferior_exit_hook): Update.
15571
2030c079
TT
155722019-01-17 Tom Tromey <tom@tromey.com>
15573
15574 * progspace.h (program_space) <objfiles_range>: New typedef.
15575 <objfiles>: New method.
15576 <objfiles_head>: Rename from objfiles.
15577 (object_files): Update.
15578 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15579 * guile/scm-pretty-print.c
15580 (ppscm_find_pretty_printer_from_objfiles): Update.
15581 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15582 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15583 Update.
15584 * python/py-progspace.c (pspy_get_objfiles): Update.
15585 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15586 Update.
15587 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15588 (objfpy_lookup_objfile_by_build_id): Update.
15589 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15590 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15591 Update.
15592 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15593 (expand_symtab_containing_pc, lookup_objfile_from_block)
15594 (lookup_static_symbol, basic_lookup_transparent_type)
15595 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15596 (find_line_symtab, info_sources_command)
15597 (default_collect_symbol_completion_matches_break_on)
15598 (make_source_files_completion_list, find_main_name): Update.
15599 * symmisc.c (print_symbol_bcache_statistics)
15600 (print_objfile_statistics, maintenance_print_symbols)
15601 (maintenance_print_msymbols, maintenance_print_objfiles)
15602 (maintenance_info_symtabs, maintenance_check_symtabs)
15603 (maintenance_expand_symtabs, maintenance_info_line_tables):
15604 Update.
15605 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15606 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15607 (map_overlay_command, unmap_overlay_command)
15608 (simple_overlay_update, expand_symtabs_matching)
15609 (map_symbol_filenames): Update.
15610 * symfile-debug.c (set_debug_symfile): Update.
15611 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15612 Update.
15613 * source.c (select_source_symtab, forget_cached_source_info):
15614 Update.
15615 * solib.c (solib_read_symbols): Update.
15616 * solib-spu.c (append_ocl_sos): Update.
15617 * psymtab.c (maintenance_print_psymbols)
15618 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15619 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15620 * printcmd.c (info_symbol_command): Update.
15621 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15622 Update.
15623 * objfiles.h (class all_objfiles): Remove.
15624 * objfiles.c (have_partial_symbols, have_full_symbols)
15625 (have_minimal_symbols, qsort_cmp, update_section_map)
15626 (shared_objfile_contains_address_p)
15627 (default_iterate_over_objfiles_in_search_order): Update.
15628 * objc-lang.c (info_selectors_command, info_classes_command)
15629 (find_methods): Update.
15630 * minsyms.c (find_solib_trampoline_target): Update.
15631 * maint.c (maintenance_info_sections)
15632 (maintenance_translate_address, count_symtabs_and_blocks):
15633 Update.
15634 * main.c (captured_main_1): Update.
15635 * linux-thread-db.c (try_thread_db_load_from_pdir)
15636 (has_libpthread): Update.
15637 * linespec.c (iterate_over_all_matching_symtabs)
15638 (search_minsyms_for_name): Update.
15639 * jit.c (jit_find_objf_with_entry_addr): Update.
15640 * hppa-tdep.c (find_unwind_entry)
15641 (hppa_lookup_stub_minimal_symbol): Update.
15642 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15643 Update.
15644 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15645 (elf_gnu_ifunc_resolve_by_got): Update.
15646 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15647 * dwarf-index-write.c (save_gdb_index_command): Update.
15648 * cp-support.c (add_symbol_overload_list_qualified): Update.
15649 * breakpoint.c (create_overlay_event_breakpoint)
15650 (create_longjmp_master_breakpoint)
15651 (create_std_terminate_master_breakpoint)
15652 (create_exception_master_breakpoint): Update.
15653 * blockframe.c (find_pc_partial_function): Update.
15654 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15655 (ada_collect_symbol_completion_matches)
15656 (ada_add_global_exceptions): Update.
15657
776489e0
TT
156582019-01-17 Tom Tromey <tom@tromey.com>
15659
15660 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15661 declare VEC.
15662 (solib_target_parse_libraries): Change return type.
15663 (library_list_start_segment, library_list_start_section)
15664 (library_list_end_library, library_list_start_library); Update.
15665 (solib_target_free_library_list): Remove.
15666 (solib_target_parse_libraries): Remove cleanup. Change return
15667 type.
15668 (solib_target_current_sos): Update.
15669
6471e7d2
TT
156702019-01-17 Tom Tromey <tromey@bapiya>
15671
15672 * valprint.c: Replace "the the" with "the".
15673 * symtab.c: Replace "the the" with "the".
15674 * solib.c: Replace "the the" with "the".
15675 * solib-dsbt.c: Replace "the the" with "the".
15676 * linespec.c: Replace "the the" with "the".
15677 * dwarf2loc.h: Replace "the the" with "the".
15678 * amd64-windows-tdep.c: Replace "the the" with "the".
15679 * aarch64-tdep.c: Replace "the the" with "the".
15680
c24bdb02
KS
156812019-01-16 Keith Seitz <keiths@redhat.com>
15682
15683 PR gdb/23773
15684 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15685 <builder>: Rename to ..
15686 <m_builder>: ... this and make private.
15687 (dwarf2_cu::get_builder): New method. Change all users of
15688 `builder' to use this method.
15689 (dwarf2_start_symtab): Move to ...
15690 (dwarf2_cu::start_symtab): ... here. Update all callers
15691 (setup_type_unit_groups): Move to ...
15692 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
15693 callers.
15694 (dwarf2_cu::reset_builder): New method.
15695 (process_full_compunit, process_full_type_unit): Use
15696 dwarf2_cu::reset_builder.
15697 (follow_die_offset): Record the ancestor CU if it is different
15698 from the followed DIE's CU.
15699 (follow_die_sig_1): Likewise.
15700
8d64371b
TT
157012019-01-15 Tom Tromey <tom@tromey.com>
15702
15703 * remote.c (class remote_state) <buf>: Now a char_vector.
15704 <buf_size>: Remove.
15705 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
15706 parameter.
15707 (remote_target::getpkt_or_notif_sane_1)
15708 (remote_target::getpkt_sane)
15709 (remote_target::getpkt_or_notif_sane): Likewise.
15710 (class remote_target) <putpkt>: New overload.
15711 (remote_target::read_frame): Change type of "buf_p". Remove
15712 sizeof_p parameter.
15713 (packet_ok): New overload.
15714 (packet_check_result): New overload.
15715 Update all uses.
15716
bb277751
TT
157172019-01-14 Tom Tromey <tom@tromey.com>
15718
15719 * remote-notif.c (handle_notification, remote_notif_ack)
15720 (remote_notif_parse): Make "buf" const.
15721 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15722 const.
15723 (remote_notif_parse, remote_notif_ack, handle_notification):
15724 Likewise.
15725 * remote.c (remote_notif_stop_parse): Make "buf" const.
15726 (remote_target::remote_parse_stop_reply): Make "buf" const.
15727 (remote_notif_stop_ack): Make "buf" const.
15728
05be00a8
TT
157292019-01-14 Tom Tromey <tom@tromey.com>
15730
15731 * remote.c (remote_console_output): Make parameter const.
15732
491adeca
TT
157332019-01-14 Tom Tromey <tom@tromey.com>
15734
15735 * target-debug.h (target_debug_print_signals): Constify.
15736 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15737 * procfs.c (procfs_target::pass_signals): Update.
15738 * linux-nat.c (linux_nat_target::pass_signals): Update.
15739 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15740 * target-delegates.c: Rebuild.
15741 * remote.c (remote_target::program_signals): Update.
15742 (remote_target::pass_signals): Update.
15743 * target.c (target_pass_signals): Constify argument.
15744 (target_program_signals): Likewise.
15745 * target.h (struct target_ops) <pass_signals, program_signals>:
15746 Constify argument.
15747 (target_pass_signals, target_program_signals): Constify argument.
15748
bbd94648
TT
157492019-01-14 Tom Tromey <tom@tromey.com>
15750
15751 PR tui/28819:
15752 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15753
6f072a10
PFC
157542019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
15755
15756 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15757 field.
15758 * rs6000-tdep.c: Include reggroups.h.
15759 (IS_V_ALIAS_PSEUDOREG): Define.
15760 (rs6000_register_name): Return names for the "vX" aliases.
15761 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15762 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
15763 aliases. Call default_register_reggroup_p for all other
15764 pseudo-registers.
15765 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15766 New functions.
15767 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15768 Handle "vX" aliases.
15769 (v_alias_pseudo_register_collect): New function.
15770 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15771 (rs6000_gdbarch_init): Initialize "vX" aliases as
15772 pseudo-registers. Restore registration of
15773 rs6000_pseudo_register_reggroup_p with
15774 set_tdesc_pseudo_register_reggroup_p.
15775
1a782351
MF
157762019-01-13 Max Filippov <jcmvbkbc@gmail.com>
15777
15778 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15779 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15780 set_gdbarch_num_pseudo_regs.
15781
d73cff18
PW
157822019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15783
15784 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15785 Remove arg prefixname, add do_set and do_show.
15786 Add member functions set_list and show_list.
15787 * cli/cli-style.c (class cli_style_option): Update accordingly.
15788 (style_set_list): Move to file scope.
15789 (style_show_list): Likewise.
15790 (set_style): Call help_list.
15791 (show_style): Call cmd_show_list.
15792 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15793 Update to use the new macro.
15794
60a90376
JB
157952019-10-12 Joel Brobecker <brobecker@adacore.com>
15796
15797 * ada-lang.c (_initialize_ada_language): Expand the help text
15798 for the "catch exception" command.
15799
9d7c67bf
PW
158002019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15801
15802 * symtab.c (matching_obj_sections): Initialize obj,
15803 declare it closer to its usage.
15804
7cf47dc4
TT
158052019-01-10 Tom Tromey <tom@tromey.com>
15806
15807 * thread-iter.h (inf_threads_iterator): Use next_iterator.
15808 (basic_inf_threads_range): Remove.
15809 (inf_threads_range, inf_non_exited_threads_range)
15810 (safe_inf_threads_range): Use next_adapter.
15811
d3cb6808
KS
158122019-01-10 Keith Seitz <keiths@redhat.com>
15813
15814 PR gdb/23712
15815 PR symtab/23010
15816 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15817 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15818
63a20375
KS
158192019-01-10 Keith Seitz <keiths@redhat.com>
15820
15821 PR gdb/23712
15822 PR symtab/23010
15823 * dictionary.c (pending_to_vector): Remove.
15824 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15825 Remove _1 suffix, replacing functions of the same name. Update
15826 all callers.
15827 (dict_create_hashed, dict_create_hashed_expandable)
15828 (dict_create_linear, dict_create_linear_expandable, dict_free)
15829 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15830 Make functions static.
15831
b026f593
KS
158322019-01-10 Keith Seitz <keiths@redhat.com>
15833
15834 PR gdb/23712
15835 PR symtab/23010
15836 * dictionary.h (struct dictionary): Replace declaration with
15837 multidictionary.
15838 (dict_create_hashed, dict_create_hashed_expandable)
15839 (dict_create_linear, dict_create_linear_expandable)
15840 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15841 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15842 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15843 taking multidictionary argument.
15844 [ALL_DICT_SYMBOLS]: Update for multidictionary.
15845 * block.h (struct block) <dict>: Change to multidictionary
15846 and rename `multidict'.
15847 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15848 symmisc.c: Update all dictionary references to multidictionary.
15849
c7748ee9
KS
158502019-01-10 Keith Seitz <keiths@redhat.com>
15851
15852 PR gdb/23712
15853 PR symtab/23010
15854 * dictionary.c: Include unordered_map.
15855 (pending_to_vector): New function.
15856 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15857 Rewrite the non-"_1" functions to take vector instead
15858 of linked list.
15859 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15860 "new" _1 versions of the same name.
15861 (multidictionary): Define.
15862 (std::hash<enum language): New definition.
15863 (collate_pending_symbols_by_language, mdict_create_hashed)
15864 (mdict_create_hashed_expandable, mdict_create_linear)
15865 (mdict_create_linear_expandable, mdict_free)
15866 (find_language_dictionary, create_new_language_dictionary)
15867 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15868 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15869 (mdict_size, mdict_empty): New functions.
15870 * dictionary.h (mdict_iterator): Define.
15871
67aa1f3c
PA
158722019-01-10 Pedro Alves <palves@redhat.com>
15873
15874 * breakpoint.c (read_uploaded_action)
15875 (create_tracepoint_from_upload): Adjust to use
15876 gdb::unique_xmalloc_ptr.
15877 * ctf.c (ctf_write_uploaded_tp):
15878 (SET_ARRAY_FIELD): Use emplace_back.
15879 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15880 * tracefile-tfile.c (tfile_write_uploaded_tp):
15881 * tracepoint.c (parse_tracepoint_definition): Adjust to use
15882 gdb::unique_xmalloc_ptr.
15883 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15884 at_string, cond_string, cmd_strings>: Replace char pointers
15885 with gdb::unique_xmalloc_ptr.
15886
2f667667
PA
158872019-01-10 Pedro Alves <palves@redhat.com>
15888
15889 * solib-target.c (library_list_start_library): Don't xstrdup name.
15890
36cb7237
PA
158912019-01-10 Pedro Alves <palves@redhat.com>
15892
15893 * mdebugread.c (parse_partial_symbols): Use
15894 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15895
da584958
AB
158962019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15897
15898 * linux-fork.c (scoped_switch_fork_info)
15899 <~scoped_switch_fork_info>: Fix incorrect variable name.
15900
1ef8573c
AB
159012019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15902
15903 * linux-fork.c (scoped_switch_fork_info)
15904 <scoped_switch_fork_info>: Make explicit.
15905 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15906
8d7bcccb
TT
159072019-01-10 Tom Tromey <tom@tromey.com>
15908
15909 * objfiles.h (objfile::reset_psymtabs): Update.
15910 * objfiles.c (objfile::objfile): Update.
15911 * psymtab.h (psymtab_storage::obstack): Update.
15912 (psymtab_storage::m_obstack): Use gdb::optional.
15913 (class psymtab_storage): Update comment. Remove objfile
15914 parameter.
15915 * psymtab.c (psymtab_storage::psymtab_storage): Update.
15916
b596a3c7
TT
159172019-01-10 Tom Tromey <tom@tromey.com>
15918
15919 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15920 <free_psymtabs>: Now private.
15921 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15922 (allocate_psymtab): Use new method.
15923
a9342b62
TT
159242019-01-10 Tom Tromey <tom@tromey.com>
15925
15926 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15927 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15928 * mdebugread.c (parse_partial_symbols): Use
15929 allocate_dependencies.
15930 * dwarf2read.c (dwarf2_create_include_psymtab): Use
15931 allocate_dependencies.
15932 (process_psymtab_comp_unit_reader)
15933 (build_type_psymtab_dependencies): Likewise.
15934 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15935
5af70966
TT
159362019-01-10 Tom Tromey <tom@tromey.com>
15937
15938 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15939 PSYMBOL_SET_LANGUAGE.
15940 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15941
5923a04c
TT
159422019-01-10 Tom Tromey <tom@tromey.com>
15943
15944 * psymtab.h (psymtab_storage::obstack): New method.
15945 <m_obstack>: Rename from obstack; now private.
15946 * psymtab.c (psymtab_storage): Update.
15947 * dwarf2read.c (create_addrmap_from_index)
15948 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15949 Update.
15950
6d6a12bf
TT
159512019-01-10 Tom Tromey <tom@tromey.com>
15952
15953 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15954 * objfiles.h (objfile::reset_psymtabs): New method.
15955
d320c2b5
TT
159562019-01-10 Tom Tromey <tom@tromey.com>
15957
15958 * symmisc.c (print_symbol_bcache_statistics): Update.
15959 (print_objfile_statistics): Update.
15960 * symfile.c (reread_symbols): Update.
15961 * psymtab.h (class psymtab_storage): New.
15962 * psymtab.c (psymtab_storage): New constructor.
15963 (~psymtab_storage): New destructor.
15964 (require_partial_symbols): Update.
15965 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15966 (find_pc_sect_psymtab, find_pc_sect_psymbol)
15967 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15968 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15969 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15970 (start_psymtab_common, end_psymtab_common)
15971 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15972 (allocate_psymtab): Update.
15973 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15974 Update.
15975 (dump_psymtab_addrmap, maintenance_print_psymbols)
15976 (maintenance_check_psymtabs): Update.
15977 (class objfile_psymtabs): Move to objfiles.h.
15978 * psympriv.h (discard_psymtab): Now inline.
15979 (psymtab_discarder::psymtab_discarder): Update.
15980 (psymtab_discarder::~psymtab_discarder): Update.
15981 (ALL_OBJFILE_PSYMTABS): Rewrite.
15982 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15983 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15984 Remove fields.
15985 <partial_symtabs>: New field.
15986 (class objfile_psymtabs): Move from psymtab.h. Update.
15987 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15988 psymbol_cache.
15989 (objfile::~objfile): Don't destroy psymbol_cache.
15990 * mdebugread.c (parse_partial_symbols): Update.
15991 * dwarf2read.c (create_addrmap_from_index)
15992 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15993 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15994 (add_partial_subprogram, dwarf2_ranges_read): Update.
15995 * dwarf-index-write.c (write_address_map)
15996 (write_one_signatured_type, recursively_write_psymbols)
15997 (class debug_names, class debug_names, write_psymtabs_to_index):
15998 Update.
15999
1d94a5a3
TT
160002019-01-10 Tom Tromey <tom@tromey.com>
16001
16002 * symtab.h (SYMBOL_SET_NAMES): Update.
16003 (symbol_set_names): Update.
16004 (MSYMBOL_SET_NAMES): Update.
16005 * symtab.c (symbol_set_names): Change argument to be an
16006 objfile_per_bfd_storage.
16007 * psymtab.c (add_psymbol_to_bcache): Update.
16008 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16009
0f14768a
TT
160102019-01-10 Tom Tromey <tom@tromey.com>
16011
16012 * symtab.c (create_demangled_names_hash): Change argument to be an
16013 objfile_per_bfd_storage.
16014 (symbol_set_names): Update.
16015
6eee24ce
TT
160162019-01-10 Tom Tromey <tom@tromey.com>
16017
16018 * xcoffread.c (xcoff_initial_scan): Unconditionally call
16019 init_psymbol_list.
16020 * psymtab.c (init_psymbol_list): Do nothing if already called.
16021 * psympriv.h (init_psymbol_list): Add comment.
16022 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16023 init_psymbol_list.
16024 * dbxread.c (dbx_symfile_read): Unconditionally call
16025 init_psymbol_list.
16026
75aedd27
TT
160272019-01-10 Tom Tromey <tom@tromey.com>
16028
16029 * xcoffread.c (scan_xcoff_symtab): Update.
16030 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16031 "where".
16032 * mdebugread.c (parse_partial_symbols)
16033 (handle_psymbol_enumerators): Update.
16034 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16035 * dbxread.c (read_dbx_symtab): Update.
16036 * psympriv.h (psymbol_placement): New enum.
16037 (add_psymbol_to_list): Update.
16038
939652a5
TT
160392019-01-10 Tom Tromey <tom@tromey.com>
16040
16041 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16042 static_psymbols parameters.
16043 (scan_xcoff_symtab): Update.
16044 * psymtab.c (start_psymtab_common): Remove global_psymbols and
16045 static_psymbols parameters.
16046 * psympriv.h (start_psymtab_common): Update.
16047 * mdebugread.c (parse_partial_symbols): Update.
16048 * dwarf2read.c (create_partial_symtab): Update.
16049 * dbxread.c (read_dbx_symtab): Update.
16050 (start_psymtab): Remove global_psymbols and static_psymbols
16051 parameters.
16052
baa62830
TT
160532019-01-10 Tom Tromey <tom@tromey.com>
16054
16055 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16056 * psymtab.c (allocate_psymtab): Add comment.
16057 * psympriv.h (allocate_psymtab): Add comment.
16058 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16059 initializations.
16060 * dbxread.c (dbx_end_psymtab): Remove some initializations.
16061
0e8f53ba
TT
160622019-01-10 Tom Tromey <tom@tromey.com>
16063
16064 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16065 Don't declare.
16066 * mipsread.c: Include mdebugread.h.
16067 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16068 Declare.
16069 * elfread.c: Include mdebugread.h.
16070
b22a7c6a
TT
160712019-01-09 Tom Tromey <tom@tromey.com>
16072
16073 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16074 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16075 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16076 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16077 (psym_lookup_symbol, psym_find_last_source_symtab)
16078 (psym_forget_cached_source_info, psym_print_stats)
16079 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16080 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16081 (psym_map_matching_symbols, psym_expand_symtabs_matching)
16082 (psym_find_compunit_symtab_by_address)
16083 (maintenance_print_psymbols, maintenance_info_psymtabs)
16084 (maintenance_check_psymtabs): Use ranged for.
16085 * psymtab.h (class objfile_psymtabs): New.
16086 (require_partial_symbols): Return objfile_psymtabs.
16087 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16088
3b9d3ac2
TT
160892019-01-09 Tom Tromey <tom@tromey.com>
16090
16091 * symfile.c (overlay_invalidate_all, find_pc_overlay)
16092 (find_pc_mapped_section, list_overlays_command)
16093 (map_overlay_command, unmap_overlay_command)
16094 (simple_overlay_update): Use all_objfiles.
16095 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16096 * printcmd.c (info_symbol_command): Use all_objfiles.
16097 * objfiles.h (ALL_OBJSECTIONS): Remove.
16098 * maint.c (maintenance_translate_address): Use all_objfiles.
16099 * gcore.c (gcore_create_callback): Use all_objfiles.
16100 (objfile_find_memory_regions): Likewise.
16101
8b31193a
TT
161022019-01-09 Tom Tromey <tom@tromey.com>
16103
16104 * symtab.c (find_line_symtab, info_sources_command)
16105 (make_source_files_completion_list): Use objfile_compunits.
16106 * source.c (select_source_symtab): Use objfile_compunits.
16107 * objfiles.h (struct objfile): Update comment.
16108 (ALL_OBJFILES): Remove.
16109 (ALL_FILETABS): Remove.
16110 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16111 objfile_compunits.
16112
d5da8b3c
TT
161132019-01-09 Tom Tromey <tom@tromey.com>
16114
16115 * symmisc.c (print_objfile_statistics, dump_objfile)
16116 (maintenance_print_symbols): Use compunit_filetabs.
16117 * source.c (forget_cached_source_info_for_objfile): Use
16118 compunit_filetabs.
16119 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16120 (ALL_FILETABS): Use compunit_filetabs.
16121 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16122 * coffread.c (coff_symtab_read): Use compunit_filetabs.
16123
5accd1a0
TT
161242019-01-09 Tom Tromey <tom@tromey.com>
16125
16126 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16127 (compunit_filetabs): New.
16128 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16129 compunit_filetabs.
16130 (info_sources_command, make_source_files_completion_list): Remove
16131 declaration.
16132 * symmisc.c (print_objfile_statistics, dump_objfile)
16133 (maintenance_print_symbols): Remove declaration.
16134 (maintenance_info_symtabs): Use compunit_filetabs.
16135 (maintenance_info_line_tables): Likewise.
16136 * source.c (select_source_symtab): Change local variable name.
16137 (forget_cached_source_info_for_objfile): Remove declaration.
16138 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16139 * objfiles.c (objfile_relocate1): Remove declaration.
16140 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16141 declaration.
16142 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16143 * coffread.c (coff_symtab_read): Remove declaration.
16144 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16145 compunit_filetabs.
16146
d8aeb77f
TT
161472019-01-09 Tom Tromey <tom@tromey.com>
16148
16149 * symtab.c (lookup_objfile_from_block)
16150 (find_pc_sect_compunit_symtab, search_symbols)
16151 (default_collect_symbol_completion_matches_break_on): Use
16152 objfile_compunits.
16153 * objfiles.h (ALL_COMPUNITS): Remove.
16154 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16155 * cp-support.c (add_symbol_overload_list_qualified): Use
16156 objfile_compunits.
16157 * ada-lang.c (ada_collect_symbol_completion_matches)
16158 (ada_add_global_exceptions): Use objfile_compunits.
16159
592553c4
TT
161602019-01-09 Tom Tromey <tom@tromey.com>
16161
16162 * source.c (select_source_symtab)
16163 (forget_cached_source_info_for_objfile): Remove declaration.
16164 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16165 declaration.
16166 * maint.c (count_symtabs_and_blocks): Remove declaration.
16167 * cp-support.c (add_symbol_overload_list_qualified): Remove
16168 declaration.
16169 * coffread.c (coff_symtab_read): Remove declaration.
16170 * symtab.c (lookup_symbol_in_objfile_symtabs)
16171 (basic_lookup_transparent_type_1): Use objfile_compunits.
16172 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16173 (info_sources_command, search_symbols)
16174 (default_collect_symbol_completion_matches_break_on)
16175 (make_source_files_completion_list): Remove declaration.
16176 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16177 (ada_collect_symbol_completion_matches)
16178 (ada_add_global_exceptions): Remove declaration.
16179 * linespec.c (iterate_over_all_matching_symtabs): Use
16180 objfile_compunits.
16181 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16182 (class objfile_compunits): New.
16183 (ALL_COMPUNITS): Use objfile_compunits.
16184 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16185 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16186 objfile_compunits.
16187 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16188
5325b9bf
TT
161892019-01-09 Tom Tromey <tom@tromey.com>
16190
16191 * symtab.c (search_symbols)
16192 (default_collect_symbol_completion_matches_break_on): Use
16193 objfile_msymbols.
16194 * ada-lang.c (ada_lookup_simple_minsym)
16195 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16196 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16197 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16198 objfile_msymbols.
16199 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16200 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16201 * objc-lang.c (find_methods): Use objfile_msymbols.
16202 (info_selectors_command, info_classes_command): Likewise.
16203 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16204 * objfiles.h (class objfile_msymbols): New.
16205 (ALL_OBJFILE_MSYMBOLS): Remove.
16206 (ALL_MSYMBOLS): Remove.
16207
cac85af2
TT
162082019-01-09 Tom Tromey <tom@tromey.com>
16209
16210 * common/next-iterator.h (next_adapter): Add Iterator template
16211 parameter.
16212 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16213 (class all_objfiles_safe): New.
16214 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16215 * objfiles.c (put_objfile_before): Update comment.
16216 (add_separate_debug_objfile): Likewise.
16217 (free_all_objfiles): Use all_objfiles_safe.
16218 (objfile_purge_solibs): Likewise.
16219
aed57c53
TT
162202019-01-09 Tom Tromey <tom@tromey.com>
16221
16222 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16223 (expand_symtab_containing_pc, lookup_static_symbol)
16224 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16225 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16226 all_objfiles.
16227 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16228 * breakpoint.c (create_overlay_event_breakpoint)
16229 (create_longjmp_master_breakpoint)
16230 (create_std_terminate_master_breakpoint)
16231 (create_exception_master_breakpoint): Use all_objfiles.
16232 * linux-thread-db.c (try_thread_db_load_from_pdir)
16233 (has_libpthread): Use all_objfiles.
16234 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16235 * linespec.c (iterate_over_all_matching_symtabs)
16236 (search_minsyms_for_name): Use all_objfiles.
16237 * maint.c (maintenance_info_sections): Use all_objfiles.
16238 * main.c (captured_main_1): Use all_objfiles.
16239 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16240 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16241 * guile/scm-pretty-print.c
16242 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16243 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16244 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16245 (maintenance_print_msymbols): Use all_objfiles.
16246 * source.c (select_source_symtab): Use all_objfiles.
16247 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16248 * symfile.c (remove_symbol_file_command)
16249 (expand_symtabs_matching, map_symbol_filenames): Use
16250 all_objfiles.
16251 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16252 all_objfiles.
16253 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16254 * objc-lang.c (find_methods): Use all_objfiles.
16255 * objfiles.c (have_partial_symbols, have_full_symbols)
16256 (have_minimal_symbols, qsort_cmp)
16257 (default_iterate_over_objfiles_in_search_order): Use
16258 all_objfiles.
16259 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16260 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16261 (maintenance_check_psymtabs): Use all_objfiles.
16262 (ALL_PSYMTABS): Remove.
16263 * compile/compile-object-run.c (do_module_cleanup): Use
16264 all_objfiles.
16265 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16266 * cp-support.c (add_symbol_overload_list_qualified): Use
16267 all_objfiles.
16268 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16269 Use all_objfiles.
16270 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16271 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16272 all_objfiles.
16273 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16274 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16275 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16276 Uses all_objfiles.
16277 * solib.c (solib_read_symbols): Use all_objfiles
16278
99d89cde
TT
162792019-01-09 Tom Tromey <tom@tromey.com>
16280
16281 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16282 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16283 all_objfiles.
16284 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16285 * symmisc.c (print_symbol_bcache_statistics)
16286 (print_objfile_statistics, maintenance_print_objfiles)
16287 (maintenance_info_symtabs, maintenance_check_symtabs)
16288 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16289 all_objfiles.
16290 * source.c (forget_cached_source_info): Use all_objfiles.
16291 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16292 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16293 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16294 * objfiles.c (update_section_map): Use all_objfiles.
16295 (shared_objfile_contains_address_p): Likewise.
16296 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16297 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16298
21708325
TT
162992019-01-09 Tom Tromey <tom@tromey.com>
16300
16301 * common/next-iterator.h: New file.
16302 * objfiles.h (class all_objfiles): New.
16303 (struct objfile_iterator): New.
16304
669e09f6
PW
163052019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16306
16307 * NEWS: Move the description of the changed "frame", "select-frame",
16308 and "info frame" commands to the Changed commands section.
16309
041be526
SM
163102019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16311
16312 * gdbtypes.c (check_stub_method_group): Remove handling of old
16313 mangling schemes.
16314 * linespec.c (find_methods): Likewise.
16315 * stabsread.c (read_member_functions): Likewise.
16316 * valops.c (search_struct_method): Likewise.
16317 (value_struct_elt_for_reference): Likewise.
16318 * NEWS: Mention this change.
16319
0e2a2133
AB
163202019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16321
16322 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16323 print_source_lines.
16324 * source.c (print_source_lines_base): Update line number check.
16325 (print_source_lines): New function.
16326 (source_lines_range::source_lines_range): New function.
16327 * source.h (class source_lines_range): New class.
16328 (print_source_lines): New declaration.
16329
1055a3b4
PW
163302019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16331
16332 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16333
cfeadda5
TT
163342019-01-08 Tom Tromey <tom@tromey.com>
16335 Simon Marchi <simon.marchi@ericsson.com>
16336
16337 PR gdb/24060
16338 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16339 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16340 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16341 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16342 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16343 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16344
583068ca
AB
163452019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16346
16347 * source.c (select_source_symtab): Move header comment to
16348 declaration in source.h.
16349 (forget_cached_source_info_for_objfile): Likewise.
16350 (forget_cached_source_info): Likewise.
16351 (identify_source_line): Likewise.
16352 * source.h (identify_source_line): Move declaration from symtab.h
16353 and add comment from source.c
16354 (print_source_lines): Likewise.
16355 (forget_cached_source_info_for_objfile): Likewise.
16356 (forget_cached_source_info): Likewise.
16357 (select_source_symtab): Likewise.
16358 (enum print_source_lines_flag): Move definition from symtab.h.
16359 * symtab.h (identify_source_line): Move declaration to source.h.
16360 (print_source_lines): Likewise.
16361 (forget_cached_source_info_for_objfile): Likewise.
16362 (forget_cached_source_info): Likewise.
16363 (select_source_symtab): Likewise.
16364 (enum print_source_lines_flag): Move definition to source.h.
16365 * tui/tui-hooks.c: Add 'source.h' include.
16366
ec98a4ad
AB
163672019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16368
16369 * source.c (print_source_lines_base): Handle requests to print
16370 reverse line number sequences, and guard against empty lines
16371 string.
16372
62ea19c1
AB
163732019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16374
16375 * source.c (print_source_lines_base): Fix skip of '\r' if next
16376 character is '\n'.
16377
9d30e1fd
TT
163782019-01-06 Tom Tromey <tom@tromey.com>
16379
16380 * c-exp.y (struct c_parse_state) <macro_original_text,
16381 expansion_obstack>: New member.
16382 (macro_original_text, expansion_obstack): Remove globals.
16383 (scan_macro_expansion, scanning_macro_expansion)
16384 (finished_macro_expansion): Update.
16385 (scan_macro_cleanup): Remove.
16386 (yylex, c_parse): Update.
16387
c65bac38
TT
163882019-01-06 Tom Tromey <tom@tromey.com>
16389
16390 * c-exp.y (struct c_parse_state) <strings>: New member.
16391 (operator_stoken): Update.
16392
02e12e38
TT
163932019-01-06 Tom Tromey <tom@tromey.com>
16394
16395 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16396 (union type_stack_elt) <typelist_val>: Now a pointer to
16397 std::vector.
16398 (type_stack_cleanup): Don't declare.
16399 (push_typelist): Update.
16400 * parse.c (pop_typelist): Return a std::vector.
16401 (push_typelist): Take a std::vector.
16402 (follow_types): Update. Do not free args.
16403 (type_stack_cleanup): Remove.
16404 * c-exp.y (struct c_parse_state): New.
16405 (cpstate): New global.
16406 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16407 (nonempty_typelist): Update.
16408 (func_mod): Create a new vector.
16409 (c_parse): Create a c_parse_state.
16410 (check_parameter_typelist): Do not delete params.
16411 (function_method): Update. Do not delete type_list.
16412
f097f5ad
TT
164132019-01-06 Tom Tromey <tom@tromey.com>
16414
16415 PR gdb/28155:
16416 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16417 check_typedef.
16418 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16419 (print_return_value): Likewise.
16420
d2adf9f1
TT
164212019-01-05 Tom Tromey <tom@tromey.com>
16422
16423 * contrib/cleanup_check.py: Remove.
16424 * contrib/gcc-with-excheck: Remove.
16425 * contrib/exsummary.py: Remove.
16426 * contrib/excheck.py: Remove.
16427
2eab46b1
JB
164282019-01-05 Joel Brobecker <brobecker@adacore.com>
16429
16430 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16431 NULL. Initialize tpprev to NULL instead of assigning it
16432 to NULL on the next statement.
16433 * windows-nat.c (windows_delete_thread): Remove check for
16434 main_thread_id before printing thread exit notifications.
16435 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16436 Remove thread ID check against main_thread_id.
16437 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16438 windows_delete_thread.
16439 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16440
48c5e7e2
TT
164412019-01-04 Tom Tromey <tom@tromey.com>
16442
16443 * compile/compile.c (_initialize_compile): Use upper case for
16444 metasyntactic variables.
16445 * symmisc.c (_initialize_symmisc): Use upper case for
16446 metasyntactic variables.
16447 * psymtab.c (_initialize_psymtab): Use upper case for
16448 metasyntactic variables.
16449 * demangle.c (demangle_command): Use upper case for metasyntactic
16450 variables.
16451 (_initialize_demangler): Likewise.
16452 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16453 variables.
16454
986041cd
TT
164552019-01-03 Tom Tromey <tom@tromey.com>
16456
16457 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16458
7c711119
TT
164592019-01-03 Tom Tromey <tom@tromey.com>
16460
16461 * python/py-symtab.c (salpy_str): Update.
16462 (struct salpy_sal_object) <symtab>: Now a PyObject.
16463 (salpy_dealloc): Update.
16464 (del_objfile_sal): Use gdbpy_ref.
16465
1b20edf0
TT
164662019-01-03 Tom Tromey <tom@tromey.com>
16467
16468 * python/py-type.c (convert_field): Use new_reference. Return
16469 gdbpy_ref.
16470 (make_fielditem): Return gdbpy_ref.
16471 (typy_fields): Update.
16472 (typy_getitem): Update.
16473 (field_name): Return gdbpy_ref. Use new_reference.
16474 (typy_iterator_iternext): Update.
16475
ea41325b
TT
164762019-01-03 Tom Tromey <tom@tromey.com>
16477
16478 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16479
2a3c71d6
TT
164802019-01-03 Tom Tromey <tom@tromey.com>
16481
16482 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16483 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16484 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16485 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16486 (pspy_set_type_printers): Likewise.
16487 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16488 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16489 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16490 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16491 (objfpy_set_type_printers): Likewise.
16492
5c329e6a
TT
164932019-01-03 Tom Tromey <tom@tromey.com>
16494
16495 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16496 (gdbpy_print_stack): Use gdbpy_err_fetch.
16497 * python/python-internal.h (class gdbpy_err_fetch): New class.
16498 (class gdbpy_enter) <m_error_type, m_error_value,
16499 m_error_traceback>: Remove.
16500 <m_error>: New member.
16501 (gdbpy_exception_to_string): Don't declare.
16502 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16503 * python/py-value.c (convert_value_from_python): Use
16504 gdbpy_err_fetch.
16505 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16506 gdbpy_exception_to_string.
16507 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16508 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16509 gdbpy_err_fetch.
16510
169bb27b
AB
165112019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16512
16513 * linux-nat.c (delete_lwp_cleanup): Delete.
16514 (struct lwp_deleter): New struct.
16515 (lwp_info_up): New typedef.
16516 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16517 lwp_info_up.
16518
a07c8880
AB
165192019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16520
16521 * linux-fork.c (class scoped_switch_fork_info): New class.
16522 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16523
26089c49
AB
165242019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16525
16526 * valops.c (find_overload_match): Remove use of null_cleanup, and
16527 calls to do_cleanups.
16528
06d3e5b0
AB
165292019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16530
16531 * compile/compile-cplus-types.c
16532 (compile_cplus_instance::decl_name): Handle changes to
16533 cp_func_name.
16534 * cp-support.c (cp_func_name): Update header comment, update
16535 return type.
16536 * cp-support.h (cp_func_name): Update return type in declaration.
16537 * valops.c (find_overload_match): Move temp_func local to top
16538 level of function and change its type. Use temp_func to hold and
16539 delete temporary string obtained from cp_func_name.
16540
66644cd3
AB
165412019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16542
16543 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16544 gdb::char_vector, remove cleanup, and update uses of `msg`.
16545
592d8c0a
JW
165462019-01-03 Jim Wilson <jimw@sifive.com>
16547
16548 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16549
c55d06ec
TT
165502019-01-02 Tom Tromey <tom@tromey.com>
16551
16552 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16553 (tdesc_parse_xml): Remove cleanups.
16554 * target-descriptions.h (make_cleanup_free_target_description):
16555 Don't declare.
16556 (target_desc_deleter): New struct.
16557 (target_desc_up): New typedef.
16558 * target-descriptions.c (target_desc_deleter::operator()): Rename
16559 from free_target_description.
16560 (make_cleanup_free_target_description): Remove.
16561
3a6ae42d
TT
165622019-01-02 Tom Tromey <tom@tromey.com>
16563
16564 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16565 constructor, destructor.
16566 (linespec_parser): Remove typedef.
16567 (~linespec_parser): Rename from linespec_parser_delete.
16568 (linespec_lex_to_end, linespec_complete_label)
16569 (linespec_complete): Update.
16570 (decode_line_full): Remove cleanups.
16571 (decode_line_1): Update.
16572
61fd3e73
TT
165732019-01-02 Tom Tromey <tom@tromey.com>
16574
16575 * python/python-internal.h (inferior_to_inferior_object): Change
16576 return type.
16577 * python/py-exitedevent.c (create_exited_event_object): Update.
16578 * python/py-inferior.c (inferior_to_inferior_object): Return
16579 gdbpy_ref.
16580 (python_new_inferior, python_inferior_deleted)
16581 (thread_to_thread_object, delete_thread_object)
16582 (build_inferior_list, gdbpy_selected_inferior): Update.
16583 * python/py-infthread.c (create_thread_object): Update. Also fail
16584 if inferior_to_inferior_object fails.
16585
d20172fc
SM
165862019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16587
16588 * inferior.h (class inferior) <displaced_step_state>: New field.
16589 * infrun.h (struct displaced_step_state): Move here from
16590 infrun.c. Initialize fields, add constructor.
16591 <inf>: Remove field.
16592 <reset>: New method.
16593 * infrun.c (struct displaced_step_inferior_state): Move to
16594 infrun.h.
16595 (displaced_step_inferior_states): Remove.
16596 (get_displaced_stepping_state): Adust.
16597 (displaced_step_in_progress_any_inferior): Adjust.
16598 (displaced_step_in_progress_thread): Adjust.
16599 (displaced_step_in_progress): Adjust.
16600 (add_displaced_stepping_state): Remove.
16601 (get_displaced_step_closure_by_addr): Adjust.
16602 (remove_displaced_stepping_state): Remove.
16603 (infrun_inferior_exit): Call displaced_step_state.reset.
16604 (use_displaced_stepping): Don't check for NULL.
16605 (displaced_step_prepare_throw): Call
16606 get_displaced_stepping_state.
16607 (displaced_step_fixup): Don't check for NULL.
16608 (prepare_for_detach): Don't check for NULL.
16609
e3319240
PW
166102019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16611
16612 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16613 in case of call that did not complete.
16614
5d36dfb9
AU
166152019-01-02 Andrey Utkin <autkin@undo.io>
16616
16617 * symfile.c (find_separate_debug_file): Fix search of debug files for
16618 remote debuggee.
16619
8833fbf0
TT
166202019-01-02 Tom Tromey <tom@tromey.com>
16621
16622 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16623 indentation.
16624 * python/py-frame.c (frapy_older): Remove cast.
16625 (frapy_newer): Likewise.
16626 * python/py-breakpoint.c (local_setattro): Remove cast.
16627 * python/py-arch.c (archpy_name): Remove local variable.
16628 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16629
4ada3dfd
JB
166302019-01-02 Joel Brobecker <brobecker@adacore.com>
16631
16632 * unittests/basic_string_view/element_access/char/empty.cc:
16633 Fix year range in copyright header.
16634
113b7b81
AB
166352019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16636
16637 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16638 Delete.
16639 <operator==>: Update with for removed field.
16640 <hash>: Likewise.
16641 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16642 <isa_features>: ...this.
16643 <abi_features>: New field.
16644 (riscv_isa_flen): Update comment.
16645 (riscv_abi_xlen): New declaration.
16646 (riscv_abi_flen): New declaration.
16647 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16648 isa_features.
16649 (riscv_abi_xlen): New function.
16650 (riscv_isa_flen): Update to get answer from isa_features.
16651 (riscv_abi_flen): New function.
16652 (riscv_has_fp_abi): Update to get answer from abi_features.
16653 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16654 xlen and flen.
16655 (riscv_call_info) <xlen, flen>: Update comment.
16656 (riscv_call_arg_struct): Remove invalid assertions
16657 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16658 is removed.
16659 (riscv_gdbarch_init): Gather isa features and abi features
16660 separately, ensure both match on the gdbarch when reusing an old
16661 gdbarch. Relax an error check to allow 32-bit abi float to run on
16662 a target with 64-bit float hardware.
16663
b18ca514
PW
166642019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16665
16666 * source.c (search_command_helper): Stop reverse search
16667 when line 1 has been searched.
16668
ec70d8db
PW
166692019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16670
16671 * record-full.c (record_full_base_target::close): Rewrite
16672 record_full_core_buf_list free logic.
16673
5b38f9c1
PW
166742019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16675
16676 * break-catch-syscall.c (print_one_catch_syscall): xfree
16677 the last text.
16678
66d91b39
JB
166792019-01-01 Joel Brobecker <brobecker@adacore.com>
16680
16681 * top.c (print_gdb_version): Update Copyright year in version
16682 message.
16683
42a4f53d
JB
166842019-01-01 Joel Brobecker <brobecker@adacore.com>
16685
16686 Update copyright year range in all GDB files.
16687
7e955d83 166882019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 16689
5bbd631d 16690 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 16691
5bbd631d 16692For older changes see ChangeLog-2018.
c906108c
SS
16693\f
16694Local Variables:
16695mode: change-log
16696left-margin: 8
16697fill-column: 74
16698version-control: never
57da7796 16699coding: utf-8
c906108c 16700End:
5bbd631d 16701
This page took 3.092977 seconds and 4 git commands to generate.