kernel.core: making some classes final

This patch is to make some classes final in kernel.core component.
It should be final to improve readability and since you should never
extend it. It also allows the jvm to inline methods and improve
performance.

Change-Id: Ie74fb3a6a36075cd355bdc58f4fe1deb3fc4a82a
Signed-off-by: Wassim <wassim.nasrallah.36@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74558
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

diff --git a/lttng/org.eclipse.tracecompass.lttng2.kernel.core/src/org/eclipse/tracecompass/internal/lttng2/kernel/core/analysis/vm/model/VirtualCPU.java b/lttng/org.eclipse.tracecompass.lttng2.kernel.core/src/org/eclipse/tracecompass/internal/lttng2/kernel/core/analysis/vm/model/VirtualCPU.java
index 7f7922c601cdf29bd5a046d00b64f0b9590a2ca0..4e1aaac3b0ed8b7ddf2b6ad3e1eade088942c79e 100644 (file)
--- a/lttng/org.eclipse.tracecompass.lttng2.kernel.core/src/org/eclipse/tracecompass/internal/lttng2/kernel/core/analysis/vm/model/VirtualCPU.java
+++ b/lttng/org.eclipse.tracecompass.lttng2.kernel.core/src/org/eclipse/tracecompass/internal/lttng2/kernel/core/analysis/vm/model/VirtualCPU.java
@@ -23,7 +23,7 @@ import com.google.common.collect.Table;
  *
  * @author Geneviève Bastien
  */
-public class VirtualCPU {
+public final class VirtualCPU {
 
     private static final Table<VirtualMachine, Long, @Nullable VirtualCPU> VIRTUAL_CPU_TABLE = HashBasedTable.create();
 

diff --git a/lttng/org.eclipse.tracecompass.lttng2.kernel.core/src/org/eclipse/tracecompass/internal/lttng2/kernel/core/analysis/vm/model/VirtualMachine.java b/lttng/org.eclipse.tracecompass.lttng2.kernel.core/src/org/eclipse/tracecompass/internal/lttng2/kernel/core/analysis/vm/model/VirtualMachine.java
index bf5d54e0ba64a55c1adb1fd68912dcfe795a7cbb..dbf315326210f16577557ea397d4526a84abd373 100644 (file)
--- a/lttng/org.eclipse.tracecompass.lttng2.kernel.core/src/org/eclipse/tracecompass/internal/lttng2/kernel/core/analysis/vm/model/VirtualMachine.java
+++ b/lttng/org.eclipse.tracecompass.lttng2.kernel.core/src/org/eclipse/tracecompass/internal/lttng2/kernel/core/analysis/vm/model/VirtualMachine.java
@@ -18,7 +18,7 @@ package org.eclipse.tracecompass.internal.lttng2.kernel.core.analysis.vm.model;
  *
  * @author Geneviève Bastien
  */
-public class VirtualMachine {
+public final class VirtualMachine {
 
     private static enum MachineType {
         HOST,

diff --git a/lttng/org.eclipse.tracecompass.lttng2.kernel.core/src/org/eclipse/tracecompass/internal/lttng2/kernel/core/trace/layout/PerfEventLayout.java b/lttng/org.eclipse.tracecompass.lttng2.kernel.core/src/org/eclipse/tracecompass/internal/lttng2/kernel/core/trace/layout/PerfEventLayout.java
index 6b83e5aea64ca79ab01b4621c9b4ae122d31a49e..d43f40b65a3272ffe677e6a17d1fe895f0faf2bc 100644 (file)
--- a/lttng/org.eclipse.tracecompass.lttng2.kernel.core/src/org/eclipse/tracecompass/internal/lttng2/kernel/core/trace/layout/PerfEventLayout.java
+++ b/lttng/org.eclipse.tracecompass.lttng2.kernel.core/src/org/eclipse/tracecompass/internal/lttng2/kernel/core/trace/layout/PerfEventLayout.java
@@ -24,7 +24,7 @@ import com.google.common.collect.ImmutableList;
  *
  * @author Alexandre Montplaisir
  */
-public class PerfEventLayout implements IKernelAnalysisEventLayout {
+public final class PerfEventLayout implements IKernelAnalysisEventLayout {
 
     private PerfEventLayout() {}